{"action":"closed","number":59,"pull_request":{"url":"https://api.github.com/repos/texastribune/queso-ui/pulls/59","id":312784906,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyNzg0OTA2","html_url":"https://github.com/texastribune/queso-ui/pull/59","diff_url":"https://github.com/texastribune/queso-ui/pull/59.diff","patch_url":"https://github.com/texastribune/queso-ui/pull/59.patch","issue_url":"https://api.github.com/repos/texastribune/queso-ui/issues/59","number":59,"state":"closed","locked":false,"title":"Add first attempt at grid helper and global updates ","user":{"login":"ashley-hebler","id":2974713,"node_id":"MDQ6VXNlcjI5NzQ3MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2974713?v=4","gravatar_id":"","url":"https://api.github.com/users/ashley-hebler","html_url":"https://github.com/ashley-hebler","followers_url":"https://api.github.com/users/ashley-hebler/followers","following_url":"https://api.github.com/users/ashley-hebler/following{/other_user}","gists_url":"https://api.github.com/users/ashley-hebler/gists{/gist_id}","starred_url":"https://api.github.com/users/ashley-hebler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashley-hebler/subscriptions","organizations_url":"https://api.github.com/users/ashley-hebler/orgs","repos_url":"https://api.github.com/users/ashley-hebler/repos","events_url":"https://api.github.com/users/ashley-hebler/events{/privacy}","received_events_url":"https://api.github.com/users/ashley-hebler/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\nAdds a grid helper more global line-heights.\r\n\r\n##### Classes added (if any)\r\n- l-col-grid\r\n- l-col-grid--1x3\r\n- l-col-grid--xxxs-gap\r\n- l-col-grid--resp\r\n\r\n#### Why are we doing this? How does it help us?\r\n\r\nl-col-grid - This is essentially the photo grid styles, but a little more generalized. We [talked about](https://github.com/texastribune/texastribune/pull/3629#issuecomment-526269751) how that one is implemented in the story page style swap PR. \r\n\r\nAll `figcaption` and `ul` tags' line-height will be our base line-height - Hopefully this adds consistency and saves us from keep having to set it with our `t-space-base` helper.\r\n\r\n#### How should this be manually tested?\r\n`yarn dev`\r\n\r\nSee: [`l-col-grid`](http://localhost:3000/pages/layout/index.html#column-grid-l-col-grid)\r\n\r\n\r\n#### Does this introduce a breaking change where queso-ui is used in the wild? If so, is there a relevant branch/PR to accompany this release?\r\n\r\nThe footer links on queso templates will get a little more spaced out with the line-height, but that feels too trivial to me to deem it \"_breaking_.\" I'd be more inclined to call this a minor release.\r\n\r\n\r\n#### TODOs / next steps:\r\n\r\n* [ ] *Add this to the /texastribune story page updates (I feel fine for this to wait until after initial deploy since there's so many moving parts in https://github.com/texastribune/texastribune/pull/3629)*\r\n","created_at":"2019-08-30T15:20:39Z","updated_at":"2019-09-03T18:24:20Z","closed_at":"2019-09-03T18:24:20Z","merged_at":"2019-09-03T18:24:19Z","merge_commit_sha":"d4fd62a928fd208eba987a12e30ad247f25d1e64","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/texastribune/queso-ui/pulls/59/commits","review_comments_url":"https://api.github.com/repos/texastribune/queso-ui/pulls/59/comments","review_comment_url":"https://api.github.com/repos/texastribune/queso-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/texastribune/queso-ui/issues/59/comments","statuses_url":"https://api.github.com/repos/texastribune/queso-ui/statuses/ae3ef903f927bddea1d28b5c3efd391d11d300a7","head":{"label":"texastribune:story-page-2","ref":"story-page-2","sha":"ae3ef903f927bddea1d28b5c3efd391d11d300a7","user":{"login":"texastribune","id":339134,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTEzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/339134?v=4","gravatar_id":"","url":"https://api.github.com/users/texastribune","html_url":"https://github.com/texastribune","followers_url":"https://api.github.com/users/texastribune/followers","following_url":"https://api.github.com/users/texastribune/following{/other_user}","gists_url":"https://api.github.com/users/texastribune/gists{/gist_id}","starred_url":"https://api.github.com/users/texastribune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/texastribune/subscriptions","organizations_url":"https://api.github.com/users/texastribune/orgs","repos_url":"https://api.github.com/users/texastribune/repos","events_url":"https://api.github.com/users/texastribune/events{/privacy}","received_events_url":"https://api.github.com/users/texastribune/received_events","type":"Organization","site_admin":false},"repo":{"id":168546916,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg1NDY5MTY=","name":"queso-ui","full_name":"texastribune/queso-ui","private":false,"owner":{"login":"texastribune","id":339134,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTEzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/339134?v=4","gravatar_id":"","url":"https://api.github.com/users/texastribune","html_url":"https://github.com/texastribune","followers_url":"https://api.github.com/users/texastribune/followers","following_url":"https://api.github.com/users/texastribune/following{/other_user}","gists_url":"https://api.github.com/users/texastribune/gists{/gist_id}","starred_url":"https://api.github.com/users/texastribune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/texastribune/subscriptions","organizations_url":"https://api.github.com/users/texastribune/orgs","repos_url":"https://api.github.com/users/texastribune/repos","events_url":"https://api.github.com/users/texastribune/events{/privacy}","received_events_url":"https://api.github.com/users/texastribune/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/texastribune/queso-ui","description":"Library of styles and icons","fork":false,"url":"https://api.github.com/repos/texastribune/queso-ui","forks_url":"https://api.github.com/repos/texastribune/queso-ui/forks","keys_url":"https://api.github.com/repos/texastribune/queso-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/texastribune/queso-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/texastribune/queso-ui/teams","hooks_url":"https://api.github.com/repos/texastribune/queso-ui/hooks","issue_events_url":"https://api.github.com/repos/texastribune/queso-ui/issues/events{/number}","events_url":"https://api.github.com/repos/texastribune/queso-ui/events","assignees_url":"https://api.github.com/repos/texastribune/queso-ui/assignees{/user}","branches_url":"https://api.github.com/repos/texastribune/queso-ui/branches{/branch}","tags_url":"https://api.github.com/repos/texastribune/queso-ui/tags","blobs_url":"https://api.github.com/repos/texastribune/queso-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/texastribune/queso-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/texastribune/queso-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/texastribune/queso-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/texastribune/queso-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/texastribune/queso-ui/languages","stargazers_url":"https://api.github.com/repos/texastribune/queso-ui/stargazers","contributors_url":"https://api.github.com/repos/texastribune/queso-ui/contributors","subscribers_url":"https://api.github.com/repos/texastribune/queso-ui/subscribers","subscription_url":"https://api.github.com/repos/texastribune/queso-ui/subscription","commits_url":"https://api.github.com/repos/texastribune/queso-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/texastribune/queso-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/texastribune/queso-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/texastribune/queso-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/texastribune/queso-ui/contents/{+path}","compare_url":"https://api.github.com/repos/texastribune/queso-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/texastribune/queso-ui/merges","archive_url":"https://api.github.com/repos/texastribune/queso-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/texastribune/queso-ui/downloads","issues_url":"https://api.github.com/repos/texastribune/queso-ui/issues{/number}","pulls_url":"https://api.github.com/repos/texastribune/queso-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/texastribune/queso-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/texastribune/queso-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/texastribune/queso-ui/labels{/name}","releases_url":"https://api.github.com/repos/texastribune/queso-ui/releases{/id}","deployments_url":"https://api.github.com/repos/texastribune/queso-ui/deployments","created_at":"2019-01-31T15:23:00Z","updated_at":"2019-08-30T13:49:59Z","pushed_at":"2019-09-03T18:24:19Z","git_url":"git://github.com/texastribune/queso-ui.git","ssh_url":"git@github.com:texastribune/queso-ui.git","clone_url":"https://github.com/texastribune/queso-ui.git","svn_url":"https://github.com/texastribune/queso-ui","homepage":"https://ttds.surge.sh/","size":766,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"texastribune:master","ref":"master","sha":"e8e4b5881b7bb95035b9012d88c818d7a72a9da2","user":{"login":"texastribune","id":339134,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTEzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/339134?v=4","gravatar_id":"","url":"https://api.github.com/users/texastribune","html_url":"https://github.com/texastribune","followers_url":"https://api.github.com/users/texastribune/followers","following_url":"https://api.github.com/users/texastribune/following{/other_user}","gists_url":"https://api.github.com/users/texastribune/gists{/gist_id}","starred_url":"https://api.github.com/users/texastribune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/texastribune/subscriptions","organizations_url":"https://api.github.com/users/texastribune/orgs","repos_url":"https://api.github.com/users/texastribune/repos","events_url":"https://api.github.com/users/texastribune/events{/privacy}","received_events_url":"https://api.github.com/users/texastribune/received_events","type":"Organization","site_admin":false},"repo":{"id":168546916,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg1NDY5MTY=","name":"queso-ui","full_name":"texastribune/queso-ui","private":false,"owner":{"login":"texastribune","id":339134,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTEzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/339134?v=4","gravatar_id":"","url":"https://api.github.com/users/texastribune","html_url":"https://github.com/texastribune","followers_url":"https://api.github.com/users/texastribune/followers","following_url":"https://api.github.com/users/texastribune/following{/other_user}","gists_url":"https://api.github.com/users/texastribune/gists{/gist_id}","starred_url":"https://api.github.com/users/texastribune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/texastribune/subscriptions","organizations_url":"https://api.github.com/users/texastribune/orgs","repos_url":"https://api.github.com/users/texastribune/repos","events_url":"https://api.github.com/users/texastribune/events{/privacy}","received_events_url":"https://api.github.com/users/texastribune/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/texastribune/queso-ui","description":"Library of styles and icons","fork":false,"url":"https://api.github.com/repos/texastribune/queso-ui","forks_url":"https://api.github.com/repos/texastribune/queso-ui/forks","keys_url":"https://api.github.com/repos/texastribune/queso-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/texastribune/queso-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/texastribune/queso-ui/teams","hooks_url":"https://api.github.com/repos/texastribune/queso-ui/hooks","issue_events_url":"https://api.github.com/repos/texastribune/queso-ui/issues/events{/number}","events_url":"https://api.github.com/repos/texastribune/queso-ui/events","assignees_url":"https://api.github.com/repos/texastribune/queso-ui/assignees{/user}","branches_url":"https://api.github.com/repos/texastribune/queso-ui/branches{/branch}","tags_url":"https://api.github.com/repos/texastribune/queso-ui/tags","blobs_url":"https://api.github.com/repos/texastribune/queso-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/texastribune/queso-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/texastribune/queso-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/texastribune/queso-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/texastribune/queso-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/texastribune/queso-ui/languages","stargazers_url":"https://api.github.com/repos/texastribune/queso-ui/stargazers","contributors_url":"https://api.github.com/repos/texastribune/queso-ui/contributors","subscribers_url":"https://api.github.com/repos/texastribune/queso-ui/subscribers","subscription_url":"https://api.github.com/repos/texastribune/queso-ui/subscription","commits_url":"https://api.github.com/repos/texastribune/queso-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/texastribune/queso-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/texastribune/queso-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/texastribune/queso-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/texastribune/queso-ui/contents/{+path}","compare_url":"https://api.github.com/repos/texastribune/queso-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/texastribune/queso-ui/merges","archive_url":"https://api.github.com/repos/texastribune/queso-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/texastribune/queso-ui/downloads","issues_url":"https://api.github.com/repos/texastribune/queso-ui/issues{/number}","pulls_url":"https://api.github.com/repos/texastribune/queso-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/texastribune/queso-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/texastribune/queso-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/texastribune/queso-ui/labels{/name}","releases_url":"https://api.github.com/repos/texastribune/queso-ui/releases{/id}","deployments_url":"https://api.github.com/repos/texastribune/queso-ui/deployments","created_at":"2019-01-31T15:23:00Z","updated_at":"2019-08-30T13:49:59Z","pushed_at":"2019-09-03T18:24:19Z","git_url":"git://github.com/texastribune/queso-ui.git","ssh_url":"git@github.com:texastribune/queso-ui.git","clone_url":"https://github.com/texastribune/queso-ui.git","svn_url":"https://github.com/texastribune/queso-ui","homepage":"https://ttds.surge.sh/","size":766,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/texastribune/queso-ui/pulls/59"},"html":{"href":"https://github.com/texastribune/queso-ui/pull/59"},"issue":{"href":"https://api.github.com/repos/texastribune/queso-ui/issues/59"},"comments":{"href":"https://api.github.com/repos/texastribune/queso-ui/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/texastribune/queso-ui/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/texastribune/queso-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/texastribune/queso-ui/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/texastribune/queso-ui/statuses/ae3ef903f927bddea1d28b5c3efd391d11d300a7"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ashley-hebler","id":2974713,"node_id":"MDQ6VXNlcjI5NzQ3MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2974713?v=4","gravatar_id":"","url":"https://api.github.com/users/ashley-hebler","html_url":"https://github.com/ashley-hebler","followers_url":"https://api.github.com/users/ashley-hebler/followers","following_url":"https://api.github.com/users/ashley-hebler/following{/other_user}","gists_url":"https://api.github.com/users/ashley-hebler/gists{/gist_id}","starred_url":"https://api.github.com/users/ashley-hebler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashley-hebler/subscriptions","organizations_url":"https://api.github.com/users/ashley-hebler/orgs","repos_url":"https://api.github.com/users/ashley-hebler/repos","events_url":"https://api.github.com/users/ashley-hebler/events{/privacy}","received_events_url":"https://api.github.com/users/ashley-hebler/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":50,"deletions":4,"changed_files":5}}
{"actor":{"display_login":"ashley-hebler"}}