{"action":"created","issue":{"url":"https://api.github.com/repos/lal12/proto-parse/issues/2","repository_url":"https://api.github.com/repos/lal12/proto-parse","labels_url":"https://api.github.com/repos/lal12/proto-parse/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/lal12/proto-parse/issues/2/comments","events_url":"https://api.github.com/repos/lal12/proto-parse/issues/2/events","html_url":"https://github.com/lal12/proto-parse/issues/2","id":398659765,"node_id":"MDU6SXNzdWUzOTg2NTk3NjU=","number":2,"title":"Can you add features? Can you add comments when parsing a file?","user":{"login":"Aaron009","id":3838050,"node_id":"MDQ6VXNlcjM4MzgwNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3838050?v=4","gravatar_id":"","url":"https://api.github.com/users/Aaron009","html_url":"https://github.com/Aaron009","followers_url":"https://api.github.com/users/Aaron009/followers","following_url":"https://api.github.com/users/Aaron009/following{/other_user}","gists_url":"https://api.github.com/users/Aaron009/gists{/gist_id}","starred_url":"https://api.github.com/users/Aaron009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aaron009/subscriptions","organizations_url":"https://api.github.com/users/Aaron009/orgs","repos_url":"https://api.github.com/users/Aaron009/repos","events_url":"https://api.github.com/users/Aaron009/events{/privacy}","received_events_url":"https://api.github.com/users/Aaron009/received_events","type":"User","site_admin":false},"labels":[{"id":1346427493,"node_id":"MDU6TGFiZWwxMzQ2NDI3NDkz","url":"https://api.github.com/repos/lal12/proto-parse/labels/documentation","name":"documentation","color":"09b8c1","default":true,"description":""},{"id":464612600,"node_id":"MDU6TGFiZWw0NjQ2MTI2MDA=","url":"https://api.github.com/repos/lal12/proto-parse/labels/enhancement","name":"enhancement","color":"84b6eb","default":true,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-01-13T13:54:05Z","updated_at":"2019-12-16T17:34:11Z","closed_at":null,"author_association":"NONE","body":"```js\r\n// SearchRequest note\r\nmessage SearchRequest {\r\n  string query = 1;         // note1\r\n  int32 page_number = 2;    // note2\r\n  int32 result_per_page = 3;  // note3\r\n  repeated string snippets = 4; // note4\r\n  Corpus corpus = 5;\r\n}\r\n\r\n// Parsing return time\r\n// example\r\n{\r\n\t\"type\": \"field\",\r\n\t\"typename\": \"map\",\r\n\t\"key\": \"int32\",\r\n\t\"value\": \"string\",\r\n\t\"name\": \"bla\",\r\n    \"note\": \"note 4\"    // this add\r\n\t\"fieldNo\": 1,\r\n\t\"opts\": {}\r\n}\r\n```\r\n\r\nTo give a suggestion, it is best to put an example.proto file in the library, so that it is easy to understand."},"comment":{"url":"https://api.github.com/repos/lal12/proto-parse/issues/comments/566162877","html_url":"https://github.com/lal12/proto-parse/issues/2#issuecomment-566162877","issue_url":"https://api.github.com/repos/lal12/proto-parse/issues/2","id":566162877,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NjE2Mjg3Nw==","user":{"login":"maltegrosse","id":16973405,"node_id":"MDQ6VXNlcjE2OTczNDA1","avatar_url":"https://avatars3.githubusercontent.com/u/16973405?v=4","gravatar_id":"","url":"https://api.github.com/users/maltegrosse","html_url":"https://github.com/maltegrosse","followers_url":"https://api.github.com/users/maltegrosse/followers","following_url":"https://api.github.com/users/maltegrosse/following{/other_user}","gists_url":"https://api.github.com/users/maltegrosse/gists{/gist_id}","starred_url":"https://api.github.com/users/maltegrosse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maltegrosse/subscriptions","organizations_url":"https://api.github.com/users/maltegrosse/orgs","repos_url":"https://api.github.com/users/maltegrosse/repos","events_url":"https://api.github.com/users/maltegrosse/events{/privacy}","received_events_url":"https://api.github.com/users/maltegrosse/received_events","type":"User","site_admin":false},"created_at":"2019-12-16T17:34:11Z","updated_at":"2019-12-16T17:34:11Z","author_association":"NONE","body":"I like the idea of adding kind of comments, but I would prefer to have it in a structured way.\r\nFor example https://github.com/favadi/protoc-go-inject-tag/blob/master/README.md#usage\r\nuse \r\n`// @inject_tag: valid:\"ip\"`\r\nthus we could define required fields which needs to be handled in the front end (for example in forms) - as the required/optional parameter was dropped in proto3\r\n`// @inject_tag: required:\"true\"`\r\n\r\nwhich would be parsed as\r\n`....{ .... \"required\": true ... }`\r\n\r\n`@inject_tag` would be nice as I already use it for my go backend.\r\nPS. the tag is always placed above the parameter"}}
{"actor":{"display_login":"maltegrosse"}}