{"action":"closed","number":48,"pull_request":{"url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/pulls/48","id":304572975,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0NTcyOTc1","html_url":"https://github.com/kinvolk/lokomotive-kubernetes/pull/48","diff_url":"https://github.com/kinvolk/lokomotive-kubernetes/pull/48.diff","patch_url":"https://github.com/kinvolk/lokomotive-kubernetes/pull/48.patch","issue_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/issues/48","number":48,"state":"closed","locked":false,"title":"Functionality to setup disk specific RAIDs","user":{"login":"surajssd","id":5815795,"node_id":"MDQ6VXNlcjU4MTU3OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5815795?v=4","gravatar_id":"","url":"https://api.github.com/users/surajssd","html_url":"https://github.com/surajssd","followers_url":"https://api.github.com/users/surajssd/followers","following_url":"https://api.github.com/users/surajssd/following{/other_user}","gists_url":"https://api.github.com/users/surajssd/gists{/gist_id}","starred_url":"https://api.github.com/users/surajssd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surajssd/subscriptions","organizations_url":"https://api.github.com/users/surajssd/orgs","repos_url":"https://api.github.com/users/surajssd/repos","events_url":"https://api.github.com/users/surajssd/events{/privacy}","received_events_url":"https://api.github.com/users/surajssd/received_events","type":"User","site_admin":false},"body":"* Added following variables:\r\n    \r\n  * `setup_raid_hdd` - If true, create RAID of HDDs only.\r\n  * `setup_raid_ssd` - If true, create RAID of SSDs only.\r\n    \r\n* Add a function to the install template of the worker nodes of packet\r\nto create RAID devices based on the disk types. Disk types here are SSD\r\nor HDD.\r\n    \r\n* Following devices are created, for each:\r\n\r\n  * SSD - `/dev/md/node-local-hdd-storage`\r\n  * HDD - `/dev/md/node-local-ssd-storage`\r\n\r\n* This can be specified by the user using the variables `setup_raid_hdd`\r\nand `setup_raid_ssd`.\r\n\r\n* This functionality is enabled only when `setup_raid` is set to\r\n`\"false\"`. So you can either use these three flags in following order:\r\n\r\n| `setup_raid_hdd`      | `setup_raid_ssd`      | `setup_raid`  |\r\n|------------------     |------------------     |-------------- |\r\n| `false`               | `false`               | `true`        |\r\n| `true`                | `false`               | `false`       |\r\n| `false`               | `true`                | `false`       |\r\n| `true`                | `true`                | `false`       |\r\n    \r\n    \r\n* The RAID persistance script(`function persist_data_raid`) currently\r\nassumes that there will be only one entry in the `/etc/mdadm.conf` file.\r\nThis commit adds logic to iterate through the file. This also changes\r\nthe hardcoded mount point of `/mnt` to `/mnt/device-name`.","created_at":"2019-08-06T06:51:13Z","updated_at":"2019-08-20T12:31:46Z","closed_at":"2019-08-20T12:31:46Z","merged_at":"2019-08-20T12:31:46Z","merge_commit_sha":"4b5174bfba533702382a55e186cd78030b721e2d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"indradhanush","id":2682729,"node_id":"MDQ6VXNlcjI2ODI3Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2682729?v=4","gravatar_id":"","url":"https://api.github.com/users/indradhanush","html_url":"https://github.com/indradhanush","followers_url":"https://api.github.com/users/indradhanush/followers","following_url":"https://api.github.com/users/indradhanush/following{/other_user}","gists_url":"https://api.github.com/users/indradhanush/gists{/gist_id}","starred_url":"https://api.github.com/users/indradhanush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indradhanush/subscriptions","organizations_url":"https://api.github.com/users/indradhanush/orgs","repos_url":"https://api.github.com/users/indradhanush/repos","events_url":"https://api.github.com/users/indradhanush/events{/privacy}","received_events_url":"https://api.github.com/users/indradhanush/received_events","type":"User","site_admin":false},{"login":"kosyfrances","id":10073270,"node_id":"MDQ6VXNlcjEwMDczMjcw","avatar_url":"https://avatars0.githubusercontent.com/u/10073270?v=4","gravatar_id":"","url":"https://api.github.com/users/kosyfrances","html_url":"https://github.com/kosyfrances","followers_url":"https://api.github.com/users/kosyfrances/followers","following_url":"https://api.github.com/users/kosyfrances/following{/other_user}","gists_url":"https://api.github.com/users/kosyfrances/gists{/gist_id}","starred_url":"https://api.github.com/users/kosyfrances/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kosyfrances/subscriptions","organizations_url":"https://api.github.com/users/kosyfrances/orgs","repos_url":"https://api.github.com/users/kosyfrances/repos","events_url":"https://api.github.com/users/kosyfrances/events{/privacy}","received_events_url":"https://api.github.com/users/kosyfrances/received_events","type":"User","site_admin":false},{"login":"johananl","id":14969425,"node_id":"MDQ6VXNlcjE0OTY5NDI1","avatar_url":"https://avatars2.githubusercontent.com/u/14969425?v=4","gravatar_id":"","url":"https://api.github.com/users/johananl","html_url":"https://github.com/johananl","followers_url":"https://api.github.com/users/johananl/followers","following_url":"https://api.github.com/users/johananl/following{/other_user}","gists_url":"https://api.github.com/users/johananl/gists{/gist_id}","starred_url":"https://api.github.com/users/johananl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johananl/subscriptions","organizations_url":"https://api.github.com/users/johananl/orgs","repos_url":"https://api.github.com/users/johananl/repos","events_url":"https://api.github.com/users/johananl/events{/privacy}","received_events_url":"https://api.github.com/users/johananl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/pulls/48/commits","review_comments_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/pulls/48/comments","review_comment_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/issues/48/comments","statuses_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/statuses/ab23803e31124c3c15fb0dd04e7c2aaed7944075","head":{"label":"kinvolk:surajssd/disk-type-specific-raid","ref":"surajssd/disk-type-specific-raid","sha":"ab23803e31124c3c15fb0dd04e7c2aaed7944075","user":{"login":"kinvolk","id":14073052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDczMDUy","avatar_url":"https://avatars0.githubusercontent.com/u/14073052?v=4","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"repo":{"id":185943369,"node_id":"MDEwOlJlcG9zaXRvcnkxODU5NDMzNjk=","name":"lokomotive-kubernetes","full_name":"kinvolk/lokomotive-kubernetes","private":false,"owner":{"login":"kinvolk","id":14073052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDczMDUy","avatar_url":"https://avatars0.githubusercontent.com/u/14073052?v=4","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kinvolk/lokomotive-kubernetes","description":"Lokomotive is a 100% open-source Kubernetes distribution from the folks at Kinvolk","fork":false,"url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes","forks_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/forks","keys_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/teams","hooks_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/events","assignees_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/tags","blobs_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/languages","stargazers_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/subscription","commits_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/merges","archive_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/downloads","issues_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/deployments","created_at":"2019-05-10T07:47:28Z","updated_at":"2019-08-19T14:23:39Z","pushed_at":"2019-08-20T12:31:45Z","git_url":"git://github.com/kinvolk/lokomotive-kubernetes.git","ssh_url":"git@github.com:kinvolk/lokomotive-kubernetes.git","clone_url":"https://github.com/kinvolk/lokomotive-kubernetes.git","svn_url":"https://github.com/kinvolk/lokomotive-kubernetes","homepage":"https://kinvolk.io","size":4058,"stargazers_count":93,"watchers_count":93,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":15,"watchers":93,"default_branch":"master"}},"base":{"label":"kinvolk:master","ref":"master","sha":"85732d1a934ddcd83fa8ea0a566f1ab3f89d0f66","user":{"login":"kinvolk","id":14073052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDczMDUy","avatar_url":"https://avatars0.githubusercontent.com/u/14073052?v=4","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"repo":{"id":185943369,"node_id":"MDEwOlJlcG9zaXRvcnkxODU5NDMzNjk=","name":"lokomotive-kubernetes","full_name":"kinvolk/lokomotive-kubernetes","private":false,"owner":{"login":"kinvolk","id":14073052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDczMDUy","avatar_url":"https://avatars0.githubusercontent.com/u/14073052?v=4","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kinvolk/lokomotive-kubernetes","description":"Lokomotive is a 100% open-source Kubernetes distribution from the folks at Kinvolk","fork":false,"url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes","forks_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/forks","keys_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/teams","hooks_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/events","assignees_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/tags","blobs_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/languages","stargazers_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/subscription","commits_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/merges","archive_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/downloads","issues_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/deployments","created_at":"2019-05-10T07:47:28Z","updated_at":"2019-08-19T14:23:39Z","pushed_at":"2019-08-20T12:31:45Z","git_url":"git://github.com/kinvolk/lokomotive-kubernetes.git","ssh_url":"git@github.com:kinvolk/lokomotive-kubernetes.git","clone_url":"https://github.com/kinvolk/lokomotive-kubernetes.git","svn_url":"https://github.com/kinvolk/lokomotive-kubernetes","homepage":"https://kinvolk.io","size":4058,"stargazers_count":93,"watchers_count":93,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":15,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/pulls/48"},"html":{"href":"https://github.com/kinvolk/lokomotive-kubernetes/pull/48"},"issue":{"href":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/issues/48"},"comments":{"href":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/kinvolk/lokomotive-kubernetes/statuses/ab23803e31124c3c15fb0dd04e7c2aaed7944075"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"surajssd","id":5815795,"node_id":"MDQ6VXNlcjU4MTU3OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5815795?v=4","gravatar_id":"","url":"https://api.github.com/users/surajssd","html_url":"https://github.com/surajssd","followers_url":"https://api.github.com/users/surajssd/followers","following_url":"https://api.github.com/users/surajssd/following{/other_user}","gists_url":"https://api.github.com/users/surajssd/gists{/gist_id}","starred_url":"https://api.github.com/users/surajssd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surajssd/subscriptions","organizations_url":"https://api.github.com/users/surajssd/orgs","repos_url":"https://api.github.com/users/surajssd/repos","events_url":"https://api.github.com/users/surajssd/events{/privacy}","received_events_url":"https://api.github.com/users/surajssd/received_events","type":"User","site_admin":false},"comments":7,"review_comments":28,"maintainer_can_modify":false,"commits":6,"additions":83,"deletions":9,"changed_files":4}}
{"actor":{"display_login":"surajssd"}}