{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74386","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74386/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74386/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74386/events","html_url":"https://github.com/kubernetes/kubernetes/pull/74386","id":413221935,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1MjU2ODcy","number":74386,"title":"fix negative slice index error in keymutex in 1.13","user":{"login":"danielqsj","id":7528864,"node_id":"MDQ6VXNlcjc1Mjg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7528864?v=4","gravatar_id":"","url":"https://api.github.com/users/danielqsj","html_url":"https://github.com/danielqsj","followers_url":"https://api.github.com/users/danielqsj/followers","following_url":"https://api.github.com/users/danielqsj/following{/other_user}","gists_url":"https://api.github.com/users/danielqsj/gists{/gist_id}","starred_url":"https://api.github.com/users/danielqsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielqsj/subscriptions","organizations_url":"https://api.github.com/users/danielqsj/orgs","repos_url":"https://api.github.com/users/danielqsj/repos","events_url":"https://api.github.com/users/danielqsj/events{/privacy}","received_events_url":"https://api.github.com/users/danielqsj/received_events","type":"User","site_admin":false},"labels":[{"id":339502903,"node_id":"MDU6TGFiZWwzMzk1MDI5MDM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cherry-pick-approved","name":"cherry-pick-approved","color":"fef2c0","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"aleksandra-malinowska","id":4884414,"node_id":"MDQ6VXNlcjQ4ODQ0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4884414?v=4","gravatar_id":"","url":"https://api.github.com/users/aleksandra-malinowska","html_url":"https://github.com/aleksandra-malinowska","followers_url":"https://api.github.com/users/aleksandra-malinowska/followers","following_url":"https://api.github.com/users/aleksandra-malinowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-malinowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-malinowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-malinowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-malinowska/orgs","repos_url":"https://api.github.com/users/aleksandra-malinowska/repos","events_url":"https://api.github.com/users/aleksandra-malinowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-malinowska/received_events","type":"User","site_admin":false},"assignees":[{"login":"apelisse","id":1929644,"node_id":"MDQ6VXNlcjE5Mjk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},{"login":"aleksandra-malinowska","id":4884414,"node_id":"MDQ6VXNlcjQ4ODQ0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4884414?v=4","gravatar_id":"","url":"https://api.github.com/users/aleksandra-malinowska","html_url":"https://github.com/aleksandra-malinowska","followers_url":"https://api.github.com/users/aleksandra-malinowska/followers","following_url":"https://api.github.com/users/aleksandra-malinowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-malinowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-malinowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-malinowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-malinowska/orgs","repos_url":"https://api.github.com/users/aleksandra-malinowska/repos","events_url":"https://api.github.com/users/aleksandra-malinowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-malinowska/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2019-02-22T03:06:00Z","updated_at":"2019-02-26T20:28:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/74386","html_url":"https://github.com/kubernetes/kubernetes/pull/74386","diff_url":"https://github.com/kubernetes/kubernetes/pull/74386.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/74386.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n\r\n1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n\r\n/kind bug\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis issue https://github.com/kubernetes/kubernetes/issues/73858 report that the generated index for slice in `keymutex` maybe negative in some platform (like arm).\r\n\r\nThis PR aims to fix this issue. \r\n\r\n**Which issue(s) this PR fixes**:\r\n<!-- \r\n*Automatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n-->\r\nFixes #73858\r\n\r\n**Special notes for your reviewer**:\r\n\r\nAlready fixed it in master branch by https://github.com/kubernetes/utils/pull/84.\r\nBut in before `1.14`, keymutex code is in k/k, so I submit this PR to fix it in `1.13`, and then will cherrypick to `1.12`.\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\" in the release-note block below.\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n-->\r\n```release-note\r\nFix keymutex issues which may crash in some platforms.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/467600627","html_url":"https://github.com/kubernetes/kubernetes/pull/74386#issuecomment-467600627","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74386","id":467600627,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NzYwMDYyNw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-02-26T20:28:46Z","updated_at":"2019-02-26T20:28:46Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/74386#issuecomment-467600345\" title=\"Approved\">apelisse</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/74386#\" title=\"Author self-approved\">danielqsj</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **thockin**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @thockin` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.13/pkg/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"thockin\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}