{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/swabbie/pulls/comments/262136401","pull_request_review_id":210234931,"id":262136401,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjEzNjQwMQ==","diff_hunk":"@@ -0,0 +1,97 @@\n+/*\n+ *\n+ * Copyright 2018 Netflix, Inc.","path":"swabbie-aws/src/main/kotlin/com/netflix/spinnaker/swabbie/aws/edda/providers/EddaAmazonSnapshotProvider.kt","position":3,"original_position":3,"commit_id":"1703b0f9e3ba11104b3ab787253cf4b854c75a8b","original_commit_id":"1703b0f9e3ba11104b3ab787253cf4b854c75a8b","user":{"login":"jeyrschabu","id":1572759,"node_id":"MDQ6VXNlcjE1NzI3NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1572759?v=4","gravatar_id":"","url":"https://api.github.com/users/jeyrschabu","html_url":"https://github.com/jeyrschabu","followers_url":"https://api.github.com/users/jeyrschabu/followers","following_url":"https://api.github.com/users/jeyrschabu/following{/other_user}","gists_url":"https://api.github.com/users/jeyrschabu/gists{/gist_id}","starred_url":"https://api.github.com/users/jeyrschabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeyrschabu/subscriptions","organizations_url":"https://api.github.com/users/jeyrschabu/orgs","repos_url":"https://api.github.com/users/jeyrschabu/repos","events_url":"https://api.github.com/users/jeyrschabu/events{/privacy}","received_events_url":"https://api.github.com/users/jeyrschabu/received_events","type":"User","site_admin":false},"body":"2019. Time flies","created_at":"2019-03-04T16:25:23Z","updated_at":"2019-03-04T16:46:48Z","html_url":"https://github.com/spinnaker/swabbie/pull/179#discussion_r262136401","pull_request_url":"https://api.github.com/repos/spinnaker/swabbie/pulls/179","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/comments/262136401"},"html":{"href":"https://github.com/spinnaker/swabbie/pull/179#discussion_r262136401"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/swabbie/pulls/179","id":257620455,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3NjIwNDU1","html_url":"https://github.com/spinnaker/swabbie/pull/179","diff_url":"https://github.com/spinnaker/swabbie/pull/179.diff","patch_url":"https://github.com/spinnaker/swabbie/pull/179.patch","issue_url":"https://api.github.com/repos/spinnaker/swabbie/issues/179","number":179,"state":"open","locked":false,"title":"feat(snapshots): snapshot handler to first pass","user":{"login":"emjburns","id":8454927,"node_id":"MDQ6VXNlcjg0NTQ5Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/8454927?v=4","gravatar_id":"","url":"https://api.github.com/users/emjburns","html_url":"https://github.com/emjburns","followers_url":"https://api.github.com/users/emjburns/followers","following_url":"https://api.github.com/users/emjburns/following{/other_user}","gists_url":"https://api.github.com/users/emjburns/gists{/gist_id}","starred_url":"https://api.github.com/users/emjburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emjburns/subscriptions","organizations_url":"https://api.github.com/users/emjburns/orgs","repos_url":"https://api.github.com/users/emjburns/repos","events_url":"https://api.github.com/users/emjburns/events{/privacy}","received_events_url":"https://api.github.com/users/emjburns/received_events","type":"User","site_admin":false},"body":"Mark snapshots. This will only mark things that fit the pattern of auto-snapshotted during a netflix bake. \r\n\r\nThere's also a change to the image handler. Some background: AMIs contain a mapping to snapshots. Snapshots do not contain the mapping of what image they're a snapshot of. The change: as we go through the AMIs we record what snapshots they have, with at TTL of 2 days. We use this information in the snapshot handler to not delete snapshots which have been recorded here aka the image still exists for this snapshot.\r\n\r\nComing: deletion of snapshots via an orca task. It's marked as to-do right now.\r\n\r\nAn important note: you can't delete a snapshot of an ebs volume when the image it was taken from exists. So, there is really no harm in 'accidentally' deleting the snapshot.  ","created_at":"2019-03-02T00:15:12Z","updated_at":"2019-03-04T16:46:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e01fcb9831bf222f5606c8d346c7af524d09310c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asher","id":59994,"node_id":"MDQ6VXNlcjU5OTk0","avatar_url":"https://avatars1.githubusercontent.com/u/59994?v=4","gravatar_id":"","url":"https://api.github.com/users/asher","html_url":"https://github.com/asher","followers_url":"https://api.github.com/users/asher/followers","following_url":"https://api.github.com/users/asher/following{/other_user}","gists_url":"https://api.github.com/users/asher/gists{/gist_id}","starred_url":"https://api.github.com/users/asher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asher/subscriptions","organizations_url":"https://api.github.com/users/asher/orgs","repos_url":"https://api.github.com/users/asher/repos","events_url":"https://api.github.com/users/asher/events{/privacy}","received_events_url":"https://api.github.com/users/asher/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/swabbie/pulls/179/commits","review_comments_url":"https://api.github.com/repos/spinnaker/swabbie/pulls/179/comments","review_comment_url":"https://api.github.com/repos/spinnaker/swabbie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/swabbie/issues/179/comments","statuses_url":"https://api.github.com/repos/spinnaker/swabbie/statuses/1703b0f9e3ba11104b3ab787253cf4b854c75a8b","head":{"label":"emjburns:snapshots","ref":"snapshots","sha":"1703b0f9e3ba11104b3ab787253cf4b854c75a8b","user":{"login":"emjburns","id":8454927,"node_id":"MDQ6VXNlcjg0NTQ5Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/8454927?v=4","gravatar_id":"","url":"https://api.github.com/users/emjburns","html_url":"https://github.com/emjburns","followers_url":"https://api.github.com/users/emjburns/followers","following_url":"https://api.github.com/users/emjburns/following{/other_user}","gists_url":"https://api.github.com/users/emjburns/gists{/gist_id}","starred_url":"https://api.github.com/users/emjburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emjburns/subscriptions","organizations_url":"https://api.github.com/users/emjburns/orgs","repos_url":"https://api.github.com/users/emjburns/repos","events_url":"https://api.github.com/users/emjburns/events{/privacy}","received_events_url":"https://api.github.com/users/emjburns/received_events","type":"User","site_admin":false},"repo":{"id":139478690,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0Nzg2OTA=","name":"swabbie","full_name":"emjburns/swabbie","private":false,"owner":{"login":"emjburns","id":8454927,"node_id":"MDQ6VXNlcjg0NTQ5Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/8454927?v=4","gravatar_id":"","url":"https://api.github.com/users/emjburns","html_url":"https://github.com/emjburns","followers_url":"https://api.github.com/users/emjburns/followers","following_url":"https://api.github.com/users/emjburns/following{/other_user}","gists_url":"https://api.github.com/users/emjburns/gists{/gist_id}","starred_url":"https://api.github.com/users/emjburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emjburns/subscriptions","organizations_url":"https://api.github.com/users/emjburns/orgs","repos_url":"https://api.github.com/users/emjburns/repos","events_url":"https://api.github.com/users/emjburns/events{/privacy}","received_events_url":"https://api.github.com/users/emjburns/received_events","type":"User","site_admin":false},"html_url":"https://github.com/emjburns/swabbie","description":"Spinnaker's janitor service","fork":true,"url":"https://api.github.com/repos/emjburns/swabbie","forks_url":"https://api.github.com/repos/emjburns/swabbie/forks","keys_url":"https://api.github.com/repos/emjburns/swabbie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emjburns/swabbie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emjburns/swabbie/teams","hooks_url":"https://api.github.com/repos/emjburns/swabbie/hooks","issue_events_url":"https://api.github.com/repos/emjburns/swabbie/issues/events{/number}","events_url":"https://api.github.com/repos/emjburns/swabbie/events","assignees_url":"https://api.github.com/repos/emjburns/swabbie/assignees{/user}","branches_url":"https://api.github.com/repos/emjburns/swabbie/branches{/branch}","tags_url":"https://api.github.com/repos/emjburns/swabbie/tags","blobs_url":"https://api.github.com/repos/emjburns/swabbie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emjburns/swabbie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emjburns/swabbie/git/refs{/sha}","trees_url":"https://api.github.com/repos/emjburns/swabbie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emjburns/swabbie/statuses/{sha}","languages_url":"https://api.github.com/repos/emjburns/swabbie/languages","stargazers_url":"https://api.github.com/repos/emjburns/swabbie/stargazers","contributors_url":"https://api.github.com/repos/emjburns/swabbie/contributors","subscribers_url":"https://api.github.com/repos/emjburns/swabbie/subscribers","subscription_url":"https://api.github.com/repos/emjburns/swabbie/subscription","commits_url":"https://api.github.com/repos/emjburns/swabbie/commits{/sha}","git_commits_url":"https://api.github.com/repos/emjburns/swabbie/git/commits{/sha}","comments_url":"https://api.github.com/repos/emjburns/swabbie/comments{/number}","issue_comment_url":"https://api.github.com/repos/emjburns/swabbie/issues/comments{/number}","contents_url":"https://api.github.com/repos/emjburns/swabbie/contents/{+path}","compare_url":"https://api.github.com/repos/emjburns/swabbie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emjburns/swabbie/merges","archive_url":"https://api.github.com/repos/emjburns/swabbie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emjburns/swabbie/downloads","issues_url":"https://api.github.com/repos/emjburns/swabbie/issues{/number}","pulls_url":"https://api.github.com/repos/emjburns/swabbie/pulls{/number}","milestones_url":"https://api.github.com/repos/emjburns/swabbie/milestones{/number}","notifications_url":"https://api.github.com/repos/emjburns/swabbie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emjburns/swabbie/labels{/name}","releases_url":"https://api.github.com/repos/emjburns/swabbie/releases{/id}","deployments_url":"https://api.github.com/repos/emjburns/swabbie/deployments","created_at":"2018-07-02T18:17:28Z","updated_at":"2018-12-07T19:50:33Z","pushed_at":"2019-03-01T23:22:41Z","git_url":"git://github.com/emjburns/swabbie.git","ssh_url":"git@github.com:emjburns/swabbie.git","clone_url":"https://github.com/emjburns/swabbie.git","svn_url":"https://github.com/emjburns/swabbie","homepage":"","size":1082,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"238de41187cfb9aaf923e8c7ad863494fb2e120a","user":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":90665799,"node_id":"MDEwOlJlcG9zaXRvcnk5MDY2NTc5OQ==","name":"swabbie","full_name":"spinnaker/swabbie","private":false,"owner":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spinnaker/swabbie","description":"Spinnaker's clean up service","fork":false,"url":"https://api.github.com/repos/spinnaker/swabbie","forks_url":"https://api.github.com/repos/spinnaker/swabbie/forks","keys_url":"https://api.github.com/repos/spinnaker/swabbie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/swabbie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/swabbie/teams","hooks_url":"https://api.github.com/repos/spinnaker/swabbie/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/swabbie/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/swabbie/events","assignees_url":"https://api.github.com/repos/spinnaker/swabbie/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/swabbie/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/swabbie/tags","blobs_url":"https://api.github.com/repos/spinnaker/swabbie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/swabbie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/swabbie/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/swabbie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/swabbie/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/swabbie/languages","stargazers_url":"https://api.github.com/repos/spinnaker/swabbie/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/swabbie/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/swabbie/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/swabbie/subscription","commits_url":"https://api.github.com/repos/spinnaker/swabbie/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/swabbie/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/swabbie/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/swabbie/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/swabbie/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/swabbie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/swabbie/merges","archive_url":"https://api.github.com/repos/spinnaker/swabbie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/swabbie/downloads","issues_url":"https://api.github.com/repos/spinnaker/swabbie/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/swabbie/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/swabbie/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/swabbie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/swabbie/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/swabbie/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/swabbie/deployments","created_at":"2017-05-08T19:39:33Z","updated_at":"2019-03-02T08:54:17Z","pushed_at":"2019-03-02T00:15:13Z","git_url":"git://github.com/spinnaker/swabbie.git","ssh_url":"git@github.com:spinnaker/swabbie.git","clone_url":"https://github.com/spinnaker/swabbie.git","svn_url":"https://github.com/spinnaker/swabbie","homepage":"","size":1002,"stargazers_count":68,"watchers_count":68,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":17,"open_issues":8,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/179"},"html":{"href":"https://github.com/spinnaker/swabbie/pull/179"},"issue":{"href":"https://api.github.com/repos/spinnaker/swabbie/issues/179"},"comments":{"href":"https://api.github.com/repos/spinnaker/swabbie/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/swabbie/statuses/1703b0f9e3ba11104b3ab787253cf4b854c75a8b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeyrschabu"}}