{"action":"created","comment":{"url":"https://api.github.com/repos/tp/tsaga/pulls/comments/275443116","pull_request_review_id":226751553,"id":275443116,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTQ0MzExNg==","diff_hunk":"@@ -66,7 +66,7 @@ export interface Saga<State, Payload> {\n \n export type AnySaga = Saga<any, any>;\n \n-export type ErrorHandler = (error: unknown) => void;\n+export type ErrorHandler = <Payload>(error: unknown, action: Action<Payload>) => void;","path":"src/lib/types.ts","position":5,"original_position":5,"commit_id":"ff12b648129493245cd12081ef00b8e8ef9b13bb","original_commit_id":"ff12b648129493245cd12081ef00b8e8ef9b13bb","user":{"login":"HenriBeck","id":8514706,"node_id":"MDQ6VXNlcjg1MTQ3MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8514706?v=4","gravatar_id":"","url":"https://api.github.com/users/HenriBeck","html_url":"https://github.com/HenriBeck","followers_url":"https://api.github.com/users/HenriBeck/followers","following_url":"https://api.github.com/users/HenriBeck/following{/other_user}","gists_url":"https://api.github.com/users/HenriBeck/gists{/gist_id}","starred_url":"https://api.github.com/users/HenriBeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenriBeck/subscriptions","organizations_url":"https://api.github.com/users/HenriBeck/orgs","repos_url":"https://api.github.com/users/HenriBeck/repos","events_url":"https://api.github.com/users/HenriBeck/events{/privacy}","received_events_url":"https://api.github.com/users/HenriBeck/received_events","type":"User","site_admin":false},"body":"Does it make sense to type `error` here as unknown? It should always be an `Error` object.","created_at":"2019-04-15T16:26:30Z","updated_at":"2019-04-15T16:26:30Z","html_url":"https://github.com/tp/tsaga/pull/46#discussion_r275443116","pull_request_url":"https://api.github.com/repos/tp/tsaga/pulls/46","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tp/tsaga/pulls/comments/275443116"},"html":{"href":"https://github.com/tp/tsaga/pull/46#discussion_r275443116"},"pull_request":{"href":"https://api.github.com/repos/tp/tsaga/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/tp/tsaga/pulls/46","id":270587977,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNTg3OTc3","html_url":"https://github.com/tp/tsaga/pull/46","diff_url":"https://github.com/tp/tsaga/pull/46.diff","patch_url":"https://github.com/tp/tsaga/pull/46.patch","issue_url":"https://api.github.com/repos/tp/tsaga/issues/46","number":46,"state":"open","locked":false,"title":"[feature] Add action to error handler as the second argument","user":{"login":"HenriBeck","id":8514706,"node_id":"MDQ6VXNlcjg1MTQ3MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8514706?v=4","gravatar_id":"","url":"https://api.github.com/users/HenriBeck","html_url":"https://github.com/HenriBeck","followers_url":"https://api.github.com/users/HenriBeck/followers","following_url":"https://api.github.com/users/HenriBeck/following{/other_user}","gists_url":"https://api.github.com/users/HenriBeck/gists{/gist_id}","starred_url":"https://api.github.com/users/HenriBeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenriBeck/subscriptions","organizations_url":"https://api.github.com/users/HenriBeck/orgs","repos_url":"https://api.github.com/users/HenriBeck/repos","events_url":"https://api.github.com/users/HenriBeck/events{/privacy}","received_events_url":"https://api.github.com/users/HenriBeck/received_events","type":"User","site_admin":false},"body":"This adds the action to the error handler to have more insights into what could have caused the issue.","created_at":"2019-04-15T16:25:52Z","updated_at":"2019-04-15T16:26:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"965b37e954c62a2ed5c1b580e0326137b44426a4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tp","id":52437,"node_id":"MDQ6VXNlcjUyNDM3","avatar_url":"https://avatars1.githubusercontent.com/u/52437?v=4","gravatar_id":"","url":"https://api.github.com/users/tp","html_url":"https://github.com/tp","followers_url":"https://api.github.com/users/tp/followers","following_url":"https://api.github.com/users/tp/following{/other_user}","gists_url":"https://api.github.com/users/tp/gists{/gist_id}","starred_url":"https://api.github.com/users/tp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tp/subscriptions","organizations_url":"https://api.github.com/users/tp/orgs","repos_url":"https://api.github.com/users/tp/repos","events_url":"https://api.github.com/users/tp/events{/privacy}","received_events_url":"https://api.github.com/users/tp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tp/tsaga/pulls/46/commits","review_comments_url":"https://api.github.com/repos/tp/tsaga/pulls/46/comments","review_comment_url":"https://api.github.com/repos/tp/tsaga/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tp/tsaga/issues/46/comments","statuses_url":"https://api.github.com/repos/tp/tsaga/statuses/ff12b648129493245cd12081ef00b8e8ef9b13bb","head":{"label":"tp:feature/add-action-to-error-handler","ref":"feature/add-action-to-error-handler","sha":"ff12b648129493245cd12081ef00b8e8ef9b13bb","user":{"login":"tp","id":52437,"node_id":"MDQ6VXNlcjUyNDM3","avatar_url":"https://avatars1.githubusercontent.com/u/52437?v=4","gravatar_id":"","url":"https://api.github.com/users/tp","html_url":"https://github.com/tp","followers_url":"https://api.github.com/users/tp/followers","following_url":"https://api.github.com/users/tp/following{/other_user}","gists_url":"https://api.github.com/users/tp/gists{/gist_id}","starred_url":"https://api.github.com/users/tp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tp/subscriptions","organizations_url":"https://api.github.com/users/tp/orgs","repos_url":"https://api.github.com/users/tp/repos","events_url":"https://api.github.com/users/tp/events{/privacy}","received_events_url":"https://api.github.com/users/tp/received_events","type":"User","site_admin":false},"repo":{"id":137528630,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1Mjg2MzA=","name":"tsaga","full_name":"tp/tsaga","private":false,"owner":{"login":"tp","id":52437,"node_id":"MDQ6VXNlcjUyNDM3","avatar_url":"https://avatars1.githubusercontent.com/u/52437?v=4","gravatar_id":"","url":"https://api.github.com/users/tp","html_url":"https://github.com/tp","followers_url":"https://api.github.com/users/tp/followers","following_url":"https://api.github.com/users/tp/following{/other_user}","gists_url":"https://api.github.com/users/tp/gists{/gist_id}","starred_url":"https://api.github.com/users/tp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tp/subscriptions","organizations_url":"https://api.github.com/users/tp/orgs","repos_url":"https://api.github.com/users/tp/repos","events_url":"https://api.github.com/users/tp/events{/privacy}","received_events_url":"https://api.github.com/users/tp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tp/tsaga","description":"Typesafe and lightweight way to write Redux-connected functions with asynchronous side-effects that are easily testable.","fork":false,"url":"https://api.github.com/repos/tp/tsaga","forks_url":"https://api.github.com/repos/tp/tsaga/forks","keys_url":"https://api.github.com/repos/tp/tsaga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tp/tsaga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tp/tsaga/teams","hooks_url":"https://api.github.com/repos/tp/tsaga/hooks","issue_events_url":"https://api.github.com/repos/tp/tsaga/issues/events{/number}","events_url":"https://api.github.com/repos/tp/tsaga/events","assignees_url":"https://api.github.com/repos/tp/tsaga/assignees{/user}","branches_url":"https://api.github.com/repos/tp/tsaga/branches{/branch}","tags_url":"https://api.github.com/repos/tp/tsaga/tags","blobs_url":"https://api.github.com/repos/tp/tsaga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tp/tsaga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tp/tsaga/git/refs{/sha}","trees_url":"https://api.github.com/repos/tp/tsaga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tp/tsaga/statuses/{sha}","languages_url":"https://api.github.com/repos/tp/tsaga/languages","stargazers_url":"https://api.github.com/repos/tp/tsaga/stargazers","contributors_url":"https://api.github.com/repos/tp/tsaga/contributors","subscribers_url":"https://api.github.com/repos/tp/tsaga/subscribers","subscription_url":"https://api.github.com/repos/tp/tsaga/subscription","commits_url":"https://api.github.com/repos/tp/tsaga/commits{/sha}","git_commits_url":"https://api.github.com/repos/tp/tsaga/git/commits{/sha}","comments_url":"https://api.github.com/repos/tp/tsaga/comments{/number}","issue_comment_url":"https://api.github.com/repos/tp/tsaga/issues/comments{/number}","contents_url":"https://api.github.com/repos/tp/tsaga/contents/{+path}","compare_url":"https://api.github.com/repos/tp/tsaga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tp/tsaga/merges","archive_url":"https://api.github.com/repos/tp/tsaga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tp/tsaga/downloads","issues_url":"https://api.github.com/repos/tp/tsaga/issues{/number}","pulls_url":"https://api.github.com/repos/tp/tsaga/pulls{/number}","milestones_url":"https://api.github.com/repos/tp/tsaga/milestones{/number}","notifications_url":"https://api.github.com/repos/tp/tsaga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tp/tsaga/labels{/name}","releases_url":"https://api.github.com/repos/tp/tsaga/releases{/id}","deployments_url":"https://api.github.com/repos/tp/tsaga/deployments","created_at":"2018-06-15T20:20:48Z","updated_at":"2019-04-15T12:51:13Z","pushed_at":"2019-04-15T16:25:52Z","git_url":"git://github.com/tp/tsaga.git","ssh_url":"git@github.com:tp/tsaga.git","clone_url":"https://github.com/tp/tsaga.git","svn_url":"https://github.com/tp/tsaga","homepage":"","size":366,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":7,"watchers":7,"default_branch":"master"}},"base":{"label":"tp:master","ref":"master","sha":"f95923fcfc00c1b87c78a15d26c0fa9e2c5e14ae","user":{"login":"tp","id":52437,"node_id":"MDQ6VXNlcjUyNDM3","avatar_url":"https://avatars1.githubusercontent.com/u/52437?v=4","gravatar_id":"","url":"https://api.github.com/users/tp","html_url":"https://github.com/tp","followers_url":"https://api.github.com/users/tp/followers","following_url":"https://api.github.com/users/tp/following{/other_user}","gists_url":"https://api.github.com/users/tp/gists{/gist_id}","starred_url":"https://api.github.com/users/tp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tp/subscriptions","organizations_url":"https://api.github.com/users/tp/orgs","repos_url":"https://api.github.com/users/tp/repos","events_url":"https://api.github.com/users/tp/events{/privacy}","received_events_url":"https://api.github.com/users/tp/received_events","type":"User","site_admin":false},"repo":{"id":137528630,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1Mjg2MzA=","name":"tsaga","full_name":"tp/tsaga","private":false,"owner":{"login":"tp","id":52437,"node_id":"MDQ6VXNlcjUyNDM3","avatar_url":"https://avatars1.githubusercontent.com/u/52437?v=4","gravatar_id":"","url":"https://api.github.com/users/tp","html_url":"https://github.com/tp","followers_url":"https://api.github.com/users/tp/followers","following_url":"https://api.github.com/users/tp/following{/other_user}","gists_url":"https://api.github.com/users/tp/gists{/gist_id}","starred_url":"https://api.github.com/users/tp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tp/subscriptions","organizations_url":"https://api.github.com/users/tp/orgs","repos_url":"https://api.github.com/users/tp/repos","events_url":"https://api.github.com/users/tp/events{/privacy}","received_events_url":"https://api.github.com/users/tp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tp/tsaga","description":"Typesafe and lightweight way to write Redux-connected functions with asynchronous side-effects that are easily testable.","fork":false,"url":"https://api.github.com/repos/tp/tsaga","forks_url":"https://api.github.com/repos/tp/tsaga/forks","keys_url":"https://api.github.com/repos/tp/tsaga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tp/tsaga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tp/tsaga/teams","hooks_url":"https://api.github.com/repos/tp/tsaga/hooks","issue_events_url":"https://api.github.com/repos/tp/tsaga/issues/events{/number}","events_url":"https://api.github.com/repos/tp/tsaga/events","assignees_url":"https://api.github.com/repos/tp/tsaga/assignees{/user}","branches_url":"https://api.github.com/repos/tp/tsaga/branches{/branch}","tags_url":"https://api.github.com/repos/tp/tsaga/tags","blobs_url":"https://api.github.com/repos/tp/tsaga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tp/tsaga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tp/tsaga/git/refs{/sha}","trees_url":"https://api.github.com/repos/tp/tsaga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tp/tsaga/statuses/{sha}","languages_url":"https://api.github.com/repos/tp/tsaga/languages","stargazers_url":"https://api.github.com/repos/tp/tsaga/stargazers","contributors_url":"https://api.github.com/repos/tp/tsaga/contributors","subscribers_url":"https://api.github.com/repos/tp/tsaga/subscribers","subscription_url":"https://api.github.com/repos/tp/tsaga/subscription","commits_url":"https://api.github.com/repos/tp/tsaga/commits{/sha}","git_commits_url":"https://api.github.com/repos/tp/tsaga/git/commits{/sha}","comments_url":"https://api.github.com/repos/tp/tsaga/comments{/number}","issue_comment_url":"https://api.github.com/repos/tp/tsaga/issues/comments{/number}","contents_url":"https://api.github.com/repos/tp/tsaga/contents/{+path}","compare_url":"https://api.github.com/repos/tp/tsaga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tp/tsaga/merges","archive_url":"https://api.github.com/repos/tp/tsaga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tp/tsaga/downloads","issues_url":"https://api.github.com/repos/tp/tsaga/issues{/number}","pulls_url":"https://api.github.com/repos/tp/tsaga/pulls{/number}","milestones_url":"https://api.github.com/repos/tp/tsaga/milestones{/number}","notifications_url":"https://api.github.com/repos/tp/tsaga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tp/tsaga/labels{/name}","releases_url":"https://api.github.com/repos/tp/tsaga/releases{/id}","deployments_url":"https://api.github.com/repos/tp/tsaga/deployments","created_at":"2018-06-15T20:20:48Z","updated_at":"2019-04-15T12:51:13Z","pushed_at":"2019-04-15T16:25:52Z","git_url":"git://github.com/tp/tsaga.git","ssh_url":"git@github.com:tp/tsaga.git","clone_url":"https://github.com/tp/tsaga.git","svn_url":"https://github.com/tp/tsaga","homepage":"","size":366,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tp/tsaga/pulls/46"},"html":{"href":"https://github.com/tp/tsaga/pull/46"},"issue":{"href":"https://api.github.com/repos/tp/tsaga/issues/46"},"comments":{"href":"https://api.github.com/repos/tp/tsaga/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/tp/tsaga/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/tp/tsaga/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tp/tsaga/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/tp/tsaga/statuses/ff12b648129493245cd12081ef00b8e8ef9b13bb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"HenriBeck"}}