{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/delicmakaveli/bitcoin/pulls/1","id":271883083,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxODgzMDgz","html_url":"https://github.com/delicmakaveli/bitcoin/pull/1","diff_url":"https://github.com/delicmakaveli/bitcoin/pull/1.diff","patch_url":"https://github.com/delicmakaveli/bitcoin/pull/1.patch","issue_url":"https://api.github.com/repos/delicmakaveli/bitcoin/issues/1","number":1,"state":"closed","locked":false,"title":"Merge master","user":{"login":"delicmakaveli","id":16024708,"node_id":"MDQ6VXNlcjE2MDI0NzA4","avatar_url":"https://avatars3.githubusercontent.com/u/16024708?v=4","gravatar_id":"","url":"https://api.github.com/users/delicmakaveli","html_url":"https://github.com/delicmakaveli","followers_url":"https://api.github.com/users/delicmakaveli/followers","following_url":"https://api.github.com/users/delicmakaveli/following{/other_user}","gists_url":"https://api.github.com/users/delicmakaveli/gists{/gist_id}","starred_url":"https://api.github.com/users/delicmakaveli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delicmakaveli/subscriptions","organizations_url":"https://api.github.com/users/delicmakaveli/orgs","repos_url":"https://api.github.com/users/delicmakaveli/repos","events_url":"https://api.github.com/users/delicmakaveli/events{/privacy}","received_events_url":"https://api.github.com/users/delicmakaveli/received_events","type":"User","site_admin":false},"body":"Pull requests without a rationale and clear improvement may be closed\r\nimmediately.\r\n\r\nPlease provide clear motivation for your patch and explain how it improves\r\nBitcoin Core user experience or Bitcoin Core developer experience\r\nsignificantly.\r\n\r\n* Any test improvements or new tests that improve coverage are always welcome.\r\n* All other changes should have accompanying unit tests (see `src/test/`) or\r\n  functional tests (see `test/`). Contributors should note which tests cover\r\n  modified code. If no tests exist for a region of modified code, new tests\r\n  should accompany the change.\r\n* Bug fixes are most welcome when they come with steps to reproduce or an\r\n  explanation of the potential issue as well as reasoning for the way the bug\r\n  was fixed.\r\n* Features are welcome, but might be rejected due to design or scope issues.\r\n  If a feature is based on a lot of dependencies, contributors should first\r\n  consider building the system outside of Bitcoin Core, if possible.\r\n* Refactoring changes are only accepted if they are required for a feature or\r\n  bug fix or otherwise improve developer experience significantly. For example,\r\n  most \"code style\" refactoring changes require a thorough explanation why they\r\n  are useful, what downsides they have and why they *significantly* improve\r\n  developer experience or avoid serious programming bugs. Note that code style\r\n  is often a subjective matter. Unless they are explicitly mentioned to be\r\n  preferred in the [developer notes](/doc/developer-notes.md), stylistic code\r\n  changes are usually rejected.\r\n\r\nBitcoin Core has a thorough review process and even the most trivial change\r\nneeds to pass a lot of eyes and requires non-zero or even substantial time\r\neffort to review. There is a huge lack of active reviewers on the project, so\r\npatches often sit for a long time.\r\n","created_at":"2019-04-19T01:41:11Z","updated_at":"2019-04-19T01:41:35Z","closed_at":"2019-04-19T01:41:35Z","merged_at":"2019-04-19T01:41:35Z","merge_commit_sha":"3bc18362826f1a9a4ac4b585f7793efe5435ed9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/delicmakaveli/bitcoin/pulls/1/commits","review_comments_url":"https://api.github.com/repos/delicmakaveli/bitcoin/pulls/1/comments","review_comment_url":"https://api.github.com/repos/delicmakaveli/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/delicmakaveli/bitcoin/issues/1/comments","statuses_url":"https://api.github.com/repos/delicmakaveli/bitcoin/statuses/d1c2ed8dd768fae8ba63b55f316a47b66e5b74f0","head":{"label":"bitcoin:master","ref":"master","sha":"d1c2ed8dd768fae8ba63b55f316a47b66e5b74f0","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2019-04-19T01:34:51Z","pushed_at":"2019-04-18T21:22:06Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":125024,"stargazers_count":37951,"watchers_count":37951,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":22520,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":963,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":22520,"open_issues":963,"watchers":37951,"default_branch":"master"}},"base":{"label":"delicmakaveli:master","ref":"master","sha":"efbc86733a551f2e1f5c43cd6de4fc730c7cce65","user":{"login":"delicmakaveli","id":16024708,"node_id":"MDQ6VXNlcjE2MDI0NzA4","avatar_url":"https://avatars3.githubusercontent.com/u/16024708?v=4","gravatar_id":"","url":"https://api.github.com/users/delicmakaveli","html_url":"https://github.com/delicmakaveli","followers_url":"https://api.github.com/users/delicmakaveli/followers","following_url":"https://api.github.com/users/delicmakaveli/following{/other_user}","gists_url":"https://api.github.com/users/delicmakaveli/gists{/gist_id}","starred_url":"https://api.github.com/users/delicmakaveli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delicmakaveli/subscriptions","organizations_url":"https://api.github.com/users/delicmakaveli/orgs","repos_url":"https://api.github.com/users/delicmakaveli/repos","events_url":"https://api.github.com/users/delicmakaveli/events{/privacy}","received_events_url":"https://api.github.com/users/delicmakaveli/received_events","type":"User","site_admin":false},"repo":{"id":179899462,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk4OTk0NjI=","name":"bitcoin","full_name":"delicmakaveli/bitcoin","private":false,"owner":{"login":"delicmakaveli","id":16024708,"node_id":"MDQ6VXNlcjE2MDI0NzA4","avatar_url":"https://avatars3.githubusercontent.com/u/16024708?v=4","gravatar_id":"","url":"https://api.github.com/users/delicmakaveli","html_url":"https://github.com/delicmakaveli","followers_url":"https://api.github.com/users/delicmakaveli/followers","following_url":"https://api.github.com/users/delicmakaveli/following{/other_user}","gists_url":"https://api.github.com/users/delicmakaveli/gists{/gist_id}","starred_url":"https://api.github.com/users/delicmakaveli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delicmakaveli/subscriptions","organizations_url":"https://api.github.com/users/delicmakaveli/orgs","repos_url":"https://api.github.com/users/delicmakaveli/repos","events_url":"https://api.github.com/users/delicmakaveli/events{/privacy}","received_events_url":"https://api.github.com/users/delicmakaveli/received_events","type":"User","site_admin":false},"html_url":"https://github.com/delicmakaveli/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/delicmakaveli/bitcoin","forks_url":"https://api.github.com/repos/delicmakaveli/bitcoin/forks","keys_url":"https://api.github.com/repos/delicmakaveli/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delicmakaveli/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delicmakaveli/bitcoin/teams","hooks_url":"https://api.github.com/repos/delicmakaveli/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/delicmakaveli/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/delicmakaveli/bitcoin/events","assignees_url":"https://api.github.com/repos/delicmakaveli/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/delicmakaveli/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/delicmakaveli/bitcoin/tags","blobs_url":"https://api.github.com/repos/delicmakaveli/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delicmakaveli/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delicmakaveli/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/delicmakaveli/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delicmakaveli/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/delicmakaveli/bitcoin/languages","stargazers_url":"https://api.github.com/repos/delicmakaveli/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/delicmakaveli/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/delicmakaveli/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/delicmakaveli/bitcoin/subscription","commits_url":"https://api.github.com/repos/delicmakaveli/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/delicmakaveli/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/delicmakaveli/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/delicmakaveli/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/delicmakaveli/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/delicmakaveli/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delicmakaveli/bitcoin/merges","archive_url":"https://api.github.com/repos/delicmakaveli/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delicmakaveli/bitcoin/downloads","issues_url":"https://api.github.com/repos/delicmakaveli/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/delicmakaveli/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/delicmakaveli/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/delicmakaveli/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delicmakaveli/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/delicmakaveli/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/delicmakaveli/bitcoin/deployments","created_at":"2019-04-06T23:57:38Z","updated_at":"2019-04-06T23:57:51Z","pushed_at":"2019-04-19T01:41:35Z","git_url":"git://github.com/delicmakaveli/bitcoin.git","ssh_url":"git@github.com:delicmakaveli/bitcoin.git","clone_url":"https://github.com/delicmakaveli/bitcoin.git","svn_url":"https://github.com/delicmakaveli/bitcoin","homepage":"https://bitcoincore.org/en/download","size":124526,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/delicmakaveli/bitcoin/pulls/1"},"html":{"href":"https://github.com/delicmakaveli/bitcoin/pull/1"},"issue":{"href":"https://api.github.com/repos/delicmakaveli/bitcoin/issues/1"},"comments":{"href":"https://api.github.com/repos/delicmakaveli/bitcoin/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/delicmakaveli/bitcoin/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/delicmakaveli/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/delicmakaveli/bitcoin/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/delicmakaveli/bitcoin/statuses/d1c2ed8dd768fae8ba63b55f316a47b66e5b74f0"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"delicmakaveli","id":16024708,"node_id":"MDQ6VXNlcjE2MDI0NzA4","avatar_url":"https://avatars3.githubusercontent.com/u/16024708?v=4","gravatar_id":"","url":"https://api.github.com/users/delicmakaveli","html_url":"https://github.com/delicmakaveli","followers_url":"https://api.github.com/users/delicmakaveli/followers","following_url":"https://api.github.com/users/delicmakaveli/following{/other_user}","gists_url":"https://api.github.com/users/delicmakaveli/gists{/gist_id}","starred_url":"https://api.github.com/users/delicmakaveli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delicmakaveli/subscriptions","organizations_url":"https://api.github.com/users/delicmakaveli/orgs","repos_url":"https://api.github.com/users/delicmakaveli/repos","events_url":"https://api.github.com/users/delicmakaveli/events{/privacy}","received_events_url":"https://api.github.com/users/delicmakaveli/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":139,"additions":4092,"deletions":2024,"changed_files":253}}
{"actor":{"display_login":"delicmakaveli"}}