{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/comments/270104706","pull_request_review_id":220153255,"id":270104706,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MDEwNDcwNg==","diff_hunk":"@@ -268,13 +268,22 @@ void createPropsFile()\n \n                 var fileContents =\n $@\"<Project DefaultTargets=\"\"Build\"\" xmlns=\"\"http://schemas.microsoft.com/developer/msbuild/2003\"\">\n-  {getEditorConfigAsAdditionalFile()}{getCodeAnalysisTreatWarningsNotAsErrors()}{getRulesetOverrides()}\n+  {getEditorConfigAsAdditionalFile()}{getCodeAnalysisTreatWarningsNotAsErrors()}{getRulesetOverrides()}{getFlowAnalysisFeatureFlag()}\n </Project>\";\n                 var directory = Directory.CreateDirectory(propsFileDir);\n                 var fileWithPath = Path.Combine(directory.FullName, propsFileName);\n                 File.WriteAllText(fileWithPath, fileContents);\n             }\n \n+            string getFlowAnalysisFeatureFlag()\n+            {\n+                return @\"\n+\n+  <PropertyGroup>\n+    <Features>$(Features);flow-analysis</Features> ","path":"src/GenerateAnalyzerRulesets/Program.cs","position":17,"original_position":17,"commit_id":"4c20716fecd9ad79b4aa275ae4b3b4bd1b3818ce","original_commit_id":"4c20716fecd9ad79b4aa275ae4b3b4bd1b3818ce","user":{"login":"genlu","id":788783,"node_id":"MDQ6VXNlcjc4ODc4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/788783?v=4","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"body":"Hmm, this is how we use it in this repo\r\nhttps://github.com/dotnet/roslyn-analyzers/blob/5ed057905c4e4def7f9e5abd4baccf8fc7286b4a/src/Directory.Build.props#L10","created_at":"2019-03-28T17:01:02Z","updated_at":"2019-03-28T17:01:03Z","html_url":"https://github.com/dotnet/roslyn-analyzers/pull/2251#discussion_r270104706","pull_request_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/2251","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/comments/270104706"},"html":{"href":"https://github.com/dotnet/roslyn-analyzers/pull/2251#discussion_r270104706"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/2251"}},"in_reply_to_id":270103951},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/2251","id":265420489,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1NDIwNDg5","html_url":"https://github.com/dotnet/roslyn-analyzers/pull/2251","diff_url":"https://github.com/dotnet/roslyn-analyzers/pull/2251.diff","patch_url":"https://github.com/dotnet/roslyn-analyzers/pull/2251.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/2251","number":2251,"state":"open","locked":false,"title":"Add flow-analysis feature flag to avoid AD0001 in pre-3.0 Roslyn","user":{"login":"genlu","id":788783,"node_id":"MDQ6VXNlcjc4ODc4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/788783?v=4","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-28T16:55:31Z","updated_at":"2019-03-28T17:01:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a60be6efa8375f9a3e0e670739c6fcced6fc2d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/2251/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/2251/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/2251/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/statuses/4c20716fecd9ad79b4aa275ae4b3b4bd1b3818ce","head":{"label":"genlu:addFeatureFlag","ref":"addFeatureFlag","sha":"4c20716fecd9ad79b4aa275ae4b3b4bd1b3818ce","user":{"login":"genlu","id":788783,"node_id":"MDQ6VXNlcjc4ODc4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/788783?v=4","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"repo":{"id":40015961,"node_id":"MDEwOlJlcG9zaXRvcnk0MDAxNTk2MQ==","name":"roslyn-analyzers","full_name":"genlu/roslyn-analyzers","private":false,"owner":{"login":"genlu","id":788783,"node_id":"MDQ6VXNlcjc4ODc4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/788783?v=4","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/genlu/roslyn-analyzers","description":null,"fork":true,"url":"https://api.github.com/repos/genlu/roslyn-analyzers","forks_url":"https://api.github.com/repos/genlu/roslyn-analyzers/forks","keys_url":"https://api.github.com/repos/genlu/roslyn-analyzers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genlu/roslyn-analyzers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genlu/roslyn-analyzers/teams","hooks_url":"https://api.github.com/repos/genlu/roslyn-analyzers/hooks","issue_events_url":"https://api.github.com/repos/genlu/roslyn-analyzers/issues/events{/number}","events_url":"https://api.github.com/repos/genlu/roslyn-analyzers/events","assignees_url":"https://api.github.com/repos/genlu/roslyn-analyzers/assignees{/user}","branches_url":"https://api.github.com/repos/genlu/roslyn-analyzers/branches{/branch}","tags_url":"https://api.github.com/repos/genlu/roslyn-analyzers/tags","blobs_url":"https://api.github.com/repos/genlu/roslyn-analyzers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genlu/roslyn-analyzers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genlu/roslyn-analyzers/git/refs{/sha}","trees_url":"https://api.github.com/repos/genlu/roslyn-analyzers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genlu/roslyn-analyzers/statuses/{sha}","languages_url":"https://api.github.com/repos/genlu/roslyn-analyzers/languages","stargazers_url":"https://api.github.com/repos/genlu/roslyn-analyzers/stargazers","contributors_url":"https://api.github.com/repos/genlu/roslyn-analyzers/contributors","subscribers_url":"https://api.github.com/repos/genlu/roslyn-analyzers/subscribers","subscription_url":"https://api.github.com/repos/genlu/roslyn-analyzers/subscription","commits_url":"https://api.github.com/repos/genlu/roslyn-analyzers/commits{/sha}","git_commits_url":"https://api.github.com/repos/genlu/roslyn-analyzers/git/commits{/sha}","comments_url":"https://api.github.com/repos/genlu/roslyn-analyzers/comments{/number}","issue_comment_url":"https://api.github.com/repos/genlu/roslyn-analyzers/issues/comments{/number}","contents_url":"https://api.github.com/repos/genlu/roslyn-analyzers/contents/{+path}","compare_url":"https://api.github.com/repos/genlu/roslyn-analyzers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genlu/roslyn-analyzers/merges","archive_url":"https://api.github.com/repos/genlu/roslyn-analyzers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genlu/roslyn-analyzers/downloads","issues_url":"https://api.github.com/repos/genlu/roslyn-analyzers/issues{/number}","pulls_url":"https://api.github.com/repos/genlu/roslyn-analyzers/pulls{/number}","milestones_url":"https://api.github.com/repos/genlu/roslyn-analyzers/milestones{/number}","notifications_url":"https://api.github.com/repos/genlu/roslyn-analyzers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genlu/roslyn-analyzers/labels{/name}","releases_url":"https://api.github.com/repos/genlu/roslyn-analyzers/releases{/id}","deployments_url":"https://api.github.com/repos/genlu/roslyn-analyzers/deployments","created_at":"2015-07-31T17:09:02Z","updated_at":"2016-03-02T01:03:50Z","pushed_at":"2019-03-28T16:55:14Z","git_url":"git://github.com/genlu/roslyn-analyzers.git","ssh_url":"git@github.com:genlu/roslyn-analyzers.git","clone_url":"https://github.com/genlu/roslyn-analyzers.git","svn_url":"https://github.com/genlu/roslyn-analyzers","homepage":null,"size":19359,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"daf067f2fc91f764bb5f447a909d215a847b3e55","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":36946704,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk0NjcwNA==","name":"roslyn-analyzers","full_name":"dotnet/roslyn-analyzers","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/roslyn-analyzers","description":null,"fork":false,"url":"https://api.github.com/repos/dotnet/roslyn-analyzers","forks_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/deployments","created_at":"2015-06-05T17:48:07Z","updated_at":"2019-03-28T16:14:07Z","pushed_at":"2019-03-28T16:55:32Z","git_url":"git://github.com/dotnet/roslyn-analyzers.git","ssh_url":"git@github.com:dotnet/roslyn-analyzers.git","clone_url":"https://github.com/dotnet/roslyn-analyzers.git","svn_url":"https://github.com/dotnet/roslyn-analyzers","homepage":null,"size":19330,"stargazers_count":469,"watchers_count":469,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"open_issues_count":388,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":168,"open_issues":388,"watchers":469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/2251"},"html":{"href":"https://github.com/dotnet/roslyn-analyzers/pull/2251"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/2251"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/2251/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/2251/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/2251/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn-analyzers/statuses/4c20716fecd9ad79b4aa275ae4b3b4bd1b3818ce"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"genlu"}}