{"action":"created","comment":{"url":"https://api.github.com/repos/slinderman/ssm/pulls/comments/281038678","pull_request_review_id":233797643,"id":281038678,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTAzODY3OA==","diff_hunk":"@@ -1,22 +1,25 @@\n-import copy\n-import warnings\n from functools import partial\n from tqdm.auto import trange\n \n import autograd.numpy as np\n import autograd.numpy.random as npr\n-from autograd.scipy.misc import logsumexp\n-from autograd.tracer import getval\n-from autograd.misc import flatten\n from autograd import value_and_grad\n \n-from ssm.optimizers import adam_step, rmsprop_step, sgd_step, convex_combination\n-from ssm.primitives import hmm_normalizer, hmm_expected_states, hmm_filter, hmm_sample, viterbi\n-from ssm.util import ensure_args_are_lists, ensure_args_not_none, \\\n+from .optimizers import adam_step, rmsprop_step, sgd_step, convex_combination","path":"ssm/hmm.py","position":16,"original_position":16,"commit_id":"cebb4e4c961f8eeb0871a2cdffd8c91f0fcf2127","original_commit_id":"cebb4e4c961f8eeb0871a2cdffd8c91f0fcf2127","user":{"login":"slinderman","id":5632040,"node_id":"MDQ6VXNlcjU2MzIwNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5632040?v=4","gravatar_id":"","url":"https://api.github.com/users/slinderman","html_url":"https://github.com/slinderman","followers_url":"https://api.github.com/users/slinderman/followers","following_url":"https://api.github.com/users/slinderman/following{/other_user}","gists_url":"https://api.github.com/users/slinderman/gists{/gist_id}","starred_url":"https://api.github.com/users/slinderman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slinderman/subscriptions","organizations_url":"https://api.github.com/users/slinderman/orgs","repos_url":"https://api.github.com/users/slinderman/repos","events_url":"https://api.github.com/users/slinderman/events{/privacy}","received_events_url":"https://api.github.com/users/slinderman/received_events","type":"User","site_admin":false},"body":"I'm not a huge fan of relative imports.  I think they're explicitly warned against in PEP8, but I might be wrong.  Anyway, no need to hold up the PR on that account.","created_at":"2019-05-05T21:03:22Z","updated_at":"2019-05-05T21:03:22Z","html_url":"https://github.com/slinderman/ssm/pull/33#discussion_r281038678","pull_request_url":"https://api.github.com/repos/slinderman/ssm/pulls/33","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/slinderman/ssm/pulls/comments/281038678"},"html":{"href":"https://github.com/slinderman/ssm/pull/33#discussion_r281038678"},"pull_request":{"href":"https://api.github.com/repos/slinderman/ssm/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/slinderman/ssm/pulls/33","id":276019889,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2MDE5ODg5","html_url":"https://github.com/slinderman/ssm/pull/33","diff_url":"https://github.com/slinderman/ssm/pull/33.diff","patch_url":"https://github.com/slinderman/ssm/pull/33.patch","issue_url":"https://api.github.com/repos/slinderman/ssm/issues/33","number":33,"state":"open","locked":false,"title":"Reorganize core models","user":{"login":"jchutrue","id":14321886,"node_id":"MDQ6VXNlcjE0MzIxODg2","avatar_url":"https://avatars0.githubusercontent.com/u/14321886?v=4","gravatar_id":"","url":"https://api.github.com/users/jchutrue","html_url":"https://github.com/jchutrue","followers_url":"https://api.github.com/users/jchutrue/followers","following_url":"https://api.github.com/users/jchutrue/following{/other_user}","gists_url":"https://api.github.com/users/jchutrue/gists{/gist_id}","starred_url":"https://api.github.com/users/jchutrue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchutrue/subscriptions","organizations_url":"https://api.github.com/users/jchutrue/orgs","repos_url":"https://api.github.com/users/jchutrue/repos","events_url":"https://api.github.com/users/jchutrue/events{/privacy}","received_events_url":"https://api.github.com/users/jchutrue/received_events","type":"User","site_admin":false},"body":"Moved HMM and LDS models into separate modules, and made them default ssm imports while removing models.py wrapper. Ensured tests and example code still run.","created_at":"2019-05-05T19:27:27Z","updated_at":"2019-05-05T21:03:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"803a23c37e481254f880a271515c7745b2fed55c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/slinderman/ssm/pulls/33/commits","review_comments_url":"https://api.github.com/repos/slinderman/ssm/pulls/33/comments","review_comment_url":"https://api.github.com/repos/slinderman/ssm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slinderman/ssm/issues/33/comments","statuses_url":"https://api.github.com/repos/slinderman/ssm/statuses/cebb4e4c961f8eeb0871a2cdffd8c91f0fcf2127","head":{"label":"jchutrue:master","ref":"master","sha":"cebb4e4c961f8eeb0871a2cdffd8c91f0fcf2127","user":{"login":"jchutrue","id":14321886,"node_id":"MDQ6VXNlcjE0MzIxODg2","avatar_url":"https://avatars0.githubusercontent.com/u/14321886?v=4","gravatar_id":"","url":"https://api.github.com/users/jchutrue","html_url":"https://github.com/jchutrue","followers_url":"https://api.github.com/users/jchutrue/followers","following_url":"https://api.github.com/users/jchutrue/following{/other_user}","gists_url":"https://api.github.com/users/jchutrue/gists{/gist_id}","starred_url":"https://api.github.com/users/jchutrue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchutrue/subscriptions","organizations_url":"https://api.github.com/users/jchutrue/orgs","repos_url":"https://api.github.com/users/jchutrue/repos","events_url":"https://api.github.com/users/jchutrue/events{/privacy}","received_events_url":"https://api.github.com/users/jchutrue/received_events","type":"User","site_admin":false},"repo":{"id":182415669,"node_id":"MDEwOlJlcG9zaXRvcnkxODI0MTU2Njk=","name":"ssm","full_name":"jchutrue/ssm","private":false,"owner":{"login":"jchutrue","id":14321886,"node_id":"MDQ6VXNlcjE0MzIxODg2","avatar_url":"https://avatars0.githubusercontent.com/u/14321886?v=4","gravatar_id":"","url":"https://api.github.com/users/jchutrue","html_url":"https://github.com/jchutrue","followers_url":"https://api.github.com/users/jchutrue/followers","following_url":"https://api.github.com/users/jchutrue/following{/other_user}","gists_url":"https://api.github.com/users/jchutrue/gists{/gist_id}","starred_url":"https://api.github.com/users/jchutrue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchutrue/subscriptions","organizations_url":"https://api.github.com/users/jchutrue/orgs","repos_url":"https://api.github.com/users/jchutrue/repos","events_url":"https://api.github.com/users/jchutrue/events{/privacy}","received_events_url":"https://api.github.com/users/jchutrue/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jchutrue/ssm","description":"Bayesian learning and inference for state space models ","fork":true,"url":"https://api.github.com/repos/jchutrue/ssm","forks_url":"https://api.github.com/repos/jchutrue/ssm/forks","keys_url":"https://api.github.com/repos/jchutrue/ssm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jchutrue/ssm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jchutrue/ssm/teams","hooks_url":"https://api.github.com/repos/jchutrue/ssm/hooks","issue_events_url":"https://api.github.com/repos/jchutrue/ssm/issues/events{/number}","events_url":"https://api.github.com/repos/jchutrue/ssm/events","assignees_url":"https://api.github.com/repos/jchutrue/ssm/assignees{/user}","branches_url":"https://api.github.com/repos/jchutrue/ssm/branches{/branch}","tags_url":"https://api.github.com/repos/jchutrue/ssm/tags","blobs_url":"https://api.github.com/repos/jchutrue/ssm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jchutrue/ssm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jchutrue/ssm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jchutrue/ssm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jchutrue/ssm/statuses/{sha}","languages_url":"https://api.github.com/repos/jchutrue/ssm/languages","stargazers_url":"https://api.github.com/repos/jchutrue/ssm/stargazers","contributors_url":"https://api.github.com/repos/jchutrue/ssm/contributors","subscribers_url":"https://api.github.com/repos/jchutrue/ssm/subscribers","subscription_url":"https://api.github.com/repos/jchutrue/ssm/subscription","commits_url":"https://api.github.com/repos/jchutrue/ssm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jchutrue/ssm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jchutrue/ssm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jchutrue/ssm/issues/comments{/number}","contents_url":"https://api.github.com/repos/jchutrue/ssm/contents/{+path}","compare_url":"https://api.github.com/repos/jchutrue/ssm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jchutrue/ssm/merges","archive_url":"https://api.github.com/repos/jchutrue/ssm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jchutrue/ssm/downloads","issues_url":"https://api.github.com/repos/jchutrue/ssm/issues{/number}","pulls_url":"https://api.github.com/repos/jchutrue/ssm/pulls{/number}","milestones_url":"https://api.github.com/repos/jchutrue/ssm/milestones{/number}","notifications_url":"https://api.github.com/repos/jchutrue/ssm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jchutrue/ssm/labels{/name}","releases_url":"https://api.github.com/repos/jchutrue/ssm/releases{/id}","deployments_url":"https://api.github.com/repos/jchutrue/ssm/deployments","created_at":"2019-04-20T14:27:13Z","updated_at":"2019-05-04T19:31:32Z","pushed_at":"2019-05-04T19:31:30Z","git_url":"git://github.com/jchutrue/ssm.git","ssh_url":"git@github.com:jchutrue/ssm.git","clone_url":"https://github.com/jchutrue/ssm.git","svn_url":"https://github.com/jchutrue/ssm","homepage":"","size":7690,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slinderman:master","ref":"master","sha":"38078d66db72005de99701ab42b5309024d14d6f","user":{"login":"slinderman","id":5632040,"node_id":"MDQ6VXNlcjU2MzIwNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5632040?v=4","gravatar_id":"","url":"https://api.github.com/users/slinderman","html_url":"https://github.com/slinderman","followers_url":"https://api.github.com/users/slinderman/followers","following_url":"https://api.github.com/users/slinderman/following{/other_user}","gists_url":"https://api.github.com/users/slinderman/gists{/gist_id}","starred_url":"https://api.github.com/users/slinderman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slinderman/subscriptions","organizations_url":"https://api.github.com/users/slinderman/orgs","repos_url":"https://api.github.com/users/slinderman/repos","events_url":"https://api.github.com/users/slinderman/events{/privacy}","received_events_url":"https://api.github.com/users/slinderman/received_events","type":"User","site_admin":false},"repo":{"id":136493649,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0OTM2NDk=","name":"ssm","full_name":"slinderman/ssm","private":false,"owner":{"login":"slinderman","id":5632040,"node_id":"MDQ6VXNlcjU2MzIwNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5632040?v=4","gravatar_id":"","url":"https://api.github.com/users/slinderman","html_url":"https://github.com/slinderman","followers_url":"https://api.github.com/users/slinderman/followers","following_url":"https://api.github.com/users/slinderman/following{/other_user}","gists_url":"https://api.github.com/users/slinderman/gists{/gist_id}","starred_url":"https://api.github.com/users/slinderman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slinderman/subscriptions","organizations_url":"https://api.github.com/users/slinderman/orgs","repos_url":"https://api.github.com/users/slinderman/repos","events_url":"https://api.github.com/users/slinderman/events{/privacy}","received_events_url":"https://api.github.com/users/slinderman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/slinderman/ssm","description":"Bayesian learning and inference for state space models ","fork":false,"url":"https://api.github.com/repos/slinderman/ssm","forks_url":"https://api.github.com/repos/slinderman/ssm/forks","keys_url":"https://api.github.com/repos/slinderman/ssm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slinderman/ssm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slinderman/ssm/teams","hooks_url":"https://api.github.com/repos/slinderman/ssm/hooks","issue_events_url":"https://api.github.com/repos/slinderman/ssm/issues/events{/number}","events_url":"https://api.github.com/repos/slinderman/ssm/events","assignees_url":"https://api.github.com/repos/slinderman/ssm/assignees{/user}","branches_url":"https://api.github.com/repos/slinderman/ssm/branches{/branch}","tags_url":"https://api.github.com/repos/slinderman/ssm/tags","blobs_url":"https://api.github.com/repos/slinderman/ssm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slinderman/ssm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slinderman/ssm/git/refs{/sha}","trees_url":"https://api.github.com/repos/slinderman/ssm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slinderman/ssm/statuses/{sha}","languages_url":"https://api.github.com/repos/slinderman/ssm/languages","stargazers_url":"https://api.github.com/repos/slinderman/ssm/stargazers","contributors_url":"https://api.github.com/repos/slinderman/ssm/contributors","subscribers_url":"https://api.github.com/repos/slinderman/ssm/subscribers","subscription_url":"https://api.github.com/repos/slinderman/ssm/subscription","commits_url":"https://api.github.com/repos/slinderman/ssm/commits{/sha}","git_commits_url":"https://api.github.com/repos/slinderman/ssm/git/commits{/sha}","comments_url":"https://api.github.com/repos/slinderman/ssm/comments{/number}","issue_comment_url":"https://api.github.com/repos/slinderman/ssm/issues/comments{/number}","contents_url":"https://api.github.com/repos/slinderman/ssm/contents/{+path}","compare_url":"https://api.github.com/repos/slinderman/ssm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slinderman/ssm/merges","archive_url":"https://api.github.com/repos/slinderman/ssm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slinderman/ssm/downloads","issues_url":"https://api.github.com/repos/slinderman/ssm/issues{/number}","pulls_url":"https://api.github.com/repos/slinderman/ssm/pulls{/number}","milestones_url":"https://api.github.com/repos/slinderman/ssm/milestones{/number}","notifications_url":"https://api.github.com/repos/slinderman/ssm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slinderman/ssm/labels{/name}","releases_url":"https://api.github.com/repos/slinderman/ssm/releases{/id}","deployments_url":"https://api.github.com/repos/slinderman/ssm/deployments","created_at":"2018-06-07T15:03:39Z","updated_at":"2019-05-02T19:06:35Z","pushed_at":"2019-05-05T19:27:28Z","git_url":"git://github.com/slinderman/ssm.git","ssh_url":"git@github.com:slinderman/ssm.git","clone_url":"https://github.com/slinderman/ssm.git","svn_url":"https://github.com/slinderman/ssm","homepage":"","size":7447,"stargazers_count":88,"watchers_count":88,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":8,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slinderman/ssm/pulls/33"},"html":{"href":"https://github.com/slinderman/ssm/pull/33"},"issue":{"href":"https://api.github.com/repos/slinderman/ssm/issues/33"},"comments":{"href":"https://api.github.com/repos/slinderman/ssm/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/slinderman/ssm/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/slinderman/ssm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slinderman/ssm/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/slinderman/ssm/statuses/cebb4e4c961f8eeb0871a2cdffd8c91f0fcf2127"}},"author_association":"NONE"}}
{"actor":{"display_login":"slinderman"}}