{"action":"created","comment":{"url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/comments/326072638","pull_request_review_id":290430003,"id":326072638,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjA3MjYzOA==","diff_hunk":"@@ -90,49 +99,17 @@ var _ = Describe(\"NodeNetworkState\", func() {\n \t\t\t\tupdateDesiredState(br1Up)\n \t\t\t})\n \t\t\tAfterEach(func() {\n-\n-\t\t\t\t// First we clean desired state if we\n-\t\t\t\t// don't do that nmstate recreates the bridge\n-\t\t\t\tresetDesiredStateForNodes()\n-\n-\t\t\t\t// TODO: Add status conditions to ensure that\n-\t\t\t\t//       it has being really reset so we can\n-\t\t\t\t//       remove this ugly sleep\n-\t\t\t\ttime.Sleep(1 * time.Second)\n-\n-\t\t\t\t// Let's clean the bridge directly in the node\n-\t\t\t\t// bypassing nmstate\n-\t\t\t\tdeleteConnectionAtNodes(\"eth1\")\n-\t\t\t\tdeleteConnectionAtNodes(\"eth2\")\n-\t\t\t\tdeleteConnectionAtNodes(\"br1\")\n-\t\t\t})\n-\t\t\tIt(\"should have the linux bridge at currentState\", func() {\n+\t\t\t\tupdateDesiredState(br1Absent)","path":"test/e2e/simple_bridge_and_bond.go","position":87,"original_position":87,"commit_id":"528bbf5c10b162d30eef905f150cb223775b1f06","original_commit_id":"528bbf5c10b162d30eef905f150cb223775b1f06","user":{"login":"phoracek","id":3493830,"node_id":"MDQ6VXNlcjM0OTM4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3493830?v=4","gravatar_id":"","url":"https://api.github.com/users/phoracek","html_url":"https://github.com/phoracek","followers_url":"https://api.github.com/users/phoracek/followers","following_url":"https://api.github.com/users/phoracek/following{/other_user}","gists_url":"https://api.github.com/users/phoracek/gists{/gist_id}","starred_url":"https://api.github.com/users/phoracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoracek/subscriptions","organizations_url":"https://api.github.com/users/phoracek/orgs","repos_url":"https://api.github.com/users/phoracek/repos","events_url":"https://api.github.com/users/phoracek/events{/privacy}","received_events_url":"https://api.github.com/users/phoracek/received_events","type":"User","site_admin":false},"body":"Man this is great!","created_at":"2019-09-19T09:19:44Z","updated_at":"2019-09-19T09:36:25Z","html_url":"https://github.com/nmstate/kubernetes-nmstate/pull/173#discussion_r326072638","pull_request_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/173","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/comments/326072638"},"html":{"href":"https://github.com/nmstate/kubernetes-nmstate/pull/173#discussion_r326072638"},"pull_request":{"href":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/173","id":318855619,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE4ODU1NjE5","html_url":"https://github.com/nmstate/kubernetes-nmstate/pull/173","diff_url":"https://github.com/nmstate/kubernetes-nmstate/pull/173.diff","patch_url":"https://github.com/nmstate/kubernetes-nmstate/pull/173.patch","issue_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/issues/173","number":173,"state":"open","locked":false,"title":"Stabilize e2e tests and skip default bridge test","user":{"login":"qinqon","id":3216202,"node_id":"MDQ6VXNlcjMyMTYyMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3216202?v=4","gravatar_id":"","url":"https://api.github.com/users/qinqon","html_url":"https://github.com/qinqon","followers_url":"https://api.github.com/users/qinqon/followers","following_url":"https://api.github.com/users/qinqon/following{/other_user}","gists_url":"https://api.github.com/users/qinqon/gists{/gist_id}","starred_url":"https://api.github.com/users/qinqon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinqon/subscriptions","organizations_url":"https://api.github.com/users/qinqon/orgs","repos_url":"https://api.github.com/users/qinqon/repos","events_url":"https://api.github.com/users/qinqon/events{/privacy}","received_events_url":"https://api.github.com/users/qinqon/received_events","type":"User","site_admin":false},"body":"- Use kubernetes-nmstate to do tear down\r\n- Skip moving ip from to bridge test since it's failing and we need to investigate why\r\n- Increase ginkgo \"slow test\" threshold to 60 seconds\r\n\r\nSigned-off-by: Quique Llorente <ellorent@redhat.com>","created_at":"2019-09-18T14:53:00Z","updated_at":"2019-09-19T09:36:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b24c4a36ad42132fbf9404cac38c8683a4d9135","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SchSeba","id":4209208,"node_id":"MDQ6VXNlcjQyMDkyMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/4209208?v=4","gravatar_id":"","url":"https://api.github.com/users/SchSeba","html_url":"https://github.com/SchSeba","followers_url":"https://api.github.com/users/SchSeba/followers","following_url":"https://api.github.com/users/SchSeba/following{/other_user}","gists_url":"https://api.github.com/users/SchSeba/gists{/gist_id}","starred_url":"https://api.github.com/users/SchSeba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SchSeba/subscriptions","organizations_url":"https://api.github.com/users/SchSeba/orgs","repos_url":"https://api.github.com/users/SchSeba/repos","events_url":"https://api.github.com/users/SchSeba/events{/privacy}","received_events_url":"https://api.github.com/users/SchSeba/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/173/commits","review_comments_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/173/comments","review_comment_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/issues/173/comments","statuses_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/statuses/528bbf5c10b162d30eef905f150cb223775b1f06","head":{"label":"qinqon:stabilize_e2e_tests","ref":"stabilize_e2e_tests","sha":"528bbf5c10b162d30eef905f150cb223775b1f06","user":{"login":"qinqon","id":3216202,"node_id":"MDQ6VXNlcjMyMTYyMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3216202?v=4","gravatar_id":"","url":"https://api.github.com/users/qinqon","html_url":"https://github.com/qinqon","followers_url":"https://api.github.com/users/qinqon/followers","following_url":"https://api.github.com/users/qinqon/following{/other_user}","gists_url":"https://api.github.com/users/qinqon/gists{/gist_id}","starred_url":"https://api.github.com/users/qinqon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinqon/subscriptions","organizations_url":"https://api.github.com/users/qinqon/orgs","repos_url":"https://api.github.com/users/qinqon/repos","events_url":"https://api.github.com/users/qinqon/events{/privacy}","received_events_url":"https://api.github.com/users/qinqon/received_events","type":"User","site_admin":false},"repo":{"id":186424117,"node_id":"MDEwOlJlcG9zaXRvcnkxODY0MjQxMTc=","name":"kubernetes-nmstate","full_name":"qinqon/kubernetes-nmstate","private":false,"owner":{"login":"qinqon","id":3216202,"node_id":"MDQ6VXNlcjMyMTYyMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3216202?v=4","gravatar_id":"","url":"https://api.github.com/users/qinqon","html_url":"https://github.com/qinqon","followers_url":"https://api.github.com/users/qinqon/followers","following_url":"https://api.github.com/users/qinqon/following{/other_user}","gists_url":"https://api.github.com/users/qinqon/gists{/gist_id}","starred_url":"https://api.github.com/users/qinqon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinqon/subscriptions","organizations_url":"https://api.github.com/users/qinqon/orgs","repos_url":"https://api.github.com/users/qinqon/repos","events_url":"https://api.github.com/users/qinqon/events{/privacy}","received_events_url":"https://api.github.com/users/qinqon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/qinqon/kubernetes-nmstate","description":"Host-networking configuration driven by Kubernetes and executed by nmstate","fork":true,"url":"https://api.github.com/repos/qinqon/kubernetes-nmstate","forks_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/forks","keys_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/teams","hooks_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/hooks","issue_events_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/issues/events{/number}","events_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/events","assignees_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/assignees{/user}","branches_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/branches{/branch}","tags_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/tags","blobs_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/statuses/{sha}","languages_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/languages","stargazers_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/stargazers","contributors_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/contributors","subscribers_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/subscribers","subscription_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/subscription","commits_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/contents/{+path}","compare_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/merges","archive_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/downloads","issues_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/issues{/number}","pulls_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/pulls{/number}","milestones_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/milestones{/number}","notifications_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/labels{/name}","releases_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/releases{/id}","deployments_url":"https://api.github.com/repos/qinqon/kubernetes-nmstate/deployments","created_at":"2019-05-13T13:23:02Z","updated_at":"2019-06-04T09:02:39Z","pushed_at":"2019-09-19T09:13:51Z","git_url":"git://github.com/qinqon/kubernetes-nmstate.git","ssh_url":"git@github.com:qinqon/kubernetes-nmstate.git","clone_url":"https://github.com/qinqon/kubernetes-nmstate.git","svn_url":"https://github.com/qinqon/kubernetes-nmstate","homepage":"","size":61558,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nmstate:master","ref":"master","sha":"472f715e3deea923c112df8a145c87919ac2c379","user":{"login":"nmstate","id":39068239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDY4MjM5","avatar_url":"https://avatars0.githubusercontent.com/u/39068239?v=4","gravatar_id":"","url":"https://api.github.com/users/nmstate","html_url":"https://github.com/nmstate","followers_url":"https://api.github.com/users/nmstate/followers","following_url":"https://api.github.com/users/nmstate/following{/other_user}","gists_url":"https://api.github.com/users/nmstate/gists{/gist_id}","starred_url":"https://api.github.com/users/nmstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmstate/subscriptions","organizations_url":"https://api.github.com/users/nmstate/orgs","repos_url":"https://api.github.com/users/nmstate/repos","events_url":"https://api.github.com/users/nmstate/events{/privacy}","received_events_url":"https://api.github.com/users/nmstate/received_events","type":"Organization","site_admin":false},"repo":{"id":155579204,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU1NzkyMDQ=","name":"kubernetes-nmstate","full_name":"nmstate/kubernetes-nmstate","private":false,"owner":{"login":"nmstate","id":39068239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDY4MjM5","avatar_url":"https://avatars0.githubusercontent.com/u/39068239?v=4","gravatar_id":"","url":"https://api.github.com/users/nmstate","html_url":"https://github.com/nmstate","followers_url":"https://api.github.com/users/nmstate/followers","following_url":"https://api.github.com/users/nmstate/following{/other_user}","gists_url":"https://api.github.com/users/nmstate/gists{/gist_id}","starred_url":"https://api.github.com/users/nmstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmstate/subscriptions","organizations_url":"https://api.github.com/users/nmstate/orgs","repos_url":"https://api.github.com/users/nmstate/repos","events_url":"https://api.github.com/users/nmstate/events{/privacy}","received_events_url":"https://api.github.com/users/nmstate/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nmstate/kubernetes-nmstate","description":"Host-networking configuration driven by Kubernetes and executed by nmstate","fork":false,"url":"https://api.github.com/repos/nmstate/kubernetes-nmstate","forks_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/forks","keys_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/teams","hooks_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/hooks","issue_events_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/issues/events{/number}","events_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/events","assignees_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/assignees{/user}","branches_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/branches{/branch}","tags_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/tags","blobs_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/statuses/{sha}","languages_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/languages","stargazers_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/stargazers","contributors_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/contributors","subscribers_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/subscribers","subscription_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/subscription","commits_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/contents/{+path}","compare_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/merges","archive_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/downloads","issues_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/issues{/number}","pulls_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls{/number}","milestones_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/milestones{/number}","notifications_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/labels{/name}","releases_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/releases{/id}","deployments_url":"https://api.github.com/repos/nmstate/kubernetes-nmstate/deployments","created_at":"2018-10-31T15:19:55Z","updated_at":"2019-09-19T09:30:34Z","pushed_at":"2019-09-19T09:13:53Z","git_url":"git://github.com/nmstate/kubernetes-nmstate.git","ssh_url":"git@github.com:nmstate/kubernetes-nmstate.git","clone_url":"https://github.com/nmstate/kubernetes-nmstate.git","svn_url":"https://github.com/nmstate/kubernetes-nmstate","homepage":"","size":61405,"stargazers_count":18,"watchers_count":18,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":33,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":8,"open_issues":33,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/173"},"html":{"href":"https://github.com/nmstate/kubernetes-nmstate/pull/173"},"issue":{"href":"https://api.github.com/repos/nmstate/kubernetes-nmstate/issues/173"},"comments":{"href":"https://api.github.com/repos/nmstate/kubernetes-nmstate/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nmstate/kubernetes-nmstate/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/nmstate/kubernetes-nmstate/statuses/528bbf5c10b162d30eef905f150cb223775b1f06"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"phoracek"}}