{"action":"created","comment":{"url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/comments/359943930","pull_request_review_id":334742856,"id":359943930,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTk0MzkzMA==","diff_hunk":"@@ -9,20 +8,25 @@ import { AppComponent } from \"../../app.component\";\n   styleUrls: [\"./timer.component.css\", \"../../../assets/css/main.css\"]\n })\n export class TimerComponent implements OnInit {\n+  constructor(private app: AppComponent) {}\n+\n   private subscription: Subscription;\n   displayTime: string;\n   everySecond: Observable<number> = timer(0, 1000);\n \n-  constructor(private app: AppComponent) {}\n-\n   ngOnInit() {\n     this.subscription = this.everySecond.subscribe(seconds => {\n-      if (this.app.timeState === \"stateActive\") {\n-        this.app.remainingTime = this.app.remainingTime - 1000;\n-        this.displayTime = formatMS(this.app.remainingTime);\n-      } else if (this.app.timeState === \"stateIdle\") {\n-        this.displayTime = formatMS(this.app.remainingTime);\n+      for (const t of this.app.timerList.getAll().values()) {","path":"front-end/src/app/components/timer/timer.component.ts","position":25,"original_position":25,"commit_id":"de3113f1ba8a5ae663a5e6663a627e65b9eb1af3","original_commit_id":"de3113f1ba8a5ae663a5e6663a627e65b9eb1af3","user":{"login":"mrlomar","id":22982133,"node_id":"MDQ6VXNlcjIyOTgyMTMz","avatar_url":"https://avatars3.githubusercontent.com/u/22982133?v=4","gravatar_id":"","url":"https://api.github.com/users/mrlomar","html_url":"https://github.com/mrlomar","followers_url":"https://api.github.com/users/mrlomar/followers","following_url":"https://api.github.com/users/mrlomar/following{/other_user}","gists_url":"https://api.github.com/users/mrlomar/gists{/gist_id}","starred_url":"https://api.github.com/users/mrlomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrlomar/subscriptions","organizations_url":"https://api.github.com/users/mrlomar/orgs","repos_url":"https://api.github.com/users/mrlomar/repos","events_url":"https://api.github.com/users/mrlomar/events{/privacy}","received_events_url":"https://api.github.com/users/mrlomar/received_events","type":"User","site_admin":false},"body":"maybe rename `t` to `timer` so the code is easier to understand","created_at":"2019-12-19T16:14:25Z","updated_at":"2019-12-19T16:14:25Z","html_url":"https://github.com/IssaHanou/BEP_1920_Q2/pull/110#discussion_r359943930","pull_request_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/110","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/comments/359943930"},"html":{"href":"https://github.com/IssaHanou/BEP_1920_Q2/pull/110#discussion_r359943930"},"pull_request":{"href":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/110","id":355183326,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU1MTgzMzI2","html_url":"https://github.com/IssaHanou/BEP_1920_Q2/pull/110","diff_url":"https://github.com/IssaHanou/BEP_1920_Q2/pull/110.diff","patch_url":"https://github.com/IssaHanou/BEP_1920_Q2/pull/110.patch","issue_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/issues/110","number":110,"state":"open","locked":false,"title":"109 timer fixes","user":{"login":"GwennanS","id":12747298,"node_id":"MDQ6VXNlcjEyNzQ3Mjk4","avatar_url":"https://avatars2.githubusercontent.com/u/12747298?v=4","gravatar_id":"","url":"https://api.github.com/users/GwennanS","html_url":"https://github.com/GwennanS","followers_url":"https://api.github.com/users/GwennanS/followers","following_url":"https://api.github.com/users/GwennanS/following{/other_user}","gists_url":"https://api.github.com/users/GwennanS/gists{/gist_id}","starred_url":"https://api.github.com/users/GwennanS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GwennanS/subscriptions","organizations_url":"https://api.github.com/users/GwennanS/orgs","repos_url":"https://api.github.com/users/GwennanS/repos","events_url":"https://api.github.com/users/GwennanS/events{/privacy}","received_events_url":"https://api.github.com/users/GwennanS/received_events","type":"User","site_admin":false},"body":"Timer has now be restructured to be more like devices, now it will be easier to show all timers in the front-end in a later stage","created_at":"2019-12-19T14:49:41Z","updated_at":"2019-12-19T16:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d30b192def550e20558015fd7c8e92d531ce5a5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/110/commits","review_comments_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/110/comments","review_comment_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/issues/110/comments","statuses_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/statuses/de3113f1ba8a5ae663a5e6663a627e65b9eb1af3","head":{"label":"IssaHanou:109-timer-fixes","ref":"109-timer-fixes","sha":"de3113f1ba8a5ae663a5e6663a627e65b9eb1af3","user":{"login":"IssaHanou","id":23522361,"node_id":"MDQ6VXNlcjIzNTIyMzYx","avatar_url":"https://avatars1.githubusercontent.com/u/23522361?v=4","gravatar_id":"","url":"https://api.github.com/users/IssaHanou","html_url":"https://github.com/IssaHanou","followers_url":"https://api.github.com/users/IssaHanou/followers","following_url":"https://api.github.com/users/IssaHanou/following{/other_user}","gists_url":"https://api.github.com/users/IssaHanou/gists{/gist_id}","starred_url":"https://api.github.com/users/IssaHanou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IssaHanou/subscriptions","organizations_url":"https://api.github.com/users/IssaHanou/orgs","repos_url":"https://api.github.com/users/IssaHanou/repos","events_url":"https://api.github.com/users/IssaHanou/events{/privacy}","received_events_url":"https://api.github.com/users/IssaHanou/received_events","type":"User","site_admin":false},"repo":{"id":220968386,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA5NjgzODY=","name":"BEP_1920_Q2","full_name":"IssaHanou/BEP_1920_Q2","private":false,"owner":{"login":"IssaHanou","id":23522361,"node_id":"MDQ6VXNlcjIzNTIyMzYx","avatar_url":"https://avatars1.githubusercontent.com/u/23522361?v=4","gravatar_id":"","url":"https://api.github.com/users/IssaHanou","html_url":"https://github.com/IssaHanou","followers_url":"https://api.github.com/users/IssaHanou/followers","following_url":"https://api.github.com/users/IssaHanou/following{/other_user}","gists_url":"https://api.github.com/users/IssaHanou/gists{/gist_id}","starred_url":"https://api.github.com/users/IssaHanou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IssaHanou/subscriptions","organizations_url":"https://api.github.com/users/IssaHanou/orgs","repos_url":"https://api.github.com/users/IssaHanou/repos","events_url":"https://api.github.com/users/IssaHanou/events{/privacy}","received_events_url":"https://api.github.com/users/IssaHanou/received_events","type":"User","site_admin":false},"html_url":"https://github.com/IssaHanou/BEP_1920_Q2","description":null,"fork":false,"url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2","forks_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/forks","keys_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/teams","hooks_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/hooks","issue_events_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/issues/events{/number}","events_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/events","assignees_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/assignees{/user}","branches_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/branches{/branch}","tags_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/tags","blobs_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/git/refs{/sha}","trees_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/statuses/{sha}","languages_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/languages","stargazers_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/stargazers","contributors_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/contributors","subscribers_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/subscribers","subscription_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/subscription","commits_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/commits{/sha}","git_commits_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/git/commits{/sha}","comments_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/comments{/number}","issue_comment_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/issues/comments{/number}","contents_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/contents/{+path}","compare_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/merges","archive_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/downloads","issues_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/issues{/number}","pulls_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls{/number}","milestones_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/milestones{/number}","notifications_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/labels{/name}","releases_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/releases{/id}","deployments_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/deployments","created_at":"2019-11-11T11:40:11Z","updated_at":"2019-12-18T15:32:42Z","pushed_at":"2019-12-19T15:51:27Z","git_url":"git://github.com/IssaHanou/BEP_1920_Q2.git","ssh_url":"git@github.com:IssaHanou/BEP_1920_Q2.git","clone_url":"https://github.com/IssaHanou/BEP_1920_Q2.git","svn_url":"https://github.com/IssaHanou/BEP_1920_Q2","homepage":null,"size":2618,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":30,"watchers":1,"default_branch":"develop-sprint-4"}},"base":{"label":"IssaHanou:develop-sprint-4","ref":"develop-sprint-4","sha":"e9599deb8a53a95f1d487f0cc14df9fa0b25f65c","user":{"login":"IssaHanou","id":23522361,"node_id":"MDQ6VXNlcjIzNTIyMzYx","avatar_url":"https://avatars1.githubusercontent.com/u/23522361?v=4","gravatar_id":"","url":"https://api.github.com/users/IssaHanou","html_url":"https://github.com/IssaHanou","followers_url":"https://api.github.com/users/IssaHanou/followers","following_url":"https://api.github.com/users/IssaHanou/following{/other_user}","gists_url":"https://api.github.com/users/IssaHanou/gists{/gist_id}","starred_url":"https://api.github.com/users/IssaHanou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IssaHanou/subscriptions","organizations_url":"https://api.github.com/users/IssaHanou/orgs","repos_url":"https://api.github.com/users/IssaHanou/repos","events_url":"https://api.github.com/users/IssaHanou/events{/privacy}","received_events_url":"https://api.github.com/users/IssaHanou/received_events","type":"User","site_admin":false},"repo":{"id":220968386,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA5NjgzODY=","name":"BEP_1920_Q2","full_name":"IssaHanou/BEP_1920_Q2","private":false,"owner":{"login":"IssaHanou","id":23522361,"node_id":"MDQ6VXNlcjIzNTIyMzYx","avatar_url":"https://avatars1.githubusercontent.com/u/23522361?v=4","gravatar_id":"","url":"https://api.github.com/users/IssaHanou","html_url":"https://github.com/IssaHanou","followers_url":"https://api.github.com/users/IssaHanou/followers","following_url":"https://api.github.com/users/IssaHanou/following{/other_user}","gists_url":"https://api.github.com/users/IssaHanou/gists{/gist_id}","starred_url":"https://api.github.com/users/IssaHanou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IssaHanou/subscriptions","organizations_url":"https://api.github.com/users/IssaHanou/orgs","repos_url":"https://api.github.com/users/IssaHanou/repos","events_url":"https://api.github.com/users/IssaHanou/events{/privacy}","received_events_url":"https://api.github.com/users/IssaHanou/received_events","type":"User","site_admin":false},"html_url":"https://github.com/IssaHanou/BEP_1920_Q2","description":null,"fork":false,"url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2","forks_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/forks","keys_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/teams","hooks_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/hooks","issue_events_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/issues/events{/number}","events_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/events","assignees_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/assignees{/user}","branches_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/branches{/branch}","tags_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/tags","blobs_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/git/refs{/sha}","trees_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/statuses/{sha}","languages_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/languages","stargazers_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/stargazers","contributors_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/contributors","subscribers_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/subscribers","subscription_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/subscription","commits_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/commits{/sha}","git_commits_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/git/commits{/sha}","comments_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/comments{/number}","issue_comment_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/issues/comments{/number}","contents_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/contents/{+path}","compare_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/merges","archive_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/downloads","issues_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/issues{/number}","pulls_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls{/number}","milestones_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/milestones{/number}","notifications_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/labels{/name}","releases_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/releases{/id}","deployments_url":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/deployments","created_at":"2019-11-11T11:40:11Z","updated_at":"2019-12-18T15:32:42Z","pushed_at":"2019-12-19T15:51:27Z","git_url":"git://github.com/IssaHanou/BEP_1920_Q2.git","ssh_url":"git@github.com:IssaHanou/BEP_1920_Q2.git","clone_url":"https://github.com/IssaHanou/BEP_1920_Q2.git","svn_url":"https://github.com/IssaHanou/BEP_1920_Q2","homepage":null,"size":2618,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":30,"watchers":1,"default_branch":"develop-sprint-4"}},"_links":{"self":{"href":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/110"},"html":{"href":"https://github.com/IssaHanou/BEP_1920_Q2/pull/110"},"issue":{"href":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/issues/110"},"comments":{"href":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/IssaHanou/BEP_1920_Q2/statuses/de3113f1ba8a5ae663a5e6663a627e65b9eb1af3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mrlomar"}}