{"action":"created","comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/359725377","pull_request_review_id":334456482,"id":359725377,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTcyNTM3Nw==","diff_hunk":"@@ -1223,6 +1219,25 @@ func (l *channelLink) processHtlcResolution(resolution invoices.HtlcResolution,\n \treturn nil\n }\n \n+// getResolutionFailure returns the wire message that a htlc resolution should\n+// be failed with.\n+func getResolutionFailure(resolution invoices.HtlcResolution,\n+\tamount lnwire.MilliSatoshi) lnwire.FailureMessage {\n+\n+\t// If the resolution has been resolved as part of a MPP timeout, we need\n+\t// to fail the htlc with lnwire.FailMppTimeout.\n+\tif resolution.Outcome == invoices.ResultMPPTimeout {\n+\t\treturn &lnwire.FailMPPTimeout{}","path":"htlcswitch/link.go","position":126,"original_position":27,"commit_id":"9a40ef2443bd16a876bf3274017dd5efd2fbfa4c","original_commit_id":"9a40ef2443bd16a876bf3274017dd5efd2fbfa4c","user":{"login":"carlaKC","id":42311294,"node_id":"MDQ6VXNlcjQyMzExMjk0","avatar_url":"https://avatars1.githubusercontent.com/u/42311294?v=4","gravatar_id":"","url":"https://api.github.com/users/carlaKC","html_url":"https://github.com/carlaKC","followers_url":"https://api.github.com/users/carlaKC/followers","following_url":"https://api.github.com/users/carlaKC/following{/other_user}","gists_url":"https://api.github.com/users/carlaKC/gists{/gist_id}","starred_url":"https://api.github.com/users/carlaKC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlaKC/subscriptions","organizations_url":"https://api.github.com/users/carlaKC/orgs","repos_url":"https://api.github.com/users/carlaKC/repos","events_url":"https://api.github.com/users/carlaKC/events{/privacy}","received_events_url":"https://api.github.com/users/carlaKC/received_events","type":"User","site_admin":false},"body":"We tend to not have them for failures with no fields, `FailFinalExpiryTooSoon` has a constructor but it's the exception among the no field failures. The majority is no fields -> no constructor so I'm going to leave as is. ","created_at":"2019-12-19T07:53:24Z","updated_at":"2019-12-19T07:53:24Z","html_url":"https://github.com/lightningnetwork/lnd/pull/3831#discussion_r359725377","pull_request_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3831","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/359725377"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/3831#discussion_r359725377"},"pull_request":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3831"}},"in_reply_to_id":359326290},"pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3831","id":352586791,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyNTg2Nzkx","html_url":"https://github.com/lightningnetwork/lnd/pull/3831","diff_url":"https://github.com/lightningnetwork/lnd/pull/3831.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/3831.patch","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/3831","number":3831,"state":"open","locked":false,"title":"Add MPPTimeout ResolutionResult and expose to caller","user":{"login":"carlaKC","id":42311294,"node_id":"MDQ6VXNlcjQyMzExMjk0","avatar_url":"https://avatars1.githubusercontent.com/u/42311294?v=4","gravatar_id":"","url":"https://api.github.com/users/carlaKC","html_url":"https://github.com/carlaKC","followers_url":"https://api.github.com/users/carlaKC/followers","following_url":"https://api.github.com/users/carlaKC/following{/other_user}","gists_url":"https://api.github.com/users/carlaKC/gists{/gist_id}","starred_url":"https://api.github.com/users/carlaKC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlaKC/subscriptions","organizations_url":"https://api.github.com/users/carlaKC/orgs","repos_url":"https://api.github.com/users/carlaKC/repos","events_url":"https://api.github.com/users/carlaKC/events{/privacy}","received_events_url":"https://api.github.com/users/carlaKC/received_events","type":"User","site_admin":false},"body":"This change adds a `ResolutionResult` to the `hodlEvent` struct to provide calling functions with additional information about the outcome of an invoice update in the invoice registry. \r\n\r\nPurpose:\r\n1. Choose wire message based on update result (FailInvalidDetails vs MPPTimeout)\r\n2. More details for htlc notifier","created_at":"2019-12-12T20:01:12Z","updated_at":"2019-12-19T07:53:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c75d4b59cc50ca80a62ef0c73f97e44dac5c2ef0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cfromknecht","id":2013993,"node_id":"MDQ6VXNlcjIwMTM5OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1477059160,"node_id":"MDU6TGFiZWwxNDc3MDU5MTYw","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/v0.9.0","name":"v0.9.0","color":"48f29d","default":false,"description":""}],"milestone":{"url":"https://api.github.com/repos/lightningnetwork/lnd/milestones/16","html_url":"https://github.com/lightningnetwork/lnd/milestone/16","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones/16/labels","id":4535167,"node_id":"MDk6TWlsZXN0b25lNDUzNTE2Nw==","number":16,"title":"0.9.0","description":"","creator":{"login":"cfromknecht","id":2013993,"node_id":"MDQ6VXNlcjIwMTM5OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":85,"state":"open","created_at":"2019-07-31T01:37:41Z","updated_at":"2019-12-19T07:08:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3831/commits","review_comments_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3831/comments","review_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/3831/comments","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/9a40ef2443bd16a876bf3274017dd5efd2fbfa4c","head":{"label":"carlaKC:invoices-surfaceupdateresult","ref":"invoices-surfaceupdateresult","sha":"9a40ef2443bd16a876bf3274017dd5efd2fbfa4c","user":{"login":"carlaKC","id":42311294,"node_id":"MDQ6VXNlcjQyMzExMjk0","avatar_url":"https://avatars1.githubusercontent.com/u/42311294?v=4","gravatar_id":"","url":"https://api.github.com/users/carlaKC","html_url":"https://github.com/carlaKC","followers_url":"https://api.github.com/users/carlaKC/followers","following_url":"https://api.github.com/users/carlaKC/following{/other_user}","gists_url":"https://api.github.com/users/carlaKC/gists{/gist_id}","starred_url":"https://api.github.com/users/carlaKC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlaKC/subscriptions","organizations_url":"https://api.github.com/users/carlaKC/orgs","repos_url":"https://api.github.com/users/carlaKC/repos","events_url":"https://api.github.com/users/carlaKC/events{/privacy}","received_events_url":"https://api.github.com/users/carlaKC/received_events","type":"User","site_admin":false},"repo":{"id":152565322,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI1NjUzMjI=","name":"lnd","full_name":"carlaKC/lnd","private":false,"owner":{"login":"carlaKC","id":42311294,"node_id":"MDQ6VXNlcjQyMzExMjk0","avatar_url":"https://avatars1.githubusercontent.com/u/42311294?v=4","gravatar_id":"","url":"https://api.github.com/users/carlaKC","html_url":"https://github.com/carlaKC","followers_url":"https://api.github.com/users/carlaKC/followers","following_url":"https://api.github.com/users/carlaKC/following{/other_user}","gists_url":"https://api.github.com/users/carlaKC/gists{/gist_id}","starred_url":"https://api.github.com/users/carlaKC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlaKC/subscriptions","organizations_url":"https://api.github.com/users/carlaKC/orgs","repos_url":"https://api.github.com/users/carlaKC/repos","events_url":"https://api.github.com/users/carlaKC/events{/privacy}","received_events_url":"https://api.github.com/users/carlaKC/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carlaKC/lnd","description":"Lightning Network Daemon ⚡️","fork":true,"url":"https://api.github.com/repos/carlaKC/lnd","forks_url":"https://api.github.com/repos/carlaKC/lnd/forks","keys_url":"https://api.github.com/repos/carlaKC/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlaKC/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlaKC/lnd/teams","hooks_url":"https://api.github.com/repos/carlaKC/lnd/hooks","issue_events_url":"https://api.github.com/repos/carlaKC/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/carlaKC/lnd/events","assignees_url":"https://api.github.com/repos/carlaKC/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/carlaKC/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/carlaKC/lnd/tags","blobs_url":"https://api.github.com/repos/carlaKC/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlaKC/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlaKC/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlaKC/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlaKC/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/carlaKC/lnd/languages","stargazers_url":"https://api.github.com/repos/carlaKC/lnd/stargazers","contributors_url":"https://api.github.com/repos/carlaKC/lnd/contributors","subscribers_url":"https://api.github.com/repos/carlaKC/lnd/subscribers","subscription_url":"https://api.github.com/repos/carlaKC/lnd/subscription","commits_url":"https://api.github.com/repos/carlaKC/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlaKC/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlaKC/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlaKC/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlaKC/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/carlaKC/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlaKC/lnd/merges","archive_url":"https://api.github.com/repos/carlaKC/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlaKC/lnd/downloads","issues_url":"https://api.github.com/repos/carlaKC/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/carlaKC/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/carlaKC/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/carlaKC/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlaKC/lnd/labels{/name}","releases_url":"https://api.github.com/repos/carlaKC/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/carlaKC/lnd/deployments","created_at":"2018-10-11T09:24:29Z","updated_at":"2019-12-19T06:41:21Z","pushed_at":"2019-12-19T06:41:16Z","git_url":"git://github.com/carlaKC/lnd.git","ssh_url":"git@github.com:carlaKC/lnd.git","clone_url":"https://github.com/carlaKC/lnd.git","svn_url":"https://github.com/carlaKC/lnd","homepage":"","size":35551,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightningnetwork:master","ref":"master","sha":"773212bdf801e32f8072008db5a2ff1e8187f65f","user":{"login":"lightningnetwork","id":13424735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDI0NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":49765480,"node_id":"MDEwOlJlcG9zaXRvcnk0OTc2NTQ4MA==","name":"lnd","full_name":"lightningnetwork/lnd","private":false,"owner":{"login":"lightningnetwork","id":13424735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDI0NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightningnetwork/lnd","description":"Lightning Network Daemon ⚡️","fork":false,"url":"https://api.github.com/repos/lightningnetwork/lnd","forks_url":"https://api.github.com/repos/lightningnetwork/lnd/forks","keys_url":"https://api.github.com/repos/lightningnetwork/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightningnetwork/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightningnetwork/lnd/teams","hooks_url":"https://api.github.com/repos/lightningnetwork/lnd/hooks","issue_events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/lightningnetwork/lnd/events","assignees_url":"https://api.github.com/repos/lightningnetwork/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/lightningnetwork/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/lightningnetwork/lnd/tags","blobs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightningnetwork/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightningnetwork/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/lightningnetwork/lnd/languages","stargazers_url":"https://api.github.com/repos/lightningnetwork/lnd/stargazers","contributors_url":"https://api.github.com/repos/lightningnetwork/lnd/contributors","subscribers_url":"https://api.github.com/repos/lightningnetwork/lnd/subscribers","subscription_url":"https://api.github.com/repos/lightningnetwork/lnd/subscription","commits_url":"https://api.github.com/repos/lightningnetwork/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightningnetwork/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightningnetwork/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/lightningnetwork/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightningnetwork/lnd/merges","archive_url":"https://api.github.com/repos/lightningnetwork/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightningnetwork/lnd/downloads","issues_url":"https://api.github.com/repos/lightningnetwork/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/lightningnetwork/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/labels{/name}","releases_url":"https://api.github.com/repos/lightningnetwork/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/lightningnetwork/lnd/deployments","created_at":"2016-01-16T08:19:33Z","updated_at":"2019-12-19T07:08:19Z","pushed_at":"2019-12-19T07:52:30Z","git_url":"git://github.com/lightningnetwork/lnd.git","ssh_url":"git@github.com:lightningnetwork/lnd.git","clone_url":"https://github.com/lightningnetwork/lnd.git","svn_url":"https://github.com/lightningnetwork/lnd","homepage":"","size":35431,"stargazers_count":4285,"watchers_count":4285,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1207,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":340,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1207,"open_issues":340,"watchers":4285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3831"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/3831"},"issue":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/3831"},"comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/3831/comments"},"review_comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3831/comments"},"review_comment":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3831/commits"},"statuses":{"href":"https://api.github.com/repos/lightningnetwork/lnd/statuses/9a40ef2443bd16a876bf3274017dd5efd2fbfa4c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"carlaKC"}}