{"action":"created","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/4927","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/4927/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/4927/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/4927/events","html_url":"https://github.com/publiclab/plots2/issues/4927","id":417904271,"node_id":"MDU6SXNzdWU0MTc5MDQyNzE=","number":4927,"title":"Side Bar Overlap On Transition To Next Device Size","user":{"login":"skilfullycurled","id":950291,"node_id":"MDQ6VXNlcjk1MDI5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/950291?v=4","gravatar_id":"","url":"https://api.github.com/users/skilfullycurled","html_url":"https://github.com/skilfullycurled","followers_url":"https://api.github.com/users/skilfullycurled/followers","following_url":"https://api.github.com/users/skilfullycurled/following{/other_user}","gists_url":"https://api.github.com/users/skilfullycurled/gists{/gist_id}","starred_url":"https://api.github.com/users/skilfullycurled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skilfullycurled/subscriptions","organizations_url":"https://api.github.com/users/skilfullycurled/orgs","repos_url":"https://api.github.com/users/skilfullycurled/repos","events_url":"https://api.github.com/users/skilfullycurled/events{/privacy}","received_events_url":"https://api.github.com/users/skilfullycurled/received_events","type":"User","site_admin":false},"labels":[{"id":42345818,"node_id":"MDU6TGFiZWw0MjM0NTgxOA==","url":"https://api.github.com/repos/publiclab/plots2/labels/bug","name":"bug","color":"fc2929","default":true},{"id":427913793,"node_id":"MDU6TGFiZWw0Mjc5MTM3OTM=","url":"https://api.github.com/repos/publiclab/plots2/labels/design","name":"design","color":"b72ec7","default":false},{"id":173349489,"node_id":"MDU6TGFiZWwxNzMzNDk0ODk=","url":"https://api.github.com/repos/publiclab/plots2/labels/help%20wanted","name":"help wanted","color":"0e8a16","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-03-06T16:45:53Z","updated_at":"2019-03-06T22:58:56Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nFirefox 65 on macOS here.  When making the research note a smaller width, there is sidebar overlap as you switch from a computer screen sized to the next device (what I think is tablet sized?) both in the sidebar and header.  So far, the sidebar issue (second image) only happens on the research notes but it does not occur on the home page (for example).  The header issue (third image) happens on both.  Probably not very important since if I take out a table, I don't see the transition, but even so, there you have it.\r\n\r\nSee images for steps of transition.\r\n\r\n<img width=\"341\" alt=\"screen shot 2019-03-06 at 11 34 37 am\" src=\"https://user-images.githubusercontent.com/950291/53897789-df2fa800-4004-11e9-8739-7b91e60d7aad.png\">\r\n<img width=\"301\" alt=\"screen shot 2019-03-06 at 11 34 57 am\" src=\"https://user-images.githubusercontent.com/950291/53897812-eeaef100-4004-11e9-924b-df8de5511bb1.png\">\r\n<img width=\"327\" alt=\"screen shot 2019-03-06 at 11 35 12 am\" src=\"https://user-images.githubusercontent.com/950291/53897836-fb334980-4004-11e9-8c82-370a04b0f52f.png\">\r\n<img width=\"253\" alt=\"screen shot 2019-03-06 at 11 35 29 am\" src=\"https://user-images.githubusercontent.com/950291/53897844-fec6d080-4004-11e9-8686-685fcaa3b182.png\">\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/publiclab/plots2/issues/comments/470311599","html_url":"https://github.com/publiclab/plots2/issues/4927#issuecomment-470311599","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/4927","id":470311599,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MDMxMTU5OQ==","user":{"login":"jywarren","id":24359,"node_id":"MDQ6VXNlcjI0MzU5","avatar_url":"https://avatars1.githubusercontent.com/u/24359?v=4","gravatar_id":"","url":"https://api.github.com/users/jywarren","html_url":"https://github.com/jywarren","followers_url":"https://api.github.com/users/jywarren/followers","following_url":"https://api.github.com/users/jywarren/following{/other_user}","gists_url":"https://api.github.com/users/jywarren/gists{/gist_id}","starred_url":"https://api.github.com/users/jywarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jywarren/subscriptions","organizations_url":"https://api.github.com/users/jywarren/orgs","repos_url":"https://api.github.com/users/jywarren/repos","events_url":"https://api.github.com/users/jywarren/events{/privacy}","received_events_url":"https://api.github.com/users/jywarren/received_events","type":"User","site_admin":false},"created_at":"2019-03-06T22:58:56Z","updated_at":"2019-03-06T22:58:56Z","author_association":"CONTRIBUTOR","body":"Hi, and thanks for posting! I believe the image will be on this template:\n\nhttps://github.com/publiclab/plots2/blob/master/app/views/notes/show.html.erb#L12-L18\n\nA quick fix could be setting \"overflow:hidden\" on the image, but we may\nalso want to ensure it has a `max-width` css property that limits it to the\nwidth of the column. Could even just max-width: 100% work? It'll take some\ntesting -- making the window wider and narrower to try it out.\n\nThanks for the helpful screenshots!\n\nOn Wed, Mar 6, 2019 at 11:46 AM skilfullycurled <notifications@github.com>\nwrote:\n\n> Hi,\n>\n> Firefox 65 on macOS here. When making the research note width smaller, you\n> have sidebar overlap as you switch from a computer screen sized device to\n> (what I think is) the tablet size both in the sidebar and header. So far,\n> the second picture only happens on the research notes (haven't checked\n> every page) but it does not occur on the home page. The third picture\n> happens on both. Probably not very important since if I take out a table, I\n> don't see the transition, but even so, there you have it.\n>\n> See photos for steps of transition.\n>\n> [image: screen shot 2019-03-06 at 11 34 37 am]\n> <https://user-images.githubusercontent.com/950291/53897789-df2fa800-4004-11e9-8739-7b91e60d7aad.png>\n>\n> [image: screen shot 2019-03-06 at 11 34 57 am]\n> <https://user-images.githubusercontent.com/950291/53897812-eeaef100-4004-11e9-924b-df8de5511bb1.png>\n>\n> [image: screen shot 2019-03-06 at 11 35 12 am]\n> <https://user-images.githubusercontent.com/950291/53897836-fb334980-4004-11e9-8c82-370a04b0f52f.png>\n>\n> [image: screen shot 2019-03-06 at 11 35 29 am]\n> <https://user-images.githubusercontent.com/950291/53897844-fec6d080-4004-11e9-8686-685fcaa3b182.png>\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/publiclab/plots2/issues/4927>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AABfJ7CDA3u_ihSKwY-EP8pyuLGWN-oOks5vT_DCgaJpZM4bhVcm>\n> .\n>\n"}}
{"actor":{"display_login":"jywarren"}}