{"action":"closed","number":5952,"pull_request":{"url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/5952","id":297812348,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3ODEyMzQ4","html_url":"https://github.com/statsmodels/statsmodels/pull/5952","diff_url":"https://github.com/statsmodels/statsmodels/pull/5952.diff","patch_url":"https://github.com/statsmodels/statsmodels/pull/5952.patch","issue_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/5952","number":5952,"state":"closed","locked":false,"title":"ENH: Improve RESET test stability","user":{"login":"bashtage","id":5585221,"node_id":"MDQ6VXNlcjU1ODUyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/5585221?v=4","gravatar_id":"","url":"https://api.github.com/users/bashtage","html_url":"https://github.com/bashtage","followers_url":"https://api.github.com/users/bashtage/followers","following_url":"https://api.github.com/users/bashtage/following{/other_user}","gists_url":"https://api.github.com/users/bashtage/gists{/gist_id}","starred_url":"https://api.github.com/users/bashtage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashtage/subscriptions","organizations_url":"https://api.github.com/users/bashtage/orgs","repos_url":"https://api.github.com/users/bashtage/repos","events_url":"https://api.github.com/users/bashtage/events{/privacy}","received_events_url":"https://api.github.com/users/bashtage/received_events","type":"User","site_admin":false},"body":"Improve stability by normalizing columns\r\nTest against Stata\r\n\r\n- [X] closes #5508\r\n- [X] tests added / passed. \r\n- [X] code/documentation is well formatted.  \r\n- [X] properly formatted commit message. See \r\n      [NumPy's guide](https://docs.scipy.org/doc/numpy/dev/gitwash/development_workflow.html#writing-the-commit-message). \r\n\r\n<details>\r\n\r\n\r\n**Notes**:\r\n\r\n* It is essential that you add a test when making code changes. Tests are not \r\n  needed for doc changes.\r\n* When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).\r\n* When fixing a bug, you must add a test that would produce the bug in master and\r\n  then show that it is fixed with the new code.\r\n* New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can\r\n  verify you changes are well formatted by running \r\n  ```\r\n  git diff upstream/master -u -- \"*.py\" | flake8 --diff --isolated\r\n  ```\r\n  assuming `flake8` is installed. This command is also available on Windows \r\n  using the Windows System for Linux once `flake8` is installed in the \r\n  local Linux environment. While passing this test is not required, it is good practice and it help \r\n  improve code quality in `statsmodels`.\r\n* Docstring additions must render correctly, including escapes and LaTeX.\r\n\r\n</details>\r\n","created_at":"2019-07-15T22:39:07Z","updated_at":"2019-07-16T08:15:51Z","closed_at":"2019-07-16T08:15:51Z","merged_at":"2019-07-16T08:15:51Z","merge_commit_sha":"bf120181a6897faa72923a8b4a37dc615c66ac74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/5952/commits","review_comments_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/5952/comments","review_comment_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/comments{/number}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/5952/comments","statuses_url":"https://api.github.com/repos/statsmodels/statsmodels/statuses/57f65144bae3399aeae58bda426179e39fb74604","head":{"label":"bashtage:issue-5508","ref":"issue-5508","sha":"57f65144bae3399aeae58bda426179e39fb74604","user":{"login":"bashtage","id":5585221,"node_id":"MDQ6VXNlcjU1ODUyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/5585221?v=4","gravatar_id":"","url":"https://api.github.com/users/bashtage","html_url":"https://github.com/bashtage","followers_url":"https://api.github.com/users/bashtage/followers","following_url":"https://api.github.com/users/bashtage/following{/other_user}","gists_url":"https://api.github.com/users/bashtage/gists{/gist_id}","starred_url":"https://api.github.com/users/bashtage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashtage/subscriptions","organizations_url":"https://api.github.com/users/bashtage/orgs","repos_url":"https://api.github.com/users/bashtage/repos","events_url":"https://api.github.com/users/bashtage/events{/privacy}","received_events_url":"https://api.github.com/users/bashtage/received_events","type":"User","site_admin":false},"repo":{"id":13931299,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkzMTI5OQ==","name":"statsmodels","full_name":"bashtage/statsmodels","private":false,"owner":{"login":"bashtage","id":5585221,"node_id":"MDQ6VXNlcjU1ODUyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/5585221?v=4","gravatar_id":"","url":"https://api.github.com/users/bashtage","html_url":"https://github.com/bashtage","followers_url":"https://api.github.com/users/bashtage/followers","following_url":"https://api.github.com/users/bashtage/following{/other_user}","gists_url":"https://api.github.com/users/bashtage/gists{/gist_id}","starred_url":"https://api.github.com/users/bashtage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashtage/subscriptions","organizations_url":"https://api.github.com/users/bashtage/orgs","repos_url":"https://api.github.com/users/bashtage/repos","events_url":"https://api.github.com/users/bashtage/events{/privacy}","received_events_url":"https://api.github.com/users/bashtage/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bashtage/statsmodels","description":"Statsmodels: statistical modeling and econometrics in Python","fork":true,"url":"https://api.github.com/repos/bashtage/statsmodels","forks_url":"https://api.github.com/repos/bashtage/statsmodels/forks","keys_url":"https://api.github.com/repos/bashtage/statsmodels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bashtage/statsmodels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bashtage/statsmodels/teams","hooks_url":"https://api.github.com/repos/bashtage/statsmodels/hooks","issue_events_url":"https://api.github.com/repos/bashtage/statsmodels/issues/events{/number}","events_url":"https://api.github.com/repos/bashtage/statsmodels/events","assignees_url":"https://api.github.com/repos/bashtage/statsmodels/assignees{/user}","branches_url":"https://api.github.com/repos/bashtage/statsmodels/branches{/branch}","tags_url":"https://api.github.com/repos/bashtage/statsmodels/tags","blobs_url":"https://api.github.com/repos/bashtage/statsmodels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bashtage/statsmodels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bashtage/statsmodels/git/refs{/sha}","trees_url":"https://api.github.com/repos/bashtage/statsmodels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bashtage/statsmodels/statuses/{sha}","languages_url":"https://api.github.com/repos/bashtage/statsmodels/languages","stargazers_url":"https://api.github.com/repos/bashtage/statsmodels/stargazers","contributors_url":"https://api.github.com/repos/bashtage/statsmodels/contributors","subscribers_url":"https://api.github.com/repos/bashtage/statsmodels/subscribers","subscription_url":"https://api.github.com/repos/bashtage/statsmodels/subscription","commits_url":"https://api.github.com/repos/bashtage/statsmodels/commits{/sha}","git_commits_url":"https://api.github.com/repos/bashtage/statsmodels/git/commits{/sha}","comments_url":"https://api.github.com/repos/bashtage/statsmodels/comments{/number}","issue_comment_url":"https://api.github.com/repos/bashtage/statsmodels/issues/comments{/number}","contents_url":"https://api.github.com/repos/bashtage/statsmodels/contents/{+path}","compare_url":"https://api.github.com/repos/bashtage/statsmodels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bashtage/statsmodels/merges","archive_url":"https://api.github.com/repos/bashtage/statsmodels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bashtage/statsmodels/downloads","issues_url":"https://api.github.com/repos/bashtage/statsmodels/issues{/number}","pulls_url":"https://api.github.com/repos/bashtage/statsmodels/pulls{/number}","milestones_url":"https://api.github.com/repos/bashtage/statsmodels/milestones{/number}","notifications_url":"https://api.github.com/repos/bashtage/statsmodels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bashtage/statsmodels/labels{/name}","releases_url":"https://api.github.com/repos/bashtage/statsmodels/releases{/id}","deployments_url":"https://api.github.com/repos/bashtage/statsmodels/deployments","created_at":"2013-10-28T16:21:09Z","updated_at":"2019-07-15T21:39:33Z","pushed_at":"2019-07-16T08:15:14Z","git_url":"git://github.com/bashtage/statsmodels.git","ssh_url":"git@github.com:bashtage/statsmodels.git","clone_url":"https://github.com/bashtage/statsmodels.git","svn_url":"https://github.com/bashtage/statsmodels","homepage":"http://statsmodels.sourceforge.net/devel/","size":32822,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"statsmodels:master","ref":"master","sha":"1e2c518c4930fd0a4cd5486ddd128fe9680bff29","user":{"login":"statsmodels","id":717666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNzY2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/717666?v=4","gravatar_id":"","url":"https://api.github.com/users/statsmodels","html_url":"https://github.com/statsmodels","followers_url":"https://api.github.com/users/statsmodels/followers","following_url":"https://api.github.com/users/statsmodels/following{/other_user}","gists_url":"https://api.github.com/users/statsmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/statsmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statsmodels/subscriptions","organizations_url":"https://api.github.com/users/statsmodels/orgs","repos_url":"https://api.github.com/users/statsmodels/repos","events_url":"https://api.github.com/users/statsmodels/events{/privacy}","received_events_url":"https://api.github.com/users/statsmodels/received_events","type":"Organization","site_admin":false},"repo":{"id":1885237,"node_id":"MDEwOlJlcG9zaXRvcnkxODg1MjM3","name":"statsmodels","full_name":"statsmodels/statsmodels","private":false,"owner":{"login":"statsmodels","id":717666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNzY2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/717666?v=4","gravatar_id":"","url":"https://api.github.com/users/statsmodels","html_url":"https://github.com/statsmodels","followers_url":"https://api.github.com/users/statsmodels/followers","following_url":"https://api.github.com/users/statsmodels/following{/other_user}","gists_url":"https://api.github.com/users/statsmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/statsmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statsmodels/subscriptions","organizations_url":"https://api.github.com/users/statsmodels/orgs","repos_url":"https://api.github.com/users/statsmodels/repos","events_url":"https://api.github.com/users/statsmodels/events{/privacy}","received_events_url":"https://api.github.com/users/statsmodels/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/statsmodels/statsmodels","description":"Statsmodels: statistical modeling and econometrics in Python","fork":false,"url":"https://api.github.com/repos/statsmodels/statsmodels","forks_url":"https://api.github.com/repos/statsmodels/statsmodels/forks","keys_url":"https://api.github.com/repos/statsmodels/statsmodels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/statsmodels/statsmodels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/statsmodels/statsmodels/teams","hooks_url":"https://api.github.com/repos/statsmodels/statsmodels/hooks","issue_events_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/events{/number}","events_url":"https://api.github.com/repos/statsmodels/statsmodels/events","assignees_url":"https://api.github.com/repos/statsmodels/statsmodels/assignees{/user}","branches_url":"https://api.github.com/repos/statsmodels/statsmodels/branches{/branch}","tags_url":"https://api.github.com/repos/statsmodels/statsmodels/tags","blobs_url":"https://api.github.com/repos/statsmodels/statsmodels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/statsmodels/statsmodels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/statsmodels/statsmodels/git/refs{/sha}","trees_url":"https://api.github.com/repos/statsmodels/statsmodels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/statsmodels/statsmodels/statuses/{sha}","languages_url":"https://api.github.com/repos/statsmodels/statsmodels/languages","stargazers_url":"https://api.github.com/repos/statsmodels/statsmodels/stargazers","contributors_url":"https://api.github.com/repos/statsmodels/statsmodels/contributors","subscribers_url":"https://api.github.com/repos/statsmodels/statsmodels/subscribers","subscription_url":"https://api.github.com/repos/statsmodels/statsmodels/subscription","commits_url":"https://api.github.com/repos/statsmodels/statsmodels/commits{/sha}","git_commits_url":"https://api.github.com/repos/statsmodels/statsmodels/git/commits{/sha}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/comments{/number}","issue_comment_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/comments{/number}","contents_url":"https://api.github.com/repos/statsmodels/statsmodels/contents/{+path}","compare_url":"https://api.github.com/repos/statsmodels/statsmodels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/statsmodels/statsmodels/merges","archive_url":"https://api.github.com/repos/statsmodels/statsmodels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/statsmodels/statsmodels/downloads","issues_url":"https://api.github.com/repos/statsmodels/statsmodels/issues{/number}","pulls_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls{/number}","milestones_url":"https://api.github.com/repos/statsmodels/statsmodels/milestones{/number}","notifications_url":"https://api.github.com/repos/statsmodels/statsmodels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/statsmodels/statsmodels/labels{/name}","releases_url":"https://api.github.com/repos/statsmodels/statsmodels/releases{/id}","deployments_url":"https://api.github.com/repos/statsmodels/statsmodels/deployments","created_at":"2011-06-12T17:04:50Z","updated_at":"2019-07-16T08:15:41Z","pushed_at":"2019-07-16T08:15:51Z","git_url":"git://github.com/statsmodels/statsmodels.git","ssh_url":"git@github.com:statsmodels/statsmodels.git","clone_url":"https://github.com/statsmodels/statsmodels.git","svn_url":"https://github.com/statsmodels/statsmodels","homepage":"http://www.statsmodels.org/devel/","size":33872,"stargazers_count":4044,"watchers_count":4044,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1663,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1980,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1663,"open_issues":1980,"watchers":4044,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/5952"},"html":{"href":"https://github.com/statsmodels/statsmodels/pull/5952"},"issue":{"href":"https://api.github.com/repos/statsmodels/statsmodels/issues/5952"},"comments":{"href":"https://api.github.com/repos/statsmodels/statsmodels/issues/5952/comments"},"review_comments":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/5952/comments"},"review_comment":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/5952/commits"},"statuses":{"href":"https://api.github.com/repos/statsmodels/statsmodels/statuses/57f65144bae3399aeae58bda426179e39fb74604"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bashtage","id":5585221,"node_id":"MDQ6VXNlcjU1ODUyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/5585221?v=4","gravatar_id":"","url":"https://api.github.com/users/bashtage","html_url":"https://github.com/bashtage","followers_url":"https://api.github.com/users/bashtage/followers","following_url":"https://api.github.com/users/bashtage/following{/other_user}","gists_url":"https://api.github.com/users/bashtage/gists{/gist_id}","starred_url":"https://api.github.com/users/bashtage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashtage/subscriptions","organizations_url":"https://api.github.com/users/bashtage/orgs","repos_url":"https://api.github.com/users/bashtage/repos","events_url":"https://api.github.com/users/bashtage/events{/privacy}","received_events_url":"https://api.github.com/users/bashtage/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":28,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"bashtage"}}