{"action":"opened","number":877,"pull_request":{"url":"https://api.github.com/repos/popperjs/popper.js/pulls/877","id":350292741,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwMjkyNzQx","html_url":"https://github.com/popperjs/popper.js/pull/877","diff_url":"https://github.com/popperjs/popper.js/pull/877.diff","patch_url":"https://github.com/popperjs/popper.js/pull/877.patch","issue_url":"https://api.github.com/repos/popperjs/popper.js/issues/877","number":877,"state":"open","locked":false,"title":"feat: hide modifier","user":{"login":"atomiks","id":22450188,"node_id":"MDQ6VXNlcjIyNDUwMTg4","avatar_url":"https://avatars3.githubusercontent.com/u/22450188?v=4","gravatar_id":"","url":"https://api.github.com/users/atomiks","html_url":"https://github.com/atomiks","followers_url":"https://api.github.com/users/atomiks/followers","following_url":"https://api.github.com/users/atomiks/following{/other_user}","gists_url":"https://api.github.com/users/atomiks/gists{/gist_id}","starred_url":"https://api.github.com/users/atomiks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomiks/subscriptions","organizations_url":"https://api.github.com/users/atomiks/orgs","repos_url":"https://api.github.com/users/atomiks/repos","events_url":"https://api.github.com/users/atomiks/events{/privacy}","received_events_url":"https://api.github.com/users/atomiks/received_events","type":"User","site_admin":false},"body":"The `clippingParent` technique we have is too naive, as it doesn't consider multiple nested scrolling containers which can clip the element, we effectively need to get the minimum bounds of all the scrolling clipping parents and use that as a virtual rect instead.\r\n\r\nI tried working on the above but I discovered a positioning bug when the popper is within the same parent as the reference if the parent has `position: relative` which we need to fix first before we can solve the clipping issue.\r\n\r\nI'm not sure about how we should store the data for both the `reference` and `popper` overflows, and how the user can configure different ones for either element. They both have to use the same options.","created_at":"2019-12-07T09:00:25Z","updated_at":"2019-12-07T09:00:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/popperjs/popper.js/pulls/877/commits","review_comments_url":"https://api.github.com/repos/popperjs/popper.js/pulls/877/comments","review_comment_url":"https://api.github.com/repos/popperjs/popper.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/popperjs/popper.js/issues/877/comments","statuses_url":"https://api.github.com/repos/popperjs/popper.js/statuses/f31b6658a8283ff0355da486c6ba522cb6de026c","head":{"label":"atomiks:feat/hide-modifier","ref":"feat/hide-modifier","sha":"f31b6658a8283ff0355da486c6ba522cb6de026c","user":{"login":"atomiks","id":22450188,"node_id":"MDQ6VXNlcjIyNDUwMTg4","avatar_url":"https://avatars3.githubusercontent.com/u/22450188?v=4","gravatar_id":"","url":"https://api.github.com/users/atomiks","html_url":"https://github.com/atomiks","followers_url":"https://api.github.com/users/atomiks/followers","following_url":"https://api.github.com/users/atomiks/following{/other_user}","gists_url":"https://api.github.com/users/atomiks/gists{/gist_id}","starred_url":"https://api.github.com/users/atomiks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomiks/subscriptions","organizations_url":"https://api.github.com/users/atomiks/orgs","repos_url":"https://api.github.com/users/atomiks/repos","events_url":"https://api.github.com/users/atomiks/events{/privacy}","received_events_url":"https://api.github.com/users/atomiks/received_events","type":"User","site_admin":false},"repo":{"id":157859483,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4NTk0ODM=","name":"popper.js","full_name":"atomiks/popper.js","private":false,"owner":{"login":"atomiks","id":22450188,"node_id":"MDQ6VXNlcjIyNDUwMTg4","avatar_url":"https://avatars3.githubusercontent.com/u/22450188?v=4","gravatar_id":"","url":"https://api.github.com/users/atomiks","html_url":"https://github.com/atomiks","followers_url":"https://api.github.com/users/atomiks/followers","following_url":"https://api.github.com/users/atomiks/following{/other_user}","gists_url":"https://api.github.com/users/atomiks/gists{/gist_id}","starred_url":"https://api.github.com/users/atomiks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomiks/subscriptions","organizations_url":"https://api.github.com/users/atomiks/orgs","repos_url":"https://api.github.com/users/atomiks/repos","events_url":"https://api.github.com/users/atomiks/events{/privacy}","received_events_url":"https://api.github.com/users/atomiks/received_events","type":"User","site_admin":false},"html_url":"https://github.com/atomiks/popper.js","description":"A kickass library to manage your poppers","fork":true,"url":"https://api.github.com/repos/atomiks/popper.js","forks_url":"https://api.github.com/repos/atomiks/popper.js/forks","keys_url":"https://api.github.com/repos/atomiks/popper.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomiks/popper.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomiks/popper.js/teams","hooks_url":"https://api.github.com/repos/atomiks/popper.js/hooks","issue_events_url":"https://api.github.com/repos/atomiks/popper.js/issues/events{/number}","events_url":"https://api.github.com/repos/atomiks/popper.js/events","assignees_url":"https://api.github.com/repos/atomiks/popper.js/assignees{/user}","branches_url":"https://api.github.com/repos/atomiks/popper.js/branches{/branch}","tags_url":"https://api.github.com/repos/atomiks/popper.js/tags","blobs_url":"https://api.github.com/repos/atomiks/popper.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomiks/popper.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomiks/popper.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomiks/popper.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomiks/popper.js/statuses/{sha}","languages_url":"https://api.github.com/repos/atomiks/popper.js/languages","stargazers_url":"https://api.github.com/repos/atomiks/popper.js/stargazers","contributors_url":"https://api.github.com/repos/atomiks/popper.js/contributors","subscribers_url":"https://api.github.com/repos/atomiks/popper.js/subscribers","subscription_url":"https://api.github.com/repos/atomiks/popper.js/subscription","commits_url":"https://api.github.com/repos/atomiks/popper.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomiks/popper.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomiks/popper.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomiks/popper.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomiks/popper.js/contents/{+path}","compare_url":"https://api.github.com/repos/atomiks/popper.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomiks/popper.js/merges","archive_url":"https://api.github.com/repos/atomiks/popper.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomiks/popper.js/downloads","issues_url":"https://api.github.com/repos/atomiks/popper.js/issues{/number}","pulls_url":"https://api.github.com/repos/atomiks/popper.js/pulls{/number}","milestones_url":"https://api.github.com/repos/atomiks/popper.js/milestones{/number}","notifications_url":"https://api.github.com/repos/atomiks/popper.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomiks/popper.js/labels{/name}","releases_url":"https://api.github.com/repos/atomiks/popper.js/releases{/id}","deployments_url":"https://api.github.com/repos/atomiks/popper.js/deployments","created_at":"2018-11-16T11:39:23Z","updated_at":"2019-11-22T09:52:12Z","pushed_at":"2019-12-07T08:48:28Z","git_url":"git://github.com/atomiks/popper.js.git","ssh_url":"git@github.com:atomiks/popper.js.git","clone_url":"https://github.com/atomiks/popper.js.git","svn_url":"https://github.com/atomiks/popper.js","homepage":"https://popper.js.org","size":6478,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"popperjs:next","ref":"next","sha":"b8e0c218f4d9bd215aa4722f74cafb6fe249a50d","user":{"login":"popperjs","id":58035617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MDM1NjE3","avatar_url":"https://avatars3.githubusercontent.com/u/58035617?v=4","gravatar_id":"","url":"https://api.github.com/users/popperjs","html_url":"https://github.com/popperjs","followers_url":"https://api.github.com/users/popperjs/followers","following_url":"https://api.github.com/users/popperjs/following{/other_user}","gists_url":"https://api.github.com/users/popperjs/gists{/gist_id}","starred_url":"https://api.github.com/users/popperjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popperjs/subscriptions","organizations_url":"https://api.github.com/users/popperjs/orgs","repos_url":"https://api.github.com/users/popperjs/repos","events_url":"https://api.github.com/users/popperjs/events{/privacy}","received_events_url":"https://api.github.com/users/popperjs/received_events","type":"Organization","site_admin":false},"repo":{"id":54994103,"node_id":"MDEwOlJlcG9zaXRvcnk1NDk5NDEwMw==","name":"popper.js","full_name":"popperjs/popper.js","private":false,"owner":{"login":"popperjs","id":58035617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MDM1NjE3","avatar_url":"https://avatars3.githubusercontent.com/u/58035617?v=4","gravatar_id":"","url":"https://api.github.com/users/popperjs","html_url":"https://github.com/popperjs","followers_url":"https://api.github.com/users/popperjs/followers","following_url":"https://api.github.com/users/popperjs/following{/other_user}","gists_url":"https://api.github.com/users/popperjs/gists{/gist_id}","starred_url":"https://api.github.com/users/popperjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popperjs/subscriptions","organizations_url":"https://api.github.com/users/popperjs/orgs","repos_url":"https://api.github.com/users/popperjs/repos","events_url":"https://api.github.com/users/popperjs/events{/privacy}","received_events_url":"https://api.github.com/users/popperjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/popperjs/popper.js","description":"A kickass library to manage your poppers","fork":false,"url":"https://api.github.com/repos/popperjs/popper.js","forks_url":"https://api.github.com/repos/popperjs/popper.js/forks","keys_url":"https://api.github.com/repos/popperjs/popper.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/popperjs/popper.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/popperjs/popper.js/teams","hooks_url":"https://api.github.com/repos/popperjs/popper.js/hooks","issue_events_url":"https://api.github.com/repos/popperjs/popper.js/issues/events{/number}","events_url":"https://api.github.com/repos/popperjs/popper.js/events","assignees_url":"https://api.github.com/repos/popperjs/popper.js/assignees{/user}","branches_url":"https://api.github.com/repos/popperjs/popper.js/branches{/branch}","tags_url":"https://api.github.com/repos/popperjs/popper.js/tags","blobs_url":"https://api.github.com/repos/popperjs/popper.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/popperjs/popper.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/popperjs/popper.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/popperjs/popper.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/popperjs/popper.js/statuses/{sha}","languages_url":"https://api.github.com/repos/popperjs/popper.js/languages","stargazers_url":"https://api.github.com/repos/popperjs/popper.js/stargazers","contributors_url":"https://api.github.com/repos/popperjs/popper.js/contributors","subscribers_url":"https://api.github.com/repos/popperjs/popper.js/subscribers","subscription_url":"https://api.github.com/repos/popperjs/popper.js/subscription","commits_url":"https://api.github.com/repos/popperjs/popper.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/popperjs/popper.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/popperjs/popper.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/popperjs/popper.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/popperjs/popper.js/contents/{+path}","compare_url":"https://api.github.com/repos/popperjs/popper.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/popperjs/popper.js/merges","archive_url":"https://api.github.com/repos/popperjs/popper.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/popperjs/popper.js/downloads","issues_url":"https://api.github.com/repos/popperjs/popper.js/issues{/number}","pulls_url":"https://api.github.com/repos/popperjs/popper.js/pulls{/number}","milestones_url":"https://api.github.com/repos/popperjs/popper.js/milestones{/number}","notifications_url":"https://api.github.com/repos/popperjs/popper.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/popperjs/popper.js/labels{/name}","releases_url":"https://api.github.com/repos/popperjs/popper.js/releases{/id}","deployments_url":"https://api.github.com/repos/popperjs/popper.js/deployments","created_at":"2016-03-29T17:00:47Z","updated_at":"2019-12-07T05:46:29Z","pushed_at":"2019-12-07T03:41:55Z","git_url":"git://github.com/popperjs/popper.js.git","ssh_url":"git@github.com:popperjs/popper.js.git","clone_url":"https://github.com/popperjs/popper.js.git","svn_url":"https://github.com/popperjs/popper.js","homepage":"https://popper.js.org","size":6297,"stargazers_count":13258,"watchers_count":13258,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":925,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":60,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":925,"open_issues":60,"watchers":13258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/popperjs/popper.js/pulls/877"},"html":{"href":"https://github.com/popperjs/popper.js/pull/877"},"issue":{"href":"https://api.github.com/repos/popperjs/popper.js/issues/877"},"comments":{"href":"https://api.github.com/repos/popperjs/popper.js/issues/877/comments"},"review_comments":{"href":"https://api.github.com/repos/popperjs/popper.js/pulls/877/comments"},"review_comment":{"href":"https://api.github.com/repos/popperjs/popper.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/popperjs/popper.js/pulls/877/commits"},"statuses":{"href":"https://api.github.com/repos/popperjs/popper.js/statuses/f31b6658a8283ff0355da486c6ba522cb6de026c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":174,"deletions":16,"changed_files":8}}
{"actor":{"display_login":"atomiks"}}