{"action":"closed","number":3507,"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/3507","id":352239553,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyMjM5NTUz","html_url":"https://github.com/apache/carbondata/pull/3507","diff_url":"https://github.com/apache/carbondata/pull/3507.diff","patch_url":"https://github.com/apache/carbondata/pull/3507.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/3507","number":3507,"state":"closed","locked":false,"title":"[CARBONDATA-3617] loadDataUsingGlobalSort should based on SortColumns…","user":{"login":"marchpure","id":5616456,"node_id":"MDQ6VXNlcjU2MTY0NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5616456?v=4","gravatar_id":"","url":"https://api.github.com/users/marchpure","html_url":"https://github.com/marchpure","followers_url":"https://api.github.com/users/marchpure/followers","following_url":"https://api.github.com/users/marchpure/following{/other_user}","gists_url":"https://api.github.com/users/marchpure/gists{/gist_id}","starred_url":"https://api.github.com/users/marchpure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marchpure/subscriptions","organizations_url":"https://api.github.com/users/marchpure/orgs","repos_url":"https://api.github.com/users/marchpure/repos","events_url":"https://api.github.com/users/marchpure/events{/privacy}","received_events_url":"https://api.github.com/users/marchpure/received_events","type":"User","site_admin":false},"body":"… Instead Of Whole CarbonRow\r\n\r\nModification reason: During loading Data usesing globalsort, the sortby processing is based the whole carbon row, the overhead of gc is huge when there are many columns. Theoretically, the sortby processing can works well just based on the sort columns, which will brings less time overhead and gc overhead.\r\n\r\nModification content: In case of loadDataUsingGlobalSort, the first parameter of rdd.sortby is changed to CarbonRow.getKey from CarbonRow.getData. In CarbonRow.getKey, we get the sortcolumns of CarbonRow\r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [ ] Any interfaces changed?\r\n \r\n - [ ] Any backward compatibility impacted?\r\n \r\n - [ ] Document update required?\r\n\r\n - [ ] Testing done\r\n        Please provide details on \r\n        - Whether new unit test cases have been added or why no new tests are required?\r\n        - How it is tested? Please attach test report.\r\n        - Is it a performance related change? Please attach the performance test report.\r\n        - Any additional information to help reviewers in testing this change.\r\n       \r\n - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\n\r\n","created_at":"2019-12-12T05:30:37Z","updated_at":"2019-12-29T23:37:06Z","closed_at":"2019-12-29T23:37:06Z","merged_at":null,"merge_commit_sha":"ce6623bdfa0141c1e068676926823a9ec0a8fbdf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/3507/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/3507/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/3507/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/6c489bd0c865650b0cc0e7a6ffc5ee54846f7045","head":{"label":"marchpure:master","ref":"master","sha":"6c489bd0c865650b0cc0e7a6ffc5ee54846f7045","user":{"login":"marchpure","id":5616456,"node_id":"MDQ6VXNlcjU2MTY0NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5616456?v=4","gravatar_id":"","url":"https://api.github.com/users/marchpure","html_url":"https://github.com/marchpure","followers_url":"https://api.github.com/users/marchpure/followers","following_url":"https://api.github.com/users/marchpure/following{/other_user}","gists_url":"https://api.github.com/users/marchpure/gists{/gist_id}","starred_url":"https://api.github.com/users/marchpure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marchpure/subscriptions","organizations_url":"https://api.github.com/users/marchpure/orgs","repos_url":"https://api.github.com/users/marchpure/repos","events_url":"https://api.github.com/users/marchpure/events{/privacy}","received_events_url":"https://api.github.com/users/marchpure/received_events","type":"User","site_admin":false},"repo":{"id":222347069,"node_id":"MDEwOlJlcG9zaXRvcnkyMjIzNDcwNjk=","name":"carbondata","full_name":"marchpure/carbondata","private":false,"owner":{"login":"marchpure","id":5616456,"node_id":"MDQ6VXNlcjU2MTY0NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5616456?v=4","gravatar_id":"","url":"https://api.github.com/users/marchpure","html_url":"https://github.com/marchpure","followers_url":"https://api.github.com/users/marchpure/followers","following_url":"https://api.github.com/users/marchpure/following{/other_user}","gists_url":"https://api.github.com/users/marchpure/gists{/gist_id}","starred_url":"https://api.github.com/users/marchpure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marchpure/subscriptions","organizations_url":"https://api.github.com/users/marchpure/orgs","repos_url":"https://api.github.com/users/marchpure/repos","events_url":"https://api.github.com/users/marchpure/events{/privacy}","received_events_url":"https://api.github.com/users/marchpure/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marchpure/carbondata","description":"Mirror of Apache CarbonData","fork":true,"url":"https://api.github.com/repos/marchpure/carbondata","forks_url":"https://api.github.com/repos/marchpure/carbondata/forks","keys_url":"https://api.github.com/repos/marchpure/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marchpure/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marchpure/carbondata/teams","hooks_url":"https://api.github.com/repos/marchpure/carbondata/hooks","issue_events_url":"https://api.github.com/repos/marchpure/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/marchpure/carbondata/events","assignees_url":"https://api.github.com/repos/marchpure/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/marchpure/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/marchpure/carbondata/tags","blobs_url":"https://api.github.com/repos/marchpure/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marchpure/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marchpure/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/marchpure/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marchpure/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/marchpure/carbondata/languages","stargazers_url":"https://api.github.com/repos/marchpure/carbondata/stargazers","contributors_url":"https://api.github.com/repos/marchpure/carbondata/contributors","subscribers_url":"https://api.github.com/repos/marchpure/carbondata/subscribers","subscription_url":"https://api.github.com/repos/marchpure/carbondata/subscription","commits_url":"https://api.github.com/repos/marchpure/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/marchpure/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/marchpure/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/marchpure/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/marchpure/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/marchpure/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marchpure/carbondata/merges","archive_url":"https://api.github.com/repos/marchpure/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marchpure/carbondata/downloads","issues_url":"https://api.github.com/repos/marchpure/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/marchpure/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/marchpure/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/marchpure/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marchpure/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/marchpure/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/marchpure/carbondata/deployments","created_at":"2019-11-18T02:28:37Z","updated_at":"2019-12-28T01:37:22Z","pushed_at":"2019-12-29T23:33:44Z","git_url":"git://github.com/marchpure/carbondata.git","ssh_url":"git@github.com:marchpure/carbondata.git","clone_url":"https://github.com/marchpure/carbondata.git","svn_url":"https://github.com/marchpure/carbondata","homepage":"","size":72820,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2c0a1e0241463110b10ccf65efce41fb7c8bb9d3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxOA==","name":"carbondata","full_name":"apache/carbondata","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2019-12-29T12:11:48Z","pushed_at":"2019-12-29T23:35:38Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":72931,"stargazers_count":1006,"watchers_count":1006,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":586,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":142,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":586,"open_issues":142,"watchers":1006,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/3507"},"html":{"href":"https://github.com/apache/carbondata/pull/3507"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/3507"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/3507/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/3507/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/3507/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/6c489bd0c865650b0cc0e7a6ffc5ee54846f7045"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":26,"review_comments":8,"maintainer_can_modify":false,"commits":16,"additions":1922,"deletions":16230,"changed_files":197}}
{"actor":{"display_login":"marchpure"}}