{"action":"created","issue":{"url":"https://api.github.com/repos/helm/helm-2to3/issues/98","repository_url":"https://api.github.com/repos/helm/helm-2to3","labels_url":"https://api.github.com/repos/helm/helm-2to3/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/helm/helm-2to3/issues/98/comments","events_url":"https://api.github.com/repos/helm/helm-2to3/issues/98/events","html_url":"https://github.com/helm/helm-2to3/issues/98","id":532369696,"node_id":"MDU6SXNzdWU1MzIzNjk2OTY=","number":98,"title":"`move` creates plugin symlinks which are removed by `cleanup`","user":{"login":"timfallmk","id":5316117,"node_id":"MDQ6VXNlcjUzMTYxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5316117?v=4","gravatar_id":"","url":"https://api.github.com/users/timfallmk","html_url":"https://github.com/timfallmk","followers_url":"https://api.github.com/users/timfallmk/followers","following_url":"https://api.github.com/users/timfallmk/following{/other_user}","gists_url":"https://api.github.com/users/timfallmk/gists{/gist_id}","starred_url":"https://api.github.com/users/timfallmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timfallmk/subscriptions","organizations_url":"https://api.github.com/users/timfallmk/orgs","repos_url":"https://api.github.com/users/timfallmk/repos","events_url":"https://api.github.com/users/timfallmk/events{/privacy}","received_events_url":"https://api.github.com/users/timfallmk/received_events","type":"User","site_admin":false},"labels":[{"id":1487661262,"node_id":"MDU6TGFiZWwxNDg3NjYxMjYy","url":"https://api.github.com/repos/helm/helm-2to3/labels/bug","name":"bug","color":"d73a4a","default":true,"description":"Something isn't working"}],"state":"open","locked":false,"assignee":{"login":"hickeyma","id":14892004,"node_id":"MDQ6VXNlcjE0ODkyMDA0","avatar_url":"https://avatars3.githubusercontent.com/u/14892004?v=4","gravatar_id":"","url":"https://api.github.com/users/hickeyma","html_url":"https://github.com/hickeyma","followers_url":"https://api.github.com/users/hickeyma/followers","following_url":"https://api.github.com/users/hickeyma/following{/other_user}","gists_url":"https://api.github.com/users/hickeyma/gists{/gist_id}","starred_url":"https://api.github.com/users/hickeyma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hickeyma/subscriptions","organizations_url":"https://api.github.com/users/hickeyma/orgs","repos_url":"https://api.github.com/users/hickeyma/repos","events_url":"https://api.github.com/users/hickeyma/events{/privacy}","received_events_url":"https://api.github.com/users/hickeyma/received_events","type":"User","site_admin":false},"assignees":[{"login":"hickeyma","id":14892004,"node_id":"MDQ6VXNlcjE0ODkyMDA0","avatar_url":"https://avatars3.githubusercontent.com/u/14892004?v=4","gravatar_id":"","url":"https://api.github.com/users/hickeyma","html_url":"https://github.com/hickeyma","followers_url":"https://api.github.com/users/hickeyma/followers","following_url":"https://api.github.com/users/hickeyma/following{/other_user}","gists_url":"https://api.github.com/users/hickeyma/gists{/gist_id}","starred_url":"https://api.github.com/users/hickeyma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hickeyma/subscriptions","organizations_url":"https://api.github.com/users/hickeyma/orgs","repos_url":"https://api.github.com/users/hickeyma/repos","events_url":"https://api.github.com/users/hickeyma/events{/privacy}","received_events_url":"https://api.github.com/users/hickeyma/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2019-12-04T00:58:42Z","updated_at":"2019-12-06T16:20:02Z","closed_at":null,"author_association":"NONE","body":"I ran the migration steps as intended and ended up with broken plugins. It seems that the `2to3 move` step creates symlinks to existing plugins (which are later cleaned up) in the new plugin directory.\r\n\r\n```\r\nlrwxr-xr-x  1 tfall  staff  72 Dec  3 09:22 helm-2to3 -> /Users/tfall/Library/Caches/helm/plugins/https-github.com-helm-helm-2to3\r\nlrwxr-xr-x  1 tfall  staff  69 Dec  3 16:08 helm-diff -> /Users/tfall/.helm/cache/plugins/https-github.com-databus23-helm-diff\r\nlrwxr-xr-x  1 tfall  staff  68 Dec  3 16:08 helm-edit -> /Users/tfall/.helm/cache/plugins/https-github.com-mstrzele-helm-edit\r\nlrwxr-xr-x  1 tfall  staff  68 Dec  3 16:08 helm-env -> /Users/tfall/.helm/cache/plugins/https-github.com-adamreese-helm-env\r\nlrwxr-xr-x  1 tfall  staff  65 Dec  3 16:08 helm-gcs -> /Users/tfall/.helm/cache/plugins/https-github.com-nouney-helm-gcs\r\nlrwxr-xr-x  1 tfall  staff  74 Dec  3 16:08 helm-github -> /Users/tfall/.helm/cache/plugins/https-github.com-technosophos-helm-github\r\nlrwxr-xr-x  1 tfall  staff  71 Dec  3 16:08 helm-gpg -> /Users/tfall/.helm/cache/plugins/https-github.com-technosophos-helm-gpg\r\nlrwxr-xr-x  1 tfall  staff  70 Dec  3 16:08 helm-hashtag -> /Users/tfall/.helm/cache/plugins/https-github.com-balboah-helm-hashtag\r\nlrwxr-xr-x  1 tfall  staff  75 Dec  3 16:08 helm-keybase -> /Users/tfall/.helm/cache/plugins/https-github.com-technosophos-helm-keybase\r\nlrwxr-xr-x  1 tfall  staff  69 Dec  3 16:08 helm-last -> /Users/tfall/.helm/cache/plugins/https-github.com-adamreese-helm-last\r\nlrwxr-xr-x  1 tfall  staff  66 Dec  3 16:08 helm-logs -> /Users/tfall/.helm/cache/plugins/https-github.com-maorfr-helm-logs\r\nlrwxr-xr-x  1 tfall  staff  69 Dec  3 16:08 helm-nuke -> /Users/tfall/.helm/cache/plugins/https-github.com-adamreese-helm-nuke\r\nlrwxr-xr-x  1 tfall  staff  67 Dec  3 16:08 helm-s3 -> /Users/tfall/.helm/cache/plugins/https-github.com-hypnoglow-helm-s3\r\nlrwxr-xr-x  1 tfall  staff  75 Dec  3 16:08 helm-secrets -> /Users/tfall/.helm/cache/plugins/https-github.com-futuresimple-helm-secrets\r\nlrwxr-xr-x  1 tfall  staff  63 Dec  3 16:08 helm-stop -> /Users/tfall/.helm/cache/plugins/https-github.com-IBM-helm-stop\r\nlrwxr-xr-x  1 tfall  staff  76 Dec  3 16:08 helm-template -> /Users/tfall/.helm/cache/plugins/https-github.com-technosophos-helm-template\r\nlrwxr-xr-x  1 tfall  staff  71 Dec  3 16:08 helm-tiller -> /Users/tfall/.helm/cache/plugins/https-github.com-adamreese-helm-tiller\r\nlrwxr-xr-x  1 tfall  staff  73 Dec  3 16:08 helm-tiller-info -> /Users/tfall/.helm/cache/plugins/https-github.com-maorfr-helm-tiller-info\r\nlrwxr-xr-x  1 tfall  staff  74 Dec  3 16:08 helm-whatup -> /Users/tfall/.helm/cache/plugins/https-github.com-bacongobbler-helm-whatup\r\n```\r\nYou can see newly installed plugins (`2to3`) are installed to the correct location, but plugin _binaries_ are not moved for existing plugins.\r\n\r\nAt this point `helm plugins list` will show all plugins, as intended. Plugins can also be used.\r\n\r\nWhen running the `2to3 clean` step, the `~/.helm` directory is removed, along with previously installed plugin binaries. This leaves the symlinks in the new plugins directory pointing to nothing and the user can no longer access their (old) plugins.\r\n\r\nAdditionally, if the user runs `helm plugin list` now they won't see any of the previously installed plugins. Without knowing the cause, if the user runs `helm plugin install <url>` in an attempt to reinstall the \"missing\" plugins, the command will error out `symlink exists`.\r\n\r\n**Edit**: `helm plugin remove` will also error out. The symlinks must be removed manually in order for the plugin to be reinstalled with `helm plugin install`."},"comment":{"url":"https://api.github.com/repos/helm/helm-2to3/issues/comments/562638972","html_url":"https://github.com/helm/helm-2to3/issues/98#issuecomment-562638972","issue_url":"https://api.github.com/repos/helm/helm-2to3/issues/98","id":562638972,"node_id":"MDEyOklzc3VlQ29tbWVudDU2MjYzODk3Mg==","user":{"login":"hickeyma","id":14892004,"node_id":"MDQ6VXNlcjE0ODkyMDA0","avatar_url":"https://avatars3.githubusercontent.com/u/14892004?v=4","gravatar_id":"","url":"https://api.github.com/users/hickeyma","html_url":"https://github.com/hickeyma","followers_url":"https://api.github.com/users/hickeyma/followers","following_url":"https://api.github.com/users/hickeyma/following{/other_user}","gists_url":"https://api.github.com/users/hickeyma/gists{/gist_id}","starred_url":"https://api.github.com/users/hickeyma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hickeyma/subscriptions","organizations_url":"https://api.github.com/users/hickeyma/orgs","repos_url":"https://api.github.com/users/hickeyma/repos","events_url":"https://api.github.com/users/hickeyma/events{/privacy}","received_events_url":"https://api.github.com/users/hickeyma/received_events","type":"User","site_admin":false},"created_at":"2019-12-06T16:20:02Z","updated_at":"2019-12-06T16:20:02Z","author_association":"COLLABORATOR","body":"@timfallmk Thanks for find this issue. I have push PR #100 as a fix. If you get a chance, can you try it out and see if it fixes the issue?"}}
{"actor":{"display_login":"hickeyma"}}