{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/comments/293997173","pull_request_review_id":250134496,"id":293997173,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5Mzk5NzE3Mw==","diff_hunk":"@@ -278,6 +287,20 @@ metadata:\n   name: config\n `\n \n+// JoinConfigTemplate is the kubadm join config template\n+const JoinConfigTemplate = `# config generated by kind\n+# no-op entry that exists solely so it can be patched\n+apiVersion: kubeadm.k8s.io/{{ .KubedamAPI }}","path":"pkg/cluster/internal/kubeadm/config.go","position":null,"original_position":23,"commit_id":"f0fbf82d45d218d1ce86a72490e1c9d18b8ce6e6","original_commit_id":"b849566e693300a63e6e567998c791f6c2555cd3","user":{"login":"neolit123","id":331852,"node_id":"MDQ6VXNlcjMzMTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"body":"i think we can pass the same kubeadm.cfg to both init and join (with the multi-yaml doc; `---` separated). i was under the impression we are already doing that.\r\n","created_at":"2019-06-14T21:24:19Z","updated_at":"2019-06-14T21:24:19Z","html_url":"https://github.com/kubernetes-sigs/kind/pull/616#discussion_r293997173","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/616","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/comments/293997173"},"html":{"href":"https://github.com/kubernetes-sigs/kind/pull/616#discussion_r293997173"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/616"}},"in_reply_to_id":293974476},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/616","id":288400879,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NDAwODc5","html_url":"https://github.com/kubernetes-sigs/kind/pull/616","diff_url":"https://github.com/kubernetes-sigs/kind/pull/616.diff","patch_url":"https://github.com/kubernetes-sigs/kind/pull/616.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/kind/issues/616","number":616,"state":"open","locked":false,"title":"WIP Use config file to join nodes to the cluster","user":{"login":"aojea","id":6450081,"node_id":"MDQ6VXNlcjY0NTAwODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6450081?v=4","gravatar_id":"","url":"https://api.github.com/users/aojea","html_url":"https://github.com/aojea","followers_url":"https://api.github.com/users/aojea/followers","following_url":"https://api.github.com/users/aojea/following{/other_user}","gists_url":"https://api.github.com/users/aojea/gists{/gist_id}","starred_url":"https://api.github.com/users/aojea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aojea/subscriptions","organizations_url":"https://api.github.com/users/aojea/orgs","repos_url":"https://api.github.com/users/aojea/repos","events_url":"https://api.github.com/users/aojea/events{/privacy}","received_events_url":"https://api.github.com/users/aojea/received_events","type":"User","site_admin":false},"body":"This avoids having to write configuration files on runtime, however, seems that the control plane nodes can't use it","created_at":"2019-06-14T16:28:45Z","updated_at":"2019-06-14T21:24:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94c06174c02561cde5010fabb61479aaab483530","assignee":{"login":"BenTheElder","id":917931,"node_id":"MDQ6VXNlcjkxNzkzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"assignees":[{"login":"neolit123","id":331852,"node_id":"MDQ6VXNlcjMzMTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},{"login":"BenTheElder","id":917931,"node_id":"MDQ6VXNlcjkxNzkzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"amwat","id":22800763,"node_id":"MDQ6VXNlcjIyODAwNzYz","avatar_url":"https://avatars1.githubusercontent.com/u/22800763?v=4","gravatar_id":"","url":"https://api.github.com/users/amwat","html_url":"https://github.com/amwat","followers_url":"https://api.github.com/users/amwat/followers","following_url":"https://api.github.com/users/amwat/following{/other_user}","gists_url":"https://api.github.com/users/amwat/gists{/gist_id}","starred_url":"https://api.github.com/users/amwat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amwat/subscriptions","organizations_url":"https://api.github.com/users/amwat/orgs","repos_url":"https://api.github.com/users/amwat/repos","events_url":"https://api.github.com/users/amwat/events{/privacy}","received_events_url":"https://api.github.com/users/amwat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1054945752,"node_id":"MDU6TGFiZWwxMDU0OTQ1NzUy","url":"https://api.github.com/repos/kubernetes-sigs/kind/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1054954293,"node_id":"MDU6TGFiZWwxMDU0OTU0Mjkz","url":"https://api.github.com/repos/kubernetes-sigs/kind/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":1054954257,"node_id":"MDU6TGFiZWwxMDU0OTU0MjU3","url":"https://api.github.com/repos/kubernetes-sigs/kind/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/616/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/616/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kind/issues/616/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/kind/statuses/f0fbf82d45d218d1ce86a72490e1c9d18b8ce6e6","head":{"label":"aojea:kubeadmjoin","ref":"kubeadmjoin","sha":"f0fbf82d45d218d1ce86a72490e1c9d18b8ce6e6","user":{"login":"aojea","id":6450081,"node_id":"MDQ6VXNlcjY0NTAwODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6450081?v=4","gravatar_id":"","url":"https://api.github.com/users/aojea","html_url":"https://github.com/aojea","followers_url":"https://api.github.com/users/aojea/followers","following_url":"https://api.github.com/users/aojea/following{/other_user}","gists_url":"https://api.github.com/users/aojea/gists{/gist_id}","starred_url":"https://api.github.com/users/aojea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aojea/subscriptions","organizations_url":"https://api.github.com/users/aojea/orgs","repos_url":"https://api.github.com/users/aojea/repos","events_url":"https://api.github.com/users/aojea/events{/privacy}","received_events_url":"https://api.github.com/users/aojea/received_events","type":"User","site_admin":false},"repo":{"id":171760991,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE3NjA5OTE=","name":"kind","full_name":"aojea/kind","private":false,"owner":{"login":"aojea","id":6450081,"node_id":"MDQ6VXNlcjY0NTAwODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6450081?v=4","gravatar_id":"","url":"https://api.github.com/users/aojea","html_url":"https://github.com/aojea","followers_url":"https://api.github.com/users/aojea/followers","following_url":"https://api.github.com/users/aojea/following{/other_user}","gists_url":"https://api.github.com/users/aojea/gists{/gist_id}","starred_url":"https://api.github.com/users/aojea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aojea/subscriptions","organizations_url":"https://api.github.com/users/aojea/orgs","repos_url":"https://api.github.com/users/aojea/repos","events_url":"https://api.github.com/users/aojea/events{/privacy}","received_events_url":"https://api.github.com/users/aojea/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aojea/kind","description":"Kubernetes IN Docker - local clusters for testing Kubernetes","fork":true,"url":"https://api.github.com/repos/aojea/kind","forks_url":"https://api.github.com/repos/aojea/kind/forks","keys_url":"https://api.github.com/repos/aojea/kind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aojea/kind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aojea/kind/teams","hooks_url":"https://api.github.com/repos/aojea/kind/hooks","issue_events_url":"https://api.github.com/repos/aojea/kind/issues/events{/number}","events_url":"https://api.github.com/repos/aojea/kind/events","assignees_url":"https://api.github.com/repos/aojea/kind/assignees{/user}","branches_url":"https://api.github.com/repos/aojea/kind/branches{/branch}","tags_url":"https://api.github.com/repos/aojea/kind/tags","blobs_url":"https://api.github.com/repos/aojea/kind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aojea/kind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aojea/kind/git/refs{/sha}","trees_url":"https://api.github.com/repos/aojea/kind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aojea/kind/statuses/{sha}","languages_url":"https://api.github.com/repos/aojea/kind/languages","stargazers_url":"https://api.github.com/repos/aojea/kind/stargazers","contributors_url":"https://api.github.com/repos/aojea/kind/contributors","subscribers_url":"https://api.github.com/repos/aojea/kind/subscribers","subscription_url":"https://api.github.com/repos/aojea/kind/subscription","commits_url":"https://api.github.com/repos/aojea/kind/commits{/sha}","git_commits_url":"https://api.github.com/repos/aojea/kind/git/commits{/sha}","comments_url":"https://api.github.com/repos/aojea/kind/comments{/number}","issue_comment_url":"https://api.github.com/repos/aojea/kind/issues/comments{/number}","contents_url":"https://api.github.com/repos/aojea/kind/contents/{+path}","compare_url":"https://api.github.com/repos/aojea/kind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aojea/kind/merges","archive_url":"https://api.github.com/repos/aojea/kind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aojea/kind/downloads","issues_url":"https://api.github.com/repos/aojea/kind/issues{/number}","pulls_url":"https://api.github.com/repos/aojea/kind/pulls{/number}","milestones_url":"https://api.github.com/repos/aojea/kind/milestones{/number}","notifications_url":"https://api.github.com/repos/aojea/kind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aojea/kind/labels{/name}","releases_url":"https://api.github.com/repos/aojea/kind/releases{/id}","deployments_url":"https://api.github.com/repos/aojea/kind/deployments","created_at":"2019-02-20T22:44:58Z","updated_at":"2019-03-18T10:11:19Z","pushed_at":"2019-06-14T16:30:33Z","git_url":"git://github.com/aojea/kind.git","ssh_url":"git@github.com:aojea/kind.git","clone_url":"https://github.com/aojea/kind.git","svn_url":"https://github.com/aojea/kind","homepage":"https://kind.sigs.k8s.io/","size":9125,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"cdf9183fa11d3092c85cf773a0ca6e3b49d83dff","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":148545807,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1NDU4MDc=","name":"kind","full_name":"kubernetes-sigs/kind","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/kind","description":"Kubernetes IN Docker - local clusters for testing Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/kind","forks_url":"https://api.github.com/repos/kubernetes-sigs/kind/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/kind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/kind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/kind/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/kind/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/kind/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/kind/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/kind/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/kind/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/kind/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/kind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/kind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/kind/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/kind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/kind/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/kind/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/kind/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/kind/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/kind/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/kind/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/kind/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/kind/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kind/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/kind/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/kind/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/kind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/kind/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/kind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/kind/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/kind/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/kind/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/kind/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/kind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/kind/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/kind/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/kind/deployments","created_at":"2018-09-12T21:45:05Z","updated_at":"2019-06-14T21:09:41Z","pushed_at":"2019-06-14T16:30:34Z","git_url":"git://github.com/kubernetes-sigs/kind.git","ssh_url":"git@github.com:kubernetes-sigs/kind.git","clone_url":"https://github.com/kubernetes-sigs/kind.git","svn_url":"https://github.com/kubernetes-sigs/kind","homepage":"https://kind.sigs.k8s.io/","size":8847,"stargazers_count":2132,"watchers_count":2132,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":221,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":73,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":221,"open_issues":73,"watchers":2132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/616"},"html":{"href":"https://github.com/kubernetes-sigs/kind/pull/616"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/kind/issues/616"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/kind/issues/616/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/616/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/kind/pulls/616/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/kind/statuses/f0fbf82d45d218d1ce86a72490e1c9d18b8ce6e6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"neolit123"}}