{"action":"created","issue":{"url":"https://api.github.com/repos/cloudalchemy/ansible-prometheus/issues/245","repository_url":"https://api.github.com/repos/cloudalchemy/ansible-prometheus","labels_url":"https://api.github.com/repos/cloudalchemy/ansible-prometheus/issues/245/labels{/name}","comments_url":"https://api.github.com/repos/cloudalchemy/ansible-prometheus/issues/245/comments","events_url":"https://api.github.com/repos/cloudalchemy/ansible-prometheus/issues/245/events","html_url":"https://github.com/cloudalchemy/ansible-prometheus/issues/245","id":525032527,"node_id":"MDU6SXNzdWU1MjUwMzI1Mjc=","number":245,"title":"Download process for binaries ","user":{"login":"th31nitiate","id":14749635,"node_id":"MDQ6VXNlcjE0NzQ5NjM1","avatar_url":"https://avatars3.githubusercontent.com/u/14749635?v=4","gravatar_id":"","url":"https://api.github.com/users/th31nitiate","html_url":"https://github.com/th31nitiate","followers_url":"https://api.github.com/users/th31nitiate/followers","following_url":"https://api.github.com/users/th31nitiate/following{/other_user}","gists_url":"https://api.github.com/users/th31nitiate/gists{/gist_id}","starred_url":"https://api.github.com/users/th31nitiate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/th31nitiate/subscriptions","organizations_url":"https://api.github.com/users/th31nitiate/orgs","repos_url":"https://api.github.com/users/th31nitiate/repos","events_url":"https://api.github.com/users/th31nitiate/events{/privacy}","received_events_url":"https://api.github.com/users/th31nitiate/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-11-19T14:08:32Z","updated_at":"2019-11-19T14:16:53Z","closed_at":null,"author_association":"NONE","body":"I love the playbook it works perfectly and I truly appreciate the work. I have a question around the download process. I understand that it downloads and works with archives locally. \r\n\r\nI was wondering why you do not download the archives in the remote system. This some like for some it would be a suitable solution. I can understand the requirement for your method when working in air gap like networks or when you have multiple nodes. \r\n\r\nIn my current environment it may be beneficial to have the choice of both. Please let me know if you would be interested in PR to add a toggle ?"},"comment":{"url":"https://api.github.com/repos/cloudalchemy/ansible-prometheus/issues/comments/555526826","html_url":"https://github.com/cloudalchemy/ansible-prometheus/issues/245#issuecomment-555526826","issue_url":"https://api.github.com/repos/cloudalchemy/ansible-prometheus/issues/245","id":555526826,"node_id":"MDEyOklzc3VlQ29tbWVudDU1NTUyNjgyNg==","user":{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false},"created_at":"2019-11-19T14:16:53Z","updated_at":"2019-11-19T14:16:53Z","author_association":"MEMBER","body":"There are multiple reasons for downloading binary to deployer host and propagating it:\r\n1) easier to deploy in air-gap networks\r\n2) download once - propagate to many scales well in systems with multiple hosts. This may not be ideal for prometheus itself and more necessary for things like node-exporter. But for the sake of simplicity and easier maintainability we didn't want to diverge.\r\n3) code reuse for propagating custom binaries (flag `prometheus_binaries_local_dir`). Which means installation path is the same for custom binary and \"official\" ones and that gives us better test coverage.\r\n\r\nWhat would be the benefit of doing it directly on target host without downloading binary to deployer host beforehand?"}}
{"actor":{"display_login":"paulfantom"}}