{"action":"created","issue":{"url":"https://api.github.com/repos/code-squad/javascript-amazon/issues/78","repository_url":"https://api.github.com/repos/code-squad/javascript-amazon","labels_url":"https://api.github.com/repos/code-squad/javascript-amazon/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/code-squad/javascript-amazon/issues/78/comments","events_url":"https://api.github.com/repos/code-squad/javascript-amazon/issues/78/events","html_url":"https://github.com/code-squad/javascript-amazon/pull/78","id":464700624,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0OTI1MDMx","number":78,"title":"[Michelle] Step14-1 검토 부탁드립니다. ","user":{"login":"leehwarang","id":18614517,"node_id":"MDQ6VXNlcjE4NjE0NTE3","avatar_url":"https://avatars2.githubusercontent.com/u/18614517?v=4","gravatar_id":"","url":"https://api.github.com/users/leehwarang","html_url":"https://github.com/leehwarang","followers_url":"https://api.github.com/users/leehwarang/followers","following_url":"https://api.github.com/users/leehwarang/following{/other_user}","gists_url":"https://api.github.com/users/leehwarang/gists{/gist_id}","starred_url":"https://api.github.com/users/leehwarang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leehwarang/subscriptions","organizations_url":"https://api.github.com/users/leehwarang/orgs","repos_url":"https://api.github.com/users/leehwarang/repos","events_url":"https://api.github.com/users/leehwarang/events{/privacy}","received_events_url":"https://api.github.com/users/leehwarang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-07-05T16:02:10Z","updated_at":"2019-07-08T08:04:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/code-squad/javascript-amazon/pulls/78","html_url":"https://github.com/code-squad/javascript-amazon/pull/78","diff_url":"https://github.com/code-squad/javascript-amazon/pull/78.diff","patch_url":"https://github.com/code-squad/javascript-amazon/pull/78.patch"},"body":"- 기능 구현\r\n    - Fetch 사용하여 json 데이터 가져오기\r\n\r\n- 리팩토링\r\n    - 기존에는 Carousel과 Pagination이 서로의 객체를 가지고 있는 구조였어서 두 클래스의 의존성이 높다는 피드백을 받았습니다. **따라서 Manager 클래스를 추가로 생성하여 처음에 carousel과 pagination을 초기화 해주고, carousel의 버튼이나 pagination이 클릭 되었을 때 다시 Manager에게 알림을 주는 방식으로 수정하였습니다.**\r\n   - (참고) 옵저버 등의 패턴에 대해 공부하지 않고 생각하는대로 구현해보려고 했습니다. 하지만 이전보다 어떤 부분에서 의존성이 얼마나 줄어 들었는지 잘 모르겠어서 다음 미션 때, 패턴 공부 후 재리팩토링 해 볼 예정입니다. \r\n\r\n- 추가로 개선해야 할 점\r\n    - pagination이나 btn을 클릭하면 애니메이션이 적용되며 컨텐츠가 변경됩니다. 다만, 한 번의 애니메이션이 완료되기 전에 또 다시 클릭하는 경우에는 가끔 버그가 발생합니다. 원인 파악 후 수정하겠습니다. \r\n\r\n- 데모링크\r\n    - https://leehwarang.github.io//docs/tech/demo/step14/index.html "},"comment":{"url":"https://api.github.com/repos/code-squad/javascript-amazon/issues/comments/509122887","html_url":"https://github.com/code-squad/javascript-amazon/pull/78#issuecomment-509122887","issue_url":"https://api.github.com/repos/code-squad/javascript-amazon/issues/78","id":509122887,"node_id":"MDEyOklzc3VlQ29tbWVudDUwOTEyMjg4Nw==","user":{"login":"nigayo","id":1456761,"node_id":"MDQ6VXNlcjE0NTY3NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1456761?v=4","gravatar_id":"","url":"https://api.github.com/users/nigayo","html_url":"https://github.com/nigayo","followers_url":"https://api.github.com/users/nigayo/followers","following_url":"https://api.github.com/users/nigayo/following{/other_user}","gists_url":"https://api.github.com/users/nigayo/gists{/gist_id}","starred_url":"https://api.github.com/users/nigayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigayo/subscriptions","organizations_url":"https://api.github.com/users/nigayo/orgs","repos_url":"https://api.github.com/users/nigayo/repos","events_url":"https://api.github.com/users/nigayo/events{/privacy}","received_events_url":"https://api.github.com/users/nigayo/received_events","type":"User","site_admin":false},"created_at":"2019-07-08T08:04:45Z","updated_at":"2019-07-08T08:04:45Z","author_association":"CONTRIBUTOR","body":"가끔 생기는 버그가 찾기가 어렵죠;\r\n좋은 코드보다 기능의 완전성이 더 중요하긴해요 ^^\r\n버그가 없도록 , 본인이 구현한 코드를 더 잘 이해해보세요!  \r\n"}}
{"actor":{"display_login":"nigayo"}}