{"action":"closed","number":210,"pull_request":{"url":"https://api.github.com/repos/FluxML/Zygote.jl/pulls/210","id":284291900,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0MjkxOTAw","html_url":"https://github.com/FluxML/Zygote.jl/pull/210","diff_url":"https://github.com/FluxML/Zygote.jl/pull/210.diff","patch_url":"https://github.com/FluxML/Zygote.jl/pull/210.patch","issue_url":"https://api.github.com/repos/FluxML/Zygote.jl/issues/210","number":210,"state":"closed","locked":false,"title":"Fix and test adjoint for hvcat","user":{"login":"under-Peter","id":31702355,"node_id":"MDQ6VXNlcjMxNzAyMzU1","avatar_url":"https://avatars2.githubusercontent.com/u/31702355?v=4","gravatar_id":"","url":"https://api.github.com/users/under-Peter","html_url":"https://github.com/under-Peter","followers_url":"https://api.github.com/users/under-Peter/followers","following_url":"https://api.github.com/users/under-Peter/following{/other_user}","gists_url":"https://api.github.com/users/under-Peter/gists{/gist_id}","starred_url":"https://api.github.com/users/under-Peter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/under-Peter/subscriptions","organizations_url":"https://api.github.com/users/under-Peter/orgs","repos_url":"https://api.github.com/users/under-Peter/repos","events_url":"https://api.github.com/users/under-Peter/events{/privacy}","received_events_url":"https://api.github.com/users/under-Peter/received_events","type":"User","site_admin":false},"body":"This PR fixes the the adjoint for `hvcat`. The issue arises from \r\n```\r\njulia> (hvcat((2,2),1,2,3,4)...,) == (1,2,3,4)\r\nfalse\r\n```\r\nwhich was an implicit assumption in the implementation so far, leading to errors in functions where the arguments appear in matrices such as\r\n```\r\nfoo(x) = [x 2x; 3x 4x]\r\n```","created_at":"2019-06-01T19:12:15Z","updated_at":"2019-06-04T09:44:51Z","closed_at":"2019-06-04T09:44:51Z","merged_at":"2019-06-04T09:44:51Z","merge_commit_sha":"0bcec373855119e356c498dfe9954bfda0152dbd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FluxML/Zygote.jl/pulls/210/commits","review_comments_url":"https://api.github.com/repos/FluxML/Zygote.jl/pulls/210/comments","review_comment_url":"https://api.github.com/repos/FluxML/Zygote.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FluxML/Zygote.jl/issues/210/comments","statuses_url":"https://api.github.com/repos/FluxML/Zygote.jl/statuses/b82bdf8760cef5a5796177876e1586d331f13d1b","head":{"label":"under-Peter:fix-hvcat","ref":"fix-hvcat","sha":"b82bdf8760cef5a5796177876e1586d331f13d1b","user":{"login":"under-Peter","id":31702355,"node_id":"MDQ6VXNlcjMxNzAyMzU1","avatar_url":"https://avatars2.githubusercontent.com/u/31702355?v=4","gravatar_id":"","url":"https://api.github.com/users/under-Peter","html_url":"https://github.com/under-Peter","followers_url":"https://api.github.com/users/under-Peter/followers","following_url":"https://api.github.com/users/under-Peter/following{/other_user}","gists_url":"https://api.github.com/users/under-Peter/gists{/gist_id}","starred_url":"https://api.github.com/users/under-Peter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/under-Peter/subscriptions","organizations_url":"https://api.github.com/users/under-Peter/orgs","repos_url":"https://api.github.com/users/under-Peter/repos","events_url":"https://api.github.com/users/under-Peter/events{/privacy}","received_events_url":"https://api.github.com/users/under-Peter/received_events","type":"User","site_admin":false},"repo":{"id":189750992,"node_id":"MDEwOlJlcG9zaXRvcnkxODk3NTA5OTI=","name":"Zygote.jl","full_name":"under-Peter/Zygote.jl","private":false,"owner":{"login":"under-Peter","id":31702355,"node_id":"MDQ6VXNlcjMxNzAyMzU1","avatar_url":"https://avatars2.githubusercontent.com/u/31702355?v=4","gravatar_id":"","url":"https://api.github.com/users/under-Peter","html_url":"https://github.com/under-Peter","followers_url":"https://api.github.com/users/under-Peter/followers","following_url":"https://api.github.com/users/under-Peter/following{/other_user}","gists_url":"https://api.github.com/users/under-Peter/gists{/gist_id}","starred_url":"https://api.github.com/users/under-Peter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/under-Peter/subscriptions","organizations_url":"https://api.github.com/users/under-Peter/orgs","repos_url":"https://api.github.com/users/under-Peter/repos","events_url":"https://api.github.com/users/under-Peter/events{/privacy}","received_events_url":"https://api.github.com/users/under-Peter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/under-Peter/Zygote.jl","description":"21st Century AD","fork":true,"url":"https://api.github.com/repos/under-Peter/Zygote.jl","forks_url":"https://api.github.com/repos/under-Peter/Zygote.jl/forks","keys_url":"https://api.github.com/repos/under-Peter/Zygote.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/under-Peter/Zygote.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/under-Peter/Zygote.jl/teams","hooks_url":"https://api.github.com/repos/under-Peter/Zygote.jl/hooks","issue_events_url":"https://api.github.com/repos/under-Peter/Zygote.jl/issues/events{/number}","events_url":"https://api.github.com/repos/under-Peter/Zygote.jl/events","assignees_url":"https://api.github.com/repos/under-Peter/Zygote.jl/assignees{/user}","branches_url":"https://api.github.com/repos/under-Peter/Zygote.jl/branches{/branch}","tags_url":"https://api.github.com/repos/under-Peter/Zygote.jl/tags","blobs_url":"https://api.github.com/repos/under-Peter/Zygote.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/under-Peter/Zygote.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/under-Peter/Zygote.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/under-Peter/Zygote.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/under-Peter/Zygote.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/under-Peter/Zygote.jl/languages","stargazers_url":"https://api.github.com/repos/under-Peter/Zygote.jl/stargazers","contributors_url":"https://api.github.com/repos/under-Peter/Zygote.jl/contributors","subscribers_url":"https://api.github.com/repos/under-Peter/Zygote.jl/subscribers","subscription_url":"https://api.github.com/repos/under-Peter/Zygote.jl/subscription","commits_url":"https://api.github.com/repos/under-Peter/Zygote.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/under-Peter/Zygote.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/under-Peter/Zygote.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/under-Peter/Zygote.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/under-Peter/Zygote.jl/contents/{+path}","compare_url":"https://api.github.com/repos/under-Peter/Zygote.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/under-Peter/Zygote.jl/merges","archive_url":"https://api.github.com/repos/under-Peter/Zygote.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/under-Peter/Zygote.jl/downloads","issues_url":"https://api.github.com/repos/under-Peter/Zygote.jl/issues{/number}","pulls_url":"https://api.github.com/repos/under-Peter/Zygote.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/under-Peter/Zygote.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/under-Peter/Zygote.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/under-Peter/Zygote.jl/labels{/name}","releases_url":"https://api.github.com/repos/under-Peter/Zygote.jl/releases{/id}","deployments_url":"https://api.github.com/repos/under-Peter/Zygote.jl/deployments","created_at":"2019-06-01T15:52:23Z","updated_at":"2019-06-01T15:52:25Z","pushed_at":"2019-06-01T19:07:47Z","git_url":"git://github.com/under-Peter/Zygote.jl.git","ssh_url":"git@github.com:under-Peter/Zygote.jl.git","clone_url":"https://github.com/under-Peter/Zygote.jl.git","svn_url":"https://github.com/under-Peter/Zygote.jl","homepage":"https://fluxml.ai/Zygote.jl/","size":654,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FluxML:master","ref":"master","sha":"3f422a2f1ae05c6158f0a6eec939644488cab97b","user":{"login":"FluxML","id":26222520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjIyNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/26222520?v=4","gravatar_id":"","url":"https://api.github.com/users/FluxML","html_url":"https://github.com/FluxML","followers_url":"https://api.github.com/users/FluxML/followers","following_url":"https://api.github.com/users/FluxML/following{/other_user}","gists_url":"https://api.github.com/users/FluxML/gists{/gist_id}","starred_url":"https://api.github.com/users/FluxML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluxML/subscriptions","organizations_url":"https://api.github.com/users/FluxML/orgs","repos_url":"https://api.github.com/users/FluxML/repos","events_url":"https://api.github.com/users/FluxML/events{/privacy}","received_events_url":"https://api.github.com/users/FluxML/received_events","type":"Organization","site_admin":false},"repo":{"id":143788442,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3ODg0NDI=","name":"Zygote.jl","full_name":"FluxML/Zygote.jl","private":false,"owner":{"login":"FluxML","id":26222520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjIyNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/26222520?v=4","gravatar_id":"","url":"https://api.github.com/users/FluxML","html_url":"https://github.com/FluxML","followers_url":"https://api.github.com/users/FluxML/followers","following_url":"https://api.github.com/users/FluxML/following{/other_user}","gists_url":"https://api.github.com/users/FluxML/gists{/gist_id}","starred_url":"https://api.github.com/users/FluxML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluxML/subscriptions","organizations_url":"https://api.github.com/users/FluxML/orgs","repos_url":"https://api.github.com/users/FluxML/repos","events_url":"https://api.github.com/users/FluxML/events{/privacy}","received_events_url":"https://api.github.com/users/FluxML/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FluxML/Zygote.jl","description":"21st Century AD","fork":false,"url":"https://api.github.com/repos/FluxML/Zygote.jl","forks_url":"https://api.github.com/repos/FluxML/Zygote.jl/forks","keys_url":"https://api.github.com/repos/FluxML/Zygote.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FluxML/Zygote.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FluxML/Zygote.jl/teams","hooks_url":"https://api.github.com/repos/FluxML/Zygote.jl/hooks","issue_events_url":"https://api.github.com/repos/FluxML/Zygote.jl/issues/events{/number}","events_url":"https://api.github.com/repos/FluxML/Zygote.jl/events","assignees_url":"https://api.github.com/repos/FluxML/Zygote.jl/assignees{/user}","branches_url":"https://api.github.com/repos/FluxML/Zygote.jl/branches{/branch}","tags_url":"https://api.github.com/repos/FluxML/Zygote.jl/tags","blobs_url":"https://api.github.com/repos/FluxML/Zygote.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FluxML/Zygote.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FluxML/Zygote.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/FluxML/Zygote.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FluxML/Zygote.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/FluxML/Zygote.jl/languages","stargazers_url":"https://api.github.com/repos/FluxML/Zygote.jl/stargazers","contributors_url":"https://api.github.com/repos/FluxML/Zygote.jl/contributors","subscribers_url":"https://api.github.com/repos/FluxML/Zygote.jl/subscribers","subscription_url":"https://api.github.com/repos/FluxML/Zygote.jl/subscription","commits_url":"https://api.github.com/repos/FluxML/Zygote.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/FluxML/Zygote.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/FluxML/Zygote.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/FluxML/Zygote.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/FluxML/Zygote.jl/contents/{+path}","compare_url":"https://api.github.com/repos/FluxML/Zygote.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FluxML/Zygote.jl/merges","archive_url":"https://api.github.com/repos/FluxML/Zygote.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FluxML/Zygote.jl/downloads","issues_url":"https://api.github.com/repos/FluxML/Zygote.jl/issues{/number}","pulls_url":"https://api.github.com/repos/FluxML/Zygote.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/FluxML/Zygote.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/FluxML/Zygote.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FluxML/Zygote.jl/labels{/name}","releases_url":"https://api.github.com/repos/FluxML/Zygote.jl/releases{/id}","deployments_url":"https://api.github.com/repos/FluxML/Zygote.jl/deployments","created_at":"2018-08-06T22:08:26Z","updated_at":"2019-06-04T09:14:21Z","pushed_at":"2019-06-04T09:44:51Z","git_url":"git://github.com/FluxML/Zygote.jl.git","ssh_url":"git@github.com:FluxML/Zygote.jl.git","clone_url":"https://github.com/FluxML/Zygote.jl.git","svn_url":"https://github.com/FluxML/Zygote.jl","homepage":"https://fluxml.ai/Zygote.jl/","size":655,"stargazers_count":341,"watchers_count":341,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":83,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FluxML/Zygote.jl/pulls/210"},"html":{"href":"https://github.com/FluxML/Zygote.jl/pull/210"},"issue":{"href":"https://api.github.com/repos/FluxML/Zygote.jl/issues/210"},"comments":{"href":"https://api.github.com/repos/FluxML/Zygote.jl/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/FluxML/Zygote.jl/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/FluxML/Zygote.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FluxML/Zygote.jl/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/FluxML/Zygote.jl/statuses/b82bdf8760cef5a5796177876e1586d331f13d1b"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MikeInnes","id":2234614,"node_id":"MDQ6VXNlcjIyMzQ2MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2234614?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeInnes","html_url":"https://github.com/MikeInnes","followers_url":"https://api.github.com/users/MikeInnes/followers","following_url":"https://api.github.com/users/MikeInnes/following{/other_user}","gists_url":"https://api.github.com/users/MikeInnes/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeInnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeInnes/subscriptions","organizations_url":"https://api.github.com/users/MikeInnes/orgs","repos_url":"https://api.github.com/users/MikeInnes/repos","events_url":"https://api.github.com/users/MikeInnes/events{/privacy}","received_events_url":"https://api.github.com/users/MikeInnes/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"MikeInnes"}}