{"action":"created","comment":{"url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/comments/300174077","pull_request_review_id":257759655,"id":300174077,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDE3NDA3Nw==","diff_hunk":"@@ -154,7 +155,25 @@ func (ts *TaskService) Create(requestCtx context.Context, req *taskAPI.CreateTas\n \t\treturn nil, fmt.Errorf(\"Drive %q could not be found\", driveID)\n \t}\n \n-\terr = bundleDir.MountRootfs(drive.Path(), \"ext4\", nil)\n+\tconst (\n+\t\tmaxRetries = 100\n+\t\tretryDelay = 10 * time.Millisecond\n+\t)\n+\n+\t// We retry here due to Firecracker needing some time to populate the guest","path":"agent/service.go","position":18,"original_position":18,"commit_id":"17043200f5b9bb0d4baf672fccf58e932ad67f63","original_commit_id":"17043200f5b9bb0d4baf672fccf58e932ad67f63","user":{"login":"sipsma","id":30126853,"node_id":"MDQ6VXNlcjMwMTI2ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/30126853?v=4","gravatar_id":"","url":"https://api.github.com/users/sipsma","html_url":"https://github.com/sipsma","followers_url":"https://api.github.com/users/sipsma/followers","following_url":"https://api.github.com/users/sipsma/following{/other_user}","gists_url":"https://api.github.com/users/sipsma/gists{/gist_id}","starred_url":"https://api.github.com/users/sipsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipsma/subscriptions","organizations_url":"https://api.github.com/users/sipsma/orgs","repos_url":"https://api.github.com/users/sipsma/repos","events_url":"https://api.github.com/users/sipsma/events{/privacy}","received_events_url":"https://api.github.com/users/sipsma/received_events","type":"User","site_admin":false},"body":"nit: I think it's more accurate to say the guest kernel needs time to rescan the guest drive","created_at":"2019-07-03T22:25:30Z","updated_at":"2019-07-03T22:25:59Z","html_url":"https://github.com/firecracker-microvm/firecracker-containerd/pull/219#discussion_r300174077","pull_request_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/219","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/comments/300174077"},"html":{"href":"https://github.com/firecracker-microvm/firecracker-containerd/pull/219#discussion_r300174077"},"pull_request":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/219"}}},"pull_request":{"url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/219","id":294318315,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0MzE4MzE1","html_url":"https://github.com/firecracker-microvm/firecracker-containerd/pull/219","diff_url":"https://github.com/firecracker-microvm/firecracker-containerd/pull/219.diff","patch_url":"https://github.com/firecracker-microvm/firecracker-containerd/pull/219.patch","issue_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/219","number":219,"state":"open","locked":false,"title":"agent: Adding retry around mounting logic","user":{"login":"xibz","id":1964445,"node_id":"MDQ6VXNlcjE5NjQ0NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1964445?v=4","gravatar_id":"","url":"https://api.github.com/users/xibz","html_url":"https://github.com/xibz","followers_url":"https://api.github.com/users/xibz/followers","following_url":"https://api.github.com/users/xibz/following{/other_user}","gists_url":"https://api.github.com/users/xibz/gists{/gist_id}","starred_url":"https://api.github.com/users/xibz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xibz/subscriptions","organizations_url":"https://api.github.com/users/xibz/orgs","repos_url":"https://api.github.com/users/xibz/repos","events_url":"https://api.github.com/users/xibz/events{/privacy}","received_events_url":"https://api.github.com/users/xibz/received_events","type":"User","site_admin":false},"body":"Firecracker requires some time to populate the config space change which\r\nwas causing failures in our CI due to calling patch drive followed by\r\nan immediate call of mounting that drive.\r\n\r\nhttps://github.com/firecracker-microvm/firecracker/issues/1159#issuecomment-507984468\r\n\r\nFixes #214\r\n\r\nSigned-off-by: xibz <impactbchang@gmail.com>\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2019-07-03T20:27:50Z","updated_at":"2019-07-03T22:25:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09f9071b6f092e21eb7d1f821e63413693135b7f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mxpv","id":865334,"node_id":"MDQ6VXNlcjg2NTMzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/865334?v=4","gravatar_id":"","url":"https://api.github.com/users/mxpv","html_url":"https://github.com/mxpv","followers_url":"https://api.github.com/users/mxpv/followers","following_url":"https://api.github.com/users/mxpv/following{/other_user}","gists_url":"https://api.github.com/users/mxpv/gists{/gist_id}","starred_url":"https://api.github.com/users/mxpv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxpv/subscriptions","organizations_url":"https://api.github.com/users/mxpv/orgs","repos_url":"https://api.github.com/users/mxpv/repos","events_url":"https://api.github.com/users/mxpv/events{/privacy}","received_events_url":"https://api.github.com/users/mxpv/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/219/commits","review_comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/219/comments","review_comment_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/219/comments","statuses_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/statuses/17043200f5b9bb0d4baf672fccf58e932ad67f63","head":{"label":"xibz:retryer","ref":"retryer","sha":"17043200f5b9bb0d4baf672fccf58e932ad67f63","user":{"login":"xibz","id":1964445,"node_id":"MDQ6VXNlcjE5NjQ0NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1964445?v=4","gravatar_id":"","url":"https://api.github.com/users/xibz","html_url":"https://github.com/xibz","followers_url":"https://api.github.com/users/xibz/followers","following_url":"https://api.github.com/users/xibz/following{/other_user}","gists_url":"https://api.github.com/users/xibz/gists{/gist_id}","starred_url":"https://api.github.com/users/xibz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xibz/subscriptions","organizations_url":"https://api.github.com/users/xibz/orgs","repos_url":"https://api.github.com/users/xibz/repos","events_url":"https://api.github.com/users/xibz/events{/privacy}","received_events_url":"https://api.github.com/users/xibz/received_events","type":"User","site_admin":false},"repo":{"id":166133882,"node_id":"MDEwOlJlcG9zaXRvcnkxNjYxMzM4ODI=","name":"firecracker-containerd","full_name":"xibz/firecracker-containerd","private":false,"owner":{"login":"xibz","id":1964445,"node_id":"MDQ6VXNlcjE5NjQ0NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1964445?v=4","gravatar_id":"","url":"https://api.github.com/users/xibz","html_url":"https://github.com/xibz","followers_url":"https://api.github.com/users/xibz/followers","following_url":"https://api.github.com/users/xibz/following{/other_user}","gists_url":"https://api.github.com/users/xibz/gists{/gist_id}","starred_url":"https://api.github.com/users/xibz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xibz/subscriptions","organizations_url":"https://api.github.com/users/xibz/orgs","repos_url":"https://api.github.com/users/xibz/repos","events_url":"https://api.github.com/users/xibz/events{/privacy}","received_events_url":"https://api.github.com/users/xibz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xibz/firecracker-containerd","description":"firecracker-containerd enables containerd to manage containers as Firecracker microVMs","fork":true,"url":"https://api.github.com/repos/xibz/firecracker-containerd","forks_url":"https://api.github.com/repos/xibz/firecracker-containerd/forks","keys_url":"https://api.github.com/repos/xibz/firecracker-containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xibz/firecracker-containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xibz/firecracker-containerd/teams","hooks_url":"https://api.github.com/repos/xibz/firecracker-containerd/hooks","issue_events_url":"https://api.github.com/repos/xibz/firecracker-containerd/issues/events{/number}","events_url":"https://api.github.com/repos/xibz/firecracker-containerd/events","assignees_url":"https://api.github.com/repos/xibz/firecracker-containerd/assignees{/user}","branches_url":"https://api.github.com/repos/xibz/firecracker-containerd/branches{/branch}","tags_url":"https://api.github.com/repos/xibz/firecracker-containerd/tags","blobs_url":"https://api.github.com/repos/xibz/firecracker-containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xibz/firecracker-containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xibz/firecracker-containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xibz/firecracker-containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xibz/firecracker-containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/xibz/firecracker-containerd/languages","stargazers_url":"https://api.github.com/repos/xibz/firecracker-containerd/stargazers","contributors_url":"https://api.github.com/repos/xibz/firecracker-containerd/contributors","subscribers_url":"https://api.github.com/repos/xibz/firecracker-containerd/subscribers","subscription_url":"https://api.github.com/repos/xibz/firecracker-containerd/subscription","commits_url":"https://api.github.com/repos/xibz/firecracker-containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xibz/firecracker-containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xibz/firecracker-containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xibz/firecracker-containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xibz/firecracker-containerd/contents/{+path}","compare_url":"https://api.github.com/repos/xibz/firecracker-containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xibz/firecracker-containerd/merges","archive_url":"https://api.github.com/repos/xibz/firecracker-containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xibz/firecracker-containerd/downloads","issues_url":"https://api.github.com/repos/xibz/firecracker-containerd/issues{/number}","pulls_url":"https://api.github.com/repos/xibz/firecracker-containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/xibz/firecracker-containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/xibz/firecracker-containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xibz/firecracker-containerd/labels{/name}","releases_url":"https://api.github.com/repos/xibz/firecracker-containerd/releases{/id}","deployments_url":"https://api.github.com/repos/xibz/firecracker-containerd/deployments","created_at":"2019-01-17T00:42:53Z","updated_at":"2019-07-02T21:27:03Z","pushed_at":"2019-07-03T22:18:15Z","git_url":"git://github.com/xibz/firecracker-containerd.git","ssh_url":"git@github.com:xibz/firecracker-containerd.git","clone_url":"https://github.com/xibz/firecracker-containerd.git","svn_url":"https://github.com/xibz/firecracker-containerd","homepage":null,"size":1260,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firecracker-microvm:master","ref":"master","sha":"a06d2d892b51225bcbb0d89b2fa0e8739588e836","user":{"login":"firecracker-microvm","id":44477506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NDc3NTA2","avatar_url":"https://avatars0.githubusercontent.com/u/44477506?v=4","gravatar_id":"","url":"https://api.github.com/users/firecracker-microvm","html_url":"https://github.com/firecracker-microvm","followers_url":"https://api.github.com/users/firecracker-microvm/followers","following_url":"https://api.github.com/users/firecracker-microvm/following{/other_user}","gists_url":"https://api.github.com/users/firecracker-microvm/gists{/gist_id}","starred_url":"https://api.github.com/users/firecracker-microvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firecracker-microvm/subscriptions","organizations_url":"https://api.github.com/users/firecracker-microvm/orgs","repos_url":"https://api.github.com/users/firecracker-microvm/repos","events_url":"https://api.github.com/users/firecracker-microvm/events{/privacy}","received_events_url":"https://api.github.com/users/firecracker-microvm/received_events","type":"Organization","site_admin":false},"repo":{"id":157781317,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3ODEzMTc=","name":"firecracker-containerd","full_name":"firecracker-microvm/firecracker-containerd","private":false,"owner":{"login":"firecracker-microvm","id":44477506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NDc3NTA2","avatar_url":"https://avatars0.githubusercontent.com/u/44477506?v=4","gravatar_id":"","url":"https://api.github.com/users/firecracker-microvm","html_url":"https://github.com/firecracker-microvm","followers_url":"https://api.github.com/users/firecracker-microvm/followers","following_url":"https://api.github.com/users/firecracker-microvm/following{/other_user}","gists_url":"https://api.github.com/users/firecracker-microvm/gists{/gist_id}","starred_url":"https://api.github.com/users/firecracker-microvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firecracker-microvm/subscriptions","organizations_url":"https://api.github.com/users/firecracker-microvm/orgs","repos_url":"https://api.github.com/users/firecracker-microvm/repos","events_url":"https://api.github.com/users/firecracker-microvm/events{/privacy}","received_events_url":"https://api.github.com/users/firecracker-microvm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firecracker-microvm/firecracker-containerd","description":"firecracker-containerd enables containerd to manage containers as Firecracker microVMs","fork":false,"url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd","forks_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/forks","keys_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/teams","hooks_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/hooks","issue_events_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/events{/number}","events_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/events","assignees_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/assignees{/user}","branches_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/branches{/branch}","tags_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/tags","blobs_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/languages","stargazers_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/stargazers","contributors_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/contributors","subscribers_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/subscribers","subscription_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/subscription","commits_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/contents/{+path}","compare_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/merges","archive_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/downloads","issues_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues{/number}","pulls_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/labels{/name}","releases_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/releases{/id}","deployments_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/deployments","created_at":"2018-11-15T22:36:30Z","updated_at":"2019-07-03T07:05:35Z","pushed_at":"2019-07-03T22:18:17Z","git_url":"git://github.com/firecracker-microvm/firecracker-containerd.git","ssh_url":"git@github.com:firecracker-microvm/firecracker-containerd.git","clone_url":"https://github.com/firecracker-microvm/firecracker-containerd.git","svn_url":"https://github.com/firecracker-microvm/firecracker-containerd","homepage":null,"size":1216,"stargazers_count":607,"watchers_count":607,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":41,"watchers":607,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/219"},"html":{"href":"https://github.com/firecracker-microvm/firecracker-containerd/pull/219"},"issue":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/219"},"comments":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/statuses/17043200f5b9bb0d4baf672fccf58e932ad67f63"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sipsma"}}