{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/302540875","pull_request_review_id":260693983,"id":302540875,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjU0MDg3NQ==","diff_hunk":"@@ -0,0 +1,104 @@\n+// Module included in the following assemblies:\n+//\n+// * service_mesh/service_mesh_install/installing-ossm.adoc\n+\n+[id=\"ossm-cr-istio-global_{context}\"]\n+= Istio global example\n+\n+Here is an example that illustrates the Istio global parameters for the {ProductName} custom resource and a description of the available parameters with appropriate values.\n+\n+[NOTE]\n+====\n+In order for the 3scale Istio Adapter to work, `disablePolicyChecks` must be `false`.\n+====\n+\n+[source,yaml]\n+----\n+  istio:\n+    global:\n+      hub: `maistra/` or `registry.redhat.io/openshift-istio-tech-preview/`\n+      tag: 0.11.0\n+      proxy:\n+        resources:\n+          requests:\n+            cpu: 100m\n+            memory: 128Mi\n+          limits:\n+            cpu: 500m\n+            memory: 128Mi\n+      mtls:\n+        enabled: false\n+      disablePolicyChecks: true\n+      policyCheckFailOpen: false\n+      imagePullSecrets:\n+        - MyPullSecret\n+----\n+\n+[NOTE]\n+====\n+See the OpenShift documentation on xref:../../scalability_and_performance/recommended-host-practices.html#recommended-node-host-practices_[Scalability and performance] for additional details on CPU and memory resources for the containers in your pod.\n+====\n+\n+.General parameters\n+|===\n+|Parameter |Description |Values |Default value\n+","path":"modules/ossm-cr-istio-global.adoc","position":45,"original_position":45,"commit_id":"6969f479bebc4089bf1ad206ad3346295a856c0a","original_commit_id":"6969f479bebc4089bf1ad206ad3346295a856c0a","user":{"login":"brian-avery","id":8484260,"node_id":"MDQ6VXNlcjg0ODQyNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/8484260?v=4","gravatar_id":"","url":"https://api.github.com/users/brian-avery","html_url":"https://github.com/brian-avery","followers_url":"https://api.github.com/users/brian-avery/followers","following_url":"https://api.github.com/users/brian-avery/following{/other_user}","gists_url":"https://api.github.com/users/brian-avery/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-avery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-avery/subscriptions","organizations_url":"https://api.github.com/users/brian-avery/orgs","repos_url":"https://api.github.com/users/brian-avery/repos","events_url":"https://api.github.com/users/brian-avery/events{/privacy}","received_events_url":"https://api.github.com/users/brian-avery/received_events","type":"User","site_admin":false},"body":"Haven't heard of anyone doing it, but I haven't talked to a lot of users. My guess is no. ","created_at":"2019-07-11T13:25:39Z","updated_at":"2019-07-11T13:25:40Z","html_url":"https://github.com/openshift/openshift-docs/pull/15681#discussion_r302540875","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/15681","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/302540875"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/15681#discussion_r302540875"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/15681"}},"in_reply_to_id":302298667},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/15681","id":293448218,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzNDQ4MjE4","html_url":"https://github.com/openshift/openshift-docs/pull/15681","diff_url":"https://github.com/openshift/openshift-docs/pull/15681.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/15681.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/15681","number":15681,"state":"open","locked":false,"title":"TP12 Modularization Work","user":{"login":"geekspertise","id":41442779,"node_id":"MDQ6VXNlcjQxNDQyNzc5","avatar_url":"https://avatars3.githubusercontent.com/u/41442779?v=4","gravatar_id":"","url":"https://api.github.com/users/geekspertise","html_url":"https://github.com/geekspertise","followers_url":"https://api.github.com/users/geekspertise/followers","following_url":"https://api.github.com/users/geekspertise/following{/other_user}","gists_url":"https://api.github.com/users/geekspertise/gists{/gist_id}","starred_url":"https://api.github.com/users/geekspertise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geekspertise/subscriptions","organizations_url":"https://api.github.com/users/geekspertise/orgs","repos_url":"https://api.github.com/users/geekspertise/repos","events_url":"https://api.github.com/users/geekspertise/events{/privacy}","received_events_url":"https://api.github.com/users/geekspertise/received_events","type":"User","site_admin":false},"body":"This PR is a WIP that currently includes:\r\n\r\n- Modularization work for Service Mesh Installation documentation\r\n- Modularization of 3scale Istio Adapter documentation\r\n- Updated links\r\n\r\nAdditional work necessary before merge:\r\n\r\n- TP12 documentation updates\r\n- Clean up\r\n\r\nCan @knrc @tvieira and @brian-avery start reviewing the docs to ensure post-mod accuracy?\r\n\r\nCan @kalexand-rh or @vikram-redhat review for modularization issues?\r\n\r\nCan @JStickler review to ensure we are ready to form Voltron when TP12 is complete? ","created_at":"2019-07-01T18:23:47Z","updated_at":"2019-07-11T13:25:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7154975f2eeed4687a6d42d679c436d85f6cf2f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":752435819,"node_id":"MDU6TGFiZWw3NTI0MzU4MTk=","url":"https://api.github.com/repos/openshift/openshift-docs/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/15681/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/15681/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/15681/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/6969f479bebc4089bf1ad206ad3346295a856c0a","head":{"label":"geekspertise:servicemesh","ref":"servicemesh","sha":"6969f479bebc4089bf1ad206ad3346295a856c0a","user":{"login":"geekspertise","id":41442779,"node_id":"MDQ6VXNlcjQxNDQyNzc5","avatar_url":"https://avatars3.githubusercontent.com/u/41442779?v=4","gravatar_id":"","url":"https://api.github.com/users/geekspertise","html_url":"https://github.com/geekspertise","followers_url":"https://api.github.com/users/geekspertise/followers","following_url":"https://api.github.com/users/geekspertise/following{/other_user}","gists_url":"https://api.github.com/users/geekspertise/gists{/gist_id}","starred_url":"https://api.github.com/users/geekspertise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geekspertise/subscriptions","organizations_url":"https://api.github.com/users/geekspertise/orgs","repos_url":"https://api.github.com/users/geekspertise/repos","events_url":"https://api.github.com/users/geekspertise/events{/privacy}","received_events_url":"https://api.github.com/users/geekspertise/received_events","type":"User","site_admin":false},"repo":{"id":149351094,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNTEwOTQ=","name":"openshift-docs","full_name":"geekspertise/openshift-docs","private":false,"owner":{"login":"geekspertise","id":41442779,"node_id":"MDQ6VXNlcjQxNDQyNzc5","avatar_url":"https://avatars3.githubusercontent.com/u/41442779?v=4","gravatar_id":"","url":"https://api.github.com/users/geekspertise","html_url":"https://github.com/geekspertise","followers_url":"https://api.github.com/users/geekspertise/followers","following_url":"https://api.github.com/users/geekspertise/following{/other_user}","gists_url":"https://api.github.com/users/geekspertise/gists{/gist_id}","starred_url":"https://api.github.com/users/geekspertise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geekspertise/subscriptions","organizations_url":"https://api.github.com/users/geekspertise/orgs","repos_url":"https://api.github.com/users/geekspertise/repos","events_url":"https://api.github.com/users/geekspertise/events{/privacy}","received_events_url":"https://api.github.com/users/geekspertise/received_events","type":"User","site_admin":false},"html_url":"https://github.com/geekspertise/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/geekspertise/openshift-docs","forks_url":"https://api.github.com/repos/geekspertise/openshift-docs/forks","keys_url":"https://api.github.com/repos/geekspertise/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geekspertise/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geekspertise/openshift-docs/teams","hooks_url":"https://api.github.com/repos/geekspertise/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/geekspertise/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/geekspertise/openshift-docs/events","assignees_url":"https://api.github.com/repos/geekspertise/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/geekspertise/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/geekspertise/openshift-docs/tags","blobs_url":"https://api.github.com/repos/geekspertise/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geekspertise/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geekspertise/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/geekspertise/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geekspertise/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/geekspertise/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/geekspertise/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/geekspertise/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/geekspertise/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/geekspertise/openshift-docs/subscription","commits_url":"https://api.github.com/repos/geekspertise/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/geekspertise/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/geekspertise/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/geekspertise/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/geekspertise/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/geekspertise/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geekspertise/openshift-docs/merges","archive_url":"https://api.github.com/repos/geekspertise/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geekspertise/openshift-docs/downloads","issues_url":"https://api.github.com/repos/geekspertise/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/geekspertise/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/geekspertise/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/geekspertise/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geekspertise/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/geekspertise/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/geekspertise/openshift-docs/deployments","created_at":"2018-09-18T20:55:47Z","updated_at":"2019-07-03T18:24:16Z","pushed_at":"2019-07-10T19:52:05Z","git_url":"git://github.com/geekspertise/openshift-docs.git","ssh_url":"git@github.com:geekspertise/openshift-docs.git","clone_url":"https://github.com/geekspertise/openshift-docs.git","svn_url":"https://github.com/geekspertise/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":101946,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"c5df9253c1a02688d2ed8f7b3ad9bb1925750480","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc0MDg0NA==","name":"openshift-docs","full_name":"openshift/openshift-docs","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-docs/deployments","created_at":"2014-07-11T15:14:42Z","updated_at":"2019-07-11T12:16:20Z","pushed_at":"2019-07-11T12:34:53Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"git@github.com:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":105810,"stargazers_count":299,"watchers_count":299,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":729,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":327,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":729,"open_issues":327,"watchers":299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/15681"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/15681"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/15681"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/15681/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/15681/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/15681/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/6969f479bebc4089bf1ad206ad3346295a856c0a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brian-avery"}}