{"action":"created","comment":{"url":"https://api.github.com/repos/ovh/cds/pulls/comments/316041805","pull_request_review_id":277613294,"id":316041805,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjA0MTgwNQ==","diff_hunk":"@@ -108,106 +105,62 @@ func TestLoadAll(t *testing.T) {\n \tdb, cache, end := test.SetupPG(t, bootstrap.InitiliazeDB)\n \tdefer end()\n \n-\tproject.Delete(db, cache, \"test_TestLoadAll\")\n \tproject.Delete(db, cache, \"test_TestLoadAll1\")\n+\tproject.Delete(db, cache, \"test_TestLoadAll2\")","path":"engine/api/project/dao_test.go","position":98,"original_position":98,"commit_id":"af6b034f641f44fb887924f96afcedc0a0153e4f","original_commit_id":"af6b034f641f44fb887924f96afcedc0a0153e4f","user":{"login":"golangcibot","id":42910462,"node_id":"MDQ6VXNlcjQyOTEwNDYy","avatar_url":"https://avatars1.githubusercontent.com/u/42910462?v=4","gravatar_id":"","url":"https://api.github.com/users/golangcibot","html_url":"https://github.com/golangcibot","followers_url":"https://api.github.com/users/golangcibot/followers","following_url":"https://api.github.com/users/golangcibot/following{/other_user}","gists_url":"https://api.github.com/users/golangcibot/gists{/gist_id}","starred_url":"https://api.github.com/users/golangcibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golangcibot/subscriptions","organizations_url":"https://api.github.com/users/golangcibot/orgs","repos_url":"https://api.github.com/users/golangcibot/repos","events_url":"https://api.github.com/users/golangcibot/events{/privacy}","received_events_url":"https://api.github.com/users/golangcibot/received_events","type":"User","site_admin":false},"body":"Error return value of `project.Delete` is not checked (from `errcheck`)","created_at":"2019-08-21T07:51:05Z","updated_at":"2019-08-21T07:51:12Z","html_url":"https://github.com/ovh/cds/pull/4290#discussion_r316041805","pull_request_url":"https://api.github.com/repos/ovh/cds/pulls/4290","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ovh/cds/pulls/comments/316041805"},"html":{"href":"https://github.com/ovh/cds/pull/4290#discussion_r316041805"},"pull_request":{"href":"https://api.github.com/repos/ovh/cds/pulls/4290"}}},"pull_request":{"url":"https://api.github.com/repos/ovh/cds/pulls/4290","id":279097110,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5MDk3MTEw","html_url":"https://github.com/ovh/cds/pull/4290","diff_url":"https://github.com/ovh/cds/pull/4290.diff","patch_url":"https://github.com/ovh/cds/pull/4290.patch","issue_url":"https://api.github.com/repos/ovh/cds/issues/4290","number":4290,"state":"open","locked":false,"title":"Refactor/users","user":{"login":"fsamin","id":684151,"node_id":"MDQ6VXNlcjY4NDE1MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/684151?v=4","gravatar_id":"","url":"https://api.github.com/users/fsamin","html_url":"https://github.com/fsamin","followers_url":"https://api.github.com/users/fsamin/followers","following_url":"https://api.github.com/users/fsamin/following{/other_user}","gists_url":"https://api.github.com/users/fsamin/gists{/gist_id}","starred_url":"https://api.github.com/users/fsamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsamin/subscriptions","organizations_url":"https://api.github.com/users/fsamin/orgs","repos_url":"https://api.github.com/users/fsamin/repos","events_url":"https://api.github.com/users/fsamin/events{/privacy}","received_events_url":"https://api.github.com/users/fsamin/received_events","type":"User","site_admin":false},"body":"1. Description\r\n\r\n- [ ] When a user is removed from a group, removed from admins, when a group is deleted, check if some consumers need to be revoked or updated.\r\n- [ ] Use of a builtin signin token in CLI, should use the client that automatically signin. We can also signin manually.\r\n- [ ] Consumer \"data\" map should be scoped to authentication package.\r\n\r\n TODOs\r\n - [ ] cdsclt consumer & sessions management\r\n - [ ] `getActionsForGroupHandler, getWorkerModelsForGroupHandler`: move this in a permGroupID middleware\r\n - [ ] api startup authentication drivers initialization\r\n - [x] LDAP authentication drivers\r\n - [ ] api debug handlers `getProfileIndexHandler`\r\n - [ ] `updateGroupHandler`checks number of remaining admins\r\n - [ ] `GetUserWorkflowEvents`send email notifications\r\n - [ ] `Test_checkWorkerModelPermissionsByUser`\r\n - [x] `Test_checkWorkflowPermissionsByUser`\r\n - [x] `postServiceRegisterHandler`: for hatcheries, the user who created the used token must be admin of all groups in the token\r\n  - [x] `serviceAPIHeartbeat`: fake user ?\r\n  - [ ] `bookWorkerModelHandler`: permModelID middleware\r\n  - [ ] Implement a unit test for checkGroupPermissions\r\n  - [ ] Implement a unit test for checkWorkerModelPermissions\r\n  - [ ] Implement a unit test for checkActionPermissions\r\n  - [ ] Implement permActionBuiltinName\r\n  - [ ] Implement a unit tests for checkTemplateSlugPermissions\r\n  - [ ] Check the \"triggered by\" data when a workflow is run by a uService\r\n  - [ ] [ERROR] error executing query UPDATE services SET sig = $2 WHERE id = $1 with parameters services, id: pq: payload string too long \r\n - [ ] Implement session clean goroutine on API side\r\n - [ ] Add XSRF signin local and ldap\r\n - [ ] username check syntax backend","created_at":"2019-05-15T13:25:52Z","updated_at":"2019-08-21T07:51:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07c373ba16f10abf300fefac4ed959f095b97687","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1099241641,"node_id":"MDU6TGFiZWwxMDk5MjQxNjQx","url":"https://api.github.com/repos/ovh/cds/labels/api","name":"api","color":"000080","default":false},{"id":851152631,"node_id":"MDU6TGFiZWw4NTExNTI2MzE=","url":"https://api.github.com/repos/ovh/cds/labels/refactor","name":"refactor","color":"CD5C5C","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ovh/cds/pulls/4290/commits","review_comments_url":"https://api.github.com/repos/ovh/cds/pulls/4290/comments","review_comment_url":"https://api.github.com/repos/ovh/cds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ovh/cds/issues/4290/comments","statuses_url":"https://api.github.com/repos/ovh/cds/statuses/af6b034f641f44fb887924f96afcedc0a0153e4f","head":{"label":"ovh:refactor/users","ref":"refactor/users","sha":"af6b034f641f44fb887924f96afcedc0a0153e4f","user":{"login":"ovh","id":1698434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTg0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1698434?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"repo":{"id":70572539,"node_id":"MDEwOlJlcG9zaXRvcnk3MDU3MjUzOQ==","name":"cds","full_name":"ovh/cds","private":false,"owner":{"login":"ovh","id":1698434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTg0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1698434?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ovh/cds","description":"Enterprise-Grade Continuous Delivery & DevOps Automation Open Source Platform","fork":false,"url":"https://api.github.com/repos/ovh/cds","forks_url":"https://api.github.com/repos/ovh/cds/forks","keys_url":"https://api.github.com/repos/ovh/cds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh/cds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh/cds/teams","hooks_url":"https://api.github.com/repos/ovh/cds/hooks","issue_events_url":"https://api.github.com/repos/ovh/cds/issues/events{/number}","events_url":"https://api.github.com/repos/ovh/cds/events","assignees_url":"https://api.github.com/repos/ovh/cds/assignees{/user}","branches_url":"https://api.github.com/repos/ovh/cds/branches{/branch}","tags_url":"https://api.github.com/repos/ovh/cds/tags","blobs_url":"https://api.github.com/repos/ovh/cds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh/cds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh/cds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh/cds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh/cds/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh/cds/languages","stargazers_url":"https://api.github.com/repos/ovh/cds/stargazers","contributors_url":"https://api.github.com/repos/ovh/cds/contributors","subscribers_url":"https://api.github.com/repos/ovh/cds/subscribers","subscription_url":"https://api.github.com/repos/ovh/cds/subscription","commits_url":"https://api.github.com/repos/ovh/cds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh/cds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh/cds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh/cds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh/cds/contents/{+path}","compare_url":"https://api.github.com/repos/ovh/cds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh/cds/merges","archive_url":"https://api.github.com/repos/ovh/cds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh/cds/downloads","issues_url":"https://api.github.com/repos/ovh/cds/issues{/number}","pulls_url":"https://api.github.com/repos/ovh/cds/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh/cds/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh/cds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh/cds/labels{/name}","releases_url":"https://api.github.com/repos/ovh/cds/releases{/id}","deployments_url":"https://api.github.com/repos/ovh/cds/deployments","created_at":"2016-10-11T08:28:23Z","updated_at":"2019-08-21T07:04:39Z","pushed_at":"2019-08-21T07:45:40Z","git_url":"git://github.com/ovh/cds.git","ssh_url":"git@github.com:ovh/cds.git","clone_url":"https://github.com/ovh/cds.git","svn_url":"https://github.com/ovh/cds","homepage":"https://ovh.github.io/cds/","size":198797,"stargazers_count":2325,"watchers_count":2325,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":178,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":168,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":178,"open_issues":168,"watchers":2325,"default_branch":"master"}},"base":{"label":"ovh:master","ref":"master","sha":"3b329d500313a2b535114b77982087d70ffc6162","user":{"login":"ovh","id":1698434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTg0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1698434?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"repo":{"id":70572539,"node_id":"MDEwOlJlcG9zaXRvcnk3MDU3MjUzOQ==","name":"cds","full_name":"ovh/cds","private":false,"owner":{"login":"ovh","id":1698434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTg0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1698434?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh","html_url":"https://github.com/ovh","followers_url":"https://api.github.com/users/ovh/followers","following_url":"https://api.github.com/users/ovh/following{/other_user}","gists_url":"https://api.github.com/users/ovh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh/subscriptions","organizations_url":"https://api.github.com/users/ovh/orgs","repos_url":"https://api.github.com/users/ovh/repos","events_url":"https://api.github.com/users/ovh/events{/privacy}","received_events_url":"https://api.github.com/users/ovh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ovh/cds","description":"Enterprise-Grade Continuous Delivery & DevOps Automation Open Source Platform","fork":false,"url":"https://api.github.com/repos/ovh/cds","forks_url":"https://api.github.com/repos/ovh/cds/forks","keys_url":"https://api.github.com/repos/ovh/cds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh/cds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh/cds/teams","hooks_url":"https://api.github.com/repos/ovh/cds/hooks","issue_events_url":"https://api.github.com/repos/ovh/cds/issues/events{/number}","events_url":"https://api.github.com/repos/ovh/cds/events","assignees_url":"https://api.github.com/repos/ovh/cds/assignees{/user}","branches_url":"https://api.github.com/repos/ovh/cds/branches{/branch}","tags_url":"https://api.github.com/repos/ovh/cds/tags","blobs_url":"https://api.github.com/repos/ovh/cds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh/cds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh/cds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh/cds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh/cds/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh/cds/languages","stargazers_url":"https://api.github.com/repos/ovh/cds/stargazers","contributors_url":"https://api.github.com/repos/ovh/cds/contributors","subscribers_url":"https://api.github.com/repos/ovh/cds/subscribers","subscription_url":"https://api.github.com/repos/ovh/cds/subscription","commits_url":"https://api.github.com/repos/ovh/cds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh/cds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh/cds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh/cds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh/cds/contents/{+path}","compare_url":"https://api.github.com/repos/ovh/cds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh/cds/merges","archive_url":"https://api.github.com/repos/ovh/cds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh/cds/downloads","issues_url":"https://api.github.com/repos/ovh/cds/issues{/number}","pulls_url":"https://api.github.com/repos/ovh/cds/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh/cds/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh/cds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh/cds/labels{/name}","releases_url":"https://api.github.com/repos/ovh/cds/releases{/id}","deployments_url":"https://api.github.com/repos/ovh/cds/deployments","created_at":"2016-10-11T08:28:23Z","updated_at":"2019-08-21T07:04:39Z","pushed_at":"2019-08-21T07:45:40Z","git_url":"git://github.com/ovh/cds.git","ssh_url":"git@github.com:ovh/cds.git","clone_url":"https://github.com/ovh/cds.git","svn_url":"https://github.com/ovh/cds","homepage":"https://ovh.github.io/cds/","size":198797,"stargazers_count":2325,"watchers_count":2325,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":178,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":168,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":178,"open_issues":168,"watchers":2325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ovh/cds/pulls/4290"},"html":{"href":"https://github.com/ovh/cds/pull/4290"},"issue":{"href":"https://api.github.com/repos/ovh/cds/issues/4290"},"comments":{"href":"https://api.github.com/repos/ovh/cds/issues/4290/comments"},"review_comments":{"href":"https://api.github.com/repos/ovh/cds/pulls/4290/comments"},"review_comment":{"href":"https://api.github.com/repos/ovh/cds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ovh/cds/pulls/4290/commits"},"statuses":{"href":"https://api.github.com/repos/ovh/cds/statuses/af6b034f641f44fb887924f96afcedc0a0153e4f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"golangcibot"}}