{"action":"created","comment":{"url":"https://api.github.com/repos/plotly/dash-table/pulls/comments/309759287","pull_request_review_id":269700415,"id":309759287,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTc1OTI4Nw==","diff_hunk":"@@ -275,6 +272,8 @@ export interface IProps {\n     fill_width?: boolean;\n     filter_query?: string;\n     filter_action?: TableAction;\n+    hideable?: boolean | boolean[];\n+    hidden_columns?: string[];","path":"src/dash-table/components/Table/props.ts","position":51,"original_position":51,"commit_id":"d01777c8462ceb1179662154171d589351028f9e","original_commit_id":"d01777c8462ceb1179662154171d589351028f9e","user":{"login":"Marc-Andre-Rivet","id":8092993,"node_id":"MDQ6VXNlcjgwOTI5OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8092993?v=4","gravatar_id":"","url":"https://api.github.com/users/Marc-Andre-Rivet","html_url":"https://github.com/Marc-Andre-Rivet","followers_url":"https://api.github.com/users/Marc-Andre-Rivet/followers","following_url":"https://api.github.com/users/Marc-Andre-Rivet/following{/other_user}","gists_url":"https://api.github.com/users/Marc-Andre-Rivet/gists{/gist_id}","starred_url":"https://api.github.com/users/Marc-Andre-Rivet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marc-Andre-Rivet/subscriptions","organizations_url":"https://api.github.com/users/Marc-Andre-Rivet/orgs","repos_url":"https://api.github.com/users/Marc-Andre-Rivet/repos","events_url":"https://api.github.com/users/Marc-Andre-Rivet/events{/privacy}","received_events_url":"https://api.github.com/users/Marc-Andre-Rivet/received_events","type":"User","site_admin":false},"body":"removing","created_at":"2019-08-01T15:26:45Z","updated_at":"2019-08-01T15:26:46Z","html_url":"https://github.com/plotly/dash-table/pull/508#discussion_r309759287","pull_request_url":"https://api.github.com/repos/plotly/dash-table/pulls/508","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/comments/309759287"},"html":{"href":"https://github.com/plotly/dash-table/pull/508#discussion_r309759287"},"pull_request":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/508"}}},"pull_request":{"url":"https://api.github.com/repos/plotly/dash-table/pulls/508","id":298897783,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4ODk3Nzgz","html_url":"https://github.com/plotly/dash-table/pull/508","diff_url":"https://github.com/plotly/dash-table/pull/508.diff","patch_url":"https://github.com/plotly/dash-table/pull/508.patch","issue_url":"https://api.github.com/repos/plotly/dash-table/issues/508","number":508,"state":"open","locked":false,"title":"Issue 314 - Hidden Columns","user":{"login":"Marc-Andre-Rivet","id":8092993,"node_id":"MDQ6VXNlcjgwOTI5OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8092993?v=4","gravatar_id":"","url":"https://api.github.com/users/Marc-Andre-Rivet","html_url":"https://github.com/Marc-Andre-Rivet","followers_url":"https://api.github.com/users/Marc-Andre-Rivet/followers","following_url":"https://api.github.com/users/Marc-Andre-Rivet/following{/other_user}","gists_url":"https://api.github.com/users/Marc-Andre-Rivet/gists{/gist_id}","starred_url":"https://api.github.com/users/Marc-Andre-Rivet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marc-Andre-Rivet/subscriptions","organizations_url":"https://api.github.com/users/Marc-Andre-Rivet/orgs","repos_url":"https://api.github.com/users/Marc-Andre-Rivet/repos","events_url":"https://api.github.com/users/Marc-Andre-Rivet/events{/privacy}","received_events_url":"https://api.github.com/users/Marc-Andre-Rivet/received_events","type":"User","site_admin":false},"body":"Hidden columns feature #314 \r\n\r\nSupport to toggle columns visibility.\r\n\r\n**API modifications**\r\n- added `column.hideable: boolean | undefined`\r\n- added `hidden_columns: string[] | undefined`\r\n\r\nThis proposed solution deviates from the one describe in the parent issue in a few ways.\r\n- `hideable` only supports `boolean`: supporting `boolean[]` makes it hard to give a consistent experience when toggling visibility while supporting making non-hideable but hidden columns visible if necessary. It also requires more complex UI interactions that are not obvious to define correctly.. also deviates from more simple column visibility ideas usually associated with spreadsheets\r\n- the on-hover UI that shows a dropdown / marker for hidden columns interacts badly with the existing actions inside the header cells\r\n\r\nSo,\r\n- columns can only be hidden one by one\r\n- with multiple header rows, the last row is the one with the `hide` action\r\n- making columns visible again is done through a dropdown / toggle columns button / menu that closes when the user clicks on something else than the menu itself\r\n\r\nWhile not ideal this solution should be flexible enough to make it possible for us to improve upon while not limiting our options.\r\n\r\n-----------------------------------\r\n\r\nOn a totally different note, with the addition of multiple actions in the header cells, the use of unicode characters is starting to be problematic as they hardly ever align correctly or feel consistent. With that in mind, introducing `fortawesome`, a JS / es6-aware (read: tree shaking) wrapper around Font-Awesome free icon library to be used for the actions.\r\n\r\n![image](https://user-images.githubusercontent.com/8092993/61757707-c0516880-ad8f-11e9-9100-933dfb2e4cab.png)\r\n\r\nOne of the goal of a previous PR was to make it easy for users to override the default icon with an icon of their choice. This is still possible with the proposed solution, but the selector(s) will be slightly different. As (a) the modified code w/ customization support has not been release yet and (b) this must be done through unofficial `css` props or custom stylesheet, this seems fine.","created_at":"2019-07-18T12:48:00Z","updated_at":"2019-08-01T15:26:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"735225de16ab233033b2cc79f3e5cab267a341ab","assignee":null,"assignees":[],"requested_reviewers":[{"login":"byronz","id":1394467,"node_id":"MDQ6VXNlcjEzOTQ0Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1394467?v=4","gravatar_id":"","url":"https://api.github.com/users/byronz","html_url":"https://github.com/byronz","followers_url":"https://api.github.com/users/byronz/followers","following_url":"https://api.github.com/users/byronz/following{/other_user}","gists_url":"https://api.github.com/users/byronz/gists{/gist_id}","starred_url":"https://api.github.com/users/byronz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byronz/subscriptions","organizations_url":"https://api.github.com/users/byronz/orgs","repos_url":"https://api.github.com/users/byronz/repos","events_url":"https://api.github.com/users/byronz/events{/privacy}","received_events_url":"https://api.github.com/users/byronz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/plotly/dash-table/pulls/508/commits","review_comments_url":"https://api.github.com/repos/plotly/dash-table/pulls/508/comments","review_comment_url":"https://api.github.com/repos/plotly/dash-table/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plotly/dash-table/issues/508/comments","statuses_url":"https://api.github.com/repos/plotly/dash-table/statuses/d01777c8462ceb1179662154171d589351028f9e","head":{"label":"plotly:314-hidden-columns","ref":"314-hidden-columns","sha":"d01777c8462ceb1179662154171d589351028f9e","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":128151266,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxNTEyNjY=","name":"dash-table","full_name":"plotly/dash-table","private":false,"owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/plotly/dash-table","description":"A First-Class Interactive DataTable for Dash ","fork":false,"url":"https://api.github.com/repos/plotly/dash-table","forks_url":"https://api.github.com/repos/plotly/dash-table/forks","keys_url":"https://api.github.com/repos/plotly/dash-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/dash-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/dash-table/teams","hooks_url":"https://api.github.com/repos/plotly/dash-table/hooks","issue_events_url":"https://api.github.com/repos/plotly/dash-table/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/dash-table/events","assignees_url":"https://api.github.com/repos/plotly/dash-table/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/dash-table/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/dash-table/tags","blobs_url":"https://api.github.com/repos/plotly/dash-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/dash-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/dash-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/dash-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/dash-table/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/dash-table/languages","stargazers_url":"https://api.github.com/repos/plotly/dash-table/stargazers","contributors_url":"https://api.github.com/repos/plotly/dash-table/contributors","subscribers_url":"https://api.github.com/repos/plotly/dash-table/subscribers","subscription_url":"https://api.github.com/repos/plotly/dash-table/subscription","commits_url":"https://api.github.com/repos/plotly/dash-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/dash-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/dash-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/dash-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/dash-table/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/dash-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/dash-table/merges","archive_url":"https://api.github.com/repos/plotly/dash-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/dash-table/downloads","issues_url":"https://api.github.com/repos/plotly/dash-table/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/dash-table/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/dash-table/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/dash-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/dash-table/labels{/name}","releases_url":"https://api.github.com/repos/plotly/dash-table/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/dash-table/deployments","created_at":"2018-04-05T02:45:57Z","updated_at":"2019-08-01T04:13:19Z","pushed_at":"2019-08-01T15:19:33Z","git_url":"git://github.com/plotly/dash-table.git","ssh_url":"git@github.com:plotly/dash-table.git","clone_url":"https://github.com/plotly/dash-table.git","svn_url":"https://github.com/plotly/dash-table","homepage":"https://dash.plot.ly/datatable","size":13506,"stargazers_count":210,"watchers_count":210,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":127,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":127,"watchers":210,"default_branch":"master"}},"base":{"label":"plotly:master","ref":"master","sha":"0ea08fa52e5d6cbaaf6a57e5eb8f616f2439c552","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":128151266,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxNTEyNjY=","name":"dash-table","full_name":"plotly/dash-table","private":false,"owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/plotly/dash-table","description":"A First-Class Interactive DataTable for Dash ","fork":false,"url":"https://api.github.com/repos/plotly/dash-table","forks_url":"https://api.github.com/repos/plotly/dash-table/forks","keys_url":"https://api.github.com/repos/plotly/dash-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/dash-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/dash-table/teams","hooks_url":"https://api.github.com/repos/plotly/dash-table/hooks","issue_events_url":"https://api.github.com/repos/plotly/dash-table/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/dash-table/events","assignees_url":"https://api.github.com/repos/plotly/dash-table/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/dash-table/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/dash-table/tags","blobs_url":"https://api.github.com/repos/plotly/dash-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/dash-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/dash-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/dash-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/dash-table/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/dash-table/languages","stargazers_url":"https://api.github.com/repos/plotly/dash-table/stargazers","contributors_url":"https://api.github.com/repos/plotly/dash-table/contributors","subscribers_url":"https://api.github.com/repos/plotly/dash-table/subscribers","subscription_url":"https://api.github.com/repos/plotly/dash-table/subscription","commits_url":"https://api.github.com/repos/plotly/dash-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/dash-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/dash-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/dash-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/dash-table/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/dash-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/dash-table/merges","archive_url":"https://api.github.com/repos/plotly/dash-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/dash-table/downloads","issues_url":"https://api.github.com/repos/plotly/dash-table/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/dash-table/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/dash-table/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/dash-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/dash-table/labels{/name}","releases_url":"https://api.github.com/repos/plotly/dash-table/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/dash-table/deployments","created_at":"2018-04-05T02:45:57Z","updated_at":"2019-08-01T04:13:19Z","pushed_at":"2019-08-01T15:19:33Z","git_url":"git://github.com/plotly/dash-table.git","ssh_url":"git@github.com:plotly/dash-table.git","clone_url":"https://github.com/plotly/dash-table.git","svn_url":"https://github.com/plotly/dash-table","homepage":"https://dash.plot.ly/datatable","size":13506,"stargazers_count":210,"watchers_count":210,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":127,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":127,"watchers":210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/508"},"html":{"href":"https://github.com/plotly/dash-table/pull/508"},"issue":{"href":"https://api.github.com/repos/plotly/dash-table/issues/508"},"comments":{"href":"https://api.github.com/repos/plotly/dash-table/issues/508/comments"},"review_comments":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/508/comments"},"review_comment":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/508/commits"},"statuses":{"href":"https://api.github.com/repos/plotly/dash-table/statuses/d01777c8462ceb1179662154171d589351028f9e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Marc-Andre-Rivet"}}