{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/267702120","pull_request_review_id":217170654,"id":267702120,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzcwMjEyMA==","diff_hunk":"@@ -684,7 +685,7 @@ def session_creator():\n             preprocessor_pref=config[\"preprocessor_pref\"],\n             sample_async=config[\"sample_async\"],\n             compress_observations=config[\"compress_observations\"],\n-            num_envs=config[\"num_envs_per_worker\"],\n+            num_envs=num_envs,","path":"python/ray/rllib/agents/agent.py","position":null,"original_position":49,"commit_id":"8c242796258c05508016cbdf4fe0f80afc697732","original_commit_id":"3f281819d5a9c470920f738e2b278da3aee047f3","user":{"login":"bjg2","id":6639273,"node_id":"MDQ6VXNlcjY2MzkyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6639273?v=4","gravatar_id":"","url":"https://api.github.com/users/bjg2","html_url":"https://github.com/bjg2","followers_url":"https://api.github.com/users/bjg2/followers","following_url":"https://api.github.com/users/bjg2/following{/other_user}","gists_url":"https://api.github.com/users/bjg2/gists{/gist_id}","starred_url":"https://api.github.com/users/bjg2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjg2/subscriptions","organizations_url":"https://api.github.com/users/bjg2/orgs","repos_url":"https://api.github.com/users/bjg2/repos","events_url":"https://api.github.com/users/bjg2/events{/privacy}","received_events_url":"https://api.github.com/users/bjg2/received_events","type":"User","site_admin":false},"body":"We can and I did. I was not aware of algos using local evaluator to compute samples.","created_at":"2019-03-21T10:47:56Z","updated_at":"2019-03-21T10:47:57Z","html_url":"https://github.com/ray-project/ray/pull/4435#discussion_r267702120","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/4435","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/267702120"},"html":{"href":"https://github.com/ray-project/ray/pull/4435#discussion_r267702120"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/4435"}},"in_reply_to_id":267636686},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/4435","id":262921576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyOTIxNTc2","html_url":"https://github.com/ray-project/ray/pull/4435","diff_url":"https://github.com/ray-project/ray/pull/4435.diff","patch_url":"https://github.com/ray-project/ray/pull/4435.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/4435","number":4435,"state":"open","locked":false,"title":"[rllib] Remote workers improvements","user":{"login":"bjg2","id":6639273,"node_id":"MDQ6VXNlcjY2MzkyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6639273?v=4","gravatar_id":"","url":"https://api.github.com/users/bjg2","html_url":"https://github.com/bjg2","followers_url":"https://api.github.com/users/bjg2/followers","following_url":"https://api.github.com/users/bjg2/following{/other_user}","gists_url":"https://api.github.com/users/bjg2/gists{/gist_id}","starred_url":"https://api.github.com/users/bjg2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjg2/subscriptions","organizations_url":"https://api.github.com/users/bjg2/orgs","repos_url":"https://api.github.com/users/bjg2/repos","events_url":"https://api.github.com/users/bjg2/events{/privacy}","received_events_url":"https://api.github.com/users/bjg2/received_events","type":"User","site_admin":false},"body":"## What do these changes do?\r\n\r\n- Removed `async_remote_worker_envs` arg and added `remote_worker_env_timeout_ms` one instead. Default is async (timeout 0), setting it to large number would be equal to sync, but timeout now can be set to any value. Some steps / resets in our envs can last much longer than others - this is mitigation for that.\r\n- Initiating local evaluator with `num_envs` 0. Local evaluator is not creating not-needed envs, and, especially important in the remote case, is not creating ray remote processes.\r\n- Added async way of sending reset in remote environments. Reset is a slow operation in some of our envs, and waiting for it one by one is super-bad for our performance. It is implemented half-hacky by checking if send_reset method exists, since I can't implement it the same for other case envs, as they need whole vector step at the same time (they need to have reset obs inferred right away).","created_at":"2019-03-20T15:40:52Z","updated_at":"2019-03-21T10:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"933b5d4c59d2289a080b71157b3bc48a6f35ebb8","assignee":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"assignees":[{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/4435/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/4435/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/4435/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/8c242796258c05508016cbdf4fe0f80afc697732","head":{"label":"wingman-ai:remote_improvements","ref":"remote_improvements","sha":"8c242796258c05508016cbdf4fe0f80afc697732","user":{"login":"wingman-ai","id":47114553,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MTE0NTUz","avatar_url":"https://avatars3.githubusercontent.com/u/47114553?v=4","gravatar_id":"","url":"https://api.github.com/users/wingman-ai","html_url":"https://github.com/wingman-ai","followers_url":"https://api.github.com/users/wingman-ai/followers","following_url":"https://api.github.com/users/wingman-ai/following{/other_user}","gists_url":"https://api.github.com/users/wingman-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/wingman-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingman-ai/subscriptions","organizations_url":"https://api.github.com/users/wingman-ai/orgs","repos_url":"https://api.github.com/users/wingman-ai/repos","events_url":"https://api.github.com/users/wingman-ai/events{/privacy}","received_events_url":"https://api.github.com/users/wingman-ai/received_events","type":"Organization","site_admin":false},"repo":{"id":167988246,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc5ODgyNDY=","name":"ray","full_name":"wingman-ai/ray","private":false,"owner":{"login":"wingman-ai","id":47114553,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MTE0NTUz","avatar_url":"https://avatars3.githubusercontent.com/u/47114553?v=4","gravatar_id":"","url":"https://api.github.com/users/wingman-ai","html_url":"https://github.com/wingman-ai","followers_url":"https://api.github.com/users/wingman-ai/followers","following_url":"https://api.github.com/users/wingman-ai/following{/other_user}","gists_url":"https://api.github.com/users/wingman-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/wingman-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingman-ai/subscriptions","organizations_url":"https://api.github.com/users/wingman-ai/orgs","repos_url":"https://api.github.com/users/wingman-ai/repos","events_url":"https://api.github.com/users/wingman-ai/events{/privacy}","received_events_url":"https://api.github.com/users/wingman-ai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wingman-ai/ray","description":"A system for parallel and distributed Python that unifies the ML ecosystem.","fork":true,"url":"https://api.github.com/repos/wingman-ai/ray","forks_url":"https://api.github.com/repos/wingman-ai/ray/forks","keys_url":"https://api.github.com/repos/wingman-ai/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wingman-ai/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wingman-ai/ray/teams","hooks_url":"https://api.github.com/repos/wingman-ai/ray/hooks","issue_events_url":"https://api.github.com/repos/wingman-ai/ray/issues/events{/number}","events_url":"https://api.github.com/repos/wingman-ai/ray/events","assignees_url":"https://api.github.com/repos/wingman-ai/ray/assignees{/user}","branches_url":"https://api.github.com/repos/wingman-ai/ray/branches{/branch}","tags_url":"https://api.github.com/repos/wingman-ai/ray/tags","blobs_url":"https://api.github.com/repos/wingman-ai/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wingman-ai/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wingman-ai/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/wingman-ai/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wingman-ai/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/wingman-ai/ray/languages","stargazers_url":"https://api.github.com/repos/wingman-ai/ray/stargazers","contributors_url":"https://api.github.com/repos/wingman-ai/ray/contributors","subscribers_url":"https://api.github.com/repos/wingman-ai/ray/subscribers","subscription_url":"https://api.github.com/repos/wingman-ai/ray/subscription","commits_url":"https://api.github.com/repos/wingman-ai/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/wingman-ai/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/wingman-ai/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/wingman-ai/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/wingman-ai/ray/contents/{+path}","compare_url":"https://api.github.com/repos/wingman-ai/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wingman-ai/ray/merges","archive_url":"https://api.github.com/repos/wingman-ai/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wingman-ai/ray/downloads","issues_url":"https://api.github.com/repos/wingman-ai/ray/issues{/number}","pulls_url":"https://api.github.com/repos/wingman-ai/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/wingman-ai/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/wingman-ai/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wingman-ai/ray/labels{/name}","releases_url":"https://api.github.com/repos/wingman-ai/ray/releases{/id}","deployments_url":"https://api.github.com/repos/wingman-ai/ray/deployments","created_at":"2019-01-28T15:47:18Z","updated_at":"2019-03-21T08:13:38Z","pushed_at":"2019-03-21T10:47:20Z","git_url":"git://github.com/wingman-ai/ray.git","ssh_url":"git@github.com:wingman-ai/ray.git","clone_url":"https://github.com/wingman-ai/ray.git","svn_url":"https://github.com/wingman-ai/ray","homepage":"https://ray.readthedocs.io/en/latest/","size":21397,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"57c1aeb427fa116790a16c17777ce944ccb5666c","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","private":false,"owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ray-project/ray","description":"A system for parallel and distributed Python that unifies the ML ecosystem.","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2019-03-21T08:39:46Z","pushed_at":"2019-03-21T10:47:29Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"https://ray.readthedocs.io/en/latest/","size":21034,"stargazers_count":6279,"watchers_count":6279,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":859,"mirror_url":null,"archived":false,"open_issues_count":604,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":859,"open_issues":604,"watchers":6279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/4435"},"html":{"href":"https://github.com/ray-project/ray/pull/4435"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/4435"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/4435/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/4435/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/4435/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/8c242796258c05508016cbdf4fe0f80afc697732"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bjg2"}}