{"action":"created","comment":{"url":"https://api.github.com/repos/datastax/nodejs-driver/pulls/comments/329492375","pull_request_review_id":294860180,"id":329492375,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTQ5MjM3NQ==","diff_hunk":"@@ -128,27 +128,27 @@ export namespace mapping {\n     update(doc: any, docInfo?: UpdateDocInfo): ModelBatchItem;\n   }\n \n-  interface ModelMapper {\n+  interface ModelMapper<T = { [key: string]: any }> {","path":"lib/mapping/index.d.ts","position":33,"original_position":33,"commit_id":"637a46ade3ebc96b16def94a55b0e850d9ec0bfc","original_commit_id":"637a46ade3ebc96b16def94a55b0e850d9ec0bfc","user":{"login":"koriwi","id":6781497,"node_id":"MDQ6VXNlcjY3ODE0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6781497?v=4","gravatar_id":"","url":"https://api.github.com/users/koriwi","html_url":"https://github.com/koriwi","followers_url":"https://api.github.com/users/koriwi/followers","following_url":"https://api.github.com/users/koriwi/following{/other_user}","gists_url":"https://api.github.com/users/koriwi/gists{/gist_id}","starred_url":"https://api.github.com/users/koriwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koriwi/subscriptions","organizations_url":"https://api.github.com/users/koriwi/orgs","repos_url":"https://api.github.com/users/koriwi/repos","events_url":"https://api.github.com/users/koriwi/events{/privacy}","received_events_url":"https://api.github.com/users/koriwi/received_events","type":"User","site_admin":false},"body":"I can't think of any case where you need any.\r\nIf you want backwards compatibility, we can just change it to:\r\n`interface ModelMapper<T = any }> {`","created_at":"2019-09-30T09:44:30Z","updated_at":"2019-09-30T09:44:30Z","html_url":"https://github.com/datastax/nodejs-driver/pull/338#discussion_r329492375","pull_request_url":"https://api.github.com/repos/datastax/nodejs-driver/pulls/338","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/datastax/nodejs-driver/pulls/comments/329492375"},"html":{"href":"https://github.com/datastax/nodejs-driver/pull/338#discussion_r329492375"},"pull_request":{"href":"https://api.github.com/repos/datastax/nodejs-driver/pulls/338"}},"in_reply_to_id":329477733},"pull_request":{"url":"https://api.github.com/repos/datastax/nodejs-driver/pulls/338","id":321665628,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxNjY1NjI4","html_url":"https://github.com/datastax/nodejs-driver/pull/338","diff_url":"https://github.com/datastax/nodejs-driver/pull/338.diff","patch_url":"https://github.com/datastax/nodejs-driver/pull/338.patch","issue_url":"https://api.github.com/repos/datastax/nodejs-driver/issues/338","number":338,"state":"open","locked":false,"title":"feat(ts): add generic to mapper","user":{"login":"koriwi","id":6781497,"node_id":"MDQ6VXNlcjY3ODE0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6781497?v=4","gravatar_id":"","url":"https://api.github.com/users/koriwi","html_url":"https://github.com/koriwi","followers_url":"https://api.github.com/users/koriwi/followers","following_url":"https://api.github.com/users/koriwi/following{/other_user}","gists_url":"https://api.github.com/users/koriwi/gists{/gist_id}","starred_url":"https://api.github.com/users/koriwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koriwi/subscriptions","organizations_url":"https://api.github.com/users/koriwi/orgs","repos_url":"https://api.github.com/users/koriwi/repos","events_url":"https://api.github.com/users/koriwi/events{/privacy}","received_events_url":"https://api.github.com/users/koriwi/received_events","type":"User","site_admin":false},"body":"may i propose these changes?\r\nI modified the DefinetlyTyped typings before and used them with 100% success.\r\nTried to port them to your official typings now.","created_at":"2019-09-26T11:09:04Z","updated_at":"2019-09-30T09:44:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5431da9659cd9ce2b4df0b4b95f69632b04f46bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/datastax/nodejs-driver/pulls/338/commits","review_comments_url":"https://api.github.com/repos/datastax/nodejs-driver/pulls/338/comments","review_comment_url":"https://api.github.com/repos/datastax/nodejs-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datastax/nodejs-driver/issues/338/comments","statuses_url":"https://api.github.com/repos/datastax/nodejs-driver/statuses/637a46ade3ebc96b16def94a55b0e850d9ec0bfc","head":{"label":"koriwi:typescript_generic","ref":"typescript_generic","sha":"637a46ade3ebc96b16def94a55b0e850d9ec0bfc","user":{"login":"koriwi","id":6781497,"node_id":"MDQ6VXNlcjY3ODE0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6781497?v=4","gravatar_id":"","url":"https://api.github.com/users/koriwi","html_url":"https://github.com/koriwi","followers_url":"https://api.github.com/users/koriwi/followers","following_url":"https://api.github.com/users/koriwi/following{/other_user}","gists_url":"https://api.github.com/users/koriwi/gists{/gist_id}","starred_url":"https://api.github.com/users/koriwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koriwi/subscriptions","organizations_url":"https://api.github.com/users/koriwi/orgs","repos_url":"https://api.github.com/users/koriwi/repos","events_url":"https://api.github.com/users/koriwi/events{/privacy}","received_events_url":"https://api.github.com/users/koriwi/received_events","type":"User","site_admin":false},"repo":{"id":198405566,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg0MDU1NjY=","name":"nodejs-driver","full_name":"koriwi/nodejs-driver","private":false,"owner":{"login":"koriwi","id":6781497,"node_id":"MDQ6VXNlcjY3ODE0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6781497?v=4","gravatar_id":"","url":"https://api.github.com/users/koriwi","html_url":"https://github.com/koriwi","followers_url":"https://api.github.com/users/koriwi/followers","following_url":"https://api.github.com/users/koriwi/following{/other_user}","gists_url":"https://api.github.com/users/koriwi/gists{/gist_id}","starred_url":"https://api.github.com/users/koriwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koriwi/subscriptions","organizations_url":"https://api.github.com/users/koriwi/orgs","repos_url":"https://api.github.com/users/koriwi/repos","events_url":"https://api.github.com/users/koriwi/events{/privacy}","received_events_url":"https://api.github.com/users/koriwi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/koriwi/nodejs-driver","description":"DataStax Node.js Driver for Apache Cassandra","fork":true,"url":"https://api.github.com/repos/koriwi/nodejs-driver","forks_url":"https://api.github.com/repos/koriwi/nodejs-driver/forks","keys_url":"https://api.github.com/repos/koriwi/nodejs-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koriwi/nodejs-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koriwi/nodejs-driver/teams","hooks_url":"https://api.github.com/repos/koriwi/nodejs-driver/hooks","issue_events_url":"https://api.github.com/repos/koriwi/nodejs-driver/issues/events{/number}","events_url":"https://api.github.com/repos/koriwi/nodejs-driver/events","assignees_url":"https://api.github.com/repos/koriwi/nodejs-driver/assignees{/user}","branches_url":"https://api.github.com/repos/koriwi/nodejs-driver/branches{/branch}","tags_url":"https://api.github.com/repos/koriwi/nodejs-driver/tags","blobs_url":"https://api.github.com/repos/koriwi/nodejs-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koriwi/nodejs-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koriwi/nodejs-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/koriwi/nodejs-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koriwi/nodejs-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/koriwi/nodejs-driver/languages","stargazers_url":"https://api.github.com/repos/koriwi/nodejs-driver/stargazers","contributors_url":"https://api.github.com/repos/koriwi/nodejs-driver/contributors","subscribers_url":"https://api.github.com/repos/koriwi/nodejs-driver/subscribers","subscription_url":"https://api.github.com/repos/koriwi/nodejs-driver/subscription","commits_url":"https://api.github.com/repos/koriwi/nodejs-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/koriwi/nodejs-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/koriwi/nodejs-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/koriwi/nodejs-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/koriwi/nodejs-driver/contents/{+path}","compare_url":"https://api.github.com/repos/koriwi/nodejs-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koriwi/nodejs-driver/merges","archive_url":"https://api.github.com/repos/koriwi/nodejs-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koriwi/nodejs-driver/downloads","issues_url":"https://api.github.com/repos/koriwi/nodejs-driver/issues{/number}","pulls_url":"https://api.github.com/repos/koriwi/nodejs-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/koriwi/nodejs-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/koriwi/nodejs-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koriwi/nodejs-driver/labels{/name}","releases_url":"https://api.github.com/repos/koriwi/nodejs-driver/releases{/id}","deployments_url":"https://api.github.com/repos/koriwi/nodejs-driver/deployments","created_at":"2019-07-23T10:13:35Z","updated_at":"2019-09-26T11:14:26Z","pushed_at":"2019-09-26T15:49:23Z","git_url":"git://github.com/koriwi/nodejs-driver.git","ssh_url":"git@github.com:koriwi/nodejs-driver.git","clone_url":"https://github.com/koriwi/nodejs-driver.git","svn_url":"https://github.com/koriwi/nodejs-driver","homepage":null,"size":4766,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"datastax:master","ref":"master","sha":"a2e9edeba4cda397984fccd6d631c1f3427961b3","user":{"login":"datastax","id":573369,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzM2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/573369?v=4","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"repo":{"id":23706552,"node_id":"MDEwOlJlcG9zaXRvcnkyMzcwNjU1Mg==","name":"nodejs-driver","full_name":"datastax/nodejs-driver","private":false,"owner":{"login":"datastax","id":573369,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzM2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/573369?v=4","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/datastax/nodejs-driver","description":"DataStax Node.js Driver for Apache Cassandra","fork":false,"url":"https://api.github.com/repos/datastax/nodejs-driver","forks_url":"https://api.github.com/repos/datastax/nodejs-driver/forks","keys_url":"https://api.github.com/repos/datastax/nodejs-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datastax/nodejs-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datastax/nodejs-driver/teams","hooks_url":"https://api.github.com/repos/datastax/nodejs-driver/hooks","issue_events_url":"https://api.github.com/repos/datastax/nodejs-driver/issues/events{/number}","events_url":"https://api.github.com/repos/datastax/nodejs-driver/events","assignees_url":"https://api.github.com/repos/datastax/nodejs-driver/assignees{/user}","branches_url":"https://api.github.com/repos/datastax/nodejs-driver/branches{/branch}","tags_url":"https://api.github.com/repos/datastax/nodejs-driver/tags","blobs_url":"https://api.github.com/repos/datastax/nodejs-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datastax/nodejs-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datastax/nodejs-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/datastax/nodejs-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datastax/nodejs-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/datastax/nodejs-driver/languages","stargazers_url":"https://api.github.com/repos/datastax/nodejs-driver/stargazers","contributors_url":"https://api.github.com/repos/datastax/nodejs-driver/contributors","subscribers_url":"https://api.github.com/repos/datastax/nodejs-driver/subscribers","subscription_url":"https://api.github.com/repos/datastax/nodejs-driver/subscription","commits_url":"https://api.github.com/repos/datastax/nodejs-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/datastax/nodejs-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/datastax/nodejs-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/datastax/nodejs-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/datastax/nodejs-driver/contents/{+path}","compare_url":"https://api.github.com/repos/datastax/nodejs-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datastax/nodejs-driver/merges","archive_url":"https://api.github.com/repos/datastax/nodejs-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datastax/nodejs-driver/downloads","issues_url":"https://api.github.com/repos/datastax/nodejs-driver/issues{/number}","pulls_url":"https://api.github.com/repos/datastax/nodejs-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/datastax/nodejs-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/datastax/nodejs-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datastax/nodejs-driver/labels{/name}","releases_url":"https://api.github.com/repos/datastax/nodejs-driver/releases{/id}","deployments_url":"https://api.github.com/repos/datastax/nodejs-driver/deployments","created_at":"2014-09-05T14:46:37Z","updated_at":"2019-09-28T00:23:30Z","pushed_at":"2019-09-26T15:46:51Z","git_url":"git://github.com/datastax/nodejs-driver.git","ssh_url":"git@github.com:datastax/nodejs-driver.git","clone_url":"https://github.com/datastax/nodejs-driver.git","svn_url":"https://github.com/datastax/nodejs-driver","homepage":null,"size":4746,"stargazers_count":917,"watchers_count":917,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":148,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":148,"open_issues":3,"watchers":917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datastax/nodejs-driver/pulls/338"},"html":{"href":"https://github.com/datastax/nodejs-driver/pull/338"},"issue":{"href":"https://api.github.com/repos/datastax/nodejs-driver/issues/338"},"comments":{"href":"https://api.github.com/repos/datastax/nodejs-driver/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/datastax/nodejs-driver/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/datastax/nodejs-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datastax/nodejs-driver/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/datastax/nodejs-driver/statuses/637a46ade3ebc96b16def94a55b0e850d9ec0bfc"}},"author_association":"NONE"}}
{"actor":{"display_login":"koriwi"}}