{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/341810160","pull_request_review_id":310769450,"id":341810160,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTgxMDE2MA==","diff_hunk":"@@ -388,12 +388,9 @@ def test_issue_10198():\n \n \n def test_issue_10047():\n-    # issue 10047: this must remain an inequality, not True, since if x\n-    # is not real the inequality is invalid\n-    # assert solve(sin(x) < 2) == (x <= oo)\n-\n     # with PR 16956, (x <= oo) autoevaluates when x is extended_real\n     assert solve(sin(x) < 2) == True","path":"sympy/solvers/tests/test_inequalities.py","position":9,"original_position":9,"commit_id":"c9ca88c7b8b7b8dad74a13a411f52d5b6ed0bd20","original_commit_id":"c9ca88c7b8b7b8dad74a13a411f52d5b6ed0bd20","user":{"login":"smichr","id":90703,"node_id":"MDQ6VXNlcjkwNzAz","avatar_url":"https://avatars3.githubusercontent.com/u/90703?v=4","gravatar_id":"","url":"https://api.github.com/users/smichr","html_url":"https://github.com/smichr","followers_url":"https://api.github.com/users/smichr/followers","following_url":"https://api.github.com/users/smichr/following{/other_user}","gists_url":"https://api.github.com/users/smichr/gists{/gist_id}","starred_url":"https://api.github.com/users/smichr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smichr/subscriptions","organizations_url":"https://api.github.com/users/smichr/orgs","repos_url":"https://api.github.com/users/smichr/repos","events_url":"https://api.github.com/users/smichr/events{/privacy}","received_events_url":"https://api.github.com/users/smichr/received_events","type":"User","site_admin":false},"body":"This really shouldn't be evaluating as True for reasons given in the comment that you deleted. `x` was not declared in this file to be `extended_real` so this shouldn't have evaluated. If it does (and did at the time of the comment) it should be opened as an issue. Please leave the comment and put a \"# XXX need to fix\" instead of deleting the comment.","created_at":"2019-11-02T12:49:59Z","updated_at":"2019-11-02T12:49:59Z","html_url":"https://github.com/sympy/sympy/pull/17825#discussion_r341810160","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/17825","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/341810160"},"html":{"href":"https://github.com/sympy/sympy/pull/17825#discussion_r341810160"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/17825"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/17825","id":334550088,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0NTUwMDg4","html_url":"https://github.com/sympy/sympy/pull/17825","diff_url":"https://github.com/sympy/sympy/pull/17825.diff","patch_url":"https://github.com/sympy/sympy/pull/17825.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/17825","number":17825,"state":"open","locked":false,"title":"Reorganization to reduce duplicate code","user":{"login":"warnerjon12","id":31259668,"node_id":"MDQ6VXNlcjMxMjU5NjY4","avatar_url":"https://avatars3.githubusercontent.com/u/31259668?v=4","gravatar_id":"","url":"https://api.github.com/users/warnerjon12","html_url":"https://github.com/warnerjon12","followers_url":"https://api.github.com/users/warnerjon12/followers","following_url":"https://api.github.com/users/warnerjon12/following{/other_user}","gists_url":"https://api.github.com/users/warnerjon12/gists{/gist_id}","starred_url":"https://api.github.com/users/warnerjon12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warnerjon12/subscriptions","organizations_url":"https://api.github.com/users/warnerjon12/orgs","repos_url":"https://api.github.com/users/warnerjon12/repos","events_url":"https://api.github.com/users/warnerjon12/events{/privacy}","received_events_url":"https://api.github.com/users/warnerjon12/received_events","type":"User","site_admin":false},"body":"<!-- Your title above should be a short description of what\r\nwas changed. Do not include the issue number in the title. -->\r\n\r\n#### References to other Issues or PRs\r\n<!-- If this pull request fixes an issue, write \"Fixes #NNNN\" in that exact\r\nformat, e.g. \"Fixes #1234\". See\r\nhttps://github.com/blog/1506-closing-issues-via-pull-requests . Please also\r\nwrite a comment on that issue linking back to this pull request once it is\r\nopen. -->\r\nPartially fixes #10047\r\n\r\n#### Brief description of what is fixed or changed\r\nReorganized some of the code to reduce duplicate code and encourage code reuse\r\n\r\n#### Other comments\r\nMakes the code more maintainable\r\n\r\n#### Release Notes\r\n\r\n<!-- Write the release notes for this release below. See\r\nhttps://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information\r\non how to write release notes. The bot will check your release notes\r\nautomatically to see if they are formatted correctly. -->\r\n\r\n<!-- BEGIN RELEASE NOTES -->\r\nNO ENTRY\r\n<!-- END RELEASE NOTES -->\r\n","created_at":"2019-10-30T22:27:30Z","updated_at":"2019-11-02T12:49:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fee79e88d87c00e0cf15aa21a044709809348a9b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1209049874,"node_id":"MDU6TGFiZWwxMjA5MDQ5ODc0","url":"https://api.github.com/repos/sympy/sympy/labels/Code%20quality","name":"Code quality","color":"cccccc","default":false},{"id":83720928,"node_id":"MDU6TGFiZWw4MzcyMDkyOA==","url":"https://api.github.com/repos/sympy/sympy/labels/core","name":"core","color":"0000FF","default":false},{"id":84627360,"node_id":"MDU6TGFiZWw4NDYyNzM2MA==","url":"https://api.github.com/repos/sympy/sympy/labels/solvers","name":"solvers","color":"0000FF","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/17825/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/17825/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/17825/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/c9ca88c7b8b7b8dad74a13a411f52d5b6ed0bd20","head":{"label":"warnerjon12:organization","ref":"organization","sha":"c9ca88c7b8b7b8dad74a13a411f52d5b6ed0bd20","user":{"login":"warnerjon12","id":31259668,"node_id":"MDQ6VXNlcjMxMjU5NjY4","avatar_url":"https://avatars3.githubusercontent.com/u/31259668?v=4","gravatar_id":"","url":"https://api.github.com/users/warnerjon12","html_url":"https://github.com/warnerjon12","followers_url":"https://api.github.com/users/warnerjon12/followers","following_url":"https://api.github.com/users/warnerjon12/following{/other_user}","gists_url":"https://api.github.com/users/warnerjon12/gists{/gist_id}","starred_url":"https://api.github.com/users/warnerjon12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warnerjon12/subscriptions","organizations_url":"https://api.github.com/users/warnerjon12/orgs","repos_url":"https://api.github.com/users/warnerjon12/repos","events_url":"https://api.github.com/users/warnerjon12/events{/privacy}","received_events_url":"https://api.github.com/users/warnerjon12/received_events","type":"User","site_admin":false},"repo":{"id":151283215,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyODMyMTU=","name":"sympy","full_name":"warnerjon12/sympy","private":false,"owner":{"login":"warnerjon12","id":31259668,"node_id":"MDQ6VXNlcjMxMjU5NjY4","avatar_url":"https://avatars3.githubusercontent.com/u/31259668?v=4","gravatar_id":"","url":"https://api.github.com/users/warnerjon12","html_url":"https://github.com/warnerjon12","followers_url":"https://api.github.com/users/warnerjon12/followers","following_url":"https://api.github.com/users/warnerjon12/following{/other_user}","gists_url":"https://api.github.com/users/warnerjon12/gists{/gist_id}","starred_url":"https://api.github.com/users/warnerjon12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warnerjon12/subscriptions","organizations_url":"https://api.github.com/users/warnerjon12/orgs","repos_url":"https://api.github.com/users/warnerjon12/repos","events_url":"https://api.github.com/users/warnerjon12/events{/privacy}","received_events_url":"https://api.github.com/users/warnerjon12/received_events","type":"User","site_admin":false},"html_url":"https://github.com/warnerjon12/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/warnerjon12/sympy","forks_url":"https://api.github.com/repos/warnerjon12/sympy/forks","keys_url":"https://api.github.com/repos/warnerjon12/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/warnerjon12/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/warnerjon12/sympy/teams","hooks_url":"https://api.github.com/repos/warnerjon12/sympy/hooks","issue_events_url":"https://api.github.com/repos/warnerjon12/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/warnerjon12/sympy/events","assignees_url":"https://api.github.com/repos/warnerjon12/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/warnerjon12/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/warnerjon12/sympy/tags","blobs_url":"https://api.github.com/repos/warnerjon12/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/warnerjon12/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/warnerjon12/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/warnerjon12/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/warnerjon12/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/warnerjon12/sympy/languages","stargazers_url":"https://api.github.com/repos/warnerjon12/sympy/stargazers","contributors_url":"https://api.github.com/repos/warnerjon12/sympy/contributors","subscribers_url":"https://api.github.com/repos/warnerjon12/sympy/subscribers","subscription_url":"https://api.github.com/repos/warnerjon12/sympy/subscription","commits_url":"https://api.github.com/repos/warnerjon12/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/warnerjon12/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/warnerjon12/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/warnerjon12/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/warnerjon12/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/warnerjon12/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/warnerjon12/sympy/merges","archive_url":"https://api.github.com/repos/warnerjon12/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/warnerjon12/sympy/downloads","issues_url":"https://api.github.com/repos/warnerjon12/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/warnerjon12/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/warnerjon12/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/warnerjon12/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/warnerjon12/sympy/labels{/name}","releases_url":"https://api.github.com/repos/warnerjon12/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/warnerjon12/sympy/deployments","created_at":"2018-10-02T16:04:23Z","updated_at":"2018-10-23T04:10:10Z","pushed_at":"2019-11-02T00:33:38Z","git_url":"git://github.com/warnerjon12/sympy.git","ssh_url":"git@github.com:warnerjon12/sympy.git","clone_url":"https://github.com/warnerjon12/sympy.git","svn_url":"https://github.com/warnerjon12/sympy","homepage":"https://sympy.org/","size":114523,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"cf43f87f5d145f2589cee8a79d0f20bbdf9eb075","user":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MzQ=","name":"sympy","full_name":"sympy/sympy","private":false,"owner":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2019-11-02T07:47:43Z","pushed_at":"2019-11-02T11:30:16Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"https://sympy.org/","size":114947,"stargazers_count":6339,"watchers_count":6339,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2757,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3609,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2757,"open_issues":3609,"watchers":6339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/17825"},"html":{"href":"https://github.com/sympy/sympy/pull/17825"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/17825"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/17825/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/17825/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/17825/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/c9ca88c7b8b7b8dad74a13a411f52d5b6ed0bd20"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"smichr"}}