{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/277799905","pull_request_review_id":229705006,"id":277799905,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Nzc5OTkwNQ==","diff_hunk":"@@ -0,0 +1,154 @@\n+#define DEBUG_TYPE \"opaque-archetype-specializer\"\n+\n+#include \"swift/SIL/SILFunction.h\"\n+#include \"swift/SIL/TypeSubstCloner.h\"\n+#include \"swift/SIL/SILInstruction.h\"\n+#include \"swift/SILOptimizer/PassManager/Transforms.h\"\n+\n+\n+using namespace swift;\n+\n+namespace {\n+class OpaqueSpecializerCloner\n+    : public TypeSubstCloner<OpaqueSpecializerCloner,\n+                      SILOptFunctionBuilder /*unused*/> {\n+\n+  using SuperTy =\n+      TypeSubstCloner<OpaqueSpecializerCloner, SILOptFunctionBuilder>;\n+\n+  SILBasicBlock *entryBlock;\n+  SILBasicBlock *cloneFromBlock;\n+\n+public:\n+  friend class SILCloner<OpaqueSpecializerCloner>;\n+  OpaqueSpecializerCloner(SubstitutionMap opaqueArchetypeSubs, SILFunction &fun)\n+      : SuperTy(fun, fun, opaqueArchetypeSubs) {\n+    entryBlock = fun.getEntryBlock();\n+    cloneFromBlock = entryBlock->split(entryBlock->begin());\n+  }\n+\n+  void clone();\n+\n+protected:\n+  void insertOpaqueToConcreteAddressCasts(SILInstruction *orig,\n+                                          SILInstruction *cloned);\n+\n+  void postProcess(SILInstruction *orig, SILInstruction *cloned) {\n+    SILClonerWithScopes<OpaqueSpecializerCloner>::postProcess(orig, cloned);\n+    insertOpaqueToConcreteAddressCasts(orig, cloned);\n+  }\n+\n+  void visitTerminator(SILBasicBlock *BB) { visit(BB->getTerminator()); }\n+\n+  SILType remapType(SILType Ty) {\n+    SILType &Sty = TypeCache[Ty];\n+    if (!Sty) {\n+      // Apply the opaque types substitution.\n+      ReplaceOpaqueTypesWithUnderlyingTypes replacer;\n+      Sty = Ty.subst(Original.getModule(), SubsMap)\n+                .subst(Original.getModule(), replacer, replacer,\n+                       CanGenericSignature(), true);\n+    }\n+    return Sty;\n+  }\n+\n+  CanType remapASTType(CanType ty) {\n+    // Apply the opaque types substitution.\n+    ReplaceOpaqueTypesWithUnderlyingTypes replacer;\n+    return SuperTy::remapASTType(ty)\n+        .subst(replacer, replacer,\n+               SubstFlags::SubstituteOpaqueArchetypes |\n+                   SubstFlags::AllowLoweredTypes)","path":"lib/SILOptimizer/Transforms/SpecializeOpaqueArchetypes.cpp","position":106,"original_position":61,"commit_id":"14089c1644d204ea2f9ff4b1a469b5613b98fbd1","original_commit_id":"612a87f910bb9451a12b585bb13a6912e62fe8a2","user":{"login":"aschwaighofer","id":15268288,"node_id":"MDQ6VXNlcjE1MjY4Mjg4","avatar_url":"https://avatars2.githubusercontent.com/u/15268288?v=4","gravatar_id":"","url":"https://api.github.com/users/aschwaighofer","html_url":"https://github.com/aschwaighofer","followers_url":"https://api.github.com/users/aschwaighofer/followers","following_url":"https://api.github.com/users/aschwaighofer/following{/other_user}","gists_url":"https://api.github.com/users/aschwaighofer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschwaighofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschwaighofer/subscriptions","organizations_url":"https://api.github.com/users/aschwaighofer/orgs","repos_url":"https://api.github.com/users/aschwaighofer/repos","events_url":"https://api.github.com/users/aschwaighofer/events{/privacy}","received_events_url":"https://api.github.com/users/aschwaighofer/received_events","type":"User","site_admin":false},"body":"clang-format does that.","created_at":"2019-04-23T17:54:35Z","updated_at":"2019-04-23T17:54:36Z","html_url":"https://github.com/apple/swift/pull/24201#discussion_r277799905","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/24201","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/277799905"},"html":{"href":"https://github.com/apple/swift/pull/24201#discussion_r277799905"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/24201"}},"in_reply_to_id":277485404},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/24201","id":272408457,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyNDA4NDU3","html_url":"https://github.com/apple/swift/pull/24201","diff_url":"https://github.com/apple/swift/pull/24201.diff","patch_url":"https://github.com/apple/swift/pull/24201.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/24201","number":24201,"state":"open","locked":false,"title":"Opaque result types: dynamic replacement and specialization","user":{"login":"aschwaighofer","id":15268288,"node_id":"MDQ6VXNlcjE1MjY4Mjg4","avatar_url":"https://avatars2.githubusercontent.com/u/15268288?v=4","gravatar_id":"","url":"https://api.github.com/users/aschwaighofer","html_url":"https://github.com/aschwaighofer","followers_url":"https://api.github.com/users/aschwaighofer/followers","following_url":"https://api.github.com/users/aschwaighofer/following{/other_user}","gists_url":"https://api.github.com/users/aschwaighofer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschwaighofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschwaighofer/subscriptions","organizations_url":"https://api.github.com/users/aschwaighofer/orgs","repos_url":"https://api.github.com/users/aschwaighofer/repos","events_url":"https://api.github.com/users/aschwaighofer/events{/privacy}","received_events_url":"https://api.github.com/users/aschwaighofer/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2019-04-22T15:36:57Z","updated_at":"2019-04-23T17:54:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f5ba4136c7793555eed3cd03b3eed8d028dda20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/24201/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/24201/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/24201/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/14089c1644d204ea2f9ff4b1a469b5613b98fbd1","head":{"label":"aschwaighofer:opaque_result_types_dyn_replacement_and_specialization","ref":"opaque_result_types_dyn_replacement_and_specialization","sha":"14089c1644d204ea2f9ff4b1a469b5613b98fbd1","user":{"login":"aschwaighofer","id":15268288,"node_id":"MDQ6VXNlcjE1MjY4Mjg4","avatar_url":"https://avatars2.githubusercontent.com/u/15268288?v=4","gravatar_id":"","url":"https://api.github.com/users/aschwaighofer","html_url":"https://github.com/aschwaighofer","followers_url":"https://api.github.com/users/aschwaighofer/followers","following_url":"https://api.github.com/users/aschwaighofer/following{/other_user}","gists_url":"https://api.github.com/users/aschwaighofer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschwaighofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschwaighofer/subscriptions","organizations_url":"https://api.github.com/users/aschwaighofer/orgs","repos_url":"https://api.github.com/users/aschwaighofer/repos","events_url":"https://api.github.com/users/aschwaighofer/events{/privacy}","received_events_url":"https://api.github.com/users/aschwaighofer/received_events","type":"User","site_admin":false},"repo":{"id":47787198,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzc4NzE5OA==","name":"swift","full_name":"aschwaighofer/swift","private":false,"owner":{"login":"aschwaighofer","id":15268288,"node_id":"MDQ6VXNlcjE1MjY4Mjg4","avatar_url":"https://avatars2.githubusercontent.com/u/15268288?v=4","gravatar_id":"","url":"https://api.github.com/users/aschwaighofer","html_url":"https://github.com/aschwaighofer","followers_url":"https://api.github.com/users/aschwaighofer/followers","following_url":"https://api.github.com/users/aschwaighofer/following{/other_user}","gists_url":"https://api.github.com/users/aschwaighofer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschwaighofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschwaighofer/subscriptions","organizations_url":"https://api.github.com/users/aschwaighofer/orgs","repos_url":"https://api.github.com/users/aschwaighofer/repos","events_url":"https://api.github.com/users/aschwaighofer/events{/privacy}","received_events_url":"https://api.github.com/users/aschwaighofer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aschwaighofer/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/aschwaighofer/swift","forks_url":"https://api.github.com/repos/aschwaighofer/swift/forks","keys_url":"https://api.github.com/repos/aschwaighofer/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aschwaighofer/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aschwaighofer/swift/teams","hooks_url":"https://api.github.com/repos/aschwaighofer/swift/hooks","issue_events_url":"https://api.github.com/repos/aschwaighofer/swift/issues/events{/number}","events_url":"https://api.github.com/repos/aschwaighofer/swift/events","assignees_url":"https://api.github.com/repos/aschwaighofer/swift/assignees{/user}","branches_url":"https://api.github.com/repos/aschwaighofer/swift/branches{/branch}","tags_url":"https://api.github.com/repos/aschwaighofer/swift/tags","blobs_url":"https://api.github.com/repos/aschwaighofer/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aschwaighofer/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aschwaighofer/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/aschwaighofer/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aschwaighofer/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/aschwaighofer/swift/languages","stargazers_url":"https://api.github.com/repos/aschwaighofer/swift/stargazers","contributors_url":"https://api.github.com/repos/aschwaighofer/swift/contributors","subscribers_url":"https://api.github.com/repos/aschwaighofer/swift/subscribers","subscription_url":"https://api.github.com/repos/aschwaighofer/swift/subscription","commits_url":"https://api.github.com/repos/aschwaighofer/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/aschwaighofer/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/aschwaighofer/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/aschwaighofer/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/aschwaighofer/swift/contents/{+path}","compare_url":"https://api.github.com/repos/aschwaighofer/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aschwaighofer/swift/merges","archive_url":"https://api.github.com/repos/aschwaighofer/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aschwaighofer/swift/downloads","issues_url":"https://api.github.com/repos/aschwaighofer/swift/issues{/number}","pulls_url":"https://api.github.com/repos/aschwaighofer/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/aschwaighofer/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/aschwaighofer/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aschwaighofer/swift/labels{/name}","releases_url":"https://api.github.com/repos/aschwaighofer/swift/releases{/id}","deployments_url":"https://api.github.com/repos/aschwaighofer/swift/deployments","created_at":"2015-12-10T21:01:21Z","updated_at":"2019-04-22T14:26:45Z","pushed_at":"2019-04-23T17:53:45Z","git_url":"git://github.com/aschwaighofer/swift.git","ssh_url":"git@github.com:aschwaighofer/swift.git","clone_url":"https://github.com/aschwaighofer/swift.git","svn_url":"https://github.com/aschwaighofer/swift","homepage":"","size":378382,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"904ba9bafe1f0a59c52ad8eda014a504163c98f3","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2019-04-23T17:31:24Z","pushed_at":"2019-04-23T17:53:48Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":412021,"stargazers_count":47461,"watchers_count":47461,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7526,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":527,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7526,"open_issues":527,"watchers":47461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/24201"},"html":{"href":"https://github.com/apple/swift/pull/24201"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/24201"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/24201/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/24201/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/24201/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/14089c1644d204ea2f9ff4b1a469b5613b98fbd1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aschwaighofer"}}