{"action":"created","issue":{"url":"https://api.github.com/repos/SUSE/scf/issues/2865","repository_url":"https://api.github.com/repos/SUSE/scf","labels_url":"https://api.github.com/repos/SUSE/scf/issues/2865/labels{/name}","comments_url":"https://api.github.com/repos/SUSE/scf/issues/2865/comments","events_url":"https://api.github.com/repos/SUSE/scf/issues/2865/events","html_url":"https://github.com/SUSE/scf/pull/2865","id":501694527,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzOTE5MDcw","number":2865,"title":"(Option to) use helm/stable NATS chart","user":{"login":"mook-as","id":3977982,"node_id":"MDQ6VXNlcjM5Nzc5ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/3977982?v=4","gravatar_id":"","url":"https://api.github.com/users/mook-as","html_url":"https://github.com/mook-as","followers_url":"https://api.github.com/users/mook-as/followers","following_url":"https://api.github.com/users/mook-as/following{/other_user}","gists_url":"https://api.github.com/users/mook-as/gists{/gist_id}","starred_url":"https://api.github.com/users/mook-as/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mook-as/subscriptions","organizations_url":"https://api.github.com/users/mook-as/orgs","repos_url":"https://api.github.com/users/mook-as/repos","events_url":"https://api.github.com/users/mook-as/events{/privacy}","received_events_url":"https://api.github.com/users/mook-as/received_events","type":"User","site_admin":false},"labels":[{"id":1559044022,"node_id":"MDU6TGFiZWwxNTU5MDQ0MDIy","url":"https://api.github.com/repos/SUSE/scf/labels/spike%20%F0%9F%90%B1%E2%80%8D%F0%9F%8F%8D","name":"spike 🐱‍🏍","color":"220f68","default":false},{"id":425263827,"node_id":"MDU6TGFiZWw0MjUyNjM4Mjc=","url":"https://api.github.com/repos/SUSE/scf/labels/wip%20%F0%9F%91%B7%E2%80%8D%E2%99%80%EF%B8%8F","name":"wip 👷‍♀️","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-10-02T19:57:49Z","updated_at":"2019-10-03T20:43:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/SUSE/scf/pulls/2865","html_url":"https://github.com/SUSE/scf/pull/2865","diff_url":"https://github.com/SUSE/scf/pull/2865.diff","patch_url":"https://github.com/SUSE/scf/pull/2865.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nThis adds support to use the upstream helm chart for NATS, rather than using NATS based on the BOSH release.\r\n\r\n## Motivation and Context\r\nFixes #2723\r\n\r\n## How Has This Been Tested?\r\nBrought up (on minikube/libvirt) both with `nats.external = true` and `= false` configurations, and checked that everything looks ready and smoke tests start.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\n## Additional Information:\r\n\r\n:warning: The NATS subchart currently still gets deployed even when not used; not sure yet how I'd go about disabling that."},"comment":{"url":"https://api.github.com/repos/SUSE/scf/issues/comments/538120215","html_url":"https://github.com/SUSE/scf/pull/2865#issuecomment-538120215","issue_url":"https://api.github.com/repos/SUSE/scf/issues/2865","id":538120215,"node_id":"MDEyOklzc3VlQ29tbWVudDUzODEyMDIxNQ==","user":{"login":"andreas-kupries","id":577247,"node_id":"MDQ6VXNlcjU3NzI0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/577247?v=4","gravatar_id":"","url":"https://api.github.com/users/andreas-kupries","html_url":"https://github.com/andreas-kupries","followers_url":"https://api.github.com/users/andreas-kupries/followers","following_url":"https://api.github.com/users/andreas-kupries/following{/other_user}","gists_url":"https://api.github.com/users/andreas-kupries/gists{/gist_id}","starred_url":"https://api.github.com/users/andreas-kupries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreas-kupries/subscriptions","organizations_url":"https://api.github.com/users/andreas-kupries/orgs","repos_url":"https://api.github.com/users/andreas-kupries/repos","events_url":"https://api.github.com/users/andreas-kupries/events{/privacy}","received_events_url":"https://api.github.com/users/andreas-kupries/received_events","type":"User","site_admin":false},"created_at":"2019-10-03T20:43:09Z","updated_at":"2019-10-03T20:43:09Z","author_association":"CONTRIBUTOR","body":"Definitely have trouble standing up the system with external nats.\r\nNats does not seem to start, and then all the roles requiring it for communications fall over."}}
{"actor":{"display_login":"andreas-kupries"}}