{"action":"closed","number":373,"pull_request":{"url":"https://api.github.com/repos/klaytn/klaytn/pulls/373","id":339353313,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5MzUzMzEz","html_url":"https://github.com/klaytn/klaytn/pull/373","diff_url":"https://github.com/klaytn/klaytn/pull/373.diff","patch_url":"https://github.com/klaytn/klaytn/pull/373.patch","issue_url":"https://api.github.com/repos/klaytn/klaytn/issues/373","number":373,"state":"closed","locked":false,"title":"Implement `checkArgs` for Sign/Send APIs and change field names of `SendTxArgs`","user":{"login":"aidan-kwon","id":48199072,"node_id":"MDQ6VXNlcjQ4MTk5MDcy","avatar_url":"https://avatars0.githubusercontent.com/u/48199072?v=4","gravatar_id":"","url":"https://api.github.com/users/aidan-kwon","html_url":"https://github.com/aidan-kwon","followers_url":"https://api.github.com/users/aidan-kwon/followers","following_url":"https://api.github.com/users/aidan-kwon/following{/other_user}","gists_url":"https://api.github.com/users/aidan-kwon/gists{/gist_id}","starred_url":"https://api.github.com/users/aidan-kwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidan-kwon/subscriptions","organizations_url":"https://api.github.com/users/aidan-kwon/orgs","repos_url":"https://api.github.com/users/aidan-kwon/repos","events_url":"https://api.github.com/users/aidan-kwon/events{/privacy}","received_events_url":"https://api.github.com/users/aidan-kwon/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\n- Sync up field names of `SendTxArgs` with fileds of `TxInternalData` \r\n- Implement `checkArgs` for Sign/Send APIs\r\n\r\n## Types of changes\r\n\r\nPlease put an x in the boxes related to your change.\r\n\r\n- [ ] Bugfix\r\n- [x] New feature or enhancement\r\n- [ ] Others\r\n\r\n## Checklist\r\n\r\n*Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.*\r\n\r\n- [x] I have read the [CONTRIBUTING GUIDELINES](https://github.com/klaytn/klaytn/blob/master/CONTRIBUTING.md) doc\r\n- [x] I have signed the [CLA](https://cla-assistant.io/klaytn/klaytn)\r\n- [x] Lint and unit tests pass locally with my changes (`$ make test`)\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation (if appropriate)\r\n- [ ] Any dependent changes have been merged and published in downstream modules\r\n","created_at":"2019-11-11T10:18:47Z","updated_at":"2019-11-13T09:12:48Z","closed_at":"2019-11-13T09:12:48Z","merged_at":"2019-11-13T09:12:48Z","merge_commit_sha":"782c8e1fd3b54b8d8d73bd23fbff4e9afdd89afb","assignee":{"login":"aidan-kwon","id":48199072,"node_id":"MDQ6VXNlcjQ4MTk5MDcy","avatar_url":"https://avatars0.githubusercontent.com/u/48199072?v=4","gravatar_id":"","url":"https://api.github.com/users/aidan-kwon","html_url":"https://github.com/aidan-kwon","followers_url":"https://api.github.com/users/aidan-kwon/followers","following_url":"https://api.github.com/users/aidan-kwon/following{/other_user}","gists_url":"https://api.github.com/users/aidan-kwon/gists{/gist_id}","starred_url":"https://api.github.com/users/aidan-kwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidan-kwon/subscriptions","organizations_url":"https://api.github.com/users/aidan-kwon/orgs","repos_url":"https://api.github.com/users/aidan-kwon/repos","events_url":"https://api.github.com/users/aidan-kwon/events{/privacy}","received_events_url":"https://api.github.com/users/aidan-kwon/received_events","type":"User","site_admin":false},"assignees":[{"login":"aidan-kwon","id":48199072,"node_id":"MDQ6VXNlcjQ4MTk5MDcy","avatar_url":"https://avatars0.githubusercontent.com/u/48199072?v=4","gravatar_id":"","url":"https://api.github.com/users/aidan-kwon","html_url":"https://github.com/aidan-kwon","followers_url":"https://api.github.com/users/aidan-kwon/followers","following_url":"https://api.github.com/users/aidan-kwon/following{/other_user}","gists_url":"https://api.github.com/users/aidan-kwon/gists{/gist_id}","starred_url":"https://api.github.com/users/aidan-kwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidan-kwon/subscriptions","organizations_url":"https://api.github.com/users/aidan-kwon/orgs","repos_url":"https://api.github.com/users/aidan-kwon/repos","events_url":"https://api.github.com/users/aidan-kwon/events{/privacy}","received_events_url":"https://api.github.com/users/aidan-kwon/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jeonghonah","id":4974738,"node_id":"MDQ6VXNlcjQ5NzQ3Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4974738?v=4","gravatar_id":"","url":"https://api.github.com/users/jeonghonah","html_url":"https://github.com/jeonghonah","followers_url":"https://api.github.com/users/jeonghonah/followers","following_url":"https://api.github.com/users/jeonghonah/following{/other_user}","gists_url":"https://api.github.com/users/jeonghonah/gists{/gist_id}","starred_url":"https://api.github.com/users/jeonghonah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeonghonah/subscriptions","organizations_url":"https://api.github.com/users/jeonghonah/orgs","repos_url":"https://api.github.com/users/jeonghonah/repos","events_url":"https://api.github.com/users/jeonghonah/events{/privacy}","received_events_url":"https://api.github.com/users/jeonghonah/received_events","type":"User","site_admin":false},{"login":"kjhman21","id":20692739,"node_id":"MDQ6VXNlcjIwNjkyNzM5","avatar_url":"https://avatars3.githubusercontent.com/u/20692739?v=4","gravatar_id":"","url":"https://api.github.com/users/kjhman21","html_url":"https://github.com/kjhman21","followers_url":"https://api.github.com/users/kjhman21/followers","following_url":"https://api.github.com/users/kjhman21/following{/other_user}","gists_url":"https://api.github.com/users/kjhman21/gists{/gist_id}","starred_url":"https://api.github.com/users/kjhman21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjhman21/subscriptions","organizations_url":"https://api.github.com/users/kjhman21/orgs","repos_url":"https://api.github.com/users/kjhman21/repos","events_url":"https://api.github.com/users/kjhman21/events{/privacy}","received_events_url":"https://api.github.com/users/kjhman21/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/klaytn/klaytn/pulls/373/commits","review_comments_url":"https://api.github.com/repos/klaytn/klaytn/pulls/373/comments","review_comment_url":"https://api.github.com/repos/klaytn/klaytn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/klaytn/klaytn/issues/373/comments","statuses_url":"https://api.github.com/repos/klaytn/klaytn/statuses/86fe6fc767a0053c7a3d6d87ea6241a95a6b3495","head":{"label":"aidan-kwon:1108-checkArgs","ref":"1108-checkArgs","sha":"86fe6fc767a0053c7a3d6d87ea6241a95a6b3495","user":{"login":"aidan-kwon","id":48199072,"node_id":"MDQ6VXNlcjQ4MTk5MDcy","avatar_url":"https://avatars0.githubusercontent.com/u/48199072?v=4","gravatar_id":"","url":"https://api.github.com/users/aidan-kwon","html_url":"https://github.com/aidan-kwon","followers_url":"https://api.github.com/users/aidan-kwon/followers","following_url":"https://api.github.com/users/aidan-kwon/following{/other_user}","gists_url":"https://api.github.com/users/aidan-kwon/gists{/gist_id}","starred_url":"https://api.github.com/users/aidan-kwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidan-kwon/subscriptions","organizations_url":"https://api.github.com/users/aidan-kwon/orgs","repos_url":"https://api.github.com/users/aidan-kwon/repos","events_url":"https://api.github.com/users/aidan-kwon/events{/privacy}","received_events_url":"https://api.github.com/users/aidan-kwon/received_events","type":"User","site_admin":false},"repo":{"id":200169128,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAxNjkxMjg=","name":"klaytn","full_name":"aidan-kwon/klaytn","private":false,"owner":{"login":"aidan-kwon","id":48199072,"node_id":"MDQ6VXNlcjQ4MTk5MDcy","avatar_url":"https://avatars0.githubusercontent.com/u/48199072?v=4","gravatar_id":"","url":"https://api.github.com/users/aidan-kwon","html_url":"https://github.com/aidan-kwon","followers_url":"https://api.github.com/users/aidan-kwon/followers","following_url":"https://api.github.com/users/aidan-kwon/following{/other_user}","gists_url":"https://api.github.com/users/aidan-kwon/gists{/gist_id}","starred_url":"https://api.github.com/users/aidan-kwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidan-kwon/subscriptions","organizations_url":"https://api.github.com/users/aidan-kwon/orgs","repos_url":"https://api.github.com/users/aidan-kwon/repos","events_url":"https://api.github.com/users/aidan-kwon/events{/privacy}","received_events_url":"https://api.github.com/users/aidan-kwon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aidan-kwon/klaytn","description":"Official Go implementation of the Klaytn protocol","fork":true,"url":"https://api.github.com/repos/aidan-kwon/klaytn","forks_url":"https://api.github.com/repos/aidan-kwon/klaytn/forks","keys_url":"https://api.github.com/repos/aidan-kwon/klaytn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aidan-kwon/klaytn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aidan-kwon/klaytn/teams","hooks_url":"https://api.github.com/repos/aidan-kwon/klaytn/hooks","issue_events_url":"https://api.github.com/repos/aidan-kwon/klaytn/issues/events{/number}","events_url":"https://api.github.com/repos/aidan-kwon/klaytn/events","assignees_url":"https://api.github.com/repos/aidan-kwon/klaytn/assignees{/user}","branches_url":"https://api.github.com/repos/aidan-kwon/klaytn/branches{/branch}","tags_url":"https://api.github.com/repos/aidan-kwon/klaytn/tags","blobs_url":"https://api.github.com/repos/aidan-kwon/klaytn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aidan-kwon/klaytn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aidan-kwon/klaytn/git/refs{/sha}","trees_url":"https://api.github.com/repos/aidan-kwon/klaytn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aidan-kwon/klaytn/statuses/{sha}","languages_url":"https://api.github.com/repos/aidan-kwon/klaytn/languages","stargazers_url":"https://api.github.com/repos/aidan-kwon/klaytn/stargazers","contributors_url":"https://api.github.com/repos/aidan-kwon/klaytn/contributors","subscribers_url":"https://api.github.com/repos/aidan-kwon/klaytn/subscribers","subscription_url":"https://api.github.com/repos/aidan-kwon/klaytn/subscription","commits_url":"https://api.github.com/repos/aidan-kwon/klaytn/commits{/sha}","git_commits_url":"https://api.github.com/repos/aidan-kwon/klaytn/git/commits{/sha}","comments_url":"https://api.github.com/repos/aidan-kwon/klaytn/comments{/number}","issue_comment_url":"https://api.github.com/repos/aidan-kwon/klaytn/issues/comments{/number}","contents_url":"https://api.github.com/repos/aidan-kwon/klaytn/contents/{+path}","compare_url":"https://api.github.com/repos/aidan-kwon/klaytn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aidan-kwon/klaytn/merges","archive_url":"https://api.github.com/repos/aidan-kwon/klaytn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aidan-kwon/klaytn/downloads","issues_url":"https://api.github.com/repos/aidan-kwon/klaytn/issues{/number}","pulls_url":"https://api.github.com/repos/aidan-kwon/klaytn/pulls{/number}","milestones_url":"https://api.github.com/repos/aidan-kwon/klaytn/milestones{/number}","notifications_url":"https://api.github.com/repos/aidan-kwon/klaytn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aidan-kwon/klaytn/labels{/name}","releases_url":"https://api.github.com/repos/aidan-kwon/klaytn/releases{/id}","deployments_url":"https://api.github.com/repos/aidan-kwon/klaytn/deployments","created_at":"2019-08-02T05:11:19Z","updated_at":"2019-11-11T11:02:02Z","pushed_at":"2019-11-13T07:35:30Z","git_url":"git://github.com/aidan-kwon/klaytn.git","ssh_url":"git@github.com:aidan-kwon/klaytn.git","clone_url":"https://github.com/aidan-kwon/klaytn.git","svn_url":"https://github.com/aidan-kwon/klaytn","homepage":"","size":14669,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"klaytn:dev","ref":"dev","sha":"d31067e2bf9648184ee0966b0e5978a49449f847","user":{"login":"klaytn","id":41137100,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMTM3MTAw","avatar_url":"https://avatars1.githubusercontent.com/u/41137100?v=4","gravatar_id":"","url":"https://api.github.com/users/klaytn","html_url":"https://github.com/klaytn","followers_url":"https://api.github.com/users/klaytn/followers","following_url":"https://api.github.com/users/klaytn/following{/other_user}","gists_url":"https://api.github.com/users/klaytn/gists{/gist_id}","starred_url":"https://api.github.com/users/klaytn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaytn/subscriptions","organizations_url":"https://api.github.com/users/klaytn/orgs","repos_url":"https://api.github.com/users/klaytn/repos","events_url":"https://api.github.com/users/klaytn/events{/privacy}","received_events_url":"https://api.github.com/users/klaytn/received_events","type":"Organization","site_admin":false},"repo":{"id":191270251,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEyNzAyNTE=","name":"klaytn","full_name":"klaytn/klaytn","private":false,"owner":{"login":"klaytn","id":41137100,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMTM3MTAw","avatar_url":"https://avatars1.githubusercontent.com/u/41137100?v=4","gravatar_id":"","url":"https://api.github.com/users/klaytn","html_url":"https://github.com/klaytn","followers_url":"https://api.github.com/users/klaytn/followers","following_url":"https://api.github.com/users/klaytn/following{/other_user}","gists_url":"https://api.github.com/users/klaytn/gists{/gist_id}","starred_url":"https://api.github.com/users/klaytn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaytn/subscriptions","organizations_url":"https://api.github.com/users/klaytn/orgs","repos_url":"https://api.github.com/users/klaytn/repos","events_url":"https://api.github.com/users/klaytn/events{/privacy}","received_events_url":"https://api.github.com/users/klaytn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/klaytn/klaytn","description":"Official Go implementation of the Klaytn protocol","fork":false,"url":"https://api.github.com/repos/klaytn/klaytn","forks_url":"https://api.github.com/repos/klaytn/klaytn/forks","keys_url":"https://api.github.com/repos/klaytn/klaytn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klaytn/klaytn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klaytn/klaytn/teams","hooks_url":"https://api.github.com/repos/klaytn/klaytn/hooks","issue_events_url":"https://api.github.com/repos/klaytn/klaytn/issues/events{/number}","events_url":"https://api.github.com/repos/klaytn/klaytn/events","assignees_url":"https://api.github.com/repos/klaytn/klaytn/assignees{/user}","branches_url":"https://api.github.com/repos/klaytn/klaytn/branches{/branch}","tags_url":"https://api.github.com/repos/klaytn/klaytn/tags","blobs_url":"https://api.github.com/repos/klaytn/klaytn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klaytn/klaytn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klaytn/klaytn/git/refs{/sha}","trees_url":"https://api.github.com/repos/klaytn/klaytn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klaytn/klaytn/statuses/{sha}","languages_url":"https://api.github.com/repos/klaytn/klaytn/languages","stargazers_url":"https://api.github.com/repos/klaytn/klaytn/stargazers","contributors_url":"https://api.github.com/repos/klaytn/klaytn/contributors","subscribers_url":"https://api.github.com/repos/klaytn/klaytn/subscribers","subscription_url":"https://api.github.com/repos/klaytn/klaytn/subscription","commits_url":"https://api.github.com/repos/klaytn/klaytn/commits{/sha}","git_commits_url":"https://api.github.com/repos/klaytn/klaytn/git/commits{/sha}","comments_url":"https://api.github.com/repos/klaytn/klaytn/comments{/number}","issue_comment_url":"https://api.github.com/repos/klaytn/klaytn/issues/comments{/number}","contents_url":"https://api.github.com/repos/klaytn/klaytn/contents/{+path}","compare_url":"https://api.github.com/repos/klaytn/klaytn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klaytn/klaytn/merges","archive_url":"https://api.github.com/repos/klaytn/klaytn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klaytn/klaytn/downloads","issues_url":"https://api.github.com/repos/klaytn/klaytn/issues{/number}","pulls_url":"https://api.github.com/repos/klaytn/klaytn/pulls{/number}","milestones_url":"https://api.github.com/repos/klaytn/klaytn/milestones{/number}","notifications_url":"https://api.github.com/repos/klaytn/klaytn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klaytn/klaytn/labels{/name}","releases_url":"https://api.github.com/repos/klaytn/klaytn/releases{/id}","deployments_url":"https://api.github.com/repos/klaytn/klaytn/deployments","created_at":"2019-06-11T01:22:29Z","updated_at":"2019-11-13T08:28:19Z","pushed_at":"2019-11-13T09:12:49Z","git_url":"git://github.com/klaytn/klaytn.git","ssh_url":"git@github.com:klaytn/klaytn.git","clone_url":"https://github.com/klaytn/klaytn.git","svn_url":"https://github.com/klaytn/klaytn","homepage":"","size":14731,"stargazers_count":59,"watchers_count":59,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":33,"open_issues":12,"watchers":59,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/klaytn/klaytn/pulls/373"},"html":{"href":"https://github.com/klaytn/klaytn/pull/373"},"issue":{"href":"https://api.github.com/repos/klaytn/klaytn/issues/373"},"comments":{"href":"https://api.github.com/repos/klaytn/klaytn/issues/373/comments"},"review_comments":{"href":"https://api.github.com/repos/klaytn/klaytn/pulls/373/comments"},"review_comment":{"href":"https://api.github.com/repos/klaytn/klaytn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/klaytn/klaytn/pulls/373/commits"},"statuses":{"href":"https://api.github.com/repos/klaytn/klaytn/statuses/86fe6fc767a0053c7a3d6d87ea6241a95a6b3495"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aidan-kwon","id":48199072,"node_id":"MDQ6VXNlcjQ4MTk5MDcy","avatar_url":"https://avatars0.githubusercontent.com/u/48199072?v=4","gravatar_id":"","url":"https://api.github.com/users/aidan-kwon","html_url":"https://github.com/aidan-kwon","followers_url":"https://api.github.com/users/aidan-kwon/followers","following_url":"https://api.github.com/users/aidan-kwon/following{/other_user}","gists_url":"https://api.github.com/users/aidan-kwon/gists{/gist_id}","starred_url":"https://api.github.com/users/aidan-kwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidan-kwon/subscriptions","organizations_url":"https://api.github.com/users/aidan-kwon/orgs","repos_url":"https://api.github.com/users/aidan-kwon/repos","events_url":"https://api.github.com/users/aidan-kwon/events{/privacy}","received_events_url":"https://api.github.com/users/aidan-kwon/received_events","type":"User","site_admin":false},"comments":0,"review_comments":7,"maintainer_can_modify":false,"commits":3,"additions":308,"deletions":87,"changed_files":5}}
{"actor":{"display_login":"aidan-kwon"}}