{"push_id":3357285673,"size":50,"distinct_size":1,"ref":"refs/heads/FB8-82","head":"0967c1045cd51400319032ac45c6f8c2ebf63996","before":"3c78331e52392654813cf14a25c6391273fc8c0f","commits":[{"sha":"d867a4f47d70c0a0298547c977f8750b053c9664","author":{"name":"Manuel Ung","email":"afd0c7fe9cb17a28019c95dba0af2c76a915af91@fb.com"},"message":"Revert \"Add admin TCP/IP port in mysql\"\n\nSummary:\nThis reverts commit 4b25deb8b2ed1a550f39853ca4ea18a286aa528b.\n\nWe will be using upstream's implementation of admin port instead in 8.0.14.\n\nSquash with: D7363142\n\nReviewed By: hermanlee\n\nDifferential Revision: D13881371\n\nfbshipit-source-id: d3aa88351bb","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/d867a4f47d70c0a0298547c977f8750b053c9664"},{"sha":"16b383e1a816f506a5770fe245ada70a0dcf8861","author":{"name":"Dmitry Shulga","email":"d55f73c7d2cba7597fa5e9ea951abda3d567a790@oracle.com"},"message":"WL#12138 -- Add Admin Port\n\nSummary:\n```\nThis worklog adds capability to specify a separate IP address and TCP port\nthat are ready to accept TCP connection and speak MySQL protocol.\nThe following features are added within the worklog:\n\n  * The new command-line options --admin-address and --admin-port\n    to specify admin interface for listening incoming connection requests.\n\n  * The new privilege SERVICE_CONNECTION_ADMIN to restrict\n    access to admin socket.\n\n  * Ignore restrictions imposed by parameters max_user_connections\n    and max_connections in case a connection is made to admin interface.\n\n  * The new option --create-admin-listener-thread to listen on admin interface\n    in a separate thread.\n\nReviewed By: hermanlee\n\nDifferential Revision: D13881490\n\nfbshipit-source-id: d4e33e1cc4f","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/16b383e1a816f506a5770fe245ada70a0dcf8861"},{"sha":"df48579887ed8ef1f9f3ebc4fd4c166844d87540","author":{"name":"Zsolt Parragi","email":"ca264def71cbf9665e47ab04db02aefc0828a6a8@percona.com"},"message":"FB8-64: Fix time granularity in dump thread (#933)\n\nSummary:\nDump thread used second granularity to decide whether\nheartbeat needs to be sent to slaves. With milli-second heartbeat\nconfiguration on slaves, this caused dump thread to send heartbeat\nevents for every skipped event. This significantly increases slave\nstart time. Fix this by increasing the granularity.\n\nJIRA: https://jira.percona.com/browse/FB8-64\n\nFixes upstream bug: https://bugs.mysql.com/bug.php?id=81164\n\nReference patch: https://github.com/facebook/mysql-5.6/commit/1ac73cf\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/933\n\nReviewed By: lth\n\nDifferential Revision: D13790257\n\nPulled By: lth\n\nfbshipit-source-id: 846cbdf6003","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/df48579887ed8ef1f9f3ebc4fd4c166844d87540"},{"sha":"a4d4b0bd84c4e7b5d86b1049f39380b8b3b5c3a8","author":{"name":"przemyslaw.skibinski@percona.com","email":"035081a600efb43fbb22946bd9efedc58c802f4d@percona.com"},"message":"FB8-69: Don't force flush relay log info (#935)\n\nSummary:\nWith gtid enabled, flushing relay log info is not necessary. The force flushing is required to ensure recovery of MTS in non-gtid mode. The coordinator thread relies on positions in the relay log info repository during recovery. With GTID, this is not required and sql_thread doesn't even need to do any recovery. The slave (io_thread) uses auto-positioning directly.\n\nJIRA: https://jira.percona.com/browse/FB8-69\n\nReference Patch: https://github.com/facebook/mysql-5.6/commit/ed39d49\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/935\n\nReviewed By: lth\n\nDifferential Revision: D13874140\n\nPulled By: lth\n\nfbshipit-source-id: bc11ce0a7b5","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/a4d4b0bd84c4e7b5d86b1049f39380b8b3b5c3a8"},{"sha":"0c4630cded1d45993676e30a69765bb8943ea508","author":{"name":"Manuel Ung","email":"afd0c7fe9cb17a28019c95dba0af2c76a915af91@fb.com"},"message":"Fix main.admin_interface test\n\nSummary: The main.admin_interface test fails occasionally for some reason because the server binds to 127.0.0.1, but the client connects to localhost. Fix this by connecting to 127.0.0.1 like in other places where we connect to admin port.\n\nReviewed By: abal147\n\nDifferential Revision: D13909582\n\nfbshipit-source-id: e8d39805acc","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/0c4630cded1d45993676e30a69765bb8943ea508"},{"sha":"cc31371b2568344cec93b4fc5ebe07c883864e23","author":{"name":"Manuel Ung","email":"afd0c7fe9cb17a28019c95dba0af2c76a915af91@fb.com"},"message":"Fix resource leaks in mysqlbinlog\n\nSummary:\nAs titled.\n\nReference patch: https://github.com/facebook/mysql-5.6/commit/544f11a\n\nSquash with: D9093419\n\nReviewed By: hermanlee\n\nDifferential Revision: D13930353\n\nfbshipit-source-id: 63c8594a501","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/cc31371b2568344cec93b4fc5ebe07c883864e23"},{"sha":"6554a768c576feb17cb39fef7c68d0253b08dbf1","author":{"name":"Manuel Ung","email":"afd0c7fe9cb17a28019c95dba0af2c76a915af91@fb.com"},"message":"Fix memory leak in mysqldump\n\nSummary:\nmysql_free_result needs to be called on the the MYSQL_RES object after mysql_store_result is called.\n\nSquash with: D6437452\n\nReviewed By: hermanlee\n\nDifferential Revision: D13911815\n\nfbshipit-source-id: 1f926258566","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/6554a768c576feb17cb39fef7c68d0253b08dbf1"},{"sha":"0432d8c19faac1de6749731334be691c716d9480","author":{"name":"Herman Lee","email":"c3d7983e47b19501211b1b6328c7f9744af9d0ad@fb.com"},"message":"FB8-97: Add mtr suppression rule for rpl.rpl_gtid_skip_writing_previous_gtid_set test (#944)\n\nSummary:\nJIRA: https://jira.percona.com/browse/FB8-97\n\nReference Patch: https://github.com/facebook/mysql-5.6/commit/eaabc64\nReference Patch: https://github.com/facebook/mysql-5.6/commit/62c3073\n\nAdd mtr suppression rule for rpl.rpl_gtid_skip_writing_previous_gtid_set test\n\nAdding slave start/stop calls to the\nrpl.rpl_gtid_skip_writing_previous_gtid_set test can sometimes trigger a\nwarning message in the log. Add a new suppression rule for this warning\nmessage since it does not cause the test to fail.\n\nA flaky warning `failed registering on master` may happen in this rpl test,\nwhen the master restarts twice in a row. The slave may still try to connect to\nthe master while the master restarts again. Adding stop/start slaves when\nmaster restarts.\n\nSquash with: D8923357\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/944\n\nReviewed By: lth\n\nDifferential Revision: D13930851\n\nPulled By: lth\n\nfbshipit-source-id: 7776f5cdb99","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/0432d8c19faac1de6749731334be691c716d9480"},{"sha":"726e9bd8b38eed7317fc8fa05840011a94adb3d8","author":{"name":"Venkatesh Venugopal","email":"92700c3a97a22374060055013d6a8960fba5aeb7@oracle.com"},"message":"FB8-129 Bug#26997096: RELAY_LOG_SPACE IS INACCURATE AND LEAKS (#945)\n\nSummary:\nProblem\n-------\nThe Relay_Log_Space variable shown in SHOW SLAVE STATUS is\nsometimes much higher than the actual disk space used by relay\nlogs.\n\nAnalysis\n--------\nThis is because we are not writing to\nRelay_log_info::log_space_total in a synchronized manner. i.e, no\nlock is being taken by the IO thread while updating the variable.\n\nFix\n ---\nThe Relay_log_info::log_space_total is now guarded by the\nRelay_log_info::log_space_lock and this protects concurrent\nupdate on Relay_log_info::log_space_total.\n\nThis solves https://jira.percona.com/browse/FB8-129\n\nReference Patch: https://github.com/mysql/mysql-server/commit/14c10add4\nResolves https://bugs.mysql.com/bug.php?id=87832, which is fixed in 8.0.14, where this patch can be dropped.\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/945\n\nReviewed By: lth\n\nDifferential Revision: D13941902\n\nPulled By: lth\n\nfbshipit-source-id: bc459cdbdbf","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/726e9bd8b38eed7317fc8fa05840011a94adb3d8"},{"sha":"c981837531a71c5c983d06dc3ddf1b729f9e94cb","author":{"name":"Jay Edgar","email":"c32fbe7f523a947cf9ce5c3972401ffea9bcea18@fb.com"},"message":"FB8-100: Handle out-of-space on binlog cache file (#938)\n\nSummary:\nJIRA: https://jira.percona.com/browse/FB8-100\n\nReference Patch: https://github.com/facebook/mysql-5.6/commit/e29ff14\n\nThe binlog cache file code is designed to handle an error that would cause binlog corruption.  It does this by checking the error for a set of values that it expects and when it finds one it marks the cache to indicate an incident has occurred and this mark keeps it from writing corrupt entries to the binlog.  Unfortunately, during an out-of-space event, there is a lower level error that gets set which is not being overwritten when we set the expected error.  This means that when the code checks for the expected error it is not found - the original lower level error is found.  This diff modifies the checking code to scan through all associated conditions (which is a list of all encountered errors) to see if the expected error is present anywhere in the list.\n\nThis diff can be reverted if/when https://bugs.mysql.com/bug.php?id=72457 is resolved upstream.\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/938\n\nReviewed By: lth\n\nDifferential Revision: D13924297\n\nPulled By: lth\n\nfbshipit-source-id: bf743b697c9","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/c981837531a71c5c983d06dc3ddf1b729f9e94cb"},{"sha":"eb7278c2387eae2b9dcbb352f41f5d05f8f8d311","author":{"name":"Abhinav Sharma","email":"2fb2960e2e9451a8be4f1cab21178ee30dcef77d@fb.com"},"message":"FB8-86: Delete crash safe index file if index file exists (#939)\n\nSummary:\nJIRA: https://jira.percona.com/browse/FB8-86\n\nReference Patch: https://github.com/facebook/mysql-5.6/commit/78fa270\n\nCrash safe index file is created when any change is made to the index\nfile. The index file is first copied over to the crash safe one and then stuff\nis added/removed from the crash safe index file. Finally, the old index file is\ndeleted and crash safe index file is renamed to the index file. There might be a\nscenario where mysql crashes after stuff is changed in the crash safe file\nbut before the old index file is deleted. In this case we should delete the\ncrash safe index file at restart. If we don't delete it subsequent changes to\nthe index file can corrupt it because it can be copied to the old crash safe\nfile which already has some data in it.\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/939\n\nReviewed By: lth\n\nDifferential Revision: D13924478\n\nPulled By: lth\n\nfbshipit-source-id: 003c1b56614","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/eb7278c2387eae2b9dcbb352f41f5d05f8f8d311"},{"sha":"97ae20bd3aa24aee6d3ad87ec7833931c451d887","author":{"name":"Abhinav Sharma","email":"2fb2960e2e9451a8be4f1cab21178ee30dcef77d@fb.com"},"message":"FB8-77: Changed the behavior of purging logs. Now deleting logs first and then updating the index (#943)\n\nSummary:\nJIRA: https://jira.percona.com/browse/FB8-77\n\nReference Patch: https://github.com/facebook/mysql-5.6/commit/832be30\nReference Patch: https://github.com/facebook/mysql-5.6/commit/0d85250\nReference Patch: https://github.com/facebook/mysql-5.6/commit/e8be5be\n\nChanged the behavior of purging logs. Now deleting logs first and then updating the index.\n\nPreviously when purging logs, the index was updated before deleting the logs. This creates problems the disk is full. We should first delete logs to free up disk and then update index.\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/943\n\nReviewed By: lth\n\nDifferential Revision: D13930811\n\nPulled By: lth\n\nfbshipit-source-id: 59c6a6a53f0","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/97ae20bd3aa24aee6d3ad87ec7833931c451d887"},{"sha":"7fa4a1136ceba0e7840c4ed140fa8a8567520b92","author":{"name":"Santosh Praneeth Banda","email":"debbb4f8d47b8e770bc03b2e485a42e7ce1c844d@fb.com"},"message":"FB8-56: Create a new mode SEMI_STRICT for slave_exec_mode (#941)\n\nSummary:\nJIRA: https://jira.percona.com/browse/FB8-56\n\nReference Patch: https://github.com/facebook/mysql-5.6/commit/9d97282\n\nCreate a new mode SEMI_STRICT which ignores HA_ERR_RECORD_CHANGED and HA_ERR_KEY_NOT_FOUND errors.\nA new status counter will track the usage of this new mode. Logging a warning/error message may cause error log to get flooded with same error message, so I decided against it.\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/941\n\nReviewed By: lth\n\nDifferential Revision: D13924607\n\nPulled By: lth\n\nfbshipit-source-id: 7ad4b85e7b8","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/7fa4a1136ceba0e7840c4ed140fa8a8567520b92"},{"sha":"06b23751db85d0fa1a81702609309e4bc390cfcf","author":{"name":"Zsolt Parragi","email":"ca264def71cbf9665e47ab04db02aefc0828a6a8@percona.com"},"message":"FB8-96: Remove special formatting for user name when writing to audit plugin log (#948)\n\nSummary:\nJira issue: https://jira.percona.com/browse/FB8-96\n\nReference patch: https://github.com/facebook/mysql-5.6/commit/3b47dae\nReference patch: https://github.com/facebook/mysql-5.6/commit/87e0683\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/948\n\nReviewed By: lth\n\nDifferential Revision: D13941932\n\nPulled By: lth\n\nfbshipit-source-id: 1435058910b","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/06b23751db85d0fa1a81702609309e4bc390cfcf"},{"sha":"ad858f8b2b5e142166159d2bdc21725fcc0deca4","author":{"name":"Annamalai Gurusami","email":"3dd7fa59519d1d3dbf7043cc4f1397eca520ea4c@oracle.com"},"message":"Bug #28825617 ASSERTION FAILURE: LOB0LOB.CC.*TRX == NULLPTR || TRX->IS_READ_UNCOMMITTED()\n\nSummary:\n```\nBackground:\n\nThis is a regression caused by the following commit:\n\ncommit 56eb89637db93f16bcf7e7e047d6ec7907cd5bbe\nAuthor: Kevin Lewis <kevin.lewis@oracle.com>\nDate:   Wed May 23 15:51:08 2018 -0700\n\nBug#25540277 - INNODB'S MVCC HAS O(N^2) BEHAVIORS\n\nProblem:\n\nThe function row_sel_build_prev_vers_for_mysql() goes through the old versions\nof the clustered index record and identifies the one which can be viewed by the\ncurrent transaction (MVCC).  The result is then cached in an object of\nRow_sel_get_clust_rec_for_mysql.\n\nThe two things that are cached by the helper class\nRow_sel_get_clust_rec_for_mysql are cached_clust_rec and cached_old_vers.  If\nthe latest record is cached_clust_rec, its old version for the given\ntransaction that is viewable is cached_old_vers. The important point here is\nthat the record offsets for these two records are not cached.\n\nThe record offsets for cached_clust_rec and the cached_old_vers need not be the\nsame.  This is confirmed by looking at row_sel_build_prev_vers_for_mysql().\nThe 6th argument which contains the record offsets is an input/output argument.\nThe input is the offsets of the latest version of clust_rec, and the output is\nthe record offsets of the older version.  So the record offsets of different\nversions of clust_rec can change.\n\nSolution:\n\nRe-calculate the record offsets for the cached old_vers.\n\nrb#20927 approved by Kevin.\n```\n\nReviewed By: hermanlee\n\nDifferential Revision: D13999012\n\nfbshipit-source-id: f41126f0f28","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/ad858f8b2b5e142166159d2bdc21725fcc0deca4"},{"sha":"231b9a6c7472fe31869b9f4365e9c5c35d4f67bc","author":{"name":"Herman Lee","email":"c3d7983e47b19501211b1b6328c7f9744af9d0ad@fb.com"},"message":"Fix stack buffer overflow for parsing connection options\n\nSummary:\nIncrease the size of the stack buffer to handle the string for \"TIMEOUT_1500MS\".\n\nSquash with D7298713\n\nReviewed By: lth\n\nDifferential Revision: D13995206\n\nfbshipit-source-id: 9cc3f4ce3dd","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/231b9a6c7472fe31869b9f4365e9c5c35d4f67bc"},{"sha":"0aba46640a49251c0f1fe343f1905668f39d5ffe","author":{"name":"Herman Lee","email":"c3d7983e47b19501211b1b6328c7f9744af9d0ad@fb.com"},"message":"Fix tests to handle asan error code\n\nSummary:\nSome tests expect mysqld to crash/fail on startup. With ASan builds,\nmysqld also reports memory leaks and exits with exit code 23. Update\nthe tests to handle exit code 23 too. If mysqld ever returns exit code\n23 for specific error handling, it may be better to disable these tests\nrunning in ASan mode.\n\nSquash with D7827421\n\nReviewed By: lth\n\nDifferential Revision: D13996188\n\nfbshipit-source-id: 222d9923dd7","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/0aba46640a49251c0f1fe343f1905668f39d5ffe"},{"sha":"48615c444dd7ccaf0bc387017ca44b3dda7764ae","author":{"name":"Satya Bodapati","email":"bbe924d3dc8a23580eff6f3776b2270a1d1e225d@percona.com"},"message":"FB8-52: Slowing down transaction log init (#931)\n\nSummary:\nJIRA: https://jira.percona.com/browse/FB8-52\n\nReference Patch: https://github.com/facebook/mysql-5.6/commit/80ca845\nReference Patch: https://github.com/facebook/mysql-5.6/commit/0fb428b\n\nPatch introduces new variable 'innodb_txlog_init_rate' to limit\nthe IO rate of InnoDB redo log file initialization.\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/931\n\nReviewed By: lth\n\nDifferential Revision: D13789095\n\nPulled By: lth\n\nfbshipit-source-id: d572c7b8896","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/48615c444dd7ccaf0bc387017ca44b3dda7764ae"},{"sha":"309222564ff6400059ecd8202791d214ae21835a","author":{"name":"Zsolt Parragi","email":"ca264def71cbf9665e47ab04db02aefc0828a6a8@percona.com"},"message":"FB8-54, FB8-55, FB8-70, FB8-101: Expose more information to audit plugin (#934)\n\nSummary:\nJIRA: https://jira.percona.com/browse/FB8-54\nJIRA: https://jira.percona.com/browse/FB8-55\nJIRA: https://jira.percona.com/browse/FB8-70\nJIRA: https://jira.percona.com/browse/FB8-101\n\nThis commit adds the following fields to the generic event in audit log:\n* query_id\n* database\n* affected_rows\n* connection_certificate\n\nReference Patch: https://github.com/facebook/mysql-5.6/commit/1def6b7\nReference Patch: https://github.com/facebook/mysql-5.6/commit/ce95a09\nReference Patch: https://github.com/facebook/mysql-5.6/commit/588be34\nReference Patch: https://github.com/facebook/mysql-5.6/commit/ba03c70\nReference Patch: https://github.com/facebook/mysql-5.6/commit/be8c587\nReference Patch: https://github.com/facebook/mysql-5.6/commit/22b2508\n\nWe need some extra info for the shadowing and security logging. This is a\nsimple first step of info that MariaDB actually also exposes.\nNow we would have the `query_id` and the database name for general events.\nMaking as few changes as possible to accomplish it, so I'm just taking the\ninformation from the TDH and exposing it through `mysql_event_general`\nstruct and as a argument to disconnect.\n\nForward the connection certificate to the audit plugin. The connection certificate can then be parsed by the audit plugin and handled appropriately. It made more sense for the certificate to live in the connection events, since they generally don't change between every general event, so the move was done.\n\nThis is done by caching a BUF_MEM struct on the THD object. Since it's not possible to change certificates on the same connection, this caching should be correct. The BUF_MEM is released on THD::release_resources.\n\nIf upstream bumps the MYSQL_AUDIT_INTERFACE_VERSION, we should bump ours to be greater or equal to it.\n\nExpose the port current mysqld is running on for the audit plugin. If no port, 0 is used.\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/934\n\nReviewed By: lth\n\nDifferential Revision: D13874133\n\nPulled By: lth\n\nfbshipit-source-id: 889398cc14d","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/309222564ff6400059ecd8202791d214ae21835a"},{"sha":"e04518828b51cfbf2adbd1ab75ec20510ad774e6","author":{"name":"Xuli Liu","email":"77f56d3c2a84e944c413253559e897b4e8e38118@fb.com"},"message":"FB8-93: output symbolic errno for 'SHOW SLAVE STATUS' (#940)\n\nSummary:\nJIRA: https://jira.percona.com/browse/FB8-93\n\nReference Patch: https://github.com/facebook/mysql-5.6/commit/a2b0c32\nReference Patch: https://github.com/facebook/mysql-5.6/commit/e82ab5a\n\n Instead of just showing the errno when running SHOW SLAVE STATUS command, also printing the error name so that user won't have misunderstanding\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/940\n\nReviewed By: lth\n\nDifferential Revision: D13924591\n\nPulled By: lth\n\nfbshipit-source-id: fafc6a8c18f","distinct":false,"url":"https://api.github.com/repos/inikep/mysql-5.6/commits/e04518828b51cfbf2adbd1ab75ec20510ad774e6"}]}
{"actor":{"display_login":"inikep"}}