{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/320220212","pull_request_review_id":282926532,"id":320220212,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDIyMDIxMg==","diff_hunk":"@@ -0,0 +1,37 @@\n+#pragma once\n+\n+#include \"routing/routing_quality/api/api.hpp\"\n+\n+#include \"routing/routing_quality/api/google/types.hpp\"\n+\n+#include <cstdint>\n+#include <string>\n+\n+namespace routing_quality\n+{\n+namespace api\n+{\n+namespace google\n+{\n+class GoogleApi : public RoutingApi\n+{\n+public:\n+  GoogleApi(std::string const & token);","path":"routing/routing_quality/api/google/google_api.hpp","position":19,"original_position":19,"commit_id":"c04678969fd77936e4fefe864c6fdc28b829c02a","original_commit_id":"c04678969fd77936e4fefe864c6fdc28b829c02a","user":{"login":"bykoianko","id":1768114,"node_id":"MDQ6VXNlcjE3NjgxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"body":"?","created_at":"2019-09-03T11:21:44Z","updated_at":"2019-09-03T11:21:44Z","html_url":"https://github.com/mapsme/omim/pull/11067#discussion_r320220212","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/11067","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/320220212"},"html":{"href":"https://github.com/mapsme/omim/pull/11067#discussion_r320220212"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/11067"}},"in_reply_to_id":320220188},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/11067","id":289333510,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5MzMzNTEw","html_url":"https://github.com/mapsme/omim/pull/11067","diff_url":"https://github.com/mapsme/omim/pull/11067.diff","patch_url":"https://github.com/mapsme/omim/pull/11067.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/11067","number":11067,"state":"open","locked":false,"title":"[routing] Routes builder tool","user":{"login":"gmoryes","id":17534533,"node_id":"MDQ6VXNlcjE3NTM0NTMz","avatar_url":"https://avatars2.githubusercontent.com/u/17534533?v=4","gravatar_id":"","url":"https://api.github.com/users/gmoryes","html_url":"https://github.com/gmoryes","followers_url":"https://api.github.com/users/gmoryes/followers","following_url":"https://api.github.com/users/gmoryes/following{/other_user}","gists_url":"https://api.github.com/users/gmoryes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoryes/subscriptions","organizations_url":"https://api.github.com/users/gmoryes/orgs","repos_url":"https://api.github.com/users/gmoryes/repos","events_url":"https://api.github.com/users/gmoryes/events{/privacy}","received_events_url":"https://api.github.com/users/gmoryes/received_events","type":"User","site_admin":false},"body":"Это часть работ для поиска аномалий в наших маршрутах. \r\nВ чем заключается план:\r\nВо первых: у нас в роутинге нельзя просто так взять и построить маршрут: `BuildRoute(start, finish)`. Нужно перед этим сделать кучу телодвижений, и у каждой тулзы эти движения собственные (`routing_integration_tests`, `routing_quolity_tests`) и вот сейчас еще моя тулза подъехала. Предлагается везде использовать мою библиотеку, потому что:\r\n1) ее можно подключать к `executable` и просто использовать: `BuildRoute(start, finish)`\r\n2) она умеет в многопоточность\r\n\r\nПо сути уже такая же была у Влада в `routing_quolity` (`RoutesGetter`), но она не поддерживала многопоточность,  часть кода я оттуда и взял.\r\n\r\nВо вторых: я перенес mapbox в отдельную директорию и теперь у нас есть библиотека: `routing_api`.\r\n\r\nВ третьих: раньше была тулза, которую написал Влад: `routing_quolity_tool`, я хочу удалить код оттуда и сделать у `routes_builder_tool` опцию: \"построй маршруты с координатами из файла\" (такое уже есть) + \"и используй при этом такое-то api\" (такого пока нет)\r\n\r\nВ четвертых: `routing_quolity_tool` я хочу превратить в тулзу, которая будет парсить файлы от `routes_builder_tool` и будет говорить на выходе что-то вроде: \"степень похожести на такое-то api: 0.76, вот список маршрутов, которые отличаются более чем на 70%\"\r\n\r\n###  **смотреть по коммитам**","created_at":"2019-06-18T15:21:19Z","updated_at":"2019-09-03T11:21:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c09ff0e80b59666c7e3077418c5b015fdb26b0c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/11067/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/11067/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/11067/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/c04678969fd77936e4fefe864c6fdc28b829c02a","head":{"label":"gmoryes:routes_builder_tool","ref":"routes_builder_tool","sha":"c04678969fd77936e4fefe864c6fdc28b829c02a","user":{"login":"gmoryes","id":17534533,"node_id":"MDQ6VXNlcjE3NTM0NTMz","avatar_url":"https://avatars2.githubusercontent.com/u/17534533?v=4","gravatar_id":"","url":"https://api.github.com/users/gmoryes","html_url":"https://github.com/gmoryes","followers_url":"https://api.github.com/users/gmoryes/followers","following_url":"https://api.github.com/users/gmoryes/following{/other_user}","gists_url":"https://api.github.com/users/gmoryes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoryes/subscriptions","organizations_url":"https://api.github.com/users/gmoryes/orgs","repos_url":"https://api.github.com/users/gmoryes/repos","events_url":"https://api.github.com/users/gmoryes/events{/privacy}","received_events_url":"https://api.github.com/users/gmoryes/received_events","type":"User","site_admin":false},"repo":{"id":141252817,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNTI4MTc=","name":"omim","full_name":"gmoryes/omim","private":false,"owner":{"login":"gmoryes","id":17534533,"node_id":"MDQ6VXNlcjE3NTM0NTMz","avatar_url":"https://avatars2.githubusercontent.com/u/17534533?v=4","gravatar_id":"","url":"https://api.github.com/users/gmoryes","html_url":"https://github.com/gmoryes","followers_url":"https://api.github.com/users/gmoryes/followers","following_url":"https://api.github.com/users/gmoryes/following{/other_user}","gists_url":"https://api.github.com/users/gmoryes/gists{/gist_id}","starred_url":"https://api.github.com/users/gmoryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmoryes/subscriptions","organizations_url":"https://api.github.com/users/gmoryes/orgs","repos_url":"https://api.github.com/users/gmoryes/repos","events_url":"https://api.github.com/users/gmoryes/events{/privacy}","received_events_url":"https://api.github.com/users/gmoryes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gmoryes/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":true,"url":"https://api.github.com/repos/gmoryes/omim","forks_url":"https://api.github.com/repos/gmoryes/omim/forks","keys_url":"https://api.github.com/repos/gmoryes/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmoryes/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmoryes/omim/teams","hooks_url":"https://api.github.com/repos/gmoryes/omim/hooks","issue_events_url":"https://api.github.com/repos/gmoryes/omim/issues/events{/number}","events_url":"https://api.github.com/repos/gmoryes/omim/events","assignees_url":"https://api.github.com/repos/gmoryes/omim/assignees{/user}","branches_url":"https://api.github.com/repos/gmoryes/omim/branches{/branch}","tags_url":"https://api.github.com/repos/gmoryes/omim/tags","blobs_url":"https://api.github.com/repos/gmoryes/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmoryes/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmoryes/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmoryes/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmoryes/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/gmoryes/omim/languages","stargazers_url":"https://api.github.com/repos/gmoryes/omim/stargazers","contributors_url":"https://api.github.com/repos/gmoryes/omim/contributors","subscribers_url":"https://api.github.com/repos/gmoryes/omim/subscribers","subscription_url":"https://api.github.com/repos/gmoryes/omim/subscription","commits_url":"https://api.github.com/repos/gmoryes/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmoryes/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmoryes/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmoryes/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmoryes/omim/contents/{+path}","compare_url":"https://api.github.com/repos/gmoryes/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmoryes/omim/merges","archive_url":"https://api.github.com/repos/gmoryes/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmoryes/omim/downloads","issues_url":"https://api.github.com/repos/gmoryes/omim/issues{/number}","pulls_url":"https://api.github.com/repos/gmoryes/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/gmoryes/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/gmoryes/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmoryes/omim/labels{/name}","releases_url":"https://api.github.com/repos/gmoryes/omim/releases{/id}","deployments_url":"https://api.github.com/repos/gmoryes/omim/deployments","created_at":"2018-07-17T07:57:11Z","updated_at":"2019-06-20T15:09:20Z","pushed_at":"2019-09-02T17:16:50Z","git_url":"git://github.com/gmoryes/omim.git","ssh_url":"git@github.com:gmoryes/omim.git","clone_url":"https://github.com/gmoryes/omim.git","svn_url":"https://github.com/gmoryes/omim","homepage":"","size":4427960,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"9c3994fdfb5e8d3e3e6f91ee00ed713c76282df8","user":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc5ODAzMw==","name":"omim","full_name":"mapsme/omim","private":false,"owner":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2019-09-03T07:19:30Z","pushed_at":"2019-09-03T11:19:28Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":4449923,"stargazers_count":3087,"watchers_count":3087,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":667,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":837,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":667,"open_issues":837,"watchers":3087,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/11067"},"html":{"href":"https://github.com/mapsme/omim/pull/11067"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/11067"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/11067/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/11067/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/11067/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/c04678969fd77936e4fefe864c6fdc28b829c02a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bykoianko"}}