{"action":"closed","number":2550,"pull_request":{"url":"https://api.github.com/repos/uber/baseweb/pulls/2550","id":356794531,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2Nzk0NTMx","html_url":"https://github.com/uber/baseweb/pull/2550","diff_url":"https://github.com/uber/baseweb/pull/2550.diff","patch_url":"https://github.com/uber/baseweb/pull/2550.patch","issue_url":"https://api.github.com/repos/uber/baseweb/issues/2550","number":2550,"state":"closed","locked":false,"title":"fix(flex-grid): re-implement FlexGridItem to avoid nth-child selectors","user":{"login":"leyanlo","id":1285326,"node_id":"MDQ6VXNlcjEyODUzMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1285326?v=4","gravatar_id":"","url":"https://api.github.com/users/leyanlo","html_url":"https://github.com/leyanlo","followers_url":"https://api.github.com/users/leyanlo/followers","following_url":"https://api.github.com/users/leyanlo/following{/other_user}","gists_url":"https://api.github.com/users/leyanlo/gists{/gist_id}","starred_url":"https://api.github.com/users/leyanlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leyanlo/subscriptions","organizations_url":"https://api.github.com/users/leyanlo/orgs","repos_url":"https://api.github.com/users/leyanlo/repos","events_url":"https://api.github.com/users/leyanlo/events{/privacy}","received_events_url":"https://api.github.com/users/leyanlo/received_events","type":"User","site_admin":false},"body":"#### Description\r\n\r\nRe-implement FlexGridItem to avoid nth-child selectors. Original implementation relied on the order of rules in the stylesheet, which is not guaranteed with Styletron, sometimes causing layout bugs if rules are out of order.\r\n\r\nBy passing the index and count props to each FlexGridItem, we can explicitly set margin-right and margin-bottom without relying on nth-child selectors. This also cleans up the DOM and reduces the number of classes:\r\n\r\nFlexGridItem classes before: \r\n![flex-grid-item-classes-before](https://user-images.githubusercontent.com/1285326/71444987-ca72ec80-26ca-11ea-9f59-991fdb0d8f4c.png)\r\nFlexGridItem classes after: \r\n![flex-grid-item-classes-after](https://user-images.githubusercontent.com/1285326/71444990-d1016400-26ca-11ea-8bfe-abae9be62462.png)\r\n\r\n#### Scope\r\n\r\n- [x] Patch: Bug Fix\r\n- [ ] Minor: New Feature\r\n- [ ] Major: Breaking Change\r\n","created_at":"2019-12-25T12:00:22Z","updated_at":"2020-01-02T22:29:09Z","closed_at":"2020-01-02T22:29:08Z","merged_at":"2020-01-02T22:29:08Z","merge_commit_sha":"73bec393215145ea41c814dbaa04243c87f6afc7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tajo","id":1387913,"node_id":"MDQ6VXNlcjEzODc5MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1387913?v=4","gravatar_id":"","url":"https://api.github.com/users/tajo","html_url":"https://github.com/tajo","followers_url":"https://api.github.com/users/tajo/followers","following_url":"https://api.github.com/users/tajo/following{/other_user}","gists_url":"https://api.github.com/users/tajo/gists{/gist_id}","starred_url":"https://api.github.com/users/tajo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tajo/subscriptions","organizations_url":"https://api.github.com/users/tajo/orgs","repos_url":"https://api.github.com/users/tajo/repos","events_url":"https://api.github.com/users/tajo/events{/privacy}","received_events_url":"https://api.github.com/users/tajo/received_events","type":"User","site_admin":false},{"login":"nadiia","id":1920399,"node_id":"MDQ6VXNlcjE5MjAzOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1920399?v=4","gravatar_id":"","url":"https://api.github.com/users/nadiia","html_url":"https://github.com/nadiia","followers_url":"https://api.github.com/users/nadiia/followers","following_url":"https://api.github.com/users/nadiia/following{/other_user}","gists_url":"https://api.github.com/users/nadiia/gists{/gist_id}","starred_url":"https://api.github.com/users/nadiia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadiia/subscriptions","organizations_url":"https://api.github.com/users/nadiia/orgs","repos_url":"https://api.github.com/users/nadiia/repos","events_url":"https://api.github.com/users/nadiia/events{/privacy}","received_events_url":"https://api.github.com/users/nadiia/received_events","type":"User","site_admin":false},{"login":"sandgraham","id":1939257,"node_id":"MDQ6VXNlcjE5MzkyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1939257?v=4","gravatar_id":"","url":"https://api.github.com/users/sandgraham","html_url":"https://github.com/sandgraham","followers_url":"https://api.github.com/users/sandgraham/followers","following_url":"https://api.github.com/users/sandgraham/following{/other_user}","gists_url":"https://api.github.com/users/sandgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/sandgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandgraham/subscriptions","organizations_url":"https://api.github.com/users/sandgraham/orgs","repos_url":"https://api.github.com/users/sandgraham/repos","events_url":"https://api.github.com/users/sandgraham/events{/privacy}","received_events_url":"https://api.github.com/users/sandgraham/received_events","type":"User","site_admin":false},{"login":"chasestarr","id":5317799,"node_id":"MDQ6VXNlcjUzMTc3OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/5317799?v=4","gravatar_id":"","url":"https://api.github.com/users/chasestarr","html_url":"https://github.com/chasestarr","followers_url":"https://api.github.com/users/chasestarr/followers","following_url":"https://api.github.com/users/chasestarr/following{/other_user}","gists_url":"https://api.github.com/users/chasestarr/gists{/gist_id}","starred_url":"https://api.github.com/users/chasestarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chasestarr/subscriptions","organizations_url":"https://api.github.com/users/chasestarr/orgs","repos_url":"https://api.github.com/users/chasestarr/repos","events_url":"https://api.github.com/users/chasestarr/events{/privacy}","received_events_url":"https://api.github.com/users/chasestarr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":861027216,"node_id":"MDU6TGFiZWw4NjEwMjcyMTY=","url":"https://api.github.com/repos/uber/baseweb/labels/bugfix","name":"bugfix","color":"499302","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/uber/baseweb/pulls/2550/commits","review_comments_url":"https://api.github.com/repos/uber/baseweb/pulls/2550/comments","review_comment_url":"https://api.github.com/repos/uber/baseweb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/baseweb/issues/2550/comments","statuses_url":"https://api.github.com/repos/uber/baseweb/statuses/d24fa01cabacf11004b82dd71b6992c5c76f10a3","head":{"label":"leyanlo:leyan/flex-grid","ref":"leyan/flex-grid","sha":"d24fa01cabacf11004b82dd71b6992c5c76f10a3","user":{"login":"leyanlo","id":1285326,"node_id":"MDQ6VXNlcjEyODUzMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1285326?v=4","gravatar_id":"","url":"https://api.github.com/users/leyanlo","html_url":"https://github.com/leyanlo","followers_url":"https://api.github.com/users/leyanlo/followers","following_url":"https://api.github.com/users/leyanlo/following{/other_user}","gists_url":"https://api.github.com/users/leyanlo/gists{/gist_id}","starred_url":"https://api.github.com/users/leyanlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leyanlo/subscriptions","organizations_url":"https://api.github.com/users/leyanlo/orgs","repos_url":"https://api.github.com/users/leyanlo/repos","events_url":"https://api.github.com/users/leyanlo/events{/privacy}","received_events_url":"https://api.github.com/users/leyanlo/received_events","type":"User","site_admin":false},"repo":{"id":154485691,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0ODU2OTE=","name":"baseui","full_name":"leyanlo/baseui","private":false,"owner":{"login":"leyanlo","id":1285326,"node_id":"MDQ6VXNlcjEyODUzMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1285326?v=4","gravatar_id":"","url":"https://api.github.com/users/leyanlo","html_url":"https://github.com/leyanlo","followers_url":"https://api.github.com/users/leyanlo/followers","following_url":"https://api.github.com/users/leyanlo/following{/other_user}","gists_url":"https://api.github.com/users/leyanlo/gists{/gist_id}","starred_url":"https://api.github.com/users/leyanlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leyanlo/subscriptions","organizations_url":"https://api.github.com/users/leyanlo/orgs","repos_url":"https://api.github.com/users/leyanlo/repos","events_url":"https://api.github.com/users/leyanlo/events{/privacy}","received_events_url":"https://api.github.com/users/leyanlo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/leyanlo/baseui","description":"A React Component library implementing the Base UI design","fork":true,"url":"https://api.github.com/repos/leyanlo/baseui","forks_url":"https://api.github.com/repos/leyanlo/baseui/forks","keys_url":"https://api.github.com/repos/leyanlo/baseui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leyanlo/baseui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leyanlo/baseui/teams","hooks_url":"https://api.github.com/repos/leyanlo/baseui/hooks","issue_events_url":"https://api.github.com/repos/leyanlo/baseui/issues/events{/number}","events_url":"https://api.github.com/repos/leyanlo/baseui/events","assignees_url":"https://api.github.com/repos/leyanlo/baseui/assignees{/user}","branches_url":"https://api.github.com/repos/leyanlo/baseui/branches{/branch}","tags_url":"https://api.github.com/repos/leyanlo/baseui/tags","blobs_url":"https://api.github.com/repos/leyanlo/baseui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leyanlo/baseui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leyanlo/baseui/git/refs{/sha}","trees_url":"https://api.github.com/repos/leyanlo/baseui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leyanlo/baseui/statuses/{sha}","languages_url":"https://api.github.com/repos/leyanlo/baseui/languages","stargazers_url":"https://api.github.com/repos/leyanlo/baseui/stargazers","contributors_url":"https://api.github.com/repos/leyanlo/baseui/contributors","subscribers_url":"https://api.github.com/repos/leyanlo/baseui/subscribers","subscription_url":"https://api.github.com/repos/leyanlo/baseui/subscription","commits_url":"https://api.github.com/repos/leyanlo/baseui/commits{/sha}","git_commits_url":"https://api.github.com/repos/leyanlo/baseui/git/commits{/sha}","comments_url":"https://api.github.com/repos/leyanlo/baseui/comments{/number}","issue_comment_url":"https://api.github.com/repos/leyanlo/baseui/issues/comments{/number}","contents_url":"https://api.github.com/repos/leyanlo/baseui/contents/{+path}","compare_url":"https://api.github.com/repos/leyanlo/baseui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leyanlo/baseui/merges","archive_url":"https://api.github.com/repos/leyanlo/baseui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leyanlo/baseui/downloads","issues_url":"https://api.github.com/repos/leyanlo/baseui/issues{/number}","pulls_url":"https://api.github.com/repos/leyanlo/baseui/pulls{/number}","milestones_url":"https://api.github.com/repos/leyanlo/baseui/milestones{/number}","notifications_url":"https://api.github.com/repos/leyanlo/baseui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leyanlo/baseui/labels{/name}","releases_url":"https://api.github.com/repos/leyanlo/baseui/releases{/id}","deployments_url":"https://api.github.com/repos/leyanlo/baseui/deployments","created_at":"2018-10-24T10:56:51Z","updated_at":"2019-10-10T18:08:38Z","pushed_at":"2020-01-02T22:12:42Z","git_url":"git://github.com/leyanlo/baseui.git","ssh_url":"git@github.com:leyanlo/baseui.git","clone_url":"https://github.com/leyanlo/baseui.git","svn_url":"https://github.com/leyanlo/baseui","homepage":"https://baseui.netlify.com","size":71866,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"73d4880e70ffc74f44129dc80b0dfd720febf55c","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":124470321,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0NzAzMjE=","name":"baseweb","full_name":"uber/baseweb","private":false,"owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uber/baseweb","description":"A React Component library implementing the Base design language","fork":false,"url":"https://api.github.com/repos/uber/baseweb","forks_url":"https://api.github.com/repos/uber/baseweb/forks","keys_url":"https://api.github.com/repos/uber/baseweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/baseweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/baseweb/teams","hooks_url":"https://api.github.com/repos/uber/baseweb/hooks","issue_events_url":"https://api.github.com/repos/uber/baseweb/issues/events{/number}","events_url":"https://api.github.com/repos/uber/baseweb/events","assignees_url":"https://api.github.com/repos/uber/baseweb/assignees{/user}","branches_url":"https://api.github.com/repos/uber/baseweb/branches{/branch}","tags_url":"https://api.github.com/repos/uber/baseweb/tags","blobs_url":"https://api.github.com/repos/uber/baseweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/baseweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/baseweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/baseweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/baseweb/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/baseweb/languages","stargazers_url":"https://api.github.com/repos/uber/baseweb/stargazers","contributors_url":"https://api.github.com/repos/uber/baseweb/contributors","subscribers_url":"https://api.github.com/repos/uber/baseweb/subscribers","subscription_url":"https://api.github.com/repos/uber/baseweb/subscription","commits_url":"https://api.github.com/repos/uber/baseweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/baseweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/baseweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/baseweb/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/baseweb/contents/{+path}","compare_url":"https://api.github.com/repos/uber/baseweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/baseweb/merges","archive_url":"https://api.github.com/repos/uber/baseweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/baseweb/downloads","issues_url":"https://api.github.com/repos/uber/baseweb/issues{/number}","pulls_url":"https://api.github.com/repos/uber/baseweb/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/baseweb/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/baseweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/baseweb/labels{/name}","releases_url":"https://api.github.com/repos/uber/baseweb/releases{/id}","deployments_url":"https://api.github.com/repos/uber/baseweb/deployments","created_at":"2018-03-09T01:32:10Z","updated_at":"2020-01-02T22:18:54Z","pushed_at":"2020-01-02T22:29:09Z","git_url":"git://github.com/uber/baseweb.git","ssh_url":"git@github.com:uber/baseweb.git","clone_url":"https://github.com/uber/baseweb.git","svn_url":"https://github.com/uber/baseweb","homepage":"https://baseweb.design","size":59872,"stargazers_count":3156,"watchers_count":3156,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":252,"open_issues":40,"watchers":3156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/baseweb/pulls/2550"},"html":{"href":"https://github.com/uber/baseweb/pull/2550"},"issue":{"href":"https://api.github.com/repos/uber/baseweb/issues/2550"},"comments":{"href":"https://api.github.com/repos/uber/baseweb/issues/2550/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/baseweb/pulls/2550/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/baseweb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/baseweb/pulls/2550/commits"},"statuses":{"href":"https://api.github.com/repos/uber/baseweb/statuses/d24fa01cabacf11004b82dd71b6992c5c76f10a3"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gergelyke","id":2174968,"node_id":"MDQ6VXNlcjIxNzQ5Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/2174968?v=4","gravatar_id":"","url":"https://api.github.com/users/gergelyke","html_url":"https://github.com/gergelyke","followers_url":"https://api.github.com/users/gergelyke/followers","following_url":"https://api.github.com/users/gergelyke/following{/other_user}","gists_url":"https://api.github.com/users/gergelyke/gists{/gist_id}","starred_url":"https://api.github.com/users/gergelyke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gergelyke/subscriptions","organizations_url":"https://api.github.com/users/gergelyke/orgs","repos_url":"https://api.github.com/users/gergelyke/repos","events_url":"https://api.github.com/users/gergelyke/events{/privacy}","received_events_url":"https://api.github.com/users/gergelyke/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":231,"deletions":279,"changed_files":7}}
{"actor":{"display_login":"gergelyke"}}