{"action":"closed","number":2727,"pull_request":{"url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2727","id":270192599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMTkyNTk5","html_url":"https://github.com/KSP-CKAN/CKAN/pull/2727","diff_url":"https://github.com/KSP-CKAN/CKAN/pull/2727.diff","patch_url":"https://github.com/KSP-CKAN/CKAN/pull/2727.patch","issue_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2727","number":2727,"state":"closed","locked":false,"title":"Fix home/end, url handler, typing nav, and dependency double click","user":{"login":"HebaruSan","id":1559108,"node_id":"MDQ6VXNlcjE1NTkxMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1559108?v=4","gravatar_id":"","url":"https://api.github.com/users/HebaruSan","html_url":"https://github.com/HebaruSan","followers_url":"https://api.github.com/users/HebaruSan/followers","following_url":"https://api.github.com/users/HebaruSan/following{/other_user}","gists_url":"https://api.github.com/users/HebaruSan/gists{/gist_id}","starred_url":"https://api.github.com/users/HebaruSan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HebaruSan/subscriptions","organizations_url":"https://api.github.com/users/HebaruSan/orgs","repos_url":"https://api.github.com/users/HebaruSan/repos","events_url":"https://api.github.com/users/HebaruSan/events{/privacy}","received_events_url":"https://api.github.com/users/HebaruSan/received_events","type":"User","site_admin":false},"body":"## Problem\r\n\r\nIf you do any of the following:\r\n\r\n- Press Home on the mod list\r\n- Press End on the mod list\r\n- Invoke the URL handler\r\n- Start typing a mod name on the mod list\r\n- Double click a mod in the mod info dependency tree\r\n\r\n... this exception occurs:\r\n\r\n```\r\nSystem.InvalidOperationException: Die aktuelle Zelle kann nicht auf eine unsichtbare Zelle festgelegt werden. (Rough translation: the current cell can't be set to an invisible cell)\r\n   bei System.Windows.Forms.DataGridView.set_CurrentCell(DataGridViewCell value)\r\n   bei CKAN.Main.ModList_KeyDown(Object sender, KeyEventArgs e)\r\n   bei System.Windows.Forms.Control.OnKeyDown(KeyEventArgs e)\r\n   bei System.Windows.Forms.DataGridView.OnKeyDown(KeyEventArgs e)\r\n   bei System.Windows.Forms.Control.ProcessKeyEventArgs(Message& m)\r\n   bei System.Windows.Forms.DataGridView.ProcessKeyEventArgs(Message& m)\r\n   bei System.Windows.Forms.Control.WmKeyChar(Message& m)\r\n   bei System.Windows.Forms.Control.WndProc(Message& m)\r\n   bei System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)\r\n```\r\n\r\n## Cause\r\n\r\nThese all work by setting `ModList.CurrentCell` to a row's third cell, for reasons explained here:\r\n\r\nhttps://github.com/KSP-CKAN/CKAN/blob/3bc537637e8f4452c9787699045d61b4d869061f/GUI/Main.cs#L1055-L1056\r\n\r\nHowever, as of #2671, the third cell is Replace instead of Name, and as of #2690, it's hidden most of the time. A hidden cell cannot be the current cell, so an exception is thrown. This is essentially the same problem as #2703, but it's not specific to the mark-all-updates operation.\r\n\r\n## Changes\r\n\r\nNow we look for usable columns in this order:\r\n\r\n1. The current column, if any, to avoid scrolling horizontally\r\n2. The first visible non-checkbox column, if any\r\n3. The Installed checkbox column (always visible fallback)\r\n\r\nIn addition, the fix for #2704 is modified to use this same logic. I think the original reasoning from the comment quoted above applies here, and so we should avoid setting focus to checkboxes when we can.\r\n\r\nFixes KSP-CKAN/NetKAN#7108.","created_at":"2019-04-13T01:41:33Z","updated_at":"2019-04-20T18:49:26Z","closed_at":"2019-04-20T18:49:26Z","merged_at":"2019-04-20T18:49:26Z","merge_commit_sha":"3b553bbd5a32a684b2588b5ac274bfdb66be1685","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":122535234,"node_id":"MDU6TGFiZWwxMjI1MzUyMzQ=","url":"https://api.github.com/repos/KSP-CKAN/CKAN/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":139464212,"node_id":"MDU6TGFiZWwxMzk0NjQyMTI=","url":"https://api.github.com/repos/KSP-CKAN/CKAN/labels/GUI","name":"GUI","color":"006b75","default":false},{"id":139897064,"node_id":"MDU6TGFiZWwxMzk4OTcwNjQ=","url":"https://api.github.com/repos/KSP-CKAN/CKAN/labels/Pull%20request","name":"Pull request","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2727/commits","review_comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2727/comments","review_comment_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2727/comments","statuses_url":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/3b553bbd5a32a684b2588b5ac274bfdb66be1685","head":{"label":"HebaruSan:fix/home-end-crash","ref":"fix/home-end-crash","sha":"3b553bbd5a32a684b2588b5ac274bfdb66be1685","user":{"login":"HebaruSan","id":1559108,"node_id":"MDQ6VXNlcjE1NTkxMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1559108?v=4","gravatar_id":"","url":"https://api.github.com/users/HebaruSan","html_url":"https://github.com/HebaruSan","followers_url":"https://api.github.com/users/HebaruSan/followers","following_url":"https://api.github.com/users/HebaruSan/following{/other_user}","gists_url":"https://api.github.com/users/HebaruSan/gists{/gist_id}","starred_url":"https://api.github.com/users/HebaruSan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HebaruSan/subscriptions","organizations_url":"https://api.github.com/users/HebaruSan/orgs","repos_url":"https://api.github.com/users/HebaruSan/repos","events_url":"https://api.github.com/users/HebaruSan/events{/privacy}","received_events_url":"https://api.github.com/users/HebaruSan/received_events","type":"User","site_admin":false},"repo":{"id":101696387,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE2OTYzODc=","name":"CKAN","full_name":"HebaruSan/CKAN","private":false,"owner":{"login":"HebaruSan","id":1559108,"node_id":"MDQ6VXNlcjE1NTkxMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1559108?v=4","gravatar_id":"","url":"https://api.github.com/users/HebaruSan","html_url":"https://github.com/HebaruSan","followers_url":"https://api.github.com/users/HebaruSan/followers","following_url":"https://api.github.com/users/HebaruSan/following{/other_user}","gists_url":"https://api.github.com/users/HebaruSan/gists{/gist_id}","starred_url":"https://api.github.com/users/HebaruSan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HebaruSan/subscriptions","organizations_url":"https://api.github.com/users/HebaruSan/orgs","repos_url":"https://api.github.com/users/HebaruSan/repos","events_url":"https://api.github.com/users/HebaruSan/events{/privacy}","received_events_url":"https://api.github.com/users/HebaruSan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HebaruSan/CKAN","description":"The Comprehensive Kerbal Archive Network","fork":true,"url":"https://api.github.com/repos/HebaruSan/CKAN","forks_url":"https://api.github.com/repos/HebaruSan/CKAN/forks","keys_url":"https://api.github.com/repos/HebaruSan/CKAN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HebaruSan/CKAN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HebaruSan/CKAN/teams","hooks_url":"https://api.github.com/repos/HebaruSan/CKAN/hooks","issue_events_url":"https://api.github.com/repos/HebaruSan/CKAN/issues/events{/number}","events_url":"https://api.github.com/repos/HebaruSan/CKAN/events","assignees_url":"https://api.github.com/repos/HebaruSan/CKAN/assignees{/user}","branches_url":"https://api.github.com/repos/HebaruSan/CKAN/branches{/branch}","tags_url":"https://api.github.com/repos/HebaruSan/CKAN/tags","blobs_url":"https://api.github.com/repos/HebaruSan/CKAN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HebaruSan/CKAN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HebaruSan/CKAN/git/refs{/sha}","trees_url":"https://api.github.com/repos/HebaruSan/CKAN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HebaruSan/CKAN/statuses/{sha}","languages_url":"https://api.github.com/repos/HebaruSan/CKAN/languages","stargazers_url":"https://api.github.com/repos/HebaruSan/CKAN/stargazers","contributors_url":"https://api.github.com/repos/HebaruSan/CKAN/contributors","subscribers_url":"https://api.github.com/repos/HebaruSan/CKAN/subscribers","subscription_url":"https://api.github.com/repos/HebaruSan/CKAN/subscription","commits_url":"https://api.github.com/repos/HebaruSan/CKAN/commits{/sha}","git_commits_url":"https://api.github.com/repos/HebaruSan/CKAN/git/commits{/sha}","comments_url":"https://api.github.com/repos/HebaruSan/CKAN/comments{/number}","issue_comment_url":"https://api.github.com/repos/HebaruSan/CKAN/issues/comments{/number}","contents_url":"https://api.github.com/repos/HebaruSan/CKAN/contents/{+path}","compare_url":"https://api.github.com/repos/HebaruSan/CKAN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HebaruSan/CKAN/merges","archive_url":"https://api.github.com/repos/HebaruSan/CKAN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HebaruSan/CKAN/downloads","issues_url":"https://api.github.com/repos/HebaruSan/CKAN/issues{/number}","pulls_url":"https://api.github.com/repos/HebaruSan/CKAN/pulls{/number}","milestones_url":"https://api.github.com/repos/HebaruSan/CKAN/milestones{/number}","notifications_url":"https://api.github.com/repos/HebaruSan/CKAN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HebaruSan/CKAN/labels{/name}","releases_url":"https://api.github.com/repos/HebaruSan/CKAN/releases{/id}","deployments_url":"https://api.github.com/repos/HebaruSan/CKAN/deployments","created_at":"2017-08-28T23:16:51Z","updated_at":"2018-08-30T02:59:59Z","pushed_at":"2019-04-18T17:57:47Z","git_url":"git://github.com/HebaruSan/CKAN.git","ssh_url":"git@github.com:HebaruSan/CKAN.git","clone_url":"https://github.com/HebaruSan/CKAN.git","svn_url":"https://github.com/HebaruSan/CKAN","homepage":"","size":27051,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KSP-CKAN:master","ref":"master","sha":"3bc537637e8f4452c9787699045d61b4d869061f","user":{"login":"KSP-CKAN","id":9023970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMjM5NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/9023970?v=4","gravatar_id":"","url":"https://api.github.com/users/KSP-CKAN","html_url":"https://github.com/KSP-CKAN","followers_url":"https://api.github.com/users/KSP-CKAN/followers","following_url":"https://api.github.com/users/KSP-CKAN/following{/other_user}","gists_url":"https://api.github.com/users/KSP-CKAN/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-CKAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-CKAN/subscriptions","organizations_url":"https://api.github.com/users/KSP-CKAN/orgs","repos_url":"https://api.github.com/users/KSP-CKAN/repos","events_url":"https://api.github.com/users/KSP-CKAN/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-CKAN/received_events","type":"Organization","site_admin":false},"repo":{"id":23050594,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA1MDU5NA==","name":"CKAN","full_name":"KSP-CKAN/CKAN","private":false,"owner":{"login":"KSP-CKAN","id":9023970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMjM5NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/9023970?v=4","gravatar_id":"","url":"https://api.github.com/users/KSP-CKAN","html_url":"https://github.com/KSP-CKAN","followers_url":"https://api.github.com/users/KSP-CKAN/followers","following_url":"https://api.github.com/users/KSP-CKAN/following{/other_user}","gists_url":"https://api.github.com/users/KSP-CKAN/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-CKAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-CKAN/subscriptions","organizations_url":"https://api.github.com/users/KSP-CKAN/orgs","repos_url":"https://api.github.com/users/KSP-CKAN/repos","events_url":"https://api.github.com/users/KSP-CKAN/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-CKAN/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KSP-CKAN/CKAN","description":"The Comprehensive Kerbal Archive Network","fork":false,"url":"https://api.github.com/repos/KSP-CKAN/CKAN","forks_url":"https://api.github.com/repos/KSP-CKAN/CKAN/forks","keys_url":"https://api.github.com/repos/KSP-CKAN/CKAN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KSP-CKAN/CKAN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KSP-CKAN/CKAN/teams","hooks_url":"https://api.github.com/repos/KSP-CKAN/CKAN/hooks","issue_events_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/events{/number}","events_url":"https://api.github.com/repos/KSP-CKAN/CKAN/events","assignees_url":"https://api.github.com/repos/KSP-CKAN/CKAN/assignees{/user}","branches_url":"https://api.github.com/repos/KSP-CKAN/CKAN/branches{/branch}","tags_url":"https://api.github.com/repos/KSP-CKAN/CKAN/tags","blobs_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/refs{/sha}","trees_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/{sha}","languages_url":"https://api.github.com/repos/KSP-CKAN/CKAN/languages","stargazers_url":"https://api.github.com/repos/KSP-CKAN/CKAN/stargazers","contributors_url":"https://api.github.com/repos/KSP-CKAN/CKAN/contributors","subscribers_url":"https://api.github.com/repos/KSP-CKAN/CKAN/subscribers","subscription_url":"https://api.github.com/repos/KSP-CKAN/CKAN/subscription","commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/commits{/sha}","git_commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/commits{/sha}","comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/comments{/number}","issue_comment_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/comments{/number}","contents_url":"https://api.github.com/repos/KSP-CKAN/CKAN/contents/{+path}","compare_url":"https://api.github.com/repos/KSP-CKAN/CKAN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KSP-CKAN/CKAN/merges","archive_url":"https://api.github.com/repos/KSP-CKAN/CKAN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KSP-CKAN/CKAN/downloads","issues_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues{/number}","pulls_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls{/number}","milestones_url":"https://api.github.com/repos/KSP-CKAN/CKAN/milestones{/number}","notifications_url":"https://api.github.com/repos/KSP-CKAN/CKAN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KSP-CKAN/CKAN/labels{/name}","releases_url":"https://api.github.com/repos/KSP-CKAN/CKAN/releases{/id}","deployments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/deployments","created_at":"2014-08-17T21:11:54Z","updated_at":"2019-04-18T13:58:06Z","pushed_at":"2019-04-20T18:49:23Z","git_url":"git://github.com/KSP-CKAN/CKAN.git","ssh_url":"git@github.com:KSP-CKAN/CKAN.git","clone_url":"https://github.com/KSP-CKAN/CKAN.git","svn_url":"https://github.com/KSP-CKAN/CKAN","homepage":"http://forum.kerbalspaceprogram.com/index.php?/topic/154922-ckan","size":27002,"stargazers_count":912,"watchers_count":912,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":214,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":222,"open_issues":214,"watchers":912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2727"},"html":{"href":"https://github.com/KSP-CKAN/CKAN/pull/2727"},"issue":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2727"},"comments":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2727/comments"},"review_comments":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2727/comments"},"review_comment":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2727/commits"},"statuses":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/3b553bbd5a32a684b2588b5ac274bfdb66be1685"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"HebaruSan","id":1559108,"node_id":"MDQ6VXNlcjE1NTkxMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1559108?v=4","gravatar_id":"","url":"https://api.github.com/users/HebaruSan","html_url":"https://github.com/HebaruSan","followers_url":"https://api.github.com/users/HebaruSan/followers","following_url":"https://api.github.com/users/HebaruSan/following{/other_user}","gists_url":"https://api.github.com/users/HebaruSan/gists{/gist_id}","starred_url":"https://api.github.com/users/HebaruSan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HebaruSan/subscriptions","organizations_url":"https://api.github.com/users/HebaruSan/orgs","repos_url":"https://api.github.com/users/HebaruSan/repos","events_url":"https://api.github.com/users/HebaruSan/events{/privacy}","received_events_url":"https://api.github.com/users/HebaruSan/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":24,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"HebaruSan"}}