{"action":"opened","issue":{"url":"https://api.github.com/repos/rtrlib/rtrlib/issues/227","repository_url":"https://api.github.com/repos/rtrlib/rtrlib","labels_url":"https://api.github.com/repos/rtrlib/rtrlib/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/rtrlib/rtrlib/issues/227/comments","events_url":"https://api.github.com/repos/rtrlib/rtrlib/issues/227/events","html_url":"https://github.com/rtrlib/rtrlib/issues/227","id":424486658,"node_id":"MDU6SXNzdWU0MjQ0ODY2NTg=","number":227,"title":"IPv6 and ipv4 parser behave different","user":{"login":"mroethke","id":21661035,"node_id":"MDQ6VXNlcjIxNjYxMDM1","avatar_url":"https://avatars2.githubusercontent.com/u/21661035?v=4","gravatar_id":"","url":"https://api.github.com/users/mroethke","html_url":"https://github.com/mroethke","followers_url":"https://api.github.com/users/mroethke/followers","following_url":"https://api.github.com/users/mroethke/following{/other_user}","gists_url":"https://api.github.com/users/mroethke/gists{/gist_id}","starred_url":"https://api.github.com/users/mroethke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroethke/subscriptions","organizations_url":"https://api.github.com/users/mroethke/orgs","repos_url":"https://api.github.com/users/mroethke/repos","events_url":"https://api.github.com/users/mroethke/events{/privacy}","received_events_url":"https://api.github.com/users/mroethke/received_events","type":"User","site_admin":false},"labels":[{"id":43322505,"node_id":"MDU6TGFiZWw0MzMyMjUwNQ==","url":"https://api.github.com/repos/rtrlib/rtrlib/labels/type:bug","name":"type:bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":{"login":"mroethke","id":21661035,"node_id":"MDQ6VXNlcjIxNjYxMDM1","avatar_url":"https://avatars2.githubusercontent.com/u/21661035?v=4","gravatar_id":"","url":"https://api.github.com/users/mroethke","html_url":"https://github.com/mroethke","followers_url":"https://api.github.com/users/mroethke/followers","following_url":"https://api.github.com/users/mroethke/following{/other_user}","gists_url":"https://api.github.com/users/mroethke/gists{/gist_id}","starred_url":"https://api.github.com/users/mroethke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroethke/subscriptions","organizations_url":"https://api.github.com/users/mroethke/orgs","repos_url":"https://api.github.com/users/mroethke/repos","events_url":"https://api.github.com/users/mroethke/events{/privacy}","received_events_url":"https://api.github.com/users/mroethke/received_events","type":"User","site_admin":false},"assignees":[{"login":"mroethke","id":21661035,"node_id":"MDQ6VXNlcjIxNjYxMDM1","avatar_url":"https://avatars2.githubusercontent.com/u/21661035?v=4","gravatar_id":"","url":"https://api.github.com/users/mroethke","html_url":"https://github.com/mroethke","followers_url":"https://api.github.com/users/mroethke/followers","following_url":"https://api.github.com/users/mroethke/following{/other_user}","gists_url":"https://api.github.com/users/mroethke/gists{/gist_id}","starred_url":"https://api.github.com/users/mroethke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroethke/subscriptions","organizations_url":"https://api.github.com/users/mroethke/orgs","repos_url":"https://api.github.com/users/mroethke/repos","events_url":"https://api.github.com/users/mroethke/events{/privacy}","received_events_url":"https://api.github.com/users/mroethke/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2019-03-23T10:33:32Z","updated_at":"2019-03-23T10:33:32Z","closed_at":null,"author_association":"MEMBER","body":"### Description\r\nIpv4 addresses may be trailed by random characters(e.g. prefix length) and the parser will happily ignore it, the IPv6 address parser does not allow that.\r\n\r\n### Steps to reproduce the issue\r\nTry to parse `192.168.0.0/24` and `fc00::/56` with `lrtr_ip_str_to_addr`.\r\n\r\n### Expected results\r\nBoth should behave the same, ideally returning an error.\r\n\r\n### Actual results\r\nThe v4 address is parsed fine (ignoring the prefix) the v6 parser returns a error.\r\n\r\n\r\n\r\nSince this could break existing applications I would like to discuss what we should do.\r\nThe best solution would be to return an error, but allowing trailing characters could of course also be implemented for the v6 parser to provide consistency and preserve compatibility.\r\n"}}
{"actor":{"display_login":"mroethke"}}