{"action":"closed","issue":{"url":"https://api.github.com/repos/kristapsdz/rpki-client/issues/3","repository_url":"https://api.github.com/repos/kristapsdz/rpki-client","labels_url":"https://api.github.com/repos/kristapsdz/rpki-client/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/kristapsdz/rpki-client/issues/3/comments","events_url":"https://api.github.com/repos/kristapsdz/rpki-client/issues/3/events","html_url":"https://github.com/kristapsdz/rpki-client/issues/3","id":458250746,"node_id":"MDU6SXNzdWU0NTgyNTA3NDY=","number":3,"title":"CFLAGS/LDADD mangled by unpatched Makefile","user":{"login":"robert-scheck","id":10982488,"node_id":"MDQ6VXNlcjEwOTgyNDg4","avatar_url":"https://avatars3.githubusercontent.com/u/10982488?v=4","gravatar_id":"","url":"https://api.github.com/users/robert-scheck","html_url":"https://github.com/robert-scheck","followers_url":"https://api.github.com/users/robert-scheck/followers","following_url":"https://api.github.com/users/robert-scheck/following{/other_user}","gists_url":"https://api.github.com/users/robert-scheck/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-scheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-scheck/subscriptions","organizations_url":"https://api.github.com/users/robert-scheck/orgs","repos_url":"https://api.github.com/users/robert-scheck/repos","events_url":"https://api.github.com/users/robert-scheck/events{/privacy}","received_events_url":"https://api.github.com/users/robert-scheck/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-06-19T22:17:51Z","updated_at":"2019-11-17T12:48:44Z","closed_at":"2019-11-17T12:48:44Z","author_association":"NONE","body":"Speaking from a downstream perspective, I would like to avoid patching a software if possible. Thus the currently mangled `CFLAGS` variable in an unpatched Makefile is suboptimal.\r\n\r\nIn the following example, your upstream `CFLAGS` from `configure:63-65` are not applicable to `make` anymore:\r\n\r\n```\r\nexport CFLAGS=\"$RPM_OPT_FLAGS\"\r\n./configure LDFLAGS=\"$RPM_LD_FLAGS\"\r\nmake CFLAGS+=\"$(pkg-config --cflags openssl)\" LDADD+=\"$(pkg-config --libs openssl) -lresolv\"\r\n```\r\n\r\nIf I skip the `CFLAGS` for `make` (or set them before `./configure`), I still have your upstream include path defaults dangling around. Thus could you introduce something like `CFLAGS_OPENSSL` and `LDFLAGS_OPENSSL`, please?\r\n\r\nUntested example of what I'm looking for in `Makefile`:\r\n\r\n```\r\n[…]\r\n\r\n# Linux.\r\n#CFLAGS_OPENSSL += `pkg-config --libs openssl` -lresolv\r\n#LDFLAGS_OPENSSL += `pkg-config --cflags openssl`\r\n\r\n# OpenBSD.\r\nCFLAGS_OPENSSL += -I/usr/local/include/eopenssl\r\nLDFLAGS_OPENSSL += /usr/local/lib/eopenssl/libssl.a /usr/local/lib/eopenssl/libcrypto.a\r\n\r\n# Either this or use $(CFLAGS_OPENSSL)/$(LDFLAGS_OPENSSL) in $(CC) calls directly\r\nCFLAGS += CFLAGS_OPENSSL\r\nLDFLAGS += LDFLAGS_OPENSSL\r\n\r\n[…]\r\n```\r\nThus I simply could do the following without nuking your upstream `CFLAGS` from `configure:63-65`.\r\n\r\n```\r\nexport CFLAGS=\"$RPM_OPT_FLAGS\"\r\n./configure LDFLAGS=\"$RPM_LD_FLAGS\"\r\nmake CFLAGS_OPENSSL=\"$(pkg-config --cflags openssl)\" LDFLAGS_OPENSSL=\"$(pkg-config --libs openssl)\" LDADD=\"-lresolv\"\r\n```\r\n\r\nAlternatively, given there are `LDFLAGS` *and* `LDADD`, introduce something equivalent for `CFLAGS`."}}
{"actor":{"display_login":"kristapsdz"}}