{"action":"created","comment":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments/322489868","pull_request_review_id":285829230,"id":322489868,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMjQ4OTg2OA==","diff_hunk":"@@ -137,7 +138,7 @@ usage(int code)\n \t\t\"       %*s [--part_info part_info_name] [--enable_trusty] [--intr_monitor param_setting]\\n\"\n \t\t\"       %*s [--vtpm2 sock_path] [--virtio_poll interval] [--mac_seed seed_string]\\n\"\n \t\t\"       %*s [--vmcfg sub_options] [--dump vm_idx] [--ptdev_no_reset] [--debugexit] \\n\"\n-\t\t\"       %*s [--logger-setting param_setting] <vm>\\n\"\n+\t\t\"       %*s [--logger-setting param_setting] [--guest_notify_method method] <vm>\\n\"","path":"devicemodel/core/main.c","position":13,"original_position":13,"commit_id":"516a6a6bebbbf1a11183f45fcdffa28c2a37ae63","original_commit_id":"516a6a6bebbbf1a11183f45fcdffa28c2a37ae63","user":{"login":"fyin1","id":35988952,"node_id":"MDQ6VXNlcjM1OTg4OTUy","avatar_url":"https://avatars1.githubusercontent.com/u/35988952?v=4","gravatar_id":"","url":"https://api.github.com/users/fyin1","html_url":"https://github.com/fyin1","followers_url":"https://api.github.com/users/fyin1/followers","following_url":"https://api.github.com/users/fyin1/following{/other_user}","gists_url":"https://api.github.com/users/fyin1/gists{/gist_id}","starred_url":"https://api.github.com/users/fyin1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fyin1/subscriptions","organizations_url":"https://api.github.com/users/fyin1/orgs","repos_url":"https://api.github.com/users/fyin1/repos","events_url":"https://api.github.com/users/fyin1/events{/privacy}","received_events_url":"https://api.github.com/users/fyin1/received_events","type":"User","site_admin":false},"body":"Oh. Just get your point. This guest_notify_method is incorrect. It should be \"--pm_notify_channel\".\r\nThanks a lot for pointing this out.","created_at":"2019-09-09T23:02:16Z","updated_at":"2019-09-09T23:02:16Z","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/3655#discussion_r322489868","pull_request_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/3655","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments/322489868"},"html":{"href":"https://github.com/projectacrn/acrn-hypervisor/pull/3655#discussion_r322489868"},"pull_request":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/3655"}},"in_reply_to_id":322114710},"pull_request":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/3655","id":315343594,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1MzQzNTk0","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/3655","diff_url":"https://github.com/projectacrn/acrn-hypervisor/pull/3655.diff","patch_url":"https://github.com/projectacrn/acrn-hypervisor/pull/3655.patch","issue_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/3655","number":3655,"state":"open","locked":false,"title":"Pm notify channel","user":{"login":"fyin1","id":35988952,"node_id":"MDQ6VXNlcjM1OTg4OTUy","avatar_url":"https://avatars1.githubusercontent.com/u/35988952?v=4","gravatar_id":"","url":"https://api.github.com/users/fyin1","html_url":"https://github.com/fyin1","followers_url":"https://api.github.com/users/fyin1/followers","following_url":"https://api.github.com/users/fyin1/following{/other_user}","gists_url":"https://api.github.com/users/fyin1/gists{/gist_id}","starred_url":"https://api.github.com/users/fyin1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fyin1/subscriptions","organizations_url":"https://api.github.com/users/fyin1/orgs","repos_url":"https://api.github.com/users/fyin1/repos","events_url":"https://api.github.com/users/fyin1/events{/privacy}","received_events_url":"https://api.github.com/users/fyin1/received_events","type":"User","site_admin":false},"body":"Refine the guest power event notification related code a little bit. To make it easy that add vuart as new channel.\r\n\r\nTracked-on: #3564\r\nSigned-off-by: Yin Fengwei <fengwei.yin@intel.com>\r\nReviewed-by: Yuan Liu <yuan1.liu@intel.com>\r\nAcked-by: Wang Yu <yu1.wang@intel.com>","created_at":"2019-09-09T03:32:26Z","updated_at":"2019-09-09T23:02:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b37d3fdc731b31100fa923e57446d3d299caeda","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anthonyzxu","id":17092385,"node_id":"MDQ6VXNlcjE3MDkyMzg1","avatar_url":"https://avatars2.githubusercontent.com/u/17092385?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonyzxu","html_url":"https://github.com/anthonyzxu","followers_url":"https://api.github.com/users/anthonyzxu/followers","following_url":"https://api.github.com/users/anthonyzxu/following{/other_user}","gists_url":"https://api.github.com/users/anthonyzxu/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyzxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyzxu/subscriptions","organizations_url":"https://api.github.com/users/anthonyzxu/orgs","repos_url":"https://api.github.com/users/anthonyzxu/repos","events_url":"https://api.github.com/users/anthonyzxu/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyzxu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1106652365,"node_id":"MDU6TGFiZWwxMTA2NjUyMzY1","url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/labels/CI:%20Tracked%20On%20error","name":"CI: Tracked On error","color":"f25e83","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/3655/commits","review_comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/3655/comments","review_comment_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/3655/comments","statuses_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/statuses/516a6a6bebbbf1a11183f45fcdffa28c2a37ae63","head":{"label":"fyin1:pm_notify_channel","ref":"pm_notify_channel","sha":"516a6a6bebbbf1a11183f45fcdffa28c2a37ae63","user":{"login":"fyin1","id":35988952,"node_id":"MDQ6VXNlcjM1OTg4OTUy","avatar_url":"https://avatars1.githubusercontent.com/u/35988952?v=4","gravatar_id":"","url":"https://api.github.com/users/fyin1","html_url":"https://github.com/fyin1","followers_url":"https://api.github.com/users/fyin1/followers","following_url":"https://api.github.com/users/fyin1/following{/other_user}","gists_url":"https://api.github.com/users/fyin1/gists{/gist_id}","starred_url":"https://api.github.com/users/fyin1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fyin1/subscriptions","organizations_url":"https://api.github.com/users/fyin1/orgs","repos_url":"https://api.github.com/users/fyin1/repos","events_url":"https://api.github.com/users/fyin1/events{/privacy}","received_events_url":"https://api.github.com/users/fyin1/received_events","type":"User","site_admin":false},"repo":{"id":125000115,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwMDAxMTU=","name":"acrn-hypervisor","full_name":"fyin1/acrn-hypervisor","private":false,"owner":{"login":"fyin1","id":35988952,"node_id":"MDQ6VXNlcjM1OTg4OTUy","avatar_url":"https://avatars1.githubusercontent.com/u/35988952?v=4","gravatar_id":"","url":"https://api.github.com/users/fyin1","html_url":"https://github.com/fyin1","followers_url":"https://api.github.com/users/fyin1/followers","following_url":"https://api.github.com/users/fyin1/following{/other_user}","gists_url":"https://api.github.com/users/fyin1/gists{/gist_id}","starred_url":"https://api.github.com/users/fyin1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fyin1/subscriptions","organizations_url":"https://api.github.com/users/fyin1/orgs","repos_url":"https://api.github.com/users/fyin1/repos","events_url":"https://api.github.com/users/fyin1/events{/privacy}","received_events_url":"https://api.github.com/users/fyin1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fyin1/acrn-hypervisor","description":"Project ACRN hypervisor ","fork":true,"url":"https://api.github.com/repos/fyin1/acrn-hypervisor","forks_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/forks","keys_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/teams","hooks_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/hooks","issue_events_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/issues/events{/number}","events_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/events","assignees_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/assignees{/user}","branches_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/branches{/branch}","tags_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/tags","blobs_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/statuses/{sha}","languages_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/languages","stargazers_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/stargazers","contributors_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/contributors","subscribers_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/subscribers","subscription_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/subscription","commits_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/contents/{+path}","compare_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/merges","archive_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/downloads","issues_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/issues{/number}","pulls_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/pulls{/number}","milestones_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/milestones{/number}","notifications_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/labels{/name}","releases_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/releases{/id}","deployments_url":"https://api.github.com/repos/fyin1/acrn-hypervisor/deployments","created_at":"2018-03-13T05:59:52Z","updated_at":"2018-08-08T03:16:38Z","pushed_at":"2019-09-09T07:26:17Z","git_url":"git://github.com/fyin1/acrn-hypervisor.git","ssh_url":"git@github.com:fyin1/acrn-hypervisor.git","clone_url":"https://github.com/fyin1/acrn-hypervisor.git","svn_url":"https://github.com/fyin1/acrn-hypervisor","homepage":"","size":58868,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectacrn:master","ref":"master","sha":"81435f5504e1284744f4a36929e889f3b240d94d","user":{"login":"projectacrn","id":36865262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODY1MjYy","avatar_url":"https://avatars1.githubusercontent.com/u/36865262?v=4","gravatar_id":"","url":"https://api.github.com/users/projectacrn","html_url":"https://github.com/projectacrn","followers_url":"https://api.github.com/users/projectacrn/followers","following_url":"https://api.github.com/users/projectacrn/following{/other_user}","gists_url":"https://api.github.com/users/projectacrn/gists{/gist_id}","starred_url":"https://api.github.com/users/projectacrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectacrn/subscriptions","organizations_url":"https://api.github.com/users/projectacrn/orgs","repos_url":"https://api.github.com/users/projectacrn/repos","events_url":"https://api.github.com/users/projectacrn/events{/privacy}","received_events_url":"https://api.github.com/users/projectacrn/received_events","type":"Organization","site_admin":false},"repo":{"id":123983554,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5ODM1NTQ=","name":"acrn-hypervisor","full_name":"projectacrn/acrn-hypervisor","private":false,"owner":{"login":"projectacrn","id":36865262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODY1MjYy","avatar_url":"https://avatars1.githubusercontent.com/u/36865262?v=4","gravatar_id":"","url":"https://api.github.com/users/projectacrn","html_url":"https://github.com/projectacrn","followers_url":"https://api.github.com/users/projectacrn/followers","following_url":"https://api.github.com/users/projectacrn/following{/other_user}","gists_url":"https://api.github.com/users/projectacrn/gists{/gist_id}","starred_url":"https://api.github.com/users/projectacrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectacrn/subscriptions","organizations_url":"https://api.github.com/users/projectacrn/orgs","repos_url":"https://api.github.com/users/projectacrn/repos","events_url":"https://api.github.com/users/projectacrn/events{/privacy}","received_events_url":"https://api.github.com/users/projectacrn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/projectacrn/acrn-hypervisor","description":"Project ACRN hypervisor ","fork":false,"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor","forks_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/forks","keys_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/teams","hooks_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/hooks","issue_events_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/events{/number}","events_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/events","assignees_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/assignees{/user}","branches_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/branches{/branch}","tags_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/tags","blobs_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/statuses/{sha}","languages_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/languages","stargazers_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/stargazers","contributors_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/contributors","subscribers_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/subscribers","subscription_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/subscription","commits_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/contents/{+path}","compare_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/merges","archive_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/downloads","issues_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues{/number}","pulls_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls{/number}","milestones_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/milestones{/number}","notifications_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/labels{/name}","releases_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/releases{/id}","deployments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/deployments","created_at":"2018-03-05T21:52:25Z","updated_at":"2019-09-09T22:24:39Z","pushed_at":"2019-09-09T22:24:37Z","git_url":"git://github.com/projectacrn/acrn-hypervisor.git","ssh_url":"git@github.com:projectacrn/acrn-hypervisor.git","clone_url":"https://github.com/projectacrn/acrn-hypervisor.git","svn_url":"https://github.com/projectacrn/acrn-hypervisor","homepage":"","size":59491,"stargazers_count":427,"watchers_count":427,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":125,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":290,"open_issues":125,"watchers":427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/3655"},"html":{"href":"https://github.com/projectacrn/acrn-hypervisor/pull/3655"},"issue":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/3655"},"comments":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/3655/comments"},"review_comments":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/3655/comments"},"review_comment":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/3655/commits"},"statuses":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/statuses/516a6a6bebbbf1a11183f45fcdffa28c2a37ae63"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fyin1"}}