{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/27558","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/27558/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/27558/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/27558/events","html_url":"https://github.com/cms-sw/cmssw/pull/27558","id":469944097,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5MDU0Mzg5","number":27558,"title":"Use default compiler generated methods in TrajectorySeed","user":{"login":"Dr15Jones","id":3757616,"node_id":"MDQ6VXNlcjM3NTc2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":170521617,"node_id":"MDU6TGFiZWwxNzA1MjE2MTc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"ff8000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/81","html_url":"https://github.com/cms-sw/cmssw/milestone/81","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/81/labels","id":4314065,"node_id":"MDk6TWlsZXN0b25lNDMxNDA2NQ==","number":81,"title":"CMSSW_11_0_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":655,"state":"open","created_at":"2019-05-14T17:36:57Z","updated_at":"2019-07-18T19:53:07Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2019-07-18T19:17:19Z","updated_at":"2019-07-18T20:36:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/27558","html_url":"https://github.com/cms-sw/cmssw/pull/27558","diff_url":"https://github.com/cms-sw/cmssw/pull/27558.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/27558.patch"},"body":"#### PR description:\r\n\r\nThe hand written move based operator= was flagging an UBSAN error when RVO was not able to be used. The uninitialized final value was having its members being swapped to the returned object.\r\n\r\n#### PR validation:\r\n\r\nThe code compiles."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/512977337","html_url":"https://github.com/cms-sw/cmssw/pull/27558#issuecomment-512977337","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/27558","id":512977337,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMjk3NzMzNw==","user":{"login":"Dr15Jones","id":3757616,"node_id":"MDQ6VXNlcjM3NTc2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"created_at":"2019-07-18T20:36:34Z","updated_at":"2019-07-18T20:36:34Z","author_association":"CONTRIBUTOR","body":"The UBSAN report was complaining that an uninitialized value was being used in the call to `operator=` when assigning to the return value here\r\n\r\nhttps://github.com/cms-sw/cmssw/blob/ae97882c71933048f2a47a9eaeac124813029f8f/RecoMuon/MuonSeedGenerator/src/MuonCSCSeedFromRecHits.cc#L220\r\n\r\nultimately the object assigned to `seed` came from here\r\nhttps://github.com/cms-sw/cmssw/blob/ae97882c71933048f2a47a9eaeac124813029f8f/RecoMuon/MuonSeedGenerator/src/MuonCSCSeedFromRecHits.cc#L18\r\n\r\nAs the default constructor does not set any values, this lead to the UBSAN error. The compiler generated move `operator=` does not suffer from that problem since it would not swap the values and instead just overwrite the uninitialized values."}}
{"actor":{"display_login":"Dr15Jones"}}