{"action":"created","issue":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/13232","repository_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/13232/labels{/name}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/13232/comments","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/13232/events","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/13232","id":539732794,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0NjU2OTE2","number":13232,"title":"HPCC-23230 Rationalize createValue() and createDataset()","user":{"login":"ghalliday","id":902490,"node_id":"MDQ6VXNlcjkwMjQ5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/902490?v=4","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-12-18T14:56:39Z","updated_at":"2019-12-18T15:35:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/13232","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/13232","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/13232.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/13232.patch"},"body":"<!-- Thank you for submitting a pull request to the HPCC project\r\n\r\n PLEASE READ the following before proceeding.\r\n\r\n This project only accepts pull requests related to open JIRA issues.\r\n If suggesting a new feature or change, please discuss it in a JIRA issue first.\r\n If fixing a bug, there should be an issue describing it with steps to reproduce.\r\n The title line of the pull request (and of each commit within it) should refer to the\r\n associated issue using the format:\r\n\r\n HPCC-nnnnn Short description of issue\r\n\r\n This will allow the Jira ticket to be automatically updated to refer to this pull request,\r\n and will ensure that the automatically-generated changelog is properly formatted.\r\n Where a pull request contains a single commit the pull request title will be set automatically,\r\n assuming that the commit has followed the proper guidelines.\r\n\r\n Please go over all the following points, and put an `x` in all the boxes that apply. You may find\r\n it easier to press the 'Create' button first then click on the checkboxes to edit the comment.\r\n-->\r\n\r\n## Type of change:\r\n- [ ] This change is a bug fix (non-breaking change which fixes an issue).\r\n- [ ] This change is a new feature (non-breaking change which adds functionality).\r\n- [x] This change improves the code (refactor or other change that does not change the functionality)\r\n- [ ] This change fixes warnings (the fix does not alter the functionality or the generated code)\r\n- [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).\r\n- [ ] This change alters the query API (existing queries will have to be recompiled)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n  - [x] My code does not create any new warnings from compiler, build system, or lint.\r\n- [x] The commit message is properly formatted and free of typos.\r\n  - [x] The commit message title makes sense in a changelog, by itself.\r\n  - [x] The commit is signed.\r\n- [ ] My change requires a change to the documentation.\r\n  - [ ] I have updated the documentation accordingly, or...\r\n  - [ ] I have created a JIRA ticket to update the documentation.\r\n  - [ ] Any new interfaces or exported functions are appropriately commented.\r\n- [x] I have read the CONTRIBUTORS document.\r\n- [x] The change has been fully tested:\r\n  - [ ] I have added tests to cover my changes.\r\n  - [ ] All new and existing tests passed.\r\n  - [ ] I have checked that this change does not introduce memory leaks.\r\n  - [ ] I have used Valgrind or similar tools to check for potential issues.\r\n- [ ] I have given due consideration to all of the following potential concerns:\r\n  - [ ] Scalability\r\n  - [ ] Performance\r\n  - [ ] Security\r\n  - [ ] Thread-safety\r\n  - [ ] Premature optimization\r\n  - [ ] Existing deployed queries will not be broken\r\n  - [ ] This change fixes the problem, not just the symptom\r\n  - [ ] The target branch of this pull request is appropriate for such a change.\r\n- [ ] There are no similar instances of the same problem that should be addressed\r\n  - [ ] I have addressed them here\r\n  - [ ] I have raised JIRA issues to address them separately\r\n- [ ] This is a user interface / front-end modification\r\n  - [ ] I have tested my changes in multiple modern browsers\r\n  - [ ] The component(s) render as expected\r\n\r\n## Smoketest:\r\n- [ ] Send notifications about my Pull Request position in Smoketest queue.\r\n- [ ] Test my draft Pull Request.\r\n\r\n## Testing:\r\n<!-- Please describe how this change has been tested.-->\r\n\r\n<!-- Thank you for taking the time to submit this pull request and to answer all of the above-->\r\n"},"comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments/567083549","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/13232#issuecomment-567083549","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/13232","id":567083549,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NzA4MzU0OQ==","user":{"login":"ghalliday","id":902490,"node_id":"MDQ6VXNlcjkwMjQ5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/902490?v=4","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"created_at":"2019-12-18T15:35:49Z","updated_at":"2019-12-18T15:35:49Z","author_association":"MEMBER","body":"note, before merging, we should double check that changing the crcs for ECL (not for records) is acceptable."}}
{"actor":{"display_login":"ghalliday"}}