{"action":"closed","number":15972,"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/15972","id":344321374,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ0MzIxMzc0","html_url":"https://github.com/MarlinFirmware/Marlin/pull/15972","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/15972.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/15972.patch","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/15972","number":15972,"state":"closed","locked":false,"title":"Pin reassignment logic to use stallguard on diag pins and homing in positive direction on SKR 1.3","user":{"login":"pfillion42","id":33739777,"node_id":"MDQ6VXNlcjMzNzM5Nzc3","avatar_url":"https://avatars0.githubusercontent.com/u/33739777?v=4","gravatar_id":"","url":"https://api.github.com/users/pfillion42","html_url":"https://github.com/pfillion42","followers_url":"https://api.github.com/users/pfillion42/followers","following_url":"https://api.github.com/users/pfillion42/following{/other_user}","gists_url":"https://api.github.com/users/pfillion42/gists{/gist_id}","starred_url":"https://api.github.com/users/pfillion42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfillion42/subscriptions","organizations_url":"https://api.github.com/users/pfillion42/orgs","repos_url":"https://api.github.com/users/pfillion42/repos","events_url":"https://api.github.com/users/pfillion42/events{/privacy}","received_events_url":"https://api.github.com/users/pfillion42/received_events","type":"User","site_admin":false},"body":"### Requirements\r\nSKR 1.3\r\nStepstick that use stallguard diag pin\r\nsensorless homing with stallguard\r\n(X,Y,Z)_HOME_DIR == 1\r\n\r\n### Description\r\n\r\n\r\nAdded a condition to correctly assign the pins of SKR 1.3 when using sensorless homing in positive direction  with stallguard. In the case that the printer use positive homing direction, marlin use (X,Y,Z)_MAX_PIN to trigger but the stallguard diagnostic pin is physically on (X,Y,Z)_MIN_PIN\r\n\r\n\r\n### Benefits\r\n\r\nThe code automatically validates the need to change the allocation of pins\r\n\r\n### Related Issues\r\n\r\n\r\n","created_at":"2019-11-22T02:30:24Z","updated_at":"2019-11-23T22:20:14Z","closed_at":"2019-11-23T22:20:14Z","merged_at":"2019-11-23T22:20:14Z","merge_commit_sha":"4a5dee6356db96c1e14aa24b5f759cccfd330924","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":195632380,"node_id":"MDU6TGFiZWwxOTU2MzIzODA=","url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/C:%20Hardware/Boards","name":"C: Hardware/Boards","color":"006b75","default":false,"description":""},{"id":848340248,"node_id":"MDU6TGFiZWw4NDgzNDAyNDg=","url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/F:%20Trinamic","name":"F: Trinamic","color":"3cc9c9","default":false,"description":""},{"id":92052497,"node_id":"MDU6TGFiZWw5MjA1MjQ5Nw==","url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20Improvement","name":"PR: Improvement","color":"c2e0c6","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/15972/commits","review_comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/15972/comments","review_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/15972/comments","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/eb179b12c5c40e6b925dd2e2d282db5737c38eb5","head":{"label":"pfillion42:bugfix-2.0.x","ref":"bugfix-2.0.x","sha":"eb179b12c5c40e6b925dd2e2d282db5737c38eb5","user":{"login":"pfillion42","id":33739777,"node_id":"MDQ6VXNlcjMzNzM5Nzc3","avatar_url":"https://avatars0.githubusercontent.com/u/33739777?v=4","gravatar_id":"","url":"https://api.github.com/users/pfillion42","html_url":"https://github.com/pfillion42","followers_url":"https://api.github.com/users/pfillion42/followers","following_url":"https://api.github.com/users/pfillion42/following{/other_user}","gists_url":"https://api.github.com/users/pfillion42/gists{/gist_id}","starred_url":"https://api.github.com/users/pfillion42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfillion42/subscriptions","organizations_url":"https://api.github.com/users/pfillion42/orgs","repos_url":"https://api.github.com/users/pfillion42/repos","events_url":"https://api.github.com/users/pfillion42/events{/privacy}","received_events_url":"https://api.github.com/users/pfillion42/received_events","type":"User","site_admin":false},"repo":{"id":223229750,"node_id":"MDEwOlJlcG9zaXRvcnkyMjMyMjk3NTA=","name":"Marlin","full_name":"pfillion42/Marlin","private":false,"owner":{"login":"pfillion42","id":33739777,"node_id":"MDQ6VXNlcjMzNzM5Nzc3","avatar_url":"https://avatars0.githubusercontent.com/u/33739777?v=4","gravatar_id":"","url":"https://api.github.com/users/pfillion42","html_url":"https://github.com/pfillion42","followers_url":"https://api.github.com/users/pfillion42/followers","following_url":"https://api.github.com/users/pfillion42/following{/other_user}","gists_url":"https://api.github.com/users/pfillion42/gists{/gist_id}","starred_url":"https://api.github.com/users/pfillion42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfillion42/subscriptions","organizations_url":"https://api.github.com/users/pfillion42/orgs","repos_url":"https://api.github.com/users/pfillion42/repos","events_url":"https://api.github.com/users/pfillion42/events{/privacy}","received_events_url":"https://api.github.com/users/pfillion42/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pfillion42/Marlin","description":"Optimized firmware for RepRap 3D printers based on the Arduino platform.","fork":true,"url":"https://api.github.com/repos/pfillion42/Marlin","forks_url":"https://api.github.com/repos/pfillion42/Marlin/forks","keys_url":"https://api.github.com/repos/pfillion42/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfillion42/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfillion42/Marlin/teams","hooks_url":"https://api.github.com/repos/pfillion42/Marlin/hooks","issue_events_url":"https://api.github.com/repos/pfillion42/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/pfillion42/Marlin/events","assignees_url":"https://api.github.com/repos/pfillion42/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/pfillion42/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/pfillion42/Marlin/tags","blobs_url":"https://api.github.com/repos/pfillion42/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfillion42/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfillion42/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfillion42/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfillion42/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/pfillion42/Marlin/languages","stargazers_url":"https://api.github.com/repos/pfillion42/Marlin/stargazers","contributors_url":"https://api.github.com/repos/pfillion42/Marlin/contributors","subscribers_url":"https://api.github.com/repos/pfillion42/Marlin/subscribers","subscription_url":"https://api.github.com/repos/pfillion42/Marlin/subscription","commits_url":"https://api.github.com/repos/pfillion42/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfillion42/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfillion42/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfillion42/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfillion42/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/pfillion42/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfillion42/Marlin/merges","archive_url":"https://api.github.com/repos/pfillion42/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfillion42/Marlin/downloads","issues_url":"https://api.github.com/repos/pfillion42/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/pfillion42/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/pfillion42/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/pfillion42/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfillion42/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/pfillion42/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/pfillion42/Marlin/deployments","created_at":"2019-11-21T17:37:58Z","updated_at":"2019-11-23T22:10:14Z","pushed_at":"2019-11-23T22:10:11Z","git_url":"git://github.com/pfillion42/Marlin.git","ssh_url":"git@github.com:pfillion42/Marlin.git","clone_url":"https://github.com/pfillion42/Marlin.git","svn_url":"https://github.com/pfillion42/Marlin","homepage":"http://www.marlinfw.org/","size":121841,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"bugfix-2.0.x"}},"base":{"label":"MarlinFirmware:bugfix-2.0.x","ref":"bugfix-2.0.x","sha":"b2a275891c5f6f9af0170ae24084ab9dd598651a","user":{"login":"MarlinFirmware","id":10418365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE4MzY1","avatar_url":"https://avatars3.githubusercontent.com/u/10418365?v=4","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"repo":{"id":2200856,"node_id":"MDEwOlJlcG9zaXRvcnkyMjAwODU2","name":"Marlin","full_name":"MarlinFirmware/Marlin","private":false,"owner":{"login":"MarlinFirmware","id":10418365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE4MzY1","avatar_url":"https://avatars3.githubusercontent.com/u/10418365?v=4","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MarlinFirmware/Marlin","description":"Optimized firmware for RepRap 3D printers based on the Arduino platform.","fork":false,"url":"https://api.github.com/repos/MarlinFirmware/Marlin","forks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/forks","keys_url":"https://api.github.com/repos/MarlinFirmware/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarlinFirmware/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarlinFirmware/Marlin/teams","hooks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/hooks","issue_events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/events","assignees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/MarlinFirmware/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/tags","blobs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarlinFirmware/Marlin/languages","stargazers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/stargazers","contributors_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contributors","subscribers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscribers","subscription_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscription","commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/MarlinFirmware/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarlinFirmware/Marlin/merges","archive_url":"https://api.github.com/repos/MarlinFirmware/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarlinFirmware/Marlin/downloads","issues_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarlinFirmware/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarlinFirmware/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/MarlinFirmware/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/deployments","created_at":"2011-08-13T08:07:20Z","updated_at":"2019-11-23T21:07:53Z","pushed_at":"2019-11-23T22:20:14Z","git_url":"git://github.com/MarlinFirmware/Marlin.git","ssh_url":"git@github.com:MarlinFirmware/Marlin.git","clone_url":"https://github.com/MarlinFirmware/Marlin.git","svn_url":"https://github.com/MarlinFirmware/Marlin","homepage":"http://www.marlinfw.org/","size":121891,"stargazers_count":6241,"watchers_count":6241,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8083,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":456,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":8083,"open_issues":456,"watchers":6241,"default_branch":"1.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/15972"},"html":{"href":"https://github.com/MarlinFirmware/Marlin/pull/15972"},"issue":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/15972"},"comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/15972/comments"},"review_comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/15972/comments"},"review_comment":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/15972/commits"},"statuses":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/eb179b12c5c40e6b925dd2e2d282db5737c38eb5"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"thinkyhead","id":698003,"node_id":"MDQ6VXNlcjY5ODAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/698003?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"comments":4,"review_comments":4,"maintainer_can_modify":false,"commits":6,"additions":41,"deletions":10,"changed_files":3}}
{"actor":{"display_login":"thinkyhead"}}