{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/comments/352889560","pull_request_review_id":325782061,"id":352889560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Mjg4OTU2MA==","diff_hunk":"@@ -63,9 +60,25 @@ class multidevice_sync_ft : public ::testing::Test\n     virtual void SetUp()\n     {\n         srand((unsigned int)time(0)); // use current time as seed for random generator\n+        ASSERT_EQ(m_master, nullptr);\n+        ASSERT_EQ(m_subordinate, nullptr);\n     }\n \n-    virtual void TearDown() {}\n+    virtual void TearDown()\n+    {\n+        if (m_master != nullptr)\n+        {\n+            k4a_device_close(m_master);\n+            m_master = nullptr;\n+        }\n+        if (m_subordinate != nullptr)\n+        {\n+            k4a_device_close(m_subordinate);\n+            m_subordinate = nullptr;\n+        }\n+    }\n+    k4a_device_t m_master = nullptr;\n+    k4a_device_t m_subordinate = nullptr;","path":"tests/multidevice/multidevice.cpp","position":33,"original_position":33,"commit_id":"7c840dfe31a263cb1be2b60b572ae184d15e3c3d","original_commit_id":"7353e3ea5f24bfa5ea80ec6de3a17627f4f27df0","user":{"login":"schultetwin1","id":1538370,"node_id":"MDQ6VXNlcjE1MzgzNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1538370?v=4","gravatar_id":"","url":"https://api.github.com/users/schultetwin1","html_url":"https://github.com/schultetwin1","followers_url":"https://api.github.com/users/schultetwin1/followers","following_url":"https://api.github.com/users/schultetwin1/following{/other_user}","gists_url":"https://api.github.com/users/schultetwin1/gists{/gist_id}","starred_url":"https://api.github.com/users/schultetwin1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schultetwin1/subscriptions","organizations_url":"https://api.github.com/users/schultetwin1/orgs","repos_url":"https://api.github.com/users/schultetwin1/repos","events_url":"https://api.github.com/users/schultetwin1/events{/privacy}","received_events_url":"https://api.github.com/users/schultetwin1/received_events","type":"User","site_admin":false},"body":"Wes talked  with me about this, I thought this was still in a function defintion, but it's obviously in a class definition which makes more sense.","created_at":"2019-12-02T22:19:59Z","updated_at":"2019-12-02T22:19:59Z","html_url":"https://github.com/microsoft/Azure-Kinect-Sensor-SDK/pull/929#discussion_r352889560","pull_request_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/929","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/comments/352889560"},"html":{"href":"https://github.com/microsoft/Azure-Kinect-Sensor-SDK/pull/929#discussion_r352889560"},"pull_request":{"href":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/929"}},"in_reply_to_id":350341365},"pull_request":{"url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/929","id":343735210,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzNzM1MjEw","html_url":"https://github.com/microsoft/Azure-Kinect-Sensor-SDK/pull/929","diff_url":"https://github.com/microsoft/Azure-Kinect-Sensor-SDK/pull/929.diff","patch_url":"https://github.com/microsoft/Azure-Kinect-Sensor-SDK/pull/929.patch","issue_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/issues/929","number":929,"state":"open","locked":false,"title":"Updates for FW 1.6.107078014","user":{"login":"wes-b","id":11180453,"node_id":"MDQ6VXNlcjExMTgwNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/11180453?v=4","gravatar_id":"","url":"https://api.github.com/users/wes-b","html_url":"https://github.com/wes-b","followers_url":"https://api.github.com/users/wes-b/followers","following_url":"https://api.github.com/users/wes-b/following{/other_user}","gists_url":"https://api.github.com/users/wes-b/gists{/gist_id}","starred_url":"https://api.github.com/users/wes-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wes-b/subscriptions","organizations_url":"https://api.github.com/users/wes-b/orgs","repos_url":"https://api.github.com/users/wes-b/repos","events_url":"https://api.github.com/users/wes-b/events{/privacy}","received_events_url":"https://api.github.com/users/wes-b/received_events","type":"User","site_admin":false},"body":"### Description of the changes:\r\n- Modifies Color Gain test as default changes\r\n- Makes FW version checking common code common.h\r\n  - depth.c updated to use common code\r\n- Making expected capture timestamp synchronization tolerance to be based on FPS.\r\n  - Updated throughput test and multidevice tests\r\n- Updated multidevice tests to run in looping mode better and tolerant to 1 off errors.\r\n- Fix a bug in capturesync.c where dropped frame count was not zeroed out.\r\n","created_at":"2019-11-20T21:38:05Z","updated_at":"2019-12-02T22:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe90ef90323b004c3297c94139214973a54bb916","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MsDerekMa","id":13106742,"node_id":"MDQ6VXNlcjEzMTA2NzQy","avatar_url":"https://avatars3.githubusercontent.com/u/13106742?v=4","gravatar_id":"","url":"https://api.github.com/users/MsDerekMa","html_url":"https://github.com/MsDerekMa","followers_url":"https://api.github.com/users/MsDerekMa/followers","following_url":"https://api.github.com/users/MsDerekMa/following{/other_user}","gists_url":"https://api.github.com/users/MsDerekMa/gists{/gist_id}","starred_url":"https://api.github.com/users/MsDerekMa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MsDerekMa/subscriptions","organizations_url":"https://api.github.com/users/MsDerekMa/orgs","repos_url":"https://api.github.com/users/MsDerekMa/repos","events_url":"https://api.github.com/users/MsDerekMa/events{/privacy}","received_events_url":"https://api.github.com/users/MsDerekMa/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/929/commits","review_comments_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/929/comments","review_comment_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/issues/929/comments","statuses_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/statuses/7c840dfe31a263cb1be2b60b572ae184d15e3c3d","head":{"label":"wes-b:updates_for_new_firmware","ref":"updates_for_new_firmware","sha":"7c840dfe31a263cb1be2b60b572ae184d15e3c3d","user":{"login":"wes-b","id":11180453,"node_id":"MDQ6VXNlcjExMTgwNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/11180453?v=4","gravatar_id":"","url":"https://api.github.com/users/wes-b","html_url":"https://github.com/wes-b","followers_url":"https://api.github.com/users/wes-b/followers","following_url":"https://api.github.com/users/wes-b/following{/other_user}","gists_url":"https://api.github.com/users/wes-b/gists{/gist_id}","starred_url":"https://api.github.com/users/wes-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wes-b/subscriptions","organizations_url":"https://api.github.com/users/wes-b/orgs","repos_url":"https://api.github.com/users/wes-b/repos","events_url":"https://api.github.com/users/wes-b/events{/privacy}","received_events_url":"https://api.github.com/users/wes-b/received_events","type":"User","site_admin":false},"repo":{"id":186911034,"node_id":"MDEwOlJlcG9zaXRvcnkxODY5MTEwMzQ=","name":"Azure-Kinect-Sensor-SDK-1","full_name":"wes-b/Azure-Kinect-Sensor-SDK-1","private":false,"owner":{"login":"wes-b","id":11180453,"node_id":"MDQ6VXNlcjExMTgwNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/11180453?v=4","gravatar_id":"","url":"https://api.github.com/users/wes-b","html_url":"https://github.com/wes-b","followers_url":"https://api.github.com/users/wes-b/followers","following_url":"https://api.github.com/users/wes-b/following{/other_user}","gists_url":"https://api.github.com/users/wes-b/gists{/gist_id}","starred_url":"https://api.github.com/users/wes-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wes-b/subscriptions","organizations_url":"https://api.github.com/users/wes-b/orgs","repos_url":"https://api.github.com/users/wes-b/repos","events_url":"https://api.github.com/users/wes-b/events{/privacy}","received_events_url":"https://api.github.com/users/wes-b/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wes-b/Azure-Kinect-Sensor-SDK-1","description":"A cross platform (Linux and Windows) user mode SDK to read data from your Azure Kinect device.","fork":true,"url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1","forks_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/forks","keys_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/teams","hooks_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/hooks","issue_events_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/issues/events{/number}","events_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/events","assignees_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/assignees{/user}","branches_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/branches{/branch}","tags_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/tags","blobs_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/statuses/{sha}","languages_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/languages","stargazers_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/stargazers","contributors_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/contributors","subscribers_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/subscribers","subscription_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/subscription","commits_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/contents/{+path}","compare_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/merges","archive_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/downloads","issues_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/issues{/number}","pulls_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/pulls{/number}","milestones_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/milestones{/number}","notifications_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/labels{/name}","releases_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/releases{/id}","deployments_url":"https://api.github.com/repos/wes-b/Azure-Kinect-Sensor-SDK-1/deployments","created_at":"2019-05-15T22:26:28Z","updated_at":"2019-05-15T22:38:18Z","pushed_at":"2019-12-02T21:28:28Z","git_url":"git://github.com/wes-b/Azure-Kinect-Sensor-SDK-1.git","ssh_url":"git@github.com:wes-b/Azure-Kinect-Sensor-SDK-1.git","clone_url":"https://github.com/wes-b/Azure-Kinect-Sensor-SDK-1.git","svn_url":"https://github.com/wes-b/Azure-Kinect-Sensor-SDK-1","homepage":" https://Azure.com/Kinect","size":2480,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"microsoft:develop","ref":"develop","sha":"90f77529f5ad19efd1e8f155a240c329e3bcbbdf","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":161214378,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEyMTQzNzg=","name":"Azure-Kinect-Sensor-SDK","full_name":"microsoft/Azure-Kinect-Sensor-SDK","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/Azure-Kinect-Sensor-SDK","description":"A cross platform (Linux and Windows) user mode SDK to read data from your Azure Kinect device.","fork":false,"url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK","forks_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/forks","keys_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/teams","hooks_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/hooks","issue_events_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/events","assignees_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/tags","blobs_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/languages","stargazers_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/stargazers","contributors_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/contributors","subscribers_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/subscribers","subscription_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/subscription","commits_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/merges","archive_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/downloads","issues_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/deployments","created_at":"2018-12-10T17:50:05Z","updated_at":"2019-12-02T09:23:20Z","pushed_at":"2019-12-02T21:28:30Z","git_url":"git://github.com/microsoft/Azure-Kinect-Sensor-SDK.git","ssh_url":"git@github.com:microsoft/Azure-Kinect-Sensor-SDK.git","clone_url":"https://github.com/microsoft/Azure-Kinect-Sensor-SDK.git","svn_url":"https://github.com/microsoft/Azure-Kinect-Sensor-SDK","homepage":" https://Azure.com/Kinect","size":8046,"stargazers_count":473,"watchers_count":473,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":157,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":157,"open_issues":104,"watchers":473,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/929"},"html":{"href":"https://github.com/microsoft/Azure-Kinect-Sensor-SDK/pull/929"},"issue":{"href":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/issues/929"},"comments":{"href":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/issues/929/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/929/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/pulls/929/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/Azure-Kinect-Sensor-SDK/statuses/7c840dfe31a263cb1be2b60b572ae184d15e3c3d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"schultetwin1"}}