{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/255379389","pull_request_review_id":201949118,"id":255379389,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTM3OTM4OQ==","diff_hunk":"@@ -229,7 +231,8 @@ object Dependencies {\n \n   val playDocVersion = \"2.0.0\"\n   val playDocsDependencies = Seq(\n-    \"com.typesafe.play\" %% \"play-doc\" % playDocVersion\n+    \"com.typesafe.play\" %% \"play-doc\" % playDocVersion,\n+    \"org.scala-sbt\" % \"compiler-bridge_2.12\" % Dependencies.compilerBridgeVersion % Configurations.ScalaTool","path":"framework/project/Dependencies.scala","position":15,"original_position":15,"commit_id":"26c0de0c498865ab290d14a4dc81b4fe3293b9c7","original_commit_id":"26c0de0c498865ab290d14a4dc81b4fe3293b9c7","user":{"login":"gaurang-sawhney","id":25279512,"node_id":"MDQ6VXNlcjI1Mjc5NTEy","avatar_url":"https://avatars0.githubusercontent.com/u/25279512?v=4","gravatar_id":"","url":"https://api.github.com/users/gaurang-sawhney","html_url":"https://github.com/gaurang-sawhney","followers_url":"https://api.github.com/users/gaurang-sawhney/followers","following_url":"https://api.github.com/users/gaurang-sawhney/following{/other_user}","gists_url":"https://api.github.com/users/gaurang-sawhney/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurang-sawhney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurang-sawhney/subscriptions","organizations_url":"https://api.github.com/users/gaurang-sawhney/orgs","repos_url":"https://api.github.com/users/gaurang-sawhney/repos","events_url":"https://api.github.com/users/gaurang-sawhney/events{/privacy}","received_events_url":"https://api.github.com/users/gaurang-sawhney/received_events","type":"User","site_admin":false},"body":"While generating the docs using `Docs.scala`, we try to get the instance of Analyzing compiler where it internally calls out `xsbt.ScaladocInterface` which resides in `compiler-bridge.`\r\nIdeally `compiler-bridge` should be fetched using `scalaCompilerBridgeBinaryJar` task provided by `sbt`, however this is returning `None`. So just for experiment, I tried to add `compiler-bridge` explicitly but it doesn't help either.","created_at":"2019-02-11T04:26:15Z","updated_at":"2019-02-11T04:26:16Z","html_url":"https://github.com/playframework/playframework/pull/9001#discussion_r255379389","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/9001","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/255379389"},"html":{"href":"https://github.com/playframework/playframework/pull/9001#discussion_r255379389"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/9001"}},"in_reply_to_id":253963952},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/9001","id":248809907,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ4ODA5OTA3","html_url":"https://github.com/playframework/playframework/pull/9001","diff_url":"https://github.com/playframework/playframework/pull/9001.diff","patch_url":"https://github.com/playframework/playframework/pull/9001.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/9001","number":9001,"state":"open","locked":false,"title":"Sbt 0.13 to sbt 1.2","user":{"login":"gaurang-sawhney","id":25279512,"node_id":"MDQ6VXNlcjI1Mjc5NTEy","avatar_url":"https://avatars0.githubusercontent.com/u/25279512?v=4","gravatar_id":"","url":"https://api.github.com/users/gaurang-sawhney","html_url":"https://github.com/gaurang-sawhney","followers_url":"https://api.github.com/users/gaurang-sawhney/followers","following_url":"https://api.github.com/users/gaurang-sawhney/following{/other_user}","gists_url":"https://api.github.com/users/gaurang-sawhney/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurang-sawhney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurang-sawhney/subscriptions","organizations_url":"https://api.github.com/users/gaurang-sawhney/orgs","repos_url":"https://api.github.com/users/gaurang-sawhney/repos","events_url":"https://api.github.com/users/gaurang-sawhney/events{/privacy}","received_events_url":"https://api.github.com/users/gaurang-sawhney/received_events","type":"User","site_admin":false},"body":"# Pull Request Checklist\r\n\r\n* [x] Have you read [How to write the perfect pull request](https://github.com/blog/1943-how-to-write-the-perfect-pull-request)?\r\n* [x] Have you read through the [contributor guidelines](https://www.playframework.com/contributing)?\r\n* [x] Have you signed the [Lightbend CLA](https://www.lightbend.com/contribute/cla)?\r\n* [x] Have you referenced any issues you're fixing using [commit message keywords](https://help.github.com/articles/closing-issues-using-keywords/)?\r\n* [ ] Have you added copyright headers to new files?\r\n* [ ] Have you checked that both Scala and Java APIs are updated?\r\n* [ ] Have you updated the documentation for both Scala and Java sections?\r\n* [ ] Have you added tests for any changed functionality?\r\n\r\n# Helpful things\r\n\r\n## Fixes\r\n\r\nFixes #8383 \r\n\r\n## Purpose\r\n\r\nUpdated the sbt version to `1.2.8`.\r\n\r\n## Background Context\r\n\r\n[Link to discussion](https://github.com/playframework/playframework/issues/8383#issuecomment-458431728)\r\n\r\n## References\r\n\r\nAre there any relevant issues / PRs / mailing lists discussions?\r\n","created_at":"2019-01-30T09:51:56Z","updated_at":"2019-02-11T04:26:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e10a81dcf38dc0a51e5268b53d287a823a5f4ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/9001/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/9001/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/9001/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/26c0de0c498865ab290d14a4dc81b4fe3293b9c7","head":{"label":"gaurang-sawhney:sbt-0.13-to-sbt-1.2","ref":"sbt-0.13-to-sbt-1.2","sha":"26c0de0c498865ab290d14a4dc81b4fe3293b9c7","user":{"login":"gaurang-sawhney","id":25279512,"node_id":"MDQ6VXNlcjI1Mjc5NTEy","avatar_url":"https://avatars0.githubusercontent.com/u/25279512?v=4","gravatar_id":"","url":"https://api.github.com/users/gaurang-sawhney","html_url":"https://github.com/gaurang-sawhney","followers_url":"https://api.github.com/users/gaurang-sawhney/followers","following_url":"https://api.github.com/users/gaurang-sawhney/following{/other_user}","gists_url":"https://api.github.com/users/gaurang-sawhney/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurang-sawhney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurang-sawhney/subscriptions","organizations_url":"https://api.github.com/users/gaurang-sawhney/orgs","repos_url":"https://api.github.com/users/gaurang-sawhney/repos","events_url":"https://api.github.com/users/gaurang-sawhney/events{/privacy}","received_events_url":"https://api.github.com/users/gaurang-sawhney/received_events","type":"User","site_admin":false},"repo":{"id":168312030,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgzMTIwMzA=","name":"playframework","full_name":"gaurang-sawhney/playframework","private":false,"owner":{"login":"gaurang-sawhney","id":25279512,"node_id":"MDQ6VXNlcjI1Mjc5NTEy","avatar_url":"https://avatars0.githubusercontent.com/u/25279512?v=4","gravatar_id":"","url":"https://api.github.com/users/gaurang-sawhney","html_url":"https://github.com/gaurang-sawhney","followers_url":"https://api.github.com/users/gaurang-sawhney/followers","following_url":"https://api.github.com/users/gaurang-sawhney/following{/other_user}","gists_url":"https://api.github.com/users/gaurang-sawhney/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurang-sawhney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurang-sawhney/subscriptions","organizations_url":"https://api.github.com/users/gaurang-sawhney/orgs","repos_url":"https://api.github.com/users/gaurang-sawhney/repos","events_url":"https://api.github.com/users/gaurang-sawhney/events{/privacy}","received_events_url":"https://api.github.com/users/gaurang-sawhney/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gaurang-sawhney/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/gaurang-sawhney/playframework","forks_url":"https://api.github.com/repos/gaurang-sawhney/playframework/forks","keys_url":"https://api.github.com/repos/gaurang-sawhney/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaurang-sawhney/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaurang-sawhney/playframework/teams","hooks_url":"https://api.github.com/repos/gaurang-sawhney/playframework/hooks","issue_events_url":"https://api.github.com/repos/gaurang-sawhney/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/gaurang-sawhney/playframework/events","assignees_url":"https://api.github.com/repos/gaurang-sawhney/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/gaurang-sawhney/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/gaurang-sawhney/playframework/tags","blobs_url":"https://api.github.com/repos/gaurang-sawhney/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaurang-sawhney/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaurang-sawhney/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaurang-sawhney/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaurang-sawhney/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/gaurang-sawhney/playframework/languages","stargazers_url":"https://api.github.com/repos/gaurang-sawhney/playframework/stargazers","contributors_url":"https://api.github.com/repos/gaurang-sawhney/playframework/contributors","subscribers_url":"https://api.github.com/repos/gaurang-sawhney/playframework/subscribers","subscription_url":"https://api.github.com/repos/gaurang-sawhney/playframework/subscription","commits_url":"https://api.github.com/repos/gaurang-sawhney/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaurang-sawhney/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaurang-sawhney/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaurang-sawhney/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaurang-sawhney/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/gaurang-sawhney/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaurang-sawhney/playframework/merges","archive_url":"https://api.github.com/repos/gaurang-sawhney/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaurang-sawhney/playframework/downloads","issues_url":"https://api.github.com/repos/gaurang-sawhney/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/gaurang-sawhney/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/gaurang-sawhney/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/gaurang-sawhney/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaurang-sawhney/playframework/labels{/name}","releases_url":"https://api.github.com/repos/gaurang-sawhney/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/gaurang-sawhney/playframework/deployments","created_at":"2019-01-30T09:04:56Z","updated_at":"2019-01-30T09:05:03Z","pushed_at":"2019-02-05T10:15:19Z","git_url":"git://github.com/gaurang-sawhney/playframework.git","ssh_url":"git@github.com:gaurang-sawhney/playframework.git","clone_url":"https://github.com/gaurang-sawhney/playframework.git","svn_url":"https://github.com/gaurang-sawhney/playframework","homepage":"http://www.playframework.com/","size":92691,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"b2143b6c7d253d4aa0a9f71ab7c98e4a039137b9","user":{"login":"playframework","id":319107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTEwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/319107?v=4","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"node_id":"MDEwOlJlcG9zaXRvcnkyMzQwNTQ5","name":"playframework","full_name":"playframework/playframework","private":false,"owner":{"login":"playframework","id":319107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTEwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/319107?v=4","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2019-02-10T18:25:31Z","pushed_at":"2019-02-10T08:51:00Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":92724,"stargazers_count":10950,"watchers_count":10950,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3700,"mirror_url":null,"archived":false,"open_issues_count":403,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3700,"open_issues":403,"watchers":10950,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/9001"},"html":{"href":"https://github.com/playframework/playframework/pull/9001"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/9001"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/9001/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/9001/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/9001/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/26c0de0c498865ab290d14a4dc81b4fe3293b9c7"}},"author_association":"NONE"}}
{"actor":{"display_login":"gaurang-sawhney"}}