{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/eksctl/issues/1406","repository_url":"https://api.github.com/repos/weaveworks/eksctl","labels_url":"https://api.github.com/repos/weaveworks/eksctl/issues/1406/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/eksctl/issues/1406/comments","events_url":"https://api.github.com/repos/weaveworks/eksctl/issues/1406/events","html_url":"https://github.com/weaveworks/eksctl/pull/1406","id":502955293,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0OTM0Mjc4","number":1406,"title":"eksctl does not report error if it can not write kubeconfig file","user":{"login":"sayboras","id":9019229,"node_id":"MDQ6VXNlcjkwMTkyMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/9019229?v=4","gravatar_id":"","url":"https://api.github.com/users/sayboras","html_url":"https://github.com/sayboras","followers_url":"https://api.github.com/users/sayboras/followers","following_url":"https://api.github.com/users/sayboras/following{/other_user}","gists_url":"https://api.github.com/users/sayboras/gists{/gist_id}","starred_url":"https://api.github.com/users/sayboras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayboras/subscriptions","organizations_url":"https://api.github.com/users/sayboras/orgs","repos_url":"https://api.github.com/users/sayboras/repos","events_url":"https://api.github.com/users/sayboras/events{/privacy}","received_events_url":"https://api.github.com/users/sayboras/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2019-10-05T12:08:27Z","updated_at":"2019-10-10T11:01:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/weaveworks/eksctl/pulls/1406","html_url":"https://github.com/weaveworks/eksctl/pull/1406","diff_url":"https://github.com/weaveworks/eksctl/pull/1406.diff","patch_url":"https://github.com/weaveworks/eksctl/pull/1406.patch"},"body":"### Description\r\nFixed issue mentioned in https://github.com/weaveworks/eksctl/issues/1402\r\n\r\n### Checklist\r\n<!-- Delete any items if not applicable, e.g. if your name is already in `humans.txt` or doc updates are not needed. -->\r\n- [x] Code compiles correctly (i.e `make build`)\r\n- [x] Added tests that cover your change (if possible)\r\n- [x] All unit tests passing (i.e. `make test`)\r\n- [ ] Added/modified documentation as required (such as the `README.md`, and `examples` directory)\r\n- [x] Manually tested\r\n\r\n<!-- If you haven't done so already, you can add your name to the humans.txt file -->\r\n"},"comment":{"url":"https://api.github.com/repos/weaveworks/eksctl/issues/comments/540517731","html_url":"https://github.com/weaveworks/eksctl/pull/1406#issuecomment-540517731","issue_url":"https://api.github.com/repos/weaveworks/eksctl/issues/1406","id":540517731,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MDUxNzczMQ==","user":{"login":"cPu1","id":6298307,"node_id":"MDQ6VXNlcjYyOTgzMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6298307?v=4","gravatar_id":"","url":"https://api.github.com/users/cPu1","html_url":"https://github.com/cPu1","followers_url":"https://api.github.com/users/cPu1/followers","following_url":"https://api.github.com/users/cPu1/following{/other_user}","gists_url":"https://api.github.com/users/cPu1/gists{/gist_id}","starred_url":"https://api.github.com/users/cPu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cPu1/subscriptions","organizations_url":"https://api.github.com/users/cPu1/orgs","repos_url":"https://api.github.com/users/cPu1/repos","events_url":"https://api.github.com/users/cPu1/events{/privacy}","received_events_url":"https://api.github.com/users/cPu1/received_events","type":"User","site_admin":false},"created_at":"2019-10-10T11:01:07Z","updated_at":"2019-10-10T11:01:07Z","author_association":"CONTRIBUTOR","body":"Hi @sayboras, I looked into this and this would also affect `create cluster`.\r\nAny failure to write to the filesystem would prevent the worker nodes from joining the cluster, as the instance roles are added to `aws-auth` after writing the kubeconfig file.\r\n\r\nI'd suggest handling the error this way:\r\n* For `create cluster`, log the error but continue processing the command\r\n* For `utils write-kubeconfig`, propagate the error so the command halts and the error is logged"}}
{"actor":{"display_login":"cPu1"}}