{"action":"created","comment":{"url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/comments/316312670","pull_request_review_id":277956007,"id":316312670,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjMxMjY3MA==","diff_hunk":"@@ -184,7 +184,7 @@ export function* getUsersAndContacts({ domain, token }) {\n     if (res) {\n       const response = res.payload;\n       const jsonData = yield call(() => new Promise((resolve) => {\n-        resolve(response.json());\n+        resolve(response.clone().json());","path":"store/sagas/groups.sagas.js","position":259,"original_position":32,"commit_id":"2372cedfabd97a640ba4400c02505126f4af0c0c","original_commit_id":"f29a3e566af528bea9442e551ba392aa8ff99e4c","user":{"login":"zdmc23","id":191707,"node_id":"MDQ6VXNlcjE5MTcwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/191707?v=4","gravatar_id":"","url":"https://api.github.com/users/zdmc23","html_url":"https://github.com/zdmc23","followers_url":"https://api.github.com/users/zdmc23/followers","following_url":"https://api.github.com/users/zdmc23/following{/other_user}","gists_url":"https://api.github.com/users/zdmc23/gists{/gist_id}","starred_url":"https://api.github.com/users/zdmc23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdmc23/subscriptions","organizations_url":"https://api.github.com/users/zdmc23/orgs","repos_url":"https://api.github.com/users/zdmc23/repos","events_url":"https://api.github.com/users/zdmc23/events{/privacy}","received_events_url":"https://api.github.com/users/zdmc23/received_events","type":"User","site_admin":false},"body":"The call to .json() is already returning a Promise, so there should be no need to resolve it and wrap it in a new Promise.  Instead this is possible, Line #28 should be:\r\n\r\nconst jsonData = yield response.json();\r\n\r\nThis will yield the Promise returned by the .json() invocation","created_at":"2019-08-21T17:39:46Z","updated_at":"2019-08-21T17:41:42Z","html_url":"https://github.com/DiscipleTools/disciple-tools-mobile-app/pull/24#discussion_r316312670","pull_request_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/24","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/comments/316312670"},"html":{"href":"https://github.com/DiscipleTools/disciple-tools-mobile-app/pull/24#discussion_r316312670"},"pull_request":{"href":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/24","id":309255999,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5MjU1OTk5","html_url":"https://github.com/DiscipleTools/disciple-tools-mobile-app/pull/24","diff_url":"https://github.com/DiscipleTools/disciple-tools-mobile-app/pull/24.diff","patch_url":"https://github.com/DiscipleTools/disciple-tools-mobile-app/pull/24.patch","issue_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/issues/24","number":24,"state":"open","locked":false,"title":"Merge with Sprint-4, Sprint-5 with development","user":{"login":"raschdiaz","id":16809967,"node_id":"MDQ6VXNlcjE2ODA5OTY3","avatar_url":"https://avatars1.githubusercontent.com/u/16809967?v=4","gravatar_id":"","url":"https://api.github.com/users/raschdiaz","html_url":"https://github.com/raschdiaz","followers_url":"https://api.github.com/users/raschdiaz/followers","following_url":"https://api.github.com/users/raschdiaz/following{/other_user}","gists_url":"https://api.github.com/users/raschdiaz/gists{/gist_id}","starred_url":"https://api.github.com/users/raschdiaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raschdiaz/subscriptions","organizations_url":"https://api.github.com/users/raschdiaz/orgs","repos_url":"https://api.github.com/users/raschdiaz/repos","events_url":"https://api.github.com/users/raschdiaz/events{/privacy}","received_events_url":"https://api.github.com/users/raschdiaz/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-20T22:32:40Z","updated_at":"2019-08-21T17:41:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f41d4887d34cf117f4f06dcf705d7d974b31b6c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/24/commits","review_comments_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/24/comments","review_comment_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/issues/24/comments","statuses_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/statuses/2372cedfabd97a640ba4400c02505126f4af0c0c","head":{"label":"raschdiaz:sprint-6","ref":"sprint-6","sha":"2372cedfabd97a640ba4400c02505126f4af0c0c","user":{"login":"raschdiaz","id":16809967,"node_id":"MDQ6VXNlcjE2ODA5OTY3","avatar_url":"https://avatars1.githubusercontent.com/u/16809967?v=4","gravatar_id":"","url":"https://api.github.com/users/raschdiaz","html_url":"https://github.com/raschdiaz","followers_url":"https://api.github.com/users/raschdiaz/followers","following_url":"https://api.github.com/users/raschdiaz/following{/other_user}","gists_url":"https://api.github.com/users/raschdiaz/gists{/gist_id}","starred_url":"https://api.github.com/users/raschdiaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raschdiaz/subscriptions","organizations_url":"https://api.github.com/users/raschdiaz/orgs","repos_url":"https://api.github.com/users/raschdiaz/repos","events_url":"https://api.github.com/users/raschdiaz/events{/privacy}","received_events_url":"https://api.github.com/users/raschdiaz/received_events","type":"User","site_admin":false},"repo":{"id":191776356,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE3NzYzNTY=","name":"disciple-tools-mobile-app","full_name":"raschdiaz/disciple-tools-mobile-app","private":false,"owner":{"login":"raschdiaz","id":16809967,"node_id":"MDQ6VXNlcjE2ODA5OTY3","avatar_url":"https://avatars1.githubusercontent.com/u/16809967?v=4","gravatar_id":"","url":"https://api.github.com/users/raschdiaz","html_url":"https://github.com/raschdiaz","followers_url":"https://api.github.com/users/raschdiaz/followers","following_url":"https://api.github.com/users/raschdiaz/following{/other_user}","gists_url":"https://api.github.com/users/raschdiaz/gists{/gist_id}","starred_url":"https://api.github.com/users/raschdiaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raschdiaz/subscriptions","organizations_url":"https://api.github.com/users/raschdiaz/orgs","repos_url":"https://api.github.com/users/raschdiaz/repos","events_url":"https://api.github.com/users/raschdiaz/events{/privacy}","received_events_url":"https://api.github.com/users/raschdiaz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/raschdiaz/disciple-tools-mobile-app","description":"The code base for the Android IOS for the Disciple Tools mobile app.","fork":true,"url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app","forks_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/forks","keys_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/teams","hooks_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/hooks","issue_events_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/issues/events{/number}","events_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/events","assignees_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/assignees{/user}","branches_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/branches{/branch}","tags_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/tags","blobs_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/statuses/{sha}","languages_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/languages","stargazers_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/stargazers","contributors_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/contributors","subscribers_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/subscribers","subscription_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/subscription","commits_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/contents/{+path}","compare_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/merges","archive_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/downloads","issues_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/issues{/number}","pulls_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/pulls{/number}","milestones_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/milestones{/number}","notifications_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/labels{/name}","releases_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/releases{/id}","deployments_url":"https://api.github.com/repos/raschdiaz/disciple-tools-mobile-app/deployments","created_at":"2019-06-13T14:15:21Z","updated_at":"2019-07-22T13:20:14Z","pushed_at":"2019-08-20T22:30:54Z","git_url":"git://github.com/raschdiaz/disciple-tools-mobile-app.git","ssh_url":"git@github.com:raschdiaz/disciple-tools-mobile-app.git","clone_url":"https://github.com/raschdiaz/disciple-tools-mobile-app.git","svn_url":"https://github.com/raschdiaz/disciple-tools-mobile-app","homepage":null,"size":8885,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DiscipleTools:development","ref":"development","sha":"e170f38af0b59bb560c090fef9ee03b4e4f93eb5","user":{"login":"DiscipleTools","id":31960909,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTYwOTA5","avatar_url":"https://avatars2.githubusercontent.com/u/31960909?v=4","gravatar_id":"","url":"https://api.github.com/users/DiscipleTools","html_url":"https://github.com/DiscipleTools","followers_url":"https://api.github.com/users/DiscipleTools/followers","following_url":"https://api.github.com/users/DiscipleTools/following{/other_user}","gists_url":"https://api.github.com/users/DiscipleTools/gists{/gist_id}","starred_url":"https://api.github.com/users/DiscipleTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DiscipleTools/subscriptions","organizations_url":"https://api.github.com/users/DiscipleTools/orgs","repos_url":"https://api.github.com/users/DiscipleTools/repos","events_url":"https://api.github.com/users/DiscipleTools/events{/privacy}","received_events_url":"https://api.github.com/users/DiscipleTools/received_events","type":"Organization","site_admin":false},"repo":{"id":164704981,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ3MDQ5ODE=","name":"disciple-tools-mobile-app","full_name":"DiscipleTools/disciple-tools-mobile-app","private":false,"owner":{"login":"DiscipleTools","id":31960909,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTYwOTA5","avatar_url":"https://avatars2.githubusercontent.com/u/31960909?v=4","gravatar_id":"","url":"https://api.github.com/users/DiscipleTools","html_url":"https://github.com/DiscipleTools","followers_url":"https://api.github.com/users/DiscipleTools/followers","following_url":"https://api.github.com/users/DiscipleTools/following{/other_user}","gists_url":"https://api.github.com/users/DiscipleTools/gists{/gist_id}","starred_url":"https://api.github.com/users/DiscipleTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DiscipleTools/subscriptions","organizations_url":"https://api.github.com/users/DiscipleTools/orgs","repos_url":"https://api.github.com/users/DiscipleTools/repos","events_url":"https://api.github.com/users/DiscipleTools/events{/privacy}","received_events_url":"https://api.github.com/users/DiscipleTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DiscipleTools/disciple-tools-mobile-app","description":"The code base for the Android IOS for the Disciple Tools mobile app.","fork":false,"url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app","forks_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/forks","keys_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/teams","hooks_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/hooks","issue_events_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/issues/events{/number}","events_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/events","assignees_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/assignees{/user}","branches_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/branches{/branch}","tags_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/tags","blobs_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/statuses/{sha}","languages_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/languages","stargazers_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/stargazers","contributors_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/contributors","subscribers_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/subscribers","subscription_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/subscription","commits_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/contents/{+path}","compare_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/merges","archive_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/downloads","issues_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/issues{/number}","pulls_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls{/number}","milestones_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/milestones{/number}","notifications_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/labels{/name}","releases_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/releases{/id}","deployments_url":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/deployments","created_at":"2019-01-08T18:00:40Z","updated_at":"2019-07-02T14:10:42Z","pushed_at":"2019-08-20T22:32:41Z","git_url":"git://github.com/DiscipleTools/disciple-tools-mobile-app.git","ssh_url":"git@github.com:DiscipleTools/disciple-tools-mobile-app.git","clone_url":"https://github.com/DiscipleTools/disciple-tools-mobile-app.git","svn_url":"https://github.com/DiscipleTools/disciple-tools-mobile-app","homepage":null,"size":5518,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":12,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/24"},"html":{"href":"https://github.com/DiscipleTools/disciple-tools-mobile-app/pull/24"},"issue":{"href":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/issues/24"},"comments":{"href":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/DiscipleTools/disciple-tools-mobile-app/statuses/2372cedfabd97a640ba4400c02505126f4af0c0c"}},"author_association":"NONE"}}
{"actor":{"display_login":"zdmc23"}}