{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/24030","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/24030/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/24030/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/24030/events","html_url":"https://github.com/magento/magento2/pull/24030","id":477306242,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0NjU2NDc5","number":24030,"title":"24025 add caching for magento product version","user":{"login":"davidverholen","id":2813693,"node_id":"MDQ6VXNlcjI4MTM2OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2813693?v=4","gravatar_id":"","url":"https://api.github.com/users/davidverholen","html_url":"https://github.com/davidverholen","followers_url":"https://api.github.com/users/davidverholen/followers","following_url":"https://api.github.com/users/davidverholen/following{/other_user}","gists_url":"https://api.github.com/users/davidverholen/gists{/gist_id}","starred_url":"https://api.github.com/users/davidverholen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidverholen/subscriptions","organizations_url":"https://api.github.com/users/davidverholen/orgs","repos_url":"https://api.github.com/users/davidverholen/repos","events_url":"https://api.github.com/users/davidverholen/events{/privacy}","received_events_url":"https://api.github.com/users/davidverholen/received_events","type":"User","site_admin":false},"labels":[{"id":1259501610,"node_id":"MDU6TGFiZWwxMjU5NTAxNjEw","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20App","name":"Component: App","color":"7fb703","default":false},{"id":1306854409,"node_id":"MDU6TGFiZWwxMzA2ODU0NDA5","url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Brandung","name":"Partner: Brandung","color":"f9d0c4","default":false},{"id":161563561,"node_id":"MDU6TGFiZWwxNjE1NjM1NjE=","url":"https://api.github.com/repos/magento/magento2/labels/Progress:%20needs%20update","name":"Progress: needs update","color":"b60205","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false},{"id":882948356,"node_id":"MDU6TGFiZWw4ODI5NDgzNTY=","url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"torhoehn","id":1945725,"node_id":"MDQ6VXNlcjE5NDU3MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1945725?v=4","gravatar_id":"","url":"https://api.github.com/users/torhoehn","html_url":"https://github.com/torhoehn","followers_url":"https://api.github.com/users/torhoehn/followers","following_url":"https://api.github.com/users/torhoehn/following{/other_user}","gists_url":"https://api.github.com/users/torhoehn/gists{/gist_id}","starred_url":"https://api.github.com/users/torhoehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torhoehn/subscriptions","organizations_url":"https://api.github.com/users/torhoehn/orgs","repos_url":"https://api.github.com/users/torhoehn/repos","events_url":"https://api.github.com/users/torhoehn/events{/privacy}","received_events_url":"https://api.github.com/users/torhoehn/received_events","type":"User","site_admin":false},"assignees":[{"login":"torhoehn","id":1945725,"node_id":"MDQ6VXNlcjE5NDU3MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1945725?v=4","gravatar_id":"","url":"https://api.github.com/users/torhoehn","html_url":"https://github.com/torhoehn","followers_url":"https://api.github.com/users/torhoehn/followers","following_url":"https://api.github.com/users/torhoehn/following{/other_user}","gists_url":"https://api.github.com/users/torhoehn/gists{/gist_id}","starred_url":"https://api.github.com/users/torhoehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torhoehn/subscriptions","organizations_url":"https://api.github.com/users/torhoehn/orgs","repos_url":"https://api.github.com/users/torhoehn/repos","events_url":"https://api.github.com/users/torhoehn/events{/privacy}","received_events_url":"https://api.github.com/users/torhoehn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2019-08-06T10:44:32Z","updated_at":"2019-08-07T14:36:15Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/24030","html_url":"https://github.com/magento/magento2/pull/24030","diff_url":"https://github.com/magento/magento2/pull/24030.diff","patch_url":"https://github.com/magento/magento2/pull/24030.patch"},"body":"fixes https://github.com/magento/magento2/issues/24025\r\n\r\n<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this pull request we recommend that you add the following information:\r\n     - Summary of the pull request,\r\n     - Issue(s) related to the changes made,\r\n     - Manual testing scenarios\r\n    Fields marked with (*) are required. Please don't remove the template.\r\n-->\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description (*)\r\n<!---\r\n    Please provide a description of the changes proposed in the pull request.\r\n    Letting us know what has changed and why it needed changing will help us validate this pull request.\r\n-->\r\nadd caching for product version, to not utilize composer runtime on every request to the magento product version.\r\n\r\nWhile this method is called rarely in the core, many 3rd party extensions rely on it to determine the magento version. This leads to many \"real\" projects having >100ms added to non cached requests\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\n1. https://github.com/magento/magento2/issues/24025\r\n\r\n### Manual testing scenarios (*)\r\n<!---\r\n    Please provide a set of unambiguous steps to test the proposed code change.\r\n    Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1. have a module installed that relies on the product version to determine e.g. feature compatibility\r\n2. profile uncached requests\r\n\r\n### Questions or comments\r\n<!---\r\n\tIf relevant, here you can ask questions or provide comments on your pull request for the reviewer\r\n\tFor example if you need assistance with writing tests or would like some feedback on one of your development ideas\r\n-->\r\n\r\n### Contribution checklist (*)\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/519125619","html_url":"https://github.com/magento/magento2/pull/24030#issuecomment-519125619","issue_url":"https://api.github.com/repos/magento/magento2/issues/24030","id":519125619,"node_id":"MDEyOklzc3VlQ29tbWVudDUxOTEyNTYxOQ==","user":{"login":"torhoehn","id":1945725,"node_id":"MDQ6VXNlcjE5NDU3MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1945725?v=4","gravatar_id":"","url":"https://api.github.com/users/torhoehn","html_url":"https://github.com/torhoehn","followers_url":"https://api.github.com/users/torhoehn/followers","following_url":"https://api.github.com/users/torhoehn/following{/other_user}","gists_url":"https://api.github.com/users/torhoehn/gists{/gist_id}","starred_url":"https://api.github.com/users/torhoehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torhoehn/subscriptions","organizations_url":"https://api.github.com/users/torhoehn/orgs","repos_url":"https://api.github.com/users/torhoehn/repos","events_url":"https://api.github.com/users/torhoehn/events{/privacy}","received_events_url":"https://api.github.com/users/torhoehn/received_events","type":"User","site_admin":false},"created_at":"2019-08-07T14:36:15Z","updated_at":"2019-08-07T14:36:15Z","author_association":"CONTRIBUTOR","body":"@davidverholen It's just a problem with the infrastructure. Seems okay for me. :)"}}
{"actor":{"display_login":"torhoehn"}}