{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/18289","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/18289/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/18289/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/18289/events","html_url":"https://github.com/grpc/grpc/pull/18289","id":418171081,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5MDA1NDQ5","number":18289,"title":"C++ callback API: properly handle and test unimplemented RPC method","user":{"login":"vjpai","id":8864912,"node_id":"MDQ6VXNlcjg4NjQ5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8864912?v=4","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"labels":[{"id":166332908,"node_id":"MDU6TGFiZWwxNjYzMzI5MDg=","url":"https://api.github.com/repos/grpc/grpc/labels/lang/c++","name":"lang/c++","color":"fad8c7","default":false},{"id":168275588,"node_id":"MDU6TGFiZWwxNjgyNzU1ODg=","url":"https://api.github.com/repos/grpc/grpc/labels/priority/P1","name":"priority/P1","color":"ff0000","default":false},{"id":961832073,"node_id":"MDU6TGFiZWw5NjE4MzIwNzM=","url":"https://api.github.com/repos/grpc/grpc/labels/release%20notes:%20no","name":"release notes: no","color":"0f5f75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-03-07T07:45:50Z","updated_at":"2019-03-07T13:43:14Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/18289","html_url":"https://github.com/grpc/grpc/pull/18289","diff_url":"https://github.com/grpc/grpc/pull/18289.diff","patch_url":"https://github.com/grpc/grpc/pull/18289.patch"},"body":"Fixes and tests an important issue by making sure that callback-only servers properly handle unimplemented methods. This is an easy follow on after #18239 . This is an easy way to do this instead of creating a separate UnknownSyncMethod call (as in the sync API) or UnimplementedAsyncRequest/Response types (as in the async API) because the callback API is based around the idea of background polling; as a result, as long as the callback CQ exists for some purpose, it will be able to also drive an additional service that the user doesn't even know about and which has a default implementation that treats RPCs as unimplemented."},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/470529744","html_url":"https://github.com/grpc/grpc/pull/18289#issuecomment-470529744","issue_url":"https://api.github.com/repos/grpc/grpc/issues/18289","id":470529744,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MDUyOTc0NA==","user":{"login":"vjpai","id":8864912,"node_id":"MDQ6VXNlcjg4NjQ5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8864912?v=4","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"created_at":"2019-03-07T13:43:14Z","updated_at":"2019-03-07T13:43:14Z","author_association":"MEMBER","body":"Only failure is python gevent on Windows so purely unrelated"}}
{"actor":{"display_login":"vjpai"}}