{"action":"created","issue":{"url":"https://api.github.com/repos/microsoft/vscode-languageserver-node/issues/478","repository_url":"https://api.github.com/repos/microsoft/vscode-languageserver-node","labels_url":"https://api.github.com/repos/microsoft/vscode-languageserver-node/issues/478/labels{/name}","comments_url":"https://api.github.com/repos/microsoft/vscode-languageserver-node/issues/478/comments","events_url":"https://api.github.com/repos/microsoft/vscode-languageserver-node/issues/478/events","html_url":"https://github.com/microsoft/vscode-languageserver-node/pull/478","id":431233423,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4OTU0NDMx","number":478,"title":"Integrate Piece Tree -> IncrementalTextDocument | TextDocuments Incremental Document Support","user":{"login":"Jma353","id":10677768,"node_id":"MDQ6VXNlcjEwNjc3NzY4","avatar_url":"https://avatars2.githubusercontent.com/u/10677768?v=4","gravatar_id":"","url":"https://api.github.com/users/Jma353","html_url":"https://github.com/Jma353","followers_url":"https://api.github.com/users/Jma353/followers","following_url":"https://api.github.com/users/Jma353/following{/other_user}","gists_url":"https://api.github.com/users/Jma353/gists{/gist_id}","starred_url":"https://api.github.com/users/Jma353/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jma353/subscriptions","organizations_url":"https://api.github.com/users/Jma353/orgs","repos_url":"https://api.github.com/users/Jma353/repos","events_url":"https://api.github.com/users/Jma353/events{/privacy}","received_events_url":"https://api.github.com/users/Jma353/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/microsoft/vscode-languageserver-node/milestones/36","html_url":"https://github.com/microsoft/vscode-languageserver-node/milestone/36","labels_url":"https://api.github.com/repos/microsoft/vscode-languageserver-node/milestones/36/labels","id":4299049,"node_id":"MDk6TWlsZXN0b25lNDI5OTA0OQ==","number":36,"title":"May 2019","description":"","creator":{"login":"dbaeumer","id":1931590,"node_id":"MDQ6VXNlcjE5MzE1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1931590?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2019-05-09T10:04:08Z","updated_at":"2019-05-16T16:34:19Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2019-04-09T23:05:43Z","updated_at":"2019-05-29T20:15:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/microsoft/vscode-languageserver-node/pulls/478","html_url":"https://github.com/microsoft/vscode-languageserver-node/pull/478","diff_url":"https://github.com/microsoft/vscode-languageserver-node/pull/478.diff","patch_url":"https://github.com/microsoft/vscode-languageserver-node/pull/478.patch"},"body":"This pull request is the result of a dialogue in #476.\r\n\r\nThis PR does 2 things: \r\n1. Integrates @rebornix's [`vscode-piece-tree`](https://github.com/rebornix/PieceTree) npm module.  I use this module to implement `IncrementalTextDocument`, which is the Incremental sync document representation (as `FullTextDocument` is the Full sync document representation).  I add an optional parameter `isFullSync` to `TextDocument#create`, which defaults to `true`.  \r\n2. Updates the `TextDocuments` document manager to support `Incremental` text synchronization mode.  This manager defaults to `Full`, but has an optional constructor parameter that allows the consumer of the API to specify `Incremental` document sync.  When `Incremental` document sync is specified, this document manager passes `isFullSync = false` to `TextDocument#create`, which results in `IncrementalTextDocument` being used per document.\r\n\r\nThis PR also extends the test-suite for `TextDocument`, and bootstraps a test suite for `TextDocuments` (specifically involving `onChange` events).   I reorganize the `TextDocument` tests into two suites, so the test results now look like this: \r\n\r\n```\r\n  TextDocument Lines Model Validator\r\n    ✓ FullTextDocument - Single line\r\n    ✓ FullTextDocument - Multiple lines\r\n    ✓ FullTextDocument - New line characters\r\n    ✓ FullTextDocument - getText(Range)\r\n    ✓ FullTextDocument - Invalid inputs\r\n    ✓ IncrementalTextDocument - Single line\r\n    ✓ IncrementalTextDocument - Multiple lines\r\n    ✓ IncrementalTextDocument - New line characters\r\n    ✓ IncrementalTextDocument - getText(Range)\r\n    ✓ IncrementalTextDocument - Invalid inputs\r\n\r\n  Updateable TextDocument Validator\r\n    ✓ FullTextDocument - update\r\n    ✓ IncrementalTextDocument - basic append\r\n    ✓ IncrementalTextDocument - multi-line append\r\n    ✓ IncrementalTextDocument - basic delete\r\n    ✓ IncrementalTextDocument - multi-line delete\r\n    ✓ IncrementalTextDocument - single character replace\r\n    ✓ IncrementalTextDocument - multi-character replace\r\n    ✓ IncrementalTextDocument - invalid update ranges\r\n```"},"comment":{"url":"https://api.github.com/repos/microsoft/vscode-languageserver-node/issues/comments/497092624","html_url":"https://github.com/microsoft/vscode-languageserver-node/pull/478#issuecomment-497092624","issue_url":"https://api.github.com/repos/microsoft/vscode-languageserver-node/issues/478","id":497092624,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5NzA5MjYyNA==","user":{"login":"Jma353","id":10677768,"node_id":"MDQ6VXNlcjEwNjc3NzY4","avatar_url":"https://avatars2.githubusercontent.com/u/10677768?v=4","gravatar_id":"","url":"https://api.github.com/users/Jma353","html_url":"https://github.com/Jma353","followers_url":"https://api.github.com/users/Jma353/followers","following_url":"https://api.github.com/users/Jma353/following{/other_user}","gists_url":"https://api.github.com/users/Jma353/gists{/gist_id}","starred_url":"https://api.github.com/users/Jma353/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jma353/subscriptions","organizations_url":"https://api.github.com/users/Jma353/orgs","repos_url":"https://api.github.com/users/Jma353/repos","events_url":"https://api.github.com/users/Jma353/events{/privacy}","received_events_url":"https://api.github.com/users/Jma353/received_events","type":"User","site_admin":false},"created_at":"2019-05-29T20:15:52Z","updated_at":"2019-05-29T20:15:52Z","author_association":"NONE","body":"I can change these things @aeschli - thanks for the thoughtful feedback.  \r\n\r\nExpect an update with said changes by Friday, this way you don't have to do any additional refinements on your part. "}}
{"actor":{"display_login":"Jma353"}}