{"action":"created","issue":{"url":"https://api.github.com/repos/urbit/urbit/issues/1892","repository_url":"https://api.github.com/repos/urbit/urbit","labels_url":"https://api.github.com/repos/urbit/urbit/issues/1892/labels{/name}","comments_url":"https://api.github.com/repos/urbit/urbit/issues/1892/comments","events_url":"https://api.github.com/repos/urbit/urbit/issues/1892/events","html_url":"https://github.com/urbit/urbit/pull/1892","id":514821330,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0MzgyMDYx","number":1892,"title":"app: bitcoin integration of %wallet and %zmp RPC calls","user":{"login":"yosoyubik","id":1033194,"node_id":"MDQ6VXNlcjEwMzMxOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1033194?v=4","gravatar_id":"","url":"https://api.github.com/users/yosoyubik","html_url":"https://github.com/yosoyubik","followers_url":"https://api.github.com/users/yosoyubik/followers","following_url":"https://api.github.com/users/yosoyubik/following{/other_user}","gists_url":"https://api.github.com/users/yosoyubik/gists{/gist_id}","starred_url":"https://api.github.com/users/yosoyubik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosoyubik/subscriptions","organizations_url":"https://api.github.com/users/yosoyubik/orgs","repos_url":"https://api.github.com/users/yosoyubik/repos","events_url":"https://api.github.com/users/yosoyubik/events{/privacy}","received_events_url":"https://api.github.com/users/yosoyubik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2019-10-30T16:44:14Z","updated_at":"2019-11-15T19:05:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/urbit/urbit/pulls/1892","html_url":"https://github.com/urbit/urbit/pull/1892","diff_url":"https://github.com/urbit/urbit/pull/1892.diff","patch_url":"https://github.com/urbit/urbit/pull/1892.patch"},"body":"This is still a work in progress, but I'd like to get some feedback to check if this is going in the right direction. \r\n\r\nYou can see a small demo [here](https://youtu.be/k-TjZfMLqOc)\r\n\r\nThere are unit tests that check the proper request and response format but these have been tested manually, not based on the output from the RPC node, since it's not clear from the spec if, for example, some of the attributes returned by the API will be present. These are by no means comprehensive or even correct (that might even be a grant on its own...)\r\n\r\nThere is an attempt at an integration test in the app folder but that one only checks that the proper call to `%iris` is made. I would imagine that a proper integration test in this case (call `%iris` get the response back from the RPC node) would use the `+ph` test framework instead of the normal `+test`?\r\n\r\nThe authentication data for the RPC node is hardcoded in the +prep arm (this should be removed and included via integration with %sole) and the wallet path needs to be added as part of the state of the hook app (when there is only one wallet created there is no need to use it)\r\n\r\nOne last thing is the logic of the store app to stay in sync with the node. For example, it seems that a wallet with no name is created by default when the node is booted up. That will make the state already incompatible (if we create a wallet from the hook app, two will be present in the RPC node but only one in our \"local\" urbit store). You can see this in the demo video. Maybe a sync call needs to be made when the store app is booted?\r\n\r\nProbably all of these has already been considered, solved and declared case closed. In any case I'd love to hear what the general direction is since I probably took too many liberties here."},"comment":{"url":"https://api.github.com/repos/urbit/urbit/issues/comments/554488223","html_url":"https://github.com/urbit/urbit/pull/1892#issuecomment-554488223","issue_url":"https://api.github.com/repos/urbit/urbit/issues/1892","id":554488223,"node_id":"MDEyOklzc3VlQ29tbWVudDU1NDQ4ODIyMw==","user":{"login":"ohAitch","id":1857414,"node_id":"MDQ6VXNlcjE4NTc0MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1857414?v=4","gravatar_id":"","url":"https://api.github.com/users/ohAitch","html_url":"https://github.com/ohAitch","followers_url":"https://api.github.com/users/ohAitch/followers","following_url":"https://api.github.com/users/ohAitch/following{/other_user}","gists_url":"https://api.github.com/users/ohAitch/gists{/gist_id}","starred_url":"https://api.github.com/users/ohAitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohAitch/subscriptions","organizations_url":"https://api.github.com/users/ohAitch/orgs","repos_url":"https://api.github.com/users/ohAitch/repos","events_url":"https://api.github.com/users/ohAitch/events{/privacy}","received_events_url":"https://api.github.com/users/ohAitch/received_events","type":"User","site_admin":false},"created_at":"2019-11-15T19:05:21Z","updated_at":"2019-11-15T19:05:21Z","author_association":"CONTRIBUTOR","body":"sorry I'm not keeping up with the times, is nock 13 .^\n\nOn Fri, Nov 15, 2019 at 10:46, Philip Monk <notifications@github.com> wrote:\n\n> While we're at it let's make a +mule variant that intercepts nock 13 and\n> turns it into ames packets, no *arbitrary effects*.  This is fun!\n>\n> On Fri, Nov 15, 2019 at 10:34 AM, Anton Dyudin < notifications@github.com\n> > wrote:\n>\n> >\n> > feature request: ++mule variant that intercepts ~&s to a list it gives\n> you\n> >\n> > at the end/crash of the computation :P\n> >\n> > (this would also be neat for web dojo work, though _that_ might want to\n> be\n> >\n> > more of a per-event stderr handler. I guess pH would also want to just\n> > install one to the inner arvo?)\n> >\n> > On Fri, Nov 15, 2019 at 10:30, Philip Monk < notifications@ github. com\n> (\n> > notifications@github.com ) > wrote:\n> >\n> > > When you say \"real output\" that's a sole-effect right? Would adding ~&\n> > > cause problems to parse output from dojo? (I would expect that they'd\n> be\n> >\n> > > ignored... mainly to avoid removing/adding those printfs)\n> > >\n> > > Yes, sole-effect will give you real output. If you're in a context\n> where\n> >\n> > > you can't easily do that, you can also send %flog moves to dill. ~& is\n> a\n> >\n> > > nock hint, so it's entirely outside the system -- it won't interfere\n> > with\n> > > anything, but you also can't make pH look for it.\n> > >\n> > > Don't I need to add this as well to the manual-test to start the apps?\n> > >\n> > > Yes, you'll need to start the apps and do any kind of setup you might\n> > need.\n> > >\n> > > —\n> > > You are receiving this because you are subscribed to this thread.\n> > > Reply to this email directly, view it on GitHub\n> > > < https:/ / github. com/ urbit/ urbit/ pull/\n> 1892?email_source=notifications&email_token=AAOFPBUTTSURRXWTHGP2OG3QT3TDHA5CNFSM4JG4UOJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGKCKY#issuecomment-554475819\n> > (\n> >\n> https://github.com/urbit/urbit/pull/1892?email_source=notifications&email_token=AAOFPBUTTSURRXWTHGP2OG3QT3TDHA5CNFSM4JG4UOJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGKCKY#issuecomment-554475819\n> > ) >,\n> > > or unsubscribe\n> > > < https:/ / github. com/ notifications/ unsubscribe-auth/\n> AAOFPBQ4H3TK4OCYYWHSNLTQT3TDHANCNFSM4JG4UOJA\n> > (\n> >\n> https://github.com/notifications/unsubscribe-auth/AAOFPBQ4H3TK4OCYYWHSNLTQT3TDHANCNFSM4JG4UOJA\n> > ) >\n> > > .\n> > >\n> >\n> >\n> > —\n> > You are receiving this because you were mentioned.\n> > Reply to this email directly, view it on GitHub (\n> >\n> https://github.com/urbit/urbit/pull/1892?email_source=notifications&email_token=ABKLYGHOENUVGKAH4THULOLQT3TSZA5CNFSM4JG4UOJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGKOVQ#issuecomment-554477398\n> > ) , or unsubscribe (\n> >\n> https://github.com/notifications/unsubscribe-auth/ABKLYGG36KVRYGUFX5WYHSDQT3TSZANCNFSM4JG4UOJA\n> > ).\n> >\n> >\n> >\n>\n> —\n> You are receiving this because you commented.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/urbit/urbit/pull/1892?email_source=notifications&email_token=AAOFPBSV5GK23FD5OSHAISTQT3U7RA5CNFSM4JG4UOJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGLPFI#issuecomment-554481557>,\n> or unsubscribe\n> <https://github.com/notifications/unsubscribe-auth/AAOFPBWCRHJBFWX6GRPFEPTQT3U7RANCNFSM4JG4UOJA>\n> .\n>\n"}}
{"actor":{"display_login":"ohAitch"}}