{"action":"closed","issue":{"url":"https://api.github.com/repos/pytorch/pytorch/issues/20728","repository_url":"https://api.github.com/repos/pytorch/pytorch","labels_url":"https://api.github.com/repos/pytorch/pytorch/issues/20728/labels{/name}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/20728/comments","events_url":"https://api.github.com/repos/pytorch/pytorch/issues/20728/events","html_url":"https://github.com/pytorch/pytorch/issues/20728","id":446338043,"node_id":"MDU6SXNzdWU0NDYzMzgwNDM=","number":20728,"title":"pythonb -m torch.distributed.launch doesn't propagate non-0 status of child process","user":{"login":"yaroslavvb","id":23068,"node_id":"MDQ6VXNlcjIzMDY4","avatar_url":"https://avatars3.githubusercontent.com/u/23068?v=4","gravatar_id":"","url":"https://api.github.com/users/yaroslavvb","html_url":"https://github.com/yaroslavvb","followers_url":"https://api.github.com/users/yaroslavvb/followers","following_url":"https://api.github.com/users/yaroslavvb/following{/other_user}","gists_url":"https://api.github.com/users/yaroslavvb/gists{/gist_id}","starred_url":"https://api.github.com/users/yaroslavvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaroslavvb/subscriptions","organizations_url":"https://api.github.com/users/yaroslavvb/orgs","repos_url":"https://api.github.com/users/yaroslavvb/repos","events_url":"https://api.github.com/users/yaroslavvb/events{/privacy}","received_events_url":"https://api.github.com/users/yaroslavvb/received_events","type":"User","site_admin":false},"labels":[{"id":679953883,"node_id":"MDU6TGFiZWw2Nzk5NTM4ODM=","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20distributed","name":"module: distributed","color":"f7e101","default":false},{"id":1304335025,"node_id":"MDU6TGFiZWwxMzA0MzM1MDI1","url":"https://api.github.com/repos/pytorch/pytorch/labels/small","name":"small","color":"fbca04","default":false},{"id":1301347167,"node_id":"MDU6TGFiZWwxMzAxMzQ3MTY3","url":"https://api.github.com/repos/pytorch/pytorch/labels/triaged","name":"triaged","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-05-20T22:29:39Z","updated_at":"2019-05-23T18:23:56Z","closed_at":"2019-05-23T18:23:56Z","author_association":"NONE","body":"Right now if child process crashes, with `python -m torch.distributed.launch script.py` will return with a 0 return code. It should instead propagate non-zero exit status so that the launching environment could detect the failure\r\n\r\n```\r\nsubprocess.CalledProcessError: Command '['/home/ubuntu/anaconda3/envs/pytorch_p36/bin/python', '-u', 'pytorch_bench.py', '--local_rank=0', '--num_tasks=2', '--logdir', '/ncluster/runs/unnamedrun-0-ogf2l.06']' returned non-zero exit status 1.\r\n(pytorch_p36) ubuntu@ip-172-31-12-237:~$ echo $?\r\n0\r\n(pytorch_p36) ubuntu@ip-172-31-12-237:~$ python\r\nPython 3.6.5 |Anaconda, Inc.| (default, Apr 29 2018, 16:14:56)\r\n[GCC 7.2.0] on linux\r\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\r\nim>>> import torch\r\n>>> torch.__version__\r\n'1.1.0'\r\n\r\n```"}}
{"actor":{"display_login":"yaroslavvb"}}