{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/cluster-api-provider-azure/issues/75","repository_url":"https://api.github.com/repos/openshift/cluster-api-provider-azure","labels_url":"https://api.github.com/repos/openshift/cluster-api-provider-azure/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/openshift/cluster-api-provider-azure/issues/75/comments","events_url":"https://api.github.com/repos/openshift/cluster-api-provider-azure/issues/75/events","html_url":"https://github.com/openshift/cluster-api-provider-azure/pull/75","id":486237707,"node_id":"MDExOlB1bGxSZXF1ZXN0MzExNzMwMDgx","number":75,"title":"UPSTREAM: <carry>: openshift: Skip deletion of public IPs with too long names","user":{"login":"ingvagabund","id":8055242,"node_id":"MDQ6VXNlcjgwNTUyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8055242?v=4","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-08-28T08:40:20Z","updated_at":"2019-08-28T08:41:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/cluster-api-provider-azure/pulls/75","html_url":"https://github.com/openshift/cluster-api-provider-azure/pull/75","diff_url":"https://github.com/openshift/cluster-api-provider-azure/pull/75.diff","patch_url":"https://github.com/openshift/cluster-api-provider-azure/pull/75.patch"},"body":"The generated name is longer than allowed by the Azure portal under following OR conditions:\r\n- machine name is changed (can't happen without creating a new CR)\r\n- cluster name is changed (could happen but then we will get different name anyway)\r\n- machine CR was created with too long public ip name (in which case no instance was created)\r\n\r\nIn all cases there is nothing to delete. So the deletion can be skipped.\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n_Please confirm that if this PR changes any image versions, then that's the sole change this PR makes._\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/openshift/cluster-api-provider-azure/issues/comments/525644652","html_url":"https://github.com/openshift/cluster-api-provider-azure/pull/75#issuecomment-525644652","issue_url":"https://api.github.com/repos/openshift/cluster-api-provider-azure/issues/75","id":525644652,"node_id":"MDEyOklzc3VlQ29tbWVudDUyNTY0NDY1Mg==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-08-28T08:41:29Z","updated_at":"2019-08-28T08:41:29Z","author_association":"NONE","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by:\nTo complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **ingvagabund**\nYou can assign the PR to them by writing `/assign @ingvagabund` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=openshift%2Fcluster-api-provider-azure).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/openshift/cluster-api-provider-azure/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"ingvagabund\"]} -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}