{"action":"created","comment":{"url":"https://api.github.com/repos/zeromq/libzmq/pulls/comments/255335144","pull_request_review_id":201900734,"id":255335144,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTMzNTE0NA==","diff_hunk":"@@ -1452,3 +1452,10 @@ int zmq_has (const char *capability_)\n     //  Whatever the application asked for, we don't have\n     return false;\n }\n+\n+void zmq_socket_monitor_pipes_stats (void *s_)","path":"src/zmq.cpp","position":5,"original_position":5,"commit_id":"c01eaecc846af212326b9a3fb2e5c8795c08f95f","original_commit_id":"c01eaecc846af212326b9a3fb2e5c8795c08f95f","user":{"login":"sigiesec","id":16757805,"node_id":"MDQ6VXNlcjE2NzU3ODA1","avatar_url":"https://avatars0.githubusercontent.com/u/16757805?v=4","gravatar_id":"","url":"https://api.github.com/users/sigiesec","html_url":"https://github.com/sigiesec","followers_url":"https://api.github.com/users/sigiesec/followers","following_url":"https://api.github.com/users/sigiesec/following{/other_user}","gists_url":"https://api.github.com/users/sigiesec/gists{/gist_id}","starred_url":"https://api.github.com/users/sigiesec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigiesec/subscriptions","organizations_url":"https://api.github.com/users/sigiesec/orgs","repos_url":"https://api.github.com/users/sigiesec/repos","events_url":"https://api.github.com/users/sigiesec/events{/privacy}","received_events_url":"https://api.github.com/users/sigiesec/received_events","type":"User","site_admin":false},"body":"For uniformity, shouldn't this return an int, and return -1 on error (ENOTSOCK/EINVAL e.g.)? What if there is no socket monitor on the socket?","created_at":"2019-02-10T12:18:11Z","updated_at":"2019-02-10T12:18:11Z","html_url":"https://github.com/zeromq/libzmq/pull/3383#discussion_r255335144","pull_request_url":"https://api.github.com/repos/zeromq/libzmq/pulls/3383","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/comments/255335144"},"html":{"href":"https://github.com/zeromq/libzmq/pull/3383#discussion_r255335144"},"pull_request":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/3383"}}},"pull_request":{"url":"https://api.github.com/repos/zeromq/libzmq/pulls/3383","id":249911743,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5OTExNzQz","html_url":"https://github.com/zeromq/libzmq/pull/3383","diff_url":"https://github.com/zeromq/libzmq/pull/3383.diff","patch_url":"https://github.com/zeromq/libzmq/pull/3383.patch","issue_url":"https://api.github.com/repos/zeromq/libzmq/issues/3383","number":3383,"state":"open","locked":false,"title":"Problem: cannot monitor state of queues at runtime","user":{"login":"bluca","id":782193,"node_id":"MDQ6VXNlcjc4MjE5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/782193?v=4","gravatar_id":"","url":"https://api.github.com/users/bluca","html_url":"https://github.com/bluca","followers_url":"https://api.github.com/users/bluca/followers","following_url":"https://api.github.com/users/bluca/following{/other_user}","gists_url":"https://api.github.com/users/bluca/gists{/gist_id}","starred_url":"https://api.github.com/users/bluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluca/subscriptions","organizations_url":"https://api.github.com/users/bluca/orgs","repos_url":"https://api.github.com/users/bluca/repos","events_url":"https://api.github.com/users/bluca/events{/privacy}","received_events_url":"https://api.github.com/users/bluca/received_events","type":"User","site_admin":false},"body":"Solution: add API and event\r\n\r\nFixes #3403","created_at":"2019-02-03T23:14:56Z","updated_at":"2019-02-10T12:18:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5604198625d6cbb84db192dc3e9dc055edd9819e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeromq/libzmq/pulls/3383/commits","review_comments_url":"https://api.github.com/repos/zeromq/libzmq/pulls/3383/comments","review_comment_url":"https://api.github.com/repos/zeromq/libzmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeromq/libzmq/issues/3383/comments","statuses_url":"https://api.github.com/repos/zeromq/libzmq/statuses/c01eaecc846af212326b9a3fb2e5c8795c08f95f","head":{"label":"ZMQers:queue_monitor","ref":"queue_monitor","sha":"c01eaecc846af212326b9a3fb2e5c8795c08f95f","user":{"login":"ZMQers","id":16915082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTE1MDgy","avatar_url":"https://avatars0.githubusercontent.com/u/16915082?v=4","gravatar_id":"","url":"https://api.github.com/users/ZMQers","html_url":"https://github.com/ZMQers","followers_url":"https://api.github.com/users/ZMQers/followers","following_url":"https://api.github.com/users/ZMQers/following{/other_user}","gists_url":"https://api.github.com/users/ZMQers/gists{/gist_id}","starred_url":"https://api.github.com/users/ZMQers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZMQers/subscriptions","organizations_url":"https://api.github.com/users/ZMQers/orgs","repos_url":"https://api.github.com/users/ZMQers/repos","events_url":"https://api.github.com/users/ZMQers/events{/privacy}","received_events_url":"https://api.github.com/users/ZMQers/received_events","type":"Organization","site_admin":false},"repo":{"id":119815399,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4MTUzOTk=","name":"libzmq","full_name":"ZMQers/libzmq","private":false,"owner":{"login":"ZMQers","id":16915082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTE1MDgy","avatar_url":"https://avatars0.githubusercontent.com/u/16915082?v=4","gravatar_id":"","url":"https://api.github.com/users/ZMQers","html_url":"https://github.com/ZMQers","followers_url":"https://api.github.com/users/ZMQers/followers","following_url":"https://api.github.com/users/ZMQers/following{/other_user}","gists_url":"https://api.github.com/users/ZMQers/gists{/gist_id}","starred_url":"https://api.github.com/users/ZMQers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZMQers/subscriptions","organizations_url":"https://api.github.com/users/ZMQers/orgs","repos_url":"https://api.github.com/users/ZMQers/repos","events_url":"https://api.github.com/users/ZMQers/events{/privacy}","received_events_url":"https://api.github.com/users/ZMQers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ZMQers/libzmq","description":"ZeroMQ core engine in C++, implements ZMTP/3.0","fork":true,"url":"https://api.github.com/repos/ZMQers/libzmq","forks_url":"https://api.github.com/repos/ZMQers/libzmq/forks","keys_url":"https://api.github.com/repos/ZMQers/libzmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZMQers/libzmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZMQers/libzmq/teams","hooks_url":"https://api.github.com/repos/ZMQers/libzmq/hooks","issue_events_url":"https://api.github.com/repos/ZMQers/libzmq/issues/events{/number}","events_url":"https://api.github.com/repos/ZMQers/libzmq/events","assignees_url":"https://api.github.com/repos/ZMQers/libzmq/assignees{/user}","branches_url":"https://api.github.com/repos/ZMQers/libzmq/branches{/branch}","tags_url":"https://api.github.com/repos/ZMQers/libzmq/tags","blobs_url":"https://api.github.com/repos/ZMQers/libzmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZMQers/libzmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZMQers/libzmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZMQers/libzmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZMQers/libzmq/statuses/{sha}","languages_url":"https://api.github.com/repos/ZMQers/libzmq/languages","stargazers_url":"https://api.github.com/repos/ZMQers/libzmq/stargazers","contributors_url":"https://api.github.com/repos/ZMQers/libzmq/contributors","subscribers_url":"https://api.github.com/repos/ZMQers/libzmq/subscribers","subscription_url":"https://api.github.com/repos/ZMQers/libzmq/subscription","commits_url":"https://api.github.com/repos/ZMQers/libzmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZMQers/libzmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZMQers/libzmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZMQers/libzmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZMQers/libzmq/contents/{+path}","compare_url":"https://api.github.com/repos/ZMQers/libzmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZMQers/libzmq/merges","archive_url":"https://api.github.com/repos/ZMQers/libzmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZMQers/libzmq/downloads","issues_url":"https://api.github.com/repos/ZMQers/libzmq/issues{/number}","pulls_url":"https://api.github.com/repos/ZMQers/libzmq/pulls{/number}","milestones_url":"https://api.github.com/repos/ZMQers/libzmq/milestones{/number}","notifications_url":"https://api.github.com/repos/ZMQers/libzmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZMQers/libzmq/labels{/name}","releases_url":"https://api.github.com/repos/ZMQers/libzmq/releases{/id}","deployments_url":"https://api.github.com/repos/ZMQers/libzmq/deployments","created_at":"2018-02-01T09:44:27Z","updated_at":"2018-02-01T09:44:31Z","pushed_at":"2019-02-08T23:21:56Z","git_url":"git://github.com/ZMQers/libzmq.git","ssh_url":"git@github.com:ZMQers/libzmq.git","clone_url":"https://github.com/ZMQers/libzmq.git","svn_url":"https://github.com/ZMQers/libzmq","homepage":"http://www.zeromq.org","size":19176,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zeromq:master","ref":"master","sha":"e5a7f2eb568b5655699a16ae9867fe656b42b533","user":{"login":"zeromq","id":109777,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTc3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/109777?v=4","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"repo":{"id":263379,"node_id":"MDEwOlJlcG9zaXRvcnkyNjMzNzk=","name":"libzmq","full_name":"zeromq/libzmq","private":false,"owner":{"login":"zeromq","id":109777,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTc3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/109777?v=4","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zeromq/libzmq","description":"ZeroMQ core engine in C++, implements ZMTP/3.1","fork":false,"url":"https://api.github.com/repos/zeromq/libzmq","forks_url":"https://api.github.com/repos/zeromq/libzmq/forks","keys_url":"https://api.github.com/repos/zeromq/libzmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeromq/libzmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeromq/libzmq/teams","hooks_url":"https://api.github.com/repos/zeromq/libzmq/hooks","issue_events_url":"https://api.github.com/repos/zeromq/libzmq/issues/events{/number}","events_url":"https://api.github.com/repos/zeromq/libzmq/events","assignees_url":"https://api.github.com/repos/zeromq/libzmq/assignees{/user}","branches_url":"https://api.github.com/repos/zeromq/libzmq/branches{/branch}","tags_url":"https://api.github.com/repos/zeromq/libzmq/tags","blobs_url":"https://api.github.com/repos/zeromq/libzmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeromq/libzmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeromq/libzmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeromq/libzmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeromq/libzmq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeromq/libzmq/languages","stargazers_url":"https://api.github.com/repos/zeromq/libzmq/stargazers","contributors_url":"https://api.github.com/repos/zeromq/libzmq/contributors","subscribers_url":"https://api.github.com/repos/zeromq/libzmq/subscribers","subscription_url":"https://api.github.com/repos/zeromq/libzmq/subscription","commits_url":"https://api.github.com/repos/zeromq/libzmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeromq/libzmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeromq/libzmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeromq/libzmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeromq/libzmq/contents/{+path}","compare_url":"https://api.github.com/repos/zeromq/libzmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeromq/libzmq/merges","archive_url":"https://api.github.com/repos/zeromq/libzmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeromq/libzmq/downloads","issues_url":"https://api.github.com/repos/zeromq/libzmq/issues{/number}","pulls_url":"https://api.github.com/repos/zeromq/libzmq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeromq/libzmq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeromq/libzmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeromq/libzmq/labels{/name}","releases_url":"https://api.github.com/repos/zeromq/libzmq/releases{/id}","deployments_url":"https://api.github.com/repos/zeromq/libzmq/deployments","created_at":"2009-07-29T09:56:41Z","updated_at":"2019-02-10T03:03:36Z","pushed_at":"2019-02-08T23:21:58Z","git_url":"git://github.com/zeromq/libzmq.git","ssh_url":"git@github.com:zeromq/libzmq.git","clone_url":"https://github.com/zeromq/libzmq.git","svn_url":"https://github.com/zeromq/libzmq","homepage":"http://www.zeromq.org","size":19139,"stargazers_count":4922,"watchers_count":4922,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1470,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1470,"open_issues":140,"watchers":4922,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/3383"},"html":{"href":"https://github.com/zeromq/libzmq/pull/3383"},"issue":{"href":"https://api.github.com/repos/zeromq/libzmq/issues/3383"},"comments":{"href":"https://api.github.com/repos/zeromq/libzmq/issues/3383/comments"},"review_comments":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/3383/comments"},"review_comment":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/3383/commits"},"statuses":{"href":"https://api.github.com/repos/zeromq/libzmq/statuses/c01eaecc846af212326b9a3fb2e5c8795c08f95f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sigiesec"}}