{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/rmw/pulls/comments/349759718","pull_request_review_id":321763303,"id":349759718,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0OTc1OTcxOA==","diff_hunk":"@@ -1,4 +1,4 @@\n-// Copyright 2017 Open Source Robotics Foundation, Inc.\n+// Copyright 2017-2019 Open Source Robotics Foundation, Inc.","path":"rmw/src/security_options.c","position":2,"original_position":2,"commit_id":"de00c5ddd70ece8d576dbec11cb41292f16f5503","original_commit_id":"de00c5ddd70ece8d576dbec11cb41292f16f5503","user":{"login":"wjwwood","id":100427,"node_id":"MDQ6VXNlcjEwMDQyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/100427?v=4","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"Same here, seems unnecessary.","created_at":"2019-11-22T19:31:37Z","updated_at":"2019-11-22T19:31:37Z","html_url":"https://github.com/ros2/rmw/pull/189#discussion_r349759718","pull_request_url":"https://api.github.com/repos/ros2/rmw/pulls/189","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ros2/rmw/pulls/comments/349759718"},"html":{"href":"https://github.com/ros2/rmw/pull/189#discussion_r349759718"},"pull_request":{"href":"https://api.github.com/repos/ros2/rmw/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/rmw/pulls/189","id":326915780,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2OTE1Nzgw","html_url":"https://github.com/ros2/rmw/pull/189","diff_url":"https://github.com/ros2/rmw/pull/189.diff","patch_url":"https://github.com/ros2/rmw/pull/189.patch","issue_url":"https://api.github.com/repos/ros2/rmw/issues/189","number":189,"state":"open","locked":false,"title":"[WIP] Switch to one participant per context.","user":{"login":"ivanpauno","id":26796393,"node_id":"MDQ6VXNlcjI2Nzk2Mzkz","avatar_url":"https://avatars0.githubusercontent.com/u/26796393?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanpauno","html_url":"https://github.com/ivanpauno","followers_url":"https://api.github.com/users/ivanpauno/followers","following_url":"https://api.github.com/users/ivanpauno/following{/other_user}","gists_url":"https://api.github.com/users/ivanpauno/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanpauno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanpauno/subscriptions","organizations_url":"https://api.github.com/users/ivanpauno/orgs","repos_url":"https://api.github.com/users/ivanpauno/repos","events_url":"https://api.github.com/users/ivanpauno/events{/privacy}","received_events_url":"https://api.github.com/users/ivanpauno/received_events","type":"User","site_admin":false},"body":"API changes needed after ros2/rmw_fastrtps#312.\r\n\r\nTODOs:\r\n- Delete `domain_id` and `security_options` from node creation (see [here](https://github.com/ros2/rmw/blob/45c81c96b1157704dd9be7824dcd4312c8691de8/rmw/include/rmw/rmw.h#L171-L172)).","created_at":"2019-10-10T20:28:03Z","updated_at":"2019-11-22T19:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a49b85a4f2a4dea1f1cd90e92cdde22674c53ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":120328730,"node_id":"MDU6TGFiZWwxMjAzMjg3MzA=","url":"https://api.github.com/repos/ros2/rmw/labels/enhancement","name":"enhancement","color":"a2eeef","default":true,"description":"New feature or request"},{"id":1608581329,"node_id":"MDU6TGFiZWwxNjA4NTgxMzI5","url":"https://api.github.com/repos/ros2/rmw/labels/needs%20review","name":"needs review","color":"ededed","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rmw/pulls/189/commits","review_comments_url":"https://api.github.com/repos/ros2/rmw/pulls/189/comments","review_comment_url":"https://api.github.com/repos/ros2/rmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rmw/issues/189/comments","statuses_url":"https://api.github.com/repos/ros2/rmw/statuses/de00c5ddd70ece8d576dbec11cb41292f16f5503","head":{"label":"ros2:ivanpauno/one-participant-per-context","ref":"ivanpauno/one-participant-per-context","sha":"de00c5ddd70ece8d576dbec11cb41292f16f5503","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":22737319,"node_id":"MDEwOlJlcG9zaXRvcnkyMjczNzMxOQ==","name":"rmw","full_name":"ros2/rmw","private":false,"owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros2/rmw","description":"The ROS Middleware (rmw) Interface.","fork":false,"url":"https://api.github.com/repos/ros2/rmw","forks_url":"https://api.github.com/repos/ros2/rmw/forks","keys_url":"https://api.github.com/repos/ros2/rmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw/teams","hooks_url":"https://api.github.com/repos/ros2/rmw/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw/events","assignees_url":"https://api.github.com/repos/ros2/rmw/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw/tags","blobs_url":"https://api.github.com/repos/ros2/rmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw/subscription","commits_url":"https://api.github.com/repos/ros2/rmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw/merges","archive_url":"https://api.github.com/repos/ros2/rmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw/downloads","issues_url":"https://api.github.com/repos/ros2/rmw/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rmw/deployments","created_at":"2014-08-07T21:35:58Z","updated_at":"2019-11-05T02:47:31Z","pushed_at":"2019-11-21T20:57:31Z","git_url":"git://github.com/ros2/rmw.git","ssh_url":"git@github.com:ros2/rmw.git","clone_url":"https://github.com/ros2/rmw.git","svn_url":"https://github.com/ros2/rmw","homepage":"","size":358,"stargazers_count":30,"watchers_count":30,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":12,"watchers":30,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"813b94ddd5650444b312304ad156f3b5d9f05e39","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":22737319,"node_id":"MDEwOlJlcG9zaXRvcnkyMjczNzMxOQ==","name":"rmw","full_name":"ros2/rmw","private":false,"owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros2/rmw","description":"The ROS Middleware (rmw) Interface.","fork":false,"url":"https://api.github.com/repos/ros2/rmw","forks_url":"https://api.github.com/repos/ros2/rmw/forks","keys_url":"https://api.github.com/repos/ros2/rmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw/teams","hooks_url":"https://api.github.com/repos/ros2/rmw/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw/events","assignees_url":"https://api.github.com/repos/ros2/rmw/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw/tags","blobs_url":"https://api.github.com/repos/ros2/rmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw/subscription","commits_url":"https://api.github.com/repos/ros2/rmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw/merges","archive_url":"https://api.github.com/repos/ros2/rmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw/downloads","issues_url":"https://api.github.com/repos/ros2/rmw/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rmw/deployments","created_at":"2014-08-07T21:35:58Z","updated_at":"2019-11-05T02:47:31Z","pushed_at":"2019-11-21T20:57:31Z","git_url":"git://github.com/ros2/rmw.git","ssh_url":"git@github.com:ros2/rmw.git","clone_url":"https://github.com/ros2/rmw.git","svn_url":"https://github.com/ros2/rmw","homepage":"","size":358,"stargazers_count":30,"watchers_count":30,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":12,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rmw/pulls/189"},"html":{"href":"https://github.com/ros2/rmw/pull/189"},"issue":{"href":"https://api.github.com/repos/ros2/rmw/issues/189"},"comments":{"href":"https://api.github.com/repos/ros2/rmw/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rmw/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rmw/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rmw/statuses/de00c5ddd70ece8d576dbec11cb41292f16f5503"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wjwwood"}}