{"action":"created","issue":{"url":"https://api.github.com/repos/parcel-bundler/parcel/issues/3902","repository_url":"https://api.github.com/repos/parcel-bundler/parcel","labels_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/3902/labels{/name}","comments_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/3902/comments","events_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/3902/events","html_url":"https://github.com/parcel-bundler/parcel/pull/3902","id":536549133,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyMDYwMzY4","number":3902,"title":"Fix Firefox certificate warnings","user":{"login":"DeMoorJasper","id":2175521,"node_id":"MDQ6VXNlcjIxNzU1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2175521?v=4","gravatar_id":"","url":"https://api.github.com/users/DeMoorJasper","html_url":"https://github.com/DeMoorJasper","followers_url":"https://api.github.com/users/DeMoorJasper/followers","following_url":"https://api.github.com/users/DeMoorJasper/following{/other_user}","gists_url":"https://api.github.com/users/DeMoorJasper/gists{/gist_id}","starred_url":"https://api.github.com/users/DeMoorJasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeMoorJasper/subscriptions","organizations_url":"https://api.github.com/users/DeMoorJasper/orgs","repos_url":"https://api.github.com/users/DeMoorJasper/repos","events_url":"https://api.github.com/users/DeMoorJasper/events{/privacy}","received_events_url":"https://api.github.com/users/DeMoorJasper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-12-11T18:44:42Z","updated_at":"2019-12-11T18:59:53Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3902","html_url":"https://github.com/parcel-bundler/parcel/pull/3902","diff_url":"https://github.com/parcel-bundler/parcel/pull/3902.diff","patch_url":"https://github.com/parcel-bundler/parcel/pull/3902.patch"},"body":"<!---\r\nThanks for filing a pull request 😄 ! Before you submit, please read the following:\r\n\r\nSearch open/closed issues before submitting since someone might have pushed the same thing before!\r\n-->\r\n\r\n# ↪️ Pull Request\r\n\r\n<!---\r\nProvide a general summary of the pull request here\r\nPlease look for any issues that this PR resolves and tag them in the PR.\r\n-->\r\n\r\nAccording to #3398 firefox throws errors on our self-signed certificates, this is due to a misconfiguration in the generate script we use.\r\n\r\nThis PR fixes the script by removing the feature that says our certificates are issued by a CA.\r\n\r\nCloses #3398\r\n\r\n## 🚨 Test instructions\r\n\r\n<!-- In case it is impossible (or too hard) to reliably test this feature/fix with unit tests, please provide test instructions! -->\r\n\r\nRun dev server in firefox\r\n\r\n## ✔️ PR Todo\r\n\r\n- [x] Added/updated unit tests for this change\r\n- [x] Filled out test instructions (In case there aren't any unit tests)\r\n- [x] Included links to related issues/PRs\r\n\r\n<!--\r\nLove parcel? Please consider supporting our collective:\r\n👉  https://opencollective.com/parcel/donate\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/parcel-bundler/parcel/issues/comments/564684911","html_url":"https://github.com/parcel-bundler/parcel/pull/3902#issuecomment-564684911","issue_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/3902","id":564684911,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NDY4NDkxMQ==","user":{"login":"parcel-benchmark","id":56087869,"node_id":"MDQ6VXNlcjU2MDg3ODY5","avatar_url":"https://avatars1.githubusercontent.com/u/56087869?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-benchmark","html_url":"https://github.com/parcel-benchmark","followers_url":"https://api.github.com/users/parcel-benchmark/followers","following_url":"https://api.github.com/users/parcel-benchmark/following{/other_user}","gists_url":"https://api.github.com/users/parcel-benchmark/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-benchmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-benchmark/subscriptions","organizations_url":"https://api.github.com/users/parcel-benchmark/orgs","repos_url":"https://api.github.com/users/parcel-benchmark/repos","events_url":"https://api.github.com/users/parcel-benchmark/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-benchmark/received_events","type":"User","site_admin":false},"created_at":"2019-12-11T18:59:53Z","updated_at":"2019-12-11T18:59:53Z","author_association":"NONE","body":"## Benchmark Results\n<details><summary>packages/benchmarks/kitchen-sink ✅</summary><p>\n\n#### Timings\n\n| Description | Time | Difference |\n| --- | --- | --- |\n| Cold | 10.43s | +50.00ms |\n| Cached | 8.64s | -104.00ms |\n\n#### Cold Bundles\n\n| Bundle | Size | Difference | Time | Difference |\n| --- | --- | --- | --- | --- |\n| dist/legacy/parcel.ff215454.webp | 102.94kb | +0.00b | 167.00ms | +17.00ms ⚠️ |\n| dist/modern/parcel.76ee4591.webp | 102.94kb | +0.00b | 165.00ms | +17.00ms ⚠️ |\n| dist/legacy/index.css | 29.00b | +0.00b | 1.38s | +78.00ms ⚠️ |\n\n#### Cached Bundles\n\n| Bundle | Size | Difference | Time | Difference |\n| --- | --- | --- | --- | --- |\n| dist/modern/parcel.76ee4591.webp | 102.94kb | +0.00b | 11.00ms | -1.00ms 🚀 |\n| dist/legacy/index.js | 243.00b | +0.00b | 17.00ms | -1.00ms 🚀 |\n| dist/modern/index.js | 215.00b | +0.00b | 12.00ms | -1.00ms 🚀 |\n\n</p></details>\n\n<details><summary>packages/benchmarks/react-hn ✅</summary><p>\n\n#### Timings\n\n| Description | Time | Difference |\n| --- | --- | --- |\n| Cold | 14.26s | +52.00ms |\n| Cached | 9.87s | -32.00ms |\n\n#### Cold Bundles\n\n*No bundle changes detected.*\n\n#### Cached Bundles\n\n| Bundle | Size | Difference | Time | Difference |\n| --- | --- | --- | --- | --- |\n| dist/main/index.js | 34.00kb | +0.00b | 14.00ms | -1.00ms 🚀 |\n\n</p></details>\n\n<details><summary>packages/benchmarks/ak-editor 🚨</summary><p>\n\n#### Timings\n\n| Description | Time | Difference |\n| --- | --- | --- |\n| Cold | **FAILED** | -0.00ms |\n| Cached | **FAILED** | -0.00ms |\n\n#### Cold Bundles\n\n*No bundles found, this is probably a failed build...*\n#### Cached Bundles\n\n*No bundles found, this is probably a failed build...*\n</p></details>\n\n**[Click here to view a detailed benchmark overview.](https://benchmark.parceljs.org/benchmark/251482018740699657)**"}}
{"actor":{"display_login":"parcel-benchmark"}}