{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/comments/317400500","pull_request_review_id":279338410,"id":317400500,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNzQwMDUwMA==","diff_hunk":"@@ -48,31 +50,29 @@ def __init__(self, columns, row):\n                     self._hidden_values.append(value)\n                 continue\n \n-            if column_type in [\"datetime\", \"timespan\", \"decimal\"]:\n-                if value is None:\n-                    typed_value = None\n-                    if HAS_PANDAS:\n-                        self._hidden_values.append(None)\n-                else:\n-                    # If you are here to read this, you probably hit some datetime/timedelta inconsistencies.\n-                    # Azure-Data-Explorer(Kusto) supports 7 decimal digits, while the corresponding python types supports only 6.\n-                    # One example why one might want this precision, is when working with pandas.\n-                    # In that case, use azure.kusto.data.helpers.dataframe_from_result_table which takes into account the original value.\n-                    typed_value = KustoResultRow.convertion_funcs[column_type](value)\n-\n-                    # this is a special case where plain python will lose precision, so we keep the precise value hidden\n-                    # when transforming to pandas, we can use the hidden value to convert to precise pandas/numpy types\n-                    if HAS_PANDAS:\n-                        if column_type == \"datetime\":\n-                            self._hidden_values.append(to_pandas_datetime(value))\n-                        if column_type == \"timespan\":\n-                            self._hidden_values.append(to_pandas_timedelta(value, typed_value))\n-                        if column_type == \"decimal\":\n-                            self._hidden_values.append(value)\n+            if value is None:","path":"azure-kusto-data/azure/kusto/data/_models.py","position":34,"original_position":34,"commit_id":"89fe63634e8f3585bc1a48789fea14bc7e375632","original_commit_id":"89fe63634e8f3585bc1a48789fea14bc7e375632","user":{"login":"danield137","id":15192451,"node_id":"MDQ6VXNlcjE1MTkyNDUx","avatar_url":"https://avatars1.githubusercontent.com/u/15192451?v=4","gravatar_id":"","url":"https://api.github.com/users/danield137","html_url":"https://github.com/danield137","followers_url":"https://api.github.com/users/danield137/followers","following_url":"https://api.github.com/users/danield137/following{/other_user}","gists_url":"https://api.github.com/users/danield137/gists{/gist_id}","starred_url":"https://api.github.com/users/danield137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danield137/subscriptions","organizations_url":"https://api.github.com/users/danield137/orgs","repos_url":"https://api.github.com/users/danield137/repos","events_url":"https://api.github.com/users/danield137/events{/privacy}","received_events_url":"https://api.github.com/users/danield137/received_events","type":"User","site_admin":false},"body":"How is it more efficient? you can always reverse \r\n`if value is not None and column_type in KustoResultRow.pandas_funcs`\r\nwhich will do exactly the same. \r\n\r\nMy problem with the `if value is Non` is that it doesn't convey the intention of the code as well as the code without it..\r\n\r\nBut, it's not that big of a deal to me.. if you like it the way it was, ok.","created_at":"2019-08-25T14:15:16Z","updated_at":"2019-08-25T14:16:04Z","html_url":"https://github.com/Azure/azure-kusto-python/pull/160#discussion_r317400500","pull_request_url":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/160","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/comments/317400500"},"html":{"href":"https://github.com/Azure/azure-kusto-python/pull/160#discussion_r317400500"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/160"}},"in_reply_to_id":317397738},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/160","id":310675117,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwNjc1MTE3","html_url":"https://github.com/Azure/azure-kusto-python/pull/160","diff_url":"https://github.com/Azure/azure-kusto-python/pull/160.diff","patch_url":"https://github.com/Azure/azure-kusto-python/pull/160.patch","issue_url":"https://api.github.com/repos/Azure/azure-kusto-python/issues/160","number":160,"state":"open","locked":false,"title":"Deals with non nullable values","user":{"login":"boazsha","id":15858748,"node_id":"MDQ6VXNlcjE1ODU4NzQ4","avatar_url":"https://avatars2.githubusercontent.com/u/15858748?v=4","gravatar_id":"","url":"https://api.github.com/users/boazsha","html_url":"https://github.com/boazsha","followers_url":"https://api.github.com/users/boazsha/followers","following_url":"https://api.github.com/users/boazsha/following{/other_user}","gists_url":"https://api.github.com/users/boazsha/gists{/gist_id}","starred_url":"https://api.github.com/users/boazsha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boazsha/subscriptions","organizations_url":"https://api.github.com/users/boazsha/orgs","repos_url":"https://api.github.com/users/boazsha/repos","events_url":"https://api.github.com/users/boazsha/events{/privacy}","received_events_url":"https://api.github.com/users/boazsha/received_events","type":"User","site_admin":false},"body":"* Deals with None values\r\n* Generalized calls for Pandas conversion functions","created_at":"2019-08-25T10:45:13Z","updated_at":"2019-08-25T14:16:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aec12ad89a054cf0098a3be90b455bfd6bc8f9b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/160/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/160/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-kusto-python/issues/160/comments","statuses_url":"https://api.github.com/repos/Azure/azure-kusto-python/statuses/89fe63634e8f3585bc1a48789fea14bc7e375632","head":{"label":"Azure:dealWithNonNullableValues","ref":"dealWithNonNullableValues","sha":"89fe63634e8f3585bc1a48789fea14bc7e375632","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":108257720,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNTc3MjA=","name":"azure-kusto-python","full_name":"Azure/azure-kusto-python","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-kusto-python","description":"Kusto client libraries for Python","fork":false,"url":"https://api.github.com/repos/Azure/azure-kusto-python","forks_url":"https://api.github.com/repos/Azure/azure-kusto-python/forks","keys_url":"https://api.github.com/repos/Azure/azure-kusto-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-kusto-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-kusto-python/teams","hooks_url":"https://api.github.com/repos/Azure/azure-kusto-python/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-kusto-python/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-kusto-python/events","assignees_url":"https://api.github.com/repos/Azure/azure-kusto-python/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-kusto-python/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-kusto-python/tags","blobs_url":"https://api.github.com/repos/Azure/azure-kusto-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-kusto-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-kusto-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-kusto-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-kusto-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-kusto-python/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-kusto-python/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-kusto-python/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-kusto-python/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-kusto-python/subscription","commits_url":"https://api.github.com/repos/Azure/azure-kusto-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-kusto-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-kusto-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-kusto-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-kusto-python/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-kusto-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-kusto-python/merges","archive_url":"https://api.github.com/repos/Azure/azure-kusto-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-kusto-python/downloads","issues_url":"https://api.github.com/repos/Azure/azure-kusto-python/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-kusto-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-kusto-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-kusto-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-kusto-python/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-kusto-python/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-kusto-python/deployments","created_at":"2017-10-25T10:55:44Z","updated_at":"2019-08-20T16:52:55Z","pushed_at":"2019-08-25T10:45:14Z","git_url":"git://github.com/Azure/azure-kusto-python.git","ssh_url":"git@github.com:Azure/azure-kusto-python.git","clone_url":"https://github.com/Azure/azure-kusto-python.git","svn_url":"https://github.com/Azure/azure-kusto-python","homepage":null,"size":356,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":15,"watchers":52,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"e626d40cdb079d717d05133b9bde301bb071e73b","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":108257720,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNTc3MjA=","name":"azure-kusto-python","full_name":"Azure/azure-kusto-python","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-kusto-python","description":"Kusto client libraries for Python","fork":false,"url":"https://api.github.com/repos/Azure/azure-kusto-python","forks_url":"https://api.github.com/repos/Azure/azure-kusto-python/forks","keys_url":"https://api.github.com/repos/Azure/azure-kusto-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-kusto-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-kusto-python/teams","hooks_url":"https://api.github.com/repos/Azure/azure-kusto-python/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-kusto-python/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-kusto-python/events","assignees_url":"https://api.github.com/repos/Azure/azure-kusto-python/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-kusto-python/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-kusto-python/tags","blobs_url":"https://api.github.com/repos/Azure/azure-kusto-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-kusto-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-kusto-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-kusto-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-kusto-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-kusto-python/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-kusto-python/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-kusto-python/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-kusto-python/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-kusto-python/subscription","commits_url":"https://api.github.com/repos/Azure/azure-kusto-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-kusto-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-kusto-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-kusto-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-kusto-python/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-kusto-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-kusto-python/merges","archive_url":"https://api.github.com/repos/Azure/azure-kusto-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-kusto-python/downloads","issues_url":"https://api.github.com/repos/Azure/azure-kusto-python/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-kusto-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-kusto-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-kusto-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-kusto-python/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-kusto-python/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-kusto-python/deployments","created_at":"2017-10-25T10:55:44Z","updated_at":"2019-08-20T16:52:55Z","pushed_at":"2019-08-25T10:45:14Z","git_url":"git://github.com/Azure/azure-kusto-python.git","ssh_url":"git@github.com:Azure/azure-kusto-python.git","clone_url":"https://github.com/Azure/azure-kusto-python.git","svn_url":"https://github.com/Azure/azure-kusto-python","homepage":null,"size":356,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":15,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/160"},"html":{"href":"https://github.com/Azure/azure-kusto-python/pull/160"},"issue":{"href":"https://api.github.com/repos/Azure/azure-kusto-python/issues/160"},"comments":{"href":"https://api.github.com/repos/Azure/azure-kusto-python/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-kusto-python/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-kusto-python/statuses/89fe63634e8f3585bc1a48789fea14bc7e375632"}},"author_association":"NONE"}}
{"actor":{"display_login":"danield137"}}