{"action":"closed","number":265,"pull_request":{"url":"https://api.github.com/repos/mbta/dotcom/pulls/265","id":338242277,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4MjQyMjc3","html_url":"https://github.com/mbta/dotcom/pull/265","diff_url":"https://github.com/mbta/dotcom/pull/265.diff","patch_url":"https://github.com/mbta/dotcom/pull/265.patch","issue_url":"https://api.github.com/repos/mbta/dotcom/issues/265","number":265,"state":"closed","locked":false,"title":"Add server check for support form uploads","user":{"login":"digitalcora","id":394835,"node_id":"MDQ6VXNlcjM5NDgzNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/394835?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalcora","html_url":"https://github.com/digitalcora","followers_url":"https://api.github.com/users/digitalcora/followers","following_url":"https://api.github.com/users/digitalcora/following{/other_user}","gists_url":"https://api.github.com/users/digitalcora/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalcora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalcora/subscriptions","organizations_url":"https://api.github.com/users/digitalcora/orgs","repos_url":"https://api.github.com/users/digitalcora/repos","events_url":"https://api.github.com/users/digitalcora/events{/privacy}","received_events_url":"https://api.github.com/users/digitalcora/received_events","type":"User","site_admin":false},"body":"The client side already has validation for trying to attach non-images, so this is mostly an anti-spambot measure to prevent people from throwing viruses into the ticketing system (even though this would require a support person to intentionally download and open them).\r\n\r\nThe `filename` and `mime_type` of a Plug.Upload are both provided by the user and thus untrusted, but since we ultimately attach the upload to an email using its `filename`, that is what will control how the recipient's computer tries to open it.\r\n\r\n**Asana Ticket:** [Feedback Form | Address file type security issue](https://app.asana.com/0/477545582537986/1148399311722825/f)","created_at":"2019-11-07T21:08:00Z","updated_at":"2019-11-08T20:40:04Z","closed_at":"2019-11-08T20:40:04Z","merged_at":"2019-11-08T20:40:04Z","merge_commit_sha":"b31f741205c94d1a6933d4e92165a01c596b4956","assignee":null,"assignees":[],"requested_reviewers":[{"login":"amaisano","id":688435,"node_id":"MDQ6VXNlcjY4ODQzNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/688435?v=4","gravatar_id":"","url":"https://api.github.com/users/amaisano","html_url":"https://github.com/amaisano","followers_url":"https://api.github.com/users/amaisano/followers","following_url":"https://api.github.com/users/amaisano/following{/other_user}","gists_url":"https://api.github.com/users/amaisano/gists{/gist_id}","starred_url":"https://api.github.com/users/amaisano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaisano/subscriptions","organizations_url":"https://api.github.com/users/amaisano/orgs","repos_url":"https://api.github.com/users/amaisano/repos","events_url":"https://api.github.com/users/amaisano/events{/privacy}","received_events_url":"https://api.github.com/users/amaisano/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mbta/dotcom/pulls/265/commits","review_comments_url":"https://api.github.com/repos/mbta/dotcom/pulls/265/comments","review_comment_url":"https://api.github.com/repos/mbta/dotcom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mbta/dotcom/issues/265/comments","statuses_url":"https://api.github.com/repos/mbta/dotcom/statuses/32f1834e94182a749bf524e785e1ee1514f6ac29","head":{"label":"mbta:cfg-upload-file-types","ref":"cfg-upload-file-types","sha":"32f1834e94182a749bf524e785e1ee1514f6ac29","user":{"login":"mbta","id":17993322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkzMzIy","avatar_url":"https://avatars0.githubusercontent.com/u/17993322?v=4","gravatar_id":"","url":"https://api.github.com/users/mbta","html_url":"https://github.com/mbta","followers_url":"https://api.github.com/users/mbta/followers","following_url":"https://api.github.com/users/mbta/following{/other_user}","gists_url":"https://api.github.com/users/mbta/gists{/gist_id}","starred_url":"https://api.github.com/users/mbta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbta/subscriptions","organizations_url":"https://api.github.com/users/mbta/orgs","repos_url":"https://api.github.com/users/mbta/repos","events_url":"https://api.github.com/users/mbta/events{/privacy}","received_events_url":"https://api.github.com/users/mbta/received_events","type":"Organization","site_admin":false},"repo":{"id":189251630,"node_id":"MDEwOlJlcG9zaXRvcnkxODkyNTE2MzA=","name":"dotcom","full_name":"mbta/dotcom","private":false,"owner":{"login":"mbta","id":17993322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkzMzIy","avatar_url":"https://avatars0.githubusercontent.com/u/17993322?v=4","gravatar_id":"","url":"https://api.github.com/users/mbta","html_url":"https://github.com/mbta","followers_url":"https://api.github.com/users/mbta/followers","following_url":"https://api.github.com/users/mbta/following{/other_user}","gists_url":"https://api.github.com/users/mbta/gists{/gist_id}","starred_url":"https://api.github.com/users/mbta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbta/subscriptions","organizations_url":"https://api.github.com/users/mbta/orgs","repos_url":"https://api.github.com/users/mbta/repos","events_url":"https://api.github.com/users/mbta/events{/privacy}","received_events_url":"https://api.github.com/users/mbta/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mbta/dotcom","description":"mbta.com","fork":false,"url":"https://api.github.com/repos/mbta/dotcom","forks_url":"https://api.github.com/repos/mbta/dotcom/forks","keys_url":"https://api.github.com/repos/mbta/dotcom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbta/dotcom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbta/dotcom/teams","hooks_url":"https://api.github.com/repos/mbta/dotcom/hooks","issue_events_url":"https://api.github.com/repos/mbta/dotcom/issues/events{/number}","events_url":"https://api.github.com/repos/mbta/dotcom/events","assignees_url":"https://api.github.com/repos/mbta/dotcom/assignees{/user}","branches_url":"https://api.github.com/repos/mbta/dotcom/branches{/branch}","tags_url":"https://api.github.com/repos/mbta/dotcom/tags","blobs_url":"https://api.github.com/repos/mbta/dotcom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbta/dotcom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbta/dotcom/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbta/dotcom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbta/dotcom/statuses/{sha}","languages_url":"https://api.github.com/repos/mbta/dotcom/languages","stargazers_url":"https://api.github.com/repos/mbta/dotcom/stargazers","contributors_url":"https://api.github.com/repos/mbta/dotcom/contributors","subscribers_url":"https://api.github.com/repos/mbta/dotcom/subscribers","subscription_url":"https://api.github.com/repos/mbta/dotcom/subscription","commits_url":"https://api.github.com/repos/mbta/dotcom/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbta/dotcom/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbta/dotcom/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbta/dotcom/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbta/dotcom/contents/{+path}","compare_url":"https://api.github.com/repos/mbta/dotcom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbta/dotcom/merges","archive_url":"https://api.github.com/repos/mbta/dotcom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbta/dotcom/downloads","issues_url":"https://api.github.com/repos/mbta/dotcom/issues{/number}","pulls_url":"https://api.github.com/repos/mbta/dotcom/pulls{/number}","milestones_url":"https://api.github.com/repos/mbta/dotcom/milestones{/number}","notifications_url":"https://api.github.com/repos/mbta/dotcom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbta/dotcom/labels{/name}","releases_url":"https://api.github.com/repos/mbta/dotcom/releases{/id}","deployments_url":"https://api.github.com/repos/mbta/dotcom/deployments","created_at":"2019-05-29T15:24:43Z","updated_at":"2019-11-07T19:24:30Z","pushed_at":"2019-11-08T20:40:04Z","git_url":"git://github.com/mbta/dotcom.git","ssh_url":"git@github.com:mbta/dotcom.git","clone_url":"https://github.com/mbta/dotcom.git","svn_url":"https://github.com/mbta/dotcom","homepage":null,"size":1709407,"stargazers_count":17,"watchers_count":17,"language":"Elixir","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":3,"watchers":17,"default_branch":"master"}},"base":{"label":"mbta:master","ref":"master","sha":"0e6f4bcfa489e667df8f05551cf49ec54b88a729","user":{"login":"mbta","id":17993322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkzMzIy","avatar_url":"https://avatars0.githubusercontent.com/u/17993322?v=4","gravatar_id":"","url":"https://api.github.com/users/mbta","html_url":"https://github.com/mbta","followers_url":"https://api.github.com/users/mbta/followers","following_url":"https://api.github.com/users/mbta/following{/other_user}","gists_url":"https://api.github.com/users/mbta/gists{/gist_id}","starred_url":"https://api.github.com/users/mbta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbta/subscriptions","organizations_url":"https://api.github.com/users/mbta/orgs","repos_url":"https://api.github.com/users/mbta/repos","events_url":"https://api.github.com/users/mbta/events{/privacy}","received_events_url":"https://api.github.com/users/mbta/received_events","type":"Organization","site_admin":false},"repo":{"id":189251630,"node_id":"MDEwOlJlcG9zaXRvcnkxODkyNTE2MzA=","name":"dotcom","full_name":"mbta/dotcom","private":false,"owner":{"login":"mbta","id":17993322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkzMzIy","avatar_url":"https://avatars0.githubusercontent.com/u/17993322?v=4","gravatar_id":"","url":"https://api.github.com/users/mbta","html_url":"https://github.com/mbta","followers_url":"https://api.github.com/users/mbta/followers","following_url":"https://api.github.com/users/mbta/following{/other_user}","gists_url":"https://api.github.com/users/mbta/gists{/gist_id}","starred_url":"https://api.github.com/users/mbta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbta/subscriptions","organizations_url":"https://api.github.com/users/mbta/orgs","repos_url":"https://api.github.com/users/mbta/repos","events_url":"https://api.github.com/users/mbta/events{/privacy}","received_events_url":"https://api.github.com/users/mbta/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mbta/dotcom","description":"mbta.com","fork":false,"url":"https://api.github.com/repos/mbta/dotcom","forks_url":"https://api.github.com/repos/mbta/dotcom/forks","keys_url":"https://api.github.com/repos/mbta/dotcom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbta/dotcom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbta/dotcom/teams","hooks_url":"https://api.github.com/repos/mbta/dotcom/hooks","issue_events_url":"https://api.github.com/repos/mbta/dotcom/issues/events{/number}","events_url":"https://api.github.com/repos/mbta/dotcom/events","assignees_url":"https://api.github.com/repos/mbta/dotcom/assignees{/user}","branches_url":"https://api.github.com/repos/mbta/dotcom/branches{/branch}","tags_url":"https://api.github.com/repos/mbta/dotcom/tags","blobs_url":"https://api.github.com/repos/mbta/dotcom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbta/dotcom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbta/dotcom/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbta/dotcom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbta/dotcom/statuses/{sha}","languages_url":"https://api.github.com/repos/mbta/dotcom/languages","stargazers_url":"https://api.github.com/repos/mbta/dotcom/stargazers","contributors_url":"https://api.github.com/repos/mbta/dotcom/contributors","subscribers_url":"https://api.github.com/repos/mbta/dotcom/subscribers","subscription_url":"https://api.github.com/repos/mbta/dotcom/subscription","commits_url":"https://api.github.com/repos/mbta/dotcom/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbta/dotcom/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbta/dotcom/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbta/dotcom/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbta/dotcom/contents/{+path}","compare_url":"https://api.github.com/repos/mbta/dotcom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbta/dotcom/merges","archive_url":"https://api.github.com/repos/mbta/dotcom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbta/dotcom/downloads","issues_url":"https://api.github.com/repos/mbta/dotcom/issues{/number}","pulls_url":"https://api.github.com/repos/mbta/dotcom/pulls{/number}","milestones_url":"https://api.github.com/repos/mbta/dotcom/milestones{/number}","notifications_url":"https://api.github.com/repos/mbta/dotcom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbta/dotcom/labels{/name}","releases_url":"https://api.github.com/repos/mbta/dotcom/releases{/id}","deployments_url":"https://api.github.com/repos/mbta/dotcom/deployments","created_at":"2019-05-29T15:24:43Z","updated_at":"2019-11-07T19:24:30Z","pushed_at":"2019-11-08T20:40:04Z","git_url":"git://github.com/mbta/dotcom.git","ssh_url":"git@github.com:mbta/dotcom.git","clone_url":"https://github.com/mbta/dotcom.git","svn_url":"https://github.com/mbta/dotcom","homepage":null,"size":1709407,"stargazers_count":17,"watchers_count":17,"language":"Elixir","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":3,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mbta/dotcom/pulls/265"},"html":{"href":"https://github.com/mbta/dotcom/pull/265"},"issue":{"href":"https://api.github.com/repos/mbta/dotcom/issues/265"},"comments":{"href":"https://api.github.com/repos/mbta/dotcom/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/mbta/dotcom/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/mbta/dotcom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mbta/dotcom/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/mbta/dotcom/statuses/32f1834e94182a749bf524e785e1ee1514f6ac29"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"digitalcora","id":394835,"node_id":"MDQ6VXNlcjM5NDgzNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/394835?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalcora","html_url":"https://github.com/digitalcora","followers_url":"https://api.github.com/users/digitalcora/followers","following_url":"https://api.github.com/users/digitalcora/following{/other_user}","gists_url":"https://api.github.com/users/digitalcora/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalcora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalcora/subscriptions","organizations_url":"https://api.github.com/users/digitalcora/orgs","repos_url":"https://api.github.com/users/digitalcora/repos","events_url":"https://api.github.com/users/digitalcora/events{/privacy}","received_events_url":"https://api.github.com/users/digitalcora/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":32,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"digitalcora"}}