{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/iot/issues/704","repository_url":"https://api.github.com/repos/dotnet/iot","labels_url":"https://api.github.com/repos/dotnet/iot/issues/704/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/iot/issues/704/comments","events_url":"https://api.github.com/repos/dotnet/iot/issues/704/events","html_url":"https://github.com/dotnet/iot/pull/704","id":490744996,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1MjY4MjI1","number":704,"title":"Support for .netstandard2.0","user":{"login":"hugener","id":5023998,"node_id":"MDQ6VXNlcjUwMjM5OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5023998?v=4","gravatar_id":"","url":"https://api.github.com/users/hugener","html_url":"https://github.com/hugener","followers_url":"https://api.github.com/users/hugener/followers","following_url":"https://api.github.com/users/hugener/following{/other_user}","gists_url":"https://api.github.com/users/hugener/gists{/gist_id}","starred_url":"https://api.github.com/users/hugener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugener/subscriptions","organizations_url":"https://api.github.com/users/hugener/orgs","repos_url":"https://api.github.com/users/hugener/repos","events_url":"https://api.github.com/users/hugener/events{/privacy}","received_events_url":"https://api.github.com/users/hugener/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2019-09-08T11:52:55Z","updated_at":"2019-10-10T16:24:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dotnet/iot/pulls/704","html_url":"https://github.com/dotnet/iot/pull/704","diff_url":"https://github.com/dotnet/iot/pull/704.diff","patch_url":"https://github.com/dotnet/iot/pull/704.patch"},"body":"Please see the pull request as a discussion on .netstandard2.0 support. In its current state it cannot be merged and I didn't have any means for testing the changes. However, with those changes I am able to build for .netstandard2.0.\r\n- Changed TargetFramework to netstandard2.0\r\n- Added package references to: System.Buffers, System.Memory, System.Numerics.Vectors, System.Runtime.InteropServices for missing types.\r\n- Added MathEx with Clamp method as fill in for Math.Clamp, which is not available. (Copied from here: https://github.com/dotnet/corefx/blob/d58a51f911efb3c98beca21b6cf08cc703424fdf/src/Common/src/CoreLib/System/Math.cs). Might have to rethink how to do that.\r\n- Replaced MemoryMarshal.CreateReadOnlySpan and MemoryMarshal.CreateSpan with ctor call in unsafe block.\r\n- Replaced ToImmutableDictionary with new ReadOnlyDictionary.\r\n- Used array overloads of BitConverter.ToSingle since the data is already in an array and Span overloads are not available.\r\n- Used WriteByte instead of Write (Span), since it's not available.\r\n- Used AsSpan rather that implicit cast where necessary.\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/iot/issues/comments/540665071","html_url":"https://github.com/dotnet/iot/pull/704#issuecomment-540665071","issue_url":"https://api.github.com/repos/dotnet/iot/issues/704","id":540665071,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MDY2NTA3MQ==","user":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"created_at":"2019-10-10T16:24:26Z","updated_at":"2019-10-10T16:24:26Z","author_association":"MEMBER","body":"> Given that this is a project that has gone stable and is basically being tested by hobbyists, the least we could do is implement more Unit tests.\r\n\r\nTotally agree, @krwq is working on that with this PR #758, the problem is that I believe we will likely never be on a position where we will have all of the devices we have device bindings for in our test lab, so we could still add some unit test coverage that won't run in the actual hardware but there will always be that small gap for some device bindings."}}
{"actor":{"display_login":"joperezr"}}