{"action":"created","issue":{"url":"https://api.github.com/repos/pod-cast/cast-sh/issues/42","repository_url":"https://api.github.com/repos/pod-cast/cast-sh","labels_url":"https://api.github.com/repos/pod-cast/cast-sh/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/pod-cast/cast-sh/issues/42/comments","events_url":"https://api.github.com/repos/pod-cast/cast-sh/issues/42/events","html_url":"https://github.com/pod-cast/cast-sh/issues/42","id":515120332,"node_id":"MDU6SXNzdWU1MTUxMjAzMzI=","number":42,"title":"Clear closed tabs ","user":{"login":"vladdoster","id":10052309,"node_id":"MDQ6VXNlcjEwMDUyMzA5","avatar_url":"https://avatars1.githubusercontent.com/u/10052309?v=4","gravatar_id":"","url":"https://api.github.com/users/vladdoster","html_url":"https://github.com/vladdoster","followers_url":"https://api.github.com/users/vladdoster/followers","following_url":"https://api.github.com/users/vladdoster/following{/other_user}","gists_url":"https://api.github.com/users/vladdoster/gists{/gist_id}","starred_url":"https://api.github.com/users/vladdoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladdoster/subscriptions","organizations_url":"https://api.github.com/users/vladdoster/orgs","repos_url":"https://api.github.com/users/vladdoster/repos","events_url":"https://api.github.com/users/vladdoster/events{/privacy}","received_events_url":"https://api.github.com/users/vladdoster/received_events","type":"User","site_admin":false},"labels":[{"id":1505902984,"node_id":"MDU6TGFiZWwxNTA1OTAyOTg0","url":"https://api.github.com/repos/pod-cast/cast-sh/labels/enhancement","name":"enhancement","color":"a0244e","default":true}],"state":"open","locked":false,"assignee":{"login":"vladdoster","id":10052309,"node_id":"MDQ6VXNlcjEwMDUyMzA5","avatar_url":"https://avatars1.githubusercontent.com/u/10052309?v=4","gravatar_id":"","url":"https://api.github.com/users/vladdoster","html_url":"https://github.com/vladdoster","followers_url":"https://api.github.com/users/vladdoster/followers","following_url":"https://api.github.com/users/vladdoster/following{/other_user}","gists_url":"https://api.github.com/users/vladdoster/gists{/gist_id}","starred_url":"https://api.github.com/users/vladdoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladdoster/subscriptions","organizations_url":"https://api.github.com/users/vladdoster/orgs","repos_url":"https://api.github.com/users/vladdoster/repos","events_url":"https://api.github.com/users/vladdoster/events{/privacy}","received_events_url":"https://api.github.com/users/vladdoster/received_events","type":"User","site_admin":false},"assignees":[{"login":"vladdoster","id":10052309,"node_id":"MDQ6VXNlcjEwMDUyMzA5","avatar_url":"https://avatars1.githubusercontent.com/u/10052309?v=4","gravatar_id":"","url":"https://api.github.com/users/vladdoster","html_url":"https://github.com/vladdoster","followers_url":"https://api.github.com/users/vladdoster/followers","following_url":"https://api.github.com/users/vladdoster/following{/other_user}","gists_url":"https://api.github.com/users/vladdoster/gists{/gist_id}","starred_url":"https://api.github.com/users/vladdoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladdoster/subscriptions","organizations_url":"https://api.github.com/users/vladdoster/orgs","repos_url":"https://api.github.com/users/vladdoster/repos","events_url":"https://api.github.com/users/vladdoster/events{/privacy}","received_events_url":"https://api.github.com/users/vladdoster/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2019-10-31T02:51:11Z","updated_at":"2019-10-31T22:54:53Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"#### Description\r\nI promise I am going to get around to #14, but we should first tackle the hack that is tab closing. I was working on #13 and realized that tab closing is ugly and doesn't actually close the session on the back-end. I am working on the front-end/back-end code to close tabs and propagate that to the back-end.\r\n\r\nCould be seen as an attack vector.\r\n\r\n#### Screenshots\r\n![\"closed tab\" where session is still live](https://user-images.githubusercontent.com/10052309/67914741-5f43e880-fb67-11e9-812b-61c8662c0a0e.png)\r\n\r\n#### Files\r\n- [ ] app.py\r\n- [ ] app.js\r\n\r\n#### To Reproduce\r\nClose tab and check if it closed on the server.\r\n\r\n#### Tasks\r\nInclude specific tasks in the order they need to be done in. Include links to specific lines of code where the task should happen at.\r\n- [ ] Tell server to close session\r\n- [ ] Update UI\r\n- [ ] Write E2E test\r\n"},"comment":{"url":"https://api.github.com/repos/pod-cast/cast-sh/issues/comments/548600760","html_url":"https://github.com/pod-cast/cast-sh/issues/42#issuecomment-548600760","issue_url":"https://api.github.com/repos/pod-cast/cast-sh/issues/42","id":548600760,"node_id":"MDEyOklzc3VlQ29tbWVudDU0ODYwMDc2MA==","user":{"login":"hericlesme","id":30700596,"node_id":"MDQ6VXNlcjMwNzAwNTk2","avatar_url":"https://avatars2.githubusercontent.com/u/30700596?v=4","gravatar_id":"","url":"https://api.github.com/users/hericlesme","html_url":"https://github.com/hericlesme","followers_url":"https://api.github.com/users/hericlesme/followers","following_url":"https://api.github.com/users/hericlesme/following{/other_user}","gists_url":"https://api.github.com/users/hericlesme/gists{/gist_id}","starred_url":"https://api.github.com/users/hericlesme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hericlesme/subscriptions","organizations_url":"https://api.github.com/users/hericlesme/orgs","repos_url":"https://api.github.com/users/hericlesme/repos","events_url":"https://api.github.com/users/hericlesme/events{/privacy}","received_events_url":"https://api.github.com/users/hericlesme/received_events","type":"User","site_admin":false},"created_at":"2019-10-31T22:54:53Z","updated_at":"2019-10-31T22:54:53Z","author_association":"COLLABORATOR","body":">Also, you bring up a good point that I have been thinking about. The mechanism of socket triggering on every button is really slowing down the input of the user. I am thinking of an enhancement in the form of a buffer in the front-end so that the command is executed only when return is pressed. The input delay, is an issue that needs to be addressed before the software can have a functional release. Any thoughts @hericlesme ?\r\n\r\n@satanb4 Yes, I noticed that too. I want to fix it and some other things before publishing a stable release. I'll also create a new issue from this, so we can discuss it better."}}
{"actor":{"display_login":"hericlesme"}}