{"action":"created","issue":{"url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/831","repository_url":"https://api.github.com/repos/ESMValGroup/ESMValTool","labels_url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/831/labels{/name}","comments_url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/831/comments","events_url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/831/events","html_url":"https://github.com/ESMValGroup/ESMValTool/pull/831","id":407318879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwODIwMjUx","number":831,"title":"Provenance function for NCL diag_scripts","user":{"login":"LisaBock","id":25476740,"node_id":"MDQ6VXNlcjI1NDc2NzQw","avatar_url":"https://avatars1.githubusercontent.com/u/25476740?v=4","gravatar_id":"","url":"https://api.github.com/users/LisaBock","html_url":"https://github.com/LisaBock","followers_url":"https://api.github.com/users/LisaBock/followers","following_url":"https://api.github.com/users/LisaBock/following{/other_user}","gists_url":"https://api.github.com/users/LisaBock/gists{/gist_id}","starred_url":"https://api.github.com/users/LisaBock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LisaBock/subscriptions","organizations_url":"https://api.github.com/users/LisaBock/orgs","repos_url":"https://api.github.com/users/LisaBock/repos","events_url":"https://api.github.com/users/LisaBock/events{/privacy}","received_events_url":"https://api.github.com/users/LisaBock/received_events","type":"User","site_admin":false},"labels":[{"id":526450344,"node_id":"MDU6TGFiZWw1MjY0NTAzNDQ=","url":"https://api.github.com/repos/ESMValGroup/ESMValTool/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"LisaBock","id":25476740,"node_id":"MDQ6VXNlcjI1NDc2NzQw","avatar_url":"https://avatars1.githubusercontent.com/u/25476740?v=4","gravatar_id":"","url":"https://api.github.com/users/LisaBock","html_url":"https://github.com/LisaBock","followers_url":"https://api.github.com/users/LisaBock/followers","following_url":"https://api.github.com/users/LisaBock/following{/other_user}","gists_url":"https://api.github.com/users/LisaBock/gists{/gist_id}","starred_url":"https://api.github.com/users/LisaBock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LisaBock/subscriptions","organizations_url":"https://api.github.com/users/LisaBock/orgs","repos_url":"https://api.github.com/users/LisaBock/repos","events_url":"https://api.github.com/users/LisaBock/events{/privacy}","received_events_url":"https://api.github.com/users/LisaBock/received_events","type":"User","site_admin":false},"assignees":[{"login":"LisaBock","id":25476740,"node_id":"MDQ6VXNlcjI1NDc2NzQw","avatar_url":"https://avatars1.githubusercontent.com/u/25476740?v=4","gravatar_id":"","url":"https://api.github.com/users/LisaBock","html_url":"https://github.com/LisaBock","followers_url":"https://api.github.com/users/LisaBock/followers","following_url":"https://api.github.com/users/LisaBock/following{/other_user}","gists_url":"https://api.github.com/users/LisaBock/gists{/gist_id}","starred_url":"https://api.github.com/users/LisaBock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LisaBock/subscriptions","organizations_url":"https://api.github.com/users/LisaBock/orgs","repos_url":"https://api.github.com/users/LisaBock/repos","events_url":"https://api.github.com/users/LisaBock/events{/privacy}","received_events_url":"https://api.github.com/users/LisaBock/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2019-02-06T16:26:58Z","updated_at":"2019-02-14T15:39:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ESMValGroup/ESMValTool/pulls/831","html_url":"https://github.com/ESMValGroup/ESMValTool/pull/831","diff_url":"https://github.com/ESMValGroup/ESMValTool/pull/831.diff","patch_url":"https://github.com/ESMValGroup/ESMValTool/pull/831.patch"},"body":"I adapted the ESMValMD function to v2. It writes the required provenance file \"diagnostic_provenance.yml\" to the run directory.\r\nFor the moment it is applied to the examples/diagnostic.ncl diag_script (recipes/examples/recipe_ncl.yml)."},"comment":{"url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/comments/463673923","html_url":"https://github.com/ESMValGroup/ESMValTool/pull/831#issuecomment-463673923","issue_url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/831","id":463673923,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MzY3MzkyMw==","user":{"login":"axel-lauer","id":25367775,"node_id":"MDQ6VXNlcjI1MzY3Nzc1","avatar_url":"https://avatars3.githubusercontent.com/u/25367775?v=4","gravatar_id":"","url":"https://api.github.com/users/axel-lauer","html_url":"https://github.com/axel-lauer","followers_url":"https://api.github.com/users/axel-lauer/followers","following_url":"https://api.github.com/users/axel-lauer/following{/other_user}","gists_url":"https://api.github.com/users/axel-lauer/gists{/gist_id}","starred_url":"https://api.github.com/users/axel-lauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axel-lauer/subscriptions","organizations_url":"https://api.github.com/users/axel-lauer/orgs","repos_url":"https://api.github.com/users/axel-lauer/repos","events_url":"https://api.github.com/users/axel-lauer/events{/privacy}","received_events_url":"https://api.github.com/users/axel-lauer/received_events","type":"User","site_admin":false},"created_at":"2019-02-14T15:39:20Z","updated_at":"2019-02-14T15:39:20Z","author_association":"CONTRIBUTOR","body":"> > * It is not clear to me whether the tags defined in the recipe (i.e. project, main reference, authors) are automatically passed to the meta data writer. Is this the case?\r\n> > * I am missing the tags \"realm\" and \"theme\" that have to be defined in the recipe (those cannot be defined in the diagnostic as a specific diagnostic can be used for different applications, e.g. ocean, atmos, etc.). What happened to those tags?\r\n> \r\n> The tags defined in the recipe are recorded by the backend, (NCL) diagnostic code does not need to do anything with them.\r\n\r\nOK for the tags project(s), main reference(s) and author(s), but what about realm and even more importantly theme? These recipe tags have been proven useful when sorting and displaying the results with freva.\r\n\r\n> > What happens if only a plot or only a netCDF is being written? We always claimed that ESMValTool results can consist of plots and/**or** netCDF output, i.e. it is not required to have both. There are many cases in which writing both does not make any sense (e.g. simply plotting a multi-model mean calculated by the preprocessor).\r\n> \r\n> I implemented the provenance in such a way that the netcdf file is required and one optional plot can be added. This is something that can be discussed and/or changed in the future, but that is how it is now.\r\n\r\nOK, for discussion. In my opinion, all combinations of plot(s)/netcdf(s) should be supported."}}
{"actor":{"display_login":"axel-lauer"}}