{"action":"closed","number":3089,"pull_request":{"url":"https://api.github.com/repos/microsoft/terminal/pulls/3089","id":324989294,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0OTg5Mjk0","html_url":"https://github.com/microsoft/terminal/pull/3089","diff_url":"https://github.com/microsoft/terminal/pull/3089.diff","patch_url":"https://github.com/microsoft/terminal/pull/3089.patch","issue_url":"https://api.github.com/repos/microsoft/terminal/issues/3089","number":3089,"state":"closed","locked":false,"title":"Defer text buffer redrawing","user":{"login":"skyline75489","id":4710575,"node_id":"MDQ6VXNlcjQ3MTA1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/4710575?v=4","gravatar_id":"","url":"https://api.github.com/users/skyline75489","html_url":"https://github.com/skyline75489","followers_url":"https://api.github.com/users/skyline75489/followers","following_url":"https://api.github.com/users/skyline75489/following{/other_user}","gists_url":"https://api.github.com/users/skyline75489/gists{/gist_id}","starred_url":"https://api.github.com/users/skyline75489/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyline75489/subscriptions","organizations_url":"https://api.github.com/users/skyline75489/orgs","repos_url":"https://api.github.com/users/skyline75489/repos","events_url":"https://api.github.com/users/skyline75489/events{/privacy}","received_events_url":"https://api.github.com/users/skyline75489/received_events","type":"User","site_admin":false},"body":"<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->\r\n## Summary of the Pull Request\r\n\r\nThis is a draft PR that's intended to defer all kinds of redrawing.\r\n\r\n<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> \r\n## References\r\n\r\n#2960  #3075 \r\n\r\n<!-- Please review the items on the PR checklist before submitting-->\r\n## PR Checklist\r\n* [ ] Closes #xxx\r\n* [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA\r\n* [ ] Tests added/passed\r\n* [ ] Requires documentation to be updated\r\n* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx\r\n\r\n<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->\r\n## Detailed Description of the Pull Request / Additional comments\r\n\r\nComing from #2960, combined with an inspiring issue from #3075 , we are indeed doing a lot of unnecessary redrawing when there are still incoming text.\r\n\r\nI'd love to hear @miniksa 's thought on this. \r\n\r\n<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->\r\n## Validation Steps Performed\r\n","created_at":"2019-10-06T00:42:31Z","updated_at":"2019-10-11T02:15:51Z","closed_at":"2019-10-11T02:15:50Z","merged_at":null,"merge_commit_sha":"120a7156bd181ec05d3b1cb3bb166c6f54e2e76f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/terminal/pulls/3089/commits","review_comments_url":"https://api.github.com/repos/microsoft/terminal/pulls/3089/comments","review_comment_url":"https://api.github.com/repos/microsoft/terminal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/terminal/issues/3089/comments","statuses_url":"https://api.github.com/repos/microsoft/terminal/statuses/2afee728503c7b2a664b2de8adb3cc3bfe344bc8","head":{"label":"skyline75489:fix/deferOverallRedrawing","ref":"fix/deferOverallRedrawing","sha":"2afee728503c7b2a664b2de8adb3cc3bfe344bc8","user":{"login":"skyline75489","id":4710575,"node_id":"MDQ6VXNlcjQ3MTA1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/4710575?v=4","gravatar_id":"","url":"https://api.github.com/users/skyline75489","html_url":"https://github.com/skyline75489","followers_url":"https://api.github.com/users/skyline75489/followers","following_url":"https://api.github.com/users/skyline75489/following{/other_user}","gists_url":"https://api.github.com/users/skyline75489/gists{/gist_id}","starred_url":"https://api.github.com/users/skyline75489/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyline75489/subscriptions","organizations_url":"https://api.github.com/users/skyline75489/orgs","repos_url":"https://api.github.com/users/skyline75489/repos","events_url":"https://api.github.com/users/skyline75489/events{/privacy}","received_events_url":"https://api.github.com/users/skyline75489/received_events","type":"User","site_admin":false},"repo":{"id":210539335,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA1MzkzMzU=","name":"terminal","full_name":"skyline75489/terminal","private":false,"owner":{"login":"skyline75489","id":4710575,"node_id":"MDQ6VXNlcjQ3MTA1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/4710575?v=4","gravatar_id":"","url":"https://api.github.com/users/skyline75489","html_url":"https://github.com/skyline75489","followers_url":"https://api.github.com/users/skyline75489/followers","following_url":"https://api.github.com/users/skyline75489/following{/other_user}","gists_url":"https://api.github.com/users/skyline75489/gists{/gist_id}","starred_url":"https://api.github.com/users/skyline75489/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyline75489/subscriptions","organizations_url":"https://api.github.com/users/skyline75489/orgs","repos_url":"https://api.github.com/users/skyline75489/repos","events_url":"https://api.github.com/users/skyline75489/events{/privacy}","received_events_url":"https://api.github.com/users/skyline75489/received_events","type":"User","site_admin":false},"html_url":"https://github.com/skyline75489/terminal","description":"The new Windows Terminal, and the original Windows console host -- all in the same place!","fork":true,"url":"https://api.github.com/repos/skyline75489/terminal","forks_url":"https://api.github.com/repos/skyline75489/terminal/forks","keys_url":"https://api.github.com/repos/skyline75489/terminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skyline75489/terminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skyline75489/terminal/teams","hooks_url":"https://api.github.com/repos/skyline75489/terminal/hooks","issue_events_url":"https://api.github.com/repos/skyline75489/terminal/issues/events{/number}","events_url":"https://api.github.com/repos/skyline75489/terminal/events","assignees_url":"https://api.github.com/repos/skyline75489/terminal/assignees{/user}","branches_url":"https://api.github.com/repos/skyline75489/terminal/branches{/branch}","tags_url":"https://api.github.com/repos/skyline75489/terminal/tags","blobs_url":"https://api.github.com/repos/skyline75489/terminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skyline75489/terminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skyline75489/terminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/skyline75489/terminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skyline75489/terminal/statuses/{sha}","languages_url":"https://api.github.com/repos/skyline75489/terminal/languages","stargazers_url":"https://api.github.com/repos/skyline75489/terminal/stargazers","contributors_url":"https://api.github.com/repos/skyline75489/terminal/contributors","subscribers_url":"https://api.github.com/repos/skyline75489/terminal/subscribers","subscription_url":"https://api.github.com/repos/skyline75489/terminal/subscription","commits_url":"https://api.github.com/repos/skyline75489/terminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/skyline75489/terminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/skyline75489/terminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/skyline75489/terminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/skyline75489/terminal/contents/{+path}","compare_url":"https://api.github.com/repos/skyline75489/terminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skyline75489/terminal/merges","archive_url":"https://api.github.com/repos/skyline75489/terminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skyline75489/terminal/downloads","issues_url":"https://api.github.com/repos/skyline75489/terminal/issues{/number}","pulls_url":"https://api.github.com/repos/skyline75489/terminal/pulls{/number}","milestones_url":"https://api.github.com/repos/skyline75489/terminal/milestones{/number}","notifications_url":"https://api.github.com/repos/skyline75489/terminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skyline75489/terminal/labels{/name}","releases_url":"https://api.github.com/repos/skyline75489/terminal/releases{/id}","deployments_url":"https://api.github.com/repos/skyline75489/terminal/deployments","created_at":"2019-09-24T07:28:41Z","updated_at":"2019-10-10T00:33:25Z","pushed_at":"2019-10-10T00:33:17Z","git_url":"git://github.com/skyline75489/terminal.git","ssh_url":"git@github.com:skyline75489/terminal.git","clone_url":"https://github.com/skyline75489/terminal.git","svn_url":"https://github.com/skyline75489/terminal","homepage":"","size":50231,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"0691c21876229dc573a18473ca04bfc78c0d6803","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":100060912,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAwNjA5MTI=","name":"terminal","full_name":"microsoft/terminal","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/terminal","description":"The new Windows Terminal, and the original Windows console host - all in the same place!","fork":false,"url":"https://api.github.com/repos/microsoft/terminal","forks_url":"https://api.github.com/repos/microsoft/terminal/forks","keys_url":"https://api.github.com/repos/microsoft/terminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/terminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/terminal/teams","hooks_url":"https://api.github.com/repos/microsoft/terminal/hooks","issue_events_url":"https://api.github.com/repos/microsoft/terminal/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/terminal/events","assignees_url":"https://api.github.com/repos/microsoft/terminal/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/terminal/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/terminal/tags","blobs_url":"https://api.github.com/repos/microsoft/terminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/terminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/terminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/terminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/terminal/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/terminal/languages","stargazers_url":"https://api.github.com/repos/microsoft/terminal/stargazers","contributors_url":"https://api.github.com/repos/microsoft/terminal/contributors","subscribers_url":"https://api.github.com/repos/microsoft/terminal/subscribers","subscription_url":"https://api.github.com/repos/microsoft/terminal/subscription","commits_url":"https://api.github.com/repos/microsoft/terminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/terminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/terminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/terminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/terminal/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/terminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/terminal/merges","archive_url":"https://api.github.com/repos/microsoft/terminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/terminal/downloads","issues_url":"https://api.github.com/repos/microsoft/terminal/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/terminal/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/terminal/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/terminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/terminal/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/terminal/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/terminal/deployments","created_at":"2017-08-11T18:38:22Z","updated_at":"2019-10-11T02:06:42Z","pushed_at":"2019-10-11T00:51:26Z","git_url":"git://github.com/microsoft/terminal.git","ssh_url":"git@github.com:microsoft/terminal.git","clone_url":"https://github.com/microsoft/terminal.git","svn_url":"https://github.com/microsoft/terminal","homepage":"","size":50714,"stargazers_count":52972,"watchers_count":52972,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5140,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":733,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5140,"open_issues":733,"watchers":52972,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/terminal/pulls/3089"},"html":{"href":"https://github.com/microsoft/terminal/pull/3089"},"issue":{"href":"https://api.github.com/repos/microsoft/terminal/issues/3089"},"comments":{"href":"https://api.github.com/repos/microsoft/terminal/issues/3089/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/terminal/pulls/3089/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/terminal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/terminal/pulls/3089/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/terminal/statuses/2afee728503c7b2a664b2de8adb3cc3bfe344bc8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"draft","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":53,"deletions":0,"changed_files":7}}
{"actor":{"display_login":"skyline75489"}}