{"action":"created","issue":{"url":"https://api.github.com/repos/lanl/Draco/issues/600","repository_url":"https://api.github.com/repos/lanl/Draco","labels_url":"https://api.github.com/repos/lanl/Draco/issues/600/labels{/name}","comments_url":"https://api.github.com/repos/lanl/Draco/issues/600/comments","events_url":"https://api.github.com/repos/lanl/Draco/issues/600/events","html_url":"https://github.com/lanl/Draco/pull/600","id":430226287,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4MTYxMzQw","number":600,"title":"Add graphic dump reset time, to refine overwrite behavior.","user":{"login":"RyanWollaeger","id":22202519,"node_id":"MDQ6VXNlcjIyMjAyNTE5","avatar_url":"https://avatars1.githubusercontent.com/u/22202519?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanWollaeger","html_url":"https://github.com/RyanWollaeger","followers_url":"https://api.github.com/users/RyanWollaeger/followers","following_url":"https://api.github.com/users/RyanWollaeger/following{/other_user}","gists_url":"https://api.github.com/users/RyanWollaeger/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanWollaeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanWollaeger/subscriptions","organizations_url":"https://api.github.com/users/RyanWollaeger/orgs","repos_url":"https://api.github.com/users/RyanWollaeger/repos","events_url":"https://api.github.com/users/RyanWollaeger/events{/privacy}","received_events_url":"https://api.github.com/users/RyanWollaeger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"RyanWollaeger","id":22202519,"node_id":"MDQ6VXNlcjIyMjAyNTE5","avatar_url":"https://avatars1.githubusercontent.com/u/22202519?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanWollaeger","html_url":"https://github.com/RyanWollaeger","followers_url":"https://api.github.com/users/RyanWollaeger/followers","following_url":"https://api.github.com/users/RyanWollaeger/following{/other_user}","gists_url":"https://api.github.com/users/RyanWollaeger/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanWollaeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanWollaeger/subscriptions","organizations_url":"https://api.github.com/users/RyanWollaeger/orgs","repos_url":"https://api.github.com/users/RyanWollaeger/repos","events_url":"https://api.github.com/users/RyanWollaeger/events{/privacy}","received_events_url":"https://api.github.com/users/RyanWollaeger/received_events","type":"User","site_admin":false},"assignees":[{"login":"RyanWollaeger","id":22202519,"node_id":"MDQ6VXNlcjIyMjAyNTE5","avatar_url":"https://avatars1.githubusercontent.com/u/22202519?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanWollaeger","html_url":"https://github.com/RyanWollaeger","followers_url":"https://api.github.com/users/RyanWollaeger/followers","following_url":"https://api.github.com/users/RyanWollaeger/following{/other_user}","gists_url":"https://api.github.com/users/RyanWollaeger/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanWollaeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanWollaeger/subscriptions","organizations_url":"https://api.github.com/users/RyanWollaeger/orgs","repos_url":"https://api.github.com/users/RyanWollaeger/repos","events_url":"https://api.github.com/users/RyanWollaeger/events{/privacy}","received_events_url":"https://api.github.com/users/RyanWollaeger/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2019-04-08T02:14:51Z","updated_at":"2019-04-08T02:45:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lanl/Draco/pulls/600","html_url":"https://github.com/lanl/Draco/pull/600","diff_url":"https://github.com/lanl/Draco/pull/600.diff","patch_url":"https://github.com/lanl/Draco/pull/600.patch"},"body":"### Background\r\n\r\n* Ensight file generation either appends existing ensight files or fully overwrites them.\r\n* For better consistency with restart behavior, it may be worthwhile to permit partial rewriting of Ensight dump files: overwriting dumps after a time provided to the Ensight translator.\r\n*  The implementation in this PR is supposed to be flexible enough to preserve old behavior, and even permit overwriting Ensight dumps some number of cycles after a restart.\r\n\r\n### Purpose of Pull Request\r\n\r\n* Permit partial overwriting of Ensight dumps when not fully overwriting.\r\n* [Fixes Redmine Issue #1425](https://rtt.lanl.gov/redmine/issues/1425)\r\n\r\n### Description of changes\r\n\r\n+ Add optional reset time parameter to ctor of Ensight_Translator.\r\n+ Erase dump times after reset time from case file parsed in ctor.\r\n+ Update Ensight_Translator unit test to test a partial overwrite.\r\n\r\n### Status\r\n\r\n* Reference:\r\n  * [Pre-Merge Code Review](https://github.com/lanl/Draco/wiki/Style-Guide)\r\n  * [CDash Status](https://rtt.lanl.gov/cdash/index.php?project=Draco&filtercount=1&showfilters=1&field1=buildname&compare1=63&value1=-pr)\r\n* Checks\r\n  * [ ] Travis CI checks pass\r\n  * [ ] Code coverage does not decrease\r\n  * [ ] [Valgrind test passes](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [ ] [Toss3 checks pass](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [ ] [Trinitite checks pass](https://rtt.lanl.gov/CDash/index.php?project=Draco)\r\n  * [ ] Code reviewed/approved, sufficient DbC checks, testing, documentation\r\n"},"comment":{"url":"https://api.github.com/repos/lanl/Draco/issues/comments/480664499","html_url":"https://github.com/lanl/Draco/pull/600#issuecomment-480664499","issue_url":"https://api.github.com/repos/lanl/Draco/issues/600","id":480664499,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4MDY2NDQ5OQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-04-08T02:45:57Z","updated_at":"2019-04-08T02:45:57Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/lanl/Draco/pull/600?src=pr&el=h1) Report\n> Merging [#600](https://codecov.io/gh/lanl/Draco/pull/600?src=pr&el=desc) into [develop](https://codecov.io/gh/lanl/Draco/commit/2c58a420d691e24eb72ee15d307a22be7a41c788?src=pr&el=desc) will **increase** coverage by `<.1%`.\n> The diff coverage is `100%`.\n\n\n```diff\n@@            Coverage Diff            @@\n##           develop    #600     +/-   ##\n=========================================\n+ Coverage     93.7%   93.7%   +<.1%     \n=========================================\n  Files          380     380             \n  Lines        17783   17791      +8     \n=========================================\n+ Hits         16665   16673      +8     \n  Misses        1118    1118\n```\n"}}
{"actor":{"display_login":"codecov"}}