{"action":"created","comment":{"url":"https://api.github.com/repos/kpaas-io/kpaas/pulls/comments/361792341","pull_request_review_id":336913641,"id":361792341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTc5MjM0MQ==","diff_hunk":"@@ -354,15 +353,17 @@ func etcdUpAndRunning(d *deployEtcdOperation) error {\n \t}\n \tdefer cli.Close()\n \n-\t//d.logger.Debugf(\"etcd client:%#v\", cli)\n-\n \tctx, cancel := context.WithTimeout(context.Background(), time.Second*10)\n \tdefer cancel()\n \n \tresp, err := cli.MemberList(ctx)\n \n \td.logger.Debugf(\"member list done, result:%#v, error: %v\", resp, err)\n \n+\tif err != nil {","path":"pkg/deploy/operation/etcd/etcd.go","position":21,"original_position":21,"commit_id":"8a5418f57456ba41f6ca2754d8d63ed6b65be924","original_commit_id":"8a5418f57456ba41f6ca2754d8d63ed6b65be924","user":{"login":"yangruiray","id":37774269,"node_id":"MDQ6VXNlcjM3Nzc0MjY5","avatar_url":"https://avatars0.githubusercontent.com/u/37774269?v=4","gravatar_id":"","url":"https://api.github.com/users/yangruiray","html_url":"https://github.com/yangruiray","followers_url":"https://api.github.com/users/yangruiray/followers","following_url":"https://api.github.com/users/yangruiray/following{/other_user}","gists_url":"https://api.github.com/users/yangruiray/gists{/gist_id}","starred_url":"https://api.github.com/users/yangruiray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangruiray/subscriptions","organizations_url":"https://api.github.com/users/yangruiray/orgs","repos_url":"https://api.github.com/users/yangruiray/repos","events_url":"https://api.github.com/users/yangruiray/events{/privacy}","received_events_url":"https://api.github.com/users/yangruiray/received_events","type":"User","site_admin":false},"body":"这里要不要先判断 \r\n```go\r\nif err != nil {}\r\n```\r\n再 debugf","created_at":"2019-12-28T12:12:12Z","updated_at":"2019-12-28T12:13:28Z","html_url":"https://github.com/kpaas-io/kpaas/pull/139#discussion_r361792341","pull_request_url":"https://api.github.com/repos/kpaas-io/kpaas/pulls/139","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kpaas-io/kpaas/pulls/comments/361792341"},"html":{"href":"https://github.com/kpaas-io/kpaas/pull/139#discussion_r361792341"},"pull_request":{"href":"https://api.github.com/repos/kpaas-io/kpaas/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/kpaas-io/kpaas/pulls/139","id":357408757,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3NDA4NzU3","html_url":"https://github.com/kpaas-io/kpaas/pull/139","diff_url":"https://github.com/kpaas-io/kpaas/pull/139.diff","patch_url":"https://github.com/kpaas-io/kpaas/pull/139.patch","issue_url":"https://api.github.com/repos/kpaas-io/kpaas/issues/139","number":139,"state":"open","locked":false,"title":"fix(deploy/etcd): check up and running etcd bug","user":{"login":"ponypaver","id":12592690,"node_id":"MDQ6VXNlcjEyNTkyNjkw","avatar_url":"https://avatars2.githubusercontent.com/u/12592690?v=4","gravatar_id":"","url":"https://api.github.com/users/ponypaver","html_url":"https://github.com/ponypaver","followers_url":"https://api.github.com/users/ponypaver/followers","following_url":"https://api.github.com/users/ponypaver/following{/other_user}","gists_url":"https://api.github.com/users/ponypaver/gists{/gist_id}","starred_url":"https://api.github.com/users/ponypaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ponypaver/subscriptions","organizations_url":"https://api.github.com/users/ponypaver/orgs","repos_url":"https://api.github.com/users/ponypaver/repos","events_url":"https://api.github.com/users/ponypaver/events{/privacy}","received_events_url":"https://api.github.com/users/ponypaver/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-28T07:26:05Z","updated_at":"2019-12-28T12:13:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43dfbb19e1707ddd4b4d36a07c0bf3231fcdaf5d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zyseeker","id":32609289,"node_id":"MDQ6VXNlcjMyNjA5Mjg5","avatar_url":"https://avatars0.githubusercontent.com/u/32609289?v=4","gravatar_id":"","url":"https://api.github.com/users/zyseeker","html_url":"https://github.com/zyseeker","followers_url":"https://api.github.com/users/zyseeker/followers","following_url":"https://api.github.com/users/zyseeker/following{/other_user}","gists_url":"https://api.github.com/users/zyseeker/gists{/gist_id}","starred_url":"https://api.github.com/users/zyseeker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyseeker/subscriptions","organizations_url":"https://api.github.com/users/zyseeker/orgs","repos_url":"https://api.github.com/users/zyseeker/repos","events_url":"https://api.github.com/users/zyseeker/events{/privacy}","received_events_url":"https://api.github.com/users/zyseeker/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kpaas-io/kpaas/pulls/139/commits","review_comments_url":"https://api.github.com/repos/kpaas-io/kpaas/pulls/139/comments","review_comment_url":"https://api.github.com/repos/kpaas-io/kpaas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kpaas-io/kpaas/issues/139/comments","statuses_url":"https://api.github.com/repos/kpaas-io/kpaas/statuses/8a5418f57456ba41f6ca2754d8d63ed6b65be924","head":{"label":"ponypaver:master","ref":"master","sha":"8a5418f57456ba41f6ca2754d8d63ed6b65be924","user":{"login":"ponypaver","id":12592690,"node_id":"MDQ6VXNlcjEyNTkyNjkw","avatar_url":"https://avatars2.githubusercontent.com/u/12592690?v=4","gravatar_id":"","url":"https://api.github.com/users/ponypaver","html_url":"https://github.com/ponypaver","followers_url":"https://api.github.com/users/ponypaver/followers","following_url":"https://api.github.com/users/ponypaver/following{/other_user}","gists_url":"https://api.github.com/users/ponypaver/gists{/gist_id}","starred_url":"https://api.github.com/users/ponypaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ponypaver/subscriptions","organizations_url":"https://api.github.com/users/ponypaver/orgs","repos_url":"https://api.github.com/users/ponypaver/repos","events_url":"https://api.github.com/users/ponypaver/events{/privacy}","received_events_url":"https://api.github.com/users/ponypaver/received_events","type":"User","site_admin":false},"repo":{"id":222638651,"node_id":"MDEwOlJlcG9zaXRvcnkyMjI2Mzg2NTE=","name":"kpaas","full_name":"ponypaver/kpaas","private":false,"owner":{"login":"ponypaver","id":12592690,"node_id":"MDQ6VXNlcjEyNTkyNjkw","avatar_url":"https://avatars2.githubusercontent.com/u/12592690?v=4","gravatar_id":"","url":"https://api.github.com/users/ponypaver","html_url":"https://github.com/ponypaver","followers_url":"https://api.github.com/users/ponypaver/followers","following_url":"https://api.github.com/users/ponypaver/following{/other_user}","gists_url":"https://api.github.com/users/ponypaver/gists{/gist_id}","starred_url":"https://api.github.com/users/ponypaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ponypaver/subscriptions","organizations_url":"https://api.github.com/users/ponypaver/orgs","repos_url":"https://api.github.com/users/ponypaver/repos","events_url":"https://api.github.com/users/ponypaver/events{/privacy}","received_events_url":"https://api.github.com/users/ponypaver/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ponypaver/kpaas","description":null,"fork":true,"url":"https://api.github.com/repos/ponypaver/kpaas","forks_url":"https://api.github.com/repos/ponypaver/kpaas/forks","keys_url":"https://api.github.com/repos/ponypaver/kpaas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ponypaver/kpaas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ponypaver/kpaas/teams","hooks_url":"https://api.github.com/repos/ponypaver/kpaas/hooks","issue_events_url":"https://api.github.com/repos/ponypaver/kpaas/issues/events{/number}","events_url":"https://api.github.com/repos/ponypaver/kpaas/events","assignees_url":"https://api.github.com/repos/ponypaver/kpaas/assignees{/user}","branches_url":"https://api.github.com/repos/ponypaver/kpaas/branches{/branch}","tags_url":"https://api.github.com/repos/ponypaver/kpaas/tags","blobs_url":"https://api.github.com/repos/ponypaver/kpaas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ponypaver/kpaas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ponypaver/kpaas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ponypaver/kpaas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ponypaver/kpaas/statuses/{sha}","languages_url":"https://api.github.com/repos/ponypaver/kpaas/languages","stargazers_url":"https://api.github.com/repos/ponypaver/kpaas/stargazers","contributors_url":"https://api.github.com/repos/ponypaver/kpaas/contributors","subscribers_url":"https://api.github.com/repos/ponypaver/kpaas/subscribers","subscription_url":"https://api.github.com/repos/ponypaver/kpaas/subscription","commits_url":"https://api.github.com/repos/ponypaver/kpaas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ponypaver/kpaas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ponypaver/kpaas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ponypaver/kpaas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ponypaver/kpaas/contents/{+path}","compare_url":"https://api.github.com/repos/ponypaver/kpaas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ponypaver/kpaas/merges","archive_url":"https://api.github.com/repos/ponypaver/kpaas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ponypaver/kpaas/downloads","issues_url":"https://api.github.com/repos/ponypaver/kpaas/issues{/number}","pulls_url":"https://api.github.com/repos/ponypaver/kpaas/pulls{/number}","milestones_url":"https://api.github.com/repos/ponypaver/kpaas/milestones{/number}","notifications_url":"https://api.github.com/repos/ponypaver/kpaas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ponypaver/kpaas/labels{/name}","releases_url":"https://api.github.com/repos/ponypaver/kpaas/releases{/id}","deployments_url":"https://api.github.com/repos/ponypaver/kpaas/deployments","created_at":"2019-11-19T07:48:09Z","updated_at":"2019-12-28T07:50:49Z","pushed_at":"2019-12-28T07:50:47Z","git_url":"git://github.com/ponypaver/kpaas.git","ssh_url":"git@github.com:ponypaver/kpaas.git","clone_url":"https://github.com/ponypaver/kpaas.git","svn_url":"https://github.com/ponypaver/kpaas","homepage":null,"size":779,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kpaas-io:master","ref":"master","sha":"1a66bb164588f55ba7669deab85e15d9089b0992","user":{"login":"kpaas-io","id":49644279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjQ0Mjc5","avatar_url":"https://avatars3.githubusercontent.com/u/49644279?v=4","gravatar_id":"","url":"https://api.github.com/users/kpaas-io","html_url":"https://github.com/kpaas-io","followers_url":"https://api.github.com/users/kpaas-io/followers","following_url":"https://api.github.com/users/kpaas-io/following{/other_user}","gists_url":"https://api.github.com/users/kpaas-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kpaas-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpaas-io/subscriptions","organizations_url":"https://api.github.com/users/kpaas-io/orgs","repos_url":"https://api.github.com/users/kpaas-io/repos","events_url":"https://api.github.com/users/kpaas-io/events{/privacy}","received_events_url":"https://api.github.com/users/kpaas-io/received_events","type":"Organization","site_admin":false},"repo":{"id":221353554,"node_id":"MDEwOlJlcG9zaXRvcnkyMjEzNTM1NTQ=","name":"kpaas","full_name":"kpaas-io/kpaas","private":false,"owner":{"login":"kpaas-io","id":49644279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjQ0Mjc5","avatar_url":"https://avatars3.githubusercontent.com/u/49644279?v=4","gravatar_id":"","url":"https://api.github.com/users/kpaas-io","html_url":"https://github.com/kpaas-io","followers_url":"https://api.github.com/users/kpaas-io/followers","following_url":"https://api.github.com/users/kpaas-io/following{/other_user}","gists_url":"https://api.github.com/users/kpaas-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kpaas-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpaas-io/subscriptions","organizations_url":"https://api.github.com/users/kpaas-io/orgs","repos_url":"https://api.github.com/users/kpaas-io/repos","events_url":"https://api.github.com/users/kpaas-io/events{/privacy}","received_events_url":"https://api.github.com/users/kpaas-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kpaas-io/kpaas","description":"Provide RESTful APIs and manage cluster services","fork":false,"url":"https://api.github.com/repos/kpaas-io/kpaas","forks_url":"https://api.github.com/repos/kpaas-io/kpaas/forks","keys_url":"https://api.github.com/repos/kpaas-io/kpaas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kpaas-io/kpaas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kpaas-io/kpaas/teams","hooks_url":"https://api.github.com/repos/kpaas-io/kpaas/hooks","issue_events_url":"https://api.github.com/repos/kpaas-io/kpaas/issues/events{/number}","events_url":"https://api.github.com/repos/kpaas-io/kpaas/events","assignees_url":"https://api.github.com/repos/kpaas-io/kpaas/assignees{/user}","branches_url":"https://api.github.com/repos/kpaas-io/kpaas/branches{/branch}","tags_url":"https://api.github.com/repos/kpaas-io/kpaas/tags","blobs_url":"https://api.github.com/repos/kpaas-io/kpaas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kpaas-io/kpaas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kpaas-io/kpaas/git/refs{/sha}","trees_url":"https://api.github.com/repos/kpaas-io/kpaas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kpaas-io/kpaas/statuses/{sha}","languages_url":"https://api.github.com/repos/kpaas-io/kpaas/languages","stargazers_url":"https://api.github.com/repos/kpaas-io/kpaas/stargazers","contributors_url":"https://api.github.com/repos/kpaas-io/kpaas/contributors","subscribers_url":"https://api.github.com/repos/kpaas-io/kpaas/subscribers","subscription_url":"https://api.github.com/repos/kpaas-io/kpaas/subscription","commits_url":"https://api.github.com/repos/kpaas-io/kpaas/commits{/sha}","git_commits_url":"https://api.github.com/repos/kpaas-io/kpaas/git/commits{/sha}","comments_url":"https://api.github.com/repos/kpaas-io/kpaas/comments{/number}","issue_comment_url":"https://api.github.com/repos/kpaas-io/kpaas/issues/comments{/number}","contents_url":"https://api.github.com/repos/kpaas-io/kpaas/contents/{+path}","compare_url":"https://api.github.com/repos/kpaas-io/kpaas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kpaas-io/kpaas/merges","archive_url":"https://api.github.com/repos/kpaas-io/kpaas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kpaas-io/kpaas/downloads","issues_url":"https://api.github.com/repos/kpaas-io/kpaas/issues{/number}","pulls_url":"https://api.github.com/repos/kpaas-io/kpaas/pulls{/number}","milestones_url":"https://api.github.com/repos/kpaas-io/kpaas/milestones{/number}","notifications_url":"https://api.github.com/repos/kpaas-io/kpaas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kpaas-io/kpaas/labels{/name}","releases_url":"https://api.github.com/repos/kpaas-io/kpaas/releases{/id}","deployments_url":"https://api.github.com/repos/kpaas-io/kpaas/deployments","created_at":"2019-11-13T02:16:51Z","updated_at":"2019-12-27T17:48:17Z","pushed_at":"2019-12-28T07:50:49Z","git_url":"git://github.com/kpaas-io/kpaas.git","ssh_url":"git@github.com:kpaas-io/kpaas.git","clone_url":"https://github.com/kpaas-io/kpaas.git","svn_url":"https://github.com/kpaas-io/kpaas","homepage":"","size":775,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kpaas-io/kpaas/pulls/139"},"html":{"href":"https://github.com/kpaas-io/kpaas/pull/139"},"issue":{"href":"https://api.github.com/repos/kpaas-io/kpaas/issues/139"},"comments":{"href":"https://api.github.com/repos/kpaas-io/kpaas/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/kpaas-io/kpaas/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/kpaas-io/kpaas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kpaas-io/kpaas/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/kpaas-io/kpaas/statuses/8a5418f57456ba41f6ca2754d8d63ed6b65be924"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yangruiray"}}