{"action":"created","issue":{"url":"https://api.github.com/repos/gardener/gardener/issues/1430","repository_url":"https://api.github.com/repos/gardener/gardener","labels_url":"https://api.github.com/repos/gardener/gardener/issues/1430/labels{/name}","comments_url":"https://api.github.com/repos/gardener/gardener/issues/1430/comments","events_url":"https://api.github.com/repos/gardener/gardener/issues/1430/events","html_url":"https://github.com/gardener/gardener/pull/1430","id":494016754,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3ODUzMzMx","number":1430,"title":"New `core.gardener.cloud/v1alpha1.Shoot` resource","user":{"login":"rfranzke","id":19169361,"node_id":"MDQ6VXNlcjE5MTY5MzYx","avatar_url":"https://avatars1.githubusercontent.com/u/19169361?v=4","gravatar_id":"","url":"https://api.github.com/users/rfranzke","html_url":"https://github.com/rfranzke","followers_url":"https://api.github.com/users/rfranzke/followers","following_url":"https://api.github.com/users/rfranzke/following{/other_user}","gists_url":"https://api.github.com/users/rfranzke/gists{/gist_id}","starred_url":"https://api.github.com/users/rfranzke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfranzke/subscriptions","organizations_url":"https://api.github.com/users/rfranzke/orgs","repos_url":"https://api.github.com/users/rfranzke/repos","events_url":"https://api.github.com/users/rfranzke/events{/privacy}","received_events_url":"https://api.github.com/users/rfranzke/received_events","type":"User","site_admin":false},"labels":[{"id":943536012,"node_id":"MDU6TGFiZWw5NDM1MzYwMTI=","url":"https://api.github.com/repos/gardener/gardener/labels/needs/ok-to-test","name":"needs/ok-to-test","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-09-16T12:24:46Z","updated_at":"2019-09-17T14:59:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/gardener/gardener/pulls/1430","html_url":"https://github.com/gardener/gardener/pull/1430","diff_url":"https://github.com/gardener/gardener/pull/1430.diff","patch_url":"https://github.com/gardener/gardener/pull/1430.patch"},"body":"**What this PR does / why we need it**:\r\nThis PR creates the new `core.gardener.cloud/v1alpha1.Shoot` resource together with forwards and backwards compatibility compared to the current `garden.sapcloud.io/v1beta1.Shoot` resources, based on [GEP-4](#1284).\r\n\r\n**Special notes for your reviewer**:\r\n* Part of #1376\r\n* The gardener-controller-manager is still working on `garden.sapcloud.io/v1beta1.Shoot`, I suggest to not change this until we have introduced all resources in the new `core` API group and then change the GCM to use this API group in one go.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your release note in the below block.\r\n2. If no release note is required, just write \"NONE\" within the block.\r\n\r\nFormat of block header: <category> <target_group>\r\nPossible values:\r\n- category:       improvement|noteworthy|action\r\n- target_group:   user|operator|developer\r\n-->\r\n```noteworthy developer\r\nThe `garden.sapcloud.io.CIDR` and `garden.sapcloud.io/v1beta1.CIDR` type has been replaced with `string` type.\r\n```\r\n```noteworthy developer\r\nThe `.spec.kubernetes.kubeAPIServer.admissionPlugins[].config` type has been changed from `*string` to `*ProviderConfig` (which effectively is a `*runtime.RawExtension`).\r\n```\r\n```noteworthy user\r\nThe deprecated `.spec.backup` section in the `garden.sapcloud.io/v1beta1.Shoot` resource has been removed.\r\n```\r\n```noteworthy user\r\nIt is now possible to specify a CA certificate bundle per worker pool. Gardener will automatically install the CA certificates on every worker node of this pool.\r\n```\r\n```noteworthy operator\r\nIt is now possible to configure which domains shall be included or excluded for DNS providers. If you are using a custom domain for your shoot then you can use `.spec.dns.includeDomains`, `.spec.dns.excludeDomains`.\r\n```\r\n```noteworthy user\r\nGardener does now feature a new `Shoot` resource which is part of the `core.gardener.cloud/v1alpha1` API group. It is fully forwards and backwards compatible to the old `Shoot` resource in the `garden.sapcloud.io/v1beta1` API group. It will be the new default, and the old `garden.sapcloud.io/v1beta1.Shoot` resource are deprecated now. It will be removed in a future version. Consider switching to using the new `core.gardener.cloud/v1alpha1.Shoot` resource. The `example` directory contains proper example manifests.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/gardener/gardener/issues/comments/532260255","html_url":"https://github.com/gardener/gardener/pull/1430#issuecomment-532260255","issue_url":"https://api.github.com/repos/gardener/gardener/issues/1430","id":532260255,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMjI2MDI1NQ==","user":{"login":"ialidzhikov","id":9372594,"node_id":"MDQ6VXNlcjkzNzI1OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9372594?v=4","gravatar_id":"","url":"https://api.github.com/users/ialidzhikov","html_url":"https://github.com/ialidzhikov","followers_url":"https://api.github.com/users/ialidzhikov/followers","following_url":"https://api.github.com/users/ialidzhikov/following{/other_user}","gists_url":"https://api.github.com/users/ialidzhikov/gists{/gist_id}","starred_url":"https://api.github.com/users/ialidzhikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ialidzhikov/subscriptions","organizations_url":"https://api.github.com/users/ialidzhikov/orgs","repos_url":"https://api.github.com/users/ialidzhikov/repos","events_url":"https://api.github.com/users/ialidzhikov/events{/privacy}","received_events_url":"https://api.github.com/users/ialidzhikov/received_events","type":"User","site_admin":false},"created_at":"2019-09-17T14:59:13Z","updated_at":"2019-09-17T14:59:13Z","author_association":"MEMBER","body":"During Shoot deletion gcm fails with  `Failed to updated Shoot [..]. is invalid spec: field is immutable` and after a successful deletion the Shoot is not removed from the etcd. Are you able to reproduce this behaviour?"}}
{"actor":{"display_login":"ialidzhikov"}}