{"action":"created","issue":{"url":"https://api.github.com/repos/jwilm/alacritty/issues/3127","repository_url":"https://api.github.com/repos/jwilm/alacritty","labels_url":"https://api.github.com/repos/jwilm/alacritty/issues/3127/labels{/name}","comments_url":"https://api.github.com/repos/jwilm/alacritty/issues/3127/comments","events_url":"https://api.github.com/repos/jwilm/alacritty/issues/3127/events","html_url":"https://github.com/jwilm/alacritty/pull/3127","id":542870441,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3MjI4OTk3","number":3127,"title":"[WIP] Add windows font fallbacks","user":{"login":"davidhewitt","id":1939362,"node_id":"MDQ6VXNlcjE5MzkzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1939362?v=4","gravatar_id":"","url":"https://api.github.com/users/davidhewitt","html_url":"https://github.com/davidhewitt","followers_url":"https://api.github.com/users/davidhewitt/followers","following_url":"https://api.github.com/users/davidhewitt/following{/other_user}","gists_url":"https://api.github.com/users/davidhewitt/gists{/gist_id}","starred_url":"https://api.github.com/users/davidhewitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidhewitt/subscriptions","organizations_url":"https://api.github.com/users/davidhewitt/orgs","repos_url":"https://api.github.com/users/davidhewitt/repos","events_url":"https://api.github.com/users/davidhewitt/events{/privacy}","received_events_url":"https://api.github.com/users/davidhewitt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2019-12-27T13:09:06Z","updated_at":"2019-12-29T10:55:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jwilm/alacritty/pulls/3127","html_url":"https://github.com/jwilm/alacritty/pull/3127","diff_url":"https://github.com/jwilm/alacritty/pull/3127.diff","patch_url":"https://github.com/jwilm/alacritty/pull/3127.patch"},"body":"This is the first step for #3082\r\n\r\nAt the moment Alacritty on windows does not use any font fallbacks, so glyphs for emoji cannot be found. I suspect there are many other cases where lack of font fallbacks causes glyphs to be missing.\r\n\r\nBy adding font fallbacks, we now can rasterize (downsampled) greyscale emoji. They don't look amazing, but hey, something is better than nothing!\r\n\r\nThe remaining step to add full emoji support is to implement color font rasterizing, which will be a much bigger change and might need upstream support in the `dwrote` crate.\r\n\r\nPerhaps others may have ideas how to improve the render quality of these greyscale emojis too.\r\n\r\nIf this PR looks like the right direction to be heading, there's a couple of things for me to finish off:\r\n- [ ] Remove hard-coding of \"en-us\" locale\r\n- [ ] Try to find fallback font in loaded fonts rather than always creating fresh\r\n\r\nBefore:\r\n\r\n![image](https://user-images.githubusercontent.com/1939362/71518263-e7b1e180-28a9-11ea-8be5-cf41af80e320.png)\r\n\r\nAfter:\r\n\r\n![image](https://user-images.githubusercontent.com/1939362/71518208-ac171780-28a9-11ea-891e-2c5c6202d905.png)\r\n"},"comment":{"url":"https://api.github.com/repos/jwilm/alacritty/issues/comments/569494367","html_url":"https://github.com/jwilm/alacritty/pull/3127#issuecomment-569494367","issue_url":"https://api.github.com/repos/jwilm/alacritty/issues/3127","id":569494367,"node_id":"MDEyOklzc3VlQ29tbWVudDU2OTQ5NDM2Nw==","user":{"login":"davidhewitt","id":1939362,"node_id":"MDQ6VXNlcjE5MzkzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1939362?v=4","gravatar_id":"","url":"https://api.github.com/users/davidhewitt","html_url":"https://github.com/davidhewitt","followers_url":"https://api.github.com/users/davidhewitt/followers","following_url":"https://api.github.com/users/davidhewitt/following{/other_user}","gists_url":"https://api.github.com/users/davidhewitt/gists{/gist_id}","starred_url":"https://api.github.com/users/davidhewitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidhewitt/subscriptions","organizations_url":"https://api.github.com/users/davidhewitt/orgs","repos_url":"https://api.github.com/users/davidhewitt/repos","events_url":"https://api.github.com/users/davidhewitt/events{/privacy}","received_events_url":"https://api.github.com/users/davidhewitt/received_events","type":"User","site_admin":false},"created_at":"2019-12-29T10:55:16Z","updated_at":"2019-12-29T10:55:16Z","author_association":"CONTRIBUTOR","body":"> Yeah, ConPty + Windows 10. Windows just decides to strip emojis sometime from input and paste random things in alacritty.\r\n\r\nWeird, that would be worth investigating as a separate issue perhaps. Might be a clipboard bug our side, or ConPTY bug to report upstream. Paste _seems_ to be working for me. For now I've just manually created a text file in VSCode which has a bunch of emoji in it, and just displaying that with `cat`.\r\n\r\n> since I'm getting missing glyphs symbols, followed by emoji in some cases in other just missing glyph symbol.\r\n\r\nI _occasionally_ get a missing glyph symbol which disappears on a resize. To me that suggests an upstream bug in ConPTY. (I'll try to debug that.)"}}
{"actor":{"display_login":"davidhewitt"}}