{"action":"closed","number":360,"pull_request":{"url":"https://api.github.com/repos/dojo/framework/pulls/360","id":283809975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzODA5OTc1","html_url":"https://github.com/dojo/framework/pull/360","diff_url":"https://github.com/dojo/framework/pull/360.diff","patch_url":"https://github.com/dojo/framework/pull/360.patch","issue_url":"https://api.github.com/repos/dojo/framework/issues/360","number":360,"state":"closed","locked":false,"title":"Consolidate functionality across core into single module (vdom.ts)","user":{"login":"agubler","id":1982678,"node_id":"MDQ6VXNlcjE5ODI2Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1982678?v=4","gravatar_id":"","url":"https://api.github.com/users/agubler","html_url":"https://github.com/agubler","followers_url":"https://api.github.com/users/agubler/followers","following_url":"https://api.github.com/users/agubler/following{/other_user}","gists_url":"https://api.github.com/users/agubler/gists{/gist_id}","starred_url":"https://api.github.com/users/agubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agubler/subscriptions","organizations_url":"https://api.github.com/users/agubler/orgs","repos_url":"https://api.github.com/users/agubler/repos","events_url":"https://api.github.com/users/agubler/events{/privacy}","received_events_url":"https://api.github.com/users/agubler/received_events","type":"User","site_admin":false},"body":"**Type:** feature\r\n\r\nThe following has been addressed in the PR:\r\n\r\n* [ ] There is a related issue\r\n* [x] All code has been formatted with [`prettier`](https://prettier.io/) as per the [readme code style guidelines](./../#code-style)\r\n* [x] Unit or Functional tests are included in the PR\r\n\r\n**Description:**\r\n\r\nAfter merging `widget-core` with `core`, this change colocates all the functionality required to build and use Dojo widgets into a single module, `vdom.ts`. The driver for this is not having a sane place to put the new `create` factory for functional widgets and middleware. Also to reduce the minumum number of modules a user needs to import for Dojo.\r\n\r\n*Before*\r\n\r\n```ts\r\nimport { renderer, create } from '@dojo/framework/core/vdom';\r\nimport { v, w } from '@dojo/framework/core/d';\r\nimport { tsx } from '@dojo/framework/core/tsx';\r\n```\r\n\r\n*After*\r\n\r\n```ts\r\nimport { renderer, create, v, w, tsx } from '@dojo/framework/core/vdom';\r\n```\r\n\r\nNote: This will require some additional work for the `@dojo/cli-upgrade-app` to seamlessly migrate user codebases to the new imports.","created_at":"2019-05-30T20:55:57Z","updated_at":"2019-05-31T11:34:41Z","closed_at":"2019-05-31T11:34:40Z","merged_at":"2019-05-31T11:34:40Z","merge_commit_sha":"5ac12e5d784d44b903fbdde27870b304a43682bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dojo/framework/pulls/360/commits","review_comments_url":"https://api.github.com/repos/dojo/framework/pulls/360/comments","review_comment_url":"https://api.github.com/repos/dojo/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/framework/issues/360/comments","statuses_url":"https://api.github.com/repos/dojo/framework/statuses/0a6b88a6358adbb9081eb8593374654690c44563","head":{"label":"agubler:move-core-functions-to-vdom","ref":"move-core-functions-to-vdom","sha":"0a6b88a6358adbb9081eb8593374654690c44563","user":{"login":"agubler","id":1982678,"node_id":"MDQ6VXNlcjE5ODI2Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1982678?v=4","gravatar_id":"","url":"https://api.github.com/users/agubler","html_url":"https://github.com/agubler","followers_url":"https://api.github.com/users/agubler/followers","following_url":"https://api.github.com/users/agubler/following{/other_user}","gists_url":"https://api.github.com/users/agubler/gists{/gist_id}","starred_url":"https://api.github.com/users/agubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agubler/subscriptions","organizations_url":"https://api.github.com/users/agubler/orgs","repos_url":"https://api.github.com/users/agubler/repos","events_url":"https://api.github.com/users/agubler/events{/privacy}","received_events_url":"https://api.github.com/users/agubler/received_events","type":"User","site_admin":false},"repo":{"id":141267913,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNjc5MTM=","name":"framework","full_name":"agubler/framework","private":false,"owner":{"login":"agubler","id":1982678,"node_id":"MDQ6VXNlcjE5ODI2Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1982678?v=4","gravatar_id":"","url":"https://api.github.com/users/agubler","html_url":"https://github.com/agubler","followers_url":"https://api.github.com/users/agubler/followers","following_url":"https://api.github.com/users/agubler/following{/other_user}","gists_url":"https://api.github.com/users/agubler/gists{/gist_id}","starred_url":"https://api.github.com/users/agubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agubler/subscriptions","organizations_url":"https://api.github.com/users/agubler/orgs","repos_url":"https://api.github.com/users/agubler/repos","events_url":"https://api.github.com/users/agubler/events{/privacy}","received_events_url":"https://api.github.com/users/agubler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/agubler/framework","description":null,"fork":true,"url":"https://api.github.com/repos/agubler/framework","forks_url":"https://api.github.com/repos/agubler/framework/forks","keys_url":"https://api.github.com/repos/agubler/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agubler/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agubler/framework/teams","hooks_url":"https://api.github.com/repos/agubler/framework/hooks","issue_events_url":"https://api.github.com/repos/agubler/framework/issues/events{/number}","events_url":"https://api.github.com/repos/agubler/framework/events","assignees_url":"https://api.github.com/repos/agubler/framework/assignees{/user}","branches_url":"https://api.github.com/repos/agubler/framework/branches{/branch}","tags_url":"https://api.github.com/repos/agubler/framework/tags","blobs_url":"https://api.github.com/repos/agubler/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agubler/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agubler/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/agubler/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agubler/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/agubler/framework/languages","stargazers_url":"https://api.github.com/repos/agubler/framework/stargazers","contributors_url":"https://api.github.com/repos/agubler/framework/contributors","subscribers_url":"https://api.github.com/repos/agubler/framework/subscribers","subscription_url":"https://api.github.com/repos/agubler/framework/subscription","commits_url":"https://api.github.com/repos/agubler/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/agubler/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/agubler/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/agubler/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/agubler/framework/contents/{+path}","compare_url":"https://api.github.com/repos/agubler/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agubler/framework/merges","archive_url":"https://api.github.com/repos/agubler/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agubler/framework/downloads","issues_url":"https://api.github.com/repos/agubler/framework/issues{/number}","pulls_url":"https://api.github.com/repos/agubler/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/agubler/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/agubler/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agubler/framework/labels{/name}","releases_url":"https://api.github.com/repos/agubler/framework/releases{/id}","deployments_url":"https://api.github.com/repos/agubler/framework/deployments","created_at":"2018-07-17T09:41:09Z","updated_at":"2018-07-17T09:41:12Z","pushed_at":"2019-05-30T21:11:54Z","git_url":"git://github.com/agubler/framework.git","ssh_url":"git@github.com:agubler/framework.git","clone_url":"https://github.com/agubler/framework.git","svn_url":"https://github.com/agubler/framework","homepage":null,"size":9459,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"c1bed6195106be0c4221f326c01f0b331c819be0","user":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":140325971,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMjU5NzE=","name":"framework","full_name":"dojo/framework","private":false,"owner":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dojo/framework","description":"Dojo Framework. A Progressive Framework for Modern Web Apps","fork":false,"url":"https://api.github.com/repos/dojo/framework","forks_url":"https://api.github.com/repos/dojo/framework/forks","keys_url":"https://api.github.com/repos/dojo/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/framework/teams","hooks_url":"https://api.github.com/repos/dojo/framework/hooks","issue_events_url":"https://api.github.com/repos/dojo/framework/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/framework/events","assignees_url":"https://api.github.com/repos/dojo/framework/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/framework/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/framework/tags","blobs_url":"https://api.github.com/repos/dojo/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/framework/languages","stargazers_url":"https://api.github.com/repos/dojo/framework/stargazers","contributors_url":"https://api.github.com/repos/dojo/framework/contributors","subscribers_url":"https://api.github.com/repos/dojo/framework/subscribers","subscription_url":"https://api.github.com/repos/dojo/framework/subscription","commits_url":"https://api.github.com/repos/dojo/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/framework/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/framework/merges","archive_url":"https://api.github.com/repos/dojo/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/framework/downloads","issues_url":"https://api.github.com/repos/dojo/framework/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/framework/labels{/name}","releases_url":"https://api.github.com/repos/dojo/framework/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/framework/deployments","created_at":"2018-07-09T18:22:34Z","updated_at":"2019-05-30T20:49:12Z","pushed_at":"2019-05-31T11:34:40Z","git_url":"git://github.com/dojo/framework.git","ssh_url":"git@github.com:dojo/framework.git","clone_url":"https://github.com/dojo/framework.git","svn_url":"https://github.com/dojo/framework","homepage":"https://dojo.io/","size":8834,"stargazers_count":150,"watchers_count":150,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":49,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":35,"open_issues":49,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/framework/pulls/360"},"html":{"href":"https://github.com/dojo/framework/pull/360"},"issue":{"href":"https://api.github.com/repos/dojo/framework/issues/360"},"comments":{"href":"https://api.github.com/repos/dojo/framework/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/framework/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/framework/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/framework/statuses/0a6b88a6358adbb9081eb8593374654690c44563"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"agubler","id":1982678,"node_id":"MDQ6VXNlcjE5ODI2Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1982678?v=4","gravatar_id":"","url":"https://api.github.com/users/agubler","html_url":"https://github.com/agubler","followers_url":"https://api.github.com/users/agubler/followers","following_url":"https://api.github.com/users/agubler/following{/other_user}","gists_url":"https://api.github.com/users/agubler/gists{/gist_id}","starred_url":"https://api.github.com/users/agubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agubler/subscriptions","organizations_url":"https://api.github.com/users/agubler/orgs","repos_url":"https://api.github.com/users/agubler/repos","events_url":"https://api.github.com/users/agubler/events{/privacy}","received_events_url":"https://api.github.com/users/agubler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":367,"deletions":440,"changed_files":57}}
{"actor":{"display_login":"agubler"}}