{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLiberty/docs/pulls/comments/349517075","pull_request_review_id":321441051,"id":349517075,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0OTUxNzA3NQ==","diff_hunk":"@@ -25,15 +25,15 @@ A self-check can assess anything that the service needs:\n \n Services report as either `UP` (available) or `DOWN` (unavailable) by implementing the API provided by MicroProfile Health. A service orchestrator can then use these status reports to decide how to manage and scale the services within an application. Health checks can also interact directly with link:https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/[Kubernetes liveness and readiness probes].\n \n-For example, in a microservices-based banking application, health checks might be implemented on the login service, the balance transfer service, and the bill pay service. If a health check on the balance transfer service detects a bug or deadlock, it reports as DOWN. In this case, if the `/health/live` endpoint is configured in a Kubernetes liveness probe, the probe restarts the service automatically, saving the user from encountering downtime or an error and preserving the functions of the other services in the application.\n+For example, in a microservices-based banking application, you might implement health checks on the login service, the balance transfer service, and the bill pay service. If a health check on the balance transfer service detects a bug or deadlock, it reports as DOWN. In this case, if the `/health/live` endpoint is configured in a Kubernetes liveness probe, the probe restarts the service automatically. This feature saves the user from encountering downtime or an error and preserves the functions of the other services in the application.\n \n == MicroProfile Health provided endpoints and annotations\n \n-MicroProfile Health provides three endpoints:\n+MicroProfile Health provides the following three endpoints:\n \n - `/health/ready`: returns the readiness of a service, or whether it is ready to process requests. This endpoint corresponds to the Kubernetes readiness probe.\n-- `/health/live`: returns the liveness of a service, or whether it has encountered a bug or deadlock. If this check fails, the service is not running and can be terminated. This endpoint corresponds to the Kubernetes liveness probe, which automatically restarts the pod if the check fails.\n-- `/health`: aggregates the responses from `/health/live` and `/health/ready`. This endpoint corresponds to the deprecated `@Health` annotation and is only available to provide compatibility with MicroProfile 1.0. Developers who are using MicroProfile 2.0 or higher should use the `/health/ready` or `/health/live` endpoints instead.\n+- `/health/live`: returns the liveness of a service, or whether it encountered a bug or deadlock. If this check fails, the service is not running and can be stopped. This endpoint corresponds to the Kubernetes liveness probe, which automatically restarts the pod if the check fails.\n+- `/health`: aggregates the responses from `/health/live` and `/health/ready`. This endpoint corresponds to the deprecated `@Health` annotation and is only available to provide compatibility with MicroProfile 1.0. Developers who are using MicroProfile 2.0 or higher can use the `/health/ready` or `/health/live` endpoints instead.","path":"ref/general/health-check-microservices.adoc","position":31,"original_position":31,"commit_id":"ffeda6dd4b0d0a84603ed88be884ca080dc38ea1","original_commit_id":"ffeda6dd4b0d0a84603ed88be884ca080dc38ea1","user":{"login":"lauracowen","id":3322532,"node_id":"MDQ6VXNlcjMzMjI1MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3322532?v=4","gravatar_id":"","url":"https://api.github.com/users/lauracowen","html_url":"https://github.com/lauracowen","followers_url":"https://api.github.com/users/lauracowen/followers","following_url":"https://api.github.com/users/lauracowen/following{/other_user}","gists_url":"https://api.github.com/users/lauracowen/gists{/gist_id}","starred_url":"https://api.github.com/users/lauracowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauracowen/subscriptions","organizations_url":"https://api.github.com/users/lauracowen/orgs","repos_url":"https://api.github.com/users/lauracowen/repos","events_url":"https://api.github.com/users/lauracowen/events{/privacy}","received_events_url":"https://api.github.com/users/lauracowen/received_events","type":"User","site_admin":false},"body":"\"should\" is the right word here. We don't want developers who are able to use MP2.0 using the old endpoints. We can't say \"must\" because that would raise the question of \"or else what?\". Alternatively rephrase the sentence to \"If you are using MP 2 or higher, use the ....endpoints instead.\" (actually I prefer that)","created_at":"2019-11-22T10:01:09Z","updated_at":"2019-11-22T10:01:09Z","html_url":"https://github.com/OpenLiberty/docs/pull/805#discussion_r349517075","pull_request_url":"https://api.github.com/repos/OpenLiberty/docs/pulls/805","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/docs/pulls/comments/349517075"},"html":{"href":"https://github.com/OpenLiberty/docs/pull/805#discussion_r349517075"},"pull_request":{"href":"https://api.github.com/repos/OpenLiberty/docs/pulls/805"}}},"pull_request":{"url":"https://api.github.com/repos/OpenLiberty/docs/pulls/805","id":342884161,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyODg0MTYx","html_url":"https://github.com/OpenLiberty/docs/pull/805","diff_url":"https://github.com/OpenLiberty/docs/pull/805.diff","patch_url":"https://github.com/OpenLiberty/docs/pull/805.patch","issue_url":"https://api.github.com/repos/OpenLiberty/docs/issues/805","number":805,"state":"open","locked":false,"title":"Mueller 607 updates","user":{"login":"dmuelle","id":48686014,"node_id":"MDQ6VXNlcjQ4Njg2MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/48686014?v=4","gravatar_id":"","url":"https://api.github.com/users/dmuelle","html_url":"https://github.com/dmuelle","followers_url":"https://api.github.com/users/dmuelle/followers","following_url":"https://api.github.com/users/dmuelle/following{/other_user}","gists_url":"https://api.github.com/users/dmuelle/gists{/gist_id}","starred_url":"https://api.github.com/users/dmuelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmuelle/subscriptions","organizations_url":"https://api.github.com/users/dmuelle/orgs","repos_url":"https://api.github.com/users/dmuelle/repos","events_url":"https://api.github.com/users/dmuelle/events{/privacy}","received_events_url":"https://api.github.com/users/dmuelle/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-19T20:49:40Z","updated_at":"2019-11-22T10:01:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec8826b08d9938a73d1d0284fb9ce8660eea48e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenLiberty/docs/pulls/805/commits","review_comments_url":"https://api.github.com/repos/OpenLiberty/docs/pulls/805/comments","review_comment_url":"https://api.github.com/repos/OpenLiberty/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLiberty/docs/issues/805/comments","statuses_url":"https://api.github.com/repos/OpenLiberty/docs/statuses/ffeda6dd4b0d0a84603ed88be884ca080dc38ea1","head":{"label":"dmuelle:mueller-607-updates","ref":"mueller-607-updates","sha":"ffeda6dd4b0d0a84603ed88be884ca080dc38ea1","user":{"login":"dmuelle","id":48686014,"node_id":"MDQ6VXNlcjQ4Njg2MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/48686014?v=4","gravatar_id":"","url":"https://api.github.com/users/dmuelle","html_url":"https://github.com/dmuelle","followers_url":"https://api.github.com/users/dmuelle/followers","following_url":"https://api.github.com/users/dmuelle/following{/other_user}","gists_url":"https://api.github.com/users/dmuelle/gists{/gist_id}","starred_url":"https://api.github.com/users/dmuelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmuelle/subscriptions","organizations_url":"https://api.github.com/users/dmuelle/orgs","repos_url":"https://api.github.com/users/dmuelle/repos","events_url":"https://api.github.com/users/dmuelle/events{/privacy}","received_events_url":"https://api.github.com/users/dmuelle/received_events","type":"User","site_admin":false},"repo":{"id":221961545,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE5NjE1NDU=","name":"docs","full_name":"dmuelle/docs","private":false,"owner":{"login":"dmuelle","id":48686014,"node_id":"MDQ6VXNlcjQ4Njg2MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/48686014?v=4","gravatar_id":"","url":"https://api.github.com/users/dmuelle","html_url":"https://github.com/dmuelle","followers_url":"https://api.github.com/users/dmuelle/followers","following_url":"https://api.github.com/users/dmuelle/following{/other_user}","gists_url":"https://api.github.com/users/dmuelle/gists{/gist_id}","starred_url":"https://api.github.com/users/dmuelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmuelle/subscriptions","organizations_url":"https://api.github.com/users/dmuelle/orgs","repos_url":"https://api.github.com/users/dmuelle/repos","events_url":"https://api.github.com/users/dmuelle/events{/privacy}","received_events_url":"https://api.github.com/users/dmuelle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmuelle/docs","description":"See Open Liberty documentation on https://openliberty.io/docs/","fork":true,"url":"https://api.github.com/repos/dmuelle/docs","forks_url":"https://api.github.com/repos/dmuelle/docs/forks","keys_url":"https://api.github.com/repos/dmuelle/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmuelle/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmuelle/docs/teams","hooks_url":"https://api.github.com/repos/dmuelle/docs/hooks","issue_events_url":"https://api.github.com/repos/dmuelle/docs/issues/events{/number}","events_url":"https://api.github.com/repos/dmuelle/docs/events","assignees_url":"https://api.github.com/repos/dmuelle/docs/assignees{/user}","branches_url":"https://api.github.com/repos/dmuelle/docs/branches{/branch}","tags_url":"https://api.github.com/repos/dmuelle/docs/tags","blobs_url":"https://api.github.com/repos/dmuelle/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmuelle/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmuelle/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmuelle/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmuelle/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dmuelle/docs/languages","stargazers_url":"https://api.github.com/repos/dmuelle/docs/stargazers","contributors_url":"https://api.github.com/repos/dmuelle/docs/contributors","subscribers_url":"https://api.github.com/repos/dmuelle/docs/subscribers","subscription_url":"https://api.github.com/repos/dmuelle/docs/subscription","commits_url":"https://api.github.com/repos/dmuelle/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmuelle/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmuelle/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmuelle/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmuelle/docs/contents/{+path}","compare_url":"https://api.github.com/repos/dmuelle/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmuelle/docs/merges","archive_url":"https://api.github.com/repos/dmuelle/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmuelle/docs/downloads","issues_url":"https://api.github.com/repos/dmuelle/docs/issues{/number}","pulls_url":"https://api.github.com/repos/dmuelle/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dmuelle/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dmuelle/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmuelle/docs/labels{/name}","releases_url":"https://api.github.com/repos/dmuelle/docs/releases{/id}","deployments_url":"https://api.github.com/repos/dmuelle/docs/deployments","created_at":"2019-11-15T16:22:44Z","updated_at":"2019-11-15T16:22:46Z","pushed_at":"2019-11-19T15:41:46Z","git_url":"git://github.com/dmuelle/docs.git","ssh_url":"git@github.com:dmuelle/docs.git","clone_url":"https://github.com/dmuelle/docs.git","svn_url":"https://github.com/dmuelle/docs","homepage":"https://openliberty.io/docs/","size":13277,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenLiberty:develop","ref":"develop","sha":"17dce60fd7e1808cfc268d2516266157cc7221f2","user":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"repo":{"id":147538849,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1Mzg4NDk=","name":"docs","full_name":"OpenLiberty/docs","private":false,"owner":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenLiberty/docs","description":"See Open Liberty documentation on https://openliberty.io/docs/","fork":false,"url":"https://api.github.com/repos/OpenLiberty/docs","forks_url":"https://api.github.com/repos/OpenLiberty/docs/forks","keys_url":"https://api.github.com/repos/OpenLiberty/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLiberty/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLiberty/docs/teams","hooks_url":"https://api.github.com/repos/OpenLiberty/docs/hooks","issue_events_url":"https://api.github.com/repos/OpenLiberty/docs/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLiberty/docs/events","assignees_url":"https://api.github.com/repos/OpenLiberty/docs/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLiberty/docs/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLiberty/docs/tags","blobs_url":"https://api.github.com/repos/OpenLiberty/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLiberty/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLiberty/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLiberty/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLiberty/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLiberty/docs/languages","stargazers_url":"https://api.github.com/repos/OpenLiberty/docs/stargazers","contributors_url":"https://api.github.com/repos/OpenLiberty/docs/contributors","subscribers_url":"https://api.github.com/repos/OpenLiberty/docs/subscribers","subscription_url":"https://api.github.com/repos/OpenLiberty/docs/subscription","commits_url":"https://api.github.com/repos/OpenLiberty/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLiberty/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLiberty/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLiberty/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLiberty/docs/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLiberty/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLiberty/docs/merges","archive_url":"https://api.github.com/repos/OpenLiberty/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLiberty/docs/downloads","issues_url":"https://api.github.com/repos/OpenLiberty/docs/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLiberty/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLiberty/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLiberty/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLiberty/docs/labels{/name}","releases_url":"https://api.github.com/repos/OpenLiberty/docs/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLiberty/docs/deployments","created_at":"2018-09-05T15:19:58Z","updated_at":"2019-11-15T14:35:35Z","pushed_at":"2019-11-21T20:46:52Z","git_url":"git://github.com/OpenLiberty/docs.git","ssh_url":"git@github.com:OpenLiberty/docs.git","clone_url":"https://github.com/OpenLiberty/docs.git","svn_url":"https://github.com/OpenLiberty/docs","homepage":"https://openliberty.io/docs/","size":13269,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":107,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":107,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/docs/pulls/805"},"html":{"href":"https://github.com/OpenLiberty/docs/pull/805"},"issue":{"href":"https://api.github.com/repos/OpenLiberty/docs/issues/805"},"comments":{"href":"https://api.github.com/repos/OpenLiberty/docs/issues/805/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLiberty/docs/pulls/805/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLiberty/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLiberty/docs/pulls/805/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLiberty/docs/statuses/ffeda6dd4b0d0a84603ed88be884ca080dc38ea1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lauracowen"}}