{"action":"created","comment":{"url":"https://api.github.com/repos/asmaloney/libE57Format/pulls/comments/288780520","pull_request_review_id":243529254,"id":288780520,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODc4MDUyMA==","diff_hunk":"@@ -384,25 +437,38 @@ void CheckedFile::seek(uint64_t offset, OffsetMode omode)\n \r\n uint64_t CheckedFile::lseek64(int64_t offset, int whence)\r\n {\r\n+   int64_t result = -1;\r\n+   if(fd_ >= 0){\r\n #if defined(_WIN32)\r\n #  if defined(_MSC_VER) || defined(__MINGW32__) //<rs 2010-06-16> mingw _is_ WIN32!\r\n-   __int64 result = _lseeki64(fd_, offset, whence);\r\n+   result = _lseeki64(fd_, offset, whence);\r\n #  elif defined(__GNUC__) //<rs 2010-06-16> this most likely will not get triggered (cygwin != WIN32)?\r\n #    ifdef E57_MAX_DEBUG\r\n    if (sizeof(off_t) != sizeof(offset))\r\n       throw E57_EXCEPTION2(E57_ERROR_INTERNAL, \"sizeof(off_t)=\" + toString(sizeof(off_t)));\r\n #    endif\r\n-   int64_t result = ::lseek(fd_, offset, whence);\r\n+   result = ::lseek(fd_, offset, whence);\r\n #  else\r\n #    error \"no supported compiler defined\"\r\n #  endif\r\n #elif defined(__linux__)\r\n-   int64_t result = ::lseek64(fd_, offset, whence);\r\n+   result = ::lseek64(fd_, offset, whence);\r\n #elif defined(__APPLE__)\r\n-   int64_t result = ::lseek(fd_, offset, whence);\r\n+   result = ::lseek(fd_, offset, whence);\r\n #else\r\n #  error \"no supported OS platform defined\"\r\n #endif\r\n+   }\r\n+   else if(bufView_ != nullptr){\r\n+      if(bufView_->seek(offset, whence)){\r\n+         result = bufView_->pos();\r\n+      }\r\n+      else{\r\n+         cerr << \"CheckedFile::lseek64 Error: cursorStream_ is out of bound!\" << endl;\r","path":"src/CheckedFile.cpp","position":102,"original_position":102,"commit_id":"3c2644a6c0efdc08a2fe4e58264c0acfc90b6aae","original_commit_id":"3c2644a6c0efdc08a2fe4e58264c0acfc90b6aae","user":{"login":"asmaloney","id":391371,"node_id":"MDQ6VXNlcjM5MTM3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/391371?v=4","gravatar_id":"","url":"https://api.github.com/users/asmaloney","html_url":"https://github.com/asmaloney","followers_url":"https://api.github.com/users/asmaloney/followers","following_url":"https://api.github.com/users/asmaloney/following{/other_user}","gists_url":"https://api.github.com/users/asmaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/asmaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmaloney/subscriptions","organizations_url":"https://api.github.com/users/asmaloney/orgs","repos_url":"https://api.github.com/users/asmaloney/repos","events_url":"https://api.github.com/users/asmaloney/events{/privacy}","received_events_url":"https://api.github.com/users/asmaloney/received_events","type":"User","site_admin":false},"body":"Please remove.\r\n\r\nThis already throws an exception (next block). None of the code in this file is outputting any errors on `std::cerr`.","created_at":"2019-05-29T21:40:59Z","updated_at":"2019-05-29T21:52:06Z","html_url":"https://github.com/asmaloney/libE57Format/pull/22#discussion_r288780520","pull_request_url":"https://api.github.com/repos/asmaloney/libE57Format/pulls/22","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/asmaloney/libE57Format/pulls/comments/288780520"},"html":{"href":"https://github.com/asmaloney/libE57Format/pull/22#discussion_r288780520"},"pull_request":{"href":"https://api.github.com/repos/asmaloney/libE57Format/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/asmaloney/libE57Format/pulls/22","id":283329923,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzMzI5OTIz","html_url":"https://github.com/asmaloney/libE57Format/pull/22","diff_url":"https://github.com/asmaloney/libE57Format/pull/22.diff","patch_url":"https://github.com/asmaloney/libE57Format/pull/22.patch","issue_url":"https://api.github.com/repos/asmaloney/libE57Format/issues/22","number":22,"state":"open","locked":false,"title":"feat(CheckedFile): now support a char* input","user":{"login":"jean-noelp","id":28710922,"node_id":"MDQ6VXNlcjI4NzEwOTIy","avatar_url":"https://avatars0.githubusercontent.com/u/28710922?v=4","gravatar_id":"","url":"https://api.github.com/users/jean-noelp","html_url":"https://github.com/jean-noelp","followers_url":"https://api.github.com/users/jean-noelp/followers","following_url":"https://api.github.com/users/jean-noelp/following{/other_user}","gists_url":"https://api.github.com/users/jean-noelp/gists{/gist_id}","starred_url":"https://api.github.com/users/jean-noelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jean-noelp/subscriptions","organizations_url":"https://api.github.com/users/jean-noelp/orgs","repos_url":"https://api.github.com/users/jean-noelp/repos","events_url":"https://api.github.com/users/jean-noelp/events{/privacy}","received_events_url":"https://api.github.com/users/jean-noelp/received_events","type":"User","site_admin":false},"body":"(#15)\r\n\r\nNow you can directly use ImageFile like this:\r\n\r\n`char *buffer;`\r\n`[...] // read file`\r\n`ImageFile imf(buffer, size);`","created_at":"2019-05-29T16:01:55Z","updated_at":"2019-05-29T21:52:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"240b7877c1a3cef19f5b5a5fac5d9f13ec6f2147","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/asmaloney/libE57Format/pulls/22/commits","review_comments_url":"https://api.github.com/repos/asmaloney/libE57Format/pulls/22/comments","review_comment_url":"https://api.github.com/repos/asmaloney/libE57Format/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asmaloney/libE57Format/issues/22/comments","statuses_url":"https://api.github.com/repos/asmaloney/libE57Format/statuses/3c2644a6c0efdc08a2fe4e58264c0acfc90b6aae","head":{"label":"jean-noelp:char-input","ref":"char-input","sha":"3c2644a6c0efdc08a2fe4e58264c0acfc90b6aae","user":{"login":"jean-noelp","id":28710922,"node_id":"MDQ6VXNlcjI4NzEwOTIy","avatar_url":"https://avatars0.githubusercontent.com/u/28710922?v=4","gravatar_id":"","url":"https://api.github.com/users/jean-noelp","html_url":"https://github.com/jean-noelp","followers_url":"https://api.github.com/users/jean-noelp/followers","following_url":"https://api.github.com/users/jean-noelp/following{/other_user}","gists_url":"https://api.github.com/users/jean-noelp/gists{/gist_id}","starred_url":"https://api.github.com/users/jean-noelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jean-noelp/subscriptions","organizations_url":"https://api.github.com/users/jean-noelp/orgs","repos_url":"https://api.github.com/users/jean-noelp/repos","events_url":"https://api.github.com/users/jean-noelp/events{/privacy}","received_events_url":"https://api.github.com/users/jean-noelp/received_events","type":"User","site_admin":false},"repo":{"id":185997621,"node_id":"MDEwOlJlcG9zaXRvcnkxODU5OTc2MjE=","name":"libE57Format","full_name":"jean-noelp/libE57Format","private":false,"owner":{"login":"jean-noelp","id":28710922,"node_id":"MDQ6VXNlcjI4NzEwOTIy","avatar_url":"https://avatars0.githubusercontent.com/u/28710922?v=4","gravatar_id":"","url":"https://api.github.com/users/jean-noelp","html_url":"https://github.com/jean-noelp","followers_url":"https://api.github.com/users/jean-noelp/followers","following_url":"https://api.github.com/users/jean-noelp/following{/other_user}","gists_url":"https://api.github.com/users/jean-noelp/gists{/gist_id}","starred_url":"https://api.github.com/users/jean-noelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jean-noelp/subscriptions","organizations_url":"https://api.github.com/users/jean-noelp/orgs","repos_url":"https://api.github.com/users/jean-noelp/repos","events_url":"https://api.github.com/users/jean-noelp/events{/privacy}","received_events_url":"https://api.github.com/users/jean-noelp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jean-noelp/libE57Format","description":"Library for reading & writing the E57 file format (fork of E57RefImpl)","fork":true,"url":"https://api.github.com/repos/jean-noelp/libE57Format","forks_url":"https://api.github.com/repos/jean-noelp/libE57Format/forks","keys_url":"https://api.github.com/repos/jean-noelp/libE57Format/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jean-noelp/libE57Format/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jean-noelp/libE57Format/teams","hooks_url":"https://api.github.com/repos/jean-noelp/libE57Format/hooks","issue_events_url":"https://api.github.com/repos/jean-noelp/libE57Format/issues/events{/number}","events_url":"https://api.github.com/repos/jean-noelp/libE57Format/events","assignees_url":"https://api.github.com/repos/jean-noelp/libE57Format/assignees{/user}","branches_url":"https://api.github.com/repos/jean-noelp/libE57Format/branches{/branch}","tags_url":"https://api.github.com/repos/jean-noelp/libE57Format/tags","blobs_url":"https://api.github.com/repos/jean-noelp/libE57Format/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jean-noelp/libE57Format/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jean-noelp/libE57Format/git/refs{/sha}","trees_url":"https://api.github.com/repos/jean-noelp/libE57Format/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jean-noelp/libE57Format/statuses/{sha}","languages_url":"https://api.github.com/repos/jean-noelp/libE57Format/languages","stargazers_url":"https://api.github.com/repos/jean-noelp/libE57Format/stargazers","contributors_url":"https://api.github.com/repos/jean-noelp/libE57Format/contributors","subscribers_url":"https://api.github.com/repos/jean-noelp/libE57Format/subscribers","subscription_url":"https://api.github.com/repos/jean-noelp/libE57Format/subscription","commits_url":"https://api.github.com/repos/jean-noelp/libE57Format/commits{/sha}","git_commits_url":"https://api.github.com/repos/jean-noelp/libE57Format/git/commits{/sha}","comments_url":"https://api.github.com/repos/jean-noelp/libE57Format/comments{/number}","issue_comment_url":"https://api.github.com/repos/jean-noelp/libE57Format/issues/comments{/number}","contents_url":"https://api.github.com/repos/jean-noelp/libE57Format/contents/{+path}","compare_url":"https://api.github.com/repos/jean-noelp/libE57Format/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jean-noelp/libE57Format/merges","archive_url":"https://api.github.com/repos/jean-noelp/libE57Format/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jean-noelp/libE57Format/downloads","issues_url":"https://api.github.com/repos/jean-noelp/libE57Format/issues{/number}","pulls_url":"https://api.github.com/repos/jean-noelp/libE57Format/pulls{/number}","milestones_url":"https://api.github.com/repos/jean-noelp/libE57Format/milestones{/number}","notifications_url":"https://api.github.com/repos/jean-noelp/libE57Format/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jean-noelp/libE57Format/labels{/name}","releases_url":"https://api.github.com/repos/jean-noelp/libE57Format/releases{/id}","deployments_url":"https://api.github.com/repos/jean-noelp/libE57Format/deployments","created_at":"2019-05-10T13:58:02Z","updated_at":"2019-05-29T15:56:35Z","pushed_at":"2019-05-29T15:56:33Z","git_url":"git://github.com/jean-noelp/libE57Format.git","ssh_url":"git@github.com:jean-noelp/libE57Format.git","clone_url":"https://github.com/jean-noelp/libE57Format.git","svn_url":"https://github.com/jean-noelp/libE57Format","homepage":null,"size":708,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asmaloney:master","ref":"master","sha":"bd2af2d7b0a4c6fbb564552047ac4704066ed69d","user":{"login":"asmaloney","id":391371,"node_id":"MDQ6VXNlcjM5MTM3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/391371?v=4","gravatar_id":"","url":"https://api.github.com/users/asmaloney","html_url":"https://github.com/asmaloney","followers_url":"https://api.github.com/users/asmaloney/followers","following_url":"https://api.github.com/users/asmaloney/following{/other_user}","gists_url":"https://api.github.com/users/asmaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/asmaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmaloney/subscriptions","organizations_url":"https://api.github.com/users/asmaloney/orgs","repos_url":"https://api.github.com/users/asmaloney/repos","events_url":"https://api.github.com/users/asmaloney/events{/privacy}","received_events_url":"https://api.github.com/users/asmaloney/received_events","type":"User","site_admin":false},"repo":{"id":126400545,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY0MDA1NDU=","name":"libE57Format","full_name":"asmaloney/libE57Format","private":false,"owner":{"login":"asmaloney","id":391371,"node_id":"MDQ6VXNlcjM5MTM3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/391371?v=4","gravatar_id":"","url":"https://api.github.com/users/asmaloney","html_url":"https://github.com/asmaloney","followers_url":"https://api.github.com/users/asmaloney/followers","following_url":"https://api.github.com/users/asmaloney/following{/other_user}","gists_url":"https://api.github.com/users/asmaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/asmaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmaloney/subscriptions","organizations_url":"https://api.github.com/users/asmaloney/orgs","repos_url":"https://api.github.com/users/asmaloney/repos","events_url":"https://api.github.com/users/asmaloney/events{/privacy}","received_events_url":"https://api.github.com/users/asmaloney/received_events","type":"User","site_admin":false},"html_url":"https://github.com/asmaloney/libE57Format","description":"Library for reading & writing the E57 file format (fork of E57RefImpl)","fork":false,"url":"https://api.github.com/repos/asmaloney/libE57Format","forks_url":"https://api.github.com/repos/asmaloney/libE57Format/forks","keys_url":"https://api.github.com/repos/asmaloney/libE57Format/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asmaloney/libE57Format/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asmaloney/libE57Format/teams","hooks_url":"https://api.github.com/repos/asmaloney/libE57Format/hooks","issue_events_url":"https://api.github.com/repos/asmaloney/libE57Format/issues/events{/number}","events_url":"https://api.github.com/repos/asmaloney/libE57Format/events","assignees_url":"https://api.github.com/repos/asmaloney/libE57Format/assignees{/user}","branches_url":"https://api.github.com/repos/asmaloney/libE57Format/branches{/branch}","tags_url":"https://api.github.com/repos/asmaloney/libE57Format/tags","blobs_url":"https://api.github.com/repos/asmaloney/libE57Format/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asmaloney/libE57Format/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asmaloney/libE57Format/git/refs{/sha}","trees_url":"https://api.github.com/repos/asmaloney/libE57Format/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asmaloney/libE57Format/statuses/{sha}","languages_url":"https://api.github.com/repos/asmaloney/libE57Format/languages","stargazers_url":"https://api.github.com/repos/asmaloney/libE57Format/stargazers","contributors_url":"https://api.github.com/repos/asmaloney/libE57Format/contributors","subscribers_url":"https://api.github.com/repos/asmaloney/libE57Format/subscribers","subscription_url":"https://api.github.com/repos/asmaloney/libE57Format/subscription","commits_url":"https://api.github.com/repos/asmaloney/libE57Format/commits{/sha}","git_commits_url":"https://api.github.com/repos/asmaloney/libE57Format/git/commits{/sha}","comments_url":"https://api.github.com/repos/asmaloney/libE57Format/comments{/number}","issue_comment_url":"https://api.github.com/repos/asmaloney/libE57Format/issues/comments{/number}","contents_url":"https://api.github.com/repos/asmaloney/libE57Format/contents/{+path}","compare_url":"https://api.github.com/repos/asmaloney/libE57Format/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asmaloney/libE57Format/merges","archive_url":"https://api.github.com/repos/asmaloney/libE57Format/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asmaloney/libE57Format/downloads","issues_url":"https://api.github.com/repos/asmaloney/libE57Format/issues{/number}","pulls_url":"https://api.github.com/repos/asmaloney/libE57Format/pulls{/number}","milestones_url":"https://api.github.com/repos/asmaloney/libE57Format/milestones{/number}","notifications_url":"https://api.github.com/repos/asmaloney/libE57Format/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asmaloney/libE57Format/labels{/name}","releases_url":"https://api.github.com/repos/asmaloney/libE57Format/releases{/id}","deployments_url":"https://api.github.com/repos/asmaloney/libE57Format/deployments","created_at":"2018-03-22T22:07:21Z","updated_at":"2019-05-02T13:56:13Z","pushed_at":"2019-05-29T16:01:56Z","git_url":"git://github.com/asmaloney/libE57Format.git","ssh_url":"git@github.com:asmaloney/libE57Format.git","clone_url":"https://github.com/asmaloney/libE57Format.git","svn_url":"https://github.com/asmaloney/libE57Format","homepage":null,"size":700,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":10,"open_issues":4,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asmaloney/libE57Format/pulls/22"},"html":{"href":"https://github.com/asmaloney/libE57Format/pull/22"},"issue":{"href":"https://api.github.com/repos/asmaloney/libE57Format/issues/22"},"comments":{"href":"https://api.github.com/repos/asmaloney/libE57Format/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/asmaloney/libE57Format/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/asmaloney/libE57Format/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asmaloney/libE57Format/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/asmaloney/libE57Format/statuses/3c2644a6c0efdc08a2fe4e58264c0acfc90b6aae"}},"author_association":"NONE"}}
{"actor":{"display_login":"asmaloney"}}