{"action":"closed","number":24349,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/24349","id":313789205,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEzNzg5MjA1","html_url":"https://github.com/ampproject/amphtml/pull/24349","diff_url":"https://github.com/ampproject/amphtml/pull/24349.diff","patch_url":"https://github.com/ampproject/amphtml/pull/24349.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/24349","number":24349,"state":"closed","locked":false,"title":"[DO NOT MERGE] Prototyping nested sidebar menu with attributes","user":{"login":"leafsy","id":8905737,"node_id":"MDQ6VXNlcjg5MDU3Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/8905737?v=4","gravatar_id":"","url":"https://api.github.com/users/leafsy","html_url":"https://github.com/leafsy","followers_url":"https://api.github.com/users/leafsy/followers","following_url":"https://api.github.com/users/leafsy/following{/other_user}","gists_url":"https://api.github.com/users/leafsy/gists{/gist_id}","starred_url":"https://api.github.com/users/leafsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafsy/subscriptions","organizations_url":"https://api.github.com/users/leafsy/orgs","repos_url":"https://api.github.com/users/leafsy/repos","events_url":"https://api.github.com/users/leafsy/events{/privacy}","received_events_url":"https://api.github.com/users/leafsy/received_events","type":"User","site_admin":false},"body":"Demo: https://amp-sidebar-nested.firebaseapp.com/examples/playground.amp.html\r\n\r\nEnable nested drilldown menu inside sidebar using the following attributes:\r\n- `amp-submenu-group`: parent container of submenus that moves away when a submenu opens; \r\n- `amp-submenu`: submenu that replaces `amp-submenu-group` when opened;\r\n- `amp-submenu-open`: element that opens a submenu when clicked, must be a sibling of the corresponding submenu;\r\n- `amp-submenu-close`: element that closes a submenu when clicked, must be inside the corresponding submenu;\r\n\r\nImplement by overriding `amp-sidebar`'s on-click handler and traversing the dom tree from `event.target`.","created_at":"2019-09-03T22:23:41Z","updated_at":"2019-09-25T00:12:01Z","closed_at":"2019-09-25T00:12:01Z","merged_at":null,"merge_commit_sha":"b01cf3854b2b3b203e55588caf4a30dec3357017","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/24349/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/24349/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/24349/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/f90b2072eaf8ca76c81ba27a9ddef53694763d69","head":{"label":"leafsy:proto/nested-sidebar1","ref":"proto/nested-sidebar1","sha":"f90b2072eaf8ca76c81ba27a9ddef53694763d69","user":{"login":"leafsy","id":8905737,"node_id":"MDQ6VXNlcjg5MDU3Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/8905737?v=4","gravatar_id":"","url":"https://api.github.com/users/leafsy","html_url":"https://github.com/leafsy","followers_url":"https://api.github.com/users/leafsy/followers","following_url":"https://api.github.com/users/leafsy/following{/other_user}","gists_url":"https://api.github.com/users/leafsy/gists{/gist_id}","starred_url":"https://api.github.com/users/leafsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafsy/subscriptions","organizations_url":"https://api.github.com/users/leafsy/orgs","repos_url":"https://api.github.com/users/leafsy/repos","events_url":"https://api.github.com/users/leafsy/events{/privacy}","received_events_url":"https://api.github.com/users/leafsy/received_events","type":"User","site_admin":false},"repo":{"id":189653304,"node_id":"MDEwOlJlcG9zaXRvcnkxODk2NTMzMDQ=","name":"amphtml","full_name":"leafsy/amphtml","private":false,"owner":{"login":"leafsy","id":8905737,"node_id":"MDQ6VXNlcjg5MDU3Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/8905737?v=4","gravatar_id":"","url":"https://api.github.com/users/leafsy","html_url":"https://github.com/leafsy","followers_url":"https://api.github.com/users/leafsy/followers","following_url":"https://api.github.com/users/leafsy/following{/other_user}","gists_url":"https://api.github.com/users/leafsy/gists{/gist_id}","starred_url":"https://api.github.com/users/leafsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafsy/subscriptions","organizations_url":"https://api.github.com/users/leafsy/orgs","repos_url":"https://api.github.com/users/leafsy/repos","events_url":"https://api.github.com/users/leafsy/events{/privacy}","received_events_url":"https://api.github.com/users/leafsy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/leafsy/amphtml","description":"The AMP web component framework.","fork":true,"url":"https://api.github.com/repos/leafsy/amphtml","forks_url":"https://api.github.com/repos/leafsy/amphtml/forks","keys_url":"https://api.github.com/repos/leafsy/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leafsy/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leafsy/amphtml/teams","hooks_url":"https://api.github.com/repos/leafsy/amphtml/hooks","issue_events_url":"https://api.github.com/repos/leafsy/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/leafsy/amphtml/events","assignees_url":"https://api.github.com/repos/leafsy/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/leafsy/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/leafsy/amphtml/tags","blobs_url":"https://api.github.com/repos/leafsy/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leafsy/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leafsy/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/leafsy/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leafsy/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/leafsy/amphtml/languages","stargazers_url":"https://api.github.com/repos/leafsy/amphtml/stargazers","contributors_url":"https://api.github.com/repos/leafsy/amphtml/contributors","subscribers_url":"https://api.github.com/repos/leafsy/amphtml/subscribers","subscription_url":"https://api.github.com/repos/leafsy/amphtml/subscription","commits_url":"https://api.github.com/repos/leafsy/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/leafsy/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/leafsy/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/leafsy/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/leafsy/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/leafsy/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leafsy/amphtml/merges","archive_url":"https://api.github.com/repos/leafsy/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leafsy/amphtml/downloads","issues_url":"https://api.github.com/repos/leafsy/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/leafsy/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/leafsy/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/leafsy/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leafsy/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/leafsy/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/leafsy/amphtml/deployments","created_at":"2019-05-31T20:16:51Z","updated_at":"2019-08-14T23:07:31Z","pushed_at":"2019-09-23T21:18:47Z","git_url":"git://github.com/leafsy/amphtml.git","ssh_url":"git@github.com:leafsy/amphtml.git","clone_url":"https://github.com/leafsy/amphtml.git","svn_url":"https://github.com/leafsy/amphtml","homepage":"https://amp.dev","size":661395,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"91383ada93f76ba1b727e153374c5cf34f8292ba","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","private":false,"owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ampproject/amphtml","description":"The AMP web component framework.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2019-09-24T22:01:05Z","pushed_at":"2019-09-24T23:57:08Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://amp.dev","size":662144,"stargazers_count":13089,"watchers_count":13089,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3159,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1576,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3159,"open_issues":1576,"watchers":13089,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/24349"},"html":{"href":"https://github.com/ampproject/amphtml/pull/24349"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/24349"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/24349/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/24349/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/24349/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/f90b2072eaf8ca76c81ba27a9ddef53694763d69"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"draft","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":593,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"leafsy"}}