{"action":"created","issue":{"url":"https://api.github.com/repos/gemrb/gemrb/issues/550","repository_url":"https://api.github.com/repos/gemrb/gemrb","labels_url":"https://api.github.com/repos/gemrb/gemrb/issues/550/labels{/name}","comments_url":"https://api.github.com/repos/gemrb/gemrb/issues/550/comments","events_url":"https://api.github.com/repos/gemrb/gemrb/issues/550/events","html_url":"https://github.com/gemrb/gemrb/issues/550","id":541351965,"node_id":"MDU6SXNzdWU1NDEzNTE5NjU=","number":550,"title":"[bug] subviews build problems","user":{"login":"lynxlynxlynx","id":121515,"node_id":"MDQ6VXNlcjEyMTUxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/121515?v=4","gravatar_id":"","url":"https://api.github.com/users/lynxlynxlynx","html_url":"https://github.com/lynxlynxlynx","followers_url":"https://api.github.com/users/lynxlynxlynx/followers","following_url":"https://api.github.com/users/lynxlynxlynx/following{/other_user}","gists_url":"https://api.github.com/users/lynxlynxlynx/gists{/gist_id}","starred_url":"https://api.github.com/users/lynxlynxlynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynxlynxlynx/subscriptions","organizations_url":"https://api.github.com/users/lynxlynxlynx/orgs","repos_url":"https://api.github.com/users/lynxlynxlynx/repos","events_url":"https://api.github.com/users/lynxlynxlynx/events{/privacy}","received_events_url":"https://api.github.com/users/lynxlynxlynx/received_events","type":"User","site_admin":false},"labels":[{"id":1544554415,"node_id":"MDU6TGFiZWwxNTQ0NTU0NDE1","url":"https://api.github.com/repos/gemrb/gemrb/labels/SDL2","name":"SDL2","color":"ea41d9","default":false,"description":"Issues specifically the SDL2 backend"},{"id":1219359627,"node_id":"MDU6TGFiZWwxMjE5MzU5NjI3","url":"https://api.github.com/repos/gemrb/gemrb/labels/bug","name":"bug","color":"c1402c","default":true,"description":""},{"id":1527721442,"node_id":"MDU6TGFiZWwxNTI3NzIxNDQy","url":"https://api.github.com/repos/gemrb/gemrb/labels/subviews","name":"subviews","color":"fbca04","default":false,"description":""}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-12-21T17:42:30Z","updated_at":"2019-12-21T18:21:38Z","closed_at":"2019-12-21T18:21:38Z","author_association":"MEMBER","body":"After the changes in #441 subviews doesn't build for me any more. As expected it doesn't with sdl1, but neither does sdl2. \r\n\r\nIs opengl now required? GLFloat and similar is what's undefined when it tries to build GLSLProgram, since the driver includes it unconditionally. Removing the include fails too, since the stencilShader requires it.\r\n\r\nIsn't the 'raw' version supposed to be sdl-only?"},"comment":{"url":"https://api.github.com/repos/gemrb/gemrb/issues/comments/568201305","html_url":"https://github.com/gemrb/gemrb/issues/550#issuecomment-568201305","issue_url":"https://api.github.com/repos/gemrb/gemrb/issues/550","id":568201305,"node_id":"MDEyOklzc3VlQ29tbWVudDU2ODIwMTMwNQ==","user":{"login":"lynxlynxlynx","id":121515,"node_id":"MDQ6VXNlcjEyMTUxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/121515?v=4","gravatar_id":"","url":"https://api.github.com/users/lynxlynxlynx","html_url":"https://github.com/lynxlynxlynx","followers_url":"https://api.github.com/users/lynxlynxlynx/followers","following_url":"https://api.github.com/users/lynxlynxlynx/following{/other_user}","gists_url":"https://api.github.com/users/lynxlynxlynx/gists{/gist_id}","starred_url":"https://api.github.com/users/lynxlynxlynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynxlynxlynx/subscriptions","organizations_url":"https://api.github.com/users/lynxlynxlynx/orgs","repos_url":"https://api.github.com/users/lynxlynxlynx/repos","events_url":"https://api.github.com/users/lynxlynxlynx/events{/privacy}","received_events_url":"https://api.github.com/users/lynxlynxlynx/received_events","type":"User","site_admin":false},"created_at":"2019-12-21T18:21:38Z","updated_at":"2019-12-21T18:21:38Z","author_association":"MEMBER","body":"Thanks, it builds now. The cmake change is trivial, in gemrb/plugins/SDLVideo/CMakeLists.txt, but I don't have gl set up on that machine to test."}}
{"actor":{"display_login":"lynxlynxlynx"}}