{"action":"closed","number":15809,"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15809","id":339252932,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5MjUyOTMy","html_url":"https://github.com/civicrm/civicrm-core/pull/15809","diff_url":"https://github.com/civicrm/civicrm-core/pull/15809.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/15809.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/15809","number":15809,"state":"closed","locked":false,"title":"[NFC] declare thrown exceptions","user":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"body":"Overview\r\n----------------------------------------\r\nTidy up on test class\r\n\r\nBefore\r\n----------------------------------------\r\n\r\n\r\nAfter\r\n----------------------------------------\r\n\r\n\r\nTechnical Details\r\n----------------------------------------\r\nMostly this is declaring exceptions. I also removed a tearDown after class as the tearDown already does as much & more. It would be good to use tearDownAfterClass more but this is not a case of us doing that properly\r\n\r\nComments\r\n----------------------------------------\r\n\r\n","created_at":"2019-11-11T04:50:02Z","updated_at":"2019-11-11T08:08:00Z","closed_at":"2019-11-11T08:08:00Z","merged_at":"2019-11-11T08:08:00Z","merge_commit_sha":"a08dfa93f1f542cb071af22716f51c78fb095f02","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15809/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15809/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/15809/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/b086dc3ab54ff5d35a29640c0c90fc6037a93de8","head":{"label":"eileenmcnaughton:except","ref":"except","sha":"b086dc3ab54ff5d35a29640c0c90fc6037a93de8","user":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"repo":{"id":8567814,"node_id":"MDEwOlJlcG9zaXRvcnk4NTY3ODE0","name":"civicrm-core","full_name":"eileenmcnaughton/civicrm-core","private":false,"owner":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eileenmcnaughton/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core","forks_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/forks","keys_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/teams","hooks_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/events","assignees_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/tags","blobs_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/subscription","commits_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/merges","archive_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/downloads","issues_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/eileenmcnaughton/civicrm-core/deployments","created_at":"2013-03-04T23:49:52Z","updated_at":"2019-10-20T21:03:30Z","pushed_at":"2019-11-11T08:05:50Z","git_url":"git://github.com/eileenmcnaughton/civicrm-core.git","ssh_url":"git@github.com:eileenmcnaughton/civicrm-core.git","clone_url":"https://github.com/eileenmcnaughton/civicrm-core.git","svn_url":"https://github.com/eileenmcnaughton/civicrm-core","homepage":null,"size":189738,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":0,"watchers":3,"default_branch":"activity"}},"base":{"label":"civicrm:master","ref":"master","sha":"9822105983f1d2249bb00138de7689cfbac6c6cb","user":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk1NDk5","name":"civicrm-core","full_name":"civicrm/civicrm-core","private":false,"owner":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2019-11-11T06:00:50Z","pushed_at":"2019-11-11T08:08:00Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":203443,"stargazers_count":350,"watchers_count":350,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":694,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":117,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":694,"open_issues":117,"watchers":350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15809"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/15809"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/15809"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/15809/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15809/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15809/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/b086dc3ab54ff5d35a29640c0c90fc6037a93de8"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"seamuslee001","id":6799125,"node_id":"MDQ6VXNlcjY3OTkxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6799125?v=4","gravatar_id":"","url":"https://api.github.com/users/seamuslee001","html_url":"https://github.com/seamuslee001","followers_url":"https://api.github.com/users/seamuslee001/followers","following_url":"https://api.github.com/users/seamuslee001/following{/other_user}","gists_url":"https://api.github.com/users/seamuslee001/gists{/gist_id}","starred_url":"https://api.github.com/users/seamuslee001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seamuslee001/subscriptions","organizations_url":"https://api.github.com/users/seamuslee001/orgs","repos_url":"https://api.github.com/users/seamuslee001/repos","events_url":"https://api.github.com/users/seamuslee001/events{/privacy}","received_events_url":"https://api.github.com/users/seamuslee001/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":120,"deletions":25,"changed_files":2}}
{"actor":{"display_login":"seamuslee001"}}