{"action":"created","comment":{"url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/comments/303688090","pull_request_review_id":262137954,"id":303688090,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzY4ODA5MA==","diff_hunk":"@@ -77,7 +78,23 @@ import { getVersion } from \"../../version\";\n        * @param opts A bag of options that control this resource's behavior.\n        */\n       constructor(name: string, args?: inputApi.admissionregistration.v1beta1.MutatingWebhookConfiguration, opts?: pulumi.CustomResourceOptions) {\n+          // In Kubernetes, `.metadata.namespace` must be a `string`. In Pulumi, we allow users to\n+          // pass in `string | core.v1.Namespace`. Thus, if the user has provided a\n+          // `core.v1.Namespace`, we convert it to a `string` representing that namespace's name.","path":"sdk/nodejs/admissionregistration/v1beta1/MutatingWebhookConfiguration.ts","position":14,"original_position":14,"commit_id":"31dca8cb6c76d5f7b6193f41ba18a04e81aa78bd","original_commit_id":"31dca8cb6c76d5f7b6193f41ba18a04e81aa78bd","user":{"login":"hausdorff","id":1409156,"node_id":"MDQ6VXNlcjE0MDkxNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1409156?v=4","gravatar_id":"","url":"https://api.github.com/users/hausdorff","html_url":"https://github.com/hausdorff","followers_url":"https://api.github.com/users/hausdorff/followers","following_url":"https://api.github.com/users/hausdorff/following{/other_user}","gists_url":"https://api.github.com/users/hausdorff/gists{/gist_id}","starred_url":"https://api.github.com/users/hausdorff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hausdorff/subscriptions","organizations_url":"https://api.github.com/users/hausdorff/orgs","repos_url":"https://api.github.com/users/hausdorff/repos","events_url":"https://api.github.com/users/hausdorff/events{/privacy}","received_events_url":"https://api.github.com/users/hausdorff/received_events","type":"User","site_admin":false},"body":"We could do this, but in the longer term I wasn't sure whether this would be the `id` ([_cf_](https://github.com/pulumi/pulumi-kubernetes/issues/353).), and in any event, I personally value the explicitness of encoding relationship between resource as code vs. using parts of the Pulumi protocol that happen to contain that info, just to shorten the code. My 2 cents.","created_at":"2019-07-16T00:29:03Z","updated_at":"2019-07-16T00:29:03Z","html_url":"https://github.com/pulumi/pulumi-kubernetes/pull/635#discussion_r303688090","pull_request_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/635","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/comments/303688090"},"html":{"href":"https://github.com/pulumi/pulumi-kubernetes/pull/635#discussion_r303688090"},"pull_request":{"href":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/635"}},"in_reply_to_id":303581810},"pull_request":{"url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/635","id":297338255,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3MzM4MjU1","html_url":"https://github.com/pulumi/pulumi-kubernetes/pull/635","diff_url":"https://github.com/pulumi/pulumi-kubernetes/pull/635.diff","patch_url":"https://github.com/pulumi/pulumi-kubernetes/pull/635.patch","issue_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/issues/635","number":635,"state":"open","locked":false,"title":"Fix various typegen issues","user":{"login":"hausdorff","id":1409156,"node_id":"MDQ6VXNlcjE0MDkxNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1409156?v=4","gravatar_id":"","url":"https://api.github.com/users/hausdorff","html_url":"https://github.com/hausdorff","followers_url":"https://api.github.com/users/hausdorff/followers","following_url":"https://api.github.com/users/hausdorff/following{/other_user}","gists_url":"https://api.github.com/users/hausdorff/gists{/gist_id}","starred_url":"https://api.github.com/users/hausdorff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hausdorff/subscriptions","organizations_url":"https://api.github.com/users/hausdorff/orgs","repos_url":"https://api.github.com/users/hausdorff/repos","events_url":"https://api.github.com/users/hausdorff/events{/privacy}","received_events_url":"https://api.github.com/users/hausdorff/received_events","type":"User","site_admin":false},"body":"Fixes #152.\r\nFixes #444.","created_at":"2019-07-13T18:35:17Z","updated_at":"2019-07-16T00:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"858a48446e38f14b6a290813c517adb81b34a9e1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lblackstone","id":9253463,"node_id":"MDQ6VXNlcjkyNTM0NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/9253463?v=4","gravatar_id":"","url":"https://api.github.com/users/lblackstone","html_url":"https://github.com/lblackstone","followers_url":"https://api.github.com/users/lblackstone/followers","following_url":"https://api.github.com/users/lblackstone/following{/other_user}","gists_url":"https://api.github.com/users/lblackstone/gists{/gist_id}","starred_url":"https://api.github.com/users/lblackstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lblackstone/subscriptions","organizations_url":"https://api.github.com/users/lblackstone/orgs","repos_url":"https://api.github.com/users/lblackstone/repos","events_url":"https://api.github.com/users/lblackstone/events{/privacy}","received_events_url":"https://api.github.com/users/lblackstone/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1448918270,"node_id":"MDU6TGFiZWwxNDQ4OTE4Mjcw","url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/labels/feature/q3","name":"feature/q3","color":"e204db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/635/commits","review_comments_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/635/comments","review_comment_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/issues/635/comments","statuses_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/statuses/31dca8cb6c76d5f7b6193f41ba18a04e81aa78bd","head":{"label":"pulumi:hausdorff/explicit-ns","ref":"hausdorff/explicit-ns","sha":"31dca8cb6c76d5f7b6193f41ba18a04e81aa78bd","user":{"login":"pulumi","id":21992475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTkyNDc1","avatar_url":"https://avatars0.githubusercontent.com/u/21992475?v=4","gravatar_id":"","url":"https://api.github.com/users/pulumi","html_url":"https://github.com/pulumi","followers_url":"https://api.github.com/users/pulumi/followers","following_url":"https://api.github.com/users/pulumi/following{/other_user}","gists_url":"https://api.github.com/users/pulumi/gists{/gist_id}","starred_url":"https://api.github.com/users/pulumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulumi/subscriptions","organizations_url":"https://api.github.com/users/pulumi/orgs","repos_url":"https://api.github.com/users/pulumi/repos","events_url":"https://api.github.com/users/pulumi/events{/privacy}","received_events_url":"https://api.github.com/users/pulumi/received_events","type":"Organization","site_admin":false},"repo":{"id":116869354,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4NjkzNTQ=","name":"pulumi-kubernetes","full_name":"pulumi/pulumi-kubernetes","private":false,"owner":{"login":"pulumi","id":21992475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTkyNDc1","avatar_url":"https://avatars0.githubusercontent.com/u/21992475?v=4","gravatar_id":"","url":"https://api.github.com/users/pulumi","html_url":"https://github.com/pulumi","followers_url":"https://api.github.com/users/pulumi/followers","following_url":"https://api.github.com/users/pulumi/following{/other_user}","gists_url":"https://api.github.com/users/pulumi/gists{/gist_id}","starred_url":"https://api.github.com/users/pulumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulumi/subscriptions","organizations_url":"https://api.github.com/users/pulumi/orgs","repos_url":"https://api.github.com/users/pulumi/repos","events_url":"https://api.github.com/users/pulumi/events{/privacy}","received_events_url":"https://api.github.com/users/pulumi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pulumi/pulumi-kubernetes","description":"Kubernetes Pulumi resource provider, allowing Pulumi to manage Kubernetes resources in arbitrary Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/pulumi/pulumi-kubernetes","forks_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/forks","keys_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/teams","hooks_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/events","assignees_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/tags","blobs_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/languages","stargazers_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/subscription","commits_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/merges","archive_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/downloads","issues_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/deployments","created_at":"2018-01-09T20:50:33Z","updated_at":"2019-07-16T00:08:26Z","pushed_at":"2019-07-16T00:09:44Z","git_url":"git://github.com/pulumi/pulumi-kubernetes.git","ssh_url":"git@github.com:pulumi/pulumi-kubernetes.git","clone_url":"https://github.com/pulumi/pulumi-kubernetes.git","svn_url":"https://github.com/pulumi/pulumi-kubernetes","homepage":"","size":3642,"stargazers_count":70,"watchers_count":70,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":109,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":109,"watchers":70,"default_branch":"master"}},"base":{"label":"pulumi:master","ref":"master","sha":"a8047e5fb269d7a36b334143a6213c9ce2e9671a","user":{"login":"pulumi","id":21992475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTkyNDc1","avatar_url":"https://avatars0.githubusercontent.com/u/21992475?v=4","gravatar_id":"","url":"https://api.github.com/users/pulumi","html_url":"https://github.com/pulumi","followers_url":"https://api.github.com/users/pulumi/followers","following_url":"https://api.github.com/users/pulumi/following{/other_user}","gists_url":"https://api.github.com/users/pulumi/gists{/gist_id}","starred_url":"https://api.github.com/users/pulumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulumi/subscriptions","organizations_url":"https://api.github.com/users/pulumi/orgs","repos_url":"https://api.github.com/users/pulumi/repos","events_url":"https://api.github.com/users/pulumi/events{/privacy}","received_events_url":"https://api.github.com/users/pulumi/received_events","type":"Organization","site_admin":false},"repo":{"id":116869354,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4NjkzNTQ=","name":"pulumi-kubernetes","full_name":"pulumi/pulumi-kubernetes","private":false,"owner":{"login":"pulumi","id":21992475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTkyNDc1","avatar_url":"https://avatars0.githubusercontent.com/u/21992475?v=4","gravatar_id":"","url":"https://api.github.com/users/pulumi","html_url":"https://github.com/pulumi","followers_url":"https://api.github.com/users/pulumi/followers","following_url":"https://api.github.com/users/pulumi/following{/other_user}","gists_url":"https://api.github.com/users/pulumi/gists{/gist_id}","starred_url":"https://api.github.com/users/pulumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulumi/subscriptions","organizations_url":"https://api.github.com/users/pulumi/orgs","repos_url":"https://api.github.com/users/pulumi/repos","events_url":"https://api.github.com/users/pulumi/events{/privacy}","received_events_url":"https://api.github.com/users/pulumi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pulumi/pulumi-kubernetes","description":"Kubernetes Pulumi resource provider, allowing Pulumi to manage Kubernetes resources in arbitrary Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/pulumi/pulumi-kubernetes","forks_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/forks","keys_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/teams","hooks_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/events","assignees_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/tags","blobs_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/languages","stargazers_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/subscription","commits_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/merges","archive_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/downloads","issues_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/pulumi/pulumi-kubernetes/deployments","created_at":"2018-01-09T20:50:33Z","updated_at":"2019-07-16T00:08:26Z","pushed_at":"2019-07-16T00:09:44Z","git_url":"git://github.com/pulumi/pulumi-kubernetes.git","ssh_url":"git@github.com:pulumi/pulumi-kubernetes.git","clone_url":"https://github.com/pulumi/pulumi-kubernetes.git","svn_url":"https://github.com/pulumi/pulumi-kubernetes","homepage":"","size":3642,"stargazers_count":70,"watchers_count":70,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":109,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":109,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/635"},"html":{"href":"https://github.com/pulumi/pulumi-kubernetes/pull/635"},"issue":{"href":"https://api.github.com/repos/pulumi/pulumi-kubernetes/issues/635"},"comments":{"href":"https://api.github.com/repos/pulumi/pulumi-kubernetes/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulumi/pulumi-kubernetes/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/pulumi/pulumi-kubernetes/statuses/31dca8cb6c76d5f7b6193f41ba18a04e81aa78bd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hausdorff"}}