{"action":"created","comment":{"url":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/comments/350311960","pull_request_review_id":322437403,"id":350311960,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MDMxMTk2MA==","diff_hunk":"@@ -0,0 +1,39 @@\n+= Timers in Deployment Groups\n+\n+Timer facilities provided by EJB APIs `TimerService` and `@Scheduled` need special configuration in order to work intuitively for applications deployed to a deployment group.\n+\n+There are four types of timers distinguished by their lifecycle (persistent, non-persistent) and the mean of their definition (declarative, programmatic).\n+\n+Declarative timers are defined in EJB deployment descriptors or with annotation `@Scheduled`.\n+Programmatic timers are created via calls to `TimerService.create*Timer`.\n+\n+== Non-Persistent Timers\n+\n+Non-Persistent timers exist only in memory for duration in which the application runs of the instance.\n+Declarative non-persistent timers run on every instace, programmatic ones only on instance that created them.\n+When instance shuts down, the timer stops firing.","path":"documentation/payara-server/deployment-groups/timers.adoc","position":14,"original_position":14,"commit_id":"93fbd6640d2e8b3267534bb3535d90a6cf5f07a8","original_commit_id":"93fbd6640d2e8b3267534bb3535d90a6cf5f07a8","user":{"login":"MattGill98","id":12214116,"node_id":"MDQ6VXNlcjEyMjE0MTE2","avatar_url":"https://avatars3.githubusercontent.com/u/12214116?v=4","gravatar_id":"","url":"https://api.github.com/users/MattGill98","html_url":"https://github.com/MattGill98","followers_url":"https://api.github.com/users/MattGill98/followers","following_url":"https://api.github.com/users/MattGill98/following{/other_user}","gists_url":"https://api.github.com/users/MattGill98/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGill98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGill98/subscriptions","organizations_url":"https://api.github.com/users/MattGill98/orgs","repos_url":"https://api.github.com/users/MattGill98/repos","events_url":"https://api.github.com/users/MattGill98/events{/privacy}","received_events_url":"https://api.github.com/users/MattGill98/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nWhen the instance shuts down, the timer stops firing.\r\n```","created_at":"2019-11-25T17:08:12Z","updated_at":"2019-11-25T17:18:11Z","html_url":"https://github.com/payara/Payara-Server-Documentation/pull/661#discussion_r350311960","pull_request_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/661","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/comments/350311960"},"html":{"href":"https://github.com/payara/Payara-Server-Documentation/pull/661#discussion_r350311960"},"pull_request":{"href":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/661"}}},"pull_request":{"url":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/661","id":344554785,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ0NTU0Nzg1","html_url":"https://github.com/payara/Payara-Server-Documentation/pull/661","diff_url":"https://github.com/payara/Payara-Server-Documentation/pull/661.diff","patch_url":"https://github.com/payara/Payara-Server-Documentation/pull/661.patch","issue_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/issues/661","number":661,"state":"open","locked":false,"title":"PAYARA-4215: Describe preconditions for persistent timers in deployment groups","user":{"login":"pdudits","id":1588543,"node_id":"MDQ6VXNlcjE1ODg1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1588543?v=4","gravatar_id":"","url":"https://api.github.com/users/pdudits","html_url":"https://github.com/pdudits","followers_url":"https://api.github.com/users/pdudits/followers","following_url":"https://api.github.com/users/pdudits/following{/other_user}","gists_url":"https://api.github.com/users/pdudits/gists{/gist_id}","starred_url":"https://api.github.com/users/pdudits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdudits/subscriptions","organizations_url":"https://api.github.com/users/pdudits/orgs","repos_url":"https://api.github.com/users/pdudits/repos","events_url":"https://api.github.com/users/pdudits/events{/privacy}","received_events_url":"https://api.github.com/users/pdudits/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-22T14:50:31Z","updated_at":"2019-11-25T17:18:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fab44ad1933a1778aab38b541f0b86db5c8786e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/661/commits","review_comments_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/661/comments","review_comment_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/issues/661/comments","statuses_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/statuses/93fbd6640d2e8b3267534bb3535d90a6cf5f07a8","head":{"label":"pdudits:payara-4215","ref":"payara-4215","sha":"93fbd6640d2e8b3267534bb3535d90a6cf5f07a8","user":{"login":"pdudits","id":1588543,"node_id":"MDQ6VXNlcjE1ODg1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1588543?v=4","gravatar_id":"","url":"https://api.github.com/users/pdudits","html_url":"https://github.com/pdudits","followers_url":"https://api.github.com/users/pdudits/followers","following_url":"https://api.github.com/users/pdudits/following{/other_user}","gists_url":"https://api.github.com/users/pdudits/gists{/gist_id}","starred_url":"https://api.github.com/users/pdudits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdudits/subscriptions","organizations_url":"https://api.github.com/users/pdudits/orgs","repos_url":"https://api.github.com/users/pdudits/repos","events_url":"https://api.github.com/users/pdudits/events{/privacy}","received_events_url":"https://api.github.com/users/pdudits/received_events","type":"User","site_admin":false},"repo":{"id":187674834,"node_id":"MDEwOlJlcG9zaXRvcnkxODc2NzQ4MzQ=","name":"Payara-Server-Documentation","full_name":"pdudits/Payara-Server-Documentation","private":false,"owner":{"login":"pdudits","id":1588543,"node_id":"MDQ6VXNlcjE1ODg1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1588543?v=4","gravatar_id":"","url":"https://api.github.com/users/pdudits","html_url":"https://github.com/pdudits","followers_url":"https://api.github.com/users/pdudits/followers","following_url":"https://api.github.com/users/pdudits/following{/other_user}","gists_url":"https://api.github.com/users/pdudits/gists{/gist_id}","starred_url":"https://api.github.com/users/pdudits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdudits/subscriptions","organizations_url":"https://api.github.com/users/pdudits/orgs","repos_url":"https://api.github.com/users/pdudits/repos","events_url":"https://api.github.com/users/pdudits/events{/privacy}","received_events_url":"https://api.github.com/users/pdudits/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pdudits/Payara-Server-Documentation","description":"Documentation as rendered on GitBooks","fork":true,"url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation","forks_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/forks","keys_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/teams","hooks_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/hooks","issue_events_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/issues/events{/number}","events_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/events","assignees_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/assignees{/user}","branches_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/branches{/branch}","tags_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/tags","blobs_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/languages","stargazers_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/stargazers","contributors_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/contributors","subscribers_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/subscribers","subscription_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/subscription","commits_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/contents/{+path}","compare_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/merges","archive_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/downloads","issues_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/issues{/number}","pulls_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/labels{/name}","releases_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/releases{/id}","deployments_url":"https://api.github.com/repos/pdudits/Payara-Server-Documentation/deployments","created_at":"2019-05-20T16:14:45Z","updated_at":"2019-05-20T16:14:48Z","pushed_at":"2019-11-25T14:13:16Z","git_url":"git://github.com/pdudits/Payara-Server-Documentation.git","ssh_url":"git@github.com:pdudits/Payara-Server-Documentation.git","clone_url":"https://github.com/pdudits/Payara-Server-Documentation.git","svn_url":"https://github.com/pdudits/Payara-Server-Documentation","homepage":"https://docs.payara.fish","size":22907,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"payara:master","ref":"master","sha":"a73702b4d3e8833be4b139b37eb9e55b0a671cb2","user":{"login":"payara","id":7817189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTcxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/7817189?v=4","gravatar_id":"","url":"https://api.github.com/users/payara","html_url":"https://github.com/payara","followers_url":"https://api.github.com/users/payara/followers","following_url":"https://api.github.com/users/payara/following{/other_user}","gists_url":"https://api.github.com/users/payara/gists{/gist_id}","starred_url":"https://api.github.com/users/payara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payara/subscriptions","organizations_url":"https://api.github.com/users/payara/orgs","repos_url":"https://api.github.com/users/payara/repos","events_url":"https://api.github.com/users/payara/events{/privacy}","received_events_url":"https://api.github.com/users/payara/received_events","type":"Organization","site_admin":false},"repo":{"id":56385935,"node_id":"MDEwOlJlcG9zaXRvcnk1NjM4NTkzNQ==","name":"Payara-Server-Documentation","full_name":"payara/Payara-Server-Documentation","private":false,"owner":{"login":"payara","id":7817189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTcxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/7817189?v=4","gravatar_id":"","url":"https://api.github.com/users/payara","html_url":"https://github.com/payara","followers_url":"https://api.github.com/users/payara/followers","following_url":"https://api.github.com/users/payara/following{/other_user}","gists_url":"https://api.github.com/users/payara/gists{/gist_id}","starred_url":"https://api.github.com/users/payara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payara/subscriptions","organizations_url":"https://api.github.com/users/payara/orgs","repos_url":"https://api.github.com/users/payara/repos","events_url":"https://api.github.com/users/payara/events{/privacy}","received_events_url":"https://api.github.com/users/payara/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/payara/Payara-Server-Documentation","description":"Documentation as rendered on GitBooks","fork":false,"url":"https://api.github.com/repos/payara/Payara-Server-Documentation","forks_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/forks","keys_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/teams","hooks_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/hooks","issue_events_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/issues/events{/number}","events_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/events","assignees_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/assignees{/user}","branches_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/branches{/branch}","tags_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/tags","blobs_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/languages","stargazers_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/stargazers","contributors_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/contributors","subscribers_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/subscribers","subscription_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/subscription","commits_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/contents/{+path}","compare_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/merges","archive_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/downloads","issues_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/issues{/number}","pulls_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/labels{/name}","releases_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/releases{/id}","deployments_url":"https://api.github.com/repos/payara/Payara-Server-Documentation/deployments","created_at":"2016-04-16T13:48:09Z","updated_at":"2019-11-21T14:56:05Z","pushed_at":"2019-11-25T14:15:17Z","git_url":"git://github.com/payara/Payara-Server-Documentation.git","ssh_url":"git@github.com:payara/Payara-Server-Documentation.git","clone_url":"https://github.com/payara/Payara-Server-Documentation.git","svn_url":"https://github.com/payara/Payara-Server-Documentation","homepage":"https://docs.payara.fish","size":22991,"stargazers_count":14,"watchers_count":14,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":null,"forks":33,"open_issues":14,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/661"},"html":{"href":"https://github.com/payara/Payara-Server-Documentation/pull/661"},"issue":{"href":"https://api.github.com/repos/payara/Payara-Server-Documentation/issues/661"},"comments":{"href":"https://api.github.com/repos/payara/Payara-Server-Documentation/issues/661/comments"},"review_comments":{"href":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/661/comments"},"review_comment":{"href":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/payara/Payara-Server-Documentation/pulls/661/commits"},"statuses":{"href":"https://api.github.com/repos/payara/Payara-Server-Documentation/statuses/93fbd6640d2e8b3267534bb3535d90a6cf5f07a8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MattGill98"}}