{"action":"closed","number":71,"pull_request":{"url":"https://api.github.com/repos/alphagov/pay-java-commons/pulls/71","id":252003247,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyMDAzMjQ3","html_url":"https://github.com/alphagov/pay-java-commons/pull/71","diff_url":"https://github.com/alphagov/pay-java-commons/pull/71.diff","patch_url":"https://github.com/alphagov/pay-java-commons/pull/71.patch","issue_url":"https://api.github.com/repos/alphagov/pay-java-commons/issues/71","number":71,"state":"closed","locked":false,"title":"PP-4790 Get metadata from database login","user":{"login":"georgeracu","id":1834108,"node_id":"MDQ6VXNlcjE4MzQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1834108?v=4","gravatar_id":"","url":"https://api.github.com/users/georgeracu","html_url":"https://github.com/georgeracu","followers_url":"https://api.github.com/users/georgeracu/followers","following_url":"https://api.github.com/users/georgeracu/following{/other_user}","gists_url":"https://api.github.com/users/georgeracu/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeracu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeracu/subscriptions","organizations_url":"https://api.github.com/users/georgeracu/orgs","repos_url":"https://api.github.com/users/georgeracu/repos","events_url":"https://api.github.com/users/georgeracu/events{/privacy}","received_events_url":"https://api.github.com/users/georgeracu/received_events","type":"User","site_admin":false},"body":"- Most of the metadata can be accessed independent of a connected session.\r\nThis is done using the DatabaseLogin object. This metadata can be skipped if\r\nnot available so we will populate only what we can find.\r\n- We decided to avoid querying if the connection is null, as we observed that\r\nafter a database error, all subsequent calls to the profiler were using a\r\n`disconnected` database session. We don't need to use a connection, no matter\r\nwhat the status, so we will not use it at all.\r\n- Added DropWizard testing to write a small unit test to check that the\r\nproperties are set","created_at":"2019-02-11T17:39:33Z","updated_at":"2019-02-12T14:51:37Z","closed_at":"2019-02-12T14:51:36Z","merged_at":"2019-02-12T14:51:36Z","merge_commit_sha":"e5dc80d002d016f0ece14ec897cfbdc6998fb9bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/pay-java-commons/pulls/71/commits","review_comments_url":"https://api.github.com/repos/alphagov/pay-java-commons/pulls/71/comments","review_comment_url":"https://api.github.com/repos/alphagov/pay-java-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/pay-java-commons/issues/71/comments","statuses_url":"https://api.github.com/repos/alphagov/pay-java-commons/statuses/3da1a20dba2f5418cfd3c3d30a714c8059679845","head":{"label":"alphagov:PP-4790-protect-xraysessionprofiler-from-null","ref":"PP-4790-protect-xraysessionprofiler-from-null","sha":"3da1a20dba2f5418cfd3c3d30a714c8059679845","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":102705461,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MDU0NjE=","name":"pay-java-commons","full_name":"alphagov/pay-java-commons","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/pay-java-commons","description":"pay reusable java artifacts","fork":false,"url":"https://api.github.com/repos/alphagov/pay-java-commons","forks_url":"https://api.github.com/repos/alphagov/pay-java-commons/forks","keys_url":"https://api.github.com/repos/alphagov/pay-java-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-java-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-java-commons/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-java-commons/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-java-commons/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-java-commons/events","assignees_url":"https://api.github.com/repos/alphagov/pay-java-commons/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-java-commons/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-java-commons/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-java-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-java-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-java-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-java-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-java-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-java-commons/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-java-commons/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-java-commons/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-java-commons/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-java-commons/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-java-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-java-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-java-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-java-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-java-commons/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-java-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-java-commons/merges","archive_url":"https://api.github.com/repos/alphagov/pay-java-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-java-commons/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-java-commons/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-java-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-java-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-java-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-java-commons/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-java-commons/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-java-commons/deployments","created_at":"2017-09-07T07:27:25Z","updated_at":"2019-02-08T10:24:15Z","pushed_at":"2019-02-12T14:51:36Z","git_url":"git://github.com/alphagov/pay-java-commons.git","ssh_url":"git@github.com:alphagov/pay-java-commons.git","clone_url":"https://github.com/alphagov/pay-java-commons.git","svn_url":"https://github.com/alphagov/pay-java-commons","homepage":null,"size":204,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"067ad47f4eb7d8445531d5d8507fc1be0e5dcced","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":102705461,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MDU0NjE=","name":"pay-java-commons","full_name":"alphagov/pay-java-commons","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/pay-java-commons","description":"pay reusable java artifacts","fork":false,"url":"https://api.github.com/repos/alphagov/pay-java-commons","forks_url":"https://api.github.com/repos/alphagov/pay-java-commons/forks","keys_url":"https://api.github.com/repos/alphagov/pay-java-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-java-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-java-commons/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-java-commons/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-java-commons/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-java-commons/events","assignees_url":"https://api.github.com/repos/alphagov/pay-java-commons/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-java-commons/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-java-commons/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-java-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-java-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-java-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-java-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-java-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-java-commons/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-java-commons/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-java-commons/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-java-commons/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-java-commons/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-java-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-java-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-java-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-java-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-java-commons/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-java-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-java-commons/merges","archive_url":"https://api.github.com/repos/alphagov/pay-java-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-java-commons/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-java-commons/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-java-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-java-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-java-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-java-commons/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-java-commons/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-java-commons/deployments","created_at":"2017-09-07T07:27:25Z","updated_at":"2019-02-08T10:24:15Z","pushed_at":"2019-02-12T14:51:36Z","git_url":"git://github.com/alphagov/pay-java-commons.git","ssh_url":"git@github.com:alphagov/pay-java-commons.git","clone_url":"https://github.com/alphagov/pay-java-commons.git","svn_url":"https://github.com/alphagov/pay-java-commons","homepage":null,"size":204,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/pay-java-commons/pulls/71"},"html":{"href":"https://github.com/alphagov/pay-java-commons/pull/71"},"issue":{"href":"https://api.github.com/repos/alphagov/pay-java-commons/issues/71"},"comments":{"href":"https://api.github.com/repos/alphagov/pay-java-commons/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/pay-java-commons/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/pay-java-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/pay-java-commons/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/pay-java-commons/statuses/3da1a20dba2f5418cfd3c3d30a714c8059679845"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"georgeracu","id":1834108,"node_id":"MDQ6VXNlcjE4MzQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1834108?v=4","gravatar_id":"","url":"https://api.github.com/users/georgeracu","html_url":"https://github.com/georgeracu","followers_url":"https://api.github.com/users/georgeracu/followers","following_url":"https://api.github.com/users/georgeracu/following{/other_user}","gists_url":"https://api.github.com/users/georgeracu/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeracu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeracu/subscriptions","organizations_url":"https://api.github.com/users/georgeracu/orgs","repos_url":"https://api.github.com/users/georgeracu/repos","events_url":"https://api.github.com/users/georgeracu/events{/privacy}","received_events_url":"https://api.github.com/users/georgeracu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":7,"maintainer_can_modify":false,"commits":2,"additions":169,"deletions":37,"changed_files":3}}
{"actor":{"display_login":"georgeracu"}}