{"action":"closed","number":1915,"pull_request":{"url":"https://api.github.com/repos/amethyst/amethyst/pulls/1915","id":313038128,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEzMDM4MTI4","html_url":"https://github.com/amethyst/amethyst/pull/1915","diff_url":"https://github.com/amethyst/amethyst/pull/1915.diff","patch_url":"https://github.com/amethyst/amethyst/pull/1915.patch","issue_url":"https://api.github.com/repos/amethyst/amethyst/issues/1915","number":1915,"state":"closed","locked":false,"title":"[FEATURE] Custom Logger Formatter","user":{"login":"nalshihabi","id":8733531,"node_id":"MDQ6VXNlcjg3MzM1MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/8733531?v=4","gravatar_id":"","url":"https://api.github.com/users/nalshihabi","html_url":"https://github.com/nalshihabi","followers_url":"https://api.github.com/users/nalshihabi/followers","following_url":"https://api.github.com/users/nalshihabi/following{/other_user}","gists_url":"https://api.github.com/users/nalshihabi/gists{/gist_id}","starred_url":"https://api.github.com/users/nalshihabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalshihabi/subscriptions","organizations_url":"https://api.github.com/users/nalshihabi/orgs","repos_url":"https://api.github.com/users/nalshihabi/repos","events_url":"https://api.github.com/users/nalshihabi/events{/privacy}","received_events_url":"https://api.github.com/users/nalshihabi/received_events","type":"User","site_admin":false},"body":"Implements #1889 \r\n\r\n## Description\r\n\r\nAdd a custom log formatter option to the Amethyst logger so that instead of setting up their own logger to use their own formatting, a developer using Amethyst can just pass in their own formatter to the Amethyst logger.\r\n\r\n## Additions\r\n\r\n- `Logger::new_formatter`: a different constructor for Amethyst logger where a custom formatter can be passed as a parameter.\r\n- `Logger::from_config_formatter`: a different function for the Logger for starting a new Logger with a config and a formatter.\r\n- `Logger::new_with_config`: helper function that much of the functionality of `Logger::from_config` was moved into from `Logger::from_config` in order to allow for the functionality to be reused easily by `Logger::from_config_formatter`.\r\n\r\n## Removals\r\n\r\nNone\r\n\r\n## Modifications\r\n\r\n- `Logger::from_config`: Changed to just call `Logger::from_config_formatter` with valid parameters for the helper function.\r\n\r\n## PR Checklist\r\n\r\nBy placing an x in the boxes I certify that I have:\r\n\r\n- [ ] Updated the content of the book if this PR would make the book outdated.\r\n- [ ] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment.\r\n- [ ] Added unit tests for new code added in this PR.\r\n- [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme.\r\n\r\nIf this modified or created any rs files:\r\n\r\n- [x] Ran `cargo +stable fmt --all`\r\n- [x] Ran `cargo clippy --all --features \"empty\"`\r\n- [x] Ran `cargo test --all --features \"empty\"`\r\n","created_at":"2019-09-01T14:26:09Z","updated_at":"2019-09-03T08:27:23Z","closed_at":"2019-09-03T08:27:23Z","merged_at":"2019-09-03T08:27:23Z","merge_commit_sha":"950b0c56756337caa67df43041fc8a10ce5ed257","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/amethyst/amethyst/pulls/1915/commits","review_comments_url":"https://api.github.com/repos/amethyst/amethyst/pulls/1915/comments","review_comment_url":"https://api.github.com/repos/amethyst/amethyst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amethyst/amethyst/issues/1915/comments","statuses_url":"https://api.github.com/repos/amethyst/amethyst/statuses/950b0c56756337caa67df43041fc8a10ce5ed257","head":{"label":"nalshihabi:feat-custom-log-formatter","ref":"feat-custom-log-formatter","sha":"950b0c56756337caa67df43041fc8a10ce5ed257","user":{"login":"nalshihabi","id":8733531,"node_id":"MDQ6VXNlcjg3MzM1MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/8733531?v=4","gravatar_id":"","url":"https://api.github.com/users/nalshihabi","html_url":"https://github.com/nalshihabi","followers_url":"https://api.github.com/users/nalshihabi/followers","following_url":"https://api.github.com/users/nalshihabi/following{/other_user}","gists_url":"https://api.github.com/users/nalshihabi/gists{/gist_id}","starred_url":"https://api.github.com/users/nalshihabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalshihabi/subscriptions","organizations_url":"https://api.github.com/users/nalshihabi/orgs","repos_url":"https://api.github.com/users/nalshihabi/repos","events_url":"https://api.github.com/users/nalshihabi/events{/privacy}","received_events_url":"https://api.github.com/users/nalshihabi/received_events","type":"User","site_admin":false},"repo":{"id":204754973,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ3NTQ5NzM=","name":"amethyst","full_name":"nalshihabi/amethyst","private":false,"owner":{"login":"nalshihabi","id":8733531,"node_id":"MDQ6VXNlcjg3MzM1MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/8733531?v=4","gravatar_id":"","url":"https://api.github.com/users/nalshihabi","html_url":"https://github.com/nalshihabi","followers_url":"https://api.github.com/users/nalshihabi/followers","following_url":"https://api.github.com/users/nalshihabi/following{/other_user}","gists_url":"https://api.github.com/users/nalshihabi/gists{/gist_id}","starred_url":"https://api.github.com/users/nalshihabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalshihabi/subscriptions","organizations_url":"https://api.github.com/users/nalshihabi/orgs","repos_url":"https://api.github.com/users/nalshihabi/repos","events_url":"https://api.github.com/users/nalshihabi/events{/privacy}","received_events_url":"https://api.github.com/users/nalshihabi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nalshihabi/amethyst","description":"Data-oriented and data-driven game engine written in Rust","fork":true,"url":"https://api.github.com/repos/nalshihabi/amethyst","forks_url":"https://api.github.com/repos/nalshihabi/amethyst/forks","keys_url":"https://api.github.com/repos/nalshihabi/amethyst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nalshihabi/amethyst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nalshihabi/amethyst/teams","hooks_url":"https://api.github.com/repos/nalshihabi/amethyst/hooks","issue_events_url":"https://api.github.com/repos/nalshihabi/amethyst/issues/events{/number}","events_url":"https://api.github.com/repos/nalshihabi/amethyst/events","assignees_url":"https://api.github.com/repos/nalshihabi/amethyst/assignees{/user}","branches_url":"https://api.github.com/repos/nalshihabi/amethyst/branches{/branch}","tags_url":"https://api.github.com/repos/nalshihabi/amethyst/tags","blobs_url":"https://api.github.com/repos/nalshihabi/amethyst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nalshihabi/amethyst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nalshihabi/amethyst/git/refs{/sha}","trees_url":"https://api.github.com/repos/nalshihabi/amethyst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nalshihabi/amethyst/statuses/{sha}","languages_url":"https://api.github.com/repos/nalshihabi/amethyst/languages","stargazers_url":"https://api.github.com/repos/nalshihabi/amethyst/stargazers","contributors_url":"https://api.github.com/repos/nalshihabi/amethyst/contributors","subscribers_url":"https://api.github.com/repos/nalshihabi/amethyst/subscribers","subscription_url":"https://api.github.com/repos/nalshihabi/amethyst/subscription","commits_url":"https://api.github.com/repos/nalshihabi/amethyst/commits{/sha}","git_commits_url":"https://api.github.com/repos/nalshihabi/amethyst/git/commits{/sha}","comments_url":"https://api.github.com/repos/nalshihabi/amethyst/comments{/number}","issue_comment_url":"https://api.github.com/repos/nalshihabi/amethyst/issues/comments{/number}","contents_url":"https://api.github.com/repos/nalshihabi/amethyst/contents/{+path}","compare_url":"https://api.github.com/repos/nalshihabi/amethyst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nalshihabi/amethyst/merges","archive_url":"https://api.github.com/repos/nalshihabi/amethyst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nalshihabi/amethyst/downloads","issues_url":"https://api.github.com/repos/nalshihabi/amethyst/issues{/number}","pulls_url":"https://api.github.com/repos/nalshihabi/amethyst/pulls{/number}","milestones_url":"https://api.github.com/repos/nalshihabi/amethyst/milestones{/number}","notifications_url":"https://api.github.com/repos/nalshihabi/amethyst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nalshihabi/amethyst/labels{/name}","releases_url":"https://api.github.com/repos/nalshihabi/amethyst/releases{/id}","deployments_url":"https://api.github.com/repos/nalshihabi/amethyst/deployments","created_at":"2019-08-27T17:28:50Z","updated_at":"2019-08-27T17:28:54Z","pushed_at":"2019-09-01T14:42:19Z","git_url":"git://github.com/nalshihabi/amethyst.git","ssh_url":"git@github.com:nalshihabi/amethyst.git","clone_url":"https://github.com/nalshihabi/amethyst.git","svn_url":"https://github.com/nalshihabi/amethyst","homepage":"https://amethyst.rs/","size":38180,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amethyst:master","ref":"master","sha":"4bdfb10d69f0bed4091d2ec997633bca00b0985b","user":{"login":"amethyst","id":17814736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODE0NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/17814736?v=4","gravatar_id":"","url":"https://api.github.com/users/amethyst","html_url":"https://github.com/amethyst","followers_url":"https://api.github.com/users/amethyst/followers","following_url":"https://api.github.com/users/amethyst/following{/other_user}","gists_url":"https://api.github.com/users/amethyst/gists{/gist_id}","starred_url":"https://api.github.com/users/amethyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amethyst/subscriptions","organizations_url":"https://api.github.com/users/amethyst/orgs","repos_url":"https://api.github.com/users/amethyst/repos","events_url":"https://api.github.com/users/amethyst/events{/privacy}","received_events_url":"https://api.github.com/users/amethyst/received_events","type":"Organization","site_admin":false},"repo":{"id":48364554,"node_id":"MDEwOlJlcG9zaXRvcnk0ODM2NDU1NA==","name":"amethyst","full_name":"amethyst/amethyst","private":false,"owner":{"login":"amethyst","id":17814736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODE0NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/17814736?v=4","gravatar_id":"","url":"https://api.github.com/users/amethyst","html_url":"https://github.com/amethyst","followers_url":"https://api.github.com/users/amethyst/followers","following_url":"https://api.github.com/users/amethyst/following{/other_user}","gists_url":"https://api.github.com/users/amethyst/gists{/gist_id}","starred_url":"https://api.github.com/users/amethyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amethyst/subscriptions","organizations_url":"https://api.github.com/users/amethyst/orgs","repos_url":"https://api.github.com/users/amethyst/repos","events_url":"https://api.github.com/users/amethyst/events{/privacy}","received_events_url":"https://api.github.com/users/amethyst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/amethyst/amethyst","description":"Data-oriented and data-driven game engine written in Rust","fork":false,"url":"https://api.github.com/repos/amethyst/amethyst","forks_url":"https://api.github.com/repos/amethyst/amethyst/forks","keys_url":"https://api.github.com/repos/amethyst/amethyst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amethyst/amethyst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amethyst/amethyst/teams","hooks_url":"https://api.github.com/repos/amethyst/amethyst/hooks","issue_events_url":"https://api.github.com/repos/amethyst/amethyst/issues/events{/number}","events_url":"https://api.github.com/repos/amethyst/amethyst/events","assignees_url":"https://api.github.com/repos/amethyst/amethyst/assignees{/user}","branches_url":"https://api.github.com/repos/amethyst/amethyst/branches{/branch}","tags_url":"https://api.github.com/repos/amethyst/amethyst/tags","blobs_url":"https://api.github.com/repos/amethyst/amethyst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amethyst/amethyst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amethyst/amethyst/git/refs{/sha}","trees_url":"https://api.github.com/repos/amethyst/amethyst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amethyst/amethyst/statuses/{sha}","languages_url":"https://api.github.com/repos/amethyst/amethyst/languages","stargazers_url":"https://api.github.com/repos/amethyst/amethyst/stargazers","contributors_url":"https://api.github.com/repos/amethyst/amethyst/contributors","subscribers_url":"https://api.github.com/repos/amethyst/amethyst/subscribers","subscription_url":"https://api.github.com/repos/amethyst/amethyst/subscription","commits_url":"https://api.github.com/repos/amethyst/amethyst/commits{/sha}","git_commits_url":"https://api.github.com/repos/amethyst/amethyst/git/commits{/sha}","comments_url":"https://api.github.com/repos/amethyst/amethyst/comments{/number}","issue_comment_url":"https://api.github.com/repos/amethyst/amethyst/issues/comments{/number}","contents_url":"https://api.github.com/repos/amethyst/amethyst/contents/{+path}","compare_url":"https://api.github.com/repos/amethyst/amethyst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amethyst/amethyst/merges","archive_url":"https://api.github.com/repos/amethyst/amethyst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amethyst/amethyst/downloads","issues_url":"https://api.github.com/repos/amethyst/amethyst/issues{/number}","pulls_url":"https://api.github.com/repos/amethyst/amethyst/pulls{/number}","milestones_url":"https://api.github.com/repos/amethyst/amethyst/milestones{/number}","notifications_url":"https://api.github.com/repos/amethyst/amethyst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amethyst/amethyst/labels{/name}","releases_url":"https://api.github.com/repos/amethyst/amethyst/releases{/id}","deployments_url":"https://api.github.com/repos/amethyst/amethyst/deployments","created_at":"2015-12-21T09:59:29Z","updated_at":"2019-09-03T08:27:20Z","pushed_at":"2019-09-03T08:27:17Z","git_url":"git://github.com/amethyst/amethyst.git","ssh_url":"git@github.com:amethyst/amethyst.git","clone_url":"https://github.com/amethyst/amethyst.git","svn_url":"https://github.com/amethyst/amethyst","homepage":"https://amethyst.rs/","size":41281,"stargazers_count":4170,"watchers_count":4170,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":458,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":458,"open_issues":83,"watchers":4170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/1915"},"html":{"href":"https://github.com/amethyst/amethyst/pull/1915"},"issue":{"href":"https://api.github.com/repos/amethyst/amethyst/issues/1915"},"comments":{"href":"https://api.github.com/repos/amethyst/amethyst/issues/1915/comments"},"review_comments":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/1915/comments"},"review_comment":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/1915/commits"},"statuses":{"href":"https://api.github.com/repos/amethyst/amethyst/statuses/950b0c56756337caa67df43041fc8a10ce5ed257"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bors[bot]","id":26634292,"node_id":"MDM6Qm90MjY2MzQyOTI=","avatar_url":"https://avatars3.githubusercontent.com/in/1847?v=4","gravatar_id":"","url":"https://api.github.com/users/bors%5Bbot%5D","html_url":"https://github.com/apps/bors","followers_url":"https://api.github.com/users/bors%5Bbot%5D/followers","following_url":"https://api.github.com/users/bors%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/bors%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/bors%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/bors%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/bors%5Bbot%5D/repos","events_url":"https://api.github.com/users/bors%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/bors%5Bbot%5D/received_events","type":"Bot","site_admin":false},"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":42,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"bors"}}