{"action":"created","issue":{"url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/3893","repository_url":"https://api.github.com/repos/LiskHQ/lisk-sdk","labels_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/3893/labels{/name}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/3893/comments","events_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/3893/events","html_url":"https://github.com/LiskHQ/lisk-sdk/pull/3893","id":462028030,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyODI1NTkw","number":3893,"title":"Assign and verify transaction fees in Transactions domain - Closes #3860","user":{"login":"pablitovicente","id":502686,"node_id":"MDQ6VXNlcjUwMjY4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/502686?v=4","gravatar_id":"","url":"https://api.github.com/users/pablitovicente","html_url":"https://github.com/pablitovicente","followers_url":"https://api.github.com/users/pablitovicente/followers","following_url":"https://api.github.com/users/pablitovicente/following{/other_user}","gists_url":"https://api.github.com/users/pablitovicente/gists{/gist_id}","starred_url":"https://api.github.com/users/pablitovicente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablitovicente/subscriptions","organizations_url":"https://api.github.com/users/pablitovicente/orgs","repos_url":"https://api.github.com/users/pablitovicente/repos","events_url":"https://api.github.com/users/pablitovicente/events{/privacy}","received_events_url":"https://api.github.com/users/pablitovicente/received_events","type":"User","site_admin":false},"labels":[{"id":655482394,"node_id":"MDU6TGFiZWw2NTU0ODIzOTQ=","url":"https://api.github.com/repos/LiskHQ/lisk-sdk/labels/:eye:%20pending%20review","name":":eye: pending review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"pablitovicente","id":502686,"node_id":"MDQ6VXNlcjUwMjY4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/502686?v=4","gravatar_id":"","url":"https://api.github.com/users/pablitovicente","html_url":"https://github.com/pablitovicente","followers_url":"https://api.github.com/users/pablitovicente/followers","following_url":"https://api.github.com/users/pablitovicente/following{/other_user}","gists_url":"https://api.github.com/users/pablitovicente/gists{/gist_id}","starred_url":"https://api.github.com/users/pablitovicente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablitovicente/subscriptions","organizations_url":"https://api.github.com/users/pablitovicente/orgs","repos_url":"https://api.github.com/users/pablitovicente/repos","events_url":"https://api.github.com/users/pablitovicente/events{/privacy}","received_events_url":"https://api.github.com/users/pablitovicente/received_events","type":"User","site_admin":false},"assignees":[{"login":"pablitovicente","id":502686,"node_id":"MDQ6VXNlcjUwMjY4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/502686?v=4","gravatar_id":"","url":"https://api.github.com/users/pablitovicente","html_url":"https://github.com/pablitovicente","followers_url":"https://api.github.com/users/pablitovicente/followers","following_url":"https://api.github.com/users/pablitovicente/following{/other_user}","gists_url":"https://api.github.com/users/pablitovicente/gists{/gist_id}","starred_url":"https://api.github.com/users/pablitovicente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablitovicente/subscriptions","organizations_url":"https://api.github.com/users/pablitovicente/orgs","repos_url":"https://api.github.com/users/pablitovicente/repos","events_url":"https://api.github.com/users/pablitovicente/events{/privacy}","received_events_url":"https://api.github.com/users/pablitovicente/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2019-06-28T13:11:42Z","updated_at":"2019-07-03T12:35:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls/3893","html_url":"https://github.com/LiskHQ/lisk-sdk/pull/3893","diff_url":"https://github.com/LiskHQ/lisk-sdk/pull/3893.diff","patch_url":"https://github.com/LiskHQ/lisk-sdk/pull/3893.patch"},"body":"### What was the problem?\r\n\r\nFee as not a property that could be defined in the transaction\r\n\r\n### How did I fix it?\r\n\r\n- By adding static property `FEE`\r\n- By removing restriction of fee being greater than 0\r\n\r\n### How to test it?\r\n\r\nBuild should be green\r\n\r\n### Review checklist\r\n\r\n* The PR resolves #3860\r\n* All new code is covered with unit tests\r\n* All new code was formatted with Prettier\r\n* Linting passes\r\n* Tests pass\r\n* Commit messages follow the [commit guidelines](CONTRIBUTING.md#git-commit-messages)\r\n* Documentation has been added/updated\r\n"},"comment":{"url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/comments/508074309","html_url":"https://github.com/LiskHQ/lisk-sdk/pull/3893#issuecomment-508074309","issue_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/3893","id":508074309,"node_id":"MDEyOklzc3VlQ29tbWVudDUwODA3NDMwOQ==","user":{"login":"pablitovicente","id":502686,"node_id":"MDQ6VXNlcjUwMjY4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/502686?v=4","gravatar_id":"","url":"https://api.github.com/users/pablitovicente","html_url":"https://github.com/pablitovicente","followers_url":"https://api.github.com/users/pablitovicente/followers","following_url":"https://api.github.com/users/pablitovicente/following{/other_user}","gists_url":"https://api.github.com/users/pablitovicente/gists{/gist_id}","starred_url":"https://api.github.com/users/pablitovicente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablitovicente/subscriptions","organizations_url":"https://api.github.com/users/pablitovicente/orgs","repos_url":"https://api.github.com/users/pablitovicente/repos","events_url":"https://api.github.com/users/pablitovicente/events{/privacy}","received_events_url":"https://api.github.com/users/pablitovicente/received_events","type":"User","site_admin":false},"created_at":"2019-07-03T12:35:45Z","updated_at":"2019-07-03T12:35:45Z","author_association":"CONTRIBUTOR","body":"> `e.g. by creating a new static FEE property.` was a suggestion not a requirement. 😃\r\n\r\nBut `TYPE` is already implemented as a static property so I think that the idea was to implement as static property this kind of properties. So I guess that if would take the suggested path we should also refactor the previously merged PR with TYPE as static so as to normalize? "}}
{"actor":{"display_login":"pablitovicente"}}