{"action":"created","comment":{"url":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/comments/305996388","pull_request_review_id":265009549,"id":305996388,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTk5NjM4OA==","diff_hunk":"@@ -71,40 +44,74 @@\n \t\t</div>\n \n \t\t<!-- edit entry -->\n-\t\t<div v-if=\"item.edit\" class=\"app-navigation-entry-edit\">\n+\t\t<div v-if=\"editable\" class=\"app-navigation-entry-edit\">\n \t\t\t<form @submit.prevent.stop=\"item.edit.action\">\n-\t\t\t\t<input :placeholder=\"item.edit.text\" type=\"text\">\n+\t\t\t\t<input placeholder=\"placeholder\" type=\"text\">\n \t\t\t\t<input type=\"submit\" value=\"\" class=\"icon-confirm\">\n \t\t\t\t<input type=\"submit\" value=\"\" class=\"icon-close\"\n \t\t\t\t\t@click.stop.prevent=\"cancelEdit\">\n \t\t\t</form>\n \t\t</div>\n \n-\t\t<!-- if the item has children, inject the component with proper data -->\n-\t\t<ul v-if=\"item.children\">\n-\t\t\t<app-navigation-item v-for=\"(child, key) in item.children\" :key=\"key\" :item=\"child\" />\n+\t\t<!-- Icon or image from url -->\n+\t\t<a :class=\"[ !isIconUrl && bullet === '' ? icon : '' ]\" href=\"#\"\n+\t\t\t@click=\"handleClick\">","path":"src/components/AppNavigationItem/AppNavigationItem.vue","position":81,"original_position":81,"commit_id":"041825abe6f0b6438f82c29e8a95fce73c8527f2","original_commit_id":"041825abe6f0b6438f82c29e8a95fce73c8527f2","user":{"login":"skjnldsv","id":14975046,"node_id":"MDQ6VXNlcjE0OTc1MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\t\t\t@click=\"onClick\">\r\n```","created_at":"2019-07-22T19:33:07Z","updated_at":"2019-07-22T19:33:07Z","html_url":"https://github.com/nextcloud/nextcloud-vue/pull/486#discussion_r305996388","pull_request_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/486","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/comments/305996388"},"html":{"href":"https://github.com/nextcloud/nextcloud-vue/pull/486#discussion_r305996388"},"pull_request":{"href":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/486"}}},"pull_request":{"url":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/486","id":298448708,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4NDQ4NzA4","html_url":"https://github.com/nextcloud/nextcloud-vue/pull/486","diff_url":"https://github.com/nextcloud/nextcloud-vue/pull/486.diff","patch_url":"https://github.com/nextcloud/nextcloud-vue/pull/486.patch","issue_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/issues/486","number":486,"state":"open","locked":false,"title":"Feature/470/split appnavigationitem into small components","user":{"login":"ma12-co","id":26852655,"node_id":"MDQ6VXNlcjI2ODUyNjU1","avatar_url":"https://avatars3.githubusercontent.com/u/26852655?v=4","gravatar_id":"","url":"https://api.github.com/users/ma12-co","html_url":"https://github.com/ma12-co","followers_url":"https://api.github.com/users/ma12-co/followers","following_url":"https://api.github.com/users/ma12-co/following{/other_user}","gists_url":"https://api.github.com/users/ma12-co/gists{/gist_id}","starred_url":"https://api.github.com/users/ma12-co/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ma12-co/subscriptions","organizations_url":"https://api.github.com/users/ma12-co/orgs","repos_url":"https://api.github.com/users/ma12-co/repos","events_url":"https://api.github.com/users/ma12-co/events{/privacy}","received_events_url":"https://api.github.com/users/ma12-co/received_events","type":"User","site_admin":false},"body":"Issue #470 ","created_at":"2019-07-17T12:35:29Z","updated_at":"2019-07-22T19:33:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f449a15140b9e5d0ff1023037b8fea83953dbc0","assignee":{"login":"ma12-co","id":26852655,"node_id":"MDQ6VXNlcjI2ODUyNjU1","avatar_url":"https://avatars3.githubusercontent.com/u/26852655?v=4","gravatar_id":"","url":"https://api.github.com/users/ma12-co","html_url":"https://github.com/ma12-co","followers_url":"https://api.github.com/users/ma12-co/followers","following_url":"https://api.github.com/users/ma12-co/following{/other_user}","gists_url":"https://api.github.com/users/ma12-co/gists{/gist_id}","starred_url":"https://api.github.com/users/ma12-co/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ma12-co/subscriptions","organizations_url":"https://api.github.com/users/ma12-co/orgs","repos_url":"https://api.github.com/users/ma12-co/repos","events_url":"https://api.github.com/users/ma12-co/events{/privacy}","received_events_url":"https://api.github.com/users/ma12-co/received_events","type":"User","site_admin":false},"assignees":[{"login":"ma12-co","id":26852655,"node_id":"MDQ6VXNlcjI2ODUyNjU1","avatar_url":"https://avatars3.githubusercontent.com/u/26852655?v=4","gravatar_id":"","url":"https://api.github.com/users/ma12-co","html_url":"https://github.com/ma12-co","followers_url":"https://api.github.com/users/ma12-co/followers","following_url":"https://api.github.com/users/ma12-co/following{/other_user}","gists_url":"https://api.github.com/users/ma12-co/gists{/gist_id}","starred_url":"https://api.github.com/users/ma12-co/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ma12-co/subscriptions","organizations_url":"https://api.github.com/users/ma12-co/orgs","repos_url":"https://api.github.com/users/ma12-co/repos","events_url":"https://api.github.com/users/ma12-co/events{/privacy}","received_events_url":"https://api.github.com/users/ma12-co/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ChristophWurst","id":1374172,"node_id":"MDQ6VXNlcjEzNzQxNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1374172?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristophWurst","html_url":"https://github.com/ChristophWurst","followers_url":"https://api.github.com/users/ChristophWurst/followers","following_url":"https://api.github.com/users/ChristophWurst/following{/other_user}","gists_url":"https://api.github.com/users/ChristophWurst/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristophWurst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristophWurst/subscriptions","organizations_url":"https://api.github.com/users/ChristophWurst/orgs","repos_url":"https://api.github.com/users/ChristophWurst/repos","events_url":"https://api.github.com/users/ChristophWurst/events{/privacy}","received_events_url":"https://api.github.com/users/ChristophWurst/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1029661725,"node_id":"MDU6TGFiZWwxMDI5NjYxNzI1","url":"https://api.github.com/repos/nextcloud/nextcloud-vue/labels/2.%20developing","name":"2. developing","color":"0052cc","default":false},{"id":1029663957,"node_id":"MDU6TGFiZWwxMDI5NjYzOTU3","url":"https://api.github.com/repos/nextcloud/nextcloud-vue/labels/feature:%20app-navigation","name":"feature: app-navigation","color":"5293d3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/486/commits","review_comments_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/486/comments","review_comment_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/issues/486/comments","statuses_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/statuses/041825abe6f0b6438f82c29e8a95fce73c8527f2","head":{"label":"nextcloud:feature/470/split-appnavigationitem-into-small-components","ref":"feature/470/split-appnavigationitem-into-small-components","sha":"041825abe6f0b6438f82c29e8a95fce73c8527f2","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":129395002,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzOTUwMDI=","name":"nextcloud-vue","full_name":"nextcloud/nextcloud-vue","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/nextcloud-vue","description":"🍱 Vue.js components for Nextcloud app development  ✌","fork":false,"url":"https://api.github.com/repos/nextcloud/nextcloud-vue","forks_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/forks","keys_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/teams","hooks_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/events","assignees_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/tags","blobs_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/languages","stargazers_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/subscription","commits_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/merges","archive_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/downloads","issues_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/deployments","created_at":"2018-04-13T11:48:45Z","updated_at":"2019-07-21T19:33:30Z","pushed_at":"2019-07-22T18:23:47Z","git_url":"git://github.com/nextcloud/nextcloud-vue.git","ssh_url":"git@github.com:nextcloud/nextcloud-vue.git","clone_url":"https://github.com/nextcloud/nextcloud-vue.git","svn_url":"https://github.com/nextcloud/nextcloud-vue","homepage":"","size":6980,"stargazers_count":31,"watchers_count":31,"language":"Vue","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":9,"open_issues":24,"watchers":31,"default_branch":"master"}},"base":{"label":"nextcloud:master","ref":"master","sha":"fe4e53f6b1335422571dca579149c7cee2078857","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":129395002,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzOTUwMDI=","name":"nextcloud-vue","full_name":"nextcloud/nextcloud-vue","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/nextcloud-vue","description":"🍱 Vue.js components for Nextcloud app development  ✌","fork":false,"url":"https://api.github.com/repos/nextcloud/nextcloud-vue","forks_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/forks","keys_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/teams","hooks_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/events","assignees_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/tags","blobs_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/languages","stargazers_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/subscription","commits_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/merges","archive_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/downloads","issues_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/nextcloud-vue/deployments","created_at":"2018-04-13T11:48:45Z","updated_at":"2019-07-21T19:33:30Z","pushed_at":"2019-07-22T18:23:47Z","git_url":"git://github.com/nextcloud/nextcloud-vue.git","ssh_url":"git@github.com:nextcloud/nextcloud-vue.git","clone_url":"https://github.com/nextcloud/nextcloud-vue.git","svn_url":"https://github.com/nextcloud/nextcloud-vue","homepage":"","size":6980,"stargazers_count":31,"watchers_count":31,"language":"Vue","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":9,"open_issues":24,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/486"},"html":{"href":"https://github.com/nextcloud/nextcloud-vue/pull/486"},"issue":{"href":"https://api.github.com/repos/nextcloud/nextcloud-vue/issues/486"},"comments":{"href":"https://api.github.com/repos/nextcloud/nextcloud-vue/issues/486/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/486/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/nextcloud-vue/pulls/486/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/nextcloud-vue/statuses/041825abe6f0b6438f82c29e8a95fce73c8527f2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"skjnldsv"}}