{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/283509565","pull_request_review_id":236883080,"id":283509565,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzUwOTU2NQ==","diff_hunk":"@@ -1790,13 +1791,20 @@ impl Window {\n                 // then put it in the delaying load events mode.\n                 self.window_proxy().start_delaying_load_events_mode();\n             }\n-            self.main_thread_script_chan()\n-                .send(MainThreadScriptMsg::Navigate(\n-                    pipeline_id,\n-                    LoadData::new(url, Some(pipeline_id), Some(referrer), referrer_policy),\n-                    replace,\n-                ))\n-                .unwrap();\n+            // TODO: step 11, navigationType.\n+            // Step 12, 13\n+            let load_data = if let Some(mut load_data) = load_data {","path":"components/script/dom/window.rs","position":33,"original_position":33,"commit_id":"0bcdb62834d3c1eed3f9e481fd5dadbd67283a5f","original_commit_id":"0bcdb62834d3c1eed3f9e481fd5dadbd67283a5f","user":{"login":"Manishearth","id":1617736,"node_id":"MDQ6VXNlcjE2MTc3MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1617736?v=4","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"body":"Should we just replace the parameters of this function with a single `load_data`? Is there a reason to have both?","created_at":"2019-05-13T19:55:47Z","updated_at":"2019-05-13T19:56:02Z","html_url":"https://github.com/servo/servo/pull/23368#discussion_r283509565","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/23368","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/283509565"},"html":{"href":"https://github.com/servo/servo/pull/23368#discussion_r283509565"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/23368"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/23368","id":278044489,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4MDQ0NDg5","html_url":"https://github.com/servo/servo/pull/23368","diff_url":"https://github.com/servo/servo/pull/23368.diff","patch_url":"https://github.com/servo/servo/pull/23368.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/23368","number":23368,"state":"open","locked":false,"title":"[WIP] Clean-up navigation","user":{"login":"gterzian","id":2792687,"node_id":"MDQ6VXNlcjI3OTI2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/2792687?v=4","gravatar_id":"","url":"https://api.github.com/users/gterzian","html_url":"https://github.com/gterzian","followers_url":"https://api.github.com/users/gterzian/followers","following_url":"https://api.github.com/users/gterzian/following{/other_user}","gists_url":"https://api.github.com/users/gterzian/gists{/gist_id}","starred_url":"https://api.github.com/users/gterzian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gterzian/subscriptions","organizations_url":"https://api.github.com/users/gterzian/orgs","repos_url":"https://api.github.com/users/gterzian/repos","events_url":"https://api.github.com/users/gterzian/events{/privacy}","received_events_url":"https://api.github.com/users/gterzian/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n1. Navigation as a result of following a hyperlink should be done in a task: https://html.spec.whatwg.org/multipage/links.html#following-hyperlinks:dom-manipulation-task-source\r\n2. The javascript url navigation should also be done in a task: https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigating-across-documents:dom-manipulation-task-source\r\n3. In `window.load_url`, it seems there is no need to send a message to the script-thread(the entirety of `load_url` should instead be done in a task when appropriate), so we can just do that last part \"sync\" by calling a method on the script, which will send a message to the constellation(for the parallel navigation steps), or queue task(for the JS navigation), as appropriate. \r\n4. Separate the \"normal\" navigation flow from the handling of \"navigate an iframe\" message from constellation, since doing everything in one method as was previously done with `handle_navigate`, is confusing. \r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->\r\n- [ ] `./mach build -d` does not report any errors\r\n- [ ] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #___ (GitHub issue number if applicable)\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [ ] These changes do not require tests because ___\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/23368)\n<!-- Reviewable:end -->\n","created_at":"2019-05-12T10:49:19Z","updated_at":"2019-05-13T19:56:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcf2fda029827621f868db27204bd32f6a476637","assignee":{"login":"Manishearth","id":1617736,"node_id":"MDQ6VXNlcjE2MTc3MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1617736?v=4","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"assignees":[{"login":"Manishearth","id":1617736,"node_id":"MDQ6VXNlcjE2MTc3MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1617736?v=4","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":152310043,"node_id":"MDU6TGFiZWwxNTIzMTAwNDM=","url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/23368/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/23368/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/23368/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/0bcdb62834d3c1eed3f9e481fd5dadbd67283a5f","head":{"label":"gterzian:clean_up_navigation","ref":"clean_up_navigation","sha":"0bcdb62834d3c1eed3f9e481fd5dadbd67283a5f","user":{"login":"gterzian","id":2792687,"node_id":"MDQ6VXNlcjI3OTI2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/2792687?v=4","gravatar_id":"","url":"https://api.github.com/users/gterzian","html_url":"https://github.com/gterzian","followers_url":"https://api.github.com/users/gterzian/followers","following_url":"https://api.github.com/users/gterzian/following{/other_user}","gists_url":"https://api.github.com/users/gterzian/gists{/gist_id}","starred_url":"https://api.github.com/users/gterzian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gterzian/subscriptions","organizations_url":"https://api.github.com/users/gterzian/orgs","repos_url":"https://api.github.com/users/gterzian/repos","events_url":"https://api.github.com/users/gterzian/events{/privacy}","received_events_url":"https://api.github.com/users/gterzian/received_events","type":"User","site_admin":false},"repo":{"id":69109740,"node_id":"MDEwOlJlcG9zaXRvcnk2OTEwOTc0MA==","name":"servo","full_name":"gterzian/servo","private":false,"owner":{"login":"gterzian","id":2792687,"node_id":"MDQ6VXNlcjI3OTI2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/2792687?v=4","gravatar_id":"","url":"https://api.github.com/users/gterzian","html_url":"https://github.com/gterzian","followers_url":"https://api.github.com/users/gterzian/followers","following_url":"https://api.github.com/users/gterzian/following{/other_user}","gists_url":"https://api.github.com/users/gterzian/gists{/gist_id}","starred_url":"https://api.github.com/users/gterzian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gterzian/subscriptions","organizations_url":"https://api.github.com/users/gterzian/orgs","repos_url":"https://api.github.com/users/gterzian/repos","events_url":"https://api.github.com/users/gterzian/events{/privacy}","received_events_url":"https://api.github.com/users/gterzian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gterzian/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/gterzian/servo","forks_url":"https://api.github.com/repos/gterzian/servo/forks","keys_url":"https://api.github.com/repos/gterzian/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gterzian/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gterzian/servo/teams","hooks_url":"https://api.github.com/repos/gterzian/servo/hooks","issue_events_url":"https://api.github.com/repos/gterzian/servo/issues/events{/number}","events_url":"https://api.github.com/repos/gterzian/servo/events","assignees_url":"https://api.github.com/repos/gterzian/servo/assignees{/user}","branches_url":"https://api.github.com/repos/gterzian/servo/branches{/branch}","tags_url":"https://api.github.com/repos/gterzian/servo/tags","blobs_url":"https://api.github.com/repos/gterzian/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gterzian/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gterzian/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gterzian/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gterzian/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/gterzian/servo/languages","stargazers_url":"https://api.github.com/repos/gterzian/servo/stargazers","contributors_url":"https://api.github.com/repos/gterzian/servo/contributors","subscribers_url":"https://api.github.com/repos/gterzian/servo/subscribers","subscription_url":"https://api.github.com/repos/gterzian/servo/subscription","commits_url":"https://api.github.com/repos/gterzian/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gterzian/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gterzian/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gterzian/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gterzian/servo/contents/{+path}","compare_url":"https://api.github.com/repos/gterzian/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gterzian/servo/merges","archive_url":"https://api.github.com/repos/gterzian/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gterzian/servo/downloads","issues_url":"https://api.github.com/repos/gterzian/servo/issues{/number}","pulls_url":"https://api.github.com/repos/gterzian/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/gterzian/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/gterzian/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gterzian/servo/labels{/name}","releases_url":"https://api.github.com/repos/gterzian/servo/releases{/id}","deployments_url":"https://api.github.com/repos/gterzian/servo/deployments","created_at":"2016-09-24T15:15:52Z","updated_at":"2018-08-24T18:34:33Z","pushed_at":"2019-05-13T15:00:02Z","git_url":"git://github.com/gterzian/servo.git","ssh_url":"git@github.com:gterzian/servo.git","clone_url":"https://github.com/gterzian/servo.git","svn_url":"https://github.com/gterzian/servo","homepage":"https://servo.org/","size":667968,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"965f57e3f8011dd7bdc61b438f95eeb87748319d","user":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"node_id":"MDEwOlJlcG9zaXRvcnkzMzkwMjQz","name":"servo","full_name":"servo/servo","private":false,"owner":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2019-05-13T19:44:07Z","pushed_at":"2019-05-13T19:39:49Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":898277,"stargazers_count":14039,"watchers_count":14039,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2150,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2795,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2150,"open_issues":2795,"watchers":14039,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/23368"},"html":{"href":"https://github.com/servo/servo/pull/23368"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/23368"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/23368/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/23368/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/23368/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/0bcdb62834d3c1eed3f9e481fd5dadbd67283a5f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Manishearth"}}