{"action":"closed","number":227,"pull_request":{"url":"https://api.github.com/repos/getsentry/semaphore/pulls/227","id":310386770,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwMzg2Nzcw","html_url":"https://github.com/getsentry/semaphore/pull/227","diff_url":"https://github.com/getsentry/semaphore/pull/227.diff","patch_url":"https://github.com/getsentry/semaphore/pull/227.patch","issue_url":"https://api.github.com/repos/getsentry/semaphore/issues/227","number":227,"state":"closed","locked":false,"title":"feat: Implement data scrubbers in Relay","user":{"login":"untitaker","id":837573,"node_id":"MDQ6VXNlcjgzNzU3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/837573?v=4","gravatar_id":"","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"body":"Add function to convert datascrubbing config into PII config, apply that PII config in Relay.\r\n\r\nThis was mostly an exercise to see if our PII config format is powerful enough to migrate users from datascrubbers, and now it actually is.\r\n\r\nAlso fix a few bugs in PII processor and make it simpler (it's an older piece of code that doesn't make use of the new `before_process` hook on the processor trait).\r\n\r\n- [x] Get rid of this function and just emit datascrubbing config in Sentry: https://github.com/getsentry/sentry/blob/602f41c553efea0409af659cff52d8baa817a9dc/src/sentry/relay/config.py#L290 (PR: https://github.com/getsentry/sentry/pull/14491)","created_at":"2019-08-23T13:26:38Z","updated_at":"2019-08-29T17:33:40Z","closed_at":"2019-08-29T17:33:40Z","merged_at":"2019-08-29T17:33:40Z","merge_commit_sha":"8e5ac85fe6f87232ae87549b472d70131c8c75b8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mitsuhiko","id":7396,"node_id":"MDQ6VXNlcjczOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7396?v=4","gravatar_id":"","url":"https://api.github.com/users/mitsuhiko","html_url":"https://github.com/mitsuhiko","followers_url":"https://api.github.com/users/mitsuhiko/followers","following_url":"https://api.github.com/users/mitsuhiko/following{/other_user}","gists_url":"https://api.github.com/users/mitsuhiko/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsuhiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsuhiko/subscriptions","organizations_url":"https://api.github.com/users/mitsuhiko/orgs","repos_url":"https://api.github.com/users/mitsuhiko/repos","events_url":"https://api.github.com/users/mitsuhiko/events{/privacy}","received_events_url":"https://api.github.com/users/mitsuhiko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/semaphore/pulls/227/commits","review_comments_url":"https://api.github.com/repos/getsentry/semaphore/pulls/227/comments","review_comment_url":"https://api.github.com/repos/getsentry/semaphore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/semaphore/issues/227/comments","statuses_url":"https://api.github.com/repos/getsentry/semaphore/statuses/7cc8cc336e2eeab8033d75e94c5a30b1648dd1a7","head":{"label":"getsentry:feat/datascrubbing","ref":"feat/datascrubbing","sha":"7cc8cc336e2eeab8033d75e94c5a30b1648dd1a7","user":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":117757315,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3NTczMTU=","name":"semaphore","full_name":"getsentry/semaphore","private":false,"owner":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getsentry/semaphore","description":"Using big shuttered boxes rather than the old-fashioned semaphore arms.","fork":false,"url":"https://api.github.com/repos/getsentry/semaphore","forks_url":"https://api.github.com/repos/getsentry/semaphore/forks","keys_url":"https://api.github.com/repos/getsentry/semaphore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/semaphore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/semaphore/teams","hooks_url":"https://api.github.com/repos/getsentry/semaphore/hooks","issue_events_url":"https://api.github.com/repos/getsentry/semaphore/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/semaphore/events","assignees_url":"https://api.github.com/repos/getsentry/semaphore/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/semaphore/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/semaphore/tags","blobs_url":"https://api.github.com/repos/getsentry/semaphore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/semaphore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/semaphore/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/semaphore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/semaphore/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/semaphore/languages","stargazers_url":"https://api.github.com/repos/getsentry/semaphore/stargazers","contributors_url":"https://api.github.com/repos/getsentry/semaphore/contributors","subscribers_url":"https://api.github.com/repos/getsentry/semaphore/subscribers","subscription_url":"https://api.github.com/repos/getsentry/semaphore/subscription","commits_url":"https://api.github.com/repos/getsentry/semaphore/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/semaphore/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/semaphore/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/semaphore/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/semaphore/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/semaphore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/semaphore/merges","archive_url":"https://api.github.com/repos/getsentry/semaphore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/semaphore/downloads","issues_url":"https://api.github.com/repos/getsentry/semaphore/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/semaphore/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/semaphore/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/semaphore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/semaphore/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/semaphore/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/semaphore/deployments","created_at":"2018-01-16T23:49:43Z","updated_at":"2019-08-29T11:10:36Z","pushed_at":"2019-08-29T17:33:40Z","git_url":"git://github.com/getsentry/semaphore.git","ssh_url":"git@github.com:getsentry/semaphore.git","clone_url":"https://github.com/getsentry/semaphore.git","svn_url":"https://github.com/getsentry/semaphore","homepage":"","size":3729,"stargazers_count":51,"watchers_count":51,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":2,"watchers":51,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"7c28d7f39ad64620dd5416563299f74670db3b83","user":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":117757315,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3NTczMTU=","name":"semaphore","full_name":"getsentry/semaphore","private":false,"owner":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getsentry/semaphore","description":"Using big shuttered boxes rather than the old-fashioned semaphore arms.","fork":false,"url":"https://api.github.com/repos/getsentry/semaphore","forks_url":"https://api.github.com/repos/getsentry/semaphore/forks","keys_url":"https://api.github.com/repos/getsentry/semaphore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/semaphore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/semaphore/teams","hooks_url":"https://api.github.com/repos/getsentry/semaphore/hooks","issue_events_url":"https://api.github.com/repos/getsentry/semaphore/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/semaphore/events","assignees_url":"https://api.github.com/repos/getsentry/semaphore/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/semaphore/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/semaphore/tags","blobs_url":"https://api.github.com/repos/getsentry/semaphore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/semaphore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/semaphore/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/semaphore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/semaphore/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/semaphore/languages","stargazers_url":"https://api.github.com/repos/getsentry/semaphore/stargazers","contributors_url":"https://api.github.com/repos/getsentry/semaphore/contributors","subscribers_url":"https://api.github.com/repos/getsentry/semaphore/subscribers","subscription_url":"https://api.github.com/repos/getsentry/semaphore/subscription","commits_url":"https://api.github.com/repos/getsentry/semaphore/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/semaphore/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/semaphore/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/semaphore/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/semaphore/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/semaphore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/semaphore/merges","archive_url":"https://api.github.com/repos/getsentry/semaphore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/semaphore/downloads","issues_url":"https://api.github.com/repos/getsentry/semaphore/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/semaphore/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/semaphore/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/semaphore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/semaphore/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/semaphore/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/semaphore/deployments","created_at":"2018-01-16T23:49:43Z","updated_at":"2019-08-29T11:10:36Z","pushed_at":"2019-08-29T17:33:40Z","git_url":"git://github.com/getsentry/semaphore.git","ssh_url":"git@github.com:getsentry/semaphore.git","clone_url":"https://github.com/getsentry/semaphore.git","svn_url":"https://github.com/getsentry/semaphore","homepage":"","size":3729,"stargazers_count":51,"watchers_count":51,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":2,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/semaphore/pulls/227"},"html":{"href":"https://github.com/getsentry/semaphore/pull/227"},"issue":{"href":"https://api.github.com/repos/getsentry/semaphore/issues/227"},"comments":{"href":"https://api.github.com/repos/getsentry/semaphore/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/semaphore/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/semaphore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/semaphore/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/semaphore/statuses/7cc8cc336e2eeab8033d75e94c5a30b1648dd1a7"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jan-auer","id":1433023,"node_id":"MDQ6VXNlcjE0MzMwMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1433023?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-auer","html_url":"https://github.com/jan-auer","followers_url":"https://api.github.com/users/jan-auer/followers","following_url":"https://api.github.com/users/jan-auer/following{/other_user}","gists_url":"https://api.github.com/users/jan-auer/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-auer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-auer/subscriptions","organizations_url":"https://api.github.com/users/jan-auer/orgs","repos_url":"https://api.github.com/users/jan-auer/repos","events_url":"https://api.github.com/users/jan-auer/events{/privacy}","received_events_url":"https://api.github.com/users/jan-auer/received_events","type":"User","site_admin":false},"comments":1,"review_comments":26,"maintainer_can_modify":false,"commits":32,"additions":3485,"deletions":464,"changed_files":44}}
{"actor":{"display_login":"jan-auer"}}