{"action":"created","issue":{"url":"https://api.github.com/repos/getredash/redash/issues/3495","repository_url":"https://api.github.com/repos/getredash/redash","labels_url":"https://api.github.com/repos/getredash/redash/issues/3495/labels{/name}","comments_url":"https://api.github.com/repos/getredash/redash/issues/3495/comments","events_url":"https://api.github.com/repos/getredash/redash/issues/3495/events","html_url":"https://github.com/getredash/redash/pull/3495","id":414604755,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2Mjc3ODM0","number":3495,"title":"Sharing embeds with safe parameters","user":{"login":"rauchy","id":289488,"node_id":"MDQ6VXNlcjI4OTQ4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/289488?v=4","gravatar_id":"","url":"https://api.github.com/users/rauchy","html_url":"https://github.com/rauchy","followers_url":"https://api.github.com/users/rauchy/followers","following_url":"https://api.github.com/users/rauchy/following{/other_user}","gists_url":"https://api.github.com/users/rauchy/gists{/gist_id}","starred_url":"https://api.github.com/users/rauchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauchy/subscriptions","organizations_url":"https://api.github.com/users/rauchy/orgs","repos_url":"https://api.github.com/users/rauchy/repos","events_url":"https://api.github.com/users/rauchy/events{/privacy}","received_events_url":"https://api.github.com/users/rauchy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"rauchy","id":289488,"node_id":"MDQ6VXNlcjI4OTQ4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/289488?v=4","gravatar_id":"","url":"https://api.github.com/users/rauchy","html_url":"https://github.com/rauchy","followers_url":"https://api.github.com/users/rauchy/followers","following_url":"https://api.github.com/users/rauchy/following{/other_user}","gists_url":"https://api.github.com/users/rauchy/gists{/gist_id}","starred_url":"https://api.github.com/users/rauchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauchy/subscriptions","organizations_url":"https://api.github.com/users/rauchy/orgs","repos_url":"https://api.github.com/users/rauchy/repos","events_url":"https://api.github.com/users/rauchy/events{/privacy}","received_events_url":"https://api.github.com/users/rauchy/received_events","type":"User","site_admin":false},"assignees":[{"login":"rauchy","id":289488,"node_id":"MDQ6VXNlcjI4OTQ4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/289488?v=4","gravatar_id":"","url":"https://api.github.com/users/rauchy","html_url":"https://github.com/rauchy","followers_url":"https://api.github.com/users/rauchy/followers","following_url":"https://api.github.com/users/rauchy/following{/other_user}","gists_url":"https://api.github.com/users/rauchy/gists{/gist_id}","starred_url":"https://api.github.com/users/rauchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauchy/subscriptions","organizations_url":"https://api.github.com/users/rauchy/orgs","repos_url":"https://api.github.com/users/rauchy/repos","events_url":"https://api.github.com/users/rauchy/events{/privacy}","received_events_url":"https://api.github.com/users/rauchy/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2019-02-26T13:13:34Z","updated_at":"2019-04-08T14:17:53Z","closed_at":"2019-04-02T08:45:39Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/getredash/redash/pulls/3495","html_url":"https://github.com/getredash/redash/pull/3495","diff_url":"https://github.com/getredash/redash/pull/3495.diff","patch_url":"https://github.com/getredash/redash/pull/3495.patch"},"body":"## What type of PR is this? (check all applicable)\r\n\r\n- [x] Feature\r\n\r\n## Description\r\nThis PR points embeds are the textless endpoint, resulting in the ability to execute queries with safe parameters in embedded visualizations.\r\n\r\n## Related Tickets & Documents\r\nTowards #3284 \r\n\r\n## Mobile & Desktop Screenshots/Recordings (if there are UI changes)\r\n![feb-27-2019 14-15-05](https://user-images.githubusercontent.com/289488/53489569-2b756800-3a9a-11e9-8e32-939e30046b09.gif)"},"comment":{"url":"https://api.github.com/repos/getredash/redash/issues/comments/480850754","html_url":"https://github.com/getredash/redash/pull/3495#issuecomment-480850754","issue_url":"https://api.github.com/repos/getredash/redash/issues/3495","id":480850754,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4MDg1MDc1NA==","user":{"login":"HenroRitchie","id":13745428,"node_id":"MDQ6VXNlcjEzNzQ1NDI4","avatar_url":"https://avatars2.githubusercontent.com/u/13745428?v=4","gravatar_id":"","url":"https://api.github.com/users/HenroRitchie","html_url":"https://github.com/HenroRitchie","followers_url":"https://api.github.com/users/HenroRitchie/followers","following_url":"https://api.github.com/users/HenroRitchie/following{/other_user}","gists_url":"https://api.github.com/users/HenroRitchie/gists{/gist_id}","starred_url":"https://api.github.com/users/HenroRitchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenroRitchie/subscriptions","organizations_url":"https://api.github.com/users/HenroRitchie/orgs","repos_url":"https://api.github.com/users/HenroRitchie/repos","events_url":"https://api.github.com/users/HenroRitchie/events{/privacy}","received_events_url":"https://api.github.com/users/HenroRitchie/received_events","type":"User","site_admin":false},"created_at":"2019-04-08T14:17:53Z","updated_at":"2019-04-08T14:17:53Z","author_association":"NONE","body":"@rauchy Thank you for the updates and commits. I am happy to report that I can now embed data parameters successfully. However, the queries are still not refreshed when any of the parameters change. In my test, I have one drop-down parameter and one date range parameter. I followed the steps below to test.\r\n\r\nIn Redash select the first parameter and the date range and run the query. I manually run the query every time. Check the results in Redash. Embed the query in the secondary portal as an Iframe. This works and provides the same results as Redash directly. If I now select a different parameter from the dropdown or change the date range the chart display defaults to the generic chart. Furthermore, if I attempt to download the CSV file it fails with a server error. \r\n\r\nI monitored the Celery Status page - and it does seem that something is happening as soon as I change the parameter, but the page and chart are never updated. I don't know if the page is not updated with the latest info or if takes too long. I have a large number of data to display, and changing the first parameter might trigger the query but it takes such a long time that it never gets updated on the display. Visual feedback to show the query is being refreshed might help here.\r\n\r\nChanging the refresh schedule to every 1 minute does not make a difference.\r\n\r\nLastly, am I approaching this correctly? Should the parameter change a variable in the SQL query, or should the variable filter the results? The difference is the amount of data sent from Postgres to Redash. Running the same query everytime might be better for Redash, or will it not make a difference?"}}
{"actor":{"display_login":"HenroRitchie"}}