{"action":"created","comment":{"url":"https://api.github.com/repos/cloudtrust/keycloak/pulls/comments/335960216","pull_request_review_id":303197894,"id":335960216,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNTk2MDIxNg==","diff_hunk":"@@ -219,6 +229,59 @@ public void testSwitchExecutionNotAllowedWithRequiredPasswordAndAlternativeOTP()\n     }\n \n \n+    @Test\n+    public void testSocialProvidersPresentOnLoginUsernameOnlyPageIfConfigured() {\n+        String testRealm = \"test\";\n+        // Test setup - Configure the testing Keycloak instance with UsernameForm & PasswordForm (both REQUIRED) and OTPFormAuthenticator (ALTERNATIVE)\n+        testingClient.server(testRealm).run(configureBrowserFlowWithRequiredPasswordFormAndAlternativeOTP(\"browser - copy 1\"));\n+\n+        List<String> identityProviderAliases = new ArrayList<String>();\n+        try {\n+            SocialLoginTest socialLoginTest = new SocialLoginTest();\n+            List<SocialLoginTest.Provider> socialProviders = Arrays.asList(GITHUB, GITLAB, GOOGLE);\n+            try {\n+                Method buildProviderMethod = socialLoginTest.getClass().getDeclaredMethod(\"buildIdp\", new Class[]{SocialLoginTest.Provider.class});","path":"testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/forms/BrowserFlowTest.java","position":60,"original_position":60,"commit_id":"420b6c711bbd9fb5cc264c41d2350c687d877b42","original_commit_id":"420b6c711bbd9fb5cc264c41d2350c687d877b42","user":{"login":"iankko","id":8414918,"node_id":"MDQ6VXNlcjg0MTQ5MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/8414918?v=4","gravatar_id":"","url":"https://api.github.com/users/iankko","html_url":"https://github.com/iankko","followers_url":"https://api.github.com/users/iankko/followers","following_url":"https://api.github.com/users/iankko/following{/other_user}","gists_url":"https://api.github.com/users/iankko/gists{/gist_id}","starred_url":"https://api.github.com/users/iankko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankko/subscriptions","organizations_url":"https://api.github.com/users/iankko/orgs","repos_url":"https://api.github.com/users/iankko/repos","events_url":"https://api.github.com/users/iankko/events{/privacy}","received_events_url":"https://api.github.com/users/iankko/received_events","type":"User","site_admin":false},"body":"@mposolda Right, that would work too. Will try it (reused the existing `SocialLoginTest` function, so I wouldn't need to define a new copy with the same / similar functionality).","created_at":"2019-10-17T11:54:45Z","updated_at":"2019-10-17T11:54:46Z","html_url":"https://github.com/cloudtrust/keycloak/pull/17#discussion_r335960216","pull_request_url":"https://api.github.com/repos/cloudtrust/keycloak/pulls/17","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cloudtrust/keycloak/pulls/comments/335960216"},"html":{"href":"https://github.com/cloudtrust/keycloak/pull/17#discussion_r335960216"},"pull_request":{"href":"https://api.github.com/repos/cloudtrust/keycloak/pulls/17"}},"in_reply_to_id":335947856},"pull_request":{"url":"https://api.github.com/repos/cloudtrust/keycloak/pulls/17","id":329189514,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MTg5NTE0","html_url":"https://github.com/cloudtrust/keycloak/pull/17","diff_url":"https://github.com/cloudtrust/keycloak/pull/17.diff","patch_url":"https://github.com/cloudtrust/keycloak/pull/17.patch","issue_url":"https://api.github.com/repos/cloudtrust/keycloak/issues/17","number":17,"state":"open","locked":false,"title":"[KEYCLOAK-11752] Display also buttons for the respective social providers on the UsernameForm page if some social IdP is defined","user":{"login":"iankko","id":8414918,"node_id":"MDQ6VXNlcjg0MTQ5MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/8414918?v=4","gravatar_id":"","url":"https://api.github.com/users/iankko","html_url":"https://github.com/iankko","followers_url":"https://api.github.com/users/iankko/followers","following_url":"https://api.github.com/users/iankko/following{/other_user}","gists_url":"https://api.github.com/users/iankko/gists{/gist_id}","starred_url":"https://api.github.com/users/iankko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankko/subscriptions","organizations_url":"https://api.github.com/users/iankko/orgs","repos_url":"https://api.github.com/users/iankko/repos","events_url":"https://api.github.com/users/iankko/events{/privacy}","received_events_url":"https://api.github.com/users/iankko/received_events","type":"User","site_admin":false},"body":"\r\n    [KEYCLOAK-11752] Display also buttons for the respective social providers on the\r\n    UsernameForm page if some social IdP is defined\r\n    \r\n    Also add a corresponding test\r\n    \r\n    Signed-off-by: Jan Lieskovsky <jlieskov@redhat.com>\r\n\r\n<!---\r\nPlease read https://github.com/keycloak/keycloak/blob/master/CONTRIBUTING.md and follow these guidelines when contributing to Keycloak\r\n-->\r\n","created_at":"2019-10-17T10:41:09Z","updated_at":"2019-10-17T11:54:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b288df05d2e1ac9df17165b7c6bee2498c05ed7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudtrust/keycloak/pulls/17/commits","review_comments_url":"https://api.github.com/repos/cloudtrust/keycloak/pulls/17/comments","review_comment_url":"https://api.github.com/repos/cloudtrust/keycloak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudtrust/keycloak/issues/17/comments","statuses_url":"https://api.github.com/repos/cloudtrust/keycloak/statuses/420b6c711bbd9fb5cc264c41d2350c687d877b42","head":{"label":"iankko:KEYCLOAK-11752","ref":"KEYCLOAK-11752","sha":"420b6c711bbd9fb5cc264c41d2350c687d877b42","user":{"login":"iankko","id":8414918,"node_id":"MDQ6VXNlcjg0MTQ5MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/8414918?v=4","gravatar_id":"","url":"https://api.github.com/users/iankko","html_url":"https://github.com/iankko","followers_url":"https://api.github.com/users/iankko/followers","following_url":"https://api.github.com/users/iankko/following{/other_user}","gists_url":"https://api.github.com/users/iankko/gists{/gist_id}","starred_url":"https://api.github.com/users/iankko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankko/subscriptions","organizations_url":"https://api.github.com/users/iankko/orgs","repos_url":"https://api.github.com/users/iankko/repos","events_url":"https://api.github.com/users/iankko/events{/privacy}","received_events_url":"https://api.github.com/users/iankko/received_events","type":"User","site_admin":false},"repo":{"id":214987892,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQ5ODc4OTI=","name":"keycloak","full_name":"iankko/keycloak","private":false,"owner":{"login":"iankko","id":8414918,"node_id":"MDQ6VXNlcjg0MTQ5MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/8414918?v=4","gravatar_id":"","url":"https://api.github.com/users/iankko","html_url":"https://github.com/iankko","followers_url":"https://api.github.com/users/iankko/followers","following_url":"https://api.github.com/users/iankko/following{/other_user}","gists_url":"https://api.github.com/users/iankko/gists{/gist_id}","starred_url":"https://api.github.com/users/iankko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankko/subscriptions","organizations_url":"https://api.github.com/users/iankko/orgs","repos_url":"https://api.github.com/users/iankko/repos","events_url":"https://api.github.com/users/iankko/events{/privacy}","received_events_url":"https://api.github.com/users/iankko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/iankko/keycloak","description":"Open Source Identity and Access Management For Modern Applications and Services","fork":true,"url":"https://api.github.com/repos/iankko/keycloak","forks_url":"https://api.github.com/repos/iankko/keycloak/forks","keys_url":"https://api.github.com/repos/iankko/keycloak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iankko/keycloak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iankko/keycloak/teams","hooks_url":"https://api.github.com/repos/iankko/keycloak/hooks","issue_events_url":"https://api.github.com/repos/iankko/keycloak/issues/events{/number}","events_url":"https://api.github.com/repos/iankko/keycloak/events","assignees_url":"https://api.github.com/repos/iankko/keycloak/assignees{/user}","branches_url":"https://api.github.com/repos/iankko/keycloak/branches{/branch}","tags_url":"https://api.github.com/repos/iankko/keycloak/tags","blobs_url":"https://api.github.com/repos/iankko/keycloak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iankko/keycloak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iankko/keycloak/git/refs{/sha}","trees_url":"https://api.github.com/repos/iankko/keycloak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iankko/keycloak/statuses/{sha}","languages_url":"https://api.github.com/repos/iankko/keycloak/languages","stargazers_url":"https://api.github.com/repos/iankko/keycloak/stargazers","contributors_url":"https://api.github.com/repos/iankko/keycloak/contributors","subscribers_url":"https://api.github.com/repos/iankko/keycloak/subscribers","subscription_url":"https://api.github.com/repos/iankko/keycloak/subscription","commits_url":"https://api.github.com/repos/iankko/keycloak/commits{/sha}","git_commits_url":"https://api.github.com/repos/iankko/keycloak/git/commits{/sha}","comments_url":"https://api.github.com/repos/iankko/keycloak/comments{/number}","issue_comment_url":"https://api.github.com/repos/iankko/keycloak/issues/comments{/number}","contents_url":"https://api.github.com/repos/iankko/keycloak/contents/{+path}","compare_url":"https://api.github.com/repos/iankko/keycloak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iankko/keycloak/merges","archive_url":"https://api.github.com/repos/iankko/keycloak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iankko/keycloak/downloads","issues_url":"https://api.github.com/repos/iankko/keycloak/issues{/number}","pulls_url":"https://api.github.com/repos/iankko/keycloak/pulls{/number}","milestones_url":"https://api.github.com/repos/iankko/keycloak/milestones{/number}","notifications_url":"https://api.github.com/repos/iankko/keycloak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iankko/keycloak/labels{/name}","releases_url":"https://api.github.com/repos/iankko/keycloak/releases{/id}","deployments_url":"https://api.github.com/repos/iankko/keycloak/deployments","created_at":"2019-10-14T08:23:46Z","updated_at":"2019-10-14T08:23:48Z","pushed_at":"2019-10-17T10:38:04Z","git_url":"git://github.com/iankko/keycloak.git","ssh_url":"git@github.com:iankko/keycloak.git","clone_url":"https://github.com/iankko/keycloak.git","svn_url":"https://github.com/iankko/keycloak","homepage":"http://www.keycloak.org","size":140875,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudtrust:multi-token-prototype","ref":"multi-token-prototype","sha":"eb0409a5e46e9f5cffc10bb3cbcc5b67e68d5667","user":{"login":"cloudtrust","id":26786076,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Nzg2MDc2","avatar_url":"https://avatars2.githubusercontent.com/u/26786076?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudtrust","html_url":"https://github.com/cloudtrust","followers_url":"https://api.github.com/users/cloudtrust/followers","following_url":"https://api.github.com/users/cloudtrust/following{/other_user}","gists_url":"https://api.github.com/users/cloudtrust/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudtrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudtrust/subscriptions","organizations_url":"https://api.github.com/users/cloudtrust/orgs","repos_url":"https://api.github.com/users/cloudtrust/repos","events_url":"https://api.github.com/users/cloudtrust/events{/privacy}","received_events_url":"https://api.github.com/users/cloudtrust/received_events","type":"Organization","site_admin":false},"repo":{"id":124041287,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwNDEyODc=","name":"keycloak","full_name":"cloudtrust/keycloak","private":false,"owner":{"login":"cloudtrust","id":26786076,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Nzg2MDc2","avatar_url":"https://avatars2.githubusercontent.com/u/26786076?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudtrust","html_url":"https://github.com/cloudtrust","followers_url":"https://api.github.com/users/cloudtrust/followers","following_url":"https://api.github.com/users/cloudtrust/following{/other_user}","gists_url":"https://api.github.com/users/cloudtrust/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudtrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudtrust/subscriptions","organizations_url":"https://api.github.com/users/cloudtrust/orgs","repos_url":"https://api.github.com/users/cloudtrust/repos","events_url":"https://api.github.com/users/cloudtrust/events{/privacy}","received_events_url":"https://api.github.com/users/cloudtrust/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudtrust/keycloak","description":"Open Source Identity and Access Management For Modern Applications and Services","fork":true,"url":"https://api.github.com/repos/cloudtrust/keycloak","forks_url":"https://api.github.com/repos/cloudtrust/keycloak/forks","keys_url":"https://api.github.com/repos/cloudtrust/keycloak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudtrust/keycloak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudtrust/keycloak/teams","hooks_url":"https://api.github.com/repos/cloudtrust/keycloak/hooks","issue_events_url":"https://api.github.com/repos/cloudtrust/keycloak/issues/events{/number}","events_url":"https://api.github.com/repos/cloudtrust/keycloak/events","assignees_url":"https://api.github.com/repos/cloudtrust/keycloak/assignees{/user}","branches_url":"https://api.github.com/repos/cloudtrust/keycloak/branches{/branch}","tags_url":"https://api.github.com/repos/cloudtrust/keycloak/tags","blobs_url":"https://api.github.com/repos/cloudtrust/keycloak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudtrust/keycloak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudtrust/keycloak/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudtrust/keycloak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudtrust/keycloak/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudtrust/keycloak/languages","stargazers_url":"https://api.github.com/repos/cloudtrust/keycloak/stargazers","contributors_url":"https://api.github.com/repos/cloudtrust/keycloak/contributors","subscribers_url":"https://api.github.com/repos/cloudtrust/keycloak/subscribers","subscription_url":"https://api.github.com/repos/cloudtrust/keycloak/subscription","commits_url":"https://api.github.com/repos/cloudtrust/keycloak/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudtrust/keycloak/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudtrust/keycloak/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudtrust/keycloak/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudtrust/keycloak/contents/{+path}","compare_url":"https://api.github.com/repos/cloudtrust/keycloak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudtrust/keycloak/merges","archive_url":"https://api.github.com/repos/cloudtrust/keycloak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudtrust/keycloak/downloads","issues_url":"https://api.github.com/repos/cloudtrust/keycloak/issues{/number}","pulls_url":"https://api.github.com/repos/cloudtrust/keycloak/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudtrust/keycloak/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudtrust/keycloak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudtrust/keycloak/labels{/name}","releases_url":"https://api.github.com/repos/cloudtrust/keycloak/releases{/id}","deployments_url":"https://api.github.com/repos/cloudtrust/keycloak/deployments","created_at":"2018-03-06T07:51:16Z","updated_at":"2019-09-26T14:08:43Z","pushed_at":"2019-10-17T10:41:10Z","git_url":"git://github.com/cloudtrust/keycloak.git","ssh_url":"git@github.com:cloudtrust/keycloak.git","clone_url":"https://github.com/cloudtrust/keycloak.git","svn_url":"https://github.com/cloudtrust/keycloak","homepage":"http://www.keycloak.org","size":140872,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudtrust/keycloak/pulls/17"},"html":{"href":"https://github.com/cloudtrust/keycloak/pull/17"},"issue":{"href":"https://api.github.com/repos/cloudtrust/keycloak/issues/17"},"comments":{"href":"https://api.github.com/repos/cloudtrust/keycloak/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudtrust/keycloak/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudtrust/keycloak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudtrust/keycloak/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/cloudtrust/keycloak/statuses/420b6c711bbd9fb5cc264c41d2350c687d877b42"}},"author_association":"NONE"}}
{"actor":{"display_login":"iankko"}}