{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/hubs/issues/1075","repository_url":"https://api.github.com/repos/mozilla/hubs","labels_url":"https://api.github.com/repos/mozilla/hubs/issues/1075/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/hubs/issues/1075/comments","events_url":"https://api.github.com/repos/mozilla/hubs/issues/1075/events","html_url":"https://github.com/mozilla/hubs/pull/1075","id":420345681,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwNjQ1NDc1","number":1075,"title":"Handle cases where event handlers come in late in VR startup","user":{"login":"gfodor","id":220020,"node_id":"MDQ6VXNlcjIyMDAyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/220020?v=4","gravatar_id":"","url":"https://api.github.com/users/gfodor","html_url":"https://github.com/gfodor","followers_url":"https://api.github.com/users/gfodor/followers","following_url":"https://api.github.com/users/gfodor/following{/other_user}","gists_url":"https://api.github.com/users/gfodor/gists{/gist_id}","starred_url":"https://api.github.com/users/gfodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfodor/subscriptions","organizations_url":"https://api.github.com/users/gfodor/orgs","repos_url":"https://api.github.com/users/gfodor/repos","events_url":"https://api.github.com/users/gfodor/events{/privacy}","received_events_url":"https://api.github.com/users/gfodor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-03-13T07:00:24Z","updated_at":"2019-03-21T21:55:45Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mozilla/hubs/pulls/1075","html_url":"https://github.com/mozilla/hubs/pull/1075","diff_url":"https://github.com/mozilla/hubs/pull/1075.diff","patch_url":"https://github.com/mozilla/hubs/pull/1075.patch"},"body":"The code currently has two hacks dealing with WebVR startup in A-Frame when a user refreshes the page after a VR session on desktop:\r\n\r\n- It's always been the case that A-Frame/WebVR will retain VR mode across refreshes, we have a hack that will exit VR mode on startup if this case is hit\r\n\r\n- There was a regression in 0.9.0 that causes A-Frame to miss this condition in certain conditions, resulting in a situation where the display is presenting but A-Frame did not run its relevant \"enter VR\" routines (to tag the scene metadata, set up cameras, etc.)\r\n\r\nThe previous hacks handled these cases by subscribing to `enter-vr `and `vrdisplaypresentchange` to get out ahead of these conditions, but in practice it looks like in certain cases these event subscriptions are happening too late, the events have already fired (for both conditions.) This PR updates them to both be handled when these events fire but also pre-emptively run the necessary logic at event subscription time in case the event has already fired."},"comment":{"url":"https://api.github.com/repos/mozilla/hubs/issues/comments/475418143","html_url":"https://github.com/mozilla/hubs/pull/1075#issuecomment-475418143","issue_url":"https://api.github.com/repos/mozilla/hubs/issues/1075","id":475418143,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3NTQxODE0Mw==","user":{"login":"dmarcos","id":39342,"node_id":"MDQ6VXNlcjM5MzQy","avatar_url":"https://avatars3.githubusercontent.com/u/39342?v=4","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"created_at":"2019-03-21T21:55:45Z","updated_at":"2019-03-21T21:55:45Z","author_association":"NONE","body":"Try A-Frame master. This might help: https://github.com/aframevr/aframe/pull/4093"}}
{"actor":{"display_login":"dmarcos"}}