{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/278305927","pull_request_review_id":230336227,"id":278305927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODMwNTkyNw==","diff_hunk":"@@ -711,6 +711,24 @@ import {async_beforeEach, async_fit, async_it} from './async';\n       serverUpdate.assertNoOtherRequests();\n     });\n \n+    async_it('should bypass serviceworker on ngsw-bypass parameter', async() => {\n+      expect(await makeRequest(scope, '/foo.txt', undefined, {\n+        headers: {'ngsw-bypass': 'true'}\n+      })).toBeNull();\n+      server.assertNoRequestFor('/foo.txt');\n+\n+      expect(await makeRequest(scope, '/foo.txt')).toBe('this is foo');\n+      server.assertSawRequestFor('/foo.txt');\n+\n+      server.clearRequests();\n+\n+      expect(await makeRequest(scope, '/bar.txt?ngsw-bypass=true')).toBeNull();\n+      server.assertNoRequestFor('/bar.txt');\n+\n+      expect(await makeRequest(scope, '/bar.txt?ngsw-bypass=false')).toBe('this is bar');\n+      server.assertSawRequestFor('/bar.txt');\n+    });","path":"packages/service-worker/worker/test/happy_spec.ts","position":68,"original_position":20,"commit_id":"a33c30187e00947a53d65ed74c5160880fb718ec","original_commit_id":"b7bc822bec0c5e61b430c213c4c054bdac818f9d","user":{"login":"gkalpak","id":8604205,"node_id":"MDQ6VXNlcjg2MDQyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"I'd like to see one more test with an empty query param (e.g. `?ngsw-bypass=&foo=ngsw-bypass`).","created_at":"2019-04-24T20:32:55Z","updated_at":"2019-04-24T20:33:34Z","html_url":"https://github.com/angular/angular/pull/30010#discussion_r278305927","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/30010","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/278305927"},"html":{"href":"https://github.com/angular/angular/pull/30010#discussion_r278305927"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/30010"}},"in_reply_to_id":277687392},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/30010","id":272195539,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyMTk1NTM5","html_url":"https://github.com/angular/angular/pull/30010","diff_url":"https://github.com/angular/angular/pull/30010.diff","patch_url":"https://github.com/angular/angular/pull/30010.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/30010","number":30010,"state":"open","locked":false,"title":"feat(service-worker): bypass on queryparam/header (#21191)","user":{"login":"petersalomonsen","id":9760441,"node_id":"MDQ6VXNlcjk3NjA0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/9760441?v=4","gravatar_id":"","url":"https://api.github.com/users/petersalomonsen","html_url":"https://github.com/petersalomonsen","followers_url":"https://api.github.com/users/petersalomonsen/followers","following_url":"https://api.github.com/users/petersalomonsen/following{/other_user}","gists_url":"https://api.github.com/users/petersalomonsen/gists{/gist_id}","starred_url":"https://api.github.com/users/petersalomonsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petersalomonsen/subscriptions","organizations_url":"https://api.github.com/users/petersalomonsen/orgs","repos_url":"https://api.github.com/users/petersalomonsen/repos","events_url":"https://api.github.com/users/petersalomonsen/events{/privacy}","received_events_url":"https://api.github.com/users/petersalomonsen/received_events","type":"User","site_admin":false},"body":"issue #21191\r\n\r\nadded ngsw-bypass header and queryparameter\r\nfor bypassing serviceworker on specific requests\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [X] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [X] Tests for the changes have been added (for bug fixes / features)\r\n- [X] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n\r\n- [ ] Bugfix\r\n- [X] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build related changes\r\n- [ ] CI related changes\r\n- [ ] Documentation content changes\r\n- [ ] angular.io application / infrastructure changes\r\n- [ ] Other... Please describe:\r\n\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nIssue Number: 21191\r\n\r\n\r\n## What is the new behavior?\r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n\r\n- [ ] Yes\r\n- [X] No\r\n\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n","created_at":"2019-04-21T05:44:51Z","updated_at":"2019-04-24T20:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38bc646f20e189bcaca764377faa9def06cd7747","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":708923209,"node_id":"MDU6TGFiZWw3MDg5MjMyMDk=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20service-worker","name":"comp: service-worker","color":"c5def5","default":false}],"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/83","html_url":"https://github.com/angular/angular/milestone/83","labels_url":"https://api.github.com/repos/angular/angular/milestones/83/labels","id":3143880,"node_id":"MDk6TWlsZXN0b25lMzE0Mzg4MA==","number":83,"title":"needsTriage","description":"Milestone for all issues that haven't been triaged yet","creator":{"login":"ocombe","id":265378,"node_id":"MDQ6VXNlcjI2NTM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"open_issues":503,"closed_issues":2354,"state":"open","created_at":"2018-02-26T14:22:18Z","updated_at":"2019-04-24T20:27:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular/pulls/30010/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/30010/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/30010/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/a33c30187e00947a53d65ed74c5160880fb718ec","head":{"label":"petersalomonsen:21191-serviceworker-bypass","ref":"21191-serviceworker-bypass","sha":"a33c30187e00947a53d65ed74c5160880fb718ec","user":{"login":"petersalomonsen","id":9760441,"node_id":"MDQ6VXNlcjk3NjA0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/9760441?v=4","gravatar_id":"","url":"https://api.github.com/users/petersalomonsen","html_url":"https://github.com/petersalomonsen","followers_url":"https://api.github.com/users/petersalomonsen/followers","following_url":"https://api.github.com/users/petersalomonsen/following{/other_user}","gists_url":"https://api.github.com/users/petersalomonsen/gists{/gist_id}","starred_url":"https://api.github.com/users/petersalomonsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petersalomonsen/subscriptions","organizations_url":"https://api.github.com/users/petersalomonsen/orgs","repos_url":"https://api.github.com/users/petersalomonsen/repos","events_url":"https://api.github.com/users/petersalomonsen/events{/privacy}","received_events_url":"https://api.github.com/users/petersalomonsen/received_events","type":"User","site_admin":false},"repo":{"id":95317526,"node_id":"MDEwOlJlcG9zaXRvcnk5NTMxNzUyNg==","name":"angular","full_name":"petersalomonsen/angular","private":false,"owner":{"login":"petersalomonsen","id":9760441,"node_id":"MDQ6VXNlcjk3NjA0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/9760441?v=4","gravatar_id":"","url":"https://api.github.com/users/petersalomonsen","html_url":"https://github.com/petersalomonsen","followers_url":"https://api.github.com/users/petersalomonsen/followers","following_url":"https://api.github.com/users/petersalomonsen/following{/other_user}","gists_url":"https://api.github.com/users/petersalomonsen/gists{/gist_id}","starred_url":"https://api.github.com/users/petersalomonsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petersalomonsen/subscriptions","organizations_url":"https://api.github.com/users/petersalomonsen/orgs","repos_url":"https://api.github.com/users/petersalomonsen/repos","events_url":"https://api.github.com/users/petersalomonsen/events{/privacy}","received_events_url":"https://api.github.com/users/petersalomonsen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/petersalomonsen/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/petersalomonsen/angular","forks_url":"https://api.github.com/repos/petersalomonsen/angular/forks","keys_url":"https://api.github.com/repos/petersalomonsen/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petersalomonsen/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petersalomonsen/angular/teams","hooks_url":"https://api.github.com/repos/petersalomonsen/angular/hooks","issue_events_url":"https://api.github.com/repos/petersalomonsen/angular/issues/events{/number}","events_url":"https://api.github.com/repos/petersalomonsen/angular/events","assignees_url":"https://api.github.com/repos/petersalomonsen/angular/assignees{/user}","branches_url":"https://api.github.com/repos/petersalomonsen/angular/branches{/branch}","tags_url":"https://api.github.com/repos/petersalomonsen/angular/tags","blobs_url":"https://api.github.com/repos/petersalomonsen/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petersalomonsen/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petersalomonsen/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/petersalomonsen/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petersalomonsen/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/petersalomonsen/angular/languages","stargazers_url":"https://api.github.com/repos/petersalomonsen/angular/stargazers","contributors_url":"https://api.github.com/repos/petersalomonsen/angular/contributors","subscribers_url":"https://api.github.com/repos/petersalomonsen/angular/subscribers","subscription_url":"https://api.github.com/repos/petersalomonsen/angular/subscription","commits_url":"https://api.github.com/repos/petersalomonsen/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/petersalomonsen/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/petersalomonsen/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/petersalomonsen/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/petersalomonsen/angular/contents/{+path}","compare_url":"https://api.github.com/repos/petersalomonsen/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petersalomonsen/angular/merges","archive_url":"https://api.github.com/repos/petersalomonsen/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petersalomonsen/angular/downloads","issues_url":"https://api.github.com/repos/petersalomonsen/angular/issues{/number}","pulls_url":"https://api.github.com/repos/petersalomonsen/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/petersalomonsen/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/petersalomonsen/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petersalomonsen/angular/labels{/name}","releases_url":"https://api.github.com/repos/petersalomonsen/angular/releases{/id}","deployments_url":"https://api.github.com/repos/petersalomonsen/angular/deployments","created_at":"2017-06-24T19:10:53Z","updated_at":"2019-04-21T04:50:25Z","pushed_at":"2019-04-24T15:26:45Z","git_url":"git://github.com/petersalomonsen/angular.git","ssh_url":"git@github.com:petersalomonsen/angular.git","clone_url":"https://github.com/petersalomonsen/angular.git","svn_url":"https://github.com/petersalomonsen/angular","homepage":"https://angular.io","size":581343,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"8ca208ff59eb15c8273c9017a796538cfa1934b3","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2019-04-24T20:26:52Z","pushed_at":"2019-04-24T20:33:04Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":111291,"stargazers_count":47393,"watchers_count":47393,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12643,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2748,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12643,"open_issues":2748,"watchers":47393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/30010"},"html":{"href":"https://github.com/angular/angular/pull/30010"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/30010"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/30010/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/30010/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/30010/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/a33c30187e00947a53d65ed74c5160880fb718ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gkalpak"}}