{"action":"created","issue":{"url":"https://api.github.com/repos/urbit/urbit/issues/1853","repository_url":"https://api.github.com/repos/urbit/urbit","labels_url":"https://api.github.com/repos/urbit/urbit/issues/1853/labels{/name}","comments_url":"https://api.github.com/repos/urbit/urbit/issues/1853/comments","events_url":"https://api.github.com/repos/urbit/urbit/issues/1853/events","html_url":"https://github.com/urbit/urbit/pull/1853","id":509292163,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5OTA5NzM3","number":1853,"title":"Add unit tests for SHA encryption and related arms","user":{"login":"ken-meier","id":55196189,"node_id":"MDQ6VXNlcjU1MTk2MTg5","avatar_url":"https://avatars0.githubusercontent.com/u/55196189?v=4","gravatar_id":"","url":"https://api.github.com/users/ken-meier","html_url":"https://github.com/ken-meier","followers_url":"https://api.github.com/users/ken-meier/followers","following_url":"https://api.github.com/users/ken-meier/following{/other_user}","gists_url":"https://api.github.com/users/ken-meier/gists{/gist_id}","starred_url":"https://api.github.com/users/ken-meier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ken-meier/subscriptions","organizations_url":"https://api.github.com/users/ken-meier/orgs","repos_url":"https://api.github.com/users/ken-meier/repos","events_url":"https://api.github.com/users/ken-meier/events{/privacy}","received_events_url":"https://api.github.com/users/ken-meier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-10-18T20:21:46Z","updated_at":"2019-10-24T18:33:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/urbit/urbit/pulls/1853","html_url":"https://github.com/urbit/urbit/pull/1853","diff_url":"https://github.com/urbit/urbit/pull/1853.diff","patch_url":"https://github.com/urbit/urbit/pull/1853.patch"},"body":"This tests each arm referenced in [https://urbit.org/docs/reference/library/3d/](url), based on official NIST test vectors wherever possible. A few notes:\r\n\r\nMany failures at the moment because of the issue noted in #1540. shal and shay both take reversed byte order input and produce reversed byte order output (presumably due to cords being little endian). So, all sha256/512 arms fail against official test vectors. Tests with cord input produce expected output but in reverse byte order. Tests with hex input fail entirely.  Tests could be modified to accommodate this (reverse byte order of hex input and all expected output), but I've left them as written for now as I'm not sure how intentional this is, since shan(SHA1) works differently. shan takes little endian input and produces big endian output. This means it passes tests with cord input, but fails hex input test vectors. One way or the other I imagine we'd want some consistency here.\r\n\r\nRandomness functions and sham have simple tests based on the documentation at the moment. If shal/shay change their arbitrary outputs will probably also change.\r\n"},"comment":{"url":"https://api.github.com/repos/urbit/urbit/issues/comments/546046764","html_url":"https://github.com/urbit/urbit/pull/1853#issuecomment-546046764","issue_url":"https://api.github.com/repos/urbit/urbit/issues/1853","id":546046764,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NjA0Njc2NA==","user":{"login":"ohAitch","id":1857414,"node_id":"MDQ6VXNlcjE4NTc0MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1857414?v=4","gravatar_id":"","url":"https://api.github.com/users/ohAitch","html_url":"https://github.com/ohAitch","followers_url":"https://api.github.com/users/ohAitch/followers","following_url":"https://api.github.com/users/ohAitch/following{/other_user}","gists_url":"https://api.github.com/users/ohAitch/gists{/gist_id}","starred_url":"https://api.github.com/users/ohAitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohAitch/subscriptions","organizations_url":"https://api.github.com/users/ohAitch/orgs","repos_url":"https://api.github.com/users/ohAitch/repos","events_url":"https://api.github.com/users/ohAitch/events{/privacy}","received_events_url":"https://api.github.com/users/ohAitch/received_events","type":"User","site_admin":false},"created_at":"2019-10-24T18:33:30Z","updated_at":"2019-10-24T18:33:30Z","author_association":"CONTRIBUTOR","body":"We do have contiguous-string-split-across-line syntax! See `++po` https://github.com/urbit/urbit/blob/master/pkg/arvo/sys/hoon.hoon#L4043-L4078"}}
{"actor":{"display_login":"ohAitch"}}