{"action":"created","comment":{"url":"https://api.github.com/repos/openweave/openweave-core/pulls/comments/288672713","pull_request_review_id":243395814,"id":288672713,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODY3MjcxMw==","diff_hunk":"@@ -0,0 +1,131 @@\n+/*\n+ *\n+ *    Copyright (c) 2019 Google LLC.\n+ *    All rights reserved.\n+ *\n+ *    Licensed under the Apache License, Version 2.0 (the \"License\");\n+ *    you may not use this file except in compliance with the License.\n+ *    You may obtain a copy of the License at\n+ *\n+ *        http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ *    Unless required by applicable law or agreed to in writing, software\n+ *    distributed under the License is distributed on an \"AS IS\" BASIS,\n+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ *    See the License for the specific language governing permissions and\n+ *    limitations under the License.\n+ */\n+\n+/**\n+ *    @file\n+ *      Implementation for the Weave Device Layer EventLoggingManager object.\n+ *\n+ */\n+\n+#include <Weave/DeviceLayer/internal/WeaveDeviceLayerInternal.h>\n+#include <Weave/DeviceLayer/EventLoggingManager.h>\n+\n+using namespace nl::Weave::DeviceLayer;\n+\n+namespace nl {\n+namespace Weave {\n+namespace DeviceLayer {\n+namespace Internal {\n+\n+// For each priority level initialize event buffers and event Id counters.\n+uint64_t gCritEventBuffer[(WEAVE_DEVICE_CONFIG_EVENT_LOGGING_CRIT_BUFFER_SIZE + 7) / 8];\n+PersistedCounter sCritEventIdCounter;\n+\n+uint64_t gProdEventBuffer[(WEAVE_DEVICE_CONFIG_EVENT_LOGGING_PROD_BUFFER_SIZE + 7) / 8];\n+PersistedCounter sProdEventIdCounter;","path":"src/adaptations/device-layer/EventLoggingManager.cpp","position":40,"original_position":40,"commit_id":"de62b98efed9c29b9248b33b479e8c2f1528dde1","original_commit_id":"de62b98efed9c29b9248b33b479e8c2f1528dde1","user":{"login":"gerickson","id":380979,"node_id":"MDQ6VXNlcjM4MDk3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/380979?v=4","gravatar_id":"","url":"https://api.github.com/users/gerickson","html_url":"https://github.com/gerickson","followers_url":"https://api.github.com/users/gerickson/followers","following_url":"https://api.github.com/users/gerickson/following{/other_user}","gists_url":"https://api.github.com/users/gerickson/gists{/gist_id}","starred_url":"https://api.github.com/users/gerickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerickson/subscriptions","organizations_url":"https://api.github.com/users/gerickson/orgs","repos_url":"https://api.github.com/users/gerickson/repos","events_url":"https://api.github.com/users/gerickson/events{/privacy}","received_events_url":"https://api.github.com/users/gerickson/received_events","type":"User","site_admin":false},"body":"the \"sProd...\" here and below would seem to indicate that these globals are static and should therefore be declared with the \"static\" storage modifier. Otherwise, these should be renamed \"gProd...\", etc..","created_at":"2019-05-29T17:03:39Z","updated_at":"2019-05-29T17:03:39Z","html_url":"https://github.com/openweave/openweave-core/pull/244#discussion_r288672713","pull_request_url":"https://api.github.com/repos/openweave/openweave-core/pulls/244","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openweave/openweave-core/pulls/comments/288672713"},"html":{"href":"https://github.com/openweave/openweave-core/pull/244#discussion_r288672713"},"pull_request":{"href":"https://api.github.com/repos/openweave/openweave-core/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/openweave/openweave-core/pulls/244","id":283071213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzMDcxMjEz","html_url":"https://github.com/openweave/openweave-core/pull/244","diff_url":"https://github.com/openweave/openweave-core/pull/244.diff","patch_url":"https://github.com/openweave/openweave-core/pull/244.patch","issue_url":"https://api.github.com/repos/openweave/openweave-core/issues/244","number":244,"state":"open","locked":false,"title":"Added event logging infrastructure support for the Weave Device Layer.","user":{"login":"emargolis","id":13021231,"node_id":"MDQ6VXNlcjEzMDIxMjMx","avatar_url":"https://avatars1.githubusercontent.com/u/13021231?v=4","gravatar_id":"","url":"https://api.github.com/users/emargolis","html_url":"https://github.com/emargolis","followers_url":"https://api.github.com/users/emargolis/followers","following_url":"https://api.github.com/users/emargolis/following{/other_user}","gists_url":"https://api.github.com/users/emargolis/gists{/gist_id}","starred_url":"https://api.github.com/users/emargolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emargolis/subscriptions","organizations_url":"https://api.github.com/users/emargolis/orgs","repos_url":"https://api.github.com/users/emargolis/repos","events_url":"https://api.github.com/users/emargolis/events{/privacy}","received_events_url":"https://api.github.com/users/emargolis/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-29T02:33:18Z","updated_at":"2019-05-29T17:03:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9fd6d04ebc8522a2b506a65f6c1828f560944e1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jaylogue","id":636485,"node_id":"MDQ6VXNlcjYzNjQ4NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/636485?v=4","gravatar_id":"","url":"https://api.github.com/users/jaylogue","html_url":"https://github.com/jaylogue","followers_url":"https://api.github.com/users/jaylogue/followers","following_url":"https://api.github.com/users/jaylogue/following{/other_user}","gists_url":"https://api.github.com/users/jaylogue/gists{/gist_id}","starred_url":"https://api.github.com/users/jaylogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaylogue/subscriptions","organizations_url":"https://api.github.com/users/jaylogue/orgs","repos_url":"https://api.github.com/users/jaylogue/repos","events_url":"https://api.github.com/users/jaylogue/events{/privacy}","received_events_url":"https://api.github.com/users/jaylogue/received_events","type":"User","site_admin":false},{"login":"robszewczyk","id":4296188,"node_id":"MDQ6VXNlcjQyOTYxODg=","avatar_url":"https://avatars0.githubusercontent.com/u/4296188?v=4","gravatar_id":"","url":"https://api.github.com/users/robszewczyk","html_url":"https://github.com/robszewczyk","followers_url":"https://api.github.com/users/robszewczyk/followers","following_url":"https://api.github.com/users/robszewczyk/following{/other_user}","gists_url":"https://api.github.com/users/robszewczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/robszewczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robszewczyk/subscriptions","organizations_url":"https://api.github.com/users/robszewczyk/orgs","repos_url":"https://api.github.com/users/robszewczyk/repos","events_url":"https://api.github.com/users/robszewczyk/events{/privacy}","received_events_url":"https://api.github.com/users/robszewczyk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openweave/openweave-core/pulls/244/commits","review_comments_url":"https://api.github.com/repos/openweave/openweave-core/pulls/244/comments","review_comment_url":"https://api.github.com/repos/openweave/openweave-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openweave/openweave-core/issues/244/comments","statuses_url":"https://api.github.com/repos/openweave/openweave-core/statuses/de62b98efed9c29b9248b33b479e8c2f1528dde1","head":{"label":"openweave:feature/emargolis/device-layer-logging","ref":"feature/emargolis/device-layer-logging","sha":"de62b98efed9c29b9248b33b479e8c2f1528dde1","user":{"login":"openweave","id":29963994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTYzOTk0","avatar_url":"https://avatars2.githubusercontent.com/u/29963994?v=4","gravatar_id":"","url":"https://api.github.com/users/openweave","html_url":"https://github.com/openweave","followers_url":"https://api.github.com/users/openweave/followers","following_url":"https://api.github.com/users/openweave/following{/other_user}","gists_url":"https://api.github.com/users/openweave/gists{/gist_id}","starred_url":"https://api.github.com/users/openweave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openweave/subscriptions","organizations_url":"https://api.github.com/users/openweave/orgs","repos_url":"https://api.github.com/users/openweave/repos","events_url":"https://api.github.com/users/openweave/events{/privacy}","received_events_url":"https://api.github.com/users/openweave/received_events","type":"Organization","site_admin":false},"repo":{"id":101915019,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MTUwMTk=","name":"openweave-core","full_name":"openweave/openweave-core","private":false,"owner":{"login":"openweave","id":29963994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTYzOTk0","avatar_url":"https://avatars2.githubusercontent.com/u/29963994?v=4","gravatar_id":"","url":"https://api.github.com/users/openweave","html_url":"https://github.com/openweave","followers_url":"https://api.github.com/users/openweave/followers","following_url":"https://api.github.com/users/openweave/following{/other_user}","gists_url":"https://api.github.com/users/openweave/gists{/gist_id}","starred_url":"https://api.github.com/users/openweave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openweave/subscriptions","organizations_url":"https://api.github.com/users/openweave/orgs","repos_url":"https://api.github.com/users/openweave/repos","events_url":"https://api.github.com/users/openweave/events{/privacy}","received_events_url":"https://api.github.com/users/openweave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openweave/openweave-core","description":"openWeave is a home area network application protocol stack designed to enable asynchronous, symmetric, device-to-device, device-to-mobile and device-to-cloud communications for control path and data path messaging. ","fork":false,"url":"https://api.github.com/repos/openweave/openweave-core","forks_url":"https://api.github.com/repos/openweave/openweave-core/forks","keys_url":"https://api.github.com/repos/openweave/openweave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openweave/openweave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openweave/openweave-core/teams","hooks_url":"https://api.github.com/repos/openweave/openweave-core/hooks","issue_events_url":"https://api.github.com/repos/openweave/openweave-core/issues/events{/number}","events_url":"https://api.github.com/repos/openweave/openweave-core/events","assignees_url":"https://api.github.com/repos/openweave/openweave-core/assignees{/user}","branches_url":"https://api.github.com/repos/openweave/openweave-core/branches{/branch}","tags_url":"https://api.github.com/repos/openweave/openweave-core/tags","blobs_url":"https://api.github.com/repos/openweave/openweave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openweave/openweave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openweave/openweave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openweave/openweave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openweave/openweave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openweave/openweave-core/languages","stargazers_url":"https://api.github.com/repos/openweave/openweave-core/stargazers","contributors_url":"https://api.github.com/repos/openweave/openweave-core/contributors","subscribers_url":"https://api.github.com/repos/openweave/openweave-core/subscribers","subscription_url":"https://api.github.com/repos/openweave/openweave-core/subscription","commits_url":"https://api.github.com/repos/openweave/openweave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openweave/openweave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openweave/openweave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openweave/openweave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openweave/openweave-core/contents/{+path}","compare_url":"https://api.github.com/repos/openweave/openweave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openweave/openweave-core/merges","archive_url":"https://api.github.com/repos/openweave/openweave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openweave/openweave-core/downloads","issues_url":"https://api.github.com/repos/openweave/openweave-core/issues{/number}","pulls_url":"https://api.github.com/repos/openweave/openweave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openweave/openweave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openweave/openweave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openweave/openweave-core/labels{/name}","releases_url":"https://api.github.com/repos/openweave/openweave-core/releases{/id}","deployments_url":"https://api.github.com/repos/openweave/openweave-core/deployments","created_at":"2017-08-30T18:22:10Z","updated_at":"2019-05-29T14:47:26Z","pushed_at":"2019-05-29T16:38:26Z","git_url":"git://github.com/openweave/openweave-core.git","ssh_url":"git@github.com:openweave/openweave-core.git","clone_url":"https://github.com/openweave/openweave-core.git","svn_url":"https://github.com/openweave/openweave-core","homepage":null,"size":47688,"stargazers_count":116,"watchers_count":116,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":48,"open_issues":22,"watchers":116,"default_branch":"master"}},"base":{"label":"openweave:master","ref":"master","sha":"6d6b3fc636f594440b524441a8c5e04758412052","user":{"login":"openweave","id":29963994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTYzOTk0","avatar_url":"https://avatars2.githubusercontent.com/u/29963994?v=4","gravatar_id":"","url":"https://api.github.com/users/openweave","html_url":"https://github.com/openweave","followers_url":"https://api.github.com/users/openweave/followers","following_url":"https://api.github.com/users/openweave/following{/other_user}","gists_url":"https://api.github.com/users/openweave/gists{/gist_id}","starred_url":"https://api.github.com/users/openweave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openweave/subscriptions","organizations_url":"https://api.github.com/users/openweave/orgs","repos_url":"https://api.github.com/users/openweave/repos","events_url":"https://api.github.com/users/openweave/events{/privacy}","received_events_url":"https://api.github.com/users/openweave/received_events","type":"Organization","site_admin":false},"repo":{"id":101915019,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MTUwMTk=","name":"openweave-core","full_name":"openweave/openweave-core","private":false,"owner":{"login":"openweave","id":29963994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTYzOTk0","avatar_url":"https://avatars2.githubusercontent.com/u/29963994?v=4","gravatar_id":"","url":"https://api.github.com/users/openweave","html_url":"https://github.com/openweave","followers_url":"https://api.github.com/users/openweave/followers","following_url":"https://api.github.com/users/openweave/following{/other_user}","gists_url":"https://api.github.com/users/openweave/gists{/gist_id}","starred_url":"https://api.github.com/users/openweave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openweave/subscriptions","organizations_url":"https://api.github.com/users/openweave/orgs","repos_url":"https://api.github.com/users/openweave/repos","events_url":"https://api.github.com/users/openweave/events{/privacy}","received_events_url":"https://api.github.com/users/openweave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openweave/openweave-core","description":"openWeave is a home area network application protocol stack designed to enable asynchronous, symmetric, device-to-device, device-to-mobile and device-to-cloud communications for control path and data path messaging. ","fork":false,"url":"https://api.github.com/repos/openweave/openweave-core","forks_url":"https://api.github.com/repos/openweave/openweave-core/forks","keys_url":"https://api.github.com/repos/openweave/openweave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openweave/openweave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openweave/openweave-core/teams","hooks_url":"https://api.github.com/repos/openweave/openweave-core/hooks","issue_events_url":"https://api.github.com/repos/openweave/openweave-core/issues/events{/number}","events_url":"https://api.github.com/repos/openweave/openweave-core/events","assignees_url":"https://api.github.com/repos/openweave/openweave-core/assignees{/user}","branches_url":"https://api.github.com/repos/openweave/openweave-core/branches{/branch}","tags_url":"https://api.github.com/repos/openweave/openweave-core/tags","blobs_url":"https://api.github.com/repos/openweave/openweave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openweave/openweave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openweave/openweave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openweave/openweave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openweave/openweave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openweave/openweave-core/languages","stargazers_url":"https://api.github.com/repos/openweave/openweave-core/stargazers","contributors_url":"https://api.github.com/repos/openweave/openweave-core/contributors","subscribers_url":"https://api.github.com/repos/openweave/openweave-core/subscribers","subscription_url":"https://api.github.com/repos/openweave/openweave-core/subscription","commits_url":"https://api.github.com/repos/openweave/openweave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openweave/openweave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openweave/openweave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openweave/openweave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openweave/openweave-core/contents/{+path}","compare_url":"https://api.github.com/repos/openweave/openweave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openweave/openweave-core/merges","archive_url":"https://api.github.com/repos/openweave/openweave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openweave/openweave-core/downloads","issues_url":"https://api.github.com/repos/openweave/openweave-core/issues{/number}","pulls_url":"https://api.github.com/repos/openweave/openweave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openweave/openweave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openweave/openweave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openweave/openweave-core/labels{/name}","releases_url":"https://api.github.com/repos/openweave/openweave-core/releases{/id}","deployments_url":"https://api.github.com/repos/openweave/openweave-core/deployments","created_at":"2017-08-30T18:22:10Z","updated_at":"2019-05-29T14:47:26Z","pushed_at":"2019-05-29T16:38:26Z","git_url":"git://github.com/openweave/openweave-core.git","ssh_url":"git@github.com:openweave/openweave-core.git","clone_url":"https://github.com/openweave/openweave-core.git","svn_url":"https://github.com/openweave/openweave-core","homepage":null,"size":47688,"stargazers_count":116,"watchers_count":116,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":48,"open_issues":22,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openweave/openweave-core/pulls/244"},"html":{"href":"https://github.com/openweave/openweave-core/pull/244"},"issue":{"href":"https://api.github.com/repos/openweave/openweave-core/issues/244"},"comments":{"href":"https://api.github.com/repos/openweave/openweave-core/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/openweave/openweave-core/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/openweave/openweave-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openweave/openweave-core/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/openweave/openweave-core/statuses/de62b98efed9c29b9248b33b479e8c2f1528dde1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gerickson"}}