{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/dropbox/goebpf/pulls/17","id":350192477,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwMTkyNDc3","html_url":"https://github.com/dropbox/goebpf/pull/17","diff_url":"https://github.com/dropbox/goebpf/pull/17.diff","patch_url":"https://github.com/dropbox/goebpf/pull/17.patch","issue_url":"https://api.github.com/repos/dropbox/goebpf/issues/17","number":17,"state":"closed","locked":false,"title":"[loader] Fix possible \"slice bounds out of range\" when one multiple programs in one ELF section","user":{"login":"belyalov","id":25273194,"node_id":"MDQ6VXNlcjI1MjczMTk0","avatar_url":"https://avatars2.githubusercontent.com/u/25273194?v=4","gravatar_id":"","url":"https://api.github.com/users/belyalov","html_url":"https://github.com/belyalov","followers_url":"https://api.github.com/users/belyalov/followers","following_url":"https://api.github.com/users/belyalov/following{/other_user}","gists_url":"https://api.github.com/users/belyalov/gists{/gist_id}","starred_url":"https://api.github.com/users/belyalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belyalov/subscriptions","organizations_url":"https://api.github.com/users/belyalov/orgs","repos_url":"https://api.github.com/users/belyalov/repos","events_url":"https://api.github.com/users/belyalov/events{/privacy}","received_events_url":"https://api.github.com/users/belyalov/received_events","type":"User","site_admin":false},"body":"Since order is not guaranteed it could cause something like\r\n```\r\npanic: runtime error: slice bounds out of range [recovered]\r\n\tpanic: runtime error: slice bounds out of range\r\n\r\ngoroutine 19 [running]:\r\ntesting.tRunner.func1(0xc42008e1e0)\r\n\t/usr/lib/go-1.10/src/testing/testing.go:742 +0x29d\r\npanic(0x7ffe40, 0xc8bd40)\r\n\t/usr/lib/go-1.10/src/runtime/panic.go:502 +0x229\r\ngithub.com/dropbox/goebpf.loadPrograms(0xc4200dadc0, 0xc420091740, 0x0, 0x0, 0x0)\r\n\t/home/belyalov/go/src/github.com/dropbox/goebpf/loader.go:370 +0xfef\r\ngithub.com/dropbox/goebpf.(*ebpfSystem).LoadElf(0xc42008cd20, 0x87b77c, 0x12, 0x0, 0x0)\r\n\t/home/belyalov/go/src/github.com/dropbox/goebpf/loader.go:394 +0x152\r\n```\r\n\r\nThis PR is also slightly refactors `xdp` integration test.","created_at":"2019-12-06T20:43:31Z","updated_at":"2019-12-07T01:39:34Z","closed_at":"2019-12-07T01:39:34Z","merged_at":"2019-12-07T01:39:34Z","merge_commit_sha":"28380766b7ba08a37b95fb02106048fb0561db54","assignee":null,"assignees":[],"requested_reviewers":[{"login":"piscesdk","id":3753494,"node_id":"MDQ6VXNlcjM3NTM0OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3753494?v=4","gravatar_id":"","url":"https://api.github.com/users/piscesdk","html_url":"https://github.com/piscesdk","followers_url":"https://api.github.com/users/piscesdk/followers","following_url":"https://api.github.com/users/piscesdk/following{/other_user}","gists_url":"https://api.github.com/users/piscesdk/gists{/gist_id}","starred_url":"https://api.github.com/users/piscesdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piscesdk/subscriptions","organizations_url":"https://api.github.com/users/piscesdk/orgs","repos_url":"https://api.github.com/users/piscesdk/repos","events_url":"https://api.github.com/users/piscesdk/events{/privacy}","received_events_url":"https://api.github.com/users/piscesdk/received_events","type":"User","site_admin":false},{"login":"veshij","id":6113489,"node_id":"MDQ6VXNlcjYxMTM0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6113489?v=4","gravatar_id":"","url":"https://api.github.com/users/veshij","html_url":"https://github.com/veshij","followers_url":"https://api.github.com/users/veshij/followers","following_url":"https://api.github.com/users/veshij/following{/other_user}","gists_url":"https://api.github.com/users/veshij/gists{/gist_id}","starred_url":"https://api.github.com/users/veshij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veshij/subscriptions","organizations_url":"https://api.github.com/users/veshij/orgs","repos_url":"https://api.github.com/users/veshij/repos","events_url":"https://api.github.com/users/veshij/events{/privacy}","received_events_url":"https://api.github.com/users/veshij/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dropbox/goebpf/pulls/17/commits","review_comments_url":"https://api.github.com/repos/dropbox/goebpf/pulls/17/comments","review_comment_url":"https://api.github.com/repos/dropbox/goebpf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dropbox/goebpf/issues/17/comments","statuses_url":"https://api.github.com/repos/dropbox/goebpf/statuses/bc37d533e64bae37f8ffdab72a7a40f5205e48eb","head":{"label":"dropbox:fix_loader","ref":"fix_loader","sha":"bc37d533e64bae37f8ffdab72a7a40f5205e48eb","user":{"login":"dropbox","id":559357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTM1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/559357?v=4","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":167455605,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc0NTU2MDU=","name":"goebpf","full_name":"dropbox/goebpf","private":false,"owner":{"login":"dropbox","id":559357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTM1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/559357?v=4","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dropbox/goebpf","description":"Library to work with eBPF programs from Go","fork":false,"url":"https://api.github.com/repos/dropbox/goebpf","forks_url":"https://api.github.com/repos/dropbox/goebpf/forks","keys_url":"https://api.github.com/repos/dropbox/goebpf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/goebpf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/goebpf/teams","hooks_url":"https://api.github.com/repos/dropbox/goebpf/hooks","issue_events_url":"https://api.github.com/repos/dropbox/goebpf/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/goebpf/events","assignees_url":"https://api.github.com/repos/dropbox/goebpf/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/goebpf/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/goebpf/tags","blobs_url":"https://api.github.com/repos/dropbox/goebpf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/goebpf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/goebpf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/goebpf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/goebpf/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/goebpf/languages","stargazers_url":"https://api.github.com/repos/dropbox/goebpf/stargazers","contributors_url":"https://api.github.com/repos/dropbox/goebpf/contributors","subscribers_url":"https://api.github.com/repos/dropbox/goebpf/subscribers","subscription_url":"https://api.github.com/repos/dropbox/goebpf/subscription","commits_url":"https://api.github.com/repos/dropbox/goebpf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/goebpf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/goebpf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/goebpf/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropbox/goebpf/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/goebpf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/goebpf/merges","archive_url":"https://api.github.com/repos/dropbox/goebpf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/goebpf/downloads","issues_url":"https://api.github.com/repos/dropbox/goebpf/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/goebpf/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/goebpf/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/goebpf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/goebpf/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/goebpf/releases{/id}","deployments_url":"https://api.github.com/repos/dropbox/goebpf/deployments","created_at":"2019-01-24T23:51:24Z","updated_at":"2019-12-06T20:44:37Z","pushed_at":"2019-12-07T01:39:34Z","git_url":"git://github.com/dropbox/goebpf.git","ssh_url":"git@github.com:dropbox/goebpf.git","clone_url":"https://github.com/dropbox/goebpf.git","svn_url":"https://github.com/dropbox/goebpf","homepage":"","size":105,"stargazers_count":394,"watchers_count":394,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":3,"watchers":394,"default_branch":"master"}},"base":{"label":"dropbox:master","ref":"master","sha":"52d6e4b07756d3448916e410e39cf4f323a3a278","user":{"login":"dropbox","id":559357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTM1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/559357?v=4","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":167455605,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc0NTU2MDU=","name":"goebpf","full_name":"dropbox/goebpf","private":false,"owner":{"login":"dropbox","id":559357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTM1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/559357?v=4","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dropbox/goebpf","description":"Library to work with eBPF programs from Go","fork":false,"url":"https://api.github.com/repos/dropbox/goebpf","forks_url":"https://api.github.com/repos/dropbox/goebpf/forks","keys_url":"https://api.github.com/repos/dropbox/goebpf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/goebpf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/goebpf/teams","hooks_url":"https://api.github.com/repos/dropbox/goebpf/hooks","issue_events_url":"https://api.github.com/repos/dropbox/goebpf/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/goebpf/events","assignees_url":"https://api.github.com/repos/dropbox/goebpf/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/goebpf/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/goebpf/tags","blobs_url":"https://api.github.com/repos/dropbox/goebpf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/goebpf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/goebpf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/goebpf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/goebpf/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/goebpf/languages","stargazers_url":"https://api.github.com/repos/dropbox/goebpf/stargazers","contributors_url":"https://api.github.com/repos/dropbox/goebpf/contributors","subscribers_url":"https://api.github.com/repos/dropbox/goebpf/subscribers","subscription_url":"https://api.github.com/repos/dropbox/goebpf/subscription","commits_url":"https://api.github.com/repos/dropbox/goebpf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/goebpf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/goebpf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/goebpf/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropbox/goebpf/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/goebpf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/goebpf/merges","archive_url":"https://api.github.com/repos/dropbox/goebpf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/goebpf/downloads","issues_url":"https://api.github.com/repos/dropbox/goebpf/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/goebpf/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/goebpf/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/goebpf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/goebpf/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/goebpf/releases{/id}","deployments_url":"https://api.github.com/repos/dropbox/goebpf/deployments","created_at":"2019-01-24T23:51:24Z","updated_at":"2019-12-06T20:44:37Z","pushed_at":"2019-12-07T01:39:34Z","git_url":"git://github.com/dropbox/goebpf.git","ssh_url":"git@github.com:dropbox/goebpf.git","clone_url":"https://github.com/dropbox/goebpf.git","svn_url":"https://github.com/dropbox/goebpf","homepage":"","size":105,"stargazers_count":394,"watchers_count":394,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":3,"watchers":394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dropbox/goebpf/pulls/17"},"html":{"href":"https://github.com/dropbox/goebpf/pull/17"},"issue":{"href":"https://api.github.com/repos/dropbox/goebpf/issues/17"},"comments":{"href":"https://api.github.com/repos/dropbox/goebpf/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/dropbox/goebpf/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/dropbox/goebpf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dropbox/goebpf/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/dropbox/goebpf/statuses/bc37d533e64bae37f8ffdab72a7a40f5205e48eb"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"belyalov","id":25273194,"node_id":"MDQ6VXNlcjI1MjczMTk0","avatar_url":"https://avatars2.githubusercontent.com/u/25273194?v=4","gravatar_id":"","url":"https://api.github.com/users/belyalov","html_url":"https://github.com/belyalov","followers_url":"https://api.github.com/users/belyalov/followers","following_url":"https://api.github.com/users/belyalov/following{/other_user}","gists_url":"https://api.github.com/users/belyalov/gists{/gist_id}","starred_url":"https://api.github.com/users/belyalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belyalov/subscriptions","organizations_url":"https://api.github.com/users/belyalov/orgs","repos_url":"https://api.github.com/users/belyalov/repos","events_url":"https://api.github.com/users/belyalov/events{/privacy}","received_events_url":"https://api.github.com/users/belyalov/received_events","type":"User","site_admin":false},"comments":2,"review_comments":4,"maintainer_can_modify":false,"commits":4,"additions":67,"deletions":52,"changed_files":3}}
{"actor":{"display_login":"belyalov"}}