{"action":"closed","number":20690,"pull_request":{"url":"https://api.github.com/repos/ant-design/ant-design/pulls/20690","id":359411104,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5NDExMTA0","html_url":"https://github.com/ant-design/ant-design/pull/20690","diff_url":"https://github.com/ant-design/ant-design/pull/20690.diff","patch_url":"https://github.com/ant-design/ant-design/pull/20690.patch","issue_url":"https://api.github.com/repos/ant-design/ant-design/issues/20690","number":20690,"state":"closed","locked":false,"title":"feat: add footer property to Drawer","user":{"login":"DeanVanNiekerk","id":3798908,"node_id":"MDQ6VXNlcjM3OTg5MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3798908?v=4","gravatar_id":"","url":"https://api.github.com/users/DeanVanNiekerk","html_url":"https://github.com/DeanVanNiekerk","followers_url":"https://api.github.com/users/DeanVanNiekerk/followers","following_url":"https://api.github.com/users/DeanVanNiekerk/following{/other_user}","gists_url":"https://api.github.com/users/DeanVanNiekerk/gists{/gist_id}","starred_url":"https://api.github.com/users/DeanVanNiekerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeanVanNiekerk/subscriptions","organizations_url":"https://api.github.com/users/DeanVanNiekerk/orgs","repos_url":"https://api.github.com/users/DeanVanNiekerk/repos","events_url":"https://api.github.com/users/DeanVanNiekerk/events{/privacy}","received_events_url":"https://api.github.com/users/DeanVanNiekerk/received_events","type":"User","site_admin":false},"body":"### 🤔 This is a ...\r\n\r\n- [x] New feature\r\n- [ ] Bug fix\r\n- [x] Site / document update\r\n\r\n### 🔗 Related issue link\r\n\r\n[feature request - Drawer footer support](https://github.com/ant-design/ant-design/issues/15204)\r\n\r\nprevious PR:  #19779\r\nclose #15204\r\n\r\n<!--\r\n1. Describe the source of requirement, like related issue link.\r\n-->\r\n\r\n### 💡 Background and solution\r\n\r\nI propose a solution to add a dedicated footer property on the `Drawer` component. This solution allows for a 'fixed' footer and title.\r\n\r\n![fixed](https://user-images.githubusercontent.com/3798908/68781753-e8b3ea00-0640-11ea-803b-399a84ebd5e8.gif)\r\n\r\n### 📝 Changelog\r\n\r\n<!--\r\nDescribe changes from userside, and list all potential break changes or other risks.\r\n--->\r\n- Add footer property to Drawer\r\n\r\n| Language   | Changelog |\r\n| ---------- | --------- |\r\n| 🇺🇸 English |  Add footer property to Drawer   |\r\n| 🇨🇳 Chinese |  将页脚属性添加到抽屉  |\r\n\r\n### ☑️ Self Check before Merge\r\n\r\n- [x] Doc is updated/provided or not needed\r\n- [x] Demo is updated/provided or not needed\r\n- [x] TypeScript definition is updated/provided or not needed\r\n- [x] Changelog is provided or not needed\r\n\r\n-----\r\n[View rendered components/drawer/demo/form-in-drawer.md](https://github.com/DeanVanNiekerk/ant-design/blob/4.0-prepare-drawer-footer/components/drawer/demo/form-in-drawer.md)\r\n[View rendered components/drawer/index.en-US.md](https://github.com/DeanVanNiekerk/ant-design/blob/4.0-prepare-drawer-footer/components/drawer/index.en-US.md)\r\n[View rendered components/drawer/index.zh-CN.md](https://github.com/DeanVanNiekerk/ant-design/blob/4.0-prepare-drawer-footer/components/drawer/index.zh-CN.md)\r\n\r\n-----\r\n[View rendered components/drawer/demo/form-in-drawer.md](https://github.com/DeanVanNiekerk/ant-design/blob/4.0-prepare-drawer-footer/components/drawer/demo/form-in-drawer.md)\r\n[View rendered components/drawer/demo/multi-level-drawer.md](https://github.com/DeanVanNiekerk/ant-design/blob/4.0-prepare-drawer-footer/components/drawer/demo/multi-level-drawer.md)\r\n[View rendered components/drawer/index.en-US.md](https://github.com/DeanVanNiekerk/ant-design/blob/4.0-prepare-drawer-footer/components/drawer/index.en-US.md)\r\n[View rendered components/drawer/index.zh-CN.md](https://github.com/DeanVanNiekerk/ant-design/blob/4.0-prepare-drawer-footer/components/drawer/index.zh-CN.md)","created_at":"2020-01-06T06:32:34Z","updated_at":"2020-01-06T06:56:01Z","closed_at":"2020-01-06T06:56:01Z","merged_at":"2020-01-06T06:56:00Z","merge_commit_sha":"019fdd58a0c05818003e6079e5e6d58937d494bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1310631616,"node_id":"MDU6TGFiZWwxMzEwNjMxNjE2","url":"https://api.github.com/repos/ant-design/ant-design/labels/PR:%20reviewed-changes-requested","name":"PR: reviewed-changes-requested","color":"c2e0c6","default":false,"description":null},{"id":1581978473,"node_id":"MDU6TGFiZWwxNTgxOTc4NDcz","url":"https://api.github.com/repos/ant-design/ant-design/labels/enhancement","name":"enhancement","color":"ededed","default":true,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/ant-design/ant-design/pulls/20690/commits","review_comments_url":"https://api.github.com/repos/ant-design/ant-design/pulls/20690/comments","review_comment_url":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ant-design/ant-design/issues/20690/comments","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/eb94cf8fdcd897ec1950fd435f04bd305d84b678","head":{"label":"DeanVanNiekerk:4.0-prepare-drawer-footer","ref":"4.0-prepare-drawer-footer","sha":"eb94cf8fdcd897ec1950fd435f04bd305d84b678","user":{"login":"DeanVanNiekerk","id":3798908,"node_id":"MDQ6VXNlcjM3OTg5MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3798908?v=4","gravatar_id":"","url":"https://api.github.com/users/DeanVanNiekerk","html_url":"https://github.com/DeanVanNiekerk","followers_url":"https://api.github.com/users/DeanVanNiekerk/followers","following_url":"https://api.github.com/users/DeanVanNiekerk/following{/other_user}","gists_url":"https://api.github.com/users/DeanVanNiekerk/gists{/gist_id}","starred_url":"https://api.github.com/users/DeanVanNiekerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeanVanNiekerk/subscriptions","organizations_url":"https://api.github.com/users/DeanVanNiekerk/orgs","repos_url":"https://api.github.com/users/DeanVanNiekerk/repos","events_url":"https://api.github.com/users/DeanVanNiekerk/events{/privacy}","received_events_url":"https://api.github.com/users/DeanVanNiekerk/received_events","type":"User","site_admin":false},"repo":{"id":221231944,"node_id":"MDEwOlJlcG9zaXRvcnkyMjEyMzE5NDQ=","name":"ant-design","full_name":"DeanVanNiekerk/ant-design","private":false,"owner":{"login":"DeanVanNiekerk","id":3798908,"node_id":"MDQ6VXNlcjM3OTg5MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3798908?v=4","gravatar_id":"","url":"https://api.github.com/users/DeanVanNiekerk","html_url":"https://github.com/DeanVanNiekerk","followers_url":"https://api.github.com/users/DeanVanNiekerk/followers","following_url":"https://api.github.com/users/DeanVanNiekerk/following{/other_user}","gists_url":"https://api.github.com/users/DeanVanNiekerk/gists{/gist_id}","starred_url":"https://api.github.com/users/DeanVanNiekerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeanVanNiekerk/subscriptions","organizations_url":"https://api.github.com/users/DeanVanNiekerk/orgs","repos_url":"https://api.github.com/users/DeanVanNiekerk/repos","events_url":"https://api.github.com/users/DeanVanNiekerk/events{/privacy}","received_events_url":"https://api.github.com/users/DeanVanNiekerk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DeanVanNiekerk/ant-design","description":"🌈 A UI Design Language and React UI library","fork":true,"url":"https://api.github.com/repos/DeanVanNiekerk/ant-design","forks_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/forks","keys_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/teams","hooks_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/hooks","issue_events_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/events","assignees_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/tags","blobs_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/languages","stargazers_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/stargazers","contributors_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/contributors","subscribers_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/subscribers","subscription_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/subscription","commits_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/merges","archive_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/downloads","issues_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/DeanVanNiekerk/ant-design/deployments","created_at":"2019-11-12T14:03:47Z","updated_at":"2019-11-18T05:39:32Z","pushed_at":"2020-01-06T06:20:26Z","git_url":"git://github.com/DeanVanNiekerk/ant-design.git","ssh_url":"git@github.com:DeanVanNiekerk/ant-design.git","clone_url":"https://github.com/DeanVanNiekerk/ant-design.git","svn_url":"https://github.com/DeanVanNiekerk/ant-design","homepage":"https://ant.design","size":49679,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ant-design:master","ref":"master","sha":"faa969206c4afc5bd043da3f22c1dfd6a69b29ac","user":{"login":"ant-design","id":12101536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAxNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"repo":{"id":34526884,"node_id":"MDEwOlJlcG9zaXRvcnkzNDUyNjg4NA==","name":"ant-design","full_name":"ant-design/ant-design","private":false,"owner":{"login":"ant-design","id":12101536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAxNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ant-design/ant-design","description":"🌈 A UI Design Language and React UI library","fork":false,"url":"https://api.github.com/repos/ant-design/ant-design","forks_url":"https://api.github.com/repos/ant-design/ant-design/forks","keys_url":"https://api.github.com/repos/ant-design/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-design/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-design/ant-design/teams","hooks_url":"https://api.github.com/repos/ant-design/ant-design/hooks","issue_events_url":"https://api.github.com/repos/ant-design/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/ant-design/ant-design/events","assignees_url":"https://api.github.com/repos/ant-design/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/ant-design/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/ant-design/ant-design/tags","blobs_url":"https://api.github.com/repos/ant-design/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-design/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-design/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-design/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-design/ant-design/languages","stargazers_url":"https://api.github.com/repos/ant-design/ant-design/stargazers","contributors_url":"https://api.github.com/repos/ant-design/ant-design/contributors","subscribers_url":"https://api.github.com/repos/ant-design/ant-design/subscribers","subscription_url":"https://api.github.com/repos/ant-design/ant-design/subscription","commits_url":"https://api.github.com/repos/ant-design/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-design/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-design/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-design/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-design/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/ant-design/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-design/ant-design/merges","archive_url":"https://api.github.com/repos/ant-design/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-design/ant-design/downloads","issues_url":"https://api.github.com/repos/ant-design/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/ant-design/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-design/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-design/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-design/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/ant-design/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/ant-design/ant-design/deployments","created_at":"2015-04-24T15:37:24Z","updated_at":"2020-01-06T06:54:58Z","pushed_at":"2020-01-06T06:56:02Z","git_url":"git://github.com/ant-design/ant-design.git","ssh_url":"git@github.com:ant-design/ant-design.git","clone_url":"https://github.com/ant-design/ant-design.git","svn_url":"https://github.com/ant-design/ant-design","homepage":"https://ant.design","size":83483,"stargazers_count":55064,"watchers_count":55064,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19956,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":473,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19956,"open_issues":473,"watchers":55064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/20690"},"html":{"href":"https://github.com/ant-design/ant-design/pull/20690"},"issue":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/20690"},"comments":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/20690/comments"},"review_comments":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/20690/comments"},"review_comment":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/20690/commits"},"statuses":{"href":"https://api.github.com/repos/ant-design/ant-design/statuses/eb94cf8fdcd897ec1950fd435f04bd305d84b678"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"afc163","id":507615,"node_id":"MDQ6VXNlcjUwNzYxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/507615?v=4","gravatar_id":"","url":"https://api.github.com/users/afc163","html_url":"https://github.com/afc163","followers_url":"https://api.github.com/users/afc163/followers","following_url":"https://api.github.com/users/afc163/following{/other_user}","gists_url":"https://api.github.com/users/afc163/gists{/gist_id}","starred_url":"https://api.github.com/users/afc163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afc163/subscriptions","organizations_url":"https://api.github.com/users/afc163/orgs","repos_url":"https://api.github.com/users/afc163/repos","events_url":"https://api.github.com/users/afc163/events{/privacy}","received_events_url":"https://api.github.com/users/afc163/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":141,"deletions":19,"changed_files":10}}
{"actor":{"display_login":"afc163"}}