{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/1549","repository_url":"https://api.github.com/repos/aws/aws-sdk-java-v2","labels_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/1549/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/1549/comments","events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/1549/events","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/1549","id":538849548,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzOTI2MDMw","number":1549,"title":"IntelliJ inspections","user":{"login":"jeffalder","id":49817386,"node_id":"MDQ6VXNlcjQ5ODE3Mzg2","avatar_url":"https://avatars0.githubusercontent.com/u/49817386?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffalder","html_url":"https://github.com/jeffalder","followers_url":"https://api.github.com/users/jeffalder/followers","following_url":"https://api.github.com/users/jeffalder/following{/other_user}","gists_url":"https://api.github.com/users/jeffalder/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffalder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffalder/subscriptions","organizations_url":"https://api.github.com/users/jeffalder/orgs","repos_url":"https://api.github.com/users/jeffalder/repos","events_url":"https://api.github.com/users/jeffalder/events{/privacy}","received_events_url":"https://api.github.com/users/jeffalder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-12-17T05:38:04Z","updated_at":"2019-12-20T14:29:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/1549","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/1549","diff_url":"https://github.com/aws/aws-sdk-java-v2/pull/1549.diff","patch_url":"https://github.com/aws/aws-sdk-java-v2/pull/1549.patch"},"body":"## Description\r\nRuns IntelliJ's automatic inspections and fixes a number of issues.\r\n\r\n## Motivation and Context\r\nMany places are still using old Java syntax and style. This PR includes several fixes including lambda improvements, redundancy removal, and minor performance changes.\r\n\r\nFixes #1541 \r\n\r\nThe biggest offender vis-a-vis inspections is Javadoc issues; since this project does indeed use Javadoc I'd fix that separately.\r\n\r\nLet me know if this PR is too big; I separated the commits to make it easier to see what's going on.\r\n\r\n## Testing\r\nmvn install\r\nvisual inspection of all changes for potential side-effects. I opted not to apply some.\r\n\r\n## Screenshots (if appropriate)\r\nn/a\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n\r\n## Checklist\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the **CONTRIBUTING** document\r\n- [x] Local run of `mvn install` succeeds\r\n- [x] My code follows the code style of this project\r\n- [x] My change requires a change to the Javadoc documentation\r\n- [x] I have updated the Javadoc documentation accordingly\r\n- [x] I have read the **README** document\r\n- [x] I have added tests to cover my changes\r\n- [x] All new and existing tests passed\r\n- [x] A short description of the change has been added to the **CHANGELOG**\r\n- [x] My change is to implement 1.11 parity feature and I have updated [LaunchChangelog](https://github.com/aws/aws-sdk-java-v2/blob/master/docs/LaunchChangelog.md)\r\n\r\n## License\r\n<!--- The SDK is released under the Apache 2.0 license (http://aws.amazon.com/apache2.0/), so any code you submit will be released under that license -->\r\n<!--- For substantial contributions, we may ask you to sign a Contributor License Agreement (http://en.wikipedia.org/wiki/Contributor_License_Agreement) -->\r\n<!--- Put an `x` in the below box if you confirm that this request can be released under the Apache 2 license -->\r\n- [x] I confirm that this pull request can be released under the Apache 2 license\r\n"},"comment":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/comments/567943537","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/1549#issuecomment-567943537","issue_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/1549","id":567943537,"node_id":"MDEyOklzc3VlQ29tbWVudDU2Nzk0MzUzNw==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2019-12-20T14:29:30Z","updated_at":"2019-12-20T14:29:30Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549?src=pr&el=h1) Report\n> Merging [#1549](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549?src=pr&el=desc) into [master](https://codecov.io/gh/aws/aws-sdk-java-v2/commit/e2e8370ef9c197420de86664f53d68e43fe6a867?src=pr&el=desc) will **increase** coverage by `0.08%`.\n> The diff coverage is `75%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/graphs/tree.svg?width=650&token=HsqoWdC27Q&height=150&src=pr)](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #1549      +/-   ##\n============================================\n+ Coverage     75.39%   75.48%   +0.08%     \n  Complexity      771      771              \n============================================\n  Files           883      883              \n  Lines         27588    27613      +25     \n  Branches       2154     2171      +17     \n============================================\n+ Hits          20800    20843      +43     \n+ Misses         5793     5780      -13     \n+ Partials        995      990       -5\n```\n\n| Flag | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| #unittests | `75.48% <75%> (+0.08%)` | `771 <2> (ø)` | :arrow_down: |\n\n| [Impacted Files](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...codegen/lite/regions/ServiceMetadataGenerator.java](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree#diff-Y29kZWdlbi1saXRlL3NyYy9tYWluL2phdmEvc29mdHdhcmUvYW1hem9uL2F3c3Nkay9jb2RlZ2VuL2xpdGUvcmVnaW9ucy9TZXJ2aWNlTWV0YWRhdGFHZW5lcmF0b3IuamF2YQ==) | `99.16% <ø> (-0.03%)` | `0 <0> (ø)` | |\n| [...lite/regions/ServiceMetadataProviderGenerator.java](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree#diff-Y29kZWdlbi1saXRlL3NyYy9tYWluL2phdmEvc29mdHdhcmUvYW1hem9uL2F3c3Nkay9jb2RlZ2VuL2xpdGUvcmVnaW9ucy9TZXJ2aWNlTWV0YWRhdGFQcm92aWRlckdlbmVyYXRvci5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [.../lite/regions/RegionMetadataProviderGenerator.java](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree#diff-Y29kZWdlbi1saXRlL3NyYy9tYWluL2phdmEvc29mdHdhcmUvYW1hem9uL2F3c3Nkay9jb2RlZ2VuL2xpdGUvcmVnaW9ucy9SZWdpb25NZXRhZGF0YVByb3ZpZGVyR2VuZXJhdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...protocols/xml/internal/marshall/XmlMarshaller.java](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree#diff-Y29yZS9wcm90b2NvbHMvYXdzLXhtbC1wcm90b2NvbC9zcmMvbWFpbi9qYXZhL3NvZnR3YXJlL2FtYXpvbi9hd3NzZGsvcHJvdG9jb2xzL3htbC9pbnRlcm5hbC9tYXJzaGFsbC9YbWxNYXJzaGFsbGVyLmphdmE=) | `100% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |\n| [...te/regions/PartitionMetadataProviderGenerator.java](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree#diff-Y29kZWdlbi1saXRlL3NyYy9tYWluL2phdmEvc29mdHdhcmUvYW1hem9uL2F3c3Nkay9jb2RlZ2VuL2xpdGUvcmVnaW9ucy9QYXJ0aXRpb25NZXRhZGF0YVByb3ZpZGVyR2VuZXJhdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...odegen/lite/maven/plugin/RegionGenerationMojo.java](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree#diff-Y29kZWdlbi1saXRlLW1hdmVuLXBsdWdpbi9zcmMvbWFpbi9qYXZhL3NvZnR3YXJlL2FtYXpvbi9hd3NzZGsvY29kZWdlbi9saXRlL21hdmVuL3BsdWdpbi9SZWdpb25HZW5lcmF0aW9uTW9qby5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...tomization/processors/ShapeModifiersProcessor.java](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree#diff-Y29kZWdlbi9zcmMvbWFpbi9qYXZhL3NvZnR3YXJlL2FtYXpvbi9hd3NzZGsvY29kZWdlbi9jdXN0b21pemF0aW9uL3Byb2Nlc3NvcnMvU2hhcGVNb2RpZmllcnNQcm9jZXNzb3IuamF2YQ==) | `39.79% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...sdk/codegen/poet/eventstream/EventStreamUtils.java](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree#diff-Y29kZWdlbi9zcmMvbWFpbi9qYXZhL3NvZnR3YXJlL2FtYXpvbi9hd3NzZGsvY29kZWdlbi9wb2V0L2V2ZW50c3RyZWFtL0V2ZW50U3RyZWFtVXRpbHMuamF2YQ==) | `65.38% <0%> (+2.42%)` | `0 <0> (ø)` | :arrow_down: |\n| [...ware/amazon/awssdk/utils/internal/Base16Codec.java](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree#diff-dXRpbHMvc3JjL21haW4vamF2YS9zb2Z0d2FyZS9hbWF6b24vYXdzc2RrL3V0aWxzL2ludGVybmFsL0Jhc2UxNkNvZGVjLmphdmE=) | `88.57% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...sdk/codegen/emitters/tasks/BaseGeneratorTasks.java](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree#diff-Y29kZWdlbi9zcmMvbWFpbi9qYXZhL3NvZnR3YXJlL2FtYXpvbi9hd3NzZGsvY29kZWdlbi9lbWl0dGVycy90YXNrcy9CYXNlR2VuZXJhdG9yVGFza3MuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| ... and [78 more](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549?src=pr&el=footer). Last update [e2e8370...4bfe1ab](https://codecov.io/gh/aws/aws-sdk-java-v2/pull/1549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}