{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/258772192","pull_request_review_id":206114272,"id":258772192,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODc3MjE5Mg==","diff_hunk":"@@ -358,38 +360,43 @@ def generate_storage_type_and_tensor(backend, density, scalar_type, declarations\n         top_env['cuda_type_headers'].append(\n             '#include \"ATen/{}.h\"'.format(env['Type']))\n \n-    return env","path":"aten/src/ATen/gen.py","position":17,"original_position":17,"commit_id":"e6c40ef3d2f8c291343f73a844d8a07936c8735f","original_commit_id":"848f95fd90c250b8a549ae0b389043a9a8c6fa2b","user":{"login":"li-roy","id":8813817,"node_id":"MDQ6VXNlcjg4MTM4MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"body":"seems like these returns were used for something else in the past but aren't really needed anymore","created_at":"2019-02-21T03:57:03Z","updated_at":"2019-02-21T03:57:03Z","html_url":"https://github.com/pytorch/pytorch/pull/17278#discussion_r258772192","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/17278","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/258772192"},"html":{"href":"https://github.com/pytorch/pytorch/pull/17278#discussion_r258772192"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/17278"}},"in_reply_to_id":258315526},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/17278","id":254452871,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NDUyODcx","html_url":"https://github.com/pytorch/pytorch/pull/17278","diff_url":"https://github.com/pytorch/pytorch/pull/17278.diff","patch_url":"https://github.com/pytorch/pytorch/pull/17278.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/17278","number":17278,"state":"open","locked":false,"title":"Generate derived extension backend Type classes for each scalar type","user":{"login":"li-roy","id":8813817,"node_id":"MDQ6VXNlcjg4MTM4MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"body":"Previously we only generate one class for each extension backend. This caused issues with scalarType() calls and mapping from variable Types to non-variable types. With this change we generate one Type for each scalar type. ","created_at":"2019-02-19T23:57:39Z","updated_at":"2019-02-21T03:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d196cc7bd28a78737e068d4f8708400abe83717","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gchanan","id":3768583,"node_id":"MDQ6VXNlcjM3Njg1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3768583?v=4","gravatar_id":"","url":"https://api.github.com/users/gchanan","html_url":"https://github.com/gchanan","followers_url":"https://api.github.com/users/gchanan/followers","following_url":"https://api.github.com/users/gchanan/following{/other_user}","gists_url":"https://api.github.com/users/gchanan/gists{/gist_id}","starred_url":"https://api.github.com/users/gchanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchanan/subscriptions","organizations_url":"https://api.github.com/users/gchanan/orgs","repos_url":"https://api.github.com/users/gchanan/repos","events_url":"https://api.github.com/users/gchanan/events{/privacy}","received_events_url":"https://api.github.com/users/gchanan/received_events","type":"User","site_admin":false},{"login":"ailzhang","id":5248122,"node_id":"MDQ6VXNlcjUyNDgxMjI=","avatar_url":"https://avatars2.githubusercontent.com/u/5248122?v=4","gravatar_id":"","url":"https://api.github.com/users/ailzhang","html_url":"https://github.com/ailzhang","followers_url":"https://api.github.com/users/ailzhang/followers","following_url":"https://api.github.com/users/ailzhang/following{/other_user}","gists_url":"https://api.github.com/users/ailzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/ailzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ailzhang/subscriptions","organizations_url":"https://api.github.com/users/ailzhang/orgs","repos_url":"https://api.github.com/users/ailzhang/repos","events_url":"https://api.github.com/users/ailzhang/events{/privacy}","received_events_url":"https://api.github.com/users/ailzhang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/17278/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/17278/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/17278/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/e6c40ef3d2f8c291343f73a844d8a07936c8735f","head":{"label":"li-roy:type-extension-derived","ref":"type-extension-derived","sha":"e6c40ef3d2f8c291343f73a844d8a07936c8735f","user":{"login":"li-roy","id":8813817,"node_id":"MDQ6VXNlcjg4MTM4MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"repo":{"id":119106720,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkxMDY3MjA=","name":"pytorch","full_name":"li-roy/pytorch","private":false,"owner":{"login":"li-roy","id":8813817,"node_id":"MDQ6VXNlcjg4MTM4MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/li-roy/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/li-roy/pytorch","forks_url":"https://api.github.com/repos/li-roy/pytorch/forks","keys_url":"https://api.github.com/repos/li-roy/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/li-roy/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/li-roy/pytorch/teams","hooks_url":"https://api.github.com/repos/li-roy/pytorch/hooks","issue_events_url":"https://api.github.com/repos/li-roy/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/li-roy/pytorch/events","assignees_url":"https://api.github.com/repos/li-roy/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/li-roy/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/li-roy/pytorch/tags","blobs_url":"https://api.github.com/repos/li-roy/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/li-roy/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/li-roy/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/li-roy/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/li-roy/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/li-roy/pytorch/languages","stargazers_url":"https://api.github.com/repos/li-roy/pytorch/stargazers","contributors_url":"https://api.github.com/repos/li-roy/pytorch/contributors","subscribers_url":"https://api.github.com/repos/li-roy/pytorch/subscribers","subscription_url":"https://api.github.com/repos/li-roy/pytorch/subscription","commits_url":"https://api.github.com/repos/li-roy/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/li-roy/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/li-roy/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/li-roy/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/li-roy/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/li-roy/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/li-roy/pytorch/merges","archive_url":"https://api.github.com/repos/li-roy/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/li-roy/pytorch/downloads","issues_url":"https://api.github.com/repos/li-roy/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/li-roy/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/li-roy/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/li-roy/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/li-roy/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/li-roy/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/li-roy/pytorch/deployments","created_at":"2018-01-26T21:46:02Z","updated_at":"2018-01-26T21:46:07Z","pushed_at":"2019-02-20T22:49:57Z","git_url":"git://github.com/li-roy/pytorch.git","ssh_url":"git@github.com:li-roy/pytorch.git","clone_url":"https://github.com/li-roy/pytorch.git","svn_url":"https://github.com/li-roy/pytorch","homepage":"http://pytorch.org","size":103281,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"2e67b34ea78f19868bd661c5e8715b4e2516a5e9","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2019-02-21T03:39:44Z","pushed_at":"2019-02-21T03:55:35Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"https://pytorch.org","size":108271,"stargazers_count":24997,"watchers_count":24997,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5925,"mirror_url":null,"archived":false,"open_issues_count":2622,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5925,"open_issues":2622,"watchers":24997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/17278"},"html":{"href":"https://github.com/pytorch/pytorch/pull/17278"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/17278"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/17278/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/17278/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/17278/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/e6c40ef3d2f8c291343f73a844d8a07936c8735f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"li-roy"}}