{"action":"created","issue":{"url":"https://api.github.com/repos/mirumee/saleor/issues/4876","repository_url":"https://api.github.com/repos/mirumee/saleor","labels_url":"https://api.github.com/repos/mirumee/saleor/issues/4876/labels{/name}","comments_url":"https://api.github.com/repos/mirumee/saleor/issues/4876/comments","events_url":"https://api.github.com/repos/mirumee/saleor/issues/4876/events","html_url":"https://github.com/mirumee/saleor/pull/4876","id":510496893,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwODYwNzky","number":4876,"title":"Fix permissions on updating/clearing Order metadata","user":{"login":"szewczykmira","id":6984271,"node_id":"MDQ6VXNlcjY5ODQyNzE=","avatar_url":"https://avatars1.githubusercontent.com/u/6984271?v=4","gravatar_id":"","url":"https://api.github.com/users/szewczykmira","html_url":"https://github.com/szewczykmira","followers_url":"https://api.github.com/users/szewczykmira/followers","following_url":"https://api.github.com/users/szewczykmira/following{/other_user}","gists_url":"https://api.github.com/users/szewczykmira/gists{/gist_id}","starred_url":"https://api.github.com/users/szewczykmira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szewczykmira/subscriptions","organizations_url":"https://api.github.com/users/szewczykmira/orgs","repos_url":"https://api.github.com/users/szewczykmira/repos","events_url":"https://api.github.com/users/szewczykmira/events{/privacy}","received_events_url":"https://api.github.com/users/szewczykmira/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-10-22T08:14:14Z","updated_at":"2019-10-22T08:22:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mirumee/saleor/pulls/4876","html_url":"https://github.com/mirumee/saleor/pull/4876","diff_url":"https://github.com/mirumee/saleor/pull/4876.diff","patch_url":"https://github.com/mirumee/saleor/pull/4876.patch"},"body":"During work on #4866 I thought that I've might have introduced some bugs to our codebase.\r\nThis PR will add tests on handling permissions on updating Order metadata and some small fixes to the logic.\r\n\r\n### Pull Request Checklist\r\n\r\n<!-- Please keep this section. It will make maintainer's life easier. -->\r\n\r\n1. [ ] Privileged views and APIs are guarded by proper permission checks.\r\n1. [ ] All visible strings are translated with proper context.\r\n1. [ ] All data-formatting is locale-aware (dates, numbers, and so on).\r\n1. [ ] Database queries are optimized and the number of queries is constant.\r\n1. [ ] Database migration files are up to date.\r\n1. [ ] The changes are tested.\r\n1. [ ] GraphQL schema and type definitions are up to date.\r\n1. [ ] Changes are mentioned in the changelog.\r\n"},"comment":{"url":"https://api.github.com/repos/mirumee/saleor/issues/comments/544855591","html_url":"https://github.com/mirumee/saleor/pull/4876#issuecomment-544855591","issue_url":"https://api.github.com/repos/mirumee/saleor/issues/4876","id":544855591,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NDg1NTU5MQ==","user":{"login":"django-queries","id":51326395,"node_id":"MDQ6VXNlcjUxMzI2Mzk1","avatar_url":"https://avatars3.githubusercontent.com/u/51326395?v=4","gravatar_id":"","url":"https://api.github.com/users/django-queries","html_url":"https://github.com/django-queries","followers_url":"https://api.github.com/users/django-queries/followers","following_url":"https://api.github.com/users/django-queries/following{/other_user}","gists_url":"https://api.github.com/users/django-queries/gists{/gist_id}","starred_url":"https://api.github.com/users/django-queries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-queries/subscriptions","organizations_url":"https://api.github.com/users/django-queries/orgs","repos_url":"https://api.github.com/users/django-queries/repos","events_url":"https://api.github.com/users/django-queries/events{/privacy}","received_events_url":"https://api.github.com/users/django-queries/received_events","type":"User","site_admin":false},"created_at":"2019-10-22T08:22:34Z","updated_at":"2019-10-22T08:22:34Z","author_association":"NONE","body":"\nHere is the report for 06338ce4e1e68bb2c11cb74916df1ef2d4d894d6 (mirumee/saleor @ fix/order-metadata-permissions)\nBase comparison is 861b282d291890d79d68da8a1c41c6d6688a6f2a.\n\n\n\n<details><summary>No differences were found. (click me)</summary>\n<p>\n\n```diff\n# api.benchmark checkout\n  test name                                  \tleft count \tright count\tduplicate count\n  -------------------------------------------\t-----------\t-----------\t---------------\n  add billing address to checkout            \t         34\t         34\t             20\n  add shipping to checkout                   \t          7\t          7\t              0\n  checkout payment charge                    \t         14\t         14\t              0\n  complete checkout                          \t          6\t          6\t              0\n  create checkout                            \t         48\t         48\t             24\n\n# api.benchmark homepage\n  test name                                  \tleft count \tright count\tduplicate count\n  -------------------------------------------\t-----------\t-----------\t---------------\n  retrieve main menu                         \t          5\t          5\t              0\n  retrieve product list                      \t          4\t          4\t              0\n  retrieve secondary menu                    \t          5\t          5\t              0\n  retrieve shop                              \t          2\t          2\t              0\n\n# api.benchmark product\n  test name                                  \tleft count \tright count\tduplicate count\n  -------------------------------------------\t-----------\t-----------\t---------------\n  product details                            \t         15\t         15\t              3\n  retrieve product attributes                \t         13\t         13\t              2\n\n# api.benchmark variant\n  test name                                  \tleft count \tright count\tduplicate count\n  -------------------------------------------\t-----------\t-----------\t---------------\n  product variant bulk create                \t         51\t         51\t              3\n  retrieve variant list                      \t         15\t         15\t              6\n\n# api product sorting attributes\n  test name                                  \tleft count \tright count\tduplicate count\n  -------------------------------------------\t-----------\t-----------\t---------------\n  sort product not having attribute data     \t         21\t         21\t              0\n```\n\n</p>\n</details>\n"}}
{"actor":{"display_login":"django-queries"}}