{"action":"created","comment":{"url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/comments/349126000","pull_request_review_id":320936832,"id":349126000,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0OTEyNjAwMA==","diff_hunk":"@@ -239,7 +239,6 @@ class InsightsArchiveSpecs(Specs):\n     saphostctl_getcimobject_sapinstance = simple_file(\"insights_commands/usr.sap.hostctrl.exe.saphostctrl_-function_GetCIMObject_-enuminstances_SAPInstance\")\n     saphostexec_status = simple_file(\"insights_commands/usr.sap.hostctrl.exe.saphostexec_-status\")\n     saphostexec_version = simple_file(\"insights_commands/usr.sap.hostctrl.exe.saphostexec_-version\")\n-    satellite_enabled_features = simple_file(\"insights_commands/python_-m_insights.tools.cat_--no-header_satellite_enabled_features\")","path":"insights/specs/insights_archive.py","position":4,"original_position":4,"commit_id":"0b05cc93cd8b1bcece39fcabd4d0189d01208fc8","original_commit_id":"c479e09ad0f85d8c1902b55f0f6219e11d248e7d","user":{"login":"bfahr","id":20520336,"node_id":"MDQ6VXNlcjIwNTIwMzM2","avatar_url":"https://avatars2.githubusercontent.com/u/20520336?v=4","gravatar_id":"","url":"https://api.github.com/users/bfahr","html_url":"https://github.com/bfahr","followers_url":"https://api.github.com/users/bfahr/followers","following_url":"https://api.github.com/users/bfahr/following{/other_user}","gists_url":"https://api.github.com/users/bfahr/gists{/gist_id}","starred_url":"https://api.github.com/users/bfahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfahr/subscriptions","organizations_url":"https://api.github.com/users/bfahr/orgs","repos_url":"https://api.github.com/users/bfahr/repos","events_url":"https://api.github.com/users/bfahr/events{/privacy}","received_events_url":"https://api.github.com/users/bfahr/received_events","type":"User","site_admin":false},"body":"@huali027 you've correctly implemented this with a dependency on a datasource that will prevent it from running on all systems.  From an implementation standpoint, using the mangle as I suggested is the correct way to implement the archive spec.","created_at":"2019-11-21T14:47:55Z","updated_at":"2019-11-21T14:47:56Z","html_url":"https://github.com/RedHatInsights/insights-core/pull/2319#discussion_r349126000","pull_request_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/2319","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/comments/349126000"},"html":{"href":"https://github.com/RedHatInsights/insights-core/pull/2319#discussion_r349126000"},"pull_request":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/2319"}},"in_reply_to_id":347999409},"pull_request":{"url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/2319","id":342453598,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyNDUzNTk4","html_url":"https://github.com/RedHatInsights/insights-core/pull/2319","diff_url":"https://github.com/RedHatInsights/insights-core/pull/2319.diff","patch_url":"https://github.com/RedHatInsights/insights-core/pull/2319.patch","issue_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/2319","number":2319,"state":"open","locked":false,"title":"Remove spec fist since it can't be collected by client","user":{"login":"huali027","id":44796653,"node_id":"MDQ6VXNlcjQ0Nzk2NjUz","avatar_url":"https://avatars1.githubusercontent.com/u/44796653?v=4","gravatar_id":"","url":"https://api.github.com/users/huali027","html_url":"https://github.com/huali027","followers_url":"https://api.github.com/users/huali027/followers","following_url":"https://api.github.com/users/huali027/following{/other_user}","gists_url":"https://api.github.com/users/huali027/gists{/gist_id}","starred_url":"https://api.github.com/users/huali027/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huali027/subscriptions","organizations_url":"https://api.github.com/users/huali027/orgs","repos_url":"https://api.github.com/users/huali027/repos","events_url":"https://api.github.com/users/huali027/events{/privacy}","received_events_url":"https://api.github.com/users/huali027/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/RedHatInsights/insights-core/issues/2318\r\nSigned-off-by: Huanhuan Li <huali@redhat.com>","created_at":"2019-11-19T02:20:49Z","updated_at":"2019-11-21T14:47:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86a0f5be00e5eb7ae178047983b0745c50a78ee3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/2319/commits","review_comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/2319/comments","review_comment_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/2319/comments","statuses_url":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/0b05cc93cd8b1bcece39fcabd4d0189d01208fc8","head":{"label":"RedHatInsights:fix_featues","ref":"fix_featues","sha":"0b05cc93cd8b1bcece39fcabd4d0189d01208fc8","user":{"login":"RedHatInsights","id":24939818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5ODE4","avatar_url":"https://avatars2.githubusercontent.com/u/24939818?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"repo":{"id":92518221,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUxODIyMQ==","name":"insights-core","full_name":"RedHatInsights/insights-core","private":false,"owner":{"login":"RedHatInsights","id":24939818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5ODE4","avatar_url":"https://avatars2.githubusercontent.com/u/24939818?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RedHatInsights/insights-core","description":"Insights Core is a data collection and processing framework used by Red Hat Insights","fork":false,"url":"https://api.github.com/repos/RedHatInsights/insights-core","forks_url":"https://api.github.com/repos/RedHatInsights/insights-core/forks","keys_url":"https://api.github.com/repos/RedHatInsights/insights-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatInsights/insights-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatInsights/insights-core/teams","hooks_url":"https://api.github.com/repos/RedHatInsights/insights-core/hooks","issue_events_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatInsights/insights-core/events","assignees_url":"https://api.github.com/repos/RedHatInsights/insights-core/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatInsights/insights-core/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatInsights/insights-core/tags","blobs_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatInsights/insights-core/languages","stargazers_url":"https://api.github.com/repos/RedHatInsights/insights-core/stargazers","contributors_url":"https://api.github.com/repos/RedHatInsights/insights-core/contributors","subscribers_url":"https://api.github.com/repos/RedHatInsights/insights-core/subscribers","subscription_url":"https://api.github.com/repos/RedHatInsights/insights-core/subscription","commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatInsights/insights-core/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatInsights/insights-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatInsights/insights-core/merges","archive_url":"https://api.github.com/repos/RedHatInsights/insights-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatInsights/insights-core/downloads","issues_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatInsights/insights-core/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatInsights/insights-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatInsights/insights-core/labels{/name}","releases_url":"https://api.github.com/repos/RedHatInsights/insights-core/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatInsights/insights-core/deployments","created_at":"2017-05-26T14:23:11Z","updated_at":"2019-11-21T14:36:16Z","pushed_at":"2019-11-21T14:41:44Z","git_url":"git://github.com/RedHatInsights/insights-core.git","ssh_url":"git@github.com:RedHatInsights/insights-core.git","clone_url":"https://github.com/RedHatInsights/insights-core.git","svn_url":"https://github.com/RedHatInsights/insights-core","homepage":"https://access.redhat.com/insights","size":10534,"stargazers_count":48,"watchers_count":48,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":123,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":91,"open_issues":123,"watchers":48,"default_branch":"master"}},"base":{"label":"RedHatInsights:master","ref":"master","sha":"95ed6b42f8ee6da5bb07141e2b9b0fcc8be13c0d","user":{"login":"RedHatInsights","id":24939818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5ODE4","avatar_url":"https://avatars2.githubusercontent.com/u/24939818?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"repo":{"id":92518221,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUxODIyMQ==","name":"insights-core","full_name":"RedHatInsights/insights-core","private":false,"owner":{"login":"RedHatInsights","id":24939818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5ODE4","avatar_url":"https://avatars2.githubusercontent.com/u/24939818?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RedHatInsights/insights-core","description":"Insights Core is a data collection and processing framework used by Red Hat Insights","fork":false,"url":"https://api.github.com/repos/RedHatInsights/insights-core","forks_url":"https://api.github.com/repos/RedHatInsights/insights-core/forks","keys_url":"https://api.github.com/repos/RedHatInsights/insights-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatInsights/insights-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatInsights/insights-core/teams","hooks_url":"https://api.github.com/repos/RedHatInsights/insights-core/hooks","issue_events_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatInsights/insights-core/events","assignees_url":"https://api.github.com/repos/RedHatInsights/insights-core/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatInsights/insights-core/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatInsights/insights-core/tags","blobs_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatInsights/insights-core/languages","stargazers_url":"https://api.github.com/repos/RedHatInsights/insights-core/stargazers","contributors_url":"https://api.github.com/repos/RedHatInsights/insights-core/contributors","subscribers_url":"https://api.github.com/repos/RedHatInsights/insights-core/subscribers","subscription_url":"https://api.github.com/repos/RedHatInsights/insights-core/subscription","commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatInsights/insights-core/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatInsights/insights-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatInsights/insights-core/merges","archive_url":"https://api.github.com/repos/RedHatInsights/insights-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatInsights/insights-core/downloads","issues_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatInsights/insights-core/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatInsights/insights-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatInsights/insights-core/labels{/name}","releases_url":"https://api.github.com/repos/RedHatInsights/insights-core/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatInsights/insights-core/deployments","created_at":"2017-05-26T14:23:11Z","updated_at":"2019-11-21T14:36:16Z","pushed_at":"2019-11-21T14:41:44Z","git_url":"git://github.com/RedHatInsights/insights-core.git","ssh_url":"git@github.com:RedHatInsights/insights-core.git","clone_url":"https://github.com/RedHatInsights/insights-core.git","svn_url":"https://github.com/RedHatInsights/insights-core","homepage":"https://access.redhat.com/insights","size":10534,"stargazers_count":48,"watchers_count":48,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":123,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":91,"open_issues":123,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/2319"},"html":{"href":"https://github.com/RedHatInsights/insights-core/pull/2319"},"issue":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/issues/2319"},"comments":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/issues/2319/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/2319/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/2319/commits"},"statuses":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/0b05cc93cd8b1bcece39fcabd4d0189d01208fc8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bfahr"}}