{"action":"closed","number":5770,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/5770","id":293863627,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzODYzNjI3","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/5770","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/5770.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/5770.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/5770","number":5770,"state":"closed","locked":false,"title":"Handle nil options and missing keys in ansible credentials","user":{"login":"carbonin","id":12697904,"node_id":"MDQ6VXNlcjEyNjk3OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/12697904?v=4","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"body":"The options field for ansible credentials can be nil as the options column in the authentications table is nullable.\r\n\r\nThis PR fixes the ansible credential textual summary helper to handle situations where we attempt to display fields that could be in options and are not and adds tests for these situations.\r\n\r\nGist of an example failure => https://gist.github.com/carbonin/06148fb88ccba952a2f4f43d332b3d20\r\nThis happens when navigating to the credential details page for a machine credential with a `nil` `options` column.\r\n\r\n@miq-bot assign @mzazrivec ","created_at":"2019-07-02T18:22:25Z","updated_at":"2019-07-08T13:49:01Z","closed_at":"2019-07-08T13:49:00Z","merged_at":"2019-07-08T13:49:00Z","merge_commit_sha":"8f0e068c237dcaf8ff5080bbe32b0d6d30c0a63e","assignee":{"login":"mzazrivec","id":6648365,"node_id":"MDQ6VXNlcjY2NDgzNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6648365?v=4","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false},"assignees":[{"login":"mzazrivec","id":6648365,"node_id":"MDQ6VXNlcjY2NDgzNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6648365?v=4","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":539672755,"node_id":"MDU6TGFiZWw1Mzk2NzI3NTU=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/automation/ansible","name":"automation/ansible","color":"5319e7","default":false},{"id":505074429,"node_id":"MDU6TGFiZWw1MDUwNzQ0Mjk=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones/76","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/milestone/76","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones/76/labels","id":4437557,"node_id":"MDk6TWlsZXN0b25lNDQzNzU1Nw==","number":76,"title":"Sprint 115 Ending Jul 8, 2019","description":"","creator":{"login":"martinpovolny","id":51095,"node_id":"MDQ6VXNlcjUxMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/51095?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":23,"state":"open","created_at":"2019-06-24T20:00:07Z","updated_at":"2019-07-08T13:49:01Z","due_on":"2019-07-08T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/5770/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/5770/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/5770/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/43acc92c04611e057ba3554b05abfc49d920b5d1","head":{"label":"carbonin:ansible_credentials_optional_options","ref":"ansible_credentials_optional_options","sha":"43acc92c04611e057ba3554b05abfc49d920b5d1","user":{"login":"carbonin","id":12697904,"node_id":"MDQ6VXNlcjEyNjk3OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/12697904?v=4","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"repo":{"id":78151141,"node_id":"MDEwOlJlcG9zaXRvcnk3ODE1MTE0MQ==","name":"manageiq-ui-classic","full_name":"carbonin/manageiq-ui-classic","private":false,"owner":{"login":"carbonin","id":12697904,"node_id":"MDQ6VXNlcjEyNjk3OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/12697904?v=4","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carbonin/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":true,"url":"https://api.github.com/repos/carbonin/manageiq-ui-classic","forks_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/carbonin/manageiq-ui-classic/deployments","created_at":"2017-01-05T21:50:22Z","updated_at":"2017-01-05T21:50:28Z","pushed_at":"2019-07-03T21:43:09Z","git_url":"git://github.com/carbonin/manageiq-ui-classic.git","ssh_url":"git@github.com:carbonin/manageiq-ui-classic.git","clone_url":"https://github.com/carbonin/manageiq-ui-classic.git","svn_url":"https://github.com/carbonin/manageiq-ui-classic","homepage":null,"size":66803,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"6c895b74f404ee271d6173a27d514b71f2c643f7","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":77085298,"node_id":"MDEwOlJlcG9zaXRvcnk3NzA4NTI5OA==","name":"manageiq-ui-classic","full_name":"ManageIQ/manageiq-ui-classic","private":false,"owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ManageIQ/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/deployments","created_at":"2016-12-21T20:53:08Z","updated_at":"2019-07-08T13:44:26Z","pushed_at":"2019-07-08T13:49:00Z","git_url":"git://github.com/ManageIQ/manageiq-ui-classic.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-classic.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-classic.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-classic","homepage":null,"size":78698,"stargazers_count":33,"watchers_count":33,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":278,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":173,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":278,"open_issues":173,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/5770"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/5770"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/5770"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/5770/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/5770/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/5770/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/43acc92c04611e057ba3554b05abfc49d920b5d1"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mzazrivec","id":6648365,"node_id":"MDQ6VXNlcjY2NDgzNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6648365?v=4","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false},"comments":14,"review_comments":5,"maintainer_can_modify":false,"commits":3,"additions":43,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"mzazrivec"}}