{"action":"created","comment":{"url":"https://api.github.com/repos/yldio/yld.io/pulls/comments/276618659","pull_request_review_id":228228049,"id":276618659,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NjYxODY1OQ==","diff_hunk":"@@ -0,0 +1,12 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<svg width=\"54px\" height=\"54px\" viewBox=\"0 0 54 54\" version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\">\n+    <!-- Generator: Sketch 53.2 (72643) - https://sketchapp.com -->\n+    <title>yldsvg dark</title>\n+    <desc>Created with Sketch.</desc>\n+    <g id=\"yldsvg-dark\" stroke=\"none\" stroke-width=\"1\" fill=\"none\" fill-rule=\"evenodd\">\n+        <g id=\"Group-2\">\n+            <rect id=\"Rectangle-7\" fill=\"#52FFAC\" x=\"0\" y=\"0\" width=\"54\" height=\"54\"></rect>\n+            <path d=\"M16.8201464,23.2905974 C18.4977896,23.2905974 19.8575263,21.9304179 19.8575263,20.2527747 C19.8575263,18.5751314 18.4977896,17.2153947 16.8201464,17.2153947 C15.1425032,17.2153947 13.7823237,18.5751314 13.7823237,20.2527747 C13.7823237,21.9304179 15.1425032,23.2905974 16.8201464,23.2905974 L16.8201464,23.2905974 Z M38.4789676,28.2522416 C38.4789676,26.5768122 37.1165743,25.2144189 35.4415877,25.2144189 C33.7666011,25.2144189 32.403765,26.5768122 32.403765,28.2522416 C32.403765,29.9267854 33.7666011,31.2896215 35.4415877,31.2896215 C37.1165743,31.2896215 38.4789676,29.9267854 38.4789676,28.2522416 L38.4789676,28.2522416 Z M42.557735,16 L42.557735,35.1881828 L38.5073047,35.1881828 L38.5073047,34.6325105 C37.5779373,35.0810332 36.5409776,35.339609 35.4415877,35.339609 C31.5332856,35.339609 28.3537775,32.1601009 28.3537775,28.2522416 C28.3537775,24.3434967 31.5332856,21.1639886 35.4415877,21.1639886 C36.5409776,21.1639886 37.5779373,21.4230072 38.5073047,21.8715299 L38.5073047,16 L42.557735,16 Z M28.3537775,16 L28.3537775,28.2522416 L28.3537775,35.1881828 L24.3033473,35.1881828 L24.3033473,23.7931376 L16.8205892,40.632 L12.388494,40.632 L14.6244661,35.6003986 L9,23.2905974 L13.453348,23.2905974 L16.8201464,30.6595644 L20.0948493,23.2905974 L24.3033473,23.2905974 L24.3033473,16 L28.3537775,16 Z\" id=\"Fill-1\" fill=\"#090329\"></path>\n+        </g>\n+    </g>\n+</svg>","path":"src/images/yldsvg_dark.svg","position":12,"original_position":12,"commit_id":"e205f304470ed98e4465446013959839ef3be05f","original_commit_id":"e205f304470ed98e4465446013959839ef3be05f","user":{"login":"SemraSh","id":32770804,"node_id":"MDQ6VXNlcjMyNzcwODA0","avatar_url":"https://avatars2.githubusercontent.com/u/32770804?v=4","gravatar_id":"","url":"https://api.github.com/users/SemraSh","html_url":"https://github.com/SemraSh","followers_url":"https://api.github.com/users/SemraSh/followers","following_url":"https://api.github.com/users/SemraSh/following{/other_user}","gists_url":"https://api.github.com/users/SemraSh/gists{/gist_id}","starred_url":"https://api.github.com/users/SemraSh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemraSh/subscriptions","organizations_url":"https://api.github.com/users/SemraSh/orgs","repos_url":"https://api.github.com/users/SemraSh/repos","events_url":"https://api.github.com/users/SemraSh/events{/privacy}","received_events_url":"https://api.github.com/users/SemraSh/received_events","type":"User","site_admin":false},"body":"This can be cleaned up a little: \r\n`xmlns` and `xmlns:xlink` are not needed. \r\n`<desc>Created with Sketch.</desc>` is not needed","created_at":"2019-04-18T11:14:33Z","updated_at":"2019-04-18T11:14:37Z","html_url":"https://github.com/yldio/yld.io/pull/188#discussion_r276618659","pull_request_url":"https://api.github.com/repos/yldio/yld.io/pulls/188","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/yldio/yld.io/pulls/comments/276618659"},"html":{"href":"https://github.com/yldio/yld.io/pull/188#discussion_r276618659"},"pull_request":{"href":"https://api.github.com/repos/yldio/yld.io/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/yldio/yld.io/pulls/188","id":270581093,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNTgxMDkz","html_url":"https://github.com/yldio/yld.io/pull/188","diff_url":"https://github.com/yldio/yld.io/pull/188.diff","patch_url":"https://github.com/yldio/yld.io/pull/188.patch","issue_url":"https://api.github.com/repos/yldio/yld.io/issues/188","number":188,"state":"open","locked":false,"title":"Topnav Logo Behaviour","user":{"login":"GBouffard","id":10553003,"node_id":"MDQ6VXNlcjEwNTUzMDAz","avatar_url":"https://avatars3.githubusercontent.com/u/10553003?v=4","gravatar_id":"","url":"https://api.github.com/users/GBouffard","html_url":"https://github.com/GBouffard","followers_url":"https://api.github.com/users/GBouffard/followers","following_url":"https://api.github.com/users/GBouffard/following{/other_user}","gists_url":"https://api.github.com/users/GBouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/GBouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GBouffard/subscriptions","organizations_url":"https://api.github.com/users/GBouffard/orgs","repos_url":"https://api.github.com/users/GBouffard/repos","events_url":"https://api.github.com/users/GBouffard/events{/privacy}","received_events_url":"https://api.github.com/users/GBouffard/received_events","type":"User","site_admin":false},"body":"## Description - [393 - Logo behaviour](https://trello.com/c/UDsuOzuF/393-2-logo-behaviour)\r\n[392 - Logo SVG behaviour](https://trello.com/c/mCINtiGZ/392-13-svg-logo-should-be-recoloured-rather-than-a-different-image-being-used-on-each-page)\r\n\r\n2 tickets done as one PR as they depend on each other:\r\n- [x] logo: takes the user to the homepage \r\n- [x] title: takes user to the 'service' page (appears on service & speciality pages. nb: so far only the engineering page has specialities) \r\n- [x] create component TopNavLogo and TopNavTitle \r\n- [x] used on current topnav implementation \r\n- [x] SEO pages should have Design / Engineering (depending if they're design or engineering)  \r\n- [x] TopNavTitle on Engineering, Design, Training, Delivery, Dedicated teams and Open Source.\r\nAdd an item (nb: it's set-up to work. So far only Engineering Design and Training pages are live)  \r\n- [x] SVG loading strategy for reusing the same file everywhere \r\n- [ ] different hover states for logo & TopNavTitle \r\n- [ ] document component \r\n\r\nAlso done:\r\n- [x] removed legacy code including the 3 \"logo+title\" images\r\n\r\n## Review template\r\n\r\n- [ ] checked that this PR resolves the spec provided from trello / this description\r\n- [ ] ensured that this PR does not introduce any obvious bugs\r\n","created_at":"2019-04-15T16:05:28Z","updated_at":"2019-04-18T11:14:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56fb65659968709fb155d2a33812572bac7e2af9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yldio/yld.io/pulls/188/commits","review_comments_url":"https://api.github.com/repos/yldio/yld.io/pulls/188/comments","review_comment_url":"https://api.github.com/repos/yldio/yld.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yldio/yld.io/issues/188/comments","statuses_url":"https://api.github.com/repos/yldio/yld.io/statuses/e205f304470ed98e4465446013959839ef3be05f","head":{"label":"yldio:topnav-logo-behaviour","ref":"topnav-logo-behaviour","sha":"e205f304470ed98e4465446013959839ef3be05f","user":{"login":"yldio","id":6999859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTk4NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6999859?v=4","gravatar_id":"","url":"https://api.github.com/users/yldio","html_url":"https://github.com/yldio","followers_url":"https://api.github.com/users/yldio/followers","following_url":"https://api.github.com/users/yldio/following{/other_user}","gists_url":"https://api.github.com/users/yldio/gists{/gist_id}","starred_url":"https://api.github.com/users/yldio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yldio/subscriptions","organizations_url":"https://api.github.com/users/yldio/orgs","repos_url":"https://api.github.com/users/yldio/repos","events_url":"https://api.github.com/users/yldio/events{/privacy}","received_events_url":"https://api.github.com/users/yldio/received_events","type":"Organization","site_admin":false},"repo":{"id":155368032,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUzNjgwMzI=","name":"yld.io","full_name":"yldio/yld.io","private":false,"owner":{"login":"yldio","id":6999859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTk4NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6999859?v=4","gravatar_id":"","url":"https://api.github.com/users/yldio","html_url":"https://github.com/yldio","followers_url":"https://api.github.com/users/yldio/followers","following_url":"https://api.github.com/users/yldio/following{/other_user}","gists_url":"https://api.github.com/users/yldio/gists{/gist_id}","starred_url":"https://api.github.com/users/yldio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yldio/subscriptions","organizations_url":"https://api.github.com/users/yldio/orgs","repos_url":"https://api.github.com/users/yldio/repos","events_url":"https://api.github.com/users/yldio/events{/privacy}","received_events_url":"https://api.github.com/users/yldio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yldio/yld.io","description":"YLD Website","fork":false,"url":"https://api.github.com/repos/yldio/yld.io","forks_url":"https://api.github.com/repos/yldio/yld.io/forks","keys_url":"https://api.github.com/repos/yldio/yld.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yldio/yld.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yldio/yld.io/teams","hooks_url":"https://api.github.com/repos/yldio/yld.io/hooks","issue_events_url":"https://api.github.com/repos/yldio/yld.io/issues/events{/number}","events_url":"https://api.github.com/repos/yldio/yld.io/events","assignees_url":"https://api.github.com/repos/yldio/yld.io/assignees{/user}","branches_url":"https://api.github.com/repos/yldio/yld.io/branches{/branch}","tags_url":"https://api.github.com/repos/yldio/yld.io/tags","blobs_url":"https://api.github.com/repos/yldio/yld.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yldio/yld.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yldio/yld.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/yldio/yld.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yldio/yld.io/statuses/{sha}","languages_url":"https://api.github.com/repos/yldio/yld.io/languages","stargazers_url":"https://api.github.com/repos/yldio/yld.io/stargazers","contributors_url":"https://api.github.com/repos/yldio/yld.io/contributors","subscribers_url":"https://api.github.com/repos/yldio/yld.io/subscribers","subscription_url":"https://api.github.com/repos/yldio/yld.io/subscription","commits_url":"https://api.github.com/repos/yldio/yld.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/yldio/yld.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/yldio/yld.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/yldio/yld.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/yldio/yld.io/contents/{+path}","compare_url":"https://api.github.com/repos/yldio/yld.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yldio/yld.io/merges","archive_url":"https://api.github.com/repos/yldio/yld.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yldio/yld.io/downloads","issues_url":"https://api.github.com/repos/yldio/yld.io/issues{/number}","pulls_url":"https://api.github.com/repos/yldio/yld.io/pulls{/number}","milestones_url":"https://api.github.com/repos/yldio/yld.io/milestones{/number}","notifications_url":"https://api.github.com/repos/yldio/yld.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yldio/yld.io/labels{/name}","releases_url":"https://api.github.com/repos/yldio/yld.io/releases{/id}","deployments_url":"https://api.github.com/repos/yldio/yld.io/deployments","created_at":"2018-10-30T10:42:29Z","updated_at":"2019-04-17T14:51:59Z","pushed_at":"2019-04-18T11:07:43Z","git_url":"git://github.com/yldio/yld.io.git","ssh_url":"git@github.com:yldio/yld.io.git","clone_url":"https://github.com/yldio/yld.io.git","svn_url":"https://github.com/yldio/yld.io","homepage":"https://yld.io/","size":17261,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":4,"watchers":8,"default_branch":"master"}},"base":{"label":"yldio:master","ref":"master","sha":"4cff4f240ac9e1c67801a551439365aa159cfa48","user":{"login":"yldio","id":6999859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTk4NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6999859?v=4","gravatar_id":"","url":"https://api.github.com/users/yldio","html_url":"https://github.com/yldio","followers_url":"https://api.github.com/users/yldio/followers","following_url":"https://api.github.com/users/yldio/following{/other_user}","gists_url":"https://api.github.com/users/yldio/gists{/gist_id}","starred_url":"https://api.github.com/users/yldio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yldio/subscriptions","organizations_url":"https://api.github.com/users/yldio/orgs","repos_url":"https://api.github.com/users/yldio/repos","events_url":"https://api.github.com/users/yldio/events{/privacy}","received_events_url":"https://api.github.com/users/yldio/received_events","type":"Organization","site_admin":false},"repo":{"id":155368032,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUzNjgwMzI=","name":"yld.io","full_name":"yldio/yld.io","private":false,"owner":{"login":"yldio","id":6999859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5OTk4NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6999859?v=4","gravatar_id":"","url":"https://api.github.com/users/yldio","html_url":"https://github.com/yldio","followers_url":"https://api.github.com/users/yldio/followers","following_url":"https://api.github.com/users/yldio/following{/other_user}","gists_url":"https://api.github.com/users/yldio/gists{/gist_id}","starred_url":"https://api.github.com/users/yldio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yldio/subscriptions","organizations_url":"https://api.github.com/users/yldio/orgs","repos_url":"https://api.github.com/users/yldio/repos","events_url":"https://api.github.com/users/yldio/events{/privacy}","received_events_url":"https://api.github.com/users/yldio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yldio/yld.io","description":"YLD Website","fork":false,"url":"https://api.github.com/repos/yldio/yld.io","forks_url":"https://api.github.com/repos/yldio/yld.io/forks","keys_url":"https://api.github.com/repos/yldio/yld.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yldio/yld.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yldio/yld.io/teams","hooks_url":"https://api.github.com/repos/yldio/yld.io/hooks","issue_events_url":"https://api.github.com/repos/yldio/yld.io/issues/events{/number}","events_url":"https://api.github.com/repos/yldio/yld.io/events","assignees_url":"https://api.github.com/repos/yldio/yld.io/assignees{/user}","branches_url":"https://api.github.com/repos/yldio/yld.io/branches{/branch}","tags_url":"https://api.github.com/repos/yldio/yld.io/tags","blobs_url":"https://api.github.com/repos/yldio/yld.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yldio/yld.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yldio/yld.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/yldio/yld.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yldio/yld.io/statuses/{sha}","languages_url":"https://api.github.com/repos/yldio/yld.io/languages","stargazers_url":"https://api.github.com/repos/yldio/yld.io/stargazers","contributors_url":"https://api.github.com/repos/yldio/yld.io/contributors","subscribers_url":"https://api.github.com/repos/yldio/yld.io/subscribers","subscription_url":"https://api.github.com/repos/yldio/yld.io/subscription","commits_url":"https://api.github.com/repos/yldio/yld.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/yldio/yld.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/yldio/yld.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/yldio/yld.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/yldio/yld.io/contents/{+path}","compare_url":"https://api.github.com/repos/yldio/yld.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yldio/yld.io/merges","archive_url":"https://api.github.com/repos/yldio/yld.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yldio/yld.io/downloads","issues_url":"https://api.github.com/repos/yldio/yld.io/issues{/number}","pulls_url":"https://api.github.com/repos/yldio/yld.io/pulls{/number}","milestones_url":"https://api.github.com/repos/yldio/yld.io/milestones{/number}","notifications_url":"https://api.github.com/repos/yldio/yld.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yldio/yld.io/labels{/name}","releases_url":"https://api.github.com/repos/yldio/yld.io/releases{/id}","deployments_url":"https://api.github.com/repos/yldio/yld.io/deployments","created_at":"2018-10-30T10:42:29Z","updated_at":"2019-04-17T14:51:59Z","pushed_at":"2019-04-18T11:07:43Z","git_url":"git://github.com/yldio/yld.io.git","ssh_url":"git@github.com:yldio/yld.io.git","clone_url":"https://github.com/yldio/yld.io.git","svn_url":"https://github.com/yldio/yld.io","homepage":"https://yld.io/","size":17261,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yldio/yld.io/pulls/188"},"html":{"href":"https://github.com/yldio/yld.io/pull/188"},"issue":{"href":"https://api.github.com/repos/yldio/yld.io/issues/188"},"comments":{"href":"https://api.github.com/repos/yldio/yld.io/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/yldio/yld.io/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/yldio/yld.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yldio/yld.io/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/yldio/yld.io/statuses/e205f304470ed98e4465446013959839ef3be05f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SemraSh"}}