{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/desktop/issues/1696","repository_url":"https://api.github.com/repos/nextcloud/desktop","labels_url":"https://api.github.com/repos/nextcloud/desktop/issues/1696/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/desktop/issues/1696/comments","events_url":"https://api.github.com/repos/nextcloud/desktop/issues/1696/events","html_url":"https://github.com/nextcloud/desktop/pull/1696","id":542007938,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2NTM0ODcy","number":1696,"title":"Heavy refactoring: Windows workaround for >= 4k (4096 bit) client-cert SSL keys and large certs","user":{"login":"misch7","id":48932272,"node_id":"MDQ6VXNlcjQ4OTMyMjcy","avatar_url":"https://avatars1.githubusercontent.com/u/48932272?v=4","gravatar_id":"","url":"https://api.github.com/users/misch7","html_url":"https://github.com/misch7","followers_url":"https://api.github.com/users/misch7/followers","following_url":"https://api.github.com/users/misch7/following{/other_user}","gists_url":"https://api.github.com/users/misch7/gists{/gist_id}","starred_url":"https://api.github.com/users/misch7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misch7/subscriptions","organizations_url":"https://api.github.com/users/misch7/orgs","repos_url":"https://api.github.com/users/misch7/repos","events_url":"https://api.github.com/users/misch7/events{/privacy}","received_events_url":"https://api.github.com/users/misch7/received_events","type":"User","site_admin":false},"labels":[{"id":815325347,"node_id":"MDU6TGFiZWw4MTUzMjUzNDc=","url":"https://api.github.com/repos/nextcloud/desktop/labels/3.%20to%20release","name":"3. to release","color":"0052cc","default":false,"description":""},{"id":815325349,"node_id":"MDU6TGFiZWw4MTUzMjUzNDk=","url":"https://api.github.com/repos/nextcloud/desktop/labels/bug","name":"bug","color":"ee0701","default":true,"description":""},{"id":1251424448,"node_id":"MDU6TGFiZWwxMjUxNDI0NDQ4","url":"https://api.github.com/repos/nextcloud/desktop/labels/feature:%20:key:%20authentication","name":"feature: :key: authentication","color":"c2e0c6","default":false,"description":""}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/nextcloud/desktop/milestones/13","html_url":"https://github.com/nextcloud/desktop/milestone/13","labels_url":"https://api.github.com/repos/nextcloud/desktop/milestones/13/labels","id":4866436,"node_id":"MDk6TWlsZXN0b25lNDg2NjQzNg==","number":13,"title":"2.6.2","description":"Bug fixes.","creator":{"login":"camilasan","id":241266,"node_id":"MDQ6VXNlcjI0MTI2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/241266?v=4","gravatar_id":"","url":"https://api.github.com/users/camilasan","html_url":"https://github.com/camilasan","followers_url":"https://api.github.com/users/camilasan/followers","following_url":"https://api.github.com/users/camilasan/following{/other_user}","gists_url":"https://api.github.com/users/camilasan/gists{/gist_id}","starred_url":"https://api.github.com/users/camilasan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camilasan/subscriptions","organizations_url":"https://api.github.com/users/camilasan/orgs","repos_url":"https://api.github.com/users/camilasan/repos","events_url":"https://api.github.com/users/camilasan/events{/privacy}","received_events_url":"https://api.github.com/users/camilasan/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":38,"state":"open","created_at":"2019-11-21T12:10:46Z","updated_at":"2019-12-24T07:53:15Z","due_on":"2019-12-23T08:00:00Z","closed_at":null},"comments":0,"created_at":"2019-12-24T06:19:18Z","updated_at":"2019-12-24T11:23:10Z","closed_at":"2019-12-24T06:47:36Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nextcloud/desktop/pulls/1696","html_url":"https://github.com/nextcloud/desktop/pull/1696","diff_url":"https://github.com/nextcloud/desktop/pull/1696.diff","patch_url":"https://github.com/nextcloud/desktop/pull/1696.patch"},"body":"### Heavy refactoring: Windows workaround for >= 4k (4096 bit) client-cert SSL keys and large certs\r\n\r\nWith `QtKeychain` on Windows, storing larger keys or certs in one keychain entry causes the following error due to limits in the Windows APIs:\r\n    `Error: \"Credential size exceeds maximum size of 2560\"`\r\n\r\nThis fix implements the new wrapper class `KeychainChunk` with wrapper jobs `ReadJob` and `WriteJob` to encapsulate the `QKeychain` handling of `ReadPasswordJob` and `WritePasswordJob` with `binaryData` but split every supplied keychain entry's data into 2048 byte chunks, on Windows only.\r\n\r\nThe wrapper is used for all keychain operations in `WebFlowCredentials`, except for the server password.\r\n\r\nFor reference also see previous fixes:\r\n- https://github.com/nextcloud/desktop/pull/1389\r\n- https://github.com/nextcloud/desktop/pull/1394\r\n\r\nThis should finally fix the re-opened issue:\r\n- https://github.com/nextcloud/desktop/issues/863\r\n\r\nHopefully this solves it once for all 😄 \r\ncc @rullzer @camilasan "},"comment":{"url":"https://api.github.com/repos/nextcloud/desktop/issues/comments/568728636","html_url":"https://github.com/nextcloud/desktop/pull/1696#issuecomment-568728636","issue_url":"https://api.github.com/repos/nextcloud/desktop/issues/1696","id":568728636,"node_id":"MDEyOklzc3VlQ29tbWVudDU2ODcyODYzNg==","user":{"login":"misch7","id":48932272,"node_id":"MDQ6VXNlcjQ4OTMyMjcy","avatar_url":"https://avatars1.githubusercontent.com/u/48932272?v=4","gravatar_id":"","url":"https://api.github.com/users/misch7","html_url":"https://github.com/misch7","followers_url":"https://api.github.com/users/misch7/followers","following_url":"https://api.github.com/users/misch7/following{/other_user}","gists_url":"https://api.github.com/users/misch7/gists{/gist_id}","starred_url":"https://api.github.com/users/misch7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misch7/subscriptions","organizations_url":"https://api.github.com/users/misch7/orgs","repos_url":"https://api.github.com/users/misch7/repos","events_url":"https://api.github.com/users/misch7/events{/privacy}","received_events_url":"https://api.github.com/users/misch7/received_events","type":"User","site_admin":false},"created_at":"2019-12-24T11:23:10Z","updated_at":"2019-12-24T11:23:10Z","author_association":"MEMBER","body":"Fixed error handling in another master commit: 2b2810511d5d3a70ac37f0241b764d7526b9dfac"}}
{"actor":{"display_login":"misch7"}}