{"action":"opened","number":8142,"pull_request":{"url":"https://api.github.com/repos/facebook/flow/pulls/8142","id":329975596,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5OTc1NTk2","html_url":"https://github.com/facebook/flow/pull/8142","diff_url":"https://github.com/facebook/flow/pull/8142.diff","patch_url":"https://github.com/facebook/flow/pull/8142.patch","issue_url":"https://api.github.com/repos/facebook/flow/issues/8142","number":8142,"state":"open","locked":false,"title":"[hack] fix File_url slashes on Windows","user":{"login":"mroch","id":3012,"node_id":"MDQ6VXNlcjMwMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3012?v=4","gravatar_id":"","url":"https://api.github.com/users/mroch","html_url":"https://github.com/mroch","followers_url":"https://api.github.com/users/mroch/followers","following_url":"https://api.github.com/users/mroch/following{/other_user}","gists_url":"https://api.github.com/users/mroch/gists{/gist_id}","starred_url":"https://api.github.com/users/mroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroch/subscriptions","organizations_url":"https://api.github.com/users/mroch/orgs","repos_url":"https://api.github.com/users/mroch/repos","events_url":"https://api.github.com/users/mroch/events{/privacy}","received_events_url":"https://api.github.com/users/mroch/received_events","type":"User","site_admin":false},"body":"Summary:\npreviously, `File_url.parse \"file:///c%3A/foo/bar\"` returned `\"c:/foo/bar\"` instead of `\"c:\\foo\\bar\"`, because `/` and `\\` are (generally) interchangeable on Windows.\n\nhowever, `Sys_utils.realpath` does convert them to `\\` (only if the file exists, otherwise it leaves it alone!), which makes it more difficult to compare two paths.\n\nso, we now match `realpath`'s behavior, converting `/` to `\\` on Windows.\n\nalso, `File_url.create \"c:\\foo\\bar\"` returns `\"file:///c%3A/foo/bar\"` on Windows, but on Linux, `\\` is a valid path character and should be escaped, like `\"file:///c%3A%5Cfoo%5Cbar\"`.\n\nDifferential Revision: D18024985\n\n","created_at":"2019-10-19T02:53:42Z","updated_at":"2019-10-19T02:53:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/flow/pulls/8142/commits","review_comments_url":"https://api.github.com/repos/facebook/flow/pulls/8142/comments","review_comment_url":"https://api.github.com/repos/facebook/flow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/flow/issues/8142/comments","statuses_url":"https://api.github.com/repos/facebook/flow/statuses/51752ad3a5edf1c978486e0a45921fa166e67c22","head":{"label":"mroch:export-D18024985","ref":"export-D18024985","sha":"51752ad3a5edf1c978486e0a45921fa166e67c22","user":{"login":"mroch","id":3012,"node_id":"MDQ6VXNlcjMwMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3012?v=4","gravatar_id":"","url":"https://api.github.com/users/mroch","html_url":"https://github.com/mroch","followers_url":"https://api.github.com/users/mroch/followers","following_url":"https://api.github.com/users/mroch/following{/other_user}","gists_url":"https://api.github.com/users/mroch/gists{/gist_id}","starred_url":"https://api.github.com/users/mroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroch/subscriptions","organizations_url":"https://api.github.com/users/mroch/orgs","repos_url":"https://api.github.com/users/mroch/repos","events_url":"https://api.github.com/users/mroch/events{/privacy}","received_events_url":"https://api.github.com/users/mroch/received_events","type":"User","site_admin":false},"repo":{"id":33884096,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4NDA5Ng==","name":"flow","full_name":"mroch/flow","private":false,"owner":{"login":"mroch","id":3012,"node_id":"MDQ6VXNlcjMwMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3012?v=4","gravatar_id":"","url":"https://api.github.com/users/mroch","html_url":"https://github.com/mroch","followers_url":"https://api.github.com/users/mroch/followers","following_url":"https://api.github.com/users/mroch/following{/other_user}","gists_url":"https://api.github.com/users/mroch/gists{/gist_id}","starred_url":"https://api.github.com/users/mroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroch/subscriptions","organizations_url":"https://api.github.com/users/mroch/orgs","repos_url":"https://api.github.com/users/mroch/repos","events_url":"https://api.github.com/users/mroch/events{/privacy}","received_events_url":"https://api.github.com/users/mroch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mroch/flow","description":"Adds static typing to JavaScript to improve developer productivity and code quality.","fork":true,"url":"https://api.github.com/repos/mroch/flow","forks_url":"https://api.github.com/repos/mroch/flow/forks","keys_url":"https://api.github.com/repos/mroch/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mroch/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mroch/flow/teams","hooks_url":"https://api.github.com/repos/mroch/flow/hooks","issue_events_url":"https://api.github.com/repos/mroch/flow/issues/events{/number}","events_url":"https://api.github.com/repos/mroch/flow/events","assignees_url":"https://api.github.com/repos/mroch/flow/assignees{/user}","branches_url":"https://api.github.com/repos/mroch/flow/branches{/branch}","tags_url":"https://api.github.com/repos/mroch/flow/tags","blobs_url":"https://api.github.com/repos/mroch/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mroch/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mroch/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/mroch/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mroch/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/mroch/flow/languages","stargazers_url":"https://api.github.com/repos/mroch/flow/stargazers","contributors_url":"https://api.github.com/repos/mroch/flow/contributors","subscribers_url":"https://api.github.com/repos/mroch/flow/subscribers","subscription_url":"https://api.github.com/repos/mroch/flow/subscription","commits_url":"https://api.github.com/repos/mroch/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/mroch/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/mroch/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/mroch/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/mroch/flow/contents/{+path}","compare_url":"https://api.github.com/repos/mroch/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mroch/flow/merges","archive_url":"https://api.github.com/repos/mroch/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mroch/flow/downloads","issues_url":"https://api.github.com/repos/mroch/flow/issues{/number}","pulls_url":"https://api.github.com/repos/mroch/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/mroch/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/mroch/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mroch/flow/labels{/name}","releases_url":"https://api.github.com/repos/mroch/flow/releases{/id}","deployments_url":"https://api.github.com/repos/mroch/flow/deployments","created_at":"2015-04-13T17:48:19Z","updated_at":"2019-08-28T16:48:03Z","pushed_at":"2019-10-19T02:53:41Z","git_url":"git://github.com/mroch/flow.git","ssh_url":"git@github.com:mroch/flow.git","clone_url":"https://github.com/mroch/flow.git","svn_url":"https://github.com/mroch/flow","homepage":"http://flowtype.org/","size":56636,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"40617b4c27e50809cef349d770c512c734fff3e0","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":25880891,"node_id":"MDEwOlJlcG9zaXRvcnkyNTg4MDg5MQ==","name":"flow","full_name":"facebook/flow","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/flow","description":"Adds static typing to JavaScript to improve developer productivity and code quality.","fork":false,"url":"https://api.github.com/repos/facebook/flow","forks_url":"https://api.github.com/repos/facebook/flow/forks","keys_url":"https://api.github.com/repos/facebook/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/flow/teams","hooks_url":"https://api.github.com/repos/facebook/flow/hooks","issue_events_url":"https://api.github.com/repos/facebook/flow/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/flow/events","assignees_url":"https://api.github.com/repos/facebook/flow/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/flow/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/flow/tags","blobs_url":"https://api.github.com/repos/facebook/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/flow/languages","stargazers_url":"https://api.github.com/repos/facebook/flow/stargazers","contributors_url":"https://api.github.com/repos/facebook/flow/contributors","subscribers_url":"https://api.github.com/repos/facebook/flow/subscribers","subscription_url":"https://api.github.com/repos/facebook/flow/subscription","commits_url":"https://api.github.com/repos/facebook/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/flow/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/flow/merges","archive_url":"https://api.github.com/repos/facebook/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/flow/downloads","issues_url":"https://api.github.com/repos/facebook/flow/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/flow/labels{/name}","releases_url":"https://api.github.com/repos/facebook/flow/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/flow/deployments","created_at":"2014-10-28T17:17:45Z","updated_at":"2019-10-19T01:50:19Z","pushed_at":"2019-10-18T21:35:26Z","git_url":"git://github.com/facebook/flow.git","ssh_url":"git@github.com:facebook/flow.git","clone_url":"https://github.com/facebook/flow.git","svn_url":"https://github.com/facebook/flow","homepage":"https://flow.org/","size":57748,"stargazers_count":20114,"watchers_count":20114,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1710,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2528,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1710,"open_issues":2528,"watchers":20114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/flow/pulls/8142"},"html":{"href":"https://github.com/facebook/flow/pull/8142"},"issue":{"href":"https://api.github.com/repos/facebook/flow/issues/8142"},"comments":{"href":"https://api.github.com/repos/facebook/flow/issues/8142/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/flow/pulls/8142/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/flow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/flow/pulls/8142/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/flow/statuses/51752ad3a5edf1c978486e0a45921fa166e67c22"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":73,"deletions":53,"changed_files":1}}
{"actor":{"display_login":"mroch"}}