{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/667","repository_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime","labels_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/667/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/667/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/667/events","html_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/667","id":515299053,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0NzgxNzA2","number":667,"title":"🐛 Fix informer cache creating pointers to pointers","user":{"login":"DewaldV","id":1655931,"node_id":"MDQ6VXNlcjE2NTU5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1655931?v=4","gravatar_id":"","url":"https://api.github.com/users/DewaldV","html_url":"https://github.com/DewaldV","followers_url":"https://api.github.com/users/DewaldV/followers","following_url":"https://api.github.com/users/DewaldV/following{/other_user}","gists_url":"https://api.github.com/users/DewaldV/gists{/gist_id}","starred_url":"https://api.github.com/users/DewaldV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DewaldV/subscriptions","organizations_url":"https://api.github.com/users/DewaldV/orgs","repos_url":"https://api.github.com/users/DewaldV/repos","events_url":"https://api.github.com/users/DewaldV/events{/privacy}","received_events_url":"https://api.github.com/users/DewaldV/received_events","type":"User","site_admin":false},"labels":[{"id":957926551,"node_id":"MDU6TGFiZWw5NTc5MjY1NTE=","url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/labels/cncf-cla:%20no","name":"cncf-cla: no","color":"e11d21","default":false},{"id":957926586,"node_id":"MDU6TGFiZWw5NTc5MjY1ODY=","url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":957926588,"node_id":"MDU6TGFiZWw5NTc5MjY1ODg=","url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-10-31T09:53:45Z","updated_at":"2019-10-31T09:57:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/pulls/667","html_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/667","diff_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/667.diff","patch_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/667.patch"},"body":"It appears the code in controller-runtime/pkg/cache/informer_cache.go tries to determine whether the items can be cast to runtime.Object and in the process assumes that the slice's elements are not pointers.\r\n\r\nThis means that if you have a List whose Items type is `[]*Item` the informer cache will create a `cacheTypeValue` of `**Item` which then cannot be case to `runtime.Object` resulting in an error of:\r\n\r\n```\r\n\"error\": \"cannot get cache for *v1.PrometheusRuleList, its element **v1.PrometheusRule is not a runtime.Object\"}\r\n```\r\n\r\nDocumented more fully in issue #656"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/comments/548293567","html_url":"https://github.com/kubernetes-sigs/controller-runtime/pull/667#issuecomment-548293567","issue_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/667","id":548293567,"node_id":"MDEyOklzc3VlQ29tbWVudDU0ODI5MzU2Nw==","user":{"login":"DewaldV","id":1655931,"node_id":"MDQ6VXNlcjE2NTU5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1655931?v=4","gravatar_id":"","url":"https://api.github.com/users/DewaldV","html_url":"https://github.com/DewaldV","followers_url":"https://api.github.com/users/DewaldV/followers","following_url":"https://api.github.com/users/DewaldV/following{/other_user}","gists_url":"https://api.github.com/users/DewaldV/gists{/gist_id}","starred_url":"https://api.github.com/users/DewaldV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DewaldV/subscriptions","organizations_url":"https://api.github.com/users/DewaldV/orgs","repos_url":"https://api.github.com/users/DewaldV/repos","events_url":"https://api.github.com/users/DewaldV/events{/privacy}","received_events_url":"https://api.github.com/users/DewaldV/received_events","type":"User","site_admin":false},"created_at":"2019-10-31T09:57:41Z","updated_at":"2019-10-31T09:57:41Z","author_association":"NONE","body":"Hmm, my org has a signed CLA so I expected that check to pass. I'll try and see what's up with that before proceeding here."}}
{"actor":{"display_login":"DewaldV"}}