{"action":"opened","issue":{"url":"https://api.github.com/repos/phetsims/blackbody-spectrum/issues/76","repository_url":"https://api.github.com/repos/phetsims/blackbody-spectrum","labels_url":"https://api.github.com/repos/phetsims/blackbody-spectrum/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/blackbody-spectrum/issues/76/comments","events_url":"https://api.github.com/repos/phetsims/blackbody-spectrum/issues/76/events","html_url":"https://github.com/phetsims/blackbody-spectrum/issues/76","id":411614612,"node_id":"MDU6SXNzdWU0MTE2MTQ2MTI=","number":76,"title":"String keys can be simplified","user":{"login":"chrisklus","id":5618316,"node_id":"MDQ6VXNlcjU2MTgzMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5618316?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisklus","html_url":"https://github.com/chrisklus","followers_url":"https://api.github.com/users/chrisklus/followers","following_url":"https://api.github.com/users/chrisklus/following{/other_user}","gists_url":"https://api.github.com/users/chrisklus/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisklus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisklus/subscriptions","organizations_url":"https://api.github.com/users/chrisklus/orgs","repos_url":"https://api.github.com/users/chrisklus/repos","events_url":"https://api.github.com/users/chrisklus/events{/privacy}","received_events_url":"https://api.github.com/users/chrisklus/received_events","type":"User","site_admin":false},"labels":[{"id":322193096,"node_id":"MDU6TGFiZWwzMjIxOTMwOTY=","url":"https://api.github.com/repos/phetsims/blackbody-spectrum/labels/dev:code-review","name":"dev:code-review","color":"104E8B","default":false}],"state":"open","locked":false,"assignee":{"login":"arnabp","id":8583364,"node_id":"MDQ6VXNlcjg1ODMzNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8583364?v=4","gravatar_id":"","url":"https://api.github.com/users/arnabp","html_url":"https://github.com/arnabp","followers_url":"https://api.github.com/users/arnabp/followers","following_url":"https://api.github.com/users/arnabp/following{/other_user}","gists_url":"https://api.github.com/users/arnabp/gists{/gist_id}","starred_url":"https://api.github.com/users/arnabp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnabp/subscriptions","organizations_url":"https://api.github.com/users/arnabp/orgs","repos_url":"https://api.github.com/users/arnabp/repos","events_url":"https://api.github.com/users/arnabp/events{/privacy}","received_events_url":"https://api.github.com/users/arnabp/received_events","type":"User","site_admin":false},"assignees":[{"login":"arnabp","id":8583364,"node_id":"MDQ6VXNlcjg1ODMzNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8583364?v=4","gravatar_id":"","url":"https://api.github.com/users/arnabp","html_url":"https://github.com/arnabp","followers_url":"https://api.github.com/users/arnabp/followers","following_url":"https://api.github.com/users/arnabp/following{/other_user}","gists_url":"https://api.github.com/users/arnabp/gists{/gist_id}","starred_url":"https://api.github.com/users/arnabp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnabp/subscriptions","organizations_url":"https://api.github.com/users/arnabp/orgs","repos_url":"https://api.github.com/users/arnabp/repos","events_url":"https://api.github.com/users/arnabp/events{/privacy}","received_events_url":"https://api.github.com/users/arnabp/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2019-02-18T19:22:18Z","updated_at":"2019-02-18T19:22:18Z","closed_at":null,"author_association":"NONE","body":"From https://github.com/phetsims/blackbody-spectrum/issues/33.\r\n\r\nIt looks like keys from the older sim were ported over and have not been updated. According to the checklist, standard PhET convention is to not add a descriptor to the string key unless it would collide with another key, or if the value cannot really be used as the key. \r\n\r\nIMO, it seems reasonable to me to tack on \"Label\" to the key when there are characters in the value that wouldn't make sense to include in the key (and the string is used as a label). My recommended changes:\r\n\r\n`verticalLabelSpectralRadiance` -> `spectralRadianceLabel`\r\n`horizontalLabelWavelength` -> `wavelengthLabel`\r\n`sirius` -> `siriusA`\r\n`lightbulb` -> `lightBulb`, and value should be two words as \"Light bulb\"\r\n`xrayLabel` -> `xRay`\r\n`ultravioletLabel` -> `ultraviolet`\r\n`visibleLabel` -> `visible`\r\n`infraredLabel` -> `infrared`\r\n\r\nFeel free to use your own judgement or consult with someone else, too.\r\n\r\n"}}
{"actor":{"display_login":"chrisklus"}}