{"push_id":3798497496,"size":2,"distinct_size":0,"ref":"refs/heads/master","head":"ea7ebb9276db0a0675eb80385b6f97d4c6c48c60","before":"fe51e2e80036438362e3d814d0cacdb099a40a14","commits":[{"sha":"64362eb303157caeff124166de6c043d088736ab","author":{"name":"Jeffrey Xiao","email":"53dedebd7966a74b8912f3e7a434d62283124a58@gmail.com"},"message":"kv: remove double eviction policy in range cache\n\nPreviously if we were evicting a user-space descriptor, meta range\ndescriptors would also be evicted. Evicting meta range descriptors is\nexpensive and we shouldn't do it until we have evidence that they're\nout-of-date and useless. We should just evict a descriptor when it's\nfound to be stale whether it's a user-space descriptor during normal\noperation or a meta descriptor during a range lookup.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/64362eb303157caeff124166de6c043d088736ab"},{"sha":"ea7ebb9276db0a0675eb80385b6f97d4c6c48c60","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #38269\n\n38269: kv: remove double eviction policy in range cache r=jeffrey-xiao a=jeffrey-xiao\n\nPreviously if we were evicting a user-space descriptor, meta range descriptors would also be evicted. Evicting meta range descriptors is expensive and we shouldn't do it until we have evidence that they're out-of-date and useless. We should just evict a descriptor when it's found to be stale whether it's a user-space descriptor during normal operation or a meta descriptor during a range lookup.\r\n\r\nFixes: #18988\r\n\r\nRelease note: None\r\n\r\nI've collected metrics to compare this PR against master (`15d4329`) under two workloads while the cluster is running `kv50`.\r\n\r\n1. Split workload: Two workers splitting random ranges: `ALTER TABLE kv.kv SPLIT AT VALUES (CAST(ROUND(RANDOM() * 9223372036854775808) AS INT)) WITH EXPIRATION '1s'`\r\n2. Relocate workload: Two workers relocating random ranges: `ALTER TABLE kv.kv EXPERIMENTAL_RELOCATE SELECT ARRAY[%s, %s, %s], CAST(ROUND(RANDOM() * 9223372036854775808) AS INT)`. The new set of replicas is a random subset of the available replicas of size 3.\r\n\r\nMore details can be found in this [script](https://gist.github.com/jeffrey-xiao/2af9de98a56d8921dc7efa0cf7fb5b5e).\r\n\r\n![image](https://user-images.githubusercontent.com/8853434/60835022-233be080-a190-11e9-9302-95eccc6d6acf.png)\n\nCo-authored-by: Jeffrey Xiao <jeffrey.xiao1998@gmail.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/ea7ebb9276db0a0675eb80385b6f97d4c6c48c60"}]}
{"actor":{"display_login":"craig"}}