{"action":"opened","number":375,"pull_request":{"url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/375","id":317378871,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3Mzc4ODcx","html_url":"https://github.com/QwantResearch/erdapfel/pull/375","diff_url":"https://github.com/QwantResearch/erdapfel/pull/375.diff","patch_url":"https://github.com/QwantResearch/erdapfel/pull/375.patch","issue_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues/375","number":375,"state":"open","locked":false,"title":"React: favorites panel","user":{"login":"bbecquet","id":243653,"node_id":"MDQ6VXNlcjI0MzY1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/243653?v=4","gravatar_id":"","url":"https://api.github.com/users/bbecquet","html_url":"https://github.com/bbecquet","followers_url":"https://api.github.com/users/bbecquet/followers","following_url":"https://api.github.com/users/bbecquet/following{/other_user}","gists_url":"https://api.github.com/users/bbecquet/gists{/gist_id}","starred_url":"https://api.github.com/users/bbecquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbecquet/subscriptions","organizations_url":"https://api.github.com/users/bbecquet/orgs","repos_url":"https://api.github.com/users/bbecquet/repos","events_url":"https://api.github.com/users/bbecquet/events{/privacy}","received_events_url":"https://api.github.com/users/bbecquet/received_events","type":"User","site_admin":false},"body":"*Sorry, yet another very big React PR, but once it's merged the next ones will be smaller… *\r\n\r\n## Description\r\nThis migrates the favorites panel to React, introducing in the process three new generic components that will be ready to reuse by other UI parts.\r\nI could have pushed them in separate PR, but without working code using them it would have been hard to showcase. So I splitted by commits instead. If you prefer to have smaller PR with non-called code, tell me and I'll split this one.\r\nThe three new components are:\r\n\r\n - `<Panel>` https://github.com/QwantResearch/erdapfel/commit/db5f07654a3748dc1e6d2e7ccc67c2adf6b77e68: standardizes the behavior of the app panels, with consistent style, fully responsize resizable option, close button, etc. Meant to be re-used soon by the other top-panels (Service, Category, POI, etc.).\r\n\r\n- `<ItemList>` https://github.com/QwantResearch/erdapfel/commit/2a7eb0c0dc2a75892737134a77964329e71b2fb4: standardizes the look of card lists. Will be re-used later by the category panel.\r\n\r\n- `<ContextMenu>` https://github.com/QwantResearch/erdapfel/commit/19839ec82237610f9d1d342f06463f11c18d4704: for tooltips with contextual actions. Will be re-used by \r\n![Capture d’écran de 2019-09-13 17-18-50](https://user-images.githubusercontent.com/243653/64874045-94918700-d64a-11e9-906d-5d6b05bbb395.png)\r\n\r\nOnce these components are defined, the last commit is the actual migration. The logic of connection to a store has been cleaned-up and is managed in a top stateful component (or \"container\" in React terms), `<FavoritesPanel>` https://github.com/QwantResearch/erdapfel/commit/3ba21646643c877c6f965c6996cfba7de3f0cd9e#diff-627899dfac8239539a1303ed5c328fc7. All updates are now automatic thanks to React re-rendering system, leaving the code relatively simple.\r\n\r\n## Why\r\n- Advance React migration by converting at last a first panel.\r\n- Create a set of re-usable components which will greatly facilitate the next migrations.\r\n\r\n## Screenshots\r\n\r\n![Capture d’écran de 2019-09-13 17-26-29](https://user-images.githubusercontent.com/243653/64874916-43829280-d64c-11e9-9248-25527a2115b6.png)\r\n![Capture d’écran de 2019-09-13 17-26-39](https://user-images.githubusercontent.com/243653/64874918-43829280-d64c-11e9-8bd1-59ed41f9778d.png)\r\n![Capture d’écran de 2019-09-13 17-27-57](https://user-images.githubusercontent.com/243653/64874920-43829280-d64c-11e9-82fb-a8165148f017.png)\r\n![Capture d’écran de 2019-09-13 17-28-04](https://user-images.githubusercontent.com/243653/64874923-441b2900-d64c-11e9-9a9f-f18d234cc708.png)\r\n![Capture d’écran de 2019-09-13 17-28-12](https://user-images.githubusercontent.com/243653/64874924-441b2900-d64c-11e9-9b76-95060410fea8.png)\r\n![Capture d’écran de 2019-09-13 17-28-36](https://user-images.githubusercontent.com/243653/64874925-44b3bf80-d64c-11e9-94e1-5674da626d09.png)\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2019-09-13T15:33:21Z","updated_at":"2019-09-13T15:33:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1541077224,"node_id":"MDU6TGFiZWwxNTQxMDc3MjI0","url":"https://api.github.com/repos/QwantResearch/erdapfel/labels/React","name":"React","color":"61dafb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/375/commits","review_comments_url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/375/comments","review_comment_url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues/375/comments","statuses_url":"https://api.github.com/repos/QwantResearch/erdapfel/statuses/3ba21646643c877c6f965c6996cfba7de3f0cd9e","head":{"label":"bbecquet:react-favorites-panel","ref":"react-favorites-panel","sha":"3ba21646643c877c6f965c6996cfba7de3f0cd9e","user":{"login":"bbecquet","id":243653,"node_id":"MDQ6VXNlcjI0MzY1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/243653?v=4","gravatar_id":"","url":"https://api.github.com/users/bbecquet","html_url":"https://github.com/bbecquet","followers_url":"https://api.github.com/users/bbecquet/followers","following_url":"https://api.github.com/users/bbecquet/following{/other_user}","gists_url":"https://api.github.com/users/bbecquet/gists{/gist_id}","starred_url":"https://api.github.com/users/bbecquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbecquet/subscriptions","organizations_url":"https://api.github.com/users/bbecquet/orgs","repos_url":"https://api.github.com/users/bbecquet/repos","events_url":"https://api.github.com/users/bbecquet/events{/privacy}","received_events_url":"https://api.github.com/users/bbecquet/received_events","type":"User","site_admin":false},"repo":{"id":196999140,"node_id":"MDEwOlJlcG9zaXRvcnkxOTY5OTkxNDA=","name":"erdapfel","full_name":"bbecquet/erdapfel","private":false,"owner":{"login":"bbecquet","id":243653,"node_id":"MDQ6VXNlcjI0MzY1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/243653?v=4","gravatar_id":"","url":"https://api.github.com/users/bbecquet","html_url":"https://github.com/bbecquet","followers_url":"https://api.github.com/users/bbecquet/followers","following_url":"https://api.github.com/users/bbecquet/following{/other_user}","gists_url":"https://api.github.com/users/bbecquet/gists{/gist_id}","starred_url":"https://api.github.com/users/bbecquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbecquet/subscriptions","organizations_url":"https://api.github.com/users/bbecquet/orgs","repos_url":"https://api.github.com/users/bbecquet/repos","events_url":"https://api.github.com/users/bbecquet/events{/privacy}","received_events_url":"https://api.github.com/users/bbecquet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bbecquet/erdapfel","description":"Qwant Maps front-end","fork":true,"url":"https://api.github.com/repos/bbecquet/erdapfel","forks_url":"https://api.github.com/repos/bbecquet/erdapfel/forks","keys_url":"https://api.github.com/repos/bbecquet/erdapfel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbecquet/erdapfel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbecquet/erdapfel/teams","hooks_url":"https://api.github.com/repos/bbecquet/erdapfel/hooks","issue_events_url":"https://api.github.com/repos/bbecquet/erdapfel/issues/events{/number}","events_url":"https://api.github.com/repos/bbecquet/erdapfel/events","assignees_url":"https://api.github.com/repos/bbecquet/erdapfel/assignees{/user}","branches_url":"https://api.github.com/repos/bbecquet/erdapfel/branches{/branch}","tags_url":"https://api.github.com/repos/bbecquet/erdapfel/tags","blobs_url":"https://api.github.com/repos/bbecquet/erdapfel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbecquet/erdapfel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbecquet/erdapfel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbecquet/erdapfel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbecquet/erdapfel/statuses/{sha}","languages_url":"https://api.github.com/repos/bbecquet/erdapfel/languages","stargazers_url":"https://api.github.com/repos/bbecquet/erdapfel/stargazers","contributors_url":"https://api.github.com/repos/bbecquet/erdapfel/contributors","subscribers_url":"https://api.github.com/repos/bbecquet/erdapfel/subscribers","subscription_url":"https://api.github.com/repos/bbecquet/erdapfel/subscription","commits_url":"https://api.github.com/repos/bbecquet/erdapfel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbecquet/erdapfel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbecquet/erdapfel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbecquet/erdapfel/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbecquet/erdapfel/contents/{+path}","compare_url":"https://api.github.com/repos/bbecquet/erdapfel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbecquet/erdapfel/merges","archive_url":"https://api.github.com/repos/bbecquet/erdapfel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbecquet/erdapfel/downloads","issues_url":"https://api.github.com/repos/bbecquet/erdapfel/issues{/number}","pulls_url":"https://api.github.com/repos/bbecquet/erdapfel/pulls{/number}","milestones_url":"https://api.github.com/repos/bbecquet/erdapfel/milestones{/number}","notifications_url":"https://api.github.com/repos/bbecquet/erdapfel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbecquet/erdapfel/labels{/name}","releases_url":"https://api.github.com/repos/bbecquet/erdapfel/releases{/id}","deployments_url":"https://api.github.com/repos/bbecquet/erdapfel/deployments","created_at":"2019-07-15T12:58:04Z","updated_at":"2019-07-15T12:58:07Z","pushed_at":"2019-09-13T15:29:50Z","git_url":"git://github.com/bbecquet/erdapfel.git","ssh_url":"git@github.com:bbecquet/erdapfel.git","clone_url":"https://github.com/bbecquet/erdapfel.git","svn_url":"https://github.com/bbecquet/erdapfel","homepage":"https://www.qwant.com/maps/","size":8255,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QwantResearch:master","ref":"master","sha":"bdcac090478d485e2c83819f5f3b822820f44c0c","user":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"repo":{"id":140295292,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyOTUyOTI=","name":"erdapfel","full_name":"QwantResearch/erdapfel","private":false,"owner":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QwantResearch/erdapfel","description":"Qwant Maps front-end","fork":false,"url":"https://api.github.com/repos/QwantResearch/erdapfel","forks_url":"https://api.github.com/repos/QwantResearch/erdapfel/forks","keys_url":"https://api.github.com/repos/QwantResearch/erdapfel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QwantResearch/erdapfel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QwantResearch/erdapfel/teams","hooks_url":"https://api.github.com/repos/QwantResearch/erdapfel/hooks","issue_events_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues/events{/number}","events_url":"https://api.github.com/repos/QwantResearch/erdapfel/events","assignees_url":"https://api.github.com/repos/QwantResearch/erdapfel/assignees{/user}","branches_url":"https://api.github.com/repos/QwantResearch/erdapfel/branches{/branch}","tags_url":"https://api.github.com/repos/QwantResearch/erdapfel/tags","blobs_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/refs{/sha}","trees_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QwantResearch/erdapfel/statuses/{sha}","languages_url":"https://api.github.com/repos/QwantResearch/erdapfel/languages","stargazers_url":"https://api.github.com/repos/QwantResearch/erdapfel/stargazers","contributors_url":"https://api.github.com/repos/QwantResearch/erdapfel/contributors","subscribers_url":"https://api.github.com/repos/QwantResearch/erdapfel/subscribers","subscription_url":"https://api.github.com/repos/QwantResearch/erdapfel/subscription","commits_url":"https://api.github.com/repos/QwantResearch/erdapfel/commits{/sha}","git_commits_url":"https://api.github.com/repos/QwantResearch/erdapfel/git/commits{/sha}","comments_url":"https://api.github.com/repos/QwantResearch/erdapfel/comments{/number}","issue_comment_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues/comments{/number}","contents_url":"https://api.github.com/repos/QwantResearch/erdapfel/contents/{+path}","compare_url":"https://api.github.com/repos/QwantResearch/erdapfel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QwantResearch/erdapfel/merges","archive_url":"https://api.github.com/repos/QwantResearch/erdapfel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QwantResearch/erdapfel/downloads","issues_url":"https://api.github.com/repos/QwantResearch/erdapfel/issues{/number}","pulls_url":"https://api.github.com/repos/QwantResearch/erdapfel/pulls{/number}","milestones_url":"https://api.github.com/repos/QwantResearch/erdapfel/milestones{/number}","notifications_url":"https://api.github.com/repos/QwantResearch/erdapfel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QwantResearch/erdapfel/labels{/name}","releases_url":"https://api.github.com/repos/QwantResearch/erdapfel/releases{/id}","deployments_url":"https://api.github.com/repos/QwantResearch/erdapfel/deployments","created_at":"2018-07-09T14:12:57Z","updated_at":"2019-09-13T13:26:43Z","pushed_at":"2019-09-13T13:26:41Z","git_url":"git://github.com/QwantResearch/erdapfel.git","ssh_url":"git@github.com:QwantResearch/erdapfel.git","clone_url":"https://github.com/QwantResearch/erdapfel.git","svn_url":"https://github.com/QwantResearch/erdapfel","homepage":"https://www.qwant.com/maps/","size":8110,"stargazers_count":48,"watchers_count":48,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":7,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/375"},"html":{"href":"https://github.com/QwantResearch/erdapfel/pull/375"},"issue":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/issues/375"},"comments":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/QwantResearch/erdapfel/statuses/3ba21646643c877c6f965c6996cfba7de3f0cd9e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":666,"deletions":422,"changed_files":21}}
{"actor":{"display_login":"bbecquet"}}