{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/16852","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/16852/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/16852/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/16852/events","html_url":"https://github.com/bitcoin/bitcoin/pull/16852","id":492070489,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2MzE0NjM1","number":16852,"title":"gui: When BIP70 is disabled, get PaymentRequest merchant using string search","user":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"labels":[{"id":135946,"node_id":"MDU6TGFiZWwxMzU5NDY=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/GUI","name":"GUI","color":"02d7e1","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/37","html_url":"https://github.com/bitcoin/bitcoin/milestone/37","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/37/labels","id":3391434,"node_id":"MDk6TWlsZXN0b25lMzM5MTQzNA==","number":37,"title":"0.19.0","description":"","creator":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":156,"state":"closed","created_at":"2018-05-31T19:40:07Z","updated_at":"2019-11-10T11:39:07Z","due_on":null,"closed_at":"2019-11-10T11:39:07Z"},"comments":15,"created_at":"2019-09-11T07:41:52Z","updated_at":"2019-11-14T19:27:43Z","closed_at":"2019-10-01T09:54:47Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/16852","html_url":"https://github.com/bitcoin/bitcoin/pull/16852","diff_url":"https://github.com/bitcoin/bitcoin/pull/16852.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/16852.patch"},"body":"The merchant name is stored in the X.509 certificate embedded in a PaymentRequest. Use some string searching to locate it so that it can be shown to the user in the transaction details when BIP70 support was not configured.\r\n\r\nAn additional notice is added to the merchant string that indicates the certificate was not verified. When BIP70 is enabled, the certificate would be verified and the merchant name not shown if the certificate was invalid."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/554041684","html_url":"https://github.com/bitcoin/bitcoin/pull/16852#issuecomment-554041684","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/16852","id":554041684,"node_id":"MDEyOklzc3VlQ29tbWVudDU1NDA0MTY4NA==","user":{"login":"dooglus","id":573356,"node_id":"MDQ6VXNlcjU3MzM1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/573356?v=4","gravatar_id":"","url":"https://api.github.com/users/dooglus","html_url":"https://github.com/dooglus","followers_url":"https://api.github.com/users/dooglus/followers","following_url":"https://api.github.com/users/dooglus/following{/other_user}","gists_url":"https://api.github.com/users/dooglus/gists{/gist_id}","starred_url":"https://api.github.com/users/dooglus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooglus/subscriptions","organizations_url":"https://api.github.com/users/dooglus/orgs","repos_url":"https://api.github.com/users/dooglus/repos","events_url":"https://api.github.com/users/dooglus/events{/privacy}","received_events_url":"https://api.github.com/users/dooglus/received_events","type":"User","site_admin":false},"created_at":"2019-11-14T19:27:43Z","updated_at":"2019-11-14T19:27:43Z","author_association":"CONTRIBUTOR","body":"I have a couple of payments to bitpay in my wallet. In Bitcoin Core 0.18.1 the merchant information wasn't displayed at all for either of them. When I viewed the transaction details I would see this in the debug.log:\r\n\r\n    PaymentRequestPlus::getMerchant: Payment request: certificate expired or not yet active\r\n\r\nThe certificate was valid from 2017-03-23 18:22:00.000 UTC to 2019-04-25 19:11:00.000 UTC, and so could no longer be validated, and as a result Core wasn't showing any \"Merchant:\" information at all.\r\n\r\nIn Bitcoin Core 0.19 I see:\r\n\r\n    Merchant: bitpay.com (Certificate was not verified)\r\n\r\nwhich is infinitely better."}}
{"actor":{"display_login":"dooglus"}}