{"push_id":4169431148,"size":3,"distinct_size":0,"ref":"refs/heads/master","head":"8f9fd02118d1d12f3de06a204327794fea05c7c5","before":"fb8e58c062970c0e49c21b16b2be0af83ca7ee54","commits":[{"sha":"3234daba3f6d7ea9c0c5947fd27bfd2f4721f5cf","author":{"name":"Peter Mattis","email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com"},"message":"storage/engine: add a handful of Pebble benchmarks\n\nChanged `runMVCCGarbageCollect` to write to a batch and not commit the\nbatch. This removes batch commit from the measurement of the benchmark\nand allows us to focus on the performance of `MVCCGarbageCollect`\nitself.\n\nRocksDB (old) vs Pebble (new):\n\nname                                                                         old time/op    new time/op    delta\nMVCCComputeStats/valueSize=8-16                                                 158ms ± 1%     136ms ± 4%  -13.60%  (p=0.000 n=10+10)\nMVCCComputeStats/valueSize=32-16                                                112ms ± 1%      97ms ± 4%  -13.61%  (p=0.000 n=9+10)\nMVCCComputeStats/valueSize=256-16                                              45.5ms ± 4%    36.2ms ±14%  -20.44%  (p=0.000 n=10+10)\nMVCCFindSplitKey/valueSize=32-16                                               81.1ms ± 3%    78.9ms ± 2%   -2.73%  (p=0.000 n=10+9)\nMVCCGarbageCollect/keySize=128/valSize=128/numKeys=1/numVersions=2-16          4.07µs ± 1%    1.29µs ± 5%  -68.45%  (p=0.000 n=9+10)\nMVCCGarbageCollect/keySize=128/valSize=128/numKeys=1/numVersions=1024-16        278µs ± 4%     124µs ± 4%  -55.42%  (p=0.000 n=10+10)\nMVCCGarbageCollect/keySize=128/valSize=128/numKeys=1024/numVersions=2-16       1.67ms ± 2%    0.84ms ± 7%  -49.90%  (p=0.000 n=9+10)\nMVCCGarbageCollect/keySize=128/valSize=128/numKeys=1024/numVersions=1024-16     343ms ± 2%     170ms ± 6%  -50.33%  (p=0.000 n=10+9)\n\nname                                                                         old speed      new speed      delta\nMVCCComputeStats/valueSize=8-16                                               425MB/s ± 1%   492MB/s ± 4%  +15.77%  (p=0.000 n=10+10)\nMVCCComputeStats/valueSize=32-16                                              598MB/s ± 1%   692MB/s ± 4%  +15.80%  (p=0.000 n=9+10)\nMVCCComputeStats/valueSize=256-16                                            1.48GB/s ± 4%  1.87GB/s ±15%  +26.64%  (p=0.000 n=10+10)\nMVCCFindSplitKey/valueSize=32-16                                              827MB/s ± 3%   850MB/s ± 2%   +2.80%  (p=0.000 n=10+9)\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/3234daba3f6d7ea9c0c5947fd27bfd2f4721f5cf"},{"sha":"67dbac68880c62fc6af98756d583192c5cd2142e","author":{"name":"Peter Mattis","email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com"},"message":"storage/engine: allow reading from a distinct write-only pebble batch\n\nAllow reading from a distinct write-only pebble batch. Our RocksDB code\nallows this. This is now being used in by the MVCCGarbageCollect\nbenchmark.\n\nTook the opportunity to sprinkle some missing `p.distinctOpen` checks.\n\nFixes #41594\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/67dbac68880c62fc6af98756d583192c5cd2142e"},{"sha":"8f9fd02118d1d12f3de06a204327794fea05c7c5","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #41674\n\n41674: storage/engine: add Pebble benchmarks for ComputeStats and FindSplitKey r=itsbilal a=petermattis\n\nRocksDB (old) vs Pebble (new):\n\n```\nname                               old time/op    new time/op    delta\nMVCCComputeStats/valueSize=8-16       183ms ± 1%     176ms ± 2%   -4.11%  (p=0.000 n=10+10)\nMVCCComputeStats/valueSize=32-16      124ms ± 5%     107ms ± 2%  -13.95%  (p=0.000 n=10+9)\nMVCCComputeStats/valueSize=256-16    58.4ms ± 3%    49.4ms ± 6%  -15.44%  (p=0.000 n=10+9)\nMVCCFindSplitKey/valueSize=32-16     88.0ms ± 2%    81.8ms ± 1%   -7.06%  (p=0.000 n=10+10)\n\nname                               old speed      new speed      delta\nMVCCComputeStats/valueSize=8-16     366MB/s ± 1%   382MB/s ± 2%   +4.29%  (p=0.000 n=10+10)\nMVCCComputeStats/valueSize=32-16    539MB/s ± 4%   627MB/s ± 2%  +16.18%  (p=0.000 n=10+9)\nMVCCComputeStats/valueSize=256-16  1.15GB/s ± 2%  1.36GB/s ± 5%  +18.31%  (p=0.000 n=10+9)\nMVCCFindSplitKey/valueSize=32-16    763MB/s ± 2%   821MB/s ± 1%   +7.60%  (p=0.000 n=10+10)\n```\n\nRelease note: None\n\nCo-authored-by: Peter Mattis <petermattis@gmail.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/8f9fd02118d1d12f3de06a204327794fea05c7c5"}]}
{"actor":{"display_login":"craig"}}