{"action":"created","comment":{"url":"https://api.github.com/repos/nteract/papermill/pulls/comments/275902717","pull_request_review_id":227329326,"id":275902717,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTkwMjcxNw==","diff_hunk":"@@ -72,3 +72,52 @@ def test_repeated_run_no_parameters_tag(self):\n \n         test_nb = parameterize_notebook(test_nb, {'msg': 'Hello'})\n         self.assertEqual(self.count_nb_injected_parameter_cells(test_nb), 1)\n+\n+\n+class TestPathParameterizing(unittest.TestCase):\n+    def test_plain_text_path_with_empty_parameters_object(self):\n+        self.assertEqual(parameterize_path(\"foo/bar\", {}), \"foo/bar\")\n+\n+    def test_plain_text_path_with_none_parameters(self):\n+        self.assertEqual(parameterize_path(\"foo/bar\", None), \"foo/bar\")\n+\n+    def test_plain_text_path_with_unused_parameters(self):\n+        self.assertEqual(parameterize_path(\"foo/bar\", {\"baz\": \"quux\"}), \"foo/bar\")\n+\n+    def test_path_with_single_parameter(self):\n+        self.assertEqual(parameterize_path(\"foo/bar/{baz}\", {\"baz\": \"quux\"}), \"foo/bar/quux\")\n+\n+    def test_path_with_boolean_parameter(self):\n+        self.assertEqual(parameterize_path(\"foo/bar/{baz}\", {\"baz\": False}), \"foo/bar/False\")\n+\n+    def test_path_with_none_parameter(self):\n+        self.assertEqual(parameterize_path(\"foo/bar/{baz}\", {\"baz\": None}), \"foo/bar/None\")\n+\n+    def test_path_with_numeric_parameter(self):\n+        self.assertEqual(parameterize_path(\"foo/bar/{baz}\", {\"baz\": 42}), \"foo/bar/42\")\n+\n+    def test_path_with_numeric_format_string(self):\n+        self.assertEqual(parameterize_path(\"foo/bar/{baz:03d}\", {\"baz\": 42}), \"foo/bar/042\")\n+\n+    def test_path_with_float_format_string(self):\n+        self.assertEqual(parameterize_path(\"foo/bar/{baz:.03f}\", {\"baz\": 0.3}), \"foo/bar/0.300\")\n+","path":"papermill/tests/test_parameterize.py","position":42,"original_position":42,"commit_id":"40c9a58815e30a57a8b2829b924c1d29fb869857","original_commit_id":"40c9a58815e30a57a8b2829b924c1d29fb869857","user":{"login":"MSeal","id":1863892,"node_id":"MDQ6VXNlcjE4NjM4OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1863892?v=4","gravatar_id":"","url":"https://api.github.com/users/MSeal","html_url":"https://github.com/MSeal","followers_url":"https://api.github.com/users/MSeal/followers","following_url":"https://api.github.com/users/MSeal/following{/other_user}","gists_url":"https://api.github.com/users/MSeal/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeal/subscriptions","organizations_url":"https://api.github.com/users/MSeal/orgs","repos_url":"https://api.github.com/users/MSeal/repos","events_url":"https://api.github.com/users/MSeal/events{/privacy}","received_events_url":"https://api.github.com/users/MSeal/received_events","type":"User","site_admin":false},"body":"We should maybe test list and dict inputs, since those are common parameter types.","created_at":"2019-04-16T17:08:36Z","updated_at":"2019-04-16T17:08:36Z","html_url":"https://github.com/nteract/papermill/pull/343#discussion_r275902717","pull_request_url":"https://api.github.com/repos/nteract/papermill/pulls/343","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nteract/papermill/pulls/comments/275902717"},"html":{"href":"https://github.com/nteract/papermill/pull/343#discussion_r275902717"},"pull_request":{"href":"https://api.github.com/repos/nteract/papermill/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/nteract/papermill/pulls/343","id":270627867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNjI3ODY3","html_url":"https://github.com/nteract/papermill/pull/343","diff_url":"https://github.com/nteract/papermill/pull/343.diff","patch_url":"https://github.com/nteract/papermill/pull/343.patch","issue_url":"https://api.github.com/repos/nteract/papermill/issues/343","number":343,"state":"open","locked":false,"title":"[WIP] Add path interpolation using parameters and special keys","user":{"login":"VincentBLortie","id":1178934,"node_id":"MDQ6VXNlcjExNzg5MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1178934?v=4","gravatar_id":"","url":"https://api.github.com/users/VincentBLortie","html_url":"https://github.com/VincentBLortie","followers_url":"https://api.github.com/users/VincentBLortie/followers","following_url":"https://api.github.com/users/VincentBLortie/following{/other_user}","gists_url":"https://api.github.com/users/VincentBLortie/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentBLortie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentBLortie/subscriptions","organizations_url":"https://api.github.com/users/VincentBLortie/orgs","repos_url":"https://api.github.com/users/VincentBLortie/repos","events_url":"https://api.github.com/users/VincentBLortie/events{/privacy}","received_events_url":"https://api.github.com/users/VincentBLortie/received_events","type":"User","site_admin":false},"body":"Work in progress for nteract/papermill#300","created_at":"2019-04-15T18:37:37Z","updated_at":"2019-04-16T17:08:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"952035aa467cb0081d16f60438b49eefe76a3d83","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nteract/papermill/pulls/343/commits","review_comments_url":"https://api.github.com/repos/nteract/papermill/pulls/343/comments","review_comment_url":"https://api.github.com/repos/nteract/papermill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nteract/papermill/issues/343/comments","statuses_url":"https://api.github.com/repos/nteract/papermill/statuses/40c9a58815e30a57a8b2829b924c1d29fb869857","head":{"label":"VincentBLortie:parameterized_paths","ref":"parameterized_paths","sha":"40c9a58815e30a57a8b2829b924c1d29fb869857","user":{"login":"VincentBLortie","id":1178934,"node_id":"MDQ6VXNlcjExNzg5MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1178934?v=4","gravatar_id":"","url":"https://api.github.com/users/VincentBLortie","html_url":"https://github.com/VincentBLortie","followers_url":"https://api.github.com/users/VincentBLortie/followers","following_url":"https://api.github.com/users/VincentBLortie/following{/other_user}","gists_url":"https://api.github.com/users/VincentBLortie/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentBLortie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentBLortie/subscriptions","organizations_url":"https://api.github.com/users/VincentBLortie/orgs","repos_url":"https://api.github.com/users/VincentBLortie/repos","events_url":"https://api.github.com/users/VincentBLortie/events{/privacy}","received_events_url":"https://api.github.com/users/VincentBLortie/received_events","type":"User","site_admin":false},"repo":{"id":146315700,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzMTU3MDA=","name":"papermill","full_name":"VincentBLortie/papermill","private":false,"owner":{"login":"VincentBLortie","id":1178934,"node_id":"MDQ6VXNlcjExNzg5MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1178934?v=4","gravatar_id":"","url":"https://api.github.com/users/VincentBLortie","html_url":"https://github.com/VincentBLortie","followers_url":"https://api.github.com/users/VincentBLortie/followers","following_url":"https://api.github.com/users/VincentBLortie/following{/other_user}","gists_url":"https://api.github.com/users/VincentBLortie/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentBLortie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentBLortie/subscriptions","organizations_url":"https://api.github.com/users/VincentBLortie/orgs","repos_url":"https://api.github.com/users/VincentBLortie/repos","events_url":"https://api.github.com/users/VincentBLortie/events{/privacy}","received_events_url":"https://api.github.com/users/VincentBLortie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VincentBLortie/papermill","description":"📚 Parameterize, execute, and analyze notebooks","fork":true,"url":"https://api.github.com/repos/VincentBLortie/papermill","forks_url":"https://api.github.com/repos/VincentBLortie/papermill/forks","keys_url":"https://api.github.com/repos/VincentBLortie/papermill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VincentBLortie/papermill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VincentBLortie/papermill/teams","hooks_url":"https://api.github.com/repos/VincentBLortie/papermill/hooks","issue_events_url":"https://api.github.com/repos/VincentBLortie/papermill/issues/events{/number}","events_url":"https://api.github.com/repos/VincentBLortie/papermill/events","assignees_url":"https://api.github.com/repos/VincentBLortie/papermill/assignees{/user}","branches_url":"https://api.github.com/repos/VincentBLortie/papermill/branches{/branch}","tags_url":"https://api.github.com/repos/VincentBLortie/papermill/tags","blobs_url":"https://api.github.com/repos/VincentBLortie/papermill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VincentBLortie/papermill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VincentBLortie/papermill/git/refs{/sha}","trees_url":"https://api.github.com/repos/VincentBLortie/papermill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VincentBLortie/papermill/statuses/{sha}","languages_url":"https://api.github.com/repos/VincentBLortie/papermill/languages","stargazers_url":"https://api.github.com/repos/VincentBLortie/papermill/stargazers","contributors_url":"https://api.github.com/repos/VincentBLortie/papermill/contributors","subscribers_url":"https://api.github.com/repos/VincentBLortie/papermill/subscribers","subscription_url":"https://api.github.com/repos/VincentBLortie/papermill/subscription","commits_url":"https://api.github.com/repos/VincentBLortie/papermill/commits{/sha}","git_commits_url":"https://api.github.com/repos/VincentBLortie/papermill/git/commits{/sha}","comments_url":"https://api.github.com/repos/VincentBLortie/papermill/comments{/number}","issue_comment_url":"https://api.github.com/repos/VincentBLortie/papermill/issues/comments{/number}","contents_url":"https://api.github.com/repos/VincentBLortie/papermill/contents/{+path}","compare_url":"https://api.github.com/repos/VincentBLortie/papermill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VincentBLortie/papermill/merges","archive_url":"https://api.github.com/repos/VincentBLortie/papermill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VincentBLortie/papermill/downloads","issues_url":"https://api.github.com/repos/VincentBLortie/papermill/issues{/number}","pulls_url":"https://api.github.com/repos/VincentBLortie/papermill/pulls{/number}","milestones_url":"https://api.github.com/repos/VincentBLortie/papermill/milestones{/number}","notifications_url":"https://api.github.com/repos/VincentBLortie/papermill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VincentBLortie/papermill/labels{/name}","releases_url":"https://api.github.com/repos/VincentBLortie/papermill/releases{/id}","deployments_url":"https://api.github.com/repos/VincentBLortie/papermill/deployments","created_at":"2018-08-27T15:16:41Z","updated_at":"2019-04-15T17:24:29Z","pushed_at":"2019-04-15T18:35:57Z","git_url":"git://github.com/VincentBLortie/papermill.git","ssh_url":"git@github.com:VincentBLortie/papermill.git","clone_url":"https://github.com/VincentBLortie/papermill.git","svn_url":"https://github.com/VincentBLortie/papermill","homepage":"http://papermill.readthedocs.io/en/latest/","size":1464,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nteract:master","ref":"master","sha":"7a354655068c358698697308ee34c1f14867222b","user":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"repo":{"id":96454557,"node_id":"MDEwOlJlcG9zaXRvcnk5NjQ1NDU1Nw==","name":"papermill","full_name":"nteract/papermill","private":false,"owner":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nteract/papermill","description":"📚 Parameterize, execute, and analyze notebooks","fork":false,"url":"https://api.github.com/repos/nteract/papermill","forks_url":"https://api.github.com/repos/nteract/papermill/forks","keys_url":"https://api.github.com/repos/nteract/papermill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nteract/papermill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nteract/papermill/teams","hooks_url":"https://api.github.com/repos/nteract/papermill/hooks","issue_events_url":"https://api.github.com/repos/nteract/papermill/issues/events{/number}","events_url":"https://api.github.com/repos/nteract/papermill/events","assignees_url":"https://api.github.com/repos/nteract/papermill/assignees{/user}","branches_url":"https://api.github.com/repos/nteract/papermill/branches{/branch}","tags_url":"https://api.github.com/repos/nteract/papermill/tags","blobs_url":"https://api.github.com/repos/nteract/papermill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nteract/papermill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nteract/papermill/git/refs{/sha}","trees_url":"https://api.github.com/repos/nteract/papermill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nteract/papermill/statuses/{sha}","languages_url":"https://api.github.com/repos/nteract/papermill/languages","stargazers_url":"https://api.github.com/repos/nteract/papermill/stargazers","contributors_url":"https://api.github.com/repos/nteract/papermill/contributors","subscribers_url":"https://api.github.com/repos/nteract/papermill/subscribers","subscription_url":"https://api.github.com/repos/nteract/papermill/subscription","commits_url":"https://api.github.com/repos/nteract/papermill/commits{/sha}","git_commits_url":"https://api.github.com/repos/nteract/papermill/git/commits{/sha}","comments_url":"https://api.github.com/repos/nteract/papermill/comments{/number}","issue_comment_url":"https://api.github.com/repos/nteract/papermill/issues/comments{/number}","contents_url":"https://api.github.com/repos/nteract/papermill/contents/{+path}","compare_url":"https://api.github.com/repos/nteract/papermill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nteract/papermill/merges","archive_url":"https://api.github.com/repos/nteract/papermill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nteract/papermill/downloads","issues_url":"https://api.github.com/repos/nteract/papermill/issues{/number}","pulls_url":"https://api.github.com/repos/nteract/papermill/pulls{/number}","milestones_url":"https://api.github.com/repos/nteract/papermill/milestones{/number}","notifications_url":"https://api.github.com/repos/nteract/papermill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nteract/papermill/labels{/name}","releases_url":"https://api.github.com/repos/nteract/papermill/releases{/id}","deployments_url":"https://api.github.com/repos/nteract/papermill/deployments","created_at":"2017-07-06T17:17:53Z","updated_at":"2019-04-16T17:03:54Z","pushed_at":"2019-04-15T18:37:38Z","git_url":"git://github.com/nteract/papermill.git","ssh_url":"git@github.com:nteract/papermill.git","clone_url":"https://github.com/nteract/papermill.git","svn_url":"https://github.com/nteract/papermill","homepage":"http://papermill.readthedocs.io/en/latest/","size":1464,"stargazers_count":1697,"watchers_count":1697,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":54,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":121,"open_issues":54,"watchers":1697,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nteract/papermill/pulls/343"},"html":{"href":"https://github.com/nteract/papermill/pull/343"},"issue":{"href":"https://api.github.com/repos/nteract/papermill/issues/343"},"comments":{"href":"https://api.github.com/repos/nteract/papermill/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/nteract/papermill/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/nteract/papermill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nteract/papermill/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/nteract/papermill/statuses/40c9a58815e30a57a8b2829b924c1d29fb869857"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MSeal"}}