{"action":"created","comment":{"url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/comments/268867096","pull_request_review_id":218603754,"id":268867096,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODg2NzA5Ng==","diff_hunk":"@@ -3,5 +3,17 @@\n public class CmdConsOut{\n   public int exitCode;\n   public String consoleOut;\n+  public String consoleErr;\n   public String cmd;\n+\n+\n+  @Override\n+  public String toString() {\n+    return \"\\\"CmdConsOut\\\":{\\n\" +\n+            \"\\t\\\"cmd\\\":\\\"\" + (cmd != null ? cmd : \"\") + \"\\\",\\n\" +\n+            \"\\t\\\"exitCode\\\":\" + exitCode + \",\\n\" +\n+            \"\\t\\\"consoleOut\\\":\\\"\" + (consoleOut != null ? consoleOut : \"\") + \"\\\",\\n\" +\n+            \"\\t\\\"consoleErr\\\":\\\"\" + (consoleErr != null ? consoleErr : \"\") + \"\\\"\\n\" +\n+            \"}\\n\";\n+  }\n }","path":"framework/src/main/java/org/apache/drill/test/framework/CmdConsOut.java","position":17,"original_position":17,"commit_id":"bdb5977dd39cb6c4768a0afbbccaa8fa43788bf8","original_commit_id":"6251f6bfb4d879bf6dec1708b2c82d42494925d3","user":{"login":"aravi5","id":9062901,"node_id":"MDQ6VXNlcjkwNjI5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9062901?v=4","gravatar_id":"","url":"https://api.github.com/users/aravi5","html_url":"https://github.com/aravi5","followers_url":"https://api.github.com/users/aravi5/followers","following_url":"https://api.github.com/users/aravi5/following{/other_user}","gists_url":"https://api.github.com/users/aravi5/gists{/gist_id}","starred_url":"https://api.github.com/users/aravi5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravi5/subscriptions","organizations_url":"https://api.github.com/users/aravi5/orgs","repos_url":"https://api.github.com/users/aravi5/repos","events_url":"https://api.github.com/users/aravi5/events{/privacy}","received_events_url":"https://api.github.com/users/aravi5/received_events","type":"User","site_admin":false},"body":"I am okay with no space.","created_at":"2019-03-25T21:50:46Z","updated_at":"2019-03-25T21:50:46Z","html_url":"https://github.com/mapr/drill-test-framework/pull/563#discussion_r268867096","pull_request_url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/563","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/comments/268867096"},"html":{"href":"https://github.com/mapr/drill-test-framework/pull/563#discussion_r268867096"},"pull_request":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/563"}},"in_reply_to_id":268791408},"pull_request":{"url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/563","id":262573662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyNTczNjYy","html_url":"https://github.com/mapr/drill-test-framework/pull/563","diff_url":"https://github.com/mapr/drill-test-framework/pull/563.diff","patch_url":"https://github.com/mapr/drill-test-framework/pull/563.patch","issue_url":"https://api.github.com/repos/mapr/drill-test-framework/issues/563","number":563,"state":"open","locked":false,"title":"ISSUE-561 / ISSUE-562 : Remove custom logs in CmdConsOut, Add consoleErr for error logs","user":{"login":"aravi5","id":9062901,"node_id":"MDQ6VXNlcjkwNjI5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9062901?v=4","gravatar_id":"","url":"https://api.github.com/users/aravi5","html_url":"https://github.com/aravi5","followers_url":"https://api.github.com/users/aravi5/followers","following_url":"https://api.github.com/users/aravi5/following{/other_user}","gists_url":"https://api.github.com/users/aravi5/gists{/gist_id}","starred_url":"https://api.github.com/users/aravi5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravi5/subscriptions","organizations_url":"https://api.github.com/users/aravi5/orgs","repos_url":"https://api.github.com/users/aravi5/repos","events_url":"https://api.github.com/users/aravi5/events{/privacy}","received_events_url":"https://api.github.com/users/aravi5/received_events","type":"User","site_admin":false},"body":"- The framework currently adds ```standard output``` or ```standard error``` text to the output returned from running the shell commands. This adds complexity when modules have to parse the output. https://github.com/mapr/drill-test-framework/issues/561\r\n\r\n- The PR also resolves https://github.com/mapr/drill-test-framework/issues/562. Created a field  `consoleErr` in `CmdConsOut`. This helps separate output logs from error logs.","created_at":"2019-03-19T18:11:56Z","updated_at":"2019-03-25T21:50:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c12b8444d92742855cd80ecda8d603b385da76b1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kkhatua","id":4335237,"node_id":"MDQ6VXNlcjQzMzUyMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4335237?v=4","gravatar_id":"","url":"https://api.github.com/users/kkhatua","html_url":"https://github.com/kkhatua","followers_url":"https://api.github.com/users/kkhatua/followers","following_url":"https://api.github.com/users/kkhatua/following{/other_user}","gists_url":"https://api.github.com/users/kkhatua/gists{/gist_id}","starred_url":"https://api.github.com/users/kkhatua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkhatua/subscriptions","organizations_url":"https://api.github.com/users/kkhatua/orgs","repos_url":"https://api.github.com/users/kkhatua/repos","events_url":"https://api.github.com/users/kkhatua/events{/privacy}","received_events_url":"https://api.github.com/users/kkhatua/received_events","type":"User","site_admin":false},{"login":"rhou1","id":18729344,"node_id":"MDQ6VXNlcjE4NzI5MzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/18729344?v=4","gravatar_id":"","url":"https://api.github.com/users/rhou1","html_url":"https://github.com/rhou1","followers_url":"https://api.github.com/users/rhou1/followers","following_url":"https://api.github.com/users/rhou1/following{/other_user}","gists_url":"https://api.github.com/users/rhou1/gists{/gist_id}","starred_url":"https://api.github.com/users/rhou1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhou1/subscriptions","organizations_url":"https://api.github.com/users/rhou1/orgs","repos_url":"https://api.github.com/users/rhou1/repos","events_url":"https://api.github.com/users/rhou1/events{/privacy}","received_events_url":"https://api.github.com/users/rhou1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/563/commits","review_comments_url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/563/comments","review_comment_url":"https://api.github.com/repos/mapr/drill-test-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapr/drill-test-framework/issues/563/comments","statuses_url":"https://api.github.com/repos/mapr/drill-test-framework/statuses/bdb5977dd39cb6c4768a0afbbccaa8fa43788bf8","head":{"label":"aravi5:ISSUE-561","ref":"ISSUE-561","sha":"bdb5977dd39cb6c4768a0afbbccaa8fa43788bf8","user":{"login":"aravi5","id":9062901,"node_id":"MDQ6VXNlcjkwNjI5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9062901?v=4","gravatar_id":"","url":"https://api.github.com/users/aravi5","html_url":"https://github.com/aravi5","followers_url":"https://api.github.com/users/aravi5/followers","following_url":"https://api.github.com/users/aravi5/following{/other_user}","gists_url":"https://api.github.com/users/aravi5/gists{/gist_id}","starred_url":"https://api.github.com/users/aravi5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravi5/subscriptions","organizations_url":"https://api.github.com/users/aravi5/orgs","repos_url":"https://api.github.com/users/aravi5/repos","events_url":"https://api.github.com/users/aravi5/events{/privacy}","received_events_url":"https://api.github.com/users/aravi5/received_events","type":"User","site_admin":false},"repo":{"id":151521997,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1MjE5OTc=","name":"drill-test-framework","full_name":"aravi5/drill-test-framework","private":false,"owner":{"login":"aravi5","id":9062901,"node_id":"MDQ6VXNlcjkwNjI5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9062901?v=4","gravatar_id":"","url":"https://api.github.com/users/aravi5","html_url":"https://github.com/aravi5","followers_url":"https://api.github.com/users/aravi5/followers","following_url":"https://api.github.com/users/aravi5/following{/other_user}","gists_url":"https://api.github.com/users/aravi5/gists{/gist_id}","starred_url":"https://api.github.com/users/aravi5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravi5/subscriptions","organizations_url":"https://api.github.com/users/aravi5/orgs","repos_url":"https://api.github.com/users/aravi5/repos","events_url":"https://api.github.com/users/aravi5/events{/privacy}","received_events_url":"https://api.github.com/users/aravi5/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aravi5/drill-test-framework","description":"Test Framework for Apache Drill","fork":true,"url":"https://api.github.com/repos/aravi5/drill-test-framework","forks_url":"https://api.github.com/repos/aravi5/drill-test-framework/forks","keys_url":"https://api.github.com/repos/aravi5/drill-test-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aravi5/drill-test-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aravi5/drill-test-framework/teams","hooks_url":"https://api.github.com/repos/aravi5/drill-test-framework/hooks","issue_events_url":"https://api.github.com/repos/aravi5/drill-test-framework/issues/events{/number}","events_url":"https://api.github.com/repos/aravi5/drill-test-framework/events","assignees_url":"https://api.github.com/repos/aravi5/drill-test-framework/assignees{/user}","branches_url":"https://api.github.com/repos/aravi5/drill-test-framework/branches{/branch}","tags_url":"https://api.github.com/repos/aravi5/drill-test-framework/tags","blobs_url":"https://api.github.com/repos/aravi5/drill-test-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aravi5/drill-test-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aravi5/drill-test-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/aravi5/drill-test-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aravi5/drill-test-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/aravi5/drill-test-framework/languages","stargazers_url":"https://api.github.com/repos/aravi5/drill-test-framework/stargazers","contributors_url":"https://api.github.com/repos/aravi5/drill-test-framework/contributors","subscribers_url":"https://api.github.com/repos/aravi5/drill-test-framework/subscribers","subscription_url":"https://api.github.com/repos/aravi5/drill-test-framework/subscription","commits_url":"https://api.github.com/repos/aravi5/drill-test-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/aravi5/drill-test-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/aravi5/drill-test-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/aravi5/drill-test-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/aravi5/drill-test-framework/contents/{+path}","compare_url":"https://api.github.com/repos/aravi5/drill-test-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aravi5/drill-test-framework/merges","archive_url":"https://api.github.com/repos/aravi5/drill-test-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aravi5/drill-test-framework/downloads","issues_url":"https://api.github.com/repos/aravi5/drill-test-framework/issues{/number}","pulls_url":"https://api.github.com/repos/aravi5/drill-test-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/aravi5/drill-test-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/aravi5/drill-test-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aravi5/drill-test-framework/labels{/name}","releases_url":"https://api.github.com/repos/aravi5/drill-test-framework/releases{/id}","deployments_url":"https://api.github.com/repos/aravi5/drill-test-framework/deployments","created_at":"2018-10-04T05:16:54Z","updated_at":"2019-03-18T22:58:47Z","pushed_at":"2019-03-25T21:43:38Z","git_url":"git://github.com/aravi5/drill-test-framework.git","ssh_url":"git@github.com:aravi5/drill-test-framework.git","clone_url":"https://github.com/aravi5/drill-test-framework.git","svn_url":"https://github.com/aravi5/drill-test-framework","homepage":"","size":1092235,"stargazers_count":0,"watchers_count":0,"language":"Eiffel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapr:master","ref":"master","sha":"a60cc9cebac9b648c69f9374c6657b8377d6735b","user":{"login":"mapr","id":1226517,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjY1MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1226517?v=4","gravatar_id":"","url":"https://api.github.com/users/mapr","html_url":"https://github.com/mapr","followers_url":"https://api.github.com/users/mapr/followers","following_url":"https://api.github.com/users/mapr/following{/other_user}","gists_url":"https://api.github.com/users/mapr/gists{/gist_id}","starred_url":"https://api.github.com/users/mapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapr/subscriptions","organizations_url":"https://api.github.com/users/mapr/orgs","repos_url":"https://api.github.com/users/mapr/repos","events_url":"https://api.github.com/users/mapr/events{/privacy}","received_events_url":"https://api.github.com/users/mapr/received_events","type":"Organization","site_admin":false},"repo":{"id":41067950,"node_id":"MDEwOlJlcG9zaXRvcnk0MTA2Nzk1MA==","name":"drill-test-framework","full_name":"mapr/drill-test-framework","private":false,"owner":{"login":"mapr","id":1226517,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjY1MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1226517?v=4","gravatar_id":"","url":"https://api.github.com/users/mapr","html_url":"https://github.com/mapr","followers_url":"https://api.github.com/users/mapr/followers","following_url":"https://api.github.com/users/mapr/following{/other_user}","gists_url":"https://api.github.com/users/mapr/gists{/gist_id}","starred_url":"https://api.github.com/users/mapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapr/subscriptions","organizations_url":"https://api.github.com/users/mapr/orgs","repos_url":"https://api.github.com/users/mapr/repos","events_url":"https://api.github.com/users/mapr/events{/privacy}","received_events_url":"https://api.github.com/users/mapr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapr/drill-test-framework","description":"Test Framework for Apache Drill","fork":false,"url":"https://api.github.com/repos/mapr/drill-test-framework","forks_url":"https://api.github.com/repos/mapr/drill-test-framework/forks","keys_url":"https://api.github.com/repos/mapr/drill-test-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapr/drill-test-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapr/drill-test-framework/teams","hooks_url":"https://api.github.com/repos/mapr/drill-test-framework/hooks","issue_events_url":"https://api.github.com/repos/mapr/drill-test-framework/issues/events{/number}","events_url":"https://api.github.com/repos/mapr/drill-test-framework/events","assignees_url":"https://api.github.com/repos/mapr/drill-test-framework/assignees{/user}","branches_url":"https://api.github.com/repos/mapr/drill-test-framework/branches{/branch}","tags_url":"https://api.github.com/repos/mapr/drill-test-framework/tags","blobs_url":"https://api.github.com/repos/mapr/drill-test-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapr/drill-test-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapr/drill-test-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapr/drill-test-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapr/drill-test-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/mapr/drill-test-framework/languages","stargazers_url":"https://api.github.com/repos/mapr/drill-test-framework/stargazers","contributors_url":"https://api.github.com/repos/mapr/drill-test-framework/contributors","subscribers_url":"https://api.github.com/repos/mapr/drill-test-framework/subscribers","subscription_url":"https://api.github.com/repos/mapr/drill-test-framework/subscription","commits_url":"https://api.github.com/repos/mapr/drill-test-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapr/drill-test-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapr/drill-test-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapr/drill-test-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapr/drill-test-framework/contents/{+path}","compare_url":"https://api.github.com/repos/mapr/drill-test-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapr/drill-test-framework/merges","archive_url":"https://api.github.com/repos/mapr/drill-test-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapr/drill-test-framework/downloads","issues_url":"https://api.github.com/repos/mapr/drill-test-framework/issues{/number}","pulls_url":"https://api.github.com/repos/mapr/drill-test-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/mapr/drill-test-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/mapr/drill-test-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapr/drill-test-framework/labels{/name}","releases_url":"https://api.github.com/repos/mapr/drill-test-framework/releases{/id}","deployments_url":"https://api.github.com/repos/mapr/drill-test-framework/deployments","created_at":"2015-08-20T01:12:00Z","updated_at":"2019-03-18T23:10:31Z","pushed_at":"2019-03-25T21:43:39Z","git_url":"git://github.com/mapr/drill-test-framework.git","ssh_url":"git@github.com:mapr/drill-test-framework.git","clone_url":"https://github.com/mapr/drill-test-framework.git","svn_url":"https://github.com/mapr/drill-test-framework","homepage":"","size":1092183,"stargazers_count":6,"watchers_count":6,"language":"Eiffel","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":36,"open_issues":23,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/563"},"html":{"href":"https://github.com/mapr/drill-test-framework/pull/563"},"issue":{"href":"https://api.github.com/repos/mapr/drill-test-framework/issues/563"},"comments":{"href":"https://api.github.com/repos/mapr/drill-test-framework/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapr/drill-test-framework/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/mapr/drill-test-framework/statuses/bdb5977dd39cb6c4768a0afbbccaa8fa43788bf8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aravi5"}}