{"action":"created","issue":{"url":"https://api.github.com/repos/browserify/resolve/issues/184","repository_url":"https://api.github.com/repos/browserify/resolve","labels_url":"https://api.github.com/repos/browserify/resolve/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/browserify/resolve/issues/184/comments","events_url":"https://api.github.com/repos/browserify/resolve/issues/184/events","html_url":"https://github.com/browserify/resolve/pull/184","id":413624613,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NTY4ODMx","number":184,"title":"[New] resolve.sync can resolve to options.fallback if resolution fails","user":{"login":"flisboac","id":1124212,"node_id":"MDQ6VXNlcjExMjQyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1124212?v=4","gravatar_id":"","url":"https://api.github.com/users/flisboac","html_url":"https://github.com/flisboac","followers_url":"https://api.github.com/users/flisboac/followers","following_url":"https://api.github.com/users/flisboac/following{/other_user}","gists_url":"https://api.github.com/users/flisboac/gists{/gist_id}","starred_url":"https://api.github.com/users/flisboac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flisboac/subscriptions","organizations_url":"https://api.github.com/users/flisboac/orgs","repos_url":"https://api.github.com/users/flisboac/repos","events_url":"https://api.github.com/users/flisboac/events{/privacy}","received_events_url":"https://api.github.com/users/flisboac/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-02-22T23:59:37Z","updated_at":"2019-02-25T21:49:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/browserify/resolve/pulls/184","html_url":"https://github.com/browserify/resolve/pull/184","diff_url":"https://github.com/browserify/resolve/pull/184.diff","patch_url":"https://github.com/browserify/resolve/pull/184.patch"},"body":"Added a new optional field `fallback` in `resolve.sync`'s `options`\r\nparameter. If given,  `fallback` must be a `string` value for it to be\r\nconsidered in the resolution process. It can be an empty string.\r\n\r\nIf provided, and if the module resolution is about to fail, the fallback\r\nvalue is returned instead, and no exception is thrown.\r\n\r\nOld users of the API won't be affected by this change, and new user will\r\nbe able to avoid a possibly costly exception throw -- especially relevant\r\nin scenarios where there's a considerable amount of modules\r\n(direct or transitive) to resolve.\r\n\r\nPlease see `tests/fallback.js` for a brief example."},"comment":{"url":"https://api.github.com/repos/browserify/resolve/issues/comments/467197427","html_url":"https://github.com/browserify/resolve/pull/184#issuecomment-467197427","issue_url":"https://api.github.com/repos/browserify/resolve/issues/184","id":467197427,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NzE5NzQyNw==","user":{"login":"ljharb","id":45469,"node_id":"MDQ6VXNlcjQ1NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/45469?v=4","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"created_at":"2019-02-25T21:49:54Z","updated_at":"2019-02-25T21:49:54Z","author_association":"COLLABORATOR","body":"What else could throw an error if the only statement in `try` is `resolve.sync`? Note that you can also check the error's `.code` to see what kind of error it is, including module resolution failure."}}
{"actor":{"display_login":"ljharb"}}