{"action":"closed","issue":{"url":"https://api.github.com/repos/nvs/map/issues/79","repository_url":"https://api.github.com/repos/nvs/map","labels_url":"https://api.github.com/repos/nvs/map/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/nvs/map/issues/79/comments","events_url":"https://api.github.com/repos/nvs/map/issues/79/events","html_url":"https://github.com/nvs/map/issues/79","id":527748569,"node_id":"MDU6SXNzdWU1Mjc3NDg1Njk=","number":79,"title":"Expose more file data (e.g. preplaced stuff and terrain)","user":{"login":"nvs","id":12818,"node_id":"MDQ6VXNlcjEyODE4","avatar_url":"https://avatars3.githubusercontent.com/u/12818?v=4","gravatar_id":"","url":"https://api.github.com/users/nvs","html_url":"https://github.com/nvs","followers_url":"https://api.github.com/users/nvs/followers","following_url":"https://api.github.com/users/nvs/following{/other_user}","gists_url":"https://api.github.com/users/nvs/gists{/gist_id}","starred_url":"https://api.github.com/users/nvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvs/subscriptions","organizations_url":"https://api.github.com/users/nvs/orgs","repos_url":"https://api.github.com/users/nvs/repos","events_url":"https://api.github.com/users/nvs/events{/privacy}","received_events_url":"https://api.github.com/users/nvs/received_events","type":"User","site_admin":false},"labels":[{"id":533269508,"node_id":"MDU6TGFiZWw1MzMyNjk1MDg=","url":"https://api.github.com/repos/nvs/map/labels/Is_Feature","name":"Is_Feature","color":"0e8a16","default":false,"description":null},{"id":533270444,"node_id":"MDU6TGFiZWw1MzMyNzA0NDQ=","url":"https://api.github.com/repos/nvs/map/labels/Status_Finished","name":"Status_Finished","color":"c2e0c6","default":false,"description":null}],"state":"closed","locked":false,"assignee":{"login":"nvs","id":12818,"node_id":"MDQ6VXNlcjEyODE4","avatar_url":"https://avatars3.githubusercontent.com/u/12818?v=4","gravatar_id":"","url":"https://api.github.com/users/nvs","html_url":"https://github.com/nvs","followers_url":"https://api.github.com/users/nvs/followers","following_url":"https://api.github.com/users/nvs/following{/other_user}","gists_url":"https://api.github.com/users/nvs/gists{/gist_id}","starred_url":"https://api.github.com/users/nvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvs/subscriptions","organizations_url":"https://api.github.com/users/nvs/orgs","repos_url":"https://api.github.com/users/nvs/repos","events_url":"https://api.github.com/users/nvs/events{/privacy}","received_events_url":"https://api.github.com/users/nvs/received_events","type":"User","site_admin":false},"assignees":[{"login":"nvs","id":12818,"node_id":"MDQ6VXNlcjEyODE4","avatar_url":"https://avatars3.githubusercontent.com/u/12818?v=4","gravatar_id":"","url":"https://api.github.com/users/nvs","html_url":"https://github.com/nvs","followers_url":"https://api.github.com/users/nvs/followers","following_url":"https://api.github.com/users/nvs/following{/other_user}","gists_url":"https://api.github.com/users/nvs/gists{/gist_id}","starred_url":"https://api.github.com/users/nvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvs/subscriptions","organizations_url":"https://api.github.com/users/nvs/orgs","repos_url":"https://api.github.com/users/nvs/repos","events_url":"https://api.github.com/users/nvs/events{/privacy}","received_events_url":"https://api.github.com/users/nvs/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/nvs/map/milestones/15","html_url":"https://github.com/nvs/map/milestone/15","labels_url":"https://api.github.com/repos/nvs/map/milestones/15/labels","id":4904435,"node_id":"MDk6TWlsZXN0b25lNDkwNDQzNQ==","number":15,"title":"0.9.0","description":"","creator":{"login":"nvs","id":12818,"node_id":"MDQ6VXNlcjEyODE4","avatar_url":"https://avatars3.githubusercontent.com/u/12818?v=4","gravatar_id":"","url":"https://api.github.com/users/nvs","html_url":"https://github.com/nvs","followers_url":"https://api.github.com/users/nvs/followers","following_url":"https://api.github.com/users/nvs/following{/other_user}","gists_url":"https://api.github.com/users/nvs/gists{/gist_id}","starred_url":"https://api.github.com/users/nvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvs/subscriptions","organizations_url":"https://api.github.com/users/nvs/orgs","repos_url":"https://api.github.com/users/nvs/repos","events_url":"https://api.github.com/users/nvs/events{/privacy}","received_events_url":"https://api.github.com/users/nvs/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":5,"state":"open","created_at":"2019-12-05T02:16:48Z","updated_at":"2019-12-20T05:06:00Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2019-11-24T20:02:08Z","updated_at":"2019-12-20T05:06:00Z","closed_at":"2019-12-20T05:06:00Z","author_association":"OWNER","body":"Expose information from the following files:\r\n- [x] Units: `war3mapUnits.doo`\r\n- [x] Doodads: `war3map.doo`\r\n- [x] Terrain: `war3map.w3e`\r\n- [x] Regions: `war3map.w3r`\r\n- [x] Cameras: `war3map.w3c`\r\n- [x] Sounds: `war3map.w3s`\r\n- [x] Pathing: `war3map.wpm`\r\n\r\nThe idea is to allow the user the option to take such data, perhaps edit it, and even produce code to generate the objects themselves (as Map does not do that, nor are there plans to support such behavior). The alternative is to copy/paste such functionality from an WE generated map script. And unless WC3 becomes aware of Lua files within the map archive (e.g. true `require` support), a few interesting steps will be needed to allow user generated code to be introduced into the map script.\r\n\r\n~~One idea is for the user to require a placeholder file, knowing that in the build process it will be replaced. They can then use `require` with this file in mind, and have their build files effectively replace it. Perhaps delay the script checks until after the build process finishes? Otherwise, the true file will not be checked, except as part of the full script. This placeholder file idea is the easiest to make happen without too many changes to Map itself.~~ The ordering of tasks in the build process was changed. This allows one to generate a file in the build process and require it for checking scripts."}}
{"actor":{"display_login":"nvs"}}