{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/336219592","pull_request_review_id":303536933,"id":336219592,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjIxOTU5Mg==","diff_hunk":"@@ -0,0 +1,192 @@\n+/**\n+ * @license\n+ * Copyright Google Inc. All Rights Reserved.\n+ *\n+ * Use of this source code is governed by an MIT-style license that can be\n+ * found in the LICENSE file at https://angular.io/license\n+ */\n+\n+import {getSystemPath, normalize, virtualFs} from '@angular-devkit/core';\n+import {TempScopedNodeJsSyncHost} from '@angular-devkit/core/node/testing';\n+import {HostTree} from '@angular-devkit/schematics';\n+import {SchematicTestRunner, UnitTestTree} from '@angular-devkit/schematics/testing';\n+import * as shx from 'shelljs';\n+\n+describe('ModuleWithProviders migration', () => {\n+  let runner: SchematicTestRunner;\n+  let host: TempScopedNodeJsSyncHost;\n+  let tree: UnitTestTree;\n+  let tmpDirPath: string;\n+  let previousWorkingDir: string;\n+\n+  beforeEach(() => {\n+    runner = new SchematicTestRunner('test', require.resolve('../migrations.json'));\n+    host = new TempScopedNodeJsSyncHost();\n+    tree = new UnitTestTree(new HostTree(host));\n+\n+    writeFile('/tsconfig.json', JSON.stringify({\n+      compilerOptions: {\n+        lib: ['es2015'],\n+      }\n+    }));\n+    writeFile('/angular.json', JSON.stringify({\n+      projects: {t: {architect: {build: {options: {tsConfig: './tsconfig.json'}}}}}\n+    }));\n+\n+    previousWorkingDir = shx.pwd();\n+    tmpDirPath = getSystemPath(host.root);\n+\n+    // Switch into the temporary directory path. This allows us to run\n+    // the schematic against our custom unit test tree.\n+    shx.cd(tmpDirPath);\n+  });\n+\n+  afterEach(() => {\n+    shx.cd(previousWorkingDir);\n+    shx.rm('-r', tmpDirPath);\n+  });\n+\n+  it('should add generic type for function return', async() => {\n+    writeFile('/index.ts', `\n+        import {NgModule, ModuleWithProviders} from '@angular/core';\n+        \n+        @NgModule({})\n+        export class BaseModule {}\n+       \n+        export function getProvider() {\n+          return {ngModule: BaseModule}\n+        }\n+        \n+        @NgModule({})\n+        export class TestModule {\n+          static forRoot(): ModuleWithProviders {\n+            return getProvider();\n+          }\n+        }\n+      `);\n+\n+    await runMigration();\n+    expect(tree.readContent('/index.ts')).toContain(`ModuleWithProviders<BaseModule>`);\n+  });\n+\n+  it('should add generic type for function return; external file', async() => {\n+    writeFile('/module.ts', `\n+        import {NgModule} from '@angular/core';\n+        \n+        @NgModule({})\n+        export class BaseModule {}\n+      `);\n+    writeFile('/index.ts', `\n+        import {NgModule, ModuleWithProviders} from '@angular/core';\n+        import {BaseModule} from './module';\n+       \n+        export function getProvider() {\n+          return {ngModule: BaseModule}\n+        }\n+        \n+        @NgModule({})\n+        export class TestModule {\n+          static forRoot(): ModuleWithProviders {\n+            return getProvider();\n+          }\n+        }\n+      `);\n+\n+    await runMigration();\n+    expect(tree.readContent('/index.ts')).toContain(`ModuleWithProviders<BaseModule>`);\n+  });\n+\n+  it('should add generic type for function return without explicit type', async() => {\n+    writeFile('/index.ts', `\n+        import {NgModule} from '@angular/core';\n+        \n+        @NgModule({})\n+        export class BaseModule {}\n+       \n+        export function getProvider() {\n+          return {ngModule: BaseModule}\n+        }\n+        \n+        @NgModule({})\n+        export class TestModule {\n+          static forRoot() {\n+            return getProvider();\n+          }\n+        }\n+      `);\n+\n+    await runMigration();\n+    expect(tree.readContent('/index.ts')).toContain(`ModuleWithProviders<BaseModule>`);\n+  });\n+\n+  it('should add generic type for const variable', async() => {\n+    writeFile('/index.ts', `\n+        import {NgModule} from '@angular/core';\n+        \n+        @NgModule({})\n+        export class BaseModule {}\n+       \n+        export const myModuleWithProviders = {ngModule: BaseModule};\n+        \n+        @NgModule({})\n+        export class TestModule {\n+          static forRoot(): ModuleWithProviders {\n+            return myModuleWithProviders;\n+          }\n+        }\n+      `);\n+\n+    await runMigration();\n+    expect(tree.readContent('/index.ts')).toContain(`ModuleWithProviders<BaseModule>`);\n+  });\n+\n+  it('should add generic type for const variable without explicit type', async() => {\n+    writeFile('/index.ts', `\n+        import {NgModule} from '@angular/core';\n+        \n+        @NgModule({})\n+        export class BaseModule {}\n+       \n+        export const myModuleWithProviders = {ngModule: BaseModule};\n+        \n+        @NgModule({})\n+        export class TestModule {\n+          static forRoot() {\n+            return myModuleWithProviders;\n+          }\n+        }\n+      `);\n+\n+    await runMigration();\n+    expect(tree.readContent('/index.ts')).toContain(`ModuleWithProviders<BaseModule>`);\n+  });\n+\n+  it('should not add generic type for const variable with invalid base object', async() => {\n+    writeFile('/index.ts', `\n+        import {NgModule} from '@angular/core';\n+        \n+        @NgModule({})\n+        export class BaseModule {}\n+       \n+        export const myModuleWithProviders = {ngModule: BaseModule, otherKey: 'a'};\n+        \n+        @NgModule({})\n+        export class TestModule {\n+          static forRoot() {\n+            return myModuleWithProviders;\n+          }\n+        }\n+      `);\n+\n+    await runMigration();\n+    expect(tree.readContent('/index.ts')).not.toContain(`ModuleWithProviders<BaseModule>`);","path":"packages/core/schematics/test/module_with_providers_migration_spec.ts","position":182,"original_position":182,"commit_id":"ed526816450979d0d28bfd42eaf69d54ccb9e296","original_commit_id":"5d38a2076e6d6d0444d27cfc5d14c4629b4fed42","user":{"login":"CaerusKaru","id":416563,"node_id":"MDQ6VXNlcjQxNjU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/416563?v=4","gravatar_id":"","url":"https://api.github.com/users/CaerusKaru","html_url":"https://github.com/CaerusKaru","followers_url":"https://api.github.com/users/CaerusKaru/followers","following_url":"https://api.github.com/users/CaerusKaru/following{/other_user}","gists_url":"https://api.github.com/users/CaerusKaru/gists{/gist_id}","starred_url":"https://api.github.com/users/CaerusKaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaerusKaru/subscriptions","organizations_url":"https://api.github.com/users/CaerusKaru/orgs","repos_url":"https://api.github.com/users/CaerusKaru/repos","events_url":"https://api.github.com/users/CaerusKaru/events{/privacy}","received_events_url":"https://api.github.com/users/CaerusKaru/received_events","type":"User","site_admin":false},"body":"Usually we emit a failure and it gets printed out at the end, highlighting the exact file and line of the offending node. I can do that for this case as well.","created_at":"2019-10-17T20:48:37Z","updated_at":"2019-10-17T20:48:37Z","html_url":"https://github.com/angular/angular/pull/33217#discussion_r336219592","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/33217","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/336219592"},"html":{"href":"https://github.com/angular/angular/pull/33217#discussion_r336219592"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/33217"}},"in_reply_to_id":336174455},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/33217","id":329095047,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MDk1MDQ3","html_url":"https://github.com/angular/angular/pull/33217","diff_url":"https://github.com/angular/angular/pull/33217.diff","patch_url":"https://github.com/angular/angular/pull/33217.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/33217","number":33217,"state":"open","locked":false,"title":"feat(core): add ModuleWithProviders generic type migration","user":{"login":"CaerusKaru","id":416563,"node_id":"MDQ6VXNlcjQxNjU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/416563?v=4","gravatar_id":"","url":"https://api.github.com/users/CaerusKaru","html_url":"https://github.com/CaerusKaru","followers_url":"https://api.github.com/users/CaerusKaru/followers","following_url":"https://api.github.com/users/CaerusKaru/following{/other_user}","gists_url":"https://api.github.com/users/CaerusKaru/gists{/gist_id}","starred_url":"https://api.github.com/users/CaerusKaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaerusKaru/subscriptions","organizations_url":"https://api.github.com/users/CaerusKaru/orgs","repos_url":"https://api.github.com/users/CaerusKaru/repos","events_url":"https://api.github.com/users/CaerusKaru/events{/privacy}","received_events_url":"https://api.github.com/users/CaerusKaru/received_events","type":"User","site_admin":false},"body":"Static methods that return a type of `ModuleWithProviders` currently do not have to specify a type because the generic falls back to `any`. This is problematic because the type of the actual module being returned is not present in the type information.\r\n\r\nSince Ivy uses `d.ts` files exclusively for downstream packages (rather than `metadata.json` files, for example), we no longer have the type of the actual module being created.\r\n\r\nFor this reason, a generic type should be added for `ModuleWithProviders` that specifies the module type. This will be required for all users in v10, but will only be necessary for users of Ivy in v9.\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n\r\n- [ ] Bugfix\r\n- [x] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build related changes\r\n- [ ] CI related changes\r\n- [ ] Documentation content changes\r\n- [ ] angular.io application / infrastructure changes\r\n- [ ] Other... Please describe:\r\n\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nIssue Number: N/A\r\n\r\n\r\n## What is the new behavior?\r\n\r\n`ModuleWithProviders` requires an explicit generic type\r\n\r\n## Does this PR introduce a breaking change?\r\n\r\n- [x] Yes\r\n- [ ] No\r\n\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n","created_at":"2019-10-17T06:45:07Z","updated_at":"2019-10-17T20:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27a7ae7432ee0046bc0c7ca891702dea899a592a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"devversion","id":4987015,"node_id":"MDQ6VXNlcjQ5ODcwMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4987015?v=4","gravatar_id":"","url":"https://api.github.com/users/devversion","html_url":"https://github.com/devversion","followers_url":"https://api.github.com/users/devversion/followers","following_url":"https://api.github.com/users/devversion/following{/other_user}","gists_url":"https://api.github.com/users/devversion/gists{/gist_id}","starred_url":"https://api.github.com/users/devversion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devversion/subscriptions","organizations_url":"https://api.github.com/users/devversion/orgs","repos_url":"https://api.github.com/users/devversion/repos","events_url":"https://api.github.com/users/devversion/events{/privacy}","received_events_url":"https://api.github.com/users/devversion/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"fw-public-api","id":3050920,"node_id":"MDQ6VGVhbTMwNTA5MjA=","slug":"fw-public-api","description":"","privacy":"closed","url":"https://api.github.com/teams/3050920","html_url":"https://github.com/orgs/angular/teams/fw-public-api","members_url":"https://api.github.com/teams/3050920/members{/member}","repositories_url":"https://api.github.com/teams/3050920/repos","permission":"pull"}],"labels":[{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/33217/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/33217/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/33217/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/ed526816450979d0d28bfd42eaf69d54ccb9e296","head":{"label":"CaerusKaru:adam/mwp","ref":"adam/mwp","sha":"ed526816450979d0d28bfd42eaf69d54ccb9e296","user":{"login":"CaerusKaru","id":416563,"node_id":"MDQ6VXNlcjQxNjU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/416563?v=4","gravatar_id":"","url":"https://api.github.com/users/CaerusKaru","html_url":"https://github.com/CaerusKaru","followers_url":"https://api.github.com/users/CaerusKaru/followers","following_url":"https://api.github.com/users/CaerusKaru/following{/other_user}","gists_url":"https://api.github.com/users/CaerusKaru/gists{/gist_id}","starred_url":"https://api.github.com/users/CaerusKaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaerusKaru/subscriptions","organizations_url":"https://api.github.com/users/CaerusKaru/orgs","repos_url":"https://api.github.com/users/CaerusKaru/repos","events_url":"https://api.github.com/users/CaerusKaru/events{/privacy}","received_events_url":"https://api.github.com/users/CaerusKaru/received_events","type":"User","site_admin":false},"repo":{"id":104355918,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQzNTU5MTg=","name":"angular","full_name":"CaerusKaru/angular","private":false,"owner":{"login":"CaerusKaru","id":416563,"node_id":"MDQ6VXNlcjQxNjU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/416563?v=4","gravatar_id":"","url":"https://api.github.com/users/CaerusKaru","html_url":"https://github.com/CaerusKaru","followers_url":"https://api.github.com/users/CaerusKaru/followers","following_url":"https://api.github.com/users/CaerusKaru/following{/other_user}","gists_url":"https://api.github.com/users/CaerusKaru/gists{/gist_id}","starred_url":"https://api.github.com/users/CaerusKaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaerusKaru/subscriptions","organizations_url":"https://api.github.com/users/CaerusKaru/orgs","repos_url":"https://api.github.com/users/CaerusKaru/repos","events_url":"https://api.github.com/users/CaerusKaru/events{/privacy}","received_events_url":"https://api.github.com/users/CaerusKaru/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CaerusKaru/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/CaerusKaru/angular","forks_url":"https://api.github.com/repos/CaerusKaru/angular/forks","keys_url":"https://api.github.com/repos/CaerusKaru/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CaerusKaru/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CaerusKaru/angular/teams","hooks_url":"https://api.github.com/repos/CaerusKaru/angular/hooks","issue_events_url":"https://api.github.com/repos/CaerusKaru/angular/issues/events{/number}","events_url":"https://api.github.com/repos/CaerusKaru/angular/events","assignees_url":"https://api.github.com/repos/CaerusKaru/angular/assignees{/user}","branches_url":"https://api.github.com/repos/CaerusKaru/angular/branches{/branch}","tags_url":"https://api.github.com/repos/CaerusKaru/angular/tags","blobs_url":"https://api.github.com/repos/CaerusKaru/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CaerusKaru/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CaerusKaru/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/CaerusKaru/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CaerusKaru/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/CaerusKaru/angular/languages","stargazers_url":"https://api.github.com/repos/CaerusKaru/angular/stargazers","contributors_url":"https://api.github.com/repos/CaerusKaru/angular/contributors","subscribers_url":"https://api.github.com/repos/CaerusKaru/angular/subscribers","subscription_url":"https://api.github.com/repos/CaerusKaru/angular/subscription","commits_url":"https://api.github.com/repos/CaerusKaru/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/CaerusKaru/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/CaerusKaru/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/CaerusKaru/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/CaerusKaru/angular/contents/{+path}","compare_url":"https://api.github.com/repos/CaerusKaru/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CaerusKaru/angular/merges","archive_url":"https://api.github.com/repos/CaerusKaru/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CaerusKaru/angular/downloads","issues_url":"https://api.github.com/repos/CaerusKaru/angular/issues{/number}","pulls_url":"https://api.github.com/repos/CaerusKaru/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/CaerusKaru/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/CaerusKaru/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CaerusKaru/angular/labels{/name}","releases_url":"https://api.github.com/repos/CaerusKaru/angular/releases{/id}","deployments_url":"https://api.github.com/repos/CaerusKaru/angular/deployments","created_at":"2017-09-21T14:05:18Z","updated_at":"2019-06-06T02:34:40Z","pushed_at":"2019-10-17T20:46:16Z","git_url":"git://github.com/CaerusKaru/angular.git","ssh_url":"git@github.com:CaerusKaru/angular.git","clone_url":"https://github.com/CaerusKaru/angular.git","svn_url":"https://github.com/CaerusKaru/angular","homepage":"https://angular.io","size":118901,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"9d54679e6628bdcda93e543fcc87037da5583a85","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2019-10-17T20:46:59Z","pushed_at":"2019-10-17T20:47:38Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":124397,"stargazers_count":52959,"watchers_count":52959,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14659,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3224,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14659,"open_issues":3224,"watchers":52959,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/33217"},"html":{"href":"https://github.com/angular/angular/pull/33217"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/33217"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/33217/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/33217/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/33217/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/ed526816450979d0d28bfd42eaf69d54ccb9e296"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"CaerusKaru"}}