{"action":"closed","number":3375,"pull_request":{"url":"https://api.github.com/repos/microsoft/AdaptiveCards/pulls/3375","id":309725562,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5NzI1NTYy","html_url":"https://github.com/microsoft/AdaptiveCards/pull/3375","diff_url":"https://github.com/microsoft/AdaptiveCards/pull/3375.diff","patch_url":"https://github.com/microsoft/AdaptiveCards/pull/3375.patch","issue_url":"https://api.github.com/repos/microsoft/AdaptiveCards/issues/3375","number":3375,"state":"closed","locked":false,"title":"[UWP] Fix bugs in custom warnings","user":{"login":"RebeccaAnne","id":9091833,"node_id":"MDQ6VXNlcjkwOTE4MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/9091833?v=4","gravatar_id":"","url":"https://api.github.com/users/RebeccaAnne","html_url":"https://github.com/RebeccaAnne","followers_url":"https://api.github.com/users/RebeccaAnne/followers","following_url":"https://api.github.com/users/RebeccaAnne/following{/other_user}","gists_url":"https://api.github.com/users/RebeccaAnne/gists{/gist_id}","starred_url":"https://api.github.com/users/RebeccaAnne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RebeccaAnne/subscriptions","organizations_url":"https://api.github.com/users/RebeccaAnne/orgs","repos_url":"https://api.github.com/users/RebeccaAnne/repos","events_url":"https://api.github.com/users/RebeccaAnne/events{/privacy}","received_events_url":"https://api.github.com/users/RebeccaAnne/received_events","type":"User","site_admin":false},"body":"## Related Issues\r\nFixes #3374, Fixes #3373\r\n\r\n## Description\r\nFixes three issues related to setting warnings and errors from a custom parsers and renders:\r\n- Made the status and message properties read/write rather than readonly so that custom parsers and renderers can set them\r\n- Added CustomWarning and CustomError types to the status code enums to allow custom clients to indicate that their error or warning doesn't fall into one of our existing categories\r\n- Fixed an issue where a vector was passed by value when it should have been passed by reference, leading to the vector not being updated as expected.\r\n\r\n## How Verified\r\nVerified a custom parser could set warnings that were propagated to the visualizer using local code and manual testing. Automated and checked in custom rendering testing that will cover this scenario coming soon to a test app near you via #2720.\r\n\r\n\r\n###### Microsoft Reviewers: [Open in CodeFlow](http://wpcp.azurewebsites.net/CodeFlowProtocolProxy2.php?pullrequest=https://github.com/microsoft/AdaptiveCards/pull/3375)","created_at":"2019-08-21T23:32:38Z","updated_at":"2019-08-23T18:15:20Z","closed_at":"2019-08-23T18:15:20Z","merged_at":"2019-08-23T18:15:20Z","merge_commit_sha":"fae010682c786f9c29dc76124cc66f64e7a5efaa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/AdaptiveCards/pulls/3375/commits","review_comments_url":"https://api.github.com/repos/microsoft/AdaptiveCards/pulls/3375/comments","review_comment_url":"https://api.github.com/repos/microsoft/AdaptiveCards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/AdaptiveCards/issues/3375/comments","statuses_url":"https://api.github.com/repos/microsoft/AdaptiveCards/statuses/9714c53aff4cfb2327fad86a25204397365eb117","head":{"label":"microsoft:rebecch/CustomWarningFixes","ref":"rebecch/CustomWarningFixes","sha":"9714c53aff4cfb2327fad86a25204397365eb117","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":75978731,"node_id":"MDEwOlJlcG9zaXRvcnk3NTk3ODczMQ==","name":"AdaptiveCards","full_name":"microsoft/AdaptiveCards","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/AdaptiveCards","description":"A new way for developers to exchange card content in a common and consistent way.","fork":false,"url":"https://api.github.com/repos/microsoft/AdaptiveCards","forks_url":"https://api.github.com/repos/microsoft/AdaptiveCards/forks","keys_url":"https://api.github.com/repos/microsoft/AdaptiveCards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/AdaptiveCards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/AdaptiveCards/teams","hooks_url":"https://api.github.com/repos/microsoft/AdaptiveCards/hooks","issue_events_url":"https://api.github.com/repos/microsoft/AdaptiveCards/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/AdaptiveCards/events","assignees_url":"https://api.github.com/repos/microsoft/AdaptiveCards/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/AdaptiveCards/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/AdaptiveCards/tags","blobs_url":"https://api.github.com/repos/microsoft/AdaptiveCards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/AdaptiveCards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/AdaptiveCards/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/AdaptiveCards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/AdaptiveCards/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/AdaptiveCards/languages","stargazers_url":"https://api.github.com/repos/microsoft/AdaptiveCards/stargazers","contributors_url":"https://api.github.com/repos/microsoft/AdaptiveCards/contributors","subscribers_url":"https://api.github.com/repos/microsoft/AdaptiveCards/subscribers","subscription_url":"https://api.github.com/repos/microsoft/AdaptiveCards/subscription","commits_url":"https://api.github.com/repos/microsoft/AdaptiveCards/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/AdaptiveCards/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/AdaptiveCards/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/AdaptiveCards/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/AdaptiveCards/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/AdaptiveCards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/AdaptiveCards/merges","archive_url":"https://api.github.com/repos/microsoft/AdaptiveCards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/AdaptiveCards/downloads","issues_url":"https://api.github.com/repos/microsoft/AdaptiveCards/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/AdaptiveCards/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/AdaptiveCards/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/AdaptiveCards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/AdaptiveCards/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/AdaptiveCards/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/AdaptiveCards/deployments","created_at":"2016-12-08T22:00:33Z","updated_at":"2019-08-23T17:23:32Z","pushed_at":"2019-08-23T18:15:20Z","git_url":"git://github.com/microsoft/AdaptiveCards.git","ssh_url":"git@github.com:microsoft/AdaptiveCards.git","clone_url":"https://github.com/microsoft/AdaptiveCards.git","svn_url":"https://github.com/microsoft/AdaptiveCards","homepage":"https://adaptivecards.io","size":224576,"stargazers_count":563,"watchers_count":563,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":517,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":179,"open_issues":517,"watchers":563,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"8738f60b4f643eab49c1e622e9767cad212088c8","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":75978731,"node_id":"MDEwOlJlcG9zaXRvcnk3NTk3ODczMQ==","name":"AdaptiveCards","full_name":"microsoft/AdaptiveCards","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/AdaptiveCards","description":"A new way for developers to exchange card content in a common and consistent way.","fork":false,"url":"https://api.github.com/repos/microsoft/AdaptiveCards","forks_url":"https://api.github.com/repos/microsoft/AdaptiveCards/forks","keys_url":"https://api.github.com/repos/microsoft/AdaptiveCards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/AdaptiveCards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/AdaptiveCards/teams","hooks_url":"https://api.github.com/repos/microsoft/AdaptiveCards/hooks","issue_events_url":"https://api.github.com/repos/microsoft/AdaptiveCards/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/AdaptiveCards/events","assignees_url":"https://api.github.com/repos/microsoft/AdaptiveCards/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/AdaptiveCards/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/AdaptiveCards/tags","blobs_url":"https://api.github.com/repos/microsoft/AdaptiveCards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/AdaptiveCards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/AdaptiveCards/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/AdaptiveCards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/AdaptiveCards/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/AdaptiveCards/languages","stargazers_url":"https://api.github.com/repos/microsoft/AdaptiveCards/stargazers","contributors_url":"https://api.github.com/repos/microsoft/AdaptiveCards/contributors","subscribers_url":"https://api.github.com/repos/microsoft/AdaptiveCards/subscribers","subscription_url":"https://api.github.com/repos/microsoft/AdaptiveCards/subscription","commits_url":"https://api.github.com/repos/microsoft/AdaptiveCards/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/AdaptiveCards/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/AdaptiveCards/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/AdaptiveCards/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/AdaptiveCards/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/AdaptiveCards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/AdaptiveCards/merges","archive_url":"https://api.github.com/repos/microsoft/AdaptiveCards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/AdaptiveCards/downloads","issues_url":"https://api.github.com/repos/microsoft/AdaptiveCards/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/AdaptiveCards/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/AdaptiveCards/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/AdaptiveCards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/AdaptiveCards/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/AdaptiveCards/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/AdaptiveCards/deployments","created_at":"2016-12-08T22:00:33Z","updated_at":"2019-08-23T17:23:32Z","pushed_at":"2019-08-23T18:15:20Z","git_url":"git://github.com/microsoft/AdaptiveCards.git","ssh_url":"git@github.com:microsoft/AdaptiveCards.git","clone_url":"https://github.com/microsoft/AdaptiveCards.git","svn_url":"https://github.com/microsoft/AdaptiveCards","homepage":"https://adaptivecards.io","size":224576,"stargazers_count":563,"watchers_count":563,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":517,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":179,"open_issues":517,"watchers":563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/AdaptiveCards/pulls/3375"},"html":{"href":"https://github.com/microsoft/AdaptiveCards/pull/3375"},"issue":{"href":"https://api.github.com/repos/microsoft/AdaptiveCards/issues/3375"},"comments":{"href":"https://api.github.com/repos/microsoft/AdaptiveCards/issues/3375/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/AdaptiveCards/pulls/3375/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/AdaptiveCards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/AdaptiveCards/pulls/3375/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/AdaptiveCards/statuses/9714c53aff4cfb2327fad86a25204397365eb117"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"RebeccaAnne","id":9091833,"node_id":"MDQ6VXNlcjkwOTE4MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/9091833?v=4","gravatar_id":"","url":"https://api.github.com/users/RebeccaAnne","html_url":"https://github.com/RebeccaAnne","followers_url":"https://api.github.com/users/RebeccaAnne/followers","following_url":"https://api.github.com/users/RebeccaAnne/following{/other_user}","gists_url":"https://api.github.com/users/RebeccaAnne/gists{/gist_id}","starred_url":"https://api.github.com/users/RebeccaAnne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RebeccaAnne/subscriptions","organizations_url":"https://api.github.com/users/RebeccaAnne/orgs","repos_url":"https://api.github.com/users/RebeccaAnne/repos","events_url":"https://api.github.com/users/RebeccaAnne/events{/privacy}","received_events_url":"https://api.github.com/users/RebeccaAnne/received_events","type":"User","site_admin":false},"comments":0,"review_comments":7,"maintainer_can_modify":false,"commits":5,"additions":90,"deletions":17,"changed_files":12}}
{"actor":{"display_login":"RebeccaAnne"}}