{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/framework/issues/30607","repository_url":"https://api.github.com/repos/laravel/framework","labels_url":"https://api.github.com/repos/laravel/framework/issues/30607/labels{/name}","comments_url":"https://api.github.com/repos/laravel/framework/issues/30607/comments","events_url":"https://api.github.com/repos/laravel/framework/issues/30607/events","html_url":"https://github.com/laravel/framework/pull/30607","id":523590273,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxNTYyMjcy","number":30607,"title":"[7.x] Make consistent names of Auth Factory Contract aliases","user":{"login":"Sergo96","id":8986207,"node_id":"MDQ6VXNlcjg5ODYyMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/8986207?v=4","gravatar_id":"","url":"https://api.github.com/users/Sergo96","html_url":"https://github.com/Sergo96","followers_url":"https://api.github.com/users/Sergo96/followers","following_url":"https://api.github.com/users/Sergo96/following{/other_user}","gists_url":"https://api.github.com/users/Sergo96/gists{/gist_id}","starred_url":"https://api.github.com/users/Sergo96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sergo96/subscriptions","organizations_url":"https://api.github.com/users/Sergo96/orgs","repos_url":"https://api.github.com/users/Sergo96/repos","events_url":"https://api.github.com/users/Sergo96/events{/privacy}","received_events_url":"https://api.github.com/users/Sergo96/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-11-15T17:14:28Z","updated_at":"2019-11-16T19:19:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/30607","html_url":"https://github.com/laravel/framework/pull/30607","diff_url":"https://github.com/laravel/framework/pull/30607.diff","patch_url":"https://github.com/laravel/framework/pull/30607.patch"},"body":"In the following files:\r\n\r\n1. helpers.php\r\n2. AuthenticateSession.php\r\n3. AuthenticateWithBasicAuth.php\r\n \r\nauth factory contract alias are named \"AuthFactory\". \r\n\r\nJust to make things consistent I renamed aliases in AuthManager.php and Authenticate.php files.\r\n"},"comment":{"url":"https://api.github.com/repos/laravel/framework/issues/comments/554666158","html_url":"https://github.com/laravel/framework/pull/30607#issuecomment-554666158","issue_url":"https://api.github.com/repos/laravel/framework/issues/30607","id":554666158,"node_id":"MDEyOklzc3VlQ29tbWVudDU1NDY2NjE1OA==","user":{"login":"devcircus","id":18542852,"node_id":"MDQ6VXNlcjE4NTQyODUy","avatar_url":"https://avatars3.githubusercontent.com/u/18542852?v=4","gravatar_id":"","url":"https://api.github.com/users/devcircus","html_url":"https://github.com/devcircus","followers_url":"https://api.github.com/users/devcircus/followers","following_url":"https://api.github.com/users/devcircus/following{/other_user}","gists_url":"https://api.github.com/users/devcircus/gists{/gist_id}","starred_url":"https://api.github.com/users/devcircus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devcircus/subscriptions","organizations_url":"https://api.github.com/users/devcircus/orgs","repos_url":"https://api.github.com/users/devcircus/repos","events_url":"https://api.github.com/users/devcircus/events{/privacy}","received_events_url":"https://api.github.com/users/devcircus/received_events","type":"User","site_admin":false},"created_at":"2019-11-16T19:19:34Z","updated_at":"2019-11-16T19:19:34Z","author_association":"CONTRIBUTOR","body":"IMO, the chosen names align with the context in which they are used and seem correct to me. For example, the AuthManager implements an interface, or contract, hence \"FactoryContract\" is used. In the AuthenticateSession middleware, an instance of the factory is injected, therefore \"AuthFactory\" is used. \r\n\r\nIt doesn't make sense to use the same naming conventions in these very different contexts.\r\n\r\n"}}
{"actor":{"display_login":"devcircus"}}