{"action":"created","comment":{"url":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/comments/313126886","pull_request_review_id":273948916,"id":313126886,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzEyNjg4Ng==","diff_hunk":"@@ -145,16 +146,35 @@ func (w *LitecoinWallet) ChildKey(keyBytes []byte, chaincode []byte, isPrivateKe\n }\n \n func (w *LitecoinWallet) CurrentAddress(purpose wi.KeyPurpose) btcutil.Address {\n-\tkey, _ := w.km.GetCurrentKey(purpose)\n-\taddr, _ := litecoinAddress(key, w.params)\n+\tvar addr btcutil.Address\n+\tfor {\n+\t\tkey, _ := w.km.GetCurrentKey(purpose)\n+\t\taddr, _ = litecoinAddress(key, w.params)\n+\t\tfmt.Println(addr)\n+\n+\t\tif !strings.HasPrefix(strings.ToLower(addr.String()), \"ltc1\") {\n+\t\t\tbreak\n+\t\t}\n+\t\tif err := w.db.Keys().MarkKeyAsUsed(addr.ScriptAddress()); err != nil {\n+\t\t\tw.log.Error(\"Error marking key as used: %s\", err)","path":"litecoin/wallet.go","position":24,"original_position":24,"commit_id":"c4b574223d0fc03ef14395affb51463ddeb6a932","original_commit_id":"c4b574223d0fc03ef14395affb51463ddeb6a932","user":{"login":"placer14","id":305332,"node_id":"MDQ6VXNlcjMwNTMzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/305332?v=4","gravatar_id":"","url":"https://api.github.com/users/placer14","html_url":"https://github.com/placer14","followers_url":"https://api.github.com/users/placer14/followers","following_url":"https://api.github.com/users/placer14/following{/other_user}","gists_url":"https://api.github.com/users/placer14/gists{/gist_id}","starred_url":"https://api.github.com/users/placer14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/placer14/subscriptions","organizations_url":"https://api.github.com/users/placer14/orgs","repos_url":"https://api.github.com/users/placer14/repos","events_url":"https://api.github.com/users/placer14/events{/privacy}","received_events_url":"https://api.github.com/users/placer14/received_events","type":"User","site_admin":false},"body":"`Errorf`?","created_at":"2019-08-12T21:02:26Z","updated_at":"2019-08-12T21:06:24Z","html_url":"https://github.com/OpenBazaar/multiwallet/pull/97#discussion_r313126886","pull_request_url":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/97","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/comments/313126886"},"html":{"href":"https://github.com/OpenBazaar/multiwallet/pull/97#discussion_r313126886"},"pull_request":{"href":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/97","id":306654600,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2NjU0NjAw","html_url":"https://github.com/OpenBazaar/multiwallet/pull/97","diff_url":"https://github.com/OpenBazaar/multiwallet/pull/97.diff","patch_url":"https://github.com/OpenBazaar/multiwallet/pull/97.patch","issue_url":"https://api.github.com/repos/OpenBazaar/multiwallet/issues/97","number":97,"state":"open","locked":false,"title":"Filter addresses returned that start with ltc1","user":{"login":"cpacia","id":4504708,"node_id":"MDQ6VXNlcjQ1MDQ3MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4504708?v=4","gravatar_id":"","url":"https://api.github.com/users/cpacia","html_url":"https://github.com/cpacia","followers_url":"https://api.github.com/users/cpacia/followers","following_url":"https://api.github.com/users/cpacia/following{/other_user}","gists_url":"https://api.github.com/users/cpacia/gists{/gist_id}","starred_url":"https://api.github.com/users/cpacia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpacia/subscriptions","organizations_url":"https://api.github.com/users/cpacia/orgs","repos_url":"https://api.github.com/users/cpacia/repos","events_url":"https://api.github.com/users/cpacia/events{/privacy}","received_events_url":"https://api.github.com/users/cpacia/received_events","type":"User","site_admin":false},"body":"Updates the litecoin get address functions to keep generating addresses until it gets one that does not start with ltc1. This is needed because the decode function interprets addresses starting with ltc1 as segwit addresses where these addresses are not. \r\n\r\nI tried writing a test for this but to mock this scenario requires about 10 minutes of brute forcing to get an address which does start with ltc1. Probably too long to run every time. ","created_at":"2019-08-12T20:47:59Z","updated_at":"2019-08-12T21:06:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ccfc936ed6c36df20189db3bf45d82a89754129","assignee":{"login":"cpacia","id":4504708,"node_id":"MDQ6VXNlcjQ1MDQ3MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4504708?v=4","gravatar_id":"","url":"https://api.github.com/users/cpacia","html_url":"https://github.com/cpacia","followers_url":"https://api.github.com/users/cpacia/followers","following_url":"https://api.github.com/users/cpacia/following{/other_user}","gists_url":"https://api.github.com/users/cpacia/gists{/gist_id}","starred_url":"https://api.github.com/users/cpacia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpacia/subscriptions","organizations_url":"https://api.github.com/users/cpacia/orgs","repos_url":"https://api.github.com/users/cpacia/repos","events_url":"https://api.github.com/users/cpacia/events{/privacy}","received_events_url":"https://api.github.com/users/cpacia/received_events","type":"User","site_admin":false},"assignees":[{"login":"cpacia","id":4504708,"node_id":"MDQ6VXNlcjQ1MDQ3MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4504708?v=4","gravatar_id":"","url":"https://api.github.com/users/cpacia","html_url":"https://github.com/cpacia","followers_url":"https://api.github.com/users/cpacia/followers","following_url":"https://api.github.com/users/cpacia/following{/other_user}","gists_url":"https://api.github.com/users/cpacia/gists{/gist_id}","starred_url":"https://api.github.com/users/cpacia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpacia/subscriptions","organizations_url":"https://api.github.com/users/cpacia/orgs","repos_url":"https://api.github.com/users/cpacia/repos","events_url":"https://api.github.com/users/cpacia/events{/privacy}","received_events_url":"https://api.github.com/users/cpacia/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/97/commits","review_comments_url":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/97/comments","review_comment_url":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenBazaar/multiwallet/issues/97/comments","statuses_url":"https://api.github.com/repos/OpenBazaar/multiwallet/statuses/c4b574223d0fc03ef14395affb51463ddeb6a932","head":{"label":"OpenBazaar:laddr","ref":"laddr","sha":"c4b574223d0fc03ef14395affb51463ddeb6a932","user":{"login":"OpenBazaar","id":7438770,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzg3NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/7438770?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"repo":{"id":120046823,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwNDY4MjM=","name":"multiwallet","full_name":"OpenBazaar/multiwallet","private":false,"owner":{"login":"OpenBazaar","id":7438770,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzg3NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/7438770?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenBazaar/multiwallet","description":"API based multi-cryptocurrency wallet","fork":false,"url":"https://api.github.com/repos/OpenBazaar/multiwallet","forks_url":"https://api.github.com/repos/OpenBazaar/multiwallet/forks","keys_url":"https://api.github.com/repos/OpenBazaar/multiwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenBazaar/multiwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenBazaar/multiwallet/teams","hooks_url":"https://api.github.com/repos/OpenBazaar/multiwallet/hooks","issue_events_url":"https://api.github.com/repos/OpenBazaar/multiwallet/issues/events{/number}","events_url":"https://api.github.com/repos/OpenBazaar/multiwallet/events","assignees_url":"https://api.github.com/repos/OpenBazaar/multiwallet/assignees{/user}","branches_url":"https://api.github.com/repos/OpenBazaar/multiwallet/branches{/branch}","tags_url":"https://api.github.com/repos/OpenBazaar/multiwallet/tags","blobs_url":"https://api.github.com/repos/OpenBazaar/multiwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenBazaar/multiwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenBazaar/multiwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenBazaar/multiwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenBazaar/multiwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenBazaar/multiwallet/languages","stargazers_url":"https://api.github.com/repos/OpenBazaar/multiwallet/stargazers","contributors_url":"https://api.github.com/repos/OpenBazaar/multiwallet/contributors","subscribers_url":"https://api.github.com/repos/OpenBazaar/multiwallet/subscribers","subscription_url":"https://api.github.com/repos/OpenBazaar/multiwallet/subscription","commits_url":"https://api.github.com/repos/OpenBazaar/multiwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenBazaar/multiwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenBazaar/multiwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenBazaar/multiwallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenBazaar/multiwallet/contents/{+path}","compare_url":"https://api.github.com/repos/OpenBazaar/multiwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenBazaar/multiwallet/merges","archive_url":"https://api.github.com/repos/OpenBazaar/multiwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenBazaar/multiwallet/downloads","issues_url":"https://api.github.com/repos/OpenBazaar/multiwallet/issues{/number}","pulls_url":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenBazaar/multiwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenBazaar/multiwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenBazaar/multiwallet/labels{/name}","releases_url":"https://api.github.com/repos/OpenBazaar/multiwallet/releases{/id}","deployments_url":"https://api.github.com/repos/OpenBazaar/multiwallet/deployments","created_at":"2018-02-03T00:47:41Z","updated_at":"2019-08-12T12:40:52Z","pushed_at":"2019-08-12T21:00:06Z","git_url":"git://github.com/OpenBazaar/multiwallet.git","ssh_url":"git@github.com:OpenBazaar/multiwallet.git","clone_url":"https://github.com/OpenBazaar/multiwallet.git","svn_url":"https://github.com/OpenBazaar/multiwallet","homepage":"","size":692,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":23,"open_issues":18,"watchers":34,"default_branch":"master"}},"base":{"label":"OpenBazaar:master","ref":"master","sha":"ad30cd2b391bd3c0e06ac858cac585c076074473","user":{"login":"OpenBazaar","id":7438770,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzg3NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/7438770?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"repo":{"id":120046823,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwNDY4MjM=","name":"multiwallet","full_name":"OpenBazaar/multiwallet","private":false,"owner":{"login":"OpenBazaar","id":7438770,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzg3NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/7438770?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenBazaar/multiwallet","description":"API based multi-cryptocurrency wallet","fork":false,"url":"https://api.github.com/repos/OpenBazaar/multiwallet","forks_url":"https://api.github.com/repos/OpenBazaar/multiwallet/forks","keys_url":"https://api.github.com/repos/OpenBazaar/multiwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenBazaar/multiwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenBazaar/multiwallet/teams","hooks_url":"https://api.github.com/repos/OpenBazaar/multiwallet/hooks","issue_events_url":"https://api.github.com/repos/OpenBazaar/multiwallet/issues/events{/number}","events_url":"https://api.github.com/repos/OpenBazaar/multiwallet/events","assignees_url":"https://api.github.com/repos/OpenBazaar/multiwallet/assignees{/user}","branches_url":"https://api.github.com/repos/OpenBazaar/multiwallet/branches{/branch}","tags_url":"https://api.github.com/repos/OpenBazaar/multiwallet/tags","blobs_url":"https://api.github.com/repos/OpenBazaar/multiwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenBazaar/multiwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenBazaar/multiwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenBazaar/multiwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenBazaar/multiwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenBazaar/multiwallet/languages","stargazers_url":"https://api.github.com/repos/OpenBazaar/multiwallet/stargazers","contributors_url":"https://api.github.com/repos/OpenBazaar/multiwallet/contributors","subscribers_url":"https://api.github.com/repos/OpenBazaar/multiwallet/subscribers","subscription_url":"https://api.github.com/repos/OpenBazaar/multiwallet/subscription","commits_url":"https://api.github.com/repos/OpenBazaar/multiwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenBazaar/multiwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenBazaar/multiwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenBazaar/multiwallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenBazaar/multiwallet/contents/{+path}","compare_url":"https://api.github.com/repos/OpenBazaar/multiwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenBazaar/multiwallet/merges","archive_url":"https://api.github.com/repos/OpenBazaar/multiwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenBazaar/multiwallet/downloads","issues_url":"https://api.github.com/repos/OpenBazaar/multiwallet/issues{/number}","pulls_url":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenBazaar/multiwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenBazaar/multiwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenBazaar/multiwallet/labels{/name}","releases_url":"https://api.github.com/repos/OpenBazaar/multiwallet/releases{/id}","deployments_url":"https://api.github.com/repos/OpenBazaar/multiwallet/deployments","created_at":"2018-02-03T00:47:41Z","updated_at":"2019-08-12T12:40:52Z","pushed_at":"2019-08-12T21:00:06Z","git_url":"git://github.com/OpenBazaar/multiwallet.git","ssh_url":"git@github.com:OpenBazaar/multiwallet.git","clone_url":"https://github.com/OpenBazaar/multiwallet.git","svn_url":"https://github.com/OpenBazaar/multiwallet","homepage":"","size":692,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":23,"open_issues":18,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/97"},"html":{"href":"https://github.com/OpenBazaar/multiwallet/pull/97"},"issue":{"href":"https://api.github.com/repos/OpenBazaar/multiwallet/issues/97"},"comments":{"href":"https://api.github.com/repos/OpenBazaar/multiwallet/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenBazaar/multiwallet/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/OpenBazaar/multiwallet/statuses/c4b574223d0fc03ef14395affb51463ddeb6a932"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"placer14"}}