{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/legraphista/node-server-screenshot/pulls/17","id":329852451,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5ODUyNDUx","html_url":"https://github.com/legraphista/node-server-screenshot/pull/17","diff_url":"https://github.com/legraphista/node-server-screenshot/pull/17.diff","patch_url":"https://github.com/legraphista/node-server-screenshot/pull/17.patch","issue_url":"https://api.github.com/repos/legraphista/node-server-screenshot/issues/17","number":17,"state":"closed","locked":false,"title":"Allow screenshots for pages with forced JS redirections #16","user":{"login":"TahaBoulehmi","id":8948331,"node_id":"MDQ6VXNlcjg5NDgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/8948331?v=4","gravatar_id":"","url":"https://api.github.com/users/TahaBoulehmi","html_url":"https://github.com/TahaBoulehmi","followers_url":"https://api.github.com/users/TahaBoulehmi/followers","following_url":"https://api.github.com/users/TahaBoulehmi/following{/other_user}","gists_url":"https://api.github.com/users/TahaBoulehmi/gists{/gist_id}","starred_url":"https://api.github.com/users/TahaBoulehmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TahaBoulehmi/subscriptions","organizations_url":"https://api.github.com/users/TahaBoulehmi/orgs","repos_url":"https://api.github.com/users/TahaBoulehmi/repos","events_url":"https://api.github.com/users/TahaBoulehmi/events{/privacy}","received_events_url":"https://api.github.com/users/TahaBoulehmi/received_events","type":"User","site_admin":false},"body":"#16  This a fix for Nightmare JS to allow making screenshots when the website forces a JavaScript redirection\r\nThe solution is simple:\r\n\r\n1. ignore-certificate-errors\r\n2. whenever the error is caught, we're just forcing it to continue anyway:\r\n```javascript\r\n.catch(function (err) { return n.screenshot().then().catch(); });\r\n```\r\n3. Executing `n.end();` when everything is finished:\r\n```javascript\r\n.catch(function (err) { .... }).finally(() => { return n.end() });\r\n```","created_at":"2019-10-18T17:31:24Z","updated_at":"2019-10-22T13:18:48Z","closed_at":"2019-10-22T13:18:48Z","merged_at":"2019-10-22T13:18:48Z","merge_commit_sha":"41813eda8e293a4d0c6b9b22c834d0ea32475e03","assignee":null,"assignees":[],"requested_reviewers":[{"login":"legraphista","id":962643,"node_id":"MDQ6VXNlcjk2MjY0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/962643?v=4","gravatar_id":"","url":"https://api.github.com/users/legraphista","html_url":"https://github.com/legraphista","followers_url":"https://api.github.com/users/legraphista/followers","following_url":"https://api.github.com/users/legraphista/following{/other_user}","gists_url":"https://api.github.com/users/legraphista/gists{/gist_id}","starred_url":"https://api.github.com/users/legraphista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legraphista/subscriptions","organizations_url":"https://api.github.com/users/legraphista/orgs","repos_url":"https://api.github.com/users/legraphista/repos","events_url":"https://api.github.com/users/legraphista/events{/privacy}","received_events_url":"https://api.github.com/users/legraphista/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":326982269,"node_id":"MDU6TGFiZWwzMjY5ODIyNjk=","url":"https://api.github.com/repos/legraphista/node-server-screenshot/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/legraphista/node-server-screenshot/pulls/17/commits","review_comments_url":"https://api.github.com/repos/legraphista/node-server-screenshot/pulls/17/comments","review_comment_url":"https://api.github.com/repos/legraphista/node-server-screenshot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/legraphista/node-server-screenshot/issues/17/comments","statuses_url":"https://api.github.com/repos/legraphista/node-server-screenshot/statuses/6132b8e4cf8965e369200115111e59fd27d1cc00","head":{"label":"TahaBoulehmi:patch-1","ref":"patch-1","sha":"6132b8e4cf8965e369200115111e59fd27d1cc00","user":{"login":"TahaBoulehmi","id":8948331,"node_id":"MDQ6VXNlcjg5NDgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/8948331?v=4","gravatar_id":"","url":"https://api.github.com/users/TahaBoulehmi","html_url":"https://github.com/TahaBoulehmi","followers_url":"https://api.github.com/users/TahaBoulehmi/followers","following_url":"https://api.github.com/users/TahaBoulehmi/following{/other_user}","gists_url":"https://api.github.com/users/TahaBoulehmi/gists{/gist_id}","starred_url":"https://api.github.com/users/TahaBoulehmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TahaBoulehmi/subscriptions","organizations_url":"https://api.github.com/users/TahaBoulehmi/orgs","repos_url":"https://api.github.com/users/TahaBoulehmi/repos","events_url":"https://api.github.com/users/TahaBoulehmi/events{/privacy}","received_events_url":"https://api.github.com/users/TahaBoulehmi/received_events","type":"User","site_admin":false},"repo":{"id":216054808,"node_id":"MDEwOlJlcG9zaXRvcnkyMTYwNTQ4MDg=","name":"node-server-screenshot","full_name":"TahaBoulehmi/node-server-screenshot","private":false,"owner":{"login":"TahaBoulehmi","id":8948331,"node_id":"MDQ6VXNlcjg5NDgzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/8948331?v=4","gravatar_id":"","url":"https://api.github.com/users/TahaBoulehmi","html_url":"https://github.com/TahaBoulehmi","followers_url":"https://api.github.com/users/TahaBoulehmi/followers","following_url":"https://api.github.com/users/TahaBoulehmi/following{/other_user}","gists_url":"https://api.github.com/users/TahaBoulehmi/gists{/gist_id}","starred_url":"https://api.github.com/users/TahaBoulehmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TahaBoulehmi/subscriptions","organizations_url":"https://api.github.com/users/TahaBoulehmi/orgs","repos_url":"https://api.github.com/users/TahaBoulehmi/repos","events_url":"https://api.github.com/users/TahaBoulehmi/events{/privacy}","received_events_url":"https://api.github.com/users/TahaBoulehmi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TahaBoulehmi/node-server-screenshot","description":"a server-side nodeJs component that takes screenshots ","fork":true,"url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot","forks_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/forks","keys_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/teams","hooks_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/hooks","issue_events_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/issues/events{/number}","events_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/events","assignees_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/assignees{/user}","branches_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/branches{/branch}","tags_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/tags","blobs_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/git/refs{/sha}","trees_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/statuses/{sha}","languages_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/languages","stargazers_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/stargazers","contributors_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/contributors","subscribers_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/subscribers","subscription_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/subscription","commits_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/commits{/sha}","git_commits_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/git/commits{/sha}","comments_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/comments{/number}","issue_comment_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/issues/comments{/number}","contents_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/contents/{+path}","compare_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/merges","archive_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/downloads","issues_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/issues{/number}","pulls_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/pulls{/number}","milestones_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/milestones{/number}","notifications_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/labels{/name}","releases_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/releases{/id}","deployments_url":"https://api.github.com/repos/TahaBoulehmi/node-server-screenshot/deployments","created_at":"2019-10-18T15:29:37Z","updated_at":"2019-10-18T15:29:38Z","pushed_at":"2019-10-18T17:23:40Z","git_url":"git://github.com/TahaBoulehmi/node-server-screenshot.git","ssh_url":"git@github.com:TahaBoulehmi/node-server-screenshot.git","clone_url":"https://github.com/TahaBoulehmi/node-server-screenshot.git","svn_url":"https://github.com/TahaBoulehmi/node-server-screenshot","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"legraphista:master","ref":"master","sha":"67ace1984acfef595b369ae3e9ab095fc58b3197","user":{"login":"legraphista","id":962643,"node_id":"MDQ6VXNlcjk2MjY0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/962643?v=4","gravatar_id":"","url":"https://api.github.com/users/legraphista","html_url":"https://github.com/legraphista","followers_url":"https://api.github.com/users/legraphista/followers","following_url":"https://api.github.com/users/legraphista/following{/other_user}","gists_url":"https://api.github.com/users/legraphista/gists{/gist_id}","starred_url":"https://api.github.com/users/legraphista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legraphista/subscriptions","organizations_url":"https://api.github.com/users/legraphista/orgs","repos_url":"https://api.github.com/users/legraphista/repos","events_url":"https://api.github.com/users/legraphista/events{/privacy}","received_events_url":"https://api.github.com/users/legraphista/received_events","type":"User","site_admin":false},"repo":{"id":51843061,"node_id":"MDEwOlJlcG9zaXRvcnk1MTg0MzA2MQ==","name":"node-server-screenshot","full_name":"legraphista/node-server-screenshot","private":false,"owner":{"login":"legraphista","id":962643,"node_id":"MDQ6VXNlcjk2MjY0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/962643?v=4","gravatar_id":"","url":"https://api.github.com/users/legraphista","html_url":"https://github.com/legraphista","followers_url":"https://api.github.com/users/legraphista/followers","following_url":"https://api.github.com/users/legraphista/following{/other_user}","gists_url":"https://api.github.com/users/legraphista/gists{/gist_id}","starred_url":"https://api.github.com/users/legraphista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legraphista/subscriptions","organizations_url":"https://api.github.com/users/legraphista/orgs","repos_url":"https://api.github.com/users/legraphista/repos","events_url":"https://api.github.com/users/legraphista/events{/privacy}","received_events_url":"https://api.github.com/users/legraphista/received_events","type":"User","site_admin":false},"html_url":"https://github.com/legraphista/node-server-screenshot","description":"a server-side nodeJs component that takes screenshots ","fork":false,"url":"https://api.github.com/repos/legraphista/node-server-screenshot","forks_url":"https://api.github.com/repos/legraphista/node-server-screenshot/forks","keys_url":"https://api.github.com/repos/legraphista/node-server-screenshot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legraphista/node-server-screenshot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legraphista/node-server-screenshot/teams","hooks_url":"https://api.github.com/repos/legraphista/node-server-screenshot/hooks","issue_events_url":"https://api.github.com/repos/legraphista/node-server-screenshot/issues/events{/number}","events_url":"https://api.github.com/repos/legraphista/node-server-screenshot/events","assignees_url":"https://api.github.com/repos/legraphista/node-server-screenshot/assignees{/user}","branches_url":"https://api.github.com/repos/legraphista/node-server-screenshot/branches{/branch}","tags_url":"https://api.github.com/repos/legraphista/node-server-screenshot/tags","blobs_url":"https://api.github.com/repos/legraphista/node-server-screenshot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legraphista/node-server-screenshot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legraphista/node-server-screenshot/git/refs{/sha}","trees_url":"https://api.github.com/repos/legraphista/node-server-screenshot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legraphista/node-server-screenshot/statuses/{sha}","languages_url":"https://api.github.com/repos/legraphista/node-server-screenshot/languages","stargazers_url":"https://api.github.com/repos/legraphista/node-server-screenshot/stargazers","contributors_url":"https://api.github.com/repos/legraphista/node-server-screenshot/contributors","subscribers_url":"https://api.github.com/repos/legraphista/node-server-screenshot/subscribers","subscription_url":"https://api.github.com/repos/legraphista/node-server-screenshot/subscription","commits_url":"https://api.github.com/repos/legraphista/node-server-screenshot/commits{/sha}","git_commits_url":"https://api.github.com/repos/legraphista/node-server-screenshot/git/commits{/sha}","comments_url":"https://api.github.com/repos/legraphista/node-server-screenshot/comments{/number}","issue_comment_url":"https://api.github.com/repos/legraphista/node-server-screenshot/issues/comments{/number}","contents_url":"https://api.github.com/repos/legraphista/node-server-screenshot/contents/{+path}","compare_url":"https://api.github.com/repos/legraphista/node-server-screenshot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legraphista/node-server-screenshot/merges","archive_url":"https://api.github.com/repos/legraphista/node-server-screenshot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legraphista/node-server-screenshot/downloads","issues_url":"https://api.github.com/repos/legraphista/node-server-screenshot/issues{/number}","pulls_url":"https://api.github.com/repos/legraphista/node-server-screenshot/pulls{/number}","milestones_url":"https://api.github.com/repos/legraphista/node-server-screenshot/milestones{/number}","notifications_url":"https://api.github.com/repos/legraphista/node-server-screenshot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legraphista/node-server-screenshot/labels{/name}","releases_url":"https://api.github.com/repos/legraphista/node-server-screenshot/releases{/id}","deployments_url":"https://api.github.com/repos/legraphista/node-server-screenshot/deployments","created_at":"2016-02-16T14:40:11Z","updated_at":"2019-09-24T03:59:16Z","pushed_at":"2019-10-22T13:18:48Z","git_url":"git://github.com/legraphista/node-server-screenshot.git","ssh_url":"git@github.com:legraphista/node-server-screenshot.git","clone_url":"https://github.com/legraphista/node-server-screenshot.git","svn_url":"https://github.com/legraphista/node-server-screenshot","homepage":null,"size":58,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":5,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/legraphista/node-server-screenshot/pulls/17"},"html":{"href":"https://github.com/legraphista/node-server-screenshot/pull/17"},"issue":{"href":"https://api.github.com/repos/legraphista/node-server-screenshot/issues/17"},"comments":{"href":"https://api.github.com/repos/legraphista/node-server-screenshot/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/legraphista/node-server-screenshot/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/legraphista/node-server-screenshot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/legraphista/node-server-screenshot/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/legraphista/node-server-screenshot/statuses/6132b8e4cf8965e369200115111e59fd27d1cc00"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"legraphista","id":962643,"node_id":"MDQ6VXNlcjk2MjY0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/962643?v=4","gravatar_id":"","url":"https://api.github.com/users/legraphista","html_url":"https://github.com/legraphista","followers_url":"https://api.github.com/users/legraphista/followers","following_url":"https://api.github.com/users/legraphista/following{/other_user}","gists_url":"https://api.github.com/users/legraphista/gists{/gist_id}","starred_url":"https://api.github.com/users/legraphista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legraphista/subscriptions","organizations_url":"https://api.github.com/users/legraphista/orgs","repos_url":"https://api.github.com/users/legraphista/repos","events_url":"https://api.github.com/users/legraphista/events{/privacy}","received_events_url":"https://api.github.com/users/legraphista/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":45,"deletions":38,"changed_files":1}}
{"actor":{"display_login":"legraphista"}}