{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/17075","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/17075/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/17075/comments","events_url":"https://api.github.com/repos/helm/charts/issues/17075/events","html_url":"https://github.com/helm/charts/issues/17075","id":492305467,"node_id":"MDU6SXNzdWU0OTIzMDU0Njc=","number":17075,"title":"[stable/minio] allow to enable compat mode in settings","user":{"login":"thewilli","id":1206639,"node_id":"MDQ6VXNlcjEyMDY2Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1206639?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilli","html_url":"https://github.com/thewilli","followers_url":"https://api.github.com/users/thewilli/followers","following_url":"https://api.github.com/users/thewilli/following{/other_user}","gists_url":"https://api.github.com/users/thewilli/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilli/subscriptions","organizations_url":"https://api.github.com/users/thewilli/orgs","repos_url":"https://api.github.com/users/thewilli/repos","events_url":"https://api.github.com/users/thewilli/events{/privacy}","received_events_url":"https://api.github.com/users/thewilli/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2019-09-11T15:19:22Z","updated_at":"2020-01-13T11:03:51Z","closed_at":"2019-09-19T12:27:01Z","author_association":"CONTRIBUTOR","body":"**Is your feature request related to a problem? Please describe.**\r\n\r\nI am using Minio to (amongst other use-cases) store data of the [GitLab Helm Chart](https://docs.gitlab.com/charts/) components. GitLab - as of now - [relies](https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/398) on the `--compat` option of Minio, but I can neither directly enable that option in the Chart, nor can I inject additional CLI arguments.\r\n\r\nBecause of the missing configuration options, I have to manually patch the Deployment / Daemonset of the Helm Chart, which prevents me from doing simple updates.\r\n\r\n**Describe the solution you'd like**\r\n\r\nExtend the Minio Chart to either enable the compat mode as a setting or to inject additional CLI arguments for the [standalone](https://github.com/helm/charts/blob/a62d32a/stable/minio/templates/deployment.yaml#L63-L89) and [distributed](https://github.com/helm/charts/blob/a62d32a/stable/minio/templates/statefulset.yaml#L63-L75) setup.\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/573610120","html_url":"https://github.com/helm/charts/issues/17075#issuecomment-573610120","issue_url":"https://api.github.com/repos/helm/charts/issues/17075","id":573610120,"node_id":"MDEyOklzc3VlQ29tbWVudDU3MzYxMDEyMA==","user":{"login":"hutr","id":6513743,"node_id":"MDQ6VXNlcjY1MTM3NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/6513743?v=4","gravatar_id":"","url":"https://api.github.com/users/hutr","html_url":"https://github.com/hutr","followers_url":"https://api.github.com/users/hutr/followers","following_url":"https://api.github.com/users/hutr/following{/other_user}","gists_url":"https://api.github.com/users/hutr/gists{/gist_id}","starred_url":"https://api.github.com/users/hutr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hutr/subscriptions","organizations_url":"https://api.github.com/users/hutr/orgs","repos_url":"https://api.github.com/users/hutr/repos","events_url":"https://api.github.com/users/hutr/events{/privacy}","received_events_url":"https://api.github.com/users/hutr/received_events","type":"User","site_admin":false},"created_at":"2020-01-13T11:03:51Z","updated_at":"2020-01-13T11:03:51Z","author_association":"NONE","body":"Thanks for the PR @thewilli . I tested with chart version 5.0.4 and the issue still persist.\r\nEven though the argument exists in the deployment and pod (e.g. kubectl describe), but when exec'ing into the pod one can see that the the argument is missing.    \r\n\r\n`$ helm install --set extraArgs=\"{--compat}\" stable/minio\r\n`\r\n\r\n```\r\n$ kubectl describe pod minio-6d5bd7789-7cbd2\r\n\r\n...\r\nCommand:\r\n      /bin/sh\r\n      -ce\r\n      /usr/bin/docker-entrypoint.sh minio -S /etc/minio/certs/ server /export\r\n      --compat\r\n...\r\n```\r\n```\r\n$ kubectl exec -it minio-6d5bd7789-7cbd2 sh\r\n\r\n/ # ps\r\nPID   USER     TIME  COMMAND\r\n    1 root      0:06 minio -S /etc/minio/certs/ server /export\r\n\r\n```\r\n\r\nI am working on a PR and hopefully it's ready by the end of the day."}}
{"actor":{"display_login":"hutr"}}