{"action":"created","issue":{"url":"https://api.github.com/repos/voila-dashboards/voila/issues/413","repository_url":"https://api.github.com/repos/voila-dashboards/voila","labels_url":"https://api.github.com/repos/voila-dashboards/voila/issues/413/labels{/name}","comments_url":"https://api.github.com/repos/voila-dashboards/voila/issues/413/comments","events_url":"https://api.github.com/repos/voila-dashboards/voila/issues/413/events","html_url":"https://github.com/voila-dashboards/voila/pull/413","id":505239873,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2NzExMDAw","number":413,"title":"Expose base_url to browser-open template","user":{"login":"martinRenou","id":21197331,"node_id":"MDQ6VXNlcjIxMTk3MzMx","avatar_url":"https://avatars0.githubusercontent.com/u/21197331?v=4","gravatar_id":"","url":"https://api.github.com/users/martinRenou","html_url":"https://github.com/martinRenou","followers_url":"https://api.github.com/users/martinRenou/followers","following_url":"https://api.github.com/users/martinRenou/following{/other_user}","gists_url":"https://api.github.com/users/martinRenou/gists{/gist_id}","starred_url":"https://api.github.com/users/martinRenou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinRenou/subscriptions","organizations_url":"https://api.github.com/users/martinRenou/orgs","repos_url":"https://api.github.com/users/martinRenou/repos","events_url":"https://api.github.com/users/martinRenou/events{/privacy}","received_events_url":"https://api.github.com/users/martinRenou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2019-10-10T12:32:23Z","updated_at":"2019-10-11T09:09:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/voila-dashboards/voila/pulls/413","html_url":"https://github.com/voila-dashboards/voila/pull/413","diff_url":"https://github.com/voila-dashboards/voila/pull/413.diff","patch_url":"https://github.com/voila-dashboards/voila/pull/413.patch"},"body":"This is for homogeneity with other template files under the \"templates/\" directory. It allows having the same base template accessing the same assets under the static directory.\r\n\r\nFor example, when having a `base.html` file like this:\r\n```html\r\n<!DOCTYPE html>\r\n<html>\r\n  <head>\r\n    <link rel=\"stylesheet\" href=\"{{base_url}}voila/static/style.min.css\">\r\n  </head>\r\n\r\n  <body>\r\n    {% block body %}\r\n    {% endblock %}\r\n    \r\n    <script src=\"{{base_url}}voila/static/javascript.min.js\"></script>\r\n  </body>\r\n</html>\r\n```\r\n\r\nWe can now make the `browser-open.html` and the `404.html` template inherit from the same `base.html` template.\r\n\r\nThis is backward incompatible for other templates out there."},"comment":{"url":"https://api.github.com/repos/voila-dashboards/voila/issues/comments/540983648","html_url":"https://github.com/voila-dashboards/voila/pull/413#issuecomment-540983648","issue_url":"https://api.github.com/repos/voila-dashboards/voila/issues/413","id":540983648,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MDk4MzY0OA==","user":{"login":"maartenbreddels","id":1765949,"node_id":"MDQ6VXNlcjE3NjU5NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1765949?v=4","gravatar_id":"","url":"https://api.github.com/users/maartenbreddels","html_url":"https://github.com/maartenbreddels","followers_url":"https://api.github.com/users/maartenbreddels/followers","following_url":"https://api.github.com/users/maartenbreddels/following{/other_user}","gists_url":"https://api.github.com/users/maartenbreddels/gists{/gist_id}","starred_url":"https://api.github.com/users/maartenbreddels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maartenbreddels/subscriptions","organizations_url":"https://api.github.com/users/maartenbreddels/orgs","repos_url":"https://api.github.com/users/maartenbreddels/repos","events_url":"https://api.github.com/users/maartenbreddels/events{/privacy}","received_events_url":"https://api.github.com/users/maartenbreddels/received_events","type":"User","site_admin":false},"created_at":"2019-10-11T09:09:12Z","updated_at":"2019-10-11T09:09:12Z","author_association":"MEMBER","body":"I think all templates should have base_url exposed anyway, which would make them more uniform."}}
{"actor":{"display_login":"maartenbreddels"}}