{"action":"created","comment":{"url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/comments/334012821","pull_request_review_id":300714661,"id":334012821,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDAxMjgyMQ==","diff_hunk":"@@ -0,0 +1,93 @@\n+syntax = \"proto2\";\n+\n+package protos.soc;\n+\n+import \"soc/inventory.proto\";\n+import \"soc/board.proto\";\n+import \"soc/state.proto\";\n+\n+enum MoveType {\n+    ROLL_DICE = 0;\n+    END_TURN = 1;\n+    INITIAL_PLACEMENT = 2;\n+    DISCARD_RESOURCES = 3;\n+    MOVE_ROBBER_AND_STEAL = 4;\n+    BUY_DEVELOPMENT_CARD = 5;\n+    BUILD_ROAD = 6;\n+    BUILD_SETTLEMENT = 7;\n+    BUILD_CITY = 8;\n+    PORT_TRADE = 9;\n+    PLAY_KNIGHT = 10;\n+    PLAY_YEAR_OF_PLENTY = 11;\n+    PLAY_MONOPOLY = 12;\n+    PLAY_ROAD_BUILDER = 13;\n+}\n+\n+message SOCMove {\n+    required MoveType type = 1;\n+    oneof payload {\n+        InitialPlacement initial_placement_payload = 2;\n+        DiscardResources discard_resources_payload = 3;\n+        MoveRobberAndSteal move_robber_and_steal_payload = 4;\n+        BuildRoad build_road_payload = 5;\n+        BuildSettlement build_settlement_payload = 6;\n+        BuildCity build_city_payload = 7;\n+        PortTrade port_trade_payload = 8;\n+        MoveRobberAndSteal play_knight_payload = 9;\n+        PlayYearOfPlenty play_year_of_plenty_payload = 10;\n+        PlayMonopoly play_monopoly_payload = 11;\n+        PlayRoadBuilder play_road_builder_payload = 12;\n+    }\n+}\n+\n+message RollDice {}\n+message EndTurn {}\n+\n+message InitialPlacement {\n+    required Vertex settlement = 1;\n+    required Edge road = 2;\n+    required bool first_placement = 3;","path":"src/main/protobuf/soc/moves.proto","position":49,"original_position":49,"commit_id":"4b5c0511886236ad78c90e369bcb5e643921a8ed","original_commit_id":"4b5c0511886236ad78c90e369bcb5e643921a8ed","user":{"login":"danielglasgow","id":8742154,"node_id":"MDQ6VXNlcjg3NDIxNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8742154?v=4","gravatar_id":"","url":"https://api.github.com/users/danielglasgow","html_url":"https://github.com/danielglasgow","followers_url":"https://api.github.com/users/danielglasgow/followers","following_url":"https://api.github.com/users/danielglasgow/following{/other_user}","gists_url":"https://api.github.com/users/danielglasgow/gists{/gist_id}","starred_url":"https://api.github.com/users/danielglasgow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielglasgow/subscriptions","organizations_url":"https://api.github.com/users/danielglasgow/orgs","repos_url":"https://api.github.com/users/danielglasgow/repos","events_url":"https://api.github.com/users/danielglasgow/events{/privacy}","received_events_url":"https://api.github.com/users/danielglasgow/received_events","type":"User","site_admin":false},"body":"Why do we need first placement? The client is just responding saying where it wants to put a settlement. The server should already know if its a first placement or not. ","created_at":"2019-10-11T14:15:05Z","updated_at":"2019-10-11T14:15:06Z","html_url":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6#discussion_r334012821","pull_request_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/comments/334012821"},"html":{"href":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6#discussion_r334012821"},"pull_request":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6","id":325870098,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1ODcwMDk4","html_url":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6","diff_url":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6.diff","patch_url":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6.patch","issue_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/6","number":6,"state":"open","locked":false,"title":"Adding proto support for moves","user":{"login":"grogdotcom","id":33365105,"node_id":"MDQ6VXNlcjMzMzY1MTA1","avatar_url":"https://avatars0.githubusercontent.com/u/33365105?v=4","gravatar_id":"","url":"https://api.github.com/users/grogdotcom","html_url":"https://github.com/grogdotcom","followers_url":"https://api.github.com/users/grogdotcom/followers","following_url":"https://api.github.com/users/grogdotcom/following{/other_user}","gists_url":"https://api.github.com/users/grogdotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/grogdotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grogdotcom/subscriptions","organizations_url":"https://api.github.com/users/grogdotcom/orgs","repos_url":"https://api.github.com/users/grogdotcom/repos","events_url":"https://api.github.com/users/grogdotcom/events{/privacy}","received_events_url":"https://api.github.com/users/grogdotcom/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-08T17:00:36Z","updated_at":"2019-10-11T14:15:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c70b50a392679062aafaaf63e12c41e5f56502f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6/commits","review_comments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6/comments","review_comment_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/6/comments","statuses_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/statuses/4b5c0511886236ad78c90e369bcb5e643921a8ed","head":{"label":"SOC-Training-Tool:move_proto","ref":"move_proto","sha":"4b5c0511886236ad78c90e369bcb5e643921a8ed","user":{"login":"SOC-Training-Tool","id":55442794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDQyNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/55442794?v=4","gravatar_id":"","url":"https://api.github.com/users/SOC-Training-Tool","html_url":"https://github.com/SOC-Training-Tool","followers_url":"https://api.github.com/users/SOC-Training-Tool/followers","following_url":"https://api.github.com/users/SOC-Training-Tool/following{/other_user}","gists_url":"https://api.github.com/users/SOC-Training-Tool/gists{/gist_id}","starred_url":"https://api.github.com/users/SOC-Training-Tool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SOC-Training-Tool/subscriptions","organizations_url":"https://api.github.com/users/SOC-Training-Tool/orgs","repos_url":"https://api.github.com/users/SOC-Training-Tool/repos","events_url":"https://api.github.com/users/SOC-Training-Tool/events{/privacy}","received_events_url":"https://api.github.com/users/SOC-Training-Tool/received_events","type":"Organization","site_admin":false},"repo":{"id":209044358,"node_id":"MDEwOlJlcG9zaXRvcnkyMDkwNDQzNTg=","name":"ImmutableSOC","full_name":"SOC-Training-Tool/ImmutableSOC","private":false,"owner":{"login":"SOC-Training-Tool","id":55442794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDQyNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/55442794?v=4","gravatar_id":"","url":"https://api.github.com/users/SOC-Training-Tool","html_url":"https://github.com/SOC-Training-Tool","followers_url":"https://api.github.com/users/SOC-Training-Tool/followers","following_url":"https://api.github.com/users/SOC-Training-Tool/following{/other_user}","gists_url":"https://api.github.com/users/SOC-Training-Tool/gists{/gist_id}","starred_url":"https://api.github.com/users/SOC-Training-Tool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SOC-Training-Tool/subscriptions","organizations_url":"https://api.github.com/users/SOC-Training-Tool/orgs","repos_url":"https://api.github.com/users/SOC-Training-Tool/repos","events_url":"https://api.github.com/users/SOC-Training-Tool/events{/privacy}","received_events_url":"https://api.github.com/users/SOC-Training-Tool/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SOC-Training-Tool/ImmutableSOC","description":null,"fork":false,"url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC","forks_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/forks","keys_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/teams","hooks_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/hooks","issue_events_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/events{/number}","events_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/events","assignees_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/assignees{/user}","branches_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/branches{/branch}","tags_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/tags","blobs_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/statuses/{sha}","languages_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/languages","stargazers_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/stargazers","contributors_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/contributors","subscribers_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/subscribers","subscription_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/subscription","commits_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/contents/{+path}","compare_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/merges","archive_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/downloads","issues_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues{/number}","pulls_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls{/number}","milestones_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/milestones{/number}","notifications_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/labels{/name}","releases_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/releases{/id}","deployments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/deployments","created_at":"2019-09-17T12:12:02Z","updated_at":"2019-10-07T15:44:13Z","pushed_at":"2019-10-08T17:00:36Z","git_url":"git://github.com/SOC-Training-Tool/ImmutableSOC.git","ssh_url":"git@github.com:SOC-Training-Tool/ImmutableSOC.git","clone_url":"https://github.com/SOC-Training-Tool/ImmutableSOC.git","svn_url":"https://github.com/SOC-Training-Tool/ImmutableSOC","homepage":null,"size":144,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SOC-Training-Tool:master","ref":"master","sha":"08df24f84c798d326347fede274a9ed7d1c9ea41","user":{"login":"SOC-Training-Tool","id":55442794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDQyNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/55442794?v=4","gravatar_id":"","url":"https://api.github.com/users/SOC-Training-Tool","html_url":"https://github.com/SOC-Training-Tool","followers_url":"https://api.github.com/users/SOC-Training-Tool/followers","following_url":"https://api.github.com/users/SOC-Training-Tool/following{/other_user}","gists_url":"https://api.github.com/users/SOC-Training-Tool/gists{/gist_id}","starred_url":"https://api.github.com/users/SOC-Training-Tool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SOC-Training-Tool/subscriptions","organizations_url":"https://api.github.com/users/SOC-Training-Tool/orgs","repos_url":"https://api.github.com/users/SOC-Training-Tool/repos","events_url":"https://api.github.com/users/SOC-Training-Tool/events{/privacy}","received_events_url":"https://api.github.com/users/SOC-Training-Tool/received_events","type":"Organization","site_admin":false},"repo":{"id":209044358,"node_id":"MDEwOlJlcG9zaXRvcnkyMDkwNDQzNTg=","name":"ImmutableSOC","full_name":"SOC-Training-Tool/ImmutableSOC","private":false,"owner":{"login":"SOC-Training-Tool","id":55442794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDQyNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/55442794?v=4","gravatar_id":"","url":"https://api.github.com/users/SOC-Training-Tool","html_url":"https://github.com/SOC-Training-Tool","followers_url":"https://api.github.com/users/SOC-Training-Tool/followers","following_url":"https://api.github.com/users/SOC-Training-Tool/following{/other_user}","gists_url":"https://api.github.com/users/SOC-Training-Tool/gists{/gist_id}","starred_url":"https://api.github.com/users/SOC-Training-Tool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SOC-Training-Tool/subscriptions","organizations_url":"https://api.github.com/users/SOC-Training-Tool/orgs","repos_url":"https://api.github.com/users/SOC-Training-Tool/repos","events_url":"https://api.github.com/users/SOC-Training-Tool/events{/privacy}","received_events_url":"https://api.github.com/users/SOC-Training-Tool/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SOC-Training-Tool/ImmutableSOC","description":null,"fork":false,"url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC","forks_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/forks","keys_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/teams","hooks_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/hooks","issue_events_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/events{/number}","events_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/events","assignees_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/assignees{/user}","branches_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/branches{/branch}","tags_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/tags","blobs_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/statuses/{sha}","languages_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/languages","stargazers_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/stargazers","contributors_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/contributors","subscribers_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/subscribers","subscription_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/subscription","commits_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/contents/{+path}","compare_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/merges","archive_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/downloads","issues_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues{/number}","pulls_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls{/number}","milestones_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/milestones{/number}","notifications_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/labels{/name}","releases_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/releases{/id}","deployments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/deployments","created_at":"2019-09-17T12:12:02Z","updated_at":"2019-10-07T15:44:13Z","pushed_at":"2019-10-08T17:00:36Z","git_url":"git://github.com/SOC-Training-Tool/ImmutableSOC.git","ssh_url":"git@github.com:SOC-Training-Tool/ImmutableSOC.git","clone_url":"https://github.com/SOC-Training-Tool/ImmutableSOC.git","svn_url":"https://github.com/SOC-Training-Tool/ImmutableSOC","homepage":null,"size":144,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6"},"html":{"href":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6"},"issue":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/6"},"comments":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/statuses/4b5c0511886236ad78c90e369bcb5e643921a8ed"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"danielglasgow"}}