{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/comments/363414624","pull_request_review_id":338804899,"id":363414624,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MzQxNDYyNA==","diff_hunk":"@@ -398,8 +398,13 @@ static int hda_dsp_set_D0_state(struct snd_sof_dev *sdev,\n \tif (target_state->substate == SOF_HDA_DSP_D0I3) {\n \t\tvalue = SOF_HDA_VS_D0I3C_I3;\n \n-\t\t/* disable DMA trace in D0I3 */\n-\t\tflags = HDA_PM_NO_DMA_TRACE;\n+\t\t/*\n+\t\t * Trace DMA can be kept enabled when the DSP enters\n+\t\t * D0I3 while the system is in S0. It must be disabled\n+\t\t * when the system is suspending to S0IX.","path":"sound/soc/sof/intel/hda-dsp.c","position":78,"original_position":9,"commit_id":"d5b498e40a00535f94d8cb8dcc6910f4b7345c12","original_commit_id":"d5b498e40a00535f94d8cb8dcc6910f4b7345c12","user":{"login":"ranj063","id":7766921,"node_id":"MDQ6VXNlcjc3NjY5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7766921?v=4","gravatar_id":"","url":"https://api.github.com/users/ranj063","html_url":"https://github.com/ranj063","followers_url":"https://api.github.com/users/ranj063/followers","following_url":"https://api.github.com/users/ranj063/following{/other_user}","gists_url":"https://api.github.com/users/ranj063/gists{/gist_id}","starred_url":"https://api.github.com/users/ranj063/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranj063/subscriptions","organizations_url":"https://api.github.com/users/ranj063/orgs","repos_url":"https://api.github.com/users/ranj063/repos","events_url":"https://api.github.com/users/ranj063/events{/privacy}","received_events_url":"https://api.github.com/users/ranj063/received_events","type":"User","site_admin":false},"body":"@plbossart OK, so should I make this configurable in Kconfig?","created_at":"2020-01-06T18:15:15Z","updated_at":"2020-01-06T18:15:16Z","html_url":"https://github.com/thesofproject/linux/pull/1631#discussion_r363414624","pull_request_url":"https://api.github.com/repos/thesofproject/linux/pulls/1631","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments/363414624"},"html":{"href":"https://github.com/thesofproject/linux/pull/1631#discussion_r363414624"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1631"}},"in_reply_to_id":362625974},"pull_request":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/1631","id":353692764,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzNjkyNzY0","html_url":"https://github.com/thesofproject/linux/pull/1631","diff_url":"https://github.com/thesofproject/linux/pull/1631.diff","patch_url":"https://github.com/thesofproject/linux/pull/1631.patch","issue_url":"https://api.github.com/repos/thesofproject/linux/issues/1631","number":1631,"state":"open","locked":false,"title":"S0ix rework","user":{"login":"ranj063","id":7766921,"node_id":"MDQ6VXNlcjc3NjY5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7766921?v=4","gravatar_id":"","url":"https://api.github.com/users/ranj063","html_url":"https://github.com/ranj063","followers_url":"https://api.github.com/users/ranj063/followers","following_url":"https://api.github.com/users/ranj063/following{/other_user}","gists_url":"https://api.github.com/users/ranj063/gists{/gist_id}","starred_url":"https://api.github.com/users/ranj063/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranj063/subscriptions","organizations_url":"https://api.github.com/users/ranj063/orgs","repos_url":"https://api.github.com/users/ranj063/repos","events_url":"https://api.github.com/users/ranj063/events{/privacy}","received_events_url":"https://api.github.com/users/ranj063/received_events","type":"User","site_admin":false},"body":"This PR replaces #1524 ","created_at":"2019-12-16T18:08:15Z","updated_at":"2020-01-06T18:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84f966a38a9c692aaae904bfb1571e072fb745bd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dbaluta","id":62316,"node_id":"MDQ6VXNlcjYyMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/62316?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaluta","html_url":"https://github.com/dbaluta","followers_url":"https://api.github.com/users/dbaluta/followers","following_url":"https://api.github.com/users/dbaluta/following{/other_user}","gists_url":"https://api.github.com/users/dbaluta/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaluta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaluta/subscriptions","organizations_url":"https://api.github.com/users/dbaluta/orgs","repos_url":"https://api.github.com/users/dbaluta/repos","events_url":"https://api.github.com/users/dbaluta/events{/privacy}","received_events_url":"https://api.github.com/users/dbaluta/received_events","type":"User","site_admin":false},{"login":"juimonen","id":1136650,"node_id":"MDQ6VXNlcjExMzY2NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1136650?v=4","gravatar_id":"","url":"https://api.github.com/users/juimonen","html_url":"https://github.com/juimonen","followers_url":"https://api.github.com/users/juimonen/followers","following_url":"https://api.github.com/users/juimonen/following{/other_user}","gists_url":"https://api.github.com/users/juimonen/gists{/gist_id}","starred_url":"https://api.github.com/users/juimonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juimonen/subscriptions","organizations_url":"https://api.github.com/users/juimonen/orgs","repos_url":"https://api.github.com/users/juimonen/repos","events_url":"https://api.github.com/users/juimonen/events{/privacy}","received_events_url":"https://api.github.com/users/juimonen/received_events","type":"User","site_admin":false},{"login":"keyonjie","id":10458135,"node_id":"MDQ6VXNlcjEwNDU4MTM1","avatar_url":"https://avatars1.githubusercontent.com/u/10458135?v=4","gravatar_id":"","url":"https://api.github.com/users/keyonjie","html_url":"https://github.com/keyonjie","followers_url":"https://api.github.com/users/keyonjie/followers","following_url":"https://api.github.com/users/keyonjie/following{/other_user}","gists_url":"https://api.github.com/users/keyonjie/gists{/gist_id}","starred_url":"https://api.github.com/users/keyonjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyonjie/subscriptions","organizations_url":"https://api.github.com/users/keyonjie/orgs","repos_url":"https://api.github.com/users/keyonjie/repos","events_url":"https://api.github.com/users/keyonjie/events{/privacy}","received_events_url":"https://api.github.com/users/keyonjie/received_events","type":"User","site_admin":false},{"login":"lgirdwood","id":12020523,"node_id":"MDQ6VXNlcjEyMDIwNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/12020523?v=4","gravatar_id":"","url":"https://api.github.com/users/lgirdwood","html_url":"https://github.com/lgirdwood","followers_url":"https://api.github.com/users/lgirdwood/followers","following_url":"https://api.github.com/users/lgirdwood/following{/other_user}","gists_url":"https://api.github.com/users/lgirdwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lgirdwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgirdwood/subscriptions","organizations_url":"https://api.github.com/users/lgirdwood/orgs","repos_url":"https://api.github.com/users/lgirdwood/repos","events_url":"https://api.github.com/users/lgirdwood/events{/privacy}","received_events_url":"https://api.github.com/users/lgirdwood/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/linux/pulls/1631/commits","review_comments_url":"https://api.github.com/repos/thesofproject/linux/pulls/1631/comments","review_comment_url":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/linux/issues/1631/comments","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/d5b498e40a00535f94d8cb8dcc6910f4b7345c12","head":{"label":"ranj063:fix/s0ix_work","ref":"fix/s0ix_work","sha":"d5b498e40a00535f94d8cb8dcc6910f4b7345c12","user":{"login":"ranj063","id":7766921,"node_id":"MDQ6VXNlcjc3NjY5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7766921?v=4","gravatar_id":"","url":"https://api.github.com/users/ranj063","html_url":"https://github.com/ranj063","followers_url":"https://api.github.com/users/ranj063/followers","following_url":"https://api.github.com/users/ranj063/following{/other_user}","gists_url":"https://api.github.com/users/ranj063/gists{/gist_id}","starred_url":"https://api.github.com/users/ranj063/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranj063/subscriptions","organizations_url":"https://api.github.com/users/ranj063/orgs","repos_url":"https://api.github.com/users/ranj063/repos","events_url":"https://api.github.com/users/ranj063/events{/privacy}","received_events_url":"https://api.github.com/users/ranj063/received_events","type":"User","site_admin":false},"repo":{"id":138650918,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2NTA5MTg=","name":"linux","full_name":"ranj063/linux","private":false,"owner":{"login":"ranj063","id":7766921,"node_id":"MDQ6VXNlcjc3NjY5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7766921?v=4","gravatar_id":"","url":"https://api.github.com/users/ranj063","html_url":"https://github.com/ranj063","followers_url":"https://api.github.com/users/ranj063/followers","following_url":"https://api.github.com/users/ranj063/following{/other_user}","gists_url":"https://api.github.com/users/ranj063/gists{/gist_id}","starred_url":"https://api.github.com/users/ranj063/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranj063/subscriptions","organizations_url":"https://api.github.com/users/ranj063/orgs","repos_url":"https://api.github.com/users/ranj063/repos","events_url":"https://api.github.com/users/ranj063/events{/privacy}","received_events_url":"https://api.github.com/users/ranj063/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ranj063/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/ranj063/linux","forks_url":"https://api.github.com/repos/ranj063/linux/forks","keys_url":"https://api.github.com/repos/ranj063/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ranj063/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ranj063/linux/teams","hooks_url":"https://api.github.com/repos/ranj063/linux/hooks","issue_events_url":"https://api.github.com/repos/ranj063/linux/issues/events{/number}","events_url":"https://api.github.com/repos/ranj063/linux/events","assignees_url":"https://api.github.com/repos/ranj063/linux/assignees{/user}","branches_url":"https://api.github.com/repos/ranj063/linux/branches{/branch}","tags_url":"https://api.github.com/repos/ranj063/linux/tags","blobs_url":"https://api.github.com/repos/ranj063/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ranj063/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ranj063/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/ranj063/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ranj063/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/ranj063/linux/languages","stargazers_url":"https://api.github.com/repos/ranj063/linux/stargazers","contributors_url":"https://api.github.com/repos/ranj063/linux/contributors","subscribers_url":"https://api.github.com/repos/ranj063/linux/subscribers","subscription_url":"https://api.github.com/repos/ranj063/linux/subscription","commits_url":"https://api.github.com/repos/ranj063/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/ranj063/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/ranj063/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/ranj063/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/ranj063/linux/contents/{+path}","compare_url":"https://api.github.com/repos/ranj063/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ranj063/linux/merges","archive_url":"https://api.github.com/repos/ranj063/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ranj063/linux/downloads","issues_url":"https://api.github.com/repos/ranj063/linux/issues{/number}","pulls_url":"https://api.github.com/repos/ranj063/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/ranj063/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/ranj063/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ranj063/linux/labels{/name}","releases_url":"https://api.github.com/repos/ranj063/linux/releases{/id}","deployments_url":"https://api.github.com/repos/ranj063/linux/deployments","created_at":"2018-06-25T21:14:49Z","updated_at":"2019-10-20T00:05:03Z","pushed_at":"2019-12-21T03:23:15Z","git_url":"git://github.com/ranj063/linux.git","ssh_url":"git@github.com:ranj063/linux.git","clone_url":"https://github.com/ranj063/linux.git","svn_url":"https://github.com/ranj063/linux","homepage":"","size":2917326,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"topic/sof-dev"}},"base":{"label":"thesofproject:topic/sof-dev","ref":"topic/sof-dev","sha":"7fde47549cb1b305c4578d2b535b55b87905937d","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135611127,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MTExMjc=","name":"linux","full_name":"thesofproject/linux","private":false,"owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thesofproject/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/thesofproject/linux","forks_url":"https://api.github.com/repos/thesofproject/linux/forks","keys_url":"https://api.github.com/repos/thesofproject/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/linux/teams","hooks_url":"https://api.github.com/repos/thesofproject/linux/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/linux/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/linux/events","assignees_url":"https://api.github.com/repos/thesofproject/linux/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/linux/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/linux/tags","blobs_url":"https://api.github.com/repos/thesofproject/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/linux/languages","stargazers_url":"https://api.github.com/repos/thesofproject/linux/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/linux/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/linux/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/linux/subscription","commits_url":"https://api.github.com/repos/thesofproject/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/linux/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/linux/merges","archive_url":"https://api.github.com/repos/thesofproject/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/linux/downloads","issues_url":"https://api.github.com/repos/thesofproject/linux/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/linux/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/linux/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/linux/deployments","created_at":"2018-05-31T16:47:45Z","updated_at":"2020-01-02T19:49:41Z","pushed_at":"2020-01-06T18:04:27Z","git_url":"git://github.com/thesofproject/linux.git","ssh_url":"git@github.com:thesofproject/linux.git","clone_url":"https://github.com/thesofproject/linux.git","svn_url":"https://github.com/thesofproject/linux","homepage":"","size":3350240,"stargazers_count":22,"watchers_count":22,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":125,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":55,"open_issues":125,"watchers":22,"default_branch":"topic/sof-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1631"},"html":{"href":"https://github.com/thesofproject/linux/pull/1631"},"issue":{"href":"https://api.github.com/repos/thesofproject/linux/issues/1631"},"comments":{"href":"https://api.github.com/repos/thesofproject/linux/issues/1631/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1631/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1631/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/linux/statuses/d5b498e40a00535f94d8cb8dcc6910f4b7345c12"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ranj063"}}