{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/46492","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/46492/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/46492/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/46492/events","html_url":"https://github.com/elastic/kibana/pull/46492","id":497825857,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIwODgyNTc0","number":46492,"title":"[Uptime] Fix flaky unit test snapshot","user":{"login":"justinkambic","id":18429259,"node_id":"MDQ6VXNlcjE4NDI5MjU5","avatar_url":"https://avatars2.githubusercontent.com/u/18429259?v=4","gravatar_id":"","url":"https://api.github.com/users/justinkambic","html_url":"https://github.com/justinkambic","followers_url":"https://api.github.com/users/justinkambic/followers","following_url":"https://api.github.com/users/justinkambic/following{/other_user}","gists_url":"https://api.github.com/users/justinkambic/gists{/gist_id}","starred_url":"https://api.github.com/users/justinkambic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinkambic/subscriptions","organizations_url":"https://api.github.com/users/justinkambic/orgs","repos_url":"https://api.github.com/users/justinkambic/repos","events_url":"https://api.github.com/users/justinkambic/events{/privacy}","received_events_url":"https://api.github.com/users/justinkambic/received_events","type":"User","site_admin":false},"labels":[{"id":1135254191,"node_id":"MDU6TGFiZWwxMTM1MjU0MTkx","url":"https://api.github.com/repos/elastic/kibana/labels/Team:uptime","name":"Team:uptime","color":"e5968b","default":false},{"id":899581493,"node_id":"MDU6TGFiZWw4OTk1ODE0OTM=","url":"https://api.github.com/repos/elastic/kibana/labels/[zube]:%20In%20Review","name":"[zube]: In Review","color":"ffffff","default":false},{"id":1196522308,"node_id":"MDU6TGFiZWwxMTk2NTIyMzA4","url":"https://api.github.com/repos/elastic/kibana/labels/release_note:skip","name":"release_note:skip","color":"016589","default":false},{"id":1457877410,"node_id":"MDU6TGFiZWwxNDU3ODc3NDEw","url":"https://api.github.com/repos/elastic/kibana/labels/test-failure-flaky","name":"test-failure-flaky","color":"efa69e","default":false},{"id":1566419478,"node_id":"MDU6TGFiZWwxNTY2NDE5NDc4","url":"https://api.github.com/repos/elastic/kibana/labels/test-matrix","name":"test-matrix","color":"f7766c","default":false},{"id":1435417824,"node_id":"MDU6TGFiZWwxNDM1NDE3ODI0","url":"https://api.github.com/repos/elastic/kibana/labels/v7.5.0","name":"v7.5.0","color":"ffffff","default":false},{"id":1124458249,"node_id":"MDU6TGFiZWwxMTI0NDU4MjQ5","url":"https://api.github.com/repos/elastic/kibana/labels/v8.0.0","name":"v8.0.0","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":{"login":"justinkambic","id":18429259,"node_id":"MDQ6VXNlcjE4NDI5MjU5","avatar_url":"https://avatars2.githubusercontent.com/u/18429259?v=4","gravatar_id":"","url":"https://api.github.com/users/justinkambic","html_url":"https://github.com/justinkambic","followers_url":"https://api.github.com/users/justinkambic/followers","following_url":"https://api.github.com/users/justinkambic/following{/other_user}","gists_url":"https://api.github.com/users/justinkambic/gists{/gist_id}","starred_url":"https://api.github.com/users/justinkambic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinkambic/subscriptions","organizations_url":"https://api.github.com/users/justinkambic/orgs","repos_url":"https://api.github.com/users/justinkambic/repos","events_url":"https://api.github.com/users/justinkambic/events{/privacy}","received_events_url":"https://api.github.com/users/justinkambic/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinkambic","id":18429259,"node_id":"MDQ6VXNlcjE4NDI5MjU5","avatar_url":"https://avatars2.githubusercontent.com/u/18429259?v=4","gravatar_id":"","url":"https://api.github.com/users/justinkambic","html_url":"https://github.com/justinkambic","followers_url":"https://api.github.com/users/justinkambic/followers","following_url":"https://api.github.com/users/justinkambic/following{/other_user}","gists_url":"https://api.github.com/users/justinkambic/gists{/gist_id}","starred_url":"https://api.github.com/users/justinkambic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinkambic/subscriptions","organizations_url":"https://api.github.com/users/justinkambic/orgs","repos_url":"https://api.github.com/users/justinkambic/repos","events_url":"https://api.github.com/users/justinkambic/events{/privacy}","received_events_url":"https://api.github.com/users/justinkambic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2019-09-24T17:30:54Z","updated_at":"2019-09-26T22:53:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/46492","html_url":"https://github.com/elastic/kibana/pull/46492","diff_url":"https://github.com/elastic/kibana/pull/46492.diff","patch_url":"https://github.com/elastic/kibana/pull/46492.patch"},"body":"## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/46217.\r\n\r\nIn https://github.com/elastic/kibana/pull/40650 we added a helper function to avoid this same problem in other tests. There is a computed value that can sometimes be off by one. This does not impact performance or pose any problem in practice, but when performing snapshot comparisons it can be problematic.\r\n\r\nThis patch extracts that helper function, adds a test for it, and updates the existing unit test to avoid this flakiness.\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)\r\n- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)\r\n- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials\r\n- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios\r\n- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/535715445","html_url":"https://github.com/elastic/kibana/pull/46492#issuecomment-535715445","issue_url":"https://api.github.com/repos/elastic/kibana/issues/46492","id":535715445,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNTcxNTQ0NQ==","user":{"login":"spalger","id":1329312,"node_id":"MDQ6VXNlcjEzMjkzMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1329312?v=4","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"created_at":"2019-09-26T22:53:57Z","updated_at":"2019-09-26T22:53:57Z","author_association":"MEMBER","body":"@elasticmachine merge upstream"}}
{"actor":{"display_login":"spalger"}}