{"action":"created","comment":{"url":"https://api.github.com/repos/panoplyio/ep/pulls/comments/287587371","pull_request_review_id":242028256,"id":287587371,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NzU4NzM3MQ==","diff_hunk":"@@ -84,3 +84,57 @@ func TestComposeProject_creation(t *testing.T) {\n \t\trequire.IsType(t, cmp, project)\n \t})\n }\n+\n+func BenchmarkComposeProjectImpl(b *testing.B) {\n+\tints := make([]int, 1000)\n+\tfor i := 0; i < 1000; i++ {\n+\t\tints[i] = i\n+\t}\n+\tbatches := make(integers, 0, 1000)\n+\tbatches = append(batches, ints...)\n+\tdata := ep.NewDataset(batches)\n+\n+\tb.Run(\"2runners\", func(b *testing.B) {\n+\t\tcompProj := ep.ComposeProject(&mulIntBy2{}, &negateInt{})\n+\t\tbatchFunction := compProj.BatchFunction()\n+\n+\t\tb.ResetTimer()\n+\t\tfor n := 0; n < b.N; n++ {\n+\t\t\tres, err := batchFunction(data)\n+\t\t\trequire.NoError(b, err)\n+\t\t\trequire.NotNil(b, data)\n+\t\t\trequire.Equal(b, data.Len(), res.Len())\n+\t\t}\n+\t})\n+\n+\tb.Run(\"5runners\", func(b *testing.B) {\n+\t\tcompProj := ep.ComposeProject(&mulIntBy2{}, &negateInt{}, &mulIntBy2{}, &negateInt{}, &mulIntBy2{})\n+\t\tbatchFunction := compProj.BatchFunction()\n+\n+\t\tb.ResetTimer()\n+\t\tfor n := 0; n < b.N; n++ {\n+\t\t\tres, err := batchFunction(data)\n+\t\t\trequire.NoError(b, err)\n+\t\t\trequire.NotNil(b, data)\n+\t\t\trequire.Equal(b, data.Len(), res.Len())\n+\t\t}\n+\t})\n+\n+\tb.Run(\"100runners\", func(b *testing.B) {\n+\t\tcomposables := make([]ep.Composable, 100)\n+\t\tfor i := 0; i < 99; i++ {\n+\t\t\tcomposables[i] = &mulIntBy2{}\n+\t\t\tcomposables[i+1] = &negateInt{}","path":"compose_test.go","position":44,"original_position":44,"commit_id":"8190958628cb20b90d995a7b3a63f707b6333faf","original_commit_id":"8190958628cb20b90d995a7b3a63f707b6333faf","user":{"login":"aviaoh","id":22256371,"node_id":"MDQ6VXNlcjIyMjU2Mzcx","avatar_url":"https://avatars2.githubusercontent.com/u/22256371?v=4","gravatar_id":"","url":"https://api.github.com/users/aviaoh","html_url":"https://github.com/aviaoh","followers_url":"https://api.github.com/users/aviaoh/followers","following_url":"https://api.github.com/users/aviaoh/following{/other_user}","gists_url":"https://api.github.com/users/aviaoh/gists{/gist_id}","starred_url":"https://api.github.com/users/aviaoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviaoh/subscriptions","organizations_url":"https://api.github.com/users/aviaoh/orgs","repos_url":"https://api.github.com/users/aviaoh/repos","events_url":"https://api.github.com/users/aviaoh/events{/privacy}","received_events_url":"https://api.github.com/users/aviaoh/received_events","type":"User","site_admin":false},"body":"you can't locate mulIntBy2 after a runner that return single column.\r\nplease use valid runners pipe (if needed, use strings 😄)","created_at":"2019-05-26T08:25:15Z","updated_at":"2019-05-26T08:25:33Z","html_url":"https://github.com/panoplyio/ep/pull/166#discussion_r287587371","pull_request_url":"https://api.github.com/repos/panoplyio/ep/pulls/166","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/panoplyio/ep/pulls/comments/287587371"},"html":{"href":"https://github.com/panoplyio/ep/pull/166#discussion_r287587371"},"pull_request":{"href":"https://api.github.com/repos/panoplyio/ep/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/panoplyio/ep/pulls/166","id":280673368,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwNjczMzY4","html_url":"https://github.com/panoplyio/ep/pull/166","diff_url":"https://github.com/panoplyio/ep/pull/166.diff","patch_url":"https://github.com/panoplyio/ep/pull/166.patch","issue_url":"https://api.github.com/repos/panoplyio/ep/issues/166","number":166,"state":"open","locked":false,"title":"Change the use of Expand method in ComposeProject + add benchmark","user":{"login":"BoraBak","id":19358413,"node_id":"MDQ6VXNlcjE5MzU4NDEz","avatar_url":"https://avatars1.githubusercontent.com/u/19358413?v=4","gravatar_id":"","url":"https://api.github.com/users/BoraBak","html_url":"https://github.com/BoraBak","followers_url":"https://api.github.com/users/BoraBak/followers","following_url":"https://api.github.com/users/BoraBak/following{/other_user}","gists_url":"https://api.github.com/users/BoraBak/gists{/gist_id}","starred_url":"https://api.github.com/users/BoraBak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoraBak/subscriptions","organizations_url":"https://api.github.com/users/BoraBak/orgs","repos_url":"https://api.github.com/users/BoraBak/repos","events_url":"https://api.github.com/users/BoraBak/events{/privacy}","received_events_url":"https://api.github.com/users/BoraBak/received_events","type":"User","site_admin":false},"body":"1.  The Compose https://github.com/panoplyio/ep/pull/164 needs to be merged.\r\n2. This PR implementation should be modified a bit. The call to the method **verifySameLength()**, needs to be to the function in _dataset.go_","created_at":"2019-05-21T08:24:31Z","updated_at":"2019-05-26T08:25:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81377721a66bb79baac3ac2c84aff16102cbdbdd","assignee":{"login":"BoraBak","id":19358413,"node_id":"MDQ6VXNlcjE5MzU4NDEz","avatar_url":"https://avatars1.githubusercontent.com/u/19358413?v=4","gravatar_id":"","url":"https://api.github.com/users/BoraBak","html_url":"https://github.com/BoraBak","followers_url":"https://api.github.com/users/BoraBak/followers","following_url":"https://api.github.com/users/BoraBak/following{/other_user}","gists_url":"https://api.github.com/users/BoraBak/gists{/gist_id}","starred_url":"https://api.github.com/users/BoraBak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoraBak/subscriptions","organizations_url":"https://api.github.com/users/BoraBak/orgs","repos_url":"https://api.github.com/users/BoraBak/repos","events_url":"https://api.github.com/users/BoraBak/events{/privacy}","received_events_url":"https://api.github.com/users/BoraBak/received_events","type":"User","site_admin":false},"assignees":[{"login":"BoraBak","id":19358413,"node_id":"MDQ6VXNlcjE5MzU4NDEz","avatar_url":"https://avatars1.githubusercontent.com/u/19358413?v=4","gravatar_id":"","url":"https://api.github.com/users/BoraBak","html_url":"https://github.com/BoraBak","followers_url":"https://api.github.com/users/BoraBak/followers","following_url":"https://api.github.com/users/BoraBak/following{/other_user}","gists_url":"https://api.github.com/users/BoraBak/gists{/gist_id}","starred_url":"https://api.github.com/users/BoraBak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoraBak/subscriptions","organizations_url":"https://api.github.com/users/BoraBak/orgs","repos_url":"https://api.github.com/users/BoraBak/repos","events_url":"https://api.github.com/users/BoraBak/events{/privacy}","received_events_url":"https://api.github.com/users/BoraBak/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/panoplyio/ep/pulls/166/commits","review_comments_url":"https://api.github.com/repos/panoplyio/ep/pulls/166/comments","review_comment_url":"https://api.github.com/repos/panoplyio/ep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/panoplyio/ep/issues/166/comments","statuses_url":"https://api.github.com/repos/panoplyio/ep/statuses/8190958628cb20b90d995a7b3a63f707b6333faf","head":{"label":"BoraBak:projectComposeReduceExpandUse","ref":"projectComposeReduceExpandUse","sha":"8190958628cb20b90d995a7b3a63f707b6333faf","user":{"login":"BoraBak","id":19358413,"node_id":"MDQ6VXNlcjE5MzU4NDEz","avatar_url":"https://avatars1.githubusercontent.com/u/19358413?v=4","gravatar_id":"","url":"https://api.github.com/users/BoraBak","html_url":"https://github.com/BoraBak","followers_url":"https://api.github.com/users/BoraBak/followers","following_url":"https://api.github.com/users/BoraBak/following{/other_user}","gists_url":"https://api.github.com/users/BoraBak/gists{/gist_id}","starred_url":"https://api.github.com/users/BoraBak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoraBak/subscriptions","organizations_url":"https://api.github.com/users/BoraBak/orgs","repos_url":"https://api.github.com/users/BoraBak/repos","events_url":"https://api.github.com/users/BoraBak/events{/privacy}","received_events_url":"https://api.github.com/users/BoraBak/received_events","type":"User","site_admin":false},"repo":{"id":163969324,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM5NjkzMjQ=","name":"ep","full_name":"BoraBak/ep","private":false,"owner":{"login":"BoraBak","id":19358413,"node_id":"MDQ6VXNlcjE5MzU4NDEz","avatar_url":"https://avatars1.githubusercontent.com/u/19358413?v=4","gravatar_id":"","url":"https://api.github.com/users/BoraBak","html_url":"https://github.com/BoraBak","followers_url":"https://api.github.com/users/BoraBak/followers","following_url":"https://api.github.com/users/BoraBak/following{/other_user}","gists_url":"https://api.github.com/users/BoraBak/gists{/gist_id}","starred_url":"https://api.github.com/users/BoraBak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoraBak/subscriptions","organizations_url":"https://api.github.com/users/BoraBak/orgs","repos_url":"https://api.github.com/users/BoraBak/repos","events_url":"https://api.github.com/users/BoraBak/events{/privacy}","received_events_url":"https://api.github.com/users/BoraBak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BoraBak/ep","description":"Distributed Query Processing & Execution Framework","fork":true,"url":"https://api.github.com/repos/BoraBak/ep","forks_url":"https://api.github.com/repos/BoraBak/ep/forks","keys_url":"https://api.github.com/repos/BoraBak/ep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BoraBak/ep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BoraBak/ep/teams","hooks_url":"https://api.github.com/repos/BoraBak/ep/hooks","issue_events_url":"https://api.github.com/repos/BoraBak/ep/issues/events{/number}","events_url":"https://api.github.com/repos/BoraBak/ep/events","assignees_url":"https://api.github.com/repos/BoraBak/ep/assignees{/user}","branches_url":"https://api.github.com/repos/BoraBak/ep/branches{/branch}","tags_url":"https://api.github.com/repos/BoraBak/ep/tags","blobs_url":"https://api.github.com/repos/BoraBak/ep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BoraBak/ep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BoraBak/ep/git/refs{/sha}","trees_url":"https://api.github.com/repos/BoraBak/ep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BoraBak/ep/statuses/{sha}","languages_url":"https://api.github.com/repos/BoraBak/ep/languages","stargazers_url":"https://api.github.com/repos/BoraBak/ep/stargazers","contributors_url":"https://api.github.com/repos/BoraBak/ep/contributors","subscribers_url":"https://api.github.com/repos/BoraBak/ep/subscribers","subscription_url":"https://api.github.com/repos/BoraBak/ep/subscription","commits_url":"https://api.github.com/repos/BoraBak/ep/commits{/sha}","git_commits_url":"https://api.github.com/repos/BoraBak/ep/git/commits{/sha}","comments_url":"https://api.github.com/repos/BoraBak/ep/comments{/number}","issue_comment_url":"https://api.github.com/repos/BoraBak/ep/issues/comments{/number}","contents_url":"https://api.github.com/repos/BoraBak/ep/contents/{+path}","compare_url":"https://api.github.com/repos/BoraBak/ep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BoraBak/ep/merges","archive_url":"https://api.github.com/repos/BoraBak/ep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BoraBak/ep/downloads","issues_url":"https://api.github.com/repos/BoraBak/ep/issues{/number}","pulls_url":"https://api.github.com/repos/BoraBak/ep/pulls{/number}","milestones_url":"https://api.github.com/repos/BoraBak/ep/milestones{/number}","notifications_url":"https://api.github.com/repos/BoraBak/ep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BoraBak/ep/labels{/name}","releases_url":"https://api.github.com/repos/BoraBak/ep/releases{/id}","deployments_url":"https://api.github.com/repos/BoraBak/ep/deployments","created_at":"2019-01-03T12:19:47Z","updated_at":"2019-02-13T15:28:47Z","pushed_at":"2019-05-21T11:35:28Z","git_url":"git://github.com/BoraBak/ep.git","ssh_url":"git@github.com:BoraBak/ep.git","clone_url":"https://github.com/BoraBak/ep.git","svn_url":"https://github.com/BoraBak/ep","homepage":"http://godoc.org/github.com/panoplyio/ep","size":808,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"panoplyio:master","ref":"master","sha":"cbc507c428344434a1e65faeedf7cacacf9b25f7","user":{"login":"panoplyio","id":13719543,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzE5NTQz","avatar_url":"https://avatars2.githubusercontent.com/u/13719543?v=4","gravatar_id":"","url":"https://api.github.com/users/panoplyio","html_url":"https://github.com/panoplyio","followers_url":"https://api.github.com/users/panoplyio/followers","following_url":"https://api.github.com/users/panoplyio/following{/other_user}","gists_url":"https://api.github.com/users/panoplyio/gists{/gist_id}","starred_url":"https://api.github.com/users/panoplyio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panoplyio/subscriptions","organizations_url":"https://api.github.com/users/panoplyio/orgs","repos_url":"https://api.github.com/users/panoplyio/repos","events_url":"https://api.github.com/users/panoplyio/events{/privacy}","received_events_url":"https://api.github.com/users/panoplyio/received_events","type":"Organization","site_admin":false},"repo":{"id":93925299,"node_id":"MDEwOlJlcG9zaXRvcnk5MzkyNTI5OQ==","name":"ep","full_name":"panoplyio/ep","private":false,"owner":{"login":"panoplyio","id":13719543,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzE5NTQz","avatar_url":"https://avatars2.githubusercontent.com/u/13719543?v=4","gravatar_id":"","url":"https://api.github.com/users/panoplyio","html_url":"https://github.com/panoplyio","followers_url":"https://api.github.com/users/panoplyio/followers","following_url":"https://api.github.com/users/panoplyio/following{/other_user}","gists_url":"https://api.github.com/users/panoplyio/gists{/gist_id}","starred_url":"https://api.github.com/users/panoplyio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panoplyio/subscriptions","organizations_url":"https://api.github.com/users/panoplyio/orgs","repos_url":"https://api.github.com/users/panoplyio/repos","events_url":"https://api.github.com/users/panoplyio/events{/privacy}","received_events_url":"https://api.github.com/users/panoplyio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/panoplyio/ep","description":"Distributed Query Processing & Execution Framework","fork":false,"url":"https://api.github.com/repos/panoplyio/ep","forks_url":"https://api.github.com/repos/panoplyio/ep/forks","keys_url":"https://api.github.com/repos/panoplyio/ep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panoplyio/ep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panoplyio/ep/teams","hooks_url":"https://api.github.com/repos/panoplyio/ep/hooks","issue_events_url":"https://api.github.com/repos/panoplyio/ep/issues/events{/number}","events_url":"https://api.github.com/repos/panoplyio/ep/events","assignees_url":"https://api.github.com/repos/panoplyio/ep/assignees{/user}","branches_url":"https://api.github.com/repos/panoplyio/ep/branches{/branch}","tags_url":"https://api.github.com/repos/panoplyio/ep/tags","blobs_url":"https://api.github.com/repos/panoplyio/ep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panoplyio/ep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panoplyio/ep/git/refs{/sha}","trees_url":"https://api.github.com/repos/panoplyio/ep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panoplyio/ep/statuses/{sha}","languages_url":"https://api.github.com/repos/panoplyio/ep/languages","stargazers_url":"https://api.github.com/repos/panoplyio/ep/stargazers","contributors_url":"https://api.github.com/repos/panoplyio/ep/contributors","subscribers_url":"https://api.github.com/repos/panoplyio/ep/subscribers","subscription_url":"https://api.github.com/repos/panoplyio/ep/subscription","commits_url":"https://api.github.com/repos/panoplyio/ep/commits{/sha}","git_commits_url":"https://api.github.com/repos/panoplyio/ep/git/commits{/sha}","comments_url":"https://api.github.com/repos/panoplyio/ep/comments{/number}","issue_comment_url":"https://api.github.com/repos/panoplyio/ep/issues/comments{/number}","contents_url":"https://api.github.com/repos/panoplyio/ep/contents/{+path}","compare_url":"https://api.github.com/repos/panoplyio/ep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panoplyio/ep/merges","archive_url":"https://api.github.com/repos/panoplyio/ep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panoplyio/ep/downloads","issues_url":"https://api.github.com/repos/panoplyio/ep/issues{/number}","pulls_url":"https://api.github.com/repos/panoplyio/ep/pulls{/number}","milestones_url":"https://api.github.com/repos/panoplyio/ep/milestones{/number}","notifications_url":"https://api.github.com/repos/panoplyio/ep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panoplyio/ep/labels{/name}","releases_url":"https://api.github.com/repos/panoplyio/ep/releases{/id}","deployments_url":"https://api.github.com/repos/panoplyio/ep/deployments","created_at":"2017-06-10T08:10:41Z","updated_at":"2019-05-22T09:27:51Z","pushed_at":"2019-05-22T09:47:49Z","git_url":"git://github.com/panoplyio/ep.git","ssh_url":"git@github.com:panoplyio/ep.git","clone_url":"https://github.com/panoplyio/ep.git","svn_url":"https://github.com/panoplyio/ep","homepage":"http://godoc.org/github.com/panoplyio/ep","size":808,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":8,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/panoplyio/ep/pulls/166"},"html":{"href":"https://github.com/panoplyio/ep/pull/166"},"issue":{"href":"https://api.github.com/repos/panoplyio/ep/issues/166"},"comments":{"href":"https://api.github.com/repos/panoplyio/ep/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/panoplyio/ep/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/panoplyio/ep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/panoplyio/ep/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/panoplyio/ep/statuses/8190958628cb20b90d995a7b3a63f707b6333faf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aviaoh"}}