{"action":"opened","number":43,"pull_request":{"url":"https://api.github.com/repos/vkettools/VitDeck/pulls/43","id":282229975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyMjI5OTc1","html_url":"https://github.com/vkettools/VitDeck/pull/43","diff_url":"https://github.com/vkettools/VitDeck/pull/43.diff","patch_url":"https://github.com/vkettools/VitDeck/pull/43.patch","issue_url":"https://api.github.com/repos/vkettools/VitDeck/issues/43","number":43,"state":"open","locked":false,"title":"Feature/#9","user":{"login":"sktkkoo","id":6031376,"node_id":"MDQ6VXNlcjYwMzEzNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6031376?v=4","gravatar_id":"","url":"https://api.github.com/users/sktkkoo","html_url":"https://github.com/sktkkoo","followers_url":"https://api.github.com/users/sktkkoo/followers","following_url":"https://api.github.com/users/sktkkoo/following{/other_user}","gists_url":"https://api.github.com/users/sktkkoo/gists{/gist_id}","starred_url":"https://api.github.com/users/sktkkoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sktkkoo/subscriptions","organizations_url":"https://api.github.com/users/sktkkoo/orgs","repos_url":"https://api.github.com/users/sktkkoo/repos","events_url":"https://api.github.com/users/sktkkoo/events{/privacy}","received_events_url":"https://api.github.com/users/sktkkoo/received_events","type":"User","site_admin":false},"body":"# アップデート確認機能(#9)\r\n## レビュアー\r\n@Kozu-vr , @sokuhatiku \r\n\r\n## 変更箇所\r\n#9 として以下の機能を実装しました。\r\n- UpdateCheck：最新リリースからバージョン情報を確認し、アップデート可能かチェックする\r\n- PackageDownloader：unitypackageをダウンロード、インポート、削除\r\n- Repositoy：GitHubリポジトリ関連情報の管理\r\n\r\nまた、アップデート情報の表示のためにMain/InfoWindow.csを変更しています (詳細はissue参照)\r\n## 使い方\r\n- メニュー [VitDeck] -> [Info] でアップデート情報の確認 (要ネット接続)\r\n- アップデート可能な場合は「Update」ボタンを押すと、unitypackageのダウンロード、インポート、ダウンロード後のunitypackageの削除まで行います。\r\n## 注意点\r\n- 最新リリース情報取得にGitHub APIを利用しているため以下の制限があります\r\n  - publicでないリポジトリの情報を取得できない\r\n  - 1時間に60回以上バージョン情報を見ようとするとネットワークエラーとなる\r\n\r\n- 上記の制限により、現在は常に以下の表示になります（バグではなく、まだVitDeckのリポジトリがpublicでなく、Releaseもされていないため）\r\n![bandicam 2019-05-25 22-05-57-262](https://user-images.githubusercontent.com/6031376/58369726-77b93280-7f39-11e9-9319-048579e5ddb1.jpg)\r\n\r\nなお、1時間60件の制限に引っかかった場合は、1時間ほど待てば再び表示されるようになるはずです。\r\n## レビュー箇所・観点\r\n- 特にC#でのネットワーク周りやファイルの処理にあまり慣れていないので、危ない処理をしていないかレビューをお願いしたいです\r\n  - 具体的には、**UpdateCheckのリリース情報を取ってくる部分、PackageDownloader全体**\r\n  - ダウンロード（あるいはファイルの保存など）が完了する前にインポートや削除の処理が入ることはないのか、その場合にどのような対処方法があるかなど、できれば指摘をお願いします\r\n- その他、テストコードの書き方についても何かあればお願いします\r\n## 備考\r\nPackageDownloaderのテストコードは以下の不具合があり、今回のプルリクに含めていません。\r\n\r\n> テストコード実行後に、ダウンロードしてきたunitypackageやインポートしたファイルが残ってしまう場合がある(kozuさんと同様の現象？)\r\n\r\n\r\n\r\n","created_at":"2019-05-25T13:25:47Z","updated_at":"2019-05-25T13:25:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vkettools/VitDeck/pulls/43/commits","review_comments_url":"https://api.github.com/repos/vkettools/VitDeck/pulls/43/comments","review_comment_url":"https://api.github.com/repos/vkettools/VitDeck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vkettools/VitDeck/issues/43/comments","statuses_url":"https://api.github.com/repos/vkettools/VitDeck/statuses/7378d8fd1b77b60ff897eb98e0361d8bbc038b7f","head":{"label":"vkettools:feature/#9","ref":"feature/#9","sha":"7378d8fd1b77b60ff897eb98e0361d8bbc038b7f","user":{"login":"vkettools","id":47938719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3OTM4NzE5","avatar_url":"https://avatars0.githubusercontent.com/u/47938719?v=4","gravatar_id":"","url":"https://api.github.com/users/vkettools","html_url":"https://github.com/vkettools","followers_url":"https://api.github.com/users/vkettools/followers","following_url":"https://api.github.com/users/vkettools/following{/other_user}","gists_url":"https://api.github.com/users/vkettools/gists{/gist_id}","starred_url":"https://api.github.com/users/vkettools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkettools/subscriptions","organizations_url":"https://api.github.com/users/vkettools/orgs","repos_url":"https://api.github.com/users/vkettools/repos","events_url":"https://api.github.com/users/vkettools/events{/privacy}","received_events_url":"https://api.github.com/users/vkettools/received_events","type":"Organization","site_admin":false},"repo":{"id":179813130,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk4MTMxMzA=","name":"VitDeck","full_name":"vkettools/VitDeck","private":false,"owner":{"login":"vkettools","id":47938719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3OTM4NzE5","avatar_url":"https://avatars0.githubusercontent.com/u/47938719?v=4","gravatar_id":"","url":"https://api.github.com/users/vkettools","html_url":"https://github.com/vkettools","followers_url":"https://api.github.com/users/vkettools/followers","following_url":"https://api.github.com/users/vkettools/following{/other_user}","gists_url":"https://api.github.com/users/vkettools/gists{/gist_id}","starred_url":"https://api.github.com/users/vkettools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkettools/subscriptions","organizations_url":"https://api.github.com/users/vkettools/orgs","repos_url":"https://api.github.com/users/vkettools/repos","events_url":"https://api.github.com/users/vkettools/events{/privacy}","received_events_url":"https://api.github.com/users/vkettools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vkettools/VitDeck","description":null,"fork":false,"url":"https://api.github.com/repos/vkettools/VitDeck","forks_url":"https://api.github.com/repos/vkettools/VitDeck/forks","keys_url":"https://api.github.com/repos/vkettools/VitDeck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vkettools/VitDeck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vkettools/VitDeck/teams","hooks_url":"https://api.github.com/repos/vkettools/VitDeck/hooks","issue_events_url":"https://api.github.com/repos/vkettools/VitDeck/issues/events{/number}","events_url":"https://api.github.com/repos/vkettools/VitDeck/events","assignees_url":"https://api.github.com/repos/vkettools/VitDeck/assignees{/user}","branches_url":"https://api.github.com/repos/vkettools/VitDeck/branches{/branch}","tags_url":"https://api.github.com/repos/vkettools/VitDeck/tags","blobs_url":"https://api.github.com/repos/vkettools/VitDeck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vkettools/VitDeck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vkettools/VitDeck/git/refs{/sha}","trees_url":"https://api.github.com/repos/vkettools/VitDeck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vkettools/VitDeck/statuses/{sha}","languages_url":"https://api.github.com/repos/vkettools/VitDeck/languages","stargazers_url":"https://api.github.com/repos/vkettools/VitDeck/stargazers","contributors_url":"https://api.github.com/repos/vkettools/VitDeck/contributors","subscribers_url":"https://api.github.com/repos/vkettools/VitDeck/subscribers","subscription_url":"https://api.github.com/repos/vkettools/VitDeck/subscription","commits_url":"https://api.github.com/repos/vkettools/VitDeck/commits{/sha}","git_commits_url":"https://api.github.com/repos/vkettools/VitDeck/git/commits{/sha}","comments_url":"https://api.github.com/repos/vkettools/VitDeck/comments{/number}","issue_comment_url":"https://api.github.com/repos/vkettools/VitDeck/issues/comments{/number}","contents_url":"https://api.github.com/repos/vkettools/VitDeck/contents/{+path}","compare_url":"https://api.github.com/repos/vkettools/VitDeck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vkettools/VitDeck/merges","archive_url":"https://api.github.com/repos/vkettools/VitDeck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vkettools/VitDeck/downloads","issues_url":"https://api.github.com/repos/vkettools/VitDeck/issues{/number}","pulls_url":"https://api.github.com/repos/vkettools/VitDeck/pulls{/number}","milestones_url":"https://api.github.com/repos/vkettools/VitDeck/milestones{/number}","notifications_url":"https://api.github.com/repos/vkettools/VitDeck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vkettools/VitDeck/labels{/name}","releases_url":"https://api.github.com/repos/vkettools/VitDeck/releases{/id}","deployments_url":"https://api.github.com/repos/vkettools/VitDeck/deployments","created_at":"2019-04-06T09:24:47Z","updated_at":"2019-04-29T06:16:29Z","pushed_at":"2019-05-25T12:06:28Z","git_url":"git://github.com/vkettools/VitDeck.git","ssh_url":"git@github.com:vkettools/VitDeck.git","clone_url":"https://github.com/vkettools/VitDeck.git","svn_url":"https://github.com/vkettools/VitDeck","homepage":null,"size":231,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"vkettools:develop","ref":"develop","sha":"fae5db521b7b24b8085eb1f741a4ac42c377008b","user":{"login":"vkettools","id":47938719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3OTM4NzE5","avatar_url":"https://avatars0.githubusercontent.com/u/47938719?v=4","gravatar_id":"","url":"https://api.github.com/users/vkettools","html_url":"https://github.com/vkettools","followers_url":"https://api.github.com/users/vkettools/followers","following_url":"https://api.github.com/users/vkettools/following{/other_user}","gists_url":"https://api.github.com/users/vkettools/gists{/gist_id}","starred_url":"https://api.github.com/users/vkettools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkettools/subscriptions","organizations_url":"https://api.github.com/users/vkettools/orgs","repos_url":"https://api.github.com/users/vkettools/repos","events_url":"https://api.github.com/users/vkettools/events{/privacy}","received_events_url":"https://api.github.com/users/vkettools/received_events","type":"Organization","site_admin":false},"repo":{"id":179813130,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk4MTMxMzA=","name":"VitDeck","full_name":"vkettools/VitDeck","private":false,"owner":{"login":"vkettools","id":47938719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3OTM4NzE5","avatar_url":"https://avatars0.githubusercontent.com/u/47938719?v=4","gravatar_id":"","url":"https://api.github.com/users/vkettools","html_url":"https://github.com/vkettools","followers_url":"https://api.github.com/users/vkettools/followers","following_url":"https://api.github.com/users/vkettools/following{/other_user}","gists_url":"https://api.github.com/users/vkettools/gists{/gist_id}","starred_url":"https://api.github.com/users/vkettools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkettools/subscriptions","organizations_url":"https://api.github.com/users/vkettools/orgs","repos_url":"https://api.github.com/users/vkettools/repos","events_url":"https://api.github.com/users/vkettools/events{/privacy}","received_events_url":"https://api.github.com/users/vkettools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vkettools/VitDeck","description":null,"fork":false,"url":"https://api.github.com/repos/vkettools/VitDeck","forks_url":"https://api.github.com/repos/vkettools/VitDeck/forks","keys_url":"https://api.github.com/repos/vkettools/VitDeck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vkettools/VitDeck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vkettools/VitDeck/teams","hooks_url":"https://api.github.com/repos/vkettools/VitDeck/hooks","issue_events_url":"https://api.github.com/repos/vkettools/VitDeck/issues/events{/number}","events_url":"https://api.github.com/repos/vkettools/VitDeck/events","assignees_url":"https://api.github.com/repos/vkettools/VitDeck/assignees{/user}","branches_url":"https://api.github.com/repos/vkettools/VitDeck/branches{/branch}","tags_url":"https://api.github.com/repos/vkettools/VitDeck/tags","blobs_url":"https://api.github.com/repos/vkettools/VitDeck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vkettools/VitDeck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vkettools/VitDeck/git/refs{/sha}","trees_url":"https://api.github.com/repos/vkettools/VitDeck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vkettools/VitDeck/statuses/{sha}","languages_url":"https://api.github.com/repos/vkettools/VitDeck/languages","stargazers_url":"https://api.github.com/repos/vkettools/VitDeck/stargazers","contributors_url":"https://api.github.com/repos/vkettools/VitDeck/contributors","subscribers_url":"https://api.github.com/repos/vkettools/VitDeck/subscribers","subscription_url":"https://api.github.com/repos/vkettools/VitDeck/subscription","commits_url":"https://api.github.com/repos/vkettools/VitDeck/commits{/sha}","git_commits_url":"https://api.github.com/repos/vkettools/VitDeck/git/commits{/sha}","comments_url":"https://api.github.com/repos/vkettools/VitDeck/comments{/number}","issue_comment_url":"https://api.github.com/repos/vkettools/VitDeck/issues/comments{/number}","contents_url":"https://api.github.com/repos/vkettools/VitDeck/contents/{+path}","compare_url":"https://api.github.com/repos/vkettools/VitDeck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vkettools/VitDeck/merges","archive_url":"https://api.github.com/repos/vkettools/VitDeck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vkettools/VitDeck/downloads","issues_url":"https://api.github.com/repos/vkettools/VitDeck/issues{/number}","pulls_url":"https://api.github.com/repos/vkettools/VitDeck/pulls{/number}","milestones_url":"https://api.github.com/repos/vkettools/VitDeck/milestones{/number}","notifications_url":"https://api.github.com/repos/vkettools/VitDeck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vkettools/VitDeck/labels{/name}","releases_url":"https://api.github.com/repos/vkettools/VitDeck/releases{/id}","deployments_url":"https://api.github.com/repos/vkettools/VitDeck/deployments","created_at":"2019-04-06T09:24:47Z","updated_at":"2019-04-29T06:16:29Z","pushed_at":"2019-05-25T12:06:28Z","git_url":"git://github.com/vkettools/VitDeck.git","ssh_url":"git@github.com:vkettools/VitDeck.git","clone_url":"https://github.com/vkettools/VitDeck.git","svn_url":"https://github.com/vkettools/VitDeck","homepage":null,"size":231,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vkettools/VitDeck/pulls/43"},"html":{"href":"https://github.com/vkettools/VitDeck/pull/43"},"issue":{"href":"https://api.github.com/repos/vkettools/VitDeck/issues/43"},"comments":{"href":"https://api.github.com/repos/vkettools/VitDeck/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/vkettools/VitDeck/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/vkettools/VitDeck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vkettools/VitDeck/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/vkettools/VitDeck/statuses/7378d8fd1b77b60ff897eb98e0361d8bbc038b7f"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":28,"additions":349,"deletions":0,"changed_files":11}}
{"actor":{"display_login":"sktkkoo"}}