{"action":"created","comment":{"url":"https://api.github.com/repos/zio/zio/pulls/comments/324832811","pull_request_review_id":288832271,"id":324832811,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNDgzMjgxMQ==","diff_hunk":"@@ -0,0 +1,204 @@\n+/*\n+ * Copyright 2017-2019 John A. De Goes and the ZIO Contributors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package zio.stm\n+\n+import zio.{ FiberFailure, UIO, ZIO, ZIOBaseSpec }\n+import zio.test._\n+import zio.test.Assertion._\n+import TArraySpecUtil._\n+\n+object TArraySpec\n+    extends ZIOBaseSpec(\n+      suite(\"TArraySpec\")(\n+        suite(\"apply\")(\n+          testM(\"happy-path\") {\n+            for {\n+              tArray <- makeTArray(1)(42)\n+              value  <- tArray(0).commit\n+            } yield assert(value, equalTo(42))\n+          },\n+          testM(\"dies with ArrayIndexOutOfBounds when index is out of bounds $applyOutOfBounds\") {\n+            assertM(for {\n+              tArray <- makeTArray(1)(42)\n+              _      <- tArray(-1).commit\n+            } yield (), throws(equalTo(FiberFailure)))","path":"core-tests/shared/src/test/scala/zio/stm/TArraySpec.scala","position":37,"original_position":37,"commit_id":"b710976f0216f157d74a5ac70d82b62bf9026d7a","original_commit_id":"b710976f0216f157d74a5ac70d82b62bf9026d7a","user":{"login":"LGLO","id":2694353,"node_id":"MDQ6VXNlcjI2OTQzNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2694353?v=4","gravatar_id":"","url":"https://api.github.com/users/LGLO","html_url":"https://github.com/LGLO","followers_url":"https://api.github.com/users/LGLO/followers","following_url":"https://api.github.com/users/LGLO/following{/other_user}","gists_url":"https://api.github.com/users/LGLO/gists{/gist_id}","starred_url":"https://api.github.com/users/LGLO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LGLO/subscriptions","organizations_url":"https://api.github.com/users/LGLO/orgs","repos_url":"https://api.github.com/users/LGLO/repos","events_url":"https://api.github.com/users/LGLO/events{/privacy}","received_events_url":"https://api.github.com/users/LGLO/received_events","type":"User","site_admin":false},"body":"Expected behavior is that `Fiber` running `TArray#appy(INVALID_INDEX)` will DIE, because it's considered an fatal error. So I _guess_ there are two things to change:\r\n* use `.run` combinator to get some result or exit value from apply\r\n* because we want to ensure DIE of a fiber, then `dies` instead of `throws`.","created_at":"2019-09-16T18:55:12Z","updated_at":"2019-09-16T18:55:12Z","html_url":"https://github.com/zio/zio/pull/1688#discussion_r324832811","pull_request_url":"https://api.github.com/repos/zio/zio/pulls/1688","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zio/zio/pulls/comments/324832811"},"html":{"href":"https://github.com/zio/zio/pull/1688#discussion_r324832811"},"pull_request":{"href":"https://api.github.com/repos/zio/zio/pulls/1688"}},"in_reply_to_id":324748662},"pull_request":{"url":"https://api.github.com/repos/zio/zio/pulls/1688","id":317945568,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3OTQ1NTY4","html_url":"https://github.com/zio/zio/pull/1688","diff_url":"https://github.com/zio/zio/pull/1688.diff","patch_url":"https://github.com/zio/zio/pull/1688.patch","issue_url":"https://api.github.com/repos/zio/zio/issues/1688","number":1688,"state":"open","locked":false,"title":"Migrate TarraySpec to ZIOTest","user":{"login":"denisgarci","id":5141673,"node_id":"MDQ6VXNlcjUxNDE2NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5141673?v=4","gravatar_id":"","url":"https://api.github.com/users/denisgarci","html_url":"https://github.com/denisgarci","followers_url":"https://api.github.com/users/denisgarci/followers","following_url":"https://api.github.com/users/denisgarci/following{/other_user}","gists_url":"https://api.github.com/users/denisgarci/gists{/gist_id}","starred_url":"https://api.github.com/users/denisgarci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisgarci/subscriptions","organizations_url":"https://api.github.com/users/denisgarci/orgs","repos_url":"https://api.github.com/users/denisgarci/repos","events_url":"https://api.github.com/users/denisgarci/events{/privacy}","received_events_url":"https://api.github.com/users/denisgarci/received_events","type":"User","site_admin":false},"body":"Migrate TarraySpec to ZIOTest. A few tests are not passing.\r\n","created_at":"2019-09-16T15:44:35Z","updated_at":"2019-09-16T18:55:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72cba82002338baee35e9a97148eb0a1ac09bd07","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zio/zio/pulls/1688/commits","review_comments_url":"https://api.github.com/repos/zio/zio/pulls/1688/comments","review_comment_url":"https://api.github.com/repos/zio/zio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zio/zio/issues/1688/comments","statuses_url":"https://api.github.com/repos/zio/zio/statuses/b710976f0216f157d74a5ac70d82b62bf9026d7a","head":{"label":"denisgarci:migrate-tarrayspec","ref":"migrate-tarrayspec","sha":"b710976f0216f157d74a5ac70d82b62bf9026d7a","user":{"login":"denisgarci","id":5141673,"node_id":"MDQ6VXNlcjUxNDE2NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5141673?v=4","gravatar_id":"","url":"https://api.github.com/users/denisgarci","html_url":"https://github.com/denisgarci","followers_url":"https://api.github.com/users/denisgarci/followers","following_url":"https://api.github.com/users/denisgarci/following{/other_user}","gists_url":"https://api.github.com/users/denisgarci/gists{/gist_id}","starred_url":"https://api.github.com/users/denisgarci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisgarci/subscriptions","organizations_url":"https://api.github.com/users/denisgarci/orgs","repos_url":"https://api.github.com/users/denisgarci/repos","events_url":"https://api.github.com/users/denisgarci/events{/privacy}","received_events_url":"https://api.github.com/users/denisgarci/received_events","type":"User","site_admin":false},"repo":{"id":145336456,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUzMzY0NTY=","name":"zio","full_name":"denisgarci/zio","private":false,"owner":{"login":"denisgarci","id":5141673,"node_id":"MDQ6VXNlcjUxNDE2NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5141673?v=4","gravatar_id":"","url":"https://api.github.com/users/denisgarci","html_url":"https://github.com/denisgarci","followers_url":"https://api.github.com/users/denisgarci/followers","following_url":"https://api.github.com/users/denisgarci/following{/other_user}","gists_url":"https://api.github.com/users/denisgarci/gists{/gist_id}","starred_url":"https://api.github.com/users/denisgarci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisgarci/subscriptions","organizations_url":"https://api.github.com/users/denisgarci/orgs","repos_url":"https://api.github.com/users/denisgarci/repos","events_url":"https://api.github.com/users/denisgarci/events{/privacy}","received_events_url":"https://api.github.com/users/denisgarci/received_events","type":"User","site_admin":false},"html_url":"https://github.com/denisgarci/zio","description":"ZIO — A type-safe, composable library for asynchronous and concurrent programming in Scala","fork":true,"url":"https://api.github.com/repos/denisgarci/zio","forks_url":"https://api.github.com/repos/denisgarci/zio/forks","keys_url":"https://api.github.com/repos/denisgarci/zio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/denisgarci/zio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/denisgarci/zio/teams","hooks_url":"https://api.github.com/repos/denisgarci/zio/hooks","issue_events_url":"https://api.github.com/repos/denisgarci/zio/issues/events{/number}","events_url":"https://api.github.com/repos/denisgarci/zio/events","assignees_url":"https://api.github.com/repos/denisgarci/zio/assignees{/user}","branches_url":"https://api.github.com/repos/denisgarci/zio/branches{/branch}","tags_url":"https://api.github.com/repos/denisgarci/zio/tags","blobs_url":"https://api.github.com/repos/denisgarci/zio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/denisgarci/zio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/denisgarci/zio/git/refs{/sha}","trees_url":"https://api.github.com/repos/denisgarci/zio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/denisgarci/zio/statuses/{sha}","languages_url":"https://api.github.com/repos/denisgarci/zio/languages","stargazers_url":"https://api.github.com/repos/denisgarci/zio/stargazers","contributors_url":"https://api.github.com/repos/denisgarci/zio/contributors","subscribers_url":"https://api.github.com/repos/denisgarci/zio/subscribers","subscription_url":"https://api.github.com/repos/denisgarci/zio/subscription","commits_url":"https://api.github.com/repos/denisgarci/zio/commits{/sha}","git_commits_url":"https://api.github.com/repos/denisgarci/zio/git/commits{/sha}","comments_url":"https://api.github.com/repos/denisgarci/zio/comments{/number}","issue_comment_url":"https://api.github.com/repos/denisgarci/zio/issues/comments{/number}","contents_url":"https://api.github.com/repos/denisgarci/zio/contents/{+path}","compare_url":"https://api.github.com/repos/denisgarci/zio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/denisgarci/zio/merges","archive_url":"https://api.github.com/repos/denisgarci/zio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/denisgarci/zio/downloads","issues_url":"https://api.github.com/repos/denisgarci/zio/issues{/number}","pulls_url":"https://api.github.com/repos/denisgarci/zio/pulls{/number}","milestones_url":"https://api.github.com/repos/denisgarci/zio/milestones{/number}","notifications_url":"https://api.github.com/repos/denisgarci/zio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/denisgarci/zio/labels{/name}","releases_url":"https://api.github.com/repos/denisgarci/zio/releases{/id}","deployments_url":"https://api.github.com/repos/denisgarci/zio/deployments","created_at":"2018-08-19T20:47:24Z","updated_at":"2019-09-14T22:02:07Z","pushed_at":"2019-09-16T15:42:45Z","git_url":"git://github.com/denisgarci/zio.git","ssh_url":"git@github.com:denisgarci/zio.git","clone_url":"https://github.com/denisgarci/zio.git","svn_url":"https://github.com/denisgarci/zio","homepage":"https://zio.dev","size":57970,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zio:master","ref":"master","sha":"7a8175a3662e07573266aa6873fad351fdbf4013","user":{"login":"zio","id":49655448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjU1NDQ4","avatar_url":"https://avatars2.githubusercontent.com/u/49655448?v=4","gravatar_id":"","url":"https://api.github.com/users/zio","html_url":"https://github.com/zio","followers_url":"https://api.github.com/users/zio/followers","following_url":"https://api.github.com/users/zio/following{/other_user}","gists_url":"https://api.github.com/users/zio/gists{/gist_id}","starred_url":"https://api.github.com/users/zio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zio/subscriptions","organizations_url":"https://api.github.com/users/zio/orgs","repos_url":"https://api.github.com/users/zio/repos","events_url":"https://api.github.com/users/zio/events{/privacy}","received_events_url":"https://api.github.com/users/zio/received_events","type":"Organization","site_admin":false},"repo":{"id":134079884,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQwNzk4ODQ=","name":"zio","full_name":"zio/zio","private":false,"owner":{"login":"zio","id":49655448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjU1NDQ4","avatar_url":"https://avatars2.githubusercontent.com/u/49655448?v=4","gravatar_id":"","url":"https://api.github.com/users/zio","html_url":"https://github.com/zio","followers_url":"https://api.github.com/users/zio/followers","following_url":"https://api.github.com/users/zio/following{/other_user}","gists_url":"https://api.github.com/users/zio/gists{/gist_id}","starred_url":"https://api.github.com/users/zio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zio/subscriptions","organizations_url":"https://api.github.com/users/zio/orgs","repos_url":"https://api.github.com/users/zio/repos","events_url":"https://api.github.com/users/zio/events{/privacy}","received_events_url":"https://api.github.com/users/zio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zio/zio","description":"ZIO — A type-safe, composable library for asynchronous and concurrent programming in Scala","fork":false,"url":"https://api.github.com/repos/zio/zio","forks_url":"https://api.github.com/repos/zio/zio/forks","keys_url":"https://api.github.com/repos/zio/zio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zio/zio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zio/zio/teams","hooks_url":"https://api.github.com/repos/zio/zio/hooks","issue_events_url":"https://api.github.com/repos/zio/zio/issues/events{/number}","events_url":"https://api.github.com/repos/zio/zio/events","assignees_url":"https://api.github.com/repos/zio/zio/assignees{/user}","branches_url":"https://api.github.com/repos/zio/zio/branches{/branch}","tags_url":"https://api.github.com/repos/zio/zio/tags","blobs_url":"https://api.github.com/repos/zio/zio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zio/zio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zio/zio/git/refs{/sha}","trees_url":"https://api.github.com/repos/zio/zio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zio/zio/statuses/{sha}","languages_url":"https://api.github.com/repos/zio/zio/languages","stargazers_url":"https://api.github.com/repos/zio/zio/stargazers","contributors_url":"https://api.github.com/repos/zio/zio/contributors","subscribers_url":"https://api.github.com/repos/zio/zio/subscribers","subscription_url":"https://api.github.com/repos/zio/zio/subscription","commits_url":"https://api.github.com/repos/zio/zio/commits{/sha}","git_commits_url":"https://api.github.com/repos/zio/zio/git/commits{/sha}","comments_url":"https://api.github.com/repos/zio/zio/comments{/number}","issue_comment_url":"https://api.github.com/repos/zio/zio/issues/comments{/number}","contents_url":"https://api.github.com/repos/zio/zio/contents/{+path}","compare_url":"https://api.github.com/repos/zio/zio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zio/zio/merges","archive_url":"https://api.github.com/repos/zio/zio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zio/zio/downloads","issues_url":"https://api.github.com/repos/zio/zio/issues{/number}","pulls_url":"https://api.github.com/repos/zio/zio/pulls{/number}","milestones_url":"https://api.github.com/repos/zio/zio/milestones{/number}","notifications_url":"https://api.github.com/repos/zio/zio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zio/zio/labels{/name}","releases_url":"https://api.github.com/repos/zio/zio/releases{/id}","deployments_url":"https://api.github.com/repos/zio/zio/deployments","created_at":"2018-05-19T16:40:37Z","updated_at":"2019-09-16T15:45:07Z","pushed_at":"2019-09-16T18:14:09Z","git_url":"git://github.com/zio/zio.git","ssh_url":"git@github.com:zio/zio.git","clone_url":"https://github.com/zio/zio.git","svn_url":"https://github.com/zio/zio","homepage":"https://zio.dev","size":59188,"stargazers_count":1485,"watchers_count":1485,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":382,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":143,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":382,"open_issues":143,"watchers":1485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zio/zio/pulls/1688"},"html":{"href":"https://github.com/zio/zio/pull/1688"},"issue":{"href":"https://api.github.com/repos/zio/zio/issues/1688"},"comments":{"href":"https://api.github.com/repos/zio/zio/issues/1688/comments"},"review_comments":{"href":"https://api.github.com/repos/zio/zio/pulls/1688/comments"},"review_comment":{"href":"https://api.github.com/repos/zio/zio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zio/zio/pulls/1688/commits"},"statuses":{"href":"https://api.github.com/repos/zio/zio/statuses/b710976f0216f157d74a5ac70d82b62bf9026d7a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LGLO"}}