{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/laravel/issues/4950","repository_url":"https://api.github.com/repos/laravel/laravel","labels_url":"https://api.github.com/repos/laravel/laravel/issues/4950/labels{/name}","comments_url":"https://api.github.com/repos/laravel/laravel/issues/4950/comments","events_url":"https://api.github.com/repos/laravel/laravel/issues/4950/events","html_url":"https://github.com/laravel/laravel/pull/4950","id":414473995,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2MTc1MTk5","number":4950,"title":"[5.8] Remove docblocks from migrations","user":{"login":"SjorsO","id":7202674,"node_id":"MDQ6VXNlcjcyMDI2NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7202674?v=4","gravatar_id":"","url":"https://api.github.com/users/SjorsO","html_url":"https://github.com/SjorsO","followers_url":"https://api.github.com/users/SjorsO/followers","following_url":"https://api.github.com/users/SjorsO/following{/other_user}","gists_url":"https://api.github.com/users/SjorsO/gists{/gist_id}","starred_url":"https://api.github.com/users/SjorsO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SjorsO/subscriptions","organizations_url":"https://api.github.com/users/SjorsO/orgs","repos_url":"https://api.github.com/users/SjorsO/repos","events_url":"https://api.github.com/users/SjorsO/events{/privacy}","received_events_url":"https://api.github.com/users/SjorsO/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-02-26T07:46:04Z","updated_at":"2019-02-26T15:16:03Z","closed_at":"2019-02-26T13:55:57Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/laravel/laravel/pulls/4950","html_url":"https://github.com/laravel/laravel/pull/4950","diff_url":"https://github.com/laravel/laravel/pull/4950.diff","patch_url":"https://github.com/laravel/laravel/pull/4950.patch"},"body":"This PR removes the default docblocks from the migrations. More than 25% of the lines in the migration files are docblocks, which in this case add no useful information. The files look cleaner without them.\r\n\r\nIf this PR is accepted i'll also submit a PR to remove the docblocks from the migration stubs in the framework repo."},"comment":{"url":"https://api.github.com/repos/laravel/laravel/issues/comments/467477960","html_url":"https://github.com/laravel/laravel/pull/4950#issuecomment-467477960","issue_url":"https://api.github.com/repos/laravel/laravel/issues/4950","id":467477960,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NzQ3Nzk2MA==","user":{"login":"scoutman57","id":885461,"node_id":"MDQ6VXNlcjg4NTQ2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/885461?v=4","gravatar_id":"","url":"https://api.github.com/users/scoutman57","html_url":"https://github.com/scoutman57","followers_url":"https://api.github.com/users/scoutman57/followers","following_url":"https://api.github.com/users/scoutman57/following{/other_user}","gists_url":"https://api.github.com/users/scoutman57/gists{/gist_id}","starred_url":"https://api.github.com/users/scoutman57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scoutman57/subscriptions","organizations_url":"https://api.github.com/users/scoutman57/orgs","repos_url":"https://api.github.com/users/scoutman57/repos","events_url":"https://api.github.com/users/scoutman57/events{/privacy}","received_events_url":"https://api.github.com/users/scoutman57/received_events","type":"User","site_admin":false},"created_at":"2019-02-26T15:16:03Z","updated_at":"2019-02-26T15:16:03Z","author_association":"NONE","body":"Because it's good practice to have doc blocks on all your methods.\n\nOn Tue, Feb 26, 2019 at 9:09 AM Sjors Ottjes <notifications@github.com>\nwrote:\n\n> @taylorotwell <https://github.com/taylorotwell> Could you explain why you\n> would like to keep these docblocks?\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/laravel/laravel/pull/4950#issuecomment-467475012>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AA2C1exye5Y1iKSA3BzmlGBCgQxeAnGUks5vRU40gaJpZM4bRjRZ>\n> .\n>\n"}}
{"actor":{"display_login":"scoutman57"}}