{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/356268467","pull_request_review_id":330133390,"id":356268467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NjI2ODQ2Nw==","diff_hunk":"@@ -0,0 +1,39 @@\n+//===--- Located.h - Source Location and Associated Value ----------*- C++ -*-===//\n+//\n+// This source file is part of the Swift.org open source project\n+//\n+// Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors","path":"include/swift/Basic/Located.h","position":null,"original_position":5,"commit_id":"d411826caffd909cb75a993e7c9abc53ba2d290f","original_commit_id":"1d6f7e15fb7246890e55a5711e44b35b35f51cae","user":{"login":"kitaisreal","id":22458333,"node_id":"MDQ6VXNlcjIyNDU4MzMz","avatar_url":"https://avatars1.githubusercontent.com/u/22458333?v=4","gravatar_id":"","url":"https://api.github.com/users/kitaisreal","html_url":"https://github.com/kitaisreal","followers_url":"https://api.github.com/users/kitaisreal/followers","following_url":"https://api.github.com/users/kitaisreal/following{/other_user}","gists_url":"https://api.github.com/users/kitaisreal/gists{/gist_id}","starred_url":"https://api.github.com/users/kitaisreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitaisreal/subscriptions","organizations_url":"https://api.github.com/users/kitaisreal/orgs","repos_url":"https://api.github.com/users/kitaisreal/repos","events_url":"https://api.github.com/users/kitaisreal/events{/privacy}","received_events_url":"https://api.github.com/users/kitaisreal/received_events","type":"User","site_admin":false},"body":"Sure. Fixed.","created_at":"2019-12-10T20:46:49Z","updated_at":"2019-12-10T20:46:49Z","html_url":"https://github.com/apple/swift/pull/28643#discussion_r356268467","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/28643","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/356268467"},"html":{"href":"https://github.com/apple/swift/pull/28643#discussion_r356268467"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/28643"}},"in_reply_to_id":355620082},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/28643","id":350447983,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwNDQ3OTgz","html_url":"https://github.com/apple/swift/pull/28643","diff_url":"https://github.com/apple/swift/pull/28643.diff","patch_url":"https://github.com/apple/swift/pull/28643.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/28643","number":28643,"state":"open","locked":false,"title":"[Compiler]: Using Located<T> instead of std::pair<SourceLoc, T>","user":{"login":"kitaisreal","id":22458333,"node_id":"MDQ6VXNlcjIyNDU4MzMz","avatar_url":"https://avatars1.githubusercontent.com/u/22458333?v=4","gravatar_id":"","url":"https://api.github.com/users/kitaisreal","html_url":"https://github.com/kitaisreal","followers_url":"https://api.github.com/users/kitaisreal/followers","following_url":"https://api.github.com/users/kitaisreal/following{/other_user}","gists_url":"https://api.github.com/users/kitaisreal/gists{/gist_id}","starred_url":"https://api.github.com/users/kitaisreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitaisreal/subscriptions","organizations_url":"https://api.github.com/users/kitaisreal/orgs","repos_url":"https://api.github.com/users/kitaisreal/repos","events_url":"https://api.github.com/users/kitaisreal/events{/privacy}","received_events_url":"https://api.github.com/users/kitaisreal/received_events","type":"User","site_admin":false},"body":"1. Created Located<T> struct in swift/Basic\r\n2. Updated usages throughout the compiler\r\n\r\nhttps://bugs.swift.org/browse/SR-11889\r\n\r\n@varungandhi-apple ","created_at":"2019-12-08T19:53:34Z","updated_at":"2019-12-10T20:46:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7931d330a12e7c7bb1553b23b43cdee72afe66b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/28643/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/28643/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/28643/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/d411826caffd909cb75a993e7c9abc53ba2d290f","head":{"label":"kitaisreal:using-located-instead-of-pair","ref":"using-located-instead-of-pair","sha":"d411826caffd909cb75a993e7c9abc53ba2d290f","user":{"login":"kitaisreal","id":22458333,"node_id":"MDQ6VXNlcjIyNDU4MzMz","avatar_url":"https://avatars1.githubusercontent.com/u/22458333?v=4","gravatar_id":"","url":"https://api.github.com/users/kitaisreal","html_url":"https://github.com/kitaisreal","followers_url":"https://api.github.com/users/kitaisreal/followers","following_url":"https://api.github.com/users/kitaisreal/following{/other_user}","gists_url":"https://api.github.com/users/kitaisreal/gists{/gist_id}","starred_url":"https://api.github.com/users/kitaisreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitaisreal/subscriptions","organizations_url":"https://api.github.com/users/kitaisreal/orgs","repos_url":"https://api.github.com/users/kitaisreal/repos","events_url":"https://api.github.com/users/kitaisreal/events{/privacy}","received_events_url":"https://api.github.com/users/kitaisreal/received_events","type":"User","site_admin":false},"repo":{"id":223343030,"node_id":"MDEwOlJlcG9zaXRvcnkyMjMzNDMwMzA=","name":"swift","full_name":"kitaisreal/swift","private":false,"owner":{"login":"kitaisreal","id":22458333,"node_id":"MDQ6VXNlcjIyNDU4MzMz","avatar_url":"https://avatars1.githubusercontent.com/u/22458333?v=4","gravatar_id":"","url":"https://api.github.com/users/kitaisreal","html_url":"https://github.com/kitaisreal","followers_url":"https://api.github.com/users/kitaisreal/followers","following_url":"https://api.github.com/users/kitaisreal/following{/other_user}","gists_url":"https://api.github.com/users/kitaisreal/gists{/gist_id}","starred_url":"https://api.github.com/users/kitaisreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitaisreal/subscriptions","organizations_url":"https://api.github.com/users/kitaisreal/orgs","repos_url":"https://api.github.com/users/kitaisreal/repos","events_url":"https://api.github.com/users/kitaisreal/events{/privacy}","received_events_url":"https://api.github.com/users/kitaisreal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kitaisreal/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/kitaisreal/swift","forks_url":"https://api.github.com/repos/kitaisreal/swift/forks","keys_url":"https://api.github.com/repos/kitaisreal/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kitaisreal/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kitaisreal/swift/teams","hooks_url":"https://api.github.com/repos/kitaisreal/swift/hooks","issue_events_url":"https://api.github.com/repos/kitaisreal/swift/issues/events{/number}","events_url":"https://api.github.com/repos/kitaisreal/swift/events","assignees_url":"https://api.github.com/repos/kitaisreal/swift/assignees{/user}","branches_url":"https://api.github.com/repos/kitaisreal/swift/branches{/branch}","tags_url":"https://api.github.com/repos/kitaisreal/swift/tags","blobs_url":"https://api.github.com/repos/kitaisreal/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kitaisreal/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kitaisreal/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/kitaisreal/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kitaisreal/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/kitaisreal/swift/languages","stargazers_url":"https://api.github.com/repos/kitaisreal/swift/stargazers","contributors_url":"https://api.github.com/repos/kitaisreal/swift/contributors","subscribers_url":"https://api.github.com/repos/kitaisreal/swift/subscribers","subscription_url":"https://api.github.com/repos/kitaisreal/swift/subscription","commits_url":"https://api.github.com/repos/kitaisreal/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/kitaisreal/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/kitaisreal/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/kitaisreal/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/kitaisreal/swift/contents/{+path}","compare_url":"https://api.github.com/repos/kitaisreal/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kitaisreal/swift/merges","archive_url":"https://api.github.com/repos/kitaisreal/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kitaisreal/swift/downloads","issues_url":"https://api.github.com/repos/kitaisreal/swift/issues{/number}","pulls_url":"https://api.github.com/repos/kitaisreal/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/kitaisreal/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/kitaisreal/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kitaisreal/swift/labels{/name}","releases_url":"https://api.github.com/repos/kitaisreal/swift/releases{/id}","deployments_url":"https://api.github.com/repos/kitaisreal/swift/deployments","created_at":"2019-11-22T06:58:36Z","updated_at":"2019-11-22T14:26:29Z","pushed_at":"2019-12-10T20:46:33Z","git_url":"git://github.com/kitaisreal/swift.git","ssh_url":"git@github.com:kitaisreal/swift.git","clone_url":"https://github.com/kitaisreal/swift.git","svn_url":"https://github.com/kitaisreal/swift","homepage":"https://swift.org","size":509660,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"171987a4ca6a12d18dd02d4ffd5b017e82dd2ea0","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2019-12-10T19:56:48Z","pushed_at":"2019-12-10T20:46:40Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":514411,"stargazers_count":50002,"watchers_count":50002,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8082,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":424,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8082,"open_issues":424,"watchers":50002,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/28643"},"html":{"href":"https://github.com/apple/swift/pull/28643"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/28643"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/28643/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/28643/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/28643/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/d411826caffd909cb75a993e7c9abc53ba2d290f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kitaisreal"}}