{"action":"created","issue":{"url":"https://api.github.com/repos/keymanapp/keyboards/issues/915","repository_url":"https://api.github.com/repos/keymanapp/keyboards","labels_url":"https://api.github.com/repos/keymanapp/keyboards/issues/915/labels{/name}","comments_url":"https://api.github.com/repos/keymanapp/keyboards/issues/915/comments","events_url":"https://api.github.com/repos/keymanapp/keyboards/issues/915/events","html_url":"https://github.com/keymanapp/keyboards/pull/915","id":509482315,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwMDM5MTAy","number":915,"title":"Final Landuma keyboard","user":{"login":"leepartridge","id":44616807,"node_id":"MDQ6VXNlcjQ0NjE2ODA3","avatar_url":"https://avatars1.githubusercontent.com/u/44616807?v=4","gravatar_id":"","url":"https://api.github.com/users/leepartridge","html_url":"https://github.com/leepartridge","followers_url":"https://api.github.com/users/leepartridge/followers","following_url":"https://api.github.com/users/leepartridge/following{/other_user}","gists_url":"https://api.github.com/users/leepartridge/gists{/gist_id}","starred_url":"https://api.github.com/users/leepartridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leepartridge/subscriptions","organizations_url":"https://api.github.com/users/leepartridge/orgs","repos_url":"https://api.github.com/users/leepartridge/repos","events_url":"https://api.github.com/users/leepartridge/events{/privacy}","received_events_url":"https://api.github.com/users/leepartridge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-10-19T17:16:14Z","updated_at":"2019-10-21T22:52:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/keymanapp/keyboards/pulls/915","html_url":"https://github.com/keymanapp/keyboards/pull/915","diff_url":"https://github.com/keymanapp/keyboards/pull/915.diff","patch_url":"https://github.com/keymanapp/keyboards/pull/915.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/keymanapp/keyboards/issues/comments/544741272","html_url":"https://github.com/keymanapp/keyboards/pull/915#issuecomment-544741272","issue_url":"https://api.github.com/repos/keymanapp/keyboards/issues/915","id":544741272,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NDc0MTI3Mg==","user":{"login":"leepartridge","id":44616807,"node_id":"MDQ6VXNlcjQ0NjE2ODA3","avatar_url":"https://avatars1.githubusercontent.com/u/44616807?v=4","gravatar_id":"","url":"https://api.github.com/users/leepartridge","html_url":"https://github.com/leepartridge","followers_url":"https://api.github.com/users/leepartridge/followers","following_url":"https://api.github.com/users/leepartridge/following{/other_user}","gists_url":"https://api.github.com/users/leepartridge/gists{/gist_id}","starred_url":"https://api.github.com/users/leepartridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leepartridge/subscriptions","organizations_url":"https://api.github.com/users/leepartridge/orgs","repos_url":"https://api.github.com/users/leepartridge/repos","events_url":"https://api.github.com/users/leepartridge/events{/privacy}","received_events_url":"https://api.github.com/users/leepartridge/received_events","type":"User","site_admin":false},"created_at":"2019-10-21T22:52:04Z","updated_at":"2019-10-21T22:52:04Z","author_association":"CONTRIBUTOR","body":"I have made the changes to the .kpj file and have attached it to this email. I noticed you had two forward slashes (//) in release//shared/fonts/sil so I inserted it that way, not sure what the significance is. When I looked at my folders I don't see the same layout you are describing, but it is late so I will look at it tomorrow. I looked at Github but could not find the files there. Tomorrow is another day.\r\nThanks for your help,\r\nLee\r\n\r\nOn Mon, Oct 21, 2019 at 6:04 PM DavidLRowe <notifications@github.com<mailto:notifications@github.com>> wrote:\r\n\r\nHello, Lee. There are some extra files present in this pull request that will need to be removed (details below) and some files are in the wrong locations for the Keyman build system.\r\n\r\nSo, first of all, the project file (.kpj) needs to specify the BuildPath as $PROJECTPATH\\build which will cause the compiled items (.kmx, .js, .kvk, .kmp) to be placed in a build folder. Note that this means that the .kps (Keyman package source) file will need to reference the .kmx, .js and .kvk files in the build folder (rather than the project folder as currently is the case).\r\n\r\nremove from project folder (release/l/landuma):\r\n\r\n  *   l.bmp\r\n  *   landuma-Image.bmp\r\n  *   landuma.js\r\n  *   landuma.keyman-touch-layout\r\n  *   landuma.kmn\r\n  *   landuma.kmp\r\n  *   landuma.kps\r\n  *   landuma.kvks\r\n  *   readme.htm\r\n  *   welcome.htm\r\n\r\nremove from source folder (release/l/landuma):\r\n\r\n  *   landuma.js\r\n  *   landuma.kmp\r\n  *   landuma.kmx\r\n  *   landuma.kpj\r\n  *   landuma.kpj.user\r\n  *   landuma.kvk\r\n\r\nFix the paths in the remaining .kps file (the one in the source folder)\r\n\r\n  *   remove l.bmp from list of files\r\n  *   change .kmx, .js, .kvk to reference files in build folder (easiest to remove them from the list of files, then add them back in the right place)\r\n\r\nOne last change to the .kps file is for the font. It's perfectly acceptable to leave out the font and let the user install it. If you want to include the Andika font, we prefer that you reference it from release//shared/fonts/sil (so that we can have one copy of the font and its license files in the repository used by any keyboard that needs it). BUT I see that we do not have Andika in that folder, so we would need to add it. (@LornaSIL<https://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLornaSIL&data=02%7C01%7C%7C24a7f1ee7e594cb7e2df08d756729c0f%7C81e970b72efb4db18bd6613e99b6852b%7C0%7C0%7C637072922550624532&sdata=lSXJ0OkOpqqD4IZnQygp6HZg5RsydNCMTJMp97isDa0%3D&reserved=0> usually does that and she's not currently in the office, so it might be a week or two before that could happen.)\r\n\r\nLet me know if you have further questions.\r\n\r\n—\r\nYou are receiving this because you authored the thread.\r\nReply to this email directly, view it on GitHub<https://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkeymanapp%2Fkeyboards%2Fpull%2F915%3Femail_source%3Dnotifications%26email_token%3DAKUMYZ5E2VWAK3E3WALDTRTQPYRN3A5CNFSM4JCQU65KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB36EEI%23issuecomment-544727569&data=02%7C01%7C%7C24a7f1ee7e594cb7e2df08d756729c0f%7C81e970b72efb4db18bd6613e99b6852b%7C0%7C0%7C637072922550634529&sdata=YH790PSL9wyA18A9k29Bq6qliLjNrmVuI3E7WkzG6aM%3D&reserved=0>, or unsubscribe<https://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKUMYZYNKJDMORKMTXPBV5DQPYRN3ANCNFSM4JCQU65A&data=02%7C01%7C%7C24a7f1ee7e594cb7e2df08d756729c0f%7C81e970b72efb4db18bd6613e99b6852b%7C0%7C0%7C637072922550634529&sdata=mNaRAl3yWxhcBL4dt86bhMchf7OyPl76Sg7Rs0lV5q4%3D&reserved=0>.\r\n\r\n\r\n--\r\nNOTICE: This e-mail message and any attachment to this e-mail message may contain confidential information that may be legally privileged. If you are not the intended recipient, you must not review, retransmit, convert to hard copy, copy, use or disseminate this e-mail or any attachments to it. This e-mail is covered by the Electronic Communications Privacy Act, 18 U.S.C. Sections 2510-2521 and is legally privileged. The information contained in this e-mail is intended only for use of the individual or entity named above. If the reader of this message is not the intended recipient, or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify us immediately by return e-mail.\r\n__________________________________________\r\nLinux Mint: I wanted reliable, this is reliable. Wow!\r\n"}}
{"actor":{"display_login":"leepartridge"}}