{"action":"closed","number":3478,"pull_request":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/3478","id":263091479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzMDkxNDc5","html_url":"https://github.com/eclipse/jetty.project/pull/3478","diff_url":"https://github.com/eclipse/jetty.project/pull/3478.diff","patch_url":"https://github.com/eclipse/jetty.project/pull/3478.patch","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/3478","number":3478,"state":"closed","locked":false,"title":"Issue #3465 - WebSocket Extension Negotiation","user":{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false},"body":"#3465\r\n\r\n- Negotiated now excludes duplicate extension names when setting the negotiated extensions from offered extensions\r\n\r\n- do not allow internal extensions to be offered by the client and do not validate internal extensions when set\r\n\r\n- Throw exception on websocket errors so the proper status code can be reported back to the client\r\n- WebSocketMapping no longer catches the exceptions and warns but allows them to be caught at a higher level so the appropriate response can be returned\r\n\r\n- added tests in core and jetty-websocket to test the negotiation\r\n","created_at":"2019-03-21T01:27:24Z","updated_at":"2019-03-26T22:19:47Z","closed_at":"2019-03-26T22:19:47Z","merged_at":"2019-03-26T22:19:47Z","merge_commit_sha":"3d16eba83969ffadc9f0209206588ae0937882ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/3478/commits","review_comments_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/3478/comments","review_comment_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/3478/comments","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/46ef94c1b9bc5fa6a421859d1f97f932d0db71cb","head":{"label":"lachlan-roberts:jetty-10.0.x-3465-extension-negotiation","ref":"jetty-10.0.x-3465-extension-negotiation","sha":"46ef94c1b9bc5fa6a421859d1f97f932d0db71cb","user":{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false},"repo":{"id":123038728,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwMzg3Mjg=","name":"jetty.project","full_name":"lachlan-roberts/jetty.project","private":false,"owner":{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lachlan-roberts/jetty.project","description":"Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more","fork":true,"url":"https://api.github.com/repos/lachlan-roberts/jetty.project","forks_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/forks","keys_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/teams","hooks_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/hooks","issue_events_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/issues/events{/number}","events_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/events","assignees_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/assignees{/user}","branches_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/branches{/branch}","tags_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/tags","blobs_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/refs{/sha}","trees_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/statuses/{sha}","languages_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/languages","stargazers_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/stargazers","contributors_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/contributors","subscribers_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/subscribers","subscription_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/subscription","commits_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/commits{/sha}","git_commits_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/commits{/sha}","comments_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/comments{/number}","issue_comment_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/issues/comments{/number}","contents_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/contents/{+path}","compare_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/merges","archive_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/downloads","issues_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/issues{/number}","pulls_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/pulls{/number}","milestones_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/milestones{/number}","notifications_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/labels{/name}","releases_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/releases{/id}","deployments_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/deployments","created_at":"2018-02-26T22:23:22Z","updated_at":"2019-03-26T00:52:39Z","pushed_at":"2019-03-26T06:09:57Z","git_url":"git://github.com/lachlan-roberts/jetty.project.git","ssh_url":"git@github.com:lachlan-roberts/jetty.project.git","clone_url":"https://github.com/lachlan-roberts/jetty.project.git","svn_url":"https://github.com/lachlan-roberts/jetty.project","homepage":"https://www.eclipse.org/jetty","size":121625,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"jetty-9.4.x"}},"base":{"label":"eclipse:jetty-10.0.x","ref":"jetty-10.0.x","sha":"e01eefe40e553b0af192c2a76ea776202018507c","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":2045207,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ1MjA3","name":"jetty.project","full_name":"eclipse/jetty.project","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/jetty.project","description":"Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more","fork":false,"url":"https://api.github.com/repos/eclipse/jetty.project","forks_url":"https://api.github.com/repos/eclipse/jetty.project/forks","keys_url":"https://api.github.com/repos/eclipse/jetty.project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/jetty.project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/jetty.project/teams","hooks_url":"https://api.github.com/repos/eclipse/jetty.project/hooks","issue_events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/jetty.project/events","assignees_url":"https://api.github.com/repos/eclipse/jetty.project/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/jetty.project/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/jetty.project/tags","blobs_url":"https://api.github.com/repos/eclipse/jetty.project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/jetty.project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/jetty.project/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/jetty.project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/jetty.project/languages","stargazers_url":"https://api.github.com/repos/eclipse/jetty.project/stargazers","contributors_url":"https://api.github.com/repos/eclipse/jetty.project/contributors","subscribers_url":"https://api.github.com/repos/eclipse/jetty.project/subscribers","subscription_url":"https://api.github.com/repos/eclipse/jetty.project/subscription","commits_url":"https://api.github.com/repos/eclipse/jetty.project/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/jetty.project/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/jetty.project/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/jetty.project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/jetty.project/merges","archive_url":"https://api.github.com/repos/eclipse/jetty.project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/jetty.project/downloads","issues_url":"https://api.github.com/repos/eclipse/jetty.project/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/jetty.project/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/jetty.project/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/jetty.project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/jetty.project/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/jetty.project/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/jetty.project/deployments","created_at":"2011-07-14T01:11:57Z","updated_at":"2019-03-26T01:01:19Z","pushed_at":"2019-03-26T22:19:47Z","git_url":"git://github.com/eclipse/jetty.project.git","ssh_url":"git@github.com:eclipse/jetty.project.git","clone_url":"https://github.com/eclipse/jetty.project.git","svn_url":"https://github.com/eclipse/jetty.project","homepage":"https://www.eclipse.org/jetty","size":124167,"stargazers_count":2421,"watchers_count":2421,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1335,"mirror_url":null,"archived":false,"open_issues_count":399,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1335,"open_issues":399,"watchers":2421,"default_branch":"jetty-9.4.x"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/3478"},"html":{"href":"https://github.com/eclipse/jetty.project/pull/3478"},"issue":{"href":"https://api.github.com/repos/eclipse/jetty.project/issues/3478"},"comments":{"href":"https://api.github.com/repos/eclipse/jetty.project/issues/3478/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/3478/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/3478/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/jetty.project/statuses/46ef94c1b9bc5fa6a421859d1f97f932d0db71cb"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gregw","id":70829,"node_id":"MDQ6VXNlcjcwODI5","avatar_url":"https://avatars2.githubusercontent.com/u/70829?v=4","gravatar_id":"","url":"https://api.github.com/users/gregw","html_url":"https://github.com/gregw","followers_url":"https://api.github.com/users/gregw/followers","following_url":"https://api.github.com/users/gregw/following{/other_user}","gists_url":"https://api.github.com/users/gregw/gists{/gist_id}","starred_url":"https://api.github.com/users/gregw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregw/subscriptions","organizations_url":"https://api.github.com/users/gregw/orgs","repos_url":"https://api.github.com/users/gregw/repos","events_url":"https://api.github.com/users/gregw/events{/privacy}","received_events_url":"https://api.github.com/users/gregw/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":4,"additions":690,"deletions":249,"changed_files":23}}
{"actor":{"display_login":"gregw"}}