{"action":"created","comment":{"url":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/comments/320779258","pull_request_review_id":283642091,"id":320779258,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDc3OTI1OA==","diff_hunk":"@@ -0,0 +1,502 @@\n+#include <fastrtps/types/DynamicTypePtr.h>\n+#include <fastrtps/types/TypeObjectHashId.h>\n+#include <fastrtps/types/TypeObject.h>\n+namespace eprosima{\n+\n+namespace fastcdr{\n+    class Cdr ;\n+}\n+namespace fastrtps{\n+\n+namespace types{\n+    class DynamicData ;\n+}\n+\n+namespace serializer{\n+\n+/*********************\n+ *     SERIALIZER    *\n+ *********************/\n+\t\n+template<class Serializable>\n+class Serializer{\n+private:\n+    Serializer() = delete ;\n+public:\n+    Serializer<Serializable>(Serializable *p):p_(p){}\n+    \n+    void serialize(eprosima::fastcdr::Cdr& cdr)\n+\t\t\t\t{","path":"include/fastrtps/serializer/serializer.h","position":29,"original_position":29,"commit_id":"49e32e31601ce1e25374491073723a1541ccaf21","original_commit_id":"49e32e31601ce1e25374491073723a1541ccaf21","user":{"login":"LuisGP","id":5285735,"node_id":"MDQ6VXNlcjUyODU3MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/5285735?v=4","gravatar_id":"","url":"https://api.github.com/users/LuisGP","html_url":"https://github.com/LuisGP","followers_url":"https://api.github.com/users/LuisGP/followers","following_url":"https://api.github.com/users/LuisGP/following{/other_user}","gists_url":"https://api.github.com/users/LuisGP/gists{/gist_id}","starred_url":"https://api.github.com/users/LuisGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuisGP/subscriptions","organizations_url":"https://api.github.com/users/LuisGP/orgs","repos_url":"https://api.github.com/users/LuisGP/repos","events_url":"https://api.github.com/users/LuisGP/events{/privacy}","received_events_url":"https://api.github.com/users/LuisGP/received_events","type":"User","site_admin":false},"body":"Remove tabs, use 4 spaces.\r\nYou can automatize replacing tabs with 4 spaces and removing trailing spaces at save time in your favorite editor.","created_at":"2019-09-04T14:07:05Z","updated_at":"2019-09-04T14:33:20Z","html_url":"https://github.com/eProsima/Fast-RTPS/pull/683#discussion_r320779258","pull_request_url":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/683","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/comments/320779258"},"html":{"href":"https://github.com/eProsima/Fast-RTPS/pull/683#discussion_r320779258"},"pull_request":{"href":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/683"}}},"pull_request":{"url":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/683","id":312236504,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyMjM2NTA0","html_url":"https://github.com/eProsima/Fast-RTPS/pull/683","diff_url":"https://github.com/eProsima/Fast-RTPS/pull/683.diff","patch_url":"https://github.com/eProsima/Fast-RTPS/pull/683.patch","issue_url":"https://api.github.com/repos/eProsima/Fast-RTPS/issues/683","number":683,"state":"open","locked":false,"title":"Feature/discovery time data typing dyn type dev","user":{"login":"franava","id":52208724,"node_id":"MDQ6VXNlcjUyMjA4NzI0","avatar_url":"https://avatars0.githubusercontent.com/u/52208724?v=4","gravatar_id":"","url":"https://api.github.com/users/franava","html_url":"https://github.com/franava","followers_url":"https://api.github.com/users/franava/followers","following_url":"https://api.github.com/users/franava/following{/other_user}","gists_url":"https://api.github.com/users/franava/gists{/gist_id}","starred_url":"https://api.github.com/users/franava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franava/subscriptions","organizations_url":"https://api.github.com/users/franava/orgs","repos_url":"https://api.github.com/users/franava/repos","events_url":"https://api.github.com/users/franava/events{/privacy}","received_events_url":"https://api.github.com/users/franava/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-29T09:55:42Z","updated_at":"2019-09-04T14:33:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8653cf32cf5a1f8708ea05df2d223ced85ed38fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/683/commits","review_comments_url":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/683/comments","review_comment_url":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eProsima/Fast-RTPS/issues/683/comments","statuses_url":"https://api.github.com/repos/eProsima/Fast-RTPS/statuses/49e32e31601ce1e25374491073723a1541ccaf21","head":{"label":"eProsima:feature/discovery_time_data_typing_dyn_type_dev","ref":"feature/discovery_time_data_typing_dyn_type_dev","sha":"49e32e31601ce1e25374491073723a1541ccaf21","user":{"login":"eProsima","id":6390783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTA3ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6390783?v=4","gravatar_id":"","url":"https://api.github.com/users/eProsima","html_url":"https://github.com/eProsima","followers_url":"https://api.github.com/users/eProsima/followers","following_url":"https://api.github.com/users/eProsima/following{/other_user}","gists_url":"https://api.github.com/users/eProsima/gists{/gist_id}","starred_url":"https://api.github.com/users/eProsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eProsima/subscriptions","organizations_url":"https://api.github.com/users/eProsima/orgs","repos_url":"https://api.github.com/users/eProsima/repos","events_url":"https://api.github.com/users/eProsima/events{/privacy}","received_events_url":"https://api.github.com/users/eProsima/received_events","type":"Organization","site_admin":false},"repo":{"id":20296703,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI5NjcwMw==","name":"Fast-RTPS","full_name":"eProsima/Fast-RTPS","private":false,"owner":{"login":"eProsima","id":6390783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTA3ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6390783?v=4","gravatar_id":"","url":"https://api.github.com/users/eProsima","html_url":"https://github.com/eProsima","followers_url":"https://api.github.com/users/eProsima/followers","following_url":"https://api.github.com/users/eProsima/following{/other_user}","gists_url":"https://api.github.com/users/eProsima/gists{/gist_id}","starred_url":"https://api.github.com/users/eProsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eProsima/subscriptions","organizations_url":"https://api.github.com/users/eProsima/orgs","repos_url":"https://api.github.com/users/eProsima/repos","events_url":"https://api.github.com/users/eProsima/events{/privacy}","received_events_url":"https://api.github.com/users/eProsima/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eProsima/Fast-RTPS","description":"Implementation of RTPS Standard","fork":false,"url":"https://api.github.com/repos/eProsima/Fast-RTPS","forks_url":"https://api.github.com/repos/eProsima/Fast-RTPS/forks","keys_url":"https://api.github.com/repos/eProsima/Fast-RTPS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eProsima/Fast-RTPS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eProsima/Fast-RTPS/teams","hooks_url":"https://api.github.com/repos/eProsima/Fast-RTPS/hooks","issue_events_url":"https://api.github.com/repos/eProsima/Fast-RTPS/issues/events{/number}","events_url":"https://api.github.com/repos/eProsima/Fast-RTPS/events","assignees_url":"https://api.github.com/repos/eProsima/Fast-RTPS/assignees{/user}","branches_url":"https://api.github.com/repos/eProsima/Fast-RTPS/branches{/branch}","tags_url":"https://api.github.com/repos/eProsima/Fast-RTPS/tags","blobs_url":"https://api.github.com/repos/eProsima/Fast-RTPS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eProsima/Fast-RTPS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eProsima/Fast-RTPS/git/refs{/sha}","trees_url":"https://api.github.com/repos/eProsima/Fast-RTPS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eProsima/Fast-RTPS/statuses/{sha}","languages_url":"https://api.github.com/repos/eProsima/Fast-RTPS/languages","stargazers_url":"https://api.github.com/repos/eProsima/Fast-RTPS/stargazers","contributors_url":"https://api.github.com/repos/eProsima/Fast-RTPS/contributors","subscribers_url":"https://api.github.com/repos/eProsima/Fast-RTPS/subscribers","subscription_url":"https://api.github.com/repos/eProsima/Fast-RTPS/subscription","commits_url":"https://api.github.com/repos/eProsima/Fast-RTPS/commits{/sha}","git_commits_url":"https://api.github.com/repos/eProsima/Fast-RTPS/git/commits{/sha}","comments_url":"https://api.github.com/repos/eProsima/Fast-RTPS/comments{/number}","issue_comment_url":"https://api.github.com/repos/eProsima/Fast-RTPS/issues/comments{/number}","contents_url":"https://api.github.com/repos/eProsima/Fast-RTPS/contents/{+path}","compare_url":"https://api.github.com/repos/eProsima/Fast-RTPS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eProsima/Fast-RTPS/merges","archive_url":"https://api.github.com/repos/eProsima/Fast-RTPS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eProsima/Fast-RTPS/downloads","issues_url":"https://api.github.com/repos/eProsima/Fast-RTPS/issues{/number}","pulls_url":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls{/number}","milestones_url":"https://api.github.com/repos/eProsima/Fast-RTPS/milestones{/number}","notifications_url":"https://api.github.com/repos/eProsima/Fast-RTPS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eProsima/Fast-RTPS/labels{/name}","releases_url":"https://api.github.com/repos/eProsima/Fast-RTPS/releases{/id}","deployments_url":"https://api.github.com/repos/eProsima/Fast-RTPS/deployments","created_at":"2014-05-29T14:36:15Z","updated_at":"2019-09-04T12:32:19Z","pushed_at":"2019-09-04T13:19:26Z","git_url":"git://github.com/eProsima/Fast-RTPS.git","ssh_url":"git@github.com:eProsima/Fast-RTPS.git","clone_url":"https://github.com/eProsima/Fast-RTPS.git","svn_url":"https://github.com/eProsima/Fast-RTPS","homepage":null,"size":75968,"stargazers_count":368,"watchers_count":368,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":152,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":69,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":152,"open_issues":69,"watchers":368,"default_branch":"master"}},"base":{"label":"eProsima:feature/discovery_time_data_typing_dyn_type_mod","ref":"feature/discovery_time_data_typing_dyn_type_mod","sha":"e53524630708f407086c74aaff3b4b5dfa746777","user":{"login":"eProsima","id":6390783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTA3ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6390783?v=4","gravatar_id":"","url":"https://api.github.com/users/eProsima","html_url":"https://github.com/eProsima","followers_url":"https://api.github.com/users/eProsima/followers","following_url":"https://api.github.com/users/eProsima/following{/other_user}","gists_url":"https://api.github.com/users/eProsima/gists{/gist_id}","starred_url":"https://api.github.com/users/eProsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eProsima/subscriptions","organizations_url":"https://api.github.com/users/eProsima/orgs","repos_url":"https://api.github.com/users/eProsima/repos","events_url":"https://api.github.com/users/eProsima/events{/privacy}","received_events_url":"https://api.github.com/users/eProsima/received_events","type":"Organization","site_admin":false},"repo":{"id":20296703,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI5NjcwMw==","name":"Fast-RTPS","full_name":"eProsima/Fast-RTPS","private":false,"owner":{"login":"eProsima","id":6390783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTA3ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6390783?v=4","gravatar_id":"","url":"https://api.github.com/users/eProsima","html_url":"https://github.com/eProsima","followers_url":"https://api.github.com/users/eProsima/followers","following_url":"https://api.github.com/users/eProsima/following{/other_user}","gists_url":"https://api.github.com/users/eProsima/gists{/gist_id}","starred_url":"https://api.github.com/users/eProsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eProsima/subscriptions","organizations_url":"https://api.github.com/users/eProsima/orgs","repos_url":"https://api.github.com/users/eProsima/repos","events_url":"https://api.github.com/users/eProsima/events{/privacy}","received_events_url":"https://api.github.com/users/eProsima/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eProsima/Fast-RTPS","description":"Implementation of RTPS Standard","fork":false,"url":"https://api.github.com/repos/eProsima/Fast-RTPS","forks_url":"https://api.github.com/repos/eProsima/Fast-RTPS/forks","keys_url":"https://api.github.com/repos/eProsima/Fast-RTPS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eProsima/Fast-RTPS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eProsima/Fast-RTPS/teams","hooks_url":"https://api.github.com/repos/eProsima/Fast-RTPS/hooks","issue_events_url":"https://api.github.com/repos/eProsima/Fast-RTPS/issues/events{/number}","events_url":"https://api.github.com/repos/eProsima/Fast-RTPS/events","assignees_url":"https://api.github.com/repos/eProsima/Fast-RTPS/assignees{/user}","branches_url":"https://api.github.com/repos/eProsima/Fast-RTPS/branches{/branch}","tags_url":"https://api.github.com/repos/eProsima/Fast-RTPS/tags","blobs_url":"https://api.github.com/repos/eProsima/Fast-RTPS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eProsima/Fast-RTPS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eProsima/Fast-RTPS/git/refs{/sha}","trees_url":"https://api.github.com/repos/eProsima/Fast-RTPS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eProsima/Fast-RTPS/statuses/{sha}","languages_url":"https://api.github.com/repos/eProsima/Fast-RTPS/languages","stargazers_url":"https://api.github.com/repos/eProsima/Fast-RTPS/stargazers","contributors_url":"https://api.github.com/repos/eProsima/Fast-RTPS/contributors","subscribers_url":"https://api.github.com/repos/eProsima/Fast-RTPS/subscribers","subscription_url":"https://api.github.com/repos/eProsima/Fast-RTPS/subscription","commits_url":"https://api.github.com/repos/eProsima/Fast-RTPS/commits{/sha}","git_commits_url":"https://api.github.com/repos/eProsima/Fast-RTPS/git/commits{/sha}","comments_url":"https://api.github.com/repos/eProsima/Fast-RTPS/comments{/number}","issue_comment_url":"https://api.github.com/repos/eProsima/Fast-RTPS/issues/comments{/number}","contents_url":"https://api.github.com/repos/eProsima/Fast-RTPS/contents/{+path}","compare_url":"https://api.github.com/repos/eProsima/Fast-RTPS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eProsima/Fast-RTPS/merges","archive_url":"https://api.github.com/repos/eProsima/Fast-RTPS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eProsima/Fast-RTPS/downloads","issues_url":"https://api.github.com/repos/eProsima/Fast-RTPS/issues{/number}","pulls_url":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls{/number}","milestones_url":"https://api.github.com/repos/eProsima/Fast-RTPS/milestones{/number}","notifications_url":"https://api.github.com/repos/eProsima/Fast-RTPS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eProsima/Fast-RTPS/labels{/name}","releases_url":"https://api.github.com/repos/eProsima/Fast-RTPS/releases{/id}","deployments_url":"https://api.github.com/repos/eProsima/Fast-RTPS/deployments","created_at":"2014-05-29T14:36:15Z","updated_at":"2019-09-04T12:32:19Z","pushed_at":"2019-09-04T13:19:26Z","git_url":"git://github.com/eProsima/Fast-RTPS.git","ssh_url":"git@github.com:eProsima/Fast-RTPS.git","clone_url":"https://github.com/eProsima/Fast-RTPS.git","svn_url":"https://github.com/eProsima/Fast-RTPS","homepage":null,"size":75968,"stargazers_count":368,"watchers_count":368,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":152,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":69,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":152,"open_issues":69,"watchers":368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/683"},"html":{"href":"https://github.com/eProsima/Fast-RTPS/pull/683"},"issue":{"href":"https://api.github.com/repos/eProsima/Fast-RTPS/issues/683"},"comments":{"href":"https://api.github.com/repos/eProsima/Fast-RTPS/issues/683/comments"},"review_comments":{"href":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/683/comments"},"review_comment":{"href":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eProsima/Fast-RTPS/pulls/683/commits"},"statuses":{"href":"https://api.github.com/repos/eProsima/Fast-RTPS/statuses/49e32e31601ce1e25374491073723a1541ccaf21"}},"author_association":"NONE"}}
{"actor":{"display_login":"LuisGP"}}