{"action":"created","comment":{"url":"https://api.github.com/repos/OperationCode/front-end/pulls/comments/281844077","pull_request_review_id":234780246,"id":281844077,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTg0NDA3Nw==","diff_hunk":"@@ -70,10 +70,20 @@ export default class SchoolCard extends Component {\n \n     return (\n       <Card className={styles.SchoolCard} hasAnimationOnHover={false} data-testid=\"SchoolCard\">\n-        {hasGiBill && <div className={styles.giBillRibbon}>GI Bill</div>}\n+        {hasGiBill && (\n+          <div className={styles.giBillRibbon} data-testid=\"GI Bill Ribbon\">\n+            GI Bill\n+          </div>\n+        )}\n \n         <div className={styles.cardBrand}>\n-          <img src={props.logoSource} alt={`${props.name} logo`} height=\"150\" />\n+          <img\n+            src={props.logoSource}\n+            alt={`${props.name} logo`}\n+            data-testid=\"School logo\"\n+            height=\"150\"\n+          />\n+          <p>{props.name}</p>","path":"components/Cards/SchoolCard/SchoolCard.js","position":19,"original_position":19,"commit_id":"9aec9f79571596b534eccdec2e1d695cbc3fde30","original_commit_id":"9aec9f79571596b534eccdec2e1d695cbc3fde30","user":{"login":"kylemh","id":9523719,"node_id":"MDQ6VXNlcjk1MjM3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9523719?v=4","gravatar_id":"","url":"https://api.github.com/users/kylemh","html_url":"https://github.com/kylemh","followers_url":"https://api.github.com/users/kylemh/followers","following_url":"https://api.github.com/users/kylemh/following{/other_user}","gists_url":"https://api.github.com/users/kylemh/gists{/gist_id}","starred_url":"https://api.github.com/users/kylemh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylemh/subscriptions","organizations_url":"https://api.github.com/users/kylemh/orgs","repos_url":"https://api.github.com/users/kylemh/repos","events_url":"https://api.github.com/users/kylemh/events{/privacy}","received_events_url":"https://api.github.com/users/kylemh/received_events","type":"User","site_admin":false},"body":"So, we don't want to change the component so drastically (adding new elements) just for the sake of the test, so you should remove this line; however, your tests have highlighted an issue with our current SchoolCard implementation. Users that navigate the web with screen readers, will be left to assume the name of the Code School via the image's alt tag - that's not ideal.\r\n\r\nLet's use the `ScreenReaderOnly` component at the top of the card to declare the name of the code school. Blind users will be happier, and our tests should be very simple.","created_at":"2019-05-07T21:53:19Z","updated_at":"2019-05-07T21:53:45Z","html_url":"https://github.com/OperationCode/front-end/pull/468#discussion_r281844077","pull_request_url":"https://api.github.com/repos/OperationCode/front-end/pulls/468","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/comments/281844077"},"html":{"href":"https://github.com/OperationCode/front-end/pull/468#discussion_r281844077"},"pull_request":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/468"}}},"pull_request":{"url":"https://api.github.com/repos/OperationCode/front-end/pulls/468","id":276473113,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2NDczMTEz","html_url":"https://github.com/OperationCode/front-end/pull/468","diff_url":"https://github.com/OperationCode/front-end/pull/468.diff","patch_url":"https://github.com/OperationCode/front-end/pull/468.patch","issue_url":"https://api.github.com/repos/OperationCode/front-end/issues/468","number":468,"state":"open","locked":false,"title":"Added render tests for code schools","user":{"login":"phongvdoan","id":30167817,"node_id":"MDQ6VXNlcjMwMTY3ODE3","avatar_url":"https://avatars3.githubusercontent.com/u/30167817?v=4","gravatar_id":"","url":"https://api.github.com/users/phongvdoan","html_url":"https://github.com/phongvdoan","followers_url":"https://api.github.com/users/phongvdoan/followers","following_url":"https://api.github.com/users/phongvdoan/following{/other_user}","gists_url":"https://api.github.com/users/phongvdoan/gists{/gist_id}","starred_url":"https://api.github.com/users/phongvdoan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phongvdoan/subscriptions","organizations_url":"https://api.github.com/users/phongvdoan/orgs","repos_url":"https://api.github.com/users/phongvdoan/repos","events_url":"https://api.github.com/users/phongvdoan/events{/privacy}","received_events_url":"https://api.github.com/users/phongvdoan/received_events","type":"User","site_admin":false},"body":"# Description of changes\r\n<!-- What does this PR change and why -->\r\nAdded tests for inputting 'Ohio', clicking on VA Approved Schools, and inputting  'Alaska \r\n# Issue Resolved\r\n<!-- Keeping the format 'Fixes #{ISSUE_NUMBER}' will automatically close the issue when this PR is merged -->\r\nFixes  #390 \r\n\r\n## Screenshots/GIFs\r\n<!-- Please provide a view into the feature/bugfix if possible-->\r\n<img width=\"1287\" alt=\"Screen Shot 2019-05-07 at 12 06 43 AM\" src=\"https://user-images.githubusercontent.com/30167817/57278687-05e97980-705c-11e9-8292-5b9b6e2b195a.png\">\r\n\r\n\r\n","created_at":"2019-05-07T07:07:50Z","updated_at":"2019-05-07T21:53:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7135514cb2700563b25aca9686dbf99ac4c5143","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OperationCode/front-end/pulls/468/commits","review_comments_url":"https://api.github.com/repos/OperationCode/front-end/pulls/468/comments","review_comment_url":"https://api.github.com/repos/OperationCode/front-end/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OperationCode/front-end/issues/468/comments","statuses_url":"https://api.github.com/repos/OperationCode/front-end/statuses/9aec9f79571596b534eccdec2e1d695cbc3fde30","head":{"label":"phongvdoan:issue#390_e2etests_codeschools","ref":"issue#390_e2etests_codeschools","sha":"9aec9f79571596b534eccdec2e1d695cbc3fde30","user":{"login":"phongvdoan","id":30167817,"node_id":"MDQ6VXNlcjMwMTY3ODE3","avatar_url":"https://avatars3.githubusercontent.com/u/30167817?v=4","gravatar_id":"","url":"https://api.github.com/users/phongvdoan","html_url":"https://github.com/phongvdoan","followers_url":"https://api.github.com/users/phongvdoan/followers","following_url":"https://api.github.com/users/phongvdoan/following{/other_user}","gists_url":"https://api.github.com/users/phongvdoan/gists{/gist_id}","starred_url":"https://api.github.com/users/phongvdoan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phongvdoan/subscriptions","organizations_url":"https://api.github.com/users/phongvdoan/orgs","repos_url":"https://api.github.com/users/phongvdoan/repos","events_url":"https://api.github.com/users/phongvdoan/events{/privacy}","received_events_url":"https://api.github.com/users/phongvdoan/received_events","type":"User","site_admin":false},"repo":{"id":184099009,"node_id":"MDEwOlJlcG9zaXRvcnkxODQwOTkwMDk=","name":"front-end","full_name":"phongvdoan/front-end","private":false,"owner":{"login":"phongvdoan","id":30167817,"node_id":"MDQ6VXNlcjMwMTY3ODE3","avatar_url":"https://avatars3.githubusercontent.com/u/30167817?v=4","gravatar_id":"","url":"https://api.github.com/users/phongvdoan","html_url":"https://github.com/phongvdoan","followers_url":"https://api.github.com/users/phongvdoan/followers","following_url":"https://api.github.com/users/phongvdoan/following{/other_user}","gists_url":"https://api.github.com/users/phongvdoan/gists{/gist_id}","starred_url":"https://api.github.com/users/phongvdoan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phongvdoan/subscriptions","organizations_url":"https://api.github.com/users/phongvdoan/orgs","repos_url":"https://api.github.com/users/phongvdoan/repos","events_url":"https://api.github.com/users/phongvdoan/events{/privacy}","received_events_url":"https://api.github.com/users/phongvdoan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phongvdoan/front-end","description":"Operation Code's website","fork":true,"url":"https://api.github.com/repos/phongvdoan/front-end","forks_url":"https://api.github.com/repos/phongvdoan/front-end/forks","keys_url":"https://api.github.com/repos/phongvdoan/front-end/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phongvdoan/front-end/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phongvdoan/front-end/teams","hooks_url":"https://api.github.com/repos/phongvdoan/front-end/hooks","issue_events_url":"https://api.github.com/repos/phongvdoan/front-end/issues/events{/number}","events_url":"https://api.github.com/repos/phongvdoan/front-end/events","assignees_url":"https://api.github.com/repos/phongvdoan/front-end/assignees{/user}","branches_url":"https://api.github.com/repos/phongvdoan/front-end/branches{/branch}","tags_url":"https://api.github.com/repos/phongvdoan/front-end/tags","blobs_url":"https://api.github.com/repos/phongvdoan/front-end/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phongvdoan/front-end/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phongvdoan/front-end/git/refs{/sha}","trees_url":"https://api.github.com/repos/phongvdoan/front-end/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phongvdoan/front-end/statuses/{sha}","languages_url":"https://api.github.com/repos/phongvdoan/front-end/languages","stargazers_url":"https://api.github.com/repos/phongvdoan/front-end/stargazers","contributors_url":"https://api.github.com/repos/phongvdoan/front-end/contributors","subscribers_url":"https://api.github.com/repos/phongvdoan/front-end/subscribers","subscription_url":"https://api.github.com/repos/phongvdoan/front-end/subscription","commits_url":"https://api.github.com/repos/phongvdoan/front-end/commits{/sha}","git_commits_url":"https://api.github.com/repos/phongvdoan/front-end/git/commits{/sha}","comments_url":"https://api.github.com/repos/phongvdoan/front-end/comments{/number}","issue_comment_url":"https://api.github.com/repos/phongvdoan/front-end/issues/comments{/number}","contents_url":"https://api.github.com/repos/phongvdoan/front-end/contents/{+path}","compare_url":"https://api.github.com/repos/phongvdoan/front-end/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phongvdoan/front-end/merges","archive_url":"https://api.github.com/repos/phongvdoan/front-end/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phongvdoan/front-end/downloads","issues_url":"https://api.github.com/repos/phongvdoan/front-end/issues{/number}","pulls_url":"https://api.github.com/repos/phongvdoan/front-end/pulls{/number}","milestones_url":"https://api.github.com/repos/phongvdoan/front-end/milestones{/number}","notifications_url":"https://api.github.com/repos/phongvdoan/front-end/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phongvdoan/front-end/labels{/name}","releases_url":"https://api.github.com/repos/phongvdoan/front-end/releases{/id}","deployments_url":"https://api.github.com/repos/phongvdoan/front-end/deployments","created_at":"2019-04-29T15:42:36Z","updated_at":"2019-05-07T08:28:20Z","pushed_at":"2019-05-07T20:52:17Z","git_url":"git://github.com/phongvdoan/front-end.git","ssh_url":"git@github.com:phongvdoan/front-end.git","clone_url":"https://github.com/phongvdoan/front-end.git","svn_url":"https://github.com/phongvdoan/front-end","homepage":"https://operation-code.now.sh","size":9643,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OperationCode:master","ref":"master","sha":"862553ccfb87d9fee3ad9b4e0114a34c4e11953d","user":{"login":"OperationCode","id":10479364,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDc5MzY0","avatar_url":"https://avatars3.githubusercontent.com/u/10479364?v=4","gravatar_id":"","url":"https://api.github.com/users/OperationCode","html_url":"https://github.com/OperationCode","followers_url":"https://api.github.com/users/OperationCode/followers","following_url":"https://api.github.com/users/OperationCode/following{/other_user}","gists_url":"https://api.github.com/users/OperationCode/gists{/gist_id}","starred_url":"https://api.github.com/users/OperationCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OperationCode/subscriptions","organizations_url":"https://api.github.com/users/OperationCode/orgs","repos_url":"https://api.github.com/users/OperationCode/repos","events_url":"https://api.github.com/users/OperationCode/events{/privacy}","received_events_url":"https://api.github.com/users/OperationCode/received_events","type":"Organization","site_admin":false},"repo":{"id":135777271,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3NzcyNzE=","name":"front-end","full_name":"OperationCode/front-end","private":false,"owner":{"login":"OperationCode","id":10479364,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDc5MzY0","avatar_url":"https://avatars3.githubusercontent.com/u/10479364?v=4","gravatar_id":"","url":"https://api.github.com/users/OperationCode","html_url":"https://github.com/OperationCode","followers_url":"https://api.github.com/users/OperationCode/followers","following_url":"https://api.github.com/users/OperationCode/following{/other_user}","gists_url":"https://api.github.com/users/OperationCode/gists{/gist_id}","starred_url":"https://api.github.com/users/OperationCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OperationCode/subscriptions","organizations_url":"https://api.github.com/users/OperationCode/orgs","repos_url":"https://api.github.com/users/OperationCode/repos","events_url":"https://api.github.com/users/OperationCode/events{/privacy}","received_events_url":"https://api.github.com/users/OperationCode/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OperationCode/front-end","description":"Operation Code's website","fork":false,"url":"https://api.github.com/repos/OperationCode/front-end","forks_url":"https://api.github.com/repos/OperationCode/front-end/forks","keys_url":"https://api.github.com/repos/OperationCode/front-end/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OperationCode/front-end/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OperationCode/front-end/teams","hooks_url":"https://api.github.com/repos/OperationCode/front-end/hooks","issue_events_url":"https://api.github.com/repos/OperationCode/front-end/issues/events{/number}","events_url":"https://api.github.com/repos/OperationCode/front-end/events","assignees_url":"https://api.github.com/repos/OperationCode/front-end/assignees{/user}","branches_url":"https://api.github.com/repos/OperationCode/front-end/branches{/branch}","tags_url":"https://api.github.com/repos/OperationCode/front-end/tags","blobs_url":"https://api.github.com/repos/OperationCode/front-end/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OperationCode/front-end/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OperationCode/front-end/git/refs{/sha}","trees_url":"https://api.github.com/repos/OperationCode/front-end/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OperationCode/front-end/statuses/{sha}","languages_url":"https://api.github.com/repos/OperationCode/front-end/languages","stargazers_url":"https://api.github.com/repos/OperationCode/front-end/stargazers","contributors_url":"https://api.github.com/repos/OperationCode/front-end/contributors","subscribers_url":"https://api.github.com/repos/OperationCode/front-end/subscribers","subscription_url":"https://api.github.com/repos/OperationCode/front-end/subscription","commits_url":"https://api.github.com/repos/OperationCode/front-end/commits{/sha}","git_commits_url":"https://api.github.com/repos/OperationCode/front-end/git/commits{/sha}","comments_url":"https://api.github.com/repos/OperationCode/front-end/comments{/number}","issue_comment_url":"https://api.github.com/repos/OperationCode/front-end/issues/comments{/number}","contents_url":"https://api.github.com/repos/OperationCode/front-end/contents/{+path}","compare_url":"https://api.github.com/repos/OperationCode/front-end/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OperationCode/front-end/merges","archive_url":"https://api.github.com/repos/OperationCode/front-end/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OperationCode/front-end/downloads","issues_url":"https://api.github.com/repos/OperationCode/front-end/issues{/number}","pulls_url":"https://api.github.com/repos/OperationCode/front-end/pulls{/number}","milestones_url":"https://api.github.com/repos/OperationCode/front-end/milestones{/number}","notifications_url":"https://api.github.com/repos/OperationCode/front-end/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OperationCode/front-end/labels{/name}","releases_url":"https://api.github.com/repos/OperationCode/front-end/releases{/id}","deployments_url":"https://api.github.com/repos/OperationCode/front-end/deployments","created_at":"2018-06-02T01:23:17Z","updated_at":"2019-05-07T17:20:50Z","pushed_at":"2019-05-07T21:51:45Z","git_url":"git://github.com/OperationCode/front-end.git","ssh_url":"git@github.com:OperationCode/front-end.git","clone_url":"https://github.com/OperationCode/front-end.git","svn_url":"https://github.com/OperationCode/front-end","homepage":"https://operation-code.now.sh","size":9842,"stargazers_count":157,"watchers_count":157,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":91,"open_issues":29,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/468"},"html":{"href":"https://github.com/OperationCode/front-end/pull/468"},"issue":{"href":"https://api.github.com/repos/OperationCode/front-end/issues/468"},"comments":{"href":"https://api.github.com/repos/OperationCode/front-end/issues/468/comments"},"review_comments":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/468/comments"},"review_comment":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OperationCode/front-end/pulls/468/commits"},"statuses":{"href":"https://api.github.com/repos/OperationCode/front-end/statuses/9aec9f79571596b534eccdec2e1d695cbc3fde30"}},"author_association":"NONE"}}
{"actor":{"display_login":"kylemh"}}