{"action":"created","issue":{"url":"https://api.github.com/repos/mysociety/fixmystreet/issues/2692","repository_url":"https://api.github.com/repos/mysociety/fixmystreet","labels_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/2692/labels{/name}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/2692/comments","events_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/2692/events","html_url":"https://github.com/mysociety/fixmystreet/pull/2692","id":509125266,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5Nzc1MTk1","number":2692,"title":"[Bexley] Map NSG_REF as site_code for Confirm","user":{"login":"chrismytton","id":22996,"node_id":"MDQ6VXNlcjIyOTk2","avatar_url":"https://avatars2.githubusercontent.com/u/22996?v=4","gravatar_id":"","url":"https://api.github.com/users/chrismytton","html_url":"https://github.com/chrismytton","followers_url":"https://api.github.com/users/chrismytton/followers","following_url":"https://api.github.com/users/chrismytton/following{/other_user}","gists_url":"https://api.github.com/users/chrismytton/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismytton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismytton/subscriptions","organizations_url":"https://api.github.com/users/chrismytton/orgs","repos_url":"https://api.github.com/users/chrismytton/repos","events_url":"https://api.github.com/users/chrismytton/events{/privacy}","received_events_url":"https://api.github.com/users/chrismytton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-10-18T14:41:39Z","updated_at":"2019-10-18T16:38:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/2692","html_url":"https://github.com/mysociety/fixmystreet/pull/2692","diff_url":"https://github.com/mysociety/fixmystreet/pull/2692.diff","patch_url":"https://github.com/mysociety/fixmystreet/pull/2692.patch"},"body":"Bexley's Confirm server needs the `NSG_REF` attribute from the Streets layer to appear in the `site_code` field.\r\n\r\nWe already had a `usrn` configuration for Bexley's assets, so this change includes a modification to the code that handles the `usrn` mapping to allow it to accept an array of configuration objects as well as just a single object.\r\n\r\nFixes https://github.com/mysociety/fixmystreet-commercial/issues/1638\r\n\r\n<!-- [skip changelog] -->"},"comment":{"url":"https://api.github.com/repos/mysociety/fixmystreet/issues/comments/543827650","html_url":"https://github.com/mysociety/fixmystreet/pull/2692#issuecomment-543827650","issue_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/2692","id":543827650,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MzgyNzY1MA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-10-18T16:38:22Z","updated_at":"2019-10-18T16:38:22Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/mysociety/fixmystreet/pull/2692?src=pr&el=h1) Report\n> Merging [#2692](https://codecov.io/gh/mysociety/fixmystreet/pull/2692?src=pr&el=desc) into [bexley-reviewed](https://codecov.io/gh/mysociety/fixmystreet/commit/128ce4ad1205975adfea497ee943b664a8301905?src=pr&el=desc) will **decrease** coverage by `24.95%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/graphs/tree.svg?width=650&token=qzUD8eL6xO&height=150&src=pr)](https://codecov.io/gh/mysociety/fixmystreet/pull/2692?src=pr&el=tree)\n\n```diff\n@@                 Coverage Diff                  @@\n##           bexley-reviewed    #2692       +/-   ##\n====================================================\n- Coverage            82.31%   57.36%   -24.96%     \n====================================================\n  Files                  219      218        -1     \n  Lines                13874    13854       -20     \n  Branches              2579     2577        -2     \n====================================================\n- Hits                 11421     7947     -3474     \n- Misses                1566     4960     +3394     \n- Partials               887      947       +60\n```\n\n\n| [Impacted Files](https://codecov.io/gh/mysociety/fixmystreet/pull/2692?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [perllib/FixMyStreet/App/Controller/Auth/Profile.pm](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree#diff-cGVybGxpYi9GaXhNeVN0cmVldC9BcHAvQ29udHJvbGxlci9BdXRoL1Byb2ZpbGUucG0=) | `12.38% <0%> (-85.72%)` | :arrow_down: |\n| [...ib/FixMyStreet/DB/Result/ModerationOriginalData.pm](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree#diff-cGVybGxpYi9GaXhNeVN0cmVldC9EQi9SZXN1bHQvTW9kZXJhdGlvbk9yaWdpbmFsRGF0YS5wbQ==) | `9.33% <0%> (-81.34%)` | :arrow_down: |\n| [...erllib/FixMyStreet/App/Controller/Questionnaire.pm](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree#diff-cGVybGxpYi9GaXhNeVN0cmVldC9BcHAvQ29udHJvbGxlci9RdWVzdGlvbm5haXJlLnBt) | `11.45% <0%> (-80.92%)` | :arrow_down: |\n| [perllib/FixMyStreet/App/Controller/Admin/Roles.pm](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree#diff-cGVybGxpYi9GaXhNeVN0cmVldC9BcHAvQ29udHJvbGxlci9BZG1pbi9Sb2xlcy5wbQ==) | `17.3% <0%> (-80.77%)` | :arrow_down: |\n| [perllib/FixMyStreet/App/Controller/Admin/States.pm](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree#diff-cGVybGxpYi9GaXhNeVN0cmVldC9BcHAvQ29udHJvbGxlci9BZG1pbi9TdGF0ZXMucG0=) | `13.72% <0%> (-78.44%)` | :arrow_down: |\n| [perllib/FixMyStreet/App/Controller/Auth/Phone.pm](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree#diff-cGVybGxpYi9GaXhNeVN0cmVldC9BcHAvQ29udHJvbGxlci9BdXRoL1Bob25lLnBt) | `14.58% <0%> (-77.09%)` | :arrow_down: |\n| [...ib/FixMyStreet/App/Controller/Admin/DefectTypes.pm](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree#diff-cGVybGxpYi9GaXhNeVN0cmVldC9BcHAvQ29udHJvbGxlci9BZG1pbi9EZWZlY3RUeXBlcy5wbQ==) | `15.09% <0%> (-75.48%)` | :arrow_down: |\n| [...MyStreet/App/Controller/Admin/ReportExtraFields.pm](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree#diff-cGVybGxpYi9GaXhNeVN0cmVldC9BcHAvQ29udHJvbGxlci9BZG1pbi9SZXBvcnRFeHRyYUZpZWxkcy5wbQ==) | `24% <0%> (-72%)` | :arrow_down: |\n| [perllib/FixMyStreet/App/Form/Role.pm](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree#diff-cGVybGxpYi9GaXhNeVN0cmVldC9BcHAvRm9ybS9Sb2xlLnBt) | `14.28% <0%> (-71.43%)` | :arrow_down: |\n| [...llib/FixMyStreet/App/Controller/Open311/Updates.pm](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree#diff-cGVybGxpYi9GaXhNeVN0cmVldC9BcHAvQ29udHJvbGxlci9PcGVuMzExL1VwZGF0ZXMucG0=) | `21.05% <0%> (-71.06%)` | :arrow_down: |\n| ... and [90 more](https://codecov.io/gh/mysociety/fixmystreet/pull/2692/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/mysociety/fixmystreet/pull/2692?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/mysociety/fixmystreet/pull/2692?src=pr&el=footer). Last update [128ce4a...d812452](https://codecov.io/gh/mysociety/fixmystreet/pull/2692?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}