{"action":"created","comment":{"url":"https://api.github.com/repos/ataulm/muvi/pulls/comments/294081012","pull_request_review_id":250228957,"id":294081012,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDA4MTAxMg==","diff_hunk":"@@ -1,6 +1,8 @@\n apply plugin: 'kotlin'\n \n dependencies {\n+    implementation project(':base_domain')","path":"feed_domain/build.gradle","position":4,"original_position":4,"commit_id":"4b364f368af4df443979e6ff7adac246e3bc3c2f","original_commit_id":"4b364f368af4df443979e6ff7adac246e3bc3c2f","user":{"login":"ataulm","id":2678555,"node_id":"MDQ6VXNlcjI2Nzg1NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2678555?v=4","gravatar_id":"","url":"https://api.github.com/users/ataulm","html_url":"https://github.com/ataulm","followers_url":"https://api.github.com/users/ataulm/followers","following_url":"https://api.github.com/users/ataulm/following{/other_user}","gists_url":"https://api.github.com/users/ataulm/gists{/gist_id}","starred_url":"https://api.github.com/users/ataulm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataulm/subscriptions","organizations_url":"https://api.github.com/users/ataulm/orgs","repos_url":"https://api.github.com/users/ataulm/repos","events_url":"https://api.github.com/users/ataulm/events{/privacy}","received_events_url":"https://api.github.com/users/ataulm/received_events","type":"User","site_admin":false},"body":"wow I'm such a dirty liar - this was API because `feed` (the dynamic feature module) depends on this one `feed_domain` (which isn't a DFM) and `feed` needs to know about the domain models like FilmSummary.\r\n\r\nIf we want to be super super hardcore, we could leave it like this, but then `feed_domain` would need its own models which would probably just be a copy of the domain models.\r\n\r\nI'll revert this for now.","created_at":"2019-06-16T12:04:38Z","updated_at":"2019-06-16T12:04:39Z","html_url":"https://github.com/ataulm/muvi/pull/5#discussion_r294081012","pull_request_url":"https://api.github.com/repos/ataulm/muvi/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ataulm/muvi/pulls/comments/294081012"},"html":{"href":"https://github.com/ataulm/muvi/pull/5#discussion_r294081012"},"pull_request":{"href":"https://api.github.com/repos/ataulm/muvi/pulls/5"}},"in_reply_to_id":294076555},"pull_request":{"url":"https://api.github.com/repos/ataulm/muvi/pulls/5","id":288612692,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NjEyNjky","html_url":"https://github.com/ataulm/muvi/pull/5","diff_url":"https://github.com/ataulm/muvi/pull/5.diff","patch_url":"https://github.com/ataulm/muvi/pull/5.patch","issue_url":"https://api.github.com/repos/ataulm/muvi/issues/5","number":5,"state":"closed","locked":false,"title":"Extract base domain + FilmDetail parsing","user":{"login":"ataulm","id":2678555,"node_id":"MDQ6VXNlcjI2Nzg1NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2678555?v=4","gravatar_id":"","url":"https://api.github.com/users/ataulm","html_url":"https://github.com/ataulm","followers_url":"https://api.github.com/users/ataulm/followers","following_url":"https://api.github.com/users/ataulm/following{/other_user}","gists_url":"https://api.github.com/users/ataulm/gists{/gist_id}","starred_url":"https://api.github.com/users/ataulm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataulm/subscriptions","organizations_url":"https://api.github.com/users/ataulm/orgs","repos_url":"https://api.github.com/users/ataulm/repos","events_url":"https://api.github.com/users/ataulm/events{/privacy}","received_events_url":"https://api.github.com/users/ataulm/received_events","type":"User","site_admin":false},"body":"We extracted a base domain module where we could keep models that would be shared throughout the app - like `Image` or `FilmSummary`. \r\n\r\nIn practice, this meant that all the domain models went here - I don't think there are any domain models left that are specific to a feature module.\r\n\r\n---\r\n\r\nAlso added the parsing logic for `Film` including the directors and characters. The annoying bit is that images don't seem to be included for the cast - if we want them, we'd have to do an API call _per_ actor. What do you think about just avoiding this for now? e.g. showing their initials instead or using [robohash](https://robohash.org)?\r\n\r\n---\r\n\r\n(Also there's a new API to fetch a list of films given an actor ID. This wasn't meant to be committed - I wanted to do it as part of the same PR where the actor-detail modules are added, but oh well.)","created_at":"2019-06-16T09:51:23Z","updated_at":"2019-06-16T12:04:38Z","closed_at":"2019-06-16T11:54:13Z","merged_at":"2019-06-16T11:54:13Z","merge_commit_sha":"9b97bbe1f0ddb6b008d59d1ee70b027d001e64c1","assignee":{"login":"hitherejoe","id":3879281,"node_id":"MDQ6VXNlcjM4NzkyODE=","avatar_url":"https://avatars0.githubusercontent.com/u/3879281?v=4","gravatar_id":"","url":"https://api.github.com/users/hitherejoe","html_url":"https://github.com/hitherejoe","followers_url":"https://api.github.com/users/hitherejoe/followers","following_url":"https://api.github.com/users/hitherejoe/following{/other_user}","gists_url":"https://api.github.com/users/hitherejoe/gists{/gist_id}","starred_url":"https://api.github.com/users/hitherejoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hitherejoe/subscriptions","organizations_url":"https://api.github.com/users/hitherejoe/orgs","repos_url":"https://api.github.com/users/hitherejoe/repos","events_url":"https://api.github.com/users/hitherejoe/events{/privacy}","received_events_url":"https://api.github.com/users/hitherejoe/received_events","type":"User","site_admin":false},"assignees":[{"login":"hitherejoe","id":3879281,"node_id":"MDQ6VXNlcjM4NzkyODE=","avatar_url":"https://avatars0.githubusercontent.com/u/3879281?v=4","gravatar_id":"","url":"https://api.github.com/users/hitherejoe","html_url":"https://github.com/hitherejoe","followers_url":"https://api.github.com/users/hitherejoe/followers","following_url":"https://api.github.com/users/hitherejoe/following{/other_user}","gists_url":"https://api.github.com/users/hitherejoe/gists{/gist_id}","starred_url":"https://api.github.com/users/hitherejoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hitherejoe/subscriptions","organizations_url":"https://api.github.com/users/hitherejoe/orgs","repos_url":"https://api.github.com/users/hitherejoe/repos","events_url":"https://api.github.com/users/hitherejoe/events{/privacy}","received_events_url":"https://api.github.com/users/hitherejoe/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ataulm/muvi/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ataulm/muvi/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ataulm/muvi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ataulm/muvi/issues/5/comments","statuses_url":"https://api.github.com/repos/ataulm/muvi/statuses/4b364f368af4df443979e6ff7adac246e3bc3c2f","head":{"label":"ataulm:task/uimodel","ref":"task/uimodel","sha":"4b364f368af4df443979e6ff7adac246e3bc3c2f","user":{"login":"ataulm","id":2678555,"node_id":"MDQ6VXNlcjI2Nzg1NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2678555?v=4","gravatar_id":"","url":"https://api.github.com/users/ataulm","html_url":"https://github.com/ataulm","followers_url":"https://api.github.com/users/ataulm/followers","following_url":"https://api.github.com/users/ataulm/following{/other_user}","gists_url":"https://api.github.com/users/ataulm/gists{/gist_id}","starred_url":"https://api.github.com/users/ataulm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataulm/subscriptions","organizations_url":"https://api.github.com/users/ataulm/orgs","repos_url":"https://api.github.com/users/ataulm/repos","events_url":"https://api.github.com/users/ataulm/events{/privacy}","received_events_url":"https://api.github.com/users/ataulm/received_events","type":"User","site_admin":false},"repo":{"id":186059686,"node_id":"MDEwOlJlcG9zaXRvcnkxODYwNTk2ODY=","name":"muvi","full_name":"ataulm/muvi","private":false,"owner":{"login":"ataulm","id":2678555,"node_id":"MDQ6VXNlcjI2Nzg1NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2678555?v=4","gravatar_id":"","url":"https://api.github.com/users/ataulm","html_url":"https://github.com/ataulm","followers_url":"https://api.github.com/users/ataulm/followers","following_url":"https://api.github.com/users/ataulm/following{/other_user}","gists_url":"https://api.github.com/users/ataulm/gists{/gist_id}","starred_url":"https://api.github.com/users/ataulm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataulm/subscriptions","organizations_url":"https://api.github.com/users/ataulm/orgs","repos_url":"https://api.github.com/users/ataulm/repos","events_url":"https://api.github.com/users/ataulm/events{/privacy}","received_events_url":"https://api.github.com/users/ataulm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ataulm/muvi","description":null,"fork":false,"url":"https://api.github.com/repos/ataulm/muvi","forks_url":"https://api.github.com/repos/ataulm/muvi/forks","keys_url":"https://api.github.com/repos/ataulm/muvi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ataulm/muvi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ataulm/muvi/teams","hooks_url":"https://api.github.com/repos/ataulm/muvi/hooks","issue_events_url":"https://api.github.com/repos/ataulm/muvi/issues/events{/number}","events_url":"https://api.github.com/repos/ataulm/muvi/events","assignees_url":"https://api.github.com/repos/ataulm/muvi/assignees{/user}","branches_url":"https://api.github.com/repos/ataulm/muvi/branches{/branch}","tags_url":"https://api.github.com/repos/ataulm/muvi/tags","blobs_url":"https://api.github.com/repos/ataulm/muvi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ataulm/muvi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ataulm/muvi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ataulm/muvi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ataulm/muvi/statuses/{sha}","languages_url":"https://api.github.com/repos/ataulm/muvi/languages","stargazers_url":"https://api.github.com/repos/ataulm/muvi/stargazers","contributors_url":"https://api.github.com/repos/ataulm/muvi/contributors","subscribers_url":"https://api.github.com/repos/ataulm/muvi/subscribers","subscription_url":"https://api.github.com/repos/ataulm/muvi/subscription","commits_url":"https://api.github.com/repos/ataulm/muvi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ataulm/muvi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ataulm/muvi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ataulm/muvi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ataulm/muvi/contents/{+path}","compare_url":"https://api.github.com/repos/ataulm/muvi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ataulm/muvi/merges","archive_url":"https://api.github.com/repos/ataulm/muvi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ataulm/muvi/downloads","issues_url":"https://api.github.com/repos/ataulm/muvi/issues{/number}","pulls_url":"https://api.github.com/repos/ataulm/muvi/pulls{/number}","milestones_url":"https://api.github.com/repos/ataulm/muvi/milestones{/number}","notifications_url":"https://api.github.com/repos/ataulm/muvi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ataulm/muvi/labels{/name}","releases_url":"https://api.github.com/repos/ataulm/muvi/releases{/id}","deployments_url":"https://api.github.com/repos/ataulm/muvi/deployments","created_at":"2019-05-10T21:59:50Z","updated_at":"2019-06-16T11:54:15Z","pushed_at":"2019-06-16T11:54:16Z","git_url":"git://github.com/ataulm/muvi.git","ssh_url":"git@github.com:ataulm/muvi.git","clone_url":"https://github.com/ataulm/muvi.git","svn_url":"https://github.com/ataulm/muvi","homepage":null,"size":174,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ataulm:master","ref":"master","sha":"de030f83ba6332e187db1b4c595cb82762814409","user":{"login":"ataulm","id":2678555,"node_id":"MDQ6VXNlcjI2Nzg1NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2678555?v=4","gravatar_id":"","url":"https://api.github.com/users/ataulm","html_url":"https://github.com/ataulm","followers_url":"https://api.github.com/users/ataulm/followers","following_url":"https://api.github.com/users/ataulm/following{/other_user}","gists_url":"https://api.github.com/users/ataulm/gists{/gist_id}","starred_url":"https://api.github.com/users/ataulm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataulm/subscriptions","organizations_url":"https://api.github.com/users/ataulm/orgs","repos_url":"https://api.github.com/users/ataulm/repos","events_url":"https://api.github.com/users/ataulm/events{/privacy}","received_events_url":"https://api.github.com/users/ataulm/received_events","type":"User","site_admin":false},"repo":{"id":186059686,"node_id":"MDEwOlJlcG9zaXRvcnkxODYwNTk2ODY=","name":"muvi","full_name":"ataulm/muvi","private":false,"owner":{"login":"ataulm","id":2678555,"node_id":"MDQ6VXNlcjI2Nzg1NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2678555?v=4","gravatar_id":"","url":"https://api.github.com/users/ataulm","html_url":"https://github.com/ataulm","followers_url":"https://api.github.com/users/ataulm/followers","following_url":"https://api.github.com/users/ataulm/following{/other_user}","gists_url":"https://api.github.com/users/ataulm/gists{/gist_id}","starred_url":"https://api.github.com/users/ataulm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ataulm/subscriptions","organizations_url":"https://api.github.com/users/ataulm/orgs","repos_url":"https://api.github.com/users/ataulm/repos","events_url":"https://api.github.com/users/ataulm/events{/privacy}","received_events_url":"https://api.github.com/users/ataulm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ataulm/muvi","description":null,"fork":false,"url":"https://api.github.com/repos/ataulm/muvi","forks_url":"https://api.github.com/repos/ataulm/muvi/forks","keys_url":"https://api.github.com/repos/ataulm/muvi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ataulm/muvi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ataulm/muvi/teams","hooks_url":"https://api.github.com/repos/ataulm/muvi/hooks","issue_events_url":"https://api.github.com/repos/ataulm/muvi/issues/events{/number}","events_url":"https://api.github.com/repos/ataulm/muvi/events","assignees_url":"https://api.github.com/repos/ataulm/muvi/assignees{/user}","branches_url":"https://api.github.com/repos/ataulm/muvi/branches{/branch}","tags_url":"https://api.github.com/repos/ataulm/muvi/tags","blobs_url":"https://api.github.com/repos/ataulm/muvi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ataulm/muvi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ataulm/muvi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ataulm/muvi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ataulm/muvi/statuses/{sha}","languages_url":"https://api.github.com/repos/ataulm/muvi/languages","stargazers_url":"https://api.github.com/repos/ataulm/muvi/stargazers","contributors_url":"https://api.github.com/repos/ataulm/muvi/contributors","subscribers_url":"https://api.github.com/repos/ataulm/muvi/subscribers","subscription_url":"https://api.github.com/repos/ataulm/muvi/subscription","commits_url":"https://api.github.com/repos/ataulm/muvi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ataulm/muvi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ataulm/muvi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ataulm/muvi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ataulm/muvi/contents/{+path}","compare_url":"https://api.github.com/repos/ataulm/muvi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ataulm/muvi/merges","archive_url":"https://api.github.com/repos/ataulm/muvi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ataulm/muvi/downloads","issues_url":"https://api.github.com/repos/ataulm/muvi/issues{/number}","pulls_url":"https://api.github.com/repos/ataulm/muvi/pulls{/number}","milestones_url":"https://api.github.com/repos/ataulm/muvi/milestones{/number}","notifications_url":"https://api.github.com/repos/ataulm/muvi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ataulm/muvi/labels{/name}","releases_url":"https://api.github.com/repos/ataulm/muvi/releases{/id}","deployments_url":"https://api.github.com/repos/ataulm/muvi/deployments","created_at":"2019-05-10T21:59:50Z","updated_at":"2019-06-16T11:54:15Z","pushed_at":"2019-06-16T11:54:16Z","git_url":"git://github.com/ataulm/muvi.git","ssh_url":"git@github.com:ataulm/muvi.git","clone_url":"https://github.com/ataulm/muvi.git","svn_url":"https://github.com/ataulm/muvi","homepage":null,"size":174,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ataulm/muvi/pulls/5"},"html":{"href":"https://github.com/ataulm/muvi/pull/5"},"issue":{"href":"https://api.github.com/repos/ataulm/muvi/issues/5"},"comments":{"href":"https://api.github.com/repos/ataulm/muvi/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ataulm/muvi/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ataulm/muvi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ataulm/muvi/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ataulm/muvi/statuses/4b364f368af4df443979e6ff7adac246e3bc3c2f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ataulm"}}