{"action":"created","issue":{"url":"https://api.github.com/repos/nim-lang/Nim/issues/12554","repository_url":"https://api.github.com/repos/nim-lang/Nim","labels_url":"https://api.github.com/repos/nim-lang/Nim/issues/12554/labels{/name}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/12554/comments","events_url":"https://api.github.com/repos/nim-lang/Nim/issues/12554/events","html_url":"https://github.com/nim-lang/Nim/issues/12554","id":514072885,"node_id":"MDU6SXNzdWU1MTQwNzI4ODU=","number":12554,"title":"unsigned conversion regression","user":{"login":"mratsim","id":22738317,"node_id":"MDQ6VXNlcjIyNzM4MzE3","avatar_url":"https://avatars3.githubusercontent.com/u/22738317?v=4","gravatar_id":"","url":"https://api.github.com/users/mratsim","html_url":"https://github.com/mratsim","followers_url":"https://api.github.com/users/mratsim/followers","following_url":"https://api.github.com/users/mratsim/following{/other_user}","gists_url":"https://api.github.com/users/mratsim/gists{/gist_id}","starred_url":"https://api.github.com/users/mratsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mratsim/subscriptions","organizations_url":"https://api.github.com/users/mratsim/orgs","repos_url":"https://api.github.com/users/mratsim/repos","events_url":"https://api.github.com/users/mratsim/events{/privacy}","received_events_url":"https://api.github.com/users/mratsim/received_events","type":"User","site_admin":false},"labels":[{"id":187885236,"node_id":"MDU6TGFiZWwxODc4ODUyMzY=","url":"https://api.github.com/repos/nim-lang/Nim/labels/Regression","name":"Regression","color":"fbca04","default":false},{"id":80449731,"node_id":"MDU6TGFiZWw4MDQ0OTczMQ==","url":"https://api.github.com/repos/nim-lang/Nim/labels/Showstopper","name":"Showstopper","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":39,"created_at":"2019-10-29T16:55:13Z","updated_at":"2019-11-16T16:36:14Z","closed_at":null,"author_association":"COLLABORATOR","body":"The following used to give 44 on 0.20.2.\r\n\r\nIt now raises an error range error on 1.0.\r\n\r\n```Nim\r\nlet x = 300'u\r\necho byte(x)\r\n```\r\n\r\nThis broke our upcoming networking code: https://github.com/status-im/nim-libp2p/commit/541f0f2a41b0c47f41e63bd53fe8078e005629e2. In general, I don't think people expect range checking on unsigned integers, especially on converting to raw byte.\r\n\r\nThis may have a large impact on low-level code for example: graphics, crypto, networking, emulation ..."},"comment":{"url":"https://api.github.com/repos/nim-lang/Nim/issues/comments/554652765","html_url":"https://github.com/nim-lang/Nim/issues/12554#issuecomment-554652765","issue_url":"https://api.github.com/repos/nim-lang/Nim/issues/12554","id":554652765,"node_id":"MDEyOklzc3VlQ29tbWVudDU1NDY1Mjc2NQ==","user":{"login":"disruptek","id":1479799,"node_id":"MDQ6VXNlcjE0Nzk3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1479799?v=4","gravatar_id":"","url":"https://api.github.com/users/disruptek","html_url":"https://github.com/disruptek","followers_url":"https://api.github.com/users/disruptek/followers","following_url":"https://api.github.com/users/disruptek/following{/other_user}","gists_url":"https://api.github.com/users/disruptek/gists{/gist_id}","starred_url":"https://api.github.com/users/disruptek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disruptek/subscriptions","organizations_url":"https://api.github.com/users/disruptek/orgs","repos_url":"https://api.github.com/users/disruptek/repos","events_url":"https://api.github.com/users/disruptek/events{/privacy}","received_events_url":"https://api.github.com/users/disruptek/received_events","type":"User","site_admin":false},"created_at":"2019-11-16T16:36:14Z","updated_at":"2019-11-16T16:36:14Z","author_association":"CONTRIBUTOR","body":"Never mind, I must have had 245a954b250b3e95f68c6bdadeba6ef1425442aa in my compiler, which means this **shouldn't** work in 1.0.  Duh."}}
{"actor":{"display_login":"disruptek"}}