{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/1327","repository_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps","labels_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/1327/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/1327/comments","events_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/1327/events","html_url":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1327","id":435501079,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyMjEwMzYz","number":1327,"title":"Simplify generating xeno hud icons","user":{"login":"psykzz","id":1134201,"node_id":"MDQ6VXNlcjExMzQyMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1134201?v=4","gravatar_id":"","url":"https://api.github.com/users/psykzz","html_url":"https://github.com/psykzz","followers_url":"https://api.github.com/users/psykzz/followers","following_url":"https://api.github.com/users/psykzz/following{/other_user}","gists_url":"https://api.github.com/users/psykzz/gists{/gist_id}","starred_url":"https://api.github.com/users/psykzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psykzz/subscriptions","organizations_url":"https://api.github.com/users/psykzz/orgs","repos_url":"https://api.github.com/users/psykzz/repos","events_url":"https://api.github.com/users/psykzz/events{/privacy}","received_events_url":"https://api.github.com/users/psykzz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-04-21T11:38:52Z","updated_at":"2019-04-24T18:20:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/pulls/1327","html_url":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1327","diff_url":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1327.diff","patch_url":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1327.patch"},"body":"<!-- ***STOP!***  Read this: If this is not a PR ready for review and merge or WIP, open it as a draft PR, using the arrow next to 'Create Pull Request'>\r\n\r\n<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. -->\r\n<!-- You can view Contributing.MD for a detailed description of the pull request process. -->\r\n\r\n## About The Pull Request\r\n\r\nRefactors xeno hud to simplify buckets using maths insteading of manual assignment.\r\n\r\nI did read that switchs are faster than maths but the scale is on ten of thousands of calls. The benefit here is the calculation is shared instead of multiple implementations.\r\n\r\n<!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! -->\r\n\r\n## Changelog\r\n:cl:\r\ntweak: Xeno huds are now rounded up.\r\n/:cl:\r\n\r\n<!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. -->\r\n<!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->\r\n"},"comment":{"url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/comments/486368881","html_url":"https://github.com/tgstation/TerraGov-Marine-Corps/pull/1327#issuecomment-486368881","issue_url":"https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/issues/1327","id":486368881,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NjM2ODg4MQ==","user":{"login":"Rohesie","id":42041276,"node_id":"MDQ6VXNlcjQyMDQxMjc2","avatar_url":"https://avatars1.githubusercontent.com/u/42041276?v=4","gravatar_id":"","url":"https://api.github.com/users/Rohesie","html_url":"https://github.com/Rohesie","followers_url":"https://api.github.com/users/Rohesie/followers","following_url":"https://api.github.com/users/Rohesie/following{/other_user}","gists_url":"https://api.github.com/users/Rohesie/gists{/gist_id}","starred_url":"https://api.github.com/users/Rohesie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rohesie/subscriptions","organizations_url":"https://api.github.com/users/Rohesie/orgs","repos_url":"https://api.github.com/users/Rohesie/repos","events_url":"https://api.github.com/users/Rohesie/events{/privacy}","received_events_url":"https://api.github.com/users/Rohesie/received_events","type":"User","site_admin":false},"created_at":"2019-04-24T18:20:53Z","updated_at":"2019-04-24T18:20:53Z","author_association":"COLLABORATOR","body":"I'll leave La to answer on if the whole package should go or stay, but if you add sanity checks, do make them informative, as with `stack_trace()`.\r\nMy opinion is that it's not really necessary here."}}
{"actor":{"display_login":"Rohesie"}}