{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/351421276","pull_request_review_id":323841188,"id":351421276,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MTQyMTI3Ng==","diff_hunk":"@@ -60,30 +71,60 @@ - (void)animateTransition:(id<UIViewControllerContextTransitioning>)transitionCo\n   CGFloat endingAlpha = presenting ? 1 : 0;\n \n   animatingView.frame = [transitionContext finalFrameForViewController:animatingViewController];\n-  animatingView.alpha = startingAlpha;\n \n-  NSTimeInterval transitionDuration = [self transitionDuration:transitionContext];\n   UIViewAnimationOptions options =\n       UIViewAnimationOptionAllowUserInteraction | UIViewAnimationOptionBeginFromCurrentState;\n \n-  [UIView animateWithDuration:transitionDuration\n-      delay:0.0\n-      options:options\n-      animations:^{\n-        animatingView.alpha = endingAlpha;\n-      }\n-      completion:^(__unused BOOL finished) {\n-        // If we're dismissing, remove the presented view from the hierarchy\n-        if (!presenting) {\n-          [fromView removeFromSuperview];\n-        }\n-\n-        // From ADC : UIViewControllerContextTransitioning\n-        // When you do create transition animations, always call the\n-        // completeTransition: from an appropriate completion block to let UIKit know\n-        // when all of your animations have finished.\n-        [transitionContext completeTransition:YES];\n-      }];\n+  // Opacity animation\n+  animatingView.alpha = startingAlpha;\n+  [UIView animateWithDuration:_animationDuration / 2\n+                        delay:0\n+                      options:options\n+                   animations:^{\n+                     animatingView.alpha = endingAlpha;\n+                   }\n+                   completion:nil];\n+\n+  // Scale animation\n+  MDCDialogPresentationController *presentationController = nil;\n+  if ([animatingViewController.presentationController\n+          isKindOfClass:[MDCDialogPresentationController class]]) {\n+    presentationController =\n+        (MDCDialogPresentationController *)animatingViewController.presentationController;\n+  }\n+\n+  CGAffineTransform startingTransform =\n+      presenting ? CGAffineTransformMakeScale(_dialogScaleFactor, _dialogScaleFactor)","path":"components/Dialogs/src/MDCDialogTransitionController.m","position":74,"original_position":74,"commit_id":"8e496a53bf2913915c8f6afc882af82c0f13c44f","original_commit_id":"8e496a53bf2913915c8f6afc882af82c0f13c44f","user":{"login":"romoore","id":1753199,"node_id":"MDQ6VXNlcjE3NTMxOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1753199?v=4","gravatar_id":"","url":"https://api.github.com/users/romoore","html_url":"https://github.com/romoore","followers_url":"https://api.github.com/users/romoore/followers","following_url":"https://api.github.com/users/romoore/following{/other_user}","gists_url":"https://api.github.com/users/romoore/gists{/gist_id}","starred_url":"https://api.github.com/users/romoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romoore/subscriptions","organizations_url":"https://api.github.com/users/romoore/orgs","repos_url":"https://api.github.com/users/romoore/repos","events_url":"https://api.github.com/users/romoore/events{/privacy}","received_events_url":"https://api.github.com/users/romoore/received_events","type":"User","site_admin":false},"body":"Nit: Please use `self.dialogScaleFactor` here rather than accessing the ivar directly.  [Accessing properties via accessor methods even within an object is an Apple best practice](https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/EncapsulatingData/EncapsulatingData.html), unless it creates specific problems (e.g., from `init` or the accessor itself).","created_at":"2019-11-27T17:41:29Z","updated_at":"2019-11-27T17:44:20Z","html_url":"https://github.com/material-components/material-components-ios/pull/9033#discussion_r351421276","pull_request_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/9033","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/351421276"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/9033#discussion_r351421276"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/9033"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/9033","id":345970183,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1OTcwMTgz","html_url":"https://github.com/material-components/material-components-ios/pull/9033","diff_url":"https://github.com/material-components/material-components-ios/pull/9033.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/9033.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/9033","number":9033,"state":"open","locked":false,"title":"[Dialogs] Add configuration options to MDCDialogTransitionController","user":{"login":"bryanoltman","id":581764,"node_id":"MDQ6VXNlcjU4MTc2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/581764?v=4","gravatar_id":"","url":"https://api.github.com/users/bryanoltman","html_url":"https://github.com/bryanoltman","followers_url":"https://api.github.com/users/bryanoltman/followers","following_url":"https://api.github.com/users/bryanoltman/following{/other_user}","gists_url":"https://api.github.com/users/bryanoltman/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanoltman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanoltman/subscriptions","organizations_url":"https://api.github.com/users/bryanoltman/orgs","repos_url":"https://api.github.com/users/bryanoltman/repos","events_url":"https://api.github.com/users/bryanoltman/events{/privacy}","received_events_url":"https://api.github.com/users/bryanoltman/received_events","type":"User","site_admin":false},"body":"* Adds scaling option to dialog presentation animation, but does not perform any scaling animation.\r\n* Makes dialog animation duration configurable\r\n\r\nThis PR does not introduce any functional changes.\r\n\r\nPrework for b/143865115","created_at":"2019-11-26T22:49:02Z","updated_at":"2019-11-27T17:44:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1059d86a7eceaa7fc1f0aac66d8011372b84829e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"galiak11","id":2329102,"node_id":"MDQ6VXNlcjIzMjkxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2329102?v=4","gravatar_id":"","url":"https://api.github.com/users/galiak11","html_url":"https://github.com/galiak11","followers_url":"https://api.github.com/users/galiak11/followers","following_url":"https://api.github.com/users/galiak11/following{/other_user}","gists_url":"https://api.github.com/users/galiak11/gists{/gist_id}","starred_url":"https://api.github.com/users/galiak11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galiak11/subscriptions","organizations_url":"https://api.github.com/users/galiak11/orgs","repos_url":"https://api.github.com/users/galiak11/repos","events_url":"https://api.github.com/users/galiak11/events{/privacy}","received_events_url":"https://api.github.com/users/galiak11/received_events","type":"User","site_admin":false},{"login":"codeman7","id":7131294,"node_id":"MDQ6VXNlcjcxMzEyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7131294?v=4","gravatar_id":"","url":"https://api.github.com/users/codeman7","html_url":"https://github.com/codeman7","followers_url":"https://api.github.com/users/codeman7/followers","following_url":"https://api.github.com/users/codeman7/following{/other_user}","gists_url":"https://api.github.com/users/codeman7/gists{/gist_id}","starred_url":"https://api.github.com/users/codeman7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeman7/subscriptions","organizations_url":"https://api.github.com/users/codeman7/orgs","repos_url":"https://api.github.com/users/codeman7/repos","events_url":"https://api.github.com/users/codeman7/events{/privacy}","received_events_url":"https://api.github.com/users/codeman7/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":392757587,"node_id":"MDU6TGFiZWwzOTI3NTc1ODc=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/[Dialogs]","name":"[Dialogs]","color":"eeeeee","default":false,"description":""},{"id":273191333,"node_id":"MDU6TGFiZWwyNzMxOTEzMzM=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/9033/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/9033/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/9033/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/8e496a53bf2913915c8f6afc882af82c0f13c44f","head":{"label":"bryanoltman:dialog-gm-motion","ref":"dialog-gm-motion","sha":"8e496a53bf2913915c8f6afc882af82c0f13c44f","user":{"login":"bryanoltman","id":581764,"node_id":"MDQ6VXNlcjU4MTc2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/581764?v=4","gravatar_id":"","url":"https://api.github.com/users/bryanoltman","html_url":"https://github.com/bryanoltman","followers_url":"https://api.github.com/users/bryanoltman/followers","following_url":"https://api.github.com/users/bryanoltman/following{/other_user}","gists_url":"https://api.github.com/users/bryanoltman/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanoltman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanoltman/subscriptions","organizations_url":"https://api.github.com/users/bryanoltman/orgs","repos_url":"https://api.github.com/users/bryanoltman/repos","events_url":"https://api.github.com/users/bryanoltman/events{/privacy}","received_events_url":"https://api.github.com/users/bryanoltman/received_events","type":"User","site_admin":false},"repo":{"id":217081023,"node_id":"MDEwOlJlcG9zaXRvcnkyMTcwODEwMjM=","name":"material-components-ios","full_name":"bryanoltman/material-components-ios","private":false,"owner":{"login":"bryanoltman","id":581764,"node_id":"MDQ6VXNlcjU4MTc2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/581764?v=4","gravatar_id":"","url":"https://api.github.com/users/bryanoltman","html_url":"https://github.com/bryanoltman","followers_url":"https://api.github.com/users/bryanoltman/followers","following_url":"https://api.github.com/users/bryanoltman/following{/other_user}","gists_url":"https://api.github.com/users/bryanoltman/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanoltman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanoltman/subscriptions","organizations_url":"https://api.github.com/users/bryanoltman/orgs","repos_url":"https://api.github.com/users/bryanoltman/repos","events_url":"https://api.github.com/users/bryanoltman/events{/privacy}","received_events_url":"https://api.github.com/users/bryanoltman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bryanoltman/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/bryanoltman/material-components-ios","forks_url":"https://api.github.com/repos/bryanoltman/material-components-ios/forks","keys_url":"https://api.github.com/repos/bryanoltman/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryanoltman/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryanoltman/material-components-ios/teams","hooks_url":"https://api.github.com/repos/bryanoltman/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/bryanoltman/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/bryanoltman/material-components-ios/events","assignees_url":"https://api.github.com/repos/bryanoltman/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/bryanoltman/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/bryanoltman/material-components-ios/tags","blobs_url":"https://api.github.com/repos/bryanoltman/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryanoltman/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryanoltman/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryanoltman/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryanoltman/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/bryanoltman/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/bryanoltman/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/bryanoltman/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/bryanoltman/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/bryanoltman/material-components-ios/subscription","commits_url":"https://api.github.com/repos/bryanoltman/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryanoltman/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryanoltman/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryanoltman/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryanoltman/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/bryanoltman/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryanoltman/material-components-ios/merges","archive_url":"https://api.github.com/repos/bryanoltman/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryanoltman/material-components-ios/downloads","issues_url":"https://api.github.com/repos/bryanoltman/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/bryanoltman/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/bryanoltman/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/bryanoltman/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryanoltman/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/bryanoltman/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/bryanoltman/material-components-ios/deployments","created_at":"2019-10-23T14:42:01Z","updated_at":"2019-11-27T16:17:21Z","pushed_at":"2019-11-27T16:34:22Z","git_url":"git://github.com/bryanoltman/material-components-ios.git","ssh_url":"git@github.com:bryanoltman/material-components-ios.git","clone_url":"https://github.com/bryanoltman/material-components-ios.git","svn_url":"https://github.com/bryanoltman/material-components-ios","homepage":"","size":157080,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"c56de0ef5ff4a58c4b6fe46121d53b1100262f6e","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgyMDIxOQ==","name":"material-components-ios","full_name":"material-components/material-components-ios","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2019-11-27T17:20:32Z","pushed_at":"2019-11-27T17:20:29Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":157651,"stargazers_count":3708,"watchers_count":3708,"language":"Objective-C","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":651,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":515,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":651,"open_issues":515,"watchers":3708,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/9033"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/9033"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/9033"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/9033/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/9033/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/9033/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/8e496a53bf2913915c8f6afc882af82c0f13c44f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"romoore"}}