{"action":"closed","number":1379,"pull_request":{"url":"https://api.github.com/repos/chef/ohai/pulls/1379","id":290431759,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwNDMxNzU5","html_url":"https://github.com/chef/ohai/pull/1379","diff_url":"https://github.com/chef/ohai/pull/1379.diff","patch_url":"https://github.com/chef/ohai/pull/1379.patch","issue_url":"https://api.github.com/repos/chef/ohai/issues/1379","number":1379,"state":"closed","locked":false,"title":"[shard_seed] fix default_sources for linux, darwin and windows","user":{"login":"michel-slm","id":85603,"node_id":"MDQ6VXNlcjg1NjAz","avatar_url":"https://avatars0.githubusercontent.com/u/85603?v=4","gravatar_id":"","url":"https://api.github.com/users/michel-slm","html_url":"https://github.com/michel-slm","followers_url":"https://api.github.com/users/michel-slm/followers","following_url":"https://api.github.com/users/michel-slm/following{/other_user}","gists_url":"https://api.github.com/users/michel-slm/gists{/gist_id}","starred_url":"https://api.github.com/users/michel-slm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michel-slm/subscriptions","organizations_url":"https://api.github.com/users/michel-slm/orgs","repos_url":"https://api.github.com/users/michel-slm/repos","events_url":"https://api.github.com/users/michel-slm/events{/privacy}","received_events_url":"https://api.github.com/users/michel-slm/received_events","type":"User","site_admin":false},"body":"## Description\r\n`collect_os` now returns a string (see `mixin/os.rb`), but the shard plugin still assumed it returns a symbol, so no matter the OS, unless overridden in `client.rb` this plugin will only use the machine name as the shard source.\r\n\r\nSigned-off-by: Michel Salim <michel@fb.com>\r\n\r\n## Related Issue\r\nhttps://github.com/chef/ohai/issues/1378\r\n\r\n## Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Chore (non-breaking change that does not add functionality or fix an issue)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have run the pre-merge tests locally and they pass.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n- [x] All commits have been signed-off for [the Developer Certificate of Origin](https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/chef/ohai/1379)\n<!-- Reviewable:end -->\n","created_at":"2019-06-21T01:32:48Z","updated_at":"2019-06-22T01:36:42Z","closed_at":"2019-06-22T01:36:42Z","merged_at":"2019-06-22T01:36:42Z","merge_commit_sha":"6e643b29f0e4b96773d5d81f2ce82664cf8cfe66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/ohai/pulls/1379/commits","review_comments_url":"https://api.github.com/repos/chef/ohai/pulls/1379/comments","review_comment_url":"https://api.github.com/repos/chef/ohai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/ohai/issues/1379/comments","statuses_url":"https://api.github.com/repos/chef/ohai/statuses/a849199c12041028faf93a16d193e4bf1a35ca2e","head":{"label":"michel-slm:fix-shard-on-mac","ref":"fix-shard-on-mac","sha":"a849199c12041028faf93a16d193e4bf1a35ca2e","user":{"login":"michel-slm","id":85603,"node_id":"MDQ6VXNlcjg1NjAz","avatar_url":"https://avatars0.githubusercontent.com/u/85603?v=4","gravatar_id":"","url":"https://api.github.com/users/michel-slm","html_url":"https://github.com/michel-slm","followers_url":"https://api.github.com/users/michel-slm/followers","following_url":"https://api.github.com/users/michel-slm/following{/other_user}","gists_url":"https://api.github.com/users/michel-slm/gists{/gist_id}","starred_url":"https://api.github.com/users/michel-slm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michel-slm/subscriptions","organizations_url":"https://api.github.com/users/michel-slm/orgs","repos_url":"https://api.github.com/users/michel-slm/repos","events_url":"https://api.github.com/users/michel-slm/events{/privacy}","received_events_url":"https://api.github.com/users/michel-slm/received_events","type":"User","site_admin":false},"repo":{"id":192998170,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI5OTgxNzA=","name":"ohai","full_name":"michel-slm/ohai","private":false,"owner":{"login":"michel-slm","id":85603,"node_id":"MDQ6VXNlcjg1NjAz","avatar_url":"https://avatars0.githubusercontent.com/u/85603?v=4","gravatar_id":"","url":"https://api.github.com/users/michel-slm","html_url":"https://github.com/michel-slm","followers_url":"https://api.github.com/users/michel-slm/followers","following_url":"https://api.github.com/users/michel-slm/following{/other_user}","gists_url":"https://api.github.com/users/michel-slm/gists{/gist_id}","starred_url":"https://api.github.com/users/michel-slm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michel-slm/subscriptions","organizations_url":"https://api.github.com/users/michel-slm/orgs","repos_url":"https://api.github.com/users/michel-slm/repos","events_url":"https://api.github.com/users/michel-slm/events{/privacy}","received_events_url":"https://api.github.com/users/michel-slm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/michel-slm/ohai","description":"Ohai profiles your system and emits JSON","fork":true,"url":"https://api.github.com/repos/michel-slm/ohai","forks_url":"https://api.github.com/repos/michel-slm/ohai/forks","keys_url":"https://api.github.com/repos/michel-slm/ohai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michel-slm/ohai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michel-slm/ohai/teams","hooks_url":"https://api.github.com/repos/michel-slm/ohai/hooks","issue_events_url":"https://api.github.com/repos/michel-slm/ohai/issues/events{/number}","events_url":"https://api.github.com/repos/michel-slm/ohai/events","assignees_url":"https://api.github.com/repos/michel-slm/ohai/assignees{/user}","branches_url":"https://api.github.com/repos/michel-slm/ohai/branches{/branch}","tags_url":"https://api.github.com/repos/michel-slm/ohai/tags","blobs_url":"https://api.github.com/repos/michel-slm/ohai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michel-slm/ohai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michel-slm/ohai/git/refs{/sha}","trees_url":"https://api.github.com/repos/michel-slm/ohai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michel-slm/ohai/statuses/{sha}","languages_url":"https://api.github.com/repos/michel-slm/ohai/languages","stargazers_url":"https://api.github.com/repos/michel-slm/ohai/stargazers","contributors_url":"https://api.github.com/repos/michel-slm/ohai/contributors","subscribers_url":"https://api.github.com/repos/michel-slm/ohai/subscribers","subscription_url":"https://api.github.com/repos/michel-slm/ohai/subscription","commits_url":"https://api.github.com/repos/michel-slm/ohai/commits{/sha}","git_commits_url":"https://api.github.com/repos/michel-slm/ohai/git/commits{/sha}","comments_url":"https://api.github.com/repos/michel-slm/ohai/comments{/number}","issue_comment_url":"https://api.github.com/repos/michel-slm/ohai/issues/comments{/number}","contents_url":"https://api.github.com/repos/michel-slm/ohai/contents/{+path}","compare_url":"https://api.github.com/repos/michel-slm/ohai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michel-slm/ohai/merges","archive_url":"https://api.github.com/repos/michel-slm/ohai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michel-slm/ohai/downloads","issues_url":"https://api.github.com/repos/michel-slm/ohai/issues{/number}","pulls_url":"https://api.github.com/repos/michel-slm/ohai/pulls{/number}","milestones_url":"https://api.github.com/repos/michel-slm/ohai/milestones{/number}","notifications_url":"https://api.github.com/repos/michel-slm/ohai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michel-slm/ohai/labels{/name}","releases_url":"https://api.github.com/repos/michel-slm/ohai/releases{/id}","deployments_url":"https://api.github.com/repos/michel-slm/ohai/deployments","created_at":"2019-06-20T23:14:21Z","updated_at":"2019-06-20T23:14:24Z","pushed_at":"2019-06-21T01:27:26Z","git_url":"git://github.com/michel-slm/ohai.git","ssh_url":"git@github.com:michel-slm/ohai.git","clone_url":"https://github.com/michel-slm/ohai.git","svn_url":"https://github.com/michel-slm/ohai","homepage":"https://docs.chef.io/ohai.html","size":6495,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"570fb2f076a420cab1e793e6849f80d2ba32722b","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":108289,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyODk=","name":"ohai","full_name":"chef/ohai","private":false,"owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef/ohai","description":"Ohai profiles your system and emits JSON","fork":false,"url":"https://api.github.com/repos/chef/ohai","forks_url":"https://api.github.com/repos/chef/ohai/forks","keys_url":"https://api.github.com/repos/chef/ohai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/ohai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/ohai/teams","hooks_url":"https://api.github.com/repos/chef/ohai/hooks","issue_events_url":"https://api.github.com/repos/chef/ohai/issues/events{/number}","events_url":"https://api.github.com/repos/chef/ohai/events","assignees_url":"https://api.github.com/repos/chef/ohai/assignees{/user}","branches_url":"https://api.github.com/repos/chef/ohai/branches{/branch}","tags_url":"https://api.github.com/repos/chef/ohai/tags","blobs_url":"https://api.github.com/repos/chef/ohai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/ohai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/ohai/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/ohai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/ohai/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/ohai/languages","stargazers_url":"https://api.github.com/repos/chef/ohai/stargazers","contributors_url":"https://api.github.com/repos/chef/ohai/contributors","subscribers_url":"https://api.github.com/repos/chef/ohai/subscribers","subscription_url":"https://api.github.com/repos/chef/ohai/subscription","commits_url":"https://api.github.com/repos/chef/ohai/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/ohai/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/ohai/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/ohai/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/ohai/contents/{+path}","compare_url":"https://api.github.com/repos/chef/ohai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/ohai/merges","archive_url":"https://api.github.com/repos/chef/ohai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/ohai/downloads","issues_url":"https://api.github.com/repos/chef/ohai/issues{/number}","pulls_url":"https://api.github.com/repos/chef/ohai/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/ohai/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/ohai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/ohai/labels{/name}","releases_url":"https://api.github.com/repos/chef/ohai/releases{/id}","deployments_url":"https://api.github.com/repos/chef/ohai/deployments","created_at":"2009-01-15T20:50:43Z","updated_at":"2019-06-18T22:09:44Z","pushed_at":"2019-06-22T01:36:42Z","git_url":"git://github.com/chef/ohai.git","ssh_url":"git@github.com:chef/ohai.git","clone_url":"https://github.com/chef/ohai.git","svn_url":"https://github.com/chef/ohai","homepage":"https://docs.chef.io/ohai.html","size":6501,"stargazers_count":616,"watchers_count":616,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":427,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":427,"open_issues":46,"watchers":616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/ohai/pulls/1379"},"html":{"href":"https://github.com/chef/ohai/pull/1379"},"issue":{"href":"https://api.github.com/repos/chef/ohai/issues/1379"},"comments":{"href":"https://api.github.com/repos/chef/ohai/issues/1379/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/ohai/pulls/1379/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/ohai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/ohai/pulls/1379/commits"},"statuses":{"href":"https://api.github.com/repos/chef/ohai/statuses/a849199c12041028faf93a16d193e4bf1a35ca2e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tas50","id":1015200,"node_id":"MDQ6VXNlcjEwMTUyMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1015200?v=4","gravatar_id":"","url":"https://api.github.com/users/tas50","html_url":"https://github.com/tas50","followers_url":"https://api.github.com/users/tas50/followers","following_url":"https://api.github.com/users/tas50/following{/other_user}","gists_url":"https://api.github.com/users/tas50/gists{/gist_id}","starred_url":"https://api.github.com/users/tas50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tas50/subscriptions","organizations_url":"https://api.github.com/users/tas50/orgs","repos_url":"https://api.github.com/users/tas50/repos","events_url":"https://api.github.com/users/tas50/events{/privacy}","received_events_url":"https://api.github.com/users/tas50/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"tas50"}}