{"action":"opened","number":11373,"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/11373","id":280061015,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwMDYxMDE1","html_url":"https://github.com/ArduPilot/ardupilot/pull/11373","diff_url":"https://github.com/ArduPilot/ardupilot/pull/11373.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/11373.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/11373","number":11373,"state":"open","locked":false,"title":"GCS_MAVLink: manual_override should ignore INT16_MAX, not treat as zero","user":{"login":"magicrub","id":4782875,"node_id":"MDQ6VXNlcjQ3ODI4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4782875?v=4","gravatar_id":"","url":"https://api.github.com/users/magicrub","html_url":"https://github.com/magicrub","followers_url":"https://api.github.com/users/magicrub/followers","following_url":"https://api.github.com/users/magicrub/following{/other_user}","gists_url":"https://api.github.com/users/magicrub/gists{/gist_id}","starred_url":"https://api.github.com/users/magicrub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicrub/subscriptions","organizations_url":"https://api.github.com/users/magicrub/orgs","repos_url":"https://api.github.com/users/magicrub/repos","events_url":"https://api.github.com/users/magicrub/events{/privacy}","received_events_url":"https://api.github.com/users/magicrub/received_events","type":"User","site_admin":false},"body":"Spec for the mavlink packet MANUAL_CONTROL (69) for an axis is:\r\n      <field type=\"int16_t\" name=\"x\">X-axis, normalized to the range [-1000,1000]. A value of INT16_MAX indicates that this axis is invalid. Generally corresponds to forward(1000)-backward(-1000) movement on a joystick and the pitch of a vehicle.</field>\r\n\r\nWe were treating INT16_MAX as zero pwm instead of ignoring it like we do correctly on the [RC_CHANNELS_OVERRIDE](https://github.com/ArduPilot/ardupilot/blob/master/libraries/GCS_MAVLink/GCS_Common.cpp#L3034).\r\n\r\nThis PR now correctly ignores INT16_MAX.","created_at":"2019-05-17T23:50:39Z","updated_at":"2019-05-17T23:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"peterbarker","id":7077857,"node_id":"MDQ6VXNlcjcwNzc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/11373/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/11373/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/11373/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/67ce7fecc7cd75591aa5ce75024bf3dc2026f47a","head":{"label":"aionrobotics:pr/manual_override_int16MAX","ref":"pr/manual_override_int16MAX","sha":"67ce7fecc7cd75591aa5ce75024bf3dc2026f47a","user":{"login":"aionrobotics","id":36354789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzU0Nzg5","avatar_url":"https://avatars3.githubusercontent.com/u/36354789?v=4","gravatar_id":"","url":"https://api.github.com/users/aionrobotics","html_url":"https://github.com/aionrobotics","followers_url":"https://api.github.com/users/aionrobotics/followers","following_url":"https://api.github.com/users/aionrobotics/following{/other_user}","gists_url":"https://api.github.com/users/aionrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/aionrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionrobotics/subscriptions","organizations_url":"https://api.github.com/users/aionrobotics/orgs","repos_url":"https://api.github.com/users/aionrobotics/repos","events_url":"https://api.github.com/users/aionrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/aionrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":162756414,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3NTY0MTQ=","name":"ardupilot","full_name":"aionrobotics/ardupilot","private":false,"owner":{"login":"aionrobotics","id":36354789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzU0Nzg5","avatar_url":"https://avatars3.githubusercontent.com/u/36354789?v=4","gravatar_id":"","url":"https://api.github.com/users/aionrobotics","html_url":"https://github.com/aionrobotics","followers_url":"https://api.github.com/users/aionrobotics/followers","following_url":"https://api.github.com/users/aionrobotics/following{/other_user}","gists_url":"https://api.github.com/users/aionrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/aionrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionrobotics/subscriptions","organizations_url":"https://api.github.com/users/aionrobotics/orgs","repos_url":"https://api.github.com/users/aionrobotics/repos","events_url":"https://api.github.com/users/aionrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/aionrobotics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aionrobotics/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":true,"url":"https://api.github.com/repos/aionrobotics/ardupilot","forks_url":"https://api.github.com/repos/aionrobotics/ardupilot/forks","keys_url":"https://api.github.com/repos/aionrobotics/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aionrobotics/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aionrobotics/ardupilot/teams","hooks_url":"https://api.github.com/repos/aionrobotics/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/aionrobotics/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/aionrobotics/ardupilot/events","assignees_url":"https://api.github.com/repos/aionrobotics/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/aionrobotics/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/aionrobotics/ardupilot/tags","blobs_url":"https://api.github.com/repos/aionrobotics/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aionrobotics/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aionrobotics/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/aionrobotics/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aionrobotics/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/aionrobotics/ardupilot/languages","stargazers_url":"https://api.github.com/repos/aionrobotics/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/aionrobotics/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/aionrobotics/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/aionrobotics/ardupilot/subscription","commits_url":"https://api.github.com/repos/aionrobotics/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/aionrobotics/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/aionrobotics/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/aionrobotics/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/aionrobotics/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/aionrobotics/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aionrobotics/ardupilot/merges","archive_url":"https://api.github.com/repos/aionrobotics/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aionrobotics/ardupilot/downloads","issues_url":"https://api.github.com/repos/aionrobotics/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/aionrobotics/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/aionrobotics/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/aionrobotics/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aionrobotics/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/aionrobotics/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/aionrobotics/ardupilot/deployments","created_at":"2018-12-21T20:45:43Z","updated_at":"2019-05-12T23:27:04Z","pushed_at":"2019-05-17T23:44:50Z","git_url":"git://github.com/aionrobotics/ardupilot.git","ssh_url":"git@github.com:aionrobotics/ardupilot.git","clone_url":"https://github.com/aionrobotics/ardupilot.git","svn_url":"https://github.com/aionrobotics/ardupilot","homepage":"http://ardupilot.org/","size":136743,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"1c816b1fe1ea3f4541a580b3a444442a098b4f5b","user":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEyNDg0","name":"ardupilot","full_name":"ArduPilot/ardupilot","private":false,"owner":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2019-05-17T23:42:16Z","pushed_at":"2019-05-17T23:40:58Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":137462,"stargazers_count":3993,"watchers_count":3993,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7803,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1481,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":7803,"open_issues":1481,"watchers":3993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/11373"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/11373"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/11373"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/11373/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/11373/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/11373/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/67ce7fecc7cd75591aa5ce75024bf3dc2026f47a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":11,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"magicrub"}}