{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/comments/353791599","pull_request_review_id":326908080,"id":353791599,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Mzc5MTU5OQ==","diff_hunk":"@@ -0,0 +1,10 @@\n+{% if not grains.get('qa_mode') %}\n+{% if grains['os_family'] == 'Suse' %}\n+update_system_packages:\n+  cmd.run:\n+    - name: zypper --non-interactive --gpg-auto-import-keys update","path":"salt/default/update.sls","position":5,"original_position":5,"commit_id":"99f6f270ed2b01fbf6d2bf1b3301255f30dfd249","original_commit_id":"99f6f270ed2b01fbf6d2bf1b3301255f30dfd249","user":{"login":"diegoakechi","id":8420718,"node_id":"MDQ6VXNlcjg0MjA3MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8420718?v=4","gravatar_id":"","url":"https://api.github.com/users/diegoakechi","html_url":"https://github.com/diegoakechi","followers_url":"https://api.github.com/users/diegoakechi/followers","following_url":"https://api.github.com/users/diegoakechi/following{/other_user}","gists_url":"https://api.github.com/users/diegoakechi/gists{/gist_id}","starred_url":"https://api.github.com/users/diegoakechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegoakechi/subscriptions","organizations_url":"https://api.github.com/users/diegoakechi/orgs","repos_url":"https://api.github.com/users/diegoakechi/repos","events_url":"https://api.github.com/users/diegoakechi/events{/privacy}","received_events_url":"https://api.github.com/users/diegoakechi/received_events","type":"User","site_admin":false},"body":"@varkoly I just run 2 tests on this and I am facing a conflict during the upgrade coming from OBS packages versus IBS packages. Nothing wrong with your code, but as the recommended packages are installed by default, we are pulling packages from OBS and causing this conflict. To be on the safe side, I suggest we upgrade only the required packages instead. This is also a good practice.\r\n```suggestion\r\n    - name: zypper --non-interactive --gpg-auto-import-keys update --no-recommends\r\n```","created_at":"2019-12-04T14:57:06Z","updated_at":"2019-12-04T14:57:27Z","html_url":"https://github.com/SUSE/ha-sap-terraform-deployments/pull/282#discussion_r353791599","pull_request_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/282","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/comments/353791599"},"html":{"href":"https://github.com/SUSE/ha-sap-terraform-deployments/pull/282#discussion_r353791599"},"pull_request":{"href":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/282"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/282","id":348725047,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4NzI1MDQ3","html_url":"https://github.com/SUSE/ha-sap-terraform-deployments/pull/282","diff_url":"https://github.com/SUSE/ha-sap-terraform-deployments/pull/282.diff","patch_url":"https://github.com/SUSE/ha-sap-terraform-deployments/pull/282.patch","issue_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/issues/282","number":282,"state":"open","locked":false,"title":"Update system during deployment","user":{"login":"varkoly","id":2426636,"node_id":"MDQ6VXNlcjI0MjY2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2426636?v=4","gravatar_id":"","url":"https://api.github.com/users/varkoly","html_url":"https://github.com/varkoly","followers_url":"https://api.github.com/users/varkoly/followers","following_url":"https://api.github.com/users/varkoly/following{/other_user}","gists_url":"https://api.github.com/users/varkoly/gists{/gist_id}","starred_url":"https://api.github.com/users/varkoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varkoly/subscriptions","organizations_url":"https://api.github.com/users/varkoly/orgs","repos_url":"https://api.github.com/users/varkoly/repos","events_url":"https://api.github.com/users/varkoly/events{/privacy}","received_events_url":"https://api.github.com/users/varkoly/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-04T06:56:23Z","updated_at":"2019-12-04T14:57:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc1d280b585cdd2ac3c383b907e0e09e37033059","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/282/commits","review_comments_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/282/comments","review_comment_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/issues/282/comments","statuses_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/statuses/99f6f270ed2b01fbf6d2bf1b3301255f30dfd249","head":{"label":"varkoly:develop","ref":"develop","sha":"99f6f270ed2b01fbf6d2bf1b3301255f30dfd249","user":{"login":"varkoly","id":2426636,"node_id":"MDQ6VXNlcjI0MjY2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2426636?v=4","gravatar_id":"","url":"https://api.github.com/users/varkoly","html_url":"https://github.com/varkoly","followers_url":"https://api.github.com/users/varkoly/followers","following_url":"https://api.github.com/users/varkoly/following{/other_user}","gists_url":"https://api.github.com/users/varkoly/gists{/gist_id}","starred_url":"https://api.github.com/users/varkoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varkoly/subscriptions","organizations_url":"https://api.github.com/users/varkoly/orgs","repos_url":"https://api.github.com/users/varkoly/repos","events_url":"https://api.github.com/users/varkoly/events{/privacy}","received_events_url":"https://api.github.com/users/varkoly/received_events","type":"User","site_admin":false},"repo":{"id":197562007,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc1NjIwMDc=","name":"ha-sap-terraform-deployments","full_name":"varkoly/ha-sap-terraform-deployments","private":false,"owner":{"login":"varkoly","id":2426636,"node_id":"MDQ6VXNlcjI0MjY2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2426636?v=4","gravatar_id":"","url":"https://api.github.com/users/varkoly","html_url":"https://github.com/varkoly","followers_url":"https://api.github.com/users/varkoly/followers","following_url":"https://api.github.com/users/varkoly/following{/other_user}","gists_url":"https://api.github.com/users/varkoly/gists{/gist_id}","starred_url":"https://api.github.com/users/varkoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varkoly/subscriptions","organizations_url":"https://api.github.com/users/varkoly/orgs","repos_url":"https://api.github.com/users/varkoly/repos","events_url":"https://api.github.com/users/varkoly/events{/privacy}","received_events_url":"https://api.github.com/users/varkoly/received_events","type":"User","site_admin":false},"html_url":"https://github.com/varkoly/ha-sap-terraform-deployments","description":"Automated SAP/HA Deployments in Public/Private Clouds","fork":true,"url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments","forks_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/forks","keys_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/teams","hooks_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/hooks","issue_events_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/issues/events{/number}","events_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/events","assignees_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/assignees{/user}","branches_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/branches{/branch}","tags_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/tags","blobs_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/git/refs{/sha}","trees_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/statuses/{sha}","languages_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/languages","stargazers_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/stargazers","contributors_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/contributors","subscribers_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/subscribers","subscription_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/subscription","commits_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/commits{/sha}","git_commits_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/git/commits{/sha}","comments_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/comments{/number}","issue_comment_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/issues/comments{/number}","contents_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/contents/{+path}","compare_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/merges","archive_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/downloads","issues_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/issues{/number}","pulls_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/pulls{/number}","milestones_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/milestones{/number}","notifications_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/labels{/name}","releases_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/releases{/id}","deployments_url":"https://api.github.com/repos/varkoly/ha-sap-terraform-deployments/deployments","created_at":"2019-07-18T10:04:16Z","updated_at":"2019-07-18T10:09:10Z","pushed_at":"2019-12-04T10:08:44Z","git_url":"git://github.com/varkoly/ha-sap-terraform-deployments.git","ssh_url":"git@github.com:varkoly/ha-sap-terraform-deployments.git","clone_url":"https://github.com/varkoly/ha-sap-terraform-deployments.git","svn_url":"https://github.com/varkoly/ha-sap-terraform-deployments","homepage":null,"size":1064,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE:develop","ref":"develop","sha":"d2b37b8d5a56bad4d40e8782e2ce969912b68f10","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":153756958,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3NTY5NTg=","name":"ha-sap-terraform-deployments","full_name":"SUSE/ha-sap-terraform-deployments","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/ha-sap-terraform-deployments","description":"Automated SAP/HA Deployments in Public/Private Clouds","fork":false,"url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments","forks_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/forks","keys_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/teams","hooks_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/hooks","issue_events_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/events","assignees_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/tags","blobs_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/languages","stargazers_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/stargazers","contributors_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/contributors","subscribers_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/subscribers","subscription_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/subscription","commits_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/merges","archive_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/downloads","issues_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/deployments","created_at":"2018-10-19T09:13:16Z","updated_at":"2019-11-18T13:48:27Z","pushed_at":"2019-12-04T10:08:46Z","git_url":"git://github.com/SUSE/ha-sap-terraform-deployments.git","ssh_url":"git@github.com:SUSE/ha-sap-terraform-deployments.git","clone_url":"https://github.com/SUSE/ha-sap-terraform-deployments.git","svn_url":"https://github.com/SUSE/ha-sap-terraform-deployments","homepage":null,"size":1064,"stargazers_count":25,"watchers_count":25,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":19,"open_issues":24,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/282"},"html":{"href":"https://github.com/SUSE/ha-sap-terraform-deployments/pull/282"},"issue":{"href":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/issues/282"},"comments":{"href":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/ha-sap-terraform-deployments/statuses/99f6f270ed2b01fbf6d2bf1b3301255f30dfd249"}},"author_association":"NONE"}}
{"actor":{"display_login":"diegoakechi"}}