{"action":"created","issue":{"url":"https://api.github.com/repos/dcos/dcos/issues/6691","repository_url":"https://api.github.com/repos/dcos/dcos","labels_url":"https://api.github.com/repos/dcos/dcos/issues/6691/labels{/name}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/6691/comments","events_url":"https://api.github.com/repos/dcos/dcos/issues/6691/events","html_url":"https://github.com/dcos/dcos/pull/6691","id":540937495,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU1NjgxODE2","number":6691,"title":"admin router: prevent adminrouter from passing authrization header to etcd","user":{"login":"vespian","id":2124609,"node_id":"MDQ6VXNlcjIxMjQ2MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2124609?v=4","gravatar_id":"","url":"https://api.github.com/users/vespian","html_url":"https://github.com/vespian","followers_url":"https://api.github.com/users/vespian/followers","following_url":"https://api.github.com/users/vespian/following{/other_user}","gists_url":"https://api.github.com/users/vespian/gists{/gist_id}","starred_url":"https://api.github.com/users/vespian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespian/subscriptions","organizations_url":"https://api.github.com/users/vespian/orgs","repos_url":"https://api.github.com/users/vespian/repos","events_url":"https://api.github.com/users/vespian/events{/privacy}","received_events_url":"https://api.github.com/users/vespian/received_events","type":"User","site_admin":false},"labels":[{"id":364878184,"node_id":"MDU6TGFiZWwzNjQ4NzgxODQ=","url":"https://api.github.com/repos/dcos/dcos/labels/Ready%20For%20Review","name":"Ready For Review","color":"0e8a16","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2019-12-20T11:03:01Z","updated_at":"2019-12-25T09:31:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/6691","html_url":"https://github.com/dcos/dcos/pull/6691","diff_url":"https://github.com/dcos/dcos/pull/6691.diff","patch_url":"https://github.com/dcos/dcos/pull/6691.patch"},"body":"## High-level description\r\n\r\netcd does not tollerate the `authorization` header we set to do authn&authz as it expects it's own authorization token there instead of DC/OS authentication token. The solution is to filter it out in AR.\r\n\r\n## Corresponding DC/OS tickets (required)\r\n\r\n  - https://jira.mesosphere.com/browse/DCOS-62479 `Prevent AR from passing Authorization header to etcd`\r\n\r\n## Checklist for component/package updates:\r\n\r\nIf you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath `packages`), then in addition to the above please also include:\r\n\r\n  - [ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): [example](https://github.com/dcos/dcos-mesos-modules/compare/f6fa27d7c40f4207ba3bb2274e2cfe79b62a395a...6660b90fbbf69a15ef46d0184e36755881d6a5ae)\r\n  - [ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.\r\n  - [ ] Test Results: [link to CI job test results for component]\r\n  - [ ] Code Coverage (if available): [link to code coverage report]\r\n  \r\n\r\n<!--\r\n\r\n## Instructions and review process\r\n\r\n**What is the review process and when will my changes land?**\r\n\r\nAll PRs require approvals from any two users on the most recent commit. Any commits added to the pull request after approval will invalidate the approvals.\r\n\r\nReviewers should be:\r\n\r\n* Developers who understand the code being modified.\r\n* Developers responsible for code that interacts with or depends on the code being modified.\r\n\r\nIt is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. \r\nOnce a PR has **2 approvals**, **no red reviews**, and **all tests are green** it will be included in the next Merge Train.\r\n\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/dcos/dcos/issues/comments/568874078","html_url":"https://github.com/dcos/dcos/pull/6691#issuecomment-568874078","issue_url":"https://api.github.com/repos/dcos/dcos/issues/6691","id":568874078,"node_id":"MDEyOklzc3VlQ29tbWVudDU2ODg3NDA3OA==","user":{"login":"mainred","id":1465768,"node_id":"MDQ6VXNlcjE0NjU3Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/1465768?v=4","gravatar_id":"","url":"https://api.github.com/users/mainred","html_url":"https://github.com/mainred","followers_url":"https://api.github.com/users/mainred/followers","following_url":"https://api.github.com/users/mainred/following{/other_user}","gists_url":"https://api.github.com/users/mainred/gists{/gist_id}","starred_url":"https://api.github.com/users/mainred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mainred/subscriptions","organizations_url":"https://api.github.com/users/mainred/orgs","repos_url":"https://api.github.com/users/mainred/repos","events_url":"https://api.github.com/users/mainred/events{/privacy}","received_events_url":"https://api.github.com/users/mainred/received_events","type":"User","site_admin":false},"created_at":"2019-12-25T09:31:35Z","updated_at":"2019-12-25T09:31:35Z","author_association":"CONTRIBUTOR","body":"@mesosphere-mergebot sync\r\n\r\n"}}
{"actor":{"display_login":"mainred"}}