{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/comments/254283571","pull_request_review_id":200592229,"id":254283571,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDI4MzU3MQ==","diff_hunk":"@@ -0,0 +1,109 @@\n+/*\n+ * Copyright 2017-2019 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.springframework.data.jdbc.repository.config;\n+\n+import java.util.Optional;\n+\n+import org.springframework.context.ApplicationEventPublisher;\n+import org.springframework.context.annotation.Bean;\n+import org.springframework.context.annotation.Configuration;\n+import org.springframework.core.convert.converter.Converter;\n+import org.springframework.data.jdbc.core.DataAccessStrategy;\n+import org.springframework.data.jdbc.core.DefaultDataAccessStrategy;\n+import org.springframework.data.jdbc.core.JdbcAggregateTemplate;\n+import org.springframework.data.jdbc.core.SqlGeneratorSource;\n+import org.springframework.data.jdbc.core.convert.BasicJdbcConverter;\n+import org.springframework.data.jdbc.core.convert.JdbcConverter;\n+import org.springframework.data.jdbc.core.convert.JdbcCustomConversions;\n+import org.springframework.data.jdbc.core.mapping.JdbcMappingContext;\n+import org.springframework.data.relational.core.conversion.RelationalConverter;\n+import org.springframework.data.relational.core.mapping.NamingStrategy;\n+import org.springframework.data.relational.core.mapping.RelationalMappingContext;\n+import org.springframework.jdbc.core.namedparam.NamedParameterJdbcOperations;\n+\n+/**\n+ * Beans that must be registered for Spring Data JDBC to work.\n+ *\n+ * @author Greg Turnquist\n+ * @author Jens Schauder\n+ * @author Mark Paluch\n+ * @author Michael Simons\n+ * @author Christoph Strobl\n+ * @since 1.1\n+ */\n+@Configuration\n+public abstract class AbstractJdbcConfiguration {\n+\n+\t/**\n+\t * Register a {@link RelationalMappingContext} and apply an optional {@link NamingStrategy}.\n+\t *\n+\t * @param namingStrategy optional {@link NamingStrategy}. Use {@link NamingStrategy#INSTANCE} as fallback.\n+\t * @return must not be {@literal null}.\n+\t */\n+\t@Bean\n+\tpublic JdbcMappingContext jdbcMappingContext(Optional<NamingStrategy> namingStrategy) {\n+\n+\t\tJdbcMappingContext mappingContext = new JdbcMappingContext(namingStrategy.orElse(NamingStrategy.INSTANCE));\n+\t\tmappingContext.setSimpleTypeHolder(jdbcCustomConversions().getSimpleTypeHolder());\n+\n+\t\treturn mappingContext;\n+\t}\n+\n+\t/**\n+\t * Creates a {@link RelationalConverter} using the configured {@link #jdbcMappingContext(Optional)}. Will get\n+\t * {@link #jdbcCustomConversions()} applied.\n+\t *\n+\t * @see #jdbcMappingContext(Optional)\n+\t * @see #jdbcCustomConversions()\n+\t * @return must not be {@literal null}.\n+\t */\n+\t@Bean\n+\tpublic JdbcConverter relationalConverter(RelationalMappingContext mappingContext) {","path":"spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/config/AbstractJdbcConfiguration.java","position":74,"original_position":74,"commit_id":"13b7e2f77c0417c0ceedd13aea1dca6ef62127b8","original_commit_id":"13b7e2f77c0417c0ceedd13aea1dca6ef62127b8","user":{"login":"schauder","id":136683,"node_id":"MDQ6VXNlcjEzNjY4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/136683?v=4","gravatar_id":"","url":"https://api.github.com/users/schauder","html_url":"https://github.com/schauder","followers_url":"https://api.github.com/users/schauder/followers","following_url":"https://api.github.com/users/schauder/following{/other_user}","gists_url":"https://api.github.com/users/schauder/gists{/gist_id}","starred_url":"https://api.github.com/users/schauder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schauder/subscriptions","organizations_url":"https://api.github.com/users/schauder/orgs","repos_url":"https://api.github.com/users/schauder/repos","events_url":"https://api.github.com/users/schauder/events{/privacy}","received_events_url":"https://api.github.com/users/schauder/received_events","type":"User","site_admin":false},"body":"arg, missed that.","created_at":"2019-02-06T14:08:36Z","updated_at":"2019-02-06T14:08:36Z","html_url":"https://github.com/spring-projects/spring-data-jdbc/pull/116#discussion_r254283571","pull_request_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/116","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/comments/254283571"},"html":{"href":"https://github.com/spring-projects/spring-data-jdbc/pull/116#discussion_r254283571"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/116"}},"in_reply_to_id":254259997},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/116","id":250742260,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwNzQyMjYw","html_url":"https://github.com/spring-projects/spring-data-jdbc/pull/116","diff_url":"https://github.com/spring-projects/spring-data-jdbc/pull/116.diff","patch_url":"https://github.com/spring-projects/spring-data-jdbc/pull/116.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/issues/116","number":116,"state":"open","locked":false,"title":"DATAJDBC-329 - Replacing JdbcConfiguration.","user":{"login":"schauder","id":136683,"node_id":"MDQ6VXNlcjEzNjY4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/136683?v=4","gravatar_id":"","url":"https://api.github.com/users/schauder","html_url":"https://github.com/schauder","followers_url":"https://api.github.com/users/schauder/followers","following_url":"https://api.github.com/users/schauder/following{/other_user}","gists_url":"https://api.github.com/users/schauder/gists{/gist_id}","starred_url":"https://api.github.com/users/schauder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schauder/subscriptions","organizations_url":"https://api.github.com/users/schauder/orgs","repos_url":"https://api.github.com/users/schauder/repos","events_url":"https://api.github.com/users/schauder/events{/privacy}","received_events_url":"https://api.github.com/users/schauder/received_events","type":"User","site_admin":false},"body":"Reverting breaking changes to JdbcConfiguration.\r\nDeprecating JdbcConfiguration in favor of AbstractJdbcConfiguration.\r\nCleaning up the API to separate it from spring-data-relational and therefore R2DBC.","created_at":"2019-02-06T12:50:36Z","updated_at":"2019-02-06T14:08:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e7776871f00411cb70bbc25dfb6be1940084638","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/116/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/116/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/issues/116/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/statuses/13b7e2f77c0417c0ceedd13aea1dca6ef62127b8","head":{"label":"spring-projects:issue/DATAJDBC-329","ref":"issue/DATAJDBC-329","sha":"13b7e2f77c0417c0ceedd13aea1dca6ef62127b8","user":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":82077268,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA3NzI2OA==","name":"spring-data-jdbc","full_name":"spring-projects/spring-data-jdbc","private":false,"owner":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spring-projects/spring-data-jdbc","description":"Spring Data JDBC","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-data-jdbc","forks_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/deployments","created_at":"2017-02-15T15:47:29Z","updated_at":"2019-02-06T13:55:58Z","pushed_at":"2019-02-06T13:56:15Z","git_url":"git://github.com/spring-projects/spring-data-jdbc.git","ssh_url":"git@github.com:spring-projects/spring-data-jdbc.git","clone_url":"https://github.com/spring-projects/spring-data-jdbc.git","svn_url":"https://github.com/spring-projects/spring-data-jdbc","homepage":"https://spring.io/projects/spring-data-jdbc","size":2409,"stargazers_count":205,"watchers_count":205,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":77,"open_issues":3,"watchers":205,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"75ea44536f5361867c07d41c7a12ac772a940e94","user":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":82077268,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA3NzI2OA==","name":"spring-data-jdbc","full_name":"spring-projects/spring-data-jdbc","private":false,"owner":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spring-projects/spring-data-jdbc","description":"Spring Data JDBC","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-data-jdbc","forks_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-data-jdbc/deployments","created_at":"2017-02-15T15:47:29Z","updated_at":"2019-02-06T13:55:58Z","pushed_at":"2019-02-06T13:56:15Z","git_url":"git://github.com/spring-projects/spring-data-jdbc.git","ssh_url":"git@github.com:spring-projects/spring-data-jdbc.git","clone_url":"https://github.com/spring-projects/spring-data-jdbc.git","svn_url":"https://github.com/spring-projects/spring-data-jdbc","homepage":"https://spring.io/projects/spring-data-jdbc","size":2409,"stargazers_count":205,"watchers_count":205,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":77,"open_issues":3,"watchers":205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/116"},"html":{"href":"https://github.com/spring-projects/spring-data-jdbc/pull/116"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-data-jdbc/issues/116"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-data-jdbc/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-data-jdbc/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-data-jdbc/statuses/13b7e2f77c0417c0ceedd13aea1dca6ef62127b8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"schauder"}}