{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/cwp-recipe-kitchen-sink/issues/46","repository_url":"https://api.github.com/repos/silverstripe/cwp-recipe-kitchen-sink","labels_url":"https://api.github.com/repos/silverstripe/cwp-recipe-kitchen-sink/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/cwp-recipe-kitchen-sink/issues/46/comments","events_url":"https://api.github.com/repos/silverstripe/cwp-recipe-kitchen-sink/issues/46/events","html_url":"https://github.com/silverstripe/cwp-recipe-kitchen-sink/issues/46","id":513556539,"node_id":"MDU6SXNzdWU1MTM1NTY1Mzk=","number":46,"title":"All CWP modules should have a branch targeting next minor release","user":{"login":"brynwhyman","id":15868440,"node_id":"MDQ6VXNlcjE1ODY4NDQw","avatar_url":"https://avatars3.githubusercontent.com/u/15868440?v=4","gravatar_id":"","url":"https://api.github.com/users/brynwhyman","html_url":"https://github.com/brynwhyman","followers_url":"https://api.github.com/users/brynwhyman/followers","following_url":"https://api.github.com/users/brynwhyman/following{/other_user}","gists_url":"https://api.github.com/users/brynwhyman/gists{/gist_id}","starred_url":"https://api.github.com/users/brynwhyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brynwhyman/subscriptions","organizations_url":"https://api.github.com/users/brynwhyman/orgs","repos_url":"https://api.github.com/users/brynwhyman/repos","events_url":"https://api.github.com/users/brynwhyman/events{/privacy}","received_events_url":"https://api.github.com/users/brynwhyman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dnsl48","id":9313746,"node_id":"MDQ6VXNlcjkzMTM3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/9313746?v=4","gravatar_id":"","url":"https://api.github.com/users/dnsl48","html_url":"https://github.com/dnsl48","followers_url":"https://api.github.com/users/dnsl48/followers","following_url":"https://api.github.com/users/dnsl48/following{/other_user}","gists_url":"https://api.github.com/users/dnsl48/gists{/gist_id}","starred_url":"https://api.github.com/users/dnsl48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnsl48/subscriptions","organizations_url":"https://api.github.com/users/dnsl48/orgs","repos_url":"https://api.github.com/users/dnsl48/repos","events_url":"https://api.github.com/users/dnsl48/events{/privacy}","received_events_url":"https://api.github.com/users/dnsl48/received_events","type":"User","site_admin":false},"assignees":[{"login":"dnsl48","id":9313746,"node_id":"MDQ6VXNlcjkzMTM3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/9313746?v=4","gravatar_id":"","url":"https://api.github.com/users/dnsl48","html_url":"https://github.com/dnsl48","followers_url":"https://api.github.com/users/dnsl48/followers","following_url":"https://api.github.com/users/dnsl48/following{/other_user}","gists_url":"https://api.github.com/users/dnsl48/gists{/gist_id}","starred_url":"https://api.github.com/users/dnsl48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnsl48/subscriptions","organizations_url":"https://api.github.com/users/dnsl48/orgs","repos_url":"https://api.github.com/users/dnsl48/repos","events_url":"https://api.github.com/users/dnsl48/events{/privacy}","received_events_url":"https://api.github.com/users/dnsl48/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/silverstripe/cwp-recipe-kitchen-sink/milestones/26","html_url":"https://github.com/silverstripe/cwp-recipe-kitchen-sink/milestone/26","labels_url":"https://api.github.com/repos/silverstripe/cwp-recipe-kitchen-sink/milestones/26/labels","id":4796649,"node_id":"MDk6TWlsZXN0b25lNDc5NjY0OQ==","number":26,"title":"Sprint 47","description":"","creator":{"login":"brynwhyman","id":15868440,"node_id":"MDQ6VXNlcjE1ODY4NDQw","avatar_url":"https://avatars3.githubusercontent.com/u/15868440?v=4","gravatar_id":"","url":"https://api.github.com/users/brynwhyman","html_url":"https://github.com/brynwhyman","followers_url":"https://api.github.com/users/brynwhyman/followers","following_url":"https://api.github.com/users/brynwhyman/following{/other_user}","gists_url":"https://api.github.com/users/brynwhyman/gists{/gist_id}","starred_url":"https://api.github.com/users/brynwhyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brynwhyman/subscriptions","organizations_url":"https://api.github.com/users/brynwhyman/orgs","repos_url":"https://api.github.com/users/brynwhyman/repos","events_url":"https://api.github.com/users/brynwhyman/events{/privacy}","received_events_url":"https://api.github.com/users/brynwhyman/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2019-10-29T20:08:11Z","updated_at":"2019-10-29T21:37:17Z","due_on":"2019-11-11T08:00:00Z","closed_at":null},"comments":19,"created_at":"2019-10-28T21:03:06Z","updated_at":"2019-11-04T18:06:04Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Particularly in the CWP modules, the `master` is targeting the latest minor release (4.4.x), which means that we don't have automated builds running CWP against the next minor branch (4.5.x). This is in contrast to the core modules which use `master` to target SS5.\r\n\r\nWe need to do some immediate work to fix this for the upcoming release. \r\n\r\nAC\r\n- (CWP) modules included kitchen-sink are tracking builds of the next minor release of core modules to ensure that we're prepared in time for the upcoming release.\r\n\r\n## PRs\r\n - [x] https://github.com/silverstripe/silverstripe-framework/pull/9310"},"comment":{"url":"https://api.github.com/repos/silverstripe/cwp-recipe-kitchen-sink/issues/comments/549476527","html_url":"https://github.com/silverstripe/cwp-recipe-kitchen-sink/issues/46#issuecomment-549476527","issue_url":"https://api.github.com/repos/silverstripe/cwp-recipe-kitchen-sink/issues/46","id":549476527,"node_id":"MDEyOklzc3VlQ29tbWVudDU0OTQ3NjUyNw==","user":{"login":"ScopeyNZ","id":3260989,"node_id":"MDQ6VXNlcjMyNjA5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/3260989?v=4","gravatar_id":"","url":"https://api.github.com/users/ScopeyNZ","html_url":"https://github.com/ScopeyNZ","followers_url":"https://api.github.com/users/ScopeyNZ/followers","following_url":"https://api.github.com/users/ScopeyNZ/following{/other_user}","gists_url":"https://api.github.com/users/ScopeyNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ScopeyNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScopeyNZ/subscriptions","organizations_url":"https://api.github.com/users/ScopeyNZ/orgs","repos_url":"https://api.github.com/users/ScopeyNZ/repos","events_url":"https://api.github.com/users/ScopeyNZ/events{/privacy}","received_events_url":"https://api.github.com/users/ScopeyNZ/received_events","type":"User","site_admin":false},"created_at":"2019-11-04T18:06:04Z","updated_at":"2019-11-04T18:06:04Z","author_association":"MEMBER","body":"I am probably starting to sound a bit annoying right now but I don't accept the statements:\r\n\r\n- Better consistency - given the number of PRs you're raising that \"remove branch aliases\" - and the number of \"next minor\" branches we don't have on our satellite modules, I'd say we were pretty consistent before. I think you're talking about \"better consistency with core\" which I acknowledge but I think it's important that contributors understand the differences between a satellite module and core anyway\r\n\r\n- Simpler conventions - I don't think that having a `master` with a branch alias is any more confusing than having `master` and a `minor` branch.\r\n\r\n- reduces learning curve for new devs and potential new contributors/maintainers - 90% of PRs are just made to the default branch anyway - often mistakenly because of bugfixes. I don't think \"I don't know what target branch\" really stops contributions. The default branch will still have to be correct going forwards\r\n\r\nAgain, perhaps I've latched onto this a little too much but it pains me to watch you have to spend _days_ on something that might save us a few hours over the next few years - and I'm not joking here - I've had to deal with the existing system for a while now.\r\n\r\nI guess the other thing that gets me here is that the issue is titled \"All CWP modules should have a branch targeting next minor release\" and if I saw it then I could've said \"they do\"."}}
{"actor":{"display_login":"ScopeyNZ"}}