{"action":"closed","number":218,"pull_request":{"url":"https://api.github.com/repos/openebs/node-disk-manager/pulls/218","id":257890559,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3ODkwNTU5","html_url":"https://github.com/openebs/node-disk-manager/pull/218","diff_url":"https://github.com/openebs/node-disk-manager/pull/218.diff","patch_url":"https://github.com/openebs/node-disk-manager/pull/218.patch","issue_url":"https://api.github.com/repos/openebs/node-disk-manager/issues/218","number":218,"state":"closed","locked":false,"title":"[US4256] feat(Controller): Bussiness logic for Controllers.","user":{"login":"satbirchhikara","id":34478047,"node_id":"MDQ6VXNlcjM0NDc4MDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/34478047?v=4","gravatar_id":"","url":"https://api.github.com/users/satbirchhikara","html_url":"https://github.com/satbirchhikara","followers_url":"https://api.github.com/users/satbirchhikara/followers","following_url":"https://api.github.com/users/satbirchhikara/following{/other_user}","gists_url":"https://api.github.com/users/satbirchhikara/gists{/gist_id}","starred_url":"https://api.github.com/users/satbirchhikara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satbirchhikara/subscriptions","organizations_url":"https://api.github.com/users/satbirchhikara/orgs","repos_url":"https://api.github.com/users/satbirchhikara/repos","events_url":"https://api.github.com/users/satbirchhikara/events{/privacy}","received_events_url":"https://api.github.com/users/satbirchhikara/received_events","type":"User","site_admin":false},"body":"Implement reconciliation logic for Disk, Device & DeviceRequest controller.\r\nSmall description of changes can be found [here](https://docs.google.com/document/d/1n0fqQ-yLNk60CfexQ__R1DyIqMeePZk952-vbbj6QRQ/edit?usp=sharing).\r\n\r\nSigned-off-by: satbir <satbir.singh@mayadata.io>","created_at":"2019-03-04T10:35:23Z","updated_at":"2019-03-21T17:59:44Z","closed_at":"2019-03-21T17:59:44Z","merged_at":"2019-03-21T17:59:44Z","merge_commit_sha":"9340cc2d95284f360b67138a4d77b7d0c5730986","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AmitKumarDas","id":2794362,"node_id":"MDQ6VXNlcjI3OTQzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/2794362?v=4","gravatar_id":"","url":"https://api.github.com/users/AmitKumarDas","html_url":"https://github.com/AmitKumarDas","followers_url":"https://api.github.com/users/AmitKumarDas/followers","following_url":"https://api.github.com/users/AmitKumarDas/following{/other_user}","gists_url":"https://api.github.com/users/AmitKumarDas/gists{/gist_id}","starred_url":"https://api.github.com/users/AmitKumarDas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmitKumarDas/subscriptions","organizations_url":"https://api.github.com/users/AmitKumarDas/orgs","repos_url":"https://api.github.com/users/AmitKumarDas/repos","events_url":"https://api.github.com/users/AmitKumarDas/events{/privacy}","received_events_url":"https://api.github.com/users/AmitKumarDas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openebs/node-disk-manager/pulls/218/commits","review_comments_url":"https://api.github.com/repos/openebs/node-disk-manager/pulls/218/comments","review_comment_url":"https://api.github.com/repos/openebs/node-disk-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openebs/node-disk-manager/issues/218/comments","statuses_url":"https://api.github.com/repos/openebs/node-disk-manager/statuses/a465f2c19d1da0d89ba5627ccd68500f86d70bba","head":{"label":"satbirchhikara:bussiness_logic","ref":"bussiness_logic","sha":"a465f2c19d1da0d89ba5627ccd68500f86d70bba","user":{"login":"satbirchhikara","id":34478047,"node_id":"MDQ6VXNlcjM0NDc4MDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/34478047?v=4","gravatar_id":"","url":"https://api.github.com/users/satbirchhikara","html_url":"https://github.com/satbirchhikara","followers_url":"https://api.github.com/users/satbirchhikara/followers","following_url":"https://api.github.com/users/satbirchhikara/following{/other_user}","gists_url":"https://api.github.com/users/satbirchhikara/gists{/gist_id}","starred_url":"https://api.github.com/users/satbirchhikara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satbirchhikara/subscriptions","organizations_url":"https://api.github.com/users/satbirchhikara/orgs","repos_url":"https://api.github.com/users/satbirchhikara/repos","events_url":"https://api.github.com/users/satbirchhikara/events{/privacy}","received_events_url":"https://api.github.com/users/satbirchhikara/received_events","type":"User","site_admin":false},"repo":{"id":158663526,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg2NjM1MjY=","name":"node-disk-manager","full_name":"satbirchhikara/node-disk-manager","private":false,"owner":{"login":"satbirchhikara","id":34478047,"node_id":"MDQ6VXNlcjM0NDc4MDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/34478047?v=4","gravatar_id":"","url":"https://api.github.com/users/satbirchhikara","html_url":"https://github.com/satbirchhikara","followers_url":"https://api.github.com/users/satbirchhikara/followers","following_url":"https://api.github.com/users/satbirchhikara/following{/other_user}","gists_url":"https://api.github.com/users/satbirchhikara/gists{/gist_id}","starred_url":"https://api.github.com/users/satbirchhikara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satbirchhikara/subscriptions","organizations_url":"https://api.github.com/users/satbirchhikara/orgs","repos_url":"https://api.github.com/users/satbirchhikara/repos","events_url":"https://api.github.com/users/satbirchhikara/events{/privacy}","received_events_url":"https://api.github.com/users/satbirchhikara/received_events","type":"User","site_admin":false},"html_url":"https://github.com/satbirchhikara/node-disk-manager","description":"node-disk-manager(ndm) runs as a DaemonSet in Kubernetes and helps with Disk Inventory Management","fork":true,"url":"https://api.github.com/repos/satbirchhikara/node-disk-manager","forks_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/forks","keys_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/teams","hooks_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/hooks","issue_events_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/issues/events{/number}","events_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/events","assignees_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/assignees{/user}","branches_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/branches{/branch}","tags_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/tags","blobs_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/languages","stargazers_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/stargazers","contributors_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/contributors","subscribers_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/subscribers","subscription_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/subscription","commits_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/contents/{+path}","compare_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/merges","archive_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/downloads","issues_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/issues{/number}","pulls_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/labels{/name}","releases_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/releases{/id}","deployments_url":"https://api.github.com/repos/satbirchhikara/node-disk-manager/deployments","created_at":"2018-11-22T08:05:59Z","updated_at":"2019-03-04T05:08:02Z","pushed_at":"2019-03-21T12:22:48Z","git_url":"git://github.com/satbirchhikara/node-disk-manager.git","ssh_url":"git@github.com:satbirchhikara/node-disk-manager.git","clone_url":"https://github.com/satbirchhikara/node-disk-manager.git","svn_url":"https://github.com/satbirchhikara/node-disk-manager","homepage":"","size":63119,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openebs:master","ref":"master","sha":"f0414e079357a8e70dbf81110dbf2b60ffad8d35","user":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"repo":{"id":124062056,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwNjIwNTY=","name":"node-disk-manager","full_name":"openebs/node-disk-manager","private":false,"owner":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openebs/node-disk-manager","description":"node-disk-manager(ndm) runs as a DaemonSet in Kubernetes and helps with Disk Inventory Management","fork":false,"url":"https://api.github.com/repos/openebs/node-disk-manager","forks_url":"https://api.github.com/repos/openebs/node-disk-manager/forks","keys_url":"https://api.github.com/repos/openebs/node-disk-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openebs/node-disk-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openebs/node-disk-manager/teams","hooks_url":"https://api.github.com/repos/openebs/node-disk-manager/hooks","issue_events_url":"https://api.github.com/repos/openebs/node-disk-manager/issues/events{/number}","events_url":"https://api.github.com/repos/openebs/node-disk-manager/events","assignees_url":"https://api.github.com/repos/openebs/node-disk-manager/assignees{/user}","branches_url":"https://api.github.com/repos/openebs/node-disk-manager/branches{/branch}","tags_url":"https://api.github.com/repos/openebs/node-disk-manager/tags","blobs_url":"https://api.github.com/repos/openebs/node-disk-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openebs/node-disk-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openebs/node-disk-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/openebs/node-disk-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openebs/node-disk-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/openebs/node-disk-manager/languages","stargazers_url":"https://api.github.com/repos/openebs/node-disk-manager/stargazers","contributors_url":"https://api.github.com/repos/openebs/node-disk-manager/contributors","subscribers_url":"https://api.github.com/repos/openebs/node-disk-manager/subscribers","subscription_url":"https://api.github.com/repos/openebs/node-disk-manager/subscription","commits_url":"https://api.github.com/repos/openebs/node-disk-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/openebs/node-disk-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/openebs/node-disk-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/openebs/node-disk-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/openebs/node-disk-manager/contents/{+path}","compare_url":"https://api.github.com/repos/openebs/node-disk-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openebs/node-disk-manager/merges","archive_url":"https://api.github.com/repos/openebs/node-disk-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openebs/node-disk-manager/downloads","issues_url":"https://api.github.com/repos/openebs/node-disk-manager/issues{/number}","pulls_url":"https://api.github.com/repos/openebs/node-disk-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/openebs/node-disk-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/openebs/node-disk-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openebs/node-disk-manager/labels{/name}","releases_url":"https://api.github.com/repos/openebs/node-disk-manager/releases{/id}","deployments_url":"https://api.github.com/repos/openebs/node-disk-manager/deployments","created_at":"2018-03-06T10:31:19Z","updated_at":"2019-03-15T18:38:57Z","pushed_at":"2019-03-21T17:59:44Z","git_url":"git://github.com/openebs/node-disk-manager.git","ssh_url":"git@github.com:openebs/node-disk-manager.git","clone_url":"https://github.com/openebs/node-disk-manager.git","svn_url":"https://github.com/openebs/node-disk-manager","homepage":"","size":33772,"stargazers_count":72,"watchers_count":72,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":47,"open_issues":53,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openebs/node-disk-manager/pulls/218"},"html":{"href":"https://github.com/openebs/node-disk-manager/pull/218"},"issue":{"href":"https://api.github.com/repos/openebs/node-disk-manager/issues/218"},"comments":{"href":"https://api.github.com/repos/openebs/node-disk-manager/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/openebs/node-disk-manager/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/openebs/node-disk-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openebs/node-disk-manager/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/openebs/node-disk-manager/statuses/a465f2c19d1da0d89ba5627ccd68500f86d70bba"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kmova","id":12488783,"node_id":"MDQ6VXNlcjEyNDg4Nzgz","avatar_url":"https://avatars2.githubusercontent.com/u/12488783?v=4","gravatar_id":"","url":"https://api.github.com/users/kmova","html_url":"https://github.com/kmova","followers_url":"https://api.github.com/users/kmova/followers","following_url":"https://api.github.com/users/kmova/following{/other_user}","gists_url":"https://api.github.com/users/kmova/gists{/gist_id}","starred_url":"https://api.github.com/users/kmova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmova/subscriptions","organizations_url":"https://api.github.com/users/kmova/orgs","repos_url":"https://api.github.com/users/kmova/repos","events_url":"https://api.github.com/users/kmova/events{/privacy}","received_events_url":"https://api.github.com/users/kmova/received_events","type":"User","site_admin":false},"comments":4,"review_comments":41,"maintainer_can_modify":false,"commits":8,"additions":2597,"deletions":107,"changed_files":39}}
{"actor":{"display_login":"kmova"}}