{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/winforms/pulls/comments/287620391","pull_request_review_id":242062228,"id":287620391,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NzYyMDM5MQ==","diff_hunk":"@@ -155,29 +155,39 @@ public virtual void InitializeNewComponent(IDictionary defaultValues)\n         void IDesignerFilter.PostFilterAttributes(IDictionary attributes)\n         {\n             // If this component is being inherited, mark it as such in the class attributes.\n-            if (attributes.Contains(typeof(InheritanceAttribute)))\n-            {\n-                _inheritanceAttribute = attributes[typeof(InheritanceAttribute)] as InheritanceAttribute;\n-            }\n-            else if (!InheritanceAttribute.Equals(InheritanceAttribute.NotInherited))\n+            if (attributes != null)","path":"src/System.Windows.Forms.Design/src/System/ComponentModel/Design/ComponentDesigner.cs","position":40,"original_position":40,"commit_id":"980f5a69f0d110812f5183678d4d5dd049a56177","original_commit_id":"980f5a69f0d110812f5183678d4d5dd049a56177","user":{"login":"RussKie","id":4403806,"node_id":"MDQ6VXNlcjQ0MDM4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/4403806?v=4","gravatar_id":"","url":"https://api.github.com/users/RussKie","html_url":"https://github.com/RussKie","followers_url":"https://api.github.com/users/RussKie/followers","following_url":"https://api.github.com/users/RussKie/following{/other_user}","gists_url":"https://api.github.com/users/RussKie/gists{/gist_id}","starred_url":"https://api.github.com/users/RussKie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RussKie/subscriptions","organizations_url":"https://api.github.com/users/RussKie/orgs","repos_url":"https://api.github.com/users/RussKie/repos","events_url":"https://api.github.com/users/RussKie/events{/privacy}","received_events_url":"https://api.github.com/users/RussKie/received_events","type":"User","site_admin":false},"body":"While we are at it, do you think you could also invert ifs to reduce nesting?","created_at":"2019-05-27T00:14:43Z","updated_at":"2019-05-27T00:14:43Z","html_url":"https://github.com/dotnet/winforms/pull/1053#discussion_r287620391","pull_request_url":"https://api.github.com/repos/dotnet/winforms/pulls/1053","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/winforms/pulls/comments/287620391"},"html":{"href":"https://github.com/dotnet/winforms/pull/1053#discussion_r287620391"},"pull_request":{"href":"https://api.github.com/repos/dotnet/winforms/pulls/1053"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/winforms/pulls/1053","id":282329736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyMzI5NzM2","html_url":"https://github.com/dotnet/winforms/pull/1053","diff_url":"https://github.com/dotnet/winforms/pull/1053.diff","patch_url":"https://github.com/dotnet/winforms/pull/1053.patch","issue_url":"https://api.github.com/repos/dotnet/winforms/issues/1053","number":1053,"state":"open","locked":false,"title":"Add ComponentDesigner tests and fix bugs","user":{"login":"hughbe","id":1275900,"node_id":"MDQ6VXNlcjEyNzU5MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1275900?v=4","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"body":"Fixes #1040\r\nFixes #1041\r\nFixes #1045\r\nFixes #1046\r\nFixes #1047\r\nFixes #1048\r\nFixes #1049\r\nFixes #1050\r\nFixes #1051\r\nFixes #1052","created_at":"2019-05-26T23:09:27Z","updated_at":"2019-05-27T00:14:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02b6242c275e543351110180c0748174522b18e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"dotnet-winforms","id":2983706,"node_id":"MDQ6VGVhbTI5ODM3MDY=","slug":"dotnet-winforms","description":"Folks that regularly contribute to the WinForms repository.","privacy":"closed","url":"https://api.github.com/teams/2983706","html_url":"https://github.com/orgs/dotnet/teams/dotnet-winforms","members_url":"https://api.github.com/teams/2983706/members{/member}","repositories_url":"https://api.github.com/teams/2983706/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/winforms/pulls/1053/commits","review_comments_url":"https://api.github.com/repos/dotnet/winforms/pulls/1053/comments","review_comment_url":"https://api.github.com/repos/dotnet/winforms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/winforms/issues/1053/comments","statuses_url":"https://api.github.com/repos/dotnet/winforms/statuses/980f5a69f0d110812f5183678d4d5dd049a56177","head":{"label":"hughbe:componentdesigner-test-and-fixes","ref":"componentdesigner-test-and-fixes","sha":"980f5a69f0d110812f5183678d4d5dd049a56177","user":{"login":"hughbe","id":1275900,"node_id":"MDQ6VXNlcjEyNzU5MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1275900?v=4","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"repo":{"id":163448073,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM0NDgwNzM=","name":"winforms","full_name":"hughbe/winforms","private":false,"owner":{"login":"hughbe","id":1275900,"node_id":"MDQ6VXNlcjEyNzU5MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1275900?v=4","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hughbe/winforms","description":"Windows Forms is a .NET Core UI framework for building Windows desktop applications.","fork":true,"url":"https://api.github.com/repos/hughbe/winforms","forks_url":"https://api.github.com/repos/hughbe/winforms/forks","keys_url":"https://api.github.com/repos/hughbe/winforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughbe/winforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughbe/winforms/teams","hooks_url":"https://api.github.com/repos/hughbe/winforms/hooks","issue_events_url":"https://api.github.com/repos/hughbe/winforms/issues/events{/number}","events_url":"https://api.github.com/repos/hughbe/winforms/events","assignees_url":"https://api.github.com/repos/hughbe/winforms/assignees{/user}","branches_url":"https://api.github.com/repos/hughbe/winforms/branches{/branch}","tags_url":"https://api.github.com/repos/hughbe/winforms/tags","blobs_url":"https://api.github.com/repos/hughbe/winforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughbe/winforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughbe/winforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughbe/winforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughbe/winforms/statuses/{sha}","languages_url":"https://api.github.com/repos/hughbe/winforms/languages","stargazers_url":"https://api.github.com/repos/hughbe/winforms/stargazers","contributors_url":"https://api.github.com/repos/hughbe/winforms/contributors","subscribers_url":"https://api.github.com/repos/hughbe/winforms/subscribers","subscription_url":"https://api.github.com/repos/hughbe/winforms/subscription","commits_url":"https://api.github.com/repos/hughbe/winforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughbe/winforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughbe/winforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughbe/winforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughbe/winforms/contents/{+path}","compare_url":"https://api.github.com/repos/hughbe/winforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughbe/winforms/merges","archive_url":"https://api.github.com/repos/hughbe/winforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughbe/winforms/downloads","issues_url":"https://api.github.com/repos/hughbe/winforms/issues{/number}","pulls_url":"https://api.github.com/repos/hughbe/winforms/pulls{/number}","milestones_url":"https://api.github.com/repos/hughbe/winforms/milestones{/number}","notifications_url":"https://api.github.com/repos/hughbe/winforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughbe/winforms/labels{/name}","releases_url":"https://api.github.com/repos/hughbe/winforms/releases{/id}","deployments_url":"https://api.github.com/repos/hughbe/winforms/deployments","created_at":"2018-12-28T20:45:07Z","updated_at":"2019-05-20T18:40:49Z","pushed_at":"2019-05-26T23:08:33Z","git_url":"git://github.com/hughbe/winforms.git","ssh_url":"git@github.com:hughbe/winforms.git","clone_url":"https://github.com/hughbe/winforms.git","svn_url":"https://github.com/hughbe/winforms","homepage":"","size":20426,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f842cf0c8a3584f8848fb3134238b12e0874f2ff","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":153711830,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3MTE4MzA=","name":"winforms","full_name":"dotnet/winforms","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/winforms","description":"Windows Forms is a .NET Core UI framework for building Windows desktop applications.","fork":false,"url":"https://api.github.com/repos/dotnet/winforms","forks_url":"https://api.github.com/repos/dotnet/winforms/forks","keys_url":"https://api.github.com/repos/dotnet/winforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/winforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/winforms/teams","hooks_url":"https://api.github.com/repos/dotnet/winforms/hooks","issue_events_url":"https://api.github.com/repos/dotnet/winforms/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/winforms/events","assignees_url":"https://api.github.com/repos/dotnet/winforms/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/winforms/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/winforms/tags","blobs_url":"https://api.github.com/repos/dotnet/winforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/winforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/winforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/winforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/winforms/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/winforms/languages","stargazers_url":"https://api.github.com/repos/dotnet/winforms/stargazers","contributors_url":"https://api.github.com/repos/dotnet/winforms/contributors","subscribers_url":"https://api.github.com/repos/dotnet/winforms/subscribers","subscription_url":"https://api.github.com/repos/dotnet/winforms/subscription","commits_url":"https://api.github.com/repos/dotnet/winforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/winforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/winforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/winforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/winforms/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/winforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/winforms/merges","archive_url":"https://api.github.com/repos/dotnet/winforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/winforms/downloads","issues_url":"https://api.github.com/repos/dotnet/winforms/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/winforms/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/winforms/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/winforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/winforms/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/winforms/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/winforms/deployments","created_at":"2018-10-19T01:54:02Z","updated_at":"2019-05-27T00:03:44Z","pushed_at":"2019-05-27T00:03:39Z","git_url":"git://github.com/dotnet/winforms.git","ssh_url":"git@github.com:dotnet/winforms.git","clone_url":"https://github.com/dotnet/winforms.git","svn_url":"https://github.com/dotnet/winforms","homepage":"","size":23610,"stargazers_count":2028,"watchers_count":2028,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":199,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":121,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":199,"open_issues":121,"watchers":2028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/winforms/pulls/1053"},"html":{"href":"https://github.com/dotnet/winforms/pull/1053"},"issue":{"href":"https://api.github.com/repos/dotnet/winforms/issues/1053"},"comments":{"href":"https://api.github.com/repos/dotnet/winforms/issues/1053/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/winforms/pulls/1053/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/winforms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/winforms/pulls/1053/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/winforms/statuses/980f5a69f0d110812f5183678d4d5dd049a56177"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RussKie"}}