{"action":"created","comment":{"url":"https://api.github.com/repos/digital-asset/daml/pulls/comments/279526357","pull_request_review_id":231886192,"id":279526357,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTUyNjM1Nw==","diff_hunk":"@@ -0,0 +1,31 @@\n+// Copyright (c) 2019 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.\n+// SPDX-License-Identifier: Apache-2.0\n+\n+package com.digitalasset.daml.lf\n+package iface\n+\n+import data.Ref.Identifier\n+\n+import scala.collection.breakOut\n+import scala.collection.immutable.Map\n+import scalaz.syntax.std.map._\n+import scalaz.Semigroup\n+\n+/** The combination of multiple [[Interface]]s, such as from a dar. */\n+final case class EnvironmentInterface(typeDecls: Map[Identifier, InterfaceType])","path":"daml-lf/interface/src/main/scala/com/digitalasset/daml/lf/iface/EnvironmentInterface.scala","position":15,"original_position":15,"commit_id":"1ed0a1c908ad07b6090fa3c4fee5214a9e1723dc","original_commit_id":"42f6ef3b402c8420929f60b8c324a4f8f0936322","user":{"login":"S11001001","id":219186,"node_id":"MDQ6VXNlcjIxOTE4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/219186?v=4","gravatar_id":"","url":"https://api.github.com/users/S11001001","html_url":"https://github.com/S11001001","followers_url":"https://api.github.com/users/S11001001/followers","following_url":"https://api.github.com/users/S11001001/following{/other_user}","gists_url":"https://api.github.com/users/S11001001/gists{/gist_id}","starred_url":"https://api.github.com/users/S11001001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S11001001/subscriptions","organizations_url":"https://api.github.com/users/S11001001/orgs","repos_url":"https://api.github.com/users/S11001001/repos","events_url":"https://api.github.com/users/S11001001/events{/privacy}","received_events_url":"https://api.github.com/users/S11001001/received_events","type":"User","site_admin":false},"body":"By the way, the other common pronunciation of `Γ` is \"context\", which I think is clearly not as good as \"environment\" in this, er, context. cc @remyhaemmerle-da ","created_at":"2019-04-29T20:29:49Z","updated_at":"2019-04-29T20:29:50Z","html_url":"https://github.com/digital-asset/daml/pull/781#discussion_r279526357","pull_request_url":"https://api.github.com/repos/digital-asset/daml/pulls/781","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/comments/279526357"},"html":{"href":"https://github.com/digital-asset/daml/pull/781#discussion_r279526357"},"pull_request":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/781"}},"in_reply_to_id":279521369},"pull_request":{"url":"https://api.github.com/repos/digital-asset/daml/pulls/781","id":274499518,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NDk5NTE4","html_url":"https://github.com/digital-asset/daml/pull/781","diff_url":"https://github.com/digital-asset/daml/pull/781.diff","patch_url":"https://github.com/digital-asset/daml/pull/781.patch","issue_url":"https://api.github.com/repos/digital-asset/daml/issues/781","number":781,"state":"open","locked":false,"title":"daml-lf: move EnvironmentInterface from Scala codegen to interface library","user":{"login":"S11001001","id":219186,"node_id":"MDQ6VXNlcjIxOTE4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/219186?v=4","gravatar_id":"","url":"https://api.github.com/users/S11001001","html_url":"https://github.com/S11001001","followers_url":"https://api.github.com/users/S11001001/followers","following_url":"https://api.github.com/users/S11001001/following{/other_user}","gists_url":"https://api.github.com/users/S11001001/gists{/gist_id}","starred_url":"https://api.github.com/users/S11001001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S11001001/subscriptions","organizations_url":"https://api.github.com/users/S11001001/orgs","repos_url":"https://api.github.com/users/S11001001/repos","events_url":"https://api.github.com/users/S11001001/events{/privacy}","received_events_url":"https://api.github.com/users/S11001001/received_events","type":"User","site_admin":false},"body":"Also move `Interface` and `InterfaceType` out of the `reader` subpackage; they belong with the rest of the data model at the `iface` root.\r\n\r\nThe specific mechanics of reading a `Dar` all the way to producing an `EnvironmentInterface` are left to Scala codegen's `Codegen` and Java codegen's `CodeGenRunner`; there's no consensus or great stability on the best way to tie these pieces together, but all the pieces might as well be available in the `interface` library at least.\r\n\r\n### Pull Request Checklist\r\n\r\n- [x] Read and understand the [contribution guidelines](https://github.com/digital-asset/daml/blob/master/CONTRIBUTING.md)\r\n- [x] Include appropriate tests\r\n- [x] Set a descriptive title and thorough description\r\n- [x] Add a reference to the [issue this PR will solve](https://github.com/digital-asset/daml/issues), if appropriate\r\n- [x] Add a line to the [release notes](https://github.com/digital-asset/daml/blob/master/docs/source/support/release-notes.rst), if appropriate\r\n\r\nNOTE: CI is not automatically run on non-members pull-requests for security\r\nreasons. The reviewer will have to comment with `/AzurePipelines run` to\r\ntrigger the build.\r\n","created_at":"2019-04-29T19:45:47Z","updated_at":"2019-04-29T20:29:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dcd6b841e972f44231ba78bb62d37d20ecdf546","assignee":{"login":"S11001001","id":219186,"node_id":"MDQ6VXNlcjIxOTE4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/219186?v=4","gravatar_id":"","url":"https://api.github.com/users/S11001001","html_url":"https://github.com/S11001001","followers_url":"https://api.github.com/users/S11001001/followers","following_url":"https://api.github.com/users/S11001001/following{/other_user}","gists_url":"https://api.github.com/users/S11001001/gists{/gist_id}","starred_url":"https://api.github.com/users/S11001001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S11001001/subscriptions","organizations_url":"https://api.github.com/users/S11001001/orgs","repos_url":"https://api.github.com/users/S11001001/repos","events_url":"https://api.github.com/users/S11001001/events{/privacy}","received_events_url":"https://api.github.com/users/S11001001/received_events","type":"User","site_admin":false},"assignees":[{"login":"S11001001","id":219186,"node_id":"MDQ6VXNlcjIxOTE4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/219186?v=4","gravatar_id":"","url":"https://api.github.com/users/S11001001","html_url":"https://github.com/S11001001","followers_url":"https://api.github.com/users/S11001001/followers","following_url":"https://api.github.com/users/S11001001/following{/other_user}","gists_url":"https://api.github.com/users/S11001001/gists{/gist_id}","starred_url":"https://api.github.com/users/S11001001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S11001001/subscriptions","organizations_url":"https://api.github.com/users/S11001001/orgs","repos_url":"https://api.github.com/users/S11001001/repos","events_url":"https://api.github.com/users/S11001001/events{/privacy}","received_events_url":"https://api.github.com/users/S11001001/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1322072744,"node_id":"MDU6TGFiZWwxMzIyMDcyNzQ0","url":"https://api.github.com/repos/digital-asset/daml/labels/automerge","name":"automerge","color":"ffd3b5","default":false},{"id":1297953944,"node_id":"MDU6TGFiZWwxMjk3OTUzOTQ0","url":"https://api.github.com/repos/digital-asset/daml/labels/component/daml-lf","name":"component/daml-lf","color":"e57b79","default":false},{"id":1297955458,"node_id":"MDU6TGFiZWwxMjk3OTU1NDU4","url":"https://api.github.com/repos/digital-asset/daml/labels/component/scala-ecosystem","name":"component/scala-ecosystem","color":"c4e88b","default":false}],"milestone":{"url":"https://api.github.com/repos/digital-asset/daml/milestones/3","html_url":"https://github.com/digital-asset/daml/milestone/3","labels_url":"https://api.github.com/repos/digital-asset/daml/milestones/3/labels","id":4187018,"node_id":"MDk6TWlsZXN0b25lNDE4NzAxOA==","number":3,"title":"Maintenance","description":"","creator":{"login":"cbaatz-da","id":26059252,"node_id":"MDQ6VXNlcjI2MDU5MjUy","avatar_url":"https://avatars2.githubusercontent.com/u/26059252?v=4","gravatar_id":"","url":"https://api.github.com/users/cbaatz-da","html_url":"https://github.com/cbaatz-da","followers_url":"https://api.github.com/users/cbaatz-da/followers","following_url":"https://api.github.com/users/cbaatz-da/following{/other_user}","gists_url":"https://api.github.com/users/cbaatz-da/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaatz-da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaatz-da/subscriptions","organizations_url":"https://api.github.com/users/cbaatz-da/orgs","repos_url":"https://api.github.com/users/cbaatz-da/repos","events_url":"https://api.github.com/users/cbaatz-da/events{/privacy}","received_events_url":"https://api.github.com/users/cbaatz-da/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":42,"state":"open","created_at":"2019-03-31T19:48:51Z","updated_at":"2019-04-29T19:45:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/digital-asset/daml/pulls/781/commits","review_comments_url":"https://api.github.com/repos/digital-asset/daml/pulls/781/comments","review_comment_url":"https://api.github.com/repos/digital-asset/daml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digital-asset/daml/issues/781/comments","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/1ed0a1c908ad07b6090fa3c4fee5214a9e1723dc","head":{"label":"digital-asset:lf-environment-interface","ref":"lf-environment-interface","sha":"1ed0a1c908ad07b6090fa3c4fee5214a9e1723dc","user":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"repo":{"id":178222328,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyMjIzMjg=","name":"daml","full_name":"digital-asset/daml","private":false,"owner":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digital-asset/daml","description":"The DAML smart contract language","fork":false,"url":"https://api.github.com/repos/digital-asset/daml","forks_url":"https://api.github.com/repos/digital-asset/daml/forks","keys_url":"https://api.github.com/repos/digital-asset/daml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digital-asset/daml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digital-asset/daml/teams","hooks_url":"https://api.github.com/repos/digital-asset/daml/hooks","issue_events_url":"https://api.github.com/repos/digital-asset/daml/issues/events{/number}","events_url":"https://api.github.com/repos/digital-asset/daml/events","assignees_url":"https://api.github.com/repos/digital-asset/daml/assignees{/user}","branches_url":"https://api.github.com/repos/digital-asset/daml/branches{/branch}","tags_url":"https://api.github.com/repos/digital-asset/daml/tags","blobs_url":"https://api.github.com/repos/digital-asset/daml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digital-asset/daml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digital-asset/daml/git/refs{/sha}","trees_url":"https://api.github.com/repos/digital-asset/daml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/{sha}","languages_url":"https://api.github.com/repos/digital-asset/daml/languages","stargazers_url":"https://api.github.com/repos/digital-asset/daml/stargazers","contributors_url":"https://api.github.com/repos/digital-asset/daml/contributors","subscribers_url":"https://api.github.com/repos/digital-asset/daml/subscribers","subscription_url":"https://api.github.com/repos/digital-asset/daml/subscription","commits_url":"https://api.github.com/repos/digital-asset/daml/commits{/sha}","git_commits_url":"https://api.github.com/repos/digital-asset/daml/git/commits{/sha}","comments_url":"https://api.github.com/repos/digital-asset/daml/comments{/number}","issue_comment_url":"https://api.github.com/repos/digital-asset/daml/issues/comments{/number}","contents_url":"https://api.github.com/repos/digital-asset/daml/contents/{+path}","compare_url":"https://api.github.com/repos/digital-asset/daml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digital-asset/daml/merges","archive_url":"https://api.github.com/repos/digital-asset/daml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digital-asset/daml/downloads","issues_url":"https://api.github.com/repos/digital-asset/daml/issues{/number}","pulls_url":"https://api.github.com/repos/digital-asset/daml/pulls{/number}","milestones_url":"https://api.github.com/repos/digital-asset/daml/milestones{/number}","notifications_url":"https://api.github.com/repos/digital-asset/daml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digital-asset/daml/labels{/name}","releases_url":"https://api.github.com/repos/digital-asset/daml/releases{/id}","deployments_url":"https://api.github.com/repos/digital-asset/daml/deployments","created_at":"2019-03-28T14:38:37Z","updated_at":"2019-04-29T19:22:07Z","pushed_at":"2019-04-29T20:14:03Z","git_url":"git://github.com/digital-asset/daml.git","ssh_url":"git@github.com:digital-asset/daml.git","clone_url":"https://github.com/digital-asset/daml.git","svn_url":"https://github.com/digital-asset/daml","homepage":"https://daml.com/","size":21454,"stargazers_count":129,"watchers_count":129,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":255,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":255,"watchers":129,"default_branch":"master"}},"base":{"label":"digital-asset:master","ref":"master","sha":"f8a5fdc493e92b40cc575609976580775de112d1","user":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"repo":{"id":178222328,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyMjIzMjg=","name":"daml","full_name":"digital-asset/daml","private":false,"owner":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digital-asset/daml","description":"The DAML smart contract language","fork":false,"url":"https://api.github.com/repos/digital-asset/daml","forks_url":"https://api.github.com/repos/digital-asset/daml/forks","keys_url":"https://api.github.com/repos/digital-asset/daml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digital-asset/daml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digital-asset/daml/teams","hooks_url":"https://api.github.com/repos/digital-asset/daml/hooks","issue_events_url":"https://api.github.com/repos/digital-asset/daml/issues/events{/number}","events_url":"https://api.github.com/repos/digital-asset/daml/events","assignees_url":"https://api.github.com/repos/digital-asset/daml/assignees{/user}","branches_url":"https://api.github.com/repos/digital-asset/daml/branches{/branch}","tags_url":"https://api.github.com/repos/digital-asset/daml/tags","blobs_url":"https://api.github.com/repos/digital-asset/daml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digital-asset/daml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digital-asset/daml/git/refs{/sha}","trees_url":"https://api.github.com/repos/digital-asset/daml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/{sha}","languages_url":"https://api.github.com/repos/digital-asset/daml/languages","stargazers_url":"https://api.github.com/repos/digital-asset/daml/stargazers","contributors_url":"https://api.github.com/repos/digital-asset/daml/contributors","subscribers_url":"https://api.github.com/repos/digital-asset/daml/subscribers","subscription_url":"https://api.github.com/repos/digital-asset/daml/subscription","commits_url":"https://api.github.com/repos/digital-asset/daml/commits{/sha}","git_commits_url":"https://api.github.com/repos/digital-asset/daml/git/commits{/sha}","comments_url":"https://api.github.com/repos/digital-asset/daml/comments{/number}","issue_comment_url":"https://api.github.com/repos/digital-asset/daml/issues/comments{/number}","contents_url":"https://api.github.com/repos/digital-asset/daml/contents/{+path}","compare_url":"https://api.github.com/repos/digital-asset/daml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digital-asset/daml/merges","archive_url":"https://api.github.com/repos/digital-asset/daml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digital-asset/daml/downloads","issues_url":"https://api.github.com/repos/digital-asset/daml/issues{/number}","pulls_url":"https://api.github.com/repos/digital-asset/daml/pulls{/number}","milestones_url":"https://api.github.com/repos/digital-asset/daml/milestones{/number}","notifications_url":"https://api.github.com/repos/digital-asset/daml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digital-asset/daml/labels{/name}","releases_url":"https://api.github.com/repos/digital-asset/daml/releases{/id}","deployments_url":"https://api.github.com/repos/digital-asset/daml/deployments","created_at":"2019-03-28T14:38:37Z","updated_at":"2019-04-29T19:22:07Z","pushed_at":"2019-04-29T20:14:03Z","git_url":"git://github.com/digital-asset/daml.git","ssh_url":"git@github.com:digital-asset/daml.git","clone_url":"https://github.com/digital-asset/daml.git","svn_url":"https://github.com/digital-asset/daml","homepage":"https://daml.com/","size":21454,"stargazers_count":129,"watchers_count":129,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":255,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":255,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/781"},"html":{"href":"https://github.com/digital-asset/daml/pull/781"},"issue":{"href":"https://api.github.com/repos/digital-asset/daml/issues/781"},"comments":{"href":"https://api.github.com/repos/digital-asset/daml/issues/781/comments"},"review_comments":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/781/comments"},"review_comment":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/781/commits"},"statuses":{"href":"https://api.github.com/repos/digital-asset/daml/statuses/1ed0a1c908ad07b6090fa3c4fee5214a9e1723dc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"S11001001"}}