{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/comments/276075143","pull_request_review_id":227543373,"id":276075143,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NjA3NTE0Mw==","diff_hunk":"@@ -0,0 +1,213 @@\n+/* --------------------------------------------------------------------------------------------\r\n+ * Copyright (c) Microsoft Corporation. All Rights Reserved.\r\n+ * See 'LICENSE' in the project root for license information.\r\n+ * ------------------------------------------------------------------------------------------ */\r\n+'use strict';\r\n+\r\n+import * as path from 'path';\r\n+import * as fs from 'fs';\r\n+import * as vscode from 'vscode';\r\n+import * as util from '../common';\r\n+import * as config from './configurations';\r\n+\r\n+// TODO: share ElementId between SettingsPanel and SettingsApp. Investigate why SettingsApp used for HTML cannot import/export\r\n+const ElementId: { [key: string]: string } = {\r\n+    ActiveConfig: \"activeConfig\",\r\n+    CompilerPath: \"compilerPath\",\r\n+    IntelliSenseMode: \"intelliSenseMode\", \r\n+    IncludePath: \"includePath\",\r\n+    Defines: \"defines\",\r\n+    cStandard: \"cStandard\",\r\n+    cppStandard: \"cppStandard\"\r\n+};\r\n+\r\n+export interface ViewStateEvent {\r\n+    isActive: boolean;\r\n+}\r\n+\r\n+export class SettingsPanel {\r\n+\r","path":"Extension/src/LanguageServer/settingsPanel.ts","position":29,"original_position":29,"commit_id":"afa1b8fab698448827bfa77895084797951036b2","original_commit_id":"afa1b8fab698448827bfa77895084797951036b2","user":{"login":"bobbrow","id":12818240,"node_id":"MDQ6VXNlcjEyODE4MjQw","avatar_url":"https://avatars3.githubusercontent.com/u/12818240?v=4","gravatar_id":"","url":"https://api.github.com/users/bobbrow","html_url":"https://github.com/bobbrow","followers_url":"https://api.github.com/users/bobbrow/followers","following_url":"https://api.github.com/users/bobbrow/following{/other_user}","gists_url":"https://api.github.com/users/bobbrow/gists{/gist_id}","starred_url":"https://api.github.com/users/bobbrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobbrow/subscriptions","organizations_url":"https://api.github.com/users/bobbrow/orgs","repos_url":"https://api.github.com/users/bobbrow/repos","events_url":"https://api.github.com/users/bobbrow/events{/privacy}","received_events_url":"https://api.github.com/users/bobbrow/received_events","type":"User","site_admin":false},"body":"style: remove empty line","created_at":"2019-04-17T04:28:22Z","updated_at":"2019-04-17T04:47:51Z","html_url":"https://github.com/Microsoft/vscode-cpptools/pull/3479#discussion_r276075143","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/3479","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/comments/276075143"},"html":{"href":"https://github.com/Microsoft/vscode-cpptools/pull/3479#discussion_r276075143"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/3479"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/3479","id":271109663,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxMTA5NjYz","html_url":"https://github.com/Microsoft/vscode-cpptools/pull/3479","diff_url":"https://github.com/Microsoft/vscode-cpptools/pull/3479.diff","patch_url":"https://github.com/Microsoft/vscode-cpptools/pull/3479.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/3479","number":3479,"state":"open","locked":false,"title":"Configuration UI","user":{"login":"michelleangela","id":38734287,"node_id":"MDQ6VXNlcjM4NzM0Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/38734287?v=4","gravatar_id":"","url":"https://api.github.com/users/michelleangela","html_url":"https://github.com/michelleangela","followers_url":"https://api.github.com/users/michelleangela/followers","following_url":"https://api.github.com/users/michelleangela/following{/other_user}","gists_url":"https://api.github.com/users/michelleangela/gists{/gist_id}","starred_url":"https://api.github.com/users/michelleangela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michelleangela/subscriptions","organizations_url":"https://api.github.com/users/michelleangela/orgs","repos_url":"https://api.github.com/users/michelleangela/repos","events_url":"https://api.github.com/users/michelleangela/events{/privacy}","received_events_url":"https://api.github.com/users/michelleangela/received_events","type":"User","site_admin":false},"body":"- add a configuration UI to edit certain IntelliSense properties\r\n- add command palettes to either open configuration in UI or JSON\r\n- add command to open configuration in UI or JSON from toast notification\r\n- add telemetry to new commands\r\n- inherit workbench.settings.editor settings from VS Code to determine whether the configuration UI or JSON is opened by default","created_at":"2019-04-16T23:36:09Z","updated_at":"2019-04-17T04:47:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80ddfe39f5dc41cb41648be455ec09ead69c9c8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/3479/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/3479/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/3479/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/statuses/afa1b8fab698448827bfa77895084797951036b2","head":{"label":"Microsoft:mimatias/configUI","ref":"mimatias/configUI","sha":"afa1b8fab698448827bfa77895084797951036b2","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":54800346,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgwMDM0Ng==","name":"vscode-cpptools","full_name":"Microsoft/vscode-cpptools","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/vscode-cpptools","description":"Official repository for filing issues against and getting support for the Microsoft C/C++ extension for VS Code ","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-cpptools","forks_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/deployments","created_at":"2016-03-26T21:26:30Z","updated_at":"2019-04-17T02:48:28Z","pushed_at":"2019-04-17T00:34:43Z","git_url":"git://github.com/Microsoft/vscode-cpptools.git","ssh_url":"git@github.com:Microsoft/vscode-cpptools.git","clone_url":"https://github.com/Microsoft/vscode-cpptools.git","svn_url":"https://github.com/Microsoft/vscode-cpptools","homepage":"","size":21074,"stargazers_count":2297,"watchers_count":2297,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":574,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":948,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":574,"open_issues":948,"watchers":2297,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"c978eb07553a8774b1940c4385ab902133a03317","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":54800346,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgwMDM0Ng==","name":"vscode-cpptools","full_name":"Microsoft/vscode-cpptools","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/vscode-cpptools","description":"Official repository for filing issues against and getting support for the Microsoft C/C++ extension for VS Code ","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-cpptools","forks_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-cpptools/deployments","created_at":"2016-03-26T21:26:30Z","updated_at":"2019-04-17T02:48:28Z","pushed_at":"2019-04-17T00:34:43Z","git_url":"git://github.com/Microsoft/vscode-cpptools.git","ssh_url":"git@github.com:Microsoft/vscode-cpptools.git","clone_url":"https://github.com/Microsoft/vscode-cpptools.git","svn_url":"https://github.com/Microsoft/vscode-cpptools","homepage":"","size":21074,"stargazers_count":2297,"watchers_count":2297,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":574,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":948,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":574,"open_issues":948,"watchers":2297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/3479"},"html":{"href":"https://github.com/Microsoft/vscode-cpptools/pull/3479"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/3479"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/issues/3479/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/3479/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/pulls/3479/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-cpptools/statuses/afa1b8fab698448827bfa77895084797951036b2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bobbrow"}}