{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/comments/334236975","pull_request_review_id":301004772,"id":334236975,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDIzNjk3NQ==","diff_hunk":"@@ -0,0 +1,14 @@\n+﻿using BenchmarkDotNet.Environments;\n+using BenchmarkDotNet.Jobs;\n+using System;\n+\n+namespace BenchmarkDotNet.Attributes\n+{\n+    [Obsolete(\"Please use DryJobAttribute instead. Use the ctor that requires RuntimeMoniker argument.\", false)]","path":"src/BenchmarkDotNet/Attributes/Obsolete/DryCoreJobAttribute.cs","position":7,"original_position":7,"commit_id":"d8192b96ce4e7c5211c8107868cd45eaf120012f","original_commit_id":"d8192b96ce4e7c5211c8107868cd45eaf120012f","user":{"login":"AndreyAkinshin","id":2259237,"node_id":"MDQ6VXNlcjIyNTkyMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2259237?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreyAkinshin","html_url":"https://github.com/AndreyAkinshin","followers_url":"https://api.github.com/users/AndreyAkinshin/followers","following_url":"https://api.github.com/users/AndreyAkinshin/following{/other_user}","gists_url":"https://api.github.com/users/AndreyAkinshin/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyAkinshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyAkinshin/subscriptions","organizations_url":"https://api.github.com/users/AndreyAkinshin/orgs","repos_url":"https://api.github.com/users/AndreyAkinshin/repos","events_url":"https://api.github.com/users/AndreyAkinshin/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyAkinshin/received_events","type":"User","site_admin":false},"body":"Instead of \"Use the ctor that requires RuntimeMoniker argument\", it will be better to write a code example that can be copy-pasted.","created_at":"2019-10-12T13:11:32Z","updated_at":"2019-10-12T13:11:32Z","html_url":"https://github.com/dotnet/BenchmarkDotNet/pull/1277#discussion_r334236975","pull_request_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/1277","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/comments/334236975"},"html":{"href":"https://github.com/dotnet/BenchmarkDotNet/pull/1277#discussion_r334236975"},"pull_request":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/1277"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/1277","id":327443158,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3NDQzMTU4","html_url":"https://github.com/dotnet/BenchmarkDotNet/pull/1277","diff_url":"https://github.com/dotnet/BenchmarkDotNet/pull/1277.diff","patch_url":"https://github.com/dotnet/BenchmarkDotNet/pull/1277.patch","issue_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/1277","number":1277,"state":"open","locked":false,"title":"change the runtimes API","user":{"login":"adamsitnik","id":6011991,"node_id":"MDQ6VXNlcjYwMTE5OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6011991?v=4","gravatar_id":"","url":"https://api.github.com/users/adamsitnik","html_url":"https://github.com/adamsitnik","followers_url":"https://api.github.com/users/adamsitnik/followers","following_url":"https://api.github.com/users/adamsitnik/following{/other_user}","gists_url":"https://api.github.com/users/adamsitnik/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsitnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsitnik/subscriptions","organizations_url":"https://api.github.com/users/adamsitnik/orgs","repos_url":"https://api.github.com/users/adamsitnik/repos","events_url":"https://api.github.com/users/adamsitnik/events{/privacy}","received_events_url":"https://api.github.com/users/adamsitnik/received_events","type":"User","site_admin":false},"body":"@AndreyAkinshin this fixes the things we have discussed yesterday at Dotnetos\r\n\r\n* Don't introduce NetCoreLatest and its friends\r\n* Rename TargetFrameworkJob -> SimpleJob (don't introduce JobAttribute in 0.12)\r\n* Rename TargetFrameworkMoniker -> RuntimeMoniker\r\n\r\nWhen it comes to:\r\n\r\n> * We make [ClrJob] are friends as obsolete without errors (warning only) and use InvalidConfig with nice message\r\n\r\nI made it a warning as we talked but I've not introduced the concept of `InvalidConfig`. \r\n\r\nWhat I did instead is to call the `GetCurrentVersion` method for every runtime.\r\n\r\n```cs\r\npublic ClrJobAttribute() : base(Job.Default.With(ClrRuntime.GetCurrentVersion()))\r\n```\r\n\r\nIf the `host runtime == job runtime`, then it's going to work fine (99% of the cases). If the runtimes are different: for example running as Full .NET Framework and trying to use `[CoreJob]` attribute, then `GetCurrentVersion` is going to throw:\r\n\r\nhttps://github.com/dotnet/BenchmarkDotNet/blob/2ba30330ec5ec8a9abe284c927277a6fe0fc5a0c/src/BenchmarkDotNet/Environments/Runtimes/CoreRuntime.cs#L44","created_at":"2019-10-12T08:44:28Z","updated_at":"2019-10-12T13:11:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67ed66d7d507ce09147bf2d3cdb561bc5e1aa4f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/1277/commits","review_comments_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/1277/comments","review_comment_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/1277/comments","statuses_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/statuses/d8192b96ce4e7c5211c8107868cd45eaf120012f","head":{"label":"dotnet:runtimeApiChanges","ref":"runtimeApiChanges","sha":"d8192b96ce4e7c5211c8107868cd45eaf120012f","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":12191244,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE5MTI0NA==","name":"BenchmarkDotNet","full_name":"dotnet/BenchmarkDotNet","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/BenchmarkDotNet","description":"Powerful .NET library for benchmarking","fork":false,"url":"https://api.github.com/repos/dotnet/BenchmarkDotNet","forks_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/forks","keys_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/teams","hooks_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/hooks","issue_events_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/events","assignees_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/tags","blobs_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/languages","stargazers_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/stargazers","contributors_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/contributors","subscribers_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/subscribers","subscription_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/subscription","commits_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/merges","archive_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/downloads","issues_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/deployments","created_at":"2013-08-18T06:17:48Z","updated_at":"2019-10-11T18:56:15Z","pushed_at":"2019-10-12T08:44:29Z","git_url":"git://github.com/dotnet/BenchmarkDotNet.git","ssh_url":"git@github.com:dotnet/BenchmarkDotNet.git","clone_url":"https://github.com/dotnet/BenchmarkDotNet.git","svn_url":"https://github.com/dotnet/BenchmarkDotNet","homepage":"https://benchmarkdotnet.org/","size":20246,"stargazers_count":4539,"watchers_count":4539,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":490,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":132,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":490,"open_issues":132,"watchers":4539,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f89091a2a9c1a4058dd8e32d5aa01271910dd7dc","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":12191244,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE5MTI0NA==","name":"BenchmarkDotNet","full_name":"dotnet/BenchmarkDotNet","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/BenchmarkDotNet","description":"Powerful .NET library for benchmarking","fork":false,"url":"https://api.github.com/repos/dotnet/BenchmarkDotNet","forks_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/forks","keys_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/teams","hooks_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/hooks","issue_events_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/events","assignees_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/tags","blobs_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/languages","stargazers_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/stargazers","contributors_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/contributors","subscribers_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/subscribers","subscription_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/subscription","commits_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/merges","archive_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/downloads","issues_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/BenchmarkDotNet/deployments","created_at":"2013-08-18T06:17:48Z","updated_at":"2019-10-11T18:56:15Z","pushed_at":"2019-10-12T08:44:29Z","git_url":"git://github.com/dotnet/BenchmarkDotNet.git","ssh_url":"git@github.com:dotnet/BenchmarkDotNet.git","clone_url":"https://github.com/dotnet/BenchmarkDotNet.git","svn_url":"https://github.com/dotnet/BenchmarkDotNet","homepage":"https://benchmarkdotnet.org/","size":20246,"stargazers_count":4539,"watchers_count":4539,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":490,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":132,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":490,"open_issues":132,"watchers":4539,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/1277"},"html":{"href":"https://github.com/dotnet/BenchmarkDotNet/pull/1277"},"issue":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/1277"},"comments":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/issues/1277/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/1277/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/pulls/1277/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/BenchmarkDotNet/statuses/d8192b96ce4e7c5211c8107868cd45eaf120012f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AndreyAkinshin"}}