{"action":"created","comment":{"url":"https://api.github.com/repos/planetscale/vitess-operator/pulls/comments/359024262","pull_request_review_id":333564723,"id":359024262,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTAyNDI2Mg==","diff_hunk":"@@ -116,6 +116,12 @@ func (r *ReconcileVitessCell) reconcileVtgate(ctx context.Context, vtc *planetsc\n \t}\n \tupdate.Annotations(&annotations, vtc.Spec.Gateway.Annotations)\n \n+\t// Merge ExtraVitessFlags into ExtraFlags.","path":"pkg/controller/vitesscell/reconcile_vtgate.go","position":4,"original_position":4,"commit_id":"484652fb33e377cb93200253377b9a62ab413042","original_commit_id":"484652fb33e377cb93200253377b9a62ab413042","user":{"login":"enisoc","id":6733629,"node_id":"MDQ6VXNlcjY3MzM2Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6733629?v=4","gravatar_id":"","url":"https://api.github.com/users/enisoc","html_url":"https://github.com/enisoc","followers_url":"https://api.github.com/users/enisoc/followers","following_url":"https://api.github.com/users/enisoc/following{/other_user}","gists_url":"https://api.github.com/users/enisoc/gists{/gist_id}","starred_url":"https://api.github.com/users/enisoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enisoc/subscriptions","organizations_url":"https://api.github.com/users/enisoc/orgs","repos_url":"https://api.github.com/users/enisoc/repos","events_url":"https://api.github.com/users/enisoc/events{/privacy}","received_events_url":"https://api.github.com/users/enisoc/received_events","type":"User","site_admin":false},"body":"I think we should merge in the opposite order, so the more-specific flags (for vtgate) take precedence over less-specific (vitess-wide) flags.\r\n\r\nAlso, we should create a new, empty map to avoid mutating our inputs.","created_at":"2019-12-17T20:57:08Z","updated_at":"2019-12-17T20:57:11Z","html_url":"https://github.com/planetscale/vitess-operator/pull/14#discussion_r359024262","pull_request_url":"https://api.github.com/repos/planetscale/vitess-operator/pulls/14","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/planetscale/vitess-operator/pulls/comments/359024262"},"html":{"href":"https://github.com/planetscale/vitess-operator/pull/14#discussion_r359024262"},"pull_request":{"href":"https://api.github.com/repos/planetscale/vitess-operator/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/planetscale/vitess-operator/pulls/14","id":353896041,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzODk2MDQx","html_url":"https://github.com/planetscale/vitess-operator/pull/14","diff_url":"https://github.com/planetscale/vitess-operator/pull/14.diff","patch_url":"https://github.com/planetscale/vitess-operator/pull/14.patch","issue_url":"https://api.github.com/repos/planetscale/vitess-operator/issues/14","number":14,"state":"open","locked":false,"title":"ExtraVitessFlags Feature in VitessClusterSpec","user":{"login":"PrismaPhonic","id":8784945,"node_id":"MDQ6VXNlcjg3ODQ5NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8784945?v=4","gravatar_id":"","url":"https://api.github.com/users/PrismaPhonic","html_url":"https://github.com/PrismaPhonic","followers_url":"https://api.github.com/users/PrismaPhonic/followers","following_url":"https://api.github.com/users/PrismaPhonic/following{/other_user}","gists_url":"https://api.github.com/users/PrismaPhonic/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismaPhonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismaPhonic/subscriptions","organizations_url":"https://api.github.com/users/PrismaPhonic/orgs","repos_url":"https://api.github.com/users/PrismaPhonic/repos","events_url":"https://api.github.com/users/PrismaPhonic/events{/privacy}","received_events_url":"https://api.github.com/users/PrismaPhonic/received_events","type":"User","site_admin":false},"body":"This PR adds `ExtraVitessFlags` field to `VitessClusterSpec` and appropriate duplication and plumbing where necessary to ensure that flags provided in `VitessClusterSpec` get plumbed through to `vtgate`, `vtctld` and `vttablet`.","created_at":"2019-12-17T03:36:38Z","updated_at":"2019-12-17T20:57:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0114170e6d3915328296880038f9b8d8b3f9755","assignee":null,"assignees":[],"requested_reviewers":[{"login":"avaidyanatha","id":33042053,"node_id":"MDQ6VXNlcjMzMDQyMDUz","avatar_url":"https://avatars3.githubusercontent.com/u/33042053?v=4","gravatar_id":"","url":"https://api.github.com/users/avaidyanatha","html_url":"https://github.com/avaidyanatha","followers_url":"https://api.github.com/users/avaidyanatha/followers","following_url":"https://api.github.com/users/avaidyanatha/following{/other_user}","gists_url":"https://api.github.com/users/avaidyanatha/gists{/gist_id}","starred_url":"https://api.github.com/users/avaidyanatha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avaidyanatha/subscriptions","organizations_url":"https://api.github.com/users/avaidyanatha/orgs","repos_url":"https://api.github.com/users/avaidyanatha/repos","events_url":"https://api.github.com/users/avaidyanatha/events{/privacy}","received_events_url":"https://api.github.com/users/avaidyanatha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/planetscale/vitess-operator/pulls/14/commits","review_comments_url":"https://api.github.com/repos/planetscale/vitess-operator/pulls/14/comments","review_comment_url":"https://api.github.com/repos/planetscale/vitess-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/planetscale/vitess-operator/issues/14/comments","statuses_url":"https://api.github.com/repos/planetscale/vitess-operator/statuses/484652fb33e377cb93200253377b9a62ab413042","head":{"label":"planetscale:feature/vtop-extravitessflags","ref":"feature/vtop-extravitessflags","sha":"484652fb33e377cb93200253377b9a62ab413042","user":{"login":"planetscale","id":35612527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjEyNTI3","avatar_url":"https://avatars3.githubusercontent.com/u/35612527?v=4","gravatar_id":"","url":"https://api.github.com/users/planetscale","html_url":"https://github.com/planetscale","followers_url":"https://api.github.com/users/planetscale/followers","following_url":"https://api.github.com/users/planetscale/following{/other_user}","gists_url":"https://api.github.com/users/planetscale/gists{/gist_id}","starred_url":"https://api.github.com/users/planetscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/planetscale/subscriptions","organizations_url":"https://api.github.com/users/planetscale/orgs","repos_url":"https://api.github.com/users/planetscale/repos","events_url":"https://api.github.com/users/planetscale/events{/privacy}","received_events_url":"https://api.github.com/users/planetscale/received_events","type":"Organization","site_admin":false},"repo":{"id":225690537,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU2OTA1Mzc=","name":"vitess-operator","full_name":"planetscale/vitess-operator","private":false,"owner":{"login":"planetscale","id":35612527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjEyNTI3","avatar_url":"https://avatars3.githubusercontent.com/u/35612527?v=4","gravatar_id":"","url":"https://api.github.com/users/planetscale","html_url":"https://github.com/planetscale","followers_url":"https://api.github.com/users/planetscale/followers","following_url":"https://api.github.com/users/planetscale/following{/other_user}","gists_url":"https://api.github.com/users/planetscale/gists{/gist_id}","starred_url":"https://api.github.com/users/planetscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/planetscale/subscriptions","organizations_url":"https://api.github.com/users/planetscale/orgs","repos_url":"https://api.github.com/users/planetscale/repos","events_url":"https://api.github.com/users/planetscale/events{/privacy}","received_events_url":"https://api.github.com/users/planetscale/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/planetscale/vitess-operator","description":"Kubernetes Operator for Vitess","fork":false,"url":"https://api.github.com/repos/planetscale/vitess-operator","forks_url":"https://api.github.com/repos/planetscale/vitess-operator/forks","keys_url":"https://api.github.com/repos/planetscale/vitess-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/planetscale/vitess-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/planetscale/vitess-operator/teams","hooks_url":"https://api.github.com/repos/planetscale/vitess-operator/hooks","issue_events_url":"https://api.github.com/repos/planetscale/vitess-operator/issues/events{/number}","events_url":"https://api.github.com/repos/planetscale/vitess-operator/events","assignees_url":"https://api.github.com/repos/planetscale/vitess-operator/assignees{/user}","branches_url":"https://api.github.com/repos/planetscale/vitess-operator/branches{/branch}","tags_url":"https://api.github.com/repos/planetscale/vitess-operator/tags","blobs_url":"https://api.github.com/repos/planetscale/vitess-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/planetscale/vitess-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/planetscale/vitess-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/planetscale/vitess-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/planetscale/vitess-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/planetscale/vitess-operator/languages","stargazers_url":"https://api.github.com/repos/planetscale/vitess-operator/stargazers","contributors_url":"https://api.github.com/repos/planetscale/vitess-operator/contributors","subscribers_url":"https://api.github.com/repos/planetscale/vitess-operator/subscribers","subscription_url":"https://api.github.com/repos/planetscale/vitess-operator/subscription","commits_url":"https://api.github.com/repos/planetscale/vitess-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/planetscale/vitess-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/planetscale/vitess-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/planetscale/vitess-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/planetscale/vitess-operator/contents/{+path}","compare_url":"https://api.github.com/repos/planetscale/vitess-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/planetscale/vitess-operator/merges","archive_url":"https://api.github.com/repos/planetscale/vitess-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/planetscale/vitess-operator/downloads","issues_url":"https://api.github.com/repos/planetscale/vitess-operator/issues{/number}","pulls_url":"https://api.github.com/repos/planetscale/vitess-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/planetscale/vitess-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/planetscale/vitess-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/planetscale/vitess-operator/labels{/name}","releases_url":"https://api.github.com/repos/planetscale/vitess-operator/releases{/id}","deployments_url":"https://api.github.com/repos/planetscale/vitess-operator/deployments","created_at":"2019-12-03T18:39:09Z","updated_at":"2019-12-17T10:18:02Z","pushed_at":"2019-12-17T20:17:12Z","git_url":"git://github.com/planetscale/vitess-operator.git","ssh_url":"git@github.com:planetscale/vitess-operator.git","clone_url":"https://github.com/planetscale/vitess-operator.git","svn_url":"https://github.com/planetscale/vitess-operator","homepage":null,"size":362,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"planetscale:master","ref":"master","sha":"9fef45739859842aa62a3b18302ea9960bff18d6","user":{"login":"planetscale","id":35612527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjEyNTI3","avatar_url":"https://avatars3.githubusercontent.com/u/35612527?v=4","gravatar_id":"","url":"https://api.github.com/users/planetscale","html_url":"https://github.com/planetscale","followers_url":"https://api.github.com/users/planetscale/followers","following_url":"https://api.github.com/users/planetscale/following{/other_user}","gists_url":"https://api.github.com/users/planetscale/gists{/gist_id}","starred_url":"https://api.github.com/users/planetscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/planetscale/subscriptions","organizations_url":"https://api.github.com/users/planetscale/orgs","repos_url":"https://api.github.com/users/planetscale/repos","events_url":"https://api.github.com/users/planetscale/events{/privacy}","received_events_url":"https://api.github.com/users/planetscale/received_events","type":"Organization","site_admin":false},"repo":{"id":225690537,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU2OTA1Mzc=","name":"vitess-operator","full_name":"planetscale/vitess-operator","private":false,"owner":{"login":"planetscale","id":35612527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjEyNTI3","avatar_url":"https://avatars3.githubusercontent.com/u/35612527?v=4","gravatar_id":"","url":"https://api.github.com/users/planetscale","html_url":"https://github.com/planetscale","followers_url":"https://api.github.com/users/planetscale/followers","following_url":"https://api.github.com/users/planetscale/following{/other_user}","gists_url":"https://api.github.com/users/planetscale/gists{/gist_id}","starred_url":"https://api.github.com/users/planetscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/planetscale/subscriptions","organizations_url":"https://api.github.com/users/planetscale/orgs","repos_url":"https://api.github.com/users/planetscale/repos","events_url":"https://api.github.com/users/planetscale/events{/privacy}","received_events_url":"https://api.github.com/users/planetscale/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/planetscale/vitess-operator","description":"Kubernetes Operator for Vitess","fork":false,"url":"https://api.github.com/repos/planetscale/vitess-operator","forks_url":"https://api.github.com/repos/planetscale/vitess-operator/forks","keys_url":"https://api.github.com/repos/planetscale/vitess-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/planetscale/vitess-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/planetscale/vitess-operator/teams","hooks_url":"https://api.github.com/repos/planetscale/vitess-operator/hooks","issue_events_url":"https://api.github.com/repos/planetscale/vitess-operator/issues/events{/number}","events_url":"https://api.github.com/repos/planetscale/vitess-operator/events","assignees_url":"https://api.github.com/repos/planetscale/vitess-operator/assignees{/user}","branches_url":"https://api.github.com/repos/planetscale/vitess-operator/branches{/branch}","tags_url":"https://api.github.com/repos/planetscale/vitess-operator/tags","blobs_url":"https://api.github.com/repos/planetscale/vitess-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/planetscale/vitess-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/planetscale/vitess-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/planetscale/vitess-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/planetscale/vitess-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/planetscale/vitess-operator/languages","stargazers_url":"https://api.github.com/repos/planetscale/vitess-operator/stargazers","contributors_url":"https://api.github.com/repos/planetscale/vitess-operator/contributors","subscribers_url":"https://api.github.com/repos/planetscale/vitess-operator/subscribers","subscription_url":"https://api.github.com/repos/planetscale/vitess-operator/subscription","commits_url":"https://api.github.com/repos/planetscale/vitess-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/planetscale/vitess-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/planetscale/vitess-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/planetscale/vitess-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/planetscale/vitess-operator/contents/{+path}","compare_url":"https://api.github.com/repos/planetscale/vitess-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/planetscale/vitess-operator/merges","archive_url":"https://api.github.com/repos/planetscale/vitess-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/planetscale/vitess-operator/downloads","issues_url":"https://api.github.com/repos/planetscale/vitess-operator/issues{/number}","pulls_url":"https://api.github.com/repos/planetscale/vitess-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/planetscale/vitess-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/planetscale/vitess-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/planetscale/vitess-operator/labels{/name}","releases_url":"https://api.github.com/repos/planetscale/vitess-operator/releases{/id}","deployments_url":"https://api.github.com/repos/planetscale/vitess-operator/deployments","created_at":"2019-12-03T18:39:09Z","updated_at":"2019-12-17T10:18:02Z","pushed_at":"2019-12-17T20:17:12Z","git_url":"git://github.com/planetscale/vitess-operator.git","ssh_url":"git@github.com:planetscale/vitess-operator.git","clone_url":"https://github.com/planetscale/vitess-operator.git","svn_url":"https://github.com/planetscale/vitess-operator","homepage":null,"size":362,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/planetscale/vitess-operator/pulls/14"},"html":{"href":"https://github.com/planetscale/vitess-operator/pull/14"},"issue":{"href":"https://api.github.com/repos/planetscale/vitess-operator/issues/14"},"comments":{"href":"https://api.github.com/repos/planetscale/vitess-operator/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/planetscale/vitess-operator/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/planetscale/vitess-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/planetscale/vitess-operator/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/planetscale/vitess-operator/statuses/484652fb33e377cb93200253377b9a62ab413042"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"enisoc"}}