{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/firebase-tools/pulls/comments/291661122","pull_request_review_id":247185578,"id":291661122,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTY2MTEyMg==","diff_hunk":"@@ -372,6 +359,31 @@ function InitializeFirebaseFunctionsStubs(functionsDir: string): void {\n   };\n }\n \n+/*\n+  @google-cloud/firestore@2.0.0 made a breaking change which swapped relying on \"grpc\" to \"@grpc/grpc-js\"\n+  which has a slightly different signature. We need to detect the firestore version to know which version\n+  of grpc to pass as a credential.\n+ */\n+async function getGRPCInsecureCredential(frb: FunctionsRuntimeBundle): Promise<any> {","path":"src/emulator/functionsEmulatorRuntime.ts","position":180,"original_position":180,"commit_id":"a005b6565521ba52b610907adf6f0449aeeec319","original_commit_id":"a005b6565521ba52b610907adf6f0449aeeec319","user":{"login":"abeisgoat","id":969070,"node_id":"MDQ6VXNlcjk2OTA3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/969070?v=4","gravatar_id":"","url":"https://api.github.com/users/abeisgoat","html_url":"https://github.com/abeisgoat","followers_url":"https://api.github.com/users/abeisgoat/followers","following_url":"https://api.github.com/users/abeisgoat/following{/other_user}","gists_url":"https://api.github.com/users/abeisgoat/gists{/gist_id}","starred_url":"https://api.github.com/users/abeisgoat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abeisgoat/subscriptions","organizations_url":"https://api.github.com/users/abeisgoat/orgs","repos_url":"https://api.github.com/users/abeisgoat/repos","events_url":"https://api.github.com/users/abeisgoat/events{/privacy}","received_events_url":"https://api.github.com/users/abeisgoat/received_events","type":"User","site_admin":false},"body":"So yeah, I was thinking about this, but it really doesn't help that much until we drop `firebase-admin@7` because we'll still have to route differently based on version, ya know. Once we drop 7 we'll be able to only support `@google-cloud/firestore>=2.20` then life'll be more buttery.","created_at":"2019-06-07T16:14:44Z","updated_at":"2019-06-07T16:14:44Z","html_url":"https://github.com/firebase/firebase-tools/pull/1366#discussion_r291661122","pull_request_url":"https://api.github.com/repos/firebase/firebase-tools/pulls/1366","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-tools/pulls/comments/291661122"},"html":{"href":"https://github.com/firebase/firebase-tools/pull/1366#discussion_r291661122"},"pull_request":{"href":"https://api.github.com/repos/firebase/firebase-tools/pulls/1366"}},"in_reply_to_id":291392668},"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-tools/pulls/1366","id":284752183,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0NzUyMTgz","html_url":"https://github.com/firebase/firebase-tools/pull/1366","diff_url":"https://github.com/firebase/firebase-tools/pull/1366.diff","patch_url":"https://github.com/firebase/firebase-tools/pull/1366.patch","issue_url":"https://api.github.com/repos/firebase/firebase-tools/issues/1366","number":1366,"state":"open","locked":false,"title":"Fixes #1320, #1322, #1364, and #1312","user":{"login":"abeisgoat","id":969070,"node_id":"MDQ6VXNlcjk2OTA3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/969070?v=4","gravatar_id":"","url":"https://api.github.com/users/abeisgoat","html_url":"https://github.com/abeisgoat","followers_url":"https://api.github.com/users/abeisgoat/followers","following_url":"https://api.github.com/users/abeisgoat/following{/other_user}","gists_url":"https://api.github.com/users/abeisgoat/gists{/gist_id}","starred_url":"https://api.github.com/users/abeisgoat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abeisgoat/subscriptions","organizations_url":"https://api.github.com/users/abeisgoat/orgs","repos_url":"https://api.github.com/users/abeisgoat/repos","events_url":"https://api.github.com/users/abeisgoat/events{/privacy}","received_events_url":"https://api.github.com/users/abeisgoat/received_events","type":"User","site_admin":false},"body":"Many emulator fixes / improvements!\r\n\r\nFixes #1320\r\nFixes #1322 \r\nFixes #1364\r\nFixes #1312","created_at":"2019-06-03T22:23:15Z","updated_at":"2019-06-07T16:14:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14ff7101b0b90c46dcdf3653c61051f19f592cf4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1114199358,"node_id":"MDU6TGFiZWwxMTE0MTk5MzU4","url":"https://api.github.com/repos/firebase/firebase-tools/labels/cla:%20yes","name":"cla: yes","color":"44bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-tools/pulls/1366/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-tools/pulls/1366/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-tools/issues/1366/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-tools/statuses/a005b6565521ba52b610907adf6f0449aeeec319","head":{"label":"firebase:ah-speedhax","ref":"ah-speedhax","sha":"a005b6565521ba52b610907adf6f0449aeeec319","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":15402300,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQwMjMwMA==","name":"firebase-tools","full_name":"firebase/firebase-tools","private":false,"owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firebase/firebase-tools","description":"The Firebase Command Line Tools","fork":false,"url":"https://api.github.com/repos/firebase/firebase-tools","forks_url":"https://api.github.com/repos/firebase/firebase-tools/forks","keys_url":"https://api.github.com/repos/firebase/firebase-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-tools/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-tools/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-tools/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-tools/events","assignees_url":"https://api.github.com/repos/firebase/firebase-tools/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-tools/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-tools/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-tools/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-tools/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-tools/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-tools/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-tools/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-tools/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-tools/merges","archive_url":"https://api.github.com/repos/firebase/firebase-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-tools/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-tools/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-tools/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-tools/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-tools/deployments","created_at":"2013-12-23T18:53:04Z","updated_at":"2019-06-07T11:35:23Z","pushed_at":"2019-06-06T22:36:18Z","git_url":"git://github.com/firebase/firebase-tools.git","ssh_url":"git@github.com:firebase/firebase-tools.git","clone_url":"https://github.com/firebase/firebase-tools.git","svn_url":"https://github.com/firebase/firebase-tools","homepage":"","size":2509,"stargazers_count":1782,"watchers_count":1782,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":313,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":117,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":313,"open_issues":117,"watchers":1782,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"e36933b8fb65d4f59cac491fff4a4f77233c09b4","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":15402300,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQwMjMwMA==","name":"firebase-tools","full_name":"firebase/firebase-tools","private":false,"owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firebase/firebase-tools","description":"The Firebase Command Line Tools","fork":false,"url":"https://api.github.com/repos/firebase/firebase-tools","forks_url":"https://api.github.com/repos/firebase/firebase-tools/forks","keys_url":"https://api.github.com/repos/firebase/firebase-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-tools/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-tools/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-tools/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-tools/events","assignees_url":"https://api.github.com/repos/firebase/firebase-tools/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-tools/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-tools/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-tools/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-tools/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-tools/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-tools/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-tools/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-tools/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-tools/merges","archive_url":"https://api.github.com/repos/firebase/firebase-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-tools/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-tools/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-tools/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-tools/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-tools/deployments","created_at":"2013-12-23T18:53:04Z","updated_at":"2019-06-07T11:35:23Z","pushed_at":"2019-06-06T22:36:18Z","git_url":"git://github.com/firebase/firebase-tools.git","ssh_url":"git@github.com:firebase/firebase-tools.git","clone_url":"https://github.com/firebase/firebase-tools.git","svn_url":"https://github.com/firebase/firebase-tools","homepage":"","size":2509,"stargazers_count":1782,"watchers_count":1782,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":313,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":117,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":313,"open_issues":117,"watchers":1782,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-tools/pulls/1366"},"html":{"href":"https://github.com/firebase/firebase-tools/pull/1366"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-tools/issues/1366"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-tools/issues/1366/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-tools/pulls/1366/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-tools/pulls/1366/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-tools/statuses/a005b6565521ba52b610907adf6f0449aeeec319"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"abeisgoat"}}