{"action":"created","comment":{"url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/comments/358033486","pull_request_review_id":332316878,"id":358033486,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODAzMzQ4Ng==","diff_hunk":"@@ -73,6 +73,20 @@ const CommonShaderMode& ShaderModes::GetCommonShaderMode(\n     return ArrayRef<CommonShaderMode>(m_commonShaderModes)[stage];\n }\n \n+// =====================================================================================================================\n+// Check if any shader stage has useSubgroupSize set\n+bool ShaderModes::GetAnyUseSubgroupSize()","path":"builder/llpcShaderModes.cpp","position":6,"original_position":6,"commit_id":"738356b19f0c9bc492a3e9e9a46ec506b41bb8fe","original_commit_id":"5f7dc3f7c55f14f2751bd6ff3d6c41f42a53bdb5","user":{"login":"amdrexu","id":13959852,"node_id":"MDQ6VXNlcjEzOTU5ODUy","avatar_url":"https://avatars0.githubusercontent.com/u/13959852?v=4","gravatar_id":"","url":"https://api.github.com/users/amdrexu","html_url":"https://github.com/amdrexu","followers_url":"https://api.github.com/users/amdrexu/followers","following_url":"https://api.github.com/users/amdrexu/following{/other_user}","gists_url":"https://api.github.com/users/amdrexu/gists{/gist_id}","starred_url":"https://api.github.com/users/amdrexu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amdrexu/subscriptions","organizations_url":"https://api.github.com/users/amdrexu/orgs","repos_url":"https://api.github.com/users/amdrexu/repos","events_url":"https://api.github.com/users/amdrexu/events{/privacy}","received_events_url":"https://api.github.com/users/amdrexu/received_events","type":"User","site_admin":false},"body":"OK. Then I prefer to call it CheckAnyUseSubgroupSize(). I think although it is a getter actually, the naming is somewhat difficult to read.","created_at":"2019-12-16T02:39:10Z","updated_at":"2019-12-16T02:39:11Z","html_url":"https://github.com/GPUOpen-Drivers/llpc/pull/387#discussion_r358033486","pull_request_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/387","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/comments/358033486"},"html":{"href":"https://github.com/GPUOpen-Drivers/llpc/pull/387#discussion_r358033486"},"pull_request":{"href":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/387"}},"in_reply_to_id":357478959},"pull_request":{"url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/387","id":351488902,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxNDg4OTAy","html_url":"https://github.com/GPUOpen-Drivers/llpc/pull/387","diff_url":"https://github.com/GPUOpen-Drivers/llpc/pull/387.diff","patch_url":"https://github.com/GPUOpen-Drivers/llpc/pull/387.patch","issue_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/issues/387","number":387,"state":"open","locked":false,"title":"Middle-end interface clean-up part 2","user":{"login":"trenouf","id":5879367,"node_id":"MDQ6VXNlcjU4NzkzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/5879367?v=4","gravatar_id":"","url":"https://api.github.com/users/trenouf","html_url":"https://github.com/trenouf","followers_url":"https://api.github.com/users/trenouf/followers","following_url":"https://api.github.com/users/trenouf/following{/other_user}","gists_url":"https://api.github.com/users/trenouf/gists{/gist_id}","starred_url":"https://api.github.com/users/trenouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trenouf/subscriptions","organizations_url":"https://api.github.com/users/trenouf/orgs","repos_url":"https://api.github.com/users/trenouf/repos","events_url":"https://api.github.com/users/trenouf/events{/privacy}","received_events_url":"https://api.github.com/users/trenouf/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-10T16:43:54Z","updated_at":"2019-12-16T02:39:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5d085f1b1b83bff3dd9440c3482fc839641f0b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/387/commits","review_comments_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/387/comments","review_comment_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/issues/387/comments","statuses_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/statuses/738356b19f0c9bc492a3e9e9a46ec506b41bb8fe","head":{"label":"trenouf:pr387-middle-end-part-2","ref":"pr387-middle-end-part-2","sha":"738356b19f0c9bc492a3e9e9a46ec506b41bb8fe","user":{"login":"trenouf","id":5879367,"node_id":"MDQ6VXNlcjU4NzkzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/5879367?v=4","gravatar_id":"","url":"https://api.github.com/users/trenouf","html_url":"https://github.com/trenouf","followers_url":"https://api.github.com/users/trenouf/followers","following_url":"https://api.github.com/users/trenouf/following{/other_user}","gists_url":"https://api.github.com/users/trenouf/gists{/gist_id}","starred_url":"https://api.github.com/users/trenouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trenouf/subscriptions","organizations_url":"https://api.github.com/users/trenouf/orgs","repos_url":"https://api.github.com/users/trenouf/repos","events_url":"https://api.github.com/users/trenouf/events{/privacy}","received_events_url":"https://api.github.com/users/trenouf/received_events","type":"User","site_admin":false},"repo":{"id":177105984,"node_id":"MDEwOlJlcG9zaXRvcnkxNzcxMDU5ODQ=","name":"llpc","full_name":"trenouf/llpc","private":false,"owner":{"login":"trenouf","id":5879367,"node_id":"MDQ6VXNlcjU4NzkzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/5879367?v=4","gravatar_id":"","url":"https://api.github.com/users/trenouf","html_url":"https://github.com/trenouf","followers_url":"https://api.github.com/users/trenouf/followers","following_url":"https://api.github.com/users/trenouf/following{/other_user}","gists_url":"https://api.github.com/users/trenouf/gists{/gist_id}","starred_url":"https://api.github.com/users/trenouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trenouf/subscriptions","organizations_url":"https://api.github.com/users/trenouf/orgs","repos_url":"https://api.github.com/users/trenouf/repos","events_url":"https://api.github.com/users/trenouf/events{/privacy}","received_events_url":"https://api.github.com/users/trenouf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/trenouf/llpc","description":"LLVM-Based Pipeline Compiler","fork":true,"url":"https://api.github.com/repos/trenouf/llpc","forks_url":"https://api.github.com/repos/trenouf/llpc/forks","keys_url":"https://api.github.com/repos/trenouf/llpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trenouf/llpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trenouf/llpc/teams","hooks_url":"https://api.github.com/repos/trenouf/llpc/hooks","issue_events_url":"https://api.github.com/repos/trenouf/llpc/issues/events{/number}","events_url":"https://api.github.com/repos/trenouf/llpc/events","assignees_url":"https://api.github.com/repos/trenouf/llpc/assignees{/user}","branches_url":"https://api.github.com/repos/trenouf/llpc/branches{/branch}","tags_url":"https://api.github.com/repos/trenouf/llpc/tags","blobs_url":"https://api.github.com/repos/trenouf/llpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trenouf/llpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trenouf/llpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/trenouf/llpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trenouf/llpc/statuses/{sha}","languages_url":"https://api.github.com/repos/trenouf/llpc/languages","stargazers_url":"https://api.github.com/repos/trenouf/llpc/stargazers","contributors_url":"https://api.github.com/repos/trenouf/llpc/contributors","subscribers_url":"https://api.github.com/repos/trenouf/llpc/subscribers","subscription_url":"https://api.github.com/repos/trenouf/llpc/subscription","commits_url":"https://api.github.com/repos/trenouf/llpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/trenouf/llpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/trenouf/llpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/trenouf/llpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/trenouf/llpc/contents/{+path}","compare_url":"https://api.github.com/repos/trenouf/llpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trenouf/llpc/merges","archive_url":"https://api.github.com/repos/trenouf/llpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trenouf/llpc/downloads","issues_url":"https://api.github.com/repos/trenouf/llpc/issues{/number}","pulls_url":"https://api.github.com/repos/trenouf/llpc/pulls{/number}","milestones_url":"https://api.github.com/repos/trenouf/llpc/milestones{/number}","notifications_url":"https://api.github.com/repos/trenouf/llpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trenouf/llpc/labels{/name}","releases_url":"https://api.github.com/repos/trenouf/llpc/releases{/id}","deployments_url":"https://api.github.com/repos/trenouf/llpc/deployments","created_at":"2019-03-22T08:58:14Z","updated_at":"2019-12-14T18:10:13Z","pushed_at":"2019-12-14T20:52:03Z","git_url":"git://github.com/trenouf/llpc.git","ssh_url":"git@github.com:trenouf/llpc.git","clone_url":"https://github.com/trenouf/llpc.git","svn_url":"https://github.com/trenouf/llpc","homepage":"","size":7425,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"GPUOpen-Drivers:dev","ref":"dev","sha":"86522c797ee62cebf2354cc3e9eddc974256736b","user":{"login":"GPUOpen-Drivers","id":29980581,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTgwNTgx","avatar_url":"https://avatars2.githubusercontent.com/u/29980581?v=4","gravatar_id":"","url":"https://api.github.com/users/GPUOpen-Drivers","html_url":"https://github.com/GPUOpen-Drivers","followers_url":"https://api.github.com/users/GPUOpen-Drivers/followers","following_url":"https://api.github.com/users/GPUOpen-Drivers/following{/other_user}","gists_url":"https://api.github.com/users/GPUOpen-Drivers/gists{/gist_id}","starred_url":"https://api.github.com/users/GPUOpen-Drivers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPUOpen-Drivers/subscriptions","organizations_url":"https://api.github.com/users/GPUOpen-Drivers/orgs","repos_url":"https://api.github.com/users/GPUOpen-Drivers/repos","events_url":"https://api.github.com/users/GPUOpen-Drivers/events{/privacy}","received_events_url":"https://api.github.com/users/GPUOpen-Drivers/received_events","type":"Organization","site_admin":false},"repo":{"id":136128198,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxMjgxOTg=","name":"llpc","full_name":"GPUOpen-Drivers/llpc","private":false,"owner":{"login":"GPUOpen-Drivers","id":29980581,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTgwNTgx","avatar_url":"https://avatars2.githubusercontent.com/u/29980581?v=4","gravatar_id":"","url":"https://api.github.com/users/GPUOpen-Drivers","html_url":"https://github.com/GPUOpen-Drivers","followers_url":"https://api.github.com/users/GPUOpen-Drivers/followers","following_url":"https://api.github.com/users/GPUOpen-Drivers/following{/other_user}","gists_url":"https://api.github.com/users/GPUOpen-Drivers/gists{/gist_id}","starred_url":"https://api.github.com/users/GPUOpen-Drivers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPUOpen-Drivers/subscriptions","organizations_url":"https://api.github.com/users/GPUOpen-Drivers/orgs","repos_url":"https://api.github.com/users/GPUOpen-Drivers/repos","events_url":"https://api.github.com/users/GPUOpen-Drivers/events{/privacy}","received_events_url":"https://api.github.com/users/GPUOpen-Drivers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GPUOpen-Drivers/llpc","description":"LLVM-Based Pipeline Compiler","fork":false,"url":"https://api.github.com/repos/GPUOpen-Drivers/llpc","forks_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/forks","keys_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/teams","hooks_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/hooks","issue_events_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/issues/events{/number}","events_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/events","assignees_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/assignees{/user}","branches_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/branches{/branch}","tags_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/tags","blobs_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/statuses/{sha}","languages_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/languages","stargazers_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/stargazers","contributors_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/contributors","subscribers_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/subscribers","subscription_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/subscription","commits_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/contents/{+path}","compare_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/merges","archive_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/downloads","issues_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/issues{/number}","pulls_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls{/number}","milestones_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/milestones{/number}","notifications_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/labels{/name}","releases_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/releases{/id}","deployments_url":"https://api.github.com/repos/GPUOpen-Drivers/llpc/deployments","created_at":"2018-06-05T06:06:02Z","updated_at":"2019-12-15T10:34:49Z","pushed_at":"2019-12-15T10:34:47Z","git_url":"git://github.com/GPUOpen-Drivers/llpc.git","ssh_url":"git@github.com:GPUOpen-Drivers/llpc.git","clone_url":"https://github.com/GPUOpen-Drivers/llpc.git","svn_url":"https://github.com/GPUOpen-Drivers/llpc","homepage":"","size":7217,"stargazers_count":55,"watchers_count":55,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":48,"open_issues":11,"watchers":55,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/387"},"html":{"href":"https://github.com/GPUOpen-Drivers/llpc/pull/387"},"issue":{"href":"https://api.github.com/repos/GPUOpen-Drivers/llpc/issues/387"},"comments":{"href":"https://api.github.com/repos/GPUOpen-Drivers/llpc/issues/387/comments"},"review_comments":{"href":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/387/comments"},"review_comment":{"href":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GPUOpen-Drivers/llpc/pulls/387/commits"},"statuses":{"href":"https://api.github.com/repos/GPUOpen-Drivers/llpc/statuses/738356b19f0c9bc492a3e9e9a46ec506b41bb8fe"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"amdrexu"}}