{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments/315508790","pull_request_review_id":276933325,"id":315508790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNTUwODc5MA==","diff_hunk":"@@ -45,7 +45,7 @@ public InsertSelect addColumn(String columnName) {\n \t}\n \n \tpublic InsertSelect addColumns(String[] columnNames) {\n-\t\tthis.columnNames.addAll(Arrays.asList(columnNames));\n+\t\tCollections.addAll( this.columnNames,columnNames );","path":"hibernate-core/src/main/java/org/hibernate/sql/InsertSelect.java","position":15,"original_position":5,"commit_id":"71346da9918640d30e194ae80b18eb713a6a27e7","original_commit_id":"71346da9918640d30e194ae80b18eb713a6a27e7","user":{"login":"beikov","id":358916,"node_id":"MDQ6VXNlcjM1ODkxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/358916?v=4","gravatar_id":"","url":"https://api.github.com/users/beikov","html_url":"https://github.com/beikov","followers_url":"https://api.github.com/users/beikov/followers","following_url":"https://api.github.com/users/beikov/following{/other_user}","gists_url":"https://api.github.com/users/beikov/gists{/gist_id}","starred_url":"https://api.github.com/users/beikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beikov/subscriptions","organizations_url":"https://api.github.com/users/beikov/orgs","repos_url":"https://api.github.com/users/beikov/repos","events_url":"https://api.github.com/users/beikov/events{/privacy}","received_events_url":"https://api.github.com/users/beikov/received_events","type":"User","site_admin":false},"body":"You could additionally change the type of `columnNames` to `ArrayList` and use `ensureCapacity` before adding.","created_at":"2019-08-20T05:12:44Z","updated_at":"2019-08-20T05:14:52Z","html_url":"https://github.com/hibernate/hibernate-orm/pull/2995#discussion_r315508790","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2995","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments/315508790"},"html":{"href":"https://github.com/hibernate/hibernate-orm/pull/2995#discussion_r315508790"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2995"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2995","id":308353803,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4MzUzODAz","html_url":"https://github.com/hibernate/hibernate-orm/pull/2995","diff_url":"https://github.com/hibernate/hibernate-orm/pull/2995.diff","patch_url":"https://github.com/hibernate/hibernate-orm/pull/2995.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2995","number":2995,"state":"open","locked":false,"title":"Changing occurrences of manual array copying via for loop","user":{"login":"carstenartur","id":3164220,"node_id":"MDQ6VXNlcjMxNjQyMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/3164220?v=4","gravatar_id":"","url":"https://api.github.com/users/carstenartur","html_url":"https://github.com/carstenartur","followers_url":"https://api.github.com/users/carstenartur/followers","following_url":"https://api.github.com/users/carstenartur/following{/other_user}","gists_url":"https://api.github.com/users/carstenartur/gists{/gist_id}","starred_url":"https://api.github.com/users/carstenartur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carstenartur/subscriptions","organizations_url":"https://api.github.com/users/carstenartur/orgs","repos_url":"https://api.github.com/users/carstenartur/repos","events_url":"https://api.github.com/users/carstenartur/events{/privacy}","received_events_url":"https://api.github.com/users/carstenartur/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-18T10:35:33Z","updated_at":"2019-08-20T05:14:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa9052eb28313be212c10ac57f582eca11acddab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2995/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2995/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2995/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/71346da9918640d30e194ae80b18eb713a6a27e7","head":{"label":"carstenartur:manualarraycopy","ref":"manualarraycopy","sha":"71346da9918640d30e194ae80b18eb713a6a27e7","user":{"login":"carstenartur","id":3164220,"node_id":"MDQ6VXNlcjMxNjQyMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/3164220?v=4","gravatar_id":"","url":"https://api.github.com/users/carstenartur","html_url":"https://github.com/carstenartur","followers_url":"https://api.github.com/users/carstenartur/followers","following_url":"https://api.github.com/users/carstenartur/following{/other_user}","gists_url":"https://api.github.com/users/carstenartur/gists{/gist_id}","starred_url":"https://api.github.com/users/carstenartur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carstenartur/subscriptions","organizations_url":"https://api.github.com/users/carstenartur/orgs","repos_url":"https://api.github.com/users/carstenartur/repos","events_url":"https://api.github.com/users/carstenartur/events{/privacy}","received_events_url":"https://api.github.com/users/carstenartur/received_events","type":"User","site_admin":false},"repo":{"id":42516402,"node_id":"MDEwOlJlcG9zaXRvcnk0MjUxNjQwMg==","name":"hibernate-orm","full_name":"carstenartur/hibernate-orm","private":false,"owner":{"login":"carstenartur","id":3164220,"node_id":"MDQ6VXNlcjMxNjQyMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/3164220?v=4","gravatar_id":"","url":"https://api.github.com/users/carstenartur","html_url":"https://github.com/carstenartur","followers_url":"https://api.github.com/users/carstenartur/followers","following_url":"https://api.github.com/users/carstenartur/following{/other_user}","gists_url":"https://api.github.com/users/carstenartur/gists{/gist_id}","starred_url":"https://api.github.com/users/carstenartur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carstenartur/subscriptions","organizations_url":"https://api.github.com/users/carstenartur/orgs","repos_url":"https://api.github.com/users/carstenartur/repos","events_url":"https://api.github.com/users/carstenartur/events{/privacy}","received_events_url":"https://api.github.com/users/carstenartur/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carstenartur/hibernate-orm","description":"Hibernate's core Object/Relational Mapping functionality","fork":true,"url":"https://api.github.com/repos/carstenartur/hibernate-orm","forks_url":"https://api.github.com/repos/carstenartur/hibernate-orm/forks","keys_url":"https://api.github.com/repos/carstenartur/hibernate-orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carstenartur/hibernate-orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carstenartur/hibernate-orm/teams","hooks_url":"https://api.github.com/repos/carstenartur/hibernate-orm/hooks","issue_events_url":"https://api.github.com/repos/carstenartur/hibernate-orm/issues/events{/number}","events_url":"https://api.github.com/repos/carstenartur/hibernate-orm/events","assignees_url":"https://api.github.com/repos/carstenartur/hibernate-orm/assignees{/user}","branches_url":"https://api.github.com/repos/carstenartur/hibernate-orm/branches{/branch}","tags_url":"https://api.github.com/repos/carstenartur/hibernate-orm/tags","blobs_url":"https://api.github.com/repos/carstenartur/hibernate-orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carstenartur/hibernate-orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carstenartur/hibernate-orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/carstenartur/hibernate-orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carstenartur/hibernate-orm/statuses/{sha}","languages_url":"https://api.github.com/repos/carstenartur/hibernate-orm/languages","stargazers_url":"https://api.github.com/repos/carstenartur/hibernate-orm/stargazers","contributors_url":"https://api.github.com/repos/carstenartur/hibernate-orm/contributors","subscribers_url":"https://api.github.com/repos/carstenartur/hibernate-orm/subscribers","subscription_url":"https://api.github.com/repos/carstenartur/hibernate-orm/subscription","commits_url":"https://api.github.com/repos/carstenartur/hibernate-orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/carstenartur/hibernate-orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/carstenartur/hibernate-orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/carstenartur/hibernate-orm/issues/comments{/number}","contents_url":"https://api.github.com/repos/carstenartur/hibernate-orm/contents/{+path}","compare_url":"https://api.github.com/repos/carstenartur/hibernate-orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carstenartur/hibernate-orm/merges","archive_url":"https://api.github.com/repos/carstenartur/hibernate-orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carstenartur/hibernate-orm/downloads","issues_url":"https://api.github.com/repos/carstenartur/hibernate-orm/issues{/number}","pulls_url":"https://api.github.com/repos/carstenartur/hibernate-orm/pulls{/number}","milestones_url":"https://api.github.com/repos/carstenartur/hibernate-orm/milestones{/number}","notifications_url":"https://api.github.com/repos/carstenartur/hibernate-orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carstenartur/hibernate-orm/labels{/name}","releases_url":"https://api.github.com/repos/carstenartur/hibernate-orm/releases{/id}","deployments_url":"https://api.github.com/repos/carstenartur/hibernate-orm/deployments","created_at":"2015-09-15T11:54:23Z","updated_at":"2019-03-11T07:10:44Z","pushed_at":"2019-08-19T20:06:42Z","git_url":"git://github.com/carstenartur/hibernate-orm.git","ssh_url":"git@github.com:carstenartur/hibernate-orm.git","clone_url":"https://github.com/carstenartur/hibernate-orm.git","svn_url":"https://github.com/carstenartur/hibernate-orm","homepage":"http://hibernate.org","size":166686,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"0a1213be1aa2b8bda4cdc3219dab573cd5b9adad","user":{"login":"hibernate","id":348262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODI2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":961036,"node_id":"MDEwOlJlcG9zaXRvcnk5NjEwMzY=","name":"hibernate-orm","full_name":"hibernate/hibernate-orm","private":false,"owner":{"login":"hibernate","id":348262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODI2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hibernate/hibernate-orm","description":"Hibernate's core Object/Relational Mapping functionality","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-orm","forks_url":"https://api.github.com/repos/hibernate/hibernate-orm/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-orm/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-orm/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-orm/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-orm/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-orm/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-orm/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-orm/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-orm/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-orm/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-orm/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-orm/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-orm/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-orm/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-orm/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-orm/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-orm/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-orm/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-orm/deployments","created_at":"2010-10-04T16:15:52Z","updated_at":"2019-08-20T02:54:33Z","pushed_at":"2019-08-19T20:06:47Z","git_url":"git://github.com/hibernate/hibernate-orm.git","ssh_url":"git@github.com:hibernate/hibernate-orm.git","clone_url":"https://github.com/hibernate/hibernate-orm.git","svn_url":"https://github.com/hibernate/hibernate-orm","homepage":"http://hibernate.org","size":167115,"stargazers_count":3941,"watchers_count":3941,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2599,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":135,"license":null,"forks":2599,"open_issues":135,"watchers":3941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2995"},"html":{"href":"https://github.com/hibernate/hibernate-orm/pull/2995"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2995"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2995/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2995/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2995/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/71346da9918640d30e194ae80b18eb713a6a27e7"}},"author_association":"NONE"}}
{"actor":{"display_login":"beikov"}}