{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/18234","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/18234/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/18234/comments","events_url":"https://api.github.com/repos/helm/charts/issues/18234/events","html_url":"https://github.com/helm/charts/pull/18234","id":511293859,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxNTE4MDYz","number":18234,"title":"[stable/redis-ha] Fix missing redis ha announce services","user":{"login":"PaulFarver","id":10176751,"node_id":"MDQ6VXNlcjEwMTc2NzUx","avatar_url":"https://avatars2.githubusercontent.com/u/10176751?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulFarver","html_url":"https://github.com/PaulFarver","followers_url":"https://api.github.com/users/PaulFarver/followers","following_url":"https://api.github.com/users/PaulFarver/following{/other_user}","gists_url":"https://api.github.com/users/PaulFarver/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulFarver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulFarver/subscriptions","organizations_url":"https://api.github.com/users/PaulFarver/orgs","repos_url":"https://api.github.com/users/PaulFarver/repos","events_url":"https://api.github.com/users/PaulFarver/events{/privacy}","received_events_url":"https://api.github.com/users/PaulFarver/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":1120334296,"node_id":"MDU6TGFiZWwxMTIwMzM0Mjk2","url":"https://api.github.com/repos/helm/charts/labels/ok-to-test","name":"ok-to-test","color":"ededed","default":false},{"id":676009699,"node_id":"MDU6TGFiZWw2NzYwMDk2OTk=","url":"https://api.github.com/repos/helm/charts/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"ssalaues","id":24439848,"node_id":"MDQ6VXNlcjI0NDM5ODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/24439848?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalaues","html_url":"https://github.com/ssalaues","followers_url":"https://api.github.com/users/ssalaues/followers","following_url":"https://api.github.com/users/ssalaues/following{/other_user}","gists_url":"https://api.github.com/users/ssalaues/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalaues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalaues/subscriptions","organizations_url":"https://api.github.com/users/ssalaues/orgs","repos_url":"https://api.github.com/users/ssalaues/repos","events_url":"https://api.github.com/users/ssalaues/events{/privacy}","received_events_url":"https://api.github.com/users/ssalaues/received_events","type":"User","site_admin":false},"assignees":[{"login":"ssalaues","id":24439848,"node_id":"MDQ6VXNlcjI0NDM5ODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/24439848?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalaues","html_url":"https://github.com/ssalaues","followers_url":"https://api.github.com/users/ssalaues/followers","following_url":"https://api.github.com/users/ssalaues/following{/other_user}","gists_url":"https://api.github.com/users/ssalaues/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalaues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalaues/subscriptions","organizations_url":"https://api.github.com/users/ssalaues/orgs","repos_url":"https://api.github.com/users/ssalaues/repos","events_url":"https://api.github.com/users/ssalaues/events{/privacy}","received_events_url":"https://api.github.com/users/ssalaues/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2019-10-23T12:36:53Z","updated_at":"2019-10-25T05:58:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/18234","html_url":"https://github.com/helm/charts/pull/18234","diff_url":"https://github.com/helm/charts/pull/18234.diff","patch_url":"https://github.com/helm/charts/pull/18234.patch"},"body":"#### What this PR does / why we need it:\r\nThis fixes an issue, where announce services and SENTINEL_ID's were not properly created, when .Values.replicas was a number, as the values.yaml suggests\r\nThis happened because the int function returned 0 when used on a value that was of the json.Number type\r\n\r\n#### Which issue this PR fixes\r\n  - fixes #18190 \r\n\r\n#### Checklist\r\n- [x] [DCO](https://github.com/helm/charts/blob/master/CONTRIBUTING.md#sign-your-work) signed\r\n- [x] Chart Version bumped\r\n- [x] Title of the PR starts with chart name (e.g. `[stable/mychartname]`)\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/546213262","html_url":"https://github.com/helm/charts/pull/18234#issuecomment-546213262","issue_url":"https://api.github.com/repos/helm/charts/issues/18234","id":546213262,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NjIxMzI2Mg==","user":{"login":"DandyDeveloper","id":18436531,"node_id":"MDQ6VXNlcjE4NDM2NTMx","avatar_url":"https://avatars3.githubusercontent.com/u/18436531?v=4","gravatar_id":"","url":"https://api.github.com/users/DandyDeveloper","html_url":"https://github.com/DandyDeveloper","followers_url":"https://api.github.com/users/DandyDeveloper/followers","following_url":"https://api.github.com/users/DandyDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/DandyDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/DandyDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DandyDeveloper/subscriptions","organizations_url":"https://api.github.com/users/DandyDeveloper/orgs","repos_url":"https://api.github.com/users/DandyDeveloper/repos","events_url":"https://api.github.com/users/DandyDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/DandyDeveloper/received_events","type":"User","site_admin":false},"created_at":"2019-10-25T05:58:35Z","updated_at":"2019-10-25T05:58:35Z","author_association":"COLLABORATOR","body":"/lgtm"}}
{"actor":{"display_login":"DandyDeveloper"}}