{"action":"created","comment":{"url":"https://api.github.com/repos/kiegroup/drools/pulls/comments/302616147","pull_request_review_id":260792290,"id":302616147,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjYxNjE0Nw==","diff_hunk":"@@ -260,11 +276,13 @@ public PMML4Result execute(Context context) {\n         List<PMML4Output<?>> outputs = OutputFieldFactory.createOutputsFromResults(resultHolder);\n         ExecutionResultImpl execRes = ctx.lookup(ExecutionResultImpl.class);\n         ctx.register(PMML4Result.class, resultHolder);\n-        execRes.setResult(\"results\", resultHolder);\n-        outputs.forEach(out -> {\n-            execRes.setResult(out.getName(), out);\n-            resultHolder.updateResultVariable(out.getName(), out);\n-        });\n+        if (execRes != null) {\n+            execRes.setResult(\"results\", resultHolder);\n+            outputs.forEach(out -> {\n+                execRes.setResult(out.getName(), out);\n+                resultHolder.updateResultVariable(out.getName(), out);","path":"drools-core/src/main/java/org/drools/core/command/runtime/pmml/ApplyPmmlModelCommand.java","position":67,"original_position":67,"commit_id":"b9640f6187d259c448e9b16782519ec41152fdd9","original_commit_id":"b9640f6187d259c448e9b16782519ec41152fdd9","user":{"login":"mariofusco","id":372781,"node_id":"MDQ6VXNlcjM3Mjc4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/372781?v=4","gravatar_id":"","url":"https://api.github.com/users/mariofusco","html_url":"https://github.com/mariofusco","followers_url":"https://api.github.com/users/mariofusco/followers","following_url":"https://api.github.com/users/mariofusco/following{/other_user}","gists_url":"https://api.github.com/users/mariofusco/gists{/gist_id}","starred_url":"https://api.github.com/users/mariofusco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariofusco/subscriptions","organizations_url":"https://api.github.com/users/mariofusco/orgs","repos_url":"https://api.github.com/users/mariofusco/repos","events_url":"https://api.github.com/users/mariofusco/events{/privacy}","received_events_url":"https://api.github.com/users/mariofusco/received_events","type":"User","site_admin":false},"body":"I believe that the returned `resultHolder` should be populated even when `execRes` is `null`.","created_at":"2019-07-11T15:46:25Z","updated_at":"2019-07-11T15:46:25Z","html_url":"https://github.com/kiegroup/drools/pull/2430#discussion_r302616147","pull_request_url":"https://api.github.com/repos/kiegroup/drools/pulls/2430","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/comments/302616147"},"html":{"href":"https://github.com/kiegroup/drools/pull/2430#discussion_r302616147"},"pull_request":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/2430"}}},"pull_request":{"url":"https://api.github.com/repos/kiegroup/drools/pulls/2430","id":294649025,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0NjQ5MDI1","html_url":"https://github.com/kiegroup/drools/pull/2430","diff_url":"https://github.com/kiegroup/drools/pull/2430.diff","patch_url":"https://github.com/kiegroup/drools/pull/2430.patch","issue_url":"https://api.github.com/repos/kiegroup/drools/issues/2430","number":2430,"state":"open","locked":false,"title":"DROOLS-4278 Applying PMML model using kie-server fails","user":{"login":"lanceleverich","id":7943880,"node_id":"MDQ6VXNlcjc5NDM4ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/7943880?v=4","gravatar_id":"","url":"https://api.github.com/users/lanceleverich","html_url":"https://github.com/lanceleverich","followers_url":"https://api.github.com/users/lanceleverich/followers","following_url":"https://api.github.com/users/lanceleverich/following{/other_user}","gists_url":"https://api.github.com/users/lanceleverich/gists{/gist_id}","starred_url":"https://api.github.com/users/lanceleverich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanceleverich/subscriptions","organizations_url":"https://api.github.com/users/lanceleverich/orgs","repos_url":"https://api.github.com/users/lanceleverich/repos","events_url":"https://api.github.com/users/lanceleverich/events{/privacy}","received_events_url":"https://api.github.com/users/lanceleverich/received_events","type":"User","site_admin":false},"body":"Changed the ApplyPmmlModelCommand execute method so that it uses a\r\nRegistryContext, instead of a RequestContextImpl.","created_at":"2019-07-04T17:06:37Z","updated_at":"2019-07-11T15:46:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdef6dd67c0eadf3e40ab29d7c4c299f35e98f1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiegroup/drools/pulls/2430/commits","review_comments_url":"https://api.github.com/repos/kiegroup/drools/pulls/2430/comments","review_comment_url":"https://api.github.com/repos/kiegroup/drools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiegroup/drools/issues/2430/comments","statuses_url":"https://api.github.com/repos/kiegroup/drools/statuses/b9640f6187d259c448e9b16782519ec41152fdd9","head":{"label":"lanceleverich:DROOLS-4278","ref":"DROOLS-4278","sha":"b9640f6187d259c448e9b16782519ec41152fdd9","user":{"login":"lanceleverich","id":7943880,"node_id":"MDQ6VXNlcjc5NDM4ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/7943880?v=4","gravatar_id":"","url":"https://api.github.com/users/lanceleverich","html_url":"https://github.com/lanceleverich","followers_url":"https://api.github.com/users/lanceleverich/followers","following_url":"https://api.github.com/users/lanceleverich/following{/other_user}","gists_url":"https://api.github.com/users/lanceleverich/gists{/gist_id}","starred_url":"https://api.github.com/users/lanceleverich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanceleverich/subscriptions","organizations_url":"https://api.github.com/users/lanceleverich/orgs","repos_url":"https://api.github.com/users/lanceleverich/repos","events_url":"https://api.github.com/users/lanceleverich/events{/privacy}","received_events_url":"https://api.github.com/users/lanceleverich/received_events","type":"User","site_admin":false},"repo":{"id":92406785,"node_id":"MDEwOlJlcG9zaXRvcnk5MjQwNjc4NQ==","name":"drools","full_name":"lanceleverich/drools","private":false,"owner":{"login":"lanceleverich","id":7943880,"node_id":"MDQ6VXNlcjc5NDM4ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/7943880?v=4","gravatar_id":"","url":"https://api.github.com/users/lanceleverich","html_url":"https://github.com/lanceleverich","followers_url":"https://api.github.com/users/lanceleverich/followers","following_url":"https://api.github.com/users/lanceleverich/following{/other_user}","gists_url":"https://api.github.com/users/lanceleverich/gists{/gist_id}","starred_url":"https://api.github.com/users/lanceleverich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanceleverich/subscriptions","organizations_url":"https://api.github.com/users/lanceleverich/orgs","repos_url":"https://api.github.com/users/lanceleverich/repos","events_url":"https://api.github.com/users/lanceleverich/events{/privacy}","received_events_url":"https://api.github.com/users/lanceleverich/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lanceleverich/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":true,"url":"https://api.github.com/repos/lanceleverich/drools","forks_url":"https://api.github.com/repos/lanceleverich/drools/forks","keys_url":"https://api.github.com/repos/lanceleverich/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lanceleverich/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lanceleverich/drools/teams","hooks_url":"https://api.github.com/repos/lanceleverich/drools/hooks","issue_events_url":"https://api.github.com/repos/lanceleverich/drools/issues/events{/number}","events_url":"https://api.github.com/repos/lanceleverich/drools/events","assignees_url":"https://api.github.com/repos/lanceleverich/drools/assignees{/user}","branches_url":"https://api.github.com/repos/lanceleverich/drools/branches{/branch}","tags_url":"https://api.github.com/repos/lanceleverich/drools/tags","blobs_url":"https://api.github.com/repos/lanceleverich/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lanceleverich/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lanceleverich/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/lanceleverich/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lanceleverich/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/lanceleverich/drools/languages","stargazers_url":"https://api.github.com/repos/lanceleverich/drools/stargazers","contributors_url":"https://api.github.com/repos/lanceleverich/drools/contributors","subscribers_url":"https://api.github.com/repos/lanceleverich/drools/subscribers","subscription_url":"https://api.github.com/repos/lanceleverich/drools/subscription","commits_url":"https://api.github.com/repos/lanceleverich/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/lanceleverich/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/lanceleverich/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/lanceleverich/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/lanceleverich/drools/contents/{+path}","compare_url":"https://api.github.com/repos/lanceleverich/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lanceleverich/drools/merges","archive_url":"https://api.github.com/repos/lanceleverich/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lanceleverich/drools/downloads","issues_url":"https://api.github.com/repos/lanceleverich/drools/issues{/number}","pulls_url":"https://api.github.com/repos/lanceleverich/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/lanceleverich/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/lanceleverich/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lanceleverich/drools/labels{/name}","releases_url":"https://api.github.com/repos/lanceleverich/drools/releases{/id}","deployments_url":"https://api.github.com/repos/lanceleverich/drools/deployments","created_at":"2017-05-25T13:37:03Z","updated_at":"2019-03-06T17:16:05Z","pushed_at":"2019-07-08T23:11:49Z","git_url":"git://github.com/lanceleverich/drools.git","ssh_url":"git@github.com:lanceleverich/drools.git","clone_url":"https://github.com/lanceleverich/drools.git","svn_url":"https://github.com/lanceleverich/drools","homepage":"http://www.drools.org","size":161148,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiegroup:master","ref":"master","sha":"e3ad7ebd62880df55c61bb84257e58e18f4cb064","user":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":1381673,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNjcz","name":"drools","full_name":"kiegroup/drools","private":false,"owner":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiegroup/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":false,"url":"https://api.github.com/repos/kiegroup/drools","forks_url":"https://api.github.com/repos/kiegroup/drools/forks","keys_url":"https://api.github.com/repos/kiegroup/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiegroup/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiegroup/drools/teams","hooks_url":"https://api.github.com/repos/kiegroup/drools/hooks","issue_events_url":"https://api.github.com/repos/kiegroup/drools/issues/events{/number}","events_url":"https://api.github.com/repos/kiegroup/drools/events","assignees_url":"https://api.github.com/repos/kiegroup/drools/assignees{/user}","branches_url":"https://api.github.com/repos/kiegroup/drools/branches{/branch}","tags_url":"https://api.github.com/repos/kiegroup/drools/tags","blobs_url":"https://api.github.com/repos/kiegroup/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiegroup/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiegroup/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiegroup/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiegroup/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/kiegroup/drools/languages","stargazers_url":"https://api.github.com/repos/kiegroup/drools/stargazers","contributors_url":"https://api.github.com/repos/kiegroup/drools/contributors","subscribers_url":"https://api.github.com/repos/kiegroup/drools/subscribers","subscription_url":"https://api.github.com/repos/kiegroup/drools/subscription","commits_url":"https://api.github.com/repos/kiegroup/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiegroup/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiegroup/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiegroup/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiegroup/drools/contents/{+path}","compare_url":"https://api.github.com/repos/kiegroup/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiegroup/drools/merges","archive_url":"https://api.github.com/repos/kiegroup/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiegroup/drools/downloads","issues_url":"https://api.github.com/repos/kiegroup/drools/issues{/number}","pulls_url":"https://api.github.com/repos/kiegroup/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/kiegroup/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/kiegroup/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiegroup/drools/labels{/name}","releases_url":"https://api.github.com/repos/kiegroup/drools/releases{/id}","deployments_url":"https://api.github.com/repos/kiegroup/drools/deployments","created_at":"2011-02-18T08:37:05Z","updated_at":"2019-07-11T08:11:20Z","pushed_at":"2019-07-11T14:51:45Z","git_url":"git://github.com/kiegroup/drools.git","ssh_url":"git@github.com:kiegroup/drools.git","clone_url":"https://github.com/kiegroup/drools.git","svn_url":"https://github.com/kiegroup/drools","homepage":"http://www.drools.org","size":162825,"stargazers_count":2322,"watchers_count":2322,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1649,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1649,"open_issues":30,"watchers":2322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/2430"},"html":{"href":"https://github.com/kiegroup/drools/pull/2430"},"issue":{"href":"https://api.github.com/repos/kiegroup/drools/issues/2430"},"comments":{"href":"https://api.github.com/repos/kiegroup/drools/issues/2430/comments"},"review_comments":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/2430/comments"},"review_comment":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/2430/commits"},"statuses":{"href":"https://api.github.com/repos/kiegroup/drools/statuses/b9640f6187d259c448e9b16782519ec41152fdd9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mariofusco"}}