{"action":"closed","number":1146,"pull_request":{"url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/1146","id":286422888,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2NDIyODg4","html_url":"https://github.com/libopenstorage/openstorage/pull/1146","diff_url":"https://github.com/libopenstorage/openstorage/pull/1146.diff","patch_url":"https://github.com/libopenstorage/openstorage/pull/1146.patch","issue_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/1146","number":1146,"state":"closed","locked":false,"title":"[cherry-pick] Handle spec update for nodiscard, io_strategy (#993)","user":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"body":"Signed-off-by: prabir <prabir@portworx.com>\r\n\r\n<!--\r\n  Make sure to have done the following:\r\n  [] Signed off your work as per the DCO.\r\n  [] Add unit-tests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** (optional)\r\nCloses #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n","created_at":"2019-06-08T18:36:35Z","updated_at":"2019-08-22T05:17:04Z","closed_at":"2019-08-22T05:17:04Z","merged_at":null,"merge_commit_sha":"4096669f3cdbb7e6cfad7c7a8a1b860864c7c916","assignee":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"assignees":[{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lpabon","id":3880001,"node_id":"MDQ6VXNlcjM4ODAwMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3880001?v=4","gravatar_id":"","url":"https://api.github.com/users/lpabon","html_url":"https://github.com/lpabon","followers_url":"https://api.github.com/users/lpabon/followers","following_url":"https://api.github.com/users/lpabon/following{/other_user}","gists_url":"https://api.github.com/users/lpabon/gists{/gist_id}","starred_url":"https://api.github.com/users/lpabon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpabon/subscriptions","organizations_url":"https://api.github.com/users/lpabon/orgs","repos_url":"https://api.github.com/users/lpabon/repos","events_url":"https://api.github.com/users/lpabon/events{/privacy}","received_events_url":"https://api.github.com/users/lpabon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":782338982,"node_id":"MDU6TGFiZWw3ODIzMzg5ODI=","url":"https://api.github.com/repos/libopenstorage/openstorage/labels/do%20not%20merge","name":"do not merge","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/1146/commits","review_comments_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/1146/comments","review_comment_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/1146/comments","statuses_url":"https://api.github.com/repos/libopenstorage/openstorage/statuses/a3b9078379af254a95503a6b528679c7ffb8fca7","head":{"label":"harsh-px:release-4.0","ref":"release-4.0","sha":"a3b9078379af254a95503a6b528679c7ffb8fca7","user":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"repo":{"id":87015833,"node_id":"MDEwOlJlcG9zaXRvcnk4NzAxNTgzMw==","name":"openstorage","full_name":"harsh-px/openstorage","private":false,"owner":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"html_url":"https://github.com/harsh-px/openstorage","description":"A multi-host clustered implementation of the open storage specification","fork":true,"url":"https://api.github.com/repos/harsh-px/openstorage","forks_url":"https://api.github.com/repos/harsh-px/openstorage/forks","keys_url":"https://api.github.com/repos/harsh-px/openstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harsh-px/openstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harsh-px/openstorage/teams","hooks_url":"https://api.github.com/repos/harsh-px/openstorage/hooks","issue_events_url":"https://api.github.com/repos/harsh-px/openstorage/issues/events{/number}","events_url":"https://api.github.com/repos/harsh-px/openstorage/events","assignees_url":"https://api.github.com/repos/harsh-px/openstorage/assignees{/user}","branches_url":"https://api.github.com/repos/harsh-px/openstorage/branches{/branch}","tags_url":"https://api.github.com/repos/harsh-px/openstorage/tags","blobs_url":"https://api.github.com/repos/harsh-px/openstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harsh-px/openstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harsh-px/openstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/harsh-px/openstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harsh-px/openstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/harsh-px/openstorage/languages","stargazers_url":"https://api.github.com/repos/harsh-px/openstorage/stargazers","contributors_url":"https://api.github.com/repos/harsh-px/openstorage/contributors","subscribers_url":"https://api.github.com/repos/harsh-px/openstorage/subscribers","subscription_url":"https://api.github.com/repos/harsh-px/openstorage/subscription","commits_url":"https://api.github.com/repos/harsh-px/openstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/harsh-px/openstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/harsh-px/openstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/harsh-px/openstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/harsh-px/openstorage/contents/{+path}","compare_url":"https://api.github.com/repos/harsh-px/openstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harsh-px/openstorage/merges","archive_url":"https://api.github.com/repos/harsh-px/openstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harsh-px/openstorage/downloads","issues_url":"https://api.github.com/repos/harsh-px/openstorage/issues{/number}","pulls_url":"https://api.github.com/repos/harsh-px/openstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/harsh-px/openstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/harsh-px/openstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harsh-px/openstorage/labels{/name}","releases_url":"https://api.github.com/repos/harsh-px/openstorage/releases{/id}","deployments_url":"https://api.github.com/repos/harsh-px/openstorage/deployments","created_at":"2017-04-02T20:59:46Z","updated_at":"2017-04-02T20:59:48Z","pushed_at":"2019-08-20T22:00:08Z","git_url":"git://github.com/harsh-px/openstorage.git","ssh_url":"git@github.com:harsh-px/openstorage.git","clone_url":"https://github.com/harsh-px/openstorage.git","svn_url":"https://github.com/harsh-px/openstorage","homepage":"","size":31472,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libopenstorage:release-4.0","ref":"release-4.0","sha":"28d0b70bc27c132245b2ecae6851324d72631135","user":{"login":"libopenstorage","id":13478636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDc4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":39651750,"node_id":"MDEwOlJlcG9zaXRvcnkzOTY1MTc1MA==","name":"openstorage","full_name":"libopenstorage/openstorage","private":false,"owner":{"login":"libopenstorage","id":13478636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDc4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libopenstorage/openstorage","description":"A multi-host clustered implementation of the open storage specification","fork":false,"url":"https://api.github.com/repos/libopenstorage/openstorage","forks_url":"https://api.github.com/repos/libopenstorage/openstorage/forks","keys_url":"https://api.github.com/repos/libopenstorage/openstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libopenstorage/openstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libopenstorage/openstorage/teams","hooks_url":"https://api.github.com/repos/libopenstorage/openstorage/hooks","issue_events_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/events{/number}","events_url":"https://api.github.com/repos/libopenstorage/openstorage/events","assignees_url":"https://api.github.com/repos/libopenstorage/openstorage/assignees{/user}","branches_url":"https://api.github.com/repos/libopenstorage/openstorage/branches{/branch}","tags_url":"https://api.github.com/repos/libopenstorage/openstorage/tags","blobs_url":"https://api.github.com/repos/libopenstorage/openstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libopenstorage/openstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libopenstorage/openstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/libopenstorage/openstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libopenstorage/openstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/libopenstorage/openstorage/languages","stargazers_url":"https://api.github.com/repos/libopenstorage/openstorage/stargazers","contributors_url":"https://api.github.com/repos/libopenstorage/openstorage/contributors","subscribers_url":"https://api.github.com/repos/libopenstorage/openstorage/subscribers","subscription_url":"https://api.github.com/repos/libopenstorage/openstorage/subscription","commits_url":"https://api.github.com/repos/libopenstorage/openstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/libopenstorage/openstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/libopenstorage/openstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/libopenstorage/openstorage/contents/{+path}","compare_url":"https://api.github.com/repos/libopenstorage/openstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libopenstorage/openstorage/merges","archive_url":"https://api.github.com/repos/libopenstorage/openstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libopenstorage/openstorage/downloads","issues_url":"https://api.github.com/repos/libopenstorage/openstorage/issues{/number}","pulls_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/libopenstorage/openstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/libopenstorage/openstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libopenstorage/openstorage/labels{/name}","releases_url":"https://api.github.com/repos/libopenstorage/openstorage/releases{/id}","deployments_url":"https://api.github.com/repos/libopenstorage/openstorage/deployments","created_at":"2015-07-24T19:01:34Z","updated_at":"2019-08-20T22:59:09Z","pushed_at":"2019-08-22T01:32:58Z","git_url":"git://github.com/libopenstorage/openstorage.git","ssh_url":"git@github.com:libopenstorage/openstorage.git","clone_url":"https://github.com/libopenstorage/openstorage.git","svn_url":"https://github.com/libopenstorage/openstorage","homepage":"","size":32484,"stargazers_count":344,"watchers_count":344,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":113,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":68,"open_issues":113,"watchers":344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/1146"},"html":{"href":"https://github.com/libopenstorage/openstorage/pull/1146"},"issue":{"href":"https://api.github.com/repos/libopenstorage/openstorage/issues/1146"},"comments":{"href":"https://api.github.com/repos/libopenstorage/openstorage/issues/1146/comments"},"review_comments":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/1146/comments"},"review_comment":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/1146/commits"},"statuses":{"href":"https://api.github.com/repos/libopenstorage/openstorage/statuses/a3b9078379af254a95503a6b528679c7ffb8fca7"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1297,"deletions":1019,"changed_files":6}}
{"actor":{"display_login":"harsh-px"}}