{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/5132","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/5132/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/5132/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/5132/events","html_url":"https://github.com/trilinos/Trilinos/issues/5132","id":441478964,"node_id":"MDU6SXNzdWU0NDE0Nzg5NjQ=","number":5132,"title":"Ifpack2 non-backward compatible change broke SPARC","user":{"login":"bartlettroscoe","id":1959736,"node_id":"MDQ6VXNlcjE5NTk3MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1959736?v=4","gravatar_id":"","url":"https://api.github.com/users/bartlettroscoe","html_url":"https://github.com/bartlettroscoe","followers_url":"https://api.github.com/users/bartlettroscoe/followers","following_url":"https://api.github.com/users/bartlettroscoe/following{/other_user}","gists_url":"https://api.github.com/users/bartlettroscoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bartlettroscoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartlettroscoe/subscriptions","organizations_url":"https://api.github.com/users/bartlettroscoe/orgs","repos_url":"https://api.github.com/users/bartlettroscoe/repos","events_url":"https://api.github.com/users/bartlettroscoe/events{/privacy}","received_events_url":"https://api.github.com/users/bartlettroscoe/received_events","type":"User","site_admin":false},"labels":[{"id":1145008372,"node_id":"MDU6TGFiZWwxMTQ1MDA4Mzcy","url":"https://api.github.com/repos/trilinos/Trilinos/labels/ATDM%20Sev:%20Critical","name":"ATDM Sev: Critical","color":"ce5052","default":false},{"id":1145011874,"node_id":"MDU6TGFiZWwxMTQ1MDExODc0","url":"https://api.github.com/repos/trilinos/Trilinos/labels/PA:%20Linear%20Solvers","name":"PA: Linear Solvers","color":"57d80d","default":false},{"id":816763194,"node_id":"MDU6TGFiZWw4MTY3NjMxOTQ=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/client:%20ATDM","name":"client: ATDM","color":"fbca04","default":false},{"id":1085487687,"node_id":"MDU6TGFiZWwxMDg1NDg3Njg3","url":"https://api.github.com/repos/trilinos/Trilinos/labels/client:%20SPARC","name":"client: SPARC","color":"fbca04","default":false},{"id":291289398,"node_id":"MDU6TGFiZWwyOTEyODkzOTg=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/pkg:%20Ifpack2","name":"pkg: Ifpack2","color":"5319e7","default":false},{"id":287520103,"node_id":"MDU6TGFiZWwyODc1MjAxMDM=","url":"https://api.github.com/repos/trilinos/Trilinos/labels/type:%20bug","name":"type: bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/trilinos/Trilinos/milestones/47","html_url":"https://github.com/trilinos/Trilinos/milestone/47","labels_url":"https://api.github.com/repos/trilinos/Trilinos/milestones/47/labels","id":3131248,"node_id":"MDk6TWlsZXN0b25lMzEzMTI0OA==","number":47,"title":"Keep promoted \"ATDM\" builds of Trilinos clean","description":"This milestone/epic is to aggregate Issues for new failures in builds with the name \"Trilinos-atdm-XXX\" being posted to the \"ATDM\" CDash Track/Group that is sending out CDash error emails after these builds have been promoted.  These failures have to be fixed in short order.\r\n\r\nThere is no end-date for this milestone/epic.  As new failures are reported, new issues will be added.\r\n","creator":{"login":"bartlettroscoe","id":1959736,"node_id":"MDQ6VXNlcjE5NTk3MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1959736?v=4","gravatar_id":"","url":"https://api.github.com/users/bartlettroscoe","html_url":"https://github.com/bartlettroscoe","followers_url":"https://api.github.com/users/bartlettroscoe/followers","following_url":"https://api.github.com/users/bartlettroscoe/following{/other_user}","gists_url":"https://api.github.com/users/bartlettroscoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bartlettroscoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartlettroscoe/subscriptions","organizations_url":"https://api.github.com/users/bartlettroscoe/orgs","repos_url":"https://api.github.com/users/bartlettroscoe/repos","events_url":"https://api.github.com/users/bartlettroscoe/events{/privacy}","received_events_url":"https://api.github.com/users/bartlettroscoe/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":109,"state":"open","created_at":"2018-02-20T22:30:27Z","updated_at":"2019-05-07T22:53:32Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2019-05-07T22:53:31Z","updated_at":"2019-05-07T23:00:34Z","closed_at":null,"author_association":"MEMBER","body":"CC: @trilinos/ifpack2, @srajama1 (Trilinos Linear Solvers Product Area Lead), @kyungjoo-kim, @fryeguy52, @micahahoward, @mhoemmen \r\n\r\n## Description\r\n\r\nWhile not technically a bug, the non-backward compatible change to Ifpack2 in commit a88e5ce841909c2c8097b913efa698785b107a8f merged in PR #5032 broke the SPARC Trilinos Integration build (see [SPAR-567](https://sems-atlassian-srn.sandia.gov/browse/SPAR-567)).\r\n\r\nThe problem is that the functions `Ifpack2::BlockTriDiContainer::getNorms0()` and Ifpack2::BlockTriDiContainer::getNormsFinal()`.  These used to return array (`Teuchos::ArrayRCP<double>`) but now return scalars.  Fixing SPARC to build again is easy but what is not clear is how to translate from the array to the scalar in the customer numerical algorithms in SPARC.\r\n\r\n## Current Status on CDash\r\n\r\n* [SPARC Trilinos Integration Builds last 5 days](http://compsim-dashboard.sandia.gov/cdash/index.php?project=SPARC&filtercombine=and&filtercount=2&showfilters=1&filtercombine=and&field1=buildname&compare1=66&value1=-trildev&field2=buildstarttime&compare2=83&value2=5%20days%20ago).\r\n\r\n## Steps to Reproduce\r\n\r\nMust have access to SPARC repos and instructions to reproduce for those with access are [here](https://snl-wiki.sandia.gov/display/CoodinatedDevOpsATDM/Building+ATDM+APPs+Against+Local+Installs+of+Trilinos#BuildingATDMAPPsAgainstLocalInstallsofTrilinos-BuildingagainstTrilinos'develop'usingtheATDMTrilinosconfiguration).\r\n"},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/490284795","html_url":"https://github.com/trilinos/Trilinos/issues/5132#issuecomment-490284795","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/5132","id":490284795,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MDI4NDc5NQ==","user":{"login":"bartlettroscoe","id":1959736,"node_id":"MDQ6VXNlcjE5NTk3MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1959736?v=4","gravatar_id":"","url":"https://api.github.com/users/bartlettroscoe","html_url":"https://github.com/bartlettroscoe","followers_url":"https://api.github.com/users/bartlettroscoe/followers","following_url":"https://api.github.com/users/bartlettroscoe/following{/other_user}","gists_url":"https://api.github.com/users/bartlettroscoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bartlettroscoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartlettroscoe/subscriptions","organizations_url":"https://api.github.com/users/bartlettroscoe/orgs","repos_url":"https://api.github.com/users/bartlettroscoe/repos","events_url":"https://api.github.com/users/bartlettroscoe/events{/privacy}","received_events_url":"https://api.github.com/users/bartlettroscoe/received_events","type":"User","site_admin":false},"created_at":"2019-05-07T23:00:34Z","updated_at":"2019-05-07T23:00:34Z","author_association":"MEMBER","body":"@kyungjoo-kim, since this was your commit, can you please consult with someone on the SPARC team (or me) on how to adjust client code for this change?  In the SPARC code, it was taking the array, computing the max, of the elements and then dividing by the sqrt() of the number of rows in the matrix. \r\n\r\nFrom the patch in commit a88e5ce841909c2c8097b913efa698785b107a8f it looks like these arrays always had 0 or 1 elements so it seemed logical that it would be a simple substitution but that did not work and 6 new SPARC tests are failing.  Not sure if this or some other changes are causing the failures because the SPARC Trilinos Integration builds have been broken for several days (due to #5098).\r\n\r\nFYI: (For those with access) the SPARC MR that gets SPARC to build again is:\r\n\r\n* https://cee-gitlab.sandia.gov/sparc/sparc-ear99/merge_requests/178\r\n\r\n\r\n"}}
{"actor":{"display_login":"bartlettroscoe"}}