{"action":"created","issue":{"url":"https://api.github.com/repos/onnx/onnx/issues/1793","repository_url":"https://api.github.com/repos/onnx/onnx","labels_url":"https://api.github.com/repos/onnx/onnx/issues/1793/labels{/name}","comments_url":"https://api.github.com/repos/onnx/onnx/issues/1793/comments","events_url":"https://api.github.com/repos/onnx/onnx/issues/1793/events","html_url":"https://github.com/onnx/onnx/issues/1793","id":407096154,"node_id":"MDU6SXNzdWU0MDcwOTYxNTQ=","number":1793,"title":"Require protobuf 2.6.1 at cmake time","user":{"login":"WilliamTambellini","id":109458,"node_id":"MDQ6VXNlcjEwOTQ1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/109458?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamTambellini","html_url":"https://github.com/WilliamTambellini","followers_url":"https://api.github.com/users/WilliamTambellini/followers","following_url":"https://api.github.com/users/WilliamTambellini/following{/other_user}","gists_url":"https://api.github.com/users/WilliamTambellini/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamTambellini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamTambellini/subscriptions","organizations_url":"https://api.github.com/users/WilliamTambellini/orgs","repos_url":"https://api.github.com/users/WilliamTambellini/repos","events_url":"https://api.github.com/users/WilliamTambellini/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamTambellini/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-02-06T06:22:03Z","updated_at":"2019-02-06T18:44:54Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\nhere is a compilation failure using onnx master on a default uptodate centos 7.5:\r\n\r\ncmake .. \r\n...\r\n Found Protobuf: /usr/lib64/libprotobuf.so;-lpthread (found version \"2.5.0\") \r\n\r\n> --   CMake version         : 3.9.3\r\n--   ONNX version          : 1.4.1\r\n--   ONNX NAMESPACE        : onnx\r\n--   ONNX_BUILD_TESTS      : OFF\r\n--   ONNX_BUILD_BENCHMARKS : OFF\r\n--   ONNX_USE_LITE_PROTO   : OFF\r\n--   ONNXIFI_DUMMY_BACKEND : OFF\r\n-- \r\n--   Protobuf compiler     : /usr/bin/protoc\r\n--   Protobuf includes     : /usr/include\r\n--   Protobuf libraries    : /usr/lib64/libprotobuf.so;-lpthread\r\n--   BUILD_ONNX_PYTHON     : OFF\r\n-- Configuring done\r\n-- Generating done\r\n-- Build files have been written to: /home/wtambellini/repos/onnx/build\r\n\r\n~/repos/onnx/build] (master)\r\n$ make\r\nScanning dependencies of target gen_onnx_proto\r\n[  1%] Running gen_proto.py on onnx/onnx.in.proto\r\nProcessing /home/wtambellini/repos/onnx/onnx/onnx.in.proto\r\nWriting /home/wtambellini/repos/onnx/build/onnx/onnx.proto\r\nWriting /home/wtambellini/repos/onnx/build/onnx/onnx.proto3\r\ngenerating /home/wtambellini/repos/onnx/build/onnx/onnx_pb.py\r\n[  3%] Running C++ protocol buffer compiler on /home/wtambellini/repos/onnx/build/onnx/onnx.proto\r\nonnx/onnx.proto:429:5: Expected \"required\", \"optional\", or \"repeated\".\r\nonnx/onnx.proto:429:17: Missing field number.\r\nonnx/onnx.proto:457:3: Expected \"required\", \"optional\", or \"repeated\".\r\nonnx/onnx.proto:457:15: Missing field number.\r\nmake[2]: *** [onnx/onnx.pb.cc] Error 1\r\nmake[1]: *** [CMakeFiles/gen_onnx_proto.dir/all] Error 2\r\nmake: *** [all] Error 2\r\n\r\nI suspect onnx not to be buildable with protobuf 2.5 but looks like the CMakeList.txt does nt check if found protobuf version is adequate,  is nt it ?\r\n "},"comment":{"url":"https://api.github.com/repos/onnx/onnx/issues/comments/461139250","html_url":"https://github.com/onnx/onnx/issues/1793#issuecomment-461139250","issue_url":"https://api.github.com/repos/onnx/onnx/issues/1793","id":461139250,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MTEzOTI1MA==","user":{"login":"WilliamTambellini","id":109458,"node_id":"MDQ6VXNlcjEwOTQ1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/109458?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamTambellini","html_url":"https://github.com/WilliamTambellini","followers_url":"https://api.github.com/users/WilliamTambellini/followers","following_url":"https://api.github.com/users/WilliamTambellini/following{/other_user}","gists_url":"https://api.github.com/users/WilliamTambellini/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamTambellini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamTambellini/subscriptions","organizations_url":"https://api.github.com/users/WilliamTambellini/orgs","repos_url":"https://api.github.com/users/WilliamTambellini/repos","events_url":"https://api.github.com/users/WilliamTambellini/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamTambellini/received_events","type":"User","site_admin":false},"created_at":"2019-02-06T18:44:54Z","updated_at":"2019-02-06T18:44:54Z","author_association":"NONE","body":"https://github.com/onnx/onnx/pull/1794\r\n"}}
{"actor":{"display_login":"WilliamTambellini"}}