{"push_id":3656448908,"size":337,"distinct_size":13,"ref":"refs/heads/PSLintFixes","head":"087fadfe2e040f64bdafd106dca7173b3a4dbfd2","before":"37e59ee0f95c0fe2458f8c9738d9f5bd57683fdc","commits":[{"sha":"6e7315024421d9603ded041488cce103b1e0f2eb","author":{"name":"Anatoly Pugachev","email":"f01b9cc14a3af285a80e118b17260fa5b6593328@gmail.com"},"message":"refactor iscsi network facts module, remove external grep call, add unit test (#55643)\n\n* remove external grep call and parse with python\r\n* use function for repeated code\r\n* use module.get_bin_path() for iscsiutil on HPUX\r\n* some code opt for HPUX\r\n* clean up non-module code, module being defined is a requirement for this code\r\n* import get_bin_path() directly and use without module prefix\r\n* Add integration tests for AIX and HP-UX\r\n* add changelog fragment\r\n* Apply suggestions from code review\r\nCo-Authored-By: mator <matorola@gmail.com>\r\n* Apply suggestions from code review #2\r\nCo-Authored-By: Sam Doran <sdoran@redhat.com>\r\n* Remove strict requirement on executable to exist for get_bin_path() as\r\nit will allow facts gathering to continue without an error. Almost all\r\nother files under facts do not have \"required=True\" (except 2 files,\r\nwhich should be probably fixed). And check return value for\r\nget_bin_path() , before run attempt.\r\n\r\n* add check for AIX lsattr run_command return code","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/6e7315024421d9603ded041488cce103b1e0f2eb"},{"sha":"6a88b715f955a234a9f95b1ebac11774460dc7db","author":{"name":"Abhijeet Kasurde","email":"6334fd0c217b1f2a15926284df229acde5b4fc3a@redhat.com"},"message":"VMware: Remove ckotte from VMware notification (#56118)\n\nAs per request from ckotte, removing ckotte from\r\nbot notification.\r\n\r\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/6a88b715f955a234a9f95b1ebac11774460dc7db"},{"sha":"ba9fee6c37dd9d536dc2496dd763c5fac2a6e411","author":{"name":"Felix Fontein","email":"9c69098d379350e157eff4ad93150662007b8fb2@fontein.de"},"message":"Hetzner failover IP module (#56103)\n\n* First version of Hetzner failover IP module.\r\n\r\n* Extend module.\r\n\r\n* Add comments.\r\n\r\n* Add basic unit tests.\r\n\r\n* Add more tests.\r\n\r\n* Tests for set_failover.","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/ba9fee6c37dd9d536dc2496dd763c5fac2a6e411"},{"sha":"6f0ac90ec3a47ad86ce61228c0c2b17bba02667f","author":{"name":"vicmunoz","email":"cb2c6d93d2844b7f1739741c648bbba3d904885f@gmail.com"},"message":"na_ontap_qtree / na_ontap_gather_facts: qtree new params and modify operation / new subsets (#55825)\n\n* qtree new parameters and modify action\r\n\r\n* fixing pylint offenses\r\n\r\n* fixing shippable fails\r\n\r\n* added igroup_info gather_subset\r\n\r\n* added qos_policy_info / qos_adaptive_policy_info gather_subsets\r\n\r\n* pylint fixes\r\n\r\n* fixing shippable test failure\r\n\r\n* requiring option flexvol_name for na_ontap_qtree module","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/6f0ac90ec3a47ad86ce61228c0c2b17bba02667f"},{"sha":"8ff27c4e0c8cb34acfa04566bbc676c943a37a87","author":{"name":"Brian Coca","email":"cde2288a4505b40178bc8f0ddd96dbc32526f60d@users.noreply.github.com"},"message":"more info on how vaults work (#56183)\n\nalso add warning about what it covers.","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/8ff27c4e0c8cb34acfa04566bbc676c943a37a87"},{"sha":"38890ddcaf2272ac9e404647377e2e8cdb2a9e5f","author":{"name":"Nathaniel Case","email":"0b11fd8446c043cbe4f060d4af4c26ce1807eeaf@redhat.com"},"message":"Expose `newline` option to cli_command module (#55451)\n\n* Add newline to all cliconf plugins\r\n\r\n* Expose newline in cli_command\r\n\r\n* Also hook up to anything using transform_commands directly","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/38890ddcaf2272ac9e404647377e2e8cdb2a9e5f"},{"sha":"c99e79cc58a8cae7304d8c0444d6141993849a48","author":{"name":"Issei.M","email":"40066aa4fa5c0ce070d4654e449e61f7feda5ffb@gmail.com"},"message":"Fix wrong `date_size` skip logic in s3_sync module (#53935)","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/c99e79cc58a8cae7304d8c0444d6141993849a48"},{"sha":"e00f086c969a13cbaf0397f05166c85b9266c275","author":{"name":"Kylix","email":"30d7f005d67f3fb4c6c3d181e1b27bb5661843ee@gmail.com"},"message":"Update k8s_facts.py (#56193)\n\nhttps://github.com/ansible/ansible/issues/55448","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/e00f086c969a13cbaf0397f05166c85b9266c275"},{"sha":"193f69064fb40a83e3e7d2112ef24868b45233b3","author":{"name":"Abhijeet Kasurde","email":"6334fd0c217b1f2a15926284df229acde5b4fc3a@redhat.com"},"message":"VMware: remove duplicate implementation of memory reservation (#56161)\n\nmem_reservation and memory_reservation has redundant implementation.\r\nCombining them together.\r\n\r\nFixes: #54335\r\n\r\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/193f69064fb40a83e3e7d2112ef24868b45233b3"},{"sha":"7a957ba64ac505167e5bfb3093a40be80176084e","author":{"name":"Felix Fontein","email":"9c69098d379350e157eff4ad93150662007b8fb2@fontein.de"},"message":"openssl_certificate: fix passphrase handling for cryptography backend (#56155)\n\n* Make sure passphrase is bytes string.\n\n* Fix typo.\n\n* Add more passphrase tests.\n\n* Fix test names.\n\n* Add changelog.","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/7a957ba64ac505167e5bfb3093a40be80176084e"},{"sha":"57e0567310655a2fe87fccf6e714714f5f6733b4","author":{"name":"Trishna Guha","email":"ce185bc4d02177cfb8b83f6e4ec8fbdf1e25eaef@gmail.com"},"message":"fix nxos_vlan mode idempotence bug (#55144)\n\n* fix nxos_vlan mode idempotence bug\r\n\r\nSigned-off-by: Trishna Guha <trishnaguha17@gmail.com>\r\n\r\n* Fix CI failure\r\n\r\nSigned-off-by: Trishna Guha <trishnaguha17@gmail.com>","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/57e0567310655a2fe87fccf6e714714f5f6733b4"},{"sha":"1462fd740b279ebe7dd791c8cac338a36ad413f6","author":{"name":"James E. King III","email":"6735552445c353d3ea69863270295f8ce4deb09d@apache.org"},"message":"ec2_instance fix name idempotency (#55224)","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/1462fd740b279ebe7dd791c8cac338a36ad413f6"},{"sha":"5a6f8880360c3d4096b7e26ff9b00854f125337e","author":{"name":"Andrea Tartaglia","email":"fdb87dfd199045af7165780b11640b83768a0d57@braingap.uk"},"message":"ec2_instance: Force int when ebs.volume_size or ebs.iops is specified (#55716)\n\n* Force int when volume_size is specified\r\n\r\n* changelog\r\n\r\n* both volume_size and iops must be int\r\n\r\n* updated changelog fragment","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/5a6f8880360c3d4096b7e26ff9b00854f125337e"},{"sha":"2a39dc84b75599db0891398ccb7716601c56b139","author":{"name":"Bojan Vitnik","email":"43e941bd86404ee6e8e8853f2d31ab005b4469fb@mainstream.rs"},"message":"XenServer: Minor changes and fixes in xenserver_guest (#55678)\n\n* XenServer: Minor changes and fixes in xenserver_guest\n\n - xenserver_guest module: ignore wait_for_ip_address when\n   state=absent (fixes #55348). Module docs are updated to reflect this.\n - xenserver_guest module: show proper error message when maximum number\n   of network interfaces is reached and multiple network interfaces are\n   added at once (fix for changes introduced in #54697).\n - xenserver_guest module: fixed a bug in reconfigure() where VM would\n   be powered off even though check mode is used when reconfiguration\n   needs VM to be powered off.\n\n* Added changelog fragment","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/2a39dc84b75599db0891398ccb7716601c56b139"},{"sha":"cd95843ea5f1bff40225b0430cfbb379cbe53661","author":{"name":"Will Thames","email":"37d41699bdee4fcb969ca499eb0f8b82c60d59cc@thames.id.au"},"message":"Make ansible adhoc work with include_role (#56163)\n\n* Make ansible adhoc work with include_role\r\n\r\nFix logic condition so that include_role works\r\nwithout\r\n\r\n```\r\nERROR! 'async_val' is not a valid attribute for a IncludeRole\r\n\r\nThe error appears to be in 'None': line 0, column 0, but may\r\nbe elsewhere in the file depending on the exact syntax problem.\r\n\r\n(could not open file to display line)\r\n```\r\n\r\n* Add include_role test for adhoc","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/cd95843ea5f1bff40225b0430cfbb379cbe53661"},{"sha":"deae5b1bce9f434e67127ef0c8a46ed1d1f5544b","author":{"name":"Brian Coca","email":"cde2288a4505b40178bc8f0ddd96dbc32526f60d@users.noreply.github.com"},"message":"remove deprecated get_md5 from stat (#55659)\n\n* remove deprecated get_md5 from stat\r\n\r\n  fixes #55309\r\n\r\n* removed get_md5 from tests involving stat\r\n\r\n* keep get_md5 but hide it\r\n\r\n* rst it\r\n\r\n* ammended comment\r\n\r\n* ws\r\n\r\n* added ignore for hidden md5","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/deae5b1bce9f434e67127ef0c8a46ed1d1f5544b"},{"sha":"2e8a3efccb8f90ae03e61e3b08d238790fb50658","author":{"name":"Trishna Guha","email":"ce185bc4d02177cfb8b83f6e4ec8fbdf1e25eaef@gmail.com"},"message":"Revert nxos, ios, iosxr return_timestamps (#56206)\n\n* Revert \"nxos_command:run_commands results failure when commands array size >1 (#52670)\"\r\nThis reverts commit 0df5b92af37d43da20125dc418f1cb92390a8a25.\r\n* Revert \"added timestamps to nxos_command module (#50261)\"\r\nThis reverts commit e1509433144572e5010d0ced72a2129600dd8bd4.\r\n* Revert \"added timestamps to ios_command module (#50323)\"\r\nThis reverts commit 2a432a093b392e3f8babea6b760df6a5c8716b03.\r\n* Revert \"added response_timestamps to iosxr_command module (#50095)\"\r\nThis reverts commit 2a0c356da9d18a98399f2802ea8a52eb421f87ac.","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/2e8a3efccb8f90ae03e61e3b08d238790fb50658"},{"sha":"cf585831b4fb80c4ae5c0f5b25583bdb7e31a14d","author":{"name":"Chris Van Heuveln","email":"f80eec59ec75da267058cae26e0e1b2790525b66@cisco.com"},"message":"nxos_banner: test file cleanup (#55992)\n\n- Created `sanity.yaml` to contain all of the tests previously kept in separate files\r\n\r\n- Removed `cli` and `nxapi` test directories\r\n\r\n- Tested on current supported platforms and versions: `N3K,N6K,N7K,N9K,N3K-F,N9K-F`","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/cf585831b4fb80c4ae5c0f5b25583bdb7e31a14d"},{"sha":"a5b6a161b543966521af62a078e04df51c389437","author":{"name":"Strahinja Kustudic","email":"a578cfb8ec30df6d990d142df1db2e8c1703e52f@gmail.com"},"message":"sysctl will now return an error if the value is invalid (#55695)\n\n* sysctl will now return an error if the value is invalid\r\n\r\nsysctl can fail to set a value even if it returns an exit status 0. More\r\ndetails: https://bugzilla.redhat.com/show_bug.cgi?id=1264080. Because of\r\nthis in case of an invalid value or a read-only file system, sysctl\r\nmodule would return OK, even though it didn't set anything. To be sure\r\nthat sysctl correctly applied the changes we also need to check the\r\noutput of stderr.\r\n\r\n* Run sysctl with LANG=C\r\n\r\nBecause we are parsing sysctl stderr we need to make sure that errors\r\nare persistent across different system language settings.\r\n\r\n* Add changelog fragment for sysctl","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/a5b6a161b543966521af62a078e04df51c389437"},{"sha":"bceca72eb7f4714a64c6ebee310e005633de1f71","author":{"name":"Mike Wiebe","email":"917d7e5dd775a1ce3ba38f71a36d333814c9cd3d@cisco.com"},"message":"nxos_interface: Fix admin_state check for n6k (#55673)\n\n* Fix admin_state check for n6k\r\n\r\n* Fix rx and tx_rate intent check test","distinct":false,"url":"https://api.github.com/repos/ShachafGoldstein/ansible/commits/bceca72eb7f4714a64c6ebee310e005633de1f71"}]}
{"actor":{"display_login":"ShachafGoldstein"}}