{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/17270","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/17270/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/17270/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/17270/events","html_url":"https://github.com/bitcoin/bitcoin/pull/17270","id":512906295,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyODE1NjEy","number":17270,"title":"Feed environment data into RNG initializers","user":{"login":"sipa","id":548488,"node_id":"MDQ6VXNlcjU0ODQ4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/548488?v=4","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"labels":[{"id":241832923,"node_id":"MDU6TGFiZWwyNDE4MzI5MjM=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Utils/log/libs","name":"Utils/log/libs","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2019-10-27T01:26:21Z","updated_at":"2019-10-29T20:40:31Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/17270","html_url":"https://github.com/bitcoin/bitcoin/pull/17270","diff_url":"https://github.com/bitcoin/bitcoin/pull/17270.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/17270.patch"},"body":"This introduces a new `randomenv` module that queries varies non-cryptographic (and non-RNG) sources of entropy available on the system; things like user IDs, system configuration, time, statistics, CPUID data.\r\n\r\nThe idea is that these provide a fallback in scenarios where system entropy is somehow broken (note that if system entropy *fails* we will abort regardless; this is only meant to function as a last resort against undetected failure). It includes some data sources OpenSSL currently uses, and more.\r\n\r\nThe separation between random and randomenv is a bit arbitrary, but I felt that all this \"non-essential\" functionality deserved to be separated from the core random module."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/547619465","html_url":"https://github.com/bitcoin/bitcoin/pull/17270#issuecomment-547619465","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/17270","id":547619465,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NzYxOTQ2NQ==","user":{"login":"gmaxwell","id":858454,"node_id":"MDQ6VXNlcjg1ODQ1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/858454?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"created_at":"2019-10-29T20:40:31Z","updated_at":"2019-10-29T20:40:31Z","author_association":"CONTRIBUTOR","body":"A reminder that this sort of thing is important:  Some ryzen cpus rng returns a constant (and success), and in default configs linux relies on it for many purposes (I think, /dev/random in current default kernel configs mostly manages to dodge the over-reliance, but many other things do-- so it's a narrow miss.)"}}
{"actor":{"display_login":"gmaxwell"}}