{"action":"closed","number":52533,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/52533","id":254052420,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0MDUyNDIw","html_url":"https://github.com/ansible/ansible/pull/52533","diff_url":"https://github.com/ansible/ansible/pull/52533.diff","patch_url":"https://github.com/ansible/ansible/pull/52533.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/52533","number":52533,"state":"closed","locked":false,"title":"docker_swarm_service: Remove misinterpretable description","user":{"login":"hannseman","id":758858,"node_id":"MDQ6VXNlcjc1ODg1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/758858?v=4","gravatar_id":"","url":"https://api.github.com/users/hannseman","html_url":"https://github.com/hannseman","followers_url":"https://api.github.com/users/hannseman/followers","following_url":"https://api.github.com/users/hannseman/following{/other_user}","gists_url":"https://api.github.com/users/hannseman/gists{/gist_id}","starred_url":"https://api.github.com/users/hannseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannseman/subscriptions","organizations_url":"https://api.github.com/users/hannseman/orgs","repos_url":"https://api.github.com/users/hannseman/repos","events_url":"https://api.github.com/users/hannseman/events{/privacy}","received_events_url":"https://api.github.com/users/hannseman/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\n<!--- Describe the change below, including rationale and design decisions -->\r\n<!--- HINT: Include \"Fixes #nnn\" if you are fixing an existing issue -->\r\n\r\nThe current module description is as follows:\r\n> Manage docker services. Allows live altering of already defined services\r\n\r\nIn my opinion this reads like ansible tasks can be \"attached\" to previously non-ansible defined services without changing the state of that service if not explicitly defined in the task.\r\n\r\nThis is not the case since the `fetch_current_spec` is not used on `client.update_service`. All non specified options in task will revert to docker-py defaults.\r\n\r\nSee docs here: https://docker-py.readthedocs.io/en/stable/api.html#docker.api.service.ServiceApiMixin.update_service\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n- Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Write the short name of the module, plugin, task or feature below -->\r\ndocker_swarm_service\r\n","created_at":"2019-02-18T21:51:21Z","updated_at":"2019-02-19T19:15:38Z","closed_at":"2019-02-19T19:15:38Z","merged_at":"2019-02-19T19:15:38Z","merge_commit_sha":"991af9ca730cfdc4b38a40a10626638ab1a27ffb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"5319e7","default":false},{"id":516503247,"node_id":"MDU6TGFiZWw1MTY1MDMyNDc=","url":"https://api.github.com/repos/ansible/ansible/labels/automerge","name":"automerge","color":"d93f0b","default":false},{"id":785271699,"node_id":"MDU6TGFiZWw3ODUyNzE2OTk=","url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":61528803,"node_id":"MDU6TGFiZWw2MTUyODgwMw==","url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"4071a5","default":false},{"id":500715204,"node_id":"MDU6TGFiZWw1MDA3MTUyMDQ=","url":"https://api.github.com/repos/ansible/ansible/labels/docker","name":"docker","color":"c5def5","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":499433583,"node_id":"MDU6TGFiZWw0OTk0MzM1ODM=","url":"https://api.github.com/repos/ansible/ansible/labels/shipit","name":"shipit","color":"fbca04","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/52533/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/52533/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/52533/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/e842681aa8741e132e234aefa09f7107528f6151","head":{"label":"hannseman:docker_swarm_service-remove-existing-update-doc","ref":"docker_swarm_service-remove-existing-update-doc","sha":"e842681aa8741e132e234aefa09f7107528f6151","user":{"login":"hannseman","id":758858,"node_id":"MDQ6VXNlcjc1ODg1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/758858?v=4","gravatar_id":"","url":"https://api.github.com/users/hannseman","html_url":"https://github.com/hannseman","followers_url":"https://api.github.com/users/hannseman/followers","following_url":"https://api.github.com/users/hannseman/following{/other_user}","gists_url":"https://api.github.com/users/hannseman/gists{/gist_id}","starred_url":"https://api.github.com/users/hannseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannseman/subscriptions","organizations_url":"https://api.github.com/users/hannseman/orgs","repos_url":"https://api.github.com/users/hannseman/repos","events_url":"https://api.github.com/users/hannseman/events{/privacy}","received_events_url":"https://api.github.com/users/hannseman/received_events","type":"User","site_admin":false},"repo":{"id":164247140,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQyNDcxNDA=","name":"ansible","full_name":"hannseman/ansible","private":false,"owner":{"login":"hannseman","id":758858,"node_id":"MDQ6VXNlcjc1ODg1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/758858?v=4","gravatar_id":"","url":"https://api.github.com/users/hannseman","html_url":"https://github.com/hannseman","followers_url":"https://api.github.com/users/hannseman/followers","following_url":"https://api.github.com/users/hannseman/following{/other_user}","gists_url":"https://api.github.com/users/hannseman/gists{/gist_id}","starred_url":"https://api.github.com/users/hannseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannseman/subscriptions","organizations_url":"https://api.github.com/users/hannseman/orgs","repos_url":"https://api.github.com/users/hannseman/repos","events_url":"https://api.github.com/users/hannseman/events{/privacy}","received_events_url":"https://api.github.com/users/hannseman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hannseman/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":true,"url":"https://api.github.com/repos/hannseman/ansible","forks_url":"https://api.github.com/repos/hannseman/ansible/forks","keys_url":"https://api.github.com/repos/hannseman/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hannseman/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hannseman/ansible/teams","hooks_url":"https://api.github.com/repos/hannseman/ansible/hooks","issue_events_url":"https://api.github.com/repos/hannseman/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/hannseman/ansible/events","assignees_url":"https://api.github.com/repos/hannseman/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/hannseman/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/hannseman/ansible/tags","blobs_url":"https://api.github.com/repos/hannseman/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hannseman/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hannseman/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/hannseman/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hannseman/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/hannseman/ansible/languages","stargazers_url":"https://api.github.com/repos/hannseman/ansible/stargazers","contributors_url":"https://api.github.com/repos/hannseman/ansible/contributors","subscribers_url":"https://api.github.com/repos/hannseman/ansible/subscribers","subscription_url":"https://api.github.com/repos/hannseman/ansible/subscription","commits_url":"https://api.github.com/repos/hannseman/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/hannseman/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/hannseman/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/hannseman/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/hannseman/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/hannseman/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hannseman/ansible/merges","archive_url":"https://api.github.com/repos/hannseman/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hannseman/ansible/downloads","issues_url":"https://api.github.com/repos/hannseman/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/hannseman/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/hannseman/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/hannseman/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hannseman/ansible/labels{/name}","releases_url":"https://api.github.com/repos/hannseman/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/hannseman/ansible/deployments","created_at":"2019-01-05T20:03:58Z","updated_at":"2019-02-17T11:33:44Z","pushed_at":"2019-02-19T15:33:05Z","git_url":"git://github.com/hannseman/ansible.git","ssh_url":"git@github.com:hannseman/ansible.git","clone_url":"https://github.com/hannseman/ansible.git","svn_url":"https://github.com/hannseman/ansible","homepage":"https://www.ansible.com/","size":148689,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"a1fec259c1cf16429eb7d42c9c9a657eff814436","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2019-02-19T19:08:34Z","pushed_at":"2019-02-19T19:15:38Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":157003,"stargazers_count":35445,"watchers_count":35445,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14438,"mirror_url":null,"archived":false,"open_issues_count":5643,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":14438,"open_issues":5643,"watchers":35445,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/52533"},"html":{"href":"https://github.com/ansible/ansible/pull/52533"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/52533"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/52533/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/52533/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/52533/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/e842681aa8741e132e234aefa09f7107528f6151"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ansibot","id":6585283,"node_id":"MDQ6VXNlcjY1ODUyODM=","avatar_url":"https://avatars0.githubusercontent.com/u/6585283?v=4","gravatar_id":"","url":"https://api.github.com/users/ansibot","html_url":"https://github.com/ansibot","followers_url":"https://api.github.com/users/ansibot/followers","following_url":"https://api.github.com/users/ansibot/following{/other_user}","gists_url":"https://api.github.com/users/ansibot/gists{/gist_id}","starred_url":"https://api.github.com/users/ansibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansibot/subscriptions","organizations_url":"https://api.github.com/users/ansibot/orgs","repos_url":"https://api.github.com/users/ansibot/repos","events_url":"https://api.github.com/users/ansibot/events{/privacy}","received_events_url":"https://api.github.com/users/ansibot/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"maintainer_can_modify":false,"commits":3,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"ansibot"}}