{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/client_golang/issues/562","repository_url":"https://api.github.com/repos/prometheus/client_golang","labels_url":"https://api.github.com/repos/prometheus/client_golang/issues/562/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/client_golang/issues/562/comments","events_url":"https://api.github.com/repos/prometheus/client_golang/issues/562/events","html_url":"https://github.com/prometheus/client_golang/pull/562","id":438502407,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NTE5NjAx","number":562,"title":"Add storage.Warnings to client","user":{"login":"jacksontj","id":1619869,"node_id":"MDQ6VXNlcjE2MTk4Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1619869?v=4","gravatar_id":"","url":"https://api.github.com/users/jacksontj","html_url":"https://github.com/jacksontj","followers_url":"https://api.github.com/users/jacksontj/followers","following_url":"https://api.github.com/users/jacksontj/following{/other_user}","gists_url":"https://api.github.com/users/jacksontj/gists{/gist_id}","starred_url":"https://api.github.com/users/jacksontj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacksontj/subscriptions","organizations_url":"https://api.github.com/users/jacksontj/orgs","repos_url":"https://api.github.com/users/jacksontj/repos","events_url":"https://api.github.com/users/jacksontj/events{/privacy}","received_events_url":"https://api.github.com/users/jacksontj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-04-29T20:51:11Z","updated_at":"2019-04-30T17:30:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/prometheus/client_golang/pulls/562","html_url":"https://github.com/prometheus/client_golang/pull/562","diff_url":"https://github.com/prometheus/client_golang/pull/562.diff","patch_url":"https://github.com/prometheus/client_golang/pull/562.patch"},"body":"This adds `storage.Warnings` to the error return of Query and QueryRange. Unfortunately the client.Do() method interface makes this a bit difficult to implement. \r\n\r\nSo either we go down this path (where the specific error is a known type people should check for) *or* we need to change the Do() methods' interface to return a separate \"warning\" error."},"comment":{"url":"https://api.github.com/repos/prometheus/client_golang/issues/comments/488042563","html_url":"https://github.com/prometheus/client_golang/pull/562#issuecomment-488042563","issue_url":"https://api.github.com/repos/prometheus/client_golang/issues/562","id":488042563,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4ODA0MjU2Mw==","user":{"login":"jacksontj","id":1619869,"node_id":"MDQ6VXNlcjE2MTk4Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1619869?v=4","gravatar_id":"","url":"https://api.github.com/users/jacksontj","html_url":"https://github.com/jacksontj","followers_url":"https://api.github.com/users/jacksontj/followers","following_url":"https://api.github.com/users/jacksontj/following{/other_user}","gists_url":"https://api.github.com/users/jacksontj/gists{/gist_id}","starred_url":"https://api.github.com/users/jacksontj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacksontj/subscriptions","organizations_url":"https://api.github.com/users/jacksontj/orgs","repos_url":"https://api.github.com/users/jacksontj/repos","events_url":"https://api.github.com/users/jacksontj/events{/privacy}","received_events_url":"https://api.github.com/users/jacksontj/received_events","type":"User","site_admin":false},"created_at":"2019-04-30T17:30:10Z","updated_at":"2019-04-30T17:30:10Z","author_association":"CONTRIBUTOR","body":"@krasi-georgiev the main question is what the interface should be. Right now I'm wrapping the `Warnings` into a specific error type, which is different than the prom internals, but changes less of this client. Alternatively I can make the return of `Do()` add an additional return type of `Warnings` and have it be nil for everyone else -- either way works for me."}}
{"actor":{"display_login":"jacksontj"}}