{"action":"created","issue":{"url":"https://api.github.com/repos/yast/yast-storage-ng/issues/932","repository_url":"https://api.github.com/repos/yast/yast-storage-ng","labels_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/932/labels{/name}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/932/comments","events_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/932/events","html_url":"https://github.com/yast/yast-storage-ng/pull/932","id":458101251,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5Nzc2ODU2","number":932,"title":"Separate vg fixes","user":{"login":"ancorgs","id":3638289,"node_id":"MDQ6VXNlcjM2MzgyODk=","avatar_url":"https://avatars0.githubusercontent.com/u/3638289?v=4","gravatar_id":"","url":"https://api.github.com/users/ancorgs","html_url":"https://github.com/ancorgs","followers_url":"https://api.github.com/users/ancorgs/followers","following_url":"https://api.github.com/users/ancorgs/following{/other_user}","gists_url":"https://api.github.com/users/ancorgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ancorgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancorgs/subscriptions","organizations_url":"https://api.github.com/users/ancorgs/orgs","repos_url":"https://api.github.com/users/ancorgs/repos","events_url":"https://api.github.com/users/ancorgs/events{/privacy}","received_events_url":"https://api.github.com/users/ancorgs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-06-19T16:07:49Z","updated_at":"2019-06-19T16:27:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/932","html_url":"https://github.com/yast/yast-storage-ng/pull/932","diff_url":"https://github.com/yast/yast-storage-ng/pull/932.diff","patch_url":"https://github.com/yast/yast-storage-ng/pull/932.patch"},"body":"## Problem\r\n\r\nThe test coverage for #931 was intentionally simplistic since it makes little sense to test all the small details before getting feedback. Unfortunately that leaded to a bug been overlooked. The proposal managed to succeed when combining the \"system\" VG with some dedicated ones just by a matter of luck (and producing a clearly sub-optimal solution). It was in fact getting confused about some PVs.\r\n\r\n## Solution\r\n\r\nFix the PV detection to have into account the case of many planned VGs.\r\n"},"comment":{"url":"https://api.github.com/repos/yast/yast-storage-ng/issues/comments/503633323","html_url":"https://github.com/yast/yast-storage-ng/pull/932#issuecomment-503633323","issue_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/932","id":503633323,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMzYzMzMyMw==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2019-06-19T16:27:08Z","updated_at":"2019-06-19T16:27:08Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/24088279/badge)](https://coveralls.io/builds/24088279)\n\nCoverage increased (+0.0001%) to 97.53% when pulling **a797b0cec575e9c590ca90c0fc8384e24b71714b on ancorgs:separate_vg_fixes** into **d8774a486feae38b9ab0d84be227b39cc5ba44f5 on yast:master**.\n"}}
{"actor":{"display_login":"coveralls"}}