{"action":"closed","issue":{"url":"https://api.github.com/repos/Acumatica/Acuminator/issues/234","repository_url":"https://api.github.com/repos/Acumatica/Acuminator","labels_url":"https://api.github.com/repos/Acumatica/Acuminator/issues/234/labels{/name}","comments_url":"https://api.github.com/repos/Acumatica/Acuminator/issues/234/comments","events_url":"https://api.github.com/repos/Acumatica/Acuminator/issues/234/events","html_url":"https://github.com/Acumatica/Acuminator/issues/234","id":441440373,"node_id":"MDU6SXNzdWU0NDE0NDAzNzM=","number":234,"title":"Acuminator Nuget Package generates warnings","user":{"login":"ghigad","id":5835572,"node_id":"MDQ6VXNlcjU4MzU1NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/5835572?v=4","gravatar_id":"","url":"https://api.github.com/users/ghigad","html_url":"https://github.com/ghigad","followers_url":"https://api.github.com/users/ghigad/followers","following_url":"https://api.github.com/users/ghigad/following{/other_user}","gists_url":"https://api.github.com/users/ghigad/gists{/gist_id}","starred_url":"https://api.github.com/users/ghigad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghigad/subscriptions","organizations_url":"https://api.github.com/users/ghigad/orgs","repos_url":"https://api.github.com/users/ghigad/repos","events_url":"https://api.github.com/users/ghigad/events{/privacy}","received_events_url":"https://api.github.com/users/ghigad/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2019-05-07T20:50:22Z","updated_at":"2019-10-23T12:19:53Z","closed_at":"2019-10-23T12:19:53Z","author_association":"NONE","body":"**Issue description:**\r\nWe tried to install Acuminator's Nuget package (`Acuminator.Analyzers`) on the Visual Studio project used for our Extensions in order to get Acuminator validations on build.  When we do so, we have many warnings (~30) saying that analyzer assemblies depend on assemblies that could not be found.\r\n\r\nHere are a few examples of such warnings:\r\n\r\n> Code:  IDE1003\r\n>\r\n> Analyzer assembly 'C:\\Sources\\Acumatica\\Tests\\TestExtension\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\PX.Data.dll' depends on 'Serilog, Version=2.0.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10' but it was not found. Analyzers may not run correctly unless the missing assembly is added as an analyzer reference as well.\r\n>\r\n> Analyzer assembly 'C:\\Sources\\Acumatica\\Tests\\TestExtension\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\PX.Data.dll' depends on 'Microsoft.Data.Services.Client, Version=5.6.4.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' but it was not found. Analyzers may not run correctly unless the missing assembly is added as an analyzer reference as well.\r\n\r\nNotes:\r\n* My test project references a 2019R1U2 instance.\r\n* Tested on Acuminator.Analyzers, version 1.6.1\r\n* Using Visual Studio 2017 Professional (15.9.11)\r\n\r\n**Steps to reproduce:**\r\n* Add the `Acuminator.Analyzers` Nuget package to any standard Acumatica Extension Library project\r\n  \r\n**Expected result:**\r\n* The project should build without errors or warnings related to the analyzers...  It should only reports errors and warnings generated by Acuminator.\r\n\r\n**Actual result:**\r\n* Many warnings are present on the project when the `Acuminator.Analyzers` Nuget package is installed on an Extension Library.\r\n\r\n**Additional notes:**\r\n* I tried to comment `Analyzer` elements added to the project by the `install.ps1` script like shown below.  The warnings went away and I could get Acuminator errors and warnings properly.\r\n\r\n```\r\n<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n<Project ToolsVersion=\"15.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\r\n  <!-- ... -->\r\n  <ItemGroup>\r\n    <Analyzer Include=\"..\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\Acuminator.Analyzers.dll\" />\r\n    <Analyzer Include=\"..\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\Acuminator.Utilities.dll\" />\r\n    <!--\r\n    <Analyzer Include=\"..\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\CommonServiceLocator.dll\" />\r\n    <Analyzer Include=\"..\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\PX.BulkInsert.dll\" />\r\n    <Analyzer Include=\"..\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\PX.Common.dll\" />\r\n    <Analyzer Include=\"..\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\PX.Data.BQL.Fluent.dll\" />\r\n    <Analyzer Include=\"..\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\PX.Data.dll\" />\r\n    <Analyzer Include=\"..\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\PX.DbServices.dll\" />\r\n    <Analyzer Include=\"..\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\System.Runtime.InteropServices.RuntimeInformation.dll\" />\r\n    <Analyzer Include=\"..\\packages\\Acuminator.Analyzers.1.6.1\\analyzers\\dotnet\\cs\\System.ValueTuple.dll\" />\r\n    -->\r\n  </ItemGroup>\r\n  <Import Project=\"$(MSBuildToolsPath)\\Microsoft.CSharp.targets\" />\r\n</Project>\r\n```\r\n"}}
{"actor":{"display_login":"dropsonic"}}