{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/17040","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/17040/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/17040/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/17040/events","html_url":"https://github.com/xbmc/xbmc/pull/17040","id":538104837,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMzEzNjY1","number":17040,"title":"[cmake] add PKG_CONFIG_LIBDIR for addon build systems","user":{"login":"phunkyfish","id":4601187,"node_id":"MDQ6VXNlcjQ2MDExODc=","avatar_url":"https://avatars1.githubusercontent.com/u/4601187?v=4","gravatar_id":"","url":"https://api.github.com/users/phunkyfish","html_url":"https://github.com/phunkyfish","followers_url":"https://api.github.com/users/phunkyfish/followers","following_url":"https://api.github.com/users/phunkyfish/following{/other_user}","gists_url":"https://api.github.com/users/phunkyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/phunkyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phunkyfish/subscriptions","organizations_url":"https://api.github.com/users/phunkyfish/orgs","repos_url":"https://api.github.com/users/phunkyfish/repos","events_url":"https://api.github.com/users/phunkyfish/events{/privacy}","received_events_url":"https://api.github.com/users/phunkyfish/received_events","type":"User","site_admin":false},"labels":[{"id":1532718545,"node_id":"MDU6TGFiZWwxNTMyNzE4NTQ1","url":"https://api.github.com/repos/xbmc/xbmc/labels/Component:%20Build","name":"Component: Build","color":"f4b78d","default":false,"description":""},{"id":13087449,"node_id":"MDU6TGFiZWwxMzA4NzQ0OQ==","url":"https://api.github.com/repos/xbmc/xbmc/labels/Type:%20Improvement","name":"Type: Improvement","color":"0b02e1","default":false,"description":"non-breaking change which improves existing functionality"},{"id":1021159604,"node_id":"MDU6TGFiZWwxMDIxMTU5NjA0","url":"https://api.github.com/repos/xbmc/xbmc/labels/v19%20Matrix","name":"v19 Matrix","color":"fbca04","default":false,"description":""}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2019-12-15T20:57:10Z","updated_at":"2019-12-19T16:50:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/17040","html_url":"https://github.com/xbmc/xbmc/pull/17040","diff_url":"https://github.com/xbmc/xbmc/pull/17040.diff","patch_url":"https://github.com/xbmc/xbmc/pull/17040.patch"},"body":"## Description\r\n<!--- Provide a general summary of your change in the Pull Request title above -->\r\n<!--- Describe your change in detail here -->\r\n\r\nCopy any Cmake scripts from the addon dependency directory to the source directory.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here -->\r\n\r\nFor addon depends CMakeLists.txt is copied to the source dir of dependency but not any scripts. This is useful if a wrapper script is required or a FindXXX() script.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your change -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc -->\r\n\r\nOSX, on new inputstream addon under developement: https://github.com/phunkyfish/inputstream.ffmpegarchive\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [ ] **Bug fix** (non-breaking change which fixes an issue)\r\n- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)\r\n- [X] **Improvement** (non-breaking change which improves existing functionality)\r\n- [ ] **New feature** (non-breaking change which adds functionality)\r\n- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)\r\n- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)\r\n- [ ] **None of the above** (please explain below)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `X` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [X] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/567570564","html_url":"https://github.com/xbmc/xbmc/pull/17040#issuecomment-567570564","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/17040","id":567570564,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NzU3MDU2NA==","user":{"login":"phunkyfish","id":4601187,"node_id":"MDQ6VXNlcjQ2MDExODc=","avatar_url":"https://avatars1.githubusercontent.com/u/4601187?v=4","gravatar_id":"","url":"https://api.github.com/users/phunkyfish","html_url":"https://github.com/phunkyfish","followers_url":"https://api.github.com/users/phunkyfish/followers","following_url":"https://api.github.com/users/phunkyfish/following{/other_user}","gists_url":"https://api.github.com/users/phunkyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/phunkyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phunkyfish/subscriptions","organizations_url":"https://api.github.com/users/phunkyfish/orgs","repos_url":"https://api.github.com/users/phunkyfish/repos","events_url":"https://api.github.com/users/phunkyfish/events{/privacy}","received_events_url":"https://api.github.com/users/phunkyfish/received_events","type":"User","site_admin":false},"created_at":"2019-12-19T16:50:25Z","updated_at":"2019-12-19T16:50:25Z","author_association":"CONTRIBUTOR","body":"@Rechi @wsnipex \r\n\r\nAre you ok with this going in? I would like to start working on adding the new binary addon into Jenkins etc but need my first platform to build in CI to get started which requires this change."}}
{"actor":{"display_login":"phunkyfish"}}