{"action":"created","issue":{"url":"https://api.github.com/repos/robolectric/robolectric-bazel/issues/5","repository_url":"https://api.github.com/repos/robolectric/robolectric-bazel","labels_url":"https://api.github.com/repos/robolectric/robolectric-bazel/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/robolectric/robolectric-bazel/issues/5/comments","events_url":"https://api.github.com/repos/robolectric/robolectric-bazel/issues/5/events","html_url":"https://github.com/robolectric/robolectric-bazel/pull/5","id":425236074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0MzgwMzg5","number":5,"title":"Replace generate_workspace and maven_jar with rules_jvm_external","user":{"login":"jin","id":347918,"node_id":"MDQ6VXNlcjM0NzkxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/347918?v=4","gravatar_id":"","url":"https://api.github.com/users/jin","html_url":"https://github.com/jin","followers_url":"https://api.github.com/users/jin/followers","following_url":"https://api.github.com/users/jin/following{/other_user}","gists_url":"https://api.github.com/users/jin/gists{/gist_id}","starred_url":"https://api.github.com/users/jin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jin/subscriptions","organizations_url":"https://api.github.com/users/jin/orgs","repos_url":"https://api.github.com/users/jin/repos","events_url":"https://api.github.com/users/jin/events{/privacy}","received_events_url":"https://api.github.com/users/jin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-03-26T05:39:48Z","updated_at":"2019-03-26T05:40:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/robolectric/robolectric-bazel/pulls/5","html_url":"https://github.com/robolectric/robolectric-bazel/pull/5","diff_url":"https://github.com/robolectric/robolectric-bazel/pull/5.diff","patch_url":"https://github.com/robolectric/robolectric-bazel/pull/5.patch"},"body":"Fixes https://github.com/robolectric/robolectric/issues/4798\r\n\r\nThis allows users to use any version of `org.robolectric:robolectric`, along with the other robolectric deps like the Shadow framework. We pull `org.robolectric:robolectric` jars out from this repository, and let users declare it in `maven_install` themselves.\r\n\r\nHowever, because `rules_jvm_external` insists on only one version of an artifact in the transitive closure, it does not work with multiple `android-all` jars.  For this reason (and to generate the robolectric-deps.properties file, the android-all jars are still tracked by this repository. This also means users can use any targetSdkVersion and expect Robolectric to still work, unless they are using a bleeding edge android-all jar that hasn't been added to this repository.\r\n\r\nFor fetching, instead of using the deprecated `maven_jar`, I switched it to use `jvm_maven_import_external`, which supports sha256 repository caching by Bazel. This keeps it simple to add a new android-all jar into the .bzl file.\r\n"},"comment":{"url":"https://api.github.com/repos/robolectric/robolectric-bazel/issues/comments/476483209","html_url":"https://github.com/robolectric/robolectric-bazel/pull/5#issuecomment-476483209","issue_url":"https://api.github.com/repos/robolectric/robolectric-bazel/issues/5","id":476483209,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3NjQ4MzIwOQ==","user":{"login":"jin","id":347918,"node_id":"MDQ6VXNlcjM0NzkxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/347918?v=4","gravatar_id":"","url":"https://api.github.com/users/jin","html_url":"https://github.com/jin","followers_url":"https://api.github.com/users/jin/followers","following_url":"https://api.github.com/users/jin/following{/other_user}","gists_url":"https://api.github.com/users/jin/gists{/gist_id}","starred_url":"https://api.github.com/users/jin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jin/subscriptions","organizations_url":"https://api.github.com/users/jin/orgs","repos_url":"https://api.github.com/users/jin/repos","events_url":"https://api.github.com/users/jin/events{/privacy}","received_events_url":"https://api.github.com/users/jin/received_events","type":"User","site_admin":false},"created_at":"2019-03-26T05:40:33Z","updated_at":"2019-03-26T05:40:33Z","author_association":"NONE","body":"cc @brettchabot "}}
{"actor":{"display_login":"jin"}}