{"action":"created","comment":{"url":"https://api.github.com/repos/firefox-devtools/profiler/pulls/comments/283365536","pull_request_review_id":236701756,"id":283365536,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzM2NTUzNg==","diff_hunk":"@@ -165,20 +164,24 @@ class NetworkChart extends React.PureComponent<Props> {\n  * Wrap the component in the WithSize higher order component, as well as the redux\n  * connected component.\n  */\n-export default explicitConnect<{||}, StateProps, DispatchProps>({\n-  mapStateToProps: state => {\n-    return {\n-      markerIndexes: selectedThreadSelectors.getSearchFilteredNetworkMarkerIndexes(\n-        state\n-      ),\n-      getMarker: selectedThreadSelectors.getMarkerGetter(state),\n-      timeRange: getPreviewSelectionRange(state),\n-      disableOverscan: getPreviewSelection(state).isModifying,\n-      threadIndex: getSelectedThreadIndex(state),\n-    };\n-  },\n-  component: withSize<Props>(NetworkChart),\n-});\n+const ConnectedComponent = explicitConnect<OwnProps, StateProps, DispatchProps>(\n+  {\n+    mapStateToProps: state => {\n+      return {\n+        markerIndexes: selectedThreadSelectors.getSearchFilteredNetworkMarkerIndexes(\n+          state\n+        ),\n+        getMarker: selectedThreadSelectors.getMarkerGetter(state),\n+        timeRange: getPreviewSelectionRange(state),\n+        disableOverscan: getPreviewSelection(state).isModifying,\n+        threadIndex: getSelectedThreadIndex(state),\n+      };\n+    },\n+    component: NetworkChart,\n+  }\n+);\n+\n+export default withSize<OwnProps>(ConnectedComponent);","path":"src/components/network-chart/index.js","position":124,"original_position":49,"commit_id":"41372e82bb09645bdf5d748d7dbe9b4adbc068c0","original_commit_id":"b9c6fe8e5b1c37acca0bb39bc3682f30f1f7e698","user":{"login":"julienw","id":454175,"node_id":"MDQ6VXNlcjQ1NDE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"This reverses how withSize is applied.","created_at":"2019-05-13T14:11:18Z","updated_at":"2019-05-13T14:11:19Z","html_url":"https://github.com/firefox-devtools/profiler/pull/2009#discussion_r283365536","pull_request_url":"https://api.github.com/repos/firefox-devtools/profiler/pulls/2009","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/firefox-devtools/profiler/pulls/comments/283365536"},"html":{"href":"https://github.com/firefox-devtools/profiler/pull/2009#discussion_r283365536"},"pull_request":{"href":"https://api.github.com/repos/firefox-devtools/profiler/pulls/2009"}}},"pull_request":{"url":"https://api.github.com/repos/firefox-devtools/profiler/pulls/2009","id":278291205,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4MjkxMjA1","html_url":"https://github.com/firefox-devtools/profiler/pull/2009","diff_url":"https://github.com/firefox-devtools/profiler/pull/2009.diff","patch_url":"https://github.com/firefox-devtools/profiler/pull/2009.patch","issue_url":"https://api.github.com/repos/firefox-devtools/profiler/issues/2009","number":2009,"state":"open","locked":false,"title":"Handle preconnect phases properly","user":{"login":"julienw","id":454175,"node_id":"MDQ6VXNlcjQ1NDE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"Fixes #1965\r\n\r\nIn some cases (still a bit unclear), we can have the domain lookup and connection properties have timestamp that happen before the marker's start time. As I understand, this happens when Firefox decides to trigger a preconnect at a page load, when it thinks we'll have this connection happen. I couldn't really reproduce it reliably, but I could reproduce at least once.\r\n\r\nSee especially these links, and hover:\r\n[before](https://profiler.firefox.com/public/8b2e92d6b9d9a506737fbed3d0fa5424e3b34a0c/network-chart/?globalTrackOrder=0-1-2-3-4&hiddenGlobalTracks=1-2-3&localTrackOrderByPid=3164-1-2-0~12671-0~12665-0~12605-0~12558-0-1~&networkSearch=sdk&range=10.7576_11.6252&thread=0&v=3)\r\n[after](https://deploy-preview-2009--perf-html.netlify.com/public/8b2e92d6b9d9a506737fbed3d0fa5424e3b34a0c/network-chart/?globalTrackOrder=0-1-2-3-4&hiddenGlobalTracks=1-2-3&localTrackOrderByPid=3164-1-2-0~12671-0~12665-0~12605-0~12558-0-1~&networkSearch=sdk&range=10.7576_11.6252&thread=0&v=3)\r\n\r\nIt should be easier to look at the commits individually.","created_at":"2019-05-13T14:09:01Z","updated_at":"2019-05-13T14:11:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d79633a501a5b7180858cedd9ed8cdbff5a8273","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/firefox-devtools/profiler/pulls/2009/commits","review_comments_url":"https://api.github.com/repos/firefox-devtools/profiler/pulls/2009/comments","review_comment_url":"https://api.github.com/repos/firefox-devtools/profiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firefox-devtools/profiler/issues/2009/comments","statuses_url":"https://api.github.com/repos/firefox-devtools/profiler/statuses/41372e82bb09645bdf5d748d7dbe9b4adbc068c0","head":{"label":"julienw:handle-preconnect-phases","ref":"handle-preconnect-phases","sha":"41372e82bb09645bdf5d748d7dbe9b4adbc068c0","user":{"login":"julienw","id":454175,"node_id":"MDQ6VXNlcjQ1NDE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"repo":{"id":85606366,"node_id":"MDEwOlJlcG9zaXRvcnk4NTYwNjM2Ng==","name":"perf.html","full_name":"julienw/perf.html","private":false,"owner":{"login":"julienw","id":454175,"node_id":"MDQ6VXNlcjQ1NDE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/julienw/perf.html","description":"Firefox Performance tools for the web, by the web 🛥","fork":true,"url":"https://api.github.com/repos/julienw/perf.html","forks_url":"https://api.github.com/repos/julienw/perf.html/forks","keys_url":"https://api.github.com/repos/julienw/perf.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienw/perf.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienw/perf.html/teams","hooks_url":"https://api.github.com/repos/julienw/perf.html/hooks","issue_events_url":"https://api.github.com/repos/julienw/perf.html/issues/events{/number}","events_url":"https://api.github.com/repos/julienw/perf.html/events","assignees_url":"https://api.github.com/repos/julienw/perf.html/assignees{/user}","branches_url":"https://api.github.com/repos/julienw/perf.html/branches{/branch}","tags_url":"https://api.github.com/repos/julienw/perf.html/tags","blobs_url":"https://api.github.com/repos/julienw/perf.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienw/perf.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienw/perf.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienw/perf.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienw/perf.html/statuses/{sha}","languages_url":"https://api.github.com/repos/julienw/perf.html/languages","stargazers_url":"https://api.github.com/repos/julienw/perf.html/stargazers","contributors_url":"https://api.github.com/repos/julienw/perf.html/contributors","subscribers_url":"https://api.github.com/repos/julienw/perf.html/subscribers","subscription_url":"https://api.github.com/repos/julienw/perf.html/subscription","commits_url":"https://api.github.com/repos/julienw/perf.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienw/perf.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienw/perf.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienw/perf.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/julienw/perf.html/contents/{+path}","compare_url":"https://api.github.com/repos/julienw/perf.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienw/perf.html/merges","archive_url":"https://api.github.com/repos/julienw/perf.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienw/perf.html/downloads","issues_url":"https://api.github.com/repos/julienw/perf.html/issues{/number}","pulls_url":"https://api.github.com/repos/julienw/perf.html/pulls{/number}","milestones_url":"https://api.github.com/repos/julienw/perf.html/milestones{/number}","notifications_url":"https://api.github.com/repos/julienw/perf.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienw/perf.html/labels{/name}","releases_url":"https://api.github.com/repos/julienw/perf.html/releases{/id}","deployments_url":"https://api.github.com/repos/julienw/perf.html/deployments","created_at":"2017-03-20T17:30:11Z","updated_at":"2018-04-19T15:14:54Z","pushed_at":"2019-05-13T14:03:44Z","git_url":"git://github.com/julienw/perf.html.git","ssh_url":"git@github.com:julienw/perf.html.git","clone_url":"https://github.com/julienw/perf.html.git","svn_url":"https://github.com/julienw/perf.html","homepage":"https://perf-html.io/","size":21057,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firefox-devtools:master","ref":"master","sha":"2dda7322d1982584e227235a99ea5fffd9f2018f","user":{"login":"firefox-devtools","id":19979421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc5NDIx","avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/firefox-devtools","html_url":"https://github.com/firefox-devtools","followers_url":"https://api.github.com/users/firefox-devtools/followers","following_url":"https://api.github.com/users/firefox-devtools/following{/other_user}","gists_url":"https://api.github.com/users/firefox-devtools/gists{/gist_id}","starred_url":"https://api.github.com/users/firefox-devtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firefox-devtools/subscriptions","organizations_url":"https://api.github.com/users/firefox-devtools/orgs","repos_url":"https://api.github.com/users/firefox-devtools/repos","events_url":"https://api.github.com/users/firefox-devtools/events{/privacy}","received_events_url":"https://api.github.com/users/firefox-devtools/received_events","type":"Organization","site_admin":false},"repo":{"id":3607308,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA3MzA4","name":"profiler","full_name":"firefox-devtools/profiler","private":false,"owner":{"login":"firefox-devtools","id":19979421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc5NDIx","avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/firefox-devtools","html_url":"https://github.com/firefox-devtools","followers_url":"https://api.github.com/users/firefox-devtools/followers","following_url":"https://api.github.com/users/firefox-devtools/following{/other_user}","gists_url":"https://api.github.com/users/firefox-devtools/gists{/gist_id}","starred_url":"https://api.github.com/users/firefox-devtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firefox-devtools/subscriptions","organizations_url":"https://api.github.com/users/firefox-devtools/orgs","repos_url":"https://api.github.com/users/firefox-devtools/repos","events_url":"https://api.github.com/users/firefox-devtools/events{/privacy}","received_events_url":"https://api.github.com/users/firefox-devtools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firefox-devtools/profiler","description":"Firefox Profiler — Web app for Firefox performance analysis","fork":false,"url":"https://api.github.com/repos/firefox-devtools/profiler","forks_url":"https://api.github.com/repos/firefox-devtools/profiler/forks","keys_url":"https://api.github.com/repos/firefox-devtools/profiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firefox-devtools/profiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firefox-devtools/profiler/teams","hooks_url":"https://api.github.com/repos/firefox-devtools/profiler/hooks","issue_events_url":"https://api.github.com/repos/firefox-devtools/profiler/issues/events{/number}","events_url":"https://api.github.com/repos/firefox-devtools/profiler/events","assignees_url":"https://api.github.com/repos/firefox-devtools/profiler/assignees{/user}","branches_url":"https://api.github.com/repos/firefox-devtools/profiler/branches{/branch}","tags_url":"https://api.github.com/repos/firefox-devtools/profiler/tags","blobs_url":"https://api.github.com/repos/firefox-devtools/profiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firefox-devtools/profiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firefox-devtools/profiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/firefox-devtools/profiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firefox-devtools/profiler/statuses/{sha}","languages_url":"https://api.github.com/repos/firefox-devtools/profiler/languages","stargazers_url":"https://api.github.com/repos/firefox-devtools/profiler/stargazers","contributors_url":"https://api.github.com/repos/firefox-devtools/profiler/contributors","subscribers_url":"https://api.github.com/repos/firefox-devtools/profiler/subscribers","subscription_url":"https://api.github.com/repos/firefox-devtools/profiler/subscription","commits_url":"https://api.github.com/repos/firefox-devtools/profiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/firefox-devtools/profiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/firefox-devtools/profiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/firefox-devtools/profiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/firefox-devtools/profiler/contents/{+path}","compare_url":"https://api.github.com/repos/firefox-devtools/profiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firefox-devtools/profiler/merges","archive_url":"https://api.github.com/repos/firefox-devtools/profiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firefox-devtools/profiler/downloads","issues_url":"https://api.github.com/repos/firefox-devtools/profiler/issues{/number}","pulls_url":"https://api.github.com/repos/firefox-devtools/profiler/pulls{/number}","milestones_url":"https://api.github.com/repos/firefox-devtools/profiler/milestones{/number}","notifications_url":"https://api.github.com/repos/firefox-devtools/profiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firefox-devtools/profiler/labels{/name}","releases_url":"https://api.github.com/repos/firefox-devtools/profiler/releases{/id}","deployments_url":"https://api.github.com/repos/firefox-devtools/profiler/deployments","created_at":"2012-03-02T23:55:22Z","updated_at":"2019-05-13T14:07:46Z","pushed_at":"2019-05-13T14:09:02Z","git_url":"git://github.com/firefox-devtools/profiler.git","ssh_url":"git@github.com:firefox-devtools/profiler.git","clone_url":"https://github.com/firefox-devtools/profiler.git","svn_url":"https://github.com/firefox-devtools/profiler","homepage":"https://profiler.firefox.com","size":20543,"stargazers_count":267,"watchers_count":267,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":373,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":118,"open_issues":373,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firefox-devtools/profiler/pulls/2009"},"html":{"href":"https://github.com/firefox-devtools/profiler/pull/2009"},"issue":{"href":"https://api.github.com/repos/firefox-devtools/profiler/issues/2009"},"comments":{"href":"https://api.github.com/repos/firefox-devtools/profiler/issues/2009/comments"},"review_comments":{"href":"https://api.github.com/repos/firefox-devtools/profiler/pulls/2009/comments"},"review_comment":{"href":"https://api.github.com/repos/firefox-devtools/profiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firefox-devtools/profiler/pulls/2009/commits"},"statuses":{"href":"https://api.github.com/repos/firefox-devtools/profiler/statuses/41372e82bb09645bdf5d748d7dbe9b4adbc068c0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"julienw"}}