{"push_id":4280298941,"size":1,"distinct_size":1,"ref":"refs/heads/feat/extension-host-reloading","head":"dc74eca358a06e07d54a828d964b9da1bfa12bcf","before":"2d2b1c64f5e8548950104cf18d0154aa23c553fd","commits":[{"sha":"dc74eca358a06e07d54a828d964b9da1bfa12bcf","author":{"name":"Connor Peet","email":"3777601fdba3fe60e662fe93ad715e9272ab7c4b@peet.io"},"message":"debug: reload the extension host regardless of `supportsRestartRequest`\n\nIn PWA we set the flag `supportsRestartRequest`, since internally we\nhandle rebooting Node.js and Chrome targets. (The previous Node.js\nadapter didn't set this flag.) This gets set on the adapter level,\nbefore we know what kind of launch/attach request we might get. There\ndoes not appear to be a correct way to restart the attached Code\ninstance from the adapter, however; we need invoke to the `.reload()`\nmethod on the extension host, which as far as I know we can't access and\nis only referenced here. In PWA I was trying to send a `terminate`\ncommand with `{ restart: true }` in its body, but for adapters with\n`supportsRestartRequest` this simply loops back to a `restart()` call.\n\nThis PR just moves the extension host check prior to\n`supportsRestartRequest`. This allows PWA to restart correctly. It\nshouldn't affect any third party extensions, since\n`isExtensionHostDebugging` checks whether the debug type is\n`extensionHost`, which is a debug type our 1st\nparty Node adapter 'owns'.\n\nA more generic solution might be a way on the protocol for the adapter\nto signal that, for whatever reason, it's unable to restart the current\nsession and would like the frontend to terminate and reboot it.\n(However, I'm unsure if this would be useful outside the slightly magic\nextension host scenario, since most adapters can probably handle it\nbehind the scenes like PWA does for Node.js targets today.)","distinct":true,"url":"https://api.github.com/repos/microsoft/vscode/commits/dc74eca358a06e07d54a828d964b9da1bfa12bcf"}]}
{"actor":{"display_login":"connor4312"}}