{"action":"created","issue":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/16686","repository_url":"https://api.github.com/repos/gatsbyjs/gatsby","labels_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/16686/labels{/name}","comments_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/16686/comments","events_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/16686/events","html_url":"https://github.com/gatsbyjs/gatsby/pull/16686","id":481691077,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4MTQyMTM1","number":16686,"title":"feat(gatsby): Move webpackCompilationHash into app-data.json","user":{"login":"afenton90","id":8963736,"node_id":"MDQ6VXNlcjg5NjM3MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/8963736?v=4","gravatar_id":"","url":"https://api.github.com/users/afenton90","html_url":"https://github.com/afenton90","followers_url":"https://api.github.com/users/afenton90/followers","following_url":"https://api.github.com/users/afenton90/following{/other_user}","gists_url":"https://api.github.com/users/afenton90/gists{/gist_id}","starred_url":"https://api.github.com/users/afenton90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afenton90/subscriptions","organizations_url":"https://api.github.com/users/afenton90/orgs","repos_url":"https://api.github.com/users/afenton90/repos","events_url":"https://api.github.com/users/afenton90/events{/privacy}","received_events_url":"https://api.github.com/users/afenton90/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sidharthachatterjee","id":7701981,"node_id":"MDQ6VXNlcjc3MDE5ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/7701981?v=4","gravatar_id":"","url":"https://api.github.com/users/sidharthachatterjee","html_url":"https://github.com/sidharthachatterjee","followers_url":"https://api.github.com/users/sidharthachatterjee/followers","following_url":"https://api.github.com/users/sidharthachatterjee/following{/other_user}","gists_url":"https://api.github.com/users/sidharthachatterjee/gists{/gist_id}","starred_url":"https://api.github.com/users/sidharthachatterjee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidharthachatterjee/subscriptions","organizations_url":"https://api.github.com/users/sidharthachatterjee/orgs","repos_url":"https://api.github.com/users/sidharthachatterjee/repos","events_url":"https://api.github.com/users/sidharthachatterjee/events{/privacy}","received_events_url":"https://api.github.com/users/sidharthachatterjee/received_events","type":"User","site_admin":false},"assignees":[{"login":"sidharthachatterjee","id":7701981,"node_id":"MDQ6VXNlcjc3MDE5ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/7701981?v=4","gravatar_id":"","url":"https://api.github.com/users/sidharthachatterjee","html_url":"https://github.com/sidharthachatterjee","followers_url":"https://api.github.com/users/sidharthachatterjee/followers","following_url":"https://api.github.com/users/sidharthachatterjee/following{/other_user}","gists_url":"https://api.github.com/users/sidharthachatterjee/gists{/gist_id}","starred_url":"https://api.github.com/users/sidharthachatterjee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidharthachatterjee/subscriptions","organizations_url":"https://api.github.com/users/sidharthachatterjee/orgs","repos_url":"https://api.github.com/users/sidharthachatterjee/repos","events_url":"https://api.github.com/users/sidharthachatterjee/events{/privacy}","received_events_url":"https://api.github.com/users/sidharthachatterjee/received_events","type":"User","site_admin":false}],"milestone":null,"comments":32,"created_at":"2019-08-16T16:37:15Z","updated_at":"2019-10-18T08:27:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/pulls/16686","html_url":"https://github.com/gatsbyjs/gatsby/pull/16686","diff_url":"https://github.com/gatsbyjs/gatsby/pull/16686.diff","patch_url":"https://github.com/gatsbyjs/gatsby/pull/16686.patch"},"body":"<!--\r\n  Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or\r\n  ask in this Pull Request and a Gatsby maintainer will be happy to help :)\r\n-->\r\n\r\n## Description\r\n\r\n`webpackCompilationHash` is currently used in `page-data.json` & HTML files to decipher whether the Gatsby app running in the browser is at the same version as the code on the server/CDN.\r\n\r\nAt the moment this hash changes if anything within `./src` has changed between builds. Meaning a 404 file could be changed which would result in all `page-data.json` & HTML files being updated even if they have not changed between builds.\r\n\r\nThis causes some issues when using some cloud CDN providers as described in this issue #15872 .\r\n\r\nThis PR now moves the `webpackCompilationHash` to it's own `app-data.json` which is loaded at the same time as page-data in order to reduce the blast radius of changes in the build output.\r\nThis allows for diffs to take place between what is hosted in a CDN and what is about to be pushed to a CDN.\r\n\r\n## Related Issues\r\n\r\nclose #15872 \r\n"},"comment":{"url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/comments/543596132","html_url":"https://github.com/gatsbyjs/gatsby/pull/16686#issuecomment-543596132","issue_url":"https://api.github.com/repos/gatsbyjs/gatsby/issues/16686","id":543596132,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MzU5NjEzMg==","user":{"login":"afenton90","id":8963736,"node_id":"MDQ6VXNlcjg5NjM3MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/8963736?v=4","gravatar_id":"","url":"https://api.github.com/users/afenton90","html_url":"https://github.com/afenton90","followers_url":"https://api.github.com/users/afenton90/followers","following_url":"https://api.github.com/users/afenton90/following{/other_user}","gists_url":"https://api.github.com/users/afenton90/gists{/gist_id}","starred_url":"https://api.github.com/users/afenton90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afenton90/subscriptions","organizations_url":"https://api.github.com/users/afenton90/orgs","repos_url":"https://api.github.com/users/afenton90/repos","events_url":"https://api.github.com/users/afenton90/events{/privacy}","received_events_url":"https://api.github.com/users/afenton90/received_events","type":"User","site_admin":false},"created_at":"2019-10-18T08:27:13Z","updated_at":"2019-10-18T08:27:13Z","author_association":"NONE","body":"@tmilewski thanks for taking the time to try this PR out.\r\nI've just tried doing a fresh clone of my reactjs.org clone and running `develop` & `build` but afraid I don't see this error.\r\n\r\nNothing in this PR has touched any `Provider` code, but I'm aware this doesn't resolve your issue.\r\nHappy to jump on a call though to ensure there is no issue specifically from this PR."}}
{"actor":{"display_login":"afenton90"}}