{"action":"created","comment":{"url":"https://api.github.com/repos/trustwallet/wallet-core/pulls/comments/354618423","pull_request_review_id":327940867,"id":354618423,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDYxODQyMw==","diff_hunk":"@@ -49,6 +49,10 @@ TWData *_Nonnull TWHDWalletSeed(struct TWHDWallet *_Nonnull wallet);\n TW_EXPORT_PROPERTY\n TWString *_Nonnull TWHDWalletMnemonic(struct TWHDWallet *_Nonnull wallet);\n \n+/// Returns master key.\n+TW_EXPORT_METHOD\n+struct TWPrivateKey *_Nonnull TWHDWalletGetMasterKey(struct TWHDWallet *_Nonnull wallet, enum TWCurve curve);","path":"include/TrustWalletCore/TWHDWallet.h","position":6,"original_position":6,"commit_id":"725fe6d24e36bace89f755f513a290f80c59a623","original_commit_id":"725fe6d24e36bace89f755f513a290f80c59a623","user":{"login":"hewigovens","id":360470,"node_id":"MDQ6VXNlcjM2MDQ3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/360470?v=4","gravatar_id":"","url":"https://api.github.com/users/hewigovens","html_url":"https://github.com/hewigovens","followers_url":"https://api.github.com/users/hewigovens/followers","following_url":"https://api.github.com/users/hewigovens/following{/other_user}","gists_url":"https://api.github.com/users/hewigovens/gists{/gist_id}","starred_url":"https://api.github.com/users/hewigovens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hewigovens/subscriptions","organizations_url":"https://api.github.com/users/hewigovens/orgs","repos_url":"https://api.github.com/users/hewigovens/repos","events_url":"https://api.github.com/users/hewigovens/events{/privacy}","received_events_url":"https://api.github.com/users/hewigovens/received_events","type":"User","site_admin":false},"body":"see: https://github.com/trustwallet/wallet-core/pull/754#discussion_r354062662","created_at":"2019-12-06T00:40:31Z","updated_at":"2019-12-06T00:40:31Z","html_url":"https://github.com/trustwallet/wallet-core/pull/754#discussion_r354618423","pull_request_url":"https://api.github.com/repos/trustwallet/wallet-core/pulls/754","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/trustwallet/wallet-core/pulls/comments/354618423"},"html":{"href":"https://github.com/trustwallet/wallet-core/pull/754#discussion_r354618423"},"pull_request":{"href":"https://api.github.com/repos/trustwallet/wallet-core/pulls/754"}},"in_reply_to_id":354614868},"pull_request":{"url":"https://api.github.com/repos/trustwallet/wallet-core/pulls/754","id":348357836,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4MzU3ODM2","html_url":"https://github.com/trustwallet/wallet-core/pull/754","diff_url":"https://github.com/trustwallet/wallet-core/pull/754.diff","patch_url":"https://github.com/trustwallet/wallet-core/pull/754.patch","issue_url":"https://api.github.com/repos/trustwallet/wallet-core/issues/754","number":754,"state":"open","locked":false,"title":"Add Kusama / Polkadot address","user":{"login":"hewigovens","id":360470,"node_id":"MDQ6VXNlcjM2MDQ3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/360470?v=4","gravatar_id":"","url":"https://api.github.com/users/hewigovens","html_url":"https://github.com/hewigovens","followers_url":"https://api.github.com/users/hewigovens/followers","following_url":"https://api.github.com/users/hewigovens/following{/other_user}","gists_url":"https://api.github.com/users/hewigovens/gists{/gist_id}","starred_url":"https://api.github.com/users/hewigovens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hewigovens/subscriptions","organizations_url":"https://api.github.com/users/hewigovens/orgs","repos_url":"https://api.github.com/users/hewigovens/repos","events_url":"https://api.github.com/users/hewigovens/events{/privacy}","received_events_url":"https://api.github.com/users/hewigovens/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nDecide to create separated pull request, don't want to always rebase / merge master :( `sr25519` is not mandatory, we will keep using `ed25519` here\r\nNote the derivation path and its address is not compatible with `subkey`\r\n\r\n## Testing instructions\r\n\r\nRun UT\r\n\r\n## Types of changes\r\n\r\nNew feature (non-breaking change which adds functionality)\r\n\r\n## Checklist\r\n\r\n- [x] Prefix PR title with `[WIP]` if necessary.\r\n- [x] Add tests to cover changes as needed.\r\n- [x] Update documentation as needed.\r\n","created_at":"2019-12-03T14:22:33Z","updated_at":"2019-12-06T00:40:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12bb40ee10be8fc46751cac4600b01d72c3c596e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/trustwallet/wallet-core/pulls/754/commits","review_comments_url":"https://api.github.com/repos/trustwallet/wallet-core/pulls/754/comments","review_comment_url":"https://api.github.com/repos/trustwallet/wallet-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trustwallet/wallet-core/issues/754/comments","statuses_url":"https://api.github.com/repos/trustwallet/wallet-core/statuses/725fe6d24e36bace89f755f513a290f80c59a623","head":{"label":"trustwallet:xt/kusama-address","ref":"xt/kusama-address","sha":"725fe6d24e36bace89f755f513a290f80c59a623","user":{"login":"trustwallet","id":32179889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTc5ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/trustwallet","html_url":"https://github.com/trustwallet","followers_url":"https://api.github.com/users/trustwallet/followers","following_url":"https://api.github.com/users/trustwallet/following{/other_user}","gists_url":"https://api.github.com/users/trustwallet/gists{/gist_id}","starred_url":"https://api.github.com/users/trustwallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustwallet/subscriptions","organizations_url":"https://api.github.com/users/trustwallet/orgs","repos_url":"https://api.github.com/users/trustwallet/repos","events_url":"https://api.github.com/users/trustwallet/events{/privacy}","received_events_url":"https://api.github.com/users/trustwallet/received_events","type":"Organization","site_admin":false},"repo":{"id":170738310,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA3MzgzMTA=","name":"wallet-core","full_name":"trustwallet/wallet-core","private":false,"owner":{"login":"trustwallet","id":32179889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTc5ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/trustwallet","html_url":"https://github.com/trustwallet","followers_url":"https://api.github.com/users/trustwallet/followers","following_url":"https://api.github.com/users/trustwallet/following{/other_user}","gists_url":"https://api.github.com/users/trustwallet/gists{/gist_id}","starred_url":"https://api.github.com/users/trustwallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustwallet/subscriptions","organizations_url":"https://api.github.com/users/trustwallet/orgs","repos_url":"https://api.github.com/users/trustwallet/repos","events_url":"https://api.github.com/users/trustwallet/events{/privacy}","received_events_url":"https://api.github.com/users/trustwallet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/trustwallet/wallet-core","description":"Cross-platform, cross-blockchain wallet library.","fork":false,"url":"https://api.github.com/repos/trustwallet/wallet-core","forks_url":"https://api.github.com/repos/trustwallet/wallet-core/forks","keys_url":"https://api.github.com/repos/trustwallet/wallet-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trustwallet/wallet-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trustwallet/wallet-core/teams","hooks_url":"https://api.github.com/repos/trustwallet/wallet-core/hooks","issue_events_url":"https://api.github.com/repos/trustwallet/wallet-core/issues/events{/number}","events_url":"https://api.github.com/repos/trustwallet/wallet-core/events","assignees_url":"https://api.github.com/repos/trustwallet/wallet-core/assignees{/user}","branches_url":"https://api.github.com/repos/trustwallet/wallet-core/branches{/branch}","tags_url":"https://api.github.com/repos/trustwallet/wallet-core/tags","blobs_url":"https://api.github.com/repos/trustwallet/wallet-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trustwallet/wallet-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trustwallet/wallet-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/trustwallet/wallet-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trustwallet/wallet-core/statuses/{sha}","languages_url":"https://api.github.com/repos/trustwallet/wallet-core/languages","stargazers_url":"https://api.github.com/repos/trustwallet/wallet-core/stargazers","contributors_url":"https://api.github.com/repos/trustwallet/wallet-core/contributors","subscribers_url":"https://api.github.com/repos/trustwallet/wallet-core/subscribers","subscription_url":"https://api.github.com/repos/trustwallet/wallet-core/subscription","commits_url":"https://api.github.com/repos/trustwallet/wallet-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/trustwallet/wallet-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/trustwallet/wallet-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/trustwallet/wallet-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/trustwallet/wallet-core/contents/{+path}","compare_url":"https://api.github.com/repos/trustwallet/wallet-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trustwallet/wallet-core/merges","archive_url":"https://api.github.com/repos/trustwallet/wallet-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trustwallet/wallet-core/downloads","issues_url":"https://api.github.com/repos/trustwallet/wallet-core/issues{/number}","pulls_url":"https://api.github.com/repos/trustwallet/wallet-core/pulls{/number}","milestones_url":"https://api.github.com/repos/trustwallet/wallet-core/milestones{/number}","notifications_url":"https://api.github.com/repos/trustwallet/wallet-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trustwallet/wallet-core/labels{/name}","releases_url":"https://api.github.com/repos/trustwallet/wallet-core/releases{/id}","deployments_url":"https://api.github.com/repos/trustwallet/wallet-core/deployments","created_at":"2019-02-14T18:25:54Z","updated_at":"2019-12-06T00:00:33Z","pushed_at":"2019-12-05T22:33:16Z","git_url":"git://github.com/trustwallet/wallet-core.git","ssh_url":"git@github.com:trustwallet/wallet-core.git","clone_url":"https://github.com/trustwallet/wallet-core.git","svn_url":"https://github.com/trustwallet/wallet-core","homepage":"https://developer.trustwallet.com/wallet-core","size":15829,"stargazers_count":319,"watchers_count":319,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":230,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":230,"open_issues":13,"watchers":319,"default_branch":"master"}},"base":{"label":"trustwallet:master","ref":"master","sha":"5bed9912c74612d5e06a773d7b34f85145e97949","user":{"login":"trustwallet","id":32179889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTc5ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/trustwallet","html_url":"https://github.com/trustwallet","followers_url":"https://api.github.com/users/trustwallet/followers","following_url":"https://api.github.com/users/trustwallet/following{/other_user}","gists_url":"https://api.github.com/users/trustwallet/gists{/gist_id}","starred_url":"https://api.github.com/users/trustwallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustwallet/subscriptions","organizations_url":"https://api.github.com/users/trustwallet/orgs","repos_url":"https://api.github.com/users/trustwallet/repos","events_url":"https://api.github.com/users/trustwallet/events{/privacy}","received_events_url":"https://api.github.com/users/trustwallet/received_events","type":"Organization","site_admin":false},"repo":{"id":170738310,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA3MzgzMTA=","name":"wallet-core","full_name":"trustwallet/wallet-core","private":false,"owner":{"login":"trustwallet","id":32179889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTc5ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/trustwallet","html_url":"https://github.com/trustwallet","followers_url":"https://api.github.com/users/trustwallet/followers","following_url":"https://api.github.com/users/trustwallet/following{/other_user}","gists_url":"https://api.github.com/users/trustwallet/gists{/gist_id}","starred_url":"https://api.github.com/users/trustwallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustwallet/subscriptions","organizations_url":"https://api.github.com/users/trustwallet/orgs","repos_url":"https://api.github.com/users/trustwallet/repos","events_url":"https://api.github.com/users/trustwallet/events{/privacy}","received_events_url":"https://api.github.com/users/trustwallet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/trustwallet/wallet-core","description":"Cross-platform, cross-blockchain wallet library.","fork":false,"url":"https://api.github.com/repos/trustwallet/wallet-core","forks_url":"https://api.github.com/repos/trustwallet/wallet-core/forks","keys_url":"https://api.github.com/repos/trustwallet/wallet-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trustwallet/wallet-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trustwallet/wallet-core/teams","hooks_url":"https://api.github.com/repos/trustwallet/wallet-core/hooks","issue_events_url":"https://api.github.com/repos/trustwallet/wallet-core/issues/events{/number}","events_url":"https://api.github.com/repos/trustwallet/wallet-core/events","assignees_url":"https://api.github.com/repos/trustwallet/wallet-core/assignees{/user}","branches_url":"https://api.github.com/repos/trustwallet/wallet-core/branches{/branch}","tags_url":"https://api.github.com/repos/trustwallet/wallet-core/tags","blobs_url":"https://api.github.com/repos/trustwallet/wallet-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trustwallet/wallet-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trustwallet/wallet-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/trustwallet/wallet-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trustwallet/wallet-core/statuses/{sha}","languages_url":"https://api.github.com/repos/trustwallet/wallet-core/languages","stargazers_url":"https://api.github.com/repos/trustwallet/wallet-core/stargazers","contributors_url":"https://api.github.com/repos/trustwallet/wallet-core/contributors","subscribers_url":"https://api.github.com/repos/trustwallet/wallet-core/subscribers","subscription_url":"https://api.github.com/repos/trustwallet/wallet-core/subscription","commits_url":"https://api.github.com/repos/trustwallet/wallet-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/trustwallet/wallet-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/trustwallet/wallet-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/trustwallet/wallet-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/trustwallet/wallet-core/contents/{+path}","compare_url":"https://api.github.com/repos/trustwallet/wallet-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trustwallet/wallet-core/merges","archive_url":"https://api.github.com/repos/trustwallet/wallet-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trustwallet/wallet-core/downloads","issues_url":"https://api.github.com/repos/trustwallet/wallet-core/issues{/number}","pulls_url":"https://api.github.com/repos/trustwallet/wallet-core/pulls{/number}","milestones_url":"https://api.github.com/repos/trustwallet/wallet-core/milestones{/number}","notifications_url":"https://api.github.com/repos/trustwallet/wallet-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trustwallet/wallet-core/labels{/name}","releases_url":"https://api.github.com/repos/trustwallet/wallet-core/releases{/id}","deployments_url":"https://api.github.com/repos/trustwallet/wallet-core/deployments","created_at":"2019-02-14T18:25:54Z","updated_at":"2019-12-06T00:00:33Z","pushed_at":"2019-12-05T22:33:16Z","git_url":"git://github.com/trustwallet/wallet-core.git","ssh_url":"git@github.com:trustwallet/wallet-core.git","clone_url":"https://github.com/trustwallet/wallet-core.git","svn_url":"https://github.com/trustwallet/wallet-core","homepage":"https://developer.trustwallet.com/wallet-core","size":15829,"stargazers_count":319,"watchers_count":319,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":230,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":230,"open_issues":13,"watchers":319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trustwallet/wallet-core/pulls/754"},"html":{"href":"https://github.com/trustwallet/wallet-core/pull/754"},"issue":{"href":"https://api.github.com/repos/trustwallet/wallet-core/issues/754"},"comments":{"href":"https://api.github.com/repos/trustwallet/wallet-core/issues/754/comments"},"review_comments":{"href":"https://api.github.com/repos/trustwallet/wallet-core/pulls/754/comments"},"review_comment":{"href":"https://api.github.com/repos/trustwallet/wallet-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trustwallet/wallet-core/pulls/754/commits"},"statuses":{"href":"https://api.github.com/repos/trustwallet/wallet-core/statuses/725fe6d24e36bace89f755f513a290f80c59a623"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hewigovens"}}