{"action":"created","comment":{"url":"https://api.github.com/repos/atlassian/tangerine/pulls/comments/275296862","pull_request_review_id":226564861,"id":275296862,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTI5Njg2Mg==","diff_hunk":"@@ -0,0 +1,69 @@\n+# Javascript Node CircleCI 2.0 configuration file","path":".circleci/config.yml","position":1,"original_position":1,"commit_id":"79d3b299e807c8e20e5904f65ced6b9595a478f6","original_commit_id":"c382cd8b622cb165d3ac873d68834b2256d0a636","user":{"login":"treshugart","id":136556,"node_id":"MDQ6VXNlcjEzNjU1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/136556?v=4","gravatar_id":"","url":"https://api.github.com/users/treshugart","html_url":"https://github.com/treshugart","followers_url":"https://api.github.com/users/treshugart/followers","following_url":"https://api.github.com/users/treshugart/following{/other_user}","gists_url":"https://api.github.com/users/treshugart/gists{/gist_id}","starred_url":"https://api.github.com/users/treshugart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treshugart/subscriptions","organizations_url":"https://api.github.com/users/treshugart/orgs","repos_url":"https://api.github.com/users/treshugart/repos","events_url":"https://api.github.com/users/treshugart/events{/privacy}","received_events_url":"https://api.github.com/users/treshugart/received_events","type":"User","site_admin":false},"body":"I think that unless we can justify why we'd _need_ to use Circle, that we should use Travis because:\r\n\r\n- Ubiquity in open source and enabled by default on GitHub.\r\n- Industry-standard defaults. Much of the things like caching strategy, using `.nvmrc`, yarn if `yarn.lock` exists, and `--frozen-lockfile` are inferred in Travis because they make sense in the context of our ecosystem. If we have an `.nvmrc`, why should we have to specify it again? It's decisions like this that lend to the polish of one tool over another.\r\n- For contributors, I'd expect more people to have had exposure to TravisCI.\r\n\r\n\r\n","created_at":"2019-04-15T10:24:31Z","updated_at":"2019-04-15T10:24:31Z","html_url":"https://github.com/atlassian/tangerine/pull/39#discussion_r275296862","pull_request_url":"https://api.github.com/repos/atlassian/tangerine/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/atlassian/tangerine/pulls/comments/275296862"},"html":{"href":"https://github.com/atlassian/tangerine/pull/39#discussion_r275296862"},"pull_request":{"href":"https://api.github.com/repos/atlassian/tangerine/pulls/39"}},"in_reply_to_id":275204339},"pull_request":{"url":"https://api.github.com/repos/atlassian/tangerine/pulls/39","id":270362005,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMzYyMDA1","html_url":"https://github.com/atlassian/tangerine/pull/39","diff_url":"https://github.com/atlassian/tangerine/pull/39.diff","patch_url":"https://github.com/atlassian/tangerine/pull/39.patch","issue_url":"https://api.github.com/repos/atlassian/tangerine/issues/39","number":39,"state":"open","locked":false,"title":"Add multi-package support and first version of eslint-plugin-tangerine","user":{"login":"Blasz","id":2231370,"node_id":"MDQ6VXNlcjIyMzEzNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2231370?v=4","gravatar_id":"","url":"https://api.github.com/users/Blasz","html_url":"https://github.com/Blasz","followers_url":"https://api.github.com/users/Blasz/followers","following_url":"https://api.github.com/users/Blasz/following{/other_user}","gists_url":"https://api.github.com/users/Blasz/gists{/gist_id}","starred_url":"https://api.github.com/users/Blasz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blasz/subscriptions","organizations_url":"https://api.github.com/users/Blasz/orgs","repos_url":"https://api.github.com/users/Blasz/repos","events_url":"https://api.github.com/users/Blasz/events{/privacy}","received_events_url":"https://api.github.com/users/Blasz/received_events","type":"User","site_admin":false},"body":"This adds the `packages` directory and multi-package tooling to the repo.\r\n\r\nI've added the `eslint-plugin-repo` package which is a cut-down version of https://bitbucket.org/atlassian/eslint-plugin-tangerine with only one rule to demonstrate how this would work.\r\n\r\nFor eslint/stricter rules, no bundling or building is required, so we don't need a build tool at this stage.\r\n\r\nVersion `^1.10.0` of yarn gives us the `yarn workspaces` command which allows us to execute a script across all workspaces, which is sufficient for us to run lint/tests on CI for multiple packages.","created_at":"2019-04-15T03:47:29Z","updated_at":"2019-04-15T10:24:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c70021c60fa87e6b61d991443de5e9866131023","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JedWatson","id":872310,"node_id":"MDQ6VXNlcjg3MjMxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/872310?v=4","gravatar_id":"","url":"https://api.github.com/users/JedWatson","html_url":"https://github.com/JedWatson","followers_url":"https://api.github.com/users/JedWatson/followers","following_url":"https://api.github.com/users/JedWatson/following{/other_user}","gists_url":"https://api.github.com/users/JedWatson/gists{/gist_id}","starred_url":"https://api.github.com/users/JedWatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JedWatson/subscriptions","organizations_url":"https://api.github.com/users/JedWatson/orgs","repos_url":"https://api.github.com/users/JedWatson/repos","events_url":"https://api.github.com/users/JedWatson/events{/privacy}","received_events_url":"https://api.github.com/users/JedWatson/received_events","type":"User","site_admin":false},{"login":"nadiam84","id":6586830,"node_id":"MDQ6VXNlcjY1ODY4MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6586830?v=4","gravatar_id":"","url":"https://api.github.com/users/nadiam84","html_url":"https://github.com/nadiam84","followers_url":"https://api.github.com/users/nadiam84/followers","following_url":"https://api.github.com/users/nadiam84/following{/other_user}","gists_url":"https://api.github.com/users/nadiam84/gists{/gist_id}","starred_url":"https://api.github.com/users/nadiam84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadiam84/subscriptions","organizations_url":"https://api.github.com/users/nadiam84/orgs","repos_url":"https://api.github.com/users/nadiam84/repos","events_url":"https://api.github.com/users/nadiam84/events{/privacy}","received_events_url":"https://api.github.com/users/nadiam84/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/atlassian/tangerine/pulls/39/commits","review_comments_url":"https://api.github.com/repos/atlassian/tangerine/pulls/39/comments","review_comment_url":"https://api.github.com/repos/atlassian/tangerine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atlassian/tangerine/issues/39/comments","statuses_url":"https://api.github.com/repos/atlassian/tangerine/statuses/79d3b299e807c8e20e5904f65ced6b9595a478f6","head":{"label":"atlassian:yarn-monorepo","ref":"yarn-monorepo","sha":"79d3b299e807c8e20e5904f65ced6b9595a478f6","user":{"login":"atlassian","id":168166,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/168166?v=4","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"repo":{"id":176418757,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY0MTg3NTc=","name":"tangerine","full_name":"atlassian/tangerine","private":false,"owner":{"login":"atlassian","id":168166,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/168166?v=4","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atlassian/tangerine","description":"Atlassian's frontend guidelines","fork":false,"url":"https://api.github.com/repos/atlassian/tangerine","forks_url":"https://api.github.com/repos/atlassian/tangerine/forks","keys_url":"https://api.github.com/repos/atlassian/tangerine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlassian/tangerine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlassian/tangerine/teams","hooks_url":"https://api.github.com/repos/atlassian/tangerine/hooks","issue_events_url":"https://api.github.com/repos/atlassian/tangerine/issues/events{/number}","events_url":"https://api.github.com/repos/atlassian/tangerine/events","assignees_url":"https://api.github.com/repos/atlassian/tangerine/assignees{/user}","branches_url":"https://api.github.com/repos/atlassian/tangerine/branches{/branch}","tags_url":"https://api.github.com/repos/atlassian/tangerine/tags","blobs_url":"https://api.github.com/repos/atlassian/tangerine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlassian/tangerine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlassian/tangerine/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlassian/tangerine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlassian/tangerine/statuses/{sha}","languages_url":"https://api.github.com/repos/atlassian/tangerine/languages","stargazers_url":"https://api.github.com/repos/atlassian/tangerine/stargazers","contributors_url":"https://api.github.com/repos/atlassian/tangerine/contributors","subscribers_url":"https://api.github.com/repos/atlassian/tangerine/subscribers","subscription_url":"https://api.github.com/repos/atlassian/tangerine/subscription","commits_url":"https://api.github.com/repos/atlassian/tangerine/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlassian/tangerine/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlassian/tangerine/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlassian/tangerine/issues/comments{/number}","contents_url":"https://api.github.com/repos/atlassian/tangerine/contents/{+path}","compare_url":"https://api.github.com/repos/atlassian/tangerine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlassian/tangerine/merges","archive_url":"https://api.github.com/repos/atlassian/tangerine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlassian/tangerine/downloads","issues_url":"https://api.github.com/repos/atlassian/tangerine/issues{/number}","pulls_url":"https://api.github.com/repos/atlassian/tangerine/pulls{/number}","milestones_url":"https://api.github.com/repos/atlassian/tangerine/milestones{/number}","notifications_url":"https://api.github.com/repos/atlassian/tangerine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlassian/tangerine/labels{/name}","releases_url":"https://api.github.com/repos/atlassian/tangerine/releases{/id}","deployments_url":"https://api.github.com/repos/atlassian/tangerine/deployments","created_at":"2019-03-19T03:48:50Z","updated_at":"2019-04-15T09:23:46Z","pushed_at":"2019-04-15T07:22:59Z","git_url":"git://github.com/atlassian/tangerine.git","ssh_url":"git@github.com:atlassian/tangerine.git","clone_url":"https://github.com/atlassian/tangerine.git","svn_url":"https://github.com/atlassian/tangerine","homepage":"","size":822,"stargazers_count":52,"watchers_count":52,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":13,"watchers":52,"default_branch":"master"}},"base":{"label":"atlassian:master","ref":"master","sha":"7f42ab35dd1034b8f0ba11cc2b9f0316275206b6","user":{"login":"atlassian","id":168166,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/168166?v=4","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"repo":{"id":176418757,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY0MTg3NTc=","name":"tangerine","full_name":"atlassian/tangerine","private":false,"owner":{"login":"atlassian","id":168166,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODE2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/168166?v=4","gravatar_id":"","url":"https://api.github.com/users/atlassian","html_url":"https://github.com/atlassian","followers_url":"https://api.github.com/users/atlassian/followers","following_url":"https://api.github.com/users/atlassian/following{/other_user}","gists_url":"https://api.github.com/users/atlassian/gists{/gist_id}","starred_url":"https://api.github.com/users/atlassian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlassian/subscriptions","organizations_url":"https://api.github.com/users/atlassian/orgs","repos_url":"https://api.github.com/users/atlassian/repos","events_url":"https://api.github.com/users/atlassian/events{/privacy}","received_events_url":"https://api.github.com/users/atlassian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atlassian/tangerine","description":"Atlassian's frontend guidelines","fork":false,"url":"https://api.github.com/repos/atlassian/tangerine","forks_url":"https://api.github.com/repos/atlassian/tangerine/forks","keys_url":"https://api.github.com/repos/atlassian/tangerine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlassian/tangerine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlassian/tangerine/teams","hooks_url":"https://api.github.com/repos/atlassian/tangerine/hooks","issue_events_url":"https://api.github.com/repos/atlassian/tangerine/issues/events{/number}","events_url":"https://api.github.com/repos/atlassian/tangerine/events","assignees_url":"https://api.github.com/repos/atlassian/tangerine/assignees{/user}","branches_url":"https://api.github.com/repos/atlassian/tangerine/branches{/branch}","tags_url":"https://api.github.com/repos/atlassian/tangerine/tags","blobs_url":"https://api.github.com/repos/atlassian/tangerine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlassian/tangerine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlassian/tangerine/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlassian/tangerine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlassian/tangerine/statuses/{sha}","languages_url":"https://api.github.com/repos/atlassian/tangerine/languages","stargazers_url":"https://api.github.com/repos/atlassian/tangerine/stargazers","contributors_url":"https://api.github.com/repos/atlassian/tangerine/contributors","subscribers_url":"https://api.github.com/repos/atlassian/tangerine/subscribers","subscription_url":"https://api.github.com/repos/atlassian/tangerine/subscription","commits_url":"https://api.github.com/repos/atlassian/tangerine/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlassian/tangerine/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlassian/tangerine/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlassian/tangerine/issues/comments{/number}","contents_url":"https://api.github.com/repos/atlassian/tangerine/contents/{+path}","compare_url":"https://api.github.com/repos/atlassian/tangerine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlassian/tangerine/merges","archive_url":"https://api.github.com/repos/atlassian/tangerine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlassian/tangerine/downloads","issues_url":"https://api.github.com/repos/atlassian/tangerine/issues{/number}","pulls_url":"https://api.github.com/repos/atlassian/tangerine/pulls{/number}","milestones_url":"https://api.github.com/repos/atlassian/tangerine/milestones{/number}","notifications_url":"https://api.github.com/repos/atlassian/tangerine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlassian/tangerine/labels{/name}","releases_url":"https://api.github.com/repos/atlassian/tangerine/releases{/id}","deployments_url":"https://api.github.com/repos/atlassian/tangerine/deployments","created_at":"2019-03-19T03:48:50Z","updated_at":"2019-04-15T09:23:46Z","pushed_at":"2019-04-15T07:22:59Z","git_url":"git://github.com/atlassian/tangerine.git","ssh_url":"git@github.com:atlassian/tangerine.git","clone_url":"https://github.com/atlassian/tangerine.git","svn_url":"https://github.com/atlassian/tangerine","homepage":"","size":822,"stargazers_count":52,"watchers_count":52,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":13,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atlassian/tangerine/pulls/39"},"html":{"href":"https://github.com/atlassian/tangerine/pull/39"},"issue":{"href":"https://api.github.com/repos/atlassian/tangerine/issues/39"},"comments":{"href":"https://api.github.com/repos/atlassian/tangerine/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/atlassian/tangerine/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/atlassian/tangerine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atlassian/tangerine/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/atlassian/tangerine/statuses/79d3b299e807c8e20e5904f65ced6b9595a478f6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"treshugart"}}