{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/263894278","pull_request_review_id":212432389,"id":263894278,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2Mzg5NDI3OA==","diff_hunk":"@@ -25,5 +25,6 @@ execute: |\n   # Ensure that snapcraft uses build VMs\n   unset SNAPCRAFT_BUILD_ENVIRONMENT\n \n-  snapcraft\n-  [ $? -eq 2 ]\n+  err=0","path":"tests/spread/multipass/error-handling/task.yaml","position":6,"original_position":6,"commit_id":"637d9fffc6a857ae41f38fa76538f9f4d514f96c","original_commit_id":"637d9fffc6a857ae41f38fa76538f9f4d514f96c","user":{"login":"sergiusens","id":1146853,"node_id":"MDQ6VXNlcjExNDY4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"body":"how about using the same pattern as everywhere else\r\n\r\n```suggestion\r\n  if ! snapcraft; then\r\n    echo \"Expected <fill the blank>\"\r\n    exit 1\r\n  fi\r\n```\r\n\r\nIf we care about the code, then use your construct, but add some messaging please","created_at":"2019-03-08T19:08:20Z","updated_at":"2019-03-08T19:08:55Z","html_url":"https://github.com/snapcore/snapcraft/pull/2491#discussion_r263894278","pull_request_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2491","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/263894278"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/2491#discussion_r263894278"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2491"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2491","id":257164683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3MTY0Njgz","html_url":"https://github.com/snapcore/snapcraft/pull/2491","diff_url":"https://github.com/snapcore/snapcraft/pull/2491.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/2491.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2491","number":2491,"state":"open","locked":false,"title":"Fix multipass error handling spread test","user":{"login":"cmatsuoka","id":317355,"node_id":"MDQ6VXNlcjMxNzM1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/317355?v=4","gravatar_id":"","url":"https://api.github.com/users/cmatsuoka","html_url":"https://github.com/cmatsuoka","followers_url":"https://api.github.com/users/cmatsuoka/followers","following_url":"https://api.github.com/users/cmatsuoka/following{/other_user}","gists_url":"https://api.github.com/users/cmatsuoka/gists{/gist_id}","starred_url":"https://api.github.com/users/cmatsuoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmatsuoka/subscriptions","organizations_url":"https://api.github.com/users/cmatsuoka/orgs","repos_url":"https://api.github.com/users/cmatsuoka/repos","events_url":"https://api.github.com/users/cmatsuoka/events{/privacy}","received_events_url":"https://api.github.com/users/cmatsuoka/received_events","type":"User","site_admin":false},"body":"Fix the multipass error handler spread test but don't remove the manual switch as multipass tests in gcloud don't seem to be stable enough.\r\n\r\nSigned-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>\r\n\r\n- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?\r\n- [x] Have you successfully run `./runtests.sh static`?\r\n- [ ] Have you successfully run `./runtests.sh tests/unit`?\r\n\r\n-----\r\n","created_at":"2019-02-28T17:39:23Z","updated_at":"2019-03-08T19:08:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7bbc393a39c71cea56e1d2fb73f8f3c7d40fd8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2491/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/2491/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/2491/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/637d9fffc6a857ae41f38fa76538f9f4d514f96c","head":{"label":"cmatsuoka:fix-multipass-spread-test","ref":"fix-multipass-spread-test","sha":"637d9fffc6a857ae41f38fa76538f9f4d514f96c","user":{"login":"cmatsuoka","id":317355,"node_id":"MDQ6VXNlcjMxNzM1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/317355?v=4","gravatar_id":"","url":"https://api.github.com/users/cmatsuoka","html_url":"https://github.com/cmatsuoka","followers_url":"https://api.github.com/users/cmatsuoka/followers","following_url":"https://api.github.com/users/cmatsuoka/following{/other_user}","gists_url":"https://api.github.com/users/cmatsuoka/gists{/gist_id}","starred_url":"https://api.github.com/users/cmatsuoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmatsuoka/subscriptions","organizations_url":"https://api.github.com/users/cmatsuoka/orgs","repos_url":"https://api.github.com/users/cmatsuoka/repos","events_url":"https://api.github.com/users/cmatsuoka/events{/privacy}","received_events_url":"https://api.github.com/users/cmatsuoka/received_events","type":"User","site_admin":false},"repo":{"id":162850090,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI4NTAwOTA=","name":"snapcraft","full_name":"cmatsuoka/snapcraft","private":false,"owner":{"login":"cmatsuoka","id":317355,"node_id":"MDQ6VXNlcjMxNzM1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/317355?v=4","gravatar_id":"","url":"https://api.github.com/users/cmatsuoka","html_url":"https://github.com/cmatsuoka","followers_url":"https://api.github.com/users/cmatsuoka/followers","following_url":"https://api.github.com/users/cmatsuoka/following{/other_user}","gists_url":"https://api.github.com/users/cmatsuoka/gists{/gist_id}","starred_url":"https://api.github.com/users/cmatsuoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmatsuoka/subscriptions","organizations_url":"https://api.github.com/users/cmatsuoka/orgs","repos_url":"https://api.github.com/users/cmatsuoka/repos","events_url":"https://api.github.com/users/cmatsuoka/events{/privacy}","received_events_url":"https://api.github.com/users/cmatsuoka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cmatsuoka/snapcraft","description":"Package, distribute, and update any app for Linux and IoT.","fork":true,"url":"https://api.github.com/repos/cmatsuoka/snapcraft","forks_url":"https://api.github.com/repos/cmatsuoka/snapcraft/forks","keys_url":"https://api.github.com/repos/cmatsuoka/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmatsuoka/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmatsuoka/snapcraft/teams","hooks_url":"https://api.github.com/repos/cmatsuoka/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/cmatsuoka/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/cmatsuoka/snapcraft/events","assignees_url":"https://api.github.com/repos/cmatsuoka/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/cmatsuoka/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/cmatsuoka/snapcraft/tags","blobs_url":"https://api.github.com/repos/cmatsuoka/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmatsuoka/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmatsuoka/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmatsuoka/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmatsuoka/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/cmatsuoka/snapcraft/languages","stargazers_url":"https://api.github.com/repos/cmatsuoka/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/cmatsuoka/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/cmatsuoka/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/cmatsuoka/snapcraft/subscription","commits_url":"https://api.github.com/repos/cmatsuoka/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmatsuoka/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmatsuoka/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmatsuoka/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmatsuoka/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/cmatsuoka/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmatsuoka/snapcraft/merges","archive_url":"https://api.github.com/repos/cmatsuoka/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmatsuoka/snapcraft/downloads","issues_url":"https://api.github.com/repos/cmatsuoka/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/cmatsuoka/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/cmatsuoka/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/cmatsuoka/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmatsuoka/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/cmatsuoka/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/cmatsuoka/snapcraft/deployments","created_at":"2018-12-22T23:48:04Z","updated_at":"2019-02-27T13:22:47Z","pushed_at":"2019-03-08T18:15:31Z","git_url":"git://github.com/cmatsuoka/snapcraft.git","ssh_url":"git@github.com:cmatsuoka/snapcraft.git","clone_url":"https://github.com/cmatsuoka/snapcraft.git","svn_url":"https://github.com/cmatsuoka/snapcraft","homepage":"https://snapcraft.io","size":22177,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"ade7d65f0ba7870add2ed5ba5c016a93db2f88b8","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE5OTEzNg==","name":"snapcraft","full_name":"snapcore/snapcraft","private":false,"owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snapcore/snapcraft","description":"Package, distribute, and update any app for Linux and IoT.","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2019-03-08T19:02:20Z","pushed_at":"2019-03-08T19:02:16Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":"https://snapcraft.io","size":22102,"stargazers_count":742,"watchers_count":742,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":280,"open_issues":69,"watchers":742,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2491"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/2491"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/2491"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/2491/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2491/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/2491/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/637d9fffc6a857ae41f38fa76538f9f4d514f96c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sergiusens"}}