{"action":"closed","number":15284,"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15284","id":316553520,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2NTUzNTIw","html_url":"https://github.com/civicrm/civicrm-core/pull/15284","diff_url":"https://github.com/civicrm/civicrm-core/pull/15284.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/15284.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/15284","number":15284,"state":"closed","locked":false,"title":"dev/core#1246 fix fatal error on search builder if a core contact type is disabled","user":{"login":"colemanw","id":2874912,"node_id":"MDQ6VXNlcjI4NzQ5MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2874912?v=4","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"body":"Overview\r\n----------------------------------------\r\nThis is a more thorough treatment of @eileenmcnaughton's #15279 that makes the code more contact-type agnostic by removing some hard-coded assumptions about what contact types should & shouldn't exist.\r\n\r\nhttps://lab.civicrm.org/dev/core/issues/1246\r\n\r\nBefore\r\n----------------------------------------\r\nFatal error on search builder.\r\n\r\nAfter\r\n----------------------------------------\r\nWorks\r\n","created_at":"2019-09-11T17:23:46Z","updated_at":"2019-09-12T02:00:00Z","closed_at":"2019-09-12T02:00:00Z","merged_at":"2019-09-12T02:00:00Z","merge_commit_sha":"f299158025f051e0ad37b6ffd80bf7fa5764c9a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1491390491,"node_id":"MDU6TGFiZWwxNDkxMzkwNDkx","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/5.17","name":"5.17","color":"ededed","default":false},{"id":275096971,"node_id":"MDU6TGFiZWwyNzUwOTY5NzE=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/merge%20on%20pass","name":"merge on pass","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15284/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15284/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/15284/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/8d199bb7b0e9ddfda41fee86094a94670f9b0f88","head":{"label":"colemanw:export","ref":"export","sha":"8d199bb7b0e9ddfda41fee86094a94670f9b0f88","user":{"login":"colemanw","id":2874912,"node_id":"MDQ6VXNlcjI4NzQ5MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2874912?v=4","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"repo":{"id":8513618,"node_id":"MDEwOlJlcG9zaXRvcnk4NTEzNjE4","name":"civicrm-core","full_name":"colemanw/civicrm-core","private":false,"owner":{"login":"colemanw","id":2874912,"node_id":"MDQ6VXNlcjI4NzQ5MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2874912?v=4","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/colemanw/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/colemanw/civicrm-core","forks_url":"https://api.github.com/repos/colemanw/civicrm-core/forks","keys_url":"https://api.github.com/repos/colemanw/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colemanw/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colemanw/civicrm-core/teams","hooks_url":"https://api.github.com/repos/colemanw/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/colemanw/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/colemanw/civicrm-core/events","assignees_url":"https://api.github.com/repos/colemanw/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/colemanw/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/colemanw/civicrm-core/tags","blobs_url":"https://api.github.com/repos/colemanw/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colemanw/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colemanw/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/colemanw/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colemanw/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/colemanw/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/colemanw/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/colemanw/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/colemanw/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/colemanw/civicrm-core/subscription","commits_url":"https://api.github.com/repos/colemanw/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/colemanw/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/colemanw/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/colemanw/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/colemanw/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/colemanw/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colemanw/civicrm-core/merges","archive_url":"https://api.github.com/repos/colemanw/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colemanw/civicrm-core/downloads","issues_url":"https://api.github.com/repos/colemanw/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/colemanw/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/colemanw/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/colemanw/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colemanw/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/colemanw/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/colemanw/civicrm-core/deployments","created_at":"2013-03-02T01:06:53Z","updated_at":"2019-06-21T21:36:51Z","pushed_at":"2019-09-12T01:59:32Z","git_url":"git://github.com/colemanw/civicrm-core.git","ssh_url":"git@github.com:colemanw/civicrm-core.git","clone_url":"https://github.com/colemanw/civicrm-core.git","svn_url":"https://github.com/colemanw/civicrm-core","homepage":null,"size":185206,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:5.17","ref":"5.17","sha":"e4b146f69822bc705799269c323959ad1e32ee7b","user":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk1NDk5","name":"civicrm-core","full_name":"civicrm/civicrm-core","private":false,"owner":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2019-09-12T00:48:13Z","pushed_at":"2019-09-12T02:00:00Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":197309,"stargazers_count":342,"watchers_count":342,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":687,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":85,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":687,"open_issues":85,"watchers":342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15284"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/15284"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/15284"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/15284/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15284/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/15284/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/8d199bb7b0e9ddfda41fee86094a94670f9b0f88"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":19,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"eileenmcnaughton"}}