{"action":"created","issue":{"url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/632","repository_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol","labels_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/632/labels{/name}","comments_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/632/comments","events_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/632/events","html_url":"https://github.com/PrismarineJS/node-minecraft-protocol/issues/632","id":448469957,"node_id":"MDU6SXNzdWU0NDg0Njk5NTc=","number":632,"title":"createServer maxPlayers does nothing","user":{"login":"leumasme","id":29953391,"node_id":"MDQ6VXNlcjI5OTUzMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/29953391?v=4","gravatar_id":"","url":"https://api.github.com/users/leumasme","html_url":"https://github.com/leumasme","followers_url":"https://api.github.com/users/leumasme/followers","following_url":"https://api.github.com/users/leumasme/following{/other_user}","gists_url":"https://api.github.com/users/leumasme/gists{/gist_id}","starred_url":"https://api.github.com/users/leumasme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leumasme/subscriptions","organizations_url":"https://api.github.com/users/leumasme/orgs","repos_url":"https://api.github.com/users/leumasme/repos","events_url":"https://api.github.com/users/leumasme/events{/privacy}","received_events_url":"https://api.github.com/users/leumasme/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-05-25T14:31:02Z","updated_at":"2019-07-07T22:18:01Z","closed_at":"2019-07-07T22:01:47Z","author_association":"NONE","body":"I am just testing arround with making a pingable server and so far wrote this\r\n`mc = require(\"minecraft-protocol\")\r\n\r\nvar serveroptions = {\r\n    \"port\": 25565,\r\n    \"host\": \"127.0.0.1\",\r\n    \"kickTimeout\": 100000, // Kick after X ms without Keepalive, default 10s\r\n    \"checkTimeoutInterval\": 4000, // Send Server Keepalive every X seconds, default 4s\r\n    \"online-mode\": false,\r\n    \"beforePing\": (response,client)=>{console.log(response); return response}, // Modify Ping\r\n    \"motd\": \"NodeJS Minecraft Server\", // MOTD, modifyable in beforePing\r\n    \"maxPlayers\": 13,\r\n    \"keepAlive\": true, // Send Keepalive Packets? Default true\r\n    \"version\": 47, // MOTD only or also connections?\r\n    \"customPackets\": {}, // ??? not referenced anywhere\r\n    // \"errorHandler\" function overwrite\r\n    // \"stream\": ?\r\n    // \"connect\": relevant if using client through socks/http proxy\r\n    \"hideErrors\": false\r\n}\r\nmc.createServer(serveroptions)`\r\n\r\nNow the problem is that serveroptions.maxPlayers does not seem to do anything, instead stays at the default 20.\r\nWhen making beforePing log response, it has \"players: { max: 20, online: 0, sample: [] }\"\r\nWhen pinging it with a game client, its 20\r\nWhen logging client.maxPlayers, its undefined.\r\nAll other arguments work, for example the serveroptions.motd works as expected."},"comment":{"url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/comments/509035058","html_url":"https://github.com/PrismarineJS/node-minecraft-protocol/issues/632#issuecomment-509035058","issue_url":"https://api.github.com/repos/PrismarineJS/node-minecraft-protocol/issues/632","id":509035058,"node_id":"MDEyOklzc3VlQ29tbWVudDUwOTAzNTA1OA==","user":{"login":"rom1504","id":2346494,"node_id":"MDQ6VXNlcjIzNDY0OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2346494?v=4","gravatar_id":"","url":"https://api.github.com/users/rom1504","html_url":"https://github.com/rom1504","followers_url":"https://api.github.com/users/rom1504/followers","following_url":"https://api.github.com/users/rom1504/following{/other_user}","gists_url":"https://api.github.com/users/rom1504/gists{/gist_id}","starred_url":"https://api.github.com/users/rom1504/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rom1504/subscriptions","organizations_url":"https://api.github.com/users/rom1504/orgs","repos_url":"https://api.github.com/users/rom1504/repos","events_url":"https://api.github.com/users/rom1504/events{/privacy}","received_events_url":"https://api.github.com/users/rom1504/received_events","type":"User","site_admin":false},"created_at":"2019-07-07T22:18:01Z","updated_at":"2019-07-07T22:18:01Z","author_association":"MEMBER","body":"ok, now fixed, update to 1.9.3"}}
{"actor":{"display_login":"rom1504"}}