{"action":"created","issue":{"url":"https://api.github.com/repos/e-mission/e-mission-phone/issues/553","repository_url":"https://api.github.com/repos/e-mission/e-mission-phone","labels_url":"https://api.github.com/repos/e-mission/e-mission-phone/issues/553/labels{/name}","comments_url":"https://api.github.com/repos/e-mission/e-mission-phone/issues/553/comments","events_url":"https://api.github.com/repos/e-mission/e-mission-phone/issues/553/events","html_url":"https://github.com/e-mission/e-mission-phone/pull/553","id":431222270,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4OTQ1NTQ4","number":553,"title":"Merge the mode and purpose final code","user":{"login":"shankari","id":2423263,"node_id":"MDQ6VXNlcjI0MjMyNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2423263?v=4","gravatar_id":"","url":"https://api.github.com/users/shankari","html_url":"https://github.com/shankari","followers_url":"https://api.github.com/users/shankari/followers","following_url":"https://api.github.com/users/shankari/following{/other_user}","gists_url":"https://api.github.com/users/shankari/gists{/gist_id}","starred_url":"https://api.github.com/users/shankari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankari/subscriptions","organizations_url":"https://api.github.com/users/shankari/orgs","repos_url":"https://api.github.com/users/shankari/repos","events_url":"https://api.github.com/users/shankari/events{/privacy}","received_events_url":"https://api.github.com/users/shankari/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":27,"created_at":"2019-04-09T22:23:28Z","updated_at":"2019-04-23T17:24:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/553","html_url":"https://github.com/e-mission/e-mission-phone/pull/553","diff_url":"https://github.com/e-mission/e-mission-phone/pull/553.diff","patch_url":"https://github.com/e-mission/e-mission-phone/pull/553.patch"},"body":"This fixes https://github.com/e-mission/e-mission-docs/issues/353\r\n\r\n- Put the notification code into separate `tripconfirm`modules; there are two potential prompts and they can be configured in any combination\r\n- Merge the buttons into the list view (list view now has support for both incidents and trip confirmation)\r\n- switch the default prompt to tripconfirm\r\n- change the post-trip prompt to be more meaningful"},"comment":{"url":"https://api.github.com/repos/e-mission/e-mission-phone/issues/comments/485897588","html_url":"https://github.com/e-mission/e-mission-phone/pull/553#issuecomment-485897588","issue_url":"https://api.github.com/repos/e-mission/e-mission-phone/issues/553","id":485897588,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NTg5NzU4OA==","user":{"login":"PatGendre","id":5039447,"node_id":"MDQ6VXNlcjUwMzk0NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5039447?v=4","gravatar_id":"","url":"https://api.github.com/users/PatGendre","html_url":"https://github.com/PatGendre","followers_url":"https://api.github.com/users/PatGendre/followers","following_url":"https://api.github.com/users/PatGendre/following{/other_user}","gists_url":"https://api.github.com/users/PatGendre/gists{/gist_id}","starred_url":"https://api.github.com/users/PatGendre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatGendre/subscriptions","organizations_url":"https://api.github.com/users/PatGendre/orgs","repos_url":"https://api.github.com/users/PatGendre/repos","events_url":"https://api.github.com/users/PatGendre/events{/privacy}","received_events_url":"https://api.github.com/users/PatGendre/received_events","type":"User","site_admin":false},"created_at":"2019-04-23T17:24:39Z","updated_at":"2019-04-23T17:24:39Z","author_association":"NONE","body":"@shankari I noticed a little problem with the \"other\" mode : when I first tried to select other, I had to give a name to the new \"other\" mode, and then this new mode is added to the list of other modes, and I could add a second one. However, I couldn't select the other mode : when selecting other, I have to fill in a new mode.\r\n\r\nSame behavior for purpose : you can add a new purpose, it is added to the purpose list, but afterwards ou cannot select it in the list, you can only a new \"other purpose\".\r\n\r\nAlso, after playing 5' with the diary screen and pressing 10x the mode/purpose buttons, they don't seem to work any more, I click on mode or purpose and nothing happens.\r\nLast question : do you run the pipeline on the martanetwork data? (my trips date back from April 10 are still in draft mode, by the way, the explanation when clicking on draft is a great idea!). "}}
{"actor":{"display_login":"PatGendre"}}