{"action":"created","comment":{"url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/comments/339400711","pull_request_review_id":307639612,"id":339400711,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTQwMDcxMQ==","diff_hunk":"@@ -43,17 +87,28 @@ describe('cron-allowed-range', function() {\n       );\n     });\n \n+    ['0-59 0-23 1-31 1-11,12 0-6'].forEach(expression => {\n+      it(`should not throw any error when the values are exactly on the range'${expression}'`, function() {","path":"test/index.js","position":65,"original_position":65,"commit_id":"6ecd8841af458b1b5926794c62ea2c02c9531247","original_commit_id":"6ecd8841af458b1b5926794c62ea2c02c9531247","user":{"login":"anusha5695","id":33545283,"node_id":"MDQ6VXNlcjMzNTQ1Mjgz","avatar_url":"https://avatars1.githubusercontent.com/u/33545283?v=4","gravatar_id":"","url":"https://api.github.com/users/anusha5695","html_url":"https://github.com/anusha5695","followers_url":"https://api.github.com/users/anusha5695/followers","following_url":"https://api.github.com/users/anusha5695/following{/other_user}","gists_url":"https://api.github.com/users/anusha5695/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha5695/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha5695/subscriptions","organizations_url":"https://api.github.com/users/anusha5695/orgs","repos_url":"https://api.github.com/users/anusha5695/repos","events_url":"https://api.github.com/users/anusha5695/events{/privacy}","received_events_url":"https://api.github.com/users/anusha5695/received_events","type":"User","site_admin":false},"body":"Sure will fix this","created_at":"2019-10-28T04:39:06Z","updated_at":"2019-10-28T04:39:06Z","html_url":"https://github.com/neverendingqs/cron-allowed-range/pull/15#discussion_r339400711","pull_request_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/15","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/comments/339400711"},"html":{"href":"https://github.com/neverendingqs/cron-allowed-range/pull/15#discussion_r339400711"},"pull_request":{"href":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/15"}},"in_reply_to_id":339358462},"pull_request":{"url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/15","id":332822108,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyODIyMTA4","html_url":"https://github.com/neverendingqs/cron-allowed-range/pull/15","diff_url":"https://github.com/neverendingqs/cron-allowed-range/pull/15.diff","patch_url":"https://github.com/neverendingqs/cron-allowed-range/pull/15.patch","issue_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/issues/15","number":15,"state":"open","locked":false,"title":"[Issue-4] Validate if time elements are within range <Anusha>","user":{"login":"anusha5695","id":33545283,"node_id":"MDQ6VXNlcjMzNTQ1Mjgz","avatar_url":"https://avatars1.githubusercontent.com/u/33545283?v=4","gravatar_id":"","url":"https://api.github.com/users/anusha5695","html_url":"https://github.com/anusha5695","followers_url":"https://api.github.com/users/anusha5695/followers","following_url":"https://api.github.com/users/anusha5695/following{/other_user}","gists_url":"https://api.github.com/users/anusha5695/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha5695/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha5695/subscriptions","organizations_url":"https://api.github.com/users/anusha5695/orgs","repos_url":"https://api.github.com/users/anusha5695/repos","events_url":"https://api.github.com/users/anusha5695/events{/privacy}","received_events_url":"https://api.github.com/users/anusha5695/received_events","type":"User","site_admin":false},"body":"**Issue:**\r\nThis is a pull request for the issue : https://github.com/neverendingqs/cron-allowed-range/issues/4\r\n\r\n**Summary of changes:**\r\n1. Added a prop map for each time element's min and max allowed value\r\n2. Throw error as \"_Invalid time element. Range should be within [min - max]._ \" if the time element's values are not in the allowed range.\r\n3. Added appropriate tests cases, modify few existing ones because they were failing on validation\r\n","created_at":"2019-10-27T03:52:24Z","updated_at":"2019-10-28T04:39:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75d09a54c17215b69f50e1b8c13e237058c5e7da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/15/commits","review_comments_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/15/comments","review_comment_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/issues/15/comments","statuses_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/statuses/6ecd8841af458b1b5926794c62ea2c02c9531247","head":{"label":"anusha5695:master","ref":"master","sha":"6ecd8841af458b1b5926794c62ea2c02c9531247","user":{"login":"anusha5695","id":33545283,"node_id":"MDQ6VXNlcjMzNTQ1Mjgz","avatar_url":"https://avatars1.githubusercontent.com/u/33545283?v=4","gravatar_id":"","url":"https://api.github.com/users/anusha5695","html_url":"https://github.com/anusha5695","followers_url":"https://api.github.com/users/anusha5695/followers","following_url":"https://api.github.com/users/anusha5695/following{/other_user}","gists_url":"https://api.github.com/users/anusha5695/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha5695/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha5695/subscriptions","organizations_url":"https://api.github.com/users/anusha5695/orgs","repos_url":"https://api.github.com/users/anusha5695/repos","events_url":"https://api.github.com/users/anusha5695/events{/privacy}","received_events_url":"https://api.github.com/users/anusha5695/received_events","type":"User","site_admin":false},"repo":{"id":217759196,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc3NTkxOTY=","name":"cron-allowed-range","full_name":"anusha5695/cron-allowed-range","private":false,"owner":{"login":"anusha5695","id":33545283,"node_id":"MDQ6VXNlcjMzNTQ1Mjgz","avatar_url":"https://avatars1.githubusercontent.com/u/33545283?v=4","gravatar_id":"","url":"https://api.github.com/users/anusha5695","html_url":"https://github.com/anusha5695","followers_url":"https://api.github.com/users/anusha5695/followers","following_url":"https://api.github.com/users/anusha5695/following{/other_user}","gists_url":"https://api.github.com/users/anusha5695/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha5695/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha5695/subscriptions","organizations_url":"https://api.github.com/users/anusha5695/orgs","repos_url":"https://api.github.com/users/anusha5695/repos","events_url":"https://api.github.com/users/anusha5695/events{/privacy}","received_events_url":"https://api.github.com/users/anusha5695/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anusha5695/cron-allowed-range","description":"Use cron-like expressions to test if a datetime is in an allowed range.","fork":true,"url":"https://api.github.com/repos/anusha5695/cron-allowed-range","forks_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/forks","keys_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/teams","hooks_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/hooks","issue_events_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/issues/events{/number}","events_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/events","assignees_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/assignees{/user}","branches_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/branches{/branch}","tags_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/tags","blobs_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/git/refs{/sha}","trees_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/statuses/{sha}","languages_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/languages","stargazers_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/stargazers","contributors_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/contributors","subscribers_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/subscribers","subscription_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/subscription","commits_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/commits{/sha}","git_commits_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/git/commits{/sha}","comments_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/comments{/number}","issue_comment_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/issues/comments{/number}","contents_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/contents/{+path}","compare_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/merges","archive_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/downloads","issues_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/issues{/number}","pulls_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/pulls{/number}","milestones_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/milestones{/number}","notifications_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/labels{/name}","releases_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/releases{/id}","deployments_url":"https://api.github.com/repos/anusha5695/cron-allowed-range/deployments","created_at":"2019-10-26T19:29:16Z","updated_at":"2019-10-27T03:48:18Z","pushed_at":"2019-10-27T03:48:17Z","git_url":"git://github.com/anusha5695/cron-allowed-range.git","ssh_url":"git@github.com:anusha5695/cron-allowed-range.git","clone_url":"https://github.com/anusha5695/cron-allowed-range.git","svn_url":"https://github.com/anusha5695/cron-allowed-range","homepage":"","size":321,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neverendingqs:master","ref":"master","sha":"97a569c3b2c4d4847fe475ec811d6609dfa3983e","user":{"login":"neverendingqs","id":8854618,"node_id":"MDQ6VXNlcjg4NTQ2MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8854618?v=4","gravatar_id":"","url":"https://api.github.com/users/neverendingqs","html_url":"https://github.com/neverendingqs","followers_url":"https://api.github.com/users/neverendingqs/followers","following_url":"https://api.github.com/users/neverendingqs/following{/other_user}","gists_url":"https://api.github.com/users/neverendingqs/gists{/gist_id}","starred_url":"https://api.github.com/users/neverendingqs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neverendingqs/subscriptions","organizations_url":"https://api.github.com/users/neverendingqs/orgs","repos_url":"https://api.github.com/users/neverendingqs/repos","events_url":"https://api.github.com/users/neverendingqs/events{/privacy}","received_events_url":"https://api.github.com/users/neverendingqs/received_events","type":"User","site_admin":false},"repo":{"id":216091734,"node_id":"MDEwOlJlcG9zaXRvcnkyMTYwOTE3MzQ=","name":"cron-allowed-range","full_name":"neverendingqs/cron-allowed-range","private":false,"owner":{"login":"neverendingqs","id":8854618,"node_id":"MDQ6VXNlcjg4NTQ2MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8854618?v=4","gravatar_id":"","url":"https://api.github.com/users/neverendingqs","html_url":"https://github.com/neverendingqs","followers_url":"https://api.github.com/users/neverendingqs/followers","following_url":"https://api.github.com/users/neverendingqs/following{/other_user}","gists_url":"https://api.github.com/users/neverendingqs/gists{/gist_id}","starred_url":"https://api.github.com/users/neverendingqs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neverendingqs/subscriptions","organizations_url":"https://api.github.com/users/neverendingqs/orgs","repos_url":"https://api.github.com/users/neverendingqs/repos","events_url":"https://api.github.com/users/neverendingqs/events{/privacy}","received_events_url":"https://api.github.com/users/neverendingqs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/neverendingqs/cron-allowed-range","description":"Use cron-like expressions to test if a datetime is in an allowed range.","fork":false,"url":"https://api.github.com/repos/neverendingqs/cron-allowed-range","forks_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/forks","keys_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/teams","hooks_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/hooks","issue_events_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/issues/events{/number}","events_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/events","assignees_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/assignees{/user}","branches_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/branches{/branch}","tags_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/tags","blobs_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/git/refs{/sha}","trees_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/statuses/{sha}","languages_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/languages","stargazers_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/stargazers","contributors_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/contributors","subscribers_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/subscribers","subscription_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/subscription","commits_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/commits{/sha}","git_commits_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/git/commits{/sha}","comments_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/comments{/number}","issue_comment_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/issues/comments{/number}","contents_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/contents/{+path}","compare_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/merges","archive_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/downloads","issues_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/issues{/number}","pulls_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls{/number}","milestones_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/milestones{/number}","notifications_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/labels{/name}","releases_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/releases{/id}","deployments_url":"https://api.github.com/repos/neverendingqs/cron-allowed-range/deployments","created_at":"2019-10-18T19:15:36Z","updated_at":"2019-10-24T01:48:00Z","pushed_at":"2019-10-27T03:52:25Z","git_url":"git://github.com/neverendingqs/cron-allowed-range.git","ssh_url":"git@github.com:neverendingqs/cron-allowed-range.git","clone_url":"https://github.com/neverendingqs/cron-allowed-range.git","svn_url":"https://github.com/neverendingqs/cron-allowed-range","homepage":"","size":359,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/15"},"html":{"href":"https://github.com/neverendingqs/cron-allowed-range/pull/15"},"issue":{"href":"https://api.github.com/repos/neverendingqs/cron-allowed-range/issues/15"},"comments":{"href":"https://api.github.com/repos/neverendingqs/cron-allowed-range/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neverendingqs/cron-allowed-range/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/neverendingqs/cron-allowed-range/statuses/6ecd8841af458b1b5926794c62ea2c02c9531247"}},"author_association":"NONE"}}
{"actor":{"display_login":"anusha5695"}}