{"action":"created","issue":{"url":"https://api.github.com/repos/Baystation12/Baystation12/issues/24760","repository_url":"https://api.github.com/repos/Baystation12/Baystation12","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/24760/labels{/name}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/24760/comments","events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/24760/events","html_url":"https://github.com/Baystation12/Baystation12/pull/24760","id":418952482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5NjAzMjgy","number":24760,"title":"Increased max rated power on multiple atmos devices","user":{"login":"Anticept","id":521038,"node_id":"MDQ6VXNlcjUyMTAzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/521038?v=4","gravatar_id":"","url":"https://api.github.com/users/Anticept","html_url":"https://github.com/Anticept","followers_url":"https://api.github.com/users/Anticept/followers","following_url":"https://api.github.com/users/Anticept/following{/other_user}","gists_url":"https://api.github.com/users/Anticept/gists{/gist_id}","starred_url":"https://api.github.com/users/Anticept/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anticept/subscriptions","organizations_url":"https://api.github.com/users/Anticept/orgs","repos_url":"https://api.github.com/users/Anticept/repos","events_url":"https://api.github.com/users/Anticept/events{/privacy}","received_events_url":"https://api.github.com/users/Anticept/received_events","type":"User","site_admin":false},"labels":[{"id":749593738,"node_id":"MDU6TGFiZWw3NDk1OTM3Mzg=","url":"https://api.github.com/repos/Baystation12/Baystation12/labels/Tweak","name":"Tweak","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-03-08T20:50:16Z","updated_at":"2019-03-08T21:07:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/24760","html_url":"https://github.com/Baystation12/Baystation12/pull/24760","diff_url":"https://github.com/Baystation12/Baystation12/pull/24760.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/24760.patch"},"body":"Unlike the previous atmos PR which changed pump efficiency, this one just increases the max rated power on many atmospheric devices, as well as the max pressure on filters.\r\n\r\nWill conflict with https://github.com/Baystation12/Baystation12/pull/24248 . This is meant to be something to help with issues now rather than later.\r\n\r\nAll atmospheric devices have three limiters:\r\n- volume\r\n- pressure\r\n- power rating\r\n\r\nVolume is the maximum amount of air displacement that can be moved per tick. You often see it as 200 litres a second on pumps.\r\n\r\nPressure is obvious: if the output is above the pressure limit, it will not operate.\r\n\r\nPower rating: this one takes a little explaining. When a gas goes from high pressure to low pressure, it costs no power. It takes power, however, to move gas from low to high. The greater this difference, the greater the power consumption. Eventually, the pump hits its power rating, which caps the amount of gas it can move per tick.\r\n\r\nThis PR significantly increases the power rating on pretty much all atmos devices. Some are only a couple times, others 5+ times higher.\r\n\r\nAs a result, a few things happen. Here are the implications:\r\n\r\n- Airlocks cycle a little faster. No, they won't cycle several times faster, because an issue is scavenging gas at low pressures unrelated to pump power.\r\n- Atmospherics works a few times faster. The bottlenecks here are the air injectors, and the low air pressure max that was on filters. Now, filters max are 15000kpa. Air injectors maximum power was only dialed up a little bit, their main issue was that filters weren't supplying a high pressure. \r\n- Note: filters are not as strong as pumps; they can move a lot of gas but they do not do well at pumping pressures. If dealing with pumping low to high pressure, installing pumps on the inlets and/or outlets will dramatically increase efficiency.\r\n- Atmospherics takes CONSIDERABLE power to operate now. I've seen it hit half a million watts (SMES output limit for atmos) when filtering a lot of different gasses and things maxed out. If ship is in a power emergency, atmos should be depowered or it won't take long to drain the ship under stress. Adding a lot of high power pumps will only further increase this consumption. NOTE: if there is a widespread ship atmospheric emergency, turning off atmos could make things WORSE. See next bullet point.\r\n- Shipwide vents and scrubbers also take considerably more power (4x). An **extreme** atmos emergency will stress the powergrid to power outage, but it's unlikely to occur in normal circumstances. We're talking widespread toxins everywhere kind of emergency and significant backup in the waste system (thus requiring max power per scrubber to scrub).\r\nThe following was a test with running around with a custom CO2 canister containing hundreds of thousands of moles of CO2 (trust me, that's about half of the torch being filled with pure CO2), and filling 75% of the torch areas with air alarms, WHILE the waste system was backed up to 6000 kpa, AND pumping pure CO2 into distribution. I repeat, this is *extreme*, but demonstrates how much power running the ship atmospheric system will consume in very poor conditions.\r\n![image](https://user-images.githubusercontent.com/521038/54053704-24dfa280-41b6-11e9-8172-e9015f7d7695.png)\r\n\r\nJust purging the waste line would considerably drop the power usage, and all that takes is turning up the injectors and waste to filter pump to max, a basic level of atmos understanding.\r\n\r\nHere it is after renabling pumps after 10 minutes:\r\n\r\n![image](https://user-images.githubusercontent.com/521038/54054358-f4990380-41b7-11e9-84eb-2069059c3395.png)\r\n\r\nDumping waste to space is a recommended option if there's a widespread power emergency looming and widespread atmos contamination on the ship.\r\n\r\n- Scrubbing peak efficiency is considerably increased. Does not affect normal balance operation, at least not in my tests by spawning a few dozen monkies everywhere.\r\n- Does NOT cause the shuttles to drain power any faster when cycling. It just causes a higher power spike for a shorter period of time, and it all balances out.\r\n\r\n🆑 \r\ntweak: Atmos pumps have all had their power limits increased considerably. This means atmospherics will operate faster, but at the cost of much more power at peak performance. In addition, vents and scrubbers will operate faster when stressed, but they too will cause a tremendous power spike in a ship wide atmos contamination emergency (affecting the majority of non-maintenance areas). This can and will lead to a grid power outage if atmospherics is not functioning properly, and significant pressure is allowed to builds in the waste lines. Beware!\r\ntweak: Filter pressure limits raised to 15,000 kpa. They are still not powerful devices when pumping from low to high pressures. You should put pumps around them if you intend them to work quickly with moving pressures in a non-passive manner.\r\n/:cl:"},"comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments/471076434","html_url":"https://github.com/Baystation12/Baystation12/pull/24760#issuecomment-471076434","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/24760","id":471076434,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MTA3NjQzNA==","user":{"login":"afterthought2","id":36152617,"node_id":"MDQ6VXNlcjM2MTUyNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/36152617?v=4","gravatar_id":"","url":"https://api.github.com/users/afterthought2","html_url":"https://github.com/afterthought2","followers_url":"https://api.github.com/users/afterthought2/followers","following_url":"https://api.github.com/users/afterthought2/following{/other_user}","gists_url":"https://api.github.com/users/afterthought2/gists{/gist_id}","starred_url":"https://api.github.com/users/afterthought2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afterthought2/subscriptions","organizations_url":"https://api.github.com/users/afterthought2/orgs","repos_url":"https://api.github.com/users/afterthought2/repos","events_url":"https://api.github.com/users/afterthought2/events{/privacy}","received_events_url":"https://api.github.com/users/afterthought2/received_events","type":"User","site_admin":false},"created_at":"2019-03-08T21:07:02Z","updated_at":"2019-03-08T21:07:02Z","author_association":"CONTRIBUTOR","body":"Last time we tried this, had to instantly revert. Have you tested it extensively, including spawning monkeys or whatever to simulate breathing humans, and leaving it run for a while?"}}
{"actor":{"display_login":"afterthought2"}}