{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/76805","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/76805/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/76805/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/76805/events","html_url":"https://github.com/kubernetes/kubernetes/pull/76805","id":435025397,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxODg3NjE4","number":76805,"title":"Implement CodecFactoryOptions allowing clients to opt-in to Pretty encoders and Strict Decoders","user":{"login":"stealthybox","id":2754700,"node_id":"MDQ6VXNlcjI3NTQ3MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/2754700?v=4","gravatar_id":"","url":"https://api.github.com/users/stealthybox","html_url":"https://github.com/stealthybox","followers_url":"https://api.github.com/users/stealthybox/followers","following_url":"https://api.github.com/users/stealthybox/following{/other_user}","gists_url":"https://api.github.com/users/stealthybox/gists{/gist_id}","starred_url":"https://api.github.com/users/stealthybox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stealthybox/subscriptions","organizations_url":"https://api.github.com/users/stealthybox/orgs","repos_url":"https://api.github.com/users/stealthybox/repos","events_url":"https://api.github.com/users/stealthybox/events{/privacy}","received_events_url":"https://api.github.com/users/stealthybox/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"node_id":"MDU6TGFiZWwyNjEwMDUzNjA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"e11d21","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false},{"id":1188415049,"node_id":"MDU6TGFiZWwxMTg4NDE1MDQ5","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/wg/component-standard","name":"wg/component-standard","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-04-19T02:19:51Z","updated_at":"2019-04-19T03:00:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/76805","html_url":"https://github.com/kubernetes/kubernetes/pull/76805","diff_url":"https://github.com/kubernetes/kubernetes/pull/76805.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/76805.patch"},"body":"/kind api-change\n@kubernetes/wg-component-standard \n\n**What this PR does / why we need it**:\nThis patch introduces a new CodecFactory constructor that's capable of building different collections of Serializers.\nNote that this diverges from the current design where an initialized CodecFactory is a kitchen sink holding many forms of useful Serilaizers in a non-customizeable way.\n\nThis approach is a suggested solution from this thread:\nhttps://groups.google.com/d/msg/kubernetes-sig-api-machinery/R4Iiz3rOYd0/O6aX15_AAQAJ\n\nA universal, defaulting, strict decoder is needed for Component Config efforts. \nFuture work aims to make strict behavior the default -- right now it's not implemented in a way that is performant enough for the apiserver.\n\nThis patch adds a deprecation notice for `NewCodecFactory()`.\nFor now, uses of this public constructor remain unchanged, and the tests are still exercising it.\nIt's been modified, however, to simply wrap the `WithOptions` version.\n\nTracking issue: https://github.com/kubernetes/kubernetes/issues/75426\n\n**Special notes for your reviewer**:\nI'm not sure I like how verbose this incantation is:\n```go\ncodecs.NewCodecFactoryWithOptions(\n    scheme,\n    codecs.CodecFactoryOptions{Pretty: true, Strict: true},\n)\n```\nIt's much longer than before.\nIf you have feedback on naming, it would be beneficial to make this not look so intimidating.\n\nNote as well that the tests should be modified to exercise the non-Pretty and Strict paths.\n\n**Does this PR introduce a user-facing change?**:\n```release-note\nNONE\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/484752670","html_url":"https://github.com/kubernetes/kubernetes/pull/76805#issuecomment-484752670","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/76805","id":484752670,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NDc1MjY3MA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-04-19T03:00:50Z","updated_at":"2019-04-19T03:00:50Z","author_association":"CONTRIBUTOR","body":"@stealthybox: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-node-e2e | 9490f5b15836b2ac72bec4be6b571f6f2546ef94 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76805/pull-kubernetes-node-e2e/1119063142924554246/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-e2e-gce-device-plugin-gpu | 9490f5b15836b2ac72bec4be6b571f6f2546ef94 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76805/pull-kubernetes-e2e-gce-device-plugin-gpu/1119063142924554245/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-bazel-build | 9490f5b15836b2ac72bec4be6b571f6f2546ef94 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76805/pull-kubernetes-bazel-build/1119063142924554240/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-e2e-gce | 9490f5b15836b2ac72bec4be6b571f6f2546ef94 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76805/pull-kubernetes-e2e-gce/1119063142924554244/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-bazel-test | 9490f5b15836b2ac72bec4be6b571f6f2546ef94 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76805/pull-kubernetes-bazel-test/1119063142924554241/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-gce-100-performance | 9490f5b15836b2ac72bec4be6b571f6f2546ef94 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76805/pull-kubernetes-e2e-gce-100-performance/1119063142928748544/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-kubemark-e2e-gce-big | 9490f5b15836b2ac72bec4be6b571f6f2546ef94 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76805/pull-kubernetes-kubemark-e2e-gce-big/1119063142928748546/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\npull-kubernetes-integration | 9490f5b15836b2ac72bec4be6b571f6f2546ef94 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76805/pull-kubernetes-integration/1119063142924554243/) | `/test pull-kubernetes-integration`\npull-kubernetes-verify | 9490f5b15836b2ac72bec4be6b571f6f2546ef94 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76805/pull-kubernetes-verify/1119063142928748547) | `/test pull-kubernetes-verify`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=76805). [Your PR dashboard](https://gubernator.k8s.io/pr/stealthybox). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}