{"action":"created","comment":{"url":"https://api.github.com/repos/sindresorhus/got/pulls/comments/310392216","pull_request_review_id":270503042,"id":310392216,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDM5MjIxNg==","diff_hunk":"@@ -42,12 +42,13 @@ Got is for Node.js. For browsers, we recommend [Ky](https://github.com/sindresor\n - [WHATWG URL support](#url)\n - [Hooks](#hooks)\n - [Instances with custom defaults](#instances)\n-- [Composable](advanced-creation.md#merging-instances)\n+- [Composable](documentation/advanced-creation.md#merging-instances)\n+- [Plugins](documentatino/lest-make-a-plugin.md)","path":"readme.md","position":null,"original_position":6,"commit_id":"5cea30bc51d76183ad3dd397c4a443ef97cd3d32","original_commit_id":"73fae07775a6a81461a7e38478811af4cb650ab5","user":{"login":"szmarczak","id":36894700,"node_id":"MDQ6VXNlcjM2ODk0NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/36894700?v=4","gravatar_id":"","url":"https://api.github.com/users/szmarczak","html_url":"https://github.com/szmarczak","followers_url":"https://api.github.com/users/szmarczak/followers","following_url":"https://api.github.com/users/szmarczak/following{/other_user}","gists_url":"https://api.github.com/users/szmarczak/gists{/gist_id}","starred_url":"https://api.github.com/users/szmarczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szmarczak/subscriptions","organizations_url":"https://api.github.com/users/szmarczak/orgs","repos_url":"https://api.github.com/users/szmarczak/repos","events_url":"https://api.github.com/users/szmarczak/events{/privacy}","received_events_url":"https://api.github.com/users/szmarczak/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2019-08-04T15:29:16Z","updated_at":"2019-08-04T15:29:16Z","html_url":"https://github.com/sindresorhus/got/pull/707#discussion_r310392216","pull_request_url":"https://api.github.com/repos/sindresorhus/got/pulls/707","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/comments/310392216"},"html":{"href":"https://github.com/sindresorhus/got/pull/707#discussion_r310392216"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/707"}},"in_reply_to_id":307969826},"pull_request":{"url":"https://api.github.com/repos/sindresorhus/got/pulls/707","id":246111177,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ2MTExMTc3","html_url":"https://github.com/sindresorhus/got/pull/707","diff_url":"https://github.com/sindresorhus/got/pull/707.diff","patch_url":"https://github.com/sindresorhus/got/pull/707.patch","issue_url":"https://api.github.com/repos/sindresorhus/got/issues/707","number":707,"state":"open","locked":false,"title":"Simpler instance creation","user":{"login":"szmarczak","id":36894700,"node_id":"MDQ6VXNlcjM2ODk0NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/36894700?v=4","gravatar_id":"","url":"https://api.github.com/users/szmarczak","html_url":"https://github.com/szmarczak","followers_url":"https://api.github.com/users/szmarczak/followers","following_url":"https://api.github.com/users/szmarczak/following{/other_user}","gists_url":"https://api.github.com/users/szmarczak/gists{/gist_id}","starred_url":"https://api.github.com/users/szmarczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szmarczak/subscriptions","organizations_url":"https://api.github.com/users/szmarczak/orgs","repos_url":"https://api.github.com/users/szmarczak/repos","events_url":"https://api.github.com/users/szmarczak/events{/privacy}","received_events_url":"https://api.github.com/users/szmarczak/received_events","type":"User","site_admin":false},"body":"The same instances, but their creation is much simpler.\r\n\r\n- [x] Merging instances:\r\n      Now: `instanceA.extend(instanceB, instanceC, ...)`\r\n      Before: `got.mergeInstances(instanceA, instanceB, instanceC, ...)`\r\n- [x] Merging options:\r\n      Now: `instanceA.extend(optionsB, optionsC, ...)`\r\n      Before: `instanceA.extend(optionsB).extend(optionsC).extend(...)`\r\n- [x] Merging instances and options:\r\n      Now: `instanceA.extend(optionsB, instanceC, ...)`\r\n      Before: `got.mergeInstances(instanceA.extend(optionsB), instanceC)`\r\n- [x] Extending handlers:\r\n      Now: `instanceA.extend({handlers: [handlerB]})`\r\n      Before: `got.mergeInstances(instanceA, got.create({handler: handlerB}))`\r\n- [x] Cloning instances to make them mutable:\r\n      Now: `instanceA.extend({mutableDefaults: true})` (not changed)\r\n      Before: `instanceA.extend({mutableDefaults: true})`\r\n\r\n#### Are there any breaking changes?\r\n\r\n1. `got.create({handler: ...})` is pluralized and accepts an array.\r\n- Before: `defaults.handler` was a function containing private array of handlers.\r\n- Now: `defaults.handlers` is a public array of handlers.\r\n\r\nThis allows us to inherit properties from the original Promise.\r\nYup, it's safe to use async handlers now. All the properties (`.cancel()` etc.) will be proxied.\r\n\r\n2. `got.mergeInstances(...instances)` is deprecated. Use `instanceA.extend(instanceB)` instead.\r\n\r\n#### Checklist\r\n\r\n- [x] I have read the documentation.\r\n- [x] I have included a pull request description of my changes.\r\n- [x] I have included some tests.\r\n- [x] If it's a new feature, I have included documentation updates.\r\n- [x] Fixes #701\r\n- [x] Closes #737","created_at":"2019-01-20T14:01:36Z","updated_at":"2019-08-04T15:29:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8c8342375afac9b2249675ca9b09f2ce083e2f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1190627945,"node_id":"MDU6TGFiZWwxMTkwNjI3OTQ1","url":"https://api.github.com/repos/sindresorhus/got/labels/breaking","name":"breaking","color":"ff8a00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/got/pulls/707/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/got/pulls/707/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/got/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sindresorhus/got/issues/707/comments","statuses_url":"https://api.github.com/repos/sindresorhus/got/statuses/5cea30bc51d76183ad3dd397c4a443ef97cd3d32","head":{"label":"szmarczak:simpler-instances","ref":"simpler-instances","sha":"5cea30bc51d76183ad3dd397c4a443ef97cd3d32","user":{"login":"szmarczak","id":36894700,"node_id":"MDQ6VXNlcjM2ODk0NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/36894700?v=4","gravatar_id":"","url":"https://api.github.com/users/szmarczak","html_url":"https://github.com/szmarczak","followers_url":"https://api.github.com/users/szmarczak/followers","following_url":"https://api.github.com/users/szmarczak/following{/other_user}","gists_url":"https://api.github.com/users/szmarczak/gists{/gist_id}","starred_url":"https://api.github.com/users/szmarczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szmarczak/subscriptions","organizations_url":"https://api.github.com/users/szmarczak/orgs","repos_url":"https://api.github.com/users/szmarczak/repos","events_url":"https://api.github.com/users/szmarczak/events{/privacy}","received_events_url":"https://api.github.com/users/szmarczak/received_events","type":"User","site_admin":false},"repo":{"id":123169698,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMxNjk2OTg=","name":"got","full_name":"szmarczak/got","private":false,"owner":{"login":"szmarczak","id":36894700,"node_id":"MDQ6VXNlcjM2ODk0NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/36894700?v=4","gravatar_id":"","url":"https://api.github.com/users/szmarczak","html_url":"https://github.com/szmarczak","followers_url":"https://api.github.com/users/szmarczak/followers","following_url":"https://api.github.com/users/szmarczak/following{/other_user}","gists_url":"https://api.github.com/users/szmarczak/gists{/gist_id}","starred_url":"https://api.github.com/users/szmarczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szmarczak/subscriptions","organizations_url":"https://api.github.com/users/szmarczak/orgs","repos_url":"https://api.github.com/users/szmarczak/repos","events_url":"https://api.github.com/users/szmarczak/events{/privacy}","received_events_url":"https://api.github.com/users/szmarczak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/szmarczak/got","description":"Simplified HTTP requests","fork":true,"url":"https://api.github.com/repos/szmarczak/got","forks_url":"https://api.github.com/repos/szmarczak/got/forks","keys_url":"https://api.github.com/repos/szmarczak/got/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szmarczak/got/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szmarczak/got/teams","hooks_url":"https://api.github.com/repos/szmarczak/got/hooks","issue_events_url":"https://api.github.com/repos/szmarczak/got/issues/events{/number}","events_url":"https://api.github.com/repos/szmarczak/got/events","assignees_url":"https://api.github.com/repos/szmarczak/got/assignees{/user}","branches_url":"https://api.github.com/repos/szmarczak/got/branches{/branch}","tags_url":"https://api.github.com/repos/szmarczak/got/tags","blobs_url":"https://api.github.com/repos/szmarczak/got/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szmarczak/got/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szmarczak/got/git/refs{/sha}","trees_url":"https://api.github.com/repos/szmarczak/got/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szmarczak/got/statuses/{sha}","languages_url":"https://api.github.com/repos/szmarczak/got/languages","stargazers_url":"https://api.github.com/repos/szmarczak/got/stargazers","contributors_url":"https://api.github.com/repos/szmarczak/got/contributors","subscribers_url":"https://api.github.com/repos/szmarczak/got/subscribers","subscription_url":"https://api.github.com/repos/szmarczak/got/subscription","commits_url":"https://api.github.com/repos/szmarczak/got/commits{/sha}","git_commits_url":"https://api.github.com/repos/szmarczak/got/git/commits{/sha}","comments_url":"https://api.github.com/repos/szmarczak/got/comments{/number}","issue_comment_url":"https://api.github.com/repos/szmarczak/got/issues/comments{/number}","contents_url":"https://api.github.com/repos/szmarczak/got/contents/{+path}","compare_url":"https://api.github.com/repos/szmarczak/got/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szmarczak/got/merges","archive_url":"https://api.github.com/repos/szmarczak/got/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szmarczak/got/downloads","issues_url":"https://api.github.com/repos/szmarczak/got/issues{/number}","pulls_url":"https://api.github.com/repos/szmarczak/got/pulls{/number}","milestones_url":"https://api.github.com/repos/szmarczak/got/milestones{/number}","notifications_url":"https://api.github.com/repos/szmarczak/got/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szmarczak/got/labels{/name}","releases_url":"https://api.github.com/repos/szmarczak/got/releases{/id}","deployments_url":"https://api.github.com/repos/szmarczak/got/deployments","created_at":"2018-02-27T18:18:00Z","updated_at":"2018-08-11T07:16:13Z","pushed_at":"2019-08-04T15:29:07Z","git_url":"git://github.com/szmarczak/got.git","ssh_url":"git@github.com:szmarczak/got.git","clone_url":"https://github.com/szmarczak/got.git","svn_url":"https://github.com/szmarczak/got","homepage":"","size":1766,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"dc9030af47b1922f2ac729ab9b54fc79397a250d","user":{"login":"sindresorhus","id":170270,"node_id":"MDQ6VXNlcjE3MDI3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/170270?v=4","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":18193978,"node_id":"MDEwOlJlcG9zaXRvcnkxODE5Mzk3OA==","name":"got","full_name":"sindresorhus/got","private":false,"owner":{"login":"sindresorhus","id":170270,"node_id":"MDQ6VXNlcjE3MDI3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/170270?v=4","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sindresorhus/got","description":"Simplified HTTP requests","fork":false,"url":"https://api.github.com/repos/sindresorhus/got","forks_url":"https://api.github.com/repos/sindresorhus/got/forks","keys_url":"https://api.github.com/repos/sindresorhus/got/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/got/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/got/teams","hooks_url":"https://api.github.com/repos/sindresorhus/got/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/got/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/got/events","assignees_url":"https://api.github.com/repos/sindresorhus/got/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/got/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/got/tags","blobs_url":"https://api.github.com/repos/sindresorhus/got/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/got/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/got/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/got/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/got/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/got/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/got/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/got/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/got/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/got/subscription","commits_url":"https://api.github.com/repos/sindresorhus/got/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/got/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/got/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/got/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindresorhus/got/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/got/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/got/merges","archive_url":"https://api.github.com/repos/sindresorhus/got/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/got/downloads","issues_url":"https://api.github.com/repos/sindresorhus/got/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/got/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/got/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/got/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/got/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/got/releases{/id}","deployments_url":"https://api.github.com/repos/sindresorhus/got/deployments","created_at":"2014-03-27T22:40:49Z","updated_at":"2019-08-04T02:18:16Z","pushed_at":"2019-08-04T15:29:08Z","git_url":"git://github.com/sindresorhus/got.git","ssh_url":"git@github.com:sindresorhus/got.git","clone_url":"https://github.com/sindresorhus/got.git","svn_url":"https://github.com/sindresorhus/got","homepage":"","size":1492,"stargazers_count":5605,"watchers_count":5605,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":325,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":325,"open_issues":37,"watchers":5605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/707"},"html":{"href":"https://github.com/sindresorhus/got/pull/707"},"issue":{"href":"https://api.github.com/repos/sindresorhus/got/issues/707"},"comments":{"href":"https://api.github.com/repos/sindresorhus/got/issues/707/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/707/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/707/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/got/statuses/5cea30bc51d76183ad3dd397c4a443ef97cd3d32"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"szmarczak"}}