{"action":"created","comment":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/263283264","pull_request_review_id":211656191,"id":263283264,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzI4MzI2NA==","diff_hunk":"@@ -182,35 +179,35 @@ void Feed::handleMaxArticlesPerFeedChanged(const int n)\n     // We don't need store articles here\n }\n \n-void Feed::handleIconDownloadFinished(const QString &url, const QString &filePath)\n+void Feed::handleIconDownloadFinished(const Net::DownloadResult &result)\n {\n-    Q_UNUSED(url);\n-\n-    m_iconPath = Utils::Fs::fromNativePath(filePath);\n-    emit iconLoaded(this);\n+    if (result.status == Net::DownloadStatus::Success) {\n+        m_iconPath = Utils::Fs::fromNativePath(result.filePath);\n+        emit iconLoaded(this);\n+    }\n }\n \n bool Feed::hasError() const\n {\n     return m_hasError;\n }\n \n-void Feed::handleDownloadFinished(const QString &url, const QByteArray &data)\n-{\n-    qDebug() << \"Successfully downloaded RSS feed at\" << url;\n-    // Parse the download RSS\n-    m_parser->parse(data);\n-}\n-\n-void Feed::handleDownloadFailed(const QString &url, const QString &error)\n+void Feed::handleDownloadFinished(const Net::DownloadResult &result)\n {\n-    m_isLoading = false;\n-    m_hasError = true;\n+    if (result.status == Net::DownloadStatus::Success) {\n+        qDebug() << \"Successfully downloaded RSS feed at\" << result.url;\n+        // Parse the download RSS\n+        m_parser->parse(result.data);\n+    }\n+    else {\n+        m_isLoading = false;\n+        m_hasError = true;\n \n-    LogMsg(tr(\"Failed to download RSS feed at '%1'. Reason: %2\").arg(url, error)\n-           , Log::WARNING);\n+        LogMsg(tr(\"Failed to download RSS feed at '%1'. Reason: %2\")\n+               .arg(result.url, result.errorString), Log::WARNING);","path":"src/base/rss/rss_feed.cpp","position":67,"original_position":58,"commit_id":"fa67424a7d824522e10895cb6e990c1adedd5d11","original_commit_id":"6cb15706f5eee546ef357a8cefd99be87168619a","user":{"login":"glassez","id":5063477,"node_id":"MDQ6VXNlcjUwNjM0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5063477?v=4","gravatar_id":"","url":"https://api.github.com/users/glassez","html_url":"https://github.com/glassez","followers_url":"https://api.github.com/users/glassez/followers","following_url":"https://api.github.com/users/glassez/following{/other_user}","gists_url":"https://api.github.com/users/glassez/gists{/gist_id}","starred_url":"https://api.github.com/users/glassez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassez/subscriptions","organizations_url":"https://api.github.com/users/glassez/orgs","repos_url":"https://api.github.com/users/glassez/repos","events_url":"https://api.github.com/users/glassez/events{/privacy}","received_events_url":"https://api.github.com/users/glassez/received_events","type":"User","site_admin":false},"body":"Ok.","created_at":"2019-03-07T08:45:29Z","updated_at":"2019-03-07T08:45:29Z","html_url":"https://github.com/qbittorrent/qBittorrent/pull/10346#discussion_r263283264","pull_request_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/10346","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/263283264"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/10346#discussion_r263283264"},"pull_request":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/10346"}},"in_reply_to_id":262543157},"pull_request":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/10346","id":258199401,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4MTk5NDAx","html_url":"https://github.com/qbittorrent/qBittorrent/pull/10346","diff_url":"https://github.com/qbittorrent/qBittorrent/pull/10346.diff","patch_url":"https://github.com/qbittorrent/qBittorrent/pull/10346.patch","issue_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/10346","number":10346,"state":"open","locked":false,"title":"Improve \"Download manager\"","user":{"login":"glassez","id":5063477,"node_id":"MDQ6VXNlcjUwNjM0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5063477?v=4","gravatar_id":"","url":"https://api.github.com/users/glassez","html_url":"https://github.com/glassez","followers_url":"https://api.github.com/users/glassez/followers","following_url":"https://api.github.com/users/glassez/following{/other_user}","gists_url":"https://api.github.com/users/glassez/gists{/gist_id}","starred_url":"https://api.github.com/users/glassez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassez/subscriptions","organizations_url":"https://api.github.com/users/glassez/orgs","repos_url":"https://api.github.com/users/glassez/repos","events_url":"https://api.github.com/users/glassez/events{/privacy}","received_events_url":"https://api.github.com/users/glassez/received_events","type":"User","site_admin":false},"body":"Reduce the number of signals to simplify/unify handling.\r\nSince DownloadHandler is used only to maintain signal-to-slot connection (from the client perspective) it is moved behind the scene.\r\nUse Qt builtin HTTP redirection handling feature (requires Qt >= 5.9).","created_at":"2019-03-05T06:24:23Z","updated_at":"2019-03-07T08:45:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0661396c8f09ce34f604911df91ac4ad7e449963","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":662470851,"node_id":"MDU6TGFiZWw2NjI0NzA4NTE=","url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels/Core","name":"Core","color":"111111","default":false},{"id":30571077,"node_id":"MDU6TGFiZWwzMDU3MTA3Nw==","url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels/Network","name":"Network","color":"02d7e1","default":false}],"milestone":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/milestones/38","html_url":"https://github.com/qbittorrent/qBittorrent/milestone/38","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/milestones/38/labels","id":2660214,"node_id":"MDk6TWlsZXN0b25lMjY2MDIxNA==","number":38,"title":"4.2.0","description":"","creator":{"login":"glassez","id":5063477,"node_id":"MDQ6VXNlcjUwNjM0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5063477?v=4","gravatar_id":"","url":"https://api.github.com/users/glassez","html_url":"https://github.com/glassez","followers_url":"https://api.github.com/users/glassez/followers","following_url":"https://api.github.com/users/glassez/following{/other_user}","gists_url":"https://api.github.com/users/glassez/gists{/gist_id}","starred_url":"https://api.github.com/users/glassez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassez/subscriptions","organizations_url":"https://api.github.com/users/glassez/orgs","repos_url":"https://api.github.com/users/glassez/repos","events_url":"https://api.github.com/users/glassez/events{/privacy}","received_events_url":"https://api.github.com/users/glassez/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":17,"state":"open","created_at":"2017-07-25T08:58:00Z","updated_at":"2019-03-07T08:39:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/10346/commits","review_comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/10346/comments","review_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/10346/comments","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/fa67424a7d824522e10895cb6e990c1adedd5d11","head":{"label":"glassez:download-manager","ref":"download-manager","sha":"fa67424a7d824522e10895cb6e990c1adedd5d11","user":{"login":"glassez","id":5063477,"node_id":"MDQ6VXNlcjUwNjM0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5063477?v=4","gravatar_id":"","url":"https://api.github.com/users/glassez","html_url":"https://github.com/glassez","followers_url":"https://api.github.com/users/glassez/followers","following_url":"https://api.github.com/users/glassez/following{/other_user}","gists_url":"https://api.github.com/users/glassez/gists{/gist_id}","starred_url":"https://api.github.com/users/glassez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassez/subscriptions","organizations_url":"https://api.github.com/users/glassez/orgs","repos_url":"https://api.github.com/users/glassez/repos","events_url":"https://api.github.com/users/glassez/events{/privacy}","received_events_url":"https://api.github.com/users/glassez/received_events","type":"User","site_admin":false},"repo":{"id":11788320,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4ODMyMA==","name":"qBittorrent","full_name":"glassez/qBittorrent","private":false,"owner":{"login":"glassez","id":5063477,"node_id":"MDQ6VXNlcjUwNjM0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5063477?v=4","gravatar_id":"","url":"https://api.github.com/users/glassez","html_url":"https://github.com/glassez","followers_url":"https://api.github.com/users/glassez/followers","following_url":"https://api.github.com/users/glassez/following{/other_user}","gists_url":"https://api.github.com/users/glassez/gists{/gist_id}","starred_url":"https://api.github.com/users/glassez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassez/subscriptions","organizations_url":"https://api.github.com/users/glassez/orgs","repos_url":"https://api.github.com/users/glassez/repos","events_url":"https://api.github.com/users/glassez/events{/privacy}","received_events_url":"https://api.github.com/users/glassez/received_events","type":"User","site_admin":false},"html_url":"https://github.com/glassez/qBittorrent","description":"qBittorrent BitTorrent client","fork":true,"url":"https://api.github.com/repos/glassez/qBittorrent","forks_url":"https://api.github.com/repos/glassez/qBittorrent/forks","keys_url":"https://api.github.com/repos/glassez/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glassez/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glassez/qBittorrent/teams","hooks_url":"https://api.github.com/repos/glassez/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/glassez/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/glassez/qBittorrent/events","assignees_url":"https://api.github.com/repos/glassez/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/glassez/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/glassez/qBittorrent/tags","blobs_url":"https://api.github.com/repos/glassez/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glassez/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glassez/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/glassez/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glassez/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/glassez/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/glassez/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/glassez/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/glassez/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/glassez/qBittorrent/subscription","commits_url":"https://api.github.com/repos/glassez/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/glassez/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/glassez/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/glassez/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/glassez/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/glassez/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glassez/qBittorrent/merges","archive_url":"https://api.github.com/repos/glassez/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glassez/qBittorrent/downloads","issues_url":"https://api.github.com/repos/glassez/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/glassez/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/glassez/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/glassez/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glassez/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/glassez/qBittorrent/releases{/id}","deployments_url":"https://api.github.com/repos/glassez/qBittorrent/deployments","created_at":"2013-07-31T10:19:53Z","updated_at":"2019-02-13T15:48:59Z","pushed_at":"2019-03-07T08:41:56Z","git_url":"git://github.com/glassez/qBittorrent.git","ssh_url":"git@github.com:glassez/qBittorrent.git","clone_url":"https://github.com/glassez/qBittorrent.git","svn_url":"https://github.com/glassez/qBittorrent","homepage":"http://www.qbittorrent.org","size":154767,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"qbittorrent:master","ref":"master","sha":"ccd8f3e0f1447c0f88fedb975b52e2691722d6e9","user":{"login":"qbittorrent","id":2131270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzEyNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2131270?v=4","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"repo":{"id":3351871,"node_id":"MDEwOlJlcG9zaXRvcnkzMzUxODcx","name":"qBittorrent","full_name":"qbittorrent/qBittorrent","private":false,"owner":{"login":"qbittorrent","id":2131270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzEyNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2131270?v=4","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qbittorrent/qBittorrent","description":"qBittorrent BitTorrent client","fork":false,"url":"https://api.github.com/repos/qbittorrent/qBittorrent","forks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/forks","keys_url":"https://api.github.com/repos/qbittorrent/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qbittorrent/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qbittorrent/qBittorrent/teams","hooks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/events","assignees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/qbittorrent/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/tags","blobs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/qbittorrent/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscription","commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/qbittorrent/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qbittorrent/qBittorrent/merges","archive_url":"https://api.github.com/repos/qbittorrent/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qbittorrent/qBittorrent/downloads","issues_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/qbittorrent/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/qbittorrent/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/qbittorrent/qBittorrent/releases{/id}","deployments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/deployments","created_at":"2012-02-04T09:37:46Z","updated_at":"2019-03-07T07:15:13Z","pushed_at":"2019-03-07T08:41:58Z","git_url":"git://github.com/qbittorrent/qBittorrent.git","ssh_url":"git@github.com:qbittorrent/qBittorrent.git","clone_url":"https://github.com/qbittorrent/qBittorrent.git","svn_url":"https://github.com/qbittorrent/qBittorrent","homepage":"https://www.qbittorrent.org","size":171146,"stargazers_count":5884,"watchers_count":5884,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1009,"mirror_url":null,"archived":false,"open_issues_count":2405,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1009,"open_issues":2405,"watchers":5884,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/10346"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/10346"},"issue":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/10346"},"comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/10346/comments"},"review_comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/10346/comments"},"review_comment":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/10346/commits"},"statuses":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/fa67424a7d824522e10895cb6e990c1adedd5d11"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"glassez"}}