{"action":"created","comment":{"url":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/comments/315634410","pull_request_review_id":277095164,"id":315634410,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNTYzNDQxMA==","diff_hunk":"@@ -78,7 +81,8 @@ case class NegationRuleInterpreter(rule: NegationConformanceRule) extends RuleIn\n       case _: ShortType => when(inputColumn === Short.MinValue, errorColumnUDF).otherwise(null)\n       case _: IntegerType => when(inputColumn === Int.MinValue, errorColumnUDF).otherwise(null)\n       case _: LongType => when(inputColumn === Long.MinValue, errorColumnUDF).otherwise(null)\n-      case _ => null\n+      case a => throw new IllegalArgumentException(\"NegationRuleInterpreter.getError() should be called only for \" +","path":"conformance/src/main/scala/za/co/absa/enceladus/conformance/interpreter/rules/NegationRuleInterpreter.scala","position":26,"original_position":26,"commit_id":"63946c3bceeecd6cb22e5d01c155671807302277","original_commit_id":"b1900e496c4e41558932aa1557218222eefb2e88","user":{"login":"yruslan","id":4082463,"node_id":"MDQ6VXNlcjQwODI0NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4082463?v=4","gravatar_id":"","url":"https://api.github.com/users/yruslan","html_url":"https://github.com/yruslan","followers_url":"https://api.github.com/users/yruslan/followers","following_url":"https://api.github.com/users/yruslan/following{/other_user}","gists_url":"https://api.github.com/users/yruslan/gists{/gist_id}","starred_url":"https://api.github.com/users/yruslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yruslan/subscriptions","organizations_url":"https://api.github.com/users/yruslan/orgs","repos_url":"https://api.github.com/users/yruslan/repos","events_url":"https://api.github.com/users/yruslan/events{/privacy}","received_events_url":"https://api.github.com/users/yruslan/received_events","type":"User","site_admin":false},"body":"Exactly. That branch should be unreachable. But when a new data type is added and the function returns null the error message we get doesn't make any sense. It is a NullPointerException somewhere deep in DeepArrayTransformation. Double deep 😄 ","created_at":"2019-08-20T11:18:57Z","updated_at":"2019-08-20T11:18:57Z","html_url":"https://github.com/AbsaOSS/enceladus/pull/821#discussion_r315634410","pull_request_url":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/821","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/comments/315634410"},"html":{"href":"https://github.com/AbsaOSS/enceladus/pull/821#discussion_r315634410"},"pull_request":{"href":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/821"}},"in_reply_to_id":315614855},"pull_request":{"url":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/821","id":308934143,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4OTM0MTQz","html_url":"https://github.com/AbsaOSS/enceladus/pull/821","diff_url":"https://github.com/AbsaOSS/enceladus/pull/821.diff","patch_url":"https://github.com/AbsaOSS/enceladus/pull/821.patch","issue_url":"https://api.github.com/repos/AbsaOSS/enceladus/issues/821","number":821,"state":"open","locked":false,"title":"Feature/773 negation rule on bool","user":{"login":"Zejnilovic","id":17467768,"node_id":"MDQ6VXNlcjE3NDY3NzY4","avatar_url":"https://avatars3.githubusercontent.com/u/17467768?v=4","gravatar_id":"","url":"https://api.github.com/users/Zejnilovic","html_url":"https://github.com/Zejnilovic","followers_url":"https://api.github.com/users/Zejnilovic/followers","following_url":"https://api.github.com/users/Zejnilovic/following{/other_user}","gists_url":"https://api.github.com/users/Zejnilovic/gists{/gist_id}","starred_url":"https://api.github.com/users/Zejnilovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zejnilovic/subscriptions","organizations_url":"https://api.github.com/users/Zejnilovic/orgs","repos_url":"https://api.github.com/users/Zejnilovic/repos","events_url":"https://api.github.com/users/Zejnilovic/events{/privacy}","received_events_url":"https://api.github.com/users/Zejnilovic/received_events","type":"User","site_admin":false},"body":"Allow negation rule to be used on booleans\r\n\r\nWith great help from @yruslan ","created_at":"2019-08-20T08:29:47Z","updated_at":"2019-08-20T11:18:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6073efdb23cb169f5e19a1b57d28158c7798fe5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/821/commits","review_comments_url":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/821/comments","review_comment_url":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AbsaOSS/enceladus/issues/821/comments","statuses_url":"https://api.github.com/repos/AbsaOSS/enceladus/statuses/63946c3bceeecd6cb22e5d01c155671807302277","head":{"label":"AbsaOSS:feature/773-negation-rule-on-bool","ref":"feature/773-negation-rule-on-bool","sha":"63946c3bceeecd6cb22e5d01c155671807302277","user":{"login":"AbsaOSS","id":18133719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTMzNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/18133719?v=4","gravatar_id":"","url":"https://api.github.com/users/AbsaOSS","html_url":"https://github.com/AbsaOSS","followers_url":"https://api.github.com/users/AbsaOSS/followers","following_url":"https://api.github.com/users/AbsaOSS/following{/other_user}","gists_url":"https://api.github.com/users/AbsaOSS/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsaOSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsaOSS/subscriptions","organizations_url":"https://api.github.com/users/AbsaOSS/orgs","repos_url":"https://api.github.com/users/AbsaOSS/repos","events_url":"https://api.github.com/users/AbsaOSS/events{/privacy}","received_events_url":"https://api.github.com/users/AbsaOSS/received_events","type":"Organization","site_admin":false},"repo":{"id":154513089,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MTMwODk=","name":"enceladus","full_name":"AbsaOSS/enceladus","private":false,"owner":{"login":"AbsaOSS","id":18133719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTMzNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/18133719?v=4","gravatar_id":"","url":"https://api.github.com/users/AbsaOSS","html_url":"https://github.com/AbsaOSS","followers_url":"https://api.github.com/users/AbsaOSS/followers","following_url":"https://api.github.com/users/AbsaOSS/following{/other_user}","gists_url":"https://api.github.com/users/AbsaOSS/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsaOSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsaOSS/subscriptions","organizations_url":"https://api.github.com/users/AbsaOSS/orgs","repos_url":"https://api.github.com/users/AbsaOSS/repos","events_url":"https://api.github.com/users/AbsaOSS/events{/privacy}","received_events_url":"https://api.github.com/users/AbsaOSS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AbsaOSS/enceladus","description":"Dynamic Conformance Engine","fork":false,"url":"https://api.github.com/repos/AbsaOSS/enceladus","forks_url":"https://api.github.com/repos/AbsaOSS/enceladus/forks","keys_url":"https://api.github.com/repos/AbsaOSS/enceladus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbsaOSS/enceladus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbsaOSS/enceladus/teams","hooks_url":"https://api.github.com/repos/AbsaOSS/enceladus/hooks","issue_events_url":"https://api.github.com/repos/AbsaOSS/enceladus/issues/events{/number}","events_url":"https://api.github.com/repos/AbsaOSS/enceladus/events","assignees_url":"https://api.github.com/repos/AbsaOSS/enceladus/assignees{/user}","branches_url":"https://api.github.com/repos/AbsaOSS/enceladus/branches{/branch}","tags_url":"https://api.github.com/repos/AbsaOSS/enceladus/tags","blobs_url":"https://api.github.com/repos/AbsaOSS/enceladus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbsaOSS/enceladus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbsaOSS/enceladus/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbsaOSS/enceladus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbsaOSS/enceladus/statuses/{sha}","languages_url":"https://api.github.com/repos/AbsaOSS/enceladus/languages","stargazers_url":"https://api.github.com/repos/AbsaOSS/enceladus/stargazers","contributors_url":"https://api.github.com/repos/AbsaOSS/enceladus/contributors","subscribers_url":"https://api.github.com/repos/AbsaOSS/enceladus/subscribers","subscription_url":"https://api.github.com/repos/AbsaOSS/enceladus/subscription","commits_url":"https://api.github.com/repos/AbsaOSS/enceladus/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbsaOSS/enceladus/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbsaOSS/enceladus/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbsaOSS/enceladus/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbsaOSS/enceladus/contents/{+path}","compare_url":"https://api.github.com/repos/AbsaOSS/enceladus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbsaOSS/enceladus/merges","archive_url":"https://api.github.com/repos/AbsaOSS/enceladus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbsaOSS/enceladus/downloads","issues_url":"https://api.github.com/repos/AbsaOSS/enceladus/issues{/number}","pulls_url":"https://api.github.com/repos/AbsaOSS/enceladus/pulls{/number}","milestones_url":"https://api.github.com/repos/AbsaOSS/enceladus/milestones{/number}","notifications_url":"https://api.github.com/repos/AbsaOSS/enceladus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbsaOSS/enceladus/labels{/name}","releases_url":"https://api.github.com/repos/AbsaOSS/enceladus/releases{/id}","deployments_url":"https://api.github.com/repos/AbsaOSS/enceladus/deployments","created_at":"2018-10-24T14:12:46Z","updated_at":"2019-08-20T08:58:34Z","pushed_at":"2019-08-20T11:17:57Z","git_url":"git://github.com/AbsaOSS/enceladus.git","ssh_url":"git@github.com:AbsaOSS/enceladus.git","clone_url":"https://github.com/AbsaOSS/enceladus.git","svn_url":"https://github.com/AbsaOSS/enceladus","homepage":"","size":3231,"stargazers_count":14,"watchers_count":14,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":227,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":227,"watchers":14,"default_branch":"develop"}},"base":{"label":"AbsaOSS:develop","ref":"develop","sha":"2cb9adb16bf80790c151d6ef7acc6afef9b3f008","user":{"login":"AbsaOSS","id":18133719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTMzNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/18133719?v=4","gravatar_id":"","url":"https://api.github.com/users/AbsaOSS","html_url":"https://github.com/AbsaOSS","followers_url":"https://api.github.com/users/AbsaOSS/followers","following_url":"https://api.github.com/users/AbsaOSS/following{/other_user}","gists_url":"https://api.github.com/users/AbsaOSS/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsaOSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsaOSS/subscriptions","organizations_url":"https://api.github.com/users/AbsaOSS/orgs","repos_url":"https://api.github.com/users/AbsaOSS/repos","events_url":"https://api.github.com/users/AbsaOSS/events{/privacy}","received_events_url":"https://api.github.com/users/AbsaOSS/received_events","type":"Organization","site_admin":false},"repo":{"id":154513089,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MTMwODk=","name":"enceladus","full_name":"AbsaOSS/enceladus","private":false,"owner":{"login":"AbsaOSS","id":18133719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTMzNzE5","avatar_url":"https://avatars0.githubusercontent.com/u/18133719?v=4","gravatar_id":"","url":"https://api.github.com/users/AbsaOSS","html_url":"https://github.com/AbsaOSS","followers_url":"https://api.github.com/users/AbsaOSS/followers","following_url":"https://api.github.com/users/AbsaOSS/following{/other_user}","gists_url":"https://api.github.com/users/AbsaOSS/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsaOSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsaOSS/subscriptions","organizations_url":"https://api.github.com/users/AbsaOSS/orgs","repos_url":"https://api.github.com/users/AbsaOSS/repos","events_url":"https://api.github.com/users/AbsaOSS/events{/privacy}","received_events_url":"https://api.github.com/users/AbsaOSS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AbsaOSS/enceladus","description":"Dynamic Conformance Engine","fork":false,"url":"https://api.github.com/repos/AbsaOSS/enceladus","forks_url":"https://api.github.com/repos/AbsaOSS/enceladus/forks","keys_url":"https://api.github.com/repos/AbsaOSS/enceladus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbsaOSS/enceladus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbsaOSS/enceladus/teams","hooks_url":"https://api.github.com/repos/AbsaOSS/enceladus/hooks","issue_events_url":"https://api.github.com/repos/AbsaOSS/enceladus/issues/events{/number}","events_url":"https://api.github.com/repos/AbsaOSS/enceladus/events","assignees_url":"https://api.github.com/repos/AbsaOSS/enceladus/assignees{/user}","branches_url":"https://api.github.com/repos/AbsaOSS/enceladus/branches{/branch}","tags_url":"https://api.github.com/repos/AbsaOSS/enceladus/tags","blobs_url":"https://api.github.com/repos/AbsaOSS/enceladus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbsaOSS/enceladus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbsaOSS/enceladus/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbsaOSS/enceladus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbsaOSS/enceladus/statuses/{sha}","languages_url":"https://api.github.com/repos/AbsaOSS/enceladus/languages","stargazers_url":"https://api.github.com/repos/AbsaOSS/enceladus/stargazers","contributors_url":"https://api.github.com/repos/AbsaOSS/enceladus/contributors","subscribers_url":"https://api.github.com/repos/AbsaOSS/enceladus/subscribers","subscription_url":"https://api.github.com/repos/AbsaOSS/enceladus/subscription","commits_url":"https://api.github.com/repos/AbsaOSS/enceladus/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbsaOSS/enceladus/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbsaOSS/enceladus/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbsaOSS/enceladus/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbsaOSS/enceladus/contents/{+path}","compare_url":"https://api.github.com/repos/AbsaOSS/enceladus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbsaOSS/enceladus/merges","archive_url":"https://api.github.com/repos/AbsaOSS/enceladus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbsaOSS/enceladus/downloads","issues_url":"https://api.github.com/repos/AbsaOSS/enceladus/issues{/number}","pulls_url":"https://api.github.com/repos/AbsaOSS/enceladus/pulls{/number}","milestones_url":"https://api.github.com/repos/AbsaOSS/enceladus/milestones{/number}","notifications_url":"https://api.github.com/repos/AbsaOSS/enceladus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbsaOSS/enceladus/labels{/name}","releases_url":"https://api.github.com/repos/AbsaOSS/enceladus/releases{/id}","deployments_url":"https://api.github.com/repos/AbsaOSS/enceladus/deployments","created_at":"2018-10-24T14:12:46Z","updated_at":"2019-08-20T08:58:34Z","pushed_at":"2019-08-20T11:17:57Z","git_url":"git://github.com/AbsaOSS/enceladus.git","ssh_url":"git@github.com:AbsaOSS/enceladus.git","clone_url":"https://github.com/AbsaOSS/enceladus.git","svn_url":"https://github.com/AbsaOSS/enceladus","homepage":"","size":3231,"stargazers_count":14,"watchers_count":14,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":227,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":227,"watchers":14,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/821"},"html":{"href":"https://github.com/AbsaOSS/enceladus/pull/821"},"issue":{"href":"https://api.github.com/repos/AbsaOSS/enceladus/issues/821"},"comments":{"href":"https://api.github.com/repos/AbsaOSS/enceladus/issues/821/comments"},"review_comments":{"href":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/821/comments"},"review_comment":{"href":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AbsaOSS/enceladus/pulls/821/commits"},"statuses":{"href":"https://api.github.com/repos/AbsaOSS/enceladus/statuses/63946c3bceeecd6cb22e5d01c155671807302277"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yruslan"}}