{"action":"created","comment":{"url":"https://api.github.com/repos/BrightSpots/rcv/pulls/comments/300806658","pull_request_review_id":258562356,"id":300806658,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDgwNjY1OA==","diff_hunk":"@@ -803,7 +824,11 @@ private void processCandidateData() {\n     }\n \n     if (getTiebreakMode() == TieBreakMode.GENERATE_PERMUTATION) {\n-      Collections.shuffle(candidatePermutation);\n+      // If the random seed is null, validation will fail anyway, so let's not throw an exception\n+      // here.","path":"src/main/java/network/brightspots/rcv/ContestConfig.java","position":93,"original_position":93,"commit_id":"4d6fea82e07f0ada6e1aa84f9de06368c3d82520","original_commit_id":"4d6fea82e07f0ada6e1aa84f9de06368c3d82520","user":{"login":"tarheel","id":352413,"node_id":"MDQ6VXNlcjM1MjQxMw==","avatar_url":"https://avatars0.githubusercontent.com/u/352413?v=4","gravatar_id":"","url":"https://api.github.com/users/tarheel","html_url":"https://github.com/tarheel","followers_url":"https://api.github.com/users/tarheel/followers","following_url":"https://api.github.com/users/tarheel/following{/other_user}","gists_url":"https://api.github.com/users/tarheel/gists{/gist_id}","starred_url":"https://api.github.com/users/tarheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarheel/subscriptions","organizations_url":"https://api.github.com/users/tarheel/orgs","repos_url":"https://api.github.com/users/tarheel/repos","events_url":"https://api.github.com/users/tarheel/events{/privacy}","received_events_url":"https://api.github.com/users/tarheel/received_events","type":"User","site_admin":false},"body":"Hmm, I think I disagree. Without the comment, someone reading this code might think that it's a legitimate use case to have mode = GENERATE_PERMUTATION and random seed = null.\r\n\r\n@moldover thoughts?","created_at":"2019-07-05T22:35:54Z","updated_at":"2019-07-05T22:35:55Z","html_url":"https://github.com/BrightSpots/rcv/pull/313#discussion_r300806658","pull_request_url":"https://api.github.com/repos/BrightSpots/rcv/pulls/313","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/BrightSpots/rcv/pulls/comments/300806658"},"html":{"href":"https://github.com/BrightSpots/rcv/pull/313#discussion_r300806658"},"pull_request":{"href":"https://api.github.com/repos/BrightSpots/rcv/pulls/313"}},"in_reply_to_id":300801614},"pull_request":{"url":"https://api.github.com/repos/BrightSpots/rcv/pulls/313","id":290982503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwOTgyNTAz","html_url":"https://github.com/BrightSpots/rcv/pull/313","diff_url":"https://github.com/BrightSpots/rcv/pull/313.diff","patch_url":"https://github.com/BrightSpots/rcv/pull/313.patch","issue_url":"https://api.github.com/repos/BrightSpots/rcv/issues/313","number":313,"state":"open","locked":false,"title":"add random seed","user":{"login":"tarheel","id":352413,"node_id":"MDQ6VXNlcjM1MjQxMw==","avatar_url":"https://avatars0.githubusercontent.com/u/352413?v=4","gravatar_id":"","url":"https://api.github.com/users/tarheel","html_url":"https://github.com/tarheel","followers_url":"https://api.github.com/users/tarheel/followers","following_url":"https://api.github.com/users/tarheel/following{/other_user}","gists_url":"https://api.github.com/users/tarheel/gists{/gist_id}","starred_url":"https://api.github.com/users/tarheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarheel/subscriptions","organizations_url":"https://api.github.com/users/tarheel/orgs","repos_url":"https://api.github.com/users/tarheel/repos","events_url":"https://api.github.com/users/tarheel/events{/privacy}","received_events_url":"https://api.github.com/users/tarheel/received_events","type":"User","site_admin":false},"body":"Fixes #170.\r\n\r\nI'll need to update some of the existing test configs before committing this, since they'll now fail the validation that I added.","created_at":"2019-06-24T06:01:33Z","updated_at":"2019-07-05T22:35:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"682a5ddefc5ffc383a6db8b9276419d958824373","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BrightSpots/rcv/pulls/313/commits","review_comments_url":"https://api.github.com/repos/BrightSpots/rcv/pulls/313/comments","review_comment_url":"https://api.github.com/repos/BrightSpots/rcv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BrightSpots/rcv/issues/313/comments","statuses_url":"https://api.github.com/repos/BrightSpots/rcv/statuses/4d6fea82e07f0ada6e1aa84f9de06368c3d82520","head":{"label":"BrightSpots:random-seed","ref":"random-seed","sha":"4d6fea82e07f0ada6e1aa84f9de06368c3d82520","user":{"login":"BrightSpots","id":28843626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODQzNjI2","avatar_url":"https://avatars0.githubusercontent.com/u/28843626?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightSpots","html_url":"https://github.com/BrightSpots","followers_url":"https://api.github.com/users/BrightSpots/followers","following_url":"https://api.github.com/users/BrightSpots/following{/other_user}","gists_url":"https://api.github.com/users/BrightSpots/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightSpots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightSpots/subscriptions","organizations_url":"https://api.github.com/users/BrightSpots/orgs","repos_url":"https://api.github.com/users/BrightSpots/repos","events_url":"https://api.github.com/users/BrightSpots/events{/privacy}","received_events_url":"https://api.github.com/users/BrightSpots/received_events","type":"Organization","site_admin":false},"repo":{"id":91972800,"node_id":"MDEwOlJlcG9zaXRvcnk5MTk3MjgwMA==","name":"rcv","full_name":"BrightSpots/rcv","private":false,"owner":{"login":"BrightSpots","id":28843626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODQzNjI2","avatar_url":"https://avatars0.githubusercontent.com/u/28843626?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightSpots","html_url":"https://github.com/BrightSpots","followers_url":"https://api.github.com/users/BrightSpots/followers","following_url":"https://api.github.com/users/BrightSpots/following{/other_user}","gists_url":"https://api.github.com/users/BrightSpots/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightSpots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightSpots/subscriptions","organizations_url":"https://api.github.com/users/BrightSpots/orgs","repos_url":"https://api.github.com/users/BrightSpots/repos","events_url":"https://api.github.com/users/BrightSpots/events{/privacy}","received_events_url":"https://api.github.com/users/BrightSpots/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BrightSpots/rcv","description":"Ranked Choice Voting Universal Tabulator","fork":false,"url":"https://api.github.com/repos/BrightSpots/rcv","forks_url":"https://api.github.com/repos/BrightSpots/rcv/forks","keys_url":"https://api.github.com/repos/BrightSpots/rcv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrightSpots/rcv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrightSpots/rcv/teams","hooks_url":"https://api.github.com/repos/BrightSpots/rcv/hooks","issue_events_url":"https://api.github.com/repos/BrightSpots/rcv/issues/events{/number}","events_url":"https://api.github.com/repos/BrightSpots/rcv/events","assignees_url":"https://api.github.com/repos/BrightSpots/rcv/assignees{/user}","branches_url":"https://api.github.com/repos/BrightSpots/rcv/branches{/branch}","tags_url":"https://api.github.com/repos/BrightSpots/rcv/tags","blobs_url":"https://api.github.com/repos/BrightSpots/rcv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrightSpots/rcv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrightSpots/rcv/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrightSpots/rcv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrightSpots/rcv/statuses/{sha}","languages_url":"https://api.github.com/repos/BrightSpots/rcv/languages","stargazers_url":"https://api.github.com/repos/BrightSpots/rcv/stargazers","contributors_url":"https://api.github.com/repos/BrightSpots/rcv/contributors","subscribers_url":"https://api.github.com/repos/BrightSpots/rcv/subscribers","subscription_url":"https://api.github.com/repos/BrightSpots/rcv/subscription","commits_url":"https://api.github.com/repos/BrightSpots/rcv/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrightSpots/rcv/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrightSpots/rcv/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrightSpots/rcv/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrightSpots/rcv/contents/{+path}","compare_url":"https://api.github.com/repos/BrightSpots/rcv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrightSpots/rcv/merges","archive_url":"https://api.github.com/repos/BrightSpots/rcv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrightSpots/rcv/downloads","issues_url":"https://api.github.com/repos/BrightSpots/rcv/issues{/number}","pulls_url":"https://api.github.com/repos/BrightSpots/rcv/pulls{/number}","milestones_url":"https://api.github.com/repos/BrightSpots/rcv/milestones{/number}","notifications_url":"https://api.github.com/repos/BrightSpots/rcv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrightSpots/rcv/labels{/name}","releases_url":"https://api.github.com/repos/BrightSpots/rcv/releases{/id}","deployments_url":"https://api.github.com/repos/BrightSpots/rcv/deployments","created_at":"2017-05-21T16:49:44Z","updated_at":"2019-07-05T19:10:36Z","pushed_at":"2019-07-05T22:25:39Z","git_url":"git://github.com/BrightSpots/rcv.git","ssh_url":"git@github.com:BrightSpots/rcv.git","clone_url":"https://github.com/BrightSpots/rcv.git","svn_url":"https://github.com/BrightSpots/rcv","homepage":"","size":43657,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":71,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":71,"watchers":7,"default_branch":"master"}},"base":{"label":"BrightSpots:develop","ref":"develop","sha":"ef651534d904074cd1d639ab64c277a6bb312232","user":{"login":"BrightSpots","id":28843626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODQzNjI2","avatar_url":"https://avatars0.githubusercontent.com/u/28843626?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightSpots","html_url":"https://github.com/BrightSpots","followers_url":"https://api.github.com/users/BrightSpots/followers","following_url":"https://api.github.com/users/BrightSpots/following{/other_user}","gists_url":"https://api.github.com/users/BrightSpots/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightSpots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightSpots/subscriptions","organizations_url":"https://api.github.com/users/BrightSpots/orgs","repos_url":"https://api.github.com/users/BrightSpots/repos","events_url":"https://api.github.com/users/BrightSpots/events{/privacy}","received_events_url":"https://api.github.com/users/BrightSpots/received_events","type":"Organization","site_admin":false},"repo":{"id":91972800,"node_id":"MDEwOlJlcG9zaXRvcnk5MTk3MjgwMA==","name":"rcv","full_name":"BrightSpots/rcv","private":false,"owner":{"login":"BrightSpots","id":28843626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODQzNjI2","avatar_url":"https://avatars0.githubusercontent.com/u/28843626?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightSpots","html_url":"https://github.com/BrightSpots","followers_url":"https://api.github.com/users/BrightSpots/followers","following_url":"https://api.github.com/users/BrightSpots/following{/other_user}","gists_url":"https://api.github.com/users/BrightSpots/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightSpots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightSpots/subscriptions","organizations_url":"https://api.github.com/users/BrightSpots/orgs","repos_url":"https://api.github.com/users/BrightSpots/repos","events_url":"https://api.github.com/users/BrightSpots/events{/privacy}","received_events_url":"https://api.github.com/users/BrightSpots/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BrightSpots/rcv","description":"Ranked Choice Voting Universal Tabulator","fork":false,"url":"https://api.github.com/repos/BrightSpots/rcv","forks_url":"https://api.github.com/repos/BrightSpots/rcv/forks","keys_url":"https://api.github.com/repos/BrightSpots/rcv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrightSpots/rcv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrightSpots/rcv/teams","hooks_url":"https://api.github.com/repos/BrightSpots/rcv/hooks","issue_events_url":"https://api.github.com/repos/BrightSpots/rcv/issues/events{/number}","events_url":"https://api.github.com/repos/BrightSpots/rcv/events","assignees_url":"https://api.github.com/repos/BrightSpots/rcv/assignees{/user}","branches_url":"https://api.github.com/repos/BrightSpots/rcv/branches{/branch}","tags_url":"https://api.github.com/repos/BrightSpots/rcv/tags","blobs_url":"https://api.github.com/repos/BrightSpots/rcv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrightSpots/rcv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrightSpots/rcv/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrightSpots/rcv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrightSpots/rcv/statuses/{sha}","languages_url":"https://api.github.com/repos/BrightSpots/rcv/languages","stargazers_url":"https://api.github.com/repos/BrightSpots/rcv/stargazers","contributors_url":"https://api.github.com/repos/BrightSpots/rcv/contributors","subscribers_url":"https://api.github.com/repos/BrightSpots/rcv/subscribers","subscription_url":"https://api.github.com/repos/BrightSpots/rcv/subscription","commits_url":"https://api.github.com/repos/BrightSpots/rcv/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrightSpots/rcv/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrightSpots/rcv/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrightSpots/rcv/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrightSpots/rcv/contents/{+path}","compare_url":"https://api.github.com/repos/BrightSpots/rcv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrightSpots/rcv/merges","archive_url":"https://api.github.com/repos/BrightSpots/rcv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrightSpots/rcv/downloads","issues_url":"https://api.github.com/repos/BrightSpots/rcv/issues{/number}","pulls_url":"https://api.github.com/repos/BrightSpots/rcv/pulls{/number}","milestones_url":"https://api.github.com/repos/BrightSpots/rcv/milestones{/number}","notifications_url":"https://api.github.com/repos/BrightSpots/rcv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrightSpots/rcv/labels{/name}","releases_url":"https://api.github.com/repos/BrightSpots/rcv/releases{/id}","deployments_url":"https://api.github.com/repos/BrightSpots/rcv/deployments","created_at":"2017-05-21T16:49:44Z","updated_at":"2019-07-05T19:10:36Z","pushed_at":"2019-07-05T22:25:39Z","git_url":"git://github.com/BrightSpots/rcv.git","ssh_url":"git@github.com:BrightSpots/rcv.git","clone_url":"https://github.com/BrightSpots/rcv.git","svn_url":"https://github.com/BrightSpots/rcv","homepage":"","size":43657,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":71,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":71,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BrightSpots/rcv/pulls/313"},"html":{"href":"https://github.com/BrightSpots/rcv/pull/313"},"issue":{"href":"https://api.github.com/repos/BrightSpots/rcv/issues/313"},"comments":{"href":"https://api.github.com/repos/BrightSpots/rcv/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/BrightSpots/rcv/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/BrightSpots/rcv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BrightSpots/rcv/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/BrightSpots/rcv/statuses/4d6fea82e07f0ada6e1aa84f9de06368c3d82520"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tarheel"}}