{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/340288267","pull_request_review_id":308785787,"id":340288267,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MDI4ODI2Nw==","diff_hunk":"@@ -281,20 +281,24 @@ private static void CreateTempDirectoryWithAcl(string folder, string identity)\n         internal static DnnModel LoadDnnModel(IHostEnvironment env, string modelPath, bool metaGraph = false) =>\n             new DnnModel(GetSession(env, modelPath, metaGraph), modelPath);\n \n-        internal static DnnModel LoadDnnModel(IHostEnvironment env, Architecture arch, bool metaGraph = false)\n+        internal static DnnModel LoadDnnModel(IHostEnvironment env, Architecture arch, string path, bool metaGraph = false)\n         {\n             var modelFileName = ModelFileName[arch];\n+            var modelFilePath = Path.Combine(path, modelFileName);\n             int timeout = 10 * 60 * 1000;\n-            string currentDirectory = Directory.GetCurrentDirectory();\n-            DownloadIfNeeded(env, modelFileName, currentDirectory, modelFileName, timeout);\n+            if (path == null)","path":"src/Microsoft.ML.Dnn/DnnUtils.cs","position":12,"original_position":12,"commit_id":"94df351528af368230a9e585566b2ae8aab95ad0","original_commit_id":"f21f138264f672f4317a286f934f39004ffab614","user":{"login":"eerhardt","id":8291187,"node_id":"MDQ6VXNlcjgyOTExODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8291187?v=4","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"`if (string.IsNullOrEmpty(path))`","created_at":"2019-10-29T19:44:27Z","updated_at":"2019-10-29T19:44:27Z","html_url":"https://github.com/dotnet/machinelearning/pull/4410#discussion_r340288267","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/4410","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/340288267"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/4410#discussion_r340288267"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/4410"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/4410","id":333793734,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzNzkzNzM0","html_url":"https://github.com/dotnet/machinelearning/pull/4410","diff_url":"https://github.com/dotnet/machinelearning/pull/4410.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/4410.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/4410","number":4410,"state":"open","locked":false,"title":"Modify ImageClassification API to use a workspace for saving data","user":{"login":"bpstark","id":54910472,"node_id":"MDQ6VXNlcjU0OTEwNDcy","avatar_url":"https://avatars0.githubusercontent.com/u/54910472?v=4","gravatar_id":"","url":"https://api.github.com/users/bpstark","html_url":"https://github.com/bpstark","followers_url":"https://api.github.com/users/bpstark/followers","following_url":"https://api.github.com/users/bpstark/following{/other_user}","gists_url":"https://api.github.com/users/bpstark/gists{/gist_id}","starred_url":"https://api.github.com/users/bpstark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpstark/subscriptions","organizations_url":"https://api.github.com/users/bpstark/orgs","repos_url":"https://api.github.com/users/bpstark/repos","events_url":"https://api.github.com/users/bpstark/events{/privacy}","received_events_url":"https://api.github.com/users/bpstark/received_events","type":"User","site_admin":false},"body":"Originally this API saved data to the same directory as the DLL, this\r\ncould cause issues if the DLL was in a read only path. Instead moving to\r\ndefault to a temporary workspace path which can be defined in the\r\noptions by the user. This will allow all the data to be saved in one\r\npath.\r\n","created_at":"2019-10-29T18:23:29Z","updated_at":"2019-10-29T19:44:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"debf491b26a525db9a9b0511d5d6b795c9bef00b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/4410/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/4410/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/4410/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/94df351528af368230a9e585566b2ae8aab95ad0","head":{"label":"bpstark:fixPath","ref":"fixPath","sha":"94df351528af368230a9e585566b2ae8aab95ad0","user":{"login":"bpstark","id":54910472,"node_id":"MDQ6VXNlcjU0OTEwNDcy","avatar_url":"https://avatars0.githubusercontent.com/u/54910472?v=4","gravatar_id":"","url":"https://api.github.com/users/bpstark","html_url":"https://github.com/bpstark","followers_url":"https://api.github.com/users/bpstark/followers","following_url":"https://api.github.com/users/bpstark/following{/other_user}","gists_url":"https://api.github.com/users/bpstark/gists{/gist_id}","starred_url":"https://api.github.com/users/bpstark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpstark/subscriptions","organizations_url":"https://api.github.com/users/bpstark/orgs","repos_url":"https://api.github.com/users/bpstark/repos","events_url":"https://api.github.com/users/bpstark/events{/privacy}","received_events_url":"https://api.github.com/users/bpstark/received_events","type":"User","site_admin":false},"repo":{"id":206414436,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY0MTQ0MzY=","name":"machinelearning","full_name":"bpstark/machinelearning","private":false,"owner":{"login":"bpstark","id":54910472,"node_id":"MDQ6VXNlcjU0OTEwNDcy","avatar_url":"https://avatars0.githubusercontent.com/u/54910472?v=4","gravatar_id":"","url":"https://api.github.com/users/bpstark","html_url":"https://github.com/bpstark","followers_url":"https://api.github.com/users/bpstark/followers","following_url":"https://api.github.com/users/bpstark/following{/other_user}","gists_url":"https://api.github.com/users/bpstark/gists{/gist_id}","starred_url":"https://api.github.com/users/bpstark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpstark/subscriptions","organizations_url":"https://api.github.com/users/bpstark/orgs","repos_url":"https://api.github.com/users/bpstark/repos","events_url":"https://api.github.com/users/bpstark/events{/privacy}","received_events_url":"https://api.github.com/users/bpstark/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bpstark/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/bpstark/machinelearning","forks_url":"https://api.github.com/repos/bpstark/machinelearning/forks","keys_url":"https://api.github.com/repos/bpstark/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bpstark/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bpstark/machinelearning/teams","hooks_url":"https://api.github.com/repos/bpstark/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/bpstark/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/bpstark/machinelearning/events","assignees_url":"https://api.github.com/repos/bpstark/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/bpstark/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/bpstark/machinelearning/tags","blobs_url":"https://api.github.com/repos/bpstark/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bpstark/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bpstark/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/bpstark/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bpstark/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/bpstark/machinelearning/languages","stargazers_url":"https://api.github.com/repos/bpstark/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/bpstark/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/bpstark/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/bpstark/machinelearning/subscription","commits_url":"https://api.github.com/repos/bpstark/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/bpstark/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/bpstark/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/bpstark/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/bpstark/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/bpstark/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bpstark/machinelearning/merges","archive_url":"https://api.github.com/repos/bpstark/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bpstark/machinelearning/downloads","issues_url":"https://api.github.com/repos/bpstark/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/bpstark/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/bpstark/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/bpstark/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bpstark/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/bpstark/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/bpstark/machinelearning/deployments","created_at":"2019-09-04T21:09:18Z","updated_at":"2019-10-29T18:21:01Z","pushed_at":"2019-10-29T19:41:54Z","git_url":"git://github.com/bpstark/machinelearning.git","ssh_url":"git@github.com:bpstark/machinelearning.git","clone_url":"https://github.com/bpstark/machinelearning.git","svn_url":"https://github.com/bpstark/machinelearning","homepage":"https://dot.net/ml","size":49660,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"4c3be03282db29b65eb8f33888d8cb8c1a8dadac","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2019-10-29T18:24:54Z","pushed_at":"2019-10-29T19:41:57Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":49738,"stargazers_count":6524,"watchers_count":6524,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1372,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":527,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1372,"open_issues":527,"watchers":6524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/4410"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/4410"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/4410"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/4410/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/4410/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/4410/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/94df351528af368230a9e585566b2ae8aab95ad0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eerhardt"}}