{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/316525760","pull_request_review_id":278227174,"id":316525760,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjUyNTc2MA==","diff_hunk":"@@ -15,17 +15,21 @@ stdenv.mkDerivation rec {\n     sha256 = \"07mlfnh0hwvk6xarcg315x7z2j0qbg9g7cm040df9c8psiahc3g6\";\n   };\n \n+  patches = [\n+    ./5.0-soundtouch-exception-fix.patch","path":"pkgs/misc/emulators/dolphin-emu/default.nix","position":18,"original_position":18,"commit_id":"8b024f2d6bcf835ebf72c0de0d5a9e9efb1aaa51","original_commit_id":"8b024f2d6bcf835ebf72c0de0d5a9e9efb1aaa51","user":{"login":"worldofpeace","id":28888242,"node_id":"MDQ6VXNlcjI4ODg4MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/28888242?v=4","gravatar_id":"","url":"https://api.github.com/users/worldofpeace","html_url":"https://github.com/worldofpeace","followers_url":"https://api.github.com/users/worldofpeace/followers","following_url":"https://api.github.com/users/worldofpeace/following{/other_user}","gists_url":"https://api.github.com/users/worldofpeace/gists{/gist_id}","starred_url":"https://api.github.com/users/worldofpeace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worldofpeace/subscriptions","organizations_url":"https://api.github.com/users/worldofpeace/orgs","repos_url":"https://api.github.com/users/worldofpeace/repos","events_url":"https://api.github.com/users/worldofpeace/events{/privacy}","received_events_url":"https://api.github.com/users/worldofpeace/received_events","type":"User","site_admin":false},"body":"Can we use `fetchpatch` from\r\n* https://src.fedoraproject.org/rpms/dolphin-emu/raw/a1b91fdf94981e12c8889a02cba0ec2267d0f303/f/dolphin-emu-5.0-soundtouch-exception-fix.patch\r\n\r\n(url is stable)","created_at":"2019-08-22T07:09:09Z","updated_at":"2019-08-22T07:18:06Z","html_url":"https://github.com/NixOS/nixpkgs/pull/67235#discussion_r316525760","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/67235","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/316525760"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/67235#discussion_r316525760"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/67235"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/67235","id":309811086,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5ODExMDg2","html_url":"https://github.com/NixOS/nixpkgs/pull/67235","diff_url":"https://github.com/NixOS/nixpkgs/pull/67235.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/67235.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/67235","number":67235,"state":"open","locked":false,"title":"dolphin-emu fixes and updates","user":{"login":"ashkitten","id":9281956,"node_id":"MDQ6VXNlcjkyODE5NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/9281956?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkitten","html_url":"https://github.com/ashkitten","followers_url":"https://api.github.com/users/ashkitten/followers","following_url":"https://api.github.com/users/ashkitten/following{/other_user}","gists_url":"https://api.github.com/users/ashkitten/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkitten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkitten/subscriptions","organizations_url":"https://api.github.com/users/ashkitten/orgs","repos_url":"https://api.github.com/users/ashkitten/repos","events_url":"https://api.github.com/users/ashkitten/events{/privacy}","received_events_url":"https://api.github.com/users/ashkitten/received_events","type":"User","site_admin":false},"body":"<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->\r\n###### Motivation for this change\r\n\r\n- `dolphinEmu` was broken, fixed building with `soundtouch-2.1.2`\r\n- both `dolphinEmu` and `dolphinEmuMaster` were broken at runtime (see #65399)\r\n- replaced instances of `stdenv.lib` with `lib` for readability\r\n- added self as co-maintainer\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run \"nix-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Ensured that relevant documentation is up to date\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n###### Notify maintainers\r\n\r\ncc @MP2E","created_at":"2019-08-22T07:06:30Z","updated_at":"2019-08-22T07:18:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83eba229f2b4ceb9306e28b241b10d70269d3515","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/67235/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/67235/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/67235/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/8b024f2d6bcf835ebf72c0de0d5a9e9efb1aaa51","head":{"label":"ashkitten:update-dolphin","ref":"update-dolphin","sha":"8b024f2d6bcf835ebf72c0de0d5a9e9efb1aaa51","user":{"login":"ashkitten","id":9281956,"node_id":"MDQ6VXNlcjkyODE5NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/9281956?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkitten","html_url":"https://github.com/ashkitten","followers_url":"https://api.github.com/users/ashkitten/followers","following_url":"https://api.github.com/users/ashkitten/following{/other_user}","gists_url":"https://api.github.com/users/ashkitten/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkitten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkitten/subscriptions","organizations_url":"https://api.github.com/users/ashkitten/orgs","repos_url":"https://api.github.com/users/ashkitten/repos","events_url":"https://api.github.com/users/ashkitten/events{/privacy}","received_events_url":"https://api.github.com/users/ashkitten/received_events","type":"User","site_admin":false},"repo":{"id":145275192,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUyNzUxOTI=","name":"nixpkgs","full_name":"ashkitten/nixpkgs","private":false,"owner":{"login":"ashkitten","id":9281956,"node_id":"MDQ6VXNlcjkyODE5NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/9281956?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkitten","html_url":"https://github.com/ashkitten","followers_url":"https://api.github.com/users/ashkitten/followers","following_url":"https://api.github.com/users/ashkitten/following{/other_user}","gists_url":"https://api.github.com/users/ashkitten/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkitten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkitten/subscriptions","organizations_url":"https://api.github.com/users/ashkitten/orgs","repos_url":"https://api.github.com/users/ashkitten/repos","events_url":"https://api.github.com/users/ashkitten/events{/privacy}","received_events_url":"https://api.github.com/users/ashkitten/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ashkitten/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/ashkitten/nixpkgs","forks_url":"https://api.github.com/repos/ashkitten/nixpkgs/forks","keys_url":"https://api.github.com/repos/ashkitten/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashkitten/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashkitten/nixpkgs/teams","hooks_url":"https://api.github.com/repos/ashkitten/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/ashkitten/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/ashkitten/nixpkgs/events","assignees_url":"https://api.github.com/repos/ashkitten/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/ashkitten/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/ashkitten/nixpkgs/tags","blobs_url":"https://api.github.com/repos/ashkitten/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashkitten/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashkitten/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashkitten/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashkitten/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/ashkitten/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/ashkitten/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/ashkitten/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/ashkitten/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/ashkitten/nixpkgs/subscription","commits_url":"https://api.github.com/repos/ashkitten/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashkitten/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashkitten/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashkitten/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashkitten/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/ashkitten/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashkitten/nixpkgs/merges","archive_url":"https://api.github.com/repos/ashkitten/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashkitten/nixpkgs/downloads","issues_url":"https://api.github.com/repos/ashkitten/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/ashkitten/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/ashkitten/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/ashkitten/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashkitten/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/ashkitten/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/ashkitten/nixpkgs/deployments","created_at":"2018-08-19T05:14:47Z","updated_at":"2019-08-15T20:51:49Z","pushed_at":"2019-08-22T06:55:26Z","git_url":"git://github.com/ashkitten/nixpkgs.git","ssh_url":"git@github.com:ashkitten/nixpkgs.git","clone_url":"https://github.com/ashkitten/nixpkgs.git","svn_url":"https://github.com/ashkitten/nixpkgs","homepage":null,"size":948913,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"5ca95f08dcc05c24878c797a44c86cc320c4254e","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2019-08-22T07:15:28Z","pushed_at":"2019-08-22T07:17:08Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":1022844,"stargazers_count":4093,"watchers_count":4093,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3909,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4473,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3909,"open_issues":4473,"watchers":4093,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/67235"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/67235"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/67235"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/67235/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/67235/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/67235/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/8b024f2d6bcf835ebf72c0de0d5a9e9efb1aaa51"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"worldofpeace"}}