{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/62692","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/62692/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/62692/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/62692/events","html_url":"https://github.com/rust-lang/rust/pull/62692","id":468209297,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3Njg2NTk4","number":62692,"title":"rustc: precompute the largest Niche and store it in LayoutDetails.","user":{"login":"eddyb","id":77424,"node_id":"MDQ6VXNlcjc3NDI0","avatar_url":"https://avatars2.githubusercontent.com/u/77424?v=4","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"labels":[{"id":583437191,"node_id":"MDU6TGFiZWw1ODM0MzcxOTE=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-bors","name":"S-waiting-on-bors","color":"d3dddd","default":false}],"state":"open","locked":false,"assignee":{"login":"matthewjasper","id":20113453,"node_id":"MDQ6VXNlcjIwMTEzNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/20113453?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewjasper","html_url":"https://github.com/matthewjasper","followers_url":"https://api.github.com/users/matthewjasper/followers","following_url":"https://api.github.com/users/matthewjasper/following{/other_user}","gists_url":"https://api.github.com/users/matthewjasper/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjasper/subscriptions","organizations_url":"https://api.github.com/users/matthewjasper/orgs","repos_url":"https://api.github.com/users/matthewjasper/repos","events_url":"https://api.github.com/users/matthewjasper/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjasper/received_events","type":"User","site_admin":false},"assignees":[{"login":"matthewjasper","id":20113453,"node_id":"MDQ6VXNlcjIwMTEzNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/20113453?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewjasper","html_url":"https://github.com/matthewjasper","followers_url":"https://api.github.com/users/matthewjasper/followers","following_url":"https://api.github.com/users/matthewjasper/following{/other_user}","gists_url":"https://api.github.com/users/matthewjasper/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjasper/subscriptions","organizations_url":"https://api.github.com/users/matthewjasper/orgs","repos_url":"https://api.github.com/users/matthewjasper/repos","events_url":"https://api.github.com/users/matthewjasper/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjasper/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2019-07-15T16:00:11Z","updated_at":"2019-07-21T12:33:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/62692","html_url":"https://github.com/rust-lang/rust/pull/62692","diff_url":"https://github.com/rust-lang/rust/pull/62692.diff","patch_url":"https://github.com/rust-lang/rust/pull/62692.patch"},"body":"Since we only ever can use at most one niche, it makes sense to just store that in the layout, for the simplest caching (especially as it's almost trivial to compute).\r\n\r\nThere might be a speedup from this, but even if it's marginal now, the caching would be a more significant benefit for future optimization attempts."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/513550396","html_url":"https://github.com/rust-lang/rust/pull/62692#issuecomment-513550396","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/62692","id":513550396,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMzU1MDM5Ng==","user":{"login":"bors","id":3372342,"node_id":"MDQ6VXNlcjMzNzIzNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3372342?v=4","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"created_at":"2019-07-21T12:33:32Z","updated_at":"2019-07-21T12:33:32Z","author_association":"CONTRIBUTOR","body":":hourglass: Testing commit 88eced596199548a7653aaf835cda0a93fec36fd with merge 6945455ed42f049c4d5380762ef9b5bae090062a...\n<!-- homu: {\"type\":\"BuildStarted\",\"head_sha\":\"88eced596199548a7653aaf835cda0a93fec36fd\",\"merge_sha\":\"6945455ed42f049c4d5380762ef9b5bae090062a\"} -->"}}
{"actor":{"display_login":"bors"}}