{"action":"created","comment":{"url":"https://api.github.com/repos/brendanzab/gl-rs/pulls/comments/347719554","pull_request_review_id":318769482,"id":347719554,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzcxOTU1NA==","diff_hunk":"@@ -1,68 +1,32 @@\n-// Copyright 2015 Brendan Zabarauskas and the gl-rs developers\n-//\n-// Licensed under the Apache License, Version 2.0 (the \"License\");\n-// you may not use this file except in compliance with the License.\n-// You may obtain a copy of the License at\n-//\n-//     http://www.apache.org/licenses/LICENSE-2.0\n-//\n-// Unless required by applicable law or agreed to in writing, software\n-// distributed under the License is distributed on an \"AS IS\" BASIS,\n-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n-// See the License for the specific language governing permissions and\n-// limitations under the License.\n+// Based on the `gl_generator` crate, by Brendan Zabarauskas and the gl-rs\n+// developers (2015). Used under Apache-2.0 license. All new content is also\n+// available under the Apache-2.0 license.","path":"gl_generator/lib.rs","position":16,"original_position":16,"commit_id":"ffe151eec35ce2e592324d77c993754a323c38ce","original_commit_id":"ffe151eec35ce2e592324d77c993754a323c38ce","user":{"login":"Lokathor","id":5456384,"node_id":"MDQ6VXNlcjU0NTYzODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5456384?v=4","gravatar_id":"","url":"https://api.github.com/users/Lokathor","html_url":"https://github.com/Lokathor","followers_url":"https://api.github.com/users/Lokathor/followers","following_url":"https://api.github.com/users/Lokathor/following{/other_user}","gists_url":"https://api.github.com/users/Lokathor/gists{/gist_id}","starred_url":"https://api.github.com/users/Lokathor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lokathor/subscriptions","organizations_url":"https://api.github.com/users/Lokathor/orgs","repos_url":"https://api.github.com/users/Lokathor/repos","events_url":"https://api.github.com/users/Lokathor/events{/privacy}","received_events_url":"https://api.github.com/users/Lokathor/received_events","type":"User","site_admin":false},"body":"oh! right, that's from when i made this a stand alone crate. i will revert it in the next series of revisions.","created_at":"2019-11-19T03:45:35Z","updated_at":"2019-11-19T03:45:35Z","html_url":"https://github.com/brendanzab/gl-rs/pull/507#discussion_r347719554","pull_request_url":"https://api.github.com/repos/brendanzab/gl-rs/pulls/507","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/brendanzab/gl-rs/pulls/comments/347719554"},"html":{"href":"https://github.com/brendanzab/gl-rs/pull/507#discussion_r347719554"},"pull_request":{"href":"https://api.github.com/repos/brendanzab/gl-rs/pulls/507"}},"in_reply_to_id":347713840},"pull_request":{"url":"https://api.github.com/repos/brendanzab/gl-rs/pulls/507","id":342433887,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyNDMzODg3","html_url":"https://github.com/brendanzab/gl-rs/pull/507","diff_url":"https://github.com/brendanzab/gl-rs/pull/507.diff","patch_url":"https://github.com/brendanzab/gl-rs/pull/507.patch","issue_url":"https://api.github.com/repos/brendanzab/gl-rs/issues/507","number":507,"state":"open","locked":false,"title":"The big 2018 cleanup","user":{"login":"Lokathor","id":5456384,"node_id":"MDQ6VXNlcjU0NTYzODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5456384?v=4","gravatar_id":"","url":"https://api.github.com/users/Lokathor","html_url":"https://github.com/Lokathor","followers_url":"https://api.github.com/users/Lokathor/followers","following_url":"https://api.github.com/users/Lokathor/following{/other_user}","gists_url":"https://api.github.com/users/Lokathor/gists{/gist_id}","starred_url":"https://api.github.com/users/Lokathor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lokathor/subscriptions","organizations_url":"https://api.github.com/users/Lokathor/orgs","repos_url":"https://api.github.com/users/Lokathor/repos","events_url":"https://api.github.com/users/Lokathor/events{/privacy}","received_events_url":"https://api.github.com/users/Lokathor/received_events","type":"User","site_admin":false},"body":"Highlights:\r\n* `GlobalGenerator` and `StructGenerator` got a huge facelift. They now occupy half the space per function that they did before. They also will generally load faster because they pass the function name to look up directly in `*const c_char` form, so that loader function doesn't have to allocate a temporary string for every lookup.\r\n* `GlobalGenerator` and `StructGenerator` now have more options for how you build the bindings regarding trace support and error checking support. Also included is a Default impl if you don't want to think about it too hard (the default is to turn on all the extra support).\r\n* `DebugStructGenerator` is totally gone, use `StructGenerator` with the debug settings on.\r\n* `StaticGenerator` and `StaticDebugGenerator` are not gone but they are also not upgraded at all. They've been changed the minimum amount so that they build with 2018-edition and the changes to `Registry`.\r\n* The contents of the output is now designed to be a complete module file that you _don't_ include directly into your project. In fact if you do you'll get a build error because you can't use inner attributes with an inline module because rust is a dumb butt.\r\n\r\n---\r\n\r\nSo, because of that last point, basically every test fails to build, to the point where we can't even test that the output is still good or not.\r\n\r\nSo we need to decide what to do there. We could preserve the `include!` ability of the output, but then people would manually have to put all sorts of `allow(foo)` tags on whatever module does the include.","created_at":"2019-11-19T00:53:53Z","updated_at":"2019-11-19T03:45:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5851bf82ff4088a8d60f68ad43d2e5627e8c0059","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brendanzab/gl-rs/pulls/507/commits","review_comments_url":"https://api.github.com/repos/brendanzab/gl-rs/pulls/507/comments","review_comment_url":"https://api.github.com/repos/brendanzab/gl-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brendanzab/gl-rs/issues/507/comments","statuses_url":"https://api.github.com/repos/brendanzab/gl-rs/statuses/ffe151eec35ce2e592324d77c993754a323c38ce","head":{"label":"Lokathor:the-big-fix","ref":"the-big-fix","sha":"ffe151eec35ce2e592324d77c993754a323c38ce","user":{"login":"Lokathor","id":5456384,"node_id":"MDQ6VXNlcjU0NTYzODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5456384?v=4","gravatar_id":"","url":"https://api.github.com/users/Lokathor","html_url":"https://github.com/Lokathor","followers_url":"https://api.github.com/users/Lokathor/followers","following_url":"https://api.github.com/users/Lokathor/following{/other_user}","gists_url":"https://api.github.com/users/Lokathor/gists{/gist_id}","starred_url":"https://api.github.com/users/Lokathor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lokathor/subscriptions","organizations_url":"https://api.github.com/users/Lokathor/orgs","repos_url":"https://api.github.com/users/Lokathor/repos","events_url":"https://api.github.com/users/Lokathor/events{/privacy}","received_events_url":"https://api.github.com/users/Lokathor/received_events","type":"User","site_admin":false},"repo":{"id":222201788,"node_id":"MDEwOlJlcG9zaXRvcnkyMjIyMDE3ODg=","name":"gl-rs","full_name":"Lokathor/gl-rs","private":false,"owner":{"login":"Lokathor","id":5456384,"node_id":"MDQ6VXNlcjU0NTYzODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5456384?v=4","gravatar_id":"","url":"https://api.github.com/users/Lokathor","html_url":"https://github.com/Lokathor","followers_url":"https://api.github.com/users/Lokathor/followers","following_url":"https://api.github.com/users/Lokathor/following{/other_user}","gists_url":"https://api.github.com/users/Lokathor/gists{/gist_id}","starred_url":"https://api.github.com/users/Lokathor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lokathor/subscriptions","organizations_url":"https://api.github.com/users/Lokathor/orgs","repos_url":"https://api.github.com/users/Lokathor/repos","events_url":"https://api.github.com/users/Lokathor/events{/privacy}","received_events_url":"https://api.github.com/users/Lokathor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Lokathor/gl-rs","description":"An OpenGL function pointer loader for Rust","fork":true,"url":"https://api.github.com/repos/Lokathor/gl-rs","forks_url":"https://api.github.com/repos/Lokathor/gl-rs/forks","keys_url":"https://api.github.com/repos/Lokathor/gl-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lokathor/gl-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lokathor/gl-rs/teams","hooks_url":"https://api.github.com/repos/Lokathor/gl-rs/hooks","issue_events_url":"https://api.github.com/repos/Lokathor/gl-rs/issues/events{/number}","events_url":"https://api.github.com/repos/Lokathor/gl-rs/events","assignees_url":"https://api.github.com/repos/Lokathor/gl-rs/assignees{/user}","branches_url":"https://api.github.com/repos/Lokathor/gl-rs/branches{/branch}","tags_url":"https://api.github.com/repos/Lokathor/gl-rs/tags","blobs_url":"https://api.github.com/repos/Lokathor/gl-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lokathor/gl-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lokathor/gl-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lokathor/gl-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lokathor/gl-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/Lokathor/gl-rs/languages","stargazers_url":"https://api.github.com/repos/Lokathor/gl-rs/stargazers","contributors_url":"https://api.github.com/repos/Lokathor/gl-rs/contributors","subscribers_url":"https://api.github.com/repos/Lokathor/gl-rs/subscribers","subscription_url":"https://api.github.com/repos/Lokathor/gl-rs/subscription","commits_url":"https://api.github.com/repos/Lokathor/gl-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lokathor/gl-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lokathor/gl-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lokathor/gl-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lokathor/gl-rs/contents/{+path}","compare_url":"https://api.github.com/repos/Lokathor/gl-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lokathor/gl-rs/merges","archive_url":"https://api.github.com/repos/Lokathor/gl-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lokathor/gl-rs/downloads","issues_url":"https://api.github.com/repos/Lokathor/gl-rs/issues{/number}","pulls_url":"https://api.github.com/repos/Lokathor/gl-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/Lokathor/gl-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/Lokathor/gl-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lokathor/gl-rs/labels{/name}","releases_url":"https://api.github.com/repos/Lokathor/gl-rs/releases{/id}","deployments_url":"https://api.github.com/repos/Lokathor/gl-rs/deployments","created_at":"2019-11-17T05:28:59Z","updated_at":"2019-11-17T05:29:01Z","pushed_at":"2019-11-19T01:13:47Z","git_url":"git://github.com/Lokathor/gl-rs.git","ssh_url":"git@github.com:Lokathor/gl-rs.git","clone_url":"https://github.com/Lokathor/gl-rs.git","svn_url":"https://github.com/Lokathor/gl-rs","homepage":"","size":2627,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brendanzab:master","ref":"master","sha":"ea503e8d5fb6d73c6030e6191ce738cd3bf3433e","user":{"login":"brendanzab","id":695077,"node_id":"MDQ6VXNlcjY5NTA3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/695077?v=4","gravatar_id":"","url":"https://api.github.com/users/brendanzab","html_url":"https://github.com/brendanzab","followers_url":"https://api.github.com/users/brendanzab/followers","following_url":"https://api.github.com/users/brendanzab/following{/other_user}","gists_url":"https://api.github.com/users/brendanzab/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanzab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanzab/subscriptions","organizations_url":"https://api.github.com/users/brendanzab/orgs","repos_url":"https://api.github.com/users/brendanzab/repos","events_url":"https://api.github.com/users/brendanzab/events{/privacy}","received_events_url":"https://api.github.com/users/brendanzab/received_events","type":"User","site_admin":false},"repo":{"id":7655767,"node_id":"MDEwOlJlcG9zaXRvcnk3NjU1NzY3","name":"gl-rs","full_name":"brendanzab/gl-rs","private":false,"owner":{"login":"brendanzab","id":695077,"node_id":"MDQ6VXNlcjY5NTA3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/695077?v=4","gravatar_id":"","url":"https://api.github.com/users/brendanzab","html_url":"https://github.com/brendanzab","followers_url":"https://api.github.com/users/brendanzab/followers","following_url":"https://api.github.com/users/brendanzab/following{/other_user}","gists_url":"https://api.github.com/users/brendanzab/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanzab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanzab/subscriptions","organizations_url":"https://api.github.com/users/brendanzab/orgs","repos_url":"https://api.github.com/users/brendanzab/repos","events_url":"https://api.github.com/users/brendanzab/events{/privacy}","received_events_url":"https://api.github.com/users/brendanzab/received_events","type":"User","site_admin":false},"html_url":"https://github.com/brendanzab/gl-rs","description":"An OpenGL function pointer loader for Rust","fork":false,"url":"https://api.github.com/repos/brendanzab/gl-rs","forks_url":"https://api.github.com/repos/brendanzab/gl-rs/forks","keys_url":"https://api.github.com/repos/brendanzab/gl-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brendanzab/gl-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brendanzab/gl-rs/teams","hooks_url":"https://api.github.com/repos/brendanzab/gl-rs/hooks","issue_events_url":"https://api.github.com/repos/brendanzab/gl-rs/issues/events{/number}","events_url":"https://api.github.com/repos/brendanzab/gl-rs/events","assignees_url":"https://api.github.com/repos/brendanzab/gl-rs/assignees{/user}","branches_url":"https://api.github.com/repos/brendanzab/gl-rs/branches{/branch}","tags_url":"https://api.github.com/repos/brendanzab/gl-rs/tags","blobs_url":"https://api.github.com/repos/brendanzab/gl-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brendanzab/gl-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brendanzab/gl-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/brendanzab/gl-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brendanzab/gl-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/brendanzab/gl-rs/languages","stargazers_url":"https://api.github.com/repos/brendanzab/gl-rs/stargazers","contributors_url":"https://api.github.com/repos/brendanzab/gl-rs/contributors","subscribers_url":"https://api.github.com/repos/brendanzab/gl-rs/subscribers","subscription_url":"https://api.github.com/repos/brendanzab/gl-rs/subscription","commits_url":"https://api.github.com/repos/brendanzab/gl-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/brendanzab/gl-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/brendanzab/gl-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/brendanzab/gl-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/brendanzab/gl-rs/contents/{+path}","compare_url":"https://api.github.com/repos/brendanzab/gl-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brendanzab/gl-rs/merges","archive_url":"https://api.github.com/repos/brendanzab/gl-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brendanzab/gl-rs/downloads","issues_url":"https://api.github.com/repos/brendanzab/gl-rs/issues{/number}","pulls_url":"https://api.github.com/repos/brendanzab/gl-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/brendanzab/gl-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/brendanzab/gl-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brendanzab/gl-rs/labels{/name}","releases_url":"https://api.github.com/repos/brendanzab/gl-rs/releases{/id}","deployments_url":"https://api.github.com/repos/brendanzab/gl-rs/deployments","created_at":"2013-01-16T23:05:49Z","updated_at":"2019-11-04T15:06:12Z","pushed_at":"2019-11-19T01:13:49Z","git_url":"git://github.com/brendanzab/gl-rs.git","ssh_url":"git@github.com:brendanzab/gl-rs.git","clone_url":"https://github.com/brendanzab/gl-rs.git","svn_url":"https://github.com/brendanzab/gl-rs","homepage":"","size":2594,"stargazers_count":440,"watchers_count":440,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":99,"open_issues":16,"watchers":440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brendanzab/gl-rs/pulls/507"},"html":{"href":"https://github.com/brendanzab/gl-rs/pull/507"},"issue":{"href":"https://api.github.com/repos/brendanzab/gl-rs/issues/507"},"comments":{"href":"https://api.github.com/repos/brendanzab/gl-rs/issues/507/comments"},"review_comments":{"href":"https://api.github.com/repos/brendanzab/gl-rs/pulls/507/comments"},"review_comment":{"href":"https://api.github.com/repos/brendanzab/gl-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brendanzab/gl-rs/pulls/507/commits"},"statuses":{"href":"https://api.github.com/repos/brendanzab/gl-rs/statuses/ffe151eec35ce2e592324d77c993754a323c38ce"}},"author_association":"NONE"}}
{"actor":{"display_login":"Lokathor"}}