{"action":"closed","number":261,"pull_request":{"url":"https://api.github.com/repos/momentum-design/momentum-ui/pulls/261","id":286079294,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2MDc5Mjk0","html_url":"https://github.com/momentum-design/momentum-ui/pull/261","diff_url":"https://github.com/momentum-design/momentum-ui/pull/261.diff","patch_url":"https://github.com/momentum-design/momentum-ui/pull/261.patch","issue_url":"https://api.github.com/repos/momentum-design/momentum-ui/issues/261","number":261,"state":"closed","locked":false,"title":"fix(TopBar): use the prop className","user":{"login":"tbassetto","id":211630,"node_id":"MDQ6VXNlcjIxMTYzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/211630?v=4","gravatar_id":"","url":"https://api.github.com/users/tbassetto","html_url":"https://github.com/tbassetto","followers_url":"https://api.github.com/users/tbassetto/followers","following_url":"https://api.github.com/users/tbassetto/following{/other_user}","gists_url":"https://api.github.com/users/tbassetto/gists{/gist_id}","starred_url":"https://api.github.com/users/tbassetto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbassetto/subscriptions","organizations_url":"https://api.github.com/users/tbassetto/orgs","repos_url":"https://api.github.com/users/tbassetto/repos","events_url":"https://api.github.com/users/tbassetto/events{/privacy}","received_events_url":"https://api.github.com/users/tbassetto/received_events","type":"User","site_admin":false},"body":"## Description\r\nSee #260 \r\n\r\nThe `className` change if ok I think, but adding `row` may be **very naive**. Maybe it works better only on \"sites\" and not on \"apps\". But are apps supposed to use this TopBar component anyway? Also, I did not update the other TopBar components (like the Angular one).\r\n\r\n## Related Issue\r\nfixes #260 & fixes #239 \r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots:\r\n**Before** (If applicable):\r\n<!--- Please add before images, gifs or videos here: -->\r\n\r\n**After**:\r\n<!--- Please add after images, gifs or videos here: -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Documentation update\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build related changes\r\n- [ ] CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n","created_at":"2019-06-07T07:36:49Z","updated_at":"2019-06-18T21:13:52Z","closed_at":"2019-06-18T21:13:51Z","merged_at":"2019-06-18T21:13:51Z","merge_commit_sha":"aa350e42f05caae97711545290f682cf3149bfd6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/momentum-design/momentum-ui/pulls/261/commits","review_comments_url":"https://api.github.com/repos/momentum-design/momentum-ui/pulls/261/comments","review_comment_url":"https://api.github.com/repos/momentum-design/momentum-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/momentum-design/momentum-ui/issues/261/comments","statuses_url":"https://api.github.com/repos/momentum-design/momentum-ui/statuses/8d76c117dda9959cd53519e9e4d1fe55d1c4d656","head":{"label":"tbassetto:issue-260","ref":"issue-260","sha":"8d76c117dda9959cd53519e9e4d1fe55d1c4d656","user":{"login":"tbassetto","id":211630,"node_id":"MDQ6VXNlcjIxMTYzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/211630?v=4","gravatar_id":"","url":"https://api.github.com/users/tbassetto","html_url":"https://github.com/tbassetto","followers_url":"https://api.github.com/users/tbassetto/followers","following_url":"https://api.github.com/users/tbassetto/following{/other_user}","gists_url":"https://api.github.com/users/tbassetto/gists{/gist_id}","starred_url":"https://api.github.com/users/tbassetto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbassetto/subscriptions","organizations_url":"https://api.github.com/users/tbassetto/orgs","repos_url":"https://api.github.com/users/tbassetto/repos","events_url":"https://api.github.com/users/tbassetto/events{/privacy}","received_events_url":"https://api.github.com/users/tbassetto/received_events","type":"User","site_admin":false},"repo":{"id":186799006,"node_id":"MDEwOlJlcG9zaXRvcnkxODY3OTkwMDY=","name":"momentum-ui","full_name":"tbassetto/momentum-ui","private":false,"owner":{"login":"tbassetto","id":211630,"node_id":"MDQ6VXNlcjIxMTYzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/211630?v=4","gravatar_id":"","url":"https://api.github.com/users/tbassetto","html_url":"https://github.com/tbassetto","followers_url":"https://api.github.com/users/tbassetto/followers","following_url":"https://api.github.com/users/tbassetto/following{/other_user}","gists_url":"https://api.github.com/users/tbassetto/gists{/gist_id}","starred_url":"https://api.github.com/users/tbassetto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbassetto/subscriptions","organizations_url":"https://api.github.com/users/tbassetto/orgs","repos_url":"https://api.github.com/users/tbassetto/repos","events_url":"https://api.github.com/users/tbassetto/events{/privacy}","received_events_url":"https://api.github.com/users/tbassetto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tbassetto/momentum-ui","description":"Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.","fork":true,"url":"https://api.github.com/repos/tbassetto/momentum-ui","forks_url":"https://api.github.com/repos/tbassetto/momentum-ui/forks","keys_url":"https://api.github.com/repos/tbassetto/momentum-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbassetto/momentum-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbassetto/momentum-ui/teams","hooks_url":"https://api.github.com/repos/tbassetto/momentum-ui/hooks","issue_events_url":"https://api.github.com/repos/tbassetto/momentum-ui/issues/events{/number}","events_url":"https://api.github.com/repos/tbassetto/momentum-ui/events","assignees_url":"https://api.github.com/repos/tbassetto/momentum-ui/assignees{/user}","branches_url":"https://api.github.com/repos/tbassetto/momentum-ui/branches{/branch}","tags_url":"https://api.github.com/repos/tbassetto/momentum-ui/tags","blobs_url":"https://api.github.com/repos/tbassetto/momentum-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbassetto/momentum-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbassetto/momentum-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbassetto/momentum-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbassetto/momentum-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/tbassetto/momentum-ui/languages","stargazers_url":"https://api.github.com/repos/tbassetto/momentum-ui/stargazers","contributors_url":"https://api.github.com/repos/tbassetto/momentum-ui/contributors","subscribers_url":"https://api.github.com/repos/tbassetto/momentum-ui/subscribers","subscription_url":"https://api.github.com/repos/tbassetto/momentum-ui/subscription","commits_url":"https://api.github.com/repos/tbassetto/momentum-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbassetto/momentum-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbassetto/momentum-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbassetto/momentum-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbassetto/momentum-ui/contents/{+path}","compare_url":"https://api.github.com/repos/tbassetto/momentum-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbassetto/momentum-ui/merges","archive_url":"https://api.github.com/repos/tbassetto/momentum-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbassetto/momentum-ui/downloads","issues_url":"https://api.github.com/repos/tbassetto/momentum-ui/issues{/number}","pulls_url":"https://api.github.com/repos/tbassetto/momentum-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/tbassetto/momentum-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/tbassetto/momentum-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbassetto/momentum-ui/labels{/name}","releases_url":"https://api.github.com/repos/tbassetto/momentum-ui/releases{/id}","deployments_url":"https://api.github.com/repos/tbassetto/momentum-ui/deployments","created_at":"2019-05-15T09:55:38Z","updated_at":"2019-06-07T05:22:07Z","pushed_at":"2019-06-18T20:57:31Z","git_url":"git://github.com/tbassetto/momentum-ui.git","ssh_url":"git@github.com:tbassetto/momentum-ui.git","clone_url":"https://github.com/tbassetto/momentum-ui.git","svn_url":"https://github.com/tbassetto/momentum-ui","homepage":"https://momentum.design","size":97804,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"momentum-design:master","ref":"master","sha":"a8f9e13e0f69a80718095d86bd5c290b24f85353","user":{"login":"momentum-design","id":19691026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjkxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/19691026?v=4","gravatar_id":"","url":"https://api.github.com/users/momentum-design","html_url":"https://github.com/momentum-design","followers_url":"https://api.github.com/users/momentum-design/followers","following_url":"https://api.github.com/users/momentum-design/following{/other_user}","gists_url":"https://api.github.com/users/momentum-design/gists{/gist_id}","starred_url":"https://api.github.com/users/momentum-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momentum-design/subscriptions","organizations_url":"https://api.github.com/users/momentum-design/orgs","repos_url":"https://api.github.com/users/momentum-design/repos","events_url":"https://api.github.com/users/momentum-design/events{/privacy}","received_events_url":"https://api.github.com/users/momentum-design/received_events","type":"Organization","site_admin":false},"repo":{"id":164343086,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQzNDMwODY=","name":"momentum-ui","full_name":"momentum-design/momentum-ui","private":false,"owner":{"login":"momentum-design","id":19691026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjkxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/19691026?v=4","gravatar_id":"","url":"https://api.github.com/users/momentum-design","html_url":"https://github.com/momentum-design","followers_url":"https://api.github.com/users/momentum-design/followers","following_url":"https://api.github.com/users/momentum-design/following{/other_user}","gists_url":"https://api.github.com/users/momentum-design/gists{/gist_id}","starred_url":"https://api.github.com/users/momentum-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momentum-design/subscriptions","organizations_url":"https://api.github.com/users/momentum-design/orgs","repos_url":"https://api.github.com/users/momentum-design/repos","events_url":"https://api.github.com/users/momentum-design/events{/privacy}","received_events_url":"https://api.github.com/users/momentum-design/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/momentum-design/momentum-ui","description":"Momentum UI is a collection of UI libraries for implementing Momentum Design into web applications and websites.","fork":false,"url":"https://api.github.com/repos/momentum-design/momentum-ui","forks_url":"https://api.github.com/repos/momentum-design/momentum-ui/forks","keys_url":"https://api.github.com/repos/momentum-design/momentum-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/momentum-design/momentum-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/momentum-design/momentum-ui/teams","hooks_url":"https://api.github.com/repos/momentum-design/momentum-ui/hooks","issue_events_url":"https://api.github.com/repos/momentum-design/momentum-ui/issues/events{/number}","events_url":"https://api.github.com/repos/momentum-design/momentum-ui/events","assignees_url":"https://api.github.com/repos/momentum-design/momentum-ui/assignees{/user}","branches_url":"https://api.github.com/repos/momentum-design/momentum-ui/branches{/branch}","tags_url":"https://api.github.com/repos/momentum-design/momentum-ui/tags","blobs_url":"https://api.github.com/repos/momentum-design/momentum-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/momentum-design/momentum-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/momentum-design/momentum-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/momentum-design/momentum-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/momentum-design/momentum-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/momentum-design/momentum-ui/languages","stargazers_url":"https://api.github.com/repos/momentum-design/momentum-ui/stargazers","contributors_url":"https://api.github.com/repos/momentum-design/momentum-ui/contributors","subscribers_url":"https://api.github.com/repos/momentum-design/momentum-ui/subscribers","subscription_url":"https://api.github.com/repos/momentum-design/momentum-ui/subscription","commits_url":"https://api.github.com/repos/momentum-design/momentum-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/momentum-design/momentum-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/momentum-design/momentum-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/momentum-design/momentum-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/momentum-design/momentum-ui/contents/{+path}","compare_url":"https://api.github.com/repos/momentum-design/momentum-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/momentum-design/momentum-ui/merges","archive_url":"https://api.github.com/repos/momentum-design/momentum-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/momentum-design/momentum-ui/downloads","issues_url":"https://api.github.com/repos/momentum-design/momentum-ui/issues{/number}","pulls_url":"https://api.github.com/repos/momentum-design/momentum-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/momentum-design/momentum-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/momentum-design/momentum-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/momentum-design/momentum-ui/labels{/name}","releases_url":"https://api.github.com/repos/momentum-design/momentum-ui/releases{/id}","deployments_url":"https://api.github.com/repos/momentum-design/momentum-ui/deployments","created_at":"2019-01-06T20:31:41Z","updated_at":"2019-06-18T20:56:50Z","pushed_at":"2019-06-18T21:13:51Z","git_url":"git://github.com/momentum-design/momentum-ui.git","ssh_url":"git@github.com:momentum-design/momentum-ui.git","clone_url":"https://github.com/momentum-design/momentum-ui.git","svn_url":"https://github.com/momentum-design/momentum-ui","homepage":"https://momentum.design","size":98898,"stargazers_count":11,"watchers_count":11,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":27,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/momentum-design/momentum-ui/pulls/261"},"html":{"href":"https://github.com/momentum-design/momentum-ui/pull/261"},"issue":{"href":"https://api.github.com/repos/momentum-design/momentum-ui/issues/261"},"comments":{"href":"https://api.github.com/repos/momentum-design/momentum-ui/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/momentum-design/momentum-ui/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/momentum-design/momentum-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/momentum-design/momentum-ui/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/momentum-design/momentum-ui/statuses/8d76c117dda9959cd53519e9e4d1fe55d1c4d656"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bfbiggs","id":36969382,"node_id":"MDQ6VXNlcjM2OTY5Mzgy","avatar_url":"https://avatars0.githubusercontent.com/u/36969382?v=4","gravatar_id":"","url":"https://api.github.com/users/bfbiggs","html_url":"https://github.com/bfbiggs","followers_url":"https://api.github.com/users/bfbiggs/followers","following_url":"https://api.github.com/users/bfbiggs/following{/other_user}","gists_url":"https://api.github.com/users/bfbiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/bfbiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfbiggs/subscriptions","organizations_url":"https://api.github.com/users/bfbiggs/orgs","repos_url":"https://api.github.com/users/bfbiggs/repos","events_url":"https://api.github.com/users/bfbiggs/events{/privacy}","received_events_url":"https://api.github.com/users/bfbiggs/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"bfbiggs"}}