{"action":"created","comment":{"url":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/comments/256325862","pull_request_review_id":203123721,"id":256325862,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjMyNTg2Mg==","diff_hunk":"@@ -40,45 +41,69 @@ import * as os from \"os\";\n import * as path from \"path\";\n import { cleanImageName } from \"./name\";\n \n-/**\n- * Options to configure the Docker image build\n- */\n-export interface DockerOptions {\n-\n+export interface DockerRegistry {\n     /**\n-     * Provide the image tag for the docker image to build\n+     * Push Url for this registry\n      */\n-    dockerImageNameCreator?: DockerImageNameCreator;\n+    url: string;","path":"lib/docker/executeDockerBuild.ts","position":23,"original_position":23,"commit_id":"7d18a408fbc7c2c555b7aa08a5a3ce10d518f66f","original_commit_id":"7d18a408fbc7c2c555b7aa08a5a3ce10d518f66f","user":{"login":"cdupuis","id":206707,"node_id":"MDQ6VXNlcjIwNjcwNw==","avatar_url":"https://avatars3.githubusercontent.com/u/206707?v=4","gravatar_id":"","url":"https://api.github.com/users/cdupuis","html_url":"https://github.com/cdupuis","followers_url":"https://api.github.com/users/cdupuis/followers","following_url":"https://api.github.com/users/cdupuis/following{/other_user}","gists_url":"https://api.github.com/users/cdupuis/gists{/gist_id}","starred_url":"https://api.github.com/users/cdupuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdupuis/subscriptions","organizations_url":"https://api.github.com/users/cdupuis/orgs","repos_url":"https://api.github.com/users/cdupuis/repos","events_url":"https://api.github.com/users/cdupuis/events{/privacy}","received_events_url":"https://api.github.com/users/cdupuis/received_events","type":"User","site_admin":false},"body":"This is not a url. Please change back to registry. Eg. `atomist` is a valid registry but that is commonly not referred to as url. Alternatively docker login refers to this as `server`","created_at":"2019-02-13T10:11:15Z","updated_at":"2019-02-13T10:36:50Z","html_url":"https://github.com/atomist/sdm-pack-docker/pull/39#discussion_r256325862","pull_request_url":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/comments/256325862"},"html":{"href":"https://github.com/atomist/sdm-pack-docker/pull/39#discussion_r256325862"},"pull_request":{"href":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/39","id":252516997,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyNTE2OTk3","html_url":"https://github.com/atomist/sdm-pack-docker/pull/39","diff_url":"https://github.com/atomist/sdm-pack-docker/pull/39.diff","patch_url":"https://github.com/atomist/sdm-pack-docker/pull/39.patch","issue_url":"https://api.github.com/repos/atomist/sdm-pack-docker/issues/39","number":39,"state":"open","locked":false,"title":"Add Multi-Registry Support","user":{"login":"ipcrm","id":10358528,"node_id":"MDQ6VXNlcjEwMzU4NTI4","avatar_url":"https://avatars3.githubusercontent.com/u/10358528?v=4","gravatar_id":"","url":"https://api.github.com/users/ipcrm","html_url":"https://github.com/ipcrm","followers_url":"https://api.github.com/users/ipcrm/followers","following_url":"https://api.github.com/users/ipcrm/following{/other_user}","gists_url":"https://api.github.com/users/ipcrm/gists{/gist_id}","starred_url":"https://api.github.com/users/ipcrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipcrm/subscriptions","organizations_url":"https://api.github.com/users/ipcrm/orgs","repos_url":"https://api.github.com/users/ipcrm/repos","events_url":"https://api.github.com/users/ipcrm/events{/privacy}","received_events_url":"https://api.github.com/users/ipcrm/received_events","type":"User","site_admin":false},"body":"* Adjustments to Kaniko options handling\r\n* Support supplying multiple registries to both docker and kaniko builder types\r\n* Support for displaying links to images in goal externalUrls (with options to modify behavior of the links)\r\n","created_at":"2019-02-13T00:10:55Z","updated_at":"2019-02-13T10:36:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f691ff5bc5a8f369defd2496dbba1b4ac9ba4740","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/39/commits","review_comments_url":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/39/comments","review_comment_url":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atomist/sdm-pack-docker/issues/39/comments","statuses_url":"https://api.github.com/repos/atomist/sdm-pack-docker/statuses/7d18a408fbc7c2c555b7aa08a5a3ce10d518f66f","head":{"label":"atomist:ipcrm_multi_registry","ref":"ipcrm_multi_registry","sha":"7d18a408fbc7c2c555b7aa08a5a3ce10d518f66f","user":{"login":"atomist","id":19392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Mzky","avatar_url":"https://avatars3.githubusercontent.com/u/19392?v=4","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"repo":{"id":147254539,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyNTQ1Mzk=","name":"sdm-pack-docker","full_name":"atomist/sdm-pack-docker","private":false,"owner":{"login":"atomist","id":19392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Mzky","avatar_url":"https://avatars3.githubusercontent.com/u/19392?v=4","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atomist/sdm-pack-docker","description":"Extension Pack for an Atomist SDM to integrate Docker","fork":false,"url":"https://api.github.com/repos/atomist/sdm-pack-docker","forks_url":"https://api.github.com/repos/atomist/sdm-pack-docker/forks","keys_url":"https://api.github.com/repos/atomist/sdm-pack-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomist/sdm-pack-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomist/sdm-pack-docker/teams","hooks_url":"https://api.github.com/repos/atomist/sdm-pack-docker/hooks","issue_events_url":"https://api.github.com/repos/atomist/sdm-pack-docker/issues/events{/number}","events_url":"https://api.github.com/repos/atomist/sdm-pack-docker/events","assignees_url":"https://api.github.com/repos/atomist/sdm-pack-docker/assignees{/user}","branches_url":"https://api.github.com/repos/atomist/sdm-pack-docker/branches{/branch}","tags_url":"https://api.github.com/repos/atomist/sdm-pack-docker/tags","blobs_url":"https://api.github.com/repos/atomist/sdm-pack-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomist/sdm-pack-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomist/sdm-pack-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomist/sdm-pack-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomist/sdm-pack-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/atomist/sdm-pack-docker/languages","stargazers_url":"https://api.github.com/repos/atomist/sdm-pack-docker/stargazers","contributors_url":"https://api.github.com/repos/atomist/sdm-pack-docker/contributors","subscribers_url":"https://api.github.com/repos/atomist/sdm-pack-docker/subscribers","subscription_url":"https://api.github.com/repos/atomist/sdm-pack-docker/subscription","commits_url":"https://api.github.com/repos/atomist/sdm-pack-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomist/sdm-pack-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomist/sdm-pack-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomist/sdm-pack-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomist/sdm-pack-docker/contents/{+path}","compare_url":"https://api.github.com/repos/atomist/sdm-pack-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomist/sdm-pack-docker/merges","archive_url":"https://api.github.com/repos/atomist/sdm-pack-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomist/sdm-pack-docker/downloads","issues_url":"https://api.github.com/repos/atomist/sdm-pack-docker/issues{/number}","pulls_url":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/atomist/sdm-pack-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/atomist/sdm-pack-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomist/sdm-pack-docker/labels{/name}","releases_url":"https://api.github.com/repos/atomist/sdm-pack-docker/releases{/id}","deployments_url":"https://api.github.com/repos/atomist/sdm-pack-docker/deployments","created_at":"2018-09-03T21:18:37Z","updated_at":"2019-02-07T00:22:41Z","pushed_at":"2019-02-13T00:10:56Z","git_url":"git://github.com/atomist/sdm-pack-docker.git","ssh_url":"git@github.com:atomist/sdm-pack-docker.git","clone_url":"https://github.com/atomist/sdm-pack-docker.git","svn_url":"https://github.com/atomist/sdm-pack-docker","homepage":"","size":638,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"atomist:kaniko","ref":"kaniko","sha":"e3481450e8c456f18829152fba9f66f23e9c1bf0","user":{"login":"atomist","id":19392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Mzky","avatar_url":"https://avatars3.githubusercontent.com/u/19392?v=4","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"repo":{"id":147254539,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyNTQ1Mzk=","name":"sdm-pack-docker","full_name":"atomist/sdm-pack-docker","private":false,"owner":{"login":"atomist","id":19392,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Mzky","avatar_url":"https://avatars3.githubusercontent.com/u/19392?v=4","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atomist/sdm-pack-docker","description":"Extension Pack for an Atomist SDM to integrate Docker","fork":false,"url":"https://api.github.com/repos/atomist/sdm-pack-docker","forks_url":"https://api.github.com/repos/atomist/sdm-pack-docker/forks","keys_url":"https://api.github.com/repos/atomist/sdm-pack-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomist/sdm-pack-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomist/sdm-pack-docker/teams","hooks_url":"https://api.github.com/repos/atomist/sdm-pack-docker/hooks","issue_events_url":"https://api.github.com/repos/atomist/sdm-pack-docker/issues/events{/number}","events_url":"https://api.github.com/repos/atomist/sdm-pack-docker/events","assignees_url":"https://api.github.com/repos/atomist/sdm-pack-docker/assignees{/user}","branches_url":"https://api.github.com/repos/atomist/sdm-pack-docker/branches{/branch}","tags_url":"https://api.github.com/repos/atomist/sdm-pack-docker/tags","blobs_url":"https://api.github.com/repos/atomist/sdm-pack-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomist/sdm-pack-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomist/sdm-pack-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomist/sdm-pack-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomist/sdm-pack-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/atomist/sdm-pack-docker/languages","stargazers_url":"https://api.github.com/repos/atomist/sdm-pack-docker/stargazers","contributors_url":"https://api.github.com/repos/atomist/sdm-pack-docker/contributors","subscribers_url":"https://api.github.com/repos/atomist/sdm-pack-docker/subscribers","subscription_url":"https://api.github.com/repos/atomist/sdm-pack-docker/subscription","commits_url":"https://api.github.com/repos/atomist/sdm-pack-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomist/sdm-pack-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomist/sdm-pack-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomist/sdm-pack-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomist/sdm-pack-docker/contents/{+path}","compare_url":"https://api.github.com/repos/atomist/sdm-pack-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomist/sdm-pack-docker/merges","archive_url":"https://api.github.com/repos/atomist/sdm-pack-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomist/sdm-pack-docker/downloads","issues_url":"https://api.github.com/repos/atomist/sdm-pack-docker/issues{/number}","pulls_url":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/atomist/sdm-pack-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/atomist/sdm-pack-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomist/sdm-pack-docker/labels{/name}","releases_url":"https://api.github.com/repos/atomist/sdm-pack-docker/releases{/id}","deployments_url":"https://api.github.com/repos/atomist/sdm-pack-docker/deployments","created_at":"2018-09-03T21:18:37Z","updated_at":"2019-02-07T00:22:41Z","pushed_at":"2019-02-13T00:10:56Z","git_url":"git://github.com/atomist/sdm-pack-docker.git","ssh_url":"git@github.com:atomist/sdm-pack-docker.git","clone_url":"https://github.com/atomist/sdm-pack-docker.git","svn_url":"https://github.com/atomist/sdm-pack-docker","homepage":"","size":638,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/39"},"html":{"href":"https://github.com/atomist/sdm-pack-docker/pull/39"},"issue":{"href":"https://api.github.com/repos/atomist/sdm-pack-docker/issues/39"},"comments":{"href":"https://api.github.com/repos/atomist/sdm-pack-docker/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atomist/sdm-pack-docker/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/atomist/sdm-pack-docker/statuses/7d18a408fbc7c2c555b7aa08a5a3ce10d518f66f"}},"author_association":"NONE"}}
{"actor":{"display_login":"cdupuis"}}