{"action":"created","comment":{"url":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/comments/364897393","pull_request_review_id":340730189,"id":364897393,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDg5NzM5Mw==","diff_hunk":"@@ -39,30 +26,41 @@\n   height: 100%;\n   max-height: 100%;\n }\n-\n-[aria-label=\"breadcrumb\"] {\n-  position: relative;\n-}\n-\n-.modeler-save-button {\n-  right: 1rem;\n-  transform: translateY(-50%);\n-  top: 50%;\n-}\n </style>\n @endsection\n \n @section('js')\n   <script src=\"{{mix('js/leave-warning.js')}}\"></script>\n-  <script>\n+  <script> \n+  const breadcrumbData = [\n+    {\n+      'text':'{{__('Designer')}}',\n+      'url':'{{route('processes.index')}}'\n+    },\n+    {\n+      'text':'{{__('Processes')}}',\n+      'url':'{{route('processes.index')}}'\n+    },\n+    {\n+      'text':'{{__('Modeler')}}',\n+      'url':''\n+    },\n+    {\n+      'text':'{{$process->name}}',\n+      'url':''\n+    },\n+  ]\n   window.ProcessMaker.modeler = {\n     process: @json($process),\n-    xml: @json($process->bpmn)\n+    xml: @json($process->bpmn),\n+    processName: @json($process->name),\n   }\n   const warnings = @json($process->warnings);\n-  window.ProcessMaker.EventBus.$on('modeler-start', ({ loadXML, addWarnings }) => {\n+ \n+  window.ProcessMaker.EventBus.$on('modeler-start', ({ loadXML, addWarnings, breadcrumbs }) => {\n     loadXML(window.ProcessMaker.modeler.xml);\n     addWarnings(warnings || []);\n+    breadcrumbs(breadcrumbData || []);","path":"resources/views/processes/modeler/index.blade.php","position":71,"original_position":71,"commit_id":"4a1cec2563e76ecc4769965b5e2a0539f1e09944","original_commit_id":"4a1cec2563e76ecc4769965b5e2a0539f1e09944","user":{"login":"chipit24","id":7561061,"node_id":"MDQ6VXNlcjc1NjEwNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/7561061?v=4","gravatar_id":"","url":"https://api.github.com/users/chipit24","html_url":"https://github.com/chipit24","followers_url":"https://api.github.com/users/chipit24/followers","following_url":"https://api.github.com/users/chipit24/following{/other_user}","gists_url":"https://api.github.com/users/chipit24/gists{/gist_id}","starred_url":"https://api.github.com/users/chipit24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipit24/subscriptions","organizations_url":"https://api.github.com/users/chipit24/orgs","repos_url":"https://api.github.com/users/chipit24/repos","events_url":"https://api.github.com/users/chipit24/events{/privacy}","received_events_url":"https://api.github.com/users/chipit24/received_events","type":"User","site_admin":false},"body":"Do you think a name like `addBreadcrumbs` would be more readable? I think it will keep it consistent with the naming for the function above it (`addWarnigns`) and also better communicate what the function is actually doing.","created_at":"2020-01-09T18:36:47Z","updated_at":"2020-01-09T18:36:48Z","html_url":"https://github.com/ProcessMaker/processmaker/pull/2722#discussion_r364897393","pull_request_url":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/2722","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/comments/364897393"},"html":{"href":"https://github.com/ProcessMaker/processmaker/pull/2722#discussion_r364897393"},"pull_request":{"href":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/2722"}}},"pull_request":{"url":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/2722","id":361033652,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxMDMzNjUy","html_url":"https://github.com/ProcessMaker/processmaker/pull/2722","diff_url":"https://github.com/ProcessMaker/processmaker/pull/2722.diff","patch_url":"https://github.com/ProcessMaker/processmaker/pull/2722.patch","issue_url":"https://api.github.com/repos/ProcessMaker/processmaker/issues/2722","number":2722,"state":"open","locked":false,"title":"Merge breadcrumb nav and toolbar","user":{"login":"tuantruong625","id":26545455,"node_id":"MDQ6VXNlcjI2NTQ1NDU1","avatar_url":"https://avatars0.githubusercontent.com/u/26545455?v=4","gravatar_id":"","url":"https://api.github.com/users/tuantruong625","html_url":"https://github.com/tuantruong625","followers_url":"https://api.github.com/users/tuantruong625/followers","following_url":"https://api.github.com/users/tuantruong625/following{/other_user}","gists_url":"https://api.github.com/users/tuantruong625/gists{/gist_id}","starred_url":"https://api.github.com/users/tuantruong625/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuantruong625/subscriptions","organizations_url":"https://api.github.com/users/tuantruong625/orgs","repos_url":"https://api.github.com/users/tuantruong625/repos","events_url":"https://api.github.com/users/tuantruong625/events{/privacy}","received_events_url":"https://api.github.com/users/tuantruong625/received_events","type":"User","site_admin":false},"body":"The purpose of this PR is to merge the breadcrumb navigation with the toolbar into a single bar.\r\n\r\n**Note**\r\n- Replace breadcrumbs with modeler toolbar which contains, breadcrumbs and toolbar\r\n\r\nAssociated PR in Modeler\r\nhttps://github.com/ProcessMaker/modeler/pull/1010\r\n ","created_at":"2020-01-09T16:01:23Z","updated_at":"2020-01-09T18:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc970732ce72dbedbe9ba09ff9235d83c27be107","assignee":{"login":"tuantruong625","id":26545455,"node_id":"MDQ6VXNlcjI2NTQ1NDU1","avatar_url":"https://avatars0.githubusercontent.com/u/26545455?v=4","gravatar_id":"","url":"https://api.github.com/users/tuantruong625","html_url":"https://github.com/tuantruong625","followers_url":"https://api.github.com/users/tuantruong625/followers","following_url":"https://api.github.com/users/tuantruong625/following{/other_user}","gists_url":"https://api.github.com/users/tuantruong625/gists{/gist_id}","starred_url":"https://api.github.com/users/tuantruong625/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuantruong625/subscriptions","organizations_url":"https://api.github.com/users/tuantruong625/orgs","repos_url":"https://api.github.com/users/tuantruong625/repos","events_url":"https://api.github.com/users/tuantruong625/events{/privacy}","received_events_url":"https://api.github.com/users/tuantruong625/received_events","type":"User","site_admin":false},"assignees":[{"login":"tuantruong625","id":26545455,"node_id":"MDQ6VXNlcjI2NTQ1NDU1","avatar_url":"https://avatars0.githubusercontent.com/u/26545455?v=4","gravatar_id":"","url":"https://api.github.com/users/tuantruong625","html_url":"https://github.com/tuantruong625","followers_url":"https://api.github.com/users/tuantruong625/followers","following_url":"https://api.github.com/users/tuantruong625/following{/other_user}","gists_url":"https://api.github.com/users/tuantruong625/gists{/gist_id}","starred_url":"https://api.github.com/users/tuantruong625/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuantruong625/subscriptions","organizations_url":"https://api.github.com/users/tuantruong625/orgs","repos_url":"https://api.github.com/users/tuantruong625/repos","events_url":"https://api.github.com/users/tuantruong625/events{/privacy}","received_events_url":"https://api.github.com/users/tuantruong625/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"JCook21","id":858371,"node_id":"MDQ6VXNlcjg1ODM3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/858371?v=4","gravatar_id":"","url":"https://api.github.com/users/JCook21","html_url":"https://github.com/JCook21","followers_url":"https://api.github.com/users/JCook21/followers","following_url":"https://api.github.com/users/JCook21/following{/other_user}","gists_url":"https://api.github.com/users/JCook21/gists{/gist_id}","starred_url":"https://api.github.com/users/JCook21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCook21/subscriptions","organizations_url":"https://api.github.com/users/JCook21/orgs","repos_url":"https://api.github.com/users/JCook21/repos","events_url":"https://api.github.com/users/JCook21/events{/privacy}","received_events_url":"https://api.github.com/users/JCook21/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/2722/commits","review_comments_url":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/2722/comments","review_comment_url":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProcessMaker/processmaker/issues/2722/comments","statuses_url":"https://api.github.com/repos/ProcessMaker/processmaker/statuses/4a1cec2563e76ecc4769965b5e2a0539f1e09944","head":{"label":"ProcessMaker:788-toolbar-layout","ref":"788-toolbar-layout","sha":"4a1cec2563e76ecc4769965b5e2a0539f1e09944","user":{"login":"ProcessMaker","id":12500880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTAwODgw","avatar_url":"https://avatars0.githubusercontent.com/u/12500880?v=4","gravatar_id":"","url":"https://api.github.com/users/ProcessMaker","html_url":"https://github.com/ProcessMaker","followers_url":"https://api.github.com/users/ProcessMaker/followers","following_url":"https://api.github.com/users/ProcessMaker/following{/other_user}","gists_url":"https://api.github.com/users/ProcessMaker/gists{/gist_id}","starred_url":"https://api.github.com/users/ProcessMaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProcessMaker/subscriptions","organizations_url":"https://api.github.com/users/ProcessMaker/orgs","repos_url":"https://api.github.com/users/ProcessMaker/repos","events_url":"https://api.github.com/users/ProcessMaker/events{/privacy}","received_events_url":"https://api.github.com/users/ProcessMaker/received_events","type":"Organization","site_admin":false},"repo":{"id":127204751,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcyMDQ3NTE=","name":"processmaker","full_name":"ProcessMaker/processmaker","private":false,"owner":{"login":"ProcessMaker","id":12500880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTAwODgw","avatar_url":"https://avatars0.githubusercontent.com/u/12500880?v=4","gravatar_id":"","url":"https://api.github.com/users/ProcessMaker","html_url":"https://github.com/ProcessMaker","followers_url":"https://api.github.com/users/ProcessMaker/followers","following_url":"https://api.github.com/users/ProcessMaker/following{/other_user}","gists_url":"https://api.github.com/users/ProcessMaker/gists{/gist_id}","starred_url":"https://api.github.com/users/ProcessMaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProcessMaker/subscriptions","organizations_url":"https://api.github.com/users/ProcessMaker/orgs","repos_url":"https://api.github.com/users/ProcessMaker/repos","events_url":"https://api.github.com/users/ProcessMaker/events{/privacy}","received_events_url":"https://api.github.com/users/ProcessMaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProcessMaker/processmaker","description":"ProcessMaker BPM Core","fork":false,"url":"https://api.github.com/repos/ProcessMaker/processmaker","forks_url":"https://api.github.com/repos/ProcessMaker/processmaker/forks","keys_url":"https://api.github.com/repos/ProcessMaker/processmaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProcessMaker/processmaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProcessMaker/processmaker/teams","hooks_url":"https://api.github.com/repos/ProcessMaker/processmaker/hooks","issue_events_url":"https://api.github.com/repos/ProcessMaker/processmaker/issues/events{/number}","events_url":"https://api.github.com/repos/ProcessMaker/processmaker/events","assignees_url":"https://api.github.com/repos/ProcessMaker/processmaker/assignees{/user}","branches_url":"https://api.github.com/repos/ProcessMaker/processmaker/branches{/branch}","tags_url":"https://api.github.com/repos/ProcessMaker/processmaker/tags","blobs_url":"https://api.github.com/repos/ProcessMaker/processmaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProcessMaker/processmaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProcessMaker/processmaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProcessMaker/processmaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProcessMaker/processmaker/statuses/{sha}","languages_url":"https://api.github.com/repos/ProcessMaker/processmaker/languages","stargazers_url":"https://api.github.com/repos/ProcessMaker/processmaker/stargazers","contributors_url":"https://api.github.com/repos/ProcessMaker/processmaker/contributors","subscribers_url":"https://api.github.com/repos/ProcessMaker/processmaker/subscribers","subscription_url":"https://api.github.com/repos/ProcessMaker/processmaker/subscription","commits_url":"https://api.github.com/repos/ProcessMaker/processmaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProcessMaker/processmaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProcessMaker/processmaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProcessMaker/processmaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProcessMaker/processmaker/contents/{+path}","compare_url":"https://api.github.com/repos/ProcessMaker/processmaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProcessMaker/processmaker/merges","archive_url":"https://api.github.com/repos/ProcessMaker/processmaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProcessMaker/processmaker/downloads","issues_url":"https://api.github.com/repos/ProcessMaker/processmaker/issues{/number}","pulls_url":"https://api.github.com/repos/ProcessMaker/processmaker/pulls{/number}","milestones_url":"https://api.github.com/repos/ProcessMaker/processmaker/milestones{/number}","notifications_url":"https://api.github.com/repos/ProcessMaker/processmaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProcessMaker/processmaker/labels{/name}","releases_url":"https://api.github.com/repos/ProcessMaker/processmaker/releases{/id}","deployments_url":"https://api.github.com/repos/ProcessMaker/processmaker/deployments","created_at":"2018-03-28T22:15:29Z","updated_at":"2020-01-07T22:58:18Z","pushed_at":"2020-01-09T17:58:57Z","git_url":"git://github.com/ProcessMaker/processmaker.git","ssh_url":"git@github.com:ProcessMaker/processmaker.git","clone_url":"https://github.com/ProcessMaker/processmaker.git","svn_url":"https://github.com/ProcessMaker/processmaker","homepage":null,"size":76620,"stargazers_count":80,"watchers_count":80,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":95,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":43,"open_issues":95,"watchers":80,"default_branch":"develop"}},"base":{"label":"ProcessMaker:develop","ref":"develop","sha":"462a9143e21351d9d6a313dc782fd56953835731","user":{"login":"ProcessMaker","id":12500880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTAwODgw","avatar_url":"https://avatars0.githubusercontent.com/u/12500880?v=4","gravatar_id":"","url":"https://api.github.com/users/ProcessMaker","html_url":"https://github.com/ProcessMaker","followers_url":"https://api.github.com/users/ProcessMaker/followers","following_url":"https://api.github.com/users/ProcessMaker/following{/other_user}","gists_url":"https://api.github.com/users/ProcessMaker/gists{/gist_id}","starred_url":"https://api.github.com/users/ProcessMaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProcessMaker/subscriptions","organizations_url":"https://api.github.com/users/ProcessMaker/orgs","repos_url":"https://api.github.com/users/ProcessMaker/repos","events_url":"https://api.github.com/users/ProcessMaker/events{/privacy}","received_events_url":"https://api.github.com/users/ProcessMaker/received_events","type":"Organization","site_admin":false},"repo":{"id":127204751,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcyMDQ3NTE=","name":"processmaker","full_name":"ProcessMaker/processmaker","private":false,"owner":{"login":"ProcessMaker","id":12500880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTAwODgw","avatar_url":"https://avatars0.githubusercontent.com/u/12500880?v=4","gravatar_id":"","url":"https://api.github.com/users/ProcessMaker","html_url":"https://github.com/ProcessMaker","followers_url":"https://api.github.com/users/ProcessMaker/followers","following_url":"https://api.github.com/users/ProcessMaker/following{/other_user}","gists_url":"https://api.github.com/users/ProcessMaker/gists{/gist_id}","starred_url":"https://api.github.com/users/ProcessMaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProcessMaker/subscriptions","organizations_url":"https://api.github.com/users/ProcessMaker/orgs","repos_url":"https://api.github.com/users/ProcessMaker/repos","events_url":"https://api.github.com/users/ProcessMaker/events{/privacy}","received_events_url":"https://api.github.com/users/ProcessMaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProcessMaker/processmaker","description":"ProcessMaker BPM Core","fork":false,"url":"https://api.github.com/repos/ProcessMaker/processmaker","forks_url":"https://api.github.com/repos/ProcessMaker/processmaker/forks","keys_url":"https://api.github.com/repos/ProcessMaker/processmaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProcessMaker/processmaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProcessMaker/processmaker/teams","hooks_url":"https://api.github.com/repos/ProcessMaker/processmaker/hooks","issue_events_url":"https://api.github.com/repos/ProcessMaker/processmaker/issues/events{/number}","events_url":"https://api.github.com/repos/ProcessMaker/processmaker/events","assignees_url":"https://api.github.com/repos/ProcessMaker/processmaker/assignees{/user}","branches_url":"https://api.github.com/repos/ProcessMaker/processmaker/branches{/branch}","tags_url":"https://api.github.com/repos/ProcessMaker/processmaker/tags","blobs_url":"https://api.github.com/repos/ProcessMaker/processmaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProcessMaker/processmaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProcessMaker/processmaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProcessMaker/processmaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProcessMaker/processmaker/statuses/{sha}","languages_url":"https://api.github.com/repos/ProcessMaker/processmaker/languages","stargazers_url":"https://api.github.com/repos/ProcessMaker/processmaker/stargazers","contributors_url":"https://api.github.com/repos/ProcessMaker/processmaker/contributors","subscribers_url":"https://api.github.com/repos/ProcessMaker/processmaker/subscribers","subscription_url":"https://api.github.com/repos/ProcessMaker/processmaker/subscription","commits_url":"https://api.github.com/repos/ProcessMaker/processmaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProcessMaker/processmaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProcessMaker/processmaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProcessMaker/processmaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProcessMaker/processmaker/contents/{+path}","compare_url":"https://api.github.com/repos/ProcessMaker/processmaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProcessMaker/processmaker/merges","archive_url":"https://api.github.com/repos/ProcessMaker/processmaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProcessMaker/processmaker/downloads","issues_url":"https://api.github.com/repos/ProcessMaker/processmaker/issues{/number}","pulls_url":"https://api.github.com/repos/ProcessMaker/processmaker/pulls{/number}","milestones_url":"https://api.github.com/repos/ProcessMaker/processmaker/milestones{/number}","notifications_url":"https://api.github.com/repos/ProcessMaker/processmaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProcessMaker/processmaker/labels{/name}","releases_url":"https://api.github.com/repos/ProcessMaker/processmaker/releases{/id}","deployments_url":"https://api.github.com/repos/ProcessMaker/processmaker/deployments","created_at":"2018-03-28T22:15:29Z","updated_at":"2020-01-07T22:58:18Z","pushed_at":"2020-01-09T17:58:57Z","git_url":"git://github.com/ProcessMaker/processmaker.git","ssh_url":"git@github.com:ProcessMaker/processmaker.git","clone_url":"https://github.com/ProcessMaker/processmaker.git","svn_url":"https://github.com/ProcessMaker/processmaker","homepage":null,"size":76620,"stargazers_count":80,"watchers_count":80,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":95,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":43,"open_issues":95,"watchers":80,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/2722"},"html":{"href":"https://github.com/ProcessMaker/processmaker/pull/2722"},"issue":{"href":"https://api.github.com/repos/ProcessMaker/processmaker/issues/2722"},"comments":{"href":"https://api.github.com/repos/ProcessMaker/processmaker/issues/2722/comments"},"review_comments":{"href":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/2722/comments"},"review_comment":{"href":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProcessMaker/processmaker/pulls/2722/commits"},"statuses":{"href":"https://api.github.com/repos/ProcessMaker/processmaker/statuses/4a1cec2563e76ecc4769965b5e2a0539f1e09944"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"chipit24"}}