{"action":"closed","issue":{"url":"https://api.github.com/repos/Tazinho/Advanced-R-Solutions/issues/124","repository_url":"https://api.github.com/repos/Tazinho/Advanced-R-Solutions","labels_url":"https://api.github.com/repos/Tazinho/Advanced-R-Solutions/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/Tazinho/Advanced-R-Solutions/issues/124/comments","events_url":"https://api.github.com/repos/Tazinho/Advanced-R-Solutions/issues/124/events","html_url":"https://github.com/Tazinho/Advanced-R-Solutions/issues/124","id":394878300,"node_id":"MDU6SXNzdWUzOTQ4NzgzMDA=","number":124,"title":"[Edit] - \"Conditions\"-Chapter","user":{"login":"Tazinho","id":11295192,"node_id":"MDQ6VXNlcjExMjk1MTky","avatar_url":"https://avatars1.githubusercontent.com/u/11295192?v=4","gravatar_id":"","url":"https://api.github.com/users/Tazinho","html_url":"https://github.com/Tazinho","followers_url":"https://api.github.com/users/Tazinho/followers","following_url":"https://api.github.com/users/Tazinho/following{/other_user}","gists_url":"https://api.github.com/users/Tazinho/gists{/gist_id}","starred_url":"https://api.github.com/users/Tazinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tazinho/subscriptions","organizations_url":"https://api.github.com/users/Tazinho/orgs","repos_url":"https://api.github.com/users/Tazinho/repos","events_url":"https://api.github.com/users/Tazinho/events{/privacy}","received_events_url":"https://api.github.com/users/Tazinho/received_events","type":"User","site_admin":false},"labels":[{"id":1078622918,"node_id":"MDU6TGFiZWwxMDc4NjIyOTE4","url":"https://api.github.com/repos/Tazinho/Advanced-R-Solutions/labels/editing%20%F0%9F%93%9D","name":"editing 📝","color":"79e53b","default":false}],"state":"closed","locked":false,"assignee":{"login":"henningsway","id":1403304,"node_id":"MDQ6VXNlcjE0MDMzMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1403304?v=4","gravatar_id":"","url":"https://api.github.com/users/henningsway","html_url":"https://github.com/henningsway","followers_url":"https://api.github.com/users/henningsway/followers","following_url":"https://api.github.com/users/henningsway/following{/other_user}","gists_url":"https://api.github.com/users/henningsway/gists{/gist_id}","starred_url":"https://api.github.com/users/henningsway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henningsway/subscriptions","organizations_url":"https://api.github.com/users/henningsway/orgs","repos_url":"https://api.github.com/users/henningsway/repos","events_url":"https://api.github.com/users/henningsway/events{/privacy}","received_events_url":"https://api.github.com/users/henningsway/received_events","type":"User","site_admin":false},"assignees":[{"login":"henningsway","id":1403304,"node_id":"MDQ6VXNlcjE0MDMzMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1403304?v=4","gravatar_id":"","url":"https://api.github.com/users/henningsway","html_url":"https://github.com/henningsway","followers_url":"https://api.github.com/users/henningsway/followers","following_url":"https://api.github.com/users/henningsway/following{/other_user}","gists_url":"https://api.github.com/users/henningsway/gists{/gist_id}","starred_url":"https://api.github.com/users/henningsway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henningsway/subscriptions","organizations_url":"https://api.github.com/users/henningsway/orgs","repos_url":"https://api.github.com/users/henningsway/repos","events_url":"https://api.github.com/users/henningsway/events{/privacy}","received_events_url":"https://api.github.com/users/henningsway/received_events","type":"User","site_admin":false},{"login":"Tazinho","id":11295192,"node_id":"MDQ6VXNlcjExMjk1MTky","avatar_url":"https://avatars1.githubusercontent.com/u/11295192?v=4","gravatar_id":"","url":"https://api.github.com/users/Tazinho","html_url":"https://github.com/Tazinho","followers_url":"https://api.github.com/users/Tazinho/followers","following_url":"https://api.github.com/users/Tazinho/following{/other_user}","gists_url":"https://api.github.com/users/Tazinho/gists{/gist_id}","starred_url":"https://api.github.com/users/Tazinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tazinho/subscriptions","organizations_url":"https://api.github.com/users/Tazinho/orgs","repos_url":"https://api.github.com/users/Tazinho/repos","events_url":"https://api.github.com/users/Tazinho/events{/privacy}","received_events_url":"https://api.github.com/users/Tazinho/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Tazinho/Advanced-R-Solutions/milestones/4","html_url":"https://github.com/Tazinho/Advanced-R-Solutions/milestone/4","labels_url":"https://api.github.com/repos/Tazinho/Advanced-R-Solutions/milestones/4/labels","id":3717770,"node_id":"MDk6TWlsZXN0b25lMzcxNzc3MA==","number":4,"title":"Part I  complete","description":"These Exersises will change the least and a pretty stable already. So let's tackle these first.","creator":{"login":"henningsway","id":1403304,"node_id":"MDQ6VXNlcjE0MDMzMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1403304?v=4","gravatar_id":"","url":"https://api.github.com/users/henningsway","html_url":"https://github.com/henningsway","followers_url":"https://api.github.com/users/henningsway/followers","following_url":"https://api.github.com/users/henningsway/following{/other_user}","gists_url":"https://api.github.com/users/henningsway/gists{/gist_id}","starred_url":"https://api.github.com/users/henningsway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henningsway/subscriptions","organizations_url":"https://api.github.com/users/henningsway/orgs","repos_url":"https://api.github.com/users/henningsway/repos","events_url":"https://api.github.com/users/henningsway/events{/privacy}","received_events_url":"https://api.github.com/users/henningsway/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":12,"state":"open","created_at":"2018-10-07T15:49:13Z","updated_at":"2019-02-12T12:41:04Z","due_on":"2019-02-28T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-12-30T14:59:12Z","updated_at":"2019-02-12T12:41:04Z","closed_at":"2019-02-12T12:41:04Z","author_association":"OWNER","body":"@Tazinho \r\n- [x] Sync subsection names\r\n- [x] Ensure that exercise numbers go 1,2,3,.. in each subsection.\r\n- [x] Ensure linebreaks between Q & As\r\n- [x] Sync the text and the order of all exercises in the chapter between Adv R and Adv R Solutions.\r\n\r\nRead through all exercises. Edit them if possible and mark their correct status (green = \"think this solution is correct\", orange = \"this solution is definitely not correct or sth. is missing\". If sth. is missing, try to includede a todo). Also document open points within the following checklist:\r\n- [x] [Signalling conditions](https://advanced-r-solutions.rbind.io/conditions.html#signalling-conditions)\r\n  - [x] Nr. 1\r\n  - [x] Nr. 2: \r\n    - Unfortunately not really solved yet. Also: Maybe we can find better (less arbitrary) names for the examples...also think about using the info from the footnote on `cat()`\r\n- [x] [Handling conditions](https://advanced-r-solutions.rbind.io/conditions.html#signalling-conditions)\r\n  - [x] Nr. 1: The output might be a little bit long. Also: Why doesn't `catch_cnd()` throw an error (rlang is not loaded in any of the above codechunks!?)\r\n  - [x] Nr. 2: Maybe we can format the comments a bit nicer (Or answer the question within a new code chunk)\r\n  - [x] Nr. 3: @Tazinho could you clarify a little bit more, what is happening in this example? Afterwards, I will improve the prose.\r\n    TBH, after looking at this answer again, I think it is already clear enough.\r\n  - [x] Nr. 4: Improve formulations a bit\r\n  - [x] Nr. 5: Not sure if we need the 2nd part of the answer. (It might become too lengthy).\r\n        @Tazinho could you elaborate a little bit more on, how this works exactly? (1 good sentence or so)\r\n    - Thanks, looks far better without the 2nd part of the answer!\r\n- [x] [Custom conditions](https://advanced-r-solutions.rbind.io/conditions.html#custom-conditions)\r\n  - [x] Nr. 1: Improve forumlations a bit.\r\n  - [x] Nr. 2: Unclear if the solution is correct.\r\n- [x] [Applications](https://advanced-r-solutions.rbind.io/conditions.html#Applications)\r\n  - [x] Nr. 1: From my perspective this one is solved. If Hadley rejects this solutions we might need to ask him about why `dump.frames()` doesn't seem to work as documented. Regarding issue on SO: https://stackoverflow.com/questions/23329178/why-is-behavior-in-r-cmd-batch-different-for-optionserror-utilsdump-frames. Or we might adapt some parts from `purrr::safely()` or `purrr::possibly()`. (However, we should then clarify the intention of this exercise, as it formulated a bit inconcrete.)\r\n  - [x] Nr. 2: Need to add good screenshots to the book, as .Rmd won't show the traceback natively.\r\n    ![grafik](https://user-images.githubusercontent.com/11295192/50551247-fe652e80-0c7d-11e9-8757-7b2e689440bb.png)\r\n  - [x] Nr. 3: Not solved yet.\r\n  - [x] Nr. 4: @Tazinho Let's try to finalize this together.\r\n\r\n- [x] All open points/exercises should now be reported explicitly under each bullet point above (maybe henningsway can solve one or the other, has a good idea for a new approach or has a more specific question to raise in an issue to Hadley. \r\n\r\n- [x] Assign Henningsway\r\n\r\n@henningsway \r\n- [x] Read & edit all exercises.\r\n- [x] Report any new points while updating the list above. \r\n- [x] Run a final spellcheck\r\n\r\n@Tazinho and @henningsway \r\n- [x] Try to resolve any of the reported issues above. "}}
{"actor":{"display_login":"Tazinho"}}