{"action":"created","comment":{"url":"https://api.github.com/repos/heimdal/heimdal/pulls/comments/356341613","pull_request_review_id":330219635,"id":356341613,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NjM0MTYxMw==","diff_hunk":"@@ -202,9 +203,11 @@ _kdc_audit_trail(kdc_request_t r, krb5_error_code ret)\n     }\n     kvbuf[j] = '\\0';\n \n-    kdc_log(r->context, r->config, 3, \"%s %s %s %s %s%s\",\n-\t    r->reqtype, retval, r->from, r->cname,\n-\t    r->sname, kvbuf);\n+    kdc_log(r->context, r->config, 3, \"%s %s %d %s %s %s%s\",\n+\t    r->reqtype, retval, ret, r->from,","path":"kdc/process.c","position":16,"original_position":16,"commit_id":"dd114c078826fb7ae7cd0b818c950c81c3d9a738","original_commit_id":"dd114c078826fb7ae7cd0b818c950c81c3d9a738","user":{"login":"vdukhovni","id":1107986,"node_id":"MDQ6VXNlcjExMDc5ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1107986?v=4","gravatar_id":"","url":"https://api.github.com/users/vdukhovni","html_url":"https://github.com/vdukhovni","followers_url":"https://api.github.com/users/vdukhovni/followers","following_url":"https://api.github.com/users/vdukhovni/following{/other_user}","gists_url":"https://api.github.com/users/vdukhovni/gists{/gist_id}","starred_url":"https://api.github.com/users/vdukhovni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdukhovni/subscriptions","organizations_url":"https://api.github.com/users/vdukhovni/orgs","repos_url":"https://api.github.com/users/vdukhovni/repos","events_url":"https://api.github.com/users/vdukhovni/events{/privacy}","received_events_url":"https://api.github.com/users/vdukhovni/received_events","type":"User","site_admin":false},"body":"I thought you would only add the integer ret when we don't have a known string...","created_at":"2019-12-10T23:56:01Z","updated_at":"2019-12-10T23:57:06Z","html_url":"https://github.com/heimdal/heimdal/pull/665#discussion_r356341613","pull_request_url":"https://api.github.com/repos/heimdal/heimdal/pulls/665","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/heimdal/heimdal/pulls/comments/356341613"},"html":{"href":"https://github.com/heimdal/heimdal/pull/665#discussion_r356341613"},"pull_request":{"href":"https://api.github.com/repos/heimdal/heimdal/pulls/665"}}},"pull_request":{"url":"https://api.github.com/repos/heimdal/heimdal/pulls/665","id":351655838,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxNjU1ODM4","html_url":"https://github.com/heimdal/heimdal/pull/665","diff_url":"https://github.com/heimdal/heimdal/pull/665.diff","patch_url":"https://github.com/heimdal/heimdal/pull/665.patch","issue_url":"https://api.github.com/repos/heimdal/heimdal/issues/665","number":665,"state":"open","locked":false,"title":"Update bx509d to log the new way","user":{"login":"nicowilliams","id":604851,"node_id":"MDQ6VXNlcjYwNDg1MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/604851?v=4","gravatar_id":"","url":"https://api.github.com/users/nicowilliams","html_url":"https://github.com/nicowilliams","followers_url":"https://api.github.com/users/nicowilliams/followers","following_url":"https://api.github.com/users/nicowilliams/following{/other_user}","gists_url":"https://api.github.com/users/nicowilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/nicowilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicowilliams/subscriptions","organizations_url":"https://api.github.com/users/nicowilliams/orgs","repos_url":"https://api.github.com/users/nicowilliams/repos","events_url":"https://api.github.com/users/nicowilliams/events{/privacy}","received_events_url":"https://api.github.com/users/nicowilliams/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-10T23:38:56Z","updated_at":"2019-12-10T23:57:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dae9fe41d7ad44b0e0445612cb32080ea16706c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heimdal/heimdal/pulls/665/commits","review_comments_url":"https://api.github.com/repos/heimdal/heimdal/pulls/665/comments","review_comment_url":"https://api.github.com/repos/heimdal/heimdal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heimdal/heimdal/issues/665/comments","statuses_url":"https://api.github.com/repos/heimdal/heimdal/statuses/dd114c078826fb7ae7cd0b818c950c81c3d9a738","head":{"label":"nicowilliams:master","ref":"master","sha":"dd114c078826fb7ae7cd0b818c950c81c3d9a738","user":{"login":"nicowilliams","id":604851,"node_id":"MDQ6VXNlcjYwNDg1MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/604851?v=4","gravatar_id":"","url":"https://api.github.com/users/nicowilliams","html_url":"https://github.com/nicowilliams","followers_url":"https://api.github.com/users/nicowilliams/followers","following_url":"https://api.github.com/users/nicowilliams/following{/other_user}","gists_url":"https://api.github.com/users/nicowilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/nicowilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicowilliams/subscriptions","organizations_url":"https://api.github.com/users/nicowilliams/orgs","repos_url":"https://api.github.com/users/nicowilliams/repos","events_url":"https://api.github.com/users/nicowilliams/events{/privacy}","received_events_url":"https://api.github.com/users/nicowilliams/received_events","type":"User","site_admin":false},"repo":{"id":2089649,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg5NjQ5","name":"heimdal","full_name":"nicowilliams/heimdal","private":false,"owner":{"login":"nicowilliams","id":604851,"node_id":"MDQ6VXNlcjYwNDg1MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/604851?v=4","gravatar_id":"","url":"https://api.github.com/users/nicowilliams","html_url":"https://github.com/nicowilliams","followers_url":"https://api.github.com/users/nicowilliams/followers","following_url":"https://api.github.com/users/nicowilliams/following{/other_user}","gists_url":"https://api.github.com/users/nicowilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/nicowilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicowilliams/subscriptions","organizations_url":"https://api.github.com/users/nicowilliams/orgs","repos_url":"https://api.github.com/users/nicowilliams/repos","events_url":"https://api.github.com/users/nicowilliams/events{/privacy}","received_events_url":"https://api.github.com/users/nicowilliams/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nicowilliams/heimdal","description":"Heimdal","fork":true,"url":"https://api.github.com/repos/nicowilliams/heimdal","forks_url":"https://api.github.com/repos/nicowilliams/heimdal/forks","keys_url":"https://api.github.com/repos/nicowilliams/heimdal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicowilliams/heimdal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicowilliams/heimdal/teams","hooks_url":"https://api.github.com/repos/nicowilliams/heimdal/hooks","issue_events_url":"https://api.github.com/repos/nicowilliams/heimdal/issues/events{/number}","events_url":"https://api.github.com/repos/nicowilliams/heimdal/events","assignees_url":"https://api.github.com/repos/nicowilliams/heimdal/assignees{/user}","branches_url":"https://api.github.com/repos/nicowilliams/heimdal/branches{/branch}","tags_url":"https://api.github.com/repos/nicowilliams/heimdal/tags","blobs_url":"https://api.github.com/repos/nicowilliams/heimdal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicowilliams/heimdal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicowilliams/heimdal/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicowilliams/heimdal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicowilliams/heimdal/statuses/{sha}","languages_url":"https://api.github.com/repos/nicowilliams/heimdal/languages","stargazers_url":"https://api.github.com/repos/nicowilliams/heimdal/stargazers","contributors_url":"https://api.github.com/repos/nicowilliams/heimdal/contributors","subscribers_url":"https://api.github.com/repos/nicowilliams/heimdal/subscribers","subscription_url":"https://api.github.com/repos/nicowilliams/heimdal/subscription","commits_url":"https://api.github.com/repos/nicowilliams/heimdal/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicowilliams/heimdal/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicowilliams/heimdal/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicowilliams/heimdal/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicowilliams/heimdal/contents/{+path}","compare_url":"https://api.github.com/repos/nicowilliams/heimdal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicowilliams/heimdal/merges","archive_url":"https://api.github.com/repos/nicowilliams/heimdal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicowilliams/heimdal/downloads","issues_url":"https://api.github.com/repos/nicowilliams/heimdal/issues{/number}","pulls_url":"https://api.github.com/repos/nicowilliams/heimdal/pulls{/number}","milestones_url":"https://api.github.com/repos/nicowilliams/heimdal/milestones{/number}","notifications_url":"https://api.github.com/repos/nicowilliams/heimdal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicowilliams/heimdal/labels{/name}","releases_url":"https://api.github.com/repos/nicowilliams/heimdal/releases{/id}","deployments_url":"https://api.github.com/repos/nicowilliams/heimdal/deployments","created_at":"2011-07-22T16:58:02Z","updated_at":"2019-12-10T23:37:36Z","pushed_at":"2019-12-10T23:37:34Z","git_url":"git://github.com/nicowilliams/heimdal.git","ssh_url":"git@github.com:nicowilliams/heimdal.git","clone_url":"https://github.com/nicowilliams/heimdal.git","svn_url":"https://github.com/nicowilliams/heimdal","homepage":"http://www.h5l.org/","size":47198,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"heimdal:master","ref":"master","sha":"5c25450e504f525720b5565f5f6c5367bc238f21","user":{"login":"heimdal","id":131972,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTk3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/131972?v=4","gravatar_id":"","url":"https://api.github.com/users/heimdal","html_url":"https://github.com/heimdal","followers_url":"https://api.github.com/users/heimdal/followers","following_url":"https://api.github.com/users/heimdal/following{/other_user}","gists_url":"https://api.github.com/users/heimdal/gists{/gist_id}","starred_url":"https://api.github.com/users/heimdal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heimdal/subscriptions","organizations_url":"https://api.github.com/users/heimdal/orgs","repos_url":"https://api.github.com/users/heimdal/repos","events_url":"https://api.github.com/users/heimdal/events{/privacy}","received_events_url":"https://api.github.com/users/heimdal/received_events","type":"Organization","site_admin":false},"repo":{"id":319333,"node_id":"MDEwOlJlcG9zaXRvcnkzMTkzMzM=","name":"heimdal","full_name":"heimdal/heimdal","private":false,"owner":{"login":"heimdal","id":131972,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTk3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/131972?v=4","gravatar_id":"","url":"https://api.github.com/users/heimdal","html_url":"https://github.com/heimdal","followers_url":"https://api.github.com/users/heimdal/followers","following_url":"https://api.github.com/users/heimdal/following{/other_user}","gists_url":"https://api.github.com/users/heimdal/gists{/gist_id}","starred_url":"https://api.github.com/users/heimdal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heimdal/subscriptions","organizations_url":"https://api.github.com/users/heimdal/orgs","repos_url":"https://api.github.com/users/heimdal/repos","events_url":"https://api.github.com/users/heimdal/events{/privacy}","received_events_url":"https://api.github.com/users/heimdal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/heimdal/heimdal","description":"Heimdal","fork":false,"url":"https://api.github.com/repos/heimdal/heimdal","forks_url":"https://api.github.com/repos/heimdal/heimdal/forks","keys_url":"https://api.github.com/repos/heimdal/heimdal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heimdal/heimdal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heimdal/heimdal/teams","hooks_url":"https://api.github.com/repos/heimdal/heimdal/hooks","issue_events_url":"https://api.github.com/repos/heimdal/heimdal/issues/events{/number}","events_url":"https://api.github.com/repos/heimdal/heimdal/events","assignees_url":"https://api.github.com/repos/heimdal/heimdal/assignees{/user}","branches_url":"https://api.github.com/repos/heimdal/heimdal/branches{/branch}","tags_url":"https://api.github.com/repos/heimdal/heimdal/tags","blobs_url":"https://api.github.com/repos/heimdal/heimdal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heimdal/heimdal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heimdal/heimdal/git/refs{/sha}","trees_url":"https://api.github.com/repos/heimdal/heimdal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heimdal/heimdal/statuses/{sha}","languages_url":"https://api.github.com/repos/heimdal/heimdal/languages","stargazers_url":"https://api.github.com/repos/heimdal/heimdal/stargazers","contributors_url":"https://api.github.com/repos/heimdal/heimdal/contributors","subscribers_url":"https://api.github.com/repos/heimdal/heimdal/subscribers","subscription_url":"https://api.github.com/repos/heimdal/heimdal/subscription","commits_url":"https://api.github.com/repos/heimdal/heimdal/commits{/sha}","git_commits_url":"https://api.github.com/repos/heimdal/heimdal/git/commits{/sha}","comments_url":"https://api.github.com/repos/heimdal/heimdal/comments{/number}","issue_comment_url":"https://api.github.com/repos/heimdal/heimdal/issues/comments{/number}","contents_url":"https://api.github.com/repos/heimdal/heimdal/contents/{+path}","compare_url":"https://api.github.com/repos/heimdal/heimdal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heimdal/heimdal/merges","archive_url":"https://api.github.com/repos/heimdal/heimdal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heimdal/heimdal/downloads","issues_url":"https://api.github.com/repos/heimdal/heimdal/issues{/number}","pulls_url":"https://api.github.com/repos/heimdal/heimdal/pulls{/number}","milestones_url":"https://api.github.com/repos/heimdal/heimdal/milestones{/number}","notifications_url":"https://api.github.com/repos/heimdal/heimdal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heimdal/heimdal/labels{/name}","releases_url":"https://api.github.com/repos/heimdal/heimdal/releases{/id}","deployments_url":"https://api.github.com/repos/heimdal/heimdal/deployments","created_at":"2009-09-27T21:15:13Z","updated_at":"2019-12-10T20:11:08Z","pushed_at":"2019-12-10T23:38:57Z","git_url":"git://github.com/heimdal/heimdal.git","ssh_url":"git@github.com:heimdal/heimdal.git","clone_url":"https://github.com/heimdal/heimdal.git","svn_url":"https://github.com/heimdal/heimdal","homepage":"https://heimdal.software","size":46205,"stargazers_count":171,"watchers_count":171,"language":"C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":91,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":111,"open_issues":91,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heimdal/heimdal/pulls/665"},"html":{"href":"https://github.com/heimdal/heimdal/pull/665"},"issue":{"href":"https://api.github.com/repos/heimdal/heimdal/issues/665"},"comments":{"href":"https://api.github.com/repos/heimdal/heimdal/issues/665/comments"},"review_comments":{"href":"https://api.github.com/repos/heimdal/heimdal/pulls/665/comments"},"review_comment":{"href":"https://api.github.com/repos/heimdal/heimdal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heimdal/heimdal/pulls/665/commits"},"statuses":{"href":"https://api.github.com/repos/heimdal/heimdal/statuses/dd114c078826fb7ae7cd0b818c950c81c3d9a738"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vdukhovni"}}