{"action":"created","comment":{"url":"https://api.github.com/repos/cylc/cylc/pulls/comments/264600079","pull_request_review_id":213291183,"id":264600079,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NDYwMDA3OQ==","diff_hunk":"@@ -0,0 +1,70 @@\n+# THIS FILE IS PART OF THE CYLC SUITE ENGINE.\n+# Copyright (C) 2008-2018 NIWA & British Crown (Met Office) & Contributors.\n+#\n+# This program is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation, either version 3 of the License, or\n+# (at your option) any later version.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+\n+[metadata]\n+name = cylc\n+author = Hilary Oliver\n+author_email = cylc@googlegroups.com\n+url=https://cylc.github.io/\n+description =\n+    Cylc (\\\"silk\\\") is a workflow engine for cycling systems -\n+    it orchestrates distributed suites of interdependent\n+    cycling tasks that may continue to run indefinitely.\n+keywords =\n+    cycling-workflows\n+    hpc\n+    job-scheduler\n+    metascheduler\n+    workflow-automation\n+    workflow-engine\n+    workflow-management\n+    scheduling\n+license = GPL\n+license_file = COPYING\n+platforms = any\n+classifiers =\n+    Development Status :: 5 - Production/Stable","path":"setup.cfg","position":39,"original_position":39,"commit_id":"6ca3263d71017020a8ca88aa1f85a78393fe2abf","original_commit_id":"6ca3263d71017020a8ca88aa1f85a78393fe2abf","user":{"login":"kinow","id":304786,"node_id":"MDQ6VXNlcjMwNDc4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/304786?v=4","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false},"body":"Question for @cylc/core I think. No decision that I am aware. These classifiers - and pretty much everything in the metadata section - needs review from others too.","created_at":"2019-03-12T10:02:55Z","updated_at":"2019-03-12T10:02:55Z","html_url":"https://github.com/cylc/cylc/pull/2990#discussion_r264600079","pull_request_url":"https://api.github.com/repos/cylc/cylc/pulls/2990","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments/264600079"},"html":{"href":"https://github.com/cylc/cylc/pull/2990#discussion_r264600079"},"pull_request":{"href":"https://api.github.com/repos/cylc/cylc/pulls/2990"}},"in_reply_to_id":264592791},"pull_request":{"url":"https://api.github.com/repos/cylc/cylc/pulls/2990","id":260193900,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwMTkzOTAw","html_url":"https://github.com/cylc/cylc/pull/2990","diff_url":"https://github.com/cylc/cylc/pull/2990.diff","patch_url":"https://github.com/cylc/cylc/pull/2990.patch","issue_url":"https://api.github.com/repos/cylc/cylc/issues/2990","number":2990,"state":"open","locked":false,"title":"Make cylc a module","user":{"login":"kinow","id":304786,"node_id":"MDQ6VXNlcjMwNDc4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/304786?v=4","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false},"body":"Fix for #2989 \r\n\r\nAdapted code from previous pull request, but it was a bit outdated (4 months old), with conflicts due to Python 3. So I thought it would be easier to copy the `setuptools` files, and simply apply the other changes manually.\r\n\r\nAlso looked at `isodatetime` to see what we could improve in our `setup.py`.\r\n\r\n- Based on `master` with Python 3\r\n- Python requires set to 3.5\r\n- Removed the folders of jinja2, markupsafe, and isodatetime, as they are not dependencies in `setup.py`\r\n- Added dependencies introduced for Python 3 (e.g. colorama, pyzmq) to `setup.py`\r\n- Moved [static metadata](https://www.python.org/dev/peps/pep-0390/) to `setup.cfg`. It is possible to confirm what it looks like running `rm -rf lib/cylc.egg*`, then `pip install -e .`, and inspecting the `PKGINFO` file created within that egg folder\r\n- Copied the topics from our GitHub repository as keywords (except for Python)\r\n- Added more [classifiers](https://pypi.org/pypi?%3Aaction=list_classifiers) to the `setup.cfg`\r\n- Updates `.travis.yml` file to run `pip install -e .[all]` and `pip install -e .`.\r\n- Removed the old `ssl` groups from the old pull request, as it does not seem to be a requirement for `pyzmq` (@oliver-sanders ? not sure if I missed any dependency for Python 3)\r\n\r\nTests were done via `python setup.py test` and `cylc run --no-detach --debug --verbose five`. Let's see if Travis-CI approves these changes too.\r\n\r\nRelated: https://github.com/cylc/cylc/pull/2834","created_at":"2019-03-12T01:59:40Z","updated_at":"2019-03-12T10:02:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"935fc412d79b5ddcc99362be7bd3e8bf2bd19231","assignee":{"login":"kinow","id":304786,"node_id":"MDQ6VXNlcjMwNDc4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/304786?v=4","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false},"assignees":[{"login":"kinow","id":304786,"node_id":"MDQ6VXNlcjMwNDc4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/304786?v=4","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/cylc/cylc/milestones/77","html_url":"https://github.com/cylc/cylc/milestone/77","labels_url":"https://api.github.com/repos/cylc/cylc/milestones/77/labels","id":4125456,"node_id":"MDk6TWlsZXN0b25lNDEyNTQ1Ng==","number":77,"title":"cylc-8-alpha-1","description":"Python 3 + Hub + packaging + basic web UI (e.g. scan).\r\n(Date be adjusted after checking project Gantt chart...)","creator":{"login":"hjoliver","id":2362137,"node_id":"MDQ6VXNlcjIzNjIxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2362137?v=4","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":11,"state":"open","created_at":"2019-03-10T01:51:17Z","updated_at":"2019-03-12T01:59:40Z","due_on":"2019-06-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cylc/cylc/pulls/2990/commits","review_comments_url":"https://api.github.com/repos/cylc/cylc/pulls/2990/comments","review_comment_url":"https://api.github.com/repos/cylc/cylc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cylc/cylc/issues/2990/comments","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/6ca3263d71017020a8ca88aa1f85a78393fe2abf","head":{"label":"kinow:make-cylc-a-module-take-2","ref":"make-cylc-a-module-take-2","sha":"6ca3263d71017020a8ca88aa1f85a78393fe2abf","user":{"login":"kinow","id":304786,"node_id":"MDQ6VXNlcjMwNDc4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/304786?v=4","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false},"repo":{"id":51749332,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc0OTMzMg==","name":"cylc","full_name":"kinow/cylc","private":false,"owner":{"login":"kinow","id":304786,"node_id":"MDQ6VXNlcjMwNDc4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/304786?v=4","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kinow/cylc","description":"This is the official repository of the cylc suite engine. It will normally contain just the master branch, with completed features merged in from feature branches in developer forks.","fork":true,"url":"https://api.github.com/repos/kinow/cylc","forks_url":"https://api.github.com/repos/kinow/cylc/forks","keys_url":"https://api.github.com/repos/kinow/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinow/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinow/cylc/teams","hooks_url":"https://api.github.com/repos/kinow/cylc/hooks","issue_events_url":"https://api.github.com/repos/kinow/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/kinow/cylc/events","assignees_url":"https://api.github.com/repos/kinow/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/kinow/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/kinow/cylc/tags","blobs_url":"https://api.github.com/repos/kinow/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinow/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinow/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinow/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinow/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/kinow/cylc/languages","stargazers_url":"https://api.github.com/repos/kinow/cylc/stargazers","contributors_url":"https://api.github.com/repos/kinow/cylc/contributors","subscribers_url":"https://api.github.com/repos/kinow/cylc/subscribers","subscription_url":"https://api.github.com/repos/kinow/cylc/subscription","commits_url":"https://api.github.com/repos/kinow/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinow/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinow/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinow/cylc/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinow/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/kinow/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinow/cylc/merges","archive_url":"https://api.github.com/repos/kinow/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinow/cylc/downloads","issues_url":"https://api.github.com/repos/kinow/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/kinow/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/kinow/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/kinow/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinow/cylc/labels{/name}","releases_url":"https://api.github.com/repos/kinow/cylc/releases{/id}","deployments_url":"https://api.github.com/repos/kinow/cylc/deployments","created_at":"2016-02-15T10:51:15Z","updated_at":"2019-02-10T10:01:46Z","pushed_at":"2019-03-12T01:41:14Z","git_url":"git://github.com/kinow/cylc.git","ssh_url":"git@github.com:kinow/cylc.git","clone_url":"https://github.com/kinow/cylc.git","svn_url":"https://github.com/kinow/cylc","homepage":"http://cylc.github.com/cylc","size":135055,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cylc:master","ref":"master","sha":"f5dbc9653353438129c3769ae1d421fde0e85c0f","user":{"login":"cylc","id":824878,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDg3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/824878?v=4","gravatar_id":"","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"repo":{"id":1836229,"node_id":"MDEwOlJlcG9zaXRvcnkxODM2MjI5","name":"cylc","full_name":"cylc/cylc","private":false,"owner":{"login":"cylc","id":824878,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDg3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/824878?v=4","gravatar_id":"","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cylc/cylc","description":"Cylc: a workflow engine for cycling systems.","fork":false,"url":"https://api.github.com/repos/cylc/cylc","forks_url":"https://api.github.com/repos/cylc/cylc/forks","keys_url":"https://api.github.com/repos/cylc/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cylc/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cylc/cylc/teams","hooks_url":"https://api.github.com/repos/cylc/cylc/hooks","issue_events_url":"https://api.github.com/repos/cylc/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/cylc/cylc/events","assignees_url":"https://api.github.com/repos/cylc/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/cylc/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/cylc/cylc/tags","blobs_url":"https://api.github.com/repos/cylc/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cylc/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cylc/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cylc/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/cylc/cylc/languages","stargazers_url":"https://api.github.com/repos/cylc/cylc/stargazers","contributors_url":"https://api.github.com/repos/cylc/cylc/contributors","subscribers_url":"https://api.github.com/repos/cylc/cylc/subscribers","subscription_url":"https://api.github.com/repos/cylc/cylc/subscription","commits_url":"https://api.github.com/repos/cylc/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cylc/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cylc/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cylc/cylc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cylc/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/cylc/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cylc/cylc/merges","archive_url":"https://api.github.com/repos/cylc/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cylc/cylc/downloads","issues_url":"https://api.github.com/repos/cylc/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/cylc/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/cylc/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/cylc/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cylc/cylc/labels{/name}","releases_url":"https://api.github.com/repos/cylc/cylc/releases{/id}","deployments_url":"https://api.github.com/repos/cylc/cylc/deployments","created_at":"2011-06-02T08:31:49Z","updated_at":"2019-03-12T02:55:59Z","pushed_at":"2019-03-12T09:27:19Z","git_url":"git://github.com/cylc/cylc.git","ssh_url":"git@github.com:cylc/cylc.git","clone_url":"https://github.com/cylc/cylc.git","svn_url":"https://github.com/cylc/cylc","homepage":"https://cylc.github.io","size":111045,"stargazers_count":86,"watchers_count":86,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":174,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":59,"open_issues":174,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/2990"},"html":{"href":"https://github.com/cylc/cylc/pull/2990"},"issue":{"href":"https://api.github.com/repos/cylc/cylc/issues/2990"},"comments":{"href":"https://api.github.com/repos/cylc/cylc/issues/2990/comments"},"review_comments":{"href":"https://api.github.com/repos/cylc/cylc/pulls/2990/comments"},"review_comment":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cylc/cylc/pulls/2990/commits"},"statuses":{"href":"https://api.github.com/repos/cylc/cylc/statuses/6ca3263d71017020a8ca88aa1f85a78393fe2abf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kinow"}}