{"action":"closed","number":937,"pull_request":{"url":"https://api.github.com/repos/guardian/facia-tool/pulls/937","id":308167165,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4MTY3MTY1","html_url":"https://github.com/guardian/facia-tool/pull/937","diff_url":"https://github.com/guardian/facia-tool/pull/937.diff","patch_url":"https://github.com/guardian/facia-tool/pull/937.patch","issue_url":"https://api.github.com/repos/guardian/facia-tool/issues/937","number":937,"state":"closed","locked":false,"title":"Remove the non-inline form","user":{"login":"jonathonherbert","id":7767575,"node_id":"MDQ6VXNlcjc3Njc1NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/7767575?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathonherbert","html_url":"https://github.com/jonathonherbert","followers_url":"https://api.github.com/users/jonathonherbert/followers","following_url":"https://api.github.com/users/jonathonherbert/following{/other_user}","gists_url":"https://api.github.com/users/jonathonherbert/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathonherbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathonherbert/subscriptions","organizations_url":"https://api.github.com/users/jonathonherbert/orgs","repos_url":"https://api.github.com/users/jonathonherbert/repos","events_url":"https://api.github.com/users/jonathonherbert/events{/privacy}","received_events_url":"https://api.github.com/users/jonathonherbert/received_events","type":"User","site_admin":false},"body":"## What's changed?\r\n\r\nThis PR gets rid of the non-inline form. All forms are now inline, and the relevant feature switch will no longer appear in user settings.\r\n\r\n_small sound of confetti being thrown_\r\n\r\nNB: probably best to merge #938 first, otherwise the relevant feature switch will still be visible to users.\r\n\r\n## Checklist\r\n\r\n### General\r\n- [ ] 🤖 Relevant tests added\r\n- [x] ✅ CI checks / tests run locally\r\n- [ ] 🔍 Checked on CODE\r\n\r\n### Client\r\n- [x] 🚫 No obvious console errors on the client (i.e. React dev mode errors)\r\n- [x] 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)\r\n- [ ] 📷 Screenshots / GIFs of relevant UI changes included\r\n","created_at":"2019-08-16T18:04:33Z","updated_at":"2019-08-19T10:28:19Z","closed_at":"2019-08-19T10:28:18Z","merged_at":"2019-08-19T10:28:18Z","merge_commit_sha":"be0e1a4b1dead5012a144110e4acbcdcb7ff93f4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ajwl","id":10324129,"node_id":"MDQ6VXNlcjEwMzI0MTI5","avatar_url":"https://avatars2.githubusercontent.com/u/10324129?v=4","gravatar_id":"","url":"https://api.github.com/users/ajwl","html_url":"https://github.com/ajwl","followers_url":"https://api.github.com/users/ajwl/followers","following_url":"https://api.github.com/users/ajwl/following{/other_user}","gists_url":"https://api.github.com/users/ajwl/gists{/gist_id}","starred_url":"https://api.github.com/users/ajwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajwl/subscriptions","organizations_url":"https://api.github.com/users/ajwl/orgs","repos_url":"https://api.github.com/users/ajwl/repos","events_url":"https://api.github.com/users/ajwl/events{/privacy}","received_events_url":"https://api.github.com/users/ajwl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/facia-tool/pulls/937/commits","review_comments_url":"https://api.github.com/repos/guardian/facia-tool/pulls/937/comments","review_comment_url":"https://api.github.com/repos/guardian/facia-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/facia-tool/issues/937/comments","statuses_url":"https://api.github.com/repos/guardian/facia-tool/statuses/715ea67696640a1523466529d3875274160b0134","head":{"label":"guardian:jsh/remove-non-inline","ref":"jsh/remove-non-inline","sha":"715ea67696640a1523466529d3875274160b0134","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":40353770,"node_id":"MDEwOlJlcG9zaXRvcnk0MDM1Mzc3MA==","name":"facia-tool","full_name":"guardian/facia-tool","private":false,"owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardian/facia-tool","description":"Guardian front pages editor","fork":false,"url":"https://api.github.com/repos/guardian/facia-tool","forks_url":"https://api.github.com/repos/guardian/facia-tool/forks","keys_url":"https://api.github.com/repos/guardian/facia-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/facia-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/facia-tool/teams","hooks_url":"https://api.github.com/repos/guardian/facia-tool/hooks","issue_events_url":"https://api.github.com/repos/guardian/facia-tool/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/facia-tool/events","assignees_url":"https://api.github.com/repos/guardian/facia-tool/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/facia-tool/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/facia-tool/tags","blobs_url":"https://api.github.com/repos/guardian/facia-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/facia-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/facia-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/facia-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/facia-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/facia-tool/languages","stargazers_url":"https://api.github.com/repos/guardian/facia-tool/stargazers","contributors_url":"https://api.github.com/repos/guardian/facia-tool/contributors","subscribers_url":"https://api.github.com/repos/guardian/facia-tool/subscribers","subscription_url":"https://api.github.com/repos/guardian/facia-tool/subscription","commits_url":"https://api.github.com/repos/guardian/facia-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/facia-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/facia-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/facia-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/facia-tool/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/facia-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/facia-tool/merges","archive_url":"https://api.github.com/repos/guardian/facia-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/facia-tool/downloads","issues_url":"https://api.github.com/repos/guardian/facia-tool/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/facia-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/facia-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/facia-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/facia-tool/labels{/name}","releases_url":"https://api.github.com/repos/guardian/facia-tool/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/facia-tool/deployments","created_at":"2015-08-07T09:54:57Z","updated_at":"2019-08-19T10:16:02Z","pushed_at":"2019-08-19T10:28:18Z","git_url":"git://github.com/guardian/facia-tool.git","ssh_url":"git@github.com:guardian/facia-tool.git","clone_url":"https://github.com/guardian/facia-tool.git","svn_url":"https://github.com/guardian/facia-tool","homepage":null,"size":355210,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":7,"watchers":16,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"25dd0dfe157b4f25e07b6bec05e5ecfbca9608f0","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":40353770,"node_id":"MDEwOlJlcG9zaXRvcnk0MDM1Mzc3MA==","name":"facia-tool","full_name":"guardian/facia-tool","private":false,"owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardian/facia-tool","description":"Guardian front pages editor","fork":false,"url":"https://api.github.com/repos/guardian/facia-tool","forks_url":"https://api.github.com/repos/guardian/facia-tool/forks","keys_url":"https://api.github.com/repos/guardian/facia-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/facia-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/facia-tool/teams","hooks_url":"https://api.github.com/repos/guardian/facia-tool/hooks","issue_events_url":"https://api.github.com/repos/guardian/facia-tool/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/facia-tool/events","assignees_url":"https://api.github.com/repos/guardian/facia-tool/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/facia-tool/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/facia-tool/tags","blobs_url":"https://api.github.com/repos/guardian/facia-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/facia-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/facia-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/facia-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/facia-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/facia-tool/languages","stargazers_url":"https://api.github.com/repos/guardian/facia-tool/stargazers","contributors_url":"https://api.github.com/repos/guardian/facia-tool/contributors","subscribers_url":"https://api.github.com/repos/guardian/facia-tool/subscribers","subscription_url":"https://api.github.com/repos/guardian/facia-tool/subscription","commits_url":"https://api.github.com/repos/guardian/facia-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/facia-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/facia-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/facia-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/facia-tool/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/facia-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/facia-tool/merges","archive_url":"https://api.github.com/repos/guardian/facia-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/facia-tool/downloads","issues_url":"https://api.github.com/repos/guardian/facia-tool/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/facia-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/facia-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/facia-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/facia-tool/labels{/name}","releases_url":"https://api.github.com/repos/guardian/facia-tool/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/facia-tool/deployments","created_at":"2015-08-07T09:54:57Z","updated_at":"2019-08-19T10:16:02Z","pushed_at":"2019-08-19T10:28:18Z","git_url":"git://github.com/guardian/facia-tool.git","ssh_url":"git@github.com:guardian/facia-tool.git","clone_url":"https://github.com/guardian/facia-tool.git","svn_url":"https://github.com/guardian/facia-tool","homepage":null,"size":355210,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":7,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/937"},"html":{"href":"https://github.com/guardian/facia-tool/pull/937"},"issue":{"href":"https://api.github.com/repos/guardian/facia-tool/issues/937"},"comments":{"href":"https://api.github.com/repos/guardian/facia-tool/issues/937/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/937/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/937/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/facia-tool/statuses/715ea67696640a1523466529d3875274160b0134"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jonathonherbert","id":7767575,"node_id":"MDQ6VXNlcjc3Njc1NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/7767575?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathonherbert","html_url":"https://github.com/jonathonherbert","followers_url":"https://api.github.com/users/jonathonherbert/followers","following_url":"https://api.github.com/users/jonathonherbert/following{/other_user}","gists_url":"https://api.github.com/users/jonathonherbert/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathonherbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathonherbert/subscriptions","organizations_url":"https://api.github.com/users/jonathonherbert/orgs","repos_url":"https://api.github.com/users/jonathonherbert/repos","events_url":"https://api.github.com/users/jonathonherbert/events{/privacy}","received_events_url":"https://api.github.com/users/jonathonherbert/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":36,"deletions":876,"changed_files":12}}
{"actor":{"display_login":"jonathonherbert"}}