{"action":"created","comment":{"url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/comments/280317792","pull_request_review_id":232877753,"id":280317792,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDMxNzc5Mg==","diff_hunk":"@@ -12,65 +12,84 @@ source /usr/share/yunohost/helpers\n #=================================================\n # LOAD SETTINGS\n #=================================================\n+ynh_script_progression --message=\"Loading installation settings...\" --weight=2\n \n app=$YNH_APP_INSTANCE_NAME\n \n-domain=$(ynh_app_setting_get $app domain)\n-path_url=$(ynh_app_setting_get $app path)\n-port=$(ynh_app_setting_get $app port)\n-peer_port=$(ynh_app_setting_get $app peer_port)\n+domain=$(ynh_app_setting_get --app=$app --key=domain)\n+path_url=$(ynh_app_setting_get --app=$app --key=path)\n+port=$(ynh_app_setting_get --app=$app --key=port)\n+peer_port=$(ynh_app_setting_get --app=$app --key=peer_port)\n \n #=================================================\n-# FIX OLD THINGS\n+# CHECK VERSION\n #=================================================\n \n-if [ -z $port ]; then\n+upgrade_type=$(ynh_check_app_version_changed)\n+\n+#=================================================\n+# ENSURE DOWNWARD COMPATIBILITY\n+#=================================================\n+ynh_script_progression --message=\"Ensuring downward compatibility...\" --weight=4\n+\n+if [ -z \"$port\" ]; then\n \tport=9091","path":"scripts/upgrade","position":31,"original_position":31,"commit_id":"87161325171deb9a46992848b4e22e6b91ea2695","original_commit_id":"87161325171deb9a46992848b4e22e6b91ea2695","user":{"login":"kay0u","id":3713691,"node_id":"MDQ6VXNlcjM3MTM2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/3713691?v=4","gravatar_id":"","url":"https://api.github.com/users/kay0u","html_url":"https://github.com/kay0u","followers_url":"https://api.github.com/users/kay0u/followers","following_url":"https://api.github.com/users/kay0u/following{/other_user}","gists_url":"https://api.github.com/users/kay0u/gists{/gist_id}","starred_url":"https://api.github.com/users/kay0u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kay0u/subscriptions","organizations_url":"https://api.github.com/users/kay0u/orgs","repos_url":"https://api.github.com/users/kay0u/repos","events_url":"https://api.github.com/users/kay0u/events{/privacy}","received_events_url":"https://api.github.com/users/kay0u/received_events","type":"User","site_admin":false},"body":"I know you just normalize scripts, but this line can be a problem if this port is already used.\r\n\r\nTo replace with `port=$(ynh_find_port --port=9091)`\r\n\r\nDo you want I create a new PR for that or it's a small change and we can commit in this one?","created_at":"2019-05-02T07:56:22Z","updated_at":"2019-05-02T07:57:26Z","html_url":"https://github.com/YunoHost-Apps/transmission_ynh/pull/56#discussion_r280317792","pull_request_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/56","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/comments/280317792"},"html":{"href":"https://github.com/YunoHost-Apps/transmission_ynh/pull/56#discussion_r280317792"},"pull_request":{"href":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/56","id":275010076,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1MDEwMDc2","html_url":"https://github.com/YunoHost-Apps/transmission_ynh/pull/56","diff_url":"https://github.com/YunoHost-Apps/transmission_ynh/pull/56.diff","patch_url":"https://github.com/YunoHost-Apps/transmission_ynh/pull/56.patch","issue_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/issues/56","number":56,"state":"open","locked":false,"title":"Package upgrade","user":{"login":"maniackcrudelis","id":8302225,"node_id":"MDQ6VXNlcjgzMDIyMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/8302225?v=4","gravatar_id":"","url":"https://api.github.com/users/maniackcrudelis","html_url":"https://github.com/maniackcrudelis","followers_url":"https://api.github.com/users/maniackcrudelis/followers","following_url":"https://api.github.com/users/maniackcrudelis/following{/other_user}","gists_url":"https://api.github.com/users/maniackcrudelis/gists{/gist_id}","starred_url":"https://api.github.com/users/maniackcrudelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniackcrudelis/subscriptions","organizations_url":"https://api.github.com/users/maniackcrudelis/orgs","repos_url":"https://api.github.com/users/maniackcrudelis/repos","events_url":"https://api.github.com/users/maniackcrudelis/events{/privacy}","received_events_url":"https://api.github.com/users/maniackcrudelis/received_events","type":"User","site_admin":false},"body":"## Problem\r\n- *Global upgrade of the package.*\r\n\r\n## PR Status\r\n- [x] Code finished.\r\n- [x] Tested with Package_check.\r\n- [x] Fix or enhancement tested.\r\n- [x] Upgrade from last version tested.\r\n- [x] Can be reviewed and tested.\r\n\r\n## Validation\r\n---\r\n*Minor decision*\r\n- **Upgrade previous version** : \r\n- [ ] **Code review** : \r\n- [ ] **Approval (LGTM)** : \r\n- [ ] **Approval (LGTM)** : \r\n- **CI succeeded** : \r\n[![Build Status](https://ci-apps-hq.yunohost.org/jenkins/job/transmission_ynh%20PR56/badge/icon)](https://ci-apps-hq.yunohost.org/jenkins/job/transmission_ynh%20PR56/)  \r\n\r\nWhen the PR is marked as ready to merge, you have to wait for 3 days before really merging it.","created_at":"2019-05-01T11:36:36Z","updated_at":"2019-05-02T07:57:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3de16dd69247c2346299fe8291cd6e559b0d5a00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/56/commits","review_comments_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/56/comments","review_comment_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/issues/56/comments","statuses_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/statuses/87161325171deb9a46992848b4e22e6b91ea2695","head":{"label":"YunoHost-Apps:package_upgrade","ref":"package_upgrade","sha":"87161325171deb9a46992848b4e22e6b91ea2695","user":{"login":"YunoHost-Apps","id":18501020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTAxMDIw","avatar_url":"https://avatars3.githubusercontent.com/u/18501020?v=4","gravatar_id":"","url":"https://api.github.com/users/YunoHost-Apps","html_url":"https://github.com/YunoHost-Apps","followers_url":"https://api.github.com/users/YunoHost-Apps/followers","following_url":"https://api.github.com/users/YunoHost-Apps/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost-Apps/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost-Apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost-Apps/subscriptions","organizations_url":"https://api.github.com/users/YunoHost-Apps/orgs","repos_url":"https://api.github.com/users/YunoHost-Apps/repos","events_url":"https://api.github.com/users/YunoHost-Apps/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost-Apps/received_events","type":"Organization","site_admin":false},"repo":{"id":13956172,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1NjE3Mg==","name":"transmission_ynh","full_name":"YunoHost-Apps/transmission_ynh","private":false,"owner":{"login":"YunoHost-Apps","id":18501020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTAxMDIw","avatar_url":"https://avatars3.githubusercontent.com/u/18501020?v=4","gravatar_id":"","url":"https://api.github.com/users/YunoHost-Apps","html_url":"https://github.com/YunoHost-Apps","followers_url":"https://api.github.com/users/YunoHost-Apps/followers","following_url":"https://api.github.com/users/YunoHost-Apps/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost-Apps/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost-Apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost-Apps/subscriptions","organizations_url":"https://api.github.com/users/YunoHost-Apps/orgs","repos_url":"https://api.github.com/users/YunoHost-Apps/repos","events_url":"https://api.github.com/users/YunoHost-Apps/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost-Apps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/YunoHost-Apps/transmission_ynh","description":"Transmission package for YunoHost","fork":false,"url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh","forks_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/forks","keys_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/teams","hooks_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/hooks","issue_events_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/issues/events{/number}","events_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/events","assignees_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/assignees{/user}","branches_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/branches{/branch}","tags_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/tags","blobs_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/git/refs{/sha}","trees_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/statuses/{sha}","languages_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/languages","stargazers_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/stargazers","contributors_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/contributors","subscribers_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/subscribers","subscription_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/subscription","commits_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/commits{/sha}","git_commits_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/git/commits{/sha}","comments_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/comments{/number}","issue_comment_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/issues/comments{/number}","contents_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/contents/{+path}","compare_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/merges","archive_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/downloads","issues_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/issues{/number}","pulls_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls{/number}","milestones_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/milestones{/number}","notifications_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/labels{/name}","releases_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/releases{/id}","deployments_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/deployments","created_at":"2013-10-29T13:12:53Z","updated_at":"2019-04-10T19:04:15Z","pushed_at":"2019-05-01T17:39:55Z","git_url":"git://github.com/YunoHost-Apps/transmission_ynh.git","ssh_url":"git@github.com:YunoHost-Apps/transmission_ynh.git","clone_url":"https://github.com/YunoHost-Apps/transmission_ynh.git","svn_url":"https://github.com/YunoHost-Apps/transmission_ynh","homepage":null,"size":104,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":16,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"YunoHost-Apps:testing","ref":"testing","sha":"cd9b5822d579668e44d9ab81ee7ffde67fda1e26","user":{"login":"YunoHost-Apps","id":18501020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTAxMDIw","avatar_url":"https://avatars3.githubusercontent.com/u/18501020?v=4","gravatar_id":"","url":"https://api.github.com/users/YunoHost-Apps","html_url":"https://github.com/YunoHost-Apps","followers_url":"https://api.github.com/users/YunoHost-Apps/followers","following_url":"https://api.github.com/users/YunoHost-Apps/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost-Apps/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost-Apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost-Apps/subscriptions","organizations_url":"https://api.github.com/users/YunoHost-Apps/orgs","repos_url":"https://api.github.com/users/YunoHost-Apps/repos","events_url":"https://api.github.com/users/YunoHost-Apps/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost-Apps/received_events","type":"Organization","site_admin":false},"repo":{"id":13956172,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1NjE3Mg==","name":"transmission_ynh","full_name":"YunoHost-Apps/transmission_ynh","private":false,"owner":{"login":"YunoHost-Apps","id":18501020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTAxMDIw","avatar_url":"https://avatars3.githubusercontent.com/u/18501020?v=4","gravatar_id":"","url":"https://api.github.com/users/YunoHost-Apps","html_url":"https://github.com/YunoHost-Apps","followers_url":"https://api.github.com/users/YunoHost-Apps/followers","following_url":"https://api.github.com/users/YunoHost-Apps/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost-Apps/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost-Apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost-Apps/subscriptions","organizations_url":"https://api.github.com/users/YunoHost-Apps/orgs","repos_url":"https://api.github.com/users/YunoHost-Apps/repos","events_url":"https://api.github.com/users/YunoHost-Apps/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost-Apps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/YunoHost-Apps/transmission_ynh","description":"Transmission package for YunoHost","fork":false,"url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh","forks_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/forks","keys_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/teams","hooks_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/hooks","issue_events_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/issues/events{/number}","events_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/events","assignees_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/assignees{/user}","branches_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/branches{/branch}","tags_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/tags","blobs_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/git/refs{/sha}","trees_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/statuses/{sha}","languages_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/languages","stargazers_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/stargazers","contributors_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/contributors","subscribers_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/subscribers","subscription_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/subscription","commits_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/commits{/sha}","git_commits_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/git/commits{/sha}","comments_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/comments{/number}","issue_comment_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/issues/comments{/number}","contents_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/contents/{+path}","compare_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/merges","archive_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/downloads","issues_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/issues{/number}","pulls_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls{/number}","milestones_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/milestones{/number}","notifications_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/labels{/name}","releases_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/releases{/id}","deployments_url":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/deployments","created_at":"2013-10-29T13:12:53Z","updated_at":"2019-04-10T19:04:15Z","pushed_at":"2019-05-01T17:39:55Z","git_url":"git://github.com/YunoHost-Apps/transmission_ynh.git","ssh_url":"git@github.com:YunoHost-Apps/transmission_ynh.git","clone_url":"https://github.com/YunoHost-Apps/transmission_ynh.git","svn_url":"https://github.com/YunoHost-Apps/transmission_ynh","homepage":null,"size":104,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":16,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/56"},"html":{"href":"https://github.com/YunoHost-Apps/transmission_ynh/pull/56"},"issue":{"href":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/issues/56"},"comments":{"href":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/YunoHost-Apps/transmission_ynh/statuses/87161325171deb9a46992848b4e22e6b91ea2695"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kay0u"}}