{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/9240","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/9240/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/9240/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/9240/events","html_url":"https://github.com/status-im/status-react/pull/9240","id":509373016,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5OTcwNDk4","number":9240,"title":"Fixes #9238 - WIP","user":{"login":"acolytec3","id":17355484,"node_id":"MDQ6VXNlcjE3MzU1NDg0","avatar_url":"https://avatars2.githubusercontent.com/u/17355484?v=4","gravatar_id":"","url":"https://api.github.com/users/acolytec3","html_url":"https://github.com/acolytec3","followers_url":"https://api.github.com/users/acolytec3/followers","following_url":"https://api.github.com/users/acolytec3/following{/other_user}","gists_url":"https://api.github.com/users/acolytec3/gists{/gist_id}","starred_url":"https://api.github.com/users/acolytec3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acolytec3/subscriptions","organizations_url":"https://api.github.com/users/acolytec3/orgs","repos_url":"https://api.github.com/users/acolytec3/repos","events_url":"https://api.github.com/users/acolytec3/events{/privacy}","received_events_url":"https://api.github.com/users/acolytec3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-10-19T01:37:23Z","updated_at":"2019-10-19T13:18:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/9240","html_url":"https://github.com/status-im/status-react/pull/9240","diff_url":"https://github.com/status-im/status-react/pull/9240.diff","patch_url":"https://github.com/status-im/status-react/pull/9240.patch"},"body":"### Summary\r\n\r\nEIP681 URI parsing does not currently support ENS name verification.  This PR enables the `parse-uri` function to accept properly formatted ENS names as the to address in a URI\r\n\r\nThis fixes #9238 \r\n\r\n### Review notes\r\nIf you scan a QR code with an ENS address in the send-transaction, it will currently throw an unhandled error because the UI function that populates the to field is expecting an ethereum address and not an ENS address.  \r\n\r\n### Testing notes\r\nAn incorrectly structured ENS address (screenshot shows an example with sendme.ether is correctly identified as an invalid adddress).\r\n![Screenshot_20191018-213024](https://user-images.githubusercontent.com/17355484/67136024-a2f53480-f1ee-11e9-9798-4c9bc5cace82.jpg)\r\n\r\n#### Platforms\r\n\r\n- Android\r\n- iOS\r\n\r\n#### Areas that maybe impacted\r\nWallet/Send-Transaction/QR-Code\r\n\r\n##### Functional\r\n\r\n- wallet / transactions\r\n\r\n##### Non-functional\r\n\r\nN/A\r\n\r\n### Steps to test\r\n\r\n- Open Status\r\n- Open Wallet\r\n- Select any account\r\n- Select Send\r\n- Select specify-recipient\r\n- Select 'Scan QR code'\r\n- Scan a QR code with an EIP681 URI containing an ENS address\r\n\r\nstatus: WIP\r\n"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/544142996","html_url":"https://github.com/status-im/status-react/pull/9240#issuecomment-544142996","issue_url":"https://api.github.com/repos/status-im/status-react/issues/9240","id":544142996,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NDE0Mjk5Ng==","user":{"login":"3esmit","id":224810,"node_id":"MDQ6VXNlcjIyNDgxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/224810?v=4","gravatar_id":"","url":"https://api.github.com/users/3esmit","html_url":"https://github.com/3esmit","followers_url":"https://api.github.com/users/3esmit/followers","following_url":"https://api.github.com/users/3esmit/following{/other_user}","gists_url":"https://api.github.com/users/3esmit/gists{/gist_id}","starred_url":"https://api.github.com/users/3esmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3esmit/subscriptions","organizations_url":"https://api.github.com/users/3esmit/orgs","repos_url":"https://api.github.com/users/3esmit/repos","events_url":"https://api.github.com/users/3esmit/events{/privacy}","received_events_url":"https://api.github.com/users/3esmit/received_events","type":"User","site_admin":false},"created_at":"2019-10-19T13:18:22Z","updated_at":"2019-10-19T13:18:22Z","author_association":"MEMBER","body":"Thanks for this. This is one step closer to full EIP681 support :)\r\nRegarding the Name Resolution on the UI, I think that it should be another issue/PR because this would be relative to only allowing the ENS names to be used in EIP681.\r\n\r\nIf the UI is not resolving ENS Names in any `address` field, then we should investigate that separately. "}}
{"actor":{"display_login":"3esmit"}}