{"action":"created","issue":{"url":"https://api.github.com/repos/getgauge/taiko/issues/384","repository_url":"https://api.github.com/repos/getgauge/taiko","labels_url":"https://api.github.com/repos/getgauge/taiko/issues/384/labels{/name}","comments_url":"https://api.github.com/repos/getgauge/taiko/issues/384/comments","events_url":"https://api.github.com/repos/getgauge/taiko/issues/384/events","html_url":"https://github.com/getgauge/taiko/pull/384","id":406180271,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5OTM3NDI5","number":384,"title":"329 set local storage","user":{"login":"jaydeepc","id":276322,"node_id":"MDQ6VXNlcjI3NjMyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/276322?v=4","gravatar_id":"","url":"https://api.github.com/users/jaydeepc","html_url":"https://github.com/jaydeepc","followers_url":"https://api.github.com/users/jaydeepc/followers","following_url":"https://api.github.com/users/jaydeepc/following{/other_user}","gists_url":"https://api.github.com/users/jaydeepc/gists{/gist_id}","starred_url":"https://api.github.com/users/jaydeepc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaydeepc/subscriptions","organizations_url":"https://api.github.com/users/jaydeepc/orgs","repos_url":"https://api.github.com/users/jaydeepc/repos","events_url":"https://api.github.com/users/jaydeepc/events{/privacy}","received_events_url":"https://api.github.com/users/jaydeepc/received_events","type":"User","site_admin":false},"labels":[{"id":992773005,"node_id":"MDU6TGFiZWw5OTI3NzMwMDU=","url":"https://api.github.com/repos/getgauge/taiko/labels/cla-signed","name":"cla-signed","color":"ededed","default":false},{"id":735099579,"node_id":"MDU6TGFiZWw3MzUwOTk1Nzk=","url":"https://api.github.com/repos/getgauge/taiko/labels/ready","name":"ready","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-02-04T04:46:11Z","updated_at":"2019-02-04T06:32:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/getgauge/taiko/pulls/384","html_url":"https://github.com/getgauge/taiko/pull/384","diff_url":"https://github.com/getgauge/taiko/pull/384.diff","patch_url":"https://github.com/getgauge/taiko/pull/384.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/getgauge/taiko/issues/comments/460144132","html_url":"https://github.com/getgauge/taiko/pull/384#issuecomment-460144132","issue_url":"https://api.github.com/repos/getgauge/taiko/issues/384","id":460144132,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MDE0NDEzMg==","user":{"login":"NivedhaSenthil","id":6358540,"node_id":"MDQ6VXNlcjYzNTg1NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6358540?v=4","gravatar_id":"","url":"https://api.github.com/users/NivedhaSenthil","html_url":"https://github.com/NivedhaSenthil","followers_url":"https://api.github.com/users/NivedhaSenthil/followers","following_url":"https://api.github.com/users/NivedhaSenthil/following{/other_user}","gists_url":"https://api.github.com/users/NivedhaSenthil/gists{/gist_id}","starred_url":"https://api.github.com/users/NivedhaSenthil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NivedhaSenthil/subscriptions","organizations_url":"https://api.github.com/users/NivedhaSenthil/orgs","repos_url":"https://api.github.com/users/NivedhaSenthil/repos","events_url":"https://api.github.com/users/NivedhaSenthil/events{/privacy}","received_events_url":"https://api.github.com/users/NivedhaSenthil/received_events","type":"User","site_admin":false},"created_at":"2019-02-04T06:32:10Z","updated_at":"2019-02-04T06:32:10Z","author_association":"MEMBER","body":"Any scripts to be evaluated can be added via `evaluate` api or by accessing CRI apis directly currently.\r\nwith `addToLocalStorage` user will expect values given to be added to localStorage in current context which will not happen with the current implementation, it will get added only when there is a new document load and it will try to add for all new document load  so user will have to add it even before `goto` call which may not be what user will expect from `addToLocalStorage`.\r\n\r\nWe need to give a broader thought for security, currently chromium should be handling major security\r\nconcerns like CORS etc and script is run in sandboxed environment  off-process from chromium restricting access to other processes unless user disables it manually. "}}
{"actor":{"display_login":"NivedhaSenthil"}}