{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/25702","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/25702/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/25702/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/25702/events","html_url":"https://github.com/mantidproject/mantid/pull/25702","id":443258425,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4MTYzMzA2","number":25702,"title":"Now opens plot type choice dialog on workspace double click","user":{"login":"DTasev","id":9135965,"node_id":"MDQ6VXNlcjkxMzU5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/9135965?v=4","gravatar_id":"","url":"https://api.github.com/users/DTasev","html_url":"https://github.com/DTasev","followers_url":"https://api.github.com/users/DTasev/followers","following_url":"https://api.github.com/users/DTasev/following{/other_user}","gists_url":"https://api.github.com/users/DTasev/gists{/gist_id}","starred_url":"https://api.github.com/users/DTasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DTasev/subscriptions","organizations_url":"https://api.github.com/users/DTasev/orgs","repos_url":"https://api.github.com/users/DTasev/repos","events_url":"https://api.github.com/users/DTasev/events{/privacy}","received_events_url":"https://api.github.com/users/DTasev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/70","html_url":"https://github.com/mantidproject/mantid/milestone/70","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/70/labels","id":3410850,"node_id":"MDk6TWlsZXN0b25lMzQxMDg1MA==","number":70,"title":"Release 4.1","description":"Code freeze: 28 Jun\r\nBeta Test: 3-16 Jun","creator":{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":252,"closed_issues":464,"state":"open","created_at":"2018-06-08T12:45:56Z","updated_at":"2019-06-10T12:57:44Z","due_on":"2019-07-22T07:00:00Z","closed_at":null},"comments":1,"created_at":"2019-05-13T08:02:33Z","updated_at":"2019-06-10T14:03:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/25702","html_url":"https://github.com/mantidproject/mantid/pull/25702","diff_url":"https://github.com/mantidproject/mantid/pull/25702.diff","patch_url":"https://github.com/mantidproject/mantid/pull/25702.patch"},"body":"**Description of work.**\r\n- Double clicking workspace now shows Spectrum/Colorfill option\r\n- Add test_spectraselectiondialog, and test_plottypedialog.\r\n\r\n**To test:**\r\nLoad a workspace:\r\n- With 1 spectra\r\n- With >1 spectra\r\n\r\nDouble click, the following should happen:\r\n- On workspace with 1 spectra: open the same window as `Plot > Spectrum`\r\n- On workspace with >1 spectra: open a choice dialog (Spectra/Colorfill)\r\n  - Selecting `Spectra` opens the default spectra selection dialog\r\n  - Selecting `Colorfill` opens a Colorfill plot \r\n\r\n**Helper code**\r\n```python\r\nws2d_1spec = CreateWorkspace(DataX=[10, 20, 30],\r\n                                         DataY=[2, 3],\r\n                                         DataE=[1, 2],\r\n                                         NSpec=1,\r\n                                         Distribution=True,\r\n                                         UnitX='Wavelength',\r\n                                         VerticalAxisUnit='DeltaE',\r\n                                         VerticalAxisValues=[4])\r\n\r\nws2d_histo = CreateWorkspace(DataX=[10, 20, 30, 10, 20, 30, 10, 20, 30],\r\n                                         DataY=[2, 3, 4, 5, 3, 5],\r\n                                         DataE=[1, 2, 3, 4, 1, 1],\r\n                                         NSpec=3,\r\n                                         Distribution=True,\r\n                                         UnitX='Wavelength',\r\n                                         VerticalAxisUnit='DeltaE',\r\n                                         VerticalAxisValues=[4, 6, 8])\r\n```\r\n\r\nFixes #25548\r\n\r\n\r\nTODO:\r\n- [ ] Release Notes\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://developer.mantidproject.org/IndividualTicketTesting/)):\r\n\r\n##### Code Review #####\r\n\r\n- Is the code of an acceptable quality?\r\n- Does the code conform to the [coding standards](http://developer.mantidproject.org/Standards/)?\r\n- Are the unit tests small and test the class in isolation?\r\n- If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- Do changes function as described? Add comments below that describe the tests performed?\r\n- Do the changes handle unexpected situations, e.g. bad input?\r\n- Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/500428179","html_url":"https://github.com/mantidproject/mantid/pull/25702#issuecomment-500428179","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/25702","id":500428179,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMDQyODE3OQ==","user":{"login":"mantid-builder","id":1493379,"node_id":"MDQ6VXNlcjE0OTMzNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1493379?v=4","gravatar_id":"","url":"https://api.github.com/users/mantid-builder","html_url":"https://github.com/mantid-builder","followers_url":"https://api.github.com/users/mantid-builder/followers","following_url":"https://api.github.com/users/mantid-builder/following{/other_user}","gists_url":"https://api.github.com/users/mantid-builder/gists{/gist_id}","starred_url":"https://api.github.com/users/mantid-builder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantid-builder/subscriptions","organizations_url":"https://api.github.com/users/mantid-builder/orgs","repos_url":"https://api.github.com/users/mantid-builder/repos","events_url":"https://api.github.com/users/mantid-builder/events{/privacy}","received_events_url":"https://api.github.com/users/mantid-builder/received_events","type":"User","site_admin":false},"created_at":"2019-06-10T14:03:14Z","updated_at":"2019-06-10T14:03:14Z","author_association":"CONTRIBUTOR","body":"@DTasev have you had a chance to see why the build is failing?\n<!-- {\"problem_type\": \"failing\"} -->"}}
{"actor":{"display_login":"mantid-builder"}}