{"action":"created","comment":{"url":"https://api.github.com/repos/marshmallow-code/apispec/pulls/comments/320008573","pull_request_review_id":282658414,"id":320008573,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDAwODU3Mw==","diff_hunk":"@@ -91,7 +93,7 @@ def init_spec(self, spec):\n         super().init_spec(spec)\n         self.spec = spec\n         self.openapi_version = spec.openapi_version\n-        self.openapi = OpenAPIConverter(\n+        self.openapi = self.Converter(","path":"src/apispec/ext/marshmallow/__init__.py","position":33,"original_position":14,"commit_id":"04841dbe1ab95f09cba6e1d32d9cb3a6490f575d","original_commit_id":"db83cb675d677f91839ac919534c6d0820aec9ca","user":{"login":"lafrech","id":1767010,"node_id":"MDQ6VXNlcjE3NjcwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1767010?v=4","gravatar_id":"","url":"https://api.github.com/users/lafrech","html_url":"https://github.com/lafrech","followers_url":"https://api.github.com/users/lafrech/followers","following_url":"https://api.github.com/users/lafrech/following{/other_user}","gists_url":"https://api.github.com/users/lafrech/gists{/gist_id}","starred_url":"https://api.github.com/users/lafrech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafrech/subscriptions","organizations_url":"https://api.github.com/users/lafrech/orgs","repos_url":"https://api.github.com/users/lafrech/repos","events_url":"https://api.github.com/users/lafrech/events{/privacy}","received_events_url":"https://api.github.com/users/lafrech/received_events","type":"User","site_admin":false},"body":"I picked it from your comment here: https://github.com/marshmallow-code/apispec/pull/488#issuecomment-526842419\r\n\r\nI figured capitalized could make sense since it is a class.\r\n\r\nOtherwise, you'd subclass it like this:\r\n\r\n```py\r\nclass MyMarshmallowPlugin(MarshmallowPlugin):\r\n    class converter(MarshmallowPlugin.converter):  # <-- lowercase\r\n        def property2parameter(self, ...):\r\n            ...\r\n```","created_at":"2019-09-02T15:59:57Z","updated_at":"2019-09-02T15:59:57Z","html_url":"https://github.com/marshmallow-code/apispec/pull/493#discussion_r320008573","pull_request_url":"https://api.github.com/repos/marshmallow-code/apispec/pulls/493","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/marshmallow-code/apispec/pulls/comments/320008573"},"html":{"href":"https://github.com/marshmallow-code/apispec/pull/493#discussion_r320008573"},"pull_request":{"href":"https://api.github.com/repos/marshmallow-code/apispec/pulls/493"}},"in_reply_to_id":320006783},"pull_request":{"url":"https://api.github.com/repos/marshmallow-code/apispec/pulls/493","id":313311429,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEzMzExNDI5","html_url":"https://github.com/marshmallow-code/apispec/pull/493","diff_url":"https://github.com/marshmallow-code/apispec/pull/493.diff","patch_url":"https://github.com/marshmallow-code/apispec/pull/493.patch","issue_url":"https://api.github.com/repos/marshmallow-code/apispec/issues/493","number":493,"state":"open","locked":false,"title":"Make OpenAPIConverter class a class member of MarshmallowPlugin","user":{"login":"lafrech","id":1767010,"node_id":"MDQ6VXNlcjE3NjcwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1767010?v=4","gravatar_id":"","url":"https://api.github.com/users/lafrech","html_url":"https://github.com/lafrech","followers_url":"https://api.github.com/users/lafrech/followers","following_url":"https://api.github.com/users/lafrech/following{/other_user}","gists_url":"https://api.github.com/users/lafrech/gists{/gist_id}","starred_url":"https://api.github.com/users/lafrech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lafrech/subscriptions","organizations_url":"https://api.github.com/users/lafrech/orgs","repos_url":"https://api.github.com/users/lafrech/repos","events_url":"https://api.github.com/users/lafrech/events{/privacy}","received_events_url":"https://api.github.com/users/lafrech/received_events","type":"User","site_admin":false},"body":"Discussed in https://github.com/marshmallow-code/apispec/pull/488.\r\n\r\n@sloria, I cherry-picked your docs revisions.\r\n\r\nopenapi and field_converter are private API, but I left their section in the docs when rebasing your doc revisions commit. In other words, this leaves the docs in the same state as on `dev` branch.","created_at":"2019-09-02T15:42:09Z","updated_at":"2019-09-02T15:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aba41c94ea0461d230f2413adbbc5bfaf3d7f7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/marshmallow-code/apispec/pulls/493/commits","review_comments_url":"https://api.github.com/repos/marshmallow-code/apispec/pulls/493/comments","review_comment_url":"https://api.github.com/repos/marshmallow-code/apispec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marshmallow-code/apispec/issues/493/comments","statuses_url":"https://api.github.com/repos/marshmallow-code/apispec/statuses/04841dbe1ab95f09cba6e1d32d9cb3a6490f575d","head":{"label":"marshmallow-code:openapi_class_member","ref":"openapi_class_member","sha":"04841dbe1ab95f09cba6e1d32d9cb3a6490f575d","user":{"login":"marshmallow-code","id":10334301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzM0MzAx","avatar_url":"https://avatars2.githubusercontent.com/u/10334301?v=4","gravatar_id":"","url":"https://api.github.com/users/marshmallow-code","html_url":"https://github.com/marshmallow-code","followers_url":"https://api.github.com/users/marshmallow-code/followers","following_url":"https://api.github.com/users/marshmallow-code/following{/other_user}","gists_url":"https://api.github.com/users/marshmallow-code/gists{/gist_id}","starred_url":"https://api.github.com/users/marshmallow-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshmallow-code/subscriptions","organizations_url":"https://api.github.com/users/marshmallow-code/orgs","repos_url":"https://api.github.com/users/marshmallow-code/repos","events_url":"https://api.github.com/users/marshmallow-code/events{/privacy}","received_events_url":"https://api.github.com/users/marshmallow-code/received_events","type":"Organization","site_admin":false},"repo":{"id":25413181,"node_id":"MDEwOlJlcG9zaXRvcnkyNTQxMzE4MQ==","name":"apispec","full_name":"marshmallow-code/apispec","private":false,"owner":{"login":"marshmallow-code","id":10334301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzM0MzAx","avatar_url":"https://avatars2.githubusercontent.com/u/10334301?v=4","gravatar_id":"","url":"https://api.github.com/users/marshmallow-code","html_url":"https://github.com/marshmallow-code","followers_url":"https://api.github.com/users/marshmallow-code/followers","following_url":"https://api.github.com/users/marshmallow-code/following{/other_user}","gists_url":"https://api.github.com/users/marshmallow-code/gists{/gist_id}","starred_url":"https://api.github.com/users/marshmallow-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshmallow-code/subscriptions","organizations_url":"https://api.github.com/users/marshmallow-code/orgs","repos_url":"https://api.github.com/users/marshmallow-code/repos","events_url":"https://api.github.com/users/marshmallow-code/events{/privacy}","received_events_url":"https://api.github.com/users/marshmallow-code/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/marshmallow-code/apispec","description":"A pluggable API specification generator. Currently supports the OpenAPI Specification (f.k.a. the Swagger specification)..","fork":false,"url":"https://api.github.com/repos/marshmallow-code/apispec","forks_url":"https://api.github.com/repos/marshmallow-code/apispec/forks","keys_url":"https://api.github.com/repos/marshmallow-code/apispec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marshmallow-code/apispec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marshmallow-code/apispec/teams","hooks_url":"https://api.github.com/repos/marshmallow-code/apispec/hooks","issue_events_url":"https://api.github.com/repos/marshmallow-code/apispec/issues/events{/number}","events_url":"https://api.github.com/repos/marshmallow-code/apispec/events","assignees_url":"https://api.github.com/repos/marshmallow-code/apispec/assignees{/user}","branches_url":"https://api.github.com/repos/marshmallow-code/apispec/branches{/branch}","tags_url":"https://api.github.com/repos/marshmallow-code/apispec/tags","blobs_url":"https://api.github.com/repos/marshmallow-code/apispec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marshmallow-code/apispec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marshmallow-code/apispec/git/refs{/sha}","trees_url":"https://api.github.com/repos/marshmallow-code/apispec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marshmallow-code/apispec/statuses/{sha}","languages_url":"https://api.github.com/repos/marshmallow-code/apispec/languages","stargazers_url":"https://api.github.com/repos/marshmallow-code/apispec/stargazers","contributors_url":"https://api.github.com/repos/marshmallow-code/apispec/contributors","subscribers_url":"https://api.github.com/repos/marshmallow-code/apispec/subscribers","subscription_url":"https://api.github.com/repos/marshmallow-code/apispec/subscription","commits_url":"https://api.github.com/repos/marshmallow-code/apispec/commits{/sha}","git_commits_url":"https://api.github.com/repos/marshmallow-code/apispec/git/commits{/sha}","comments_url":"https://api.github.com/repos/marshmallow-code/apispec/comments{/number}","issue_comment_url":"https://api.github.com/repos/marshmallow-code/apispec/issues/comments{/number}","contents_url":"https://api.github.com/repos/marshmallow-code/apispec/contents/{+path}","compare_url":"https://api.github.com/repos/marshmallow-code/apispec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marshmallow-code/apispec/merges","archive_url":"https://api.github.com/repos/marshmallow-code/apispec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marshmallow-code/apispec/downloads","issues_url":"https://api.github.com/repos/marshmallow-code/apispec/issues{/number}","pulls_url":"https://api.github.com/repos/marshmallow-code/apispec/pulls{/number}","milestones_url":"https://api.github.com/repos/marshmallow-code/apispec/milestones{/number}","notifications_url":"https://api.github.com/repos/marshmallow-code/apispec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marshmallow-code/apispec/labels{/name}","releases_url":"https://api.github.com/repos/marshmallow-code/apispec/releases{/id}","deployments_url":"https://api.github.com/repos/marshmallow-code/apispec/deployments","created_at":"2014-10-18T23:48:49Z","updated_at":"2019-09-02T14:46:59Z","pushed_at":"2019-09-02T15:42:10Z","git_url":"git://github.com/marshmallow-code/apispec.git","ssh_url":"git@github.com:marshmallow-code/apispec.git","clone_url":"https://github.com/marshmallow-code/apispec.git","svn_url":"https://github.com/marshmallow-code/apispec","homepage":"https://apispec.readthedocs.io/","size":1513,"stargazers_count":602,"watchers_count":602,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":99,"open_issues":21,"watchers":602,"default_branch":"dev"}},"base":{"label":"marshmallow-code:dev","ref":"dev","sha":"a6f706344428d0be634ccd022de0d0acde707a17","user":{"login":"marshmallow-code","id":10334301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzM0MzAx","avatar_url":"https://avatars2.githubusercontent.com/u/10334301?v=4","gravatar_id":"","url":"https://api.github.com/users/marshmallow-code","html_url":"https://github.com/marshmallow-code","followers_url":"https://api.github.com/users/marshmallow-code/followers","following_url":"https://api.github.com/users/marshmallow-code/following{/other_user}","gists_url":"https://api.github.com/users/marshmallow-code/gists{/gist_id}","starred_url":"https://api.github.com/users/marshmallow-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshmallow-code/subscriptions","organizations_url":"https://api.github.com/users/marshmallow-code/orgs","repos_url":"https://api.github.com/users/marshmallow-code/repos","events_url":"https://api.github.com/users/marshmallow-code/events{/privacy}","received_events_url":"https://api.github.com/users/marshmallow-code/received_events","type":"Organization","site_admin":false},"repo":{"id":25413181,"node_id":"MDEwOlJlcG9zaXRvcnkyNTQxMzE4MQ==","name":"apispec","full_name":"marshmallow-code/apispec","private":false,"owner":{"login":"marshmallow-code","id":10334301,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzM0MzAx","avatar_url":"https://avatars2.githubusercontent.com/u/10334301?v=4","gravatar_id":"","url":"https://api.github.com/users/marshmallow-code","html_url":"https://github.com/marshmallow-code","followers_url":"https://api.github.com/users/marshmallow-code/followers","following_url":"https://api.github.com/users/marshmallow-code/following{/other_user}","gists_url":"https://api.github.com/users/marshmallow-code/gists{/gist_id}","starred_url":"https://api.github.com/users/marshmallow-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshmallow-code/subscriptions","organizations_url":"https://api.github.com/users/marshmallow-code/orgs","repos_url":"https://api.github.com/users/marshmallow-code/repos","events_url":"https://api.github.com/users/marshmallow-code/events{/privacy}","received_events_url":"https://api.github.com/users/marshmallow-code/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/marshmallow-code/apispec","description":"A pluggable API specification generator. Currently supports the OpenAPI Specification (f.k.a. the Swagger specification)..","fork":false,"url":"https://api.github.com/repos/marshmallow-code/apispec","forks_url":"https://api.github.com/repos/marshmallow-code/apispec/forks","keys_url":"https://api.github.com/repos/marshmallow-code/apispec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marshmallow-code/apispec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marshmallow-code/apispec/teams","hooks_url":"https://api.github.com/repos/marshmallow-code/apispec/hooks","issue_events_url":"https://api.github.com/repos/marshmallow-code/apispec/issues/events{/number}","events_url":"https://api.github.com/repos/marshmallow-code/apispec/events","assignees_url":"https://api.github.com/repos/marshmallow-code/apispec/assignees{/user}","branches_url":"https://api.github.com/repos/marshmallow-code/apispec/branches{/branch}","tags_url":"https://api.github.com/repos/marshmallow-code/apispec/tags","blobs_url":"https://api.github.com/repos/marshmallow-code/apispec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marshmallow-code/apispec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marshmallow-code/apispec/git/refs{/sha}","trees_url":"https://api.github.com/repos/marshmallow-code/apispec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marshmallow-code/apispec/statuses/{sha}","languages_url":"https://api.github.com/repos/marshmallow-code/apispec/languages","stargazers_url":"https://api.github.com/repos/marshmallow-code/apispec/stargazers","contributors_url":"https://api.github.com/repos/marshmallow-code/apispec/contributors","subscribers_url":"https://api.github.com/repos/marshmallow-code/apispec/subscribers","subscription_url":"https://api.github.com/repos/marshmallow-code/apispec/subscription","commits_url":"https://api.github.com/repos/marshmallow-code/apispec/commits{/sha}","git_commits_url":"https://api.github.com/repos/marshmallow-code/apispec/git/commits{/sha}","comments_url":"https://api.github.com/repos/marshmallow-code/apispec/comments{/number}","issue_comment_url":"https://api.github.com/repos/marshmallow-code/apispec/issues/comments{/number}","contents_url":"https://api.github.com/repos/marshmallow-code/apispec/contents/{+path}","compare_url":"https://api.github.com/repos/marshmallow-code/apispec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marshmallow-code/apispec/merges","archive_url":"https://api.github.com/repos/marshmallow-code/apispec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marshmallow-code/apispec/downloads","issues_url":"https://api.github.com/repos/marshmallow-code/apispec/issues{/number}","pulls_url":"https://api.github.com/repos/marshmallow-code/apispec/pulls{/number}","milestones_url":"https://api.github.com/repos/marshmallow-code/apispec/milestones{/number}","notifications_url":"https://api.github.com/repos/marshmallow-code/apispec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marshmallow-code/apispec/labels{/name}","releases_url":"https://api.github.com/repos/marshmallow-code/apispec/releases{/id}","deployments_url":"https://api.github.com/repos/marshmallow-code/apispec/deployments","created_at":"2014-10-18T23:48:49Z","updated_at":"2019-09-02T14:46:59Z","pushed_at":"2019-09-02T15:42:10Z","git_url":"git://github.com/marshmallow-code/apispec.git","ssh_url":"git@github.com:marshmallow-code/apispec.git","clone_url":"https://github.com/marshmallow-code/apispec.git","svn_url":"https://github.com/marshmallow-code/apispec","homepage":"https://apispec.readthedocs.io/","size":1513,"stargazers_count":602,"watchers_count":602,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":99,"open_issues":21,"watchers":602,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/marshmallow-code/apispec/pulls/493"},"html":{"href":"https://github.com/marshmallow-code/apispec/pull/493"},"issue":{"href":"https://api.github.com/repos/marshmallow-code/apispec/issues/493"},"comments":{"href":"https://api.github.com/repos/marshmallow-code/apispec/issues/493/comments"},"review_comments":{"href":"https://api.github.com/repos/marshmallow-code/apispec/pulls/493/comments"},"review_comment":{"href":"https://api.github.com/repos/marshmallow-code/apispec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marshmallow-code/apispec/pulls/493/commits"},"statuses":{"href":"https://api.github.com/repos/marshmallow-code/apispec/statuses/04841dbe1ab95f09cba6e1d32d9cb3a6490f575d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lafrech"}}