{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/comments/351267715","pull_request_review_id":323647371,"id":351267715,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MTI2NzcxNQ==","diff_hunk":"@@ -0,0 +1,8 @@\n+$OpenSans: \"Open Sans\", \"Arial\", sans-serif;\n+\n+$white: #ffffff;","path":"source/sass/variables.scss","position":3,"original_position":3,"commit_id":"495ab574040beade4832a2fbc77ff6f8ec2d2295","original_commit_id":"495ab574040beade4832a2fbc77ff6f8ec2d2295","user":{"login":"sealeye","id":13489907,"node_id":"MDQ6VXNlcjEzNDg5OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/13489907?v=4","gravatar_id":"","url":"https://api.github.com/users/sealeye","html_url":"https://github.com/sealeye","followers_url":"https://api.github.com/users/sealeye/followers","following_url":"https://api.github.com/users/sealeye/following{/other_user}","gists_url":"https://api.github.com/users/sealeye/gists{/gist_id}","starred_url":"https://api.github.com/users/sealeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sealeye/subscriptions","organizations_url":"https://api.github.com/users/sealeye/orgs","repos_url":"https://api.github.com/users/sealeye/repos","events_url":"https://api.github.com/users/sealeye/events{/privacy}","received_events_url":"https://api.github.com/users/sealeye/received_events","type":"User","site_admin":false},"body":"Цветовые переменные это очень здорово, но давай добавим смысла и модульности как и с переменной шрифта. \r\n\r\nВ переменные, которые действительно осмысленно используются несколько раз нужно присвоить эти переменные цвета:\r\n\r\n```\r\n$input-color: $gray--light;\r\n$input-color--focus: $gray;\r\n$input-color--active: $gray--dark;\r\n```\r\n\r\nПри этом переменные, которые близки по использованию, должны иметь одинаковое начало. Типа всё про инпуты начинается со слов` input-color`.\r\nЕсли цвет используется где-то в одном месте, то прямо в файле так и написать его:\r\n\r\n```\r\n.feature {\r\n    background-color: $gray--lighter;\r\n}\r\n```\r\n\r\nЭто поможет избавиться от неосмысляемых названий вроде `unimportant-color`. Ну или просто назвать переменную более осмысленно, например `feature-color` и `feature-color--small`.","created_at":"2019-11-27T12:48:01Z","updated_at":"2019-11-27T12:48:01Z","html_url":"https://github.com/htmlacademy-adaptive/245269-pink-18/pull/10#discussion_r351267715","pull_request_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/10","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/comments/351267715"},"html":{"href":"https://github.com/htmlacademy-adaptive/245269-pink-18/pull/10#discussion_r351267715"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/10","id":345927842,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1OTI3ODQy","html_url":"https://github.com/htmlacademy-adaptive/245269-pink-18/pull/10","diff_url":"https://github.com/htmlacademy-adaptive/245269-pink-18/pull/10.diff","patch_url":"https://github.com/htmlacademy-adaptive/245269-pink-18/pull/10.patch","issue_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/issues/10","number":10,"state":"open","locked":false,"title":"Начинаем вёрстку с препроцессором","user":{"login":"zharkowski","id":31830105,"node_id":"MDQ6VXNlcjMxODMwMTA1","avatar_url":"https://avatars1.githubusercontent.com/u/31830105?v=4","gravatar_id":"","url":"https://api.github.com/users/zharkowski","html_url":"https://github.com/zharkowski","followers_url":"https://api.github.com/users/zharkowski/followers","following_url":"https://api.github.com/users/zharkowski/following{/other_user}","gists_url":"https://api.github.com/users/zharkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/zharkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zharkowski/subscriptions","organizations_url":"https://api.github.com/users/zharkowski/orgs","repos_url":"https://api.github.com/users/zharkowski/repos","events_url":"https://api.github.com/users/zharkowski/events{/privacy}","received_events_url":"https://api.github.com/users/zharkowski/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Начинаем вёрстку с препроцессором](https://up.htmlacademy.ru/adaptive/18/user/245269/tasks/6)","created_at":"2019-11-26T20:45:19Z","updated_at":"2019-11-27T12:48:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c15903857e62d9560c0d7fb408ecc5a49cf37ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/10/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/10/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/issues/10/comments","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/statuses/495ab574040beade4832a2fbc77ff6f8ec2d2295","head":{"label":"zharkowski:module3-task1","ref":"module3-task1","sha":"495ab574040beade4832a2fbc77ff6f8ec2d2295","user":{"login":"zharkowski","id":31830105,"node_id":"MDQ6VXNlcjMxODMwMTA1","avatar_url":"https://avatars1.githubusercontent.com/u/31830105?v=4","gravatar_id":"","url":"https://api.github.com/users/zharkowski","html_url":"https://github.com/zharkowski","followers_url":"https://api.github.com/users/zharkowski/followers","following_url":"https://api.github.com/users/zharkowski/following{/other_user}","gists_url":"https://api.github.com/users/zharkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/zharkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zharkowski/subscriptions","organizations_url":"https://api.github.com/users/zharkowski/orgs","repos_url":"https://api.github.com/users/zharkowski/repos","events_url":"https://api.github.com/users/zharkowski/events{/privacy}","received_events_url":"https://api.github.com/users/zharkowski/received_events","type":"User","site_admin":false},"repo":{"id":221234159,"node_id":"MDEwOlJlcG9zaXRvcnkyMjEyMzQxNTk=","name":"245269-pink-18","full_name":"zharkowski/245269-pink-18","private":false,"owner":{"login":"zharkowski","id":31830105,"node_id":"MDQ6VXNlcjMxODMwMTA1","avatar_url":"https://avatars1.githubusercontent.com/u/31830105?v=4","gravatar_id":"","url":"https://api.github.com/users/zharkowski","html_url":"https://github.com/zharkowski","followers_url":"https://api.github.com/users/zharkowski/followers","following_url":"https://api.github.com/users/zharkowski/following{/other_user}","gists_url":"https://api.github.com/users/zharkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/zharkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zharkowski/subscriptions","organizations_url":"https://api.github.com/users/zharkowski/orgs","repos_url":"https://api.github.com/users/zharkowski/repos","events_url":"https://api.github.com/users/zharkowski/events{/privacy}","received_events_url":"https://api.github.com/users/zharkowski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zharkowski/245269-pink-18","description":"Максим Жарков","fork":true,"url":"https://api.github.com/repos/zharkowski/245269-pink-18","forks_url":"https://api.github.com/repos/zharkowski/245269-pink-18/forks","keys_url":"https://api.github.com/repos/zharkowski/245269-pink-18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zharkowski/245269-pink-18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zharkowski/245269-pink-18/teams","hooks_url":"https://api.github.com/repos/zharkowski/245269-pink-18/hooks","issue_events_url":"https://api.github.com/repos/zharkowski/245269-pink-18/issues/events{/number}","events_url":"https://api.github.com/repos/zharkowski/245269-pink-18/events","assignees_url":"https://api.github.com/repos/zharkowski/245269-pink-18/assignees{/user}","branches_url":"https://api.github.com/repos/zharkowski/245269-pink-18/branches{/branch}","tags_url":"https://api.github.com/repos/zharkowski/245269-pink-18/tags","blobs_url":"https://api.github.com/repos/zharkowski/245269-pink-18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zharkowski/245269-pink-18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zharkowski/245269-pink-18/git/refs{/sha}","trees_url":"https://api.github.com/repos/zharkowski/245269-pink-18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zharkowski/245269-pink-18/statuses/{sha}","languages_url":"https://api.github.com/repos/zharkowski/245269-pink-18/languages","stargazers_url":"https://api.github.com/repos/zharkowski/245269-pink-18/stargazers","contributors_url":"https://api.github.com/repos/zharkowski/245269-pink-18/contributors","subscribers_url":"https://api.github.com/repos/zharkowski/245269-pink-18/subscribers","subscription_url":"https://api.github.com/repos/zharkowski/245269-pink-18/subscription","commits_url":"https://api.github.com/repos/zharkowski/245269-pink-18/commits{/sha}","git_commits_url":"https://api.github.com/repos/zharkowski/245269-pink-18/git/commits{/sha}","comments_url":"https://api.github.com/repos/zharkowski/245269-pink-18/comments{/number}","issue_comment_url":"https://api.github.com/repos/zharkowski/245269-pink-18/issues/comments{/number}","contents_url":"https://api.github.com/repos/zharkowski/245269-pink-18/contents/{+path}","compare_url":"https://api.github.com/repos/zharkowski/245269-pink-18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zharkowski/245269-pink-18/merges","archive_url":"https://api.github.com/repos/zharkowski/245269-pink-18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zharkowski/245269-pink-18/downloads","issues_url":"https://api.github.com/repos/zharkowski/245269-pink-18/issues{/number}","pulls_url":"https://api.github.com/repos/zharkowski/245269-pink-18/pulls{/number}","milestones_url":"https://api.github.com/repos/zharkowski/245269-pink-18/milestones{/number}","notifications_url":"https://api.github.com/repos/zharkowski/245269-pink-18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zharkowski/245269-pink-18/labels{/name}","releases_url":"https://api.github.com/repos/zharkowski/245269-pink-18/releases{/id}","deployments_url":"https://api.github.com/repos/zharkowski/245269-pink-18/deployments","created_at":"2019-11-12T14:14:02Z","updated_at":"2019-11-20T09:45:46Z","pushed_at":"2019-11-26T20:44:33Z","git_url":"git://github.com/zharkowski/245269-pink-18.git","ssh_url":"git@github.com:zharkowski/245269-pink-18.git","clone_url":"https://github.com/zharkowski/245269-pink-18.git","svn_url":"https://github.com/zharkowski/245269-pink-18","homepage":null,"size":4204,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-adaptive:master","ref":"master","sha":"d6ba5018e6bdfca068337560d6d27cbb363072e2","user":{"login":"htmlacademy-adaptive","id":9918669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTg2Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/9918669?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"repo":{"id":220324831,"node_id":"MDEwOlJlcG9zaXRvcnkyMjAzMjQ4MzE=","name":"245269-pink-18","full_name":"htmlacademy-adaptive/245269-pink-18","private":false,"owner":{"login":"htmlacademy-adaptive","id":9918669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTg2Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/9918669?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-adaptive","html_url":"https://github.com/htmlacademy-adaptive","followers_url":"https://api.github.com/users/htmlacademy-adaptive/followers","following_url":"https://api.github.com/users/htmlacademy-adaptive/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-adaptive/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-adaptive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-adaptive/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-adaptive/orgs","repos_url":"https://api.github.com/users/htmlacademy-adaptive/repos","events_url":"https://api.github.com/users/htmlacademy-adaptive/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-adaptive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-adaptive/245269-pink-18","description":"Максим Жарков","fork":false,"url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18","forks_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/forks","keys_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/teams","hooks_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/events","assignees_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/tags","blobs_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/subscription","commits_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/merges","archive_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/downloads","issues_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/deployments","created_at":"2019-11-07T20:38:18Z","updated_at":"2019-11-20T09:39:51Z","pushed_at":"2019-11-26T20:45:20Z","git_url":"git://github.com/htmlacademy-adaptive/245269-pink-18.git","ssh_url":"git@github.com:htmlacademy-adaptive/245269-pink-18.git","clone_url":"https://github.com/htmlacademy-adaptive/245269-pink-18.git","svn_url":"https://github.com/htmlacademy-adaptive/245269-pink-18","homepage":"https://github.com/zharkowski/245269-pink-18","size":4583,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":null,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/10"},"html":{"href":"https://github.com/htmlacademy-adaptive/245269-pink-18/pull/10"},"issue":{"href":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/issues/10"},"comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-adaptive/245269-pink-18/statuses/495ab574040beade4832a2fbc77ff6f8ec2d2295"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sealeye"}}