{"action":"created","comment":{"url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/comments/334105400","pull_request_review_id":300836627,"id":334105400,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDEwNTQwMA==","diff_hunk":"@@ -183,6 +184,10 @@ class BlockingLoadEvents extends Audit {\n           // Sort by start time so we process the earliest requests first.\n           .sort((a, b) => a.startTime - b.startTime);\n \n+    if (criticalRequests.length) {","path":"lighthouse-plugin-publisher-ads/audits/blocking-load-events.js","position":12,"original_position":12,"commit_id":"c3cc59de6e86a4f312701390a952ff4dae4b0a43","original_commit_id":"c3cc59de6e86a4f312701390a952ff4dae4b0a43","user":{"login":"warrengm","id":5326842,"node_id":"MDQ6VXNlcjUzMjY4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5326842?v=4","gravatar_id":"","url":"https://api.github.com/users/warrengm","html_url":"https://github.com/warrengm","followers_url":"https://api.github.com/users/warrengm/followers","following_url":"https://api.github.com/users/warrengm/following{/other_user}","gists_url":"https://api.github.com/users/warrengm/gists{/gist_id}","starred_url":"https://api.github.com/users/warrengm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrengm/subscriptions","organizations_url":"https://api.github.com/users/warrengm/orgs","repos_url":"https://api.github.com/users/warrengm/repos","events_url":"https://api.github.com/users/warrengm/events{/privacy}","received_events_url":"https://api.github.com/users/warrengm/received_events","type":"User","site_admin":false},"body":"Should you check for emptiness here?","created_at":"2019-10-11T17:50:14Z","updated_at":"2019-10-11T17:50:22Z","html_url":"https://github.com/googleads/publisher-ads-lighthouse-plugin/pull/135#discussion_r334105400","pull_request_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/135","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/comments/334105400"},"html":{"href":"https://github.com/googleads/publisher-ads-lighthouse-plugin/pull/135#discussion_r334105400"},"pull_request":{"href":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/135","id":325936975,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1OTM2OTc1","html_url":"https://github.com/googleads/publisher-ads-lighthouse-plugin/pull/135","diff_url":"https://github.com/googleads/publisher-ads-lighthouse-plugin/pull/135.diff","patch_url":"https://github.com/googleads/publisher-ads-lighthouse-plugin/pull/135.patch","issue_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/issues/135","number":135,"state":"open","locked":false,"title":"Make `blocking-load-event` audit not applicable when there are no ad …","user":{"login":"jburger424","id":3991915,"node_id":"MDQ6VXNlcjM5OTE5MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3991915?v=4","gravatar_id":"","url":"https://api.github.com/users/jburger424","html_url":"https://github.com/jburger424","followers_url":"https://api.github.com/users/jburger424/followers","following_url":"https://api.github.com/users/jburger424/following{/other_user}","gists_url":"https://api.github.com/users/jburger424/gists{/gist_id}","starred_url":"https://api.github.com/users/jburger424/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburger424/subscriptions","organizations_url":"https://api.github.com/users/jburger424/orgs","repos_url":"https://api.github.com/users/jburger424/repos","events_url":"https://api.github.com/users/jburger424/events{/privacy}","received_events_url":"https://api.github.com/users/jburger424/received_events","type":"User","site_admin":false},"body":"…related requests.","created_at":"2019-10-08T19:57:17Z","updated_at":"2019-10-11T17:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7410c38870fcc681f593ae26c540e82f0d255e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/135/commits","review_comments_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/135/comments","review_comment_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/issues/135/comments","statuses_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/statuses/c3cc59de6e86a4f312701390a952ff4dae4b0a43","head":{"label":"jburger424:fix-not-app","ref":"fix-not-app","sha":"c3cc59de6e86a4f312701390a952ff4dae4b0a43","user":{"login":"jburger424","id":3991915,"node_id":"MDQ6VXNlcjM5OTE5MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3991915?v=4","gravatar_id":"","url":"https://api.github.com/users/jburger424","html_url":"https://github.com/jburger424","followers_url":"https://api.github.com/users/jburger424/followers","following_url":"https://api.github.com/users/jburger424/following{/other_user}","gists_url":"https://api.github.com/users/jburger424/gists{/gist_id}","starred_url":"https://api.github.com/users/jburger424/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburger424/subscriptions","organizations_url":"https://api.github.com/users/jburger424/orgs","repos_url":"https://api.github.com/users/jburger424/repos","events_url":"https://api.github.com/users/jburger424/events{/privacy}","received_events_url":"https://api.github.com/users/jburger424/received_events","type":"User","site_admin":false},"repo":{"id":181958801,"node_id":"MDEwOlJlcG9zaXRvcnkxODE5NTg4MDE=","name":"ad-speed-insights","full_name":"jburger424/ad-speed-insights","private":false,"owner":{"login":"jburger424","id":3991915,"node_id":"MDQ6VXNlcjM5OTE5MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3991915?v=4","gravatar_id":"","url":"https://api.github.com/users/jburger424","html_url":"https://github.com/jburger424","followers_url":"https://api.github.com/users/jburger424/followers","following_url":"https://api.github.com/users/jburger424/following{/other_user}","gists_url":"https://api.github.com/users/jburger424/gists{/gist_id}","starred_url":"https://api.github.com/users/jburger424/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburger424/subscriptions","organizations_url":"https://api.github.com/users/jburger424/orgs","repos_url":"https://api.github.com/users/jburger424/repos","events_url":"https://api.github.com/users/jburger424/events{/privacy}","received_events_url":"https://api.github.com/users/jburger424/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jburger424/ad-speed-insights","description":"Ad Speed Insights is a tool to improve ad speed and overall quality through a series of automated audits. This tool will aid in resolving discovered problems, providing a tool to be used to evaluate effectiveness of iterative changes while suggesting actionable feedback.","fork":true,"url":"https://api.github.com/repos/jburger424/ad-speed-insights","forks_url":"https://api.github.com/repos/jburger424/ad-speed-insights/forks","keys_url":"https://api.github.com/repos/jburger424/ad-speed-insights/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jburger424/ad-speed-insights/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jburger424/ad-speed-insights/teams","hooks_url":"https://api.github.com/repos/jburger424/ad-speed-insights/hooks","issue_events_url":"https://api.github.com/repos/jburger424/ad-speed-insights/issues/events{/number}","events_url":"https://api.github.com/repos/jburger424/ad-speed-insights/events","assignees_url":"https://api.github.com/repos/jburger424/ad-speed-insights/assignees{/user}","branches_url":"https://api.github.com/repos/jburger424/ad-speed-insights/branches{/branch}","tags_url":"https://api.github.com/repos/jburger424/ad-speed-insights/tags","blobs_url":"https://api.github.com/repos/jburger424/ad-speed-insights/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jburger424/ad-speed-insights/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jburger424/ad-speed-insights/git/refs{/sha}","trees_url":"https://api.github.com/repos/jburger424/ad-speed-insights/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jburger424/ad-speed-insights/statuses/{sha}","languages_url":"https://api.github.com/repos/jburger424/ad-speed-insights/languages","stargazers_url":"https://api.github.com/repos/jburger424/ad-speed-insights/stargazers","contributors_url":"https://api.github.com/repos/jburger424/ad-speed-insights/contributors","subscribers_url":"https://api.github.com/repos/jburger424/ad-speed-insights/subscribers","subscription_url":"https://api.github.com/repos/jburger424/ad-speed-insights/subscription","commits_url":"https://api.github.com/repos/jburger424/ad-speed-insights/commits{/sha}","git_commits_url":"https://api.github.com/repos/jburger424/ad-speed-insights/git/commits{/sha}","comments_url":"https://api.github.com/repos/jburger424/ad-speed-insights/comments{/number}","issue_comment_url":"https://api.github.com/repos/jburger424/ad-speed-insights/issues/comments{/number}","contents_url":"https://api.github.com/repos/jburger424/ad-speed-insights/contents/{+path}","compare_url":"https://api.github.com/repos/jburger424/ad-speed-insights/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jburger424/ad-speed-insights/merges","archive_url":"https://api.github.com/repos/jburger424/ad-speed-insights/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jburger424/ad-speed-insights/downloads","issues_url":"https://api.github.com/repos/jburger424/ad-speed-insights/issues{/number}","pulls_url":"https://api.github.com/repos/jburger424/ad-speed-insights/pulls{/number}","milestones_url":"https://api.github.com/repos/jburger424/ad-speed-insights/milestones{/number}","notifications_url":"https://api.github.com/repos/jburger424/ad-speed-insights/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jburger424/ad-speed-insights/labels{/name}","releases_url":"https://api.github.com/repos/jburger424/ad-speed-insights/releases{/id}","deployments_url":"https://api.github.com/repos/jburger424/ad-speed-insights/deployments","created_at":"2019-04-17T19:51:50Z","updated_at":"2019-07-09T21:44:56Z","pushed_at":"2019-10-11T16:40:59Z","git_url":"git://github.com/jburger424/ad-speed-insights.git","ssh_url":"git@github.com:jburger424/ad-speed-insights.git","clone_url":"https://github.com/jburger424/ad-speed-insights.git","svn_url":"https://github.com/jburger424/ad-speed-insights","homepage":"","size":800,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleads:master","ref":"master","sha":"0493259f75ed115d071ab69bd5a1f721fc13c0e7","user":{"login":"googleads","id":4551618,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NTE2MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4551618?v=4","gravatar_id":"","url":"https://api.github.com/users/googleads","html_url":"https://github.com/googleads","followers_url":"https://api.github.com/users/googleads/followers","following_url":"https://api.github.com/users/googleads/following{/other_user}","gists_url":"https://api.github.com/users/googleads/gists{/gist_id}","starred_url":"https://api.github.com/users/googleads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleads/subscriptions","organizations_url":"https://api.github.com/users/googleads/orgs","repos_url":"https://api.github.com/users/googleads/repos","events_url":"https://api.github.com/users/googleads/events{/privacy}","received_events_url":"https://api.github.com/users/googleads/received_events","type":"Organization","site_admin":false},"repo":{"id":167601443,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc2MDE0NDM=","name":"publisher-ads-lighthouse-plugin","full_name":"googleads/publisher-ads-lighthouse-plugin","private":false,"owner":{"login":"googleads","id":4551618,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NTE2MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4551618?v=4","gravatar_id":"","url":"https://api.github.com/users/googleads","html_url":"https://github.com/googleads","followers_url":"https://api.github.com/users/googleads/followers","following_url":"https://api.github.com/users/googleads/following{/other_user}","gists_url":"https://api.github.com/users/googleads/gists{/gist_id}","starred_url":"https://api.github.com/users/googleads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleads/subscriptions","organizations_url":"https://api.github.com/users/googleads/orgs","repos_url":"https://api.github.com/users/googleads/repos","events_url":"https://api.github.com/users/googleads/events{/privacy}","received_events_url":"https://api.github.com/users/googleads/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleads/publisher-ads-lighthouse-plugin","description":"Publisher Ads Lighthouse Plugin is a tool to improve ad speed and overall quality through a series of automated audits. This tool will aid in resolving discovered problems, providing a tool to be used to evaluate effectiveness of iterative changes while suggesting actionable feedback.","fork":false,"url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin","forks_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/forks","keys_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/teams","hooks_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/hooks","issue_events_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/events","assignees_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/tags","blobs_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/languages","stargazers_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/stargazers","contributors_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/contributors","subscribers_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/subscribers","subscription_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/subscription","commits_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/merges","archive_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/downloads","issues_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/labels{/name}","releases_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/deployments","created_at":"2019-01-25T19:25:30Z","updated_at":"2019-10-11T15:37:39Z","pushed_at":"2019-10-11T16:41:01Z","git_url":"git://github.com/googleads/publisher-ads-lighthouse-plugin.git","ssh_url":"git@github.com:googleads/publisher-ads-lighthouse-plugin.git","clone_url":"https://github.com/googleads/publisher-ads-lighthouse-plugin.git","svn_url":"https://github.com/googleads/publisher-ads-lighthouse-plugin","homepage":"","size":673,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":17,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/135"},"html":{"href":"https://github.com/googleads/publisher-ads-lighthouse-plugin/pull/135"},"issue":{"href":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/issues/135"},"comments":{"href":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/googleads/publisher-ads-lighthouse-plugin/statuses/c3cc59de6e86a4f312701390a952ff4dae4b0a43"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"warrengm"}}