{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/295180724","pull_request_review_id":251548785,"id":295180724,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTE4MDcyNA==","diff_hunk":"@@ -0,0 +1,207 @@\n+// Copyright 2019 Authors of Cilium\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package mock\n+\n+import (\n+\t\"fmt\"\n+\t\"net\"\n+\n+\t\"github.com/cilium/cilium/pkg/aws/types\"\n+\t\"github.com/cilium/cilium/pkg/k8s/apis/cilium.io/v2\"\n+\t\"github.com/cilium/cilium/pkg/lock\"\n+\t\"github.com/cilium/cilium/pkg/uuid\"\n+\n+\t\"k8s.io/kubernetes/pkg/registry/core/service/ipallocator\"\n+)\n+\n+type eniMap map[string]*v2.ENI\n+\n+type API struct {\n+\tmutex      lock.RWMutex\n+\tunattached map[string]*v2.ENI\n+\tenis       map[string]eniMap\n+\tsubnets    map[string]*types.Subnet\n+\tallocator  *ipallocator.Range\n+}\n+\n+func NewAPI(subnets []*types.Subnet) *API {\n+\t_, cidr, _ := net.ParseCIDR(\"10.0.0.0/8\")\n+\n+\tapi := &API{\n+\t\tunattached: map[string]*v2.ENI{},\n+\t\tenis:       map[string]eniMap{},\n+\t\tsubnets:    map[string]*types.Subnet{},\n+\t\tallocator:  ipallocator.NewCIDRRange(cidr),\n+\t}\n+\n+\tfor _, s := range subnets {\n+\t\tapi.subnets[s.ID] = s\n+\t}\n+\n+\treturn api\n+}\n+\n+func (e *API) GetENI(instanceID string, index int) *v2.ENI {\n+\te.mutex.RLock()\n+\tdefer e.mutex.RUnlock()\n+\n+\tfor _, eni := range e.enis[instanceID] {\n+\t\tif eni.Number == index {\n+\t\t\treturn eni\n+\t\t}\n+\t}\n+\n+\treturn nil\n+}\n+\n+func (e *API) GetENIs(instanceID string) (enis []*v2.ENI) {","path":"pkg/aws/ec2/mock/mock.go","position":69,"original_position":69,"commit_id":"5cfdfc85e6a3693cf44542c759ef75733a7b0257","original_commit_id":"5cfdfc85e6a3693cf44542c759ef75733a7b0257","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"exported method API.GetENIs should have comment or be unexported","created_at":"2019-06-19T08:34:57Z","updated_at":"2019-06-19T08:34:58Z","html_url":"https://github.com/cilium/cilium/pull/8347#discussion_r295180724","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/8347","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/295180724"},"html":{"href":"https://github.com/cilium/cilium/pull/8347#discussion_r295180724"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/8347"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/8347","id":289595640,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5NTk1NjQw","html_url":"https://github.com/cilium/cilium/pull/8347","diff_url":"https://github.com/cilium/cilium/pull/8347.diff","patch_url":"https://github.com/cilium/cilium/pull/8347.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/8347","number":8347,"state":"open","locked":false,"title":"[WIP] AWS ENI support","user":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"body":"This PR adds AWS ENI IP allocation and datapath support. The details can be found in the individual commit messages and in the documentation commit.\r\n\r\nFixes: #6430\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/8347)\n<!-- Reviewable:end -->\n","created_at":"2019-06-19T08:34:46Z","updated_at":"2019-06-19T08:34:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3aa8dce13c870b4af40cdbe04f6a3b422a026c00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"bpf","id":2519779,"node_id":"MDQ6VGVhbTI1MTk3Nzk=","slug":"bpf","description":"BPF datapath","privacy":"closed","url":"https://api.github.com/teams/2519779","html_url":"https://github.com/orgs/cilium/teams/bpf","members_url":"https://api.github.com/teams/2519779/members{/member}","repositories_url":"https://api.github.com/teams/2519779/repos","permission":"pull"},{"name":"kubernetes","id":2519785,"node_id":"MDQ6VGVhbTI1MTk3ODU=","slug":"kubernetes","description":"Kubernetes integration","privacy":"closed","url":"https://api.github.com/teams/2519785","html_url":"https://github.com/orgs/cilium/teams/kubernetes","members_url":"https://api.github.com/teams/2519785/members{/member}","repositories_url":"https://api.github.com/teams/2519785/repos","permission":"pull"},{"name":"docs","id":2519789,"node_id":"MDQ6VGVhbTI1MTk3ODk=","slug":"docs","description":"Documentation","privacy":"closed","url":"https://api.github.com/teams/2519789","html_url":"https://github.com/orgs/cilium/teams/docs","members_url":"https://api.github.com/teams/2519789/members{/member}","repositories_url":"https://api.github.com/teams/2519789/repos","permission":"pull"},{"name":"agent","id":2519792,"node_id":"MDQ6VGVhbTI1MTk3OTI=","slug":"agent","description":"Cilium Agent","privacy":"closed","url":"https://api.github.com/teams/2519792","html_url":"https://github.com/orgs/cilium/teams/agent","members_url":"https://api.github.com/teams/2519792/members{/member}","repositories_url":"https://api.github.com/teams/2519792/repos","permission":"pull"},{"name":"api","id":2519795,"node_id":"MDQ6VGVhbTI1MTk3OTU=","slug":"api","description":"REST API","privacy":"closed","url":"https://api.github.com/teams/2519795","html_url":"https://github.com/orgs/cilium/teams/api","members_url":"https://api.github.com/teams/2519795/members{/member}","repositories_url":"https://api.github.com/teams/2519795/repos","permission":"pull"},{"name":"janitors","id":2519796,"node_id":"MDQ6VGVhbTI1MTk3OTY=","slug":"janitors","description":"Rotating team of janitors for unowned code","privacy":"closed","url":"https://api.github.com/teams/2519796","html_url":"https://github.com/orgs/cilium/teams/janitors","members_url":"https://api.github.com/teams/2519796/members{/member}","repositories_url":"https://api.github.com/teams/2519796/repos","permission":"pull"}],"labels":[{"id":403244562,"node_id":"MDU6TGFiZWw0MDMyNDQ1NjI=","url":"https://api.github.com/repos/cilium/cilium/labels/wip","name":"wip","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/8347/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/8347/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/8347/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/5cfdfc85e6a3693cf44542c759ef75733a7b0257","head":{"label":"cilium:pr/tgraf/aws-eni-ipam","ref":"pr/tgraf/aws-eni-ipam","sha":"5cfdfc85e6a3693cf44542c759ef75733a7b0257","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","private":false,"owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cilium/cilium","description":"API Aware Networking and Security using BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2019-06-19T07:38:43Z","pushed_at":"2019-06-19T08:34:57Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":97668,"stargazers_count":4041,"watchers_count":4041,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":368,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":359,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":368,"open_issues":359,"watchers":4041,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"fa3de3fefb9ae8913879246d603a0b3bdcb72e63","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","private":false,"owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cilium/cilium","description":"API Aware Networking and Security using BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2019-06-19T07:38:43Z","pushed_at":"2019-06-19T08:34:57Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":97668,"stargazers_count":4041,"watchers_count":4041,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":368,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":359,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":368,"open_issues":359,"watchers":4041,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/8347"},"html":{"href":"https://github.com/cilium/cilium/pull/8347"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/8347"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/8347/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/8347/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/8347/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/5cfdfc85e6a3693cf44542c759ef75733a7b0257"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}