{"action":"closed","number":3261,"pull_request":{"url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/3261","id":350033069,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwMDMzMDY5","html_url":"https://github.com/ianstormtaylor/slate/pull/3261","diff_url":"https://github.com/ianstormtaylor/slate/pull/3261.diff","patch_url":"https://github.com/ianstormtaylor/slate/pull/3261.patch","issue_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/3261","number":3261,"state":"closed","locked":false,"title":"Force a zero offset when inside a void node","user":{"login":"dmarkow","id":8009,"node_id":"MDQ6VXNlcjgwMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/8009?v=4","gravatar_id":"","url":"https://api.github.com/users/dmarkow","html_url":"https://github.com/dmarkow","followers_url":"https://api.github.com/users/dmarkow/followers","following_url":"https://api.github.com/users/dmarkow/following{/other_user}","gists_url":"https://api.github.com/users/dmarkow/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarkow/subscriptions","organizations_url":"https://api.github.com/users/dmarkow/orgs","repos_url":"https://api.github.com/users/dmarkow/repos","events_url":"https://api.github.com/users/dmarkow/events{/privacy}","received_events_url":"https://api.github.com/users/dmarkow/received_events","type":"User","site_admin":false},"body":"#### Is this adding or improving a _feature_ or fixing a _bug_?\r\n\r\nFixing a bug\r\n\r\n#### What's the new behavior?\r\n\r\nSelecting a void node no longer crashes.\r\n\r\n#### How does this change work?\r\n\r\n`ReactEditor.toDOMPoint` forces an offset of 0 if the point is inside a void node.\r\n\r\nI have no idea how to add tests for this, but can include some with a little guidance. \r\n\r\n#### Have you checked that...?\r\n\r\n- [x] The new code matches the existing patterns and styles.\r\n- [x] The tests pass with `yarn test`.\r\n- [x] The linter passes with `yarn lint`. (Fix errors with `yarn fix`.)\r\n- [x] The relevant examples still work. (Run examples with `yarn start`.)\r\n\r\n#### Does this fix any issues or need any specific reviewers?\r\n\r\nFixes: #3239 \r\n","created_at":"2019-12-06T15:12:52Z","updated_at":"2019-12-06T16:13:04Z","closed_at":"2019-12-06T16:13:04Z","merged_at":"2019-12-06T16:13:03Z","merge_commit_sha":"eeecae023fefc7cd7d0451209b8c3efbbedd9cbd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":404055005,"node_id":"MDU6TGFiZWw0MDQwNTUwMDU=","url":"https://api.github.com/repos/ianstormtaylor/slate/labels/bug","name":"bug","color":"f9d0c4","default":true,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/3261/commits","review_comments_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/3261/comments","review_comment_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/3261/comments","statuses_url":"https://api.github.com/repos/ianstormtaylor/slate/statuses/56277a22e86ddeec2be80a4b007590529678c0fd","head":{"label":"dmarkow:fix-void-node-selection","ref":"fix-void-node-selection","sha":"56277a22e86ddeec2be80a4b007590529678c0fd","user":{"login":"dmarkow","id":8009,"node_id":"MDQ6VXNlcjgwMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/8009?v=4","gravatar_id":"","url":"https://api.github.com/users/dmarkow","html_url":"https://github.com/dmarkow","followers_url":"https://api.github.com/users/dmarkow/followers","following_url":"https://api.github.com/users/dmarkow/following{/other_user}","gists_url":"https://api.github.com/users/dmarkow/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarkow/subscriptions","organizations_url":"https://api.github.com/users/dmarkow/orgs","repos_url":"https://api.github.com/users/dmarkow/repos","events_url":"https://api.github.com/users/dmarkow/events{/privacy}","received_events_url":"https://api.github.com/users/dmarkow/received_events","type":"User","site_admin":false},"repo":{"id":225750354,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU3NTAzNTQ=","name":"slate","full_name":"dmarkow/slate","private":false,"owner":{"login":"dmarkow","id":8009,"node_id":"MDQ6VXNlcjgwMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/8009?v=4","gravatar_id":"","url":"https://api.github.com/users/dmarkow","html_url":"https://github.com/dmarkow","followers_url":"https://api.github.com/users/dmarkow/followers","following_url":"https://api.github.com/users/dmarkow/following{/other_user}","gists_url":"https://api.github.com/users/dmarkow/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarkow/subscriptions","organizations_url":"https://api.github.com/users/dmarkow/orgs","repos_url":"https://api.github.com/users/dmarkow/repos","events_url":"https://api.github.com/users/dmarkow/events{/privacy}","received_events_url":"https://api.github.com/users/dmarkow/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmarkow/slate","description":"A completely customizable framework for building rich text editors. (Currently in beta.)","fork":true,"url":"https://api.github.com/repos/dmarkow/slate","forks_url":"https://api.github.com/repos/dmarkow/slate/forks","keys_url":"https://api.github.com/repos/dmarkow/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmarkow/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmarkow/slate/teams","hooks_url":"https://api.github.com/repos/dmarkow/slate/hooks","issue_events_url":"https://api.github.com/repos/dmarkow/slate/issues/events{/number}","events_url":"https://api.github.com/repos/dmarkow/slate/events","assignees_url":"https://api.github.com/repos/dmarkow/slate/assignees{/user}","branches_url":"https://api.github.com/repos/dmarkow/slate/branches{/branch}","tags_url":"https://api.github.com/repos/dmarkow/slate/tags","blobs_url":"https://api.github.com/repos/dmarkow/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmarkow/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmarkow/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmarkow/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmarkow/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/dmarkow/slate/languages","stargazers_url":"https://api.github.com/repos/dmarkow/slate/stargazers","contributors_url":"https://api.github.com/repos/dmarkow/slate/contributors","subscribers_url":"https://api.github.com/repos/dmarkow/slate/subscribers","subscription_url":"https://api.github.com/repos/dmarkow/slate/subscription","commits_url":"https://api.github.com/repos/dmarkow/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmarkow/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmarkow/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmarkow/slate/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmarkow/slate/contents/{+path}","compare_url":"https://api.github.com/repos/dmarkow/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmarkow/slate/merges","archive_url":"https://api.github.com/repos/dmarkow/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmarkow/slate/downloads","issues_url":"https://api.github.com/repos/dmarkow/slate/issues{/number}","pulls_url":"https://api.github.com/repos/dmarkow/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/dmarkow/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/dmarkow/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmarkow/slate/labels{/name}","releases_url":"https://api.github.com/repos/dmarkow/slate/releases{/id}","deployments_url":"https://api.github.com/repos/dmarkow/slate/deployments","created_at":"2019-12-04T01:17:46Z","updated_at":"2019-12-06T13:34:59Z","pushed_at":"2019-12-06T14:45:26Z","git_url":"git://github.com/dmarkow/slate.git","ssh_url":"git@github.com:dmarkow/slate.git","clone_url":"https://github.com/dmarkow/slate.git","svn_url":"https://github.com/dmarkow/slate","homepage":"http://slatejs.org","size":240989,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ianstormtaylor:master","ref":"master","sha":"8982ba9b2f384881ffbcc820a12da3d0d4abde01","user":{"login":"ianstormtaylor","id":311752,"node_id":"MDQ6VXNlcjMxMTc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/311752?v=4","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"repo":{"id":61412022,"node_id":"MDEwOlJlcG9zaXRvcnk2MTQxMjAyMg==","name":"slate","full_name":"ianstormtaylor/slate","private":false,"owner":{"login":"ianstormtaylor","id":311752,"node_id":"MDQ6VXNlcjMxMTc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/311752?v=4","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ianstormtaylor/slate","description":"A completely customizable framework for building rich text editors. (Currently in beta.)","fork":false,"url":"https://api.github.com/repos/ianstormtaylor/slate","forks_url":"https://api.github.com/repos/ianstormtaylor/slate/forks","keys_url":"https://api.github.com/repos/ianstormtaylor/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianstormtaylor/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianstormtaylor/slate/teams","hooks_url":"https://api.github.com/repos/ianstormtaylor/slate/hooks","issue_events_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/events{/number}","events_url":"https://api.github.com/repos/ianstormtaylor/slate/events","assignees_url":"https://api.github.com/repos/ianstormtaylor/slate/assignees{/user}","branches_url":"https://api.github.com/repos/ianstormtaylor/slate/branches{/branch}","tags_url":"https://api.github.com/repos/ianstormtaylor/slate/tags","blobs_url":"https://api.github.com/repos/ianstormtaylor/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianstormtaylor/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianstormtaylor/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianstormtaylor/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianstormtaylor/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/ianstormtaylor/slate/languages","stargazers_url":"https://api.github.com/repos/ianstormtaylor/slate/stargazers","contributors_url":"https://api.github.com/repos/ianstormtaylor/slate/contributors","subscribers_url":"https://api.github.com/repos/ianstormtaylor/slate/subscribers","subscription_url":"https://api.github.com/repos/ianstormtaylor/slate/subscription","commits_url":"https://api.github.com/repos/ianstormtaylor/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianstormtaylor/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianstormtaylor/slate/contents/{+path}","compare_url":"https://api.github.com/repos/ianstormtaylor/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianstormtaylor/slate/merges","archive_url":"https://api.github.com/repos/ianstormtaylor/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianstormtaylor/slate/downloads","issues_url":"https://api.github.com/repos/ianstormtaylor/slate/issues{/number}","pulls_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/ianstormtaylor/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/ianstormtaylor/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianstormtaylor/slate/labels{/name}","releases_url":"https://api.github.com/repos/ianstormtaylor/slate/releases{/id}","deployments_url":"https://api.github.com/repos/ianstormtaylor/slate/deployments","created_at":"2016-06-18T01:52:42Z","updated_at":"2019-12-06T15:59:04Z","pushed_at":"2019-12-06T16:13:05Z","git_url":"git://github.com/ianstormtaylor/slate.git","ssh_url":"git@github.com:ianstormtaylor/slate.git","clone_url":"https://github.com/ianstormtaylor/slate.git","svn_url":"https://github.com/ianstormtaylor/slate","homepage":"http://slatejs.org","size":240984,"stargazers_count":16028,"watchers_count":16028,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1528,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1528,"open_issues":87,"watchers":16028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/3261"},"html":{"href":"https://github.com/ianstormtaylor/slate/pull/3261"},"issue":{"href":"https://api.github.com/repos/ianstormtaylor/slate/issues/3261"},"comments":{"href":"https://api.github.com/repos/ianstormtaylor/slate/issues/3261/comments"},"review_comments":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/3261/comments"},"review_comment":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/3261/commits"},"statuses":{"href":"https://api.github.com/repos/ianstormtaylor/slate/statuses/56277a22e86ddeec2be80a4b007590529678c0fd"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ianstormtaylor","id":311752,"node_id":"MDQ6VXNlcjMxMTc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/311752?v=4","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"ianstormtaylor"}}