{"action":"created","comment":{"url":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/comments/310396910","pull_request_review_id":270507674,"id":310396910,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDM5NjkxMA==","diff_hunk":"@@ -338,7 +338,6 @@ readrec5(File *f, Job *l, int *err)\n             j = make_job_with_id(jr.pri, jr.delay, jr.ttr, jr.body_size,\n                                  t, jr.id);\n             j->next = j->prev = j;\n-            j->r.created_at = jr.created_at;","path":"file.c","position":4,"original_position":4,"commit_id":"2ee2ba52fdc2d9275f38109c487c54b2b4b7b579","original_commit_id":"2ee2ba52fdc2d9275f38109c487c54b2b4b7b579","user":{"login":"ysmolsky","id":140245,"node_id":"MDQ6VXNlcjE0MDI0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/140245?v=4","gravatar_id":"","url":"https://api.github.com/users/ysmolsky","html_url":"https://github.com/ysmolsky","followers_url":"https://api.github.com/users/ysmolsky/followers","following_url":"https://api.github.com/users/ysmolsky/following{/other_user}","gists_url":"https://api.github.com/users/ysmolsky/gists{/gist_id}","starred_url":"https://api.github.com/users/ysmolsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysmolsky/subscriptions","organizations_url":"https://api.github.com/users/ysmolsky/orgs","repos_url":"https://api.github.com/users/ysmolsky/repos","events_url":"https://api.github.com/users/ysmolsky/events{/privacy}","received_events_url":"https://api.github.com/users/ysmolsky/received_events","type":"User","site_admin":false},"body":"Yep, most of the issues here were reported by cppcheck and manually fixed by me.\r\nIn this case, see line 348 where value to `j->r.created_at` assigned regardless of deleted line the branch `if (!j)`.","created_at":"2019-08-04T17:42:16Z","updated_at":"2019-08-04T17:42:17Z","html_url":"https://github.com/beanstalkd/beanstalkd/pull/522#discussion_r310396910","pull_request_url":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/522","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/comments/310396910"},"html":{"href":"https://github.com/beanstalkd/beanstalkd/pull/522#discussion_r310396910"},"pull_request":{"href":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/522"}},"in_reply_to_id":310395543},"pull_request":{"url":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/522","id":304069022,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0MDY5MDIy","html_url":"https://github.com/beanstalkd/beanstalkd/pull/522","diff_url":"https://github.com/beanstalkd/beanstalkd/pull/522.diff","patch_url":"https://github.com/beanstalkd/beanstalkd/pull/522.patch","issue_url":"https://api.github.com/repos/beanstalkd/beanstalkd/issues/522","number":522,"state":"open","locked":false,"title":"fix style of the code","user":{"login":"ysmolsky","id":140245,"node_id":"MDQ6VXNlcjE0MDI0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/140245?v=4","gravatar_id":"","url":"https://api.github.com/users/ysmolsky","html_url":"https://github.com/ysmolsky","followers_url":"https://api.github.com/users/ysmolsky/followers","following_url":"https://api.github.com/users/ysmolsky/following{/other_user}","gists_url":"https://api.github.com/users/ysmolsky/gists{/gist_id}","starred_url":"https://api.github.com/users/ysmolsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysmolsky/subscriptions","organizations_url":"https://api.github.com/users/ysmolsky/orgs","repos_url":"https://api.github.com/users/ysmolsky/repos","events_url":"https://api.github.com/users/ysmolsky/events{/privacy}","received_events_url":"https://api.github.com/users/ysmolsky/received_events","type":"User","site_admin":false},"body":"* remove global vars where possible\r\n* reduce scope of variables\r\n* remove shadowing of variables\r\n* remove redundant assigments\r\n* fix prototypes according to the definion of functions\r\n\r\nUpdates #442","created_at":"2019-08-04T13:47:48Z","updated_at":"2019-08-04T17:42:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1fe4e3eb6c7c052c59f809afd70a63174deeed7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tomponline","id":280181,"node_id":"MDQ6VXNlcjI4MDE4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/280181?v=4","gravatar_id":"","url":"https://api.github.com/users/tomponline","html_url":"https://github.com/tomponline","followers_url":"https://api.github.com/users/tomponline/followers","following_url":"https://api.github.com/users/tomponline/following{/other_user}","gists_url":"https://api.github.com/users/tomponline/gists{/gist_id}","starred_url":"https://api.github.com/users/tomponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomponline/subscriptions","organizations_url":"https://api.github.com/users/tomponline/orgs","repos_url":"https://api.github.com/users/tomponline/repos","events_url":"https://api.github.com/users/tomponline/events{/privacy}","received_events_url":"https://api.github.com/users/tomponline/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/522/commits","review_comments_url":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/522/comments","review_comment_url":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/beanstalkd/beanstalkd/issues/522/comments","statuses_url":"https://api.github.com/repos/beanstalkd/beanstalkd/statuses/2ee2ba52fdc2d9275f38109c487c54b2b4b7b579","head":{"label":"beanstalkd:fix-style-scope-shadows","ref":"fix-style-scope-shadows","sha":"2ee2ba52fdc2d9275f38109c487c54b2b4b7b579","user":{"login":"beanstalkd","id":2703664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDM2NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2703664?v=4","gravatar_id":"","url":"https://api.github.com/users/beanstalkd","html_url":"https://github.com/beanstalkd","followers_url":"https://api.github.com/users/beanstalkd/followers","following_url":"https://api.github.com/users/beanstalkd/following{/other_user}","gists_url":"https://api.github.com/users/beanstalkd/gists{/gist_id}","starred_url":"https://api.github.com/users/beanstalkd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beanstalkd/subscriptions","organizations_url":"https://api.github.com/users/beanstalkd/orgs","repos_url":"https://api.github.com/users/beanstalkd/repos","events_url":"https://api.github.com/users/beanstalkd/events{/privacy}","received_events_url":"https://api.github.com/users/beanstalkd/received_events","type":"Organization","site_admin":false},"repo":{"id":6040,"node_id":"MDEwOlJlcG9zaXRvcnk2MDQw","name":"beanstalkd","full_name":"beanstalkd/beanstalkd","private":false,"owner":{"login":"beanstalkd","id":2703664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDM2NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2703664?v=4","gravatar_id":"","url":"https://api.github.com/users/beanstalkd","html_url":"https://github.com/beanstalkd","followers_url":"https://api.github.com/users/beanstalkd/followers","following_url":"https://api.github.com/users/beanstalkd/following{/other_user}","gists_url":"https://api.github.com/users/beanstalkd/gists{/gist_id}","starred_url":"https://api.github.com/users/beanstalkd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beanstalkd/subscriptions","organizations_url":"https://api.github.com/users/beanstalkd/orgs","repos_url":"https://api.github.com/users/beanstalkd/repos","events_url":"https://api.github.com/users/beanstalkd/events{/privacy}","received_events_url":"https://api.github.com/users/beanstalkd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/beanstalkd/beanstalkd","description":"Beanstalk is a simple, fast work queue.","fork":false,"url":"https://api.github.com/repos/beanstalkd/beanstalkd","forks_url":"https://api.github.com/repos/beanstalkd/beanstalkd/forks","keys_url":"https://api.github.com/repos/beanstalkd/beanstalkd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beanstalkd/beanstalkd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beanstalkd/beanstalkd/teams","hooks_url":"https://api.github.com/repos/beanstalkd/beanstalkd/hooks","issue_events_url":"https://api.github.com/repos/beanstalkd/beanstalkd/issues/events{/number}","events_url":"https://api.github.com/repos/beanstalkd/beanstalkd/events","assignees_url":"https://api.github.com/repos/beanstalkd/beanstalkd/assignees{/user}","branches_url":"https://api.github.com/repos/beanstalkd/beanstalkd/branches{/branch}","tags_url":"https://api.github.com/repos/beanstalkd/beanstalkd/tags","blobs_url":"https://api.github.com/repos/beanstalkd/beanstalkd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beanstalkd/beanstalkd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beanstalkd/beanstalkd/git/refs{/sha}","trees_url":"https://api.github.com/repos/beanstalkd/beanstalkd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beanstalkd/beanstalkd/statuses/{sha}","languages_url":"https://api.github.com/repos/beanstalkd/beanstalkd/languages","stargazers_url":"https://api.github.com/repos/beanstalkd/beanstalkd/stargazers","contributors_url":"https://api.github.com/repos/beanstalkd/beanstalkd/contributors","subscribers_url":"https://api.github.com/repos/beanstalkd/beanstalkd/subscribers","subscription_url":"https://api.github.com/repos/beanstalkd/beanstalkd/subscription","commits_url":"https://api.github.com/repos/beanstalkd/beanstalkd/commits{/sha}","git_commits_url":"https://api.github.com/repos/beanstalkd/beanstalkd/git/commits{/sha}","comments_url":"https://api.github.com/repos/beanstalkd/beanstalkd/comments{/number}","issue_comment_url":"https://api.github.com/repos/beanstalkd/beanstalkd/issues/comments{/number}","contents_url":"https://api.github.com/repos/beanstalkd/beanstalkd/contents/{+path}","compare_url":"https://api.github.com/repos/beanstalkd/beanstalkd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beanstalkd/beanstalkd/merges","archive_url":"https://api.github.com/repos/beanstalkd/beanstalkd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beanstalkd/beanstalkd/downloads","issues_url":"https://api.github.com/repos/beanstalkd/beanstalkd/issues{/number}","pulls_url":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls{/number}","milestones_url":"https://api.github.com/repos/beanstalkd/beanstalkd/milestones{/number}","notifications_url":"https://api.github.com/repos/beanstalkd/beanstalkd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beanstalkd/beanstalkd/labels{/name}","releases_url":"https://api.github.com/repos/beanstalkd/beanstalkd/releases{/id}","deployments_url":"https://api.github.com/repos/beanstalkd/beanstalkd/deployments","created_at":"2008-03-31T20:20:41Z","updated_at":"2019-08-04T09:16:40Z","pushed_at":"2019-08-04T16:05:29Z","git_url":"git://github.com/beanstalkd/beanstalkd.git","ssh_url":"git@github.com:beanstalkd/beanstalkd.git","clone_url":"https://github.com/beanstalkd/beanstalkd.git","svn_url":"https://github.com/beanstalkd/beanstalkd","homepage":"https://beanstalkd.github.io/","size":1220,"stargazers_count":5173,"watchers_count":5173,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":754,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":754,"open_issues":54,"watchers":5173,"default_branch":"master"}},"base":{"label":"beanstalkd:master","ref":"master","sha":"e9a9e7b94196ce51a193a5bbcc3f7ae690ac3674","user":{"login":"beanstalkd","id":2703664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDM2NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2703664?v=4","gravatar_id":"","url":"https://api.github.com/users/beanstalkd","html_url":"https://github.com/beanstalkd","followers_url":"https://api.github.com/users/beanstalkd/followers","following_url":"https://api.github.com/users/beanstalkd/following{/other_user}","gists_url":"https://api.github.com/users/beanstalkd/gists{/gist_id}","starred_url":"https://api.github.com/users/beanstalkd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beanstalkd/subscriptions","organizations_url":"https://api.github.com/users/beanstalkd/orgs","repos_url":"https://api.github.com/users/beanstalkd/repos","events_url":"https://api.github.com/users/beanstalkd/events{/privacy}","received_events_url":"https://api.github.com/users/beanstalkd/received_events","type":"Organization","site_admin":false},"repo":{"id":6040,"node_id":"MDEwOlJlcG9zaXRvcnk2MDQw","name":"beanstalkd","full_name":"beanstalkd/beanstalkd","private":false,"owner":{"login":"beanstalkd","id":2703664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDM2NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2703664?v=4","gravatar_id":"","url":"https://api.github.com/users/beanstalkd","html_url":"https://github.com/beanstalkd","followers_url":"https://api.github.com/users/beanstalkd/followers","following_url":"https://api.github.com/users/beanstalkd/following{/other_user}","gists_url":"https://api.github.com/users/beanstalkd/gists{/gist_id}","starred_url":"https://api.github.com/users/beanstalkd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beanstalkd/subscriptions","organizations_url":"https://api.github.com/users/beanstalkd/orgs","repos_url":"https://api.github.com/users/beanstalkd/repos","events_url":"https://api.github.com/users/beanstalkd/events{/privacy}","received_events_url":"https://api.github.com/users/beanstalkd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/beanstalkd/beanstalkd","description":"Beanstalk is a simple, fast work queue.","fork":false,"url":"https://api.github.com/repos/beanstalkd/beanstalkd","forks_url":"https://api.github.com/repos/beanstalkd/beanstalkd/forks","keys_url":"https://api.github.com/repos/beanstalkd/beanstalkd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beanstalkd/beanstalkd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beanstalkd/beanstalkd/teams","hooks_url":"https://api.github.com/repos/beanstalkd/beanstalkd/hooks","issue_events_url":"https://api.github.com/repos/beanstalkd/beanstalkd/issues/events{/number}","events_url":"https://api.github.com/repos/beanstalkd/beanstalkd/events","assignees_url":"https://api.github.com/repos/beanstalkd/beanstalkd/assignees{/user}","branches_url":"https://api.github.com/repos/beanstalkd/beanstalkd/branches{/branch}","tags_url":"https://api.github.com/repos/beanstalkd/beanstalkd/tags","blobs_url":"https://api.github.com/repos/beanstalkd/beanstalkd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beanstalkd/beanstalkd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beanstalkd/beanstalkd/git/refs{/sha}","trees_url":"https://api.github.com/repos/beanstalkd/beanstalkd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beanstalkd/beanstalkd/statuses/{sha}","languages_url":"https://api.github.com/repos/beanstalkd/beanstalkd/languages","stargazers_url":"https://api.github.com/repos/beanstalkd/beanstalkd/stargazers","contributors_url":"https://api.github.com/repos/beanstalkd/beanstalkd/contributors","subscribers_url":"https://api.github.com/repos/beanstalkd/beanstalkd/subscribers","subscription_url":"https://api.github.com/repos/beanstalkd/beanstalkd/subscription","commits_url":"https://api.github.com/repos/beanstalkd/beanstalkd/commits{/sha}","git_commits_url":"https://api.github.com/repos/beanstalkd/beanstalkd/git/commits{/sha}","comments_url":"https://api.github.com/repos/beanstalkd/beanstalkd/comments{/number}","issue_comment_url":"https://api.github.com/repos/beanstalkd/beanstalkd/issues/comments{/number}","contents_url":"https://api.github.com/repos/beanstalkd/beanstalkd/contents/{+path}","compare_url":"https://api.github.com/repos/beanstalkd/beanstalkd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beanstalkd/beanstalkd/merges","archive_url":"https://api.github.com/repos/beanstalkd/beanstalkd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beanstalkd/beanstalkd/downloads","issues_url":"https://api.github.com/repos/beanstalkd/beanstalkd/issues{/number}","pulls_url":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls{/number}","milestones_url":"https://api.github.com/repos/beanstalkd/beanstalkd/milestones{/number}","notifications_url":"https://api.github.com/repos/beanstalkd/beanstalkd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beanstalkd/beanstalkd/labels{/name}","releases_url":"https://api.github.com/repos/beanstalkd/beanstalkd/releases{/id}","deployments_url":"https://api.github.com/repos/beanstalkd/beanstalkd/deployments","created_at":"2008-03-31T20:20:41Z","updated_at":"2019-08-04T09:16:40Z","pushed_at":"2019-08-04T16:05:29Z","git_url":"git://github.com/beanstalkd/beanstalkd.git","ssh_url":"git@github.com:beanstalkd/beanstalkd.git","clone_url":"https://github.com/beanstalkd/beanstalkd.git","svn_url":"https://github.com/beanstalkd/beanstalkd","homepage":"https://beanstalkd.github.io/","size":1220,"stargazers_count":5173,"watchers_count":5173,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":754,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":754,"open_issues":54,"watchers":5173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/522"},"html":{"href":"https://github.com/beanstalkd/beanstalkd/pull/522"},"issue":{"href":"https://api.github.com/repos/beanstalkd/beanstalkd/issues/522"},"comments":{"href":"https://api.github.com/repos/beanstalkd/beanstalkd/issues/522/comments"},"review_comments":{"href":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/522/comments"},"review_comment":{"href":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/beanstalkd/beanstalkd/pulls/522/commits"},"statuses":{"href":"https://api.github.com/repos/beanstalkd/beanstalkd/statuses/2ee2ba52fdc2d9275f38109c487c54b2b4b7b579"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ysmolsky"}}