{"action":"created","issue":{"url":"https://api.github.com/repos/Agoric/agoric-sdk/issues/389","repository_url":"https://api.github.com/repos/Agoric/agoric-sdk","labels_url":"https://api.github.com/repos/Agoric/agoric-sdk/issues/389/labels{/name}","comments_url":"https://api.github.com/repos/Agoric/agoric-sdk/issues/389/comments","events_url":"https://api.github.com/repos/Agoric/agoric-sdk/issues/389/events","html_url":"https://github.com/Agoric/agoric-sdk/pull/389","id":547530968,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxMDAyMzQ3","number":389,"title":"[ERTP] Move away from generators and use layer-cake instead for makeMint configuration","user":{"login":"DavidBruant","id":165829,"node_id":"MDQ6VXNlcjE2NTgyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/165829?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidBruant","html_url":"https://github.com/DavidBruant","followers_url":"https://api.github.com/users/DavidBruant/followers","following_url":"https://api.github.com/users/DavidBruant/following{/other_user}","gists_url":"https://api.github.com/users/DavidBruant/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidBruant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidBruant/subscriptions","organizations_url":"https://api.github.com/users/DavidBruant/orgs","repos_url":"https://api.github.com/users/DavidBruant/repos","events_url":"https://api.github.com/users/DavidBruant/events{/privacy}","received_events_url":"https://api.github.com/users/DavidBruant/received_events","type":"User","site_admin":false},"labels":[{"id":1708565823,"node_id":"MDU6TGFiZWwxNzA4NTY1ODIz","url":"https://api.github.com/repos/Agoric/agoric-sdk/labels/ERTP","name":"ERTP","color":"42119e","default":false,"description":"package: ERTP"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Agoric/agoric-sdk/milestones/1","html_url":"https://github.com/Agoric/agoric-sdk/milestone/1","labels_url":"https://api.github.com/repos/Agoric/agoric-sdk/milestones/1/labels","id":4980155,"node_id":"MDk6TWlsZXN0b25lNDk4MDE1NQ==","number":1,"title":"ERTP 0.3.0","description":null,"creator":{"login":"katelynsills","id":2441069,"node_id":"MDQ6VXNlcjI0NDEwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2441069?v=4","gravatar_id":"","url":"https://api.github.com/users/katelynsills","html_url":"https://github.com/katelynsills","followers_url":"https://api.github.com/users/katelynsills/followers","following_url":"https://api.github.com/users/katelynsills/following{/other_user}","gists_url":"https://api.github.com/users/katelynsills/gists{/gist_id}","starred_url":"https://api.github.com/users/katelynsills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katelynsills/subscriptions","organizations_url":"https://api.github.com/users/katelynsills/orgs","repos_url":"https://api.github.com/users/katelynsills/repos","events_url":"https://api.github.com/users/katelynsills/events{/privacy}","received_events_url":"https://api.github.com/users/katelynsills/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":2,"state":"open","created_at":"2020-01-07T00:57:15Z","updated_at":"2020-01-10T19:44:39Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2020-01-09T14:59:13Z","updated_at":"2020-01-10T19:47:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Agoric/agoric-sdk/pulls/389","html_url":"https://github.com/Agoric/agoric-sdk/pull/389","diff_url":"https://github.com/Agoric/agoric-sdk/pull/389.diff","patch_url":"https://github.com/Agoric/agoric-sdk/pull/389.patch"},"body":"Plan of the PR is:\r\n- [x] change relevant ERTP tests + add tests\r\n- [x] use trait layer-cake as dependency\r\n- [x] change makeMint code to get rid of generators and use layer-cake instead\r\n    - [x] modify makeMint tests to make sure they pass again\r\n    - [x] run all tests to see what breaks and fix accordingly\r\n    \r\n\r\nFixes #375 "},"comment":{"url":"https://api.github.com/repos/Agoric/agoric-sdk/issues/comments/573179691","html_url":"https://github.com/Agoric/agoric-sdk/pull/389#issuecomment-573179691","issue_url":"https://api.github.com/repos/Agoric/agoric-sdk/issues/389","id":573179691,"node_id":"MDEyOklzc3VlQ29tbWVudDU3MzE3OTY5MQ==","user":{"login":"katelynsills","id":2441069,"node_id":"MDQ6VXNlcjI0NDEwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2441069?v=4","gravatar_id":"","url":"https://api.github.com/users/katelynsills","html_url":"https://github.com/katelynsills","followers_url":"https://api.github.com/users/katelynsills/followers","following_url":"https://api.github.com/users/katelynsills/following{/other_user}","gists_url":"https://api.github.com/users/katelynsills/gists{/gist_id}","starred_url":"https://api.github.com/users/katelynsills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katelynsills/subscriptions","organizations_url":"https://api.github.com/users/katelynsills/orgs","repos_url":"https://api.github.com/users/katelynsills/repos","events_url":"https://api.github.com/users/katelynsills/events{/privacy}","received_events_url":"https://api.github.com/users/katelynsills/received_events","type":"User","site_admin":false},"created_at":"2020-01-10T19:47:08Z","updated_at":"2020-01-10T19:47:08Z","author_association":"MEMBER","body":"Ok, great. I'll be working with Mark to make layer-cake an npm package today. \r\n\r\nI'm going to try to something new when it comes to this PR. Rather than trying to make sure that our documentation and our references are correct for each breaking change (and this PR would be a breaking change), I'm consolidating the breaking changes into release branches such that we can run through a checklist for each release rather than each PR. This PR will be part of ERTP v0.3.0, so I will create an empty branch off master for ertp-v0.3.0 and make that branch the base of this PR. "}}
{"actor":{"display_login":"katelynsills"}}