{"action":"created","issue":{"url":"https://api.github.com/repos/line/armeria/issues/1655","repository_url":"https://api.github.com/repos/line/armeria","labels_url":"https://api.github.com/repos/line/armeria/issues/1655/labels{/name}","comments_url":"https://api.github.com/repos/line/armeria/issues/1655/comments","events_url":"https://api.github.com/repos/line/armeria/issues/1655/events","html_url":"https://github.com/line/armeria/issues/1655","id":419860218,"node_id":"MDU6SXNzdWU0MTk4NjAyMTg=","number":1655,"title":"HttpFileService could provide more options related to trailing slash","user":{"login":"anuraaga","id":198344,"node_id":"MDQ6VXNlcjE5ODM0NA==","avatar_url":"https://avatars0.githubusercontent.com/u/198344?v=4","gravatar_id":"","url":"https://api.github.com/users/anuraaga","html_url":"https://github.com/anuraaga","followers_url":"https://api.github.com/users/anuraaga/followers","following_url":"https://api.github.com/users/anuraaga/following{/other_user}","gists_url":"https://api.github.com/users/anuraaga/gists{/gist_id}","starred_url":"https://api.github.com/users/anuraaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuraaga/subscriptions","organizations_url":"https://api.github.com/users/anuraaga/orgs","repos_url":"https://api.github.com/users/anuraaga/repos","events_url":"https://api.github.com/users/anuraaga/events{/privacy}","received_events_url":"https://api.github.com/users/anuraaga/received_events","type":"User","site_admin":false},"labels":[{"id":287373881,"node_id":"MDU6TGFiZWwyODczNzM4ODE=","url":"https://api.github.com/repos/line/armeria/labels/new-feature","name":"new-feature","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-03-12T08:35:33Z","updated_at":"2019-05-26T23:47:25Z","closed_at":null,"author_association":"COLLABORATOR","body":"I was trying to clean up code using the new file service capabilities (removing hacky path mapping to redirect everything to index.html for example) but found I can't remove all my hacks since we use \"clean URLs\" without a trailing slash to read index.html for that page. The current `HttpFileService` will read index.html for requests that end with `/` but not otherwise. Adding an option to HttpFileServiceBuilder that allows URLs without an extension to have slash added before resolving the file would make this simpler.\r\n\r\nFor reference, firebase's related setting\r\nhttps://firebase.google.com/docs/hosting/full-config#control_trailing_slashes"},"comment":{"url":"https://api.github.com/repos/line/armeria/issues/comments/496040868","html_url":"https://github.com/line/armeria/issues/1655#issuecomment-496040868","issue_url":"https://api.github.com/repos/line/armeria/issues/1655","id":496040868,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5NjA0MDg2OA==","user":{"login":"trustin","id":173918,"node_id":"MDQ6VXNlcjE3MzkxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"created_at":"2019-05-26T23:47:25Z","updated_at":"2019-05-26T23:47:25Z","author_association":"MEMBER","body":"@anuraaga I didn't think much about redirection, but `HttpServerHandler` also makes use of redirection when received a path that does not end with slash:\r\n\r\nhttps://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/server/HttpServerHandler.java#L461-L483\r\n\r\nI guess I just wanted to make them consistent, but I think we can change that if other servers behave differently."}}
{"actor":{"display_login":"trustin"}}