{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/8322","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/8322/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/8322/comments","events_url":"https://api.github.com/repos/apache/flink/issues/8322/events","html_url":"https://github.com/apache/flink/pull/8322","id":438767629,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NzIyNzA1","number":8322,"title":"[FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure","user":{"login":"yanghua","id":2283778,"node_id":"MDQ6VXNlcjIyODM3Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2283778?v=4","gravatar_id":"","url":"https://api.github.com/users/yanghua","html_url":"https://github.com/yanghua","followers_url":"https://api.github.com/users/yanghua/followers","following_url":"https://api.github.com/users/yanghua/following{/other_user}","gists_url":"https://api.github.com/users/yanghua/gists{/gist_id}","starred_url":"https://api.github.com/users/yanghua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanghua/subscriptions","organizations_url":"https://api.github.com/users/yanghua/orgs","repos_url":"https://api.github.com/users/yanghua/repos","events_url":"https://api.github.com/users/yanghua/events{/privacy}","received_events_url":"https://api.github.com/users/yanghua/received_events","type":"User","site_admin":false},"labels":[{"id":1273376312,"node_id":"MDU6TGFiZWwxMjczMzc2MzEy","url":"https://api.github.com/repos/apache/flink/labels/component=Runtime/Checkpointing","name":"component=Runtime/Checkpointing","color":"175fb7","default":false},{"id":1244454690,"node_id":"MDU6TGFiZWwxMjQ0NDU0Njkw","url":"https://api.github.com/repos/apache/flink/labels/review=description?","name":"review=description?","color":"bcf5db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2019-04-30T13:04:56Z","updated_at":"2019-05-25T12:35:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/8322","html_url":"https://github.com/apache/flink/pull/8322","diff_url":"https://github.com/apache/flink/pull/8322.diff","patch_url":"https://github.com/apache/flink/pull/8322.patch"},"body":"## What is the purpose of the change\r\n\r\n*This pull request introduces a CheckpointFailureManager to centralized manage checkpoint failure*\r\n\r\n## Brief change log\r\n\r\n  - *Introduce a CheckpointFailureManager to centralized manage checkpoint failure*\r\n  - *Add a test case for CheckpointFailureManager*\r\n\r\n## Verifying this change\r\n\r\nThis change is already covered by existing tests, such as *CheckpointFailureManagerTest*.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (yes / **no**)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)\r\n  - The serializers: (yes / **no** / don't know)\r\n  - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)\r\n  - The S3 file system connector: (yes / **no** / don't know)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (yes / **no**)\r\n  - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)\r\n"},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/495915181","html_url":"https://github.com/apache/flink/pull/8322#issuecomment-495915181","issue_url":"https://api.github.com/repos/apache/flink/issues/8322","id":495915181,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5NTkxNTE4MQ==","user":{"login":"yanghua","id":2283778,"node_id":"MDQ6VXNlcjIyODM3Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2283778?v=4","gravatar_id":"","url":"https://api.github.com/users/yanghua","html_url":"https://github.com/yanghua","followers_url":"https://api.github.com/users/yanghua/followers","following_url":"https://api.github.com/users/yanghua/following{/other_user}","gists_url":"https://api.github.com/users/yanghua/gists{/gist_id}","starred_url":"https://api.github.com/users/yanghua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanghua/subscriptions","organizations_url":"https://api.github.com/users/yanghua/orgs","repos_url":"https://api.github.com/users/yanghua/repos","events_url":"https://api.github.com/users/yanghua/events{/privacy}","received_events_url":"https://api.github.com/users/yanghua/received_events","type":"User","site_admin":false},"created_at":"2019-05-25T12:35:50Z","updated_at":"2019-05-25T12:35:50Z","author_association":"CONTRIBUTOR","body":"Hi @StefanRRichter I understand what you mean and have given a reply. I think this PR has a relationship with FLINK-11662, but there is no dependency. If FLINK-11662 can be completed before this PR, it will make the CheckpointFailureManager looks better. But if it is resolved after this PR, it will not affect the semantics of this PR. I think the semantics of this PR is: tolerate failure in the situation we have controlled, and the current unhandled exception is not tolerated. In addition, the failure of the job caused by FLINK-11662 will cause the entire job to start again.\r\n\r\nIsn't the introduction of `CheckpointFailureManager` so that it can handle `CheckpointFailureReason` better? In fact, `CheckpointFailureReason` is a change point (it may increase because maybe there are other issues like FLINK-11662 we do not find or track them, or it may decrease in the future), we encapsulate its counting logic in the `handleCheckpointException` to change their counting logic in the future."}}
{"actor":{"display_login":"yanghua"}}