{"action":"created","comment":{"url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/comments/322604527","pull_request_review_id":285971794,"id":322604527,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMjYwNDUyNw==","diff_hunk":"@@ -217,6 +217,21 @@ namespace graphene { namespace chain {\n           */\n          fc::signal<void(const vector<object_id_type>&, const vector<const object*>&, const flat_set<account_id_type>&)>  removed_objects;\n \n+         /**\n+          * Emitted after the calculation of the voting_stake (occurs in the maintenance interval)\n+          */\n+         fc::signal<void(const account_object&, const account_object&, const uint64_t)> on_voting_stake_calculated;","path":"libraries/chain/include/graphene/chain/database.hpp","position":7,"original_position":7,"commit_id":"47861c97790f284e9c8b1ce069e8d5f53049ee3f","original_commit_id":"47861c97790f284e9c8b1ce069e8d5f53049ee3f","user":{"login":"Dimfred","id":29997904,"node_id":"MDQ6VXNlcjI5OTk3OTA0","avatar_url":"https://avatars1.githubusercontent.com/u/29997904?v=4","gravatar_id":"","url":"https://api.github.com/users/Dimfred","html_url":"https://github.com/Dimfred","followers_url":"https://api.github.com/users/Dimfred/followers","following_url":"https://api.github.com/users/Dimfred/following{/other_user}","gists_url":"https://api.github.com/users/Dimfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Dimfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dimfred/subscriptions","organizations_url":"https://api.github.com/users/Dimfred/orgs","repos_url":"https://api.github.com/users/Dimfred/repos","events_url":"https://api.github.com/users/Dimfred/events{/privacy}","received_events_url":"https://api.github.com/users/Dimfred/received_events","type":"User","site_admin":false},"body":"I need all the data to properly feed the plugin, so AFAIK there is no way to avoid this. Everything is performed inside the `vote_tally_helper` and nothing is given outside. \r\n\r\nWhat exactly do you don't like? Is the signal signature to specific? \r\n\r\nTo make it more generic I could switch the emission signature to emit an object with the data. This would make it extensible. It would be up to the signal receiver to use the data or not.","created_at":"2019-09-10T08:06:24Z","updated_at":"2019-09-10T08:06:24Z","html_url":"https://github.com/bitshares/bitshares-core/pull/1983#discussion_r322604527","pull_request_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1983","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/comments/322604527"},"html":{"href":"https://github.com/bitshares/bitshares-core/pull/1983#discussion_r322604527"},"pull_request":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1983"}},"in_reply_to_id":321997934},"pull_request":{"url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1983","id":315183709,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1MTgzNzA5","html_url":"https://github.com/bitshares/bitshares-core/pull/1983","diff_url":"https://github.com/bitshares/bitshares-core/pull/1983.diff","patch_url":"https://github.com/bitshares/bitshares-core/pull/1983.patch","issue_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/1983","number":1983,"state":"open","locked":false,"title":"Feature/es voting stat plugin","user":{"login":"Dimfred","id":29997904,"node_id":"MDQ6VXNlcjI5OTk3OTA0","avatar_url":"https://avatars1.githubusercontent.com/u/29997904?v=4","gravatar_id":"","url":"https://api.github.com/users/Dimfred","html_url":"https://github.com/Dimfred","followers_url":"https://api.github.com/users/Dimfred/followers","following_url":"https://api.github.com/users/Dimfred/following{/other_user}","gists_url":"https://api.github.com/users/Dimfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Dimfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dimfred/subscriptions","organizations_url":"https://api.github.com/users/Dimfred/orgs","repos_url":"https://api.github.com/users/Dimfred/repos","events_url":"https://api.github.com/users/Dimfred/events{/privacy}","received_events_url":"https://api.github.com/users/Dimfred/received_events","type":"User","site_admin":false},"body":"Sry for the last PR (#1971), here is now the clean one.\r\n\r\nLike said, still not fully mature.","created_at":"2019-09-07T10:02:18Z","updated_at":"2019-09-10T08:06:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccf5697e202af645057b8347e9d832f4a7d2d02f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/bitshares/bitshares-core/milestones/31","html_url":"https://github.com/bitshares/bitshares-core/milestone/31","labels_url":"https://api.github.com/repos/bitshares/bitshares-core/milestones/31/labels","id":4555071,"node_id":"MDk6TWlsZXN0b25lNDU1NTA3MQ==","number":31,"title":"4.1.0 - Feature Release","description":"temp","creator":{"login":"ryanRfox","id":13419165,"node_id":"MDQ6VXNlcjEzNDE5MTY1","avatar_url":"https://avatars1.githubusercontent.com/u/13419165?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanRfox","html_url":"https://github.com/ryanRfox","followers_url":"https://api.github.com/users/ryanRfox/followers","following_url":"https://api.github.com/users/ryanRfox/following{/other_user}","gists_url":"https://api.github.com/users/ryanRfox/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanRfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanRfox/subscriptions","organizations_url":"https://api.github.com/users/ryanRfox/orgs","repos_url":"https://api.github.com/users/ryanRfox/repos","events_url":"https://api.github.com/users/ryanRfox/events{/privacy}","received_events_url":"https://api.github.com/users/ryanRfox/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":15,"state":"open","created_at":"2019-08-07T12:13:41Z","updated_at":"2019-09-09T19:54:15Z","due_on":"2019-10-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1983/commits","review_comments_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1983/comments","review_comment_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/1983/comments","statuses_url":"https://api.github.com/repos/bitshares/bitshares-core/statuses/47861c97790f284e9c8b1ce069e8d5f53049ee3f","head":{"label":"blockchainprojects:feature/es-voting-stat-plugin-clean","ref":"feature/es-voting-stat-plugin-clean","sha":"47861c97790f284e9c8b1ce069e8d5f53049ee3f","user":{"login":"blockchainprojects","id":33057493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDU3NDkz","avatar_url":"https://avatars0.githubusercontent.com/u/33057493?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchainprojects","html_url":"https://github.com/blockchainprojects","followers_url":"https://api.github.com/users/blockchainprojects/followers","following_url":"https://api.github.com/users/blockchainprojects/following{/other_user}","gists_url":"https://api.github.com/users/blockchainprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchainprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchainprojects/subscriptions","organizations_url":"https://api.github.com/users/blockchainprojects/orgs","repos_url":"https://api.github.com/users/blockchainprojects/repos","events_url":"https://api.github.com/users/blockchainprojects/events{/privacy}","received_events_url":"https://api.github.com/users/blockchainprojects/received_events","type":"Organization","site_admin":false},"repo":{"id":154283753,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQyODM3NTM=","name":"bitshares-core","full_name":"blockchainprojects/bitshares-core","private":false,"owner":{"login":"blockchainprojects","id":33057493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDU3NDkz","avatar_url":"https://avatars0.githubusercontent.com/u/33057493?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchainprojects","html_url":"https://github.com/blockchainprojects","followers_url":"https://api.github.com/users/blockchainprojects/followers","following_url":"https://api.github.com/users/blockchainprojects/following{/other_user}","gists_url":"https://api.github.com/users/blockchainprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchainprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchainprojects/subscriptions","organizations_url":"https://api.github.com/users/blockchainprojects/orgs","repos_url":"https://api.github.com/users/blockchainprojects/repos","events_url":"https://api.github.com/users/blockchainprojects/events{/privacy}","received_events_url":"https://api.github.com/users/blockchainprojects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/blockchainprojects/bitshares-core","description":"BitShares Blockchain implementation and command-line interface","fork":true,"url":"https://api.github.com/repos/blockchainprojects/bitshares-core","forks_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/forks","keys_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/teams","hooks_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/hooks","issue_events_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/issues/events{/number}","events_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/events","assignees_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/assignees{/user}","branches_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/branches{/branch}","tags_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/tags","blobs_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/languages","stargazers_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/stargazers","contributors_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/contributors","subscribers_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/subscribers","subscription_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/subscription","commits_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/contents/{+path}","compare_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/merges","archive_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/downloads","issues_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/issues{/number}","pulls_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/labels{/name}","releases_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/releases{/id}","deployments_url":"https://api.github.com/repos/blockchainprojects/bitshares-core/deployments","created_at":"2018-10-23T07:36:18Z","updated_at":"2019-01-10T15:47:12Z","pushed_at":"2019-09-07T10:05:21Z","git_url":"git://github.com/blockchainprojects/bitshares-core.git","ssh_url":"git@github.com:blockchainprojects/bitshares-core.git","clone_url":"https://github.com/blockchainprojects/bitshares-core.git","svn_url":"https://github.com/blockchainprojects/bitshares-core","homepage":"https://bitshares.org/","size":24959,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"bitshares:develop","ref":"develop","sha":"ee588197f498f07480b94f120af948230c94faeb","user":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"repo":{"id":44123252,"node_id":"MDEwOlJlcG9zaXRvcnk0NDEyMzI1Mg==","name":"bitshares-core","full_name":"bitshares/bitshares-core","private":false,"owner":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitshares/bitshares-core","description":"BitShares Blockchain implementation and command-line interface","fork":false,"url":"https://api.github.com/repos/bitshares/bitshares-core","forks_url":"https://api.github.com/repos/bitshares/bitshares-core/forks","keys_url":"https://api.github.com/repos/bitshares/bitshares-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitshares/bitshares-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitshares/bitshares-core/teams","hooks_url":"https://api.github.com/repos/bitshares/bitshares-core/hooks","issue_events_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/events{/number}","events_url":"https://api.github.com/repos/bitshares/bitshares-core/events","assignees_url":"https://api.github.com/repos/bitshares/bitshares-core/assignees{/user}","branches_url":"https://api.github.com/repos/bitshares/bitshares-core/branches{/branch}","tags_url":"https://api.github.com/repos/bitshares/bitshares-core/tags","blobs_url":"https://api.github.com/repos/bitshares/bitshares-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitshares/bitshares-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitshares/bitshares-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitshares/bitshares-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitshares/bitshares-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bitshares/bitshares-core/languages","stargazers_url":"https://api.github.com/repos/bitshares/bitshares-core/stargazers","contributors_url":"https://api.github.com/repos/bitshares/bitshares-core/contributors","subscribers_url":"https://api.github.com/repos/bitshares/bitshares-core/subscribers","subscription_url":"https://api.github.com/repos/bitshares/bitshares-core/subscription","commits_url":"https://api.github.com/repos/bitshares/bitshares-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitshares/bitshares-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitshares/bitshares-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitshares/bitshares-core/contents/{+path}","compare_url":"https://api.github.com/repos/bitshares/bitshares-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitshares/bitshares-core/merges","archive_url":"https://api.github.com/repos/bitshares/bitshares-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitshares/bitshares-core/downloads","issues_url":"https://api.github.com/repos/bitshares/bitshares-core/issues{/number}","pulls_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bitshares/bitshares-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bitshares/bitshares-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitshares/bitshares-core/labels{/name}","releases_url":"https://api.github.com/repos/bitshares/bitshares-core/releases{/id}","deployments_url":"https://api.github.com/repos/bitshares/bitshares-core/deployments","created_at":"2015-10-12T17:36:04Z","updated_at":"2019-09-09T08:41:54Z","pushed_at":"2019-09-09T13:47:51Z","git_url":"git://github.com/bitshares/bitshares-core.git","ssh_url":"git@github.com:bitshares/bitshares-core.git","clone_url":"https://github.com/bitshares/bitshares-core.git","svn_url":"https://github.com/bitshares/bitshares-core","homepage":"https://bitshares.org/","size":24861,"stargazers_count":1039,"watchers_count":1039,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":574,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":235,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":574,"open_issues":235,"watchers":1039,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1983"},"html":{"href":"https://github.com/bitshares/bitshares-core/pull/1983"},"issue":{"href":"https://api.github.com/repos/bitshares/bitshares-core/issues/1983"},"comments":{"href":"https://api.github.com/repos/bitshares/bitshares-core/issues/1983/comments"},"review_comments":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1983/comments"},"review_comment":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/1983/commits"},"statuses":{"href":"https://api.github.com/repos/bitshares/bitshares-core/statuses/47861c97790f284e9c8b1ce069e8d5f53049ee3f"}},"author_association":"NONE"}}
{"actor":{"display_login":"Dimfred"}}