{"action":"created","issue":{"url":"https://api.github.com/repos/tikv/tikv/issues/4934","repository_url":"https://api.github.com/repos/tikv/tikv","labels_url":"https://api.github.com/repos/tikv/tikv/issues/4934/labels{/name}","comments_url":"https://api.github.com/repos/tikv/tikv/issues/4934/comments","events_url":"https://api.github.com/repos/tikv/tikv/issues/4934/events","html_url":"https://github.com/tikv/tikv/pull/4934","id":458084142,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5NzYzMDYw","number":4934,"title":"fix(scripts): disassemble using objdump with addresses","user":{"login":"shafreeck","id":418483,"node_id":"MDQ6VXNlcjQxODQ4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/418483?v=4","gravatar_id":"","url":"https://api.github.com/users/shafreeck","html_url":"https://github.com/shafreeck","followers_url":"https://api.github.com/users/shafreeck/followers","following_url":"https://api.github.com/users/shafreeck/following{/other_user}","gists_url":"https://api.github.com/users/shafreeck/gists{/gist_id}","starred_url":"https://api.github.com/users/shafreeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shafreeck/subscriptions","organizations_url":"https://api.github.com/users/shafreeck/orgs","repos_url":"https://api.github.com/users/shafreeck/repos","events_url":"https://api.github.com/users/shafreeck/events{/privacy}","received_events_url":"https://api.github.com/users/shafreeck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2019-06-19T15:34:00Z","updated_at":"2019-07-03T06:49:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tikv/tikv/pulls/4934","html_url":"https://github.com/tikv/tikv/pull/4934","diff_url":"https://github.com/tikv/tikv/pull/4934.diff","patch_url":"https://github.com/tikv/tikv/pull/4934.patch"},"body":"The `--disassemble=<sym>` option does not work on versions\r\nbelow 2.32. We change to disassemble with the start and\r\nstop addresses which work for common versions of `objdump`.\r\n\r\nSigned-off-by: Shafreeck Sea <shafreeck@gmail.com>\r\n\r\n<!--\r\nThank you for contributing to TiKV! Please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n## What have you changed? (mandatory)\r\n\r\ndisassemble with the start and stop addresses\r\n\r\nPlease **NOTE** that:\r\n- Do not assume reviewers understand the original issue\r\n\r\n## What are the type of the changes? (mandatory)\r\n\r\n- Bug fix (change which fixes an issue)\r\n\r\n\r\n## How has this PR been tested? (mandatory)\r\n\r\n- manually tested\r\n\r\n## Refer to a related PR or issue link (optional)\r\n\r\n- https://github.com/tikv/tikv/issues/4367\r\n- https://github.com/tikv/tikv/pull/4915\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/tikv/tikv/issues/comments/507964201","html_url":"https://github.com/tikv/tikv/pull/4934#issuecomment-507964201","issue_url":"https://api.github.com/repos/tikv/tikv/issues/4934","id":507964201,"node_id":"MDEyOklzc3VlQ29tbWVudDUwNzk2NDIwMQ==","user":{"login":"shafreeck","id":418483,"node_id":"MDQ6VXNlcjQxODQ4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/418483?v=4","gravatar_id":"","url":"https://api.github.com/users/shafreeck","html_url":"https://github.com/shafreeck","followers_url":"https://api.github.com/users/shafreeck/followers","following_url":"https://api.github.com/users/shafreeck/following{/other_user}","gists_url":"https://api.github.com/users/shafreeck/gists{/gist_id}","starred_url":"https://api.github.com/users/shafreeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shafreeck/subscriptions","organizations_url":"https://api.github.com/users/shafreeck/orgs","repos_url":"https://api.github.com/users/shafreeck/repos","events_url":"https://api.github.com/users/shafreeck/events{/privacy}","received_events_url":"https://api.github.com/users/shafreeck/received_events","type":"User","site_admin":false},"created_at":"2019-07-03T06:49:44Z","updated_at":"2019-07-03T06:49:44Z","author_association":"CONTRIBUTOR","body":"> Could we merge it?\r\n\r\nYeah, of course. You guys approved it. I thought you would merge it :)."}}
{"actor":{"display_login":"shafreeck"}}