{"action":"created","issue":{"url":"https://api.github.com/repos/qmk/qmk_firmware/issues/6516","repository_url":"https://api.github.com/repos/qmk/qmk_firmware","labels_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/6516/labels{/name}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/6516/comments","events_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/6516/events","html_url":"https://github.com/qmk/qmk_firmware/pull/6516","id":479203808,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2MTY3MTg0","number":6516,"title":"WS2812 support for ARM boards (planck rev6, preonic rev3)","user":{"login":"chax","id":632945,"node_id":"MDQ6VXNlcjYzMjk0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/632945?v=4","gravatar_id":"","url":"https://api.github.com/users/chax","html_url":"https://github.com/chax","followers_url":"https://api.github.com/users/chax/followers","following_url":"https://api.github.com/users/chax/following{/other_user}","gists_url":"https://api.github.com/users/chax/gists{/gist_id}","starred_url":"https://api.github.com/users/chax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chax/subscriptions","organizations_url":"https://api.github.com/users/chax/orgs","repos_url":"https://api.github.com/users/chax/repos","events_url":"https://api.github.com/users/chax/events{/privacy}","received_events_url":"https://api.github.com/users/chax/received_events","type":"User","site_admin":false},"labels":[{"id":155557981,"node_id":"MDU6TGFiZWwxNTU1NTc5ODE=","url":"https://api.github.com/repos/qmk/qmk_firmware/labels/duplicate","name":"duplicate","color":"cccccc","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2019-08-09T23:52:13Z","updated_at":"2019-08-12T07:00:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/6516","html_url":"https://github.com/qmk/qmk_firmware/pull/6516","diff_url":"https://github.com/qmk/qmk_firmware/pull/6516.diff","patch_url":"https://github.com/qmk/qmk_firmware/pull/6516.patch"},"body":"<!--- Provide a general summary of your changes in the title above. -->\r\n\r\n<!--- This template is entirely optional and can be removed, but is here to help both you and us. -->\r\n<!--- Anything on lines wrapped in comments like these will not show up in the final text. -->\r\n\r\n## Description\r\n\r\nThis is basically @jackhumbert's _arm_rgb_ branch, merged with latest _master_ branch, resolved all the conflicts and updated to use new format of rgb matrix (`led_config_t`).\r\n\r\nI've been using this branch for a long time with no problem on my planck. I've been regularly merging master and testing. In the end i created new clean branch and merged things in clean way.\r\nI've been waiting for this feature (along with a lot of others who I've seen have been asking for it) to become officially supported by qmk firmware and merged in master branch. Since last update on original branch was several months ago, i decided to merge in latest master and open PR.\r\n\r\nIf this is already planned to be implemented in another way or @jackhumbert plans to update his branch on his own, then you can close this PR.\r\n\r\n## Types of Changes\r\n\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply. -->\r\n- [ ] Core\r\n- [ ] Bugfix\r\n- [x] New feature\r\n- [x] Enhancement/optimization\r\n- [ ] Keyboard (addition or update)\r\n- [ ] Keymap/layout/userspace (addition or update)\r\n- [ ] Documentation\r\n\r\n## Issues Fixed or Closed by This PR\r\n\r\n* \r\n\r\n## Checklist\r\n\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have read the [**CONTRIBUTING** document](https://docs.qmk.fm/#/contributing).\r\n- [ ] I have added tests to cover my changes.\r\n- [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).\r\n  - Tested on planck rev6 with soldered WS2812 leds.\r\n  - Tested building preonic rev3 (unfortunatelly can't test because my preonic doesn't have soldered leds)\r\n  - Tested building few other boards to check if everything still builds without errors.\r\n"},"comment":{"url":"https://api.github.com/repos/qmk/qmk_firmware/issues/comments/520316709","html_url":"https://github.com/qmk/qmk_firmware/pull/6516#issuecomment-520316709","issue_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/6516","id":520316709,"node_id":"MDEyOklzc3VlQ29tbWVudDUyMDMxNjcwOQ==","user":{"login":"kratsyn","id":1988073,"node_id":"MDQ6VXNlcjE5ODgwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1988073?v=4","gravatar_id":"","url":"https://api.github.com/users/kratsyn","html_url":"https://github.com/kratsyn","followers_url":"https://api.github.com/users/kratsyn/followers","following_url":"https://api.github.com/users/kratsyn/following{/other_user}","gists_url":"https://api.github.com/users/kratsyn/gists{/gist_id}","starred_url":"https://api.github.com/users/kratsyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kratsyn/subscriptions","organizations_url":"https://api.github.com/users/kratsyn/orgs","repos_url":"https://api.github.com/users/kratsyn/repos","events_url":"https://api.github.com/users/kratsyn/events{/privacy}","received_events_url":"https://api.github.com/users/kratsyn/received_events","type":"User","site_admin":false},"created_at":"2019-08-12T07:00:08Z","updated_at":"2019-08-12T07:00:08Z","author_association":"NONE","body":"I'm not sure where to continue this discussion so i'll just reply back here.\r\n\r\nI've mocked up an example using my working branch [kratsyn:arm_ws2812-krats](https://github.com/kratsyn/qmk_firmware/tree/arm_ws2812-krats). \r\n\r\nThe only build failure is on hadron/ver3 and it appears that is because of how i have wrapped the configuration."}}
{"actor":{"display_login":"kratsyn"}}