{"action":"created","comment":{"url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/comments/258422927","pull_request_review_id":205685118,"id":258422927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODQyMjkyNw==","diff_hunk":"@@ -180,7 +180,7 @@ export function DesksFactory($q, api, preferencesService, userList, notify,\n                 return $q.when(self.userDesks);\n             }\n \n-            return this.fetchCurrentDeskId() // make sure there will be current desk\n+            return $q.when().then(this.fetchCurrentDeskId()) // make sure there will be current desk","path":"scripts/apps/desks/services/DesksFactory.js","position":null,"original_position":14,"commit_id":"dc2861672960de79c47c56fa5b5bfafff82078ce","original_commit_id":"2691fb450e25cf7eda1e38b2663ed3fc55868f6b","user":{"login":"GyanP","id":10600741,"node_id":"MDQ6VXNlcjEwNjAwNzQx","avatar_url":"https://avatars0.githubusercontent.com/u/10600741?v=4","gravatar_id":"","url":"https://api.github.com/users/GyanP","html_url":"https://github.com/GyanP","followers_url":"https://api.github.com/users/GyanP/followers","following_url":"https://api.github.com/users/GyanP/following{/other_user}","gists_url":"https://api.github.com/users/GyanP/gists{/gist_id}","starred_url":"https://api.github.com/users/GyanP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GyanP/subscriptions","organizations_url":"https://api.github.com/users/GyanP/orgs","repos_url":"https://api.github.com/users/GyanP/repos","events_url":"https://api.github.com/users/GyanP/events{/privacy}","received_events_url":"https://api.github.com/users/GyanP/received_events","type":"User","site_admin":false},"body":"`authoring.itemActions` function is called at more than 50 places across 15 files. So, every time the `self.userDesks` is required, that is why we need to keep it there. ","created_at":"2019-02-20T10:37:47Z","updated_at":"2019-02-20T10:37:47Z","html_url":"https://github.com/superdesk/superdesk-client-core/pull/2829#discussion_r258422927","pull_request_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2829","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/comments/258422927"},"html":{"href":"https://github.com/superdesk/superdesk-client-core/pull/2829#discussion_r258422927"},"pull_request":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2829"}},"in_reply_to_id":256459792},"pull_request":{"url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2829","id":251468440,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNDY4NDQw","html_url":"https://github.com/superdesk/superdesk-client-core/pull/2829","diff_url":"https://github.com/superdesk/superdesk-client-core/pull/2829.diff","patch_url":"https://github.com/superdesk/superdesk-client-core/pull/2829.patch","issue_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/2829","number":2829,"state":"open","locked":false,"title":"Fixed: Opening an item by pasting the URL does not show all actions. …","user":{"login":"GyanP","id":10600741,"node_id":"MDQ6VXNlcjEwNjAwNzQx","avatar_url":"https://avatars0.githubusercontent.com/u/10600741?v=4","gravatar_id":"","url":"https://api.github.com/users/GyanP","html_url":"https://github.com/GyanP","followers_url":"https://api.github.com/users/GyanP/followers","following_url":"https://api.github.com/users/GyanP/following{/other_user}","gists_url":"https://api.github.com/users/GyanP/gists{/gist_id}","starred_url":"https://api.github.com/users/GyanP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GyanP/subscriptions","organizations_url":"https://api.github.com/users/GyanP/orgs","repos_url":"https://api.github.com/users/GyanP/repos","events_url":"https://api.github.com/users/GyanP/events{/privacy}","received_events_url":"https://api.github.com/users/GyanP/received_events","type":"User","site_admin":false},"body":"…(SDESK-3919)","created_at":"2019-02-08T13:41:30Z","updated_at":"2019-02-20T10:37:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7fe40faabbfb4a3d6ca8e7fdcc3308593642f45","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/superdesk/superdesk-client-core/milestones/63","html_url":"https://github.com/superdesk/superdesk-client-core/milestone/63","labels_url":"https://api.github.com/repos/superdesk/superdesk-client-core/milestones/63/labels","id":3992134,"node_id":"MDk6TWlsZXN0b25lMzk5MjEzNA==","number":63,"title":"1.28.1","description":null,"creator":{"login":"petrjasek","id":179249,"node_id":"MDQ6VXNlcjE3OTI0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/179249?v=4","gravatar_id":"","url":"https://api.github.com/users/petrjasek","html_url":"https://github.com/petrjasek","followers_url":"https://api.github.com/users/petrjasek/followers","following_url":"https://api.github.com/users/petrjasek/following{/other_user}","gists_url":"https://api.github.com/users/petrjasek/gists{/gist_id}","starred_url":"https://api.github.com/users/petrjasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrjasek/subscriptions","organizations_url":"https://api.github.com/users/petrjasek/orgs","repos_url":"https://api.github.com/users/petrjasek/repos","events_url":"https://api.github.com/users/petrjasek/events{/privacy}","received_events_url":"https://api.github.com/users/petrjasek/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":27,"state":"open","created_at":"2019-01-22T08:51:38Z","updated_at":"2019-02-20T08:34:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2829/commits","review_comments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2829/comments","review_comment_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/2829/comments","statuses_url":"https://api.github.com/repos/superdesk/superdesk-client-core/statuses/dc2861672960de79c47c56fa5b5bfafff82078ce","head":{"label":"GyanP:SDESK-3919","ref":"SDESK-3919","sha":"dc2861672960de79c47c56fa5b5bfafff82078ce","user":{"login":"GyanP","id":10600741,"node_id":"MDQ6VXNlcjEwNjAwNzQx","avatar_url":"https://avatars0.githubusercontent.com/u/10600741?v=4","gravatar_id":"","url":"https://api.github.com/users/GyanP","html_url":"https://github.com/GyanP","followers_url":"https://api.github.com/users/GyanP/followers","following_url":"https://api.github.com/users/GyanP/following{/other_user}","gists_url":"https://api.github.com/users/GyanP/gists{/gist_id}","starred_url":"https://api.github.com/users/GyanP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GyanP/subscriptions","organizations_url":"https://api.github.com/users/GyanP/orgs","repos_url":"https://api.github.com/users/GyanP/repos","events_url":"https://api.github.com/users/GyanP/events{/privacy}","received_events_url":"https://api.github.com/users/GyanP/received_events","type":"User","site_admin":false},"repo":{"id":150074524,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwNzQ1MjQ=","name":"superdesk-client-core","full_name":"GyanP/superdesk-client-core","private":false,"owner":{"login":"GyanP","id":10600741,"node_id":"MDQ6VXNlcjEwNjAwNzQx","avatar_url":"https://avatars0.githubusercontent.com/u/10600741?v=4","gravatar_id":"","url":"https://api.github.com/users/GyanP","html_url":"https://github.com/GyanP","followers_url":"https://api.github.com/users/GyanP/followers","following_url":"https://api.github.com/users/GyanP/following{/other_user}","gists_url":"https://api.github.com/users/GyanP/gists{/gist_id}","starred_url":"https://api.github.com/users/GyanP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GyanP/subscriptions","organizations_url":"https://api.github.com/users/GyanP/orgs","repos_url":"https://api.github.com/users/GyanP/repos","events_url":"https://api.github.com/users/GyanP/events{/privacy}","received_events_url":"https://api.github.com/users/GyanP/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GyanP/superdesk-client-core","description":"Common client modules for superdesk apps.","fork":true,"url":"https://api.github.com/repos/GyanP/superdesk-client-core","forks_url":"https://api.github.com/repos/GyanP/superdesk-client-core/forks","keys_url":"https://api.github.com/repos/GyanP/superdesk-client-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GyanP/superdesk-client-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GyanP/superdesk-client-core/teams","hooks_url":"https://api.github.com/repos/GyanP/superdesk-client-core/hooks","issue_events_url":"https://api.github.com/repos/GyanP/superdesk-client-core/issues/events{/number}","events_url":"https://api.github.com/repos/GyanP/superdesk-client-core/events","assignees_url":"https://api.github.com/repos/GyanP/superdesk-client-core/assignees{/user}","branches_url":"https://api.github.com/repos/GyanP/superdesk-client-core/branches{/branch}","tags_url":"https://api.github.com/repos/GyanP/superdesk-client-core/tags","blobs_url":"https://api.github.com/repos/GyanP/superdesk-client-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GyanP/superdesk-client-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GyanP/superdesk-client-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/GyanP/superdesk-client-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GyanP/superdesk-client-core/statuses/{sha}","languages_url":"https://api.github.com/repos/GyanP/superdesk-client-core/languages","stargazers_url":"https://api.github.com/repos/GyanP/superdesk-client-core/stargazers","contributors_url":"https://api.github.com/repos/GyanP/superdesk-client-core/contributors","subscribers_url":"https://api.github.com/repos/GyanP/superdesk-client-core/subscribers","subscription_url":"https://api.github.com/repos/GyanP/superdesk-client-core/subscription","commits_url":"https://api.github.com/repos/GyanP/superdesk-client-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/GyanP/superdesk-client-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/GyanP/superdesk-client-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/GyanP/superdesk-client-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/GyanP/superdesk-client-core/contents/{+path}","compare_url":"https://api.github.com/repos/GyanP/superdesk-client-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GyanP/superdesk-client-core/merges","archive_url":"https://api.github.com/repos/GyanP/superdesk-client-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GyanP/superdesk-client-core/downloads","issues_url":"https://api.github.com/repos/GyanP/superdesk-client-core/issues{/number}","pulls_url":"https://api.github.com/repos/GyanP/superdesk-client-core/pulls{/number}","milestones_url":"https://api.github.com/repos/GyanP/superdesk-client-core/milestones{/number}","notifications_url":"https://api.github.com/repos/GyanP/superdesk-client-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GyanP/superdesk-client-core/labels{/name}","releases_url":"https://api.github.com/repos/GyanP/superdesk-client-core/releases{/id}","deployments_url":"https://api.github.com/repos/GyanP/superdesk-client-core/deployments","created_at":"2018-09-24T08:35:02Z","updated_at":"2019-02-18T06:06:05Z","pushed_at":"2019-02-20T10:00:29Z","git_url":"git://github.com/GyanP/superdesk-client-core.git","ssh_url":"git@github.com:GyanP/superdesk-client-core.git","clone_url":"https://github.com/GyanP/superdesk-client-core.git","svn_url":"https://github.com/GyanP/superdesk-client-core","homepage":"","size":17056,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superdesk:master","ref":"master","sha":"fc62cef948cbf2f9cb033c4469b9280e6fac02d8","user":{"login":"superdesk","id":5527298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MjcyOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5527298?v=4","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"repo":{"id":50631400,"node_id":"MDEwOlJlcG9zaXRvcnk1MDYzMTQwMA==","name":"superdesk-client-core","full_name":"superdesk/superdesk-client-core","private":false,"owner":{"login":"superdesk","id":5527298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MjcyOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5527298?v=4","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/superdesk/superdesk-client-core","description":"Common client modules for superdesk apps.","fork":false,"url":"https://api.github.com/repos/superdesk/superdesk-client-core","forks_url":"https://api.github.com/repos/superdesk/superdesk-client-core/forks","keys_url":"https://api.github.com/repos/superdesk/superdesk-client-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superdesk/superdesk-client-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superdesk/superdesk-client-core/teams","hooks_url":"https://api.github.com/repos/superdesk/superdesk-client-core/hooks","issue_events_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/events{/number}","events_url":"https://api.github.com/repos/superdesk/superdesk-client-core/events","assignees_url":"https://api.github.com/repos/superdesk/superdesk-client-core/assignees{/user}","branches_url":"https://api.github.com/repos/superdesk/superdesk-client-core/branches{/branch}","tags_url":"https://api.github.com/repos/superdesk/superdesk-client-core/tags","blobs_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superdesk/superdesk-client-core/statuses/{sha}","languages_url":"https://api.github.com/repos/superdesk/superdesk-client-core/languages","stargazers_url":"https://api.github.com/repos/superdesk/superdesk-client-core/stargazers","contributors_url":"https://api.github.com/repos/superdesk/superdesk-client-core/contributors","subscribers_url":"https://api.github.com/repos/superdesk/superdesk-client-core/subscribers","subscription_url":"https://api.github.com/repos/superdesk/superdesk-client-core/subscription","commits_url":"https://api.github.com/repos/superdesk/superdesk-client-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/superdesk/superdesk-client-core/contents/{+path}","compare_url":"https://api.github.com/repos/superdesk/superdesk-client-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superdesk/superdesk-client-core/merges","archive_url":"https://api.github.com/repos/superdesk/superdesk-client-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superdesk/superdesk-client-core/downloads","issues_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues{/number}","pulls_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls{/number}","milestones_url":"https://api.github.com/repos/superdesk/superdesk-client-core/milestones{/number}","notifications_url":"https://api.github.com/repos/superdesk/superdesk-client-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superdesk/superdesk-client-core/labels{/name}","releases_url":"https://api.github.com/repos/superdesk/superdesk-client-core/releases{/id}","deployments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/deployments","created_at":"2016-01-29T02:33:16Z","updated_at":"2019-02-20T05:09:22Z","pushed_at":"2019-02-20T10:00:31Z","git_url":"git://github.com/superdesk/superdesk-client-core.git","ssh_url":"git@github.com:superdesk/superdesk-client-core.git","clone_url":"https://github.com/superdesk/superdesk-client-core.git","svn_url":"https://github.com/superdesk/superdesk-client-core","homepage":"","size":17033,"stargazers_count":20,"watchers_count":20,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":61,"open_issues":9,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2829"},"html":{"href":"https://github.com/superdesk/superdesk-client-core/pull/2829"},"issue":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/2829"},"comments":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/2829/comments"},"review_comments":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2829/comments"},"review_comment":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/2829/commits"},"statuses":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/statuses/dc2861672960de79c47c56fa5b5bfafff82078ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"GyanP"}}