{"action":"created","comment":{"url":"https://api.github.com/repos/ezEngine/ezEngine/pulls/comments/314235640","pull_request_review_id":275336693,"id":314235640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDIzNTY0MA==","diff_hunk":"@@ -712,14 +712,58 @@ class EZ_FOUNDATION_DLL ezAutoGenVisScriptMsgSender : public ezPropertyAttribute\n   EZ_ADD_DYNAMIC_REFLECTION(ezAutoGenVisScriptMsgSender, ezPropertyAttribute);\n };\n \n-\n /// \\brief Attribute for ezMessages to instruct the visual script framework to automatically generate a node for handling this type of\n /// message\n class EZ_FOUNDATION_DLL ezAutoGenVisScriptMsgHandler : public ezPropertyAttribute\n {\n   EZ_ADD_DYNAMIC_REFLECTION(ezAutoGenVisScriptMsgHandler, ezPropertyAttribute);\n };\n \n+/// \\brief Attribute for ezMessages to instruct the visual script framework to automatically generate a node for handling this type of","path":"Code/Engine/Foundation/Reflection/Implementation/PropertyAttributes.h","position":12,"original_position":12,"commit_id":"12345086d4062ecaa901f1d267f2b6b0a0482fc7","original_commit_id":"12345086d4062ecaa901f1d267f2b6b0a0482fc7","user":{"login":"C-Core","id":9219412,"node_id":"MDQ6VXNlcjkyMTk0MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9219412?v=4","gravatar_id":"","url":"https://api.github.com/users/C-Core","html_url":"https://github.com/C-Core","followers_url":"https://api.github.com/users/C-Core/followers","following_url":"https://api.github.com/users/C-Core/following{/other_user}","gists_url":"https://api.github.com/users/C-Core/gists{/gist_id}","starred_url":"https://api.github.com/users/C-Core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C-Core/subscriptions","organizations_url":"https://api.github.com/users/C-Core/orgs","repos_url":"https://api.github.com/users/C-Core/repos","events_url":"https://api.github.com/users/C-Core/events{/privacy}","received_events_url":"https://api.github.com/users/C-Core/received_events","type":"User","site_admin":false},"body":"Copy paste comment","created_at":"2019-08-15T09:24:52Z","updated_at":"2019-08-15T09:46:58Z","html_url":"https://github.com/ezEngine/ezEngine/pull/79#discussion_r314235640","pull_request_url":"https://api.github.com/repos/ezEngine/ezEngine/pulls/79","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ezEngine/ezEngine/pulls/comments/314235640"},"html":{"href":"https://github.com/ezEngine/ezEngine/pull/79#discussion_r314235640"},"pull_request":{"href":"https://api.github.com/repos/ezEngine/ezEngine/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/ezEngine/ezEngine/pulls/79","id":307513017,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3NTEzMDE3","html_url":"https://github.com/ezEngine/ezEngine/pull/79","diff_url":"https://github.com/ezEngine/ezEngine/pull/79.diff","patch_url":"https://github.com/ezEngine/ezEngine/pull/79.patch","issue_url":"https://api.github.com/repos/ezEngine/ezEngine/issues/79","number":79,"state":"open","locked":false,"title":"Calling reflected functions from Visual Script","user":{"login":"jankrassnigg","id":6001174,"node_id":"MDQ6VXNlcjYwMDExNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6001174?v=4","gravatar_id":"","url":"https://api.github.com/users/jankrassnigg","html_url":"https://github.com/jankrassnigg","followers_url":"https://api.github.com/users/jankrassnigg/followers","following_url":"https://api.github.com/users/jankrassnigg/following{/other_user}","gists_url":"https://api.github.com/users/jankrassnigg/gists{/gist_id}","starred_url":"https://api.github.com/users/jankrassnigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jankrassnigg/subscriptions","organizations_url":"https://api.github.com/users/jankrassnigg/orgs","repos_url":"https://api.github.com/users/jankrassnigg/repos","events_url":"https://api.github.com/users/jankrassnigg/events{/privacy}","received_events_url":"https://api.github.com/users/jankrassnigg/received_events","type":"User","site_admin":false},"body":"PR for proof of concept review.\r\n\r\nCalling reflected functions now works from visual scripts. No messages involved, probably less runtime overhead in general, no macro syntax needed for exposing them, though it is not as easy to see on a component now, which functions are scriptable and which aren't. Could be added with some syntactic sugar, though.\r\n\r\nWorking:\r\n* Calling a function\r\n* passing parameters through input pins\r\n* setting parameter default values through node properties\r\n\r\nTODO:\r\n* setting up output pins\r\n* function return values\r\n* tagging function arguments as inout or out\r\n* returning out values to script output pins","created_at":"2019-08-14T21:56:25Z","updated_at":"2019-08-15T09:46:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de623b86ad1243106880f352df953b5bf37a4437","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ezEngine/ezEngine/pulls/79/commits","review_comments_url":"https://api.github.com/repos/ezEngine/ezEngine/pulls/79/comments","review_comment_url":"https://api.github.com/repos/ezEngine/ezEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezEngine/ezEngine/issues/79/comments","statuses_url":"https://api.github.com/repos/ezEngine/ezEngine/statuses/12345086d4062ecaa901f1d267f2b6b0a0482fc7","head":{"label":"ezEngine:user/jk/script-functions","ref":"user/jk/script-functions","sha":"12345086d4062ecaa901f1d267f2b6b0a0482fc7","user":{"login":"ezEngine","id":7082461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwODI0NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/7082461?v=4","gravatar_id":"","url":"https://api.github.com/users/ezEngine","html_url":"https://github.com/ezEngine","followers_url":"https://api.github.com/users/ezEngine/followers","following_url":"https://api.github.com/users/ezEngine/following{/other_user}","gists_url":"https://api.github.com/users/ezEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ezEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezEngine/subscriptions","organizations_url":"https://api.github.com/users/ezEngine/orgs","repos_url":"https://api.github.com/users/ezEngine/repos","events_url":"https://api.github.com/users/ezEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ezEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":18179848,"node_id":"MDEwOlJlcG9zaXRvcnkxODE3OTg0OA==","name":"ezEngine","full_name":"ezEngine/ezEngine","private":false,"owner":{"login":"ezEngine","id":7082461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwODI0NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/7082461?v=4","gravatar_id":"","url":"https://api.github.com/users/ezEngine","html_url":"https://github.com/ezEngine","followers_url":"https://api.github.com/users/ezEngine/followers","following_url":"https://api.github.com/users/ezEngine/following{/other_user}","gists_url":"https://api.github.com/users/ezEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ezEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezEngine/subscriptions","organizations_url":"https://api.github.com/users/ezEngine/orgs","repos_url":"https://api.github.com/users/ezEngine/repos","events_url":"https://api.github.com/users/ezEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ezEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ezEngine/ezEngine","description":"An open source game engine in active development","fork":false,"url":"https://api.github.com/repos/ezEngine/ezEngine","forks_url":"https://api.github.com/repos/ezEngine/ezEngine/forks","keys_url":"https://api.github.com/repos/ezEngine/ezEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezEngine/ezEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezEngine/ezEngine/teams","hooks_url":"https://api.github.com/repos/ezEngine/ezEngine/hooks","issue_events_url":"https://api.github.com/repos/ezEngine/ezEngine/issues/events{/number}","events_url":"https://api.github.com/repos/ezEngine/ezEngine/events","assignees_url":"https://api.github.com/repos/ezEngine/ezEngine/assignees{/user}","branches_url":"https://api.github.com/repos/ezEngine/ezEngine/branches{/branch}","tags_url":"https://api.github.com/repos/ezEngine/ezEngine/tags","blobs_url":"https://api.github.com/repos/ezEngine/ezEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezEngine/ezEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezEngine/ezEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezEngine/ezEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezEngine/ezEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/ezEngine/ezEngine/languages","stargazers_url":"https://api.github.com/repos/ezEngine/ezEngine/stargazers","contributors_url":"https://api.github.com/repos/ezEngine/ezEngine/contributors","subscribers_url":"https://api.github.com/repos/ezEngine/ezEngine/subscribers","subscription_url":"https://api.github.com/repos/ezEngine/ezEngine/subscription","commits_url":"https://api.github.com/repos/ezEngine/ezEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezEngine/ezEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezEngine/ezEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezEngine/ezEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezEngine/ezEngine/contents/{+path}","compare_url":"https://api.github.com/repos/ezEngine/ezEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezEngine/ezEngine/merges","archive_url":"https://api.github.com/repos/ezEngine/ezEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezEngine/ezEngine/downloads","issues_url":"https://api.github.com/repos/ezEngine/ezEngine/issues{/number}","pulls_url":"https://api.github.com/repos/ezEngine/ezEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/ezEngine/ezEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/ezEngine/ezEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezEngine/ezEngine/labels{/name}","releases_url":"https://api.github.com/repos/ezEngine/ezEngine/releases{/id}","deployments_url":"https://api.github.com/repos/ezEngine/ezEngine/deployments","created_at":"2014-03-27T15:02:16Z","updated_at":"2019-08-14T19:43:28Z","pushed_at":"2019-08-14T21:56:26Z","git_url":"git://github.com/ezEngine/ezEngine.git","ssh_url":"git@github.com:ezEngine/ezEngine.git","clone_url":"https://github.com/ezEngine/ezEngine.git","svn_url":"https://github.com/ezEngine/ezEngine","homepage":"","size":216436,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":4,"watchers":22,"default_branch":"dev"}},"base":{"label":"ezEngine:dev","ref":"dev","sha":"9812f8c1d11974b8922fa529dbdb3765dd34e594","user":{"login":"ezEngine","id":7082461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwODI0NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/7082461?v=4","gravatar_id":"","url":"https://api.github.com/users/ezEngine","html_url":"https://github.com/ezEngine","followers_url":"https://api.github.com/users/ezEngine/followers","following_url":"https://api.github.com/users/ezEngine/following{/other_user}","gists_url":"https://api.github.com/users/ezEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ezEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezEngine/subscriptions","organizations_url":"https://api.github.com/users/ezEngine/orgs","repos_url":"https://api.github.com/users/ezEngine/repos","events_url":"https://api.github.com/users/ezEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ezEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":18179848,"node_id":"MDEwOlJlcG9zaXRvcnkxODE3OTg0OA==","name":"ezEngine","full_name":"ezEngine/ezEngine","private":false,"owner":{"login":"ezEngine","id":7082461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwODI0NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/7082461?v=4","gravatar_id":"","url":"https://api.github.com/users/ezEngine","html_url":"https://github.com/ezEngine","followers_url":"https://api.github.com/users/ezEngine/followers","following_url":"https://api.github.com/users/ezEngine/following{/other_user}","gists_url":"https://api.github.com/users/ezEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ezEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezEngine/subscriptions","organizations_url":"https://api.github.com/users/ezEngine/orgs","repos_url":"https://api.github.com/users/ezEngine/repos","events_url":"https://api.github.com/users/ezEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ezEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ezEngine/ezEngine","description":"An open source game engine in active development","fork":false,"url":"https://api.github.com/repos/ezEngine/ezEngine","forks_url":"https://api.github.com/repos/ezEngine/ezEngine/forks","keys_url":"https://api.github.com/repos/ezEngine/ezEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezEngine/ezEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezEngine/ezEngine/teams","hooks_url":"https://api.github.com/repos/ezEngine/ezEngine/hooks","issue_events_url":"https://api.github.com/repos/ezEngine/ezEngine/issues/events{/number}","events_url":"https://api.github.com/repos/ezEngine/ezEngine/events","assignees_url":"https://api.github.com/repos/ezEngine/ezEngine/assignees{/user}","branches_url":"https://api.github.com/repos/ezEngine/ezEngine/branches{/branch}","tags_url":"https://api.github.com/repos/ezEngine/ezEngine/tags","blobs_url":"https://api.github.com/repos/ezEngine/ezEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezEngine/ezEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezEngine/ezEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezEngine/ezEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezEngine/ezEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/ezEngine/ezEngine/languages","stargazers_url":"https://api.github.com/repos/ezEngine/ezEngine/stargazers","contributors_url":"https://api.github.com/repos/ezEngine/ezEngine/contributors","subscribers_url":"https://api.github.com/repos/ezEngine/ezEngine/subscribers","subscription_url":"https://api.github.com/repos/ezEngine/ezEngine/subscription","commits_url":"https://api.github.com/repos/ezEngine/ezEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezEngine/ezEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezEngine/ezEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezEngine/ezEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezEngine/ezEngine/contents/{+path}","compare_url":"https://api.github.com/repos/ezEngine/ezEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezEngine/ezEngine/merges","archive_url":"https://api.github.com/repos/ezEngine/ezEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezEngine/ezEngine/downloads","issues_url":"https://api.github.com/repos/ezEngine/ezEngine/issues{/number}","pulls_url":"https://api.github.com/repos/ezEngine/ezEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/ezEngine/ezEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/ezEngine/ezEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezEngine/ezEngine/labels{/name}","releases_url":"https://api.github.com/repos/ezEngine/ezEngine/releases{/id}","deployments_url":"https://api.github.com/repos/ezEngine/ezEngine/deployments","created_at":"2014-03-27T15:02:16Z","updated_at":"2019-08-14T19:43:28Z","pushed_at":"2019-08-14T21:56:26Z","git_url":"git://github.com/ezEngine/ezEngine.git","ssh_url":"git@github.com:ezEngine/ezEngine.git","clone_url":"https://github.com/ezEngine/ezEngine.git","svn_url":"https://github.com/ezEngine/ezEngine","homepage":"","size":216436,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":4,"watchers":22,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/ezEngine/ezEngine/pulls/79"},"html":{"href":"https://github.com/ezEngine/ezEngine/pull/79"},"issue":{"href":"https://api.github.com/repos/ezEngine/ezEngine/issues/79"},"comments":{"href":"https://api.github.com/repos/ezEngine/ezEngine/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/ezEngine/ezEngine/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/ezEngine/ezEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezEngine/ezEngine/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/ezEngine/ezEngine/statuses/12345086d4062ecaa901f1d267f2b6b0a0482fc7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"C-Core"}}