{"action":"created","comment":{"url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/comments/314106274","pull_request_review_id":275178881,"id":314106274,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDEwNjI3NA==","diff_hunk":"@@ -81,29 +80,29 @@ fn client(\n \n fn server(\n     mut conn: TcpStream,\n-    min_minor: i32,\n-    max_minor: i32,\n-    exp_minor: Result<i32, ()>,\n+    min_version: Version,\n+    max_version: Version,\n+    exp_version: Result<Version, ()>,\n ) -> TlsResult<()> {","path":"mbedtls/tests/client_server.rs","position":57,"original_position":57,"commit_id":"97b9e31a39c41aa39e23e6670b7c41e04774b4e3","original_commit_id":"97b9e31a39c41aa39e23e6670b7c41e04774b4e3","user":{"login":"Goirad","id":20523291,"node_id":"MDQ6VXNlcjIwNTIzMjkx","avatar_url":"https://avatars3.githubusercontent.com/u/20523291?v=4","gravatar_id":"","url":"https://api.github.com/users/Goirad","html_url":"https://github.com/Goirad","followers_url":"https://api.github.com/users/Goirad/followers","following_url":"https://api.github.com/users/Goirad/following{/other_user}","gists_url":"https://api.github.com/users/Goirad/gists{/gist_id}","starred_url":"https://api.github.com/users/Goirad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Goirad/subscriptions","organizations_url":"https://api.github.com/users/Goirad/orgs","repos_url":"https://api.github.com/users/Goirad/repos","events_url":"https://api.github.com/users/Goirad/events{/privacy}","received_events_url":"https://api.github.com/users/Goirad/received_events","type":"User","site_admin":false},"body":"Why is the expected version passed as a result? It also seems to me like it is acting semantically as an `Option<Version>`. I see that it is like this since before this particular PR, but I'd still like to know.","created_at":"2019-08-14T22:12:34Z","updated_at":"2019-08-14T22:12:34Z","html_url":"https://github.com/fortanix/rust-mbedtls/pull/49#discussion_r314106274","pull_request_url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/49","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/comments/314106274"},"html":{"href":"https://github.com/fortanix/rust-mbedtls/pull/49#discussion_r314106274"},"pull_request":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/49","id":307465989,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3NDY1OTg5","html_url":"https://github.com/fortanix/rust-mbedtls/pull/49","diff_url":"https://github.com/fortanix/rust-mbedtls/pull/49.diff","patch_url":"https://github.com/fortanix/rust-mbedtls/pull/49.patch","issue_url":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/49","number":49,"state":"open","locked":false,"title":"Add Version enum for TLS","user":{"login":"jack-fortanix","id":45053604,"node_id":"MDQ6VXNlcjQ1MDUzNjA0","avatar_url":"https://avatars3.githubusercontent.com/u/45053604?v=4","gravatar_id":"","url":"https://api.github.com/users/jack-fortanix","html_url":"https://github.com/jack-fortanix","followers_url":"https://api.github.com/users/jack-fortanix/followers","following_url":"https://api.github.com/users/jack-fortanix/following{/other_user}","gists_url":"https://api.github.com/users/jack-fortanix/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-fortanix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-fortanix/subscriptions","organizations_url":"https://api.github.com/users/jack-fortanix/orgs","repos_url":"https://api.github.com/users/jack-fortanix/repos","events_url":"https://api.github.com/users/jack-fortanix/events{/privacy}","received_events_url":"https://api.github.com/users/jack-fortanix/received_events","type":"User","site_admin":false},"body":"Adapted from ced45e6c2e of internal version","created_at":"2019-08-14T19:27:41Z","updated_at":"2019-08-14T22:12:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f6c36de855da5f746dfe0a3643b67f540647dcd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jethrogb","id":1132307,"node_id":"MDQ6VXNlcjExMzIzMDc=","avatar_url":"https://avatars0.githubusercontent.com/u/1132307?v=4","gravatar_id":"","url":"https://api.github.com/users/jethrogb","html_url":"https://github.com/jethrogb","followers_url":"https://api.github.com/users/jethrogb/followers","following_url":"https://api.github.com/users/jethrogb/following{/other_user}","gists_url":"https://api.github.com/users/jethrogb/gists{/gist_id}","starred_url":"https://api.github.com/users/jethrogb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jethrogb/subscriptions","organizations_url":"https://api.github.com/users/jethrogb/orgs","repos_url":"https://api.github.com/users/jethrogb/repos","events_url":"https://api.github.com/users/jethrogb/events{/privacy}","received_events_url":"https://api.github.com/users/jethrogb/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/49/commits","review_comments_url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/49/comments","review_comment_url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/49/comments","statuses_url":"https://api.github.com/repos/fortanix/rust-mbedtls/statuses/97b9e31a39c41aa39e23e6670b7c41e04774b4e3","head":{"label":"jack-fortanix:jack/tls-version-enum","ref":"jack/tls-version-enum","sha":"97b9e31a39c41aa39e23e6670b7c41e04774b4e3","user":{"login":"jack-fortanix","id":45053604,"node_id":"MDQ6VXNlcjQ1MDUzNjA0","avatar_url":"https://avatars3.githubusercontent.com/u/45053604?v=4","gravatar_id":"","url":"https://api.github.com/users/jack-fortanix","html_url":"https://github.com/jack-fortanix","followers_url":"https://api.github.com/users/jack-fortanix/followers","following_url":"https://api.github.com/users/jack-fortanix/following{/other_user}","gists_url":"https://api.github.com/users/jack-fortanix/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-fortanix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-fortanix/subscriptions","organizations_url":"https://api.github.com/users/jack-fortanix/orgs","repos_url":"https://api.github.com/users/jack-fortanix/repos","events_url":"https://api.github.com/users/jack-fortanix/events{/privacy}","received_events_url":"https://api.github.com/users/jack-fortanix/received_events","type":"User","site_admin":false},"repo":{"id":166300578,"node_id":"MDEwOlJlcG9zaXRvcnkxNjYzMDA1Nzg=","name":"rust-mbedtls","full_name":"jack-fortanix/rust-mbedtls","private":false,"owner":{"login":"jack-fortanix","id":45053604,"node_id":"MDQ6VXNlcjQ1MDUzNjA0","avatar_url":"https://avatars3.githubusercontent.com/u/45053604?v=4","gravatar_id":"","url":"https://api.github.com/users/jack-fortanix","html_url":"https://github.com/jack-fortanix","followers_url":"https://api.github.com/users/jack-fortanix/followers","following_url":"https://api.github.com/users/jack-fortanix/following{/other_user}","gists_url":"https://api.github.com/users/jack-fortanix/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-fortanix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-fortanix/subscriptions","organizations_url":"https://api.github.com/users/jack-fortanix/orgs","repos_url":"https://api.github.com/users/jack-fortanix/repos","events_url":"https://api.github.com/users/jack-fortanix/events{/privacy}","received_events_url":"https://api.github.com/users/jack-fortanix/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jack-fortanix/rust-mbedtls","description":"Idiomatic Rust wrapper for MbedTLS","fork":true,"url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls","forks_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/forks","keys_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/teams","hooks_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/hooks","issue_events_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/events","assignees_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/tags","blobs_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/languages","stargazers_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/stargazers","contributors_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/contributors","subscribers_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/subscribers","subscription_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/subscription","commits_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/merges","archive_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/downloads","issues_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/jack-fortanix/rust-mbedtls/deployments","created_at":"2019-01-17T21:37:35Z","updated_at":"2019-06-26T16:02:08Z","pushed_at":"2019-08-14T20:05:30Z","git_url":"git://github.com/jack-fortanix/rust-mbedtls.git","ssh_url":"git@github.com:jack-fortanix/rust-mbedtls.git","clone_url":"https://github.com/jack-fortanix/rust-mbedtls.git","svn_url":"https://github.com/jack-fortanix/rust-mbedtls","homepage":"","size":4860,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fortanix:master","ref":"master","sha":"8d1f5f98b9a32561139ea2f8b9d4c817a16e6caf","user":{"login":"fortanix","id":25450966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDUwOTY2","avatar_url":"https://avatars2.githubusercontent.com/u/25450966?v=4","gravatar_id":"","url":"https://api.github.com/users/fortanix","html_url":"https://github.com/fortanix","followers_url":"https://api.github.com/users/fortanix/followers","following_url":"https://api.github.com/users/fortanix/following{/other_user}","gists_url":"https://api.github.com/users/fortanix/gists{/gist_id}","starred_url":"https://api.github.com/users/fortanix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortanix/subscriptions","organizations_url":"https://api.github.com/users/fortanix/orgs","repos_url":"https://api.github.com/users/fortanix/repos","events_url":"https://api.github.com/users/fortanix/events{/privacy}","received_events_url":"https://api.github.com/users/fortanix/received_events","type":"Organization","site_admin":false},"repo":{"id":72390806,"node_id":"MDEwOlJlcG9zaXRvcnk3MjM5MDgwNg==","name":"rust-mbedtls","full_name":"fortanix/rust-mbedtls","private":false,"owner":{"login":"fortanix","id":25450966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDUwOTY2","avatar_url":"https://avatars2.githubusercontent.com/u/25450966?v=4","gravatar_id":"","url":"https://api.github.com/users/fortanix","html_url":"https://github.com/fortanix","followers_url":"https://api.github.com/users/fortanix/followers","following_url":"https://api.github.com/users/fortanix/following{/other_user}","gists_url":"https://api.github.com/users/fortanix/gists{/gist_id}","starred_url":"https://api.github.com/users/fortanix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortanix/subscriptions","organizations_url":"https://api.github.com/users/fortanix/orgs","repos_url":"https://api.github.com/users/fortanix/repos","events_url":"https://api.github.com/users/fortanix/events{/privacy}","received_events_url":"https://api.github.com/users/fortanix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fortanix/rust-mbedtls","description":"Idiomatic Rust wrapper for MbedTLS","fork":false,"url":"https://api.github.com/repos/fortanix/rust-mbedtls","forks_url":"https://api.github.com/repos/fortanix/rust-mbedtls/forks","keys_url":"https://api.github.com/repos/fortanix/rust-mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fortanix/rust-mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fortanix/rust-mbedtls/teams","hooks_url":"https://api.github.com/repos/fortanix/rust-mbedtls/hooks","issue_events_url":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/fortanix/rust-mbedtls/events","assignees_url":"https://api.github.com/repos/fortanix/rust-mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/fortanix/rust-mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/fortanix/rust-mbedtls/tags","blobs_url":"https://api.github.com/repos/fortanix/rust-mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fortanix/rust-mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fortanix/rust-mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/fortanix/rust-mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fortanix/rust-mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/fortanix/rust-mbedtls/languages","stargazers_url":"https://api.github.com/repos/fortanix/rust-mbedtls/stargazers","contributors_url":"https://api.github.com/repos/fortanix/rust-mbedtls/contributors","subscribers_url":"https://api.github.com/repos/fortanix/rust-mbedtls/subscribers","subscription_url":"https://api.github.com/repos/fortanix/rust-mbedtls/subscription","commits_url":"https://api.github.com/repos/fortanix/rust-mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/fortanix/rust-mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/fortanix/rust-mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/fortanix/rust-mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/fortanix/rust-mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fortanix/rust-mbedtls/merges","archive_url":"https://api.github.com/repos/fortanix/rust-mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fortanix/rust-mbedtls/downloads","issues_url":"https://api.github.com/repos/fortanix/rust-mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/fortanix/rust-mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/fortanix/rust-mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fortanix/rust-mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/fortanix/rust-mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/fortanix/rust-mbedtls/deployments","created_at":"2016-10-31T02:25:25Z","updated_at":"2019-08-13T18:24:47Z","pushed_at":"2019-08-14T20:05:32Z","git_url":"git://github.com/fortanix/rust-mbedtls.git","ssh_url":"git@github.com:fortanix/rust-mbedtls.git","clone_url":"https://github.com/fortanix/rust-mbedtls.git","svn_url":"https://github.com/fortanix/rust-mbedtls","homepage":"","size":4857,"stargazers_count":12,"watchers_count":12,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":13,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/49"},"html":{"href":"https://github.com/fortanix/rust-mbedtls/pull/49"},"issue":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/49"},"comments":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/statuses/97b9e31a39c41aa39e23e6670b7c41e04774b4e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Goirad"}}