{"action":"opened","number":399,"pull_request":{"url":"https://api.github.com/repos/PynPoint/PynPoint/pulls/399","id":342062550,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyMDYyNTUw","html_url":"https://github.com/PynPoint/PynPoint/pull/399","diff_url":"https://github.com/PynPoint/PynPoint/pull/399.diff","patch_url":"https://github.com/PynPoint/PynPoint/pull/399.patch","issue_url":"https://api.github.com/repos/PynPoint/PynPoint/issues/399","number":399,"state":"open","locked":false,"title":"Nelder-Mead minimization in FalsePositiveModule and offset parameter","user":{"login":"tomasstolker","id":3204762,"node_id":"MDQ6VXNlcjMyMDQ3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/3204762?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasstolker","html_url":"https://github.com/tomasstolker","followers_url":"https://api.github.com/users/tomasstolker/followers","following_url":"https://api.github.com/users/tomasstolker/following{/other_user}","gists_url":"https://api.github.com/users/tomasstolker/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasstolker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasstolker/subscriptions","organizations_url":"https://api.github.com/users/tomasstolker/orgs","repos_url":"https://api.github.com/users/tomasstolker/repos","events_url":"https://api.github.com/users/tomasstolker/events{/privacy}","received_events_url":"https://api.github.com/users/tomasstolker/received_events","type":"User","site_admin":false},"body":"- Changed the minimization method in the `FalsePositiveModule` to Nelder-Mead.\r\n\r\n- Instead of using `bounds` (which is not possible with Nelder-Mead), I have added an `offset` parameter. If the aperture position (with `optimize=True`) deviates by more than an `offset` number of pixels, the SNR is set to zero. The default value of `offset` is None in which case there is no restriction on the aperture position.\r\n\r\n- With Nelder-Mead, the `tolerance` kwarg is an absolute tolerance. It's default value is 0.01 pix. ","created_at":"2019-11-18T09:56:47Z","updated_at":"2019-11-18T09:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PynPoint/PynPoint/pulls/399/commits","review_comments_url":"https://api.github.com/repos/PynPoint/PynPoint/pulls/399/comments","review_comment_url":"https://api.github.com/repos/PynPoint/PynPoint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PynPoint/PynPoint/issues/399/comments","statuses_url":"https://api.github.com/repos/PynPoint/PynPoint/statuses/4351013e4f081a17de1b793c928d6495487903de","head":{"label":"tomasstolker:snr","ref":"snr","sha":"4351013e4f081a17de1b793c928d6495487903de","user":{"login":"tomasstolker","id":3204762,"node_id":"MDQ6VXNlcjMyMDQ3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/3204762?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasstolker","html_url":"https://github.com/tomasstolker","followers_url":"https://api.github.com/users/tomasstolker/followers","following_url":"https://api.github.com/users/tomasstolker/following{/other_user}","gists_url":"https://api.github.com/users/tomasstolker/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasstolker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasstolker/subscriptions","organizations_url":"https://api.github.com/users/tomasstolker/orgs","repos_url":"https://api.github.com/users/tomasstolker/repos","events_url":"https://api.github.com/users/tomasstolker/events{/privacy}","received_events_url":"https://api.github.com/users/tomasstolker/received_events","type":"User","site_admin":false},"repo":{"id":220317589,"node_id":"MDEwOlJlcG9zaXRvcnkyMjAzMTc1ODk=","name":"PynPoint","full_name":"tomasstolker/PynPoint","private":false,"owner":{"login":"tomasstolker","id":3204762,"node_id":"MDQ6VXNlcjMyMDQ3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/3204762?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasstolker","html_url":"https://github.com/tomasstolker","followers_url":"https://api.github.com/users/tomasstolker/followers","following_url":"https://api.github.com/users/tomasstolker/following{/other_user}","gists_url":"https://api.github.com/users/tomasstolker/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasstolker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasstolker/subscriptions","organizations_url":"https://api.github.com/users/tomasstolker/orgs","repos_url":"https://api.github.com/users/tomasstolker/repos","events_url":"https://api.github.com/users/tomasstolker/events{/privacy}","received_events_url":"https://api.github.com/users/tomasstolker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tomasstolker/PynPoint","description":"Pipeline for processing and analysis of high-contrast imaging data","fork":true,"url":"https://api.github.com/repos/tomasstolker/PynPoint","forks_url":"https://api.github.com/repos/tomasstolker/PynPoint/forks","keys_url":"https://api.github.com/repos/tomasstolker/PynPoint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomasstolker/PynPoint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomasstolker/PynPoint/teams","hooks_url":"https://api.github.com/repos/tomasstolker/PynPoint/hooks","issue_events_url":"https://api.github.com/repos/tomasstolker/PynPoint/issues/events{/number}","events_url":"https://api.github.com/repos/tomasstolker/PynPoint/events","assignees_url":"https://api.github.com/repos/tomasstolker/PynPoint/assignees{/user}","branches_url":"https://api.github.com/repos/tomasstolker/PynPoint/branches{/branch}","tags_url":"https://api.github.com/repos/tomasstolker/PynPoint/tags","blobs_url":"https://api.github.com/repos/tomasstolker/PynPoint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomasstolker/PynPoint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomasstolker/PynPoint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomasstolker/PynPoint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomasstolker/PynPoint/statuses/{sha}","languages_url":"https://api.github.com/repos/tomasstolker/PynPoint/languages","stargazers_url":"https://api.github.com/repos/tomasstolker/PynPoint/stargazers","contributors_url":"https://api.github.com/repos/tomasstolker/PynPoint/contributors","subscribers_url":"https://api.github.com/repos/tomasstolker/PynPoint/subscribers","subscription_url":"https://api.github.com/repos/tomasstolker/PynPoint/subscription","commits_url":"https://api.github.com/repos/tomasstolker/PynPoint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomasstolker/PynPoint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomasstolker/PynPoint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomasstolker/PynPoint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomasstolker/PynPoint/contents/{+path}","compare_url":"https://api.github.com/repos/tomasstolker/PynPoint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomasstolker/PynPoint/merges","archive_url":"https://api.github.com/repos/tomasstolker/PynPoint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomasstolker/PynPoint/downloads","issues_url":"https://api.github.com/repos/tomasstolker/PynPoint/issues{/number}","pulls_url":"https://api.github.com/repos/tomasstolker/PynPoint/pulls{/number}","milestones_url":"https://api.github.com/repos/tomasstolker/PynPoint/milestones{/number}","notifications_url":"https://api.github.com/repos/tomasstolker/PynPoint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomasstolker/PynPoint/labels{/name}","releases_url":"https://api.github.com/repos/tomasstolker/PynPoint/releases{/id}","deployments_url":"https://api.github.com/repos/tomasstolker/PynPoint/deployments","created_at":"2019-11-07T19:52:43Z","updated_at":"2019-11-09T11:52:45Z","pushed_at":"2019-11-18T09:49:53Z","git_url":"git://github.com/tomasstolker/PynPoint.git","ssh_url":"git@github.com:tomasstolker/PynPoint.git","clone_url":"https://github.com/tomasstolker/PynPoint.git","svn_url":"https://github.com/tomasstolker/PynPoint","homepage":"","size":11849,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PynPoint:master","ref":"master","sha":"cd80555a9ffeb8d69f1ccfa2af8001f9cad71c75","user":{"login":"PynPoint","id":37398986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3Mzk4OTg2","avatar_url":"https://avatars0.githubusercontent.com/u/37398986?v=4","gravatar_id":"","url":"https://api.github.com/users/PynPoint","html_url":"https://github.com/PynPoint","followers_url":"https://api.github.com/users/PynPoint/followers","following_url":"https://api.github.com/users/PynPoint/following{/other_user}","gists_url":"https://api.github.com/users/PynPoint/gists{/gist_id}","starred_url":"https://api.github.com/users/PynPoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PynPoint/subscriptions","organizations_url":"https://api.github.com/users/PynPoint/orgs","repos_url":"https://api.github.com/users/PynPoint/repos","events_url":"https://api.github.com/users/PynPoint/events{/privacy}","received_events_url":"https://api.github.com/users/PynPoint/received_events","type":"Organization","site_admin":false},"repo":{"id":60430018,"node_id":"MDEwOlJlcG9zaXRvcnk2MDQzMDAxOA==","name":"PynPoint","full_name":"PynPoint/PynPoint","private":false,"owner":{"login":"PynPoint","id":37398986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3Mzk4OTg2","avatar_url":"https://avatars0.githubusercontent.com/u/37398986?v=4","gravatar_id":"","url":"https://api.github.com/users/PynPoint","html_url":"https://github.com/PynPoint","followers_url":"https://api.github.com/users/PynPoint/followers","following_url":"https://api.github.com/users/PynPoint/following{/other_user}","gists_url":"https://api.github.com/users/PynPoint/gists{/gist_id}","starred_url":"https://api.github.com/users/PynPoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PynPoint/subscriptions","organizations_url":"https://api.github.com/users/PynPoint/orgs","repos_url":"https://api.github.com/users/PynPoint/repos","events_url":"https://api.github.com/users/PynPoint/events{/privacy}","received_events_url":"https://api.github.com/users/PynPoint/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PynPoint/PynPoint","description":"Pipeline for processing and analysis of high-contrast imaging data","fork":false,"url":"https://api.github.com/repos/PynPoint/PynPoint","forks_url":"https://api.github.com/repos/PynPoint/PynPoint/forks","keys_url":"https://api.github.com/repos/PynPoint/PynPoint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PynPoint/PynPoint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PynPoint/PynPoint/teams","hooks_url":"https://api.github.com/repos/PynPoint/PynPoint/hooks","issue_events_url":"https://api.github.com/repos/PynPoint/PynPoint/issues/events{/number}","events_url":"https://api.github.com/repos/PynPoint/PynPoint/events","assignees_url":"https://api.github.com/repos/PynPoint/PynPoint/assignees{/user}","branches_url":"https://api.github.com/repos/PynPoint/PynPoint/branches{/branch}","tags_url":"https://api.github.com/repos/PynPoint/PynPoint/tags","blobs_url":"https://api.github.com/repos/PynPoint/PynPoint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PynPoint/PynPoint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PynPoint/PynPoint/git/refs{/sha}","trees_url":"https://api.github.com/repos/PynPoint/PynPoint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PynPoint/PynPoint/statuses/{sha}","languages_url":"https://api.github.com/repos/PynPoint/PynPoint/languages","stargazers_url":"https://api.github.com/repos/PynPoint/PynPoint/stargazers","contributors_url":"https://api.github.com/repos/PynPoint/PynPoint/contributors","subscribers_url":"https://api.github.com/repos/PynPoint/PynPoint/subscribers","subscription_url":"https://api.github.com/repos/PynPoint/PynPoint/subscription","commits_url":"https://api.github.com/repos/PynPoint/PynPoint/commits{/sha}","git_commits_url":"https://api.github.com/repos/PynPoint/PynPoint/git/commits{/sha}","comments_url":"https://api.github.com/repos/PynPoint/PynPoint/comments{/number}","issue_comment_url":"https://api.github.com/repos/PynPoint/PynPoint/issues/comments{/number}","contents_url":"https://api.github.com/repos/PynPoint/PynPoint/contents/{+path}","compare_url":"https://api.github.com/repos/PynPoint/PynPoint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PynPoint/PynPoint/merges","archive_url":"https://api.github.com/repos/PynPoint/PynPoint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PynPoint/PynPoint/downloads","issues_url":"https://api.github.com/repos/PynPoint/PynPoint/issues{/number}","pulls_url":"https://api.github.com/repos/PynPoint/PynPoint/pulls{/number}","milestones_url":"https://api.github.com/repos/PynPoint/PynPoint/milestones{/number}","notifications_url":"https://api.github.com/repos/PynPoint/PynPoint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PynPoint/PynPoint/labels{/name}","releases_url":"https://api.github.com/repos/PynPoint/PynPoint/releases{/id}","deployments_url":"https://api.github.com/repos/PynPoint/PynPoint/deployments","created_at":"2016-06-04T21:00:03Z","updated_at":"2019-11-16T14:28:44Z","pushed_at":"2019-11-09T11:52:38Z","git_url":"git://github.com/PynPoint/PynPoint.git","ssh_url":"git@github.com:PynPoint/PynPoint.git","clone_url":"https://github.com/PynPoint/PynPoint.git","svn_url":"https://github.com/PynPoint/PynPoint","homepage":"","size":13616,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":15,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PynPoint/PynPoint/pulls/399"},"html":{"href":"https://github.com/PynPoint/PynPoint/pull/399"},"issue":{"href":"https://api.github.com/repos/PynPoint/PynPoint/issues/399"},"comments":{"href":"https://api.github.com/repos/PynPoint/PynPoint/issues/399/comments"},"review_comments":{"href":"https://api.github.com/repos/PynPoint/PynPoint/pulls/399/comments"},"review_comment":{"href":"https://api.github.com/repos/PynPoint/PynPoint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PynPoint/PynPoint/pulls/399/commits"},"statuses":{"href":"https://api.github.com/repos/PynPoint/PynPoint/statuses/4351013e4f081a17de1b793c928d6495487903de"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":44,"deletions":24,"changed_files":2}}
{"actor":{"display_login":"tomasstolker"}}