{"action":"created","comment":{"url":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/comments/265846388","pull_request_review_id":214862222,"id":265846388,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTg0NjM4OA==","diff_hunk":"@@ -154,14 +161,23 @@ const MilestoneFields = ({\n         allowClear={false}\n         onChange={time => onChange(index, { ...milestone, dateEstimated: time.unix() })}\n         disabled={milestone.immediatePayout}\n-        disabledDate={current =>\n-          current\n-            ? current <\n-              moment()\n-                .subtract(1, 'month')\n-                .endOf('month')\n-            : false\n-        }\n+        disabledDate={current => {\n+          if (!previousMilestoneDateEstimate) {\n+            return current\n+              ? current <\n+                  moment()\n+                    .subtract(1, 'month')\n+                    .endOf('month')\n+              : false;\n+          } else {\n+            return current\n+              ? current <\n+                  moment()\n+                    .subtract(1, 'month')\n+                    .endOf('month') || current < previousMilestoneDateEstimate\n+              : false;\n+          }\n+        }}","path":"frontend/client/components/CreateFlow/Milestones.tsx","position":56,"original_position":56,"commit_id":"a745cc6804bfd9fb37e0f1db38f865dd978ed974","original_commit_id":"a745cc6804bfd9fb37e0f1db38f865dd978ed974","user":{"login":"dternyak","id":7861465,"node_id":"MDQ6VXNlcjc4NjE0NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/7861465?v=4","gravatar_id":"","url":"https://api.github.com/users/dternyak","html_url":"https://github.com/dternyak","followers_url":"https://api.github.com/users/dternyak/followers","following_url":"https://api.github.com/users/dternyak/following{/other_user}","gists_url":"https://api.github.com/users/dternyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dternyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dternyak/subscriptions","organizations_url":"https://api.github.com/users/dternyak/orgs","repos_url":"https://api.github.com/users/dternyak/repos","events_url":"https://api.github.com/users/dternyak/events{/privacy}","received_events_url":"https://api.github.com/users/dternyak/received_events","type":"User","site_admin":false},"body":"Hm, I could use more notes on how to reproduce.\r\n\r\nWe can circle back if it ends up being a problem, an Admin rejection will work as well. ","created_at":"2019-03-15T04:24:04Z","updated_at":"2019-03-15T04:24:04Z","html_url":"https://github.com/grant-project/zcash-grant-system/pull/381#discussion_r265846388","pull_request_url":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/381","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/comments/265846388"},"html":{"href":"https://github.com/grant-project/zcash-grant-system/pull/381#discussion_r265846388"},"pull_request":{"href":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/381"}},"in_reply_to_id":265846035},"pull_request":{"url":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/381","id":261409700,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxNDA5NzAw","html_url":"https://github.com/grant-project/zcash-grant-system/pull/381","diff_url":"https://github.com/grant-project/zcash-grant-system/pull/381.diff","patch_url":"https://github.com/grant-project/zcash-grant-system/pull/381.patch","issue_url":"https://api.github.com/repos/grant-project/zcash-grant-system/issues/381","number":381,"state":"open","locked":false,"title":"Misc Fixes","user":{"login":"dternyak","id":7861465,"node_id":"MDQ6VXNlcjc4NjE0NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/7861465?v=4","gravatar_id":"","url":"https://api.github.com/users/dternyak","html_url":"https://github.com/dternyak","followers_url":"https://api.github.com/users/dternyak/followers","following_url":"https://api.github.com/users/dternyak/following{/other_user}","gists_url":"https://api.github.com/users/dternyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dternyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dternyak/subscriptions","organizations_url":"https://api.github.com/users/dternyak/orgs","repos_url":"https://api.github.com/users/dternyak/repos","events_url":"https://api.github.com/users/dternyak/events{/privacy}","received_events_url":"https://api.github.com/users/dternyak/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/grant-project/zcash-grant-system/issues/364\r\nCloses https://github.com/grant-project/zcash-grant-system/issues/365\r\nCloses https://github.com/grant-project/zcash-grant-system/issues/369\r\nCloses an untracked issue where empty string targets would blow up the serializer\r\n\r\n\r\n### Testing note\r\n#364 Create a new proposal, confirm that you cant set milestone estimates before the last milestone estimate\r\n#365 Confirm copy is more reasonable for publishing with warnings (team member didn't accept)\r\n#369 Confirm you get an error with a brief larger than 140\r\n","created_at":"2019-03-15T03:23:03Z","updated_at":"2019-03-15T04:24:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d058b6a8e998cbadb0e6043ebed6b7570557694","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/381/commits","review_comments_url":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/381/comments","review_comment_url":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grant-project/zcash-grant-system/issues/381/comments","statuses_url":"https://api.github.com/repos/grant-project/zcash-grant-system/statuses/a745cc6804bfd9fb37e0f1db38f865dd978ed974","head":{"label":"grant-project:qa-fixes-dan","ref":"qa-fixes-dan","sha":"a745cc6804bfd9fb37e0f1db38f865dd978ed974","user":{"login":"grant-project","id":42623314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjIzMzE0","avatar_url":"https://avatars0.githubusercontent.com/u/42623314?v=4","gravatar_id":"","url":"https://api.github.com/users/grant-project","html_url":"https://github.com/grant-project","followers_url":"https://api.github.com/users/grant-project/followers","following_url":"https://api.github.com/users/grant-project/following{/other_user}","gists_url":"https://api.github.com/users/grant-project/gists{/gist_id}","starred_url":"https://api.github.com/users/grant-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grant-project/subscriptions","organizations_url":"https://api.github.com/users/grant-project/orgs","repos_url":"https://api.github.com/users/grant-project/repos","events_url":"https://api.github.com/users/grant-project/events{/privacy}","received_events_url":"https://api.github.com/users/grant-project/received_events","type":"Organization","site_admin":false},"repo":{"id":160740161,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3NDAxNjE=","name":"zcash-grant-system","full_name":"grant-project/zcash-grant-system","private":false,"owner":{"login":"grant-project","id":42623314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjIzMzE0","avatar_url":"https://avatars0.githubusercontent.com/u/42623314?v=4","gravatar_id":"","url":"https://api.github.com/users/grant-project","html_url":"https://github.com/grant-project","followers_url":"https://api.github.com/users/grant-project/followers","following_url":"https://api.github.com/users/grant-project/following{/other_user}","gists_url":"https://api.github.com/users/grant-project/gists{/gist_id}","starred_url":"https://api.github.com/users/grant-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grant-project/subscriptions","organizations_url":"https://api.github.com/users/grant-project/orgs","repos_url":"https://api.github.com/users/grant-project/repos","events_url":"https://api.github.com/users/grant-project/events{/privacy}","received_events_url":"https://api.github.com/users/grant-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grant-project/zcash-grant-system","description":null,"fork":false,"url":"https://api.github.com/repos/grant-project/zcash-grant-system","forks_url":"https://api.github.com/repos/grant-project/zcash-grant-system/forks","keys_url":"https://api.github.com/repos/grant-project/zcash-grant-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grant-project/zcash-grant-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grant-project/zcash-grant-system/teams","hooks_url":"https://api.github.com/repos/grant-project/zcash-grant-system/hooks","issue_events_url":"https://api.github.com/repos/grant-project/zcash-grant-system/issues/events{/number}","events_url":"https://api.github.com/repos/grant-project/zcash-grant-system/events","assignees_url":"https://api.github.com/repos/grant-project/zcash-grant-system/assignees{/user}","branches_url":"https://api.github.com/repos/grant-project/zcash-grant-system/branches{/branch}","tags_url":"https://api.github.com/repos/grant-project/zcash-grant-system/tags","blobs_url":"https://api.github.com/repos/grant-project/zcash-grant-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grant-project/zcash-grant-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grant-project/zcash-grant-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/grant-project/zcash-grant-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grant-project/zcash-grant-system/statuses/{sha}","languages_url":"https://api.github.com/repos/grant-project/zcash-grant-system/languages","stargazers_url":"https://api.github.com/repos/grant-project/zcash-grant-system/stargazers","contributors_url":"https://api.github.com/repos/grant-project/zcash-grant-system/contributors","subscribers_url":"https://api.github.com/repos/grant-project/zcash-grant-system/subscribers","subscription_url":"https://api.github.com/repos/grant-project/zcash-grant-system/subscription","commits_url":"https://api.github.com/repos/grant-project/zcash-grant-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/grant-project/zcash-grant-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/grant-project/zcash-grant-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/grant-project/zcash-grant-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/grant-project/zcash-grant-system/contents/{+path}","compare_url":"https://api.github.com/repos/grant-project/zcash-grant-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grant-project/zcash-grant-system/merges","archive_url":"https://api.github.com/repos/grant-project/zcash-grant-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grant-project/zcash-grant-system/downloads","issues_url":"https://api.github.com/repos/grant-project/zcash-grant-system/issues{/number}","pulls_url":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls{/number}","milestones_url":"https://api.github.com/repos/grant-project/zcash-grant-system/milestones{/number}","notifications_url":"https://api.github.com/repos/grant-project/zcash-grant-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grant-project/zcash-grant-system/labels{/name}","releases_url":"https://api.github.com/repos/grant-project/zcash-grant-system/releases{/id}","deployments_url":"https://api.github.com/repos/grant-project/zcash-grant-system/deployments","created_at":"2018-12-06T22:26:01Z","updated_at":"2019-03-15T04:16:41Z","pushed_at":"2019-03-15T04:17:57Z","git_url":"git://github.com/grant-project/zcash-grant-system.git","ssh_url":"git@github.com:grant-project/zcash-grant-system.git","clone_url":"https://github.com/grant-project/zcash-grant-system.git","svn_url":"https://github.com/grant-project/zcash-grant-system","homepage":"","size":5964,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":28,"watchers":0,"default_branch":"develop"}},"base":{"label":"grant-project:develop","ref":"develop","sha":"c41d74c0fa23029b1ae4a57b530c2a013b5046f1","user":{"login":"grant-project","id":42623314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjIzMzE0","avatar_url":"https://avatars0.githubusercontent.com/u/42623314?v=4","gravatar_id":"","url":"https://api.github.com/users/grant-project","html_url":"https://github.com/grant-project","followers_url":"https://api.github.com/users/grant-project/followers","following_url":"https://api.github.com/users/grant-project/following{/other_user}","gists_url":"https://api.github.com/users/grant-project/gists{/gist_id}","starred_url":"https://api.github.com/users/grant-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grant-project/subscriptions","organizations_url":"https://api.github.com/users/grant-project/orgs","repos_url":"https://api.github.com/users/grant-project/repos","events_url":"https://api.github.com/users/grant-project/events{/privacy}","received_events_url":"https://api.github.com/users/grant-project/received_events","type":"Organization","site_admin":false},"repo":{"id":160740161,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3NDAxNjE=","name":"zcash-grant-system","full_name":"grant-project/zcash-grant-system","private":false,"owner":{"login":"grant-project","id":42623314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjIzMzE0","avatar_url":"https://avatars0.githubusercontent.com/u/42623314?v=4","gravatar_id":"","url":"https://api.github.com/users/grant-project","html_url":"https://github.com/grant-project","followers_url":"https://api.github.com/users/grant-project/followers","following_url":"https://api.github.com/users/grant-project/following{/other_user}","gists_url":"https://api.github.com/users/grant-project/gists{/gist_id}","starred_url":"https://api.github.com/users/grant-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grant-project/subscriptions","organizations_url":"https://api.github.com/users/grant-project/orgs","repos_url":"https://api.github.com/users/grant-project/repos","events_url":"https://api.github.com/users/grant-project/events{/privacy}","received_events_url":"https://api.github.com/users/grant-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grant-project/zcash-grant-system","description":null,"fork":false,"url":"https://api.github.com/repos/grant-project/zcash-grant-system","forks_url":"https://api.github.com/repos/grant-project/zcash-grant-system/forks","keys_url":"https://api.github.com/repos/grant-project/zcash-grant-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grant-project/zcash-grant-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grant-project/zcash-grant-system/teams","hooks_url":"https://api.github.com/repos/grant-project/zcash-grant-system/hooks","issue_events_url":"https://api.github.com/repos/grant-project/zcash-grant-system/issues/events{/number}","events_url":"https://api.github.com/repos/grant-project/zcash-grant-system/events","assignees_url":"https://api.github.com/repos/grant-project/zcash-grant-system/assignees{/user}","branches_url":"https://api.github.com/repos/grant-project/zcash-grant-system/branches{/branch}","tags_url":"https://api.github.com/repos/grant-project/zcash-grant-system/tags","blobs_url":"https://api.github.com/repos/grant-project/zcash-grant-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grant-project/zcash-grant-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grant-project/zcash-grant-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/grant-project/zcash-grant-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grant-project/zcash-grant-system/statuses/{sha}","languages_url":"https://api.github.com/repos/grant-project/zcash-grant-system/languages","stargazers_url":"https://api.github.com/repos/grant-project/zcash-grant-system/stargazers","contributors_url":"https://api.github.com/repos/grant-project/zcash-grant-system/contributors","subscribers_url":"https://api.github.com/repos/grant-project/zcash-grant-system/subscribers","subscription_url":"https://api.github.com/repos/grant-project/zcash-grant-system/subscription","commits_url":"https://api.github.com/repos/grant-project/zcash-grant-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/grant-project/zcash-grant-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/grant-project/zcash-grant-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/grant-project/zcash-grant-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/grant-project/zcash-grant-system/contents/{+path}","compare_url":"https://api.github.com/repos/grant-project/zcash-grant-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grant-project/zcash-grant-system/merges","archive_url":"https://api.github.com/repos/grant-project/zcash-grant-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grant-project/zcash-grant-system/downloads","issues_url":"https://api.github.com/repos/grant-project/zcash-grant-system/issues{/number}","pulls_url":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls{/number}","milestones_url":"https://api.github.com/repos/grant-project/zcash-grant-system/milestones{/number}","notifications_url":"https://api.github.com/repos/grant-project/zcash-grant-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grant-project/zcash-grant-system/labels{/name}","releases_url":"https://api.github.com/repos/grant-project/zcash-grant-system/releases{/id}","deployments_url":"https://api.github.com/repos/grant-project/zcash-grant-system/deployments","created_at":"2018-12-06T22:26:01Z","updated_at":"2019-03-15T04:16:41Z","pushed_at":"2019-03-15T04:17:57Z","git_url":"git://github.com/grant-project/zcash-grant-system.git","ssh_url":"git@github.com:grant-project/zcash-grant-system.git","clone_url":"https://github.com/grant-project/zcash-grant-system.git","svn_url":"https://github.com/grant-project/zcash-grant-system","homepage":"","size":5964,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":28,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/381"},"html":{"href":"https://github.com/grant-project/zcash-grant-system/pull/381"},"issue":{"href":"https://api.github.com/repos/grant-project/zcash-grant-system/issues/381"},"comments":{"href":"https://api.github.com/repos/grant-project/zcash-grant-system/issues/381/comments"},"review_comments":{"href":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/381/comments"},"review_comment":{"href":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grant-project/zcash-grant-system/pulls/381/commits"},"statuses":{"href":"https://api.github.com/repos/grant-project/zcash-grant-system/statuses/a745cc6804bfd9fb37e0f1db38f865dd978ed974"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dternyak"}}