{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/comments/303684125","pull_request_review_id":262133091,"id":303684125,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzY4NDEyNQ==","diff_hunk":"@@ -0,0 +1,21 @@\n+add_executable(sof-fuzzer\n+\tmain.c\n+\tqemu-bridge.c\n+\ttopology.c\n+\tplatform/byt-host.c\n+)\n+\n+target_link_libraries(sof-fuzzer PRIVATE\n+\t\"-lglib-2.0 -lrt\"\n+)\n+\n+target_include_directories(sof-fuzzer PRIVATE\n+\t\"/usr/include/glib-2.0\"","path":"tools/fuzzer/CMakeLists.txt","position":13,"original_position":13,"commit_id":"72c5b56b08cc91f5da3c1304a153c4602e4ef508","original_commit_id":"72c5b56b08cc91f5da3c1304a153c4602e4ef508","user":{"login":"jajanusz","id":40290934,"node_id":"MDQ6VXNlcjQwMjkwOTM0","avatar_url":"https://avatars0.githubusercontent.com/u/40290934?v=4","gravatar_id":"","url":"https://api.github.com/users/jajanusz","html_url":"https://github.com/jajanusz","followers_url":"https://api.github.com/users/jajanusz/followers","following_url":"https://api.github.com/users/jajanusz/following{/other_user}","gists_url":"https://api.github.com/users/jajanusz/gists{/gist_id}","starred_url":"https://api.github.com/users/jajanusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jajanusz/subscriptions","organizations_url":"https://api.github.com/users/jajanusz/orgs","repos_url":"https://api.github.com/users/jajanusz/repos","events_url":"https://api.github.com/users/jajanusz/events{/privacy}","received_events_url":"https://api.github.com/users/jajanusz/received_events","type":"User","site_admin":false},"body":"Hardcoding is not the way to go. In cmake you find packages, it's not something that will differ on win vs linux, it will also differ between linux distros. You should try something like this:\r\n```\r\nfind_package(PkgConfig REQUIRED)\r\npkg_search_module(GLIB REQUIRED glib-2.0)\r\ntarget_include_directories(mytarget PRIVATE ${GLIB_INCLUDE_DIRS})\r\ntarget_link_libraries(mytarget INTERFACE ${GLIB_LDFLAGS})\r\n```","created_at":"2019-07-16T00:06:07Z","updated_at":"2019-07-16T00:09:10Z","html_url":"https://github.com/thesofproject/sof/pull/1637#discussion_r303684125","pull_request_url":"https://api.github.com/repos/thesofproject/sof/pulls/1637","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments/303684125"},"html":{"href":"https://github.com/thesofproject/sof/pull/1637#discussion_r303684125"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/1637"}}},"pull_request":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/1637","id":297477563,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3NDc3NTYz","html_url":"https://github.com/thesofproject/sof/pull/1637","diff_url":"https://github.com/thesofproject/sof/pull/1637.diff","patch_url":"https://github.com/thesofproject/sof/pull/1637.patch","issue_url":"https://api.github.com/repos/thesofproject/sof/issues/1637","number":1637,"state":"open","locked":false,"title":"Fuzzer","user":{"login":"ranj063","id":7766921,"node_id":"MDQ6VXNlcjc3NjY5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7766921?v=4","gravatar_id":"","url":"https://api.github.com/users/ranj063","html_url":"https://github.com/ranj063","followers_url":"https://api.github.com/users/ranj063/followers","following_url":"https://api.github.com/users/ranj063/following{/other_user}","gists_url":"https://api.github.com/users/ranj063/gists{/gist_id}","starred_url":"https://api.github.com/users/ranj063/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranj063/subscriptions","organizations_url":"https://api.github.com/users/ranj063/orgs","repos_url":"https://api.github.com/users/ranj063/repos","events_url":"https://api.github.com/users/ranj063/events{/privacy}","received_events_url":"https://api.github.com/users/ranj063/received_events","type":"User","site_admin":false},"body":"This PR introduces the ingredients required for adding fuzzing support in SOF. The main ingredients are as follows:\r\n\r\nQEMU bridge: This creates the IO bridge to communicate with the QEMU DSP\r\n\r\nCore IA host support for BYT/CHT platforms: Provides the host support for intializing the platform and communicating with the QEMU DSP\r\n\r\nTopology parser: Provides support for parsing the topology binary and setting up the audio pipelines in the QEMU DSP\r\n\r\nMain application: The fuzzing application that sets up the platform and initializes the communication with the QEMU DSP\r\n\r\nCurrently, running the fuzzer application only sets up the platform IO bridge for communicating with the QEMU DSP, boots the FW, parses the topology file and sets up the components and connections in topology by sending the IPC messages to the QEMU DSP. The next step is to add the fuzzing component which will be responsible for sending fuzzed IPC messages and monitoring the status.\r\n\r\nPlease ignore the first 2 commits. I will rebase after PR #1627 is merged","created_at":"2019-07-15T05:50:47Z","updated_at":"2019-07-16T00:09:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30b19cb32170b65069d85e01beb10835ff14a1bd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"plbossart","id":1149035,"node_id":"MDQ6VXNlcjExNDkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1149035?v=4","gravatar_id":"","url":"https://api.github.com/users/plbossart","html_url":"https://github.com/plbossart","followers_url":"https://api.github.com/users/plbossart/followers","following_url":"https://api.github.com/users/plbossart/following{/other_user}","gists_url":"https://api.github.com/users/plbossart/gists{/gist_id}","starred_url":"https://api.github.com/users/plbossart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plbossart/subscriptions","organizations_url":"https://api.github.com/users/plbossart/orgs","repos_url":"https://api.github.com/users/plbossart/repos","events_url":"https://api.github.com/users/plbossart/events{/privacy}","received_events_url":"https://api.github.com/users/plbossart/received_events","type":"User","site_admin":false},{"login":"lgirdwood","id":12020523,"node_id":"MDQ6VXNlcjEyMDIwNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/12020523?v=4","gravatar_id":"","url":"https://api.github.com/users/lgirdwood","html_url":"https://github.com/lgirdwood","followers_url":"https://api.github.com/users/lgirdwood/followers","following_url":"https://api.github.com/users/lgirdwood/following{/other_user}","gists_url":"https://api.github.com/users/lgirdwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lgirdwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgirdwood/subscriptions","organizations_url":"https://api.github.com/users/lgirdwood/orgs","repos_url":"https://api.github.com/users/lgirdwood/repos","events_url":"https://api.github.com/users/lgirdwood/events{/privacy}","received_events_url":"https://api.github.com/users/lgirdwood/received_events","type":"User","site_admin":false},{"login":"lbetlej","id":39951716,"node_id":"MDQ6VXNlcjM5OTUxNzE2","avatar_url":"https://avatars1.githubusercontent.com/u/39951716?v=4","gravatar_id":"","url":"https://api.github.com/users/lbetlej","html_url":"https://github.com/lbetlej","followers_url":"https://api.github.com/users/lbetlej/followers","following_url":"https://api.github.com/users/lbetlej/following{/other_user}","gists_url":"https://api.github.com/users/lbetlej/gists{/gist_id}","starred_url":"https://api.github.com/users/lbetlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbetlej/subscriptions","organizations_url":"https://api.github.com/users/lbetlej/orgs","repos_url":"https://api.github.com/users/lbetlej/repos","events_url":"https://api.github.com/users/lbetlej/events{/privacy}","received_events_url":"https://api.github.com/users/lbetlej/received_events","type":"User","site_admin":false},{"login":"mmaka1","id":40028148,"node_id":"MDQ6VXNlcjQwMDI4MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/40028148?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaka1","html_url":"https://github.com/mmaka1","followers_url":"https://api.github.com/users/mmaka1/followers","following_url":"https://api.github.com/users/mmaka1/following{/other_user}","gists_url":"https://api.github.com/users/mmaka1/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaka1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaka1/subscriptions","organizations_url":"https://api.github.com/users/mmaka1/orgs","repos_url":"https://api.github.com/users/mmaka1/repos","events_url":"https://api.github.com/users/mmaka1/events{/privacy}","received_events_url":"https://api.github.com/users/mmaka1/received_events","type":"User","site_admin":false},{"login":"kv2019i","id":46528387,"node_id":"MDQ6VXNlcjQ2NTI4Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/46528387?v=4","gravatar_id":"","url":"https://api.github.com/users/kv2019i","html_url":"https://github.com/kv2019i","followers_url":"https://api.github.com/users/kv2019i/followers","following_url":"https://api.github.com/users/kv2019i/following{/other_user}","gists_url":"https://api.github.com/users/kv2019i/gists{/gist_id}","starred_url":"https://api.github.com/users/kv2019i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kv2019i/subscriptions","organizations_url":"https://api.github.com/users/kv2019i/orgs","repos_url":"https://api.github.com/users/kv2019i/repos","events_url":"https://api.github.com/users/kv2019i/events{/privacy}","received_events_url":"https://api.github.com/users/kv2019i/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/sof/pulls/1637/commits","review_comments_url":"https://api.github.com/repos/thesofproject/sof/pulls/1637/comments","review_comment_url":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/sof/issues/1637/comments","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/72c5b56b08cc91f5da3c1304a153c4602e4ef508","head":{"label":"ranj063:topic/fuzzer","ref":"topic/fuzzer","sha":"72c5b56b08cc91f5da3c1304a153c4602e4ef508","user":{"login":"ranj063","id":7766921,"node_id":"MDQ6VXNlcjc3NjY5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7766921?v=4","gravatar_id":"","url":"https://api.github.com/users/ranj063","html_url":"https://github.com/ranj063","followers_url":"https://api.github.com/users/ranj063/followers","following_url":"https://api.github.com/users/ranj063/following{/other_user}","gists_url":"https://api.github.com/users/ranj063/gists{/gist_id}","starred_url":"https://api.github.com/users/ranj063/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranj063/subscriptions","organizations_url":"https://api.github.com/users/ranj063/orgs","repos_url":"https://api.github.com/users/ranj063/repos","events_url":"https://api.github.com/users/ranj063/events{/privacy}","received_events_url":"https://api.github.com/users/ranj063/received_events","type":"User","site_admin":false},"repo":{"id":138533501,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1MzM1MDE=","name":"sof","full_name":"ranj063/sof","private":false,"owner":{"login":"ranj063","id":7766921,"node_id":"MDQ6VXNlcjc3NjY5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7766921?v=4","gravatar_id":"","url":"https://api.github.com/users/ranj063","html_url":"https://github.com/ranj063","followers_url":"https://api.github.com/users/ranj063/followers","following_url":"https://api.github.com/users/ranj063/following{/other_user}","gists_url":"https://api.github.com/users/ranj063/gists{/gist_id}","starred_url":"https://api.github.com/users/ranj063/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranj063/subscriptions","organizations_url":"https://api.github.com/users/ranj063/orgs","repos_url":"https://api.github.com/users/ranj063/repos","events_url":"https://api.github.com/users/ranj063/events{/privacy}","received_events_url":"https://api.github.com/users/ranj063/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ranj063/sof","description":"Sound Open Firmware","fork":true,"url":"https://api.github.com/repos/ranj063/sof","forks_url":"https://api.github.com/repos/ranj063/sof/forks","keys_url":"https://api.github.com/repos/ranj063/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ranj063/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ranj063/sof/teams","hooks_url":"https://api.github.com/repos/ranj063/sof/hooks","issue_events_url":"https://api.github.com/repos/ranj063/sof/issues/events{/number}","events_url":"https://api.github.com/repos/ranj063/sof/events","assignees_url":"https://api.github.com/repos/ranj063/sof/assignees{/user}","branches_url":"https://api.github.com/repos/ranj063/sof/branches{/branch}","tags_url":"https://api.github.com/repos/ranj063/sof/tags","blobs_url":"https://api.github.com/repos/ranj063/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ranj063/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ranj063/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/ranj063/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ranj063/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/ranj063/sof/languages","stargazers_url":"https://api.github.com/repos/ranj063/sof/stargazers","contributors_url":"https://api.github.com/repos/ranj063/sof/contributors","subscribers_url":"https://api.github.com/repos/ranj063/sof/subscribers","subscription_url":"https://api.github.com/repos/ranj063/sof/subscription","commits_url":"https://api.github.com/repos/ranj063/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/ranj063/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/ranj063/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/ranj063/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/ranj063/sof/contents/{+path}","compare_url":"https://api.github.com/repos/ranj063/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ranj063/sof/merges","archive_url":"https://api.github.com/repos/ranj063/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ranj063/sof/downloads","issues_url":"https://api.github.com/repos/ranj063/sof/issues{/number}","pulls_url":"https://api.github.com/repos/ranj063/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/ranj063/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/ranj063/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ranj063/sof/labels{/name}","releases_url":"https://api.github.com/repos/ranj063/sof/releases{/id}","deployments_url":"https://api.github.com/repos/ranj063/sof/deployments","created_at":"2018-06-25T02:21:45Z","updated_at":"2018-06-28T05:21:49Z","pushed_at":"2019-07-15T05:47:52Z","git_url":"git://github.com/ranj063/sof.git","ssh_url":"git@github.com:ranj063/sof.git","clone_url":"https://github.com/ranj063/sof.git","svn_url":"https://github.com/ranj063/sof","homepage":null,"size":7316,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thesofproject:master","ref":"master","sha":"ceb35857b6294668ff4f68af577ba48ef6e21d85","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135623245,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MjMyNDU=","name":"sof","full_name":"thesofproject/sof","private":false,"owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thesofproject/sof","description":"Sound Open Firmware","fork":false,"url":"https://api.github.com/repos/thesofproject/sof","forks_url":"https://api.github.com/repos/thesofproject/sof/forks","keys_url":"https://api.github.com/repos/thesofproject/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/sof/teams","hooks_url":"https://api.github.com/repos/thesofproject/sof/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/sof/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/sof/events","assignees_url":"https://api.github.com/repos/thesofproject/sof/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/sof/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/sof/tags","blobs_url":"https://api.github.com/repos/thesofproject/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/sof/languages","stargazers_url":"https://api.github.com/repos/thesofproject/sof/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/sof/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/sof/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/sof/subscription","commits_url":"https://api.github.com/repos/thesofproject/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/sof/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/sof/merges","archive_url":"https://api.github.com/repos/thesofproject/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/sof/downloads","issues_url":"https://api.github.com/repos/thesofproject/sof/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/sof/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/sof/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/sof/deployments","created_at":"2018-05-31T18:51:03Z","updated_at":"2019-07-15T20:38:26Z","pushed_at":"2019-07-15T21:32:38Z","git_url":"git://github.com/thesofproject/sof.git","ssh_url":"git@github.com:thesofproject/sof.git","clone_url":"https://github.com/thesofproject/sof.git","svn_url":"https://github.com/thesofproject/sof","homepage":null,"size":7648,"stargazers_count":71,"watchers_count":71,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":92,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":81,"open_issues":92,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/1637"},"html":{"href":"https://github.com/thesofproject/sof/pull/1637"},"issue":{"href":"https://api.github.com/repos/thesofproject/sof/issues/1637"},"comments":{"href":"https://api.github.com/repos/thesofproject/sof/issues/1637/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/1637/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/1637/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/sof/statuses/72c5b56b08cc91f5da3c1304a153c4602e4ef508"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jajanusz"}}