{"action":"created","comment":{"url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/comments/316180318","pull_request_review_id":277788499,"id":316180318,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjE4MDMxOA==","diff_hunk":"@@ -1,68 +1,73 @@\n # Introduction\n This repo contains a framework to extract data acquired from sensors connected to a Rpi, using the MQTT protocol, as well as provide an easy way to access those data points using a REST API.","path":"README.md","position":2,"original_position":2,"commit_id":"dd39ec6b2460e0a1b3ad6db71490f018a4b93ffb","original_commit_id":"dd39ec6b2460e0a1b3ad6db71490f018a4b93ffb","user":{"login":"csazevedo","id":25006170,"node_id":"MDQ6VXNlcjI1MDA2MTcw","avatar_url":"https://avatars2.githubusercontent.com/u/25006170?v=4","gravatar_id":"","url":"https://api.github.com/users/csazevedo","html_url":"https://github.com/csazevedo","followers_url":"https://api.github.com/users/csazevedo/followers","following_url":"https://api.github.com/users/csazevedo/following{/other_user}","gists_url":"https://api.github.com/users/csazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/csazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csazevedo/subscriptions","organizations_url":"https://api.github.com/users/csazevedo/orgs","repos_url":"https://api.github.com/users/csazevedo/repos","events_url":"https://api.github.com/users/csazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/csazevedo/received_events","type":"User","site_admin":false},"body":"Not this pull request but consistency on Rpi -> RPI","created_at":"2019-08-21T13:21:31Z","updated_at":"2019-08-21T13:21:32Z","html_url":"https://github.com/TechhubLisbon/sinfo-rpi-truck/pull/3#discussion_r316180318","pull_request_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/comments/316180318"},"html":{"href":"https://github.com/TechhubLisbon/sinfo-rpi-truck/pull/3#discussion_r316180318"},"pull_request":{"href":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/3","id":309122029,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5MTIyMDI5","html_url":"https://github.com/TechhubLisbon/sinfo-rpi-truck/pull/3","diff_url":"https://github.com/TechhubLisbon/sinfo-rpi-truck/pull/3.diff","patch_url":"https://github.com/TechhubLisbon/sinfo-rpi-truck/pull/3.patch","issue_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/issues/3","number":3,"state":"open","locked":false,"title":"Rest controller","user":{"login":"tiagomiotto","id":34488331,"node_id":"MDQ6VXNlcjM0NDg4MzMx","avatar_url":"https://avatars2.githubusercontent.com/u/34488331?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagomiotto","html_url":"https://github.com/tiagomiotto","followers_url":"https://api.github.com/users/tiagomiotto/followers","following_url":"https://api.github.com/users/tiagomiotto/following{/other_user}","gists_url":"https://api.github.com/users/tiagomiotto/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagomiotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagomiotto/subscriptions","organizations_url":"https://api.github.com/users/tiagomiotto/orgs","repos_url":"https://api.github.com/users/tiagomiotto/repos","events_url":"https://api.github.com/users/tiagomiotto/events{/privacy}","received_events_url":"https://api.github.com/users/tiagomiotto/received_events","type":"User","site_admin":false},"body":"- Added support for the camera and proximity sensors\r\n- Found out a problem with the steering motor, noted in the README\r\n- Added a motor component to poll the data from the SBrick from time to time\r\n- Added some unit tests for the components\r\n- Added a controller using REST requests\r\n- Updated the README to reflect the changes\r\n\r\n**Note:** The camera component sends the address of the video stream to the backend. Right now it is a private IP address, which means that to access it the client needs to be in the same network as the RPi. The better solution, when we have access to a modem exclusively for the RPi, would be to change that to broadcast the public IP address, since to access the stream via the public address we need to open the necssary ports, which is highly unlikely we would be able to do otherwise.","created_at":"2019-08-20T15:59:13Z","updated_at":"2019-08-21T13:21:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"242722e43e6f476c583ef006685f63ec8459d921","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/3/commits","review_comments_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/3/comments","review_comment_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/issues/3/comments","statuses_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/statuses/dd39ec6b2460e0a1b3ad6db71490f018a4b93ffb","head":{"label":"tiagomiotto:rest_controller","ref":"rest_controller","sha":"dd39ec6b2460e0a1b3ad6db71490f018a4b93ffb","user":{"login":"tiagomiotto","id":34488331,"node_id":"MDQ6VXNlcjM0NDg4MzMx","avatar_url":"https://avatars2.githubusercontent.com/u/34488331?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagomiotto","html_url":"https://github.com/tiagomiotto","followers_url":"https://api.github.com/users/tiagomiotto/followers","following_url":"https://api.github.com/users/tiagomiotto/following{/other_user}","gists_url":"https://api.github.com/users/tiagomiotto/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagomiotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagomiotto/subscriptions","organizations_url":"https://api.github.com/users/tiagomiotto/orgs","repos_url":"https://api.github.com/users/tiagomiotto/repos","events_url":"https://api.github.com/users/tiagomiotto/events{/privacy}","received_events_url":"https://api.github.com/users/tiagomiotto/received_events","type":"User","site_admin":false},"repo":{"id":195414815,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU0MTQ4MTU=","name":"sinfo-rpi-truck","full_name":"tiagomiotto/sinfo-rpi-truck","private":false,"owner":{"login":"tiagomiotto","id":34488331,"node_id":"MDQ6VXNlcjM0NDg4MzMx","avatar_url":"https://avatars2.githubusercontent.com/u/34488331?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagomiotto","html_url":"https://github.com/tiagomiotto","followers_url":"https://api.github.com/users/tiagomiotto/followers","following_url":"https://api.github.com/users/tiagomiotto/following{/other_user}","gists_url":"https://api.github.com/users/tiagomiotto/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagomiotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagomiotto/subscriptions","organizations_url":"https://api.github.com/users/tiagomiotto/orgs","repos_url":"https://api.github.com/users/tiagomiotto/repos","events_url":"https://api.github.com/users/tiagomiotto/events{/privacy}","received_events_url":"https://api.github.com/users/tiagomiotto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tiagomiotto/sinfo-rpi-truck","description":"Raspberry Pi and MPU-9250 setup for the truck project","fork":true,"url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck","forks_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/forks","keys_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/teams","hooks_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/hooks","issue_events_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/issues/events{/number}","events_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/events","assignees_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/assignees{/user}","branches_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/branches{/branch}","tags_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/tags","blobs_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/statuses/{sha}","languages_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/languages","stargazers_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/stargazers","contributors_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/contributors","subscribers_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/subscribers","subscription_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/subscription","commits_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/contents/{+path}","compare_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/merges","archive_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/downloads","issues_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/issues{/number}","pulls_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/pulls{/number}","milestones_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/milestones{/number}","notifications_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/labels{/name}","releases_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/releases{/id}","deployments_url":"https://api.github.com/repos/tiagomiotto/sinfo-rpi-truck/deployments","created_at":"2019-07-05T13:33:37Z","updated_at":"2019-08-20T20:34:58Z","pushed_at":"2019-08-20T21:38:52Z","git_url":"git://github.com/tiagomiotto/sinfo-rpi-truck.git","ssh_url":"git@github.com:tiagomiotto/sinfo-rpi-truck.git","clone_url":"https://github.com/tiagomiotto/sinfo-rpi-truck.git","svn_url":"https://github.com/tiagomiotto/sinfo-rpi-truck","homepage":null,"size":1348,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"TechhubLisbon:master","ref":"master","sha":"9262d4ccebc2d36e8ee07940978e9dc871b9a47c","user":{"login":"TechhubLisbon","id":39816576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODE2NTc2","avatar_url":"https://avatars2.githubusercontent.com/u/39816576?v=4","gravatar_id":"","url":"https://api.github.com/users/TechhubLisbon","html_url":"https://github.com/TechhubLisbon","followers_url":"https://api.github.com/users/TechhubLisbon/followers","following_url":"https://api.github.com/users/TechhubLisbon/following{/other_user}","gists_url":"https://api.github.com/users/TechhubLisbon/gists{/gist_id}","starred_url":"https://api.github.com/users/TechhubLisbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechhubLisbon/subscriptions","organizations_url":"https://api.github.com/users/TechhubLisbon/orgs","repos_url":"https://api.github.com/users/TechhubLisbon/repos","events_url":"https://api.github.com/users/TechhubLisbon/events{/privacy}","received_events_url":"https://api.github.com/users/TechhubLisbon/received_events","type":"Organization","site_admin":false},"repo":{"id":171266875,"node_id":"MDEwOlJlcG9zaXRvcnkxNzEyNjY4NzU=","name":"sinfo-rpi-truck","full_name":"TechhubLisbon/sinfo-rpi-truck","private":false,"owner":{"login":"TechhubLisbon","id":39816576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODE2NTc2","avatar_url":"https://avatars2.githubusercontent.com/u/39816576?v=4","gravatar_id":"","url":"https://api.github.com/users/TechhubLisbon","html_url":"https://github.com/TechhubLisbon","followers_url":"https://api.github.com/users/TechhubLisbon/followers","following_url":"https://api.github.com/users/TechhubLisbon/following{/other_user}","gists_url":"https://api.github.com/users/TechhubLisbon/gists{/gist_id}","starred_url":"https://api.github.com/users/TechhubLisbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechhubLisbon/subscriptions","organizations_url":"https://api.github.com/users/TechhubLisbon/orgs","repos_url":"https://api.github.com/users/TechhubLisbon/repos","events_url":"https://api.github.com/users/TechhubLisbon/events{/privacy}","received_events_url":"https://api.github.com/users/TechhubLisbon/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TechhubLisbon/sinfo-rpi-truck","description":"Raspberry Pi and MPU-9250 setup for the truck project","fork":false,"url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck","forks_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/forks","keys_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/teams","hooks_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/hooks","issue_events_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/issues/events{/number}","events_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/events","assignees_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/assignees{/user}","branches_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/branches{/branch}","tags_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/tags","blobs_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/statuses/{sha}","languages_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/languages","stargazers_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/stargazers","contributors_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/contributors","subscribers_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/subscribers","subscription_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/subscription","commits_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/contents/{+path}","compare_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/merges","archive_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/downloads","issues_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/issues{/number}","pulls_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls{/number}","milestones_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/milestones{/number}","notifications_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/labels{/name}","releases_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/releases{/id}","deployments_url":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/deployments","created_at":"2019-02-18T10:53:01Z","updated_at":"2019-08-12T17:49:35Z","pushed_at":"2019-08-20T21:38:53Z","git_url":"git://github.com/TechhubLisbon/sinfo-rpi-truck.git","ssh_url":"git@github.com:TechhubLisbon/sinfo-rpi-truck.git","clone_url":"https://github.com/TechhubLisbon/sinfo-rpi-truck.git","svn_url":"https://github.com/TechhubLisbon/sinfo-rpi-truck","homepage":null,"size":902,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/3"},"html":{"href":"https://github.com/TechhubLisbon/sinfo-rpi-truck/pull/3"},"issue":{"href":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/issues/3"},"comments":{"href":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/TechhubLisbon/sinfo-rpi-truck/statuses/dd39ec6b2460e0a1b3ad6db71490f018a4b93ffb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"csazevedo"}}