{"action":"created","issue":{"url":"https://api.github.com/repos/SAP/openui5/issues/2687","repository_url":"https://api.github.com/repos/SAP/openui5","labels_url":"https://api.github.com/repos/SAP/openui5/issues/2687/labels{/name}","comments_url":"https://api.github.com/repos/SAP/openui5/issues/2687/comments","events_url":"https://api.github.com/repos/SAP/openui5/issues/2687/events","html_url":"https://github.com/SAP/openui5/issues/2687","id":497519513,"node_id":"MDU6SXNzdWU0OTc1MTk1MTM=","number":2687,"title":"P13nSortPanel - additional items in value select in case with Array polyfil","user":{"login":"huhle","id":43252730,"node_id":"MDQ6VXNlcjQzMjUyNzMw","avatar_url":"https://avatars1.githubusercontent.com/u/43252730?v=4","gravatar_id":"","url":"https://api.github.com/users/huhle","html_url":"https://github.com/huhle","followers_url":"https://api.github.com/users/huhle/followers","following_url":"https://api.github.com/users/huhle/following{/other_user}","gists_url":"https://api.github.com/users/huhle/gists{/gist_id}","starred_url":"https://api.github.com/users/huhle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huhle/subscriptions","organizations_url":"https://api.github.com/users/huhle/orgs","repos_url":"https://api.github.com/users/huhle/repos","events_url":"https://api.github.com/users/huhle/events{/privacy}","received_events_url":"https://api.github.com/users/huhle/received_events","type":"User","site_admin":false},"labels":[{"id":85376367,"node_id":"MDU6TGFiZWw4NTM3NjM2Nw==","url":"https://api.github.com/repos/SAP/openui5/labels/in%20progress","name":"in progress","color":"FFBF7F","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-09-24T07:52:41Z","updated_at":"2019-10-11T10:31:26Z","closed_at":"2019-10-11T10:31:26Z","author_association":"NONE","body":"OpenUI5 version: 1.52.30\r\n\r\nBrowser/version (+device/version): Google Chrome 70.0.3538.67 (Official Build) (64-bit) on Windows 7\r\n\r\nAny other tested browsers/devices(OK/FAIL): Also fails on Firefox 69.0.1 and Internet Explorer 11\r\n\r\nMinimal example:\r\n[p13n.zip](https://github.com/SAP/openui5/files/3645813/p13n.zip)\r\n\r\n\r\nSteps to reproduce the problem:\r\n1. Run the application and open personalization dialog by clicking on the button\r\n2. Click on Ascending/Descending checkbox\r\n3. Checkbox contains rows not just for the content of sortItems, but also for every function added to Array.prototype (which happens when polyfils are used)\r\n\r\nTo simulate polyfiling I added \r\n`Array.prototype.someCustomFunction = function() { /* this will be visible in p13n panel */ }`\r\nto the index html.\r\n\r\nThe problem seems to be in P13nConditionPanel._fillOperationListItems function, where aOperations are looped by `for ( var iOperation in aOperations) {` without own property check\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/SAP/openui5/issues/comments/541010421","html_url":"https://github.com/SAP/openui5/issues/2687#issuecomment-541010421","issue_url":"https://api.github.com/repos/SAP/openui5/issues/2687","id":541010421,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MTAxMDQyMQ==","user":{"login":"HerzogIgzorn","id":31067673,"node_id":"MDQ6VXNlcjMxMDY3Njcz","avatar_url":"https://avatars1.githubusercontent.com/u/31067673?v=4","gravatar_id":"","url":"https://api.github.com/users/HerzogIgzorn","html_url":"https://github.com/HerzogIgzorn","followers_url":"https://api.github.com/users/HerzogIgzorn/followers","following_url":"https://api.github.com/users/HerzogIgzorn/following{/other_user}","gists_url":"https://api.github.com/users/HerzogIgzorn/gists{/gist_id}","starred_url":"https://api.github.com/users/HerzogIgzorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerzogIgzorn/subscriptions","organizations_url":"https://api.github.com/users/HerzogIgzorn/orgs","repos_url":"https://api.github.com/users/HerzogIgzorn/repos","events_url":"https://api.github.com/users/HerzogIgzorn/events{/privacy}","received_events_url":"https://api.github.com/users/HerzogIgzorn/received_events","type":"User","site_admin":false},"created_at":"2019-10-11T10:31:26Z","updated_at":"2019-10-11T10:31:26Z","author_association":"CONTRIBUTOR","body":"Hello huhle,\r\n\r\nthis issue has been solved. The fix will be available in the nightly build as well as OpenUI5 1.72 and higher.\r\n\r\nRegards Sebastian"}}
{"actor":{"display_login":"HerzogIgzorn"}}