{"action":"closed","number":78844,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78844","id":286580379,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2NTgwMzc5","html_url":"https://github.com/kubernetes/kubernetes/pull/78844","diff_url":"https://github.com/kubernetes/kubernetes/pull/78844.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/78844.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/78844","number":78844,"state":"closed","locked":false,"title":"Add non-preemptible policy to PriorityClasses","user":{"login":"xychu","id":936394,"node_id":"MDQ6VXNlcjkzNjM5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/936394?v=4","gravatar_id":"","url":"https://api.github.com/users/xychu","html_url":"https://github.com/xychu","followers_url":"https://api.github.com/users/xychu/followers","following_url":"https://api.github.com/users/xychu/following{/other_user}","gists_url":"https://api.github.com/users/xychu/gists{/gist_id}","starred_url":"https://api.github.com/users/xychu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xychu/subscriptions","organizations_url":"https://api.github.com/users/xychu/orgs","repos_url":"https://api.github.com/users/xychu/repos","events_url":"https://api.github.com/users/xychu/events{/privacy}","received_events_url":"https://api.github.com/users/xychu/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n\r\n1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespaces from that line:\r\n>\r\n> /kind api-change\r\n> /kind bug\r\n> /kind cleanup\r\n> /kind design\r\n> /kind documentation\r\n> /kind failing-test\r\n\r\n/kind feature\r\n> /kind flake\r\n\r\n**What this PR does / why we need it**:\r\nAs we've have non-preempting(https://github.com/kubernetes/kubernetes/pull/74614) policy, for some cases, users may need non-preemptible PriorityClasses as well.\r\n\r\n**Which issue(s) this PR fixes**:\r\n<!--\r\n*Automatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n-->\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n```\r\n\t// PreemptLowerPriority means that pod can preempt other pods with lower priority.\r\n\tPreemptLowerPriority PreemptionPolicy = \"PreemptLowerPriority\"\r\n\t// PreemptNever means that pod never preempts other pods with lower priority.\r\n\tPreemptNever PreemptionPolicy = \"Never\"\r\n\t// NonPreemptible means that pod can not be preempted by other pods with higher priority.\r\n\tNonPreemptible PreemptionPolicy = \"NonPreemptible\"\r\n\t// NonPreemptiblePreemptNever means that pod can not be preempted by other pods with higher priority and never preempts other pods with lower priority.\r\n\tNonPreemptiblePreemptNever PreemptionPolicy = \"NonPreemptiblePreemptNever\"\r\n```\r\nNeed advice on the naming part.\r\n**Does this PR introduce a user-facing change?**:\r\n<!--\r\nIf no, just write \"NONE\" in the release-note block below.\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n-->\r\n```release-note\r\nAdd non-preemptible policy to PriorityClass\r\n```\r\n","created_at":"2019-06-10T08:13:26Z","updated_at":"2019-11-08T07:16:53Z","closed_at":"2019-11-08T07:16:53Z","merged_at":null,"merge_commit_sha":"9f3cbf65696b01d9e3908d28f44b6e6d848ce1d7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mikedanese","id":1787169,"node_id":"MDQ6VXNlcjE3ODcxNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1787169?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},{"login":"brendandburns","id":5751682,"node_id":"MDQ6VXNlcjU3NTE2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"node_id":"MDU6TGFiZWwyNjEwMDUzNjA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"e11d21","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":778118402,"node_id":"MDU6TGFiZWw3NzgxMTg0MDI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lifecycle/rotten","name":"lifecycle/rotten","color":"604460","default":false},{"id":573014062,"node_id":"MDU6TGFiZWw1NzMwMTQwNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":404091735,"node_id":"MDU6TGFiZWw0MDQwOTE3MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false},{"id":125550211,"node_id":"MDU6TGFiZWwxMjU1NTAyMTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78844/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78844/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/78844/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e6f586308279ee50216abed17079b9b9a5221d40","head":{"label":"xychu:more-priority-policies","ref":"more-priority-policies","sha":"e6f586308279ee50216abed17079b9b9a5221d40","user":{"login":"xychu","id":936394,"node_id":"MDQ6VXNlcjkzNjM5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/936394?v=4","gravatar_id":"","url":"https://api.github.com/users/xychu","html_url":"https://github.com/xychu","followers_url":"https://api.github.com/users/xychu/followers","following_url":"https://api.github.com/users/xychu/following{/other_user}","gists_url":"https://api.github.com/users/xychu/gists{/gist_id}","starred_url":"https://api.github.com/users/xychu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xychu/subscriptions","organizations_url":"https://api.github.com/users/xychu/orgs","repos_url":"https://api.github.com/users/xychu/repos","events_url":"https://api.github.com/users/xychu/events{/privacy}","received_events_url":"https://api.github.com/users/xychu/received_events","type":"User","site_admin":false},"repo":{"id":43956428,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzk1NjQyOA==","name":"kubernetes","full_name":"xychu/kubernetes","private":false,"owner":{"login":"xychu","id":936394,"node_id":"MDQ6VXNlcjkzNjM5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/936394?v=4","gravatar_id":"","url":"https://api.github.com/users/xychu","html_url":"https://github.com/xychu","followers_url":"https://api.github.com/users/xychu/followers","following_url":"https://api.github.com/users/xychu/following{/other_user}","gists_url":"https://api.github.com/users/xychu/gists{/gist_id}","starred_url":"https://api.github.com/users/xychu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xychu/subscriptions","organizations_url":"https://api.github.com/users/xychu/orgs","repos_url":"https://api.github.com/users/xychu/repos","events_url":"https://api.github.com/users/xychu/events{/privacy}","received_events_url":"https://api.github.com/users/xychu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xychu/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/xychu/kubernetes","forks_url":"https://api.github.com/repos/xychu/kubernetes/forks","keys_url":"https://api.github.com/repos/xychu/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xychu/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xychu/kubernetes/teams","hooks_url":"https://api.github.com/repos/xychu/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/xychu/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/xychu/kubernetes/events","assignees_url":"https://api.github.com/repos/xychu/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/xychu/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/xychu/kubernetes/tags","blobs_url":"https://api.github.com/repos/xychu/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xychu/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xychu/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/xychu/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xychu/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/xychu/kubernetes/languages","stargazers_url":"https://api.github.com/repos/xychu/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/xychu/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/xychu/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/xychu/kubernetes/subscription","commits_url":"https://api.github.com/repos/xychu/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/xychu/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/xychu/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/xychu/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/xychu/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/xychu/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xychu/kubernetes/merges","archive_url":"https://api.github.com/repos/xychu/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xychu/kubernetes/downloads","issues_url":"https://api.github.com/repos/xychu/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/xychu/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/xychu/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/xychu/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xychu/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/xychu/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/xychu/kubernetes/deployments","created_at":"2015-10-09T13:18:21Z","updated_at":"2019-10-15T02:16:30Z","pushed_at":"2019-10-25T07:28:40Z","git_url":"git://github.com/xychu/kubernetes.git","ssh_url":"git@github.com:xychu/kubernetes.git","clone_url":"https://github.com/xychu/kubernetes.git","svn_url":"https://github.com/xychu/kubernetes","homepage":"http://kubernetes.io","size":638014,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3d4124f2e083591c98e8a874760011781d3ee15c","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2019-11-08T07:06:11Z","pushed_at":"2019-11-08T06:50:10Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":890389,"stargazers_count":59750,"watchers_count":59750,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20993,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3371,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20993,"open_issues":3371,"watchers":59750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78844"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/78844"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/78844"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/78844/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78844/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78844/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e6f586308279ee50216abed17079b9b9a5221d40"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":10,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":189,"deletions":14,"changed_files":8}}
{"actor":{"display_login":"k8s-ci-robot"}}