{"action":"created","issue":{"url":"https://api.github.com/repos/alan-turing-institute/dodo/issues/67","repository_url":"https://api.github.com/repos/alan-turing-institute/dodo","labels_url":"https://api.github.com/repos/alan-turing-institute/dodo/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/alan-turing-institute/dodo/issues/67/comments","events_url":"https://api.github.com/repos/alan-turing-institute/dodo/issues/67/events","html_url":"https://github.com/alan-turing-institute/dodo/issues/67","id":482398009,"node_id":"MDU6SXNzdWU0ODIzOTgwMDk=","number":67,"title":"test_manage_simulation.py::test_load_bluesky - Failure","user":{"login":"tallamjr","id":8843728,"node_id":"MDQ6VXNlcjg4NDM3Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/8843728?v=4","gravatar_id":"","url":"https://api.github.com/users/tallamjr","html_url":"https://github.com/tallamjr","followers_url":"https://api.github.com/users/tallamjr/followers","following_url":"https://api.github.com/users/tallamjr/following{/other_user}","gists_url":"https://api.github.com/users/tallamjr/gists{/gist_id}","starred_url":"https://api.github.com/users/tallamjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallamjr/subscriptions","organizations_url":"https://api.github.com/users/tallamjr/orgs","repos_url":"https://api.github.com/users/tallamjr/repos","events_url":"https://api.github.com/users/tallamjr/events{/privacy}","received_events_url":"https://api.github.com/users/tallamjr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-08-19T16:05:04Z","updated_at":"2019-08-19T16:23:26Z","closed_at":null,"author_association":"NONE","body":"When examining the issues relating to https://github.com/alan-turing-institute/dodo/pull/64 , I compared the method for\r\nintegration tests with what is being done in [simurgh's travis script](https://github.com/alan-turing-institute/simurgh/blob/ef1d33916acdfa66738b2ffa1f77fd395e7662e0/.travis.yml#L45)\r\nThis lead to the discovery of where it appeared to be issues with\r\n`load_scenario()` function in `bluebird`\r\n\r\nWhen running the integration tests locally using docker the following test fails:\r\n```bash\r\n...\r\ntests/integration/test_manage_simulation.py::test_simulation_control PASSED\r\ntests/integration/test_manage_simulation.py::test_load_bluesky FAILED\r\ntests/integration/test_manage_simulation.py::test_load_fail PASSED\r\n...\r\n```\r\nWith the accompanying error of:\r\n```bash\r\nif http_error_msg:\r\n>           raise HTTPError(http_error_msg, response=self)\r\nE           requests.exceptions.HTTPError: 500 Server Error: INTERNAL SERVER ERROR for url: http://localhost:5001/api/v1/ic\r\n```\r\nIt appears the test expects the file extension to be lowercase but is in fact\r\nupper case as found in `bluesky/scenario/8.SCN`. A change to\r\n`tests/test_simulation_control.py` should resolve this.\r\n\r\nPlease see this https://github.com/alan-turing-institute/nats/issues/98 where it outlines the fact that although this appears to be a general issue, it does not seem to arise when one does _not_ use the docker builds"},"comment":{"url":"https://api.github.com/repos/alan-turing-institute/dodo/issues/comments/522650984","html_url":"https://github.com/alan-turing-institute/dodo/issues/67#issuecomment-522650984","issue_url":"https://api.github.com/repos/alan-turing-institute/dodo/issues/67","id":522650984,"node_id":"MDEyOklzc3VlQ29tbWVudDUyMjY1MDk4NA==","user":{"login":"rkm","id":5160559,"node_id":"MDQ6VXNlcjUxNjA1NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5160559?v=4","gravatar_id":"","url":"https://api.github.com/users/rkm","html_url":"https://github.com/rkm","followers_url":"https://api.github.com/users/rkm/followers","following_url":"https://api.github.com/users/rkm/following{/other_user}","gists_url":"https://api.github.com/users/rkm/gists{/gist_id}","starred_url":"https://api.github.com/users/rkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkm/subscriptions","organizations_url":"https://api.github.com/users/rkm/orgs","repos_url":"https://api.github.com/users/rkm/repos","events_url":"https://api.github.com/users/rkm/events{/privacy}","received_events_url":"https://api.github.com/users/rkm/received_events","type":"User","site_admin":false},"created_at":"2019-08-19T16:23:26Z","updated_at":"2019-08-19T16:23:26Z","author_association":"MEMBER","body":"This is an issue with using the pre-defined BlueSky scenarios. Some are uppercase and some are lowercase, so we have to do lots of string-mangling to try and guess which case a particular file is (in BlueBird). In general, we should be moving away from using these scenarios, and instead create our own for testing using the upload scenario `/api/v1/scenario` API."}}
{"actor":{"display_login":"rkm"}}