{"action":"created","issue":{"url":"https://api.github.com/repos/akveo/nebular/issues/1985","repository_url":"https://api.github.com/repos/akveo/nebular","labels_url":"https://api.github.com/repos/akveo/nebular/issues/1985/labels{/name}","comments_url":"https://api.github.com/repos/akveo/nebular/issues/1985/comments","events_url":"https://api.github.com/repos/akveo/nebular/issues/1985/events","html_url":"https://github.com/akveo/nebular/issues/1985","id":499896432,"node_id":"MDU6SXNzdWU0OTk4OTY0MzI=","number":1985,"title":"all element's height are fixed and don't get the element's content height ","user":{"login":"mahsatahmasebi","id":42890790,"node_id":"MDQ6VXNlcjQyODkwNzkw","avatar_url":"https://avatars3.githubusercontent.com/u/42890790?v=4","gravatar_id":"","url":"https://api.github.com/users/mahsatahmasebi","html_url":"https://github.com/mahsatahmasebi","followers_url":"https://api.github.com/users/mahsatahmasebi/followers","following_url":"https://api.github.com/users/mahsatahmasebi/following{/other_user}","gists_url":"https://api.github.com/users/mahsatahmasebi/gists{/gist_id}","starred_url":"https://api.github.com/users/mahsatahmasebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahsatahmasebi/subscriptions","organizations_url":"https://api.github.com/users/mahsatahmasebi/orgs","repos_url":"https://api.github.com/users/mahsatahmasebi/repos","events_url":"https://api.github.com/users/mahsatahmasebi/events{/privacy}","received_events_url":"https://api.github.com/users/mahsatahmasebi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-09-29T10:22:28Z","updated_at":"2019-10-03T09:35:29Z","closed_at":null,"author_association":"NONE","body":"I'm sorry I'm new so if I made a mistake I apologize, but I found some problem and fixed it and I want to write about it. \r\nI found out that all element's height are (div, a , p , etc...) fixed and are 20 px and doesn't get their content's size. So after searching I found out in the theme files (_default.scss ,..)are line-height parameters that come with rem unit, and when I removed these units, my problem solved (which was that all texts were tangled and were illegible). \r\nBut I wanted another solution beside changing theme library file. So in themes.scss file under nb-register-theme of my theme I added all the parameters in _mapping.scss of node-modules that had line-height and were mapped to _default.scss line-height parameters, with their number values without rem unit. maybe there is another solution. \r\n\r\nmy code in themes.scss is  :\r\n$nb-themes: nb-register-theme((\r\n  \r\n  card-text-line-height: 1.25,\r\n  card-header-text-line-height: 1.5,\r\n  header-text-line-height: 1.25,\r\n  footer-text-line-height: 1.25,\r\n  layout-text-line-height: 1.25,\r\n  sidebar-text-line-height: 1.25,\r\n  menu-text-line-height: 1.5,\r\n  tabset-tab-text-line-height: 1,\r\n  tabset-content-text-line-height: 1.25,\r\n  route-tabset-tab-text-line-height: 1,\r\n  user-tiny-initials-text-line-height: 1,\r\n  user-tiny-name-text-line-height: 1,\r\n  user-tiny-title-text-line-height:1,\r\n  user-small-initials-text-line-height:1,\r\n  user-small-name-text-line-height: 1,\r\n  user-small-title-text-line-height: 1,\r\n  user-medium-initials-text-line-height: 1.25,\r\n  user-medium-name-text-line-height: 1.25,\r\n  user-medium-title-text-line-height: 1,\r\n  user-large-initials-text-line-height: 1.25,\r\n  user-large-name-text-line-height: 1.25,\r\n  user-large-title-text-line-height: 1.125,\r\n  user-giant-initials-text-line-height: 1.25,\r\n  user-giant-name-text-line-height: 1.25,\r\n  user-giant-title-text-line-height: 1.25,\r\n  popover-text-line-height: 1.25,\r\n  actions-text-line-height: 1,\r\n  search-text-line-height: 3,\r\n  search-info-text-line-height: 1.5,\r\n  smart-table-header-line-height: 1.25,\r\n  smart-table-line-height: 1.25,\r\n  toastr-text-line-height: 1.125,\r\n  toastr-title-text-line-height: 1.5,\r\n  button-tiny-text-line-height: 0.75,\r\n  button-small-text-line-height: 1,\r\n  button-medium-text-line-height: 1,\r\n  button-large-text-line-height: 1.25,\r\n  button-giant-text-line-height: 1.5,\r\n  input-tiny-text-line-height: 1,\r\n  input-tiny-placeholder-text-line-height: 1.25,\r\n  input-small-text-line-height: 1.5,\r\n  input-small-placeholder-text-line-height: 1.25,\r\n  input-medium-text-line-height: 1.5,\r\n  input-medium-placeholder-text-line-height: 1.25,\r\n  input-large-text-line-height: 1.5,\r\n  input-large-placeholder-text-line-height: 1.25,\r\n  input-giant-text-line-height: 1.5,\r\n  input-giant-placeholder-text-line-height: 1.25,\r\n  checkbox-text-line-height: 1.5,\r\n  progress-bar-tiny-text-line-height: 1.5,\r\n  progress-bar-small-text-line-height: 1.5,\r\n  progress-bar-medium-text-line-height: 1.5,\r\n  progress-bar-large-text-line-height: 1.5,\r\n  progress-bar-giant-text-line-height:1.5,\r\n  alert-text-line-height: 1.5,\r\n  chat-text-line-height: 1.25,\r\n  chat-header-text-line-height: 1.5,\r\n  spinner-text-line-height: 1.25,\r\n  stepper-step-text-line-height: 1.25,\r\n  accordion-header-text-line-height: 1.5,\r\n  accordion-item-text-line-height: 1.25,\r\n  list-item-line-height: 1.25,\r\n  calendar-text-line-height: 1.25,\r\n  calendar-header-title-text-line-height: 1.5,\r\n  calendar-header-sub-title-text-line-height: 1.25,\r\n  calendar-cell-selected-text-line-height: 1.5,\r\n  calendar-cell-hover-text-line-height: 1.5,\r\n  calendar-cell-active-text-line-height: 1.5,\r\n  calendar-cell-today-text-line-height: 1.5,\r\n  calendar-weekday-text-line-height: 1.125,\r\n  tooltip-text-line-height: 1,\r\n  select-tiny-text-line-height: 1,\r\n  select-small-text-line-height: 1.5,\r\n  select-medium-text-line-height: 1.5,\r\n  select-large-text-line-height: 1.5,\r\n  select-giant-text-line-height: 1.5,\r\n  radio-text-line-height: 1.5,\r\n  tree-grid-header-text-line-height: 1.5,\r\n  tree-grid-row-text-line-height: 1.25,\r\n  icon-line-height: 1,\r\n\r\n), default, default);\r\n\r\nThank you "},"comment":{"url":"https://api.github.com/repos/akveo/nebular/issues/comments/537868568","html_url":"https://github.com/akveo/nebular/issues/1985#issuecomment-537868568","issue_url":"https://api.github.com/repos/akveo/nebular/issues/1985","id":537868568,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNzg2ODU2OA==","user":{"login":"mahsatahmasebi","id":42890790,"node_id":"MDQ6VXNlcjQyODkwNzkw","avatar_url":"https://avatars3.githubusercontent.com/u/42890790?v=4","gravatar_id":"","url":"https://api.github.com/users/mahsatahmasebi","html_url":"https://github.com/mahsatahmasebi","followers_url":"https://api.github.com/users/mahsatahmasebi/followers","following_url":"https://api.github.com/users/mahsatahmasebi/following{/other_user}","gists_url":"https://api.github.com/users/mahsatahmasebi/gists{/gist_id}","starred_url":"https://api.github.com/users/mahsatahmasebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahsatahmasebi/subscriptions","organizations_url":"https://api.github.com/users/mahsatahmasebi/orgs","repos_url":"https://api.github.com/users/mahsatahmasebi/repos","events_url":"https://api.github.com/users/mahsatahmasebi/events{/privacy}","received_events_url":"https://api.github.com/users/mahsatahmasebi/received_events","type":"User","site_admin":false},"created_at":"2019-10-03T09:35:29Z","updated_at":"2019-10-03T09:35:29Z","author_association":"NONE","body":"@ArtemRomanovsky if we don't fix this we have to use a lot of padding and margin in order to our lines don't tangle to each other, specifically for project migration where this problem shows up in the higher versions of nebular and we have to rearrange all of the pages again. "}}
{"actor":{"display_login":"mahsatahmasebi"}}