{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/issues/389","repository_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere","labels_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/issues/389/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/issues/389/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/issues/389/events","html_url":"https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/389","id":462151582,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyOTIzNDE5","number":389,"title":"Fix Kubeadm Init and Join NodeRegistration Options","user":{"login":"james65535","id":11385677,"node_id":"MDQ6VXNlcjExMzg1Njc3","avatar_url":"https://avatars2.githubusercontent.com/u/11385677?v=4","gravatar_id":"","url":"https://api.github.com/users/james65535","html_url":"https://github.com/james65535","followers_url":"https://api.github.com/users/james65535/followers","following_url":"https://api.github.com/users/james65535/following{/other_user}","gists_url":"https://api.github.com/users/james65535/gists{/gist_id}","starred_url":"https://api.github.com/users/james65535/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james65535/subscriptions","organizations_url":"https://api.github.com/users/james65535/orgs","repos_url":"https://api.github.com/users/james65535/repos","events_url":"https://api.github.com/users/james65535/events{/privacy}","received_events_url":"https://api.github.com/users/james65535/received_events","type":"User","site_admin":false},"labels":[{"id":1014085420,"node_id":"MDU6TGFiZWwxMDE0MDg1NDIw","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1014081666,"node_id":"MDU6TGFiZWwxMDE0MDgxNjY2","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":1086818449,"node_id":"MDU6TGFiZWwxMDg2ODE4NDQ5","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":1014087364,"node_id":"MDU6TGFiZWwxMDE0MDg3MzY0","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2019-06-28T18:11:53Z","updated_at":"2019-06-28T18:31:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/pulls/389","html_url":"https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/389","diff_url":"https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/389.diff","patch_url":"https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/389.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nKubeadm init and join Node Registration options currently overwrites values passed in through the provider config.  This fix replaces the NewNodeRegistration function so that it does not start with empty Node Registration Options"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/issues/comments/506835193","html_url":"https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/389#issuecomment-506835193","issue_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api-provider-vsphere/issues/389","id":506835193,"node_id":"MDEyOklzc3VlQ29tbWVudDUwNjgzNTE5Mw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-06-28T18:31:47Z","updated_at":"2019-06-28T18:31:47Z","author_association":"CONTRIBUTOR","body":"@james65535: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-cluster-api-provider-vsphere-test | fb4fd6f611bfc7a0e6cd0ccf8e74ed5963a19086 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-vsphere/389/pull-cluster-api-provider-vsphere-test/1144670614896775175) | `/test pull-cluster-api-provider-vsphere-test`\npull-cluster-api-provider-vsphere-e2e | fb4fd6f611bfc7a0e6cd0ccf8e74ed5963a19086 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-vsphere/389/pull-cluster-api-provider-vsphere-e2e/1144670614917746688) | `/test pull-cluster-api-provider-vsphere-e2e`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes-sigs&repo=cluster-api-provider-vsphere&pr=389). [Your PR dashboard](https://gubernator.k8s.io/pr/james65535). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}