{"action":"created","issue":{"url":"https://api.github.com/repos/rapidsai/cudf/issues/1005","repository_url":"https://api.github.com/repos/rapidsai/cudf","labels_url":"https://api.github.com/repos/rapidsai/cudf/issues/1005/labels{/name}","comments_url":"https://api.github.com/repos/rapidsai/cudf/issues/1005/comments","events_url":"https://api.github.com/repos/rapidsai/cudf/issues/1005/events","html_url":"https://github.com/rapidsai/cudf/pull/1005","id":412413111,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NjI3MDky","number":1005,"title":"[WIP] libcudf reductions should support non-arithmetic types for some operations","user":{"login":"kovaltan","id":45648273,"node_id":"MDQ6VXNlcjQ1NjQ4Mjcz","avatar_url":"https://avatars2.githubusercontent.com/u/45648273?v=4","gravatar_id":"","url":"https://api.github.com/users/kovaltan","html_url":"https://github.com/kovaltan","followers_url":"https://api.github.com/users/kovaltan/followers","following_url":"https://api.github.com/users/kovaltan/following{/other_user}","gists_url":"https://api.github.com/users/kovaltan/gists{/gist_id}","starred_url":"https://api.github.com/users/kovaltan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kovaltan/subscriptions","organizations_url":"https://api.github.com/users/kovaltan/orgs","repos_url":"https://api.github.com/users/kovaltan/repos","events_url":"https://api.github.com/users/kovaltan/events{/privacy}","received_events_url":"https://api.github.com/users/kovaltan/received_events","type":"User","site_admin":false},"labels":[{"id":1013987503,"node_id":"MDU6TGFiZWwxMDEzOTg3NTAz","url":"https://api.github.com/repos/rapidsai/cudf/labels/2%20-%20In%20Progress","name":"2 - In Progress","color":"fef2c0","default":false},{"id":1139740666,"node_id":"MDU6TGFiZWwxMTM5NzQwNjY2","url":"https://api.github.com/repos/rapidsai/cudf/labels/libcudf%20(C++/CUDA)","name":"libcudf (C++/CUDA)","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-02-20T13:00:24Z","updated_at":"2019-02-27T18:58:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/1005","html_url":"https://github.com/rapidsai/cudf/pull/1005","diff_url":"https://github.com/rapidsai/cudf/pull/1005.diff","patch_url":"https://github.com/rapidsai/cudf/pull/1005.patch"},"body":"`gdf_min` and `gdf_max` do not support non-arithmetic types, e.g., `GDF_CATEGORY`, `GDF_DATE32`, `GDF_DATE64`, `GDF_CATEGORY`, `GDF_TIMESTAMP`.\r\n\r\nCloses #954\r\n\r\n- [x] Add  `min`, `max` operation support for non-arithmetic types\r\n- [ ] Add test cases for non-arithmetic types (gtest)\r\n- [ ] Use single stage reduction using atomic operation\r\n- [ ] Remove `gdf_reduce_optimal_output_size` since it is required for 2-step reduction\r\n- [ ] merge APIs to a single generic `gdf_reduction`"},"comment":{"url":"https://api.github.com/repos/rapidsai/cudf/issues/comments/467987022","html_url":"https://github.com/rapidsai/cudf/pull/1005#issuecomment-467987022","issue_url":"https://api.github.com/repos/rapidsai/cudf/issues/1005","id":467987022,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2Nzk4NzAyMg==","user":{"login":"jrhemstad","id":15221289,"node_id":"MDQ6VXNlcjE1MjIxMjg5","avatar_url":"https://avatars1.githubusercontent.com/u/15221289?v=4","gravatar_id":"","url":"https://api.github.com/users/jrhemstad","html_url":"https://github.com/jrhemstad","followers_url":"https://api.github.com/users/jrhemstad/followers","following_url":"https://api.github.com/users/jrhemstad/following{/other_user}","gists_url":"https://api.github.com/users/jrhemstad/gists{/gist_id}","starred_url":"https://api.github.com/users/jrhemstad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrhemstad/subscriptions","organizations_url":"https://api.github.com/users/jrhemstad/orgs","repos_url":"https://api.github.com/users/jrhemstad/repos","events_url":"https://api.github.com/users/jrhemstad/events{/privacy}","received_events_url":"https://api.github.com/users/jrhemstad/received_events","type":"User","site_admin":false},"created_at":"2019-02-27T18:58:47Z","updated_at":"2019-02-27T18:58:47Z","author_association":"CONTRIBUTOR","body":"See https://github.com/rapidsai/cudf/pull/892/files#diff-4b0b6cd3d7dabc1501cc00b5b13d9370R93 for `gdf_scalar` which should be used for the return value of a reduction. "}}
{"actor":{"display_login":"jrhemstad"}}