{"action":"created","comment":{"url":"https://api.github.com/repos/v3io/prometheus/pulls/comments/273956934","pull_request_review_id":224967477,"id":273956934,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Mzk1NjkzNA==","diff_hunk":"@@ -100,28 +100,34 @@ func (promQuery *V3ioPromQuerier) Select(params *storage.SelectParams, oms ...*l\n \t}\n \n \tpromQuery.logger.Debug(\"SelectParams: %+v\", params)\n+\toverTimeSuffix := \"_over_time\"\n \n \tif params.Func != \"\" {\n \t\t// only pass xx_over_time functions (just the xx part)\n \t\t// TODO: support count/stdxx, require changes in Prometheus: promql/functions.go, not calc aggregate twice\n-\t\tif strings.HasSuffix(params.Func, \"_over_time\") {\n-\t\t\tf := params.Func[0:3]\n-\t\t\tif params.Step == 0 && (f == \"min\" || f == \"max\" || f == \"sum\" || f == \"avg\") {\n-\t\t\t\tfunctions = f\n+\t\tif strings.HasSuffix(params.Func, overTimeSuffix) {\n+\t\t\tif promQuery.UseAggregates && promQuery.UseAggregatesConfig {\n+\t\t\t\tfunctions = strings.TrimSuffix(params.Func, overTimeSuffix)\n \t\t\t} else {\n-\t\t\t\tnoAggr = true\n+\t\t\t\tf := params.Func[0:3]\n+\t\t\t\tif params.Step == 0 && (f == \"min\" || f == \"max\" || f == \"sum\" || f == \"avg\") {","path":"storage/tsdb/promtsdb.go","position":19,"original_position":19,"commit_id":"cd4590e59c5bf731bea3e95b88368c951f6b5825","original_commit_id":"cd4590e59c5bf731bea3e95b88368c951f6b5825","user":{"login":"gtopper","id":4675524,"node_id":"MDQ6VXNlcjQ2NzU1MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4675524?v=4","gravatar_id":"","url":"https://api.github.com/users/gtopper","html_url":"https://github.com/gtopper","followers_url":"https://api.github.com/users/gtopper/followers","following_url":"https://api.github.com/users/gtopper/following{/other_user}","gists_url":"https://api.github.com/users/gtopper/gists{/gist_id}","starred_url":"https://api.github.com/users/gtopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtopper/subscriptions","organizations_url":"https://api.github.com/users/gtopper/orgs","repos_url":"https://api.github.com/users/gtopper/repos","events_url":"https://api.github.com/users/gtopper/events{/privacy}","received_events_url":"https://api.github.com/users/gtopper/received_events","type":"User","site_admin":false},"body":"Not really safe... Could be called `summary`, and that starts with `sum`... But not a regression in this PR.","created_at":"2019-04-10T13:25:34Z","updated_at":"2019-04-10T13:25:34Z","html_url":"https://github.com/v3io/prometheus/pull/36#discussion_r273956934","pull_request_url":"https://api.github.com/repos/v3io/prometheus/pulls/36","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/v3io/prometheus/pulls/comments/273956934"},"html":{"href":"https://github.com/v3io/prometheus/pull/36#discussion_r273956934"},"pull_request":{"href":"https://api.github.com/repos/v3io/prometheus/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/v3io/prometheus/pulls/36","id":269131741,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5MTMxNzQx","html_url":"https://github.com/v3io/prometheus/pull/36","diff_url":"https://github.com/v3io/prometheus/pull/36.diff","patch_url":"https://github.com/v3io/prometheus/pull/36.patch","issue_url":"https://api.github.com/repos/v3io/prometheus/issues/36","number":36,"state":"open","locked":false,"title":"Support v3io over-time aggregations","user":{"login":"talIguaz","id":33829179,"node_id":"MDQ6VXNlcjMzODI5MTc5","avatar_url":"https://avatars1.githubusercontent.com/u/33829179?v=4","gravatar_id":"","url":"https://api.github.com/users/talIguaz","html_url":"https://github.com/talIguaz","followers_url":"https://api.github.com/users/talIguaz/followers","following_url":"https://api.github.com/users/talIguaz/following{/other_user}","gists_url":"https://api.github.com/users/talIguaz/gists{/gist_id}","starred_url":"https://api.github.com/users/talIguaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talIguaz/subscriptions","organizations_url":"https://api.github.com/users/talIguaz/orgs","repos_url":"https://api.github.com/users/talIguaz/repos","events_url":"https://api.github.com/users/talIguaz/events{/privacy}","received_events_url":"https://api.github.com/users/talIguaz/received_events","type":"User","site_admin":false},"body":"* Bump tsdb to 0.9\r\n* support v3io aggregations for `<aggr>_over_time`","created_at":"2019-04-10T12:02:04Z","updated_at":"2019-04-10T13:25:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"308db17211d88ec317bcb6df2b011e85eee13002","assignee":{"login":"gtopper","id":4675524,"node_id":"MDQ6VXNlcjQ2NzU1MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4675524?v=4","gravatar_id":"","url":"https://api.github.com/users/gtopper","html_url":"https://github.com/gtopper","followers_url":"https://api.github.com/users/gtopper/followers","following_url":"https://api.github.com/users/gtopper/following{/other_user}","gists_url":"https://api.github.com/users/gtopper/gists{/gist_id}","starred_url":"https://api.github.com/users/gtopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtopper/subscriptions","organizations_url":"https://api.github.com/users/gtopper/orgs","repos_url":"https://api.github.com/users/gtopper/repos","events_url":"https://api.github.com/users/gtopper/events{/privacy}","received_events_url":"https://api.github.com/users/gtopper/received_events","type":"User","site_admin":false},"assignees":[{"login":"gtopper","id":4675524,"node_id":"MDQ6VXNlcjQ2NzU1MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4675524?v=4","gravatar_id":"","url":"https://api.github.com/users/gtopper","html_url":"https://github.com/gtopper","followers_url":"https://api.github.com/users/gtopper/followers","following_url":"https://api.github.com/users/gtopper/following{/other_user}","gists_url":"https://api.github.com/users/gtopper/gists{/gist_id}","starred_url":"https://api.github.com/users/gtopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtopper/subscriptions","organizations_url":"https://api.github.com/users/gtopper/orgs","repos_url":"https://api.github.com/users/gtopper/repos","events_url":"https://api.github.com/users/gtopper/events{/privacy}","received_events_url":"https://api.github.com/users/gtopper/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/v3io/prometheus/pulls/36/commits","review_comments_url":"https://api.github.com/repos/v3io/prometheus/pulls/36/comments","review_comment_url":"https://api.github.com/repos/v3io/prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/v3io/prometheus/issues/36/comments","statuses_url":"https://api.github.com/repos/v3io/prometheus/statuses/cd4590e59c5bf731bea3e95b88368c951f6b5825","head":{"label":"talIguaz:over-time-aggregations","ref":"over-time-aggregations","sha":"cd4590e59c5bf731bea3e95b88368c951f6b5825","user":{"login":"talIguaz","id":33829179,"node_id":"MDQ6VXNlcjMzODI5MTc5","avatar_url":"https://avatars1.githubusercontent.com/u/33829179?v=4","gravatar_id":"","url":"https://api.github.com/users/talIguaz","html_url":"https://github.com/talIguaz","followers_url":"https://api.github.com/users/talIguaz/followers","following_url":"https://api.github.com/users/talIguaz/following{/other_user}","gists_url":"https://api.github.com/users/talIguaz/gists{/gist_id}","starred_url":"https://api.github.com/users/talIguaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talIguaz/subscriptions","organizations_url":"https://api.github.com/users/talIguaz/orgs","repos_url":"https://api.github.com/users/talIguaz/repos","events_url":"https://api.github.com/users/talIguaz/events{/privacy}","received_events_url":"https://api.github.com/users/talIguaz/received_events","type":"User","site_admin":false},"repo":{"id":167464338,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc0NjQzMzg=","name":"prometheus","full_name":"talIguaz/prometheus","private":false,"owner":{"login":"talIguaz","id":33829179,"node_id":"MDQ6VXNlcjMzODI5MTc5","avatar_url":"https://avatars1.githubusercontent.com/u/33829179?v=4","gravatar_id":"","url":"https://api.github.com/users/talIguaz","html_url":"https://github.com/talIguaz","followers_url":"https://api.github.com/users/talIguaz/followers","following_url":"https://api.github.com/users/talIguaz/following{/other_user}","gists_url":"https://api.github.com/users/talIguaz/gists{/gist_id}","starred_url":"https://api.github.com/users/talIguaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talIguaz/subscriptions","organizations_url":"https://api.github.com/users/talIguaz/orgs","repos_url":"https://api.github.com/users/talIguaz/repos","events_url":"https://api.github.com/users/talIguaz/events{/privacy}","received_events_url":"https://api.github.com/users/talIguaz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/talIguaz/prometheus","description":"The Prometheus monitoring system and time series database.","fork":true,"url":"https://api.github.com/repos/talIguaz/prometheus","forks_url":"https://api.github.com/repos/talIguaz/prometheus/forks","keys_url":"https://api.github.com/repos/talIguaz/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talIguaz/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talIguaz/prometheus/teams","hooks_url":"https://api.github.com/repos/talIguaz/prometheus/hooks","issue_events_url":"https://api.github.com/repos/talIguaz/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/talIguaz/prometheus/events","assignees_url":"https://api.github.com/repos/talIguaz/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/talIguaz/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/talIguaz/prometheus/tags","blobs_url":"https://api.github.com/repos/talIguaz/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talIguaz/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talIguaz/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/talIguaz/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talIguaz/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/talIguaz/prometheus/languages","stargazers_url":"https://api.github.com/repos/talIguaz/prometheus/stargazers","contributors_url":"https://api.github.com/repos/talIguaz/prometheus/contributors","subscribers_url":"https://api.github.com/repos/talIguaz/prometheus/subscribers","subscription_url":"https://api.github.com/repos/talIguaz/prometheus/subscription","commits_url":"https://api.github.com/repos/talIguaz/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/talIguaz/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/talIguaz/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/talIguaz/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/talIguaz/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/talIguaz/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talIguaz/prometheus/merges","archive_url":"https://api.github.com/repos/talIguaz/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talIguaz/prometheus/downloads","issues_url":"https://api.github.com/repos/talIguaz/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/talIguaz/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/talIguaz/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/talIguaz/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talIguaz/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/talIguaz/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/talIguaz/prometheus/deployments","created_at":"2019-01-25T01:25:00Z","updated_at":"2019-01-25T01:25:05Z","pushed_at":"2019-04-10T13:15:22Z","git_url":"git://github.com/talIguaz/prometheus.git","ssh_url":"git@github.com:talIguaz/prometheus.git","clone_url":"https://github.com/talIguaz/prometheus.git","svn_url":"https://github.com/talIguaz/prometheus","homepage":"https://prometheus.io/","size":63662,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"v3io:development","ref":"development","sha":"0585ec91f8493759c8f5138b07192dd561b3784d","user":{"login":"v3io","id":23224979,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjI0OTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23224979?v=4","gravatar_id":"","url":"https://api.github.com/users/v3io","html_url":"https://github.com/v3io","followers_url":"https://api.github.com/users/v3io/followers","following_url":"https://api.github.com/users/v3io/following{/other_user}","gists_url":"https://api.github.com/users/v3io/gists{/gist_id}","starred_url":"https://api.github.com/users/v3io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v3io/subscriptions","organizations_url":"https://api.github.com/users/v3io/orgs","repos_url":"https://api.github.com/users/v3io/repos","events_url":"https://api.github.com/users/v3io/events{/privacy}","received_events_url":"https://api.github.com/users/v3io/received_events","type":"Organization","site_admin":false},"repo":{"id":123961104,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5NjExMDQ=","name":"prometheus","full_name":"v3io/prometheus","private":false,"owner":{"login":"v3io","id":23224979,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjI0OTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23224979?v=4","gravatar_id":"","url":"https://api.github.com/users/v3io","html_url":"https://github.com/v3io","followers_url":"https://api.github.com/users/v3io/followers","following_url":"https://api.github.com/users/v3io/following{/other_user}","gists_url":"https://api.github.com/users/v3io/gists{/gist_id}","starred_url":"https://api.github.com/users/v3io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v3io/subscriptions","organizations_url":"https://api.github.com/users/v3io/orgs","repos_url":"https://api.github.com/users/v3io/repos","events_url":"https://api.github.com/users/v3io/events{/privacy}","received_events_url":"https://api.github.com/users/v3io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/v3io/prometheus","description":"The Prometheus monitoring system and time series database.","fork":true,"url":"https://api.github.com/repos/v3io/prometheus","forks_url":"https://api.github.com/repos/v3io/prometheus/forks","keys_url":"https://api.github.com/repos/v3io/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/v3io/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/v3io/prometheus/teams","hooks_url":"https://api.github.com/repos/v3io/prometheus/hooks","issue_events_url":"https://api.github.com/repos/v3io/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/v3io/prometheus/events","assignees_url":"https://api.github.com/repos/v3io/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/v3io/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/v3io/prometheus/tags","blobs_url":"https://api.github.com/repos/v3io/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/v3io/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/v3io/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/v3io/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/v3io/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/v3io/prometheus/languages","stargazers_url":"https://api.github.com/repos/v3io/prometheus/stargazers","contributors_url":"https://api.github.com/repos/v3io/prometheus/contributors","subscribers_url":"https://api.github.com/repos/v3io/prometheus/subscribers","subscription_url":"https://api.github.com/repos/v3io/prometheus/subscription","commits_url":"https://api.github.com/repos/v3io/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/v3io/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/v3io/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/v3io/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/v3io/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/v3io/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/v3io/prometheus/merges","archive_url":"https://api.github.com/repos/v3io/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/v3io/prometheus/downloads","issues_url":"https://api.github.com/repos/v3io/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/v3io/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/v3io/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/v3io/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/v3io/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/v3io/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/v3io/prometheus/deployments","created_at":"2018-03-05T18:30:07Z","updated_at":"2019-04-10T11:40:16Z","pushed_at":"2019-04-10T13:15:26Z","git_url":"git://github.com/v3io/prometheus.git","ssh_url":"git@github.com:v3io/prometheus.git","clone_url":"https://github.com/v3io/prometheus.git","svn_url":"https://github.com/v3io/prometheus","homepage":"https://prometheus.io/","size":63630,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/v3io/prometheus/pulls/36"},"html":{"href":"https://github.com/v3io/prometheus/pull/36"},"issue":{"href":"https://api.github.com/repos/v3io/prometheus/issues/36"},"comments":{"href":"https://api.github.com/repos/v3io/prometheus/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/v3io/prometheus/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/v3io/prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/v3io/prometheus/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/v3io/prometheus/statuses/cd4590e59c5bf731bea3e95b88368c951f6b5825"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gtopper"}}