{"action":"created","comment":{"url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/comments/365754041","pull_request_review_id":341777831,"id":365754041,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTc1NDA0MQ==","diff_hunk":"@@ -109,6 +112,17 @@ def check_attribute_name(self, node: ast.ClassDef) -> None:\n                     naming.UpperCaseAttributeViolation(target, text=target.id),\n                 )\n \n+    @property","path":"wemake_python_styleguide/visitors/ast/naming.py","position":39,"original_position":39,"commit_id":"2013802e2547e6a546b0778bbb358f6f706ee374","original_commit_id":"2013802e2547e6a546b0778bbb358f6f706ee374","user":{"login":"sobolevn","id":4660275,"node_id":"MDQ6VXNlcjQ2NjAyNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/4660275?v=4","gravatar_id":"","url":"https://api.github.com/users/sobolevn","html_url":"https://github.com/sobolevn","followers_url":"https://api.github.com/users/sobolevn/followers","following_url":"https://api.github.com/users/sobolevn/following{/other_user}","gists_url":"https://api.github.com/users/sobolevn/gists{/gist_id}","starred_url":"https://api.github.com/users/sobolevn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobolevn/subscriptions","organizations_url":"https://api.github.com/users/sobolevn/orgs","repos_url":"https://api.github.com/users/sobolevn/repos","events_url":"https://api.github.com/users/sobolevn/events{/privacy}","received_events_url":"https://api.github.com/users/sobolevn/received_events","type":"User","site_admin":false},"body":"It can be:\r\n1. Cached\r\n2. Moved to `logic/`","created_at":"2020-01-13T11:23:20Z","updated_at":"2020-01-13T11:24:10Z","html_url":"https://github.com/wemake-services/wemake-python-styleguide/pull/1106#discussion_r365754041","pull_request_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/1106","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/comments/365754041"},"html":{"href":"https://github.com/wemake-services/wemake-python-styleguide/pull/1106#discussion_r365754041"},"pull_request":{"href":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/1106"}}},"pull_request":{"url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/1106","id":362053500,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYyMDUzNTAw","html_url":"https://github.com/wemake-services/wemake-python-styleguide/pull/1106","diff_url":"https://github.com/wemake-services/wemake-python-styleguide/pull/1106.diff","patch_url":"https://github.com/wemake-services/wemake-python-styleguide/pull/1106.patch","issue_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/issues/1106","number":1106,"state":"open","locked":false,"title":"add new domain names options","user":{"login":"skarzi","id":9096146,"node_id":"MDQ6VXNlcjkwOTYxNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/9096146?v=4","gravatar_id":"","url":"https://api.github.com/users/skarzi","html_url":"https://github.com/skarzi","followers_url":"https://api.github.com/users/skarzi/followers","following_url":"https://api.github.com/users/skarzi/following{/other_user}","gists_url":"https://api.github.com/users/skarzi/gists{/gist_id}","starred_url":"https://api.github.com/users/skarzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skarzi/subscriptions","organizations_url":"https://api.github.com/users/skarzi/orgs","repos_url":"https://api.github.com/users/skarzi/repos","events_url":"https://api.github.com/users/skarzi/events{/privacy}","received_events_url":"https://api.github.com/users/skarzi/received_events","type":"User","site_admin":false},"body":"# I have made things!\r\n\r\n<!--\r\nHi, thanks for submitting a Pull Request. We appreciate it.\r\n\r\nPlease, fill in all the required information\r\nto make our review and merging processes easier.\r\n\r\nCheers!\r\n-->\r\n\r\n## Checklist\r\n\r\n<!-- Please check everything that applies: -->\r\n\r\n- [x] I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)\r\n- [x] I have created at least one test case for the changes I have made\r\n- [x] I have updated the documentation for the changes I have made\r\n- [ ] I have added my changes to the `CHANGELOG.md`\r\n\r\n## Related issue\r\n\r\n<!--\r\nMark what issues this Pull Request closes or references.\r\n\r\nFormat is:\r\n- Closes #issue-number\r\n- Refs #issue-number\r\n\r\nExample. Refs #0\r\nDocumentation: https://blog.github.com/2013-05-14-closing-issues-via-pull-requests/\r\n-->\r\nCloses: #1103 \r\n<!--\r\nIf you have any feedback, just write it here.\r\n\r\nIt can be whatever you want!\r\n-->\r\n\r\nIntroduce 2 new options:\r\n    \r\n+ `--allowed-domain-names` - remove given names from variable names'\r\n   blacklist\r\n+ `--forbidden-domain-names` - extends variable names' blacklist with\r\n   given names\r\n    \r\nThe options listed above are used to create variable names' blacklist\r\nwhich is leveraged to detect `WrongVariableNameViolation` violations.\r\n","created_at":"2020-01-13T10:54:53Z","updated_at":"2020-01-13T11:24:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d77e7fa012eceba4e4574b913faf6565801d655","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/1106/commits","review_comments_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/1106/comments","review_comment_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/issues/1106/comments","statuses_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/statuses/2013802e2547e6a546b0778bbb358f6f706ee374","head":{"label":"skarzi:issue-1103","ref":"issue-1103","sha":"2013802e2547e6a546b0778bbb358f6f706ee374","user":{"login":"skarzi","id":9096146,"node_id":"MDQ6VXNlcjkwOTYxNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/9096146?v=4","gravatar_id":"","url":"https://api.github.com/users/skarzi","html_url":"https://github.com/skarzi","followers_url":"https://api.github.com/users/skarzi/followers","following_url":"https://api.github.com/users/skarzi/following{/other_user}","gists_url":"https://api.github.com/users/skarzi/gists{/gist_id}","starred_url":"https://api.github.com/users/skarzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skarzi/subscriptions","organizations_url":"https://api.github.com/users/skarzi/orgs","repos_url":"https://api.github.com/users/skarzi/repos","events_url":"https://api.github.com/users/skarzi/events{/privacy}","received_events_url":"https://api.github.com/users/skarzi/received_events","type":"User","site_admin":false},"repo":{"id":233373075,"node_id":"MDEwOlJlcG9zaXRvcnkyMzMzNzMwNzU=","name":"wemake-python-styleguide","full_name":"skarzi/wemake-python-styleguide","private":false,"owner":{"login":"skarzi","id":9096146,"node_id":"MDQ6VXNlcjkwOTYxNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/9096146?v=4","gravatar_id":"","url":"https://api.github.com/users/skarzi","html_url":"https://github.com/skarzi","followers_url":"https://api.github.com/users/skarzi/followers","following_url":"https://api.github.com/users/skarzi/following{/other_user}","gists_url":"https://api.github.com/users/skarzi/gists{/gist_id}","starred_url":"https://api.github.com/users/skarzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skarzi/subscriptions","organizations_url":"https://api.github.com/users/skarzi/orgs","repos_url":"https://api.github.com/users/skarzi/repos","events_url":"https://api.github.com/users/skarzi/events{/privacy}","received_events_url":"https://api.github.com/users/skarzi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/skarzi/wemake-python-styleguide","description":"The strictest and most opinionated python linter ever!","fork":true,"url":"https://api.github.com/repos/skarzi/wemake-python-styleguide","forks_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/forks","keys_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/teams","hooks_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/hooks","issue_events_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/events","assignees_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/tags","blobs_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/languages","stargazers_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/stargazers","contributors_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/contributors","subscribers_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/subscribers","subscription_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/subscription","commits_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/merges","archive_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/downloads","issues_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/labels{/name}","releases_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/releases{/id}","deployments_url":"https://api.github.com/repos/skarzi/wemake-python-styleguide/deployments","created_at":"2020-01-12T10:15:07Z","updated_at":"2020-01-12T10:15:09Z","pushed_at":"2020-01-13T11:18:32Z","git_url":"git://github.com/skarzi/wemake-python-styleguide.git","ssh_url":"git@github.com:skarzi/wemake-python-styleguide.git","clone_url":"https://github.com/skarzi/wemake-python-styleguide.git","svn_url":"https://github.com/skarzi/wemake-python-styleguide","homepage":"https://wemake-python-stylegui.de","size":5019,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wemake-services:master","ref":"master","sha":"b8b99403564b4efc29a766c2eb2a857caab3dba5","user":{"login":"wemake-services","id":19639014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjM5MDE0","avatar_url":"https://avatars2.githubusercontent.com/u/19639014?v=4","gravatar_id":"","url":"https://api.github.com/users/wemake-services","html_url":"https://github.com/wemake-services","followers_url":"https://api.github.com/users/wemake-services/followers","following_url":"https://api.github.com/users/wemake-services/following{/other_user}","gists_url":"https://api.github.com/users/wemake-services/gists{/gist_id}","starred_url":"https://api.github.com/users/wemake-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemake-services/subscriptions","organizations_url":"https://api.github.com/users/wemake-services/orgs","repos_url":"https://api.github.com/users/wemake-services/repos","events_url":"https://api.github.com/users/wemake-services/events{/privacy}","received_events_url":"https://api.github.com/users/wemake-services/received_events","type":"Organization","site_admin":false},"repo":{"id":124593057,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ1OTMwNTc=","name":"wemake-python-styleguide","full_name":"wemake-services/wemake-python-styleguide","private":false,"owner":{"login":"wemake-services","id":19639014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjM5MDE0","avatar_url":"https://avatars2.githubusercontent.com/u/19639014?v=4","gravatar_id":"","url":"https://api.github.com/users/wemake-services","html_url":"https://github.com/wemake-services","followers_url":"https://api.github.com/users/wemake-services/followers","following_url":"https://api.github.com/users/wemake-services/following{/other_user}","gists_url":"https://api.github.com/users/wemake-services/gists{/gist_id}","starred_url":"https://api.github.com/users/wemake-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemake-services/subscriptions","organizations_url":"https://api.github.com/users/wemake-services/orgs","repos_url":"https://api.github.com/users/wemake-services/repos","events_url":"https://api.github.com/users/wemake-services/events{/privacy}","received_events_url":"https://api.github.com/users/wemake-services/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wemake-services/wemake-python-styleguide","description":"The strictest and most opinionated python linter ever!","fork":false,"url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide","forks_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/forks","keys_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/teams","hooks_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/hooks","issue_events_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/events","assignees_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/tags","blobs_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/languages","stargazers_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/stargazers","contributors_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/contributors","subscribers_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/subscribers","subscription_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/subscription","commits_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/merges","archive_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/downloads","issues_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/labels{/name}","releases_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/releases{/id}","deployments_url":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/deployments","created_at":"2018-03-09T21:04:25Z","updated_at":"2020-01-12T13:37:39Z","pushed_at":"2020-01-13T11:18:34Z","git_url":"git://github.com/wemake-services/wemake-python-styleguide.git","ssh_url":"git@github.com:wemake-services/wemake-python-styleguide.git","clone_url":"https://github.com/wemake-services/wemake-python-styleguide.git","svn_url":"https://github.com/wemake-services/wemake-python-styleguide","homepage":"https://wemake-python-stylegui.de","size":5016,"stargazers_count":671,"watchers_count":671,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":49,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":155,"open_issues":49,"watchers":671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/1106"},"html":{"href":"https://github.com/wemake-services/wemake-python-styleguide/pull/1106"},"issue":{"href":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/issues/1106"},"comments":{"href":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/issues/1106/comments"},"review_comments":{"href":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/1106/comments"},"review_comment":{"href":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/pulls/1106/commits"},"statuses":{"href":"https://api.github.com/repos/wemake-services/wemake-python-styleguide/statuses/2013802e2547e6a546b0778bbb358f6f706ee374"}},"author_association":"NONE"}}
{"actor":{"display_login":"sobolevn"}}