{"action":"closed","number":141,"pull_request":{"url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/pulls/141","id":292516674,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyNTE2Njc0","html_url":"https://github.com/mozilla-iot/zigbee-adapter/pull/141","diff_url":"https://github.com/mozilla-iot/zigbee-adapter/pull/141.diff","patch_url":"https://github.com/mozilla-iot/zigbee-adapter/pull/141.patch","issue_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/issues/141","number":141,"state":"closed","locked":false,"title":"Xiaomi Zigbee - Pressure, Motion and illuminance improvements","user":{"login":"Beejeedeb","id":51539492,"node_id":"MDQ6VXNlcjUxNTM5NDky","avatar_url":"https://avatars1.githubusercontent.com/u/51539492?v=4","gravatar_id":"","url":"https://api.github.com/users/Beejeedeb","html_url":"https://github.com/Beejeedeb","followers_url":"https://api.github.com/users/Beejeedeb/followers","following_url":"https://api.github.com/users/Beejeedeb/following{/other_user}","gists_url":"https://api.github.com/users/Beejeedeb/gists{/gist_id}","starred_url":"https://api.github.com/users/Beejeedeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beejeedeb/subscriptions","organizations_url":"https://api.github.com/users/Beejeedeb/orgs","repos_url":"https://api.github.com/users/Beejeedeb/repos","events_url":"https://api.github.com/users/Beejeedeb/events{/privacy}","received_events_url":"https://api.github.com/users/Beejeedeb/received_events","type":"User","site_admin":false},"body":"WSDCGQ11LM (square) changed the pressure part; unit is now hPa with a minimum of 800 and maximum of 1100 and I used ParseNumericAttr for the parseValueFromAttr. Under normal circumstances the atmospheric pressure falls between 800 and 1100 hPa. I have compared the numbers from the pressure sensor with a nearby weather station and the numbers are comparable.\r\n\r\nRTCGQ11LM changed the illuminance part; type is now levelproperty, lux has now a maximum of 1500 and used ParseNumericAttr for the parseValueFromAttr. it is still not very accurate, but it is enough to detect changes in light to act accordingly to it.\r\n\r\nChange label from the motion sensors properties from Occupied to Motion.\r\n\r\nRelates to issues:\r\nhttps://github.com/mozilla-iot/zigbee-adapter/issues/138 \r\nhttps://github.com/mozilla-iot/zigbee-adapter/issues/139","created_at":"2019-06-27T16:38:14Z","updated_at":"2019-06-27T18:50:41Z","closed_at":"2019-06-27T18:50:41Z","merged_at":"2019-06-27T18:50:41Z","merge_commit_sha":"2e53e1465c917b5e5fab19669661b7a28a1e5c4f","assignee":{"login":"Beejeedeb","id":51539492,"node_id":"MDQ6VXNlcjUxNTM5NDky","avatar_url":"https://avatars1.githubusercontent.com/u/51539492?v=4","gravatar_id":"","url":"https://api.github.com/users/Beejeedeb","html_url":"https://github.com/Beejeedeb","followers_url":"https://api.github.com/users/Beejeedeb/followers","following_url":"https://api.github.com/users/Beejeedeb/following{/other_user}","gists_url":"https://api.github.com/users/Beejeedeb/gists{/gist_id}","starred_url":"https://api.github.com/users/Beejeedeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beejeedeb/subscriptions","organizations_url":"https://api.github.com/users/Beejeedeb/orgs","repos_url":"https://api.github.com/users/Beejeedeb/repos","events_url":"https://api.github.com/users/Beejeedeb/events{/privacy}","received_events_url":"https://api.github.com/users/Beejeedeb/received_events","type":"User","site_admin":false},"assignees":[{"login":"Beejeedeb","id":51539492,"node_id":"MDQ6VXNlcjUxNTM5NDky","avatar_url":"https://avatars1.githubusercontent.com/u/51539492?v=4","gravatar_id":"","url":"https://api.github.com/users/Beejeedeb","html_url":"https://github.com/Beejeedeb","followers_url":"https://api.github.com/users/Beejeedeb/followers","following_url":"https://api.github.com/users/Beejeedeb/following{/other_user}","gists_url":"https://api.github.com/users/Beejeedeb/gists{/gist_id}","starred_url":"https://api.github.com/users/Beejeedeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beejeedeb/subscriptions","organizations_url":"https://api.github.com/users/Beejeedeb/orgs","repos_url":"https://api.github.com/users/Beejeedeb/repos","events_url":"https://api.github.com/users/Beejeedeb/events{/privacy}","received_events_url":"https://api.github.com/users/Beejeedeb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/pulls/141/commits","review_comments_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/pulls/141/comments","review_comment_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/issues/141/comments","statuses_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/statuses/7a37636446ea33811d78beebe40b6079896daac0","head":{"label":"Beejeedeb:patch-1","ref":"patch-1","sha":"7a37636446ea33811d78beebe40b6079896daac0","user":{"login":"Beejeedeb","id":51539492,"node_id":"MDQ6VXNlcjUxNTM5NDky","avatar_url":"https://avatars1.githubusercontent.com/u/51539492?v=4","gravatar_id":"","url":"https://api.github.com/users/Beejeedeb","html_url":"https://github.com/Beejeedeb","followers_url":"https://api.github.com/users/Beejeedeb/followers","following_url":"https://api.github.com/users/Beejeedeb/following{/other_user}","gists_url":"https://api.github.com/users/Beejeedeb/gists{/gist_id}","starred_url":"https://api.github.com/users/Beejeedeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beejeedeb/subscriptions","organizations_url":"https://api.github.com/users/Beejeedeb/orgs","repos_url":"https://api.github.com/users/Beejeedeb/repos","events_url":"https://api.github.com/users/Beejeedeb/events{/privacy}","received_events_url":"https://api.github.com/users/Beejeedeb/received_events","type":"User","site_admin":false},"repo":{"id":194098937,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQwOTg5Mzc=","name":"zigbee-adapter","full_name":"Beejeedeb/zigbee-adapter","private":false,"owner":{"login":"Beejeedeb","id":51539492,"node_id":"MDQ6VXNlcjUxNTM5NDky","avatar_url":"https://avatars1.githubusercontent.com/u/51539492?v=4","gravatar_id":"","url":"https://api.github.com/users/Beejeedeb","html_url":"https://github.com/Beejeedeb","followers_url":"https://api.github.com/users/Beejeedeb/followers","following_url":"https://api.github.com/users/Beejeedeb/following{/other_user}","gists_url":"https://api.github.com/users/Beejeedeb/gists{/gist_id}","starred_url":"https://api.github.com/users/Beejeedeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beejeedeb/subscriptions","organizations_url":"https://api.github.com/users/Beejeedeb/orgs","repos_url":"https://api.github.com/users/Beejeedeb/repos","events_url":"https://api.github.com/users/Beejeedeb/events{/privacy}","received_events_url":"https://api.github.com/users/Beejeedeb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Beejeedeb/zigbee-adapter","description":"Zigbee adapter add-on for Mozilla WebThings Gateway","fork":true,"url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter","forks_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/forks","keys_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/teams","hooks_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/hooks","issue_events_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/events","assignees_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/tags","blobs_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/languages","stargazers_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/stargazers","contributors_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/contributors","subscribers_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/subscribers","subscription_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/subscription","commits_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/merges","archive_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/downloads","issues_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/labels{/name}","releases_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/Beejeedeb/zigbee-adapter/deployments","created_at":"2019-06-27T13:17:49Z","updated_at":"2019-06-27T13:17:52Z","pushed_at":"2019-06-27T16:44:09Z","git_url":"git://github.com/Beejeedeb/zigbee-adapter.git","ssh_url":"git@github.com:Beejeedeb/zigbee-adapter.git","clone_url":"https://github.com/Beejeedeb/zigbee-adapter.git","svn_url":"https://github.com/Beejeedeb/zigbee-adapter","homepage":"","size":544,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-iot:master","ref":"master","sha":"e34ebdc1a4b119e494020095875d7f076d0e6fee","user":{"login":"mozilla-iot","id":20707259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzA3MjU5","avatar_url":"https://avatars0.githubusercontent.com/u/20707259?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-iot","html_url":"https://github.com/mozilla-iot","followers_url":"https://api.github.com/users/mozilla-iot/followers","following_url":"https://api.github.com/users/mozilla-iot/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-iot/subscriptions","organizations_url":"https://api.github.com/users/mozilla-iot/orgs","repos_url":"https://api.github.com/users/mozilla-iot/repos","events_url":"https://api.github.com/users/mozilla-iot/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-iot/received_events","type":"Organization","site_admin":false},"repo":{"id":117883296,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4ODMyOTY=","name":"zigbee-adapter","full_name":"mozilla-iot/zigbee-adapter","private":false,"owner":{"login":"mozilla-iot","id":20707259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzA3MjU5","avatar_url":"https://avatars0.githubusercontent.com/u/20707259?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-iot","html_url":"https://github.com/mozilla-iot","followers_url":"https://api.github.com/users/mozilla-iot/followers","following_url":"https://api.github.com/users/mozilla-iot/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-iot/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-iot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-iot/subscriptions","organizations_url":"https://api.github.com/users/mozilla-iot/orgs","repos_url":"https://api.github.com/users/mozilla-iot/repos","events_url":"https://api.github.com/users/mozilla-iot/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-iot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla-iot/zigbee-adapter","description":"Zigbee adapter add-on for Mozilla WebThings Gateway","fork":false,"url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter","forks_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/forks","keys_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/teams","hooks_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/hooks","issue_events_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/events","assignees_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/tags","blobs_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/languages","stargazers_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/stargazers","contributors_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/contributors","subscribers_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/subscribers","subscription_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/subscription","commits_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/merges","archive_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/downloads","issues_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/deployments","created_at":"2018-01-17T19:33:45Z","updated_at":"2019-06-26T18:31:22Z","pushed_at":"2019-06-27T18:50:41Z","git_url":"git://github.com/mozilla-iot/zigbee-adapter.git","ssh_url":"git@github.com:mozilla-iot/zigbee-adapter.git","clone_url":"https://github.com/mozilla-iot/zigbee-adapter.git","svn_url":"https://github.com/mozilla-iot/zigbee-adapter","homepage":"","size":537,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":34,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":11,"open_issues":34,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/pulls/141"},"html":{"href":"https://github.com/mozilla-iot/zigbee-adapter/pull/141"},"issue":{"href":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/issues/141"},"comments":{"href":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-iot/zigbee-adapter/statuses/7a37636446ea33811d78beebe40b6079896daac0"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dhylands","id":127500,"node_id":"MDQ6VXNlcjEyNzUwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/127500?v=4","gravatar_id":"","url":"https://api.github.com/users/dhylands","html_url":"https://github.com/dhylands","followers_url":"https://api.github.com/users/dhylands/followers","following_url":"https://api.github.com/users/dhylands/following{/other_user}","gists_url":"https://api.github.com/users/dhylands/gists{/gist_id}","starred_url":"https://api.github.com/users/dhylands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhylands/subscriptions","organizations_url":"https://api.github.com/users/dhylands/orgs","repos_url":"https://api.github.com/users/dhylands/repos","events_url":"https://api.github.com/users/dhylands/events{/privacy}","received_events_url":"https://api.github.com/users/dhylands/received_events","type":"User","site_admin":false},"comments":1,"review_comments":7,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":14,"changed_files":1}}
{"actor":{"display_login":"dhylands"}}