{"action":"opened","issue":{"url":"https://api.github.com/repos/creativesoftwarefdn/weaviate/issues/726","repository_url":"https://api.github.com/repos/creativesoftwarefdn/weaviate","labels_url":"https://api.github.com/repos/creativesoftwarefdn/weaviate/issues/726/labels{/name}","comments_url":"https://api.github.com/repos/creativesoftwarefdn/weaviate/issues/726/comments","events_url":"https://api.github.com/repos/creativesoftwarefdn/weaviate/issues/726/events","html_url":"https://github.com/creativesoftwarefdn/weaviate/issues/726","id":412958100,"node_id":"MDU6SXNzdWU0MTI5NTgxMDA=","number":726,"title":"Feature flag location for Monitoring Service","user":{"login":"JeroenStravers1","id":9214481,"node_id":"MDQ6VXNlcjkyMTQ0ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/9214481?v=4","gravatar_id":"","url":"https://api.github.com/users/JeroenStravers1","html_url":"https://github.com/JeroenStravers1","followers_url":"https://api.github.com/users/JeroenStravers1/followers","following_url":"https://api.github.com/users/JeroenStravers1/following{/other_user}","gists_url":"https://api.github.com/users/JeroenStravers1/gists{/gist_id}","starred_url":"https://api.github.com/users/JeroenStravers1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeroenStravers1/subscriptions","organizations_url":"https://api.github.com/users/JeroenStravers1/orgs","repos_url":"https://api.github.com/users/JeroenStravers1/repos","events_url":"https://api.github.com/users/JeroenStravers1/events{/privacy}","received_events_url":"https://api.github.com/users/JeroenStravers1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-02-21T14:40:36Z","updated_at":"2019-02-21T14:40:36Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### Issue\r\nI put the monitoring service feature flag in `tools/dev/conf.json` and I'm encountering an \"issue\" in the way reading the config file is handled (it's not wrong, it just doesn't suit my needs). \r\n\r\nReally short version: the config (and thereby my flag) is only accessible at runtime as which config environment is chosen relies on command line args. Since all monitoring functions check the state of the flag this effectively precludes the use of unit tests for the monitoring service; I'd need a running Weaviate instance.\r\n\r\n### Options\r\nI can't find another logical spot for config items in our codebase, so I see two options:\r\n- all my tests will be acceptance tests. At over 10 mins per test run this does not seem optimal.\r\n- I find a new place for the flag. I'd suggest putting the flag conf file in the monitoring folder. \r\nThis means deviating from the provided location (the json conf), which is why I don't want to just unilaterally decide.\r\n\r\nThe location will of course be documented. \r\n\r\n### Current solution\r\nI'm using basic [constants](https://github.com/creativesoftwarefdn/weaviate/blob/feature/monitoring-service/telemetry/utils/toggle.go) as an intermediate solution.\r\n\r\n\r\nThoughts @etiennedi @bobvanluijt?\r\n\r\nRelated to #699 "}}
{"actor":{"display_login":"JeroenStravers1"}}