{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/comments/290892454","pull_request_review_id":246203566,"id":290892454,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDg5MjQ1NA==","diff_hunk":"@@ -10,9 +10,9 @@ The Application Gateway Ingress controller runs as pod within the AKS cluster. I\n \n In order to install the ingress controller on AKS we use [Helm](https://docs.microsoft.com/en-us/azure/aks/kubernetes-helm).\n \n-## Assumptions","path":"docs/install-existing.md","position":11,"original_position":4,"commit_id":"ee4a1f1326047ed2c63fce32e2c85171ba0444a7","original_commit_id":"36e3b01b3de3e04672d7fd72d18fff109229022a","user":{"login":"draychev","id":49918230,"node_id":"MDQ6VXNlcjQ5OTE4MjMw","avatar_url":"https://avatars1.githubusercontent.com/u/49918230?v=4","gravatar_id":"","url":"https://api.github.com/users/draychev","html_url":"https://github.com/draychev","followers_url":"https://api.github.com/users/draychev/followers","following_url":"https://api.github.com/users/draychev/following{/other_user}","gists_url":"https://api.github.com/users/draychev/gists{/gist_id}","starred_url":"https://api.github.com/users/draychev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draychev/subscriptions","organizations_url":"https://api.github.com/users/draychev/orgs","repos_url":"https://api.github.com/users/draychev/repos","events_url":"https://api.github.com/users/draychev/events{/privacy}","received_events_url":"https://api.github.com/users/draychev/received_events","type":"User","site_admin":false},"body":"Good catch!  We need a markdown static analyzer to catch these things automatically. 🔜 ","created_at":"2019-06-05T19:11:22Z","updated_at":"2019-06-05T19:11:22Z","html_url":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/249#discussion_r290892454","pull_request_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/249","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/comments/290892454"},"html":{"href":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/249#discussion_r290892454"},"pull_request":{"href":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/249"}},"in_reply_to_id":290890064},"pull_request":{"url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/249","id":285509471,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1NTA5NDcx","html_url":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/249","diff_url":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/249.diff","patch_url":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/249.patch","issue_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/249","number":249,"state":"open","locked":false,"title":"Updating documentation to remove the constraint on Autoscale-disabled App Gateway; Fixes #245","user":{"login":"draychev","id":49918230,"node_id":"MDQ6VXNlcjQ5OTE4MjMw","avatar_url":"https://avatars1.githubusercontent.com/u/49918230?v=4","gravatar_id":"","url":"https://api.github.com/users/draychev","html_url":"https://github.com/draychev","followers_url":"https://api.github.com/users/draychev/followers","following_url":"https://api.github.com/users/draychev/following{/other_user}","gists_url":"https://api.github.com/users/draychev/gists{/gist_id}","starred_url":"https://api.github.com/users/draychev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draychev/subscriptions","organizations_url":"https://api.github.com/users/draychev/orgs","repos_url":"https://api.github.com/users/draychev/repos","events_url":"https://api.github.com/users/draychev/events{/privacy}","received_events_url":"https://api.github.com/users/draychev/received_events","type":"User","site_admin":false},"body":"In December 2018 when we used an older version of the underlying SDK we had to ensure we don't accidentally disable autoscale. So this blurb was added to the documentation.\r\nAs we discovered in https://github.com/Azure/application-gateway-kubernetes-ingress/issues/245 - this is no longer the case.\r\n\r\nAGIC can work with Auto-scale enabled App Gateways as well.","created_at":"2019-06-05T19:01:49Z","updated_at":"2019-06-05T19:11:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7aa65a7cffab8417769863e5fba2762631d885d8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asridharan","id":3128730,"node_id":"MDQ6VXNlcjMxMjg3MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/3128730?v=4","gravatar_id":"","url":"https://api.github.com/users/asridharan","html_url":"https://github.com/asridharan","followers_url":"https://api.github.com/users/asridharan/followers","following_url":"https://api.github.com/users/asridharan/following{/other_user}","gists_url":"https://api.github.com/users/asridharan/gists{/gist_id}","starred_url":"https://api.github.com/users/asridharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asridharan/subscriptions","organizations_url":"https://api.github.com/users/asridharan/orgs","repos_url":"https://api.github.com/users/asridharan/repos","events_url":"https://api.github.com/users/asridharan/events{/privacy}","received_events_url":"https://api.github.com/users/asridharan/received_events","type":"User","site_admin":false},{"login":"doodlemania2","id":5252217,"node_id":"MDQ6VXNlcjUyNTIyMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5252217?v=4","gravatar_id":"","url":"https://api.github.com/users/doodlemania2","html_url":"https://github.com/doodlemania2","followers_url":"https://api.github.com/users/doodlemania2/followers","following_url":"https://api.github.com/users/doodlemania2/following{/other_user}","gists_url":"https://api.github.com/users/doodlemania2/gists{/gist_id}","starred_url":"https://api.github.com/users/doodlemania2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doodlemania2/subscriptions","organizations_url":"https://api.github.com/users/doodlemania2/orgs","repos_url":"https://api.github.com/users/doodlemania2/repos","events_url":"https://api.github.com/users/doodlemania2/events{/privacy}","received_events_url":"https://api.github.com/users/doodlemania2/received_events","type":"User","site_admin":false},{"login":"rheaj99","id":16848566,"node_id":"MDQ6VXNlcjE2ODQ4NTY2","avatar_url":"https://avatars3.githubusercontent.com/u/16848566?v=4","gravatar_id":"","url":"https://api.github.com/users/rheaj99","html_url":"https://github.com/rheaj99","followers_url":"https://api.github.com/users/rheaj99/followers","following_url":"https://api.github.com/users/rheaj99/following{/other_user}","gists_url":"https://api.github.com/users/rheaj99/gists{/gist_id}","starred_url":"https://api.github.com/users/rheaj99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rheaj99/subscriptions","organizations_url":"https://api.github.com/users/rheaj99/orgs","repos_url":"https://api.github.com/users/rheaj99/repos","events_url":"https://api.github.com/users/rheaj99/events{/privacy}","received_events_url":"https://api.github.com/users/rheaj99/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/249/commits","review_comments_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/249/comments","review_comment_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/249/comments","statuses_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/statuses/ee4a1f1326047ed2c63fce32e2c85171ba0444a7","head":{"label":"Azure:draychev/update-documentation","ref":"draychev/update-documentation","sha":"ee4a1f1326047ed2c63fce32e2c85171ba0444a7","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":146650795,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NTA3OTU=","name":"application-gateway-kubernetes-ingress","full_name":"Azure/application-gateway-kubernetes-ingress","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/application-gateway-kubernetes-ingress","description":"This is an ingress controller that can be run on Azure Kubernetes Service (AKS) to allow an Azure Application Gateway to act as the ingress for an AKS cluster.","fork":false,"url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress","forks_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/forks","keys_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/teams","hooks_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/hooks","issue_events_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/events","assignees_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/tags","blobs_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/languages","stargazers_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/stargazers","contributors_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/contributors","subscribers_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/subscribers","subscription_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/subscription","commits_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/merges","archive_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/downloads","issues_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/labels{/name}","releases_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/deployments","created_at":"2018-08-29T19:52:40Z","updated_at":"2019-06-05T08:23:02Z","pushed_at":"2019-06-05T19:11:01Z","git_url":"git://github.com/Azure/application-gateway-kubernetes-ingress.git","ssh_url":"git@github.com:Azure/application-gateway-kubernetes-ingress.git","clone_url":"https://github.com/Azure/application-gateway-kubernetes-ingress.git","svn_url":"https://github.com/Azure/application-gateway-kubernetes-ingress","homepage":"https://azure.github.io/application-gateway-kubernetes-ingress","size":39766,"stargazers_count":129,"watchers_count":129,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":41,"watchers":129,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"7277a4445f937cd27b6d6477c84e1c4c1b99e8ee","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":146650795,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NTA3OTU=","name":"application-gateway-kubernetes-ingress","full_name":"Azure/application-gateway-kubernetes-ingress","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/application-gateway-kubernetes-ingress","description":"This is an ingress controller that can be run on Azure Kubernetes Service (AKS) to allow an Azure Application Gateway to act as the ingress for an AKS cluster.","fork":false,"url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress","forks_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/forks","keys_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/teams","hooks_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/hooks","issue_events_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/events","assignees_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/tags","blobs_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/languages","stargazers_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/stargazers","contributors_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/contributors","subscribers_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/subscribers","subscription_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/subscription","commits_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/merges","archive_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/downloads","issues_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/labels{/name}","releases_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/deployments","created_at":"2018-08-29T19:52:40Z","updated_at":"2019-06-05T08:23:02Z","pushed_at":"2019-06-05T19:11:01Z","git_url":"git://github.com/Azure/application-gateway-kubernetes-ingress.git","ssh_url":"git@github.com:Azure/application-gateway-kubernetes-ingress.git","clone_url":"https://github.com/Azure/application-gateway-kubernetes-ingress.git","svn_url":"https://github.com/Azure/application-gateway-kubernetes-ingress","homepage":"https://azure.github.io/application-gateway-kubernetes-ingress","size":39766,"stargazers_count":129,"watchers_count":129,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":41,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/249"},"html":{"href":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/249"},"issue":{"href":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/249"},"comments":{"href":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/statuses/ee4a1f1326047ed2c63fce32e2c85171ba0444a7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"draychev"}}