{"action":"created","comment":{"url":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments/332034438","pull_request_review_id":298148250,"id":332034438,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMjAzNDQzOA==","diff_hunk":"@@ -26,6 +26,31 @@\n \t\t\t<parameter key=\"type\" value=\"default\"/>\n \t\t\t<parameter key=\"ipMatch\" value=\"127.0.0.1\"/>\n \t\t</detector>\n+\t\t<detector name=\"JMX-Newts\" class=\"org.opennms.netmgt.provision.detector.jmx.Jsr160Detector\">\n+\t\t\t<parameter key=\"factory\" value=\"PASSWORD-CLEAR\"/>\n+\t\t\t<parameter key=\"username\" value=\"admin\"/>\n+\t\t\t<parameter key=\"ipMatch\" value=\"127.0.0.1\"/>\n+\t\t\t<parameter key=\"port\" value=\"18980\"/>\n+\t\t\t<parameter key=\"password\" value=\"admin\"/>\n+\t\t\t<parameter key=\"urlPath\" value=\"/jmxrmi\"/>\n+\t\t\t<parameter key=\"retries\" value=\"2\"/>\n+\t\t\t<parameter key=\"type\" value=\"default\"/>\n+\t\t\t<parameter key=\"protocol\" value=\"rmi\"/>\n+\t\t\t<parameter key=\"timeout\" value=\"3000\"/>\n+\t\t\t<parameter key=\"object\" value=\"org.opennms.newts:name=ring-buffer.size\"/>\n+\t\t</detector>\n+\t\t<detector name=\"JMX-Java-Virtual-Machine\" class=\"org.opennms.netmgt.provision.detector.jmx.Jsr160Detector\">","path":"opennms-provision/opennms-provision-persistence/src/main/resources/org/opennms/netmgt/provision/persist/default-foreign-source.xml","position":17,"original_position":17,"commit_id":"5693e60659640fd2be2c5738b27782a92ab2af12","original_commit_id":"5693e60659640fd2be2c5738b27782a92ab2af12","user":{"login":"mvrueden","id":4202259,"node_id":"MDQ6VXNlcjQyMDIyNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4202259?v=4","gravatar_id":"","url":"https://api.github.com/users/mvrueden","html_url":"https://github.com/mvrueden","followers_url":"https://api.github.com/users/mvrueden/followers","following_url":"https://api.github.com/users/mvrueden/following{/other_user}","gists_url":"https://api.github.com/users/mvrueden/gists{/gist_id}","starred_url":"https://api.github.com/users/mvrueden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvrueden/subscriptions","organizations_url":"https://api.github.com/users/mvrueden/orgs","repos_url":"https://api.github.com/users/mvrueden/repos","events_url":"https://api.github.com/users/mvrueden/events{/privacy}","received_events_url":"https://api.github.com/users/mvrueden/received_events","type":"User","site_admin":false},"body":"Shouldn't this be `JMX-Java-8`, otherwise the detector finds a service called `JMX-Java-Virtual-Machine` which is `NOT MONITORED`","created_at":"2019-10-07T13:59:35Z","updated_at":"2019-10-07T13:59:36Z","html_url":"https://github.com/OpenNMS/opennms/pull/2685#discussion_r332034438","pull_request_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/2685","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments/332034438"},"html":{"href":"https://github.com/OpenNMS/opennms/pull/2685#discussion_r332034438"},"pull_request":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/2685"}}},"pull_request":{"url":"https://api.github.com/repos/OpenNMS/opennms/pulls/2685","id":315207909,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1MjA3OTA5","html_url":"https://github.com/OpenNMS/opennms/pull/2685","diff_url":"https://github.com/OpenNMS/opennms/pull/2685.diff","patch_url":"https://github.com/OpenNMS/opennms/pull/2685.patch","issue_url":"https://api.github.com/repos/OpenNMS/opennms/issues/2685","number":2685,"state":"open","locked":false,"title":"NMS-9784: JMX config clean up","user":{"login":"mfuhrmann","id":4995222,"node_id":"MDQ6VXNlcjQ5OTUyMjI=","avatar_url":"https://avatars2.githubusercontent.com/u/4995222?v=4","gravatar_id":"","url":"https://api.github.com/users/mfuhrmann","html_url":"https://github.com/mfuhrmann","followers_url":"https://api.github.com/users/mfuhrmann/followers","following_url":"https://api.github.com/users/mfuhrmann/following{/other_user}","gists_url":"https://api.github.com/users/mfuhrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mfuhrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfuhrmann/subscriptions","organizations_url":"https://api.github.com/users/mfuhrmann/orgs","repos_url":"https://api.github.com/users/mfuhrmann/repos","events_url":"https://api.github.com/users/mfuhrmann/events{/privacy}","received_events_url":"https://api.github.com/users/mfuhrmann/received_events","type":"User","site_admin":false},"body":"The branch https://github.com/OpenNMS/opennms/tree/jira/NMS-9784/opennms-base-assembly/src/main/filtered/etc was initially created to solve NMS-9784. But it was to inversive because of metric name changes etc.\r\nIt can be deleted, after merging this one.\r\n\r\nThis PR now contains only a separation of the `jmx-datacollection-config.xml` content into single files.\r\nNo impact for all OpenNMS' out there.\r\n`jmx-datacollection-config.xml` is now empty.\r\n\r\nAlso, I've used identical names for data collection files and graph config files.\r\n\r\n* JIRA (Issue Tracker): https://issues.opennms.org/browse/NMS-9784\r\n* Bamboo (Continuous Integration): https://bamboo.opennms.org/\r\n\r\n","created_at":"2019-09-07T16:25:23Z","updated_at":"2019-10-07T13:59:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d20e2e81f3ce0048060affd40dfba042ccca4f6","assignee":{"login":"mfuhrmann","id":4995222,"node_id":"MDQ6VXNlcjQ5OTUyMjI=","avatar_url":"https://avatars2.githubusercontent.com/u/4995222?v=4","gravatar_id":"","url":"https://api.github.com/users/mfuhrmann","html_url":"https://github.com/mfuhrmann","followers_url":"https://api.github.com/users/mfuhrmann/followers","following_url":"https://api.github.com/users/mfuhrmann/following{/other_user}","gists_url":"https://api.github.com/users/mfuhrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mfuhrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfuhrmann/subscriptions","organizations_url":"https://api.github.com/users/mfuhrmann/orgs","repos_url":"https://api.github.com/users/mfuhrmann/repos","events_url":"https://api.github.com/users/mfuhrmann/events{/privacy}","received_events_url":"https://api.github.com/users/mfuhrmann/received_events","type":"User","site_admin":false},"assignees":[{"login":"mfuhrmann","id":4995222,"node_id":"MDQ6VXNlcjQ5OTUyMjI=","avatar_url":"https://avatars2.githubusercontent.com/u/4995222?v=4","gravatar_id":"","url":"https://api.github.com/users/mfuhrmann","html_url":"https://github.com/mfuhrmann","followers_url":"https://api.github.com/users/mfuhrmann/followers","following_url":"https://api.github.com/users/mfuhrmann/following{/other_user}","gists_url":"https://api.github.com/users/mfuhrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mfuhrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfuhrmann/subscriptions","organizations_url":"https://api.github.com/users/mfuhrmann/orgs","repos_url":"https://api.github.com/users/mfuhrmann/repos","events_url":"https://api.github.com/users/mfuhrmann/events{/privacy}","received_events_url":"https://api.github.com/users/mfuhrmann/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1369160226,"node_id":"MDU6TGFiZWwxMzY5MTYwMjI2","url":"https://api.github.com/repos/OpenNMS/opennms/labels/cleanup","name":"cleanup","color":"a7f989","default":false},{"id":234759840,"node_id":"MDU6TGFiZWwyMzQ3NTk4NDA=","url":"https://api.github.com/repos/OpenNMS/opennms/labels/triage","name":"triage","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/2685/commits","review_comments_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/2685/comments","review_comment_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenNMS/opennms/issues/2685/comments","statuses_url":"https://api.github.com/repos/OpenNMS/opennms/statuses/5693e60659640fd2be2c5738b27782a92ab2af12","head":{"label":"OpenNMS:jira/NMS-9784-2","ref":"jira/NMS-9784-2","sha":"5693e60659640fd2be2c5738b27782a92ab2af12","user":{"login":"OpenNMS","id":2972482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzI0ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/2972482?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"repo":{"id":9377198,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzc3MTk4","name":"opennms","full_name":"OpenNMS/opennms","private":false,"owner":{"login":"OpenNMS","id":2972482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzI0ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/2972482?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenNMS/opennms","description":"Enterprise-Grade Open-Source Network Management Platform","fork":false,"url":"https://api.github.com/repos/OpenNMS/opennms","forks_url":"https://api.github.com/repos/OpenNMS/opennms/forks","keys_url":"https://api.github.com/repos/OpenNMS/opennms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenNMS/opennms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenNMS/opennms/teams","hooks_url":"https://api.github.com/repos/OpenNMS/opennms/hooks","issue_events_url":"https://api.github.com/repos/OpenNMS/opennms/issues/events{/number}","events_url":"https://api.github.com/repos/OpenNMS/opennms/events","assignees_url":"https://api.github.com/repos/OpenNMS/opennms/assignees{/user}","branches_url":"https://api.github.com/repos/OpenNMS/opennms/branches{/branch}","tags_url":"https://api.github.com/repos/OpenNMS/opennms/tags","blobs_url":"https://api.github.com/repos/OpenNMS/opennms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenNMS/opennms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenNMS/opennms/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenNMS/opennms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenNMS/opennms/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenNMS/opennms/languages","stargazers_url":"https://api.github.com/repos/OpenNMS/opennms/stargazers","contributors_url":"https://api.github.com/repos/OpenNMS/opennms/contributors","subscribers_url":"https://api.github.com/repos/OpenNMS/opennms/subscribers","subscription_url":"https://api.github.com/repos/OpenNMS/opennms/subscription","commits_url":"https://api.github.com/repos/OpenNMS/opennms/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenNMS/opennms/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenNMS/opennms/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenNMS/opennms/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenNMS/opennms/contents/{+path}","compare_url":"https://api.github.com/repos/OpenNMS/opennms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenNMS/opennms/merges","archive_url":"https://api.github.com/repos/OpenNMS/opennms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenNMS/opennms/downloads","issues_url":"https://api.github.com/repos/OpenNMS/opennms/issues{/number}","pulls_url":"https://api.github.com/repos/OpenNMS/opennms/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenNMS/opennms/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenNMS/opennms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenNMS/opennms/labels{/name}","releases_url":"https://api.github.com/repos/OpenNMS/opennms/releases{/id}","deployments_url":"https://api.github.com/repos/OpenNMS/opennms/deployments","created_at":"2013-04-11T18:22:33Z","updated_at":"2019-10-07T12:57:41Z","pushed_at":"2019-10-07T12:58:07Z","git_url":"git://github.com/OpenNMS/opennms.git","ssh_url":"git@github.com:OpenNMS/opennms.git","clone_url":"https://github.com/OpenNMS/opennms.git","svn_url":"https://github.com/OpenNMS/opennms","homepage":"http://www.opennms.org/","size":534502,"stargazers_count":464,"watchers_count":464,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":428,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":428,"open_issues":32,"watchers":464,"default_branch":"develop"}},"base":{"label":"OpenNMS:develop","ref":"develop","sha":"1aa2eb01241b9b310d50483c31651349ae4c310c","user":{"login":"OpenNMS","id":2972482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzI0ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/2972482?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"repo":{"id":9377198,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzc3MTk4","name":"opennms","full_name":"OpenNMS/opennms","private":false,"owner":{"login":"OpenNMS","id":2972482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzI0ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/2972482?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenNMS/opennms","description":"Enterprise-Grade Open-Source Network Management Platform","fork":false,"url":"https://api.github.com/repos/OpenNMS/opennms","forks_url":"https://api.github.com/repos/OpenNMS/opennms/forks","keys_url":"https://api.github.com/repos/OpenNMS/opennms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenNMS/opennms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenNMS/opennms/teams","hooks_url":"https://api.github.com/repos/OpenNMS/opennms/hooks","issue_events_url":"https://api.github.com/repos/OpenNMS/opennms/issues/events{/number}","events_url":"https://api.github.com/repos/OpenNMS/opennms/events","assignees_url":"https://api.github.com/repos/OpenNMS/opennms/assignees{/user}","branches_url":"https://api.github.com/repos/OpenNMS/opennms/branches{/branch}","tags_url":"https://api.github.com/repos/OpenNMS/opennms/tags","blobs_url":"https://api.github.com/repos/OpenNMS/opennms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenNMS/opennms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenNMS/opennms/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenNMS/opennms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenNMS/opennms/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenNMS/opennms/languages","stargazers_url":"https://api.github.com/repos/OpenNMS/opennms/stargazers","contributors_url":"https://api.github.com/repos/OpenNMS/opennms/contributors","subscribers_url":"https://api.github.com/repos/OpenNMS/opennms/subscribers","subscription_url":"https://api.github.com/repos/OpenNMS/opennms/subscription","commits_url":"https://api.github.com/repos/OpenNMS/opennms/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenNMS/opennms/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenNMS/opennms/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenNMS/opennms/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenNMS/opennms/contents/{+path}","compare_url":"https://api.github.com/repos/OpenNMS/opennms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenNMS/opennms/merges","archive_url":"https://api.github.com/repos/OpenNMS/opennms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenNMS/opennms/downloads","issues_url":"https://api.github.com/repos/OpenNMS/opennms/issues{/number}","pulls_url":"https://api.github.com/repos/OpenNMS/opennms/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenNMS/opennms/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenNMS/opennms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenNMS/opennms/labels{/name}","releases_url":"https://api.github.com/repos/OpenNMS/opennms/releases{/id}","deployments_url":"https://api.github.com/repos/OpenNMS/opennms/deployments","created_at":"2013-04-11T18:22:33Z","updated_at":"2019-10-07T12:57:41Z","pushed_at":"2019-10-07T12:58:07Z","git_url":"git://github.com/OpenNMS/opennms.git","ssh_url":"git@github.com:OpenNMS/opennms.git","clone_url":"https://github.com/OpenNMS/opennms.git","svn_url":"https://github.com/OpenNMS/opennms","homepage":"http://www.opennms.org/","size":534502,"stargazers_count":464,"watchers_count":464,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":428,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":428,"open_issues":32,"watchers":464,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/2685"},"html":{"href":"https://github.com/OpenNMS/opennms/pull/2685"},"issue":{"href":"https://api.github.com/repos/OpenNMS/opennms/issues/2685"},"comments":{"href":"https://api.github.com/repos/OpenNMS/opennms/issues/2685/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/2685/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/2685/commits"},"statuses":{"href":"https://api.github.com/repos/OpenNMS/opennms/statuses/5693e60659640fd2be2c5738b27782a92ab2af12"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mvrueden"}}