{"action":"created","comment":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments/284169489","pull_request_review_id":237711466,"id":284169489,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDE2OTQ4OQ==","diff_hunk":"@@ -39,6 +39,9 @@ class AlazarTech_ATS(Instrument):\n         system_id: target system id for this board\n         board_id: target board id within the system for this board\n         dll_path: path to the ATS driver dll library file\n+        api: AlazarATSAPI interface, defaults to the dll api. This argument\n+            enables to provide another api, e.g. for a simulated driver for","path":"qcodes/instrument_drivers/AlazarTech/ATS.py","position":14,"original_position":5,"commit_id":"fa29cfa817bad857870679e4b7631afaadf8f63e","original_commit_id":"26b257ff6fb531ece82fa6df2b6c2307556bc606","user":{"login":"jenshnielsen","id":548266,"node_id":"MDQ6VXNlcjU0ODI2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/548266?v=4","gravatar_id":"","url":"https://api.github.com/users/jenshnielsen","html_url":"https://github.com/jenshnielsen","followers_url":"https://api.github.com/users/jenshnielsen/followers","following_url":"https://api.github.com/users/jenshnielsen/following{/other_user}","gists_url":"https://api.github.com/users/jenshnielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jenshnielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenshnielsen/subscriptions","organizations_url":"https://api.github.com/users/jenshnielsen/orgs","repos_url":"https://api.github.com/users/jenshnielsen/repos","events_url":"https://api.github.com/users/jenshnielsen/events{/privacy}","received_events_url":"https://api.github.com/users/jenshnielsen/received_events","type":"User","site_admin":false},"body":"I would write. `This argument makes it possible to provide another api` ... or `This argument enables the user to provide another api` ","created_at":"2019-05-15T09:37:59Z","updated_at":"2019-05-15T09:37:59Z","html_url":"https://github.com/QCoDeS/Qcodes/pull/1524#discussion_r284169489","pull_request_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1524","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments/284169489"},"html":{"href":"https://github.com/QCoDeS/Qcodes/pull/1524#discussion_r284169489"},"pull_request":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1524"}}},"pull_request":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1524","id":262771005,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyNzcxMDA1","html_url":"https://github.com/QCoDeS/Qcodes/pull/1524","diff_url":"https://github.com/QCoDeS/Qcodes/pull/1524.diff","patch_url":"https://github.com/QCoDeS/Qcodes/pull/1524.patch","issue_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1524","number":1524,"state":"open","locked":false,"title":"[WIP] Alazar Driver: Add api instance as initialization parameter","user":{"login":"Dominik-Vogel","id":30660470,"node_id":"MDQ6VXNlcjMwNjYwNDcw","avatar_url":"https://avatars2.githubusercontent.com/u/30660470?v=4","gravatar_id":"","url":"https://api.github.com/users/Dominik-Vogel","html_url":"https://github.com/Dominik-Vogel","followers_url":"https://api.github.com/users/Dominik-Vogel/followers","following_url":"https://api.github.com/users/Dominik-Vogel/following{/other_user}","gists_url":"https://api.github.com/users/Dominik-Vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/Dominik-Vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dominik-Vogel/subscriptions","organizations_url":"https://api.github.com/users/Dominik-Vogel/orgs","repos_url":"https://api.github.com/users/Dominik-Vogel/repos","events_url":"https://api.github.com/users/Dominik-Vogel/events{/privacy}","received_events_url":"https://api.github.com/users/Dominik-Vogel/received_events","type":"User","site_admin":false},"body":"With this small change I will be able to create a mock of the alazar driver that does not require an alazar card in order to instantiate and also potentially benchmark the alazar and alazar controllers, by simply providing an instance of  an api object that wraps all the dll calls without actually calling into the dll.\r\n\r\n\r\n","created_at":"2019-03-20T08:52:31Z","updated_at":"2019-05-15T09:37:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7964875cb51f6f90d30d88ddefe832d44838ff2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":443708179,"node_id":"MDU6TGFiZWw0NDM3MDgxNzk=","url":"https://api.github.com/repos/QCoDeS/Qcodes/labels/driver","name":"driver","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1524/commits","review_comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1524/comments","review_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1524/comments","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/fa29cfa817bad857870679e4b7631afaadf8f63e","head":{"label":"Dominik-Vogel:driver_ats_api_input","ref":"driver_ats_api_input","sha":"fa29cfa817bad857870679e4b7631afaadf8f63e","user":{"login":"Dominik-Vogel","id":30660470,"node_id":"MDQ6VXNlcjMwNjYwNDcw","avatar_url":"https://avatars2.githubusercontent.com/u/30660470?v=4","gravatar_id":"","url":"https://api.github.com/users/Dominik-Vogel","html_url":"https://github.com/Dominik-Vogel","followers_url":"https://api.github.com/users/Dominik-Vogel/followers","following_url":"https://api.github.com/users/Dominik-Vogel/following{/other_user}","gists_url":"https://api.github.com/users/Dominik-Vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/Dominik-Vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dominik-Vogel/subscriptions","organizations_url":"https://api.github.com/users/Dominik-Vogel/orgs","repos_url":"https://api.github.com/users/Dominik-Vogel/repos","events_url":"https://api.github.com/users/Dominik-Vogel/events{/privacy}","received_events_url":"https://api.github.com/users/Dominik-Vogel/received_events","type":"User","site_admin":false},"repo":{"id":99123813,"node_id":"MDEwOlJlcG9zaXRvcnk5OTEyMzgxMw==","name":"Qcodes","full_name":"Dominik-Vogel/Qcodes","private":false,"owner":{"login":"Dominik-Vogel","id":30660470,"node_id":"MDQ6VXNlcjMwNjYwNDcw","avatar_url":"https://avatars2.githubusercontent.com/u/30660470?v=4","gravatar_id":"","url":"https://api.github.com/users/Dominik-Vogel","html_url":"https://github.com/Dominik-Vogel","followers_url":"https://api.github.com/users/Dominik-Vogel/followers","following_url":"https://api.github.com/users/Dominik-Vogel/following{/other_user}","gists_url":"https://api.github.com/users/Dominik-Vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/Dominik-Vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dominik-Vogel/subscriptions","organizations_url":"https://api.github.com/users/Dominik-Vogel/orgs","repos_url":"https://api.github.com/users/Dominik-Vogel/repos","events_url":"https://api.github.com/users/Dominik-Vogel/events{/privacy}","received_events_url":"https://api.github.com/users/Dominik-Vogel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Dominik-Vogel/Qcodes","description":"Modular data acquisition framework","fork":true,"url":"https://api.github.com/repos/Dominik-Vogel/Qcodes","forks_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/forks","keys_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/teams","hooks_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/hooks","issue_events_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/issues/events{/number}","events_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/events","assignees_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/assignees{/user}","branches_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/branches{/branch}","tags_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/tags","blobs_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/languages","stargazers_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/stargazers","contributors_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/contributors","subscribers_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/subscribers","subscription_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/subscription","commits_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/contents/{+path}","compare_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/merges","archive_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/downloads","issues_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/issues{/number}","pulls_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/labels{/name}","releases_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/releases{/id}","deployments_url":"https://api.github.com/repos/Dominik-Vogel/Qcodes/deployments","created_at":"2017-08-02T14:11:34Z","updated_at":"2018-11-09T10:11:29Z","pushed_at":"2019-05-15T09:35:37Z","git_url":"git://github.com/Dominik-Vogel/Qcodes.git","ssh_url":"git@github.com:Dominik-Vogel/Qcodes.git","clone_url":"https://github.com/Dominik-Vogel/Qcodes.git","svn_url":"https://github.com/Dominik-Vogel/Qcodes","homepage":"http://qcodes.github.io/Qcodes","size":61516,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"QCoDeS:master","ref":"master","sha":"7d35d816e460b85cdfb730563b0e686920047cac","user":{"login":"QCoDeS","id":20478252,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/20478252?v=4","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"repo":{"id":37137879,"node_id":"MDEwOlJlcG9zaXRvcnkzNzEzNzg3OQ==","name":"Qcodes","full_name":"QCoDeS/Qcodes","private":false,"owner":{"login":"QCoDeS","id":20478252,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/20478252?v=4","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QCoDeS/Qcodes","description":"Modular data acquisition framework","fork":false,"url":"https://api.github.com/repos/QCoDeS/Qcodes","forks_url":"https://api.github.com/repos/QCoDeS/Qcodes/forks","keys_url":"https://api.github.com/repos/QCoDeS/Qcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QCoDeS/Qcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QCoDeS/Qcodes/teams","hooks_url":"https://api.github.com/repos/QCoDeS/Qcodes/hooks","issue_events_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/events{/number}","events_url":"https://api.github.com/repos/QCoDeS/Qcodes/events","assignees_url":"https://api.github.com/repos/QCoDeS/Qcodes/assignees{/user}","branches_url":"https://api.github.com/repos/QCoDeS/Qcodes/branches{/branch}","tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/tags","blobs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/QCoDeS/Qcodes/languages","stargazers_url":"https://api.github.com/repos/QCoDeS/Qcodes/stargazers","contributors_url":"https://api.github.com/repos/QCoDeS/Qcodes/contributors","subscribers_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscribers","subscription_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscription","commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/QCoDeS/Qcodes/contents/{+path}","compare_url":"https://api.github.com/repos/QCoDeS/Qcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QCoDeS/Qcodes/merges","archive_url":"https://api.github.com/repos/QCoDeS/Qcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QCoDeS/Qcodes/downloads","issues_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues{/number}","pulls_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/QCoDeS/Qcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/QCoDeS/Qcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QCoDeS/Qcodes/labels{/name}","releases_url":"https://api.github.com/repos/QCoDeS/Qcodes/releases{/id}","deployments_url":"https://api.github.com/repos/QCoDeS/Qcodes/deployments","created_at":"2015-06-09T14:42:14Z","updated_at":"2019-05-15T09:27:46Z","pushed_at":"2019-05-15T09:35:39Z","git_url":"git://github.com/QCoDeS/Qcodes.git","ssh_url":"git@github.com:QCoDeS/Qcodes.git","clone_url":"https://github.com/QCoDeS/Qcodes.git","svn_url":"https://github.com/QCoDeS/Qcodes","homepage":"http://qcodes.github.io/Qcodes","size":166067,"stargazers_count":93,"watchers_count":93,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":110,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":225,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":110,"open_issues":225,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1524"},"html":{"href":"https://github.com/QCoDeS/Qcodes/pull/1524"},"issue":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1524"},"comments":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1524/comments"},"review_comments":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1524/comments"},"review_comment":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1524/commits"},"statuses":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/fa29cfa817bad857870679e4b7631afaadf8f63e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jenshnielsen"}}