{"action":"opened","number":1945,"pull_request":{"url":"https://api.github.com/repos/apple/foundationdb/pulls/1945","id":303171637,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzMTcxNjM3","html_url":"https://github.com/apple/foundationdb/pull/1945","diff_url":"https://github.com/apple/foundationdb/pull/1945.diff","patch_url":"https://github.com/apple/foundationdb/pull/1945.patch","issue_url":"https://api.github.com/repos/apple/foundationdb/issues/1945","number":1945,"state":"open","locked":false,"title":"Add comments to DiskQueue and tLog","user":{"login":"xumengpanda","id":42559636,"node_id":"MDQ6VXNlcjQyNTU5NjM2","avatar_url":"https://avatars2.githubusercontent.com/u/42559636?v=4","gravatar_id":"","url":"https://api.github.com/users/xumengpanda","html_url":"https://github.com/xumengpanda","followers_url":"https://api.github.com/users/xumengpanda/followers","following_url":"https://api.github.com/users/xumengpanda/following{/other_user}","gists_url":"https://api.github.com/users/xumengpanda/gists{/gist_id}","starred_url":"https://api.github.com/users/xumengpanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xumengpanda/subscriptions","organizations_url":"https://api.github.com/users/xumengpanda/orgs","repos_url":"https://api.github.com/users/xumengpanda/repos","events_url":"https://api.github.com/users/xumengpanda/events{/privacy}","received_events_url":"https://api.github.com/users/xumengpanda/received_events","type":"User","site_admin":false},"body":"Add comments to explain some structures and functions related to DiskQueue and TagPartitionedLogSystem.\r\n\r\nNo functional change.\r\n\r\nAcknowledgement:\r\nThank @alexmiller-apple  for helping on explaining the code.","created_at":"2019-08-01T00:20:14Z","updated_at":"2019-08-01T00:20:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/foundationdb/pulls/1945/commits","review_comments_url":"https://api.github.com/repos/apple/foundationdb/pulls/1945/comments","review_comment_url":"https://api.github.com/repos/apple/foundationdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/foundationdb/issues/1945/comments","statuses_url":"https://api.github.com/repos/apple/foundationdb/statuses/1802b461cb56c7ef7848c9962dc3b885007fac99","head":{"label":"xumengpanda:mengxu/tLog-code-read-v2","ref":"mengxu/tLog-code-read-v2","sha":"1802b461cb56c7ef7848c9962dc3b885007fac99","user":{"login":"xumengpanda","id":42559636,"node_id":"MDQ6VXNlcjQyNTU5NjM2","avatar_url":"https://avatars2.githubusercontent.com/u/42559636?v=4","gravatar_id":"","url":"https://api.github.com/users/xumengpanda","html_url":"https://github.com/xumengpanda","followers_url":"https://api.github.com/users/xumengpanda/followers","following_url":"https://api.github.com/users/xumengpanda/following{/other_user}","gists_url":"https://api.github.com/users/xumengpanda/gists{/gist_id}","starred_url":"https://api.github.com/users/xumengpanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xumengpanda/subscriptions","organizations_url":"https://api.github.com/users/xumengpanda/orgs","repos_url":"https://api.github.com/users/xumengpanda/repos","events_url":"https://api.github.com/users/xumengpanda/events{/privacy}","received_events_url":"https://api.github.com/users/xumengpanda/received_events","type":"User","site_admin":false},"repo":{"id":145486951,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0ODY5NTE=","name":"foundationdb","full_name":"xumengpanda/foundationdb","private":false,"owner":{"login":"xumengpanda","id":42559636,"node_id":"MDQ6VXNlcjQyNTU5NjM2","avatar_url":"https://avatars2.githubusercontent.com/u/42559636?v=4","gravatar_id":"","url":"https://api.github.com/users/xumengpanda","html_url":"https://github.com/xumengpanda","followers_url":"https://api.github.com/users/xumengpanda/followers","following_url":"https://api.github.com/users/xumengpanda/following{/other_user}","gists_url":"https://api.github.com/users/xumengpanda/gists{/gist_id}","starred_url":"https://api.github.com/users/xumengpanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xumengpanda/subscriptions","organizations_url":"https://api.github.com/users/xumengpanda/orgs","repos_url":"https://api.github.com/users/xumengpanda/repos","events_url":"https://api.github.com/users/xumengpanda/events{/privacy}","received_events_url":"https://api.github.com/users/xumengpanda/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xumengpanda/foundationdb","description":"FoundationDB - the open source, distributed, transactional key-value store","fork":true,"url":"https://api.github.com/repos/xumengpanda/foundationdb","forks_url":"https://api.github.com/repos/xumengpanda/foundationdb/forks","keys_url":"https://api.github.com/repos/xumengpanda/foundationdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xumengpanda/foundationdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xumengpanda/foundationdb/teams","hooks_url":"https://api.github.com/repos/xumengpanda/foundationdb/hooks","issue_events_url":"https://api.github.com/repos/xumengpanda/foundationdb/issues/events{/number}","events_url":"https://api.github.com/repos/xumengpanda/foundationdb/events","assignees_url":"https://api.github.com/repos/xumengpanda/foundationdb/assignees{/user}","branches_url":"https://api.github.com/repos/xumengpanda/foundationdb/branches{/branch}","tags_url":"https://api.github.com/repos/xumengpanda/foundationdb/tags","blobs_url":"https://api.github.com/repos/xumengpanda/foundationdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xumengpanda/foundationdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xumengpanda/foundationdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/xumengpanda/foundationdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xumengpanda/foundationdb/statuses/{sha}","languages_url":"https://api.github.com/repos/xumengpanda/foundationdb/languages","stargazers_url":"https://api.github.com/repos/xumengpanda/foundationdb/stargazers","contributors_url":"https://api.github.com/repos/xumengpanda/foundationdb/contributors","subscribers_url":"https://api.github.com/repos/xumengpanda/foundationdb/subscribers","subscription_url":"https://api.github.com/repos/xumengpanda/foundationdb/subscription","commits_url":"https://api.github.com/repos/xumengpanda/foundationdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/xumengpanda/foundationdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/xumengpanda/foundationdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/xumengpanda/foundationdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/xumengpanda/foundationdb/contents/{+path}","compare_url":"https://api.github.com/repos/xumengpanda/foundationdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xumengpanda/foundationdb/merges","archive_url":"https://api.github.com/repos/xumengpanda/foundationdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xumengpanda/foundationdb/downloads","issues_url":"https://api.github.com/repos/xumengpanda/foundationdb/issues{/number}","pulls_url":"https://api.github.com/repos/xumengpanda/foundationdb/pulls{/number}","milestones_url":"https://api.github.com/repos/xumengpanda/foundationdb/milestones{/number}","notifications_url":"https://api.github.com/repos/xumengpanda/foundationdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xumengpanda/foundationdb/labels{/name}","releases_url":"https://api.github.com/repos/xumengpanda/foundationdb/releases{/id}","deployments_url":"https://api.github.com/repos/xumengpanda/foundationdb/deployments","created_at":"2018-08-21T01:01:52Z","updated_at":"2019-07-31T22:23:50Z","pushed_at":"2019-08-01T00:17:48Z","git_url":"git://github.com/xumengpanda/foundationdb.git","ssh_url":"git@github.com:xumengpanda/foundationdb.git","clone_url":"https://github.com/xumengpanda/foundationdb.git","svn_url":"https://github.com/xumengpanda/foundationdb","homepage":"https://www.foundationdb.org","size":22403,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"f4bcfcd53c437109dc4d2de9ad42d3bac60cae5d","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":114187903,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQxODc5MDM=","name":"foundationdb","full_name":"apple/foundationdb","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/foundationdb","description":"FoundationDB - the open source, distributed, transactional key-value store","fork":false,"url":"https://api.github.com/repos/apple/foundationdb","forks_url":"https://api.github.com/repos/apple/foundationdb/forks","keys_url":"https://api.github.com/repos/apple/foundationdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/foundationdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/foundationdb/teams","hooks_url":"https://api.github.com/repos/apple/foundationdb/hooks","issue_events_url":"https://api.github.com/repos/apple/foundationdb/issues/events{/number}","events_url":"https://api.github.com/repos/apple/foundationdb/events","assignees_url":"https://api.github.com/repos/apple/foundationdb/assignees{/user}","branches_url":"https://api.github.com/repos/apple/foundationdb/branches{/branch}","tags_url":"https://api.github.com/repos/apple/foundationdb/tags","blobs_url":"https://api.github.com/repos/apple/foundationdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/foundationdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/foundationdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/foundationdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/foundationdb/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/foundationdb/languages","stargazers_url":"https://api.github.com/repos/apple/foundationdb/stargazers","contributors_url":"https://api.github.com/repos/apple/foundationdb/contributors","subscribers_url":"https://api.github.com/repos/apple/foundationdb/subscribers","subscription_url":"https://api.github.com/repos/apple/foundationdb/subscription","commits_url":"https://api.github.com/repos/apple/foundationdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/foundationdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/foundationdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/foundationdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/foundationdb/contents/{+path}","compare_url":"https://api.github.com/repos/apple/foundationdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/foundationdb/merges","archive_url":"https://api.github.com/repos/apple/foundationdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/foundationdb/downloads","issues_url":"https://api.github.com/repos/apple/foundationdb/issues{/number}","pulls_url":"https://api.github.com/repos/apple/foundationdb/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/foundationdb/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/foundationdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/foundationdb/labels{/name}","releases_url":"https://api.github.com/repos/apple/foundationdb/releases{/id}","deployments_url":"https://api.github.com/repos/apple/foundationdb/deployments","created_at":"2017-12-14T01:40:42Z","updated_at":"2019-08-01T00:14:08Z","pushed_at":"2019-08-01T00:13:59Z","git_url":"git://github.com/apple/foundationdb.git","ssh_url":"git@github.com:apple/foundationdb.git","clone_url":"https://github.com/apple/foundationdb.git","svn_url":"https://github.com/apple/foundationdb","homepage":"https://www.foundationdb.org","size":21167,"stargazers_count":9418,"watchers_count":9418,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":745,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":268,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":745,"open_issues":268,"watchers":9418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/1945"},"html":{"href":"https://github.com/apple/foundationdb/pull/1945"},"issue":{"href":"https://api.github.com/repos/apple/foundationdb/issues/1945"},"comments":{"href":"https://api.github.com/repos/apple/foundationdb/issues/1945/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/1945/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/1945/commits"},"statuses":{"href":"https://api.github.com/repos/apple/foundationdb/statuses/1802b461cb56c7ef7848c9962dc3b885007fac99"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":63,"deletions":20,"changed_files":9}}
{"actor":{"display_login":"xumengpanda"}}