{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/12937","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/12937/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/12937/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/12937/events","html_url":"https://github.com/MarlinFirmware/Marlin/issues/12937","id":400265547,"node_id":"MDU6SXNzdWU0MDAyNjU1NDc=","number":12937,"title":"[bugfix-2.0.x] ULTRA_LCD + REPRAP_DISCOUNT_SMART_CONTROLLER is buggy","user":{"login":"mordaha","id":800239,"node_id":"MDQ6VXNlcjgwMDIzOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/800239?v=4","gravatar_id":"","url":"https://api.github.com/users/mordaha","html_url":"https://github.com/mordaha","followers_url":"https://api.github.com/users/mordaha/followers","following_url":"https://api.github.com/users/mordaha/following{/other_user}","gists_url":"https://api.github.com/users/mordaha/gists{/gist_id}","starred_url":"https://api.github.com/users/mordaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mordaha/subscriptions","organizations_url":"https://api.github.com/users/mordaha/orgs","repos_url":"https://api.github.com/users/mordaha/repos","events_url":"https://api.github.com/users/mordaha/events{/privacy}","received_events_url":"https://api.github.com/users/mordaha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2019-01-17T12:57:46Z","updated_at":"2019-03-09T15:24:37Z","closed_at":null,"author_association":"NONE","body":"### Description\r\n\r\nI connected standard  RepRap Smart LCD Controller to my DUE_USB+RURAMPS4D_13 (Marlin bugfix-2.0.x 32 bit) with this config:\r\n\r\n```\r\n#define REPRAP_DISCOUNT_SMART_CONTROLLER\r\n\r\n#define ULTRA_LCD\r\n#define NEWPANEL\r\n#define LCD_WIDTH 20\r\n#define LCD_HEIGHT 4\r\n```\r\n\r\nAnd it didn't work, it showed 2 strings of trash, something like this: https://i.imgur.com/RtGtHNw.png \r\n\r\nI debugged a little through the code and found that `LiquidCrystal lcd()` somehow initialized wrong or not initialized at all.\r\n\r\nSo, here, at L900 (https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.0.x/Marlin/src/lcd/HD44780/lcdprint_hd44780.cpp#L900) in `lcd_put_wchar_max()`, `lcd.` is useless (pointing to a wrong device, not my?).\r\n\r\nI added initialisation (hack) just before that `if`:\r\n```  \r\n  // initialize lcd()\r\n  LCD_CLASS lcd(LCD_PINS_RS, LCD_PINS_ENABLE, LCD_PINS_D4, LCD_PINS_D5, LCD_PINS_D6, LCD_PINS_D7); \r\n\r\n  // TODO: fix the '\\\\' that doesnt exist in the HD44870\r\n  if (c < 128) {\r\n    lcd.write((uint8_t)c);\r\n    return 1;\r\n  }\r\n```\r\nAnd it started to work fine, as expected: https://i.imgur.com/incMr9w.png\r\n\r\nI didn't debug through that lot of `#if ENABLED() -> #define` symbols, so i don't know where exactly the buggy code is, but i think it somewhere in defines/configs. May be lcd_i2c config somehow fired.\r\n\r\nMy full Configuration.h: https://pastebin.com/Q6J85X2k\r\n\r\nHow else can i help?\r\n"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/471188871","html_url":"https://github.com/MarlinFirmware/Marlin/issues/12937#issuecomment-471188871","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/12937","id":471188871,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MTE4ODg3MQ==","user":{"login":"mordaha","id":800239,"node_id":"MDQ6VXNlcjgwMDIzOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/800239?v=4","gravatar_id":"","url":"https://api.github.com/users/mordaha","html_url":"https://github.com/mordaha","followers_url":"https://api.github.com/users/mordaha/followers","following_url":"https://api.github.com/users/mordaha/following{/other_user}","gists_url":"https://api.github.com/users/mordaha/gists{/gist_id}","starred_url":"https://api.github.com/users/mordaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mordaha/subscriptions","organizations_url":"https://api.github.com/users/mordaha/orgs","repos_url":"https://api.github.com/users/mordaha/repos","events_url":"https://api.github.com/users/mordaha/events{/privacy}","received_events_url":"https://api.github.com/users/mordaha/received_events","type":"User","site_admin":false},"created_at":"2019-03-09T15:24:37Z","updated_at":"2019-03-09T15:24:37Z","author_association":"NONE","body":">are you sure the problem is still here with todays copy of bugfix 2.0? have you tested?\r\n\r\ni can in git ))\r\n\r\n<img width=\"554\" alt=\"image\" src=\"https://user-images.githubusercontent.com/800239/54073476-9263ff80-4298-11e9-9392-9d6079306664.png\">\r\n"}}
{"actor":{"display_login":"mordaha"}}