{"action":"closed","number":332,"pull_request":{"url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/pulls/332","id":256365240,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2MzY1MjQw","html_url":"https://github.com/NCIOCPL/wcms-front-end/pull/332","diff_url":"https://github.com/NCIOCPL/wcms-front-end/pull/332.diff","patch_url":"https://github.com/NCIOCPL/wcms-front-end/pull/332.patch","issue_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/issues/332","number":332,"state":"closed","locked":false,"title":"[WCMSFEQ-1303][WCMSFEQ-1338] Sortable tables fixed column","user":{"login":"mltnewman","id":19537101,"node_id":"MDQ6VXNlcjE5NTM3MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/19537101?v=4","gravatar_id":"","url":"https://api.github.com/users/mltnewman","html_url":"https://github.com/mltnewman","followers_url":"https://api.github.com/users/mltnewman/followers","following_url":"https://api.github.com/users/mltnewman/following{/other_user}","gists_url":"https://api.github.com/users/mltnewman/gists{/gist_id}","starred_url":"https://api.github.com/users/mltnewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mltnewman/subscriptions","organizations_url":"https://api.github.com/users/mltnewman/orgs","repos_url":"https://api.github.com/users/mltnewman/repos","events_url":"https://api.github.com/users/mltnewman/events{/privacy}","received_events_url":"https://api.github.com/users/mltnewman/received_events","type":"User","site_admin":false},"body":"In some tables, sorting the first column made it appear as tiles.  This was occurrring when the content in some columns exceed the height of the first.  On mobile, the height was set at 200px on mobile, which accommodated most content sizing, but still produced that funky \"tiled\" look. \r\n\r\nTo correct this, the height of the first cell of the table was set to 100%, less the height of the header cell and height of the horizontal scroll bar that is generated on mobile.  The fixed height of 200px was removed from the cells of the first column, and the box shadow and other styling was added to that first cell (of the first frozen column).  In order to fully implement this fix, any sortable table with a footer (which uses the ```<tfoot>``` element) must be removed from the content.  A separate ticket was submitted for this content cleanup step on production: https://tracker.nci.nih.gov/browse/CGOV-8918 ","created_at":"2019-02-26T16:55:19Z","updated_at":"2019-02-27T00:37:52Z","closed_at":"2019-02-27T00:37:52Z","merged_at":"2019-02-27T00:37:52Z","merge_commit_sha":"6a78c4c1950b6f0b3b4297344f1f23b4248c5ef9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alifr","id":5579274,"node_id":"MDQ6VXNlcjU1NzkyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5579274?v=4","gravatar_id":"","url":"https://api.github.com/users/alifr","html_url":"https://github.com/alifr","followers_url":"https://api.github.com/users/alifr/followers","following_url":"https://api.github.com/users/alifr/following{/other_user}","gists_url":"https://api.github.com/users/alifr/gists{/gist_id}","starred_url":"https://api.github.com/users/alifr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alifr/subscriptions","organizations_url":"https://api.github.com/users/alifr/orgs","repos_url":"https://api.github.com/users/alifr/repos","events_url":"https://api.github.com/users/alifr/events{/privacy}","received_events_url":"https://api.github.com/users/alifr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/pulls/332/commits","review_comments_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/pulls/332/comments","review_comment_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/issues/332/comments","statuses_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/statuses/0fceffb0ee24d54a5f9605a6b9a943ecc9ef473f","head":{"label":"NCIOCPL:sortable-tables-fixed-column","ref":"sortable-tables-fixed-column","sha":"0fceffb0ee24d54a5f9605a6b9a943ecc9ef473f","user":{"login":"NCIOCPL","id":22624912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjI0OTEy","avatar_url":"https://avatars3.githubusercontent.com/u/22624912?v=4","gravatar_id":"","url":"https://api.github.com/users/NCIOCPL","html_url":"https://github.com/NCIOCPL","followers_url":"https://api.github.com/users/NCIOCPL/followers","following_url":"https://api.github.com/users/NCIOCPL/following{/other_user}","gists_url":"https://api.github.com/users/NCIOCPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NCIOCPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCIOCPL/subscriptions","organizations_url":"https://api.github.com/users/NCIOCPL/orgs","repos_url":"https://api.github.com/users/NCIOCPL/repos","events_url":"https://api.github.com/users/NCIOCPL/events{/privacy}","received_events_url":"https://api.github.com/users/NCIOCPL/received_events","type":"Organization","site_admin":false},"repo":{"id":98353543,"node_id":"MDEwOlJlcG9zaXRvcnk5ODM1MzU0Mw==","name":"wcms-front-end","full_name":"NCIOCPL/wcms-front-end","private":false,"owner":{"login":"NCIOCPL","id":22624912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjI0OTEy","avatar_url":"https://avatars3.githubusercontent.com/u/22624912?v=4","gravatar_id":"","url":"https://api.github.com/users/NCIOCPL","html_url":"https://github.com/NCIOCPL","followers_url":"https://api.github.com/users/NCIOCPL/followers","following_url":"https://api.github.com/users/NCIOCPL/following{/other_user}","gists_url":"https://api.github.com/users/NCIOCPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NCIOCPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCIOCPL/subscriptions","organizations_url":"https://api.github.com/users/NCIOCPL/orgs","repos_url":"https://api.github.com/users/NCIOCPL/repos","events_url":"https://api.github.com/users/NCIOCPL/events{/privacy}","received_events_url":"https://api.github.com/users/NCIOCPL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NCIOCPL/wcms-front-end","description":"WCMS presentation layer.","fork":false,"url":"https://api.github.com/repos/NCIOCPL/wcms-front-end","forks_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/forks","keys_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/teams","hooks_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/hooks","issue_events_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/issues/events{/number}","events_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/events","assignees_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/assignees{/user}","branches_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/branches{/branch}","tags_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/tags","blobs_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/git/refs{/sha}","trees_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/statuses/{sha}","languages_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/languages","stargazers_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/stargazers","contributors_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/contributors","subscribers_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/subscribers","subscription_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/subscription","commits_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/commits{/sha}","git_commits_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/git/commits{/sha}","comments_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/comments{/number}","issue_comment_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/issues/comments{/number}","contents_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/contents/{+path}","compare_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/merges","archive_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/downloads","issues_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/issues{/number}","pulls_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/pulls{/number}","milestones_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/milestones{/number}","notifications_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/labels{/name}","releases_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/releases{/id}","deployments_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/deployments","created_at":"2017-07-25T21:59:36Z","updated_at":"2019-02-14T04:45:40Z","pushed_at":"2019-02-27T00:37:52Z","git_url":"git://github.com/NCIOCPL/wcms-front-end.git","ssh_url":"git@github.com:NCIOCPL/wcms-front-end.git","clone_url":"https://github.com/NCIOCPL/wcms-front-end.git","svn_url":"https://github.com/NCIOCPL/wcms-front-end","homepage":"","size":18308,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NCIOCPL:FEQ-february2019-backlog-release","ref":"FEQ-february2019-backlog-release","sha":"b3779156dbbca0bfbe5d3b10df063174c0b506b1","user":{"login":"NCIOCPL","id":22624912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjI0OTEy","avatar_url":"https://avatars3.githubusercontent.com/u/22624912?v=4","gravatar_id":"","url":"https://api.github.com/users/NCIOCPL","html_url":"https://github.com/NCIOCPL","followers_url":"https://api.github.com/users/NCIOCPL/followers","following_url":"https://api.github.com/users/NCIOCPL/following{/other_user}","gists_url":"https://api.github.com/users/NCIOCPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NCIOCPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCIOCPL/subscriptions","organizations_url":"https://api.github.com/users/NCIOCPL/orgs","repos_url":"https://api.github.com/users/NCIOCPL/repos","events_url":"https://api.github.com/users/NCIOCPL/events{/privacy}","received_events_url":"https://api.github.com/users/NCIOCPL/received_events","type":"Organization","site_admin":false},"repo":{"id":98353543,"node_id":"MDEwOlJlcG9zaXRvcnk5ODM1MzU0Mw==","name":"wcms-front-end","full_name":"NCIOCPL/wcms-front-end","private":false,"owner":{"login":"NCIOCPL","id":22624912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjI0OTEy","avatar_url":"https://avatars3.githubusercontent.com/u/22624912?v=4","gravatar_id":"","url":"https://api.github.com/users/NCIOCPL","html_url":"https://github.com/NCIOCPL","followers_url":"https://api.github.com/users/NCIOCPL/followers","following_url":"https://api.github.com/users/NCIOCPL/following{/other_user}","gists_url":"https://api.github.com/users/NCIOCPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NCIOCPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCIOCPL/subscriptions","organizations_url":"https://api.github.com/users/NCIOCPL/orgs","repos_url":"https://api.github.com/users/NCIOCPL/repos","events_url":"https://api.github.com/users/NCIOCPL/events{/privacy}","received_events_url":"https://api.github.com/users/NCIOCPL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NCIOCPL/wcms-front-end","description":"WCMS presentation layer.","fork":false,"url":"https://api.github.com/repos/NCIOCPL/wcms-front-end","forks_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/forks","keys_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/teams","hooks_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/hooks","issue_events_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/issues/events{/number}","events_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/events","assignees_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/assignees{/user}","branches_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/branches{/branch}","tags_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/tags","blobs_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/git/refs{/sha}","trees_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/statuses/{sha}","languages_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/languages","stargazers_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/stargazers","contributors_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/contributors","subscribers_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/subscribers","subscription_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/subscription","commits_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/commits{/sha}","git_commits_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/git/commits{/sha}","comments_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/comments{/number}","issue_comment_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/issues/comments{/number}","contents_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/contents/{+path}","compare_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/merges","archive_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/downloads","issues_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/issues{/number}","pulls_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/pulls{/number}","milestones_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/milestones{/number}","notifications_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/labels{/name}","releases_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/releases{/id}","deployments_url":"https://api.github.com/repos/NCIOCPL/wcms-front-end/deployments","created_at":"2017-07-25T21:59:36Z","updated_at":"2019-02-14T04:45:40Z","pushed_at":"2019-02-27T00:37:52Z","git_url":"git://github.com/NCIOCPL/wcms-front-end.git","ssh_url":"git@github.com:NCIOCPL/wcms-front-end.git","clone_url":"https://github.com/NCIOCPL/wcms-front-end.git","svn_url":"https://github.com/NCIOCPL/wcms-front-end","homepage":"","size":18308,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NCIOCPL/wcms-front-end/pulls/332"},"html":{"href":"https://github.com/NCIOCPL/wcms-front-end/pull/332"},"issue":{"href":"https://api.github.com/repos/NCIOCPL/wcms-front-end/issues/332"},"comments":{"href":"https://api.github.com/repos/NCIOCPL/wcms-front-end/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/NCIOCPL/wcms-front-end/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/NCIOCPL/wcms-front-end/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NCIOCPL/wcms-front-end/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/NCIOCPL/wcms-front-end/statuses/0fceffb0ee24d54a5f9605a6b9a943ecc9ef473f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alifr","id":5579274,"node_id":"MDQ6VXNlcjU1NzkyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5579274?v=4","gravatar_id":"","url":"https://api.github.com/users/alifr","html_url":"https://github.com/alifr","followers_url":"https://api.github.com/users/alifr/followers","following_url":"https://api.github.com/users/alifr/following{/other_user}","gists_url":"https://api.github.com/users/alifr/gists{/gist_id}","starred_url":"https://api.github.com/users/alifr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alifr/subscriptions","organizations_url":"https://api.github.com/users/alifr/orgs","repos_url":"https://api.github.com/users/alifr/repos","events_url":"https://api.github.com/users/alifr/events{/privacy}","received_events_url":"https://api.github.com/users/alifr/received_events","type":"User","site_admin":false},"comments":0,"review_comments":12,"maintainer_can_modify":false,"commits":6,"additions":125,"deletions":96,"changed_files":3}}
{"actor":{"display_login":"alifr"}}