{"action":"created","comment":{"url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/comments/303815272","pull_request_review_id":262297656,"id":303815272,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzgxNTI3Mg==","diff_hunk":"@@ -22,16 +22,19 @@ const LinkdropSDK = ({\n     throw new Error('Please provide valid chain and/or chain id')\n   }\n \n-  let version\n   const provider = new ethers.providers.JsonRpcProvider(jsonRpcUrl)\n+\n   const factoryContract = new ethers.Contract(\n     factory,\n     LinkdropFactory.abi,\n     provider\n   )\n \n-  const getVersion = async () => {\n-    return factoryContract.getProxyMasterCopyVersion(linkdropMasterAddress)\n+  const getVersion = async campaignId => {","path":"sdk/src/index.js","position":24,"original_position":24,"commit_id":"e3dd97db2d39dfa568d385cdea5fb79d5c7dd94b","original_commit_id":"e3dd97db2d39dfa568d385cdea5fb79d5c7dd94b","user":{"login":"Dobrokhvalov","id":4770810,"node_id":"MDQ6VXNlcjQ3NzA4MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4770810?v=4","gravatar_id":"","url":"https://api.github.com/users/Dobrokhvalov","html_url":"https://github.com/Dobrokhvalov","followers_url":"https://api.github.com/users/Dobrokhvalov/followers","following_url":"https://api.github.com/users/Dobrokhvalov/following{/other_user}","gists_url":"https://api.github.com/users/Dobrokhvalov/gists{/gist_id}","starred_url":"https://api.github.com/users/Dobrokhvalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dobrokhvalov/subscriptions","organizations_url":"https://api.github.com/users/Dobrokhvalov/orgs","repos_url":"https://api.github.com/users/Dobrokhvalov/repos","events_url":"https://api.github.com/users/Dobrokhvalov/events{/privacy}","received_events_url":"https://api.github.com/users/Dobrokhvalov/received_events","type":"User","site_admin":false},"body":"@amiromayer, add memoization here: \r\n```\r\nif (!dct[campaignId]) {\r\n dct[campaignId] = await factoryContract.getProxyMasterCopyVersion... \r\n}\r\nreturn dct[campaignId]\r\n```","created_at":"2019-07-16T09:38:35Z","updated_at":"2019-07-16T09:38:35Z","html_url":"https://github.com/LinkdropProtocol/linkdrop-monorepo/pull/276#discussion_r303815272","pull_request_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/276","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/comments/303815272"},"html":{"href":"https://github.com/LinkdropProtocol/linkdrop-monorepo/pull/276#discussion_r303815272"},"pull_request":{"href":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/276"}}},"pull_request":{"url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/276","id":297953305,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3OTUzMzA1","html_url":"https://github.com/LinkdropProtocol/linkdrop-monorepo/pull/276","diff_url":"https://github.com/LinkdropProtocol/linkdrop-monorepo/pull/276.diff","patch_url":"https://github.com/LinkdropProtocol/linkdrop-monorepo/pull/276.patch","issue_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/issues/276","number":276,"state":"open","locked":false,"title":"Updated scripts and sdk (After dev branch update)","user":{"login":"Dobrokhvalov","id":4770810,"node_id":"MDQ6VXNlcjQ3NzA4MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4770810?v=4","gravatar_id":"","url":"https://api.github.com/users/Dobrokhvalov","html_url":"https://github.com/Dobrokhvalov","followers_url":"https://api.github.com/users/Dobrokhvalov/followers","following_url":"https://api.github.com/users/Dobrokhvalov/following{/other_user}","gists_url":"https://api.github.com/users/Dobrokhvalov/gists{/gist_id}","starred_url":"https://api.github.com/users/Dobrokhvalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dobrokhvalov/subscriptions","organizations_url":"https://api.github.com/users/Dobrokhvalov/orgs","repos_url":"https://api.github.com/users/Dobrokhvalov/repos","events_url":"https://api.github.com/users/Dobrokhvalov/events{/privacy}","received_events_url":"https://api.github.com/users/Dobrokhvalov/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-16T09:31:07Z","updated_at":"2019-07-16T09:38:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c214ffcca3dcac9fbe9aa81274daa1b33e7a6fc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/276/commits","review_comments_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/276/comments","review_comment_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/issues/276/comments","statuses_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/statuses/e3dd97db2d39dfa568d385cdea5fb79d5c7dd94b","head":{"label":"LinkdropProtocol:dev_271","ref":"dev_271","sha":"e3dd97db2d39dfa568d385cdea5fb79d5c7dd94b","user":{"login":"LinkdropProtocol","id":47248636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MjQ4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/47248636?v=4","gravatar_id":"","url":"https://api.github.com/users/LinkdropProtocol","html_url":"https://github.com/LinkdropProtocol","followers_url":"https://api.github.com/users/LinkdropProtocol/followers","following_url":"https://api.github.com/users/LinkdropProtocol/following{/other_user}","gists_url":"https://api.github.com/users/LinkdropProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/LinkdropProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinkdropProtocol/subscriptions","organizations_url":"https://api.github.com/users/LinkdropProtocol/orgs","repos_url":"https://api.github.com/users/LinkdropProtocol/repos","events_url":"https://api.github.com/users/LinkdropProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/LinkdropProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":179045813,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkwNDU4MTM=","name":"linkdrop-monorepo","full_name":"LinkdropProtocol/linkdrop-monorepo","private":false,"owner":{"login":"LinkdropProtocol","id":47248636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MjQ4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/47248636?v=4","gravatar_id":"","url":"https://api.github.com/users/LinkdropProtocol","html_url":"https://github.com/LinkdropProtocol","followers_url":"https://api.github.com/users/LinkdropProtocol/followers","following_url":"https://api.github.com/users/LinkdropProtocol/following{/other_user}","gists_url":"https://api.github.com/users/LinkdropProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/LinkdropProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinkdropProtocol/subscriptions","organizations_url":"https://api.github.com/users/LinkdropProtocol/orgs","repos_url":"https://api.github.com/users/LinkdropProtocol/repos","events_url":"https://api.github.com/users/LinkdropProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/LinkdropProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LinkdropProtocol/linkdrop-monorepo","description":"Send and receive Ether, ERC20 and/or ERC721 tokens via shareable links and QR codes","fork":false,"url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo","forks_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/forks","keys_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/teams","hooks_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/hooks","issue_events_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/events","assignees_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/tags","blobs_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/languages","stargazers_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/stargazers","contributors_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/contributors","subscribers_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/subscribers","subscription_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/subscription","commits_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/merges","archive_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/downloads","issues_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/deployments","created_at":"2019-04-02T09:38:35Z","updated_at":"2019-07-15T16:45:42Z","pushed_at":"2019-07-16T09:33:28Z","git_url":"git://github.com/LinkdropProtocol/linkdrop-monorepo.git","ssh_url":"git@github.com:LinkdropProtocol/linkdrop-monorepo.git","clone_url":"https://github.com/LinkdropProtocol/linkdrop-monorepo.git","svn_url":"https://github.com/LinkdropProtocol/linkdrop-monorepo","homepage":"https://linkdrop.io","size":8821,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":23,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":23,"watchers":8,"default_branch":"master"}},"base":{"label":"LinkdropProtocol:dev","ref":"dev","sha":"a011308a9791527422b77e98a14026ccab006d13","user":{"login":"LinkdropProtocol","id":47248636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MjQ4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/47248636?v=4","gravatar_id":"","url":"https://api.github.com/users/LinkdropProtocol","html_url":"https://github.com/LinkdropProtocol","followers_url":"https://api.github.com/users/LinkdropProtocol/followers","following_url":"https://api.github.com/users/LinkdropProtocol/following{/other_user}","gists_url":"https://api.github.com/users/LinkdropProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/LinkdropProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinkdropProtocol/subscriptions","organizations_url":"https://api.github.com/users/LinkdropProtocol/orgs","repos_url":"https://api.github.com/users/LinkdropProtocol/repos","events_url":"https://api.github.com/users/LinkdropProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/LinkdropProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":179045813,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkwNDU4MTM=","name":"linkdrop-monorepo","full_name":"LinkdropProtocol/linkdrop-monorepo","private":false,"owner":{"login":"LinkdropProtocol","id":47248636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MjQ4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/47248636?v=4","gravatar_id":"","url":"https://api.github.com/users/LinkdropProtocol","html_url":"https://github.com/LinkdropProtocol","followers_url":"https://api.github.com/users/LinkdropProtocol/followers","following_url":"https://api.github.com/users/LinkdropProtocol/following{/other_user}","gists_url":"https://api.github.com/users/LinkdropProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/LinkdropProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinkdropProtocol/subscriptions","organizations_url":"https://api.github.com/users/LinkdropProtocol/orgs","repos_url":"https://api.github.com/users/LinkdropProtocol/repos","events_url":"https://api.github.com/users/LinkdropProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/LinkdropProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LinkdropProtocol/linkdrop-monorepo","description":"Send and receive Ether, ERC20 and/or ERC721 tokens via shareable links and QR codes","fork":false,"url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo","forks_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/forks","keys_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/teams","hooks_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/hooks","issue_events_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/events","assignees_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/tags","blobs_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/languages","stargazers_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/stargazers","contributors_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/contributors","subscribers_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/subscribers","subscription_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/subscription","commits_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/merges","archive_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/downloads","issues_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/deployments","created_at":"2019-04-02T09:38:35Z","updated_at":"2019-07-15T16:45:42Z","pushed_at":"2019-07-16T09:33:28Z","git_url":"git://github.com/LinkdropProtocol/linkdrop-monorepo.git","ssh_url":"git@github.com:LinkdropProtocol/linkdrop-monorepo.git","clone_url":"https://github.com/LinkdropProtocol/linkdrop-monorepo.git","svn_url":"https://github.com/LinkdropProtocol/linkdrop-monorepo","homepage":"https://linkdrop.io","size":8821,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":23,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":23,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/276"},"html":{"href":"https://github.com/LinkdropProtocol/linkdrop-monorepo/pull/276"},"issue":{"href":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/issues/276"},"comments":{"href":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/LinkdropProtocol/linkdrop-monorepo/statuses/e3dd97db2d39dfa568d385cdea5fb79d5c7dd94b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Dobrokhvalov"}}