{"action":"created","issue":{"url":"https://api.github.com/repos/libreops/libredns.gr/issues/1","repository_url":"https://api.github.com/repos/libreops/libredns.gr","labels_url":"https://api.github.com/repos/libreops/libredns.gr/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/libreops/libredns.gr/issues/1/comments","events_url":"https://api.github.com/repos/libreops/libredns.gr/issues/1/events","html_url":"https://github.com/libreops/libredns.gr/issues/1","id":515215492,"node_id":"MDU6SXNzdWU1MTUyMTU0OTI=","number":1,"title":"A few suggestions","user":{"login":"XhmikosR","id":349621,"node_id":"MDQ6VXNlcjM0OTYyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/349621?v=4","gravatar_id":"","url":"https://api.github.com/users/XhmikosR","html_url":"https://github.com/XhmikosR","followers_url":"https://api.github.com/users/XhmikosR/followers","following_url":"https://api.github.com/users/XhmikosR/following{/other_user}","gists_url":"https://api.github.com/users/XhmikosR/gists{/gist_id}","starred_url":"https://api.github.com/users/XhmikosR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XhmikosR/subscriptions","organizations_url":"https://api.github.com/users/XhmikosR/orgs","repos_url":"https://api.github.com/users/XhmikosR/repos","events_url":"https://api.github.com/users/XhmikosR/events{/privacy}","received_events_url":"https://api.github.com/users/XhmikosR/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-10-31T07:12:02Z","updated_at":"2019-11-03T19:14:51Z","closed_at":null,"author_association":"NONE","body":"* use packages from npm instead of lib\r\n* use sass and extend Bootstrap's Sass; this will allow you to just include what you need\r\n* remove font awesome and just use an SVG; you only use one icon\r\n* use purgecss\r\n* optimize images\r\n* generate proper favicons for all platforms (I need the logo as an SVG, preferably square)\r\n\r\n427 for a single page seems a lot; we can definitely do a lot better :)\r\n\r\nPS. I could probably take a stab at it later and make a branch with separate patches with my suggestions."},"comment":{"url":"https://api.github.com/repos/libreops/libredns.gr/issues/comments/549168905","html_url":"https://github.com/libreops/libredns.gr/issues/1#issuecomment-549168905","issue_url":"https://api.github.com/repos/libreops/libredns.gr/issues/1","id":549168905,"node_id":"MDEyOklzc3VlQ29tbWVudDU0OTE2ODkwNQ==","user":{"login":"comzeradd","id":939357,"node_id":"MDQ6VXNlcjkzOTM1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/939357?v=4","gravatar_id":"","url":"https://api.github.com/users/comzeradd","html_url":"https://github.com/comzeradd","followers_url":"https://api.github.com/users/comzeradd/followers","following_url":"https://api.github.com/users/comzeradd/following{/other_user}","gists_url":"https://api.github.com/users/comzeradd/gists{/gist_id}","starred_url":"https://api.github.com/users/comzeradd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comzeradd/subscriptions","organizations_url":"https://api.github.com/users/comzeradd/orgs","repos_url":"https://api.github.com/users/comzeradd/repos","events_url":"https://api.github.com/users/comzeradd/events{/privacy}","received_events_url":"https://api.github.com/users/comzeradd/received_events","type":"User","site_admin":false},"created_at":"2019-11-03T19:14:51Z","updated_at":"2019-11-03T19:14:51Z","author_association":"MEMBER","body":"> > The packages inside lib are coming from npm. We just run gulp assets to move the relevant bits there so we don't need to have the node_modules folder on production.\r\n> \r\n> Then, shouldn't the lib folder be in .gitignore?\r\n\r\nNo, because we don't run `npm i` on production, we just clone whatever is on the repo. So we check-in the specific files we use from these libraries. Once we put this on CI we can definitely gitignore these files."}}
{"actor":{"display_login":"comzeradd"}}