{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/fsharp/pulls/comments/287441752","pull_request_review_id":241848158,"id":287441752,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NzQ0MTc1Mg==","diff_hunk":"@@ -34,7 +34,7 @@ type FSharpAccessibility(a:Accessibility, ?isProtected) =\n         | _ when List.forall isInternalCompPath p  -> Internal \n         | _ -> Private\n \n-    member __.IsPublic = not isProtected && match a with Public -> true | _ -> false\n+    member __.IsPublic = not isProtected && match a with TAccess [] -> true | _ -> false","path":"src/fsharp/symbols/Symbols.fs","position":5,"original_position":5,"commit_id":"dad2fe42b708d19ab6a96ab16a51fbf46976f770","original_commit_id":"dad2fe42b708d19ab6a96ab16a51fbf46976f770","user":{"login":"baronfel","id":573979,"node_id":"MDQ6VXNlcjU3Mzk3OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/573979?v=4","gravatar_id":"","url":"https://api.github.com/users/baronfel","html_url":"https://github.com/baronfel","followers_url":"https://api.github.com/users/baronfel/followers","following_url":"https://api.github.com/users/baronfel/following{/other_user}","gists_url":"https://api.github.com/users/baronfel/gists{/gist_id}","starred_url":"https://api.github.com/users/baronfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baronfel/subscriptions","organizations_url":"https://api.github.com/users/baronfel/orgs","repos_url":"https://api.github.com/users/baronfel/repos","events_url":"https://api.github.com/users/baronfel/events{/privacy}","received_events_url":"https://api.github.com/users/baronfel/received_events","type":"User","site_admin":false},"body":"Not sure about the type-private case you mention, but if you remove the `inline` in that sharplab you see the additional choice allocations occurring. It's also a very simple example and I'm sure there's additional context I'm missing.  And yes, I do mean `inline` :D","created_at":"2019-05-24T16:57:20Z","updated_at":"2019-05-24T16:57:20Z","html_url":"https://github.com/dotnet/fsharp/pull/6847#discussion_r287441752","pull_request_url":"https://api.github.com/repos/dotnet/fsharp/pulls/6847","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/fsharp/pulls/comments/287441752"},"html":{"href":"https://github.com/dotnet/fsharp/pull/6847#discussion_r287441752"},"pull_request":{"href":"https://api.github.com/repos/dotnet/fsharp/pulls/6847"}},"in_reply_to_id":287440794},"pull_request":{"url":"https://api.github.com/repos/dotnet/fsharp/pulls/6847","id":282088334,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyMDg4MzM0","html_url":"https://github.com/dotnet/fsharp/pull/6847","diff_url":"https://github.com/dotnet/fsharp/pull/6847.diff","patch_url":"https://github.com/dotnet/fsharp/pull/6847.patch","issue_url":"https://api.github.com/repos/dotnet/fsharp/issues/6847","number":6847,"state":"open","locked":false,"title":"Make FSharpAccessibility.IsProtected public, optimize IsPublic property","user":{"login":"auduchinok","id":3923587,"node_id":"MDQ6VXNlcjM5MjM1ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/3923587?v=4","gravatar_id":"","url":"https://api.github.com/users/auduchinok","html_url":"https://github.com/auduchinok","followers_url":"https://api.github.com/users/auduchinok/followers","following_url":"https://api.github.com/users/auduchinok/following{/other_user}","gists_url":"https://api.github.com/users/auduchinok/gists{/gist_id}","starred_url":"https://api.github.com/users/auduchinok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auduchinok/subscriptions","organizations_url":"https://api.github.com/users/auduchinok/orgs","repos_url":"https://api.github.com/users/auduchinok/repos","events_url":"https://api.github.com/users/auduchinok/events{/privacy}","received_events_url":"https://api.github.com/users/auduchinok/received_events","type":"User","site_admin":false},"body":"Small changes to FSharpAccessibility in Symbols API.","created_at":"2019-05-24T16:50:41Z","updated_at":"2019-05-24T16:57:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c64b0d7dc3fb1e4186e1be106dc7d74c06f0554e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/fsharp/pulls/6847/commits","review_comments_url":"https://api.github.com/repos/dotnet/fsharp/pulls/6847/comments","review_comment_url":"https://api.github.com/repos/dotnet/fsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/fsharp/issues/6847/comments","statuses_url":"https://api.github.com/repos/dotnet/fsharp/statuses/dad2fe42b708d19ab6a96ab16a51fbf46976f770","head":{"label":"auduchinok:accessibility-protected","ref":"accessibility-protected","sha":"dad2fe42b708d19ab6a96ab16a51fbf46976f770","user":{"login":"auduchinok","id":3923587,"node_id":"MDQ6VXNlcjM5MjM1ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/3923587?v=4","gravatar_id":"","url":"https://api.github.com/users/auduchinok","html_url":"https://github.com/auduchinok","followers_url":"https://api.github.com/users/auduchinok/followers","following_url":"https://api.github.com/users/auduchinok/following{/other_user}","gists_url":"https://api.github.com/users/auduchinok/gists{/gist_id}","starred_url":"https://api.github.com/users/auduchinok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auduchinok/subscriptions","organizations_url":"https://api.github.com/users/auduchinok/orgs","repos_url":"https://api.github.com/users/auduchinok/repos","events_url":"https://api.github.com/users/auduchinok/events{/privacy}","received_events_url":"https://api.github.com/users/auduchinok/received_events","type":"User","site_admin":false},"repo":{"id":92434210,"node_id":"MDEwOlJlcG9zaXRvcnk5MjQzNDIxMA==","name":"visualfsharp","full_name":"auduchinok/visualfsharp","private":false,"owner":{"login":"auduchinok","id":3923587,"node_id":"MDQ6VXNlcjM5MjM1ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/3923587?v=4","gravatar_id":"","url":"https://api.github.com/users/auduchinok","html_url":"https://github.com/auduchinok","followers_url":"https://api.github.com/users/auduchinok/followers","following_url":"https://api.github.com/users/auduchinok/following{/other_user}","gists_url":"https://api.github.com/users/auduchinok/gists{/gist_id}","starred_url":"https://api.github.com/users/auduchinok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auduchinok/subscriptions","organizations_url":"https://api.github.com/users/auduchinok/orgs","repos_url":"https://api.github.com/users/auduchinok/repos","events_url":"https://api.github.com/users/auduchinok/events{/privacy}","received_events_url":"https://api.github.com/users/auduchinok/received_events","type":"User","site_admin":false},"html_url":"https://github.com/auduchinok/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/auduchinok/visualfsharp","forks_url":"https://api.github.com/repos/auduchinok/visualfsharp/forks","keys_url":"https://api.github.com/repos/auduchinok/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auduchinok/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auduchinok/visualfsharp/teams","hooks_url":"https://api.github.com/repos/auduchinok/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/auduchinok/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/auduchinok/visualfsharp/events","assignees_url":"https://api.github.com/repos/auduchinok/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/auduchinok/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/auduchinok/visualfsharp/tags","blobs_url":"https://api.github.com/repos/auduchinok/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auduchinok/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auduchinok/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/auduchinok/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auduchinok/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/auduchinok/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/auduchinok/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/auduchinok/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/auduchinok/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/auduchinok/visualfsharp/subscription","commits_url":"https://api.github.com/repos/auduchinok/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/auduchinok/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/auduchinok/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/auduchinok/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/auduchinok/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/auduchinok/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auduchinok/visualfsharp/merges","archive_url":"https://api.github.com/repos/auduchinok/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auduchinok/visualfsharp/downloads","issues_url":"https://api.github.com/repos/auduchinok/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/auduchinok/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/auduchinok/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/auduchinok/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auduchinok/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/auduchinok/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/auduchinok/visualfsharp/deployments","created_at":"2017-05-25T18:49:46Z","updated_at":"2019-05-15T20:03:35Z","pushed_at":"2019-05-24T16:49:10Z","git_url":"git://github.com/auduchinok/visualfsharp.git","ssh_url":"git@github.com:auduchinok/visualfsharp.git","clone_url":"https://github.com/auduchinok/visualfsharp.git","svn_url":"https://github.com/auduchinok/visualfsharp","homepage":null,"size":155111,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f83739fb7a8423b04624d0a44b001a82562e388b","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA0ODg5MQ==","name":"fsharp","full_name":"dotnet/fsharp","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/fsharp","description":"The F# compiler, FSharp.Core library, and tools for F#","fork":false,"url":"https://api.github.com/repos/dotnet/fsharp","forks_url":"https://api.github.com/repos/dotnet/fsharp/forks","keys_url":"https://api.github.com/repos/dotnet/fsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/fsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/fsharp/teams","hooks_url":"https://api.github.com/repos/dotnet/fsharp/hooks","issue_events_url":"https://api.github.com/repos/dotnet/fsharp/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/fsharp/events","assignees_url":"https://api.github.com/repos/dotnet/fsharp/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/fsharp/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/fsharp/tags","blobs_url":"https://api.github.com/repos/dotnet/fsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/fsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/fsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/fsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/fsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/fsharp/languages","stargazers_url":"https://api.github.com/repos/dotnet/fsharp/stargazers","contributors_url":"https://api.github.com/repos/dotnet/fsharp/contributors","subscribers_url":"https://api.github.com/repos/dotnet/fsharp/subscribers","subscription_url":"https://api.github.com/repos/dotnet/fsharp/subscription","commits_url":"https://api.github.com/repos/dotnet/fsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/fsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/fsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/fsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/fsharp/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/fsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/fsharp/merges","archive_url":"https://api.github.com/repos/dotnet/fsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/fsharp/downloads","issues_url":"https://api.github.com/repos/dotnet/fsharp/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/fsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/fsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/fsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/fsharp/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/fsharp/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/fsharp/deployments","created_at":"2015-01-10T05:58:43Z","updated_at":"2019-05-24T15:53:05Z","pushed_at":"2019-05-24T16:50:42Z","git_url":"git://github.com/dotnet/fsharp.git","ssh_url":"git@github.com:dotnet/fsharp.git","clone_url":"https://github.com/dotnet/fsharp.git","svn_url":"https://github.com/dotnet/fsharp","homepage":"https://www.microsoft.com/net/learn/languages/fsharp","size":167402,"stargazers_count":1748,"watchers_count":1748,"language":"F#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":430,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":813,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":430,"open_issues":813,"watchers":1748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/fsharp/pulls/6847"},"html":{"href":"https://github.com/dotnet/fsharp/pull/6847"},"issue":{"href":"https://api.github.com/repos/dotnet/fsharp/issues/6847"},"comments":{"href":"https://api.github.com/repos/dotnet/fsharp/issues/6847/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/fsharp/pulls/6847/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/fsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/fsharp/pulls/6847/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/fsharp/statuses/dad2fe42b708d19ab6a96ab16a51fbf46976f770"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"baronfel"}}