{"action":"created","issue":{"url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1762","repository_url":"https://api.github.com/repos/graphhopper/graphhopper","labels_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1762/labels{/name}","comments_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1762/comments","events_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1762/events","html_url":"https://github.com/graphhopper/graphhopper/pull/1762","id":510954104,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxMjQwODA3","number":1762,"title":"introduce new POST /route possibility","user":{"login":"karussell","id":129644,"node_id":"MDQ6VXNlcjEyOTY0NA==","avatar_url":"https://avatars0.githubusercontent.com/u/129644?v=4","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"labels":[{"id":32202809,"node_id":"MDU6TGFiZWwzMjIwMjgwOQ==","url":"https://api.github.com/repos/graphhopper/graphhopper/labels/new%20feature","name":"new feature","color":"0b02e1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-10-22T22:13:22Z","updated_at":"2019-10-23T06:26:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/1762","html_url":"https://github.com/graphhopper/graphhopper/pull/1762","diff_url":"https://github.com/graphhopper/graphhopper/pull/1762.diff","patch_url":"https://github.com/graphhopper/graphhopper/pull/1762.patch"},"body":"fixes #1689\r\n\r\nWith the new \"curbsides\" features the problems described in #1689 will be even worse and so I think we need this new option. I was surprised that it was possible with so few code lines (the actual feature is 50 lines!). Especially nice is the possibility to annotate classes like GHRequest without adding the annotation dependency to core via so called MixIn classes.\r\n\r\nTODOs:\r\n\r\n - [ ] maybe rename `GHRequest.put(String fieldName, Object value)` into `putHint` and add javadoc that this is different to point_hint\r\n - [ ] should we rename `GHRequest setCurbSides(List<String> curbSides)` into `setCurbsides`?\r\n - [ ] see: TODO NOW was this really missing before? also update api-doc.md for /route endpoint\r\n - [ ] see: TODO NOW for more than 50 or 100 locations we could zip the body\r\n - [ ] bring to production and use setPostRequest(true) in integration test"},"comment":{"url":"https://api.github.com/repos/graphhopper/graphhopper/issues/comments/545288938","html_url":"https://github.com/graphhopper/graphhopper/pull/1762#issuecomment-545288938","issue_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1762","id":545288938,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NTI4ODkzOA==","user":{"login":"easbar","id":17603532,"node_id":"MDQ6VXNlcjE3NjAzNTMy","avatar_url":"https://avatars1.githubusercontent.com/u/17603532?v=4","gravatar_id":"","url":"https://api.github.com/users/easbar","html_url":"https://github.com/easbar","followers_url":"https://api.github.com/users/easbar/followers","following_url":"https://api.github.com/users/easbar/following{/other_user}","gists_url":"https://api.github.com/users/easbar/gists{/gist_id}","starred_url":"https://api.github.com/users/easbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easbar/subscriptions","organizations_url":"https://api.github.com/users/easbar/orgs","repos_url":"https://api.github.com/users/easbar/repos","events_url":"https://api.github.com/users/easbar/events{/privacy}","received_events_url":"https://api.github.com/users/easbar/received_events","type":"User","site_admin":false},"created_at":"2019-10-23T06:26:58Z","updated_at":"2019-10-23T06:26:58Z","author_association":"COLLABORATOR","body":"> decide by itself whether it should use the GET or the POST request?\r\n\r\nIn which case would should it use GET, can it not just always use POST ? that said I think having the setter is useful to test the GET/POST endpoints separately (or even run the existing tests `@Parameterized` once using GET and once using POST). "}}
{"actor":{"display_login":"easbar"}}