{"action":"opened","number":2551,"pull_request":{"url":"https://api.github.com/repos/windmilleng/tilt/pulls/2551","id":340672378,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQwNjcyMzc4","html_url":"https://github.com/windmilleng/tilt/pull/2551","diff_url":"https://github.com/windmilleng/tilt/pull/2551.diff","patch_url":"https://github.com/windmilleng/tilt/pull/2551.patch","issue_url":"https://api.github.com/repos/windmilleng/tilt/issues/2551","number":2551,"state":"open","locked":false,"title":"web: If the ending line is an element, grab the lineID directly","user":{"login":"jazzdan","id":452453,"node_id":"MDQ6VXNlcjQ1MjQ1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/452453?v=4","gravatar_id":"","url":"https://api.github.com/users/jazzdan","html_url":"https://github.com/jazzdan","followers_url":"https://api.github.com/users/jazzdan/followers","following_url":"https://api.github.com/users/jazzdan/following{/other_user}","gists_url":"https://api.github.com/users/jazzdan/gists{/gist_id}","starred_url":"https://api.github.com/users/jazzdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jazzdan/subscriptions","organizations_url":"https://api.github.com/users/jazzdan/orgs","repos_url":"https://api.github.com/users/jazzdan/repos","events_url":"https://api.github.com/users/jazzdan/events{/privacy}","received_events_url":"https://api.github.com/users/jazzdan/received_events","type":"User","site_admin":false},"body":"When you select UP the ending log line is an element, not a text node.\r\n\r\nWhen checking the ending element, see which kind of node it is, and handle it appropriately.","created_at":"2019-11-13T21:18:18Z","updated_at":"2019-11-13T21:18:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"hyu","id":20349,"node_id":"MDQ6VXNlcjIwMzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/20349?v=4","gravatar_id":"","url":"https://api.github.com/users/hyu","html_url":"https://github.com/hyu","followers_url":"https://api.github.com/users/hyu/followers","following_url":"https://api.github.com/users/hyu/following{/other_user}","gists_url":"https://api.github.com/users/hyu/gists{/gist_id}","starred_url":"https://api.github.com/users/hyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyu/subscriptions","organizations_url":"https://api.github.com/users/hyu/orgs","repos_url":"https://api.github.com/users/hyu/repos","events_url":"https://api.github.com/users/hyu/events{/privacy}","received_events_url":"https://api.github.com/users/hyu/received_events","type":"User","site_admin":false},{"login":"nicks","id":278641,"node_id":"MDQ6VXNlcjI3ODY0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/278641?v=4","gravatar_id":"","url":"https://api.github.com/users/nicks","html_url":"https://github.com/nicks","followers_url":"https://api.github.com/users/nicks/followers","following_url":"https://api.github.com/users/nicks/following{/other_user}","gists_url":"https://api.github.com/users/nicks/gists{/gist_id}","starred_url":"https://api.github.com/users/nicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicks/subscriptions","organizations_url":"https://api.github.com/users/nicks/orgs","repos_url":"https://api.github.com/users/nicks/repos","events_url":"https://api.github.com/users/nicks/events{/privacy}","received_events_url":"https://api.github.com/users/nicks/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/windmilleng/tilt/pulls/2551/commits","review_comments_url":"https://api.github.com/repos/windmilleng/tilt/pulls/2551/comments","review_comment_url":"https://api.github.com/repos/windmilleng/tilt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windmilleng/tilt/issues/2551/comments","statuses_url":"https://api.github.com/repos/windmilleng/tilt/statuses/6aaaff8870c68a4848d252ac3855fdf6925e8519","head":{"label":"windmilleng:dmiller/ch3947/you-can-t-make-a-highlight-while-dragging","ref":"dmiller/ch3947/you-can-t-make-a-highlight-while-dragging","sha":"6aaaff8870c68a4848d252ac3855fdf6925e8519","user":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"repo":{"id":143896900,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4OTY5MDA=","name":"tilt","full_name":"windmilleng/tilt","private":false,"owner":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/windmilleng/tilt","description":"Local Kubernetes development with no stress","fork":false,"url":"https://api.github.com/repos/windmilleng/tilt","forks_url":"https://api.github.com/repos/windmilleng/tilt/forks","keys_url":"https://api.github.com/repos/windmilleng/tilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windmilleng/tilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windmilleng/tilt/teams","hooks_url":"https://api.github.com/repos/windmilleng/tilt/hooks","issue_events_url":"https://api.github.com/repos/windmilleng/tilt/issues/events{/number}","events_url":"https://api.github.com/repos/windmilleng/tilt/events","assignees_url":"https://api.github.com/repos/windmilleng/tilt/assignees{/user}","branches_url":"https://api.github.com/repos/windmilleng/tilt/branches{/branch}","tags_url":"https://api.github.com/repos/windmilleng/tilt/tags","blobs_url":"https://api.github.com/repos/windmilleng/tilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windmilleng/tilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windmilleng/tilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/windmilleng/tilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windmilleng/tilt/statuses/{sha}","languages_url":"https://api.github.com/repos/windmilleng/tilt/languages","stargazers_url":"https://api.github.com/repos/windmilleng/tilt/stargazers","contributors_url":"https://api.github.com/repos/windmilleng/tilt/contributors","subscribers_url":"https://api.github.com/repos/windmilleng/tilt/subscribers","subscription_url":"https://api.github.com/repos/windmilleng/tilt/subscription","commits_url":"https://api.github.com/repos/windmilleng/tilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/windmilleng/tilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/windmilleng/tilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/windmilleng/tilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/windmilleng/tilt/contents/{+path}","compare_url":"https://api.github.com/repos/windmilleng/tilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windmilleng/tilt/merges","archive_url":"https://api.github.com/repos/windmilleng/tilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windmilleng/tilt/downloads","issues_url":"https://api.github.com/repos/windmilleng/tilt/issues{/number}","pulls_url":"https://api.github.com/repos/windmilleng/tilt/pulls{/number}","milestones_url":"https://api.github.com/repos/windmilleng/tilt/milestones{/number}","notifications_url":"https://api.github.com/repos/windmilleng/tilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windmilleng/tilt/labels{/name}","releases_url":"https://api.github.com/repos/windmilleng/tilt/releases{/id}","deployments_url":"https://api.github.com/repos/windmilleng/tilt/deployments","created_at":"2018-08-07T16:00:26Z","updated_at":"2019-11-13T19:50:49Z","pushed_at":"2019-11-13T21:17:18Z","git_url":"git://github.com/windmilleng/tilt.git","ssh_url":"git@github.com:windmilleng/tilt.git","clone_url":"https://github.com/windmilleng/tilt.git","svn_url":"https://github.com/windmilleng/tilt","homepage":"https://tilt.dev/","size":35297,"stargazers_count":2923,"watchers_count":2923,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":88,"open_issues":102,"watchers":2923,"default_branch":"master"}},"base":{"label":"windmilleng:master","ref":"master","sha":"a7df4bbc22b7d4803d4d966a35ee007d61637bde","user":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"repo":{"id":143896900,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4OTY5MDA=","name":"tilt","full_name":"windmilleng/tilt","private":false,"owner":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/windmilleng/tilt","description":"Local Kubernetes development with no stress","fork":false,"url":"https://api.github.com/repos/windmilleng/tilt","forks_url":"https://api.github.com/repos/windmilleng/tilt/forks","keys_url":"https://api.github.com/repos/windmilleng/tilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windmilleng/tilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windmilleng/tilt/teams","hooks_url":"https://api.github.com/repos/windmilleng/tilt/hooks","issue_events_url":"https://api.github.com/repos/windmilleng/tilt/issues/events{/number}","events_url":"https://api.github.com/repos/windmilleng/tilt/events","assignees_url":"https://api.github.com/repos/windmilleng/tilt/assignees{/user}","branches_url":"https://api.github.com/repos/windmilleng/tilt/branches{/branch}","tags_url":"https://api.github.com/repos/windmilleng/tilt/tags","blobs_url":"https://api.github.com/repos/windmilleng/tilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windmilleng/tilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windmilleng/tilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/windmilleng/tilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windmilleng/tilt/statuses/{sha}","languages_url":"https://api.github.com/repos/windmilleng/tilt/languages","stargazers_url":"https://api.github.com/repos/windmilleng/tilt/stargazers","contributors_url":"https://api.github.com/repos/windmilleng/tilt/contributors","subscribers_url":"https://api.github.com/repos/windmilleng/tilt/subscribers","subscription_url":"https://api.github.com/repos/windmilleng/tilt/subscription","commits_url":"https://api.github.com/repos/windmilleng/tilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/windmilleng/tilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/windmilleng/tilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/windmilleng/tilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/windmilleng/tilt/contents/{+path}","compare_url":"https://api.github.com/repos/windmilleng/tilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windmilleng/tilt/merges","archive_url":"https://api.github.com/repos/windmilleng/tilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windmilleng/tilt/downloads","issues_url":"https://api.github.com/repos/windmilleng/tilt/issues{/number}","pulls_url":"https://api.github.com/repos/windmilleng/tilt/pulls{/number}","milestones_url":"https://api.github.com/repos/windmilleng/tilt/milestones{/number}","notifications_url":"https://api.github.com/repos/windmilleng/tilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windmilleng/tilt/labels{/name}","releases_url":"https://api.github.com/repos/windmilleng/tilt/releases{/id}","deployments_url":"https://api.github.com/repos/windmilleng/tilt/deployments","created_at":"2018-08-07T16:00:26Z","updated_at":"2019-11-13T19:50:49Z","pushed_at":"2019-11-13T21:17:18Z","git_url":"git://github.com/windmilleng/tilt.git","ssh_url":"git@github.com:windmilleng/tilt.git","clone_url":"https://github.com/windmilleng/tilt.git","svn_url":"https://github.com/windmilleng/tilt","homepage":"https://tilt.dev/","size":35297,"stargazers_count":2923,"watchers_count":2923,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":88,"open_issues":102,"watchers":2923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/2551"},"html":{"href":"https://github.com/windmilleng/tilt/pull/2551"},"issue":{"href":"https://api.github.com/repos/windmilleng/tilt/issues/2551"},"comments":{"href":"https://api.github.com/repos/windmilleng/tilt/issues/2551/comments"},"review_comments":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/2551/comments"},"review_comment":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/2551/commits"},"statuses":{"href":"https://api.github.com/repos/windmilleng/tilt/statuses/6aaaff8870c68a4848d252ac3855fdf6925e8519"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"jazzdan"}}