{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments/323493669","pull_request_review_id":287116107,"id":323493669,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMzQ5MzY2OQ==","diff_hunk":"@@ -265,6 +265,23 @@ public ValueTask<FlushResult> WriteDataAsync(int streamId, StreamOutputFlowContr\n             }\n         }\n \n+        public void WriteDataWithoutFlush(int streamId, StreamOutputFlowControl flowControl, in ReadOnlySequence<byte> data, bool endStream)","path":"src/Servers/Kestrel/Core/src/Internal/Http2/Http2FrameWriter.cs","position":4,"original_position":4,"commit_id":"dfe6267601d774c480db55e752dacb4e4264b807","original_commit_id":"4efef27ccb45956c3bf81a5741f6f6ce90dad5b3","user":{"login":"jkotalik","id":8302101,"node_id":"MDQ6VXNlcjgzMDIxMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8302101?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotalik","html_url":"https://github.com/jkotalik","followers_url":"https://api.github.com/users/jkotalik/followers","following_url":"https://api.github.com/users/jkotalik/following{/other_user}","gists_url":"https://api.github.com/users/jkotalik/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotalik/subscriptions","organizations_url":"https://api.github.com/users/jkotalik/orgs","repos_url":"https://api.github.com/users/jkotalik/repos","events_url":"https://api.github.com/users/jkotalik/events{/privacy}","received_events_url":"https://api.github.com/users/jkotalik/received_events","type":"User","site_admin":false},"body":"I think it is an issue. flowControl is only accessed when holding the _writeLock, seems very prone to an issue.","created_at":"2019-09-11T22:53:38Z","updated_at":"2019-09-11T22:53:38Z","html_url":"https://github.com/aspnet/AspNetCore/pull/13914#discussion_r323493669","pull_request_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/13914","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments/323493669"},"html":{"href":"https://github.com/aspnet/AspNetCore/pull/13914#discussion_r323493669"},"pull_request":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/13914"}},"in_reply_to_id":323491770},"pull_request":{"url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/13914","id":316647513,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2NjQ3NTEz","html_url":"https://github.com/aspnet/AspNetCore/pull/13914","diff_url":"https://github.com/aspnet/AspNetCore/pull/13914.diff","patch_url":"https://github.com/aspnet/AspNetCore/pull/13914.patch","issue_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/13914","number":13914,"state":"open","locked":false,"title":"HTTP2: Send remaining data and trailers together","user":{"login":"JamesNK","id":303201,"node_id":"MDQ6VXNlcjMwMzIwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/303201?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesNK","html_url":"https://github.com/JamesNK","followers_url":"https://api.github.com/users/JamesNK/followers","following_url":"https://api.github.com/users/JamesNK/following{/other_user}","gists_url":"https://api.github.com/users/JamesNK/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesNK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesNK/subscriptions","organizations_url":"https://api.github.com/users/JamesNK/orgs","repos_url":"https://api.github.com/users/JamesNK/repos","events_url":"https://api.github.com/users/JamesNK/events{/privacy}","received_events_url":"https://api.github.com/users/JamesNK/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/aspnet/AspNetCore/issues/11270\r\n\r\nThe test checks that the data is correct, but it doesn't verify that data and trailers were flushed together. What is the best way to check this using the current HTTP/2 test pattern?","created_at":"2019-09-11T21:44:15Z","updated_at":"2019-09-11T22:53:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90e5232008b6340bda50d2370ce960b2e1f61ff5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anurse","id":7574,"node_id":"MDQ6VXNlcjc1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7574?v=4","gravatar_id":"","url":"https://api.github.com/users/anurse","html_url":"https://github.com/anurse","followers_url":"https://api.github.com/users/anurse/followers","following_url":"https://api.github.com/users/anurse/following{/other_user}","gists_url":"https://api.github.com/users/anurse/gists{/gist_id}","starred_url":"https://api.github.com/users/anurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anurse/subscriptions","organizations_url":"https://api.github.com/users/anurse/orgs","repos_url":"https://api.github.com/users/anurse/repos","events_url":"https://api.github.com/users/anurse/events{/privacy}","received_events_url":"https://api.github.com/users/anurse/received_events","type":"User","site_admin":false},{"login":"halter73","id":54385,"node_id":"MDQ6VXNlcjU0Mzg1","avatar_url":"https://avatars3.githubusercontent.com/u/54385?v=4","gravatar_id":"","url":"https://api.github.com/users/halter73","html_url":"https://github.com/halter73","followers_url":"https://api.github.com/users/halter73/followers","following_url":"https://api.github.com/users/halter73/following{/other_user}","gists_url":"https://api.github.com/users/halter73/gists{/gist_id}","starred_url":"https://api.github.com/users/halter73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halter73/subscriptions","organizations_url":"https://api.github.com/users/halter73/orgs","repos_url":"https://api.github.com/users/halter73/repos","events_url":"https://api.github.com/users/halter73/events{/privacy}","received_events_url":"https://api.github.com/users/halter73/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1119602498,"node_id":"MDU6TGFiZWwxMTE5NjAyNDk4","url":"https://api.github.com/repos/aspnet/AspNetCore/labels/area-servers","name":"area-servers","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/13914/commits","review_comments_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/13914/comments","review_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/13914/comments","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/dfe6267601d774c480db55e752dacb4e4264b807","head":{"label":"aspnet:jamesnk/http2-trailers-with-data","ref":"jamesnk/http2-trailers-with-data","sha":"dfe6267601d774c480db55e752dacb4e4264b807","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17620347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyMDM0Nw==","name":"AspNetCore","full_name":"aspnet/AspNetCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/AspNetCore","description":"ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.","fork":false,"url":"https://api.github.com/repos/aspnet/AspNetCore","forks_url":"https://api.github.com/repos/aspnet/AspNetCore/forks","keys_url":"https://api.github.com/repos/aspnet/AspNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/AspNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/AspNetCore/teams","hooks_url":"https://api.github.com/repos/aspnet/AspNetCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/AspNetCore/events","assignees_url":"https://api.github.com/repos/aspnet/AspNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/AspNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/AspNetCore/tags","blobs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/AspNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/AspNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/AspNetCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/AspNetCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/AspNetCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/AspNetCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/AspNetCore/subscription","commits_url":"https://api.github.com/repos/aspnet/AspNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/AspNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/AspNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/AspNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/AspNetCore/merges","archive_url":"https://api.github.com/repos/aspnet/AspNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/AspNetCore/downloads","issues_url":"https://api.github.com/repos/aspnet/AspNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/AspNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/AspNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/AspNetCore/deployments","created_at":"2014-03-11T06:09:42Z","updated_at":"2019-09-11T22:43:57Z","pushed_at":"2019-09-11T22:53:14Z","git_url":"git://github.com/aspnet/AspNetCore.git","ssh_url":"git@github.com:aspnet/AspNetCore.git","clone_url":"https://github.com/aspnet/AspNetCore.git","svn_url":"https://github.com/aspnet/AspNetCore","homepage":"https://asp.net","size":290689,"stargazers_count":13641,"watchers_count":13641,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3363,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1923,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3363,"open_issues":1923,"watchers":13641,"default_branch":"master"}},"base":{"label":"aspnet:master","ref":"master","sha":"71c5c66b211c7ab9d44751e39cef27c525124bb7","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17620347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyMDM0Nw==","name":"AspNetCore","full_name":"aspnet/AspNetCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/AspNetCore","description":"ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.","fork":false,"url":"https://api.github.com/repos/aspnet/AspNetCore","forks_url":"https://api.github.com/repos/aspnet/AspNetCore/forks","keys_url":"https://api.github.com/repos/aspnet/AspNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/AspNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/AspNetCore/teams","hooks_url":"https://api.github.com/repos/aspnet/AspNetCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/AspNetCore/events","assignees_url":"https://api.github.com/repos/aspnet/AspNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/AspNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/AspNetCore/tags","blobs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/AspNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/AspNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/AspNetCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/AspNetCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/AspNetCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/AspNetCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/AspNetCore/subscription","commits_url":"https://api.github.com/repos/aspnet/AspNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/AspNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/AspNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/AspNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/AspNetCore/merges","archive_url":"https://api.github.com/repos/aspnet/AspNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/AspNetCore/downloads","issues_url":"https://api.github.com/repos/aspnet/AspNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/AspNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/AspNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/AspNetCore/deployments","created_at":"2014-03-11T06:09:42Z","updated_at":"2019-09-11T22:43:57Z","pushed_at":"2019-09-11T22:53:14Z","git_url":"git://github.com/aspnet/AspNetCore.git","ssh_url":"git@github.com:aspnet/AspNetCore.git","clone_url":"https://github.com/aspnet/AspNetCore.git","svn_url":"https://github.com/aspnet/AspNetCore","homepage":"https://asp.net","size":290689,"stargazers_count":13641,"watchers_count":13641,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3363,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1923,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3363,"open_issues":1923,"watchers":13641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/13914"},"html":{"href":"https://github.com/aspnet/AspNetCore/pull/13914"},"issue":{"href":"https://api.github.com/repos/aspnet/AspNetCore/issues/13914"},"comments":{"href":"https://api.github.com/repos/aspnet/AspNetCore/issues/13914/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/13914/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/13914/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/AspNetCore/statuses/dfe6267601d774c480db55e752dacb4e4264b807"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jkotalik"}}