{"action":"closed","number":2548,"pull_request":{"url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/pulls/2548","id":267472177,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY3NDcyMTc3","html_url":"https://github.com/Cog-Creators/Red-DiscordBot/pull/2548","diff_url":"https://github.com/Cog-Creators/Red-DiscordBot/pull/2548.diff","patch_url":"https://github.com/Cog-Creators/Red-DiscordBot/pull/2548.patch","issue_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/2548","number":2548,"state":"closed","locked":false,"title":"[V3 Config] Make bot.add_cog() a coroutine","user":{"login":"tekulvw","id":3731082,"node_id":"MDQ6VXNlcjM3MzEwODI=","avatar_url":"https://avatars1.githubusercontent.com/u/3731082?v=4","gravatar_id":"","url":"https://api.github.com/users/tekulvw","html_url":"https://github.com/tekulvw","followers_url":"https://api.github.com/users/tekulvw/followers","following_url":"https://api.github.com/users/tekulvw/following{/other_user}","gists_url":"https://api.github.com/users/tekulvw/gists{/gist_id}","starred_url":"https://api.github.com/users/tekulvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tekulvw/subscriptions","organizations_url":"https://api.github.com/users/tekulvw/orgs","repos_url":"https://api.github.com/users/tekulvw/repos","events_url":"https://api.github.com/users/tekulvw/events{/privacy}","received_events_url":"https://api.github.com/users/tekulvw/received_events","type":"User","site_admin":false},"body":"### Type\r\n\r\n- [ ] Bugfix\r\n- [ ] Enhancement\r\n- [x] New feature\r\n\r\n### Description of the changes\r\nThis PR makes `bot.add_cog()` a coroutine and requires all cog `setup` functions to be coroutines as well. `bot.add_cog()` is overridden and used to save custom group information initialized during the cog's `__init__`.\r\n\r\nThis PR depends on #2545.\r\n","created_at":"2019-04-04T14:22:06Z","updated_at":"2019-04-05T01:50:57Z","closed_at":"2019-04-05T01:50:57Z","merged_at":null,"merge_commit_sha":"9dd2ffad716a81b10d104685c08ab41107f3873c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"palmtree5","id":3577255,"node_id":"MDQ6VXNlcjM1NzcyNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3577255?v=4","gravatar_id":"","url":"https://api.github.com/users/palmtree5","html_url":"https://github.com/palmtree5","followers_url":"https://api.github.com/users/palmtree5/followers","following_url":"https://api.github.com/users/palmtree5/following{/other_user}","gists_url":"https://api.github.com/users/palmtree5/gists{/gist_id}","starred_url":"https://api.github.com/users/palmtree5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palmtree5/subscriptions","organizations_url":"https://api.github.com/users/palmtree5/orgs","repos_url":"https://api.github.com/users/palmtree5/repos","events_url":"https://api.github.com/users/palmtree5/events{/privacy}","received_events_url":"https://api.github.com/users/palmtree5/received_events","type":"User","site_admin":false},{"login":"Twentysix26","id":6267772,"node_id":"MDQ6VXNlcjYyNjc3NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6267772?v=4","gravatar_id":"","url":"https://api.github.com/users/Twentysix26","html_url":"https://github.com/Twentysix26","followers_url":"https://api.github.com/users/Twentysix26/followers","following_url":"https://api.github.com/users/Twentysix26/following{/other_user}","gists_url":"https://api.github.com/users/Twentysix26/gists{/gist_id}","starred_url":"https://api.github.com/users/Twentysix26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Twentysix26/subscriptions","organizations_url":"https://api.github.com/users/Twentysix26/orgs","repos_url":"https://api.github.com/users/Twentysix26/repos","events_url":"https://api.github.com/users/Twentysix26/events{/privacy}","received_events_url":"https://api.github.com/users/Twentysix26/received_events","type":"User","site_admin":false},{"login":"Tobotimus","id":7438501,"node_id":"MDQ6VXNlcjc0Mzg1MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/7438501?v=4","gravatar_id":"","url":"https://api.github.com/users/Tobotimus","html_url":"https://github.com/Tobotimus","followers_url":"https://api.github.com/users/Tobotimus/followers","following_url":"https://api.github.com/users/Tobotimus/following{/other_user}","gists_url":"https://api.github.com/users/Tobotimus/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobotimus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobotimus/subscriptions","organizations_url":"https://api.github.com/users/Tobotimus/orgs","repos_url":"https://api.github.com/users/Tobotimus/repos","events_url":"https://api.github.com/users/Tobotimus/events{/privacy}","received_events_url":"https://api.github.com/users/Tobotimus/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":972882695,"node_id":"MDU6TGFiZWw5NzI4ODI2OTU=","url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/labels/Blocked%20by:%20Other%20PR","name":"Blocked by: Other PR","color":"ff5555","default":false},{"id":491301295,"node_id":"MDU6TGFiZWw0OTEzMDEyOTU=","url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/labels/Breaking%20Change","name":"Breaking Change","color":"ff0000","default":false},{"id":1022554516,"node_id":"MDU6TGFiZWwxMDIyNTU0NTE2","url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/labels/QA:%20Unassigned","name":"QA: Unassigned","color":"fcc900","default":false},{"id":593836458,"node_id":"MDU6TGFiZWw1OTM4MzY0NTg=","url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/labels/V3","name":"V3","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/pulls/2548/commits","review_comments_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/pulls/2548/comments","review_comment_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/2548/comments","statuses_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/statuses/7dc70953834dc75e664bf85dbcb11de9f2948323","head":{"label":"tekulvw:V3/add_cog_coro","ref":"V3/add_cog_coro","sha":"7dc70953834dc75e664bf85dbcb11de9f2948323","user":{"login":"tekulvw","id":3731082,"node_id":"MDQ6VXNlcjM3MzEwODI=","avatar_url":"https://avatars1.githubusercontent.com/u/3731082?v=4","gravatar_id":"","url":"https://api.github.com/users/tekulvw","html_url":"https://github.com/tekulvw","followers_url":"https://api.github.com/users/tekulvw/followers","following_url":"https://api.github.com/users/tekulvw/following{/other_user}","gists_url":"https://api.github.com/users/tekulvw/gists{/gist_id}","starred_url":"https://api.github.com/users/tekulvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tekulvw/subscriptions","organizations_url":"https://api.github.com/users/tekulvw/orgs","repos_url":"https://api.github.com/users/tekulvw/repos","events_url":"https://api.github.com/users/tekulvw/events{/privacy}","received_events_url":"https://api.github.com/users/tekulvw/received_events","type":"User","site_admin":false},"repo":{"id":52219662,"node_id":"MDEwOlJlcG9zaXRvcnk1MjIxOTY2Mg==","name":"Red-DiscordBot","full_name":"tekulvw/Red-DiscordBot","private":false,"owner":{"login":"tekulvw","id":3731082,"node_id":"MDQ6VXNlcjM3MzEwODI=","avatar_url":"https://avatars1.githubusercontent.com/u/3731082?v=4","gravatar_id":"","url":"https://api.github.com/users/tekulvw","html_url":"https://github.com/tekulvw","followers_url":"https://api.github.com/users/tekulvw/followers","following_url":"https://api.github.com/users/tekulvw/following{/other_user}","gists_url":"https://api.github.com/users/tekulvw/gists{/gist_id}","starred_url":"https://api.github.com/users/tekulvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tekulvw/subscriptions","organizations_url":"https://api.github.com/users/tekulvw/orgs","repos_url":"https://api.github.com/users/tekulvw/repos","events_url":"https://api.github.com/users/tekulvw/events{/privacy}","received_events_url":"https://api.github.com/users/tekulvw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tekulvw/Red-DiscordBot","description":"A highly modified version of Red-DiscordBot with (eventually) a redesigned plugin management system","fork":true,"url":"https://api.github.com/repos/tekulvw/Red-DiscordBot","forks_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/forks","keys_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/teams","hooks_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/hooks","issue_events_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/issues/events{/number}","events_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/events","assignees_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/assignees{/user}","branches_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/branches{/branch}","tags_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/tags","blobs_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/statuses/{sha}","languages_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/languages","stargazers_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/stargazers","contributors_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/contributors","subscribers_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/subscribers","subscription_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/subscription","commits_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/contents/{+path}","compare_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/merges","archive_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/downloads","issues_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/issues{/number}","pulls_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/pulls{/number}","milestones_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/milestones{/number}","notifications_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/labels{/name}","releases_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/releases{/id}","deployments_url":"https://api.github.com/repos/tekulvw/Red-DiscordBot/deployments","created_at":"2016-02-21T17:59:05Z","updated_at":"2017-12-23T06:20:25Z","pushed_at":"2019-04-05T00:56:09Z","git_url":"git://github.com/tekulvw/Red-DiscordBot.git","ssh_url":"git@github.com:tekulvw/Red-DiscordBot.git","clone_url":"https://github.com/tekulvw/Red-DiscordBot.git","svn_url":"https://github.com/tekulvw/Red-DiscordBot","homepage":"","size":44832,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":0,"watchers":10,"default_branch":"develop"}},"base":{"label":"Cog-Creators:V3/develop","ref":"V3/develop","sha":"c63d069f699b3241529ae3048e1123020da3f080","user":{"login":"Cog-Creators","id":23690422,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjkwNDIy","avatar_url":"https://avatars2.githubusercontent.com/u/23690422?v=4","gravatar_id":"","url":"https://api.github.com/users/Cog-Creators","html_url":"https://github.com/Cog-Creators","followers_url":"https://api.github.com/users/Cog-Creators/followers","following_url":"https://api.github.com/users/Cog-Creators/following{/other_user}","gists_url":"https://api.github.com/users/Cog-Creators/gists{/gist_id}","starred_url":"https://api.github.com/users/Cog-Creators/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cog-Creators/subscriptions","organizations_url":"https://api.github.com/users/Cog-Creators/orgs","repos_url":"https://api.github.com/users/Cog-Creators/repos","events_url":"https://api.github.com/users/Cog-Creators/events{/privacy}","received_events_url":"https://api.github.com/users/Cog-Creators/received_events","type":"Organization","site_admin":false},"repo":{"id":48904888,"node_id":"MDEwOlJlcG9zaXRvcnk0ODkwNDg4OA==","name":"Red-DiscordBot","full_name":"Cog-Creators/Red-DiscordBot","private":false,"owner":{"login":"Cog-Creators","id":23690422,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjkwNDIy","avatar_url":"https://avatars2.githubusercontent.com/u/23690422?v=4","gravatar_id":"","url":"https://api.github.com/users/Cog-Creators","html_url":"https://github.com/Cog-Creators","followers_url":"https://api.github.com/users/Cog-Creators/followers","following_url":"https://api.github.com/users/Cog-Creators/following{/other_user}","gists_url":"https://api.github.com/users/Cog-Creators/gists{/gist_id}","starred_url":"https://api.github.com/users/Cog-Creators/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cog-Creators/subscriptions","organizations_url":"https://api.github.com/users/Cog-Creators/orgs","repos_url":"https://api.github.com/users/Cog-Creators/repos","events_url":"https://api.github.com/users/Cog-Creators/events{/privacy}","received_events_url":"https://api.github.com/users/Cog-Creators/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Cog-Creators/Red-DiscordBot","description":"A multifunction Discord bot","fork":false,"url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot","forks_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/forks","keys_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/teams","hooks_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/hooks","issue_events_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/events{/number}","events_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/events","assignees_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/assignees{/user}","branches_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/branches{/branch}","tags_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/tags","blobs_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/statuses/{sha}","languages_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/languages","stargazers_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/stargazers","contributors_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/contributors","subscribers_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/subscribers","subscription_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/subscription","commits_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/contents/{+path}","compare_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/merges","archive_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/downloads","issues_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues{/number}","pulls_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/pulls{/number}","milestones_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/milestones{/number}","notifications_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/labels{/name}","releases_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/releases{/id}","deployments_url":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/deployments","created_at":"2016-01-02T09:27:12Z","updated_at":"2019-04-05T01:47:19Z","pushed_at":"2019-04-05T01:47:09Z","git_url":"git://github.com/Cog-Creators/Red-DiscordBot.git","ssh_url":"git@github.com:Cog-Creators/Red-DiscordBot.git","clone_url":"https://github.com/Cog-Creators/Red-DiscordBot.git","svn_url":"https://github.com/Cog-Creators/Red-DiscordBot","homepage":null,"size":45228,"stargazers_count":1198,"watchers_count":1198,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1008,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":130,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1008,"open_issues":130,"watchers":1198,"default_branch":"V3/develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/pulls/2548"},"html":{"href":"https://github.com/Cog-Creators/Red-DiscordBot/pull/2548"},"issue":{"href":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/2548"},"comments":{"href":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/issues/2548/comments"},"review_comments":{"href":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/pulls/2548/comments"},"review_comment":{"href":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/pulls/2548/commits"},"statuses":{"href":"https://api.github.com/repos/Cog-Creators/Red-DiscordBot/statuses/7dc70953834dc75e664bf85dbcb11de9f2948323"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":69,"deletions":42,"changed_files":21}}
{"actor":{"display_login":"tekulvw"}}