{"action":"created","issue":{"url":"https://api.github.com/repos/influxdata/flux/issues/1086","repository_url":"https://api.github.com/repos/influxdata/flux","labels_url":"https://api.github.com/repos/influxdata/flux/issues/1086/labels{/name}","comments_url":"https://api.github.com/repos/influxdata/flux/issues/1086/comments","events_url":"https://api.github.com/repos/influxdata/flux/issues/1086/events","html_url":"https://github.com/influxdata/flux/issues/1086","id":425075859,"node_id":"MDU6SXNzdWU0MjUwNzU4NTk=","number":1086,"title":"Change flux.Compiler interface to remove Spec","user":{"login":"nathanielc","id":3771906,"node_id":"MDQ6VXNlcjM3NzE5MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3771906?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanielc","html_url":"https://github.com/nathanielc","followers_url":"https://api.github.com/users/nathanielc/followers","following_url":"https://api.github.com/users/nathanielc/following{/other_user}","gists_url":"https://api.github.com/users/nathanielc/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielc/subscriptions","organizations_url":"https://api.github.com/users/nathanielc/orgs","repos_url":"https://api.github.com/users/nathanielc/repos","events_url":"https://api.github.com/users/nathanielc/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"wolffcm","id":7902964,"node_id":"MDQ6VXNlcjc5MDI5NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7902964?v=4","gravatar_id":"","url":"https://api.github.com/users/wolffcm","html_url":"https://github.com/wolffcm","followers_url":"https://api.github.com/users/wolffcm/followers","following_url":"https://api.github.com/users/wolffcm/following{/other_user}","gists_url":"https://api.github.com/users/wolffcm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolffcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolffcm/subscriptions","organizations_url":"https://api.github.com/users/wolffcm/orgs","repos_url":"https://api.github.com/users/wolffcm/repos","events_url":"https://api.github.com/users/wolffcm/events{/privacy}","received_events_url":"https://api.github.com/users/wolffcm/received_events","type":"User","site_admin":false},"assignees":[{"login":"wolffcm","id":7902964,"node_id":"MDQ6VXNlcjc5MDI5NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7902964?v=4","gravatar_id":"","url":"https://api.github.com/users/wolffcm","html_url":"https://github.com/wolffcm","followers_url":"https://api.github.com/users/wolffcm/followers","following_url":"https://api.github.com/users/wolffcm/following{/other_user}","gists_url":"https://api.github.com/users/wolffcm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolffcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolffcm/subscriptions","organizations_url":"https://api.github.com/users/wolffcm/orgs","repos_url":"https://api.github.com/users/wolffcm/repos","events_url":"https://api.github.com/users/wolffcm/events{/privacy}","received_events_url":"https://api.github.com/users/wolffcm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2019-03-25T19:25:04Z","updated_at":"2019-03-26T14:57:37Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The compiler interface should not expose the Spec.\r\n\r\nThe interface should look like:\r\n\r\n```\r\ntype Compiler interface {\r\n    Compile(context.Context, Request) (Program,error)\r\n}\r\n```\r\n\r\nWhere Program is:\r\n\r\n```\r\ntype Program interface {\r\n    // Starts execution of the program and returns immediately\r\n    // As results are produced they arrive on the channel, the program is finished once the result channel is closed and all results have been consumed.\r\n    Start(context) (<-chan flux.Result, error)\r\n}\r\n```\r\n\r\nPreviously the results returned from execution where a `map[string]flux.Result` but that is no longer a valid return value since an undetermined number of Results may be produced. A result knows it own name so the map is not needed. \r\n\r\nAlso of note is that multiple results can be read off the channel before the results themselves are fully consumed. So while the retrieval of the results is serial the results can still be consumed concurrently. \r\n\r\nThis is part of #1085"},"comment":{"url":"https://api.github.com/repos/influxdata/flux/issues/comments/476686958","html_url":"https://github.com/influxdata/flux/issues/1086#issuecomment-476686958","issue_url":"https://api.github.com/repos/influxdata/flux/issues/1086","id":476686958,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3NjY4Njk1OA==","user":{"login":"wolffcm","id":7902964,"node_id":"MDQ6VXNlcjc5MDI5NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7902964?v=4","gravatar_id":"","url":"https://api.github.com/users/wolffcm","html_url":"https://github.com/wolffcm","followers_url":"https://api.github.com/users/wolffcm/followers","following_url":"https://api.github.com/users/wolffcm/following{/other_user}","gists_url":"https://api.github.com/users/wolffcm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolffcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolffcm/subscriptions","organizations_url":"https://api.github.com/users/wolffcm/orgs","repos_url":"https://api.github.com/users/wolffcm/repos","events_url":"https://api.github.com/users/wolffcm/events{/privacy}","received_events_url":"https://api.github.com/users/wolffcm/received_events","type":"User","site_admin":false},"created_at":"2019-03-26T14:57:37Z","updated_at":"2019-03-26T14:57:37Z","author_association":"CONTRIBUTOR","body":"I'm just putting my questions in a comment as the come up.  How should dependencies be handled?\r\n\r\nMaybe, `Program.Start()` method should accept an instance of `Executor` as an argument."}}
{"actor":{"display_login":"wolffcm"}}