{"action":"opened","number":147,"pull_request":{"url":"https://api.github.com/repos/closeio/tasktiger/pulls/147","id":323755446,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzNzU1NDQ2","html_url":"https://github.com/closeio/tasktiger/pull/147","diff_url":"https://github.com/closeio/tasktiger/pull/147.diff","patch_url":"https://github.com/closeio/tasktiger/pull/147.patch","issue_url":"https://api.github.com/repos/closeio/tasktiger/issues/147","number":147,"state":"open","locked":false,"title":"WIP Fix Default Periodic Task Unique ID","user":{"login":"AlecRosenbaum","id":1953412,"node_id":"MDQ6VXNlcjE5NTM0MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1953412?v=4","gravatar_id":"","url":"https://api.github.com/users/AlecRosenbaum","html_url":"https://github.com/AlecRosenbaum","followers_url":"https://api.github.com/users/AlecRosenbaum/followers","following_url":"https://api.github.com/users/AlecRosenbaum/following{/other_user}","gists_url":"https://api.github.com/users/AlecRosenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/AlecRosenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlecRosenbaum/subscriptions","organizations_url":"https://api.github.com/users/AlecRosenbaum/orgs","repos_url":"https://api.github.com/users/AlecRosenbaum/repos","events_url":"https://api.github.com/users/AlecRosenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/AlecRosenbaum/received_events","type":"User","site_admin":false},"body":"__WIP__ There's a lot of noise in this right now because it builds off of https://github.com/closeio/tasktiger/pull/145. I'll rebase once that PR merges.\r\n\r\nRelated Issue: https://github.com/closeio/tasktiger/issues/146\r\n\r\nPer the issue, manually scheduled and automatically queued period tasks _should_ have the same unique id, but currently don't.\r\n```python\r\nperiodic_task.delay()  # id == hash(function_name, [], {})\r\nWorker().run()  # periodic_task.id == hash(function_name, None, None)\r\n```\r\n\r\nIf this happens then there can end up being multiple versions of an argument-less periodic task floating around in the queue. This change _shouldn't_ have a significant impact on deployment since task ids should self-correct after being run. __TODO__ add a test confirming this behavior.","created_at":"2019-10-02T13:35:48Z","updated_at":"2019-10-02T13:35:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/closeio/tasktiger/pulls/147/commits","review_comments_url":"https://api.github.com/repos/closeio/tasktiger/pulls/147/comments","review_comment_url":"https://api.github.com/repos/closeio/tasktiger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/closeio/tasktiger/issues/147/comments","statuses_url":"https://api.github.com/repos/closeio/tasktiger/statuses/09f9a2d788ab28aa608e67526772d940d180c27c","head":{"label":"closeio:tasktiger_146_default_periodic_unique_id","ref":"tasktiger_146_default_periodic_unique_id","sha":"09f9a2d788ab28aa608e67526772d940d180c27c","user":{"login":"closeio","id":437267,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzI2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/437267?v=4","gravatar_id":"","url":"https://api.github.com/users/closeio","html_url":"https://github.com/closeio","followers_url":"https://api.github.com/users/closeio/followers","following_url":"https://api.github.com/users/closeio/following{/other_user}","gists_url":"https://api.github.com/users/closeio/gists{/gist_id}","starred_url":"https://api.github.com/users/closeio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/closeio/subscriptions","organizations_url":"https://api.github.com/users/closeio/orgs","repos_url":"https://api.github.com/users/closeio/repos","events_url":"https://api.github.com/users/closeio/events{/privacy}","received_events_url":"https://api.github.com/users/closeio/received_events","type":"Organization","site_admin":false},"repo":{"id":35581334,"node_id":"MDEwOlJlcG9zaXRvcnkzNTU4MTMzNA==","name":"tasktiger","full_name":"closeio/tasktiger","private":false,"owner":{"login":"closeio","id":437267,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzI2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/437267?v=4","gravatar_id":"","url":"https://api.github.com/users/closeio","html_url":"https://github.com/closeio","followers_url":"https://api.github.com/users/closeio/followers","following_url":"https://api.github.com/users/closeio/following{/other_user}","gists_url":"https://api.github.com/users/closeio/gists{/gist_id}","starred_url":"https://api.github.com/users/closeio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/closeio/subscriptions","organizations_url":"https://api.github.com/users/closeio/orgs","repos_url":"https://api.github.com/users/closeio/repos","events_url":"https://api.github.com/users/closeio/events{/privacy}","received_events_url":"https://api.github.com/users/closeio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/closeio/tasktiger","description":"Python task queue. Because celery is gross.","fork":false,"url":"https://api.github.com/repos/closeio/tasktiger","forks_url":"https://api.github.com/repos/closeio/tasktiger/forks","keys_url":"https://api.github.com/repos/closeio/tasktiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/closeio/tasktiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/closeio/tasktiger/teams","hooks_url":"https://api.github.com/repos/closeio/tasktiger/hooks","issue_events_url":"https://api.github.com/repos/closeio/tasktiger/issues/events{/number}","events_url":"https://api.github.com/repos/closeio/tasktiger/events","assignees_url":"https://api.github.com/repos/closeio/tasktiger/assignees{/user}","branches_url":"https://api.github.com/repos/closeio/tasktiger/branches{/branch}","tags_url":"https://api.github.com/repos/closeio/tasktiger/tags","blobs_url":"https://api.github.com/repos/closeio/tasktiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/closeio/tasktiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/closeio/tasktiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/closeio/tasktiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/closeio/tasktiger/statuses/{sha}","languages_url":"https://api.github.com/repos/closeio/tasktiger/languages","stargazers_url":"https://api.github.com/repos/closeio/tasktiger/stargazers","contributors_url":"https://api.github.com/repos/closeio/tasktiger/contributors","subscribers_url":"https://api.github.com/repos/closeio/tasktiger/subscribers","subscription_url":"https://api.github.com/repos/closeio/tasktiger/subscription","commits_url":"https://api.github.com/repos/closeio/tasktiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/closeio/tasktiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/closeio/tasktiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/closeio/tasktiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/closeio/tasktiger/contents/{+path}","compare_url":"https://api.github.com/repos/closeio/tasktiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/closeio/tasktiger/merges","archive_url":"https://api.github.com/repos/closeio/tasktiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/closeio/tasktiger/downloads","issues_url":"https://api.github.com/repos/closeio/tasktiger/issues{/number}","pulls_url":"https://api.github.com/repos/closeio/tasktiger/pulls{/number}","milestones_url":"https://api.github.com/repos/closeio/tasktiger/milestones{/number}","notifications_url":"https://api.github.com/repos/closeio/tasktiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/closeio/tasktiger/labels{/name}","releases_url":"https://api.github.com/repos/closeio/tasktiger/releases{/id}","deployments_url":"https://api.github.com/repos/closeio/tasktiger/deployments","created_at":"2015-05-14T00:26:32Z","updated_at":"2019-09-27T15:57:53Z","pushed_at":"2019-10-02T13:29:06Z","git_url":"git://github.com/closeio/tasktiger.git","ssh_url":"git@github.com:closeio/tasktiger.git","clone_url":"https://github.com/closeio/tasktiger.git","svn_url":"https://github.com/closeio/tasktiger","homepage":"","size":615,"stargazers_count":923,"watchers_count":923,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":55,"open_issues":36,"watchers":923,"default_branch":"master"}},"base":{"label":"closeio:master","ref":"master","sha":"ad744574c053ed7cba3f10cabea3770c6c2e57f6","user":{"login":"closeio","id":437267,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzI2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/437267?v=4","gravatar_id":"","url":"https://api.github.com/users/closeio","html_url":"https://github.com/closeio","followers_url":"https://api.github.com/users/closeio/followers","following_url":"https://api.github.com/users/closeio/following{/other_user}","gists_url":"https://api.github.com/users/closeio/gists{/gist_id}","starred_url":"https://api.github.com/users/closeio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/closeio/subscriptions","organizations_url":"https://api.github.com/users/closeio/orgs","repos_url":"https://api.github.com/users/closeio/repos","events_url":"https://api.github.com/users/closeio/events{/privacy}","received_events_url":"https://api.github.com/users/closeio/received_events","type":"Organization","site_admin":false},"repo":{"id":35581334,"node_id":"MDEwOlJlcG9zaXRvcnkzNTU4MTMzNA==","name":"tasktiger","full_name":"closeio/tasktiger","private":false,"owner":{"login":"closeio","id":437267,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzI2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/437267?v=4","gravatar_id":"","url":"https://api.github.com/users/closeio","html_url":"https://github.com/closeio","followers_url":"https://api.github.com/users/closeio/followers","following_url":"https://api.github.com/users/closeio/following{/other_user}","gists_url":"https://api.github.com/users/closeio/gists{/gist_id}","starred_url":"https://api.github.com/users/closeio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/closeio/subscriptions","organizations_url":"https://api.github.com/users/closeio/orgs","repos_url":"https://api.github.com/users/closeio/repos","events_url":"https://api.github.com/users/closeio/events{/privacy}","received_events_url":"https://api.github.com/users/closeio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/closeio/tasktiger","description":"Python task queue. Because celery is gross.","fork":false,"url":"https://api.github.com/repos/closeio/tasktiger","forks_url":"https://api.github.com/repos/closeio/tasktiger/forks","keys_url":"https://api.github.com/repos/closeio/tasktiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/closeio/tasktiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/closeio/tasktiger/teams","hooks_url":"https://api.github.com/repos/closeio/tasktiger/hooks","issue_events_url":"https://api.github.com/repos/closeio/tasktiger/issues/events{/number}","events_url":"https://api.github.com/repos/closeio/tasktiger/events","assignees_url":"https://api.github.com/repos/closeio/tasktiger/assignees{/user}","branches_url":"https://api.github.com/repos/closeio/tasktiger/branches{/branch}","tags_url":"https://api.github.com/repos/closeio/tasktiger/tags","blobs_url":"https://api.github.com/repos/closeio/tasktiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/closeio/tasktiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/closeio/tasktiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/closeio/tasktiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/closeio/tasktiger/statuses/{sha}","languages_url":"https://api.github.com/repos/closeio/tasktiger/languages","stargazers_url":"https://api.github.com/repos/closeio/tasktiger/stargazers","contributors_url":"https://api.github.com/repos/closeio/tasktiger/contributors","subscribers_url":"https://api.github.com/repos/closeio/tasktiger/subscribers","subscription_url":"https://api.github.com/repos/closeio/tasktiger/subscription","commits_url":"https://api.github.com/repos/closeio/tasktiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/closeio/tasktiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/closeio/tasktiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/closeio/tasktiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/closeio/tasktiger/contents/{+path}","compare_url":"https://api.github.com/repos/closeio/tasktiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/closeio/tasktiger/merges","archive_url":"https://api.github.com/repos/closeio/tasktiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/closeio/tasktiger/downloads","issues_url":"https://api.github.com/repos/closeio/tasktiger/issues{/number}","pulls_url":"https://api.github.com/repos/closeio/tasktiger/pulls{/number}","milestones_url":"https://api.github.com/repos/closeio/tasktiger/milestones{/number}","notifications_url":"https://api.github.com/repos/closeio/tasktiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/closeio/tasktiger/labels{/name}","releases_url":"https://api.github.com/repos/closeio/tasktiger/releases{/id}","deployments_url":"https://api.github.com/repos/closeio/tasktiger/deployments","created_at":"2015-05-14T00:26:32Z","updated_at":"2019-09-27T15:57:53Z","pushed_at":"2019-10-02T13:29:06Z","git_url":"git://github.com/closeio/tasktiger.git","ssh_url":"git@github.com:closeio/tasktiger.git","clone_url":"https://github.com/closeio/tasktiger.git","svn_url":"https://github.com/closeio/tasktiger","homepage":"","size":615,"stargazers_count":923,"watchers_count":923,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":55,"open_issues":36,"watchers":923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/closeio/tasktiger/pulls/147"},"html":{"href":"https://github.com/closeio/tasktiger/pull/147"},"issue":{"href":"https://api.github.com/repos/closeio/tasktiger/issues/147"},"comments":{"href":"https://api.github.com/repos/closeio/tasktiger/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/closeio/tasktiger/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/closeio/tasktiger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/closeio/tasktiger/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/closeio/tasktiger/statuses/09f9a2d788ab28aa608e67526772d940d180c27c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":1109,"deletions":586,"changed_files":27}}
{"actor":{"display_login":"AlecRosenbaum"}}