{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-admin-frontend/issues/541","repository_url":"https://api.github.com/repos/alphagov/digitalmarketplace-admin-frontend","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-admin-frontend/issues/541/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-admin-frontend/issues/541/comments","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-admin-frontend/issues/541/events","html_url":"https://github.com/alphagov/digitalmarketplace-admin-frontend/pull/541","id":482799997,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5MDAwNTc0","number":541,"title":"view_supplier_declaration: enable view for \"expired\" frameworks ","user":{"login":"risicle","id":807447,"node_id":"MDQ6VXNlcjgwNzQ0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-08-20T11:20:39Z","updated_at":"2019-08-22T09:23:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-admin-frontend/pulls/541","html_url":"https://github.com/alphagov/digitalmarketplace-admin-frontend/pull/541","diff_url":"https://github.com/alphagov/digitalmarketplace-admin-frontend/pull/541.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-admin-frontend/pull/541.patch"},"body":"This started out as https://trello.com/c/R9x4f7te but as you can see from that ticket this morphed a bit.\r\n\r\nWhat we're now doing is enabling the \"view declaration\" view for `expired` frameworks. This was previously prevented (which is what was causing the 403 mentioned in the ticket).\r\n\r\nThis also makes sure `supplierFramework`s which don't have a declaration don't even show in the table on the `supplier_details` page, as there's nothing useful that can be done with such `supplierFramework`s from here."},"comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-admin-frontend/issues/comments/523824910","html_url":"https://github.com/alphagov/digitalmarketplace-admin-frontend/pull/541#issuecomment-523824910","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-admin-frontend/issues/541","id":523824910,"node_id":"MDEyOklzc3VlQ29tbWVudDUyMzgyNDkxMA==","user":{"login":"risicle","id":807447,"node_id":"MDQ6VXNlcjgwNzQ0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},"created_at":"2019-08-22T09:23:03Z","updated_at":"2019-08-22T09:23:03Z","author_association":"CONTRIBUTOR","body":"That is a good question."}}
{"actor":{"display_login":"risicle"}}