{"action":"created","comment":{"url":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments/321029481","pull_request_review_id":283963093,"id":321029481,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMTAyOTQ4MQ==","diff_hunk":"@@ -48,34 +48,20 @@ describe('NavItem', () => {\n       expect(actual).toMatchSnapshot();\n     });\n \n-    it('should render children when selected', () => {","path":"src/components/Sidebar/components/NavItem/NavItem.spec.js","position":4,"original_position":4,"commit_id":"b51f71be1390fe4e0e103d5f2ede4538d713f7f6","original_commit_id":"b51f71be1390fe4e0e103d5f2ede4538d713f7f6","user":{"login":"connor-baer","id":11017722,"node_id":"MDQ6VXNlcjExMDE3NzIy","avatar_url":"https://avatars0.githubusercontent.com/u/11017722?v=4","gravatar_id":"","url":"https://api.github.com/users/connor-baer","html_url":"https://github.com/connor-baer","followers_url":"https://api.github.com/users/connor-baer/followers","following_url":"https://api.github.com/users/connor-baer/following{/other_user}","gists_url":"https://api.github.com/users/connor-baer/gists{/gist_id}","starred_url":"https://api.github.com/users/connor-baer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connor-baer/subscriptions","organizations_url":"https://api.github.com/users/connor-baer/orgs","repos_url":"https://api.github.com/users/connor-baer/repos","events_url":"https://api.github.com/users/connor-baer/events{/privacy}","received_events_url":"https://api.github.com/users/connor-baer/received_events","type":"User","site_admin":false},"body":"Why did you remove these tests? ","created_at":"2019-09-05T00:18:10Z","updated_at":"2019-09-05T00:27:43Z","html_url":"https://github.com/sumup/circuit-ui/pull/464#discussion_r321029481","pull_request_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/464","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments/321029481"},"html":{"href":"https://github.com/sumup/circuit-ui/pull/464#discussion_r321029481"},"pull_request":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/464"}}},"pull_request":{"url":"https://api.github.com/repos/sumup/circuit-ui/pulls/464","id":313636236,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEzNjM2MjM2","html_url":"https://github.com/sumup/circuit-ui/pull/464","diff_url":"https://github.com/sumup/circuit-ui/pull/464.diff","patch_url":"https://github.com/sumup/circuit-ui/pull/464.patch","issue_url":"https://api.github.com/repos/sumup/circuit-ui/issues/464","number":464,"state":"open","locked":false,"title":"feature(components): add Sidebar disabled state","user":{"login":"robinmetral","id":35560568,"node_id":"MDQ6VXNlcjM1NTYwNTY4","avatar_url":"https://avatars3.githubusercontent.com/u/35560568?v=4","gravatar_id":"","url":"https://api.github.com/users/robinmetral","html_url":"https://github.com/robinmetral","followers_url":"https://api.github.com/users/robinmetral/followers","following_url":"https://api.github.com/users/robinmetral/following{/other_user}","gists_url":"https://api.github.com/users/robinmetral/gists{/gist_id}","starred_url":"https://api.github.com/users/robinmetral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinmetral/subscriptions","organizations_url":"https://api.github.com/users/robinmetral/orgs","repos_url":"https://api.github.com/users/robinmetral/repos","events_url":"https://api.github.com/users/robinmetral/events{/privacy}","received_events_url":"https://api.github.com/users/robinmetral/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n\r\nAdd a disabled state to Sidebar NavItems.\r\n\r\n## Approach and changes\r\n\r\n- [x] Add support for a `disabled` prop for both `NavItem` and `Aggregator`\r\n   - [x] Block interactions (click, Aggregator toggle)\r\n- [x] Change styles when disabled according to design (see Circuit UI Figma)\r\n   - [x] Change color\r\n   - [x] Replace icon (if any) by Lock\r\n      - [x] Add util to determine which icon should be rendered for each NavItem\r\n\r\n## Preview\r\n\r\n![sidebar-disabled](https://user-images.githubusercontent.com/35560568/64255234-3b767480-cf21-11e9-931d-13951afeb01e.gif)\r\n\r\n## Definition of done\r\n\r\n* [x] Development completed\r\n* [x] Reviewers assigned\r\n* [x] Unit and integration tests\r\n* [x] Meets minimum browser support\r\n* [x] Meets accessibility requirements\r\n","created_at":"2019-09-03T15:02:43Z","updated_at":"2019-09-05T00:27:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a84a8a4d88e9fbaa10cdf1009575e1ccf51ff21","assignee":null,"assignees":[],"requested_reviewers":[{"login":"afonsodelgado","id":15806312,"node_id":"MDQ6VXNlcjE1ODA2MzEy","avatar_url":"https://avatars2.githubusercontent.com/u/15806312?v=4","gravatar_id":"","url":"https://api.github.com/users/afonsodelgado","html_url":"https://github.com/afonsodelgado","followers_url":"https://api.github.com/users/afonsodelgado/followers","following_url":"https://api.github.com/users/afonsodelgado/following{/other_user}","gists_url":"https://api.github.com/users/afonsodelgado/gists{/gist_id}","starred_url":"https://api.github.com/users/afonsodelgado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afonsodelgado/subscriptions","organizations_url":"https://api.github.com/users/afonsodelgado/orgs","repos_url":"https://api.github.com/users/afonsodelgado/repos","events_url":"https://api.github.com/users/afonsodelgado/events{/privacy}","received_events_url":"https://api.github.com/users/afonsodelgado/received_events","type":"User","site_admin":false},{"login":"joaovtg","id":40067278,"node_id":"MDQ6VXNlcjQwMDY3Mjc4","avatar_url":"https://avatars0.githubusercontent.com/u/40067278?v=4","gravatar_id":"","url":"https://api.github.com/users/joaovtg","html_url":"https://github.com/joaovtg","followers_url":"https://api.github.com/users/joaovtg/followers","following_url":"https://api.github.com/users/joaovtg/following{/other_user}","gists_url":"https://api.github.com/users/joaovtg/gists{/gist_id}","starred_url":"https://api.github.com/users/joaovtg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaovtg/subscriptions","organizations_url":"https://api.github.com/users/joaovtg/orgs","repos_url":"https://api.github.com/users/joaovtg/repos","events_url":"https://api.github.com/users/joaovtg/events{/privacy}","received_events_url":"https://api.github.com/users/joaovtg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1178185833,"node_id":"MDU6TGFiZWwxMTc4MTg1ODMz","url":"https://api.github.com/repos/sumup/circuit-ui/labels/design","name":"design","color":"63ddb9","default":false},{"id":809259911,"node_id":"MDU6TGFiZWw4MDkyNTk5MTE=","url":"https://api.github.com/repos/sumup/circuit-ui/labels/in%20progress","name":"in progress","color":"FFC859","default":false},{"id":922895694,"node_id":"MDU6TGFiZWw5MjI4OTU2OTQ=","url":"https://api.github.com/repos/sumup/circuit-ui/labels/ready%20for%20review","name":"ready for review","color":"FF7559","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/464/commits","review_comments_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/464/comments","review_comment_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/issues/464/comments","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/b51f71be1390fe4e0e103d5f2ede4538d713f7f6","head":{"label":"sumup:feature/sidebar-disabled-state","ref":"feature/sidebar-disabled-state","sha":"b51f71be1390fe4e0e103d5f2ede4538d713f7f6","user":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"repo":{"id":95433249,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQzMzI0OQ==","name":"circuit-ui","full_name":"sumup/circuit-ui","private":false,"owner":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sumup/circuit-ui","description":"Design system & component library for SumUp web apps","fork":false,"url":"https://api.github.com/repos/sumup/circuit-ui","forks_url":"https://api.github.com/repos/sumup/circuit-ui/forks","keys_url":"https://api.github.com/repos/sumup/circuit-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumup/circuit-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumup/circuit-ui/teams","hooks_url":"https://api.github.com/repos/sumup/circuit-ui/hooks","issue_events_url":"https://api.github.com/repos/sumup/circuit-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sumup/circuit-ui/events","assignees_url":"https://api.github.com/repos/sumup/circuit-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sumup/circuit-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sumup/circuit-ui/tags","blobs_url":"https://api.github.com/repos/sumup/circuit-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumup/circuit-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumup/circuit-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumup/circuit-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sumup/circuit-ui/languages","stargazers_url":"https://api.github.com/repos/sumup/circuit-ui/stargazers","contributors_url":"https://api.github.com/repos/sumup/circuit-ui/contributors","subscribers_url":"https://api.github.com/repos/sumup/circuit-ui/subscribers","subscription_url":"https://api.github.com/repos/sumup/circuit-ui/subscription","commits_url":"https://api.github.com/repos/sumup/circuit-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumup/circuit-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumup/circuit-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumup/circuit-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sumup/circuit-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumup/circuit-ui/merges","archive_url":"https://api.github.com/repos/sumup/circuit-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumup/circuit-ui/downloads","issues_url":"https://api.github.com/repos/sumup/circuit-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sumup/circuit-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sumup/circuit-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sumup/circuit-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumup/circuit-ui/labels{/name}","releases_url":"https://api.github.com/repos/sumup/circuit-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sumup/circuit-ui/deployments","created_at":"2017-06-26T09:57:50Z","updated_at":"2019-09-04T23:19:56Z","pushed_at":"2019-09-04T23:26:13Z","git_url":"git://github.com/sumup/circuit-ui.git","ssh_url":"git@github.com:sumup/circuit-ui.git","clone_url":"https://github.com/sumup/circuit-ui.git","svn_url":"https://github.com/sumup/circuit-ui","homepage":"https://circuit.sumup.com","size":9463,"stargazers_count":384,"watchers_count":384,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":53,"open_issues":18,"watchers":384,"default_branch":"canary"}},"base":{"label":"sumup:canary","ref":"canary","sha":"be4a49e62d412a1ebbdd96370e52dc04e74df020","user":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"repo":{"id":95433249,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQzMzI0OQ==","name":"circuit-ui","full_name":"sumup/circuit-ui","private":false,"owner":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sumup/circuit-ui","description":"Design system & component library for SumUp web apps","fork":false,"url":"https://api.github.com/repos/sumup/circuit-ui","forks_url":"https://api.github.com/repos/sumup/circuit-ui/forks","keys_url":"https://api.github.com/repos/sumup/circuit-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumup/circuit-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumup/circuit-ui/teams","hooks_url":"https://api.github.com/repos/sumup/circuit-ui/hooks","issue_events_url":"https://api.github.com/repos/sumup/circuit-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sumup/circuit-ui/events","assignees_url":"https://api.github.com/repos/sumup/circuit-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sumup/circuit-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sumup/circuit-ui/tags","blobs_url":"https://api.github.com/repos/sumup/circuit-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumup/circuit-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumup/circuit-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumup/circuit-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sumup/circuit-ui/languages","stargazers_url":"https://api.github.com/repos/sumup/circuit-ui/stargazers","contributors_url":"https://api.github.com/repos/sumup/circuit-ui/contributors","subscribers_url":"https://api.github.com/repos/sumup/circuit-ui/subscribers","subscription_url":"https://api.github.com/repos/sumup/circuit-ui/subscription","commits_url":"https://api.github.com/repos/sumup/circuit-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumup/circuit-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumup/circuit-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumup/circuit-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sumup/circuit-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumup/circuit-ui/merges","archive_url":"https://api.github.com/repos/sumup/circuit-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumup/circuit-ui/downloads","issues_url":"https://api.github.com/repos/sumup/circuit-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sumup/circuit-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sumup/circuit-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sumup/circuit-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumup/circuit-ui/labels{/name}","releases_url":"https://api.github.com/repos/sumup/circuit-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sumup/circuit-ui/deployments","created_at":"2017-06-26T09:57:50Z","updated_at":"2019-09-04T23:19:56Z","pushed_at":"2019-09-04T23:26:13Z","git_url":"git://github.com/sumup/circuit-ui.git","ssh_url":"git@github.com:sumup/circuit-ui.git","clone_url":"https://github.com/sumup/circuit-ui.git","svn_url":"https://github.com/sumup/circuit-ui","homepage":"https://circuit.sumup.com","size":9463,"stargazers_count":384,"watchers_count":384,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":53,"open_issues":18,"watchers":384,"default_branch":"canary"}},"_links":{"self":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/464"},"html":{"href":"https://github.com/sumup/circuit-ui/pull/464"},"issue":{"href":"https://api.github.com/repos/sumup/circuit-ui/issues/464"},"comments":{"href":"https://api.github.com/repos/sumup/circuit-ui/issues/464/comments"},"review_comments":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/464/comments"},"review_comment":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/464/commits"},"statuses":{"href":"https://api.github.com/repos/sumup/circuit-ui/statuses/b51f71be1390fe4e0e103d5f2ede4538d713f7f6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"connor-baer"}}