{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments/332772679","pull_request_review_id":299099700,"id":332772679,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMjc3MjY3OQ==","diff_hunk":"@@ -177,7 +176,7 @@ export class AddControllerDialog {\n \t\t\t\t\t],\n \t\t\t\t\ttitle: ''\n \t\t\t\t}]).withLayout({ width: '100%' }).component();\n-\n+\t\t\tthis.onAuthChanged();","path":"extensions/big-data-cluster/src/bigDataCluster/dialog/addControllerDialog.ts","position":13,"original_position":13,"commit_id":"426f5555f0c0e3e9dacb731a2f393d72a8a4114d","original_commit_id":"426f5555f0c0e3e9dacb731a2f393d72a8a4114d","user":{"login":"kevcunnane","id":10819925,"node_id":"MDQ6VXNlcjEwODE5OTI1","avatar_url":"https://avatars3.githubusercontent.com/u/10819925?v=4","gravatar_id":"","url":"https://api.github.com/users/kevcunnane","html_url":"https://github.com/kevcunnane","followers_url":"https://api.github.com/users/kevcunnane/followers","following_url":"https://api.github.com/users/kevcunnane/following{/other_user}","gists_url":"https://api.github.com/users/kevcunnane/gists{/gist_id}","starred_url":"https://api.github.com/users/kevcunnane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevcunnane/subscriptions","organizations_url":"https://api.github.com/users/kevcunnane/orgs","repos_url":"https://api.github.com/users/kevcunnane/repos","events_url":"https://api.github.com/users/kevcunnane/events{/privacy}","received_events_url":"https://api.github.com/users/kevcunnane/received_events","type":"User","site_admin":false},"body":"Fixes an issue where if Windows auth is default, the username/password weren't being disabled","created_at":"2019-10-08T23:14:11Z","updated_at":"2019-10-08T23:14:12Z","html_url":"https://github.com/microsoft/azuredatastudio/pull/7580#discussion_r332772679","pull_request_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/7580","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments/332772679"},"html":{"href":"https://github.com/microsoft/azuredatastudio/pull/7580#discussion_r332772679"},"pull_request":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/7580"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/7580","id":326001186,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2MDAxMTg2","html_url":"https://github.com/microsoft/azuredatastudio/pull/7580","diff_url":"https://github.com/microsoft/azuredatastudio/pull/7580.diff","patch_url":"https://github.com/microsoft/azuredatastudio/pull/7580.patch","issue_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/7580","number":7580,"state":"open","locked":false,"title":"Mount HDFS Dialog: basic support","user":{"login":"kevcunnane","id":10819925,"node_id":"MDQ6VXNlcjEwODE5OTI1","avatar_url":"https://avatars3.githubusercontent.com/u/10819925?v=4","gravatar_id":"","url":"https://api.github.com/users/kevcunnane","html_url":"https://github.com/kevcunnane","followers_url":"https://api.github.com/users/kevcunnane/followers","following_url":"https://api.github.com/users/kevcunnane/following{/other_user}","gists_url":"https://api.github.com/users/kevcunnane/gists{/gist_id}","starred_url":"https://api.github.com/users/kevcunnane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevcunnane/subscriptions","organizations_url":"https://api.github.com/users/kevcunnane/orgs","repos_url":"https://api.github.com/users/kevcunnane/repos","events_url":"https://api.github.com/users/kevcunnane/events{/privacy}","received_events_url":"https://api.github.com/users/kevcunnane/received_events","type":"User","site_admin":false},"body":"**Implemented in this PR**\r\n- New base dialog for anything needing to work with the controller. This is important since going from SQL -> Controller we \"should\" have the right permissions but aren't guaranteed\r\n- Support for Mount HDFS via a dialog. \r\n\r\n**Not implemented in this PR**\r\n- Script as Notebook button. This should convert the inputs to a set of cells in a notebook so users can run things themselves\r\n- Polling status of the mount being created. Need to sync with PM to understand what expected behavior is since right now it's unintuitive (seems like error conditions aren't captured?)\r\n- Updates based on PM / UX reviews. I think we'll need a round of feedback before completing this work.\r\n\r\n**Screenshots**\r\n![image](https://user-images.githubusercontent.com/10819925/66439983-58054100-e9e6-11e9-89ca-b46d12e61d75.png)\r\n\r\n![image](https://user-images.githubusercontent.com/10819925/66440029-78cd9680-e9e6-11e9-8a89-b37620f2da09.png)\r\n\r\n![image](https://user-images.githubusercontent.com/10819925/66440053-84b95880-e9e6-11e9-8b30-cb62a2dc03ef.png)\r\n","created_at":"2019-10-08T23:13:28Z","updated_at":"2019-10-08T23:14:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"631b870ab51ef48533d535f9daf3412657cb3637","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alanrenmsft","id":13777222,"node_id":"MDQ6VXNlcjEzNzc3MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13777222?v=4","gravatar_id":"","url":"https://api.github.com/users/alanrenmsft","html_url":"https://github.com/alanrenmsft","followers_url":"https://api.github.com/users/alanrenmsft/followers","following_url":"https://api.github.com/users/alanrenmsft/following{/other_user}","gists_url":"https://api.github.com/users/alanrenmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/alanrenmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanrenmsft/subscriptions","organizations_url":"https://api.github.com/users/alanrenmsft/orgs","repos_url":"https://api.github.com/users/alanrenmsft/repos","events_url":"https://api.github.com/users/alanrenmsft/events{/privacy}","received_events_url":"https://api.github.com/users/alanrenmsft/received_events","type":"User","site_admin":false},{"login":"Charles-Gagnon","id":28519865,"node_id":"MDQ6VXNlcjI4NTE5ODY1","avatar_url":"https://avatars0.githubusercontent.com/u/28519865?v=4","gravatar_id":"","url":"https://api.github.com/users/Charles-Gagnon","html_url":"https://github.com/Charles-Gagnon","followers_url":"https://api.github.com/users/Charles-Gagnon/followers","following_url":"https://api.github.com/users/Charles-Gagnon/following{/other_user}","gists_url":"https://api.github.com/users/Charles-Gagnon/gists{/gist_id}","starred_url":"https://api.github.com/users/Charles-Gagnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charles-Gagnon/subscriptions","organizations_url":"https://api.github.com/users/Charles-Gagnon/orgs","repos_url":"https://api.github.com/users/Charles-Gagnon/repos","events_url":"https://api.github.com/users/Charles-Gagnon/events{/privacy}","received_events_url":"https://api.github.com/users/Charles-Gagnon/received_events","type":"User","site_admin":false},{"login":"chlafreniere","id":40371649,"node_id":"MDQ6VXNlcjQwMzcxNjQ5","avatar_url":"https://avatars2.githubusercontent.com/u/40371649?v=4","gravatar_id":"","url":"https://api.github.com/users/chlafreniere","html_url":"https://github.com/chlafreniere","followers_url":"https://api.github.com/users/chlafreniere/followers","following_url":"https://api.github.com/users/chlafreniere/following{/other_user}","gists_url":"https://api.github.com/users/chlafreniere/gists{/gist_id}","starred_url":"https://api.github.com/users/chlafreniere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chlafreniere/subscriptions","organizations_url":"https://api.github.com/users/chlafreniere/orgs","repos_url":"https://api.github.com/users/chlafreniere/repos","events_url":"https://api.github.com/users/chlafreniere/events{/privacy}","received_events_url":"https://api.github.com/users/chlafreniere/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/7580/commits","review_comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/7580/comments","review_comment_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/7580/comments","statuses_url":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/426f5555f0c0e3e9dacb731a2f393d72a8a4114d","head":{"label":"microsoft:add/mountactions","ref":"add/mountactions","sha":"426f5555f0c0e3e9dacb731a2f393d72a8a4114d","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":109200851,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyMDA4NTE=","name":"azuredatastudio","full_name":"microsoft/azuredatastudio","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azuredatastudio","description":"Azure Data Studio is a data management tool that enables working with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.","fork":false,"url":"https://api.github.com/repos/microsoft/azuredatastudio","forks_url":"https://api.github.com/repos/microsoft/azuredatastudio/forks","keys_url":"https://api.github.com/repos/microsoft/azuredatastudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azuredatastudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azuredatastudio/teams","hooks_url":"https://api.github.com/repos/microsoft/azuredatastudio/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azuredatastudio/events","assignees_url":"https://api.github.com/repos/microsoft/azuredatastudio/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azuredatastudio/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/tags","blobs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azuredatastudio/languages","stargazers_url":"https://api.github.com/repos/microsoft/azuredatastudio/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azuredatastudio/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscription","commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azuredatastudio/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azuredatastudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azuredatastudio/merges","archive_url":"https://api.github.com/repos/microsoft/azuredatastudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azuredatastudio/downloads","issues_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azuredatastudio/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azuredatastudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azuredatastudio/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azuredatastudio/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azuredatastudio/deployments","created_at":"2017-11-02T01:00:13Z","updated_at":"2019-10-08T23:02:58Z","pushed_at":"2019-10-08T23:13:29Z","git_url":"git://github.com/microsoft/azuredatastudio.git","ssh_url":"git@github.com:microsoft/azuredatastudio.git","clone_url":"https://github.com/microsoft/azuredatastudio.git","svn_url":"https://github.com/microsoft/azuredatastudio","homepage":"","size":61798,"stargazers_count":5339,"watchers_count":5339,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":422,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1645,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":422,"open_issues":1645,"watchers":5339,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"2fe82e4b2f5613e4c05ce90fd2ccc307f6583ec9","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":109200851,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyMDA4NTE=","name":"azuredatastudio","full_name":"microsoft/azuredatastudio","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/azuredatastudio","description":"Azure Data Studio is a data management tool that enables working with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.","fork":false,"url":"https://api.github.com/repos/microsoft/azuredatastudio","forks_url":"https://api.github.com/repos/microsoft/azuredatastudio/forks","keys_url":"https://api.github.com/repos/microsoft/azuredatastudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/azuredatastudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/azuredatastudio/teams","hooks_url":"https://api.github.com/repos/microsoft/azuredatastudio/hooks","issue_events_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/azuredatastudio/events","assignees_url":"https://api.github.com/repos/microsoft/azuredatastudio/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/azuredatastudio/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/tags","blobs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/azuredatastudio/languages","stargazers_url":"https://api.github.com/repos/microsoft/azuredatastudio/stargazers","contributors_url":"https://api.github.com/repos/microsoft/azuredatastudio/contributors","subscribers_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscribers","subscription_url":"https://api.github.com/repos/microsoft/azuredatastudio/subscription","commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/azuredatastudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/azuredatastudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/azuredatastudio/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/azuredatastudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/azuredatastudio/merges","archive_url":"https://api.github.com/repos/microsoft/azuredatastudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/azuredatastudio/downloads","issues_url":"https://api.github.com/repos/microsoft/azuredatastudio/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/azuredatastudio/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/azuredatastudio/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/azuredatastudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/azuredatastudio/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/azuredatastudio/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/azuredatastudio/deployments","created_at":"2017-11-02T01:00:13Z","updated_at":"2019-10-08T23:02:58Z","pushed_at":"2019-10-08T23:13:29Z","git_url":"git://github.com/microsoft/azuredatastudio.git","ssh_url":"git@github.com:microsoft/azuredatastudio.git","clone_url":"https://github.com/microsoft/azuredatastudio.git","svn_url":"https://github.com/microsoft/azuredatastudio","homepage":"","size":61798,"stargazers_count":5339,"watchers_count":5339,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":422,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1645,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":422,"open_issues":1645,"watchers":5339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/7580"},"html":{"href":"https://github.com/microsoft/azuredatastudio/pull/7580"},"issue":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/issues/7580"},"comments":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/issues/7580/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/7580/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/pulls/7580/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/azuredatastudio/statuses/426f5555f0c0e3e9dacb731a2f393d72a8a4114d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kevcunnane"}}