{"action":"created","comment":{"url":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments/269261012","pull_request_review_id":219089091,"id":269261012,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTI2MTAxMg==","diff_hunk":"@@ -37,9 +37,9 @@ @implementation ASTipsController\n \n #pragma mark - Singleton\n \n-+ (void)load","path":"Source/Private/ASTipsController.mm","position":4,"original_position":4,"commit_id":"ca18fbce720a6014c9316d292df3f900d4febf88","original_commit_id":"ca18fbce720a6014c9316d292df3f900d4febf88","user":{"login":"nguyenhuy","id":587874,"node_id":"MDQ6VXNlcjU4Nzg3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/587874?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyenhuy","html_url":"https://github.com/nguyenhuy","followers_url":"https://api.github.com/users/nguyenhuy/followers","following_url":"https://api.github.com/users/nguyenhuy/following{/other_user}","gists_url":"https://api.github.com/users/nguyenhuy/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenhuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenhuy/subscriptions","organizations_url":"https://api.github.com/users/nguyenhuy/orgs","repos_url":"https://api.github.com/users/nguyenhuy/repos","events_url":"https://api.github.com/users/nguyenhuy/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenhuy/received_events","type":"User","site_admin":false},"body":"While we're on this, can we wrap this initializer in the `AS_ENABLE_TIPS` compiler flag and get back a tiny bit of pre-main time?","created_at":"2019-03-26T18:42:56Z","updated_at":"2019-03-26T18:43:58Z","html_url":"https://github.com/TextureGroup/Texture/pull/1425#discussion_r269261012","pull_request_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/1425","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments/269261012"},"html":{"href":"https://github.com/TextureGroup/Texture/pull/1425#discussion_r269261012"},"pull_request":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/1425"}}},"pull_request":{"url":"https://api.github.com/repos/TextureGroup/Texture/pulls/1425","id":264408886,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0NDA4ODg2","html_url":"https://github.com/TextureGroup/Texture/pull/1425","diff_url":"https://github.com/TextureGroup/Texture/pull/1425.diff","patch_url":"https://github.com/TextureGroup/Texture/pull/1425.patch","issue_url":"https://api.github.com/repos/TextureGroup/Texture/issues/1425","number":1425,"state":"open","locked":false,"title":"Replace +load initializers with __attribute__((constructor)) functions","user":{"login":"farktronix","id":4943,"node_id":"MDQ6VXNlcjQ5NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4943?v=4","gravatar_id":"","url":"https://api.github.com/users/farktronix","html_url":"https://github.com/farktronix","followers_url":"https://api.github.com/users/farktronix/followers","following_url":"https://api.github.com/users/farktronix/following{/other_user}","gists_url":"https://api.github.com/users/farktronix/gists{/gist_id}","starred_url":"https://api.github.com/users/farktronix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farktronix/subscriptions","organizations_url":"https://api.github.com/users/farktronix/orgs","repos_url":"https://api.github.com/users/farktronix/repos","events_url":"https://api.github.com/users/farktronix/events{/privacy}","received_events_url":"https://api.github.com/users/farktronix/received_events","type":"User","site_admin":false},"body":"With the latest version of Xcode installed I was getting this dyld error at app launch time:\r\n\r\n```Swift class extensions and categories on Swift classes are not allowed to have +load methods```\r\n\r\nIt looks like it's possible to replace `+load` methods with a static `__attribute__((constructor))` function without making dyld angry.","created_at":"2019-03-26T07:57:34Z","updated_at":"2019-03-26T18:43:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03cc4d8cbafeaf789c6fb831ab3bbe18b61c2271","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/1425/commits","review_comments_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/1425/comments","review_comment_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/issues/1425/comments","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/ca18fbce720a6014c9316d292df3f900d4febf88","head":{"label":"farktronix:StaticLoad","ref":"StaticLoad","sha":"ca18fbce720a6014c9316d292df3f900d4febf88","user":{"login":"farktronix","id":4943,"node_id":"MDQ6VXNlcjQ5NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4943?v=4","gravatar_id":"","url":"https://api.github.com/users/farktronix","html_url":"https://github.com/farktronix","followers_url":"https://api.github.com/users/farktronix/followers","following_url":"https://api.github.com/users/farktronix/following{/other_user}","gists_url":"https://api.github.com/users/farktronix/gists{/gist_id}","starred_url":"https://api.github.com/users/farktronix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farktronix/subscriptions","organizations_url":"https://api.github.com/users/farktronix/orgs","repos_url":"https://api.github.com/users/farktronix/repos","events_url":"https://api.github.com/users/farktronix/events{/privacy}","received_events_url":"https://api.github.com/users/farktronix/received_events","type":"User","site_admin":false},"repo":{"id":155999413,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU5OTk0MTM=","name":"Texture","full_name":"farktronix/Texture","private":false,"owner":{"login":"farktronix","id":4943,"node_id":"MDQ6VXNlcjQ5NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4943?v=4","gravatar_id":"","url":"https://api.github.com/users/farktronix","html_url":"https://github.com/farktronix","followers_url":"https://api.github.com/users/farktronix/followers","following_url":"https://api.github.com/users/farktronix/following{/other_user}","gists_url":"https://api.github.com/users/farktronix/gists{/gist_id}","starred_url":"https://api.github.com/users/farktronix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farktronix/subscriptions","organizations_url":"https://api.github.com/users/farktronix/orgs","repos_url":"https://api.github.com/users/farktronix/repos","events_url":"https://api.github.com/users/farktronix/events{/privacy}","received_events_url":"https://api.github.com/users/farktronix/received_events","type":"User","site_admin":false},"html_url":"https://github.com/farktronix/Texture","description":"Smooth asynchronous user interfaces for iOS apps.","fork":true,"url":"https://api.github.com/repos/farktronix/Texture","forks_url":"https://api.github.com/repos/farktronix/Texture/forks","keys_url":"https://api.github.com/repos/farktronix/Texture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/farktronix/Texture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/farktronix/Texture/teams","hooks_url":"https://api.github.com/repos/farktronix/Texture/hooks","issue_events_url":"https://api.github.com/repos/farktronix/Texture/issues/events{/number}","events_url":"https://api.github.com/repos/farktronix/Texture/events","assignees_url":"https://api.github.com/repos/farktronix/Texture/assignees{/user}","branches_url":"https://api.github.com/repos/farktronix/Texture/branches{/branch}","tags_url":"https://api.github.com/repos/farktronix/Texture/tags","blobs_url":"https://api.github.com/repos/farktronix/Texture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/farktronix/Texture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/farktronix/Texture/git/refs{/sha}","trees_url":"https://api.github.com/repos/farktronix/Texture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/farktronix/Texture/statuses/{sha}","languages_url":"https://api.github.com/repos/farktronix/Texture/languages","stargazers_url":"https://api.github.com/repos/farktronix/Texture/stargazers","contributors_url":"https://api.github.com/repos/farktronix/Texture/contributors","subscribers_url":"https://api.github.com/repos/farktronix/Texture/subscribers","subscription_url":"https://api.github.com/repos/farktronix/Texture/subscription","commits_url":"https://api.github.com/repos/farktronix/Texture/commits{/sha}","git_commits_url":"https://api.github.com/repos/farktronix/Texture/git/commits{/sha}","comments_url":"https://api.github.com/repos/farktronix/Texture/comments{/number}","issue_comment_url":"https://api.github.com/repos/farktronix/Texture/issues/comments{/number}","contents_url":"https://api.github.com/repos/farktronix/Texture/contents/{+path}","compare_url":"https://api.github.com/repos/farktronix/Texture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/farktronix/Texture/merges","archive_url":"https://api.github.com/repos/farktronix/Texture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/farktronix/Texture/downloads","issues_url":"https://api.github.com/repos/farktronix/Texture/issues{/number}","pulls_url":"https://api.github.com/repos/farktronix/Texture/pulls{/number}","milestones_url":"https://api.github.com/repos/farktronix/Texture/milestones{/number}","notifications_url":"https://api.github.com/repos/farktronix/Texture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/farktronix/Texture/labels{/name}","releases_url":"https://api.github.com/repos/farktronix/Texture/releases{/id}","deployments_url":"https://api.github.com/repos/farktronix/Texture/deployments","created_at":"2018-11-03T16:03:04Z","updated_at":"2019-03-26T07:58:33Z","pushed_at":"2019-03-26T07:58:31Z","git_url":"git://github.com/farktronix/Texture.git","ssh_url":"git@github.com:farktronix/Texture.git","clone_url":"https://github.com/farktronix/Texture.git","svn_url":"https://github.com/farktronix/Texture","homepage":"http://texturegroup.org","size":127741,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TextureGroup:master","ref":"master","sha":"27cc0f27175f66623aa93037085b131e1e0e5694","user":{"login":"TextureGroup","id":25676156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc2MTU2","avatar_url":"https://avatars3.githubusercontent.com/u/25676156?v=4","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":81514066,"node_id":"MDEwOlJlcG9zaXRvcnk4MTUxNDA2Ng==","name":"Texture","full_name":"TextureGroup/Texture","private":false,"owner":{"login":"TextureGroup","id":25676156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc2MTU2","avatar_url":"https://avatars3.githubusercontent.com/u/25676156?v=4","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TextureGroup/Texture","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/TextureGroup/Texture","forks_url":"https://api.github.com/repos/TextureGroup/Texture/forks","keys_url":"https://api.github.com/repos/TextureGroup/Texture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TextureGroup/Texture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TextureGroup/Texture/teams","hooks_url":"https://api.github.com/repos/TextureGroup/Texture/hooks","issue_events_url":"https://api.github.com/repos/TextureGroup/Texture/issues/events{/number}","events_url":"https://api.github.com/repos/TextureGroup/Texture/events","assignees_url":"https://api.github.com/repos/TextureGroup/Texture/assignees{/user}","branches_url":"https://api.github.com/repos/TextureGroup/Texture/branches{/branch}","tags_url":"https://api.github.com/repos/TextureGroup/Texture/tags","blobs_url":"https://api.github.com/repos/TextureGroup/Texture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TextureGroup/Texture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TextureGroup/Texture/git/refs{/sha}","trees_url":"https://api.github.com/repos/TextureGroup/Texture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/{sha}","languages_url":"https://api.github.com/repos/TextureGroup/Texture/languages","stargazers_url":"https://api.github.com/repos/TextureGroup/Texture/stargazers","contributors_url":"https://api.github.com/repos/TextureGroup/Texture/contributors","subscribers_url":"https://api.github.com/repos/TextureGroup/Texture/subscribers","subscription_url":"https://api.github.com/repos/TextureGroup/Texture/subscription","commits_url":"https://api.github.com/repos/TextureGroup/Texture/commits{/sha}","git_commits_url":"https://api.github.com/repos/TextureGroup/Texture/git/commits{/sha}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/comments{/number}","issue_comment_url":"https://api.github.com/repos/TextureGroup/Texture/issues/comments{/number}","contents_url":"https://api.github.com/repos/TextureGroup/Texture/contents/{+path}","compare_url":"https://api.github.com/repos/TextureGroup/Texture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TextureGroup/Texture/merges","archive_url":"https://api.github.com/repos/TextureGroup/Texture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TextureGroup/Texture/downloads","issues_url":"https://api.github.com/repos/TextureGroup/Texture/issues{/number}","pulls_url":"https://api.github.com/repos/TextureGroup/Texture/pulls{/number}","milestones_url":"https://api.github.com/repos/TextureGroup/Texture/milestones{/number}","notifications_url":"https://api.github.com/repos/TextureGroup/Texture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TextureGroup/Texture/labels{/name}","releases_url":"https://api.github.com/repos/TextureGroup/Texture/releases{/id}","deployments_url":"https://api.github.com/repos/TextureGroup/Texture/deployments","created_at":"2017-02-10T01:44:38Z","updated_at":"2019-03-26T12:38:14Z","pushed_at":"2019-03-26T07:57:35Z","git_url":"git://github.com/TextureGroup/Texture.git","ssh_url":"git@github.com:TextureGroup/Texture.git","clone_url":"https://github.com/TextureGroup/Texture.git","svn_url":"https://github.com/TextureGroup/Texture","homepage":"http://texturegroup.org","size":127790,"stargazers_count":5322,"watchers_count":5322,"language":"Objective-C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":711,"mirror_url":null,"archived":false,"open_issues_count":375,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":711,"open_issues":375,"watchers":5322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/1425"},"html":{"href":"https://github.com/TextureGroup/Texture/pull/1425"},"issue":{"href":"https://api.github.com/repos/TextureGroup/Texture/issues/1425"},"comments":{"href":"https://api.github.com/repos/TextureGroup/Texture/issues/1425/comments"},"review_comments":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/1425/comments"},"review_comment":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/1425/commits"},"statuses":{"href":"https://api.github.com/repos/TextureGroup/Texture/statuses/ca18fbce720a6014c9316d292df3f900d4febf88"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nguyenhuy"}}