{"push_id":4113806618,"size":26,"distinct_size":26,"ref":"refs/heads/azure_windows_node_setup","head":"e740f2053b21f2b8f5e2c7767567f313f0bd834f","before":"ee49161d345b1ba410614234163d0cac6e43b6df","commits":[{"sha":"fdd09adf7bd7e13cc579cc9d1f18dea9b46a10dc","author":{"name":"bowenislandsong","email":"89d45410a4f7e06857fab990986b5c5931fa8055@redhat.com"},"message":"[docs][wni] README update\n\nThis update refactors the doc for the wni tool.","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/fdd09adf7bd7e13cc579cc9d1f18dea9b46a10dc"},{"sha":"cd07090d118394b2fbf03984e415b821f8dc4f66","author":{"name":"bowenislandsong","email":"89d45410a4f7e06857fab990986b5c5931fa8055@redhat.com"},"message":"[wni] cmd help output change\n\nThe help outputs of flags do not need periods.\nThus, unnecessary periods and spelling mistakes are removed.","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/cd07090d118394b2fbf03984e415b821f8dc4f66"},{"sha":"d31bffc67e10bf920a8989d377bb0a16ea9effc3","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #29 from Bowenislandsong/wni_readme_update\n\n[docs][wni] README update","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/d31bffc67e10bf920a8989d377bb0a16ea9effc3"},{"sha":"eb430741c23bb59b8d3abe0ff6de508921611cda","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #34 from Bowenislandsong/cmd_fix\n\n[wni] cmd help output change","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/eb430741c23bb59b8d3abe0ff6de508921611cda"},{"sha":"818e3d27c936ba6e3e1fe6400a9924f720b56b7a","author":{"name":"ravisantoshgudimetla","email":"7b2a5a1ffc7a60e8b88a62def144a93be32db4ea@gmail.com"},"message":"[WNI] Combine unnecessary AWS structs\nAs of now, we don't need the AWSOpts and createFlagInfo structs within\ncmd as both of them are being bound from the user provided command\nline options, so collapsing them into a single structure","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/818e3d27c936ba6e3e1fe6400a9924f720b56b7a"},{"sha":"8abaeb0ac7c67cd28e24effe01c942fad17dc3cb","author":{"name":"ravisantoshgudimetla","email":"7b2a5a1ffc7a60e8b88a62def144a93be32db4ea@gmail.com"},"message":"[wni] Refactor interface to be cloud provider agnostic\nAs of now, CreateVM method in cloudprovider interface has AWS specific\narguments, removing them to make the cloud provider interface\ngeneric enough across all cloud providers\n\nSigned-off-by: ravisantoshgudimetla <ravisantoshgudimetla@gmail.com>","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/8abaeb0ac7c67cd28e24effe01c942fad17dc3cb"},{"sha":"3944fbafad0e50d3582795ba894a02c6afeaebb5","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #37 from ravisantoshgudimetla/refactor-aws-opts\n\n[WNI] Combine unnecessary AWS structs","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/3944fbafad0e50d3582795ba894a02c6afeaebb5"},{"sha":"f154b77517df0ad51db0154e4fcf23db710673a0","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #38 from ravisantoshgudimetla/refactor-interface\n\n[wni] Refactor interface to be cloud provider agnostic","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/f154b77517df0ad51db0154e4fcf23db710673a0"},{"sha":"9cc8f188e9afac94bf7b51d89b4869028c7b2a95","author":{"name":"bowenislandsong","email":"89d45410a4f7e06857fab990986b5c5931fa8055@redhat.com"},"message":"Bug 1757446: [wni] Directory validation errors\n\nCause:\nThere is no sanity check for whether a path input has content.\nThere is also a lack of error messages specifying which path input:\nkubeconfig, credentials, and windows-node-installer.json file\nfailed checking against the validation of the path.\n\nConsequence:\nThe empty path is checked to see if `~` present in the head of the path,\nwhich results in an index out of range error. The error message was\nreturned directly without knowing which path input is failing.\n\nFix:\nCheck if the input path is empty.\nAdd explicit error messages to places where the validation function\nis called.\n\nResult:\nEmpty input path is errored out with proper messages showing which\ninput path is not valid.","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/9cc8f188e9afac94bf7b51d89b4869028c7b2a95"},{"sha":"6ba50540d8bc506804b4ddac0357b5db13114982","author":{"name":"ravisantoshgudimetla","email":"7b2a5a1ffc7a60e8b88a62def144a93be32db4ea@gmail.com"},"message":"[wni] Fix path resolution for wni input files\nAs of now, we're getting index out of range error while\nreading kubeconfig, resource tracker directory and credentials\nfiles if the input path is an empty string. This commit fixes\nthe problem and adds a test for the fix.","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/6ba50540d8bc506804b4ddac0357b5db13114982"},{"sha":"8f74849eb3cf4a86440bc9b1714684ab977e2cd9","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #40 from ravisantoshgudimetla/wni_bug_fix\n\nBug 1757446: [wni] Directory validation errors","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/8f74849eb3cf4a86440bc9b1714684ab977e2cd9"},{"sha":"00bf61c6b7ca4a995e98541eddb8f04902881478","author":{"name":"bowenislandsong","email":"89d45410a4f7e06857fab990986b5c5931fa8055@redhat.com"},"message":"[wni] add tools e2e test\n\nThis commit adds e2e test for `wni`.\nThe e2e-test runs against aws provider to create and delete Windows\ninstance. It does not check if all required components are created and\nalso deleted afterward.\n\nThis is the first step towards the full e2e test.","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/00bf61c6b7ca4a995e98541eddb8f04902881478"},{"sha":"7b63dc54291ed8afb14d65620709ad83737b1447","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #41 from Bowenislandsong/wni_small_e2e_test\n\n[wni] add tools e2e test","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/7b63dc54291ed8afb14d65620709ad83737b1447"},{"sha":"77520082efa9af4db995c3127527598ec93c65fa","author":{"name":"ravisantoshgudimetla","email":"7b2a5a1ffc7a60e8b88a62def144a93be32db4ea@gmail.com"},"message":"[wni] Fix the trailing slash\nerror. Without this we would be creating files in\nunnecessary directories and cannot read from the\nrequired directories.","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/77520082efa9af4db995c3127527598ec93c65fa"},{"sha":"584c990b60d0c03dfa7a5c509ce0636b9d5ec4f9","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #43 from ravisantoshgudimetla/fix-panic\n\n[wni] Fix the trailing slash","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/584c990b60d0c03dfa7a5c509ce0636b9d5ec4f9"},{"sha":"59739b8ed073915bf349a10df67943d21f9db8eb","author":{"name":"ravisantoshgudimetla","email":"7b2a5a1ffc7a60e8b88a62def144a93be32db4ea@gmail.com"},"message":"[wni] Fix the path validation err\n#43 introduced a bug, where we're not checking if the\ngiven path is file or dir and appending / while this\nshould have been normalized, in order to keep us\nmoving forward, providing this fix which ensures\ntrailing slash will be added only to directories","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/59739b8ed073915bf349a10df67943d21f9db8eb"},{"sha":"6d0f7f6061ae8bcbb2bf6b6ab8b09df835beb5f1","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #44 from ravisantoshgudimetla/fix-path-error\n\n[wni] Fix the path validation err","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/6d0f7f6061ae8bcbb2bf6b6ab8b09df835beb5f1"},{"sha":"33a0df119dd86fc026fa5977cd213dd5514a8564","author":{"name":"Leo Jia","email":"f8e312f553aba04bcf59466df43926731b73e383@redhat.com"},"message":"Enable winrm when launch Windows instance\n\nThis commit Inject PowerShell script to launch Windows instance and open port 5986 for\nwinrm https inbound traffic so the windows instance is ready for Ansible\ncommunication at launch and every time it boot up.\n\nChange the createInstance() function input with an extra parameter the\ncontains the user data input, which could be either Windows PowerShell command\nor other. So this function is still generic for all the instance type.","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/33a0df119dd86fc026fa5977cd213dd5514a8564"},{"sha":"65f7d17227782e68a5483b51b8392a9a3437714f","author":{"name":"ravisantoshgudimetla","email":"7b2a5a1ffc7a60e8b88a62def144a93be32db4ea@gmail.com"},"message":"[wni] Fix test panics\nWe are reading a wrong path in test causing the test\nto panic.","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/65f7d17227782e68a5483b51b8392a9a3437714f"},{"sha":"69f6096d11f1f77ecc1becb4a54fe91c46f01712","author":{"name":"OpenShift Merge Robot","email":"dd8cc73a9fcbc4f2f987fe818c87bd17f8347a2c@users.noreply.github.com"},"message":"Merge pull request #32 from leonjia0112/enable-instance-winrm\n\n[aws] Enable winrm when launching Windows instance","distinct":true,"url":"https://api.github.com/repos/vinaykns/windows-machine-config-operator/commits/69f6096d11f1f77ecc1becb4a54fe91c46f01712"}]}
{"actor":{"display_login":"vinaykns"}}