{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/CCF/pulls/comments/352588617","pull_request_review_id":325228590,"id":352588617,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjU4ODYxNw==","diff_hunk":"@@ -28,8 +28,13 @@ Prepare::Prepare(View v, Seqno s, Digest& d, Principal* dst) :\n   rep().digest = d;\n \n #ifdef SIGN_BATCH\n-  node->gen_signature(\n-    d.digest(), d.digest_size(), rep().batch_digest_signature);\n+  if (\n+    ((s - replica->next_expected_sig_offset()) % replica->sig_req_offset()) ==","path":"src/consensus/pbft/libbyz/Prepare.cpp","position":7,"original_position":7,"commit_id":"9551709d909f82ec12182b3b690bc3703a537de0","original_commit_id":"9551709d909f82ec12182b3b690bc3703a537de0","user":{"login":"achamayou","id":4016369,"node_id":"MDQ6VXNlcjQwMTYzNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/4016369?v=4","gravatar_id":"","url":"https://api.github.com/users/achamayou","html_url":"https://github.com/achamayou","followers_url":"https://api.github.com/users/achamayou/followers","following_url":"https://api.github.com/users/achamayou/following{/other_user}","gists_url":"https://api.github.com/users/achamayou/gists{/gist_id}","starred_url":"https://api.github.com/users/achamayou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achamayou/subscriptions","organizations_url":"https://api.github.com/users/achamayou/orgs","repos_url":"https://api.github.com/users/achamayou/repos","events_url":"https://api.github.com/users/achamayou/events{/privacy}","received_events_url":"https://api.github.com/users/achamayou/received_events","type":"User","site_admin":false},"body":"Why do we need to sign the prepare?","created_at":"2019-12-02T13:16:24Z","updated_at":"2019-12-02T13:16:25Z","html_url":"https://github.com/microsoft/CCF/pull/604#discussion_r352588617","pull_request_url":"https://api.github.com/repos/microsoft/CCF/pulls/604","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/CCF/pulls/comments/352588617"},"html":{"href":"https://github.com/microsoft/CCF/pull/604#discussion_r352588617"},"pull_request":{"href":"https://api.github.com/repos/microsoft/CCF/pulls/604"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/CCF/pulls/604","id":347171978,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MTcxOTc4","html_url":"https://github.com/microsoft/CCF/pull/604","diff_url":"https://github.com/microsoft/CCF/pull/604.diff","patch_url":"https://github.com/microsoft/CCF/pull/604.patch","issue_url":"https://api.github.com/repos/microsoft/CCF/issues/604","number":604,"state":"open","locked":false,"title":"ePBFT should not sign every request","user":{"login":"ashamis","id":887483,"node_id":"MDQ6VXNlcjg4NzQ4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/887483?v=4","gravatar_id":"","url":"https://api.github.com/users/ashamis","html_url":"https://github.com/ashamis","followers_url":"https://api.github.com/users/ashamis/followers","following_url":"https://api.github.com/users/ashamis/following{/other_user}","gists_url":"https://api.github.com/users/ashamis/gists{/gist_id}","starred_url":"https://api.github.com/users/ashamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashamis/subscriptions","organizations_url":"https://api.github.com/users/ashamis/orgs","repos_url":"https://api.github.com/users/ashamis/repos","events_url":"https://api.github.com/users/ashamis/events{/privacy}","received_events_url":"https://api.github.com/users/ashamis/received_events","type":"User","site_admin":false},"body":"resolves #597 ","created_at":"2019-11-29T22:58:46Z","updated_at":"2019-12-02T13:16:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1848fdf4cf16759aceefb4859761264568ba9e8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/CCF/pulls/604/commits","review_comments_url":"https://api.github.com/repos/microsoft/CCF/pulls/604/comments","review_comment_url":"https://api.github.com/repos/microsoft/CCF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/CCF/issues/604/comments","statuses_url":"https://api.github.com/repos/microsoft/CCF/statuses/9551709d909f82ec12182b3b690bc3703a537de0","head":{"label":"ashamis:sign_requests_4","ref":"sign_requests_4","sha":"9551709d909f82ec12182b3b690bc3703a537de0","user":{"login":"ashamis","id":887483,"node_id":"MDQ6VXNlcjg4NzQ4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/887483?v=4","gravatar_id":"","url":"https://api.github.com/users/ashamis","html_url":"https://github.com/ashamis","followers_url":"https://api.github.com/users/ashamis/followers","following_url":"https://api.github.com/users/ashamis/following{/other_user}","gists_url":"https://api.github.com/users/ashamis/gists{/gist_id}","starred_url":"https://api.github.com/users/ashamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashamis/subscriptions","organizations_url":"https://api.github.com/users/ashamis/orgs","repos_url":"https://api.github.com/users/ashamis/repos","events_url":"https://api.github.com/users/ashamis/events{/privacy}","received_events_url":"https://api.github.com/users/ashamis/received_events","type":"User","site_admin":false},"repo":{"id":190365867,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAzNjU4Njc=","name":"CCF","full_name":"ashamis/CCF","private":false,"owner":{"login":"ashamis","id":887483,"node_id":"MDQ6VXNlcjg4NzQ4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/887483?v=4","gravatar_id":"","url":"https://api.github.com/users/ashamis","html_url":"https://github.com/ashamis","followers_url":"https://api.github.com/users/ashamis/followers","following_url":"https://api.github.com/users/ashamis/following{/other_user}","gists_url":"https://api.github.com/users/ashamis/gists{/gist_id}","starred_url":"https://api.github.com/users/ashamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashamis/subscriptions","organizations_url":"https://api.github.com/users/ashamis/orgs","repos_url":"https://api.github.com/users/ashamis/repos","events_url":"https://api.github.com/users/ashamis/events{/privacy}","received_events_url":"https://api.github.com/users/ashamis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ashamis/CCF","description":"Confidential Consortium Framework - a framework to build secure, highly available, and performant applications that focus on multi-party compute and data","fork":true,"url":"https://api.github.com/repos/ashamis/CCF","forks_url":"https://api.github.com/repos/ashamis/CCF/forks","keys_url":"https://api.github.com/repos/ashamis/CCF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashamis/CCF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashamis/CCF/teams","hooks_url":"https://api.github.com/repos/ashamis/CCF/hooks","issue_events_url":"https://api.github.com/repos/ashamis/CCF/issues/events{/number}","events_url":"https://api.github.com/repos/ashamis/CCF/events","assignees_url":"https://api.github.com/repos/ashamis/CCF/assignees{/user}","branches_url":"https://api.github.com/repos/ashamis/CCF/branches{/branch}","tags_url":"https://api.github.com/repos/ashamis/CCF/tags","blobs_url":"https://api.github.com/repos/ashamis/CCF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashamis/CCF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashamis/CCF/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashamis/CCF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashamis/CCF/statuses/{sha}","languages_url":"https://api.github.com/repos/ashamis/CCF/languages","stargazers_url":"https://api.github.com/repos/ashamis/CCF/stargazers","contributors_url":"https://api.github.com/repos/ashamis/CCF/contributors","subscribers_url":"https://api.github.com/repos/ashamis/CCF/subscribers","subscription_url":"https://api.github.com/repos/ashamis/CCF/subscription","commits_url":"https://api.github.com/repos/ashamis/CCF/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashamis/CCF/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashamis/CCF/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashamis/CCF/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashamis/CCF/contents/{+path}","compare_url":"https://api.github.com/repos/ashamis/CCF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashamis/CCF/merges","archive_url":"https://api.github.com/repos/ashamis/CCF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashamis/CCF/downloads","issues_url":"https://api.github.com/repos/ashamis/CCF/issues{/number}","pulls_url":"https://api.github.com/repos/ashamis/CCF/pulls{/number}","milestones_url":"https://api.github.com/repos/ashamis/CCF/milestones{/number}","notifications_url":"https://api.github.com/repos/ashamis/CCF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashamis/CCF/labels{/name}","releases_url":"https://api.github.com/repos/ashamis/CCF/releases{/id}","deployments_url":"https://api.github.com/repos/ashamis/CCF/deployments","created_at":"2019-06-05T09:26:18Z","updated_at":"2019-11-27T15:50:19Z","pushed_at":"2019-11-29T23:21:47Z","git_url":"git://github.com/ashamis/CCF.git","ssh_url":"git@github.com:ashamis/CCF.git","clone_url":"https://github.com/ashamis/CCF.git","svn_url":"https://github.com/ashamis/CCF","homepage":"","size":5602,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"7204e79bcce99541ae8e88d289b69abafc4ec4d0","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":180112558,"node_id":"MDEwOlJlcG9zaXRvcnkxODAxMTI1NTg=","name":"CCF","full_name":"microsoft/CCF","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/CCF","description":"Confidential Consortium Framework - a framework to build secure, highly available, and performant applications that focus on multi-party compute and data","fork":false,"url":"https://api.github.com/repos/microsoft/CCF","forks_url":"https://api.github.com/repos/microsoft/CCF/forks","keys_url":"https://api.github.com/repos/microsoft/CCF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/CCF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/CCF/teams","hooks_url":"https://api.github.com/repos/microsoft/CCF/hooks","issue_events_url":"https://api.github.com/repos/microsoft/CCF/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/CCF/events","assignees_url":"https://api.github.com/repos/microsoft/CCF/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/CCF/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/CCF/tags","blobs_url":"https://api.github.com/repos/microsoft/CCF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/CCF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/CCF/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/CCF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/CCF/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/CCF/languages","stargazers_url":"https://api.github.com/repos/microsoft/CCF/stargazers","contributors_url":"https://api.github.com/repos/microsoft/CCF/contributors","subscribers_url":"https://api.github.com/repos/microsoft/CCF/subscribers","subscription_url":"https://api.github.com/repos/microsoft/CCF/subscription","commits_url":"https://api.github.com/repos/microsoft/CCF/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/CCF/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/CCF/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/CCF/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/CCF/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/CCF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/CCF/merges","archive_url":"https://api.github.com/repos/microsoft/CCF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/CCF/downloads","issues_url":"https://api.github.com/repos/microsoft/CCF/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/CCF/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/CCF/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/CCF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/CCF/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/CCF/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/CCF/deployments","created_at":"2019-04-08T09:13:04Z","updated_at":"2019-12-01T17:30:09Z","pushed_at":"2019-12-02T12:07:09Z","git_url":"git://github.com/microsoft/CCF.git","ssh_url":"git@github.com:microsoft/CCF.git","clone_url":"https://github.com/microsoft/CCF.git","svn_url":"https://github.com/microsoft/CCF","homepage":"https://microsoft.github.io/CCF/","size":26716,"stargazers_count":252,"watchers_count":252,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":54,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":79,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":54,"open_issues":79,"watchers":252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/CCF/pulls/604"},"html":{"href":"https://github.com/microsoft/CCF/pull/604"},"issue":{"href":"https://api.github.com/repos/microsoft/CCF/issues/604"},"comments":{"href":"https://api.github.com/repos/microsoft/CCF/issues/604/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/CCF/pulls/604/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/CCF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/CCF/pulls/604/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/CCF/statuses/9551709d909f82ec12182b3b690bc3703a537de0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"achamayou"}}