{"action":"created","issue":{"url":"https://api.github.com/repos/ElemeFE/element/issues/17002","repository_url":"https://api.github.com/repos/ElemeFE/element","labels_url":"https://api.github.com/repos/ElemeFE/element/issues/17002/labels{/name}","comments_url":"https://api.github.com/repos/ElemeFE/element/issues/17002/comments","events_url":"https://api.github.com/repos/ElemeFE/element/issues/17002/events","html_url":"https://github.com/ElemeFE/element/pull/17002","id":479926733,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2NzIwODE1","number":17002,"title":"Table: fixed row-style with display not work","user":{"login":"a631807682","id":11827916,"node_id":"MDQ6VXNlcjExODI3OTE2","avatar_url":"https://avatars2.githubusercontent.com/u/11827916?v=4","gravatar_id":"","url":"https://api.github.com/users/a631807682","html_url":"https://github.com/a631807682","followers_url":"https://api.github.com/users/a631807682/followers","following_url":"https://api.github.com/users/a631807682/following{/other_user}","gists_url":"https://api.github.com/users/a631807682/gists{/gist_id}","starred_url":"https://api.github.com/users/a631807682/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a631807682/subscriptions","organizations_url":"https://api.github.com/users/a631807682/orgs","repos_url":"https://api.github.com/users/a631807682/repos","events_url":"https://api.github.com/users/a631807682/events{/privacy}","received_events_url":"https://api.github.com/users/a631807682/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"ziyoung","id":12947422,"node_id":"MDQ6VXNlcjEyOTQ3NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/12947422?v=4","gravatar_id":"","url":"https://api.github.com/users/ziyoung","html_url":"https://github.com/ziyoung","followers_url":"https://api.github.com/users/ziyoung/followers","following_url":"https://api.github.com/users/ziyoung/following{/other_user}","gists_url":"https://api.github.com/users/ziyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/ziyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziyoung/subscriptions","organizations_url":"https://api.github.com/users/ziyoung/orgs","repos_url":"https://api.github.com/users/ziyoung/repos","events_url":"https://api.github.com/users/ziyoung/events{/privacy}","received_events_url":"https://api.github.com/users/ziyoung/received_events","type":"User","site_admin":false},"assignees":[{"login":"ziyoung","id":12947422,"node_id":"MDQ6VXNlcjEyOTQ3NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/12947422?v=4","gravatar_id":"","url":"https://api.github.com/users/ziyoung","html_url":"https://github.com/ziyoung","followers_url":"https://api.github.com/users/ziyoung/followers","following_url":"https://api.github.com/users/ziyoung/following{/other_user}","gists_url":"https://api.github.com/users/ziyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/ziyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziyoung/subscriptions","organizations_url":"https://api.github.com/users/ziyoung/orgs","repos_url":"https://api.github.com/users/ziyoung/repos","events_url":"https://api.github.com/users/ziyoung/events{/privacy}","received_events_url":"https://api.github.com/users/ziyoung/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ElemeFE/element/milestones/25","html_url":"https://github.com/ElemeFE/element/milestone/25","labels_url":"https://api.github.com/repos/ElemeFE/element/milestones/25/labels","id":4609088,"node_id":"MDk6TWlsZXN0b25lNDYwOTA4OA==","number":25,"title":"2.13.0","description":"","creator":{"login":"ziyoung","id":12947422,"node_id":"MDQ6VXNlcjEyOTQ3NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/12947422?v=4","gravatar_id":"","url":"https://api.github.com/users/ziyoung","html_url":"https://github.com/ziyoung","followers_url":"https://api.github.com/users/ziyoung/followers","following_url":"https://api.github.com/users/ziyoung/following{/other_user}","gists_url":"https://api.github.com/users/ziyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/ziyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziyoung/subscriptions","organizations_url":"https://api.github.com/users/ziyoung/orgs","repos_url":"https://api.github.com/users/ziyoung/repos","events_url":"https://api.github.com/users/ziyoung/events{/privacy}","received_events_url":"https://api.github.com/users/ziyoung/received_events","type":"User","site_admin":false},"open_issues":81,"closed_issues":59,"state":"open","created_at":"2019-08-28T08:11:35Z","updated_at":"2019-11-12T07:34:03Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2019-08-13T02:13:03Z","updated_at":"2019-12-11T06:55:35Z","closed_at":"2019-09-06T07:46:26Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ElemeFE/element/pulls/17002","html_url":"https://github.com/ElemeFE/element/pull/17002","diff_url":"https://github.com/ElemeFE/element/pull/17002.diff","patch_url":"https://github.com/ElemeFE/element/pull/17002.patch"},"body":"Please make sure these boxes are checked before submitting your PR, thank you!\r\n\r\n* [x] Make sure you follow Element's contributing guide ([中文](https://github.com/ElemeFE/element/blob/master/.github/CONTRIBUTING.zh-CN.md) | [English](https://github.com/ElemeFE/element/blob/master/.github/CONTRIBUTING.en-US.md) | [Español](https://github.com/ElemeFE/element/blob/master/.github/CONTRIBUTING.es.md) | [Français](https://github.com/ElemeFE/element/blob/master/.github/CONTRIBUTING.fr-FR.md)).\r\n* [x] Make sure you are merging your commits to `dev` branch.\r\n* [x] Add some descriptions and refer relative issues for you PR.\r\n\r\n#16995 \r\n"},"comment":{"url":"https://api.github.com/repos/ElemeFE/element/issues/comments/564406460","html_url":"https://github.com/ElemeFE/element/pull/17002#issuecomment-564406460","issue_url":"https://api.github.com/repos/ElemeFE/element/issues/17002","id":564406460,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NDQwNjQ2MA==","user":{"login":"gladysyang","id":20352653,"node_id":"MDQ6VXNlcjIwMzUyNjUz","avatar_url":"https://avatars3.githubusercontent.com/u/20352653?v=4","gravatar_id":"","url":"https://api.github.com/users/gladysyang","html_url":"https://github.com/gladysyang","followers_url":"https://api.github.com/users/gladysyang/followers","following_url":"https://api.github.com/users/gladysyang/following{/other_user}","gists_url":"https://api.github.com/users/gladysyang/gists{/gist_id}","starred_url":"https://api.github.com/users/gladysyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gladysyang/subscriptions","organizations_url":"https://api.github.com/users/gladysyang/orgs","repos_url":"https://api.github.com/users/gladysyang/repos","events_url":"https://api.github.com/users/gladysyang/events{/privacy}","received_events_url":"https://api.github.com/users/gladysyang/received_events","type":"User","site_admin":false},"created_at":"2019-12-11T06:55:35Z","updated_at":"2019-12-11T06:55:35Z","author_association":"NONE","body":"> > 我按照这个issue修改了下源码 但是还是没生效啊\r\n> \r\n> 提供一下复现链接，比如这样\r\n> https://codepen.io/a631807682/pen/dybXLdm?editors=1111\r\n\r\n\r\n\r\n> > @a631807682 我改成这样才能起作用，麻烦您确认下，谢谢！\r\n> > ```js\r\n> >         rowClasses.push('el-table__row--level-' + treeRowData.level);\r\n> >         display = treeRowData.display;\r\n> >       }\r\n> >       // https://github.com/ElemeFE/element/issues/16995\r\n> >       let displayStyle = display ? null : {\r\n> >         display: 'none'\r\n> >       };\r\n> >       return (<tr\r\n> >         style={ displayStyle || this.getRowStyle(row, $index) }\r\n> >         class={ rowClasses }\r\n> >         key={ this.getKeyOfRow(row, $index) }\r\n> >         on-dblclick={ ($event) => this.handleDoubleClick($event, row) }\r\n> > ```\r\n> \r\n> 如果是这样，则`row-style`不修改`display`状态，`display`状态也会被覆盖。\r\n> \r\n> ## 如何生效\r\n> 如上面`codepen`示例，`style`以`Object`返回，查看效果是否符合。\r\n> \r\n> ## 修改后原 issue 仍然无法工作\r\n> 我的理解文档定义 [row-style](https://element.eleme.cn/#/zh-CN/component/table) 设计上支持的是`Object`或返回`Object`的`Function`，因此原`issue`返回`string`不支持。\r\n> \r\n> ## 如何支持Sting/Array/Object\r\n> 见上一个回复（需要在`table`上`merge`多种类型`style`）\r\n\r\n[row-style]一直以来都是支持`string`的吧，因为我之前用的返回的都是`string`,之前都是支持的，但是现在升级后就不支持了，改成`Object`才支持，我觉得返回`string`应该要兼容一下的吧，不然又要我们去改之前的代码了，这样不太合理的哟"}}
{"actor":{"display_login":"gladysyang"}}