{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/comments/291510898","pull_request_review_id":246988694,"id":291510898,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTUxMDg5OA==","diff_hunk":"@@ -11,10 +11,16 @@\n #include \"libsecp256k1-config.h\"\n #endif\n \n+#include <string.h>\n #include <stdlib.h>\n #include <stdint.h>\n #include <stdio.h>\n \n+#if defined(_MSC_VER)\n+// For SecureZeroMemory\n+#include <Windows.h>","path":"src/util.h","position":11,"original_position":11,"commit_id":"aa65cd6f737ddea6022ac0f0ebe1a28d9d31c9af","original_commit_id":"aa65cd6f737ddea6022ac0f0ebe1a28d9d31c9af","user":{"login":"gmaxwell","id":858454,"node_id":"MDQ6VXNlcjg1ODQ1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/858454?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"body":"I would be that this should be version gated, I'll see if I can figure out where thats supported to.","created_at":"2019-06-07T09:08:53Z","updated_at":"2019-06-07T09:08:54Z","html_url":"https://github.com/bitcoin-core/secp256k1/pull/636#discussion_r291510898","pull_request_url":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/636","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/comments/291510898"},"html":{"href":"https://github.com/bitcoin-core/secp256k1/pull/636#discussion_r291510898"},"pull_request":{"href":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/636"}},"in_reply_to_id":291366629},"pull_request":{"url":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/636","id":285964513,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1OTY0NTEz","html_url":"https://github.com/bitcoin-core/secp256k1/pull/636","diff_url":"https://github.com/bitcoin-core/secp256k1/pull/636.diff","patch_url":"https://github.com/bitcoin-core/secp256k1/pull/636.patch","issue_url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/636","number":636,"state":"open","locked":false,"title":"Clear sensitive memory without getting optimized out","user":{"login":"real-or-random","id":1071625,"node_id":"MDQ6VXNlcjEwNzE2MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1071625?v=4","gravatar_id":"","url":"https://api.github.com/users/real-or-random","html_url":"https://github.com/real-or-random","followers_url":"https://api.github.com/users/real-or-random/followers","following_url":"https://api.github.com/users/real-or-random/following{/other_user}","gists_url":"https://api.github.com/users/real-or-random/gists{/gist_id}","starred_url":"https://api.github.com/users/real-or-random/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/real-or-random/subscriptions","organizations_url":"https://api.github.com/users/real-or-random/orgs","repos_url":"https://api.github.com/users/real-or-random/repos","events_url":"https://api.github.com/users/real-or-random/events{/privacy}","received_events_url":"https://api.github.com/users/real-or-random/received_events","type":"User","site_admin":false},"body":"This is a rebase of #448, including a few changes (mostly implementing what I described in #185). I haven't tested this on Windows and I actually haven't reviewed this in detail so far, but people can start to have a look.\r\n\r\nFixes #185 and closes #448.","created_at":"2019-06-06T20:49:54Z","updated_at":"2019-06-07T09:08:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91cb917819bcf5ac7f2a0086a4d06492531a5f52","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/636/commits","review_comments_url":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/636/comments","review_comment_url":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/636/comments","statuses_url":"https://api.github.com/repos/bitcoin-core/secp256k1/statuses/aa65cd6f737ddea6022ac0f0ebe1a28d9d31c9af","head":{"label":"real-or-random:cleanse","ref":"cleanse","sha":"aa65cd6f737ddea6022ac0f0ebe1a28d9d31c9af","user":{"login":"real-or-random","id":1071625,"node_id":"MDQ6VXNlcjEwNzE2MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1071625?v=4","gravatar_id":"","url":"https://api.github.com/users/real-or-random","html_url":"https://github.com/real-or-random","followers_url":"https://api.github.com/users/real-or-random/followers","following_url":"https://api.github.com/users/real-or-random/following{/other_user}","gists_url":"https://api.github.com/users/real-or-random/gists{/gist_id}","starred_url":"https://api.github.com/users/real-or-random/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/real-or-random/subscriptions","organizations_url":"https://api.github.com/users/real-or-random/orgs","repos_url":"https://api.github.com/users/real-or-random/repos","events_url":"https://api.github.com/users/real-or-random/events{/privacy}","received_events_url":"https://api.github.com/users/real-or-random/received_events","type":"User","site_admin":false},"repo":{"id":93596674,"node_id":"MDEwOlJlcG9zaXRvcnk5MzU5NjY3NA==","name":"secp256k1","full_name":"real-or-random/secp256k1","private":false,"owner":{"login":"real-or-random","id":1071625,"node_id":"MDQ6VXNlcjEwNzE2MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1071625?v=4","gravatar_id":"","url":"https://api.github.com/users/real-or-random","html_url":"https://github.com/real-or-random","followers_url":"https://api.github.com/users/real-or-random/followers","following_url":"https://api.github.com/users/real-or-random/following{/other_user}","gists_url":"https://api.github.com/users/real-or-random/gists{/gist_id}","starred_url":"https://api.github.com/users/real-or-random/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/real-or-random/subscriptions","organizations_url":"https://api.github.com/users/real-or-random/orgs","repos_url":"https://api.github.com/users/real-or-random/repos","events_url":"https://api.github.com/users/real-or-random/events{/privacy}","received_events_url":"https://api.github.com/users/real-or-random/received_events","type":"User","site_admin":false},"html_url":"https://github.com/real-or-random/secp256k1","description":"Optimized C library for EC operations on curve secp256k1","fork":true,"url":"https://api.github.com/repos/real-or-random/secp256k1","forks_url":"https://api.github.com/repos/real-or-random/secp256k1/forks","keys_url":"https://api.github.com/repos/real-or-random/secp256k1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/real-or-random/secp256k1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/real-or-random/secp256k1/teams","hooks_url":"https://api.github.com/repos/real-or-random/secp256k1/hooks","issue_events_url":"https://api.github.com/repos/real-or-random/secp256k1/issues/events{/number}","events_url":"https://api.github.com/repos/real-or-random/secp256k1/events","assignees_url":"https://api.github.com/repos/real-or-random/secp256k1/assignees{/user}","branches_url":"https://api.github.com/repos/real-or-random/secp256k1/branches{/branch}","tags_url":"https://api.github.com/repos/real-or-random/secp256k1/tags","blobs_url":"https://api.github.com/repos/real-or-random/secp256k1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/real-or-random/secp256k1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/real-or-random/secp256k1/git/refs{/sha}","trees_url":"https://api.github.com/repos/real-or-random/secp256k1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/real-or-random/secp256k1/statuses/{sha}","languages_url":"https://api.github.com/repos/real-or-random/secp256k1/languages","stargazers_url":"https://api.github.com/repos/real-or-random/secp256k1/stargazers","contributors_url":"https://api.github.com/repos/real-or-random/secp256k1/contributors","subscribers_url":"https://api.github.com/repos/real-or-random/secp256k1/subscribers","subscription_url":"https://api.github.com/repos/real-or-random/secp256k1/subscription","commits_url":"https://api.github.com/repos/real-or-random/secp256k1/commits{/sha}","git_commits_url":"https://api.github.com/repos/real-or-random/secp256k1/git/commits{/sha}","comments_url":"https://api.github.com/repos/real-or-random/secp256k1/comments{/number}","issue_comment_url":"https://api.github.com/repos/real-or-random/secp256k1/issues/comments{/number}","contents_url":"https://api.github.com/repos/real-or-random/secp256k1/contents/{+path}","compare_url":"https://api.github.com/repos/real-or-random/secp256k1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/real-or-random/secp256k1/merges","archive_url":"https://api.github.com/repos/real-or-random/secp256k1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/real-or-random/secp256k1/downloads","issues_url":"https://api.github.com/repos/real-or-random/secp256k1/issues{/number}","pulls_url":"https://api.github.com/repos/real-or-random/secp256k1/pulls{/number}","milestones_url":"https://api.github.com/repos/real-or-random/secp256k1/milestones{/number}","notifications_url":"https://api.github.com/repos/real-or-random/secp256k1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/real-or-random/secp256k1/labels{/name}","releases_url":"https://api.github.com/repos/real-or-random/secp256k1/releases{/id}","deployments_url":"https://api.github.com/repos/real-or-random/secp256k1/deployments","created_at":"2017-06-07T05:39:43Z","updated_at":"2019-03-08T13:44:45Z","pushed_at":"2019-06-06T20:48:18Z","git_url":"git://github.com/real-or-random/secp256k1.git","ssh_url":"git@github.com:real-or-random/secp256k1.git","clone_url":"https://github.com/real-or-random/secp256k1.git","svn_url":"https://github.com/real-or-random/secp256k1","homepage":null,"size":2270,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin-core:master","ref":"master","sha":"fa3301713549d118e57ebe6551d062903ddd6b63","user":{"login":"bitcoin-core","id":13464320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDY0MzIw","avatar_url":"https://avatars2.githubusercontent.com/u/13464320?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin-core","html_url":"https://github.com/bitcoin-core","followers_url":"https://api.github.com/users/bitcoin-core/followers","following_url":"https://api.github.com/users/bitcoin-core/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin-core/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin-core/subscriptions","organizations_url":"https://api.github.com/users/bitcoin-core/orgs","repos_url":"https://api.github.com/users/bitcoin-core/repos","events_url":"https://api.github.com/users/bitcoin-core/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin-core/received_events","type":"Organization","site_admin":false},"repo":{"id":16648618,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY0ODYxOA==","name":"secp256k1","full_name":"bitcoin-core/secp256k1","private":false,"owner":{"login":"bitcoin-core","id":13464320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDY0MzIw","avatar_url":"https://avatars2.githubusercontent.com/u/13464320?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin-core","html_url":"https://github.com/bitcoin-core","followers_url":"https://api.github.com/users/bitcoin-core/followers","following_url":"https://api.github.com/users/bitcoin-core/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin-core/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin-core/subscriptions","organizations_url":"https://api.github.com/users/bitcoin-core/orgs","repos_url":"https://api.github.com/users/bitcoin-core/repos","events_url":"https://api.github.com/users/bitcoin-core/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin-core/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoin-core/secp256k1","description":"Optimized C library for EC operations on curve secp256k1","fork":false,"url":"https://api.github.com/repos/bitcoin-core/secp256k1","forks_url":"https://api.github.com/repos/bitcoin-core/secp256k1/forks","keys_url":"https://api.github.com/repos/bitcoin-core/secp256k1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin-core/secp256k1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin-core/secp256k1/teams","hooks_url":"https://api.github.com/repos/bitcoin-core/secp256k1/hooks","issue_events_url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin-core/secp256k1/events","assignees_url":"https://api.github.com/repos/bitcoin-core/secp256k1/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin-core/secp256k1/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin-core/secp256k1/tags","blobs_url":"https://api.github.com/repos/bitcoin-core/secp256k1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin-core/secp256k1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin-core/secp256k1/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin-core/secp256k1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin-core/secp256k1/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin-core/secp256k1/languages","stargazers_url":"https://api.github.com/repos/bitcoin-core/secp256k1/stargazers","contributors_url":"https://api.github.com/repos/bitcoin-core/secp256k1/contributors","subscribers_url":"https://api.github.com/repos/bitcoin-core/secp256k1/subscribers","subscription_url":"https://api.github.com/repos/bitcoin-core/secp256k1/subscription","commits_url":"https://api.github.com/repos/bitcoin-core/secp256k1/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin-core/secp256k1/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin-core/secp256k1/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin-core/secp256k1/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin-core/secp256k1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin-core/secp256k1/merges","archive_url":"https://api.github.com/repos/bitcoin-core/secp256k1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin-core/secp256k1/downloads","issues_url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin-core/secp256k1/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin-core/secp256k1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin-core/secp256k1/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin-core/secp256k1/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin-core/secp256k1/deployments","created_at":"2014-02-08T17:30:06Z","updated_at":"2019-06-06T01:53:09Z","pushed_at":"2019-06-06T20:49:54Z","git_url":"git://github.com/bitcoin-core/secp256k1.git","ssh_url":"git@github.com:bitcoin-core/secp256k1.git","clone_url":"https://github.com/bitcoin-core/secp256k1.git","svn_url":"https://github.com/bitcoin-core/secp256k1","homepage":null,"size":2040,"stargazers_count":811,"watchers_count":811,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":493,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":70,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":493,"open_issues":70,"watchers":811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/636"},"html":{"href":"https://github.com/bitcoin-core/secp256k1/pull/636"},"issue":{"href":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/636"},"comments":{"href":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin-core/secp256k1/statuses/aa65cd6f737ddea6022ac0f0ebe1a28d9d31c9af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gmaxwell"}}