{"action":"created","comment":{"url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/comments/291861290","pull_request_review_id":247428112,"id":291861290,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTg2MTI5MA==","diff_hunk":"@@ -631,8 +643,15 @@ def main(args=None, app=None):\n                     parser.error(\n                         'this requires --i-understand-format-is-unstable '\n                         'and a sacrifice of one cute kitten')\n-                sys.stdout.write(''.join('{} - {}\\n'.format(*available)\n-                    for available in appmenus.get_available(vm)))\n+                if not args.fields:\n+                    sys.stdout.write(''.join('{} - {}\\n'.format(*available)\n+                                             for available in\n+                                             appmenus.get_available(vm)))\n+                else:\n+                    for result in appmenus.get_available(\n+                            vm, fields=args.fields):\n+                        print(' | '.join(result))","path":"qubesappmenus/__init__.py","position":58,"original_position":58,"commit_id":"b04ba532cb5c680d3ab10e4226716c6c9283f99b","original_commit_id":"b04ba532cb5c680d3ab10e4226716c6c9283f99b","user":{"login":"marmarek","id":726704,"node_id":"MDQ6VXNlcjcyNjcwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/726704?v=4","gravatar_id":"","url":"https://api.github.com/users/marmarek","html_url":"https://github.com/marmarek","followers_url":"https://api.github.com/users/marmarek/followers","following_url":"https://api.github.com/users/marmarek/following{/other_user}","gists_url":"https://api.github.com/users/marmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/marmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmarek/subscriptions","organizations_url":"https://api.github.com/users/marmarek/orgs","repos_url":"https://api.github.com/users/marmarek/repos","events_url":"https://api.github.com/users/marmarek/events{/privacy}","received_events_url":"https://api.github.com/users/marmarek/received_events","type":"User","site_admin":false},"body":"Please make the separate one character. Multi-character field separators may lead to various corner cases (for example how to interpret `a | | b`).","created_at":"2019-06-10T01:54:20Z","updated_at":"2019-06-10T01:54:33Z","html_url":"https://github.com/QubesOS/qubes-desktop-linux-common/pull/12#discussion_r291861290","pull_request_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/12","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/comments/291861290"},"html":{"href":"https://github.com/QubesOS/qubes-desktop-linux-common/pull/12#discussion_r291861290"},"pull_request":{"href":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/12","id":285396520,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1Mzk2NTIw","html_url":"https://github.com/QubesOS/qubes-desktop-linux-common/pull/12","diff_url":"https://github.com/QubesOS/qubes-desktop-linux-common/pull/12.diff","patch_url":"https://github.com/QubesOS/qubes-desktop-linux-common/pull/12.patch","issue_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/issues/12","number":12,"state":"open","locked":false,"title":"Added handling for more file fields in GetAppmenus","user":{"login":"marmarta","id":7242298,"node_id":"MDQ6VXNlcjcyNDIyOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7242298?v=4","gravatar_id":"","url":"https://api.github.com/users/marmarta","html_url":"https://github.com/marmarta","followers_url":"https://api.github.com/users/marmarta/followers","following_url":"https://api.github.com/users/marmarta/following{/other_user}","gists_url":"https://api.github.com/users/marmarta/gists{/gist_id}","starred_url":"https://api.github.com/users/marmarta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmarta/subscriptions","organizations_url":"https://api.github.com/users/marmarta/orgs","repos_url":"https://api.github.com/users/marmarta/repos","events_url":"https://api.github.com/users/marmarta/events{/privacy}","received_events_url":"https://api.github.com/users/marmarta/received_events","type":"User","site_admin":false},"body":"Adding the optional --file-field parameter. It changes to output format\r\nto '|'-separated one, and outputs not only file name and app name, but\r\nalso whatever fields from the file the user has requested. Used by\r\nGUI VM settings.\r\n\r\nreferences QubesOS/qubes-issues#5076","created_at":"2019-06-05T14:18:15Z","updated_at":"2019-06-10T01:54:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"720b6a39f2f9f96c5d786860b05751bc737c7cf7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/12/commits","review_comments_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/12/comments","review_comment_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/issues/12/comments","statuses_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/statuses/b04ba532cb5c680d3ab10e4226716c6c9283f99b","head":{"label":"marmarta:feature5076","ref":"feature5076","sha":"b04ba532cb5c680d3ab10e4226716c6c9283f99b","user":{"login":"marmarta","id":7242298,"node_id":"MDQ6VXNlcjcyNDIyOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7242298?v=4","gravatar_id":"","url":"https://api.github.com/users/marmarta","html_url":"https://github.com/marmarta","followers_url":"https://api.github.com/users/marmarta/followers","following_url":"https://api.github.com/users/marmarta/following{/other_user}","gists_url":"https://api.github.com/users/marmarta/gists{/gist_id}","starred_url":"https://api.github.com/users/marmarta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmarta/subscriptions","organizations_url":"https://api.github.com/users/marmarta/orgs","repos_url":"https://api.github.com/users/marmarta/repos","events_url":"https://api.github.com/users/marmarta/events{/privacy}","received_events_url":"https://api.github.com/users/marmarta/received_events","type":"User","site_admin":false},"repo":{"id":97387903,"node_id":"MDEwOlJlcG9zaXRvcnk5NzM4NzkwMw==","name":"qubes-desktop-linux-common","full_name":"marmarta/qubes-desktop-linux-common","private":false,"owner":{"login":"marmarta","id":7242298,"node_id":"MDQ6VXNlcjcyNDIyOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7242298?v=4","gravatar_id":"","url":"https://api.github.com/users/marmarta","html_url":"https://github.com/marmarta","followers_url":"https://api.github.com/users/marmarta/followers","following_url":"https://api.github.com/users/marmarta/following{/other_user}","gists_url":"https://api.github.com/users/marmarta/gists{/gist_id}","starred_url":"https://api.github.com/users/marmarta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmarta/subscriptions","organizations_url":"https://api.github.com/users/marmarta/orgs","repos_url":"https://api.github.com/users/marmarta/repos","events_url":"https://api.github.com/users/marmarta/events{/privacy}","received_events_url":"https://api.github.com/users/marmarta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marmarta/qubes-desktop-linux-common","description":"Common code used for multiple desktop environments' Qubes integration","fork":true,"url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common","forks_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/forks","keys_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/teams","hooks_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/hooks","issue_events_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/issues/events{/number}","events_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/events","assignees_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/assignees{/user}","branches_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/branches{/branch}","tags_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/tags","blobs_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/statuses/{sha}","languages_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/languages","stargazers_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/stargazers","contributors_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/contributors","subscribers_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/subscribers","subscription_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/subscription","commits_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/contents/{+path}","compare_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/merges","archive_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/downloads","issues_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/issues{/number}","pulls_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/pulls{/number}","milestones_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/milestones{/number}","notifications_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/labels{/name}","releases_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/releases{/id}","deployments_url":"https://api.github.com/repos/marmarta/qubes-desktop-linux-common/deployments","created_at":"2017-07-16T14:15:00Z","updated_at":"2017-07-16T14:15:03Z","pushed_at":"2019-06-07T15:44:13Z","git_url":"git://github.com/marmarta/qubes-desktop-linux-common.git","ssh_url":"git@github.com:marmarta/qubes-desktop-linux-common.git","clone_url":"https://github.com/marmarta/qubes-desktop-linux-common.git","svn_url":"https://github.com/marmarta/qubes-desktop-linux-common","homepage":null,"size":1865,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QubesOS:master","ref":"master","sha":"b7cc87217309b71f169acad7b5f70a945793d24f","user":{"login":"QubesOS","id":10213205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjEzMjA1","avatar_url":"https://avatars3.githubusercontent.com/u/10213205?v=4","gravatar_id":"","url":"https://api.github.com/users/QubesOS","html_url":"https://github.com/QubesOS","followers_url":"https://api.github.com/users/QubesOS/followers","following_url":"https://api.github.com/users/QubesOS/following{/other_user}","gists_url":"https://api.github.com/users/QubesOS/gists{/gist_id}","starred_url":"https://api.github.com/users/QubesOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QubesOS/subscriptions","organizations_url":"https://api.github.com/users/QubesOS/orgs","repos_url":"https://api.github.com/users/QubesOS/repos","events_url":"https://api.github.com/users/QubesOS/events{/privacy}","received_events_url":"https://api.github.com/users/QubesOS/received_events","type":"Organization","site_admin":false},"repo":{"id":88909144,"node_id":"MDEwOlJlcG9zaXRvcnk4ODkwOTE0NA==","name":"qubes-desktop-linux-common","full_name":"QubesOS/qubes-desktop-linux-common","private":false,"owner":{"login":"QubesOS","id":10213205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjEzMjA1","avatar_url":"https://avatars3.githubusercontent.com/u/10213205?v=4","gravatar_id":"","url":"https://api.github.com/users/QubesOS","html_url":"https://github.com/QubesOS","followers_url":"https://api.github.com/users/QubesOS/followers","following_url":"https://api.github.com/users/QubesOS/following{/other_user}","gists_url":"https://api.github.com/users/QubesOS/gists{/gist_id}","starred_url":"https://api.github.com/users/QubesOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QubesOS/subscriptions","organizations_url":"https://api.github.com/users/QubesOS/orgs","repos_url":"https://api.github.com/users/QubesOS/repos","events_url":"https://api.github.com/users/QubesOS/events{/privacy}","received_events_url":"https://api.github.com/users/QubesOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QubesOS/qubes-desktop-linux-common","description":"Common code used for multiple desktop environments' Qubes integration","fork":true,"url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common","forks_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/forks","keys_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/teams","hooks_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/hooks","issue_events_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/issues/events{/number}","events_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/events","assignees_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/assignees{/user}","branches_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/branches{/branch}","tags_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/tags","blobs_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/statuses/{sha}","languages_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/languages","stargazers_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/stargazers","contributors_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/contributors","subscribers_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/subscribers","subscription_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/subscription","commits_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/contents/{+path}","compare_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/merges","archive_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/downloads","issues_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/issues{/number}","pulls_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls{/number}","milestones_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/milestones{/number}","notifications_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/labels{/name}","releases_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/releases{/id}","deployments_url":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/deployments","created_at":"2017-04-20T20:47:17Z","updated_at":"2019-04-12T22:08:56Z","pushed_at":"2019-06-07T15:44:14Z","git_url":"git://github.com/QubesOS/qubes-desktop-linux-common.git","ssh_url":"git@github.com:QubesOS/qubes-desktop-linux-common.git","clone_url":"https://github.com/QubesOS/qubes-desktop-linux-common.git","svn_url":"https://github.com/QubesOS/qubes-desktop-linux-common","homepage":null,"size":1912,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/12"},"html":{"href":"https://github.com/QubesOS/qubes-desktop-linux-common/pull/12"},"issue":{"href":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/issues/12"},"comments":{"href":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/QubesOS/qubes-desktop-linux-common/statuses/b04ba532cb5c680d3ab10e4226716c6c9283f99b"}},"author_association":"NONE"}}
{"actor":{"display_login":"marmarek"}}