{"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/cryptogarageinc/cfd/pulls/54","id":362406898,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYyNDA2ODk4","html_url":"https://github.com/cryptogarageinc/cfd/pull/54","diff_url":"https://github.com/cryptogarageinc/cfd/pull/54.diff","patch_url":"https://github.com/cryptogarageinc/cfd/pull/54.patch","issue_url":"https://api.github.com/repos/cryptogarageinc/cfd/issues/54","number":54,"state":"closed","locked":false,"title":"update function name","user":{"login":"k-matsuzawa","id":49175372,"node_id":"MDQ6VXNlcjQ5MTc1Mzcy","avatar_url":"https://avatars0.githubusercontent.com/u/49175372?v=4","gravatar_id":"","url":"https://api.github.com/users/k-matsuzawa","html_url":"https://github.com/k-matsuzawa","followers_url":"https://api.github.com/users/k-matsuzawa/followers","following_url":"https://api.github.com/users/k-matsuzawa/following{/other_user}","gists_url":"https://api.github.com/users/k-matsuzawa/gists{/gist_id}","starred_url":"https://api.github.com/users/k-matsuzawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-matsuzawa/subscriptions","organizations_url":"https://api.github.com/users/k-matsuzawa/orgs","repos_url":"https://api.github.com/users/k-matsuzawa/repos","events_url":"https://api.github.com/users/k-matsuzawa/events{/privacy}","received_events_url":"https://api.github.com/users/k-matsuzawa/received_events","type":"User","site_admin":false},"body":"## 関連Issue\r\n\r\n<!--\r\nこのPRが、ZenHubのどのIssueに紐づいているかを記載する\r\n  - ZenHubのURL\r\n-->\r\n- https://app.zenhub.com/workspaces/cfd-5cdbe88f0f84751dcd8fd7ab/issues/cryptogarageinc/btclib-sandbox/1115\r\n\r\n## 概要\r\n\r\n<!--\r\n- 追加機能の概要を記載\r\n- 前提が共有されていない場合は、  \r\n  なぜこの変更をして、  \r\n  どう解決されるのかも併せて記載する\r\n\r\n- 必要であれば、以下のような詳細についても記載する\r\n  - 以下の観点で、レビューアーにわかるように技術的な変更点の概要を記載\r\n    - 何をどう変更したか\r\n    - どういった手法を採用したか  \r\n      （e.g. パス探索については、幅優先探索を採用した）\r\n    - 外部システムとのI/F変更\r\n    - など\r\n-->\r\n\r\n- 1136：AbstractTransactionおよび継承クラスにおける関数名を変更。cfd側はcore参照変更のみ。\r\n\r\n## 使い方\r\n\r\n<!-- \r\n- PRの動作確認方法\r\n  - 動作確認が必要なタスクについては、必要なコマンドなどを記載\r\n  - 必要なければ、無記載で良い\r\n-->\r\n\r\n```bash\r\n```\r\n\r\n## 今回保留した項目とTODO\r\n\r\n<!--\r\n- 箇条書きで保留した項目があれば、記載\r\n  - 保留項目が直近の対応が必要な場合、対応チケットを作成して記載\r\n\r\n記載例\r\n- 〇〇の計算ロジックの本実装 #0000\r\n-->\r\n\r\n- \r\n\r\n## 確認項目\r\n\r\n**PRを出した人**\r\n<!-- PRを出す前後で確認する項目 -->\r\n\r\n- [x] チェックスクリプトでチェックを実施した <!-- npm run check -->\r\n- [x] 正常にビルドできた\r\n- [ ] 関連チケットに実績をつけた\r\n- [ ] ZenHubでPRとIssueを関連付けた\r\n- [ ] ZenHubのIssueを `Review/QA` Pipelineに移した\r\n\r\n**レビューする人**\r\n<!-- レビューをする前後で確認する項目 -->\r\n- [ ] 関連チケットにレビュー実績をつけた\r\n\r\n## 備考\r\n\r\n<!--\r\n- 実装に関する悩み（AにするかBにするか迷ったがAにしたや、こうしたかったけどできなかったなど）があれば記載\r\n-->\r\n","created_at":"2020-01-14T01:59:03Z","updated_at":"2020-01-14T02:05:50Z","closed_at":"2020-01-14T02:05:50Z","merged_at":null,"merge_commit_sha":"025e80a2856e57cfc7b1355a80b7250d26bab5a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cryptogarageinc/cfd/pulls/54/commits","review_comments_url":"https://api.github.com/repos/cryptogarageinc/cfd/pulls/54/comments","review_comment_url":"https://api.github.com/repos/cryptogarageinc/cfd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cryptogarageinc/cfd/issues/54/comments","statuses_url":"https://api.github.com/repos/cryptogarageinc/cfd/statuses/c012f7159239bfb7688286632b2e9b8d30c8e9c2","head":{"label":"cryptogarageinc:feature/function_refactor_20200114","ref":"feature/function_refactor_20200114","sha":"c012f7159239bfb7688286632b2e9b8d30c8e9c2","user":{"login":"cryptogarageinc","id":43569601,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTY5NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/43569601?v=4","gravatar_id":"","url":"https://api.github.com/users/cryptogarageinc","html_url":"https://github.com/cryptogarageinc","followers_url":"https://api.github.com/users/cryptogarageinc/followers","following_url":"https://api.github.com/users/cryptogarageinc/following{/other_user}","gists_url":"https://api.github.com/users/cryptogarageinc/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptogarageinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptogarageinc/subscriptions","organizations_url":"https://api.github.com/users/cryptogarageinc/orgs","repos_url":"https://api.github.com/users/cryptogarageinc/repos","events_url":"https://api.github.com/users/cryptogarageinc/events{/privacy}","received_events_url":"https://api.github.com/users/cryptogarageinc/received_events","type":"Organization","site_admin":false},"repo":{"id":220403709,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA0MDM3MDk=","name":"cfd","full_name":"cryptogarageinc/cfd","private":false,"owner":{"login":"cryptogarageinc","id":43569601,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTY5NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/43569601?v=4","gravatar_id":"","url":"https://api.github.com/users/cryptogarageinc","html_url":"https://github.com/cryptogarageinc","followers_url":"https://api.github.com/users/cryptogarageinc/followers","following_url":"https://api.github.com/users/cryptogarageinc/following{/other_user}","gists_url":"https://api.github.com/users/cryptogarageinc/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptogarageinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptogarageinc/subscriptions","organizations_url":"https://api.github.com/users/cryptogarageinc/orgs","repos_url":"https://api.github.com/users/cryptogarageinc/repos","events_url":"https://api.github.com/users/cryptogarageinc/events{/privacy}","received_events_url":"https://api.github.com/users/cryptogarageinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cryptogarageinc/cfd","description":"Crypto Finance Development Kit","fork":true,"url":"https://api.github.com/repos/cryptogarageinc/cfd","forks_url":"https://api.github.com/repos/cryptogarageinc/cfd/forks","keys_url":"https://api.github.com/repos/cryptogarageinc/cfd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cryptogarageinc/cfd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cryptogarageinc/cfd/teams","hooks_url":"https://api.github.com/repos/cryptogarageinc/cfd/hooks","issue_events_url":"https://api.github.com/repos/cryptogarageinc/cfd/issues/events{/number}","events_url":"https://api.github.com/repos/cryptogarageinc/cfd/events","assignees_url":"https://api.github.com/repos/cryptogarageinc/cfd/assignees{/user}","branches_url":"https://api.github.com/repos/cryptogarageinc/cfd/branches{/branch}","tags_url":"https://api.github.com/repos/cryptogarageinc/cfd/tags","blobs_url":"https://api.github.com/repos/cryptogarageinc/cfd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cryptogarageinc/cfd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cryptogarageinc/cfd/git/refs{/sha}","trees_url":"https://api.github.com/repos/cryptogarageinc/cfd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cryptogarageinc/cfd/statuses/{sha}","languages_url":"https://api.github.com/repos/cryptogarageinc/cfd/languages","stargazers_url":"https://api.github.com/repos/cryptogarageinc/cfd/stargazers","contributors_url":"https://api.github.com/repos/cryptogarageinc/cfd/contributors","subscribers_url":"https://api.github.com/repos/cryptogarageinc/cfd/subscribers","subscription_url":"https://api.github.com/repos/cryptogarageinc/cfd/subscription","commits_url":"https://api.github.com/repos/cryptogarageinc/cfd/commits{/sha}","git_commits_url":"https://api.github.com/repos/cryptogarageinc/cfd/git/commits{/sha}","comments_url":"https://api.github.com/repos/cryptogarageinc/cfd/comments{/number}","issue_comment_url":"https://api.github.com/repos/cryptogarageinc/cfd/issues/comments{/number}","contents_url":"https://api.github.com/repos/cryptogarageinc/cfd/contents/{+path}","compare_url":"https://api.github.com/repos/cryptogarageinc/cfd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cryptogarageinc/cfd/merges","archive_url":"https://api.github.com/repos/cryptogarageinc/cfd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cryptogarageinc/cfd/downloads","issues_url":"https://api.github.com/repos/cryptogarageinc/cfd/issues{/number}","pulls_url":"https://api.github.com/repos/cryptogarageinc/cfd/pulls{/number}","milestones_url":"https://api.github.com/repos/cryptogarageinc/cfd/milestones{/number}","notifications_url":"https://api.github.com/repos/cryptogarageinc/cfd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cryptogarageinc/cfd/labels{/name}","releases_url":"https://api.github.com/repos/cryptogarageinc/cfd/releases{/id}","deployments_url":"https://api.github.com/repos/cryptogarageinc/cfd/deployments","created_at":"2019-11-08T06:43:12Z","updated_at":"2020-01-14T01:19:17Z","pushed_at":"2020-01-14T01:59:04Z","git_url":"git://github.com/cryptogarageinc/cfd.git","ssh_url":"git@github.com:cryptogarageinc/cfd.git","clone_url":"https://github.com/cryptogarageinc/cfd.git","svn_url":"https://github.com/cryptogarageinc/cfd","homepage":null,"size":770,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cryptogarageinc:features/sprint36","ref":"features/sprint36","sha":"f4c5dc53c3f0f570b6658a5dd6994a076f4090bb","user":{"login":"cryptogarageinc","id":43569601,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTY5NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/43569601?v=4","gravatar_id":"","url":"https://api.github.com/users/cryptogarageinc","html_url":"https://github.com/cryptogarageinc","followers_url":"https://api.github.com/users/cryptogarageinc/followers","following_url":"https://api.github.com/users/cryptogarageinc/following{/other_user}","gists_url":"https://api.github.com/users/cryptogarageinc/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptogarageinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptogarageinc/subscriptions","organizations_url":"https://api.github.com/users/cryptogarageinc/orgs","repos_url":"https://api.github.com/users/cryptogarageinc/repos","events_url":"https://api.github.com/users/cryptogarageinc/events{/privacy}","received_events_url":"https://api.github.com/users/cryptogarageinc/received_events","type":"Organization","site_admin":false},"repo":{"id":220403709,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA0MDM3MDk=","name":"cfd","full_name":"cryptogarageinc/cfd","private":false,"owner":{"login":"cryptogarageinc","id":43569601,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTY5NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/43569601?v=4","gravatar_id":"","url":"https://api.github.com/users/cryptogarageinc","html_url":"https://github.com/cryptogarageinc","followers_url":"https://api.github.com/users/cryptogarageinc/followers","following_url":"https://api.github.com/users/cryptogarageinc/following{/other_user}","gists_url":"https://api.github.com/users/cryptogarageinc/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptogarageinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptogarageinc/subscriptions","organizations_url":"https://api.github.com/users/cryptogarageinc/orgs","repos_url":"https://api.github.com/users/cryptogarageinc/repos","events_url":"https://api.github.com/users/cryptogarageinc/events{/privacy}","received_events_url":"https://api.github.com/users/cryptogarageinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cryptogarageinc/cfd","description":"Crypto Finance Development Kit","fork":true,"url":"https://api.github.com/repos/cryptogarageinc/cfd","forks_url":"https://api.github.com/repos/cryptogarageinc/cfd/forks","keys_url":"https://api.github.com/repos/cryptogarageinc/cfd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cryptogarageinc/cfd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cryptogarageinc/cfd/teams","hooks_url":"https://api.github.com/repos/cryptogarageinc/cfd/hooks","issue_events_url":"https://api.github.com/repos/cryptogarageinc/cfd/issues/events{/number}","events_url":"https://api.github.com/repos/cryptogarageinc/cfd/events","assignees_url":"https://api.github.com/repos/cryptogarageinc/cfd/assignees{/user}","branches_url":"https://api.github.com/repos/cryptogarageinc/cfd/branches{/branch}","tags_url":"https://api.github.com/repos/cryptogarageinc/cfd/tags","blobs_url":"https://api.github.com/repos/cryptogarageinc/cfd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cryptogarageinc/cfd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cryptogarageinc/cfd/git/refs{/sha}","trees_url":"https://api.github.com/repos/cryptogarageinc/cfd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cryptogarageinc/cfd/statuses/{sha}","languages_url":"https://api.github.com/repos/cryptogarageinc/cfd/languages","stargazers_url":"https://api.github.com/repos/cryptogarageinc/cfd/stargazers","contributors_url":"https://api.github.com/repos/cryptogarageinc/cfd/contributors","subscribers_url":"https://api.github.com/repos/cryptogarageinc/cfd/subscribers","subscription_url":"https://api.github.com/repos/cryptogarageinc/cfd/subscription","commits_url":"https://api.github.com/repos/cryptogarageinc/cfd/commits{/sha}","git_commits_url":"https://api.github.com/repos/cryptogarageinc/cfd/git/commits{/sha}","comments_url":"https://api.github.com/repos/cryptogarageinc/cfd/comments{/number}","issue_comment_url":"https://api.github.com/repos/cryptogarageinc/cfd/issues/comments{/number}","contents_url":"https://api.github.com/repos/cryptogarageinc/cfd/contents/{+path}","compare_url":"https://api.github.com/repos/cryptogarageinc/cfd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cryptogarageinc/cfd/merges","archive_url":"https://api.github.com/repos/cryptogarageinc/cfd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cryptogarageinc/cfd/downloads","issues_url":"https://api.github.com/repos/cryptogarageinc/cfd/issues{/number}","pulls_url":"https://api.github.com/repos/cryptogarageinc/cfd/pulls{/number}","milestones_url":"https://api.github.com/repos/cryptogarageinc/cfd/milestones{/number}","notifications_url":"https://api.github.com/repos/cryptogarageinc/cfd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cryptogarageinc/cfd/labels{/name}","releases_url":"https://api.github.com/repos/cryptogarageinc/cfd/releases{/id}","deployments_url":"https://api.github.com/repos/cryptogarageinc/cfd/deployments","created_at":"2019-11-08T06:43:12Z","updated_at":"2020-01-14T01:19:17Z","pushed_at":"2020-01-14T01:59:04Z","git_url":"git://github.com/cryptogarageinc/cfd.git","ssh_url":"git@github.com:cryptogarageinc/cfd.git","clone_url":"https://github.com/cryptogarageinc/cfd.git","svn_url":"https://github.com/cryptogarageinc/cfd","homepage":null,"size":770,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cryptogarageinc/cfd/pulls/54"},"html":{"href":"https://github.com/cryptogarageinc/cfd/pull/54"},"issue":{"href":"https://api.github.com/repos/cryptogarageinc/cfd/issues/54"},"comments":{"href":"https://api.github.com/repos/cryptogarageinc/cfd/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/cryptogarageinc/cfd/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/cryptogarageinc/cfd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cryptogarageinc/cfd/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/cryptogarageinc/cfd/statuses/c012f7159239bfb7688286632b2e9b8d30c8e9c2"}},"author_association":"COLLABORATOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"k-matsuzawa"}}