{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/295510764","pull_request_review_id":251949339,"id":295510764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTUxMDc2NA==","diff_hunk":"@@ -426,9 +426,28 @@ func (c *Cluster) startDeployments(mons []*monConfig, requireAllInQuorum bool) e\n \t\tif err != nil {\n \t\t\treturn fmt.Errorf(\"failed to create mon %s. %+v\", mons[i].DaemonName, err)\n \t\t}\n+\t\t// For the initial deployment (first creation) it's expected to not have all the monitors in quorum\n+\t\t// However, in an event of an update, it's crucial to proceed monitors by monitors\n+\t\t// At the end of the method we perform one last check where all the monitors must be in quorum\n+\t\trequireAllInQuorum := false\n+\t\terr = c.waitForMonsToJoin(mons, requireAllInQuorum)","path":"pkg/operator/ceph/cluster/mon/mon.go","position":8,"original_position":8,"commit_id":"eba06a6ec9df6ad78e35b69a0c3fd77c385215de","original_commit_id":"eba06a6ec9df6ad78e35b69a0c3fd77c385215de","user":{"login":"travisn","id":1048514,"node_id":"MDQ6VXNlcjEwNDg1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1048514?v=4","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"body":"Per our conversation, if the ok-to-stop check for mons is sufficient, we don't need the changes in this method to wait for quorum. If we change the logging to debug for some of those messages, would that be sufficient for the logging concern? This extra wait for quorum would still be good to avoid. Our mon handling is already complex enough, I don't want to add it if it's not necessary.","created_at":"2019-06-19T20:31:37Z","updated_at":"2019-06-19T20:32:45Z","html_url":"https://github.com/rook/rook/pull/2901#discussion_r295510764","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/2901","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/295510764"},"html":{"href":"https://github.com/rook/rook/pull/2901#discussion_r295510764"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/2901"}}},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/2901","id":264906614,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0OTA2NjE0","html_url":"https://github.com/rook/rook/pull/2901","diff_url":"https://github.com/rook/rook/pull/2901.diff","patch_url":"https://github.com/rook/rook/pull/2901.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/2901","number":2901,"state":"open","locked":false,"title":"ceph: improve upgrade procedure","user":{"login":"leseb","id":912735,"node_id":"MDQ6VXNlcjkxMjczNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/912735?v=4","gravatar_id":"","url":"https://api.github.com/users/leseb","html_url":"https://github.com/leseb","followers_url":"https://api.github.com/users/leseb/followers","following_url":"https://api.github.com/users/leseb/following{/other_user}","gists_url":"https://api.github.com/users/leseb/gists{/gist_id}","starred_url":"https://api.github.com/users/leseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leseb/subscriptions","organizations_url":"https://api.github.com/users/leseb/orgs","repos_url":"https://api.github.com/users/leseb/repos","events_url":"https://api.github.com/users/leseb/events{/privacy}","received_events_url":"https://api.github.com/users/leseb/received_events","type":"User","site_admin":false},"body":"**Description of your changes:**\r\n\r\nWhen a cluster is updated with a different image version, this triggers\r\na serialized restart of all the pods. Prior to this commit, no safety\r\ncheck were performed and rook was hoping for the best outcome.\r\n\r\nNow before doing restarting a daemon we check it can be restarted. Once\r\nit's restarted we also check we can pursue with the rest of the\r\nplatform. For instance, with monitors we check that they are in quorum,\r\nfor OSD we check that PGs are clean and for MDS we make sure they are\r\n  active.\r\n\r\nFixes: https://github.com/rook/rook/issues/2889\r\nSigned-off-by: Sébastien Han <seb@redhat.com>\r\n\r\n**Which issue is resolved by this Pull Request:**\r\nResolves  https://github.com/rook/rook/issues/2889\r\n\r\n**Checklist:**\r\n- [ ] Documentation has been updated, if necessary.\r\n- [ ] Pending release notes updated with breaking and/or notable changes, if necessary.\r\n- [ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.\r\n- [ ] Code generation (`make codegen`) has been run to update object specifications, if necessary.\r\n- [ ] Comments have been added or updated based on the standards set in [CONTRIBUTING.md](../blob/master/CONTRIBUTING.md#comments)","created_at":"2019-03-27T12:35:23Z","updated_at":"2019-06-19T20:32:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5345da9c403a6ba79f5e031444d707976a7e7e83","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BlaineEXE","id":3989526,"node_id":"MDQ6VXNlcjM5ODk1MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/3989526?v=4","gravatar_id":"","url":"https://api.github.com/users/BlaineEXE","html_url":"https://github.com/BlaineEXE","followers_url":"https://api.github.com/users/BlaineEXE/followers","following_url":"https://api.github.com/users/BlaineEXE/following{/other_user}","gists_url":"https://api.github.com/users/BlaineEXE/gists{/gist_id}","starred_url":"https://api.github.com/users/BlaineEXE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlaineEXE/subscriptions","organizations_url":"https://api.github.com/users/BlaineEXE/orgs","repos_url":"https://api.github.com/users/BlaineEXE/repos","events_url":"https://api.github.com/users/BlaineEXE/events{/privacy}","received_events_url":"https://api.github.com/users/BlaineEXE/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":479456042,"node_id":"MDU6TGFiZWw0Nzk0NTYwNDI=","url":"https://api.github.com/repos/rook/rook/labels/ceph","name":"ceph","color":"ef5c55","default":false},{"id":908652856,"node_id":"MDU6TGFiZWw5MDg2NTI4NTY=","url":"https://api.github.com/repos/rook/rook/labels/upgrade","name":"upgrade","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/rook/rook/milestones/12","html_url":"https://github.com/rook/rook/milestone/12","labels_url":"https://api.github.com/repos/rook/rook/milestones/12/labels","id":4144795,"node_id":"MDk6TWlsZXN0b25lNDE0NDc5NQ==","number":12,"title":"1.1","description":"","creator":{"login":"BlaineEXE","id":3989526,"node_id":"MDQ6VXNlcjM5ODk1MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/3989526?v=4","gravatar_id":"","url":"https://api.github.com/users/BlaineEXE","html_url":"https://github.com/BlaineEXE","followers_url":"https://api.github.com/users/BlaineEXE/followers","following_url":"https://api.github.com/users/BlaineEXE/following{/other_user}","gists_url":"https://api.github.com/users/BlaineEXE/gists{/gist_id}","starred_url":"https://api.github.com/users/BlaineEXE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlaineEXE/subscriptions","organizations_url":"https://api.github.com/users/BlaineEXE/orgs","repos_url":"https://api.github.com/users/BlaineEXE/repos","events_url":"https://api.github.com/users/BlaineEXE/events{/privacy}","received_events_url":"https://api.github.com/users/BlaineEXE/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":6,"state":"open","created_at":"2019-03-15T19:30:30Z","updated_at":"2019-06-18T16:09:54Z","due_on":"2019-08-16T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/rook/rook/pulls/2901/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/2901/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/2901/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/eba06a6ec9df6ad78e35b69a0c3fd77c385215de","head":{"label":"leseb:improve-upgrade","ref":"improve-upgrade","sha":"eba06a6ec9df6ad78e35b69a0c3fd77c385215de","user":{"login":"leseb","id":912735,"node_id":"MDQ6VXNlcjkxMjczNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/912735?v=4","gravatar_id":"","url":"https://api.github.com/users/leseb","html_url":"https://github.com/leseb","followers_url":"https://api.github.com/users/leseb/followers","following_url":"https://api.github.com/users/leseb/following{/other_user}","gists_url":"https://api.github.com/users/leseb/gists{/gist_id}","starred_url":"https://api.github.com/users/leseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leseb/subscriptions","organizations_url":"https://api.github.com/users/leseb/orgs","repos_url":"https://api.github.com/users/leseb/repos","events_url":"https://api.github.com/users/leseb/events{/privacy}","received_events_url":"https://api.github.com/users/leseb/received_events","type":"User","site_admin":false},"repo":{"id":114090629,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQwOTA2Mjk=","name":"rook","full_name":"leseb/rook","private":false,"owner":{"login":"leseb","id":912735,"node_id":"MDQ6VXNlcjkxMjczNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/912735?v=4","gravatar_id":"","url":"https://api.github.com/users/leseb","html_url":"https://github.com/leseb","followers_url":"https://api.github.com/users/leseb/followers","following_url":"https://api.github.com/users/leseb/following{/other_user}","gists_url":"https://api.github.com/users/leseb/gists{/gist_id}","starred_url":"https://api.github.com/users/leseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leseb/subscriptions","organizations_url":"https://api.github.com/users/leseb/orgs","repos_url":"https://api.github.com/users/leseb/repos","events_url":"https://api.github.com/users/leseb/events{/privacy}","received_events_url":"https://api.github.com/users/leseb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/leseb/rook","description":"File, Block, and Object Storage Services for your Cloud-Native Environment","fork":true,"url":"https://api.github.com/repos/leseb/rook","forks_url":"https://api.github.com/repos/leseb/rook/forks","keys_url":"https://api.github.com/repos/leseb/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leseb/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leseb/rook/teams","hooks_url":"https://api.github.com/repos/leseb/rook/hooks","issue_events_url":"https://api.github.com/repos/leseb/rook/issues/events{/number}","events_url":"https://api.github.com/repos/leseb/rook/events","assignees_url":"https://api.github.com/repos/leseb/rook/assignees{/user}","branches_url":"https://api.github.com/repos/leseb/rook/branches{/branch}","tags_url":"https://api.github.com/repos/leseb/rook/tags","blobs_url":"https://api.github.com/repos/leseb/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leseb/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leseb/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/leseb/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leseb/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/leseb/rook/languages","stargazers_url":"https://api.github.com/repos/leseb/rook/stargazers","contributors_url":"https://api.github.com/repos/leseb/rook/contributors","subscribers_url":"https://api.github.com/repos/leseb/rook/subscribers","subscription_url":"https://api.github.com/repos/leseb/rook/subscription","commits_url":"https://api.github.com/repos/leseb/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/leseb/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/leseb/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/leseb/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/leseb/rook/contents/{+path}","compare_url":"https://api.github.com/repos/leseb/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leseb/rook/merges","archive_url":"https://api.github.com/repos/leseb/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leseb/rook/downloads","issues_url":"https://api.github.com/repos/leseb/rook/issues{/number}","pulls_url":"https://api.github.com/repos/leseb/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/leseb/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/leseb/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leseb/rook/labels{/name}","releases_url":"https://api.github.com/repos/leseb/rook/releases{/id}","deployments_url":"https://api.github.com/repos/leseb/rook/deployments","created_at":"2017-12-13T07:50:05Z","updated_at":"2018-10-12T11:13:49Z","pushed_at":"2019-06-19T15:47:17Z","git_url":"git://github.com/leseb/rook.git","ssh_url":"git@github.com:leseb/rook.git","clone_url":"https://github.com/leseb/rook.git","svn_url":"https://github.com/leseb/rook","homepage":"https://rook.io","size":10775,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"818ad9c7ca4d352a9bed202e619d47b05f1a4dab","user":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"node_id":"MDEwOlJlcG9zaXRvcnk2MjkyMTU1Mw==","name":"rook","full_name":"rook/rook","private":false,"owner":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rook/rook","description":"Storage Orchestration for Kubernetes","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2019-06-19T18:15:11Z","pushed_at":"2019-06-19T18:02:42Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":10858,"stargazers_count":5408,"watchers_count":5408,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":854,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":336,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":854,"open_issues":336,"watchers":5408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/2901"},"html":{"href":"https://github.com/rook/rook/pull/2901"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/2901"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/2901/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/2901/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/2901/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/eba06a6ec9df6ad78e35b69a0c3fd77c385215de"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"travisn"}}