{"action":"created","issue":{"url":"https://api.github.com/repos/bcoin-org/bcoin/issues/723","repository_url":"https://api.github.com/repos/bcoin-org/bcoin","labels_url":"https://api.github.com/repos/bcoin-org/bcoin/issues/723/labels{/name}","comments_url":"https://api.github.com/repos/bcoin-org/bcoin/issues/723/comments","events_url":"https://api.github.com/repos/bcoin-org/bcoin/issues/723/events","html_url":"https://github.com/bcoin-org/bcoin/issues/723","id":420156137,"node_id":"MDU6SXNzdWU0MjAxNTYxMzc=","number":723,"title":"Configuration of node plugin options","user":{"login":"braydonf","id":544777,"node_id":"MDQ6VXNlcjU0NDc3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/544777?v=4","gravatar_id":"","url":"https://api.github.com/users/braydonf","html_url":"https://github.com/braydonf","followers_url":"https://api.github.com/users/braydonf/followers","following_url":"https://api.github.com/users/braydonf/following{/other_user}","gists_url":"https://api.github.com/users/braydonf/gists{/gist_id}","starred_url":"https://api.github.com/users/braydonf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braydonf/subscriptions","organizations_url":"https://api.github.com/users/braydonf/orgs","repos_url":"https://api.github.com/users/braydonf/repos","events_url":"https://api.github.com/users/braydonf/events{/privacy}","received_events_url":"https://api.github.com/users/braydonf/received_events","type":"User","site_admin":false},"labels":[{"id":1270150112,"node_id":"MDU6TGFiZWwxMjcwMTUwMTEy","url":"https://api.github.com/repos/bcoin-org/bcoin/labels/config","name":"config","color":"0000ff","default":false},{"id":1211923112,"node_id":"MDU6TGFiZWwxMjExOTIzMTEy","url":"https://api.github.com/repos/bcoin-org/bcoin/labels/wallet","name":"wallet","color":"0000ff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-03-12T19:02:32Z","updated_at":"2019-04-02T19:38:54Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Versions**\r\nbcoin v1.0.2\r\n\r\n**Expected**\r\n\r\nAbility to configure plugin options without `env` work around for the name space to be recognized.\r\n\r\n**Actual**\r\n\r\nIt's necessary to use:\r\n\r\n```js\r\nconst node = new FullNode({\r\n  plugins: [require('../../lib/wallet/plugin')],\r\n  env: {\r\n    'BCOIN_WALLET_HTTP_PORT': '49333'\r\n  }\r\n});\r\n```\r\n\r\n**Option A**\r\n\r\n```js\r\nconst node = new FullNode({\r\n  plugins: [require('../../lib/wallet/plugin')({\r\n    httpPort: 49333\r\n  })]\r\n});\r\n```\r\nPass the options directly to the plugin before it's given to the full node.\r\n\r\n**Option B**\r\n\r\n```js\r\nconst node = new FullNode({\r\n  plugins: [require('../lib/wallet/plugin')],\r\n  pluginOptions: {\r\n    walletHTTPPort: 49333\r\n  }\r\n});\r\n```\r\nProvide a specific key that handles all plugin options that would handle the plugin namespace prefixes, as described in https://github.com/bcoin-org/bcoin/pull/562\r\n\r\n**Option C**\r\n\r\n```js\r\nconst node = new FullNode({\r\n  plugins: [require('../lib/wallet/plugin')],\r\n  walletHTTPPort: 49333\r\n});\r\n```\r\n\r\nHave all of the full node options parsed to handle the plugin prefixes, for example anything that starts with `wallet` would be recognized as a wallet option."},"comment":{"url":"https://api.github.com/repos/bcoin-org/bcoin/issues/comments/479165382","html_url":"https://github.com/bcoin-org/bcoin/issues/723#issuecomment-479165382","issue_url":"https://api.github.com/repos/bcoin-org/bcoin/issues/723","id":479165382,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3OTE2NTM4Mg==","user":{"login":"braydonf","id":544777,"node_id":"MDQ6VXNlcjU0NDc3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/544777?v=4","gravatar_id":"","url":"https://api.github.com/users/braydonf","html_url":"https://github.com/braydonf","followers_url":"https://api.github.com/users/braydonf/followers","following_url":"https://api.github.com/users/braydonf/following{/other_user}","gists_url":"https://api.github.com/users/braydonf/gists{/gist_id}","starred_url":"https://api.github.com/users/braydonf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braydonf/subscriptions","organizations_url":"https://api.github.com/users/braydonf/orgs","repos_url":"https://api.github.com/users/braydonf/repos","events_url":"https://api.github.com/users/braydonf/events{/privacy}","received_events_url":"https://api.github.com/users/braydonf/received_events","type":"User","site_admin":false},"created_at":"2019-04-02T19:38:54Z","updated_at":"2019-04-02T19:38:54Z","author_association":"CONTRIBUTOR","body":"I think there are also several issues with plugins in general that make them not very usable in practice.\r\n\r\nIn regards to the wallet, it may be preferrable to consider it a seperate process and application as the default in regards to configuration, as that is how it's handled with a seperate configuration file."}}
{"actor":{"display_login":"braydonf"}}