{"action":"opened","number":51,"pull_request":{"url":"https://api.github.com/repos/mojaloop/simulator/pulls/51","id":312323693,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyMzIzNjkz","html_url":"https://github.com/mojaloop/simulator/pull/51","diff_url":"https://github.com/mojaloop/simulator/pull/51.diff","patch_url":"https://github.com/mojaloop/simulator/pull/51.patch","issue_url":"https://api.github.com/repos/mojaloop/simulator/issues/51","number":51,"state":"open","locked":false,"title":"Ensure no 'Accept' header is sent in 'PUT' requests, as per mojaloop specification","user":{"login":"oderayi","id":2910495,"node_id":"MDQ6VXNlcjI5MTA0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2910495?v=4","gravatar_id":"","url":"https://api.github.com/users/oderayi","html_url":"https://github.com/oderayi","followers_url":"https://api.github.com/users/oderayi/followers","following_url":"https://api.github.com/users/oderayi/following{/other_user}","gists_url":"https://api.github.com/users/oderayi/gists{/gist_id}","starred_url":"https://api.github.com/users/oderayi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oderayi/subscriptions","organizations_url":"https://api.github.com/users/oderayi/orgs","repos_url":"https://api.github.com/users/oderayi/repos","events_url":"https://api.github.com/users/oderayi/events{/privacy}","received_events_url":"https://api.github.com/users/oderayi/received_events","type":"User","site_admin":false},"body":"This PR ensures that no 'Accept' header is sent in `PUT` requests, in compliance with the Mojaloop specification.\r\nTo achieve this:\r\n- `node-fetch` had to be replaced with `axios` because there are no ways to prevent `node-fetch` from send the `Accept` header.\r\n- `acceptheaderpayeefsp` was added to simulate a FSP that sends the unwanted `Accept` header, for 'negative' testing. Any request to this FSP that requires a 'PUT' callback should fail.\r\n ","created_at":"2019-08-29T13:38:44Z","updated_at":"2019-08-29T13:38:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"lewisdaly","id":1683980,"node_id":"MDQ6VXNlcjE2ODM5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1683980?v=4","gravatar_id":"","url":"https://api.github.com/users/lewisdaly","html_url":"https://github.com/lewisdaly","followers_url":"https://api.github.com/users/lewisdaly/followers","following_url":"https://api.github.com/users/lewisdaly/following{/other_user}","gists_url":"https://api.github.com/users/lewisdaly/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisdaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisdaly/subscriptions","organizations_url":"https://api.github.com/users/lewisdaly/orgs","repos_url":"https://api.github.com/users/lewisdaly/repos","events_url":"https://api.github.com/users/lewisdaly/events{/privacy}","received_events_url":"https://api.github.com/users/lewisdaly/received_events","type":"User","site_admin":false},{"login":"vgenev","id":5424739,"node_id":"MDQ6VXNlcjU0MjQ3Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/5424739?v=4","gravatar_id":"","url":"https://api.github.com/users/vgenev","html_url":"https://github.com/vgenev","followers_url":"https://api.github.com/users/vgenev/followers","following_url":"https://api.github.com/users/vgenev/following{/other_user}","gists_url":"https://api.github.com/users/vgenev/gists{/gist_id}","starred_url":"https://api.github.com/users/vgenev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgenev/subscriptions","organizations_url":"https://api.github.com/users/vgenev/orgs","repos_url":"https://api.github.com/users/vgenev/repos","events_url":"https://api.github.com/users/vgenev/events{/privacy}","received_events_url":"https://api.github.com/users/vgenev/received_events","type":"User","site_admin":false},{"login":"NicoDuvenage","id":9287623,"node_id":"MDQ6VXNlcjkyODc2MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/9287623?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoDuvenage","html_url":"https://github.com/NicoDuvenage","followers_url":"https://api.github.com/users/NicoDuvenage/followers","following_url":"https://api.github.com/users/NicoDuvenage/following{/other_user}","gists_url":"https://api.github.com/users/NicoDuvenage/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoDuvenage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoDuvenage/subscriptions","organizations_url":"https://api.github.com/users/NicoDuvenage/orgs","repos_url":"https://api.github.com/users/NicoDuvenage/repos","events_url":"https://api.github.com/users/NicoDuvenage/events{/privacy}","received_events_url":"https://api.github.com/users/NicoDuvenage/received_events","type":"User","site_admin":false},{"login":"elnyry","id":10507686,"node_id":"MDQ6VXNlcjEwNTA3Njg2","avatar_url":"https://avatars1.githubusercontent.com/u/10507686?v=4","gravatar_id":"","url":"https://api.github.com/users/elnyry","html_url":"https://github.com/elnyry","followers_url":"https://api.github.com/users/elnyry/followers","following_url":"https://api.github.com/users/elnyry/following{/other_user}","gists_url":"https://api.github.com/users/elnyry/gists{/gist_id}","starred_url":"https://api.github.com/users/elnyry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elnyry/subscriptions","organizations_url":"https://api.github.com/users/elnyry/orgs","repos_url":"https://api.github.com/users/elnyry/repos","events_url":"https://api.github.com/users/elnyry/events{/privacy}","received_events_url":"https://api.github.com/users/elnyry/received_events","type":"User","site_admin":false},{"login":"mdebarros","id":11392873,"node_id":"MDQ6VXNlcjExMzkyODcz","avatar_url":"https://avatars1.githubusercontent.com/u/11392873?v=4","gravatar_id":"","url":"https://api.github.com/users/mdebarros","html_url":"https://github.com/mdebarros","followers_url":"https://api.github.com/users/mdebarros/followers","following_url":"https://api.github.com/users/mdebarros/following{/other_user}","gists_url":"https://api.github.com/users/mdebarros/gists{/gist_id}","starred_url":"https://api.github.com/users/mdebarros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdebarros/subscriptions","organizations_url":"https://api.github.com/users/mdebarros/orgs","repos_url":"https://api.github.com/users/mdebarros/repos","events_url":"https://api.github.com/users/mdebarros/events{/privacy}","received_events_url":"https://api.github.com/users/mdebarros/received_events","type":"User","site_admin":false},{"login":"rmothilal","id":16662558,"node_id":"MDQ6VXNlcjE2NjYyNTU4","avatar_url":"https://avatars1.githubusercontent.com/u/16662558?v=4","gravatar_id":"","url":"https://api.github.com/users/rmothilal","html_url":"https://github.com/rmothilal","followers_url":"https://api.github.com/users/rmothilal/followers","following_url":"https://api.github.com/users/rmothilal/following{/other_user}","gists_url":"https://api.github.com/users/rmothilal/gists{/gist_id}","starred_url":"https://api.github.com/users/rmothilal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmothilal/subscriptions","organizations_url":"https://api.github.com/users/rmothilal/orgs","repos_url":"https://api.github.com/users/rmothilal/repos","events_url":"https://api.github.com/users/rmothilal/events{/privacy}","received_events_url":"https://api.github.com/users/rmothilal/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mojaloop/simulator/pulls/51/commits","review_comments_url":"https://api.github.com/repos/mojaloop/simulator/pulls/51/comments","review_comment_url":"https://api.github.com/repos/mojaloop/simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mojaloop/simulator/issues/51/comments","statuses_url":"https://api.github.com/repos/mojaloop/simulator/statuses/1a963d59cd882fef4e913bd1c0c0fbfe7f882445","head":{"label":"oderayi:bugfix/remove-accept-header","ref":"bugfix/remove-accept-header","sha":"1a963d59cd882fef4e913bd1c0c0fbfe7f882445","user":{"login":"oderayi","id":2910495,"node_id":"MDQ6VXNlcjI5MTA0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2910495?v=4","gravatar_id":"","url":"https://api.github.com/users/oderayi","html_url":"https://github.com/oderayi","followers_url":"https://api.github.com/users/oderayi/followers","following_url":"https://api.github.com/users/oderayi/following{/other_user}","gists_url":"https://api.github.com/users/oderayi/gists{/gist_id}","starred_url":"https://api.github.com/users/oderayi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oderayi/subscriptions","organizations_url":"https://api.github.com/users/oderayi/orgs","repos_url":"https://api.github.com/users/oderayi/repos","events_url":"https://api.github.com/users/oderayi/events{/privacy}","received_events_url":"https://api.github.com/users/oderayi/received_events","type":"User","site_admin":false},"repo":{"id":204708345,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ3MDgzNDU=","name":"simulator","full_name":"oderayi/simulator","private":false,"owner":{"login":"oderayi","id":2910495,"node_id":"MDQ6VXNlcjI5MTA0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2910495?v=4","gravatar_id":"","url":"https://api.github.com/users/oderayi","html_url":"https://github.com/oderayi","followers_url":"https://api.github.com/users/oderayi/followers","following_url":"https://api.github.com/users/oderayi/following{/other_user}","gists_url":"https://api.github.com/users/oderayi/gists{/gist_id}","starred_url":"https://api.github.com/users/oderayi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oderayi/subscriptions","organizations_url":"https://api.github.com/users/oderayi/orgs","repos_url":"https://api.github.com/users/oderayi/repos","events_url":"https://api.github.com/users/oderayi/events{/privacy}","received_events_url":"https://api.github.com/users/oderayi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/oderayi/simulator","description":"FSP Simulator Implementation in Javascript","fork":true,"url":"https://api.github.com/repos/oderayi/simulator","forks_url":"https://api.github.com/repos/oderayi/simulator/forks","keys_url":"https://api.github.com/repos/oderayi/simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oderayi/simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oderayi/simulator/teams","hooks_url":"https://api.github.com/repos/oderayi/simulator/hooks","issue_events_url":"https://api.github.com/repos/oderayi/simulator/issues/events{/number}","events_url":"https://api.github.com/repos/oderayi/simulator/events","assignees_url":"https://api.github.com/repos/oderayi/simulator/assignees{/user}","branches_url":"https://api.github.com/repos/oderayi/simulator/branches{/branch}","tags_url":"https://api.github.com/repos/oderayi/simulator/tags","blobs_url":"https://api.github.com/repos/oderayi/simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oderayi/simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oderayi/simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/oderayi/simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oderayi/simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/oderayi/simulator/languages","stargazers_url":"https://api.github.com/repos/oderayi/simulator/stargazers","contributors_url":"https://api.github.com/repos/oderayi/simulator/contributors","subscribers_url":"https://api.github.com/repos/oderayi/simulator/subscribers","subscription_url":"https://api.github.com/repos/oderayi/simulator/subscription","commits_url":"https://api.github.com/repos/oderayi/simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/oderayi/simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/oderayi/simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/oderayi/simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/oderayi/simulator/contents/{+path}","compare_url":"https://api.github.com/repos/oderayi/simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oderayi/simulator/merges","archive_url":"https://api.github.com/repos/oderayi/simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oderayi/simulator/downloads","issues_url":"https://api.github.com/repos/oderayi/simulator/issues{/number}","pulls_url":"https://api.github.com/repos/oderayi/simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/oderayi/simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/oderayi/simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oderayi/simulator/labels{/name}","releases_url":"https://api.github.com/repos/oderayi/simulator/releases{/id}","deployments_url":"https://api.github.com/repos/oderayi/simulator/deployments","created_at":"2019-08-27T13:22:55Z","updated_at":"2019-08-27T13:22:57Z","pushed_at":"2019-08-29T13:35:51Z","git_url":"git://github.com/oderayi/simulator.git","ssh_url":"git@github.com:oderayi/simulator.git","clone_url":"https://github.com/oderayi/simulator.git","svn_url":"https://github.com/oderayi/simulator","homepage":"","size":5237,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mojaloop:master","ref":"master","sha":"91853f1f6d083b6e550f5fa63bb67adf89570607","user":{"login":"mojaloop","id":32749554,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzQ5NTU0","avatar_url":"https://avatars3.githubusercontent.com/u/32749554?v=4","gravatar_id":"","url":"https://api.github.com/users/mojaloop","html_url":"https://github.com/mojaloop","followers_url":"https://api.github.com/users/mojaloop/followers","following_url":"https://api.github.com/users/mojaloop/following{/other_user}","gists_url":"https://api.github.com/users/mojaloop/gists{/gist_id}","starred_url":"https://api.github.com/users/mojaloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojaloop/subscriptions","organizations_url":"https://api.github.com/users/mojaloop/orgs","repos_url":"https://api.github.com/users/mojaloop/repos","events_url":"https://api.github.com/users/mojaloop/events{/privacy}","received_events_url":"https://api.github.com/users/mojaloop/received_events","type":"Organization","site_admin":false},"repo":{"id":157415934,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc0MTU5MzQ=","name":"simulator","full_name":"mojaloop/simulator","private":false,"owner":{"login":"mojaloop","id":32749554,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzQ5NTU0","avatar_url":"https://avatars3.githubusercontent.com/u/32749554?v=4","gravatar_id":"","url":"https://api.github.com/users/mojaloop","html_url":"https://github.com/mojaloop","followers_url":"https://api.github.com/users/mojaloop/followers","following_url":"https://api.github.com/users/mojaloop/following{/other_user}","gists_url":"https://api.github.com/users/mojaloop/gists{/gist_id}","starred_url":"https://api.github.com/users/mojaloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojaloop/subscriptions","organizations_url":"https://api.github.com/users/mojaloop/orgs","repos_url":"https://api.github.com/users/mojaloop/repos","events_url":"https://api.github.com/users/mojaloop/events{/privacy}","received_events_url":"https://api.github.com/users/mojaloop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mojaloop/simulator","description":"FSP Simulator Implementation in Javascript","fork":false,"url":"https://api.github.com/repos/mojaloop/simulator","forks_url":"https://api.github.com/repos/mojaloop/simulator/forks","keys_url":"https://api.github.com/repos/mojaloop/simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mojaloop/simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mojaloop/simulator/teams","hooks_url":"https://api.github.com/repos/mojaloop/simulator/hooks","issue_events_url":"https://api.github.com/repos/mojaloop/simulator/issues/events{/number}","events_url":"https://api.github.com/repos/mojaloop/simulator/events","assignees_url":"https://api.github.com/repos/mojaloop/simulator/assignees{/user}","branches_url":"https://api.github.com/repos/mojaloop/simulator/branches{/branch}","tags_url":"https://api.github.com/repos/mojaloop/simulator/tags","blobs_url":"https://api.github.com/repos/mojaloop/simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mojaloop/simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mojaloop/simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mojaloop/simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mojaloop/simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/mojaloop/simulator/languages","stargazers_url":"https://api.github.com/repos/mojaloop/simulator/stargazers","contributors_url":"https://api.github.com/repos/mojaloop/simulator/contributors","subscribers_url":"https://api.github.com/repos/mojaloop/simulator/subscribers","subscription_url":"https://api.github.com/repos/mojaloop/simulator/subscription","commits_url":"https://api.github.com/repos/mojaloop/simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mojaloop/simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mojaloop/simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mojaloop/simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mojaloop/simulator/contents/{+path}","compare_url":"https://api.github.com/repos/mojaloop/simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mojaloop/simulator/merges","archive_url":"https://api.github.com/repos/mojaloop/simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mojaloop/simulator/downloads","issues_url":"https://api.github.com/repos/mojaloop/simulator/issues{/number}","pulls_url":"https://api.github.com/repos/mojaloop/simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/mojaloop/simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/mojaloop/simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mojaloop/simulator/labels{/name}","releases_url":"https://api.github.com/repos/mojaloop/simulator/releases{/id}","deployments_url":"https://api.github.com/repos/mojaloop/simulator/deployments","created_at":"2018-11-13T17:02:40Z","updated_at":"2019-08-27T11:52:42Z","pushed_at":"2019-08-27T17:39:18Z","git_url":"git://github.com/mojaloop/simulator.git","ssh_url":"git@github.com:mojaloop/simulator.git","clone_url":"https://github.com/mojaloop/simulator.git","svn_url":"https://github.com/mojaloop/simulator","homepage":"","size":5233,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":null,"forks":16,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mojaloop/simulator/pulls/51"},"html":{"href":"https://github.com/mojaloop/simulator/pull/51"},"issue":{"href":"https://api.github.com/repos/mojaloop/simulator/issues/51"},"comments":{"href":"https://api.github.com/repos/mojaloop/simulator/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/mojaloop/simulator/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/mojaloop/simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mojaloop/simulator/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/mojaloop/simulator/statuses/1a963d59cd882fef4e913bd1c0c0fbfe7f882445"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":1029,"deletions":116,"changed_files":13}}
{"actor":{"display_login":"oderayi"}}