{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/54259","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/54259/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/54259/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/54259/events","html_url":"https://github.com/elastic/kibana/pull/54259","id":546895854,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYwNDg3MDAy","number":54259,"title":"Fix Vega react eslint errors","user":{"login":"timroes","id":877229,"node_id":"MDQ6VXNlcjg3NzIyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"labels":[{"id":823208271,"node_id":"MDU6TGFiZWw4MjMyMDgyNzE=","url":"https://api.github.com/repos/elastic/kibana/labels/Feature:Vega","name":"Feature:Vega","color":"0e8a16","default":false,"description":"Vega visualizations"},{"id":1055842724,"node_id":"MDU6TGFiZWwxMDU1ODQyNzI0","url":"https://api.github.com/repos/elastic/kibana/labels/Team:KibanaApp","name":"Team:KibanaApp","color":"fef2c0","default":false,"description":"Team label for Kibana App Team (only Discover, Visualize, Dashboard)"},{"id":1196522308,"node_id":"MDU6TGFiZWwxMTk2NTIyMzA4","url":"https://api.github.com/repos/elastic/kibana/labels/release_note:skip","name":"release_note:skip","color":"016589","default":false,"description":"Skip the PR/issue when compiling release notes"},{"id":1523756056,"node_id":"MDU6TGFiZWwxNTIzNzU2MDU2","url":"https://api.github.com/repos/elastic/kibana/labels/v7.6.0","name":"v7.6.0","color":"ffffff","default":false,"description":""},{"id":1124458249,"node_id":"MDU6TGFiZWwxMTI0NDU4MjQ5","url":"https://api.github.com/repos/elastic/kibana/labels/v8.0.0","name":"v8.0.0","color":"ffffff","default":false,"description":""}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2020-01-08T14:31:06Z","updated_at":"2020-01-08T14:31:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/54259","html_url":"https://github.com/elastic/kibana/pull/54259","diff_url":"https://github.com/elastic/kibana/pull/54259.diff","patch_url":"https://github.com/elastic/kibana/pull/54259.patch"},"body":"## Summary\r\n\r\nFix #49552\r\n\r\nDisable the eslint react exclusion for vega again and fix the remaining errors.\r\n\r\n`isPopoverOpen` isn't needed as a dependency for creating that callback, since we never access it anywhere inside. So the callback reference can stay the same, even in case the state would change, since we anyway only set it to false inside the callback.\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- ~[ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~\r\n- ~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~\r\n- ~[ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~\r\n- ~[ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~\r\n- ~[ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~\r\n\r\n### For maintainers\r\n\r\n- ~[ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~\r\n- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/572080357","html_url":"https://github.com/elastic/kibana/pull/54259#issuecomment-572080357","issue_url":"https://api.github.com/repos/elastic/kibana/issues/54259","id":572080357,"node_id":"MDEyOklzc3VlQ29tbWVudDU3MjA4MDM1Nw==","user":{"login":"elasticmachine","id":15837671,"node_id":"MDQ6VXNlcjE1ODM3Njcx","avatar_url":"https://avatars3.githubusercontent.com/u/15837671?v=4","gravatar_id":"","url":"https://api.github.com/users/elasticmachine","html_url":"https://github.com/elasticmachine","followers_url":"https://api.github.com/users/elasticmachine/followers","following_url":"https://api.github.com/users/elasticmachine/following{/other_user}","gists_url":"https://api.github.com/users/elasticmachine/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticmachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticmachine/subscriptions","organizations_url":"https://api.github.com/users/elasticmachine/orgs","repos_url":"https://api.github.com/users/elasticmachine/repos","events_url":"https://api.github.com/users/elasticmachine/events{/privacy}","received_events_url":"https://api.github.com/users/elasticmachine/received_events","type":"User","site_admin":false},"created_at":"2020-01-08T14:31:09Z","updated_at":"2020-01-08T14:31:09Z","author_association":"CONTRIBUTOR","body":"Pinging @elastic/kibana-app (Team:KibanaApp)"}}
{"actor":{"display_login":"elasticmachine"}}