{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/kingforaday/certmagic/pulls/6","id":258074446,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4MDc0NDQ2","html_url":"https://github.com/kingforaday/certmagic/pull/6","diff_url":"https://github.com/kingforaday/certmagic/pull/6.diff","patch_url":"https://github.com/kingforaday/certmagic/pull/6.patch","issue_url":"https://api.github.com/repos/kingforaday/certmagic/issues/6","number":6,"state":"closed","locked":false,"title":"Don't re-prompt for email if account already exists","user":{"login":"kingforaday","id":38838211,"node_id":"MDQ6VXNlcjM4ODM4MjEx","avatar_url":"https://avatars1.githubusercontent.com/u/38838211?v=4","gravatar_id":"","url":"https://api.github.com/users/kingforaday","html_url":"https://github.com/kingforaday","followers_url":"https://api.github.com/users/kingforaday/followers","following_url":"https://api.github.com/users/kingforaday/following{/other_user}","gists_url":"https://api.github.com/users/kingforaday/gists{/gist_id}","starred_url":"https://api.github.com/users/kingforaday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingforaday/subscriptions","organizations_url":"https://api.github.com/users/kingforaday/orgs","repos_url":"https://api.github.com/users/kingforaday/repos","events_url":"https://api.github.com/users/kingforaday/events{/privacy}","received_events_url":"https://api.github.com/users/kingforaday/received_events","type":"User","site_admin":false},"body":"Extracting CertMagic out of Caddy was a new and complicated surgery,\r\nand although successful, it wasn't without its side-effects. One of\r\nthem was we slightly altered some of the subtle logic related to\r\ngetting an email address in order to know which account to use.\r\n\r\nIf an ACME account with an empty email already exists, and no Email is\r\navailable on the config, that account should be used without prompting\r\nthe user over and over. If no account exists and no email is available,\r\nthen yes a prompt is warranted. And of course if an email is set or an\r\naccount with a non-empty email exists, that should be used without\r\nprompts (this was already the case).\r\n\r\nThis commit fixes to align with that expectation, so that accounts with\r\nempty emails can be reused, if present.\r\n\r\nEmpty emails should only be used in dev or testing environments;\r\nomitting them in production is bad practice.","created_at":"2019-03-04T20:13:21Z","updated_at":"2019-03-04T20:13:28Z","closed_at":"2019-03-04T20:13:28Z","merged_at":"2019-03-04T20:13:28Z","merge_commit_sha":"f6f8377838923821bd27326d6229b6d4b423c1ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kingforaday/certmagic/pulls/6/commits","review_comments_url":"https://api.github.com/repos/kingforaday/certmagic/pulls/6/comments","review_comment_url":"https://api.github.com/repos/kingforaday/certmagic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kingforaday/certmagic/issues/6/comments","statuses_url":"https://api.github.com/repos/kingforaday/certmagic/statuses/e3e89d1096d76d61680f8eeb8f67649baa6c54b8","head":{"label":"mholt:master","ref":"master","sha":"e3e89d1096d76d61680f8eeb8f67649baa6c54b8","user":{"login":"mholt","id":1128849,"node_id":"MDQ6VXNlcjExMjg4NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1128849?v=4","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"repo":{"id":161109499,"node_id":"MDEwOlJlcG9zaXRvcnkxNjExMDk0OTk=","name":"certmagic","full_name":"mholt/certmagic","private":false,"owner":{"login":"mholt","id":1128849,"node_id":"MDQ6VXNlcjExMjg4NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1128849?v=4","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mholt/certmagic","description":"Automatic HTTPS for any Go program: fully-managed TLS certificate issuance and renewal","fork":false,"url":"https://api.github.com/repos/mholt/certmagic","forks_url":"https://api.github.com/repos/mholt/certmagic/forks","keys_url":"https://api.github.com/repos/mholt/certmagic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mholt/certmagic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mholt/certmagic/teams","hooks_url":"https://api.github.com/repos/mholt/certmagic/hooks","issue_events_url":"https://api.github.com/repos/mholt/certmagic/issues/events{/number}","events_url":"https://api.github.com/repos/mholt/certmagic/events","assignees_url":"https://api.github.com/repos/mholt/certmagic/assignees{/user}","branches_url":"https://api.github.com/repos/mholt/certmagic/branches{/branch}","tags_url":"https://api.github.com/repos/mholt/certmagic/tags","blobs_url":"https://api.github.com/repos/mholt/certmagic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mholt/certmagic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mholt/certmagic/git/refs{/sha}","trees_url":"https://api.github.com/repos/mholt/certmagic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mholt/certmagic/statuses/{sha}","languages_url":"https://api.github.com/repos/mholt/certmagic/languages","stargazers_url":"https://api.github.com/repos/mholt/certmagic/stargazers","contributors_url":"https://api.github.com/repos/mholt/certmagic/contributors","subscribers_url":"https://api.github.com/repos/mholt/certmagic/subscribers","subscription_url":"https://api.github.com/repos/mholt/certmagic/subscription","commits_url":"https://api.github.com/repos/mholt/certmagic/commits{/sha}","git_commits_url":"https://api.github.com/repos/mholt/certmagic/git/commits{/sha}","comments_url":"https://api.github.com/repos/mholt/certmagic/comments{/number}","issue_comment_url":"https://api.github.com/repos/mholt/certmagic/issues/comments{/number}","contents_url":"https://api.github.com/repos/mholt/certmagic/contents/{+path}","compare_url":"https://api.github.com/repos/mholt/certmagic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mholt/certmagic/merges","archive_url":"https://api.github.com/repos/mholt/certmagic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mholt/certmagic/downloads","issues_url":"https://api.github.com/repos/mholt/certmagic/issues{/number}","pulls_url":"https://api.github.com/repos/mholt/certmagic/pulls{/number}","milestones_url":"https://api.github.com/repos/mholt/certmagic/milestones{/number}","notifications_url":"https://api.github.com/repos/mholt/certmagic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mholt/certmagic/labels{/name}","releases_url":"https://api.github.com/repos/mholt/certmagic/releases{/id}","deployments_url":"https://api.github.com/repos/mholt/certmagic/deployments","created_at":"2018-12-10T03:12:30Z","updated_at":"2019-03-04T09:11:21Z","pushed_at":"2019-03-01T15:51:29Z","git_url":"git://github.com/mholt/certmagic.git","ssh_url":"git@github.com:mholt/certmagic.git","clone_url":"https://github.com/mholt/certmagic.git","svn_url":"https://github.com/mholt/certmagic","homepage":"https://godoc.org/github.com/mholt/certmagic","size":175,"stargazers_count":1976,"watchers_count":1976,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":65,"open_issues":5,"watchers":1976,"default_branch":"master"}},"base":{"label":"kingforaday:master","ref":"master","sha":"282f1b346cda2bb7d5d93409b3cd7d9f6ffb4797","user":{"login":"kingforaday","id":38838211,"node_id":"MDQ6VXNlcjM4ODM4MjEx","avatar_url":"https://avatars1.githubusercontent.com/u/38838211?v=4","gravatar_id":"","url":"https://api.github.com/users/kingforaday","html_url":"https://github.com/kingforaday","followers_url":"https://api.github.com/users/kingforaday/followers","following_url":"https://api.github.com/users/kingforaday/following{/other_user}","gists_url":"https://api.github.com/users/kingforaday/gists{/gist_id}","starred_url":"https://api.github.com/users/kingforaday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingforaday/subscriptions","organizations_url":"https://api.github.com/users/kingforaday/orgs","repos_url":"https://api.github.com/users/kingforaday/repos","events_url":"https://api.github.com/users/kingforaday/events{/privacy}","received_events_url":"https://api.github.com/users/kingforaday/received_events","type":"User","site_admin":false},"repo":{"id":164870494,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ4NzA0OTQ=","name":"certmagic","full_name":"kingforaday/certmagic","private":false,"owner":{"login":"kingforaday","id":38838211,"node_id":"MDQ6VXNlcjM4ODM4MjEx","avatar_url":"https://avatars1.githubusercontent.com/u/38838211?v=4","gravatar_id":"","url":"https://api.github.com/users/kingforaday","html_url":"https://github.com/kingforaday","followers_url":"https://api.github.com/users/kingforaday/followers","following_url":"https://api.github.com/users/kingforaday/following{/other_user}","gists_url":"https://api.github.com/users/kingforaday/gists{/gist_id}","starred_url":"https://api.github.com/users/kingforaday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingforaday/subscriptions","organizations_url":"https://api.github.com/users/kingforaday/orgs","repos_url":"https://api.github.com/users/kingforaday/repos","events_url":"https://api.github.com/users/kingforaday/events{/privacy}","received_events_url":"https://api.github.com/users/kingforaday/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kingforaday/certmagic","description":"Automatic HTTPS for any Go program: fully-managed TLS certificate issuance and renewal","fork":true,"url":"https://api.github.com/repos/kingforaday/certmagic","forks_url":"https://api.github.com/repos/kingforaday/certmagic/forks","keys_url":"https://api.github.com/repos/kingforaday/certmagic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingforaday/certmagic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingforaday/certmagic/teams","hooks_url":"https://api.github.com/repos/kingforaday/certmagic/hooks","issue_events_url":"https://api.github.com/repos/kingforaday/certmagic/issues/events{/number}","events_url":"https://api.github.com/repos/kingforaday/certmagic/events","assignees_url":"https://api.github.com/repos/kingforaday/certmagic/assignees{/user}","branches_url":"https://api.github.com/repos/kingforaday/certmagic/branches{/branch}","tags_url":"https://api.github.com/repos/kingforaday/certmagic/tags","blobs_url":"https://api.github.com/repos/kingforaday/certmagic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingforaday/certmagic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingforaday/certmagic/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingforaday/certmagic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingforaday/certmagic/statuses/{sha}","languages_url":"https://api.github.com/repos/kingforaday/certmagic/languages","stargazers_url":"https://api.github.com/repos/kingforaday/certmagic/stargazers","contributors_url":"https://api.github.com/repos/kingforaday/certmagic/contributors","subscribers_url":"https://api.github.com/repos/kingforaday/certmagic/subscribers","subscription_url":"https://api.github.com/repos/kingforaday/certmagic/subscription","commits_url":"https://api.github.com/repos/kingforaday/certmagic/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingforaday/certmagic/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingforaday/certmagic/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingforaday/certmagic/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingforaday/certmagic/contents/{+path}","compare_url":"https://api.github.com/repos/kingforaday/certmagic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingforaday/certmagic/merges","archive_url":"https://api.github.com/repos/kingforaday/certmagic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingforaday/certmagic/downloads","issues_url":"https://api.github.com/repos/kingforaday/certmagic/issues{/number}","pulls_url":"https://api.github.com/repos/kingforaday/certmagic/pulls{/number}","milestones_url":"https://api.github.com/repos/kingforaday/certmagic/milestones{/number}","notifications_url":"https://api.github.com/repos/kingforaday/certmagic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingforaday/certmagic/labels{/name}","releases_url":"https://api.github.com/repos/kingforaday/certmagic/releases{/id}","deployments_url":"https://api.github.com/repos/kingforaday/certmagic/deployments","created_at":"2019-01-09T13:43:15Z","updated_at":"2019-02-11T03:42:42Z","pushed_at":"2019-03-04T20:13:28Z","git_url":"git://github.com/kingforaday/certmagic.git","ssh_url":"git@github.com:kingforaday/certmagic.git","clone_url":"https://github.com/kingforaday/certmagic.git","svn_url":"https://github.com/kingforaday/certmagic","homepage":"https://godoc.org/github.com/mholt/certmagic","size":173,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kingforaday/certmagic/pulls/6"},"html":{"href":"https://github.com/kingforaday/certmagic/pull/6"},"issue":{"href":"https://api.github.com/repos/kingforaday/certmagic/issues/6"},"comments":{"href":"https://api.github.com/repos/kingforaday/certmagic/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/kingforaday/certmagic/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/kingforaday/certmagic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kingforaday/certmagic/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/kingforaday/certmagic/statuses/e3e89d1096d76d61680f8eeb8f67649baa6c54b8"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kingforaday","id":38838211,"node_id":"MDQ6VXNlcjM4ODM4MjEx","avatar_url":"https://avatars1.githubusercontent.com/u/38838211?v=4","gravatar_id":"","url":"https://api.github.com/users/kingforaday","html_url":"https://github.com/kingforaday","followers_url":"https://api.github.com/users/kingforaday/followers","following_url":"https://api.github.com/users/kingforaday/following{/other_user}","gists_url":"https://api.github.com/users/kingforaday/gists{/gist_id}","starred_url":"https://api.github.com/users/kingforaday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingforaday/subscriptions","organizations_url":"https://api.github.com/users/kingforaday/orgs","repos_url":"https://api.github.com/users/kingforaday/repos","events_url":"https://api.github.com/users/kingforaday/events{/privacy}","received_events_url":"https://api.github.com/users/kingforaday/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":24,"deletions":15,"changed_files":3}}
{"actor":{"display_login":"kingforaday"}}