{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments/341648450","pull_request_review_id":310556390,"id":341648450,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTY0ODQ1MA==","diff_hunk":"@@ -164,7 +164,7 @@ public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateIfVersionIsInc\n             now = new DateTimeOffset(now.Year, now.Month, now.Day, now.Hour, now.Minute, now.Second, 0, now.Offset);\n             _manager.EnsureAspNetCoreHttpsDevelopmentCertificate(now, now.AddYears(1), path: null, trust: false, subject: TestCertificateSubject);\n \n-            CertificateManager.AspNetHttpsCertificateVersion = 2;\n+            CertificateManager.AspNetHttpsCertificateVersion = 3;","path":"src/Tools/FirstRunCertGenerator/test/CertificateManagerTests.cs","position":5,"original_position":5,"commit_id":"52f021436e02a9e515d1404893589fbed499b2a4","original_commit_id":"52f021436e02a9e515d1404893589fbed499b2a4","user":{"login":"jkotalik","id":8302101,"node_id":"MDQ6VXNlcjgzMDIxMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8302101?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotalik","html_url":"https://github.com/jkotalik","followers_url":"https://api.github.com/users/jkotalik/followers","following_url":"https://api.github.com/users/jkotalik/following{/other_user}","gists_url":"https://api.github.com/users/jkotalik/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotalik/subscriptions","organizations_url":"https://api.github.com/users/jkotalik/orgs","repos_url":"https://api.github.com/users/jkotalik/repos","events_url":"https://api.github.com/users/jkotalik/events{/privacy}","received_events_url":"https://api.github.com/users/jkotalik/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n            CertificateManager.AspNetHttpsCertificateVersion = CertificateManager.AspNetHttpsCertificateVersion + 1;\r\n```","created_at":"2019-11-01T16:25:02Z","updated_at":"2019-11-01T16:25:02Z","html_url":"https://github.com/aspnet/AspNetCore/pull/16733#discussion_r341648450","pull_request_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/16733","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments/341648450"},"html":{"href":"https://github.com/aspnet/AspNetCore/pull/16733#discussion_r341648450"},"pull_request":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/16733"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/16733","id":335317587,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM1MzE3NTg3","html_url":"https://github.com/aspnet/AspNetCore/pull/16733","diff_url":"https://github.com/aspnet/AspNetCore/pull/16733.diff","patch_url":"https://github.com/aspnet/AspNetCore/pull/16733.patch","issue_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/16733","number":16733,"state":"open","locked":false,"title":"[HttpsCertificate] Increase certificate version","user":{"login":"javiercn","id":6995051,"node_id":"MDQ6VXNlcjY5OTUwNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6995051?v=4","gravatar_id":"","url":"https://api.github.com/users/javiercn","html_url":"https://github.com/javiercn","followers_url":"https://api.github.com/users/javiercn/followers","following_url":"https://api.github.com/users/javiercn/following{/other_user}","gists_url":"https://api.github.com/users/javiercn/gists{/gist_id}","starred_url":"https://api.github.com/users/javiercn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiercn/subscriptions","organizations_url":"https://api.github.com/users/javiercn/orgs","repos_url":"https://api.github.com/users/javiercn/repos","events_url":"https://api.github.com/users/javiercn/events{/privacy}","received_events_url":"https://api.github.com/users/javiercn/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-01T08:11:31Z","updated_at":"2019-11-01T16:25:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8a9704ddbfeae1fc26d0cc41b7e0bcab349725c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Pilchie","id":312835,"node_id":"MDQ6VXNlcjMxMjgzNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/312835?v=4","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/16733/commits","review_comments_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/16733/comments","review_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/16733/comments","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/52f021436e02a9e515d1404893589fbed499b2a4","head":{"label":"aspnet:javiercn/rev-dev-certificate-version","ref":"javiercn/rev-dev-certificate-version","sha":"52f021436e02a9e515d1404893589fbed499b2a4","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17620347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyMDM0Nw==","name":"AspNetCore","full_name":"aspnet/AspNetCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/AspNetCore","description":"ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.","fork":false,"url":"https://api.github.com/repos/aspnet/AspNetCore","forks_url":"https://api.github.com/repos/aspnet/AspNetCore/forks","keys_url":"https://api.github.com/repos/aspnet/AspNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/AspNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/AspNetCore/teams","hooks_url":"https://api.github.com/repos/aspnet/AspNetCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/AspNetCore/events","assignees_url":"https://api.github.com/repos/aspnet/AspNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/AspNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/AspNetCore/tags","blobs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/AspNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/AspNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/AspNetCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/AspNetCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/AspNetCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/AspNetCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/AspNetCore/subscription","commits_url":"https://api.github.com/repos/aspnet/AspNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/AspNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/AspNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/AspNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/AspNetCore/merges","archive_url":"https://api.github.com/repos/aspnet/AspNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/AspNetCore/downloads","issues_url":"https://api.github.com/repos/aspnet/AspNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/AspNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/AspNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/AspNetCore/deployments","created_at":"2014-03-11T06:09:42Z","updated_at":"2019-11-01T15:56:34Z","pushed_at":"2019-11-01T16:12:32Z","git_url":"git://github.com/aspnet/AspNetCore.git","ssh_url":"git@github.com:aspnet/AspNetCore.git","clone_url":"https://github.com/aspnet/AspNetCore.git","svn_url":"https://github.com/aspnet/AspNetCore","homepage":"https://asp.net","size":294224,"stargazers_count":14354,"watchers_count":14354,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3653,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2012,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3653,"open_issues":2012,"watchers":14354,"default_branch":"master"}},"base":{"label":"aspnet:release/3.1","ref":"release/3.1","sha":"58c49606a771dd624c411e1a51e47e7b4c4cdc21","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17620347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyMDM0Nw==","name":"AspNetCore","full_name":"aspnet/AspNetCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/AspNetCore","description":"ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.","fork":false,"url":"https://api.github.com/repos/aspnet/AspNetCore","forks_url":"https://api.github.com/repos/aspnet/AspNetCore/forks","keys_url":"https://api.github.com/repos/aspnet/AspNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/AspNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/AspNetCore/teams","hooks_url":"https://api.github.com/repos/aspnet/AspNetCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/AspNetCore/events","assignees_url":"https://api.github.com/repos/aspnet/AspNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/AspNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/AspNetCore/tags","blobs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/AspNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/AspNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/AspNetCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/AspNetCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/AspNetCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/AspNetCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/AspNetCore/subscription","commits_url":"https://api.github.com/repos/aspnet/AspNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/AspNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/AspNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/AspNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/AspNetCore/merges","archive_url":"https://api.github.com/repos/aspnet/AspNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/AspNetCore/downloads","issues_url":"https://api.github.com/repos/aspnet/AspNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/AspNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/AspNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/AspNetCore/deployments","created_at":"2014-03-11T06:09:42Z","updated_at":"2019-11-01T15:56:34Z","pushed_at":"2019-11-01T16:12:32Z","git_url":"git://github.com/aspnet/AspNetCore.git","ssh_url":"git@github.com:aspnet/AspNetCore.git","clone_url":"https://github.com/aspnet/AspNetCore.git","svn_url":"https://github.com/aspnet/AspNetCore","homepage":"https://asp.net","size":294224,"stargazers_count":14354,"watchers_count":14354,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3653,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2012,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3653,"open_issues":2012,"watchers":14354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/16733"},"html":{"href":"https://github.com/aspnet/AspNetCore/pull/16733"},"issue":{"href":"https://api.github.com/repos/aspnet/AspNetCore/issues/16733"},"comments":{"href":"https://api.github.com/repos/aspnet/AspNetCore/issues/16733/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/16733/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/16733/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/AspNetCore/statuses/52f021436e02a9e515d1404893589fbed499b2a4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jkotalik"}}