{"action":"closed","issue":{"url":"https://api.github.com/repos/coursehero/theia-php/issues/2","repository_url":"https://api.github.com/repos/coursehero/theia-php","labels_url":"https://api.github.com/repos/coursehero/theia-php/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/coursehero/theia-php/issues/2/comments","events_url":"https://api.github.com/repos/coursehero/theia-php/issues/2/events","html_url":"https://github.com/coursehero/theia-php/issues/2","id":454927248,"node_id":"MDU6SXNzdWU0NTQ5MjcyNDg=","number":2,"title":"SDK should return render result even if adding it to the cache fails","user":{"login":"kevinwilde","id":9701176,"node_id":"MDQ6VXNlcjk3MDExNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/9701176?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinwilde","html_url":"https://github.com/kevinwilde","followers_url":"https://api.github.com/users/kevinwilde/followers","following_url":"https://api.github.com/users/kevinwilde/following{/other_user}","gists_url":"https://api.github.com/users/kevinwilde/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinwilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinwilde/subscriptions","organizations_url":"https://api.github.com/users/kevinwilde/orgs","repos_url":"https://api.github.com/users/kevinwilde/repos","events_url":"https://api.github.com/users/kevinwilde/events{/privacy}","received_events_url":"https://api.github.com/users/kevinwilde/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"kevinwilde","id":9701176,"node_id":"MDQ6VXNlcjk3MDExNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/9701176?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinwilde","html_url":"https://github.com/kevinwilde","followers_url":"https://api.github.com/users/kevinwilde/followers","following_url":"https://api.github.com/users/kevinwilde/following{/other_user}","gists_url":"https://api.github.com/users/kevinwilde/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinwilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinwilde/subscriptions","organizations_url":"https://api.github.com/users/kevinwilde/orgs","repos_url":"https://api.github.com/users/kevinwilde/repos","events_url":"https://api.github.com/users/kevinwilde/events{/privacy}","received_events_url":"https://api.github.com/users/kevinwilde/received_events","type":"User","site_admin":false},"assignees":[{"login":"kevinwilde","id":9701176,"node_id":"MDQ6VXNlcjk3MDExNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/9701176?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinwilde","html_url":"https://github.com/kevinwilde","followers_url":"https://api.github.com/users/kevinwilde/followers","following_url":"https://api.github.com/users/kevinwilde/following{/other_user}","gists_url":"https://api.github.com/users/kevinwilde/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinwilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinwilde/subscriptions","organizations_url":"https://api.github.com/users/kevinwilde/orgs","repos_url":"https://api.github.com/users/kevinwilde/repos","events_url":"https://api.github.com/users/kevinwilde/events{/privacy}","received_events_url":"https://api.github.com/users/kevinwilde/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2019-06-11T22:14:50Z","updated_at":"2019-06-11T22:25:52Z","closed_at":"2019-06-11T22:25:52Z","author_association":"COLLABORATOR","body":"We are using Dynamo DB to cache the render results. We have a couple pages that exceed the allowed item size on Dynamo DB, so this line causes an exception:\r\nhttps://github.com/coursehero/theia-php/blob/6684164f0e34f3eeefbcc8e151d60f1f03ae588e/src/Client.php#L101\r\n\r\nPerhaps we shouldn't use Dynamo DB, but the general point still stands. If `cachingInterface->set` throws an exception, we should still be able to return the render result.\r\n\r\nWe can notify that the caching failed by adding a property on the `RenderResult` class similar to the `retrievedFromCache` property"}}
{"actor":{"display_login":"kevinwilde"}}