{"action":"created","issue":{"url":"https://api.github.com/repos/googleapis/google-cloud-ruby/issues/4071","repository_url":"https://api.github.com/repos/googleapis/google-cloud-ruby","labels_url":"https://api.github.com/repos/googleapis/google-cloud-ruby/issues/4071/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-ruby/issues/4071/comments","events_url":"https://api.github.com/repos/googleapis/google-cloud-ruby/issues/4071/events","html_url":"https://github.com/googleapis/google-cloud-ruby/pull/4071","id":498692322,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxNTYzNzcw","number":4071,"title":"test(spanner): acceptance tests for multi-use #3705","user":{"login":"jiren","id":109756,"node_id":"MDQ6VXNlcjEwOTc1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/109756?v=4","gravatar_id":"","url":"https://api.github.com/users/jiren","html_url":"https://github.com/jiren","followers_url":"https://api.github.com/users/jiren/followers","following_url":"https://api.github.com/users/jiren/following{/other_user}","gists_url":"https://api.github.com/users/jiren/gists{/gist_id}","starred_url":"https://api.github.com/users/jiren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiren/subscriptions","organizations_url":"https://api.github.com/users/jiren/orgs","repos_url":"https://api.github.com/users/jiren/repos","events_url":"https://api.github.com/users/jiren/events{/privacy}","received_events_url":"https://api.github.com/users/jiren/received_events","type":"User","site_admin":false},"labels":[{"id":539625447,"node_id":"MDU6TGFiZWw1Mzk2MjU0NDc=","url":"https://api.github.com/repos/googleapis/google-cloud-ruby/labels/api:%20spanner","name":"api: spanner","color":"f8f8f8","default":false},{"id":166382179,"node_id":"MDU6TGFiZWwxNjYzODIxNzk=","url":"https://api.github.com/repos/googleapis/google-cloud-ruby/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"state":"open","locked":false,"assignee":{"login":"quartzmo","id":205445,"node_id":"MDQ6VXNlcjIwNTQ0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/205445?v=4","gravatar_id":"","url":"https://api.github.com/users/quartzmo","html_url":"https://github.com/quartzmo","followers_url":"https://api.github.com/users/quartzmo/followers","following_url":"https://api.github.com/users/quartzmo/following{/other_user}","gists_url":"https://api.github.com/users/quartzmo/gists{/gist_id}","starred_url":"https://api.github.com/users/quartzmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quartzmo/subscriptions","organizations_url":"https://api.github.com/users/quartzmo/orgs","repos_url":"https://api.github.com/users/quartzmo/repos","events_url":"https://api.github.com/users/quartzmo/events{/privacy}","received_events_url":"https://api.github.com/users/quartzmo/received_events","type":"User","site_admin":false},"assignees":[{"login":"quartzmo","id":205445,"node_id":"MDQ6VXNlcjIwNTQ0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/205445?v=4","gravatar_id":"","url":"https://api.github.com/users/quartzmo","html_url":"https://github.com/quartzmo","followers_url":"https://api.github.com/users/quartzmo/followers","following_url":"https://api.github.com/users/quartzmo/following{/other_user}","gists_url":"https://api.github.com/users/quartzmo/gists{/gist_id}","starred_url":"https://api.github.com/users/quartzmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quartzmo/subscriptions","organizations_url":"https://api.github.com/users/quartzmo/orgs","repos_url":"https://api.github.com/users/quartzmo/repos","events_url":"https://api.github.com/users/quartzmo/events{/privacy}","received_events_url":"https://api.github.com/users/quartzmo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2019-09-26T06:46:10Z","updated_at":"2019-10-07T07:26:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/googleapis/google-cloud-ruby/pulls/4071","html_url":"https://github.com/googleapis/google-cloud-ruby/pull/4071","diff_url":"https://github.com/googleapis/google-cloud-ruby/pull/4071.diff","patch_url":"https://github.com/googleapis/google-cloud-ruby/pull/4071.patch"},"body":"issue #3705 \r\n\r\n- acceptance test for multi-use.  \r\n- Ruby client storing transaction id of snapshot and using it for subsequent operations so by default snapshots created by a ruby client are multi-use.\r\n- snapshot read and update acceptance test are available which are multi-use"},"comment":{"url":"https://api.github.com/repos/googleapis/google-cloud-ruby/issues/comments/538872769","html_url":"https://github.com/googleapis/google-cloud-ruby/pull/4071#issuecomment-538872769","issue_url":"https://api.github.com/repos/googleapis/google-cloud-ruby/issues/4071","id":538872769,"node_id":"MDEyOklzc3VlQ29tbWVudDUzODg3Mjc2OQ==","user":{"login":"jiren","id":109756,"node_id":"MDQ6VXNlcjEwOTc1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/109756?v=4","gravatar_id":"","url":"https://api.github.com/users/jiren","html_url":"https://github.com/jiren","followers_url":"https://api.github.com/users/jiren/followers","following_url":"https://api.github.com/users/jiren/following{/other_user}","gists_url":"https://api.github.com/users/jiren/gists{/gist_id}","starred_url":"https://api.github.com/users/jiren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiren/subscriptions","organizations_url":"https://api.github.com/users/jiren/orgs","repos_url":"https://api.github.com/users/jiren/repos","events_url":"https://api.github.com/users/jiren/events{/privacy}","received_events_url":"https://api.github.com/users/jiren/received_events","type":"User","site_admin":false},"created_at":"2019-10-07T07:26:52Z","updated_at":"2019-10-07T07:26:52Z","author_association":"MEMBER","body":"> @jiren Thanks for opening this PR. Unfortunately, the assertions for the returned rows in these tests do not work, due to the behavior of `zip`. If the receiver of `zip` is empty, no assertions will be executed in the `each` block:\r\n> \r\n> ```ruby\r\n> irb(main):001:0> rows = []\r\n> => []\r\n> irb(main):002:0> default = [1,2]\r\n> => [1, 2]\r\n> irb(main):003:0> rows.zip default\r\n> => []\r\n> ```\r\n> \r\n> I have pushed a commit to your branch with added assertions that verify that the returned rows count is the same as the expected rows:\r\n> \r\n> ```ruby\r\n> rows.count.must_equal default_account_rows.count\r\n> ```\r\n> \r\n> With these added assertions, all three tests now fail for me locally:\r\n> \r\n> ```shell\r\n>   1) Failure:\r\n> Spanner Client::snapshot::spanner#test_0016_multiuse snapshot reads with read timestamp are consistent even when delete happen [/Users/quartzmo/code/google/codez/google-cloud-ruby/google-cloud-spanner/acceptance/spanner/client/snapshot_test.rb:353]:\r\n> Expected: 3\r\n>   Actual: 0\r\n> \r\n>   2) Failure:\r\n> Spanner Client::snapshot::spanner#test_0015_multiuse snapshot reads are consistent even when delete happen [/Users/quartzmo/code/google/codez/google-cloud-ruby/google-cloud-spanner/acceptance/spanner/client/snapshot_test.rb:317]:\r\n> Expected: 3\r\n>   Actual: 0\r\n> \r\n>   3) Failure:\r\n> Spanner Client::snapshot::spanner#test_0017_multiuse snapshot reads with exact staleness are consistent even when delete happen [/Users/quartzmo/code/google/codez/google-cloud-ruby/google-cloud-spanner/acceptance/spanner/client/snapshot_test.rb:392]:\r\n> Expected: 3\r\n>   Actual: 0\r\n> ```\r\n\r\nOk, Looking into it."}}
{"actor":{"display_login":"jiren"}}