{"action":"created","issue":{"url":"https://api.github.com/repos/fwupd/fwupd/issues/1675","repository_url":"https://api.github.com/repos/fwupd/fwupd","labels_url":"https://api.github.com/repos/fwupd/fwupd/issues/1675/labels{/name}","comments_url":"https://api.github.com/repos/fwupd/fwupd/issues/1675/comments","events_url":"https://api.github.com/repos/fwupd/fwupd/issues/1675/events","html_url":"https://github.com/fwupd/fwupd/issues/1675","id":542721407,"node_id":"MDU6SXNzdWU1NDI3MjE0MDc=","number":1675,"title":"Without --allow-reinstall the same version of BIOS could still be updated by fwupd","user":{"login":"ltmvic51","id":19870443,"node_id":"MDQ6VXNlcjE5ODcwNDQz","avatar_url":"https://avatars2.githubusercontent.com/u/19870443?v=4","gravatar_id":"","url":"https://api.github.com/users/ltmvic51","html_url":"https://github.com/ltmvic51","followers_url":"https://api.github.com/users/ltmvic51/followers","following_url":"https://api.github.com/users/ltmvic51/following{/other_user}","gists_url":"https://api.github.com/users/ltmvic51/gists{/gist_id}","starred_url":"https://api.github.com/users/ltmvic51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltmvic51/subscriptions","organizations_url":"https://api.github.com/users/ltmvic51/orgs","repos_url":"https://api.github.com/users/ltmvic51/repos","events_url":"https://api.github.com/users/ltmvic51/events{/privacy}","received_events_url":"https://api.github.com/users/ltmvic51/received_events","type":"User","site_admin":false},"labels":[{"id":181181877,"node_id":"MDU6TGFiZWwxODExODE4Nzc=","url":"https://api.github.com/repos/fwupd/fwupd/labels/bug","name":"bug","color":"fc2929","default":true,"description":null}],"state":"closed","locked":false,"assignee":{"login":"superm1","id":494526,"node_id":"MDQ6VXNlcjQ5NDUyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/494526?v=4","gravatar_id":"","url":"https://api.github.com/users/superm1","html_url":"https://github.com/superm1","followers_url":"https://api.github.com/users/superm1/followers","following_url":"https://api.github.com/users/superm1/following{/other_user}","gists_url":"https://api.github.com/users/superm1/gists{/gist_id}","starred_url":"https://api.github.com/users/superm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superm1/subscriptions","organizations_url":"https://api.github.com/users/superm1/orgs","repos_url":"https://api.github.com/users/superm1/repos","events_url":"https://api.github.com/users/superm1/events{/privacy}","received_events_url":"https://api.github.com/users/superm1/received_events","type":"User","site_admin":false},"assignees":[{"login":"superm1","id":494526,"node_id":"MDQ6VXNlcjQ5NDUyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/494526?v=4","gravatar_id":"","url":"https://api.github.com/users/superm1","html_url":"https://github.com/superm1","followers_url":"https://api.github.com/users/superm1/followers","following_url":"https://api.github.com/users/superm1/following{/other_user}","gists_url":"https://api.github.com/users/superm1/gists{/gist_id}","starred_url":"https://api.github.com/users/superm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superm1/subscriptions","organizations_url":"https://api.github.com/users/superm1/orgs","repos_url":"https://api.github.com/users/superm1/repos","events_url":"https://api.github.com/users/superm1/events{/privacy}","received_events_url":"https://api.github.com/users/superm1/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2019-12-27T02:40:29Z","updated_at":"2020-01-10T15:36:49Z","closed_at":"2020-01-08T22:42:43Z","author_association":"NONE","body":"In Ubuntu 18.04, I found the same version of BIOS could still be updated by `sudo  fwupdmgr install d7baa890b5d2642ebc2eb40a7cb8f990b1f6e42c-Bandon_1.4.1.cab` without `--allow-reinstall`.\r\n\r\nfwupd 1.0.9 (in -update channel):\r\n   BIOS update would be blocked by fwupdmgr without --allow-reinstall.\r\nfwupd 1.2.5:\r\n   BIOS update would NOT be blocked by fwupdmgr without --allow-reinstall.\r\nfwupd 1.2.10 (in -proposed channel):\r\n   BIOS update would NOT be blocked by fwupdmgr without --allow-reinstall.\r\nfwupd 1.3.5:\r\n   BIOS update would NOT be blocked by fwupdmgr without --allow-reinstall.\r\n\r\n\r\n```\r\nu@u-Latitude-5300:~/Downloads$ sudo fwupdmgr install d7baa890b5d2642ebc2eb40a7cb8f990b1f6e42c-Bandon_1.4.1.cab \r\nDecompressing…         [***************************************]\r\nSpecified firmware is already installed '0.1.4.1'\r\nu@u-Latitude-5300:~/Downloads$ fwupdmgr --version\r\nclient version:\t1.0.9\r\ndaemon version:\t1.0.9\r\ncompile-time dependency versions\r\n\tappstream-glib:\t0.7.7\r\n\tgusb:\t0.2.11\r\n\tfwupdate:\t10\r\n\tefivar:\t34\r\n\r\n\r\n//=================================================================================================\r\nu@u-Latitude-5300:~/Downloads$ fwupdmgr --version\r\nclient version:\t1.2.5\r\ncompile-time dependency versions\r\n\tgusb:\t0.2.11\r\n\tefivar:\t34\r\ndaemon version:\t1.2.5\r\nu@u-Latitude-5300:~/Downloads$ sudo fwupdmgr install d7baa890b5d2642ebc2eb40a7cb8f990b1f6e42c-Bandon_1.4.1.cab \r\nDecompressing…           [***************************************]\r\nAuthenticating…          [***************************************]\r\nInstalling on Latitude 5300 System Firmware…                     ]\r\nScheduling…              [***************************************]\r\n\r\nAn update requires a reboot to complete. Restart now? [Y|n]: \r\n```"},"comment":{"url":"https://api.github.com/repos/fwupd/fwupd/issues/comments/573084334","html_url":"https://github.com/fwupd/fwupd/issues/1675#issuecomment-573084334","issue_url":"https://api.github.com/repos/fwupd/fwupd/issues/1675","id":573084334,"node_id":"MDEyOklzc3VlQ29tbWVudDU3MzA4NDMzNA==","user":{"login":"superm1","id":494526,"node_id":"MDQ6VXNlcjQ5NDUyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/494526?v=4","gravatar_id":"","url":"https://api.github.com/users/superm1","html_url":"https://github.com/superm1","followers_url":"https://api.github.com/users/superm1/followers","following_url":"https://api.github.com/users/superm1/following{/other_user}","gists_url":"https://api.github.com/users/superm1/gists{/gist_id}","starred_url":"https://api.github.com/users/superm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superm1/subscriptions","organizations_url":"https://api.github.com/users/superm1/orgs","repos_url":"https://api.github.com/users/superm1/repos","events_url":"https://api.github.com/users/superm1/events{/privacy}","received_events_url":"https://api.github.com/users/superm1/received_events","type":"User","site_admin":false},"created_at":"2020-01-10T15:36:49Z","updated_at":"2020-01-10T15:36:49Z","author_association":"COLLABORATOR","body":"@ycheng you might consider to also include https://github.com/fwupd/fwupd/commit/1f579d82c328b7eac1b95d9e7ca2dfbde79dca77 and \r\nhttps://github.com/fwupd/fwupd/commit/a5df5b0e20726985cc971bfdb6f3872cf387f258\r\n\r\nfor fixing SRU https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1858590 as well as the cleanup behavior that you observed."}}
{"actor":{"display_login":"superm1"}}