{"action":"created","comment":{"url":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/comments/310293185","pull_request_review_id":270389238,"id":310293185,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDI5MzE4NQ==","diff_hunk":"@@ -156,6 +157,23 @@ class InputLookupQA extends Component {\n           const subauthority = lookupConfig.subauthority\n           const language = lookupConfig.language\n \n+          /*\n+           *  There are two types of lookup: linked data and non-linked data. The API calls\n+           *  for each type are different, so check the nonldLookup field in the lookup config.\n+           *  If the field is not set, assume false.\n+           */\n+          const nonldLookup = lookupConfig.nonldLookup ? lookupConfig.nonldLookup : false\n+\n+          // default the API calls to their linked data values","path":"src/components/editor/property/InputLookupQA.jsx","position":21,"original_position":21,"commit_id":"30f7a18955abee6d915f8b1b5ab8b9fb10b4b70e","original_commit_id":"30f7a18955abee6d915f8b1b5ab8b9fb10b4b70e","user":{"login":"jermnelson","id":71847,"node_id":"MDQ6VXNlcjcxODQ3","avatar_url":"https://avatars0.githubusercontent.com/u/71847?v=4","gravatar_id":"","url":"https://api.github.com/users/jermnelson","html_url":"https://github.com/jermnelson","followers_url":"https://api.github.com/users/jermnelson/followers","following_url":"https://api.github.com/users/jermnelson/following{/other_user}","gists_url":"https://api.github.com/users/jermnelson/gists{/gist_id}","starred_url":"https://api.github.com/users/jermnelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jermnelson/subscriptions","organizations_url":"https://api.github.com/users/jermnelson/orgs","repos_url":"https://api.github.com/users/jermnelson/repos","events_url":"https://api.github.com/users/jermnelson/events{/privacy}","received_events_url":"https://api.github.com/users/jermnelson/received_events","type":"User","site_admin":false},"body":"I'm fine if you want to mark this resolved. When everything is merged, I think we could create an integration test to test for expectations arising from ShareVDE and Discogs sources.","created_at":"2019-08-02T20:48:54Z","updated_at":"2019-08-02T20:48:54Z","html_url":"https://github.com/LD4P/sinopia_editor/pull/1119#discussion_r310293185","pull_request_url":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/1119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/comments/310293185"},"html":{"href":"https://github.com/LD4P/sinopia_editor/pull/1119#discussion_r310293185"},"pull_request":{"href":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/1119"}},"in_reply_to_id":309758474},"pull_request":{"url":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/1119","id":303138648,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzMTM4NjQ4","html_url":"https://github.com/LD4P/sinopia_editor/pull/1119","diff_url":"https://github.com/LD4P/sinopia_editor/pull/1119.diff","patch_url":"https://github.com/LD4P/sinopia_editor/pull/1119.patch","issue_url":"https://api.github.com/repos/LD4P/sinopia_editor/issues/1119","number":1119,"state":"open","locked":false,"title":"Lookup context api","user":{"login":"hudajkhan","id":2677207,"node_id":"MDQ6VXNlcjI2NzcyMDc=","avatar_url":"https://avatars0.githubusercontent.com/u/2677207?v=4","gravatar_id":"","url":"https://api.github.com/users/hudajkhan","html_url":"https://github.com/hudajkhan","followers_url":"https://api.github.com/users/hudajkhan/followers","following_url":"https://api.github.com/users/hudajkhan/following{/other_user}","gists_url":"https://api.github.com/users/hudajkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/hudajkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hudajkhan/subscriptions","organizations_url":"https://api.github.com/users/hudajkhan/orgs","repos_url":"https://api.github.com/users/hudajkhan/repos","events_url":"https://api.github.com/users/hudajkhan/events{/privacy}","received_events_url":"https://api.github.com/users/hudajkhan/received_events","type":"User","site_admin":false},"body":"Based on discussions here (https://github.com/LD4P/sinopia_editor/pull/1023), we are breaking out work for integrating context into smaller portions, starting with this pull request.\r\n\r\nThe updates here enable a call to the Discogs authority to be made using QA and the ability to pass along a context parameter to QA if \"subtype\" in the resource template uses the value \"context\".  Two example templates, Discogs and ShareVDE, have been added to the fixtures directory and to the list of templates loaded when the application is configured to use the fixtures templates.  \r\n\r\nSuggestions on updates to InputLookupQA.test.js would be welcome.  In this PR, the input's display functionality will not change but it will be able to make calls to discogs and pass along the context parameter (which are all part of the search function).  \r\n\r\nAnother option may be to always pass along \"context:true\" to the QA API.  This may have an effect on performance (as more info is being requested in that case) but it may be fine.  ","created_at":"2019-07-31T21:45:19Z","updated_at":"2019-08-02T20:48:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1f8134bb89d852d7ead7158f0c9ef6f928144fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1071915214,"node_id":"MDU6TGFiZWwxMDcxOTE1MjE0","url":"https://api.github.com/repos/LD4P/sinopia_editor/labels/BFF","name":"BFF","color":"7614a0","default":false},{"id":1061533869,"node_id":"MDU6TGFiZWwxMDYxNTMzODY5","url":"https://api.github.com/repos/LD4P/sinopia_editor/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/1119/commits","review_comments_url":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/1119/comments","review_comment_url":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LD4P/sinopia_editor/issues/1119/comments","statuses_url":"https://api.github.com/repos/LD4P/sinopia_editor/statuses/30f7a18955abee6d915f8b1b5ab8b9fb10b4b70e","head":{"label":"LD4P:lookup_context_api","ref":"lookup_context_api","sha":"30f7a18955abee6d915f8b1b5ab8b9fb10b4b70e","user":{"login":"LD4P","id":20959259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTU5MjU5","avatar_url":"https://avatars2.githubusercontent.com/u/20959259?v=4","gravatar_id":"","url":"https://api.github.com/users/LD4P","html_url":"https://github.com/LD4P","followers_url":"https://api.github.com/users/LD4P/followers","following_url":"https://api.github.com/users/LD4P/following{/other_user}","gists_url":"https://api.github.com/users/LD4P/gists{/gist_id}","starred_url":"https://api.github.com/users/LD4P/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LD4P/subscriptions","organizations_url":"https://api.github.com/users/LD4P/orgs","repos_url":"https://api.github.com/users/LD4P/repos","events_url":"https://api.github.com/users/LD4P/events{/privacy}","received_events_url":"https://api.github.com/users/LD4P/received_events","type":"Organization","site_admin":false},"repo":{"id":149367347,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNjczNDc=","name":"sinopia_editor","full_name":"LD4P/sinopia_editor","private":false,"owner":{"login":"LD4P","id":20959259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTU5MjU5","avatar_url":"https://avatars2.githubusercontent.com/u/20959259?v=4","gravatar_id":"","url":"https://api.github.com/users/LD4P","html_url":"https://github.com/LD4P","followers_url":"https://api.github.com/users/LD4P/followers","following_url":"https://api.github.com/users/LD4P/following{/other_user}","gists_url":"https://api.github.com/users/LD4P/gists{/gist_id}","starred_url":"https://api.github.com/users/LD4P/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LD4P/subscriptions","organizations_url":"https://api.github.com/users/LD4P/orgs","repos_url":"https://api.github.com/users/LD4P/repos","events_url":"https://api.github.com/users/LD4P/events{/privacy}","received_events_url":"https://api.github.com/users/LD4P/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LD4P/sinopia_editor","description":"Sinopia Linked Data Editor","fork":false,"url":"https://api.github.com/repos/LD4P/sinopia_editor","forks_url":"https://api.github.com/repos/LD4P/sinopia_editor/forks","keys_url":"https://api.github.com/repos/LD4P/sinopia_editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LD4P/sinopia_editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LD4P/sinopia_editor/teams","hooks_url":"https://api.github.com/repos/LD4P/sinopia_editor/hooks","issue_events_url":"https://api.github.com/repos/LD4P/sinopia_editor/issues/events{/number}","events_url":"https://api.github.com/repos/LD4P/sinopia_editor/events","assignees_url":"https://api.github.com/repos/LD4P/sinopia_editor/assignees{/user}","branches_url":"https://api.github.com/repos/LD4P/sinopia_editor/branches{/branch}","tags_url":"https://api.github.com/repos/LD4P/sinopia_editor/tags","blobs_url":"https://api.github.com/repos/LD4P/sinopia_editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LD4P/sinopia_editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LD4P/sinopia_editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/LD4P/sinopia_editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LD4P/sinopia_editor/statuses/{sha}","languages_url":"https://api.github.com/repos/LD4P/sinopia_editor/languages","stargazers_url":"https://api.github.com/repos/LD4P/sinopia_editor/stargazers","contributors_url":"https://api.github.com/repos/LD4P/sinopia_editor/contributors","subscribers_url":"https://api.github.com/repos/LD4P/sinopia_editor/subscribers","subscription_url":"https://api.github.com/repos/LD4P/sinopia_editor/subscription","commits_url":"https://api.github.com/repos/LD4P/sinopia_editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/LD4P/sinopia_editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/LD4P/sinopia_editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/LD4P/sinopia_editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/LD4P/sinopia_editor/contents/{+path}","compare_url":"https://api.github.com/repos/LD4P/sinopia_editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LD4P/sinopia_editor/merges","archive_url":"https://api.github.com/repos/LD4P/sinopia_editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LD4P/sinopia_editor/downloads","issues_url":"https://api.github.com/repos/LD4P/sinopia_editor/issues{/number}","pulls_url":"https://api.github.com/repos/LD4P/sinopia_editor/pulls{/number}","milestones_url":"https://api.github.com/repos/LD4P/sinopia_editor/milestones{/number}","notifications_url":"https://api.github.com/repos/LD4P/sinopia_editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LD4P/sinopia_editor/labels{/name}","releases_url":"https://api.github.com/repos/LD4P/sinopia_editor/releases{/id}","deployments_url":"https://api.github.com/repos/LD4P/sinopia_editor/deployments","created_at":"2018-09-19T00:13:38Z","updated_at":"2019-08-02T20:45:47Z","pushed_at":"2019-08-02T20:48:51Z","git_url":"git://github.com/LD4P/sinopia_editor.git","ssh_url":"git@github.com:LD4P/sinopia_editor.git","clone_url":"https://github.com/LD4P/sinopia_editor.git","svn_url":"https://github.com/LD4P/sinopia_editor","homepage":"https://sinopia.io/","size":8456,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":82,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":82,"watchers":2,"default_branch":"master"}},"base":{"label":"LD4P:master","ref":"master","sha":"d0979e79f6162998cc95b25bfe0a85bd6702b0f3","user":{"login":"LD4P","id":20959259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTU5MjU5","avatar_url":"https://avatars2.githubusercontent.com/u/20959259?v=4","gravatar_id":"","url":"https://api.github.com/users/LD4P","html_url":"https://github.com/LD4P","followers_url":"https://api.github.com/users/LD4P/followers","following_url":"https://api.github.com/users/LD4P/following{/other_user}","gists_url":"https://api.github.com/users/LD4P/gists{/gist_id}","starred_url":"https://api.github.com/users/LD4P/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LD4P/subscriptions","organizations_url":"https://api.github.com/users/LD4P/orgs","repos_url":"https://api.github.com/users/LD4P/repos","events_url":"https://api.github.com/users/LD4P/events{/privacy}","received_events_url":"https://api.github.com/users/LD4P/received_events","type":"Organization","site_admin":false},"repo":{"id":149367347,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNjczNDc=","name":"sinopia_editor","full_name":"LD4P/sinopia_editor","private":false,"owner":{"login":"LD4P","id":20959259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTU5MjU5","avatar_url":"https://avatars2.githubusercontent.com/u/20959259?v=4","gravatar_id":"","url":"https://api.github.com/users/LD4P","html_url":"https://github.com/LD4P","followers_url":"https://api.github.com/users/LD4P/followers","following_url":"https://api.github.com/users/LD4P/following{/other_user}","gists_url":"https://api.github.com/users/LD4P/gists{/gist_id}","starred_url":"https://api.github.com/users/LD4P/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LD4P/subscriptions","organizations_url":"https://api.github.com/users/LD4P/orgs","repos_url":"https://api.github.com/users/LD4P/repos","events_url":"https://api.github.com/users/LD4P/events{/privacy}","received_events_url":"https://api.github.com/users/LD4P/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LD4P/sinopia_editor","description":"Sinopia Linked Data Editor","fork":false,"url":"https://api.github.com/repos/LD4P/sinopia_editor","forks_url":"https://api.github.com/repos/LD4P/sinopia_editor/forks","keys_url":"https://api.github.com/repos/LD4P/sinopia_editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LD4P/sinopia_editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LD4P/sinopia_editor/teams","hooks_url":"https://api.github.com/repos/LD4P/sinopia_editor/hooks","issue_events_url":"https://api.github.com/repos/LD4P/sinopia_editor/issues/events{/number}","events_url":"https://api.github.com/repos/LD4P/sinopia_editor/events","assignees_url":"https://api.github.com/repos/LD4P/sinopia_editor/assignees{/user}","branches_url":"https://api.github.com/repos/LD4P/sinopia_editor/branches{/branch}","tags_url":"https://api.github.com/repos/LD4P/sinopia_editor/tags","blobs_url":"https://api.github.com/repos/LD4P/sinopia_editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LD4P/sinopia_editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LD4P/sinopia_editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/LD4P/sinopia_editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LD4P/sinopia_editor/statuses/{sha}","languages_url":"https://api.github.com/repos/LD4P/sinopia_editor/languages","stargazers_url":"https://api.github.com/repos/LD4P/sinopia_editor/stargazers","contributors_url":"https://api.github.com/repos/LD4P/sinopia_editor/contributors","subscribers_url":"https://api.github.com/repos/LD4P/sinopia_editor/subscribers","subscription_url":"https://api.github.com/repos/LD4P/sinopia_editor/subscription","commits_url":"https://api.github.com/repos/LD4P/sinopia_editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/LD4P/sinopia_editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/LD4P/sinopia_editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/LD4P/sinopia_editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/LD4P/sinopia_editor/contents/{+path}","compare_url":"https://api.github.com/repos/LD4P/sinopia_editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LD4P/sinopia_editor/merges","archive_url":"https://api.github.com/repos/LD4P/sinopia_editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LD4P/sinopia_editor/downloads","issues_url":"https://api.github.com/repos/LD4P/sinopia_editor/issues{/number}","pulls_url":"https://api.github.com/repos/LD4P/sinopia_editor/pulls{/number}","milestones_url":"https://api.github.com/repos/LD4P/sinopia_editor/milestones{/number}","notifications_url":"https://api.github.com/repos/LD4P/sinopia_editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LD4P/sinopia_editor/labels{/name}","releases_url":"https://api.github.com/repos/LD4P/sinopia_editor/releases{/id}","deployments_url":"https://api.github.com/repos/LD4P/sinopia_editor/deployments","created_at":"2018-09-19T00:13:38Z","updated_at":"2019-08-02T20:45:47Z","pushed_at":"2019-08-02T20:48:51Z","git_url":"git://github.com/LD4P/sinopia_editor.git","ssh_url":"git@github.com:LD4P/sinopia_editor.git","clone_url":"https://github.com/LD4P/sinopia_editor.git","svn_url":"https://github.com/LD4P/sinopia_editor","homepage":"https://sinopia.io/","size":8456,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":82,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":82,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/1119"},"html":{"href":"https://github.com/LD4P/sinopia_editor/pull/1119"},"issue":{"href":"https://api.github.com/repos/LD4P/sinopia_editor/issues/1119"},"comments":{"href":"https://api.github.com/repos/LD4P/sinopia_editor/issues/1119/comments"},"review_comments":{"href":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/1119/comments"},"review_comment":{"href":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LD4P/sinopia_editor/pulls/1119/commits"},"statuses":{"href":"https://api.github.com/repos/LD4P/sinopia_editor/statuses/30f7a18955abee6d915f8b1b5ab8b9fb10b4b70e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jermnelson"}}