{"action":"created","comment":{"url":"https://api.github.com/repos/sylabs/singularity/pulls/comments/267067453","pull_request_review_id":216381728,"id":267067453,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzA2NzQ1Mw==","diff_hunk":"@@ -193,6 +193,9 @@ func (engine *EngineOperations) StartProcess(masterConn net.Conn) error {\n \n \tif (!isInstance && !shimProcess) || bootInstance || engine.EngineConfig.GetInstanceJoin() {\n \t\terr := syscall.Exec(args[0], args, env)\n+\t\tif _, errNoShell := os.Stat(\"/bin/sh\"); os.IsNotExist(errNoShell) {","path":"internal/pkg/runtime/engines/singularity/process_linux.go","position":4,"original_position":4,"commit_id":"c2729479b1e86eaa7dab5ca0c48803bfb6dfb3c8","original_commit_id":"c2729479b1e86eaa7dab5ca0c48803bfb6dfb3c8","user":{"login":"mem","id":189701,"node_id":"MDQ6VXNlcjE4OTcwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/189701?v=4","gravatar_id":"","url":"https://api.github.com/users/mem","html_url":"https://github.com/mem","followers_url":"https://api.github.com/users/mem/followers","following_url":"https://api.github.com/users/mem/following{/other_user}","gists_url":"https://api.github.com/users/mem/gists{/gist_id}","starred_url":"https://api.github.com/users/mem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mem/subscriptions","organizations_url":"https://api.github.com/users/mem/orgs","repos_url":"https://api.github.com/users/mem/repos","events_url":"https://api.github.com/users/mem/events{/privacy}","received_events_url":"https://api.github.com/users/mem/received_events","type":"User","site_admin":false},"body":"As I mentioned in the issue, I think this is happening too late. We should check for `/bin/sh` much earlier (when we decide which wrapper to launch, in `checkExec`) so that we can provide a better error message there?","created_at":"2019-03-19T19:47:22Z","updated_at":"2019-03-19T19:47:26Z","html_url":"https://github.com/sylabs/singularity/pull/2918#discussion_r267067453","pull_request_url":"https://api.github.com/repos/sylabs/singularity/pulls/2918","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sylabs/singularity/pulls/comments/267067453"},"html":{"href":"https://github.com/sylabs/singularity/pull/2918#discussion_r267067453"},"pull_request":{"href":"https://api.github.com/repos/sylabs/singularity/pulls/2918"}}},"pull_request":{"url":"https://api.github.com/repos/sylabs/singularity/pulls/2918","id":262265467,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyMjY1NDY3","html_url":"https://github.com/sylabs/singularity/pull/2918","diff_url":"https://github.com/sylabs/singularity/pull/2918.diff","patch_url":"https://github.com/sylabs/singularity/pull/2918.patch","issue_url":"https://api.github.com/repos/sylabs/singularity/issues/2918","number":2918,"state":"open","locked":false,"title":"Print appropriate error when /bin/sh is missing.","user":{"login":"phpHavok","id":4846473,"node_id":"MDQ6VXNlcjQ4NDY0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/4846473?v=4","gravatar_id":"","url":"https://api.github.com/users/phpHavok","html_url":"https://github.com/phpHavok","followers_url":"https://api.github.com/users/phpHavok/followers","following_url":"https://api.github.com/users/phpHavok/following{/other_user}","gists_url":"https://api.github.com/users/phpHavok/gists{/gist_id}","starred_url":"https://api.github.com/users/phpHavok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpHavok/subscriptions","organizations_url":"https://api.github.com/users/phpHavok/orgs","repos_url":"https://api.github.com/users/phpHavok/repos","events_url":"https://api.github.com/users/phpHavok/events{/privacy}","received_events_url":"https://api.github.com/users/phpHavok/received_events","type":"User","site_admin":false},"body":"**Description of the Pull Request (PR):**\r\n\r\nThis PR prints a descriptive error when a container fails to exec due to `/bin/sh` missing.\r\n\r\n- Related #2386\r\n\r\nAttn: @singularity-maintainers\r\n","created_at":"2019-03-18T23:51:37Z","updated_at":"2019-03-19T19:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16dc431b3298348a8e4725aca4abcee1ba74a655","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sylabs/singularity/pulls/2918/commits","review_comments_url":"https://api.github.com/repos/sylabs/singularity/pulls/2918/comments","review_comment_url":"https://api.github.com/repos/sylabs/singularity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sylabs/singularity/issues/2918/comments","statuses_url":"https://api.github.com/repos/sylabs/singularity/statuses/c2729479b1e86eaa7dab5ca0c48803bfb6dfb3c8","head":{"label":"phpHavok:2386/better_error_message","ref":"2386/better_error_message","sha":"c2729479b1e86eaa7dab5ca0c48803bfb6dfb3c8","user":{"login":"phpHavok","id":4846473,"node_id":"MDQ6VXNlcjQ4NDY0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/4846473?v=4","gravatar_id":"","url":"https://api.github.com/users/phpHavok","html_url":"https://github.com/phpHavok","followers_url":"https://api.github.com/users/phpHavok/followers","following_url":"https://api.github.com/users/phpHavok/following{/other_user}","gists_url":"https://api.github.com/users/phpHavok/gists{/gist_id}","starred_url":"https://api.github.com/users/phpHavok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpHavok/subscriptions","organizations_url":"https://api.github.com/users/phpHavok/orgs","repos_url":"https://api.github.com/users/phpHavok/repos","events_url":"https://api.github.com/users/phpHavok/events{/privacy}","received_events_url":"https://api.github.com/users/phpHavok/received_events","type":"User","site_admin":false},"repo":{"id":158891910,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg4OTE5MTA=","name":"singularity","full_name":"phpHavok/singularity","private":false,"owner":{"login":"phpHavok","id":4846473,"node_id":"MDQ6VXNlcjQ4NDY0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/4846473?v=4","gravatar_id":"","url":"https://api.github.com/users/phpHavok","html_url":"https://github.com/phpHavok","followers_url":"https://api.github.com/users/phpHavok/followers","following_url":"https://api.github.com/users/phpHavok/following{/other_user}","gists_url":"https://api.github.com/users/phpHavok/gists{/gist_id}","starred_url":"https://api.github.com/users/phpHavok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpHavok/subscriptions","organizations_url":"https://api.github.com/users/phpHavok/orgs","repos_url":"https://api.github.com/users/phpHavok/repos","events_url":"https://api.github.com/users/phpHavok/events{/privacy}","received_events_url":"https://api.github.com/users/phpHavok/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phpHavok/singularity","description":"Singularity: Application containers for Linux","fork":true,"url":"https://api.github.com/repos/phpHavok/singularity","forks_url":"https://api.github.com/repos/phpHavok/singularity/forks","keys_url":"https://api.github.com/repos/phpHavok/singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpHavok/singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpHavok/singularity/teams","hooks_url":"https://api.github.com/repos/phpHavok/singularity/hooks","issue_events_url":"https://api.github.com/repos/phpHavok/singularity/issues/events{/number}","events_url":"https://api.github.com/repos/phpHavok/singularity/events","assignees_url":"https://api.github.com/repos/phpHavok/singularity/assignees{/user}","branches_url":"https://api.github.com/repos/phpHavok/singularity/branches{/branch}","tags_url":"https://api.github.com/repos/phpHavok/singularity/tags","blobs_url":"https://api.github.com/repos/phpHavok/singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpHavok/singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpHavok/singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpHavok/singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpHavok/singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/phpHavok/singularity/languages","stargazers_url":"https://api.github.com/repos/phpHavok/singularity/stargazers","contributors_url":"https://api.github.com/repos/phpHavok/singularity/contributors","subscribers_url":"https://api.github.com/repos/phpHavok/singularity/subscribers","subscription_url":"https://api.github.com/repos/phpHavok/singularity/subscription","commits_url":"https://api.github.com/repos/phpHavok/singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpHavok/singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpHavok/singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpHavok/singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpHavok/singularity/contents/{+path}","compare_url":"https://api.github.com/repos/phpHavok/singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpHavok/singularity/merges","archive_url":"https://api.github.com/repos/phpHavok/singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpHavok/singularity/downloads","issues_url":"https://api.github.com/repos/phpHavok/singularity/issues{/number}","pulls_url":"https://api.github.com/repos/phpHavok/singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/phpHavok/singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/phpHavok/singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpHavok/singularity/labels{/name}","releases_url":"https://api.github.com/repos/phpHavok/singularity/releases{/id}","deployments_url":"https://api.github.com/repos/phpHavok/singularity/deployments","created_at":"2018-11-24T01:19:24Z","updated_at":"2019-03-18T22:53:50Z","pushed_at":"2019-03-18T23:50:27Z","git_url":"git://github.com/phpHavok/singularity.git","ssh_url":"git@github.com:phpHavok/singularity.git","clone_url":"https://github.com/phpHavok/singularity.git","svn_url":"https://github.com/phpHavok/singularity","homepage":"https://www.sylabs.io/singularity/","size":17821,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sylabs:master","ref":"master","sha":"8d93b6061a768687240aa45093eeb3c0365c0639","user":{"login":"sylabs","id":32401844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDAxODQ0","avatar_url":"https://avatars0.githubusercontent.com/u/32401844?v=4","gravatar_id":"","url":"https://api.github.com/users/sylabs","html_url":"https://github.com/sylabs","followers_url":"https://api.github.com/users/sylabs/followers","following_url":"https://api.github.com/users/sylabs/following{/other_user}","gists_url":"https://api.github.com/users/sylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/sylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylabs/subscriptions","organizations_url":"https://api.github.com/users/sylabs/orgs","repos_url":"https://api.github.com/users/sylabs/repos","events_url":"https://api.github.com/users/sylabs/events{/privacy}","received_events_url":"https://api.github.com/users/sylabs/received_events","type":"Organization","site_admin":false},"repo":{"id":43982667,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzk4MjY2Nw==","name":"singularity","full_name":"sylabs/singularity","private":false,"owner":{"login":"sylabs","id":32401844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDAxODQ0","avatar_url":"https://avatars0.githubusercontent.com/u/32401844?v=4","gravatar_id":"","url":"https://api.github.com/users/sylabs","html_url":"https://github.com/sylabs","followers_url":"https://api.github.com/users/sylabs/followers","following_url":"https://api.github.com/users/sylabs/following{/other_user}","gists_url":"https://api.github.com/users/sylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/sylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylabs/subscriptions","organizations_url":"https://api.github.com/users/sylabs/orgs","repos_url":"https://api.github.com/users/sylabs/repos","events_url":"https://api.github.com/users/sylabs/events{/privacy}","received_events_url":"https://api.github.com/users/sylabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sylabs/singularity","description":"Singularity: Application containers for Linux","fork":false,"url":"https://api.github.com/repos/sylabs/singularity","forks_url":"https://api.github.com/repos/sylabs/singularity/forks","keys_url":"https://api.github.com/repos/sylabs/singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sylabs/singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sylabs/singularity/teams","hooks_url":"https://api.github.com/repos/sylabs/singularity/hooks","issue_events_url":"https://api.github.com/repos/sylabs/singularity/issues/events{/number}","events_url":"https://api.github.com/repos/sylabs/singularity/events","assignees_url":"https://api.github.com/repos/sylabs/singularity/assignees{/user}","branches_url":"https://api.github.com/repos/sylabs/singularity/branches{/branch}","tags_url":"https://api.github.com/repos/sylabs/singularity/tags","blobs_url":"https://api.github.com/repos/sylabs/singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sylabs/singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sylabs/singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/sylabs/singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sylabs/singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/sylabs/singularity/languages","stargazers_url":"https://api.github.com/repos/sylabs/singularity/stargazers","contributors_url":"https://api.github.com/repos/sylabs/singularity/contributors","subscribers_url":"https://api.github.com/repos/sylabs/singularity/subscribers","subscription_url":"https://api.github.com/repos/sylabs/singularity/subscription","commits_url":"https://api.github.com/repos/sylabs/singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/sylabs/singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/sylabs/singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/sylabs/singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/sylabs/singularity/contents/{+path}","compare_url":"https://api.github.com/repos/sylabs/singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sylabs/singularity/merges","archive_url":"https://api.github.com/repos/sylabs/singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sylabs/singularity/downloads","issues_url":"https://api.github.com/repos/sylabs/singularity/issues{/number}","pulls_url":"https://api.github.com/repos/sylabs/singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/sylabs/singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/sylabs/singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sylabs/singularity/labels{/name}","releases_url":"https://api.github.com/repos/sylabs/singularity/releases{/id}","deployments_url":"https://api.github.com/repos/sylabs/singularity/deployments","created_at":"2015-10-09T22:15:12Z","updated_at":"2019-03-19T19:06:36Z","pushed_at":"2019-03-19T19:34:29Z","git_url":"git://github.com/sylabs/singularity.git","ssh_url":"git@github.com:sylabs/singularity.git","clone_url":"https://github.com/sylabs/singularity.git","svn_url":"https://github.com/sylabs/singularity","homepage":"https://www.sylabs.io/singularity/","size":17850,"stargazers_count":1072,"watchers_count":1072,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"archived":false,"open_issues_count":442,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":260,"open_issues":442,"watchers":1072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sylabs/singularity/pulls/2918"},"html":{"href":"https://github.com/sylabs/singularity/pull/2918"},"issue":{"href":"https://api.github.com/repos/sylabs/singularity/issues/2918"},"comments":{"href":"https://api.github.com/repos/sylabs/singularity/issues/2918/comments"},"review_comments":{"href":"https://api.github.com/repos/sylabs/singularity/pulls/2918/comments"},"review_comment":{"href":"https://api.github.com/repos/sylabs/singularity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sylabs/singularity/pulls/2918/commits"},"statuses":{"href":"https://api.github.com/repos/sylabs/singularity/statuses/c2729479b1e86eaa7dab5ca0c48803bfb6dfb3c8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mem"}}