{"action":"created","comment":{"url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/comments/270337350","pull_request_review_id":220447019,"id":270337350,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MDMzNzM1MA==","diff_hunk":"@@ -134,4 +154,26 @@ Public Class dlgSplitText\n     Private Sub Controls_ControlContentsChanged(ucrChangedControl As ucrCore) Handles ucrInputPattern.ControlContentsChanged, ucrReceiverSplitTextColumn.ControlContentsChanged, ucrNudPieces.ControlContentsChanged, ucrSaveColumn.ControlContentsChanged, ucrPnlSplitText.ControlContentsChanged\r\n         TestOKEnabled()\r\n     End Sub\r\n+\r\n+    Private Sub rdoFixedNumberOfComponents_CheckedChanged(sender As Object, e As EventArgs) Handles rdoFixedNumberOfComponents.CheckedChanged\r\n+        ucrNudPieces.Show()\r\n+    End Sub\r\n+\r\n+    Private Sub rdoMaximumNumberOfComponents_CheckedChanged(sender As Object, e As EventArgs) Handles rdoMaximumNumberOfComponents.CheckedChanged\r\n+        ucrNudPieces.Hide()\r\n+    End Sub\r\n+\r\n+    Private Sub ucrPnlTextComponents_ControlValueChanged(ucrChangedControl As ucrCore) Handles ucrPnlTextComponents.ControlValueChanged\r\n+        SplitTextOptions()\r","path":"instat/dlgSplitText.vb","position":120,"original_position":107,"commit_id":"4d82d3e6831a8d7b09740ef88b333e2b93e38e96","original_commit_id":"13327304b4f2e6cdf9ac74e677098196278602d5","user":{"login":"dannyparsons","id":11214914,"node_id":"MDQ6VXNlcjExMjE0OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/11214914?v=4","gravatar_id":"","url":"https://api.github.com/users/dannyparsons","html_url":"https://github.com/dannyparsons","followers_url":"https://api.github.com/users/dannyparsons/followers","following_url":"https://api.github.com/users/dannyparsons/following{/other_user}","gists_url":"https://api.github.com/users/dannyparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyparsons/subscriptions","organizations_url":"https://api.github.com/users/dannyparsons/orgs","repos_url":"https://api.github.com/users/dannyparsons/repos","events_url":"https://api.github.com/users/dannyparsons/events{/privacy}","received_events_url":"https://api.github.com/users/dannyparsons/received_events","type":"User","site_admin":false},"body":"Yes and it should only be on `ControlValueChanged`. `ControlContentsChanged` is used for doing non code checks, like setting OK enabled.","created_at":"2019-03-29T09:41:17Z","updated_at":"2019-03-29T09:41:22Z","html_url":"https://github.com/africanmathsinitiative/R-Instat/pull/5213#discussion_r270337350","pull_request_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5213","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/comments/270337350"},"html":{"href":"https://github.com/africanmathsinitiative/R-Instat/pull/5213#discussion_r270337350"},"pull_request":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5213"}},"in_reply_to_id":261486217},"pull_request":{"url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5213","id":256951150,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2OTUxMTUw","html_url":"https://github.com/africanmathsinitiative/R-Instat/pull/5213","diff_url":"https://github.com/africanmathsinitiative/R-Instat/pull/5213.diff","patch_url":"https://github.com/africanmathsinitiative/R-Instat/pull/5213.patch","issue_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/5213","number":5213,"state":"open","locked":false,"title":"Split text","user":{"login":"Ivanluv","id":45068931,"node_id":"MDQ6VXNlcjQ1MDY4OTMx","avatar_url":"https://avatars3.githubusercontent.com/u/45068931?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivanluv","html_url":"https://github.com/Ivanluv","followers_url":"https://api.github.com/users/Ivanluv/followers","following_url":"https://api.github.com/users/Ivanluv/following{/other_user}","gists_url":"https://api.github.com/users/Ivanluv/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivanluv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivanluv/subscriptions","organizations_url":"https://api.github.com/users/Ivanluv/orgs","repos_url":"https://api.github.com/users/Ivanluv/repos","events_url":"https://api.github.com/users/Ivanluv/events{/privacy}","received_events_url":"https://api.github.com/users/Ivanluv/received_events","type":"User","site_admin":false},"body":"fixes #5194 \r\n@africanmathsinitiative/developers  this is ready for review","created_at":"2019-02-28T06:46:31Z","updated_at":"2019-03-29T09:41:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0297cd482d927447eaab067a2d177d08f36fb61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/milestones/40","html_url":"https://github.com/africanmathsinitiative/R-Instat/milestone/40","labels_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/milestones/40/labels","id":4156537,"node_id":"MDk6TWlsZXN0b25lNDE1NjUzNw==","number":40,"title":"0.4.x","description":"","creator":{"login":"dannyparsons","id":11214914,"node_id":"MDQ6VXNlcjExMjE0OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/11214914?v=4","gravatar_id":"","url":"https://api.github.com/users/dannyparsons","html_url":"https://github.com/dannyparsons","followers_url":"https://api.github.com/users/dannyparsons/followers","following_url":"https://api.github.com/users/dannyparsons/following{/other_user}","gists_url":"https://api.github.com/users/dannyparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyparsons/subscriptions","organizations_url":"https://api.github.com/users/dannyparsons/orgs","repos_url":"https://api.github.com/users/dannyparsons/repos","events_url":"https://api.github.com/users/dannyparsons/events{/privacy}","received_events_url":"https://api.github.com/users/dannyparsons/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":6,"state":"open","created_at":"2019-03-20T07:34:13Z","updated_at":"2019-03-29T07:33:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5213/commits","review_comments_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5213/comments","review_comment_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/5213/comments","statuses_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/statuses/4d82d3e6831a8d7b09740ef88b333e2b93e38e96","head":{"label":"Ivanluv:SplitText","ref":"SplitText","sha":"4d82d3e6831a8d7b09740ef88b333e2b93e38e96","user":{"login":"Ivanluv","id":45068931,"node_id":"MDQ6VXNlcjQ1MDY4OTMx","avatar_url":"https://avatars3.githubusercontent.com/u/45068931?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivanluv","html_url":"https://github.com/Ivanluv","followers_url":"https://api.github.com/users/Ivanluv/followers","following_url":"https://api.github.com/users/Ivanluv/following{/other_user}","gists_url":"https://api.github.com/users/Ivanluv/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivanluv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivanluv/subscriptions","organizations_url":"https://api.github.com/users/Ivanluv/orgs","repos_url":"https://api.github.com/users/Ivanluv/repos","events_url":"https://api.github.com/users/Ivanluv/events{/privacy}","received_events_url":"https://api.github.com/users/Ivanluv/received_events","type":"User","site_admin":false},"repo":{"id":165000451,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUwMDA0NTE=","name":"R-Instat","full_name":"Ivanluv/R-Instat","private":false,"owner":{"login":"Ivanluv","id":45068931,"node_id":"MDQ6VXNlcjQ1MDY4OTMx","avatar_url":"https://avatars3.githubusercontent.com/u/45068931?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivanluv","html_url":"https://github.com/Ivanluv","followers_url":"https://api.github.com/users/Ivanluv/followers","following_url":"https://api.github.com/users/Ivanluv/following{/other_user}","gists_url":"https://api.github.com/users/Ivanluv/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivanluv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivanluv/subscriptions","organizations_url":"https://api.github.com/users/Ivanluv/orgs","repos_url":"https://api.github.com/users/Ivanluv/repos","events_url":"https://api.github.com/users/Ivanluv/events{/privacy}","received_events_url":"https://api.github.com/users/Ivanluv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Ivanluv/R-Instat","description":"A statistics software package powered by R","fork":true,"url":"https://api.github.com/repos/Ivanluv/R-Instat","forks_url":"https://api.github.com/repos/Ivanluv/R-Instat/forks","keys_url":"https://api.github.com/repos/Ivanluv/R-Instat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ivanluv/R-Instat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ivanluv/R-Instat/teams","hooks_url":"https://api.github.com/repos/Ivanluv/R-Instat/hooks","issue_events_url":"https://api.github.com/repos/Ivanluv/R-Instat/issues/events{/number}","events_url":"https://api.github.com/repos/Ivanluv/R-Instat/events","assignees_url":"https://api.github.com/repos/Ivanluv/R-Instat/assignees{/user}","branches_url":"https://api.github.com/repos/Ivanluv/R-Instat/branches{/branch}","tags_url":"https://api.github.com/repos/Ivanluv/R-Instat/tags","blobs_url":"https://api.github.com/repos/Ivanluv/R-Instat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ivanluv/R-Instat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ivanluv/R-Instat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ivanluv/R-Instat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ivanluv/R-Instat/statuses/{sha}","languages_url":"https://api.github.com/repos/Ivanluv/R-Instat/languages","stargazers_url":"https://api.github.com/repos/Ivanluv/R-Instat/stargazers","contributors_url":"https://api.github.com/repos/Ivanluv/R-Instat/contributors","subscribers_url":"https://api.github.com/repos/Ivanluv/R-Instat/subscribers","subscription_url":"https://api.github.com/repos/Ivanluv/R-Instat/subscription","commits_url":"https://api.github.com/repos/Ivanluv/R-Instat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ivanluv/R-Instat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ivanluv/R-Instat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ivanluv/R-Instat/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ivanluv/R-Instat/contents/{+path}","compare_url":"https://api.github.com/repos/Ivanluv/R-Instat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ivanluv/R-Instat/merges","archive_url":"https://api.github.com/repos/Ivanluv/R-Instat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ivanluv/R-Instat/downloads","issues_url":"https://api.github.com/repos/Ivanluv/R-Instat/issues{/number}","pulls_url":"https://api.github.com/repos/Ivanluv/R-Instat/pulls{/number}","milestones_url":"https://api.github.com/repos/Ivanluv/R-Instat/milestones{/number}","notifications_url":"https://api.github.com/repos/Ivanluv/R-Instat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ivanluv/R-Instat/labels{/name}","releases_url":"https://api.github.com/repos/Ivanluv/R-Instat/releases{/id}","deployments_url":"https://api.github.com/repos/Ivanluv/R-Instat/deployments","created_at":"2019-01-10T06:06:39Z","updated_at":"2019-03-25T07:18:34Z","pushed_at":"2019-03-28T20:24:19Z","git_url":"git://github.com/Ivanluv/R-Instat.git","ssh_url":"git@github.com:Ivanluv/R-Instat.git","clone_url":"https://github.com/Ivanluv/R-Instat.git","svn_url":"https://github.com/Ivanluv/R-Instat","homepage":"http://r-instat.org/","size":3366704,"stargazers_count":0,"watchers_count":0,"language":"Visual Basic","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"africanmathsinitiative:master","ref":"master","sha":"8ac1f53ce423d0c48ce4039d6d070802f580e302","user":{"login":"africanmathsinitiative","id":13917566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTE3NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/13917566?v=4","gravatar_id":"","url":"https://api.github.com/users/africanmathsinitiative","html_url":"https://github.com/africanmathsinitiative","followers_url":"https://api.github.com/users/africanmathsinitiative/followers","following_url":"https://api.github.com/users/africanmathsinitiative/following{/other_user}","gists_url":"https://api.github.com/users/africanmathsinitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/africanmathsinitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/africanmathsinitiative/subscriptions","organizations_url":"https://api.github.com/users/africanmathsinitiative/orgs","repos_url":"https://api.github.com/users/africanmathsinitiative/repos","events_url":"https://api.github.com/users/africanmathsinitiative/events{/privacy}","received_events_url":"https://api.github.com/users/africanmathsinitiative/received_events","type":"Organization","site_admin":false},"repo":{"id":44009238,"node_id":"MDEwOlJlcG9zaXRvcnk0NDAwOTIzOA==","name":"R-Instat","full_name":"africanmathsinitiative/R-Instat","private":false,"owner":{"login":"africanmathsinitiative","id":13917566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTE3NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/13917566?v=4","gravatar_id":"","url":"https://api.github.com/users/africanmathsinitiative","html_url":"https://github.com/africanmathsinitiative","followers_url":"https://api.github.com/users/africanmathsinitiative/followers","following_url":"https://api.github.com/users/africanmathsinitiative/following{/other_user}","gists_url":"https://api.github.com/users/africanmathsinitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/africanmathsinitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/africanmathsinitiative/subscriptions","organizations_url":"https://api.github.com/users/africanmathsinitiative/orgs","repos_url":"https://api.github.com/users/africanmathsinitiative/repos","events_url":"https://api.github.com/users/africanmathsinitiative/events{/privacy}","received_events_url":"https://api.github.com/users/africanmathsinitiative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/africanmathsinitiative/R-Instat","description":"A statistics software package powered by R","fork":false,"url":"https://api.github.com/repos/africanmathsinitiative/R-Instat","forks_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/forks","keys_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/teams","hooks_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/hooks","issue_events_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/events{/number}","events_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/events","assignees_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/assignees{/user}","branches_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/branches{/branch}","tags_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/tags","blobs_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/git/refs{/sha}","trees_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/statuses/{sha}","languages_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/languages","stargazers_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/stargazers","contributors_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/contributors","subscribers_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/subscribers","subscription_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/subscription","commits_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/commits{/sha}","git_commits_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/git/commits{/sha}","comments_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/comments{/number}","issue_comment_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/comments{/number}","contents_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/contents/{+path}","compare_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/merges","archive_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/downloads","issues_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues{/number}","pulls_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls{/number}","milestones_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/milestones{/number}","notifications_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/labels{/name}","releases_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/releases{/id}","deployments_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/deployments","created_at":"2015-10-10T12:10:32Z","updated_at":"2019-03-28T18:07:53Z","pushed_at":"2019-03-29T07:58:56Z","git_url":"git://github.com/africanmathsinitiative/R-Instat.git","ssh_url":"git@github.com:africanmathsinitiative/R-Instat.git","clone_url":"https://github.com/africanmathsinitiative/R-Instat.git","svn_url":"https://github.com/africanmathsinitiative/R-Instat","homepage":"http://r-instat.org/","size":3459774,"stargazers_count":14,"watchers_count":14,"language":"Visual Basic","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":579,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":53,"open_issues":579,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5213"},"html":{"href":"https://github.com/africanmathsinitiative/R-Instat/pull/5213"},"issue":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/5213"},"comments":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/5213/comments"},"review_comments":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5213/comments"},"review_comment":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5213/commits"},"statuses":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/statuses/4d82d3e6831a8d7b09740ef88b333e2b93e38e96"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dannyparsons"}}