{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/280061619","pull_request_review_id":232558839,"id":280061619,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDA2MTYxOQ==","diff_hunk":"@@ -15,4 +15,9 @@ public function setProps($name)\n     {\n         $this->_setModelClass($name);\n     }\n+\n+    public function getProp($name)","path":"tests/test_app/TestApp/Stub/Stub.php","position":5,"original_position":5,"commit_id":"9676d23ac5f0cb65686c220e06596c9477f4011e","original_commit_id":"9676d23ac5f0cb65686c220e06596c9477f4011e","user":{"login":"dereuromark","id":39854,"node_id":"MDQ6VXNlcjM5ODU0","avatar_url":"https://avatars0.githubusercontent.com/u/39854?v=4","gravatar_id":"","url":"https://api.github.com/users/dereuromark","html_url":"https://github.com/dereuromark","followers_url":"https://api.github.com/users/dereuromark/followers","following_url":"https://api.github.com/users/dereuromark/following{/other_user}","gists_url":"https://api.github.com/users/dereuromark/gists{/gist_id}","starred_url":"https://api.github.com/users/dereuromark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereuromark/subscriptions","organizations_url":"https://api.github.com/users/dereuromark/orgs","repos_url":"https://api.github.com/users/dereuromark/repos","events_url":"https://api.github.com/users/dereuromark/events{/privacy}","received_events_url":"https://api.github.com/users/dereuromark/received_events","type":"User","site_admin":false},"body":"My logic is: If it is used wrong, then the expected results are also not what you want.\r\nSo probably worth also in those cases. But no biggie.","created_at":"2019-05-01T12:45:20Z","updated_at":"2019-05-01T12:45:20Z","html_url":"https://github.com/cakephp/cakephp/pull/13179#discussion_r280061619","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/13179","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/280061619"},"html":{"href":"https://github.com/cakephp/cakephp/pull/13179#discussion_r280061619"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13179"}},"in_reply_to_id":280060855},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/13179","id":275016913,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1MDE2OTEz","html_url":"https://github.com/cakephp/cakephp/pull/13179","diff_url":"https://github.com/cakephp/cakephp/pull/13179.diff","patch_url":"https://github.com/cakephp/cakephp/pull/13179.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/13179","number":13179,"state":"open","locked":false,"title":"Make ModelAwareTrait::$modelClass protected.","user":{"login":"ADmad","id":142658,"node_id":"MDQ6VXNlcjE0MjY1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/142658?v=4","gravatar_id":"","url":"https://api.github.com/users/ADmad","html_url":"https://github.com/ADmad","followers_url":"https://api.github.com/users/ADmad/followers","following_url":"https://api.github.com/users/ADmad/following{/other_user}","gists_url":"https://api.github.com/users/ADmad/gists{/gist_id}","starred_url":"https://api.github.com/users/ADmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ADmad/subscriptions","organizations_url":"https://api.github.com/users/ADmad/orgs","repos_url":"https://api.github.com/users/ADmad/repos","events_url":"https://api.github.com/users/ADmad/events{/privacy}","received_events_url":"https://api.github.com/users/ADmad/received_events","type":"User","site_admin":false},"body":"Allow setting the property to empty string in controller to indicate\r\nthat controller does not use a default model.\r\n\r\nAlternate to #13178.","created_at":"2019-05-01T12:20:36Z","updated_at":"2019-05-01T12:45:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9f8e6005781b4eead6467aa4a37f2c5b3cddb53","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/105","html_url":"https://github.com/cakephp/cakephp/milestone/105","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/105/labels","id":2023366,"node_id":"MDk6TWlsZXN0b25lMjAyMzM2Ng==","number":105,"title":"4.0.0","description":"4.0.0 is an *API breaking* release. It will:\r\n\r\n* Remove the features deprecated in 3.x.\r\n\r\nCode that works in the latest 3.x with no deprecation warnings should work in 4.0.0 as well.\r\n\r\nSee the roadmap for more information https://github.com/cakephp/cakephp/wiki/4.0-Roadmap","creator":{"login":"markstory","id":24086,"node_id":"MDQ6VXNlcjI0MDg2","avatar_url":"https://avatars3.githubusercontent.com/u/24086?v=4","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":345,"state":"open","created_at":"2016-09-23T01:51:53Z","updated_at":"2019-05-01T12:42:45Z","due_on":"2019-05-11T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/13179/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/13179/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/13179/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/9676d23ac5f0cb65686c220e06596c9477f4011e","head":{"label":"ADmad:4.x-modelclass","ref":"4.x-modelclass","sha":"9676d23ac5f0cb65686c220e06596c9477f4011e","user":{"login":"ADmad","id":142658,"node_id":"MDQ6VXNlcjE0MjY1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/142658?v=4","gravatar_id":"","url":"https://api.github.com/users/ADmad","html_url":"https://github.com/ADmad","followers_url":"https://api.github.com/users/ADmad/followers","following_url":"https://api.github.com/users/ADmad/following{/other_user}","gists_url":"https://api.github.com/users/ADmad/gists{/gist_id}","starred_url":"https://api.github.com/users/ADmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ADmad/subscriptions","organizations_url":"https://api.github.com/users/ADmad/orgs","repos_url":"https://api.github.com/users/ADmad/repos","events_url":"https://api.github.com/users/ADmad/events{/privacy}","received_events_url":"https://api.github.com/users/ADmad/received_events","type":"User","site_admin":false},"repo":{"id":1198215,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk4MjE1","name":"cakephp","full_name":"ADmad/cakephp","private":false,"owner":{"login":"ADmad","id":142658,"node_id":"MDQ6VXNlcjE0MjY1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/142658?v=4","gravatar_id":"","url":"https://api.github.com/users/ADmad","html_url":"https://github.com/ADmad","followers_url":"https://api.github.com/users/ADmad/followers","following_url":"https://api.github.com/users/ADmad/following{/other_user}","gists_url":"https://api.github.com/users/ADmad/gists{/gist_id}","starred_url":"https://api.github.com/users/ADmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ADmad/subscriptions","organizations_url":"https://api.github.com/users/ADmad/orgs","repos_url":"https://api.github.com/users/ADmad/repos","events_url":"https://api.github.com/users/ADmad/events{/privacy}","received_events_url":"https://api.github.com/users/ADmad/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ADmad/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/ADmad/cakephp","forks_url":"https://api.github.com/repos/ADmad/cakephp/forks","keys_url":"https://api.github.com/repos/ADmad/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ADmad/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ADmad/cakephp/teams","hooks_url":"https://api.github.com/repos/ADmad/cakephp/hooks","issue_events_url":"https://api.github.com/repos/ADmad/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/ADmad/cakephp/events","assignees_url":"https://api.github.com/repos/ADmad/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/ADmad/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/ADmad/cakephp/tags","blobs_url":"https://api.github.com/repos/ADmad/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ADmad/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ADmad/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ADmad/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ADmad/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/ADmad/cakephp/languages","stargazers_url":"https://api.github.com/repos/ADmad/cakephp/stargazers","contributors_url":"https://api.github.com/repos/ADmad/cakephp/contributors","subscribers_url":"https://api.github.com/repos/ADmad/cakephp/subscribers","subscription_url":"https://api.github.com/repos/ADmad/cakephp/subscription","commits_url":"https://api.github.com/repos/ADmad/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ADmad/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ADmad/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ADmad/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ADmad/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/ADmad/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ADmad/cakephp/merges","archive_url":"https://api.github.com/repos/ADmad/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ADmad/cakephp/downloads","issues_url":"https://api.github.com/repos/ADmad/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/ADmad/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/ADmad/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/ADmad/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ADmad/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/ADmad/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/ADmad/cakephp/deployments","created_at":"2010-12-26T06:44:37Z","updated_at":"2019-02-27T05:59:38Z","pushed_at":"2019-05-01T12:26:08Z","git_url":"git://github.com/ADmad/cakephp.git","ssh_url":"git@github.com:ADmad/cakephp.git","clone_url":"https://github.com/ADmad/cakephp.git","svn_url":"https://github.com/ADmad/cakephp","homepage":"http://cakephp.org","size":78776,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"cakephp:4.x","ref":"4.x","sha":"dbc8f639a231a63f005ab6a0e24193d1497814fa","user":{"login":"cakephp","id":23666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjY2","avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"node_id":"MDEwOlJlcG9zaXRvcnk2NTY0OTQ=","name":"cakephp","full_name":"cakephp/cakephp","private":false,"owner":{"login":"cakephp","id":23666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjY2","avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2019-04-30T21:38:25Z","pushed_at":"2019-05-01T12:42:49Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":84228,"stargazers_count":7839,"watchers_count":7839,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3403,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":214,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3403,"open_issues":214,"watchers":7839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13179"},"html":{"href":"https://github.com/cakephp/cakephp/pull/13179"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/13179"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/13179/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13179/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13179/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/9676d23ac5f0cb65686c220e06596c9477f4011e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dereuromark"}}