{"action":"closed","number":26,"pull_request":{"url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/pulls/26","id":316002132,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2MDAyMTMy","html_url":"https://github.com/digipolisantwerp/starter-kit_app_nodejs/pull/26","diff_url":"https://github.com/digipolisantwerp/starter-kit_app_nodejs/pull/26.diff","patch_url":"https://github.com/digipolisantwerp/starter-kit_app_nodejs/pull/26.patch","issue_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/issues/26","number":26,"state":"closed","locked":false,"title":"Replace & test error middlewaere","user":{"login":"vademo","id":5577315,"node_id":"MDQ6VXNlcjU1NzczMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5577315?v=4","gravatar_id":"","url":"https://api.github.com/users/vademo","html_url":"https://github.com/vademo","followers_url":"https://api.github.com/users/vademo/followers","following_url":"https://api.github.com/users/vademo/following{/other_user}","gists_url":"https://api.github.com/users/vademo/gists{/gist_id}","starred_url":"https://api.github.com/users/vademo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vademo/subscriptions","organizations_url":"https://api.github.com/users/vademo/orgs","repos_url":"https://api.github.com/users/vademo/repos","events_url":"https://api.github.com/users/vademo/events{/privacy}","received_events_url":"https://api.github.com/users/vademo/received_events","type":"User","site_admin":false},"body":"    - Remove curry pattern (Seems to add unnecessary complexity to start, a logging service could be a helper function that uses ENV as its config, this passing the logging function around as an argument)\r\n    - Add tests for error middleware\r\n    - Add eslint to default test & fix warnings\r\n    - Add test for fallback route * to cover 100%","created_at":"2019-09-10T13:44:10Z","updated_at":"2019-09-16T09:24:57Z","closed_at":"2019-09-16T09:24:57Z","merged_at":"2019-09-16T09:24:57Z","merge_commit_sha":"0c7eb5146cf127fc84f3a1ee44c3ff390982353e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"frankdsm","id":304921,"node_id":"MDQ6VXNlcjMwNDkyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/304921?v=4","gravatar_id":"","url":"https://api.github.com/users/frankdsm","html_url":"https://github.com/frankdsm","followers_url":"https://api.github.com/users/frankdsm/followers","following_url":"https://api.github.com/users/frankdsm/following{/other_user}","gists_url":"https://api.github.com/users/frankdsm/gists{/gist_id}","starred_url":"https://api.github.com/users/frankdsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankdsm/subscriptions","organizations_url":"https://api.github.com/users/frankdsm/orgs","repos_url":"https://api.github.com/users/frankdsm/repos","events_url":"https://api.github.com/users/frankdsm/events{/privacy}","received_events_url":"https://api.github.com/users/frankdsm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/pulls/26/commits","review_comments_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/pulls/26/comments","review_comment_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/issues/26/comments","statuses_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/statuses/dfe0f248d7f7766bd244a99a4b514d07de3daab9","head":{"label":"digipolisantwerp:feature/errorHandling","ref":"feature/errorHandling","sha":"dfe0f248d7f7766bd244a99a4b514d07de3daab9","user":{"login":"digipolisantwerp","id":16398335,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mzk4MzM1","avatar_url":"https://avatars2.githubusercontent.com/u/16398335?v=4","gravatar_id":"","url":"https://api.github.com/users/digipolisantwerp","html_url":"https://github.com/digipolisantwerp","followers_url":"https://api.github.com/users/digipolisantwerp/followers","following_url":"https://api.github.com/users/digipolisantwerp/following{/other_user}","gists_url":"https://api.github.com/users/digipolisantwerp/gists{/gist_id}","starred_url":"https://api.github.com/users/digipolisantwerp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digipolisantwerp/subscriptions","organizations_url":"https://api.github.com/users/digipolisantwerp/orgs","repos_url":"https://api.github.com/users/digipolisantwerp/repos","events_url":"https://api.github.com/users/digipolisantwerp/events{/privacy}","received_events_url":"https://api.github.com/users/digipolisantwerp/received_events","type":"Organization","site_admin":false},"repo":{"id":130718005,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3MTgwMDU=","name":"starter-kit_app_nodejs","full_name":"digipolisantwerp/starter-kit_app_nodejs","private":false,"owner":{"login":"digipolisantwerp","id":16398335,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mzk4MzM1","avatar_url":"https://avatars2.githubusercontent.com/u/16398335?v=4","gravatar_id":"","url":"https://api.github.com/users/digipolisantwerp","html_url":"https://github.com/digipolisantwerp","followers_url":"https://api.github.com/users/digipolisantwerp/followers","following_url":"https://api.github.com/users/digipolisantwerp/following{/other_user}","gists_url":"https://api.github.com/users/digipolisantwerp/gists{/gist_id}","starred_url":"https://api.github.com/users/digipolisantwerp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digipolisantwerp/subscriptions","organizations_url":"https://api.github.com/users/digipolisantwerp/orgs","repos_url":"https://api.github.com/users/digipolisantwerp/repos","events_url":"https://api.github.com/users/digipolisantwerp/events{/privacy}","received_events_url":"https://api.github.com/users/digipolisantwerp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digipolisantwerp/starter-kit_app_nodejs","description":null,"fork":false,"url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs","forks_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/forks","keys_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/teams","hooks_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/hooks","issue_events_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/events","assignees_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/tags","blobs_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/languages","stargazers_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/stargazers","contributors_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/contributors","subscribers_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/subscribers","subscription_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/subscription","commits_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/merges","archive_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/downloads","issues_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/labels{/name}","releases_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/deployments","created_at":"2018-04-23T15:28:58Z","updated_at":"2019-09-10T06:45:19Z","pushed_at":"2019-09-16T09:24:57Z","git_url":"git://github.com/digipolisantwerp/starter-kit_app_nodejs.git","ssh_url":"git@github.com:digipolisantwerp/starter-kit_app_nodejs.git","clone_url":"https://github.com/digipolisantwerp/starter-kit_app_nodejs.git","svn_url":"https://github.com/digipolisantwerp/starter-kit_app_nodejs","homepage":null,"size":387,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":null,"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"digipolisantwerp:master","ref":"master","sha":"6cc2c220e5aa72b8b988854a767259a977438f45","user":{"login":"digipolisantwerp","id":16398335,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mzk4MzM1","avatar_url":"https://avatars2.githubusercontent.com/u/16398335?v=4","gravatar_id":"","url":"https://api.github.com/users/digipolisantwerp","html_url":"https://github.com/digipolisantwerp","followers_url":"https://api.github.com/users/digipolisantwerp/followers","following_url":"https://api.github.com/users/digipolisantwerp/following{/other_user}","gists_url":"https://api.github.com/users/digipolisantwerp/gists{/gist_id}","starred_url":"https://api.github.com/users/digipolisantwerp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digipolisantwerp/subscriptions","organizations_url":"https://api.github.com/users/digipolisantwerp/orgs","repos_url":"https://api.github.com/users/digipolisantwerp/repos","events_url":"https://api.github.com/users/digipolisantwerp/events{/privacy}","received_events_url":"https://api.github.com/users/digipolisantwerp/received_events","type":"Organization","site_admin":false},"repo":{"id":130718005,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3MTgwMDU=","name":"starter-kit_app_nodejs","full_name":"digipolisantwerp/starter-kit_app_nodejs","private":false,"owner":{"login":"digipolisantwerp","id":16398335,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mzk4MzM1","avatar_url":"https://avatars2.githubusercontent.com/u/16398335?v=4","gravatar_id":"","url":"https://api.github.com/users/digipolisantwerp","html_url":"https://github.com/digipolisantwerp","followers_url":"https://api.github.com/users/digipolisantwerp/followers","following_url":"https://api.github.com/users/digipolisantwerp/following{/other_user}","gists_url":"https://api.github.com/users/digipolisantwerp/gists{/gist_id}","starred_url":"https://api.github.com/users/digipolisantwerp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digipolisantwerp/subscriptions","organizations_url":"https://api.github.com/users/digipolisantwerp/orgs","repos_url":"https://api.github.com/users/digipolisantwerp/repos","events_url":"https://api.github.com/users/digipolisantwerp/events{/privacy}","received_events_url":"https://api.github.com/users/digipolisantwerp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digipolisantwerp/starter-kit_app_nodejs","description":null,"fork":false,"url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs","forks_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/forks","keys_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/teams","hooks_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/hooks","issue_events_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/events","assignees_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/tags","blobs_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/languages","stargazers_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/stargazers","contributors_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/contributors","subscribers_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/subscribers","subscription_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/subscription","commits_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/merges","archive_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/downloads","issues_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/labels{/name}","releases_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/deployments","created_at":"2018-04-23T15:28:58Z","updated_at":"2019-09-10T06:45:19Z","pushed_at":"2019-09-16T09:24:57Z","git_url":"git://github.com/digipolisantwerp/starter-kit_app_nodejs.git","ssh_url":"git@github.com:digipolisantwerp/starter-kit_app_nodejs.git","clone_url":"https://github.com/digipolisantwerp/starter-kit_app_nodejs.git","svn_url":"https://github.com/digipolisantwerp/starter-kit_app_nodejs","homepage":null,"size":387,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":null,"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/pulls/26"},"html":{"href":"https://github.com/digipolisantwerp/starter-kit_app_nodejs/pull/26"},"issue":{"href":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/issues/26"},"comments":{"href":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/digipolisantwerp/starter-kit_app_nodejs/statuses/dfe0f248d7f7766bd244a99a4b514d07de3daab9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"vademo","id":5577315,"node_id":"MDQ6VXNlcjU1NzczMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5577315?v=4","gravatar_id":"","url":"https://api.github.com/users/vademo","html_url":"https://github.com/vademo","followers_url":"https://api.github.com/users/vademo/followers","following_url":"https://api.github.com/users/vademo/following{/other_user}","gists_url":"https://api.github.com/users/vademo/gists{/gist_id}","starred_url":"https://api.github.com/users/vademo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vademo/subscriptions","organizations_url":"https://api.github.com/users/vademo/orgs","repos_url":"https://api.github.com/users/vademo/repos","events_url":"https://api.github.com/users/vademo/events{/privacy}","received_events_url":"https://api.github.com/users/vademo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":6,"maintainer_can_modify":false,"commits":2,"additions":160,"deletions":63,"changed_files":9}}
{"actor":{"display_login":"vademo"}}