{"action":"created","comment":{"url":"https://api.github.com/repos/kymatio/kymatio/pulls/comments/328866507","pull_request_review_id":294055132,"id":328866507,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODg2NjUwNw==","diff_hunk":"@@ -13,4 +13,6 @@ Edouard Oyallon\n Dylan Simon\n Louis Thiry\n Sergey Zagoruyko\n-Jonas1312\n\\ No newline at end of file\n+Jonas1312","path":"CONTRIBUTORS.md","position":6,"original_position":6,"commit_id":"f34b75e442b21a3523d343abd25910a5dc208a3f","original_commit_id":"03558fe799e93a4580938bbe51106b0b6aa0bf2e","user":{"login":"lostanlen","id":3943142,"node_id":"MDQ6VXNlcjM5NDMxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3943142?v=4","gravatar_id":"","url":"https://api.github.com/users/lostanlen","html_url":"https://github.com/lostanlen","followers_url":"https://api.github.com/users/lostanlen/followers","following_url":"https://api.github.com/users/lostanlen/following{/other_user}","gists_url":"https://api.github.com/users/lostanlen/gists{/gist_id}","starred_url":"https://api.github.com/users/lostanlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostanlen/subscriptions","organizations_url":"https://api.github.com/users/lostanlen/orgs","repos_url":"https://api.github.com/users/lostanlen/repos","events_url":"https://api.github.com/users/lostanlen/events{/privacy}","received_events_url":"https://api.github.com/users/lostanlen/received_events","type":"User","site_admin":false},"body":"it's been a month since this. let's make the replacement to first name - last name","created_at":"2019-09-26T23:36:01Z","updated_at":"2019-09-26T23:36:01Z","html_url":"https://github.com/kymatio/kymatio/pull/415#discussion_r328866507","pull_request_url":"https://api.github.com/repos/kymatio/kymatio/pulls/415","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kymatio/kymatio/pulls/comments/328866507"},"html":{"href":"https://github.com/kymatio/kymatio/pull/415#discussion_r328866507"},"pull_request":{"href":"https://api.github.com/repos/kymatio/kymatio/pulls/415"}},"in_reply_to_id":314350346},"pull_request":{"url":"https://api.github.com/repos/kymatio/kymatio/pulls/415","id":300240069,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMjQwMDY5","html_url":"https://github.com/kymatio/kymatio/pull/415","diff_url":"https://github.com/kymatio/kymatio/pull/415.diff","patch_url":"https://github.com/kymatio/kymatio/pull/415.patch","issue_url":"https://api.github.com/repos/kymatio/kymatio/issues/415","number":415,"state":"open","locked":false,"title":"ENH(merge!) Kymatio 2D torch/numpy frontend/backend","user":{"login":"edouardoyallon","id":4263222,"node_id":"MDQ6VXNlcjQyNjMyMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4263222?v=4","gravatar_id":"","url":"https://api.github.com/users/edouardoyallon","html_url":"https://github.com/edouardoyallon","followers_url":"https://api.github.com/users/edouardoyallon/followers","following_url":"https://api.github.com/users/edouardoyallon/following{/other_user}","gists_url":"https://api.github.com/users/edouardoyallon/gists{/gist_id}","starred_url":"https://api.github.com/users/edouardoyallon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edouardoyallon/subscriptions","organizations_url":"https://api.github.com/users/edouardoyallon/orgs","repos_url":"https://api.github.com/users/edouardoyallon/repos","events_url":"https://api.github.com/users/edouardoyallon/events{/privacy}","received_events_url":"https://api.github.com/users/edouardoyallon/received_events","type":"User","site_admin":false},"body":"This PR proposes a new mechanism for computing the scattering, that splits low level and high level calls, for the 2D scattering.\r\n\r\nExample of call:\r\n\r\n```\r\nfrom kymatio.scattering2d import Scattering2D_torch as Scattering2D\r\nfrom kymatio.scattering2d.backend import torch_backend as backend\r\nscattering = Scattering2D(J, shape=(M, N), pre_pad=pre_pad, backend=backend)\r\n```\r\nor\r\n```\r\nfrom kymatio.scattering2d import Scattering2D_torch as Scattering2D\r\nscattering = Scattering2D(J, shape=(M, N), pre_pad=pre_pad)\r\n```\r\n\r\nFix #414 \r\nFix #398 \r\n\r\n\r\n1. Add a backend and frontend support.\r\n2. Refactors the scattering into a functional manner: frontend, backend and core. Frontend calls core, which relies on backend to compute primitives.\r\n3. Refactors the tests into classes, via pytest. Each submodule of the backend is tested via a pytest class. The frontend is globally tested via a pytest class.\r\n4. Split frontend, backend and core into different subfolders.\r\n5. Remove the previous backend that was using config files, and redefines a backend as a possible argument to the frontend.\r\n6. Support a pure numpy and tensorflow backend.\r\n7. Add a template for the frontend\r\n8. Pass the backend as a namedtuple\r\n\r\n\r\n__TODO in a future PR__: Updating the documentation, testing the multi GPU support, incorporating more tests for the numpy backend, unifications, more tests for the backend-frontend links(e.g., avoiding a numpy backend on a torch backend), adding the 1D-3D core","created_at":"2019-07-23T10:58:16Z","updated_at":"2019-09-26T23:36:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f536e4e68a5175c15eea869c9adea39be1781e4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lostanlen","id":3943142,"node_id":"MDQ6VXNlcjM5NDMxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3943142?v=4","gravatar_id":"","url":"https://api.github.com/users/lostanlen","html_url":"https://github.com/lostanlen","followers_url":"https://api.github.com/users/lostanlen/followers","following_url":"https://api.github.com/users/lostanlen/following{/other_user}","gists_url":"https://api.github.com/users/lostanlen/gists{/gist_id}","starred_url":"https://api.github.com/users/lostanlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostanlen/subscriptions","organizations_url":"https://api.github.com/users/lostanlen/orgs","repos_url":"https://api.github.com/users/lostanlen/repos","events_url":"https://api.github.com/users/lostanlen/events{/privacy}","received_events_url":"https://api.github.com/users/lostanlen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1163515489,"node_id":"MDU6TGFiZWwxMTYzNTE1NDg5","url":"https://api.github.com/repos/kymatio/kymatio/labels/2D","name":"2D","color":"74ed7c","default":false},{"id":1138929232,"node_id":"MDU6TGFiZWwxMTM4OTI5MjMy","url":"https://api.github.com/repos/kymatio/kymatio/labels/API","name":"API","color":"002fa7","default":false},{"id":1076176420,"node_id":"MDU6TGFiZWwxMDc2MTc2NDIw","url":"https://api.github.com/repos/kymatio/kymatio/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/kymatio/kymatio/pulls/415/commits","review_comments_url":"https://api.github.com/repos/kymatio/kymatio/pulls/415/comments","review_comment_url":"https://api.github.com/repos/kymatio/kymatio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kymatio/kymatio/issues/415/comments","statuses_url":"https://api.github.com/repos/kymatio/kymatio/statuses/f34b75e442b21a3523d343abd25910a5dc208a3f","head":{"label":"edouardoyallon:kymatio-dev-frontend","ref":"kymatio-dev-frontend","sha":"f34b75e442b21a3523d343abd25910a5dc208a3f","user":{"login":"edouardoyallon","id":4263222,"node_id":"MDQ6VXNlcjQyNjMyMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4263222?v=4","gravatar_id":"","url":"https://api.github.com/users/edouardoyallon","html_url":"https://github.com/edouardoyallon","followers_url":"https://api.github.com/users/edouardoyallon/followers","following_url":"https://api.github.com/users/edouardoyallon/following{/other_user}","gists_url":"https://api.github.com/users/edouardoyallon/gists{/gist_id}","starred_url":"https://api.github.com/users/edouardoyallon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edouardoyallon/subscriptions","organizations_url":"https://api.github.com/users/edouardoyallon/orgs","repos_url":"https://api.github.com/users/edouardoyallon/repos","events_url":"https://api.github.com/users/edouardoyallon/events{/privacy}","received_events_url":"https://api.github.com/users/edouardoyallon/received_events","type":"User","site_admin":false},"repo":{"id":158835786,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg4MzU3ODY=","name":"kymatio","full_name":"edouardoyallon/kymatio","private":false,"owner":{"login":"edouardoyallon","id":4263222,"node_id":"MDQ6VXNlcjQyNjMyMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4263222?v=4","gravatar_id":"","url":"https://api.github.com/users/edouardoyallon","html_url":"https://github.com/edouardoyallon","followers_url":"https://api.github.com/users/edouardoyallon/followers","following_url":"https://api.github.com/users/edouardoyallon/following{/other_user}","gists_url":"https://api.github.com/users/edouardoyallon/gists{/gist_id}","starred_url":"https://api.github.com/users/edouardoyallon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edouardoyallon/subscriptions","organizations_url":"https://api.github.com/users/edouardoyallon/orgs","repos_url":"https://api.github.com/users/edouardoyallon/repos","events_url":"https://api.github.com/users/edouardoyallon/events{/privacy}","received_events_url":"https://api.github.com/users/edouardoyallon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/edouardoyallon/kymatio","description":"Wavelet scattering transforms in Python with GPU acceleration","fork":true,"url":"https://api.github.com/repos/edouardoyallon/kymatio","forks_url":"https://api.github.com/repos/edouardoyallon/kymatio/forks","keys_url":"https://api.github.com/repos/edouardoyallon/kymatio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edouardoyallon/kymatio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edouardoyallon/kymatio/teams","hooks_url":"https://api.github.com/repos/edouardoyallon/kymatio/hooks","issue_events_url":"https://api.github.com/repos/edouardoyallon/kymatio/issues/events{/number}","events_url":"https://api.github.com/repos/edouardoyallon/kymatio/events","assignees_url":"https://api.github.com/repos/edouardoyallon/kymatio/assignees{/user}","branches_url":"https://api.github.com/repos/edouardoyallon/kymatio/branches{/branch}","tags_url":"https://api.github.com/repos/edouardoyallon/kymatio/tags","blobs_url":"https://api.github.com/repos/edouardoyallon/kymatio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edouardoyallon/kymatio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edouardoyallon/kymatio/git/refs{/sha}","trees_url":"https://api.github.com/repos/edouardoyallon/kymatio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edouardoyallon/kymatio/statuses/{sha}","languages_url":"https://api.github.com/repos/edouardoyallon/kymatio/languages","stargazers_url":"https://api.github.com/repos/edouardoyallon/kymatio/stargazers","contributors_url":"https://api.github.com/repos/edouardoyallon/kymatio/contributors","subscribers_url":"https://api.github.com/repos/edouardoyallon/kymatio/subscribers","subscription_url":"https://api.github.com/repos/edouardoyallon/kymatio/subscription","commits_url":"https://api.github.com/repos/edouardoyallon/kymatio/commits{/sha}","git_commits_url":"https://api.github.com/repos/edouardoyallon/kymatio/git/commits{/sha}","comments_url":"https://api.github.com/repos/edouardoyallon/kymatio/comments{/number}","issue_comment_url":"https://api.github.com/repos/edouardoyallon/kymatio/issues/comments{/number}","contents_url":"https://api.github.com/repos/edouardoyallon/kymatio/contents/{+path}","compare_url":"https://api.github.com/repos/edouardoyallon/kymatio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edouardoyallon/kymatio/merges","archive_url":"https://api.github.com/repos/edouardoyallon/kymatio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edouardoyallon/kymatio/downloads","issues_url":"https://api.github.com/repos/edouardoyallon/kymatio/issues{/number}","pulls_url":"https://api.github.com/repos/edouardoyallon/kymatio/pulls{/number}","milestones_url":"https://api.github.com/repos/edouardoyallon/kymatio/milestones{/number}","notifications_url":"https://api.github.com/repos/edouardoyallon/kymatio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edouardoyallon/kymatio/labels{/name}","releases_url":"https://api.github.com/repos/edouardoyallon/kymatio/releases{/id}","deployments_url":"https://api.github.com/repos/edouardoyallon/kymatio/deployments","created_at":"2018-11-23T13:21:50Z","updated_at":"2019-08-27T06:25:58Z","pushed_at":"2019-09-26T20:32:50Z","git_url":"git://github.com/edouardoyallon/kymatio.git","ssh_url":"git@github.com:edouardoyallon/kymatio.git","clone_url":"https://github.com/edouardoyallon/kymatio.git","svn_url":"https://github.com/edouardoyallon/kymatio","homepage":"https://kymat.io","size":6673,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"kymatio:master","ref":"master","sha":"fff9792fa4920a2f1bd04368df524c763c823344","user":{"login":"kymatio","id":45135504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTM1NTA0","avatar_url":"https://avatars1.githubusercontent.com/u/45135504?v=4","gravatar_id":"","url":"https://api.github.com/users/kymatio","html_url":"https://github.com/kymatio","followers_url":"https://api.github.com/users/kymatio/followers","following_url":"https://api.github.com/users/kymatio/following{/other_user}","gists_url":"https://api.github.com/users/kymatio/gists{/gist_id}","starred_url":"https://api.github.com/users/kymatio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kymatio/subscriptions","organizations_url":"https://api.github.com/users/kymatio/orgs","repos_url":"https://api.github.com/users/kymatio/repos","events_url":"https://api.github.com/users/kymatio/events{/privacy}","received_events_url":"https://api.github.com/users/kymatio/received_events","type":"Organization","site_admin":false},"repo":{"id":151186173,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExODYxNzM=","name":"kymatio","full_name":"kymatio/kymatio","private":false,"owner":{"login":"kymatio","id":45135504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTM1NTA0","avatar_url":"https://avatars1.githubusercontent.com/u/45135504?v=4","gravatar_id":"","url":"https://api.github.com/users/kymatio","html_url":"https://github.com/kymatio","followers_url":"https://api.github.com/users/kymatio/followers","following_url":"https://api.github.com/users/kymatio/following{/other_user}","gists_url":"https://api.github.com/users/kymatio/gists{/gist_id}","starred_url":"https://api.github.com/users/kymatio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kymatio/subscriptions","organizations_url":"https://api.github.com/users/kymatio/orgs","repos_url":"https://api.github.com/users/kymatio/repos","events_url":"https://api.github.com/users/kymatio/events{/privacy}","received_events_url":"https://api.github.com/users/kymatio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kymatio/kymatio","description":"Wavelet scattering transforms in Python with GPU acceleration","fork":false,"url":"https://api.github.com/repos/kymatio/kymatio","forks_url":"https://api.github.com/repos/kymatio/kymatio/forks","keys_url":"https://api.github.com/repos/kymatio/kymatio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kymatio/kymatio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kymatio/kymatio/teams","hooks_url":"https://api.github.com/repos/kymatio/kymatio/hooks","issue_events_url":"https://api.github.com/repos/kymatio/kymatio/issues/events{/number}","events_url":"https://api.github.com/repos/kymatio/kymatio/events","assignees_url":"https://api.github.com/repos/kymatio/kymatio/assignees{/user}","branches_url":"https://api.github.com/repos/kymatio/kymatio/branches{/branch}","tags_url":"https://api.github.com/repos/kymatio/kymatio/tags","blobs_url":"https://api.github.com/repos/kymatio/kymatio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kymatio/kymatio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kymatio/kymatio/git/refs{/sha}","trees_url":"https://api.github.com/repos/kymatio/kymatio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kymatio/kymatio/statuses/{sha}","languages_url":"https://api.github.com/repos/kymatio/kymatio/languages","stargazers_url":"https://api.github.com/repos/kymatio/kymatio/stargazers","contributors_url":"https://api.github.com/repos/kymatio/kymatio/contributors","subscribers_url":"https://api.github.com/repos/kymatio/kymatio/subscribers","subscription_url":"https://api.github.com/repos/kymatio/kymatio/subscription","commits_url":"https://api.github.com/repos/kymatio/kymatio/commits{/sha}","git_commits_url":"https://api.github.com/repos/kymatio/kymatio/git/commits{/sha}","comments_url":"https://api.github.com/repos/kymatio/kymatio/comments{/number}","issue_comment_url":"https://api.github.com/repos/kymatio/kymatio/issues/comments{/number}","contents_url":"https://api.github.com/repos/kymatio/kymatio/contents/{+path}","compare_url":"https://api.github.com/repos/kymatio/kymatio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kymatio/kymatio/merges","archive_url":"https://api.github.com/repos/kymatio/kymatio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kymatio/kymatio/downloads","issues_url":"https://api.github.com/repos/kymatio/kymatio/issues{/number}","pulls_url":"https://api.github.com/repos/kymatio/kymatio/pulls{/number}","milestones_url":"https://api.github.com/repos/kymatio/kymatio/milestones{/number}","notifications_url":"https://api.github.com/repos/kymatio/kymatio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kymatio/kymatio/labels{/name}","releases_url":"https://api.github.com/repos/kymatio/kymatio/releases{/id}","deployments_url":"https://api.github.com/repos/kymatio/kymatio/deployments","created_at":"2018-10-02T01:45:46Z","updated_at":"2019-09-26T22:26:02Z","pushed_at":"2019-09-26T20:35:31Z","git_url":"git://github.com/kymatio/kymatio.git","ssh_url":"git@github.com:kymatio/kymatio.git","clone_url":"https://github.com/kymatio/kymatio.git","svn_url":"https://github.com/kymatio/kymatio","homepage":"https://kymat.io","size":1634,"stargazers_count":222,"watchers_count":222,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":43,"open_issues":39,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kymatio/kymatio/pulls/415"},"html":{"href":"https://github.com/kymatio/kymatio/pull/415"},"issue":{"href":"https://api.github.com/repos/kymatio/kymatio/issues/415"},"comments":{"href":"https://api.github.com/repos/kymatio/kymatio/issues/415/comments"},"review_comments":{"href":"https://api.github.com/repos/kymatio/kymatio/pulls/415/comments"},"review_comment":{"href":"https://api.github.com/repos/kymatio/kymatio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kymatio/kymatio/pulls/415/commits"},"statuses":{"href":"https://api.github.com/repos/kymatio/kymatio/statuses/f34b75e442b21a3523d343abd25910a5dc208a3f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lostanlen"}}