{"action":"created","comment":{"url":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/comments/299686226","pull_request_review_id":257151593,"id":299686226,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTY4NjIyNg==","diff_hunk":"@@ -67,6 +69,45 @@ protected boolean redirectMatches(String requestedRedirect, String clientRedirec\n         }\n     }\n \n+    /**\n+     * Repeatedly:\n+     * <ol>\n+     *     <li>checks for a match</li>\n+     *     <li>url decodes the requested path</li>\n+     * </ol>\n+     * until path cannot be url decoded any further. Then normalizes the path before the final check.\n+     * <p>\n+     *     For example, if example.com/foo is the registered url and example.com/foo/%252e./bar is the requested url,\n+     *     checks a match for:\n+     *     <ol>\n+     *         <li>example.com/foo/%252e./bar</li>\n+     *         <li>example.com/foo/%2e./bar</li>\n+     *         <li>example.com/foo/../bar</li>\n+     *         <li>example.com/bar</li>\n+     *     </ol>\n+     * </p>\n+     */\n+    private boolean matchesAfterNormalization(Predicate<String> matcher, String requestedRedirect) {\n+        int maxDecodeAttempts = 5;","path":"server/src/main/java/org/cloudfoundry/identity/uaa/oauth/AntPathRedirectResolver.java","position":74,"original_position":74,"commit_id":"e0c806b78c080dc818f061366956d909439dcadc","original_commit_id":"e0c806b78c080dc818f061366956d909439dcadc","user":{"login":"metacubed","id":7028125,"node_id":"MDQ6VXNlcjcwMjgxMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7028125?v=4","gravatar_id":"","url":"https://api.github.com/users/metacubed","html_url":"https://github.com/metacubed","followers_url":"https://api.github.com/users/metacubed/followers","following_url":"https://api.github.com/users/metacubed/following{/other_user}","gists_url":"https://api.github.com/users/metacubed/gists{/gist_id}","starred_url":"https://api.github.com/users/metacubed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metacubed/subscriptions","organizations_url":"https://api.github.com/users/metacubed/orgs","repos_url":"https://api.github.com/users/metacubed/repos","events_url":"https://api.github.com/users/metacubed/events{/privacy}","received_events_url":"https://api.github.com/users/metacubed/received_events","type":"User","site_admin":false},"body":"Make this a Java constant please - at the start of the class:\r\n```java\r\nprivate static final int MAX_DECODE_ATTEMPTS = 5\r\n```","created_at":"2019-07-02T21:10:21Z","updated_at":"2019-07-02T21:10:29Z","html_url":"https://github.com/GESoftware-CF/uaa/pull/137#discussion_r299686226","pull_request_url":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/137","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/comments/299686226"},"html":{"href":"https://github.com/GESoftware-CF/uaa/pull/137#discussion_r299686226"},"pull_request":{"href":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/137","id":288647621,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NjQ3NjIx","html_url":"https://github.com/GESoftware-CF/uaa/pull/137","diff_url":"https://github.com/GESoftware-CF/uaa/pull/137.diff","patch_url":"https://github.com/GESoftware-CF/uaa/pull/137.patch","issue_url":"https://api.github.com/repos/GESoftware-CF/uaa/issues/137","number":137,"state":"open","locked":false,"title":"redirect_uri_integrity_check_bypass","user":{"login":"taitzariel","id":34752852,"node_id":"MDQ6VXNlcjM0NzUyODUy","avatar_url":"https://avatars1.githubusercontent.com/u/34752852?v=4","gravatar_id":"","url":"https://api.github.com/users/taitzariel","html_url":"https://github.com/taitzariel","followers_url":"https://api.github.com/users/taitzariel/followers","following_url":"https://api.github.com/users/taitzariel/following{/other_user}","gists_url":"https://api.github.com/users/taitzariel/gists{/gist_id}","starred_url":"https://api.github.com/users/taitzariel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taitzariel/subscriptions","organizations_url":"https://api.github.com/users/taitzariel/orgs","repos_url":"https://api.github.com/users/taitzariel/repos","events_url":"https://api.github.com/users/taitzariel/events{/privacy}","received_events_url":"https://api.github.com/users/taitzariel/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-16T19:56:12Z","updated_at":"2019-07-02T21:10:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"026bc40c223a6fb8c0cbb06453b6632d0ecdc845","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/137/commits","review_comments_url":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/137/comments","review_comment_url":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GESoftware-CF/uaa/issues/137/comments","statuses_url":"https://api.github.com/repos/GESoftware-CF/uaa/statuses/e0c806b78c080dc818f061366956d909439dcadc","head":{"label":"GESoftware-CF:redirect_uri_integrity_check_bypass","ref":"redirect_uri_integrity_check_bypass","sha":"e0c806b78c080dc818f061366956d909439dcadc","user":{"login":"GESoftware-CF","id":12106002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTA2MDAy","avatar_url":"https://avatars3.githubusercontent.com/u/12106002?v=4","gravatar_id":"","url":"https://api.github.com/users/GESoftware-CF","html_url":"https://github.com/GESoftware-CF","followers_url":"https://api.github.com/users/GESoftware-CF/followers","following_url":"https://api.github.com/users/GESoftware-CF/following{/other_user}","gists_url":"https://api.github.com/users/GESoftware-CF/gists{/gist_id}","starred_url":"https://api.github.com/users/GESoftware-CF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GESoftware-CF/subscriptions","organizations_url":"https://api.github.com/users/GESoftware-CF/orgs","repos_url":"https://api.github.com/users/GESoftware-CF/repos","events_url":"https://api.github.com/users/GESoftware-CF/events{/privacy}","received_events_url":"https://api.github.com/users/GESoftware-CF/received_events","type":"Organization","site_admin":false},"repo":{"id":35747522,"node_id":"MDEwOlJlcG9zaXRvcnkzNTc0NzUyMg==","name":"uaa","full_name":"GESoftware-CF/uaa","private":false,"owner":{"login":"GESoftware-CF","id":12106002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTA2MDAy","avatar_url":"https://avatars3.githubusercontent.com/u/12106002?v=4","gravatar_id":"","url":"https://api.github.com/users/GESoftware-CF","html_url":"https://github.com/GESoftware-CF","followers_url":"https://api.github.com/users/GESoftware-CF/followers","following_url":"https://api.github.com/users/GESoftware-CF/following{/other_user}","gists_url":"https://api.github.com/users/GESoftware-CF/gists{/gist_id}","starred_url":"https://api.github.com/users/GESoftware-CF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GESoftware-CF/subscriptions","organizations_url":"https://api.github.com/users/GESoftware-CF/orgs","repos_url":"https://api.github.com/users/GESoftware-CF/repos","events_url":"https://api.github.com/users/GESoftware-CF/events{/privacy}","received_events_url":"https://api.github.com/users/GESoftware-CF/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GESoftware-CF/uaa","description":"CloudFoundry User Account and Authentication (UAA) Server","fork":true,"url":"https://api.github.com/repos/GESoftware-CF/uaa","forks_url":"https://api.github.com/repos/GESoftware-CF/uaa/forks","keys_url":"https://api.github.com/repos/GESoftware-CF/uaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GESoftware-CF/uaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GESoftware-CF/uaa/teams","hooks_url":"https://api.github.com/repos/GESoftware-CF/uaa/hooks","issue_events_url":"https://api.github.com/repos/GESoftware-CF/uaa/issues/events{/number}","events_url":"https://api.github.com/repos/GESoftware-CF/uaa/events","assignees_url":"https://api.github.com/repos/GESoftware-CF/uaa/assignees{/user}","branches_url":"https://api.github.com/repos/GESoftware-CF/uaa/branches{/branch}","tags_url":"https://api.github.com/repos/GESoftware-CF/uaa/tags","blobs_url":"https://api.github.com/repos/GESoftware-CF/uaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GESoftware-CF/uaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GESoftware-CF/uaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/GESoftware-CF/uaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GESoftware-CF/uaa/statuses/{sha}","languages_url":"https://api.github.com/repos/GESoftware-CF/uaa/languages","stargazers_url":"https://api.github.com/repos/GESoftware-CF/uaa/stargazers","contributors_url":"https://api.github.com/repos/GESoftware-CF/uaa/contributors","subscribers_url":"https://api.github.com/repos/GESoftware-CF/uaa/subscribers","subscription_url":"https://api.github.com/repos/GESoftware-CF/uaa/subscription","commits_url":"https://api.github.com/repos/GESoftware-CF/uaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/GESoftware-CF/uaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/GESoftware-CF/uaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/GESoftware-CF/uaa/issues/comments{/number}","contents_url":"https://api.github.com/repos/GESoftware-CF/uaa/contents/{+path}","compare_url":"https://api.github.com/repos/GESoftware-CF/uaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GESoftware-CF/uaa/merges","archive_url":"https://api.github.com/repos/GESoftware-CF/uaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GESoftware-CF/uaa/downloads","issues_url":"https://api.github.com/repos/GESoftware-CF/uaa/issues{/number}","pulls_url":"https://api.github.com/repos/GESoftware-CF/uaa/pulls{/number}","milestones_url":"https://api.github.com/repos/GESoftware-CF/uaa/milestones{/number}","notifications_url":"https://api.github.com/repos/GESoftware-CF/uaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GESoftware-CF/uaa/labels{/name}","releases_url":"https://api.github.com/repos/GESoftware-CF/uaa/releases{/id}","deployments_url":"https://api.github.com/repos/GESoftware-CF/uaa/deployments","created_at":"2015-05-17T01:44:16Z","updated_at":"2019-04-26T18:17:04Z","pushed_at":"2019-07-02T19:16:57Z","git_url":"git://github.com/GESoftware-CF/uaa.git","ssh_url":"git@github.com:GESoftware-CF/uaa.git","clone_url":"https://github.com/GESoftware-CF/uaa.git","svn_url":"https://github.com/GESoftware-CF/uaa","homepage":"","size":49619,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":1,"watchers":20,"default_branch":"master"}},"base":{"label":"GESoftware-CF:predix_extensions_4.30.0","ref":"predix_extensions_4.30.0","sha":"7bc739a5bd51c0b9584613658a50423e57da1952","user":{"login":"GESoftware-CF","id":12106002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTA2MDAy","avatar_url":"https://avatars3.githubusercontent.com/u/12106002?v=4","gravatar_id":"","url":"https://api.github.com/users/GESoftware-CF","html_url":"https://github.com/GESoftware-CF","followers_url":"https://api.github.com/users/GESoftware-CF/followers","following_url":"https://api.github.com/users/GESoftware-CF/following{/other_user}","gists_url":"https://api.github.com/users/GESoftware-CF/gists{/gist_id}","starred_url":"https://api.github.com/users/GESoftware-CF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GESoftware-CF/subscriptions","organizations_url":"https://api.github.com/users/GESoftware-CF/orgs","repos_url":"https://api.github.com/users/GESoftware-CF/repos","events_url":"https://api.github.com/users/GESoftware-CF/events{/privacy}","received_events_url":"https://api.github.com/users/GESoftware-CF/received_events","type":"Organization","site_admin":false},"repo":{"id":35747522,"node_id":"MDEwOlJlcG9zaXRvcnkzNTc0NzUyMg==","name":"uaa","full_name":"GESoftware-CF/uaa","private":false,"owner":{"login":"GESoftware-CF","id":12106002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTA2MDAy","avatar_url":"https://avatars3.githubusercontent.com/u/12106002?v=4","gravatar_id":"","url":"https://api.github.com/users/GESoftware-CF","html_url":"https://github.com/GESoftware-CF","followers_url":"https://api.github.com/users/GESoftware-CF/followers","following_url":"https://api.github.com/users/GESoftware-CF/following{/other_user}","gists_url":"https://api.github.com/users/GESoftware-CF/gists{/gist_id}","starred_url":"https://api.github.com/users/GESoftware-CF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GESoftware-CF/subscriptions","organizations_url":"https://api.github.com/users/GESoftware-CF/orgs","repos_url":"https://api.github.com/users/GESoftware-CF/repos","events_url":"https://api.github.com/users/GESoftware-CF/events{/privacy}","received_events_url":"https://api.github.com/users/GESoftware-CF/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GESoftware-CF/uaa","description":"CloudFoundry User Account and Authentication (UAA) Server","fork":true,"url":"https://api.github.com/repos/GESoftware-CF/uaa","forks_url":"https://api.github.com/repos/GESoftware-CF/uaa/forks","keys_url":"https://api.github.com/repos/GESoftware-CF/uaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GESoftware-CF/uaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GESoftware-CF/uaa/teams","hooks_url":"https://api.github.com/repos/GESoftware-CF/uaa/hooks","issue_events_url":"https://api.github.com/repos/GESoftware-CF/uaa/issues/events{/number}","events_url":"https://api.github.com/repos/GESoftware-CF/uaa/events","assignees_url":"https://api.github.com/repos/GESoftware-CF/uaa/assignees{/user}","branches_url":"https://api.github.com/repos/GESoftware-CF/uaa/branches{/branch}","tags_url":"https://api.github.com/repos/GESoftware-CF/uaa/tags","blobs_url":"https://api.github.com/repos/GESoftware-CF/uaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GESoftware-CF/uaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GESoftware-CF/uaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/GESoftware-CF/uaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GESoftware-CF/uaa/statuses/{sha}","languages_url":"https://api.github.com/repos/GESoftware-CF/uaa/languages","stargazers_url":"https://api.github.com/repos/GESoftware-CF/uaa/stargazers","contributors_url":"https://api.github.com/repos/GESoftware-CF/uaa/contributors","subscribers_url":"https://api.github.com/repos/GESoftware-CF/uaa/subscribers","subscription_url":"https://api.github.com/repos/GESoftware-CF/uaa/subscription","commits_url":"https://api.github.com/repos/GESoftware-CF/uaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/GESoftware-CF/uaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/GESoftware-CF/uaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/GESoftware-CF/uaa/issues/comments{/number}","contents_url":"https://api.github.com/repos/GESoftware-CF/uaa/contents/{+path}","compare_url":"https://api.github.com/repos/GESoftware-CF/uaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GESoftware-CF/uaa/merges","archive_url":"https://api.github.com/repos/GESoftware-CF/uaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GESoftware-CF/uaa/downloads","issues_url":"https://api.github.com/repos/GESoftware-CF/uaa/issues{/number}","pulls_url":"https://api.github.com/repos/GESoftware-CF/uaa/pulls{/number}","milestones_url":"https://api.github.com/repos/GESoftware-CF/uaa/milestones{/number}","notifications_url":"https://api.github.com/repos/GESoftware-CF/uaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GESoftware-CF/uaa/labels{/name}","releases_url":"https://api.github.com/repos/GESoftware-CF/uaa/releases{/id}","deployments_url":"https://api.github.com/repos/GESoftware-CF/uaa/deployments","created_at":"2015-05-17T01:44:16Z","updated_at":"2019-04-26T18:17:04Z","pushed_at":"2019-07-02T19:16:57Z","git_url":"git://github.com/GESoftware-CF/uaa.git","ssh_url":"git@github.com:GESoftware-CF/uaa.git","clone_url":"https://github.com/GESoftware-CF/uaa.git","svn_url":"https://github.com/GESoftware-CF/uaa","homepage":"","size":49619,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":1,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/137"},"html":{"href":"https://github.com/GESoftware-CF/uaa/pull/137"},"issue":{"href":"https://api.github.com/repos/GESoftware-CF/uaa/issues/137"},"comments":{"href":"https://api.github.com/repos/GESoftware-CF/uaa/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GESoftware-CF/uaa/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/GESoftware-CF/uaa/statuses/e0c806b78c080dc818f061366956d909439dcadc"}},"author_association":"NONE"}}
{"actor":{"display_login":"metacubed"}}