{"action":"created","comment":{"url":"https://api.github.com/repos/gnosis/dex-react/pulls/comments/329692728","pull_request_review_id":295127589,"id":329692728,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTY5MjcyOA==","diff_hunk":"@@ -146,6 +148,9 @@ export class DepositApiMock implements DepositApi {\n     pendingWithdraws.amount = ZERO\n     balanceState.balance = balanceState.balance.sub(amount)\n \n+    // mock transfer tokens to user's mock `wallet`\n+    await this._erc20Api.transfer(tokenAddress, this.getContractAddress(), userAddress, amount)","path":"src/api/exchange/DepositApiMock.ts","position":27,"original_position":27,"commit_id":"742b64d50c9ed60b26a5bda926bfc0c179b596a7","original_commit_id":"742b64d50c9ed60b26a5bda926bfc0c179b596a7","user":{"login":"alfetopito","id":43217,"node_id":"MDQ6VXNlcjQzMjE3","avatar_url":"https://avatars1.githubusercontent.com/u/43217?v=4","gravatar_id":"","url":"https://api.github.com/users/alfetopito","html_url":"https://github.com/alfetopito","followers_url":"https://api.github.com/users/alfetopito/followers","following_url":"https://api.github.com/users/alfetopito/following{/other_user}","gists_url":"https://api.github.com/users/alfetopito/gists{/gist_id}","starred_url":"https://api.github.com/users/alfetopito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfetopito/subscriptions","organizations_url":"https://api.github.com/users/alfetopito/orgs","repos_url":"https://api.github.com/users/alfetopito/repos","events_url":"https://api.github.com/users/alfetopito/events{/privacy}","received_events_url":"https://api.github.com/users/alfetopito/received_events","type":"User","site_admin":false},"body":"Yes, they are missing indeed. I thought about doing it now, but decided to leave it for when dealing with that, to not increase the scope of this PR further.","created_at":"2019-09-30T17:18:38Z","updated_at":"2019-09-30T17:18:38Z","html_url":"https://github.com/gnosis/dex-react/pull/77#discussion_r329692728","pull_request_url":"https://api.github.com/repos/gnosis/dex-react/pulls/77","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/comments/329692728"},"html":{"href":"https://github.com/gnosis/dex-react/pull/77#discussion_r329692728"},"pull_request":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/77"}},"in_reply_to_id":329677024},"pull_request":{"url":"https://api.github.com/repos/gnosis/dex-react/pulls/77","id":321347948,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxMzQ3OTQ4","html_url":"https://github.com/gnosis/dex-react/pull/77","diff_url":"https://github.com/gnosis/dex-react/pull/77.diff","patch_url":"https://github.com/gnosis/dex-react/pull/77.patch","issue_url":"https://api.github.com/repos/gnosis/dex-react/issues/77","number":77,"state":"open","locked":false,"title":"46/detect withdrawability","user":{"login":"alfetopito","id":43217,"node_id":"MDQ6VXNlcjQzMjE3","avatar_url":"https://avatars1.githubusercontent.com/u/43217?v=4","gravatar_id":"","url":"https://api.github.com/users/alfetopito","html_url":"https://github.com/alfetopito","followers_url":"https://api.github.com/users/alfetopito/followers","following_url":"https://api.github.com/users/alfetopito/following{/other_user}","gists_url":"https://api.github.com/users/alfetopito/gists{/gist_id}","starred_url":"https://api.github.com/users/alfetopito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfetopito/subscriptions","organizations_url":"https://api.github.com/users/alfetopito/orgs","repos_url":"https://api.github.com/users/alfetopito/repos","events_url":"https://api.github.com/users/alfetopito/events{/privacy}","received_events_url":"https://api.github.com/users/alfetopito/received_events","type":"User","site_admin":false},"body":"- [x] Detect withdrawability\r\n- [x] Show withdraw button\r\n- [x] Show pending withdraw icon\r\n- [x] Withdraw\r\n\r\n![withdraw](https://user-images.githubusercontent.com/43217/65622894-7c3f3780-df7b-11e9-8c6e-160fe95a7f4d.png)\r\n\r\n### Additionally:\r\n\r\n- Added a eslint plugin to check react hooks.\r\n- Added the utils function `abbreviateString` to, well, abbreviate strings.\r\n- Using a [ref](https://reactjs.org/docs/hooks-faq.html#is-there-something-like-instance-variables) to track hook mounted state as opposed to a regular variable.\r\n- Did a bit refactoring to reuse the same hook (`useTokenBalances`) for optionaly updating a single token balance as opposed to all balances at once.\r\n  Added a `update` function to the hook, to manually update the values.\r\n  Not sure this is the best approach though. Open to suggestions.\r\n\r\n--- \r\n\r\nCloses https://github.com/gnosis/dex-react/issues/46","created_at":"2019-09-25T17:02:08Z","updated_at":"2019-09-30T17:18:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f333eddf1b8cc75a2b1f9ebc0c5e3c2ab0a3e613","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gnosis/dex-react/pulls/77/commits","review_comments_url":"https://api.github.com/repos/gnosis/dex-react/pulls/77/comments","review_comment_url":"https://api.github.com/repos/gnosis/dex-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnosis/dex-react/issues/77/comments","statuses_url":"https://api.github.com/repos/gnosis/dex-react/statuses/742b64d50c9ed60b26a5bda926bfc0c179b596a7","head":{"label":"gnosis:46/detect-withdrawability","ref":"46/detect-withdrawability","sha":"742b64d50c9ed60b26a5bda926bfc0c179b596a7","user":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":200027889,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAwMjc4ODk=","name":"dex-react","full_name":"gnosis/dex-react","private":false,"owner":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gnosis/dex-react","description":null,"fork":false,"url":"https://api.github.com/repos/gnosis/dex-react","forks_url":"https://api.github.com/repos/gnosis/dex-react/forks","keys_url":"https://api.github.com/repos/gnosis/dex-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/dex-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/dex-react/teams","hooks_url":"https://api.github.com/repos/gnosis/dex-react/hooks","issue_events_url":"https://api.github.com/repos/gnosis/dex-react/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/dex-react/events","assignees_url":"https://api.github.com/repos/gnosis/dex-react/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/dex-react/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/dex-react/tags","blobs_url":"https://api.github.com/repos/gnosis/dex-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/dex-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/dex-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/dex-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/dex-react/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/dex-react/languages","stargazers_url":"https://api.github.com/repos/gnosis/dex-react/stargazers","contributors_url":"https://api.github.com/repos/gnosis/dex-react/contributors","subscribers_url":"https://api.github.com/repos/gnosis/dex-react/subscribers","subscription_url":"https://api.github.com/repos/gnosis/dex-react/subscription","commits_url":"https://api.github.com/repos/gnosis/dex-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/dex-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/dex-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/dex-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/dex-react/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/dex-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/dex-react/merges","archive_url":"https://api.github.com/repos/gnosis/dex-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/dex-react/downloads","issues_url":"https://api.github.com/repos/gnosis/dex-react/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/dex-react/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/dex-react/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/dex-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/dex-react/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/dex-react/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/dex-react/deployments","created_at":"2019-08-01T10:14:22Z","updated_at":"2019-09-27T15:02:28Z","pushed_at":"2019-09-30T15:57:13Z","git_url":"git://github.com/gnosis/dex-react.git","ssh_url":"git@github.com:gnosis/dex-react.git","clone_url":"https://github.com/gnosis/dex-react.git","svn_url":"https://github.com/gnosis/dex-react","homepage":null,"size":696,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":null,"forks":0,"open_issues":17,"watchers":1,"default_branch":"develop"}},"base":{"label":"gnosis:develop","ref":"develop","sha":"9ff81d81b46a1a7cf7369f279eb5b997d4ab6942","user":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":200027889,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAwMjc4ODk=","name":"dex-react","full_name":"gnosis/dex-react","private":false,"owner":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gnosis/dex-react","description":null,"fork":false,"url":"https://api.github.com/repos/gnosis/dex-react","forks_url":"https://api.github.com/repos/gnosis/dex-react/forks","keys_url":"https://api.github.com/repos/gnosis/dex-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/dex-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/dex-react/teams","hooks_url":"https://api.github.com/repos/gnosis/dex-react/hooks","issue_events_url":"https://api.github.com/repos/gnosis/dex-react/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/dex-react/events","assignees_url":"https://api.github.com/repos/gnosis/dex-react/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/dex-react/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/dex-react/tags","blobs_url":"https://api.github.com/repos/gnosis/dex-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/dex-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/dex-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/dex-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/dex-react/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/dex-react/languages","stargazers_url":"https://api.github.com/repos/gnosis/dex-react/stargazers","contributors_url":"https://api.github.com/repos/gnosis/dex-react/contributors","subscribers_url":"https://api.github.com/repos/gnosis/dex-react/subscribers","subscription_url":"https://api.github.com/repos/gnosis/dex-react/subscription","commits_url":"https://api.github.com/repos/gnosis/dex-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/dex-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/dex-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/dex-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/dex-react/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/dex-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/dex-react/merges","archive_url":"https://api.github.com/repos/gnosis/dex-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/dex-react/downloads","issues_url":"https://api.github.com/repos/gnosis/dex-react/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/dex-react/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/dex-react/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/dex-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/dex-react/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/dex-react/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/dex-react/deployments","created_at":"2019-08-01T10:14:22Z","updated_at":"2019-09-27T15:02:28Z","pushed_at":"2019-09-30T15:57:13Z","git_url":"git://github.com/gnosis/dex-react.git","ssh_url":"git@github.com:gnosis/dex-react.git","clone_url":"https://github.com/gnosis/dex-react.git","svn_url":"https://github.com/gnosis/dex-react","homepage":null,"size":696,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":null,"forks":0,"open_issues":17,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/77"},"html":{"href":"https://github.com/gnosis/dex-react/pull/77"},"issue":{"href":"https://api.github.com/repos/gnosis/dex-react/issues/77"},"comments":{"href":"https://api.github.com/repos/gnosis/dex-react/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/gnosis/dex-react/statuses/742b64d50c9ed60b26a5bda926bfc0c179b596a7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alfetopito"}}