{"action":"closed","number":490,"pull_request":{"url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/pulls/490","id":323090801,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzMDkwODAx","html_url":"https://github.com/fullstackopen-2019/fullstackopen-2019.github.io/pull/490","diff_url":"https://github.com/fullstackopen-2019/fullstackopen-2019.github.io/pull/490.diff","patch_url":"https://github.com/fullstackopen-2019/fullstackopen-2019.github.io/pull/490.patch","issue_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/issues/490","number":490,"state":"closed","locked":false,"title":"feat(testing react apps): Remove mention of cleanup","user":{"login":"eps1lon","id":12292047,"node_id":"MDQ6VXNlcjEyMjkyMDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/12292047?v=4","gravatar_id":"","url":"https://api.github.com/users/eps1lon","html_url":"https://github.com/eps1lon","followers_url":"https://api.github.com/users/eps1lon/followers","following_url":"https://api.github.com/users/eps1lon/following{/other_user}","gists_url":"https://api.github.com/users/eps1lon/gists{/gist_id}","starred_url":"https://api.github.com/users/eps1lon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eps1lon/subscriptions","organizations_url":"https://api.github.com/users/eps1lon/orgs","repos_url":"https://api.github.com/users/eps1lon/repos","events_url":"https://api.github.com/users/eps1lon/events{/privacy}","received_events_url":"https://api.github.com/users/eps1lon/received_events","type":"User","site_admin":false},"body":"Using this opportunity to say that this is an awesome guide. Navigation is a breeze and it looks very friendly.\r\n\r\nAs of [9.0.0](https://github.com/testing-library/react-testing-library/releases/tag/v9.0.0) cleanup happens automatically if you import from `@testing-library/react`.\r\n\r\nYou don't need any additional setup for the default case. This should also reduces possible confusion since not every test in this guide used `cleanup`.","created_at":"2019-10-01T05:28:51Z","updated_at":"2019-10-02T14:40:21Z","closed_at":"2019-10-02T14:40:21Z","merged_at":"2019-10-02T14:40:21Z","merge_commit_sha":"ed768ca75e9f55c34dbe6b745ed36782adb613c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/pulls/490/commits","review_comments_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/pulls/490/comments","review_comment_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/issues/490/comments","statuses_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/statuses/d50fa30c40b250d0caedf889d9e2a6d35a7da092","head":{"label":"eps1lon:patch-1","ref":"patch-1","sha":"d50fa30c40b250d0caedf889d9e2a6d35a7da092","user":{"login":"eps1lon","id":12292047,"node_id":"MDQ6VXNlcjEyMjkyMDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/12292047?v=4","gravatar_id":"","url":"https://api.github.com/users/eps1lon","html_url":"https://github.com/eps1lon","followers_url":"https://api.github.com/users/eps1lon/followers","following_url":"https://api.github.com/users/eps1lon/following{/other_user}","gists_url":"https://api.github.com/users/eps1lon/gists{/gist_id}","starred_url":"https://api.github.com/users/eps1lon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eps1lon/subscriptions","organizations_url":"https://api.github.com/users/eps1lon/orgs","repos_url":"https://api.github.com/users/eps1lon/repos","events_url":"https://api.github.com/users/eps1lon/events{/privacy}","received_events_url":"https://api.github.com/users/eps1lon/received_events","type":"User","site_admin":false},"repo":{"id":212017105,"node_id":"MDEwOlJlcG9zaXRvcnkyMTIwMTcxMDU=","name":"fullstackopen-2019.github.io","full_name":"eps1lon/fullstackopen-2019.github.io","private":false,"owner":{"login":"eps1lon","id":12292047,"node_id":"MDQ6VXNlcjEyMjkyMDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/12292047?v=4","gravatar_id":"","url":"https://api.github.com/users/eps1lon","html_url":"https://github.com/eps1lon","followers_url":"https://api.github.com/users/eps1lon/followers","following_url":"https://api.github.com/users/eps1lon/following{/other_user}","gists_url":"https://api.github.com/users/eps1lon/gists{/gist_id}","starred_url":"https://api.github.com/users/eps1lon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eps1lon/subscriptions","organizations_url":"https://api.github.com/users/eps1lon/orgs","repos_url":"https://api.github.com/users/eps1lon/repos","events_url":"https://api.github.com/users/eps1lon/events{/privacy}","received_events_url":"https://api.github.com/users/eps1lon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eps1lon/fullstackopen-2019.github.io","description":null,"fork":true,"url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io","forks_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/forks","keys_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/teams","hooks_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/hooks","issue_events_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/events","assignees_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/tags","blobs_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/languages","stargazers_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/stargazers","contributors_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/contributors","subscribers_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/subscribers","subscription_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/subscription","commits_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/merges","archive_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/downloads","issues_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/labels{/name}","releases_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/eps1lon/fullstackopen-2019.github.io/deployments","created_at":"2019-10-01T05:10:59Z","updated_at":"2019-10-01T05:11:00Z","pushed_at":"2019-10-01T05:20:47Z","git_url":"git://github.com/eps1lon/fullstackopen-2019.github.io.git","ssh_url":"git@github.com:eps1lon/fullstackopen-2019.github.io.git","clone_url":"https://github.com/eps1lon/fullstackopen-2019.github.io.git","svn_url":"https://github.com/eps1lon/fullstackopen-2019.github.io","homepage":null,"size":332074,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"source"}},"base":{"label":"fullstackopen-2019:source","ref":"source","sha":"1ddec0300591b536d3de050508ff2ed3ec718cef","user":{"login":"fullstackopen-2019","id":48050168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MDUwMTY4","avatar_url":"https://avatars1.githubusercontent.com/u/48050168?v=4","gravatar_id":"","url":"https://api.github.com/users/fullstackopen-2019","html_url":"https://github.com/fullstackopen-2019","followers_url":"https://api.github.com/users/fullstackopen-2019/followers","following_url":"https://api.github.com/users/fullstackopen-2019/following{/other_user}","gists_url":"https://api.github.com/users/fullstackopen-2019/gists{/gist_id}","starred_url":"https://api.github.com/users/fullstackopen-2019/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fullstackopen-2019/subscriptions","organizations_url":"https://api.github.com/users/fullstackopen-2019/orgs","repos_url":"https://api.github.com/users/fullstackopen-2019/repos","events_url":"https://api.github.com/users/fullstackopen-2019/events{/privacy}","received_events_url":"https://api.github.com/users/fullstackopen-2019/received_events","type":"Organization","site_admin":false},"repo":{"id":172881191,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI4ODExOTE=","name":"fullstackopen-2019.github.io","full_name":"fullstackopen-2019/fullstackopen-2019.github.io","private":false,"owner":{"login":"fullstackopen-2019","id":48050168,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MDUwMTY4","avatar_url":"https://avatars1.githubusercontent.com/u/48050168?v=4","gravatar_id":"","url":"https://api.github.com/users/fullstackopen-2019","html_url":"https://github.com/fullstackopen-2019","followers_url":"https://api.github.com/users/fullstackopen-2019/followers","following_url":"https://api.github.com/users/fullstackopen-2019/following{/other_user}","gists_url":"https://api.github.com/users/fullstackopen-2019/gists{/gist_id}","starred_url":"https://api.github.com/users/fullstackopen-2019/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fullstackopen-2019/subscriptions","organizations_url":"https://api.github.com/users/fullstackopen-2019/orgs","repos_url":"https://api.github.com/users/fullstackopen-2019/repos","events_url":"https://api.github.com/users/fullstackopen-2019/events{/privacy}","received_events_url":"https://api.github.com/users/fullstackopen-2019/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fullstackopen-2019/fullstackopen-2019.github.io","description":null,"fork":false,"url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io","forks_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/forks","keys_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/teams","hooks_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/hooks","issue_events_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/events","assignees_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/tags","blobs_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/languages","stargazers_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/stargazers","contributors_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/contributors","subscribers_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/subscribers","subscription_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/subscription","commits_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/merges","archive_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/downloads","issues_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/labels{/name}","releases_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/deployments","created_at":"2019-02-27T09:06:29Z","updated_at":"2019-10-02T14:39:44Z","pushed_at":"2019-10-02T14:40:21Z","git_url":"git://github.com/fullstackopen-2019/fullstackopen-2019.github.io.git","ssh_url":"git@github.com:fullstackopen-2019/fullstackopen-2019.github.io.git","clone_url":"https://github.com/fullstackopen-2019/fullstackopen-2019.github.io.git","svn_url":"https://github.com/fullstackopen-2019/fullstackopen-2019.github.io","homepage":null,"size":332091,"stargazers_count":244,"watchers_count":244,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":357,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":357,"open_issues":25,"watchers":244,"default_branch":"source"}},"_links":{"self":{"href":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/pulls/490"},"html":{"href":"https://github.com/fullstackopen-2019/fullstackopen-2019.github.io/pull/490"},"issue":{"href":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/issues/490"},"comments":{"href":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/fullstackopen-2019/fullstackopen-2019.github.io/statuses/d50fa30c40b250d0caedf889d9e2a6d35a7da092"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mluukkai","id":523235,"node_id":"MDQ6VXNlcjUyMzIzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/523235?v=4","gravatar_id":"","url":"https://api.github.com/users/mluukkai","html_url":"https://github.com/mluukkai","followers_url":"https://api.github.com/users/mluukkai/followers","following_url":"https://api.github.com/users/mluukkai/following{/other_user}","gists_url":"https://api.github.com/users/mluukkai/gists{/gist_id}","starred_url":"https://api.github.com/users/mluukkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mluukkai/subscriptions","organizations_url":"https://api.github.com/users/mluukkai/orgs","repos_url":"https://api.github.com/users/mluukkai/repos","events_url":"https://api.github.com/users/mluukkai/events{/privacy}","received_events_url":"https://api.github.com/users/mluukkai/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"mluukkai"}}