{"action":"opened","number":332,"pull_request":{"url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/332","id":267466949,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY3NDY2OTQ5","html_url":"https://github.com/NetworkManager/NetworkManager/pull/332","diff_url":"https://github.com/NetworkManager/NetworkManager/pull/332.diff","patch_url":"https://github.com/NetworkManager/NetworkManager/pull/332.patch","issue_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/332","number":332,"state":"open","locked":false,"title":"[th/strsplit]","user":{"login":"thom311","id":1295078,"node_id":"MDQ6VXNlcjEyOTUwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1295078?v=4","gravatar_id":"","url":"https://api.github.com/users/thom311","html_url":"https://github.com/thom311","followers_url":"https://api.github.com/users/thom311/followers","following_url":"https://api.github.com/users/thom311/following{/other_user}","gists_url":"https://api.github.com/users/thom311/gists{/gist_id}","starred_url":"https://api.github.com/users/thom311/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thom311/subscriptions","organizations_url":"https://api.github.com/users/thom311/orgs","repos_url":"https://api.github.com/users/thom311/repos","events_url":"https://api.github.com/users/thom311/events{/privacy}","received_events_url":"https://api.github.com/users/thom311/received_events","type":"User","site_admin":false},"body":"Recently, when refactoring nmcli (f224d6a8537dd58fafc8b7ba977ec7fffe8c31e9), handling of list-typed properties improved.\r\n\r\nStill, the splitting such values should be improved. For example, currently there is no way to escape the ',' separator. The code (and behavior) for this should be unified and powerful to support arbitrary strings (that contain the delimiter characters).\r\n\r\nIn a first step, improve our `nm_utils_strsplit_set*()` implementation which will be used for that.\r\n\r\n`nm_utils_strsplit_set*()` is a replacement for `g_strsplit_set()`, but differs in some aspects:\r\n- it may (configurably) skip empty tokens right away (repeated delimiters)\r\n- it only clones the string once, instead of returning a full strv array.\r\n- it may (optionally) honor backslash as escape characters. We will need this to make splitting options in nmcli escapeable.\r\n\r\nAdd `NM_UTILS_STRSPLIT_SET_FLAGS_PRESERVE_EMPTY` flag, so that empty tokens are preserved. As such, `nm_utils_strsplit_set_with_empty()` is now very similar to `g_strsplit_set()`.\r\n\r\nAlso, replace uses of `g_strsplit_set()` with our variant. That avoids the overhead of cloning all items of the strv array and we can leverage our variant -- that we already have and need for `NM_UTILS_STRSPLIT_SET_FLAGS_PRESERVE_EMPTY`.","created_at":"2019-04-04T14:10:03Z","updated_at":"2019-04-04T14:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/332/commits","review_comments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/332/comments","review_comment_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/332/comments","statuses_url":"https://api.github.com/repos/NetworkManager/NetworkManager/statuses/da3f7a355e4e3c9163db7bcee0cc5476d1d9ff0f","head":{"label":"NetworkManager:th/strsplit","ref":"th/strsplit","sha":"da3f7a355e4e3c9163db7bcee0cc5476d1d9ff0f","user":{"login":"NetworkManager","id":14775807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzc1ODA3","avatar_url":"https://avatars2.githubusercontent.com/u/14775807?v=4","gravatar_id":"","url":"https://api.github.com/users/NetworkManager","html_url":"https://github.com/NetworkManager","followers_url":"https://api.github.com/users/NetworkManager/followers","following_url":"https://api.github.com/users/NetworkManager/following{/other_user}","gists_url":"https://api.github.com/users/NetworkManager/gists{/gist_id}","starred_url":"https://api.github.com/users/NetworkManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetworkManager/subscriptions","organizations_url":"https://api.github.com/users/NetworkManager/orgs","repos_url":"https://api.github.com/users/NetworkManager/repos","events_url":"https://api.github.com/users/NetworkManager/events{/privacy}","received_events_url":"https://api.github.com/users/NetworkManager/received_events","type":"Organization","site_admin":false},"repo":{"id":42934521,"node_id":"MDEwOlJlcG9zaXRvcnk0MjkzNDUyMQ==","name":"NetworkManager","full_name":"NetworkManager/NetworkManager","private":false,"owner":{"login":"NetworkManager","id":14775807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzc1ODA3","avatar_url":"https://avatars2.githubusercontent.com/u/14775807?v=4","gravatar_id":"","url":"https://api.github.com/users/NetworkManager","html_url":"https://github.com/NetworkManager","followers_url":"https://api.github.com/users/NetworkManager/followers","following_url":"https://api.github.com/users/NetworkManager/following{/other_user}","gists_url":"https://api.github.com/users/NetworkManager/gists{/gist_id}","starred_url":"https://api.github.com/users/NetworkManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetworkManager/subscriptions","organizations_url":"https://api.github.com/users/NetworkManager/orgs","repos_url":"https://api.github.com/users/NetworkManager/repos","events_url":"https://api.github.com/users/NetworkManager/events{/privacy}","received_events_url":"https://api.github.com/users/NetworkManager/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NetworkManager/NetworkManager","description":"Mirror of the freedesktop.org repository. Feel free to do the pull requests!","fork":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager","forks_url":"https://api.github.com/repos/NetworkManager/NetworkManager/forks","keys_url":"https://api.github.com/repos/NetworkManager/NetworkManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetworkManager/NetworkManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetworkManager/NetworkManager/teams","hooks_url":"https://api.github.com/repos/NetworkManager/NetworkManager/hooks","issue_events_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/events{/number}","events_url":"https://api.github.com/repos/NetworkManager/NetworkManager/events","assignees_url":"https://api.github.com/repos/NetworkManager/NetworkManager/assignees{/user}","branches_url":"https://api.github.com/repos/NetworkManager/NetworkManager/branches{/branch}","tags_url":"https://api.github.com/repos/NetworkManager/NetworkManager/tags","blobs_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetworkManager/NetworkManager/statuses/{sha}","languages_url":"https://api.github.com/repos/NetworkManager/NetworkManager/languages","stargazers_url":"https://api.github.com/repos/NetworkManager/NetworkManager/stargazers","contributors_url":"https://api.github.com/repos/NetworkManager/NetworkManager/contributors","subscribers_url":"https://api.github.com/repos/NetworkManager/NetworkManager/subscribers","subscription_url":"https://api.github.com/repos/NetworkManager/NetworkManager/subscription","commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetworkManager/NetworkManager/contents/{+path}","compare_url":"https://api.github.com/repos/NetworkManager/NetworkManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetworkManager/NetworkManager/merges","archive_url":"https://api.github.com/repos/NetworkManager/NetworkManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetworkManager/NetworkManager/downloads","issues_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues{/number}","pulls_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls{/number}","milestones_url":"https://api.github.com/repos/NetworkManager/NetworkManager/milestones{/number}","notifications_url":"https://api.github.com/repos/NetworkManager/NetworkManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetworkManager/NetworkManager/labels{/name}","releases_url":"https://api.github.com/repos/NetworkManager/NetworkManager/releases{/id}","deployments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/deployments","created_at":"2015-09-22T13:12:35Z","updated_at":"2019-04-04T13:52:11Z","pushed_at":"2019-04-04T14:02:41Z","git_url":"git://github.com/NetworkManager/NetworkManager.git","ssh_url":"git@github.com:NetworkManager/NetworkManager.git","clone_url":"https://github.com/NetworkManager/NetworkManager.git","svn_url":"https://github.com/NetworkManager/NetworkManager","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","size":126550,"stargazers_count":100,"watchers_count":100,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":78,"open_issues":9,"watchers":100,"default_branch":"master"}},"base":{"label":"NetworkManager:master","ref":"master","sha":"9c049b3a0064f6054a816ad1de94a13f33a1db7f","user":{"login":"NetworkManager","id":14775807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzc1ODA3","avatar_url":"https://avatars2.githubusercontent.com/u/14775807?v=4","gravatar_id":"","url":"https://api.github.com/users/NetworkManager","html_url":"https://github.com/NetworkManager","followers_url":"https://api.github.com/users/NetworkManager/followers","following_url":"https://api.github.com/users/NetworkManager/following{/other_user}","gists_url":"https://api.github.com/users/NetworkManager/gists{/gist_id}","starred_url":"https://api.github.com/users/NetworkManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetworkManager/subscriptions","organizations_url":"https://api.github.com/users/NetworkManager/orgs","repos_url":"https://api.github.com/users/NetworkManager/repos","events_url":"https://api.github.com/users/NetworkManager/events{/privacy}","received_events_url":"https://api.github.com/users/NetworkManager/received_events","type":"Organization","site_admin":false},"repo":{"id":42934521,"node_id":"MDEwOlJlcG9zaXRvcnk0MjkzNDUyMQ==","name":"NetworkManager","full_name":"NetworkManager/NetworkManager","private":false,"owner":{"login":"NetworkManager","id":14775807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzc1ODA3","avatar_url":"https://avatars2.githubusercontent.com/u/14775807?v=4","gravatar_id":"","url":"https://api.github.com/users/NetworkManager","html_url":"https://github.com/NetworkManager","followers_url":"https://api.github.com/users/NetworkManager/followers","following_url":"https://api.github.com/users/NetworkManager/following{/other_user}","gists_url":"https://api.github.com/users/NetworkManager/gists{/gist_id}","starred_url":"https://api.github.com/users/NetworkManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetworkManager/subscriptions","organizations_url":"https://api.github.com/users/NetworkManager/orgs","repos_url":"https://api.github.com/users/NetworkManager/repos","events_url":"https://api.github.com/users/NetworkManager/events{/privacy}","received_events_url":"https://api.github.com/users/NetworkManager/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NetworkManager/NetworkManager","description":"Mirror of the freedesktop.org repository. Feel free to do the pull requests!","fork":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager","forks_url":"https://api.github.com/repos/NetworkManager/NetworkManager/forks","keys_url":"https://api.github.com/repos/NetworkManager/NetworkManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetworkManager/NetworkManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetworkManager/NetworkManager/teams","hooks_url":"https://api.github.com/repos/NetworkManager/NetworkManager/hooks","issue_events_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/events{/number}","events_url":"https://api.github.com/repos/NetworkManager/NetworkManager/events","assignees_url":"https://api.github.com/repos/NetworkManager/NetworkManager/assignees{/user}","branches_url":"https://api.github.com/repos/NetworkManager/NetworkManager/branches{/branch}","tags_url":"https://api.github.com/repos/NetworkManager/NetworkManager/tags","blobs_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetworkManager/NetworkManager/statuses/{sha}","languages_url":"https://api.github.com/repos/NetworkManager/NetworkManager/languages","stargazers_url":"https://api.github.com/repos/NetworkManager/NetworkManager/stargazers","contributors_url":"https://api.github.com/repos/NetworkManager/NetworkManager/contributors","subscribers_url":"https://api.github.com/repos/NetworkManager/NetworkManager/subscribers","subscription_url":"https://api.github.com/repos/NetworkManager/NetworkManager/subscription","commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetworkManager/NetworkManager/contents/{+path}","compare_url":"https://api.github.com/repos/NetworkManager/NetworkManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetworkManager/NetworkManager/merges","archive_url":"https://api.github.com/repos/NetworkManager/NetworkManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetworkManager/NetworkManager/downloads","issues_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues{/number}","pulls_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls{/number}","milestones_url":"https://api.github.com/repos/NetworkManager/NetworkManager/milestones{/number}","notifications_url":"https://api.github.com/repos/NetworkManager/NetworkManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetworkManager/NetworkManager/labels{/name}","releases_url":"https://api.github.com/repos/NetworkManager/NetworkManager/releases{/id}","deployments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/deployments","created_at":"2015-09-22T13:12:35Z","updated_at":"2019-04-04T13:52:11Z","pushed_at":"2019-04-04T14:02:41Z","git_url":"git://github.com/NetworkManager/NetworkManager.git","ssh_url":"git@github.com:NetworkManager/NetworkManager.git","clone_url":"https://github.com/NetworkManager/NetworkManager.git","svn_url":"https://github.com/NetworkManager/NetworkManager","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","size":126550,"stargazers_count":100,"watchers_count":100,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":78,"open_issues":9,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/332"},"html":{"href":"https://github.com/NetworkManager/NetworkManager/pull/332"},"issue":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/332"},"comments":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/statuses/da3f7a355e4e3c9163db7bcee0cc5476d1d9ff0f"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":17,"additions":768,"deletions":526,"changed_files":20}}
{"actor":{"display_login":"thom311"}}