{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-livy/pulls/comments/312343978","pull_request_review_id":272962808,"id":312343978,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjM0Mzk3OA==","diff_hunk":"@@ -101,6 +101,7 @@ object BatchSession extends Logging {\n             case 0 =>\n             case exitCode =>\n               warn(s\"spark-submit exited with code $exitCode\")\n+              s.stateChanged(SparkApp.State.KILLED)","path":"server/src/main/scala/org/apache/livy/server/batch/BatchSession.scala","position":4,"original_position":4,"commit_id":"656e59168f801c65c3b007b76e86127c718ba8e9","original_commit_id":"656e59168f801c65c3b007b76e86127c718ba8e9","user":{"login":"yiheng","id":1297418,"node_id":"MDQ6VXNlcjEyOTc0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1297418?v=4","gravatar_id":"","url":"https://api.github.com/users/yiheng","html_url":"https://github.com/yiheng","followers_url":"https://api.github.com/users/yiheng/followers","following_url":"https://api.github.com/users/yiheng/following{/other_user}","gists_url":"https://api.github.com/users/yiheng/gists{/gist_id}","starred_url":"https://api.github.com/users/yiheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiheng/subscriptions","organizations_url":"https://api.github.com/users/yiheng/orgs","repos_url":"https://api.github.com/users/yiheng/repos","events_url":"https://api.github.com/users/yiheng/events{/privacy}","received_events_url":"https://api.github.com/users/yiheng/received_events","type":"User","site_admin":false},"body":"why not use `SparkApp.State.FAILED`?","created_at":"2019-08-09T06:29:09Z","updated_at":"2019-08-09T06:29:09Z","html_url":"https://github.com/apache/incubator-livy/pull/192#discussion_r312343978","pull_request_url":"https://api.github.com/repos/apache/incubator-livy/pulls/192","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/comments/312343978"},"html":{"href":"https://github.com/apache/incubator-livy/pull/192#discussion_r312343978"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-livy/pulls/192","id":303591059,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzNTkxMDU5","html_url":"https://github.com/apache/incubator-livy/pull/192","diff_url":"https://github.com/apache/incubator-livy/pull/192.diff","patch_url":"https://github.com/apache/incubator-livy/pull/192.patch","issue_url":"https://api.github.com/repos/apache/incubator-livy/issues/192","number":192,"state":"open","locked":false,"title":"[LIVY-620] Spark batch session always ends with success when configuration is master yarn and deploy-mode client","user":{"login":"gumartinm","id":1122410,"node_id":"MDQ6VXNlcjExMjI0MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1122410?v=4","gravatar_id":"","url":"https://api.github.com/users/gumartinm","html_url":"https://github.com/gumartinm","followers_url":"https://api.github.com/users/gumartinm/followers","following_url":"https://api.github.com/users/gumartinm/following{/other_user}","gists_url":"https://api.github.com/users/gumartinm/gists{/gist_id}","starred_url":"https://api.github.com/users/gumartinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gumartinm/subscriptions","organizations_url":"https://api.github.com/users/gumartinm/orgs","repos_url":"https://api.github.com/users/gumartinm/repos","events_url":"https://api.github.com/users/gumartinm/events{/privacy}","received_events_url":"https://api.github.com/users/gumartinm/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nBatch session should end with state killed when process exits with no 0 return code.\r\nhttps://issues.apache.org/jira/browse/LIVY-620\r\n\r\n## How was this patch tested?\r\n\r\n1. Unit Test (included in this PR)\r\nSubmit batch session that runs forever, wait 2 seconds, kill that batch session and expect for state killed.\r\n\r\n2. Also currently used in production environment.\r\n","created_at":"2019-08-01T23:38:05Z","updated_at":"2019-08-09T06:29:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71df3067f9d6cf7d0675c6d88ff304a8b785d05f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-livy/pulls/192/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-livy/pulls/192/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-livy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-livy/issues/192/comments","statuses_url":"https://api.github.com/repos/apache/incubator-livy/statuses/656e59168f801c65c3b007b76e86127c718ba8e9","head":{"label":"gumartinm:master","ref":"master","sha":"656e59168f801c65c3b007b76e86127c718ba8e9","user":{"login":"gumartinm","id":1122410,"node_id":"MDQ6VXNlcjExMjI0MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1122410?v=4","gravatar_id":"","url":"https://api.github.com/users/gumartinm","html_url":"https://github.com/gumartinm","followers_url":"https://api.github.com/users/gumartinm/followers","following_url":"https://api.github.com/users/gumartinm/following{/other_user}","gists_url":"https://api.github.com/users/gumartinm/gists{/gist_id}","starred_url":"https://api.github.com/users/gumartinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gumartinm/subscriptions","organizations_url":"https://api.github.com/users/gumartinm/orgs","repos_url":"https://api.github.com/users/gumartinm/repos","events_url":"https://api.github.com/users/gumartinm/events{/privacy}","received_events_url":"https://api.github.com/users/gumartinm/received_events","type":"User","site_admin":false},"repo":{"id":200114691,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAxMTQ2OTE=","name":"incubator-livy","full_name":"gumartinm/incubator-livy","private":false,"owner":{"login":"gumartinm","id":1122410,"node_id":"MDQ6VXNlcjExMjI0MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1122410?v=4","gravatar_id":"","url":"https://api.github.com/users/gumartinm","html_url":"https://github.com/gumartinm","followers_url":"https://api.github.com/users/gumartinm/followers","following_url":"https://api.github.com/users/gumartinm/following{/other_user}","gists_url":"https://api.github.com/users/gumartinm/gists{/gist_id}","starred_url":"https://api.github.com/users/gumartinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gumartinm/subscriptions","organizations_url":"https://api.github.com/users/gumartinm/orgs","repos_url":"https://api.github.com/users/gumartinm/repos","events_url":"https://api.github.com/users/gumartinm/events{/privacy}","received_events_url":"https://api.github.com/users/gumartinm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gumartinm/incubator-livy","description":"Mirror of Apache livy (Incubating)","fork":true,"url":"https://api.github.com/repos/gumartinm/incubator-livy","forks_url":"https://api.github.com/repos/gumartinm/incubator-livy/forks","keys_url":"https://api.github.com/repos/gumartinm/incubator-livy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gumartinm/incubator-livy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gumartinm/incubator-livy/teams","hooks_url":"https://api.github.com/repos/gumartinm/incubator-livy/hooks","issue_events_url":"https://api.github.com/repos/gumartinm/incubator-livy/issues/events{/number}","events_url":"https://api.github.com/repos/gumartinm/incubator-livy/events","assignees_url":"https://api.github.com/repos/gumartinm/incubator-livy/assignees{/user}","branches_url":"https://api.github.com/repos/gumartinm/incubator-livy/branches{/branch}","tags_url":"https://api.github.com/repos/gumartinm/incubator-livy/tags","blobs_url":"https://api.github.com/repos/gumartinm/incubator-livy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gumartinm/incubator-livy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gumartinm/incubator-livy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gumartinm/incubator-livy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gumartinm/incubator-livy/statuses/{sha}","languages_url":"https://api.github.com/repos/gumartinm/incubator-livy/languages","stargazers_url":"https://api.github.com/repos/gumartinm/incubator-livy/stargazers","contributors_url":"https://api.github.com/repos/gumartinm/incubator-livy/contributors","subscribers_url":"https://api.github.com/repos/gumartinm/incubator-livy/subscribers","subscription_url":"https://api.github.com/repos/gumartinm/incubator-livy/subscription","commits_url":"https://api.github.com/repos/gumartinm/incubator-livy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gumartinm/incubator-livy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gumartinm/incubator-livy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gumartinm/incubator-livy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gumartinm/incubator-livy/contents/{+path}","compare_url":"https://api.github.com/repos/gumartinm/incubator-livy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gumartinm/incubator-livy/merges","archive_url":"https://api.github.com/repos/gumartinm/incubator-livy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gumartinm/incubator-livy/downloads","issues_url":"https://api.github.com/repos/gumartinm/incubator-livy/issues{/number}","pulls_url":"https://api.github.com/repos/gumartinm/incubator-livy/pulls{/number}","milestones_url":"https://api.github.com/repos/gumartinm/incubator-livy/milestones{/number}","notifications_url":"https://api.github.com/repos/gumartinm/incubator-livy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gumartinm/incubator-livy/labels{/name}","releases_url":"https://api.github.com/repos/gumartinm/incubator-livy/releases{/id}","deployments_url":"https://api.github.com/repos/gumartinm/incubator-livy/deployments","created_at":"2019-08-01T20:25:19Z","updated_at":"2019-08-02T00:49:48Z","pushed_at":"2019-08-02T00:49:46Z","git_url":"git://github.com/gumartinm/incubator-livy.git","ssh_url":"git@github.com:gumartinm/incubator-livy.git","clone_url":"https://github.com/gumartinm/incubator-livy.git","svn_url":"https://github.com/gumartinm/incubator-livy","homepage":null,"size":3388,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"788767e4cced78f18798f73a651f3ec2d087f938","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":95343930,"node_id":"MDEwOlJlcG9zaXRvcnk5NTM0MzkzMA==","name":"incubator-livy","full_name":"apache/incubator-livy","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-livy","description":"Mirror of Apache livy (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-livy","forks_url":"https://api.github.com/repos/apache/incubator-livy/forks","keys_url":"https://api.github.com/repos/apache/incubator-livy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-livy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-livy/teams","hooks_url":"https://api.github.com/repos/apache/incubator-livy/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-livy/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-livy/events","assignees_url":"https://api.github.com/repos/apache/incubator-livy/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-livy/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-livy/tags","blobs_url":"https://api.github.com/repos/apache/incubator-livy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-livy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-livy/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-livy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-livy/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-livy/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-livy/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-livy/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-livy/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-livy/subscription","commits_url":"https://api.github.com/repos/apache/incubator-livy/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-livy/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-livy/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-livy/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-livy/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-livy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-livy/merges","archive_url":"https://api.github.com/repos/apache/incubator-livy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-livy/downloads","issues_url":"https://api.github.com/repos/apache/incubator-livy/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-livy/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-livy/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-livy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-livy/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-livy/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-livy/deployments","created_at":"2017-06-25T07:00:09Z","updated_at":"2019-08-09T03:19:46Z","pushed_at":"2019-08-09T04:29:10Z","git_url":"git://github.com/apache/incubator-livy.git","ssh_url":"git@github.com:apache/incubator-livy.git","clone_url":"https://github.com/apache/incubator-livy.git","svn_url":"https://github.com/apache/incubator-livy","homepage":null,"size":3384,"stargazers_count":350,"watchers_count":350,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":224,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":224,"open_issues":33,"watchers":350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/192"},"html":{"href":"https://github.com/apache/incubator-livy/pull/192"},"issue":{"href":"https://api.github.com/repos/apache/incubator-livy/issues/192"},"comments":{"href":"https://api.github.com/repos/apache/incubator-livy/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-livy/statuses/656e59168f801c65c3b007b76e86127c718ba8e9"}},"author_association":"NONE"}}
{"actor":{"display_login":"yiheng"}}