{"action":"opened","number":4884,"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/4884","id":300083922,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMDgzOTIy","html_url":"https://github.com/knative/serving/pull/4884","diff_url":"https://github.com/knative/serving/pull/4884.diff","patch_url":"https://github.com/knative/serving/pull/4884.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/4884","number":4884,"state":"open","locked":false,"title":"[WIP] Only set minScale if revision is routable","user":{"login":"tanzeeb","id":8570,"node_id":"MDQ6VXNlcjg1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8570?v=4","gravatar_id":"","url":"https://api.github.com/users/tanzeeb","html_url":"https://github.com/tanzeeb","followers_url":"https://api.github.com/users/tanzeeb/followers","following_url":"https://api.github.com/users/tanzeeb/following{/other_user}","gists_url":"https://api.github.com/users/tanzeeb/gists{/gist_id}","starred_url":"https://api.github.com/users/tanzeeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanzeeb/subscriptions","organizations_url":"https://api.github.com/users/tanzeeb/orgs","repos_url":"https://api.github.com/users/tanzeeb/repos","events_url":"https://api.github.com/users/tanzeeb/events{/privacy}","received_events_url":"https://api.github.com/users/tanzeeb/received_events","type":"User","site_admin":false},"body":"*Note*: WIP POC, looking for feedback on general approach\r\n\r\nFixes #4183 \r\n\r\n## Proposed Changes\r\n\r\n* Don't set `minScale` annotation on `PodAutoscalers` of unroutable Revisions\r\n\r\n**Release Note**\r\n\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n\r\n```release-note\r\n`minScale` will only be applied to Revisions with active Routes.\r\n```\r\n","created_at":"2019-07-23T00:15:41Z","updated_at":"2019-07-23T00:15:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/4884/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/4884/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/4884/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/83d1874031706854fc19835754fbf249dc3ab614","head":{"label":"tanzeeb:no-unroutable-minscale","ref":"no-unroutable-minscale","sha":"83d1874031706854fc19835754fbf249dc3ab614","user":{"login":"tanzeeb","id":8570,"node_id":"MDQ6VXNlcjg1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8570?v=4","gravatar_id":"","url":"https://api.github.com/users/tanzeeb","html_url":"https://github.com/tanzeeb","followers_url":"https://api.github.com/users/tanzeeb/followers","following_url":"https://api.github.com/users/tanzeeb/following{/other_user}","gists_url":"https://api.github.com/users/tanzeeb/gists{/gist_id}","starred_url":"https://api.github.com/users/tanzeeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanzeeb/subscriptions","organizations_url":"https://api.github.com/users/tanzeeb/orgs","repos_url":"https://api.github.com/users/tanzeeb/repos","events_url":"https://api.github.com/users/tanzeeb/events{/privacy}","received_events_url":"https://api.github.com/users/tanzeeb/received_events","type":"User","site_admin":false},"repo":{"id":142336028,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMzYwMjg=","name":"serving","full_name":"tanzeeb/serving","private":false,"owner":{"login":"tanzeeb","id":8570,"node_id":"MDQ6VXNlcjg1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8570?v=4","gravatar_id":"","url":"https://api.github.com/users/tanzeeb","html_url":"https://github.com/tanzeeb","followers_url":"https://api.github.com/users/tanzeeb/followers","following_url":"https://api.github.com/users/tanzeeb/following{/other_user}","gists_url":"https://api.github.com/users/tanzeeb/gists{/gist_id}","starred_url":"https://api.github.com/users/tanzeeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanzeeb/subscriptions","organizations_url":"https://api.github.com/users/tanzeeb/orgs","repos_url":"https://api.github.com/users/tanzeeb/repos","events_url":"https://api.github.com/users/tanzeeb/events{/privacy}","received_events_url":"https://api.github.com/users/tanzeeb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tanzeeb/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/tanzeeb/serving","forks_url":"https://api.github.com/repos/tanzeeb/serving/forks","keys_url":"https://api.github.com/repos/tanzeeb/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tanzeeb/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tanzeeb/serving/teams","hooks_url":"https://api.github.com/repos/tanzeeb/serving/hooks","issue_events_url":"https://api.github.com/repos/tanzeeb/serving/issues/events{/number}","events_url":"https://api.github.com/repos/tanzeeb/serving/events","assignees_url":"https://api.github.com/repos/tanzeeb/serving/assignees{/user}","branches_url":"https://api.github.com/repos/tanzeeb/serving/branches{/branch}","tags_url":"https://api.github.com/repos/tanzeeb/serving/tags","blobs_url":"https://api.github.com/repos/tanzeeb/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tanzeeb/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tanzeeb/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/tanzeeb/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tanzeeb/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/tanzeeb/serving/languages","stargazers_url":"https://api.github.com/repos/tanzeeb/serving/stargazers","contributors_url":"https://api.github.com/repos/tanzeeb/serving/contributors","subscribers_url":"https://api.github.com/repos/tanzeeb/serving/subscribers","subscription_url":"https://api.github.com/repos/tanzeeb/serving/subscription","commits_url":"https://api.github.com/repos/tanzeeb/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/tanzeeb/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/tanzeeb/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/tanzeeb/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/tanzeeb/serving/contents/{+path}","compare_url":"https://api.github.com/repos/tanzeeb/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tanzeeb/serving/merges","archive_url":"https://api.github.com/repos/tanzeeb/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tanzeeb/serving/downloads","issues_url":"https://api.github.com/repos/tanzeeb/serving/issues{/number}","pulls_url":"https://api.github.com/repos/tanzeeb/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/tanzeeb/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/tanzeeb/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tanzeeb/serving/labels{/name}","releases_url":"https://api.github.com/repos/tanzeeb/serving/releases{/id}","deployments_url":"https://api.github.com/repos/tanzeeb/serving/deployments","created_at":"2018-07-25T18:01:16Z","updated_at":"2018-07-25T18:01:19Z","pushed_at":"2019-07-23T00:11:18Z","git_url":"git://github.com/tanzeeb/serving.git","ssh_url":"git@github.com:tanzeeb/serving.git","clone_url":"https://github.com/tanzeeb/serving.git","svn_url":"https://github.com/tanzeeb/serving","homepage":"","size":38028,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"b8f0692d2194dab578312e560dab6e66046d82e4","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2019-07-22T23:32:46Z","pushed_at":"2019-07-23T00:10:00Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"https://knative.dev/docs/serving/","size":38291,"stargazers_count":2074,"watchers_count":2074,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":399,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":289,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":399,"open_issues":289,"watchers":2074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/4884"},"html":{"href":"https://github.com/knative/serving/pull/4884"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/4884"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/4884/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/4884/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/4884/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/83d1874031706854fc19835754fbf249dc3ab614"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":68,"deletions":9,"changed_files":4}}
{"actor":{"display_login":"tanzeeb"}}