{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/titan/pulls/comments/303726217","pull_request_review_id":262185631,"id":303726217,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzcyNjIxNw==","diff_hunk":"@@ -209,13 +209,17 @@ TEST_F(BlobFileIteratorTest, MergeIterator) {\n   BlobFileMergeIterator iter(std::move(iters));\n \n   iter.SeekToFirst();\n-  for (int i = 1; i < kMaxKeyNum; i++, iter.Next()) {\n+  int i = 1;\n+  while (iter.Valid()) {\n     ASSERT_OK(iter.status());\n     ASSERT_TRUE(iter.Valid());\n     ASSERT_EQ(iter.key(), GenKey(i));\n     ASSERT_EQ(iter.value(), GenValue(i));\n     ASSERT_EQ(iter.GetBlobIndex().blob_handle, handles[i]);\n+    i++;\n+    iter.Next();\n   }\n+  ASSERT_EQ(i, kMaxKeyNum);","path":"src/blob_file_iterator_test.cc","position":15,"original_position":15,"commit_id":"81cfa761d52a1c6e50174bed21bd12feaadcb88e","original_commit_id":"efc0fe9a9515d422b7e6dd0faf52b70ed0575d42","user":{"login":"yiwu-arbug","id":2606959,"node_id":"MDQ6VXNlcjI2MDY5NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2606959?v=4","gravatar_id":"","url":"https://api.github.com/users/yiwu-arbug","html_url":"https://github.com/yiwu-arbug","followers_url":"https://api.github.com/users/yiwu-arbug/followers","following_url":"https://api.github.com/users/yiwu-arbug/following{/other_user}","gists_url":"https://api.github.com/users/yiwu-arbug/gists{/gist_id}","starred_url":"https://api.github.com/users/yiwu-arbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiwu-arbug/subscriptions","organizations_url":"https://api.github.com/users/yiwu-arbug/orgs","repos_url":"https://api.github.com/users/yiwu-arbug/repos","events_url":"https://api.github.com/users/yiwu-arbug/events{/privacy}","received_events_url":"https://api.github.com/users/yiwu-arbug/received_events","type":"User","site_admin":false},"body":"@wujy-cs said the test will fail ASAN on Mac though.","created_at":"2019-07-16T04:47:43Z","updated_at":"2019-07-16T04:47:43Z","html_url":"https://github.com/pingcap/titan/pull/41#discussion_r303726217","pull_request_url":"https://api.github.com/repos/pingcap/titan/pulls/41","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/titan/pulls/comments/303726217"},"html":{"href":"https://github.com/pingcap/titan/pull/41#discussion_r303726217"},"pull_request":{"href":"https://api.github.com/repos/pingcap/titan/pulls/41"}},"in_reply_to_id":302363855},"pull_request":{"url":"https://api.github.com/repos/pingcap/titan/pulls/41","id":296253979,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2MjUzOTc5","html_url":"https://github.com/pingcap/titan/pull/41","diff_url":"https://github.com/pingcap/titan/pull/41.diff","patch_url":"https://github.com/pingcap/titan/pull/41.patch","issue_url":"https://api.github.com/repos/pingcap/titan/issues/41","number":41,"state":"open","locked":false,"title":"Fix mac build and blob_file_iterator","user":{"login":"wujy-cs","id":30256490,"node_id":"MDQ6VXNlcjMwMjU2NDkw","avatar_url":"https://avatars2.githubusercontent.com/u/30256490?v=4","gravatar_id":"","url":"https://api.github.com/users/wujy-cs","html_url":"https://github.com/wujy-cs","followers_url":"https://api.github.com/users/wujy-cs/followers","following_url":"https://api.github.com/users/wujy-cs/following{/other_user}","gists_url":"https://api.github.com/users/wujy-cs/gists{/gist_id}","starred_url":"https://api.github.com/users/wujy-cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wujy-cs/subscriptions","organizations_url":"https://api.github.com/users/wujy-cs/orgs","repos_url":"https://api.github.com/users/wujy-cs/repos","events_url":"https://api.github.com/users/wujy-cs/events{/privacy}","received_events_url":"https://api.github.com/users/wujy-cs/received_events","type":"User","site_admin":false},"body":"- There is no libatomic in MacOS clang(and maybe some other environment), so check if libatomic existed before link.\r\n- Added MacOS build to travis. For TSAN build , a unused-command-line-argument is defined in RocksDB cmake file, witch will fail compilation on MacOS, skip it.\r\n- Fixed a container overflow bug in blob_file_iterator.cc, witch will fail tests on MacOS.","created_at":"2019-07-10T16:32:49Z","updated_at":"2019-07-16T04:47:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"109427d09913bea217d923b469e8fed7b0321f03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1345100670,"node_id":"MDU6TGFiZWwxMzQ1MTAwNjcw","url":"https://api.github.com/repos/pingcap/titan/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/titan/pulls/41/commits","review_comments_url":"https://api.github.com/repos/pingcap/titan/pulls/41/comments","review_comment_url":"https://api.github.com/repos/pingcap/titan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/titan/issues/41/comments","statuses_url":"https://api.github.com/repos/pingcap/titan/statuses/81cfa761d52a1c6e50174bed21bd12feaadcb88e","head":{"label":"wujy-cs:master","ref":"master","sha":"81cfa761d52a1c6e50174bed21bd12feaadcb88e","user":{"login":"wujy-cs","id":30256490,"node_id":"MDQ6VXNlcjMwMjU2NDkw","avatar_url":"https://avatars2.githubusercontent.com/u/30256490?v=4","gravatar_id":"","url":"https://api.github.com/users/wujy-cs","html_url":"https://github.com/wujy-cs","followers_url":"https://api.github.com/users/wujy-cs/followers","following_url":"https://api.github.com/users/wujy-cs/following{/other_user}","gists_url":"https://api.github.com/users/wujy-cs/gists{/gist_id}","starred_url":"https://api.github.com/users/wujy-cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wujy-cs/subscriptions","organizations_url":"https://api.github.com/users/wujy-cs/orgs","repos_url":"https://api.github.com/users/wujy-cs/repos","events_url":"https://api.github.com/users/wujy-cs/events{/privacy}","received_events_url":"https://api.github.com/users/wujy-cs/received_events","type":"User","site_admin":false},"repo":{"id":195838153,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU4MzgxNTM=","name":"titan","full_name":"wujy-cs/titan","private":false,"owner":{"login":"wujy-cs","id":30256490,"node_id":"MDQ6VXNlcjMwMjU2NDkw","avatar_url":"https://avatars2.githubusercontent.com/u/30256490?v=4","gravatar_id":"","url":"https://api.github.com/users/wujy-cs","html_url":"https://github.com/wujy-cs","followers_url":"https://api.github.com/users/wujy-cs/followers","following_url":"https://api.github.com/users/wujy-cs/following{/other_user}","gists_url":"https://api.github.com/users/wujy-cs/gists{/gist_id}","starred_url":"https://api.github.com/users/wujy-cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wujy-cs/subscriptions","organizations_url":"https://api.github.com/users/wujy-cs/orgs","repos_url":"https://api.github.com/users/wujy-cs/repos","events_url":"https://api.github.com/users/wujy-cs/events{/privacy}","received_events_url":"https://api.github.com/users/wujy-cs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wujy-cs/titan","description":"A RocksDB plugin for key-value separation, inspired by WiscKey.","fork":true,"url":"https://api.github.com/repos/wujy-cs/titan","forks_url":"https://api.github.com/repos/wujy-cs/titan/forks","keys_url":"https://api.github.com/repos/wujy-cs/titan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wujy-cs/titan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wujy-cs/titan/teams","hooks_url":"https://api.github.com/repos/wujy-cs/titan/hooks","issue_events_url":"https://api.github.com/repos/wujy-cs/titan/issues/events{/number}","events_url":"https://api.github.com/repos/wujy-cs/titan/events","assignees_url":"https://api.github.com/repos/wujy-cs/titan/assignees{/user}","branches_url":"https://api.github.com/repos/wujy-cs/titan/branches{/branch}","tags_url":"https://api.github.com/repos/wujy-cs/titan/tags","blobs_url":"https://api.github.com/repos/wujy-cs/titan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wujy-cs/titan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wujy-cs/titan/git/refs{/sha}","trees_url":"https://api.github.com/repos/wujy-cs/titan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wujy-cs/titan/statuses/{sha}","languages_url":"https://api.github.com/repos/wujy-cs/titan/languages","stargazers_url":"https://api.github.com/repos/wujy-cs/titan/stargazers","contributors_url":"https://api.github.com/repos/wujy-cs/titan/contributors","subscribers_url":"https://api.github.com/repos/wujy-cs/titan/subscribers","subscription_url":"https://api.github.com/repos/wujy-cs/titan/subscription","commits_url":"https://api.github.com/repos/wujy-cs/titan/commits{/sha}","git_commits_url":"https://api.github.com/repos/wujy-cs/titan/git/commits{/sha}","comments_url":"https://api.github.com/repos/wujy-cs/titan/comments{/number}","issue_comment_url":"https://api.github.com/repos/wujy-cs/titan/issues/comments{/number}","contents_url":"https://api.github.com/repos/wujy-cs/titan/contents/{+path}","compare_url":"https://api.github.com/repos/wujy-cs/titan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wujy-cs/titan/merges","archive_url":"https://api.github.com/repos/wujy-cs/titan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wujy-cs/titan/downloads","issues_url":"https://api.github.com/repos/wujy-cs/titan/issues{/number}","pulls_url":"https://api.github.com/repos/wujy-cs/titan/pulls{/number}","milestones_url":"https://api.github.com/repos/wujy-cs/titan/milestones{/number}","notifications_url":"https://api.github.com/repos/wujy-cs/titan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wujy-cs/titan/labels{/name}","releases_url":"https://api.github.com/repos/wujy-cs/titan/releases{/id}","deployments_url":"https://api.github.com/repos/wujy-cs/titan/deployments","created_at":"2019-07-08T15:17:40Z","updated_at":"2019-07-11T05:57:46Z","pushed_at":"2019-07-15T11:28:26Z","git_url":"git://github.com/wujy-cs/titan.git","ssh_url":"git@github.com:wujy-cs/titan.git","clone_url":"https://github.com/wujy-cs/titan.git","svn_url":"https://github.com/wujy-cs/titan","homepage":"https://pingcap.com/blog/titan-storage-engine-design-and-implementation/","size":279,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"397b6d22456d027a40c635abb2a36de9d55f48ad","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":184635772,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ2MzU3NzI=","name":"titan","full_name":"pingcap/titan","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/titan","description":"A RocksDB plugin for key-value separation, inspired by WiscKey.","fork":false,"url":"https://api.github.com/repos/pingcap/titan","forks_url":"https://api.github.com/repos/pingcap/titan/forks","keys_url":"https://api.github.com/repos/pingcap/titan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/titan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/titan/teams","hooks_url":"https://api.github.com/repos/pingcap/titan/hooks","issue_events_url":"https://api.github.com/repos/pingcap/titan/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/titan/events","assignees_url":"https://api.github.com/repos/pingcap/titan/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/titan/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/titan/tags","blobs_url":"https://api.github.com/repos/pingcap/titan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/titan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/titan/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/titan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/titan/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/titan/languages","stargazers_url":"https://api.github.com/repos/pingcap/titan/stargazers","contributors_url":"https://api.github.com/repos/pingcap/titan/contributors","subscribers_url":"https://api.github.com/repos/pingcap/titan/subscribers","subscription_url":"https://api.github.com/repos/pingcap/titan/subscription","commits_url":"https://api.github.com/repos/pingcap/titan/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/titan/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/titan/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/titan/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/titan/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/titan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/titan/merges","archive_url":"https://api.github.com/repos/pingcap/titan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/titan/downloads","issues_url":"https://api.github.com/repos/pingcap/titan/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/titan/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/titan/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/titan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/titan/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/titan/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/titan/deployments","created_at":"2019-05-02T18:59:17Z","updated_at":"2019-07-15T06:26:08Z","pushed_at":"2019-07-15T11:28:27Z","git_url":"git://github.com/pingcap/titan.git","ssh_url":"git@github.com:pingcap/titan.git","clone_url":"https://github.com/pingcap/titan.git","svn_url":"https://github.com/pingcap/titan","homepage":"https://pingcap.com/blog/titan-storage-engine-design-and-implementation/","size":264,"stargazers_count":54,"watchers_count":54,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":9,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/titan/pulls/41"},"html":{"href":"https://github.com/pingcap/titan/pull/41"},"issue":{"href":"https://api.github.com/repos/pingcap/titan/issues/41"},"comments":{"href":"https://api.github.com/repos/pingcap/titan/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/titan/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/titan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/titan/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/titan/statuses/81cfa761d52a1c6e50174bed21bd12feaadcb88e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"yiwu-arbug"}}