{"action":"opened","number":295,"pull_request":{"url":"https://api.github.com/repos/Netflix/pollyjs/pulls/295","id":361938547,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxOTM4NTQ3","html_url":"https://github.com/Netflix/pollyjs/pull/295","diff_url":"https://github.com/Netflix/pollyjs/pull/295.diff","patch_url":"https://github.com/Netflix/pollyjs/pull/295.patch","issue_url":"https://api.github.com/repos/Netflix/pollyjs/issues/295","number":295,"state":"open","locked":false,"title":"feat(core): Remove deprecated `recordIfExpired` option","user":{"login":"offirgolan","id":575938,"node_id":"MDQ6VXNlcjU3NTkzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/575938?v=4","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n\r\nThe `recordIfExpired` option has been expired for a while now and since we're about to release a new major version, this is a good time to remove it altogether.\r\n\r\n## Types of Changes\r\n\r\n<!---\r\n  What types of changes does your code introduce? Put an `x` in all the boxes that apply:\r\n-->\r\n\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist\r\n\r\n<!---\r\n  Go over all the following points, and put an `x` in all the boxes that apply.\r\n\r\n  If you're unsure about any of these, don't hesitate to ask. We're here to help!\r\n-->\r\n\r\n- [ ] I have added tests to cover my changes.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] My code follows the code style of this project.\r\n- [x] My commits and the title of this PR follow the [Conventional Commits Specification](https://www.conventionalcommits.org).\r\n- [x] I have read the [contributing guidelines](https://github.com/Netflix/pollyjs/blob/master/CONTRIBUTING.md).\r\n","created_at":"2020-01-13T05:26:53Z","updated_at":"2020-01-13T05:26:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"jasonmit","id":3108309,"node_id":"MDQ6VXNlcjMxMDgzMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/3108309?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonmit","html_url":"https://github.com/jasonmit","followers_url":"https://api.github.com/users/jasonmit/followers","following_url":"https://api.github.com/users/jasonmit/following{/other_user}","gists_url":"https://api.github.com/users/jasonmit/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmit/subscriptions","organizations_url":"https://api.github.com/users/jasonmit/orgs","repos_url":"https://api.github.com/users/jasonmit/repos","events_url":"https://api.github.com/users/jasonmit/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmit/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1049405688,"node_id":"MDU6TGFiZWwxMDQ5NDA1Njg4","url":"https://api.github.com/repos/Netflix/pollyjs/labels/:package:%20core","name":":package: core","color":"b7091d","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/pollyjs/pulls/295/commits","review_comments_url":"https://api.github.com/repos/Netflix/pollyjs/pulls/295/comments","review_comment_url":"https://api.github.com/repos/Netflix/pollyjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/pollyjs/issues/295/comments","statuses_url":"https://api.github.com/repos/Netflix/pollyjs/statuses/dbb2d078bb6bb67bfc560500fd587bf370110f43","head":{"label":"Netflix:remove-recordIfExpired","ref":"remove-recordIfExpired","sha":"dbb2d078bb6bb67bfc560500fd587bf370110f43","user":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":135633158,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MzMxNTg=","name":"pollyjs","full_name":"Netflix/pollyjs","private":false,"owner":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Netflix/pollyjs","description":"Record, Replay, and Stub HTTP Interactions.","fork":false,"url":"https://api.github.com/repos/Netflix/pollyjs","forks_url":"https://api.github.com/repos/Netflix/pollyjs/forks","keys_url":"https://api.github.com/repos/Netflix/pollyjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/pollyjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/pollyjs/teams","hooks_url":"https://api.github.com/repos/Netflix/pollyjs/hooks","issue_events_url":"https://api.github.com/repos/Netflix/pollyjs/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/pollyjs/events","assignees_url":"https://api.github.com/repos/Netflix/pollyjs/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/pollyjs/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/pollyjs/tags","blobs_url":"https://api.github.com/repos/Netflix/pollyjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/pollyjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/pollyjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/pollyjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/pollyjs/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/pollyjs/languages","stargazers_url":"https://api.github.com/repos/Netflix/pollyjs/stargazers","contributors_url":"https://api.github.com/repos/Netflix/pollyjs/contributors","subscribers_url":"https://api.github.com/repos/Netflix/pollyjs/subscribers","subscription_url":"https://api.github.com/repos/Netflix/pollyjs/subscription","commits_url":"https://api.github.com/repos/Netflix/pollyjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/pollyjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/pollyjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/pollyjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/pollyjs/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/pollyjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/pollyjs/merges","archive_url":"https://api.github.com/repos/Netflix/pollyjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/pollyjs/downloads","issues_url":"https://api.github.com/repos/Netflix/pollyjs/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/pollyjs/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/pollyjs/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/pollyjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/pollyjs/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/pollyjs/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/pollyjs/deployments","created_at":"2018-05-31T20:39:44Z","updated_at":"2020-01-13T04:07:57Z","pushed_at":"2020-01-13T05:25:27Z","git_url":"git://github.com/Netflix/pollyjs.git","ssh_url":"git@github.com:Netflix/pollyjs.git","clone_url":"https://github.com/Netflix/pollyjs.git","svn_url":"https://github.com/Netflix/pollyjs","homepage":"https://netflix.github.io/pollyjs","size":2225,"stargazers_count":8251,"watchers_count":8251,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":276,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":276,"open_issues":19,"watchers":8251,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"4e3163fe51558a382b37f3d868a7390f5173cf8c","user":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":135633158,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MzMxNTg=","name":"pollyjs","full_name":"Netflix/pollyjs","private":false,"owner":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Netflix/pollyjs","description":"Record, Replay, and Stub HTTP Interactions.","fork":false,"url":"https://api.github.com/repos/Netflix/pollyjs","forks_url":"https://api.github.com/repos/Netflix/pollyjs/forks","keys_url":"https://api.github.com/repos/Netflix/pollyjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/pollyjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/pollyjs/teams","hooks_url":"https://api.github.com/repos/Netflix/pollyjs/hooks","issue_events_url":"https://api.github.com/repos/Netflix/pollyjs/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/pollyjs/events","assignees_url":"https://api.github.com/repos/Netflix/pollyjs/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/pollyjs/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/pollyjs/tags","blobs_url":"https://api.github.com/repos/Netflix/pollyjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/pollyjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/pollyjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/pollyjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/pollyjs/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/pollyjs/languages","stargazers_url":"https://api.github.com/repos/Netflix/pollyjs/stargazers","contributors_url":"https://api.github.com/repos/Netflix/pollyjs/contributors","subscribers_url":"https://api.github.com/repos/Netflix/pollyjs/subscribers","subscription_url":"https://api.github.com/repos/Netflix/pollyjs/subscription","commits_url":"https://api.github.com/repos/Netflix/pollyjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/pollyjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/pollyjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/pollyjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/pollyjs/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/pollyjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/pollyjs/merges","archive_url":"https://api.github.com/repos/Netflix/pollyjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/pollyjs/downloads","issues_url":"https://api.github.com/repos/Netflix/pollyjs/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/pollyjs/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/pollyjs/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/pollyjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/pollyjs/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/pollyjs/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/pollyjs/deployments","created_at":"2018-05-31T20:39:44Z","updated_at":"2020-01-13T04:07:57Z","pushed_at":"2020-01-13T05:25:27Z","git_url":"git://github.com/Netflix/pollyjs.git","ssh_url":"git@github.com:Netflix/pollyjs.git","clone_url":"https://github.com/Netflix/pollyjs.git","svn_url":"https://github.com/Netflix/pollyjs","homepage":"https://netflix.github.io/pollyjs","size":2225,"stargazers_count":8251,"watchers_count":8251,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":276,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":276,"open_issues":19,"watchers":8251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/pollyjs/pulls/295"},"html":{"href":"https://github.com/Netflix/pollyjs/pull/295"},"issue":{"href":"https://api.github.com/repos/Netflix/pollyjs/issues/295"},"comments":{"href":"https://api.github.com/repos/Netflix/pollyjs/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/pollyjs/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/pollyjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/pollyjs/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/pollyjs/statuses/dbb2d078bb6bb67bfc560500fd587bf370110f43"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":51,"changed_files":3}}
{"actor":{"display_login":"offirgolan"}}