{"action":"created","issue":{"url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/794","repository_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search","labels_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/794/labels{/name}","comments_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/794/comments","events_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/794/events","html_url":"https://github.com/NYCPlanning/labs-zap-search/pull/794","id":507421169,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4NDE0NjUy","number":794,"title":"770: combine active bp & bb review on reviewed tab","user":{"login":"hannahkates","id":13967925,"node_id":"MDQ6VXNlcjEzOTY3OTI1","avatar_url":"https://avatars3.githubusercontent.com/u/13967925?v=4","gravatar_id":"","url":"https://api.github.com/users/hannahkates","html_url":"https://github.com/hannahkates","followers_url":"https://api.github.com/users/hannahkates/followers","following_url":"https://api.github.com/users/hannahkates/following{/other_user}","gists_url":"https://api.github.com/users/hannahkates/gists{/gist_id}","starred_url":"https://api.github.com/users/hannahkates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannahkates/subscriptions","organizations_url":"https://api.github.com/users/hannahkates/orgs","repos_url":"https://api.github.com/users/hannahkates/repos","events_url":"https://api.github.com/users/hannahkates/events{/privacy}","received_events_url":"https://api.github.com/users/hannahkates/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-10-15T18:52:23Z","updated_at":"2019-10-15T19:08:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/pulls/794","html_url":"https://github.com/NYCPlanning/labs-zap-search/pull/794","diff_url":"https://github.com/NYCPlanning/labs-zap-search/pull/794.diff","patch_url":"https://github.com/NYCPlanning/labs-zap-search/pull/794.patch"},"body":"Addresses #770 \r\n\r\nThis PR adds a check on the `reviewed-project-card` component. It checks if the project has multiple in-progress milestones and if those are BP and BB review. If so, it combines the countdown displays to show both reviews together instead of duplicating the same date info for each.\r\n\r\n![image](https://user-images.githubusercontent.com/13967925/66860498-4dedc000-ef5b-11e9-9875-c14d371afe99.png)\r\n"},"comment":{"url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/comments/542360479","html_url":"https://github.com/NYCPlanning/labs-zap-search/pull/794#issuecomment-542360479","issue_url":"https://api.github.com/repos/NYCPlanning/labs-zap-search/issues/794","id":542360479,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MjM2MDQ3OQ==","user":{"login":"godfreyyeung","id":3311663,"node_id":"MDQ6VXNlcjMzMTE2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3311663?v=4","gravatar_id":"","url":"https://api.github.com/users/godfreyyeung","html_url":"https://github.com/godfreyyeung","followers_url":"https://api.github.com/users/godfreyyeung/followers","following_url":"https://api.github.com/users/godfreyyeung/following{/other_user}","gists_url":"https://api.github.com/users/godfreyyeung/gists{/gist_id}","starred_url":"https://api.github.com/users/godfreyyeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godfreyyeung/subscriptions","organizations_url":"https://api.github.com/users/godfreyyeung/orgs","repos_url":"https://api.github.com/users/godfreyyeung/repos","events_url":"https://api.github.com/users/godfreyyeung/events{/privacy}","received_events_url":"https://api.github.com/users/godfreyyeung/received_events","type":"User","site_admin":false},"created_at":"2019-10-15T19:08:00Z","updated_at":"2019-10-15T19:08:00Z","author_association":"CONTRIBUTOR","body":"This works, but I would suggest the alternative of doing this through the template. It'll make it cleaner and more explicit. The proposed code hides a lot of the logic within the computed, and makes its purpose less clear. For example, in the template we can write something like: \r\n\r\n```\r\n  <div class=\"lup-countdown medium-margin-right medium-margin-left\">\r\n        {{#each this.timeDisplays as |timeDisplay|}}\r\n            <p class=\"cert-date\">{{timeDisplay.displayName}}</p>\r\n        {{/each}}\r\n            <p class=\"days\">{{this.timeDisplays.firstObject.timeRemaining}}</p>\r\n            <p class=\"total\">of {{this.timeDisplays.firstObject.timeDuration}} days remain</p>\r\n            <p class=\"end-date\">Ends {{moment-format this.timeDisplays.firstObject.dcpActualenddate \"M/D/YYYY\"}}</p>\r\n  </div>\r\n```\r\n\r\nIf we stick with the computed, the computed actually no longer needs to return an array because it (theoretically) will always just return one timeDisplay object.\r\n"}}
{"actor":{"display_login":"godfreyyeung"}}