{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/caliper/pulls/comments/260244846","pull_request_review_id":207904569,"id":260244846,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDI0NDg0Ng==","diff_hunk":"@@ -39,16 +46,38 @@ module.exports.run = function() {\n         'info' : '',\n         'item' : buf\n     };\n-    return bc.invokeSmartContract(contx, 'drm', 'v0', {verb : 'publish', item: JSON.stringify(item)}, 120)\n-        .then((results)=>{\n-            for (let i in results){\n-                let stat = results[i];\n-                if(stat.IsCommitted()) {\n-                    ids.push(stat.GetResult().toString());\n+\n+    if (bc.bcType === 'fabric-ccp') {","path":"benchmark/drm/publish.js","position":32,"original_position":32,"commit_id":"fe74b979d1217aae4d783034a7e582dd828ccb3c","original_commit_id":"fe74b979d1217aae4d783034a7e582dd828ccb3c","user":{"login":"aklenik","id":10832624,"node_id":"MDQ6VXNlcjEwODMyNjI0","avatar_url":"https://avatars2.githubusercontent.com/u/10832624?v=4","gravatar_id":"","url":"https://api.github.com/users/aklenik","html_url":"https://github.com/aklenik","followers_url":"https://api.github.com/users/aklenik/followers","following_url":"https://api.github.com/users/aklenik/following{/other_user}","gists_url":"https://api.github.com/users/aklenik/gists{/gist_id}","starred_url":"https://api.github.com/users/aklenik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aklenik/subscriptions","organizations_url":"https://api.github.com/users/aklenik/orgs","repos_url":"https://api.github.com/users/aklenik/repos","events_url":"https://api.github.com/users/aklenik/events{/privacy}","received_events_url":"https://api.github.com/users/aklenik/received_events","type":"User","site_admin":false},"body":"@feihujiang Then I'll add these features to this adapter, as a best-practice to follow for other adapters. So, for now, this adapter will follow the current API, but yeah, we'll need to consolidate it later 👍 \r\nI'll ping you when it's ready.","created_at":"2019-02-26T11:34:26Z","updated_at":"2019-02-26T11:34:26Z","html_url":"https://github.com/hyperledger/caliper/pull/296#discussion_r260244846","pull_request_url":"https://api.github.com/repos/hyperledger/caliper/pulls/296","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/caliper/pulls/comments/260244846"},"html":{"href":"https://github.com/hyperledger/caliper/pull/296#discussion_r260244846"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/caliper/pulls/296"}},"in_reply_to_id":259750615},"pull_request":{"url":"https://api.github.com/repos/hyperledger/caliper/pulls/296","id":250195233,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwMTk1MjMz","html_url":"https://github.com/hyperledger/caliper/pull/296","diff_url":"https://github.com/hyperledger/caliper/pull/296.diff","patch_url":"https://github.com/hyperledger/caliper/pull/296.patch","issue_url":"https://api.github.com/repos/hyperledger/caliper/issues/296","number":296,"state":"open","locked":false,"title":"Add connection profile-based Fabric adapter","user":{"login":"aklenik","id":10832624,"node_id":"MDQ6VXNlcjEwODMyNjI0","avatar_url":"https://avatars2.githubusercontent.com/u/10832624?v=4","gravatar_id":"","url":"https://api.github.com/users/aklenik","html_url":"https://github.com/aklenik","followers_url":"https://api.github.com/users/aklenik/followers","following_url":"https://api.github.com/users/aklenik/following{/other_user}","gists_url":"https://api.github.com/users/aklenik/gists{/gist_id}","starred_url":"https://api.github.com/users/aklenik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aklenik/subscriptions","organizations_url":"https://api.github.com/users/aklenik/orgs","repos_url":"https://api.github.com/users/aklenik/repos","events_url":"https://api.github.com/users/aklenik/events{/privacy}","received_events_url":"https://api.github.com/users/aklenik/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Attila Klenik <a.klenik@gmail.com>\r\n\r\n## Issue/User story\r\nChanges related to the adapter:\r\n* Updated the sample benchmarks to also support the new adapter API\r\n* Added settings for the new adapter in the default Caliper configuration file\r\n* Added sample network configurations for the new adapter (from v1.0 to v1.2, including mutual TLS networks from v1.1). Most of the additions originate from these example configurations, which are easy to check/test\r\n* Added lightweight Caliper-level dependecies (for general use, not Fabric-specific packages), like `tmp` and `version-compare`\r\n* Changed some `require` calls to YAML parsing for reading network configuration files in `bench-flow.js`\r\n* Integrated the new adapter into `blockchain.js`\r\n* Added general utility functions for checking/asserting property and version-related information\r\n\r\n## Directly related issues (and many more regarding the other adapter)\r\n#37 #115 #139 #185 #227 #292\r\n## Validation of the fix\r\nFor each sample benchmark, pick a configuration file (like the linear rate config), and run it with every network version/topology/`fabric-ccp*` configuration combination.\r\n\r\n## What documentation has been provided for this pull request\r\n#297 \r\n\r\n@hyperledger/caliper-committers @nklincoln Any help with the review if appreciated!","created_at":"2019-02-04T20:55:41Z","updated_at":"2019-02-26T11:34:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29ac9edaa23e38b1714cb2e8a98ec2beaa8ec57b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/caliper/pulls/296/commits","review_comments_url":"https://api.github.com/repos/hyperledger/caliper/pulls/296/comments","review_comment_url":"https://api.github.com/repos/hyperledger/caliper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/caliper/issues/296/comments","statuses_url":"https://api.github.com/repos/hyperledger/caliper/statuses/fe74b979d1217aae4d783034a7e582dd828ccb3c","head":{"label":"aklenik:fabric-ccp","ref":"fabric-ccp","sha":"fe74b979d1217aae4d783034a7e582dd828ccb3c","user":{"login":"aklenik","id":10832624,"node_id":"MDQ6VXNlcjEwODMyNjI0","avatar_url":"https://avatars2.githubusercontent.com/u/10832624?v=4","gravatar_id":"","url":"https://api.github.com/users/aklenik","html_url":"https://github.com/aklenik","followers_url":"https://api.github.com/users/aklenik/followers","following_url":"https://api.github.com/users/aklenik/following{/other_user}","gists_url":"https://api.github.com/users/aklenik/gists{/gist_id}","starred_url":"https://api.github.com/users/aklenik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aklenik/subscriptions","organizations_url":"https://api.github.com/users/aklenik/orgs","repos_url":"https://api.github.com/users/aklenik/repos","events_url":"https://api.github.com/users/aklenik/events{/privacy}","received_events_url":"https://api.github.com/users/aklenik/received_events","type":"User","site_admin":false},"repo":{"id":132733005,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3MzMwMDU=","name":"caliper","full_name":"aklenik/caliper","private":false,"owner":{"login":"aklenik","id":10832624,"node_id":"MDQ6VXNlcjEwODMyNjI0","avatar_url":"https://avatars2.githubusercontent.com/u/10832624?v=4","gravatar_id":"","url":"https://api.github.com/users/aklenik","html_url":"https://github.com/aklenik","followers_url":"https://api.github.com/users/aklenik/followers","following_url":"https://api.github.com/users/aklenik/following{/other_user}","gists_url":"https://api.github.com/users/aklenik/gists{/gist_id}","starred_url":"https://api.github.com/users/aklenik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aklenik/subscriptions","organizations_url":"https://api.github.com/users/aklenik/orgs","repos_url":"https://api.github.com/users/aklenik/repos","events_url":"https://api.github.com/users/aklenik/events{/privacy}","received_events_url":"https://api.github.com/users/aklenik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aklenik/caliper","description":" A blockchain benchmark framework to measure performance of multiple blockchain solutions","fork":true,"url":"https://api.github.com/repos/aklenik/caliper","forks_url":"https://api.github.com/repos/aklenik/caliper/forks","keys_url":"https://api.github.com/repos/aklenik/caliper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aklenik/caliper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aklenik/caliper/teams","hooks_url":"https://api.github.com/repos/aklenik/caliper/hooks","issue_events_url":"https://api.github.com/repos/aklenik/caliper/issues/events{/number}","events_url":"https://api.github.com/repos/aklenik/caliper/events","assignees_url":"https://api.github.com/repos/aklenik/caliper/assignees{/user}","branches_url":"https://api.github.com/repos/aklenik/caliper/branches{/branch}","tags_url":"https://api.github.com/repos/aklenik/caliper/tags","blobs_url":"https://api.github.com/repos/aklenik/caliper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aklenik/caliper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aklenik/caliper/git/refs{/sha}","trees_url":"https://api.github.com/repos/aklenik/caliper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aklenik/caliper/statuses/{sha}","languages_url":"https://api.github.com/repos/aklenik/caliper/languages","stargazers_url":"https://api.github.com/repos/aklenik/caliper/stargazers","contributors_url":"https://api.github.com/repos/aklenik/caliper/contributors","subscribers_url":"https://api.github.com/repos/aklenik/caliper/subscribers","subscription_url":"https://api.github.com/repos/aklenik/caliper/subscription","commits_url":"https://api.github.com/repos/aklenik/caliper/commits{/sha}","git_commits_url":"https://api.github.com/repos/aklenik/caliper/git/commits{/sha}","comments_url":"https://api.github.com/repos/aklenik/caliper/comments{/number}","issue_comment_url":"https://api.github.com/repos/aklenik/caliper/issues/comments{/number}","contents_url":"https://api.github.com/repos/aklenik/caliper/contents/{+path}","compare_url":"https://api.github.com/repos/aklenik/caliper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aklenik/caliper/merges","archive_url":"https://api.github.com/repos/aklenik/caliper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aklenik/caliper/downloads","issues_url":"https://api.github.com/repos/aklenik/caliper/issues{/number}","pulls_url":"https://api.github.com/repos/aklenik/caliper/pulls{/number}","milestones_url":"https://api.github.com/repos/aklenik/caliper/milestones{/number}","notifications_url":"https://api.github.com/repos/aklenik/caliper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aklenik/caliper/labels{/name}","releases_url":"https://api.github.com/repos/aklenik/caliper/releases{/id}","deployments_url":"https://api.github.com/repos/aklenik/caliper/deployments","created_at":"2018-05-09T09:22:35Z","updated_at":"2018-12-17T07:52:06Z","pushed_at":"2019-02-20T11:54:15Z","git_url":"git://github.com/aklenik/caliper.git","ssh_url":"git@github.com:aklenik/caliper.git","clone_url":"https://github.com/aklenik/caliper.git","svn_url":"https://github.com/aklenik/caliper","homepage":"","size":10345,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"812385cc0da728e722fda2458ff1dddf18a795e4","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":125944747,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU5NDQ3NDc=","name":"caliper","full_name":"hyperledger/caliper","private":false,"owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyperledger/caliper","description":" A blockchain benchmark framework to measure performance of multiple blockchain solutions","fork":false,"url":"https://api.github.com/repos/hyperledger/caliper","forks_url":"https://api.github.com/repos/hyperledger/caliper/forks","keys_url":"https://api.github.com/repos/hyperledger/caliper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/caliper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/caliper/teams","hooks_url":"https://api.github.com/repos/hyperledger/caliper/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/caliper/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/caliper/events","assignees_url":"https://api.github.com/repos/hyperledger/caliper/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/caliper/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/caliper/tags","blobs_url":"https://api.github.com/repos/hyperledger/caliper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/caliper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/caliper/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/caliper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/caliper/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/caliper/languages","stargazers_url":"https://api.github.com/repos/hyperledger/caliper/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/caliper/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/caliper/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/caliper/subscription","commits_url":"https://api.github.com/repos/hyperledger/caliper/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/caliper/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/caliper/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/caliper/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/caliper/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/caliper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/caliper/merges","archive_url":"https://api.github.com/repos/hyperledger/caliper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/caliper/downloads","issues_url":"https://api.github.com/repos/hyperledger/caliper/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/caliper/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/caliper/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/caliper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/caliper/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/caliper/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/caliper/deployments","created_at":"2018-03-20T01:46:34Z","updated_at":"2019-02-26T02:20:39Z","pushed_at":"2019-02-26T10:41:38Z","git_url":"git://github.com/hyperledger/caliper.git","ssh_url":"git@github.com:hyperledger/caliper.git","clone_url":"https://github.com/hyperledger/caliper.git","svn_url":"https://github.com/hyperledger/caliper","homepage":"https://hyperledger.github.io/caliper/","size":11217,"stargazers_count":255,"watchers_count":255,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":153,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":153,"open_issues":56,"watchers":255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/caliper/pulls/296"},"html":{"href":"https://github.com/hyperledger/caliper/pull/296"},"issue":{"href":"https://api.github.com/repos/hyperledger/caliper/issues/296"},"comments":{"href":"https://api.github.com/repos/hyperledger/caliper/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/caliper/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/caliper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/caliper/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/caliper/statuses/fe74b979d1217aae4d783034a7e582dd828ccb3c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aklenik"}}