{"action":"created","comment":{"url":"https://api.github.com/repos/omni-viral/rendy/pulls/comments/257836446","pull_request_review_id":204964357,"id":257836446,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzgzNjQ0Ng==","diff_hunk":"@@ -363,7 +369,7 @@ where\n                 .filter_map(|x| x)\n                 .map(|(image, _)| image)\n                 .collect(),\n-            inflight: 3,\n+            inflight: self.frames_in_flight as _,","path":"graph/src/graph/mod.rs","position":36,"original_position":36,"commit_id":"c2a9ba16590fef45680b3f1a6950ced3c016de1f","original_commit_id":"c2a9ba16590fef45680b3f1a6950ced3c016de1f","user":{"login":"termhn","id":887711,"node_id":"MDQ6VXNlcjg4NzcxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/887711?v=4","gravatar_id":"","url":"https://api.github.com/users/termhn","html_url":"https://github.com/termhn","followers_url":"https://api.github.com/users/termhn/followers","following_url":"https://api.github.com/users/termhn/following{/other_user}","gists_url":"https://api.github.com/users/termhn/gists{/gist_id}","starred_url":"https://api.github.com/users/termhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/termhn/subscriptions","organizations_url":"https://api.github.com/users/termhn/orgs","repos_url":"https://api.github.com/users/termhn/repos","events_url":"https://api.github.com/users/termhn/events{/privacy}","received_events_url":"https://api.github.com/users/termhn/received_events","type":"User","site_admin":false},"body":"I mean there's no way you're gonna want more than a u32's worth of frames_in_flight, so... x)","created_at":"2019-02-18T21:58:00Z","updated_at":"2019-02-18T21:58:00Z","html_url":"https://github.com/omni-viral/rendy/pull/52#discussion_r257836446","pull_request_url":"https://api.github.com/repos/omni-viral/rendy/pulls/52","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/omni-viral/rendy/pulls/comments/257836446"},"html":{"href":"https://github.com/omni-viral/rendy/pull/52#discussion_r257836446"},"pull_request":{"href":"https://api.github.com/repos/omni-viral/rendy/pulls/52"}},"in_reply_to_id":257620466},"pull_request":{"url":"https://api.github.com/repos/omni-viral/rendy/pulls/52","id":253679141,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzNjc5MTQx","html_url":"https://github.com/omni-viral/rendy/pull/52","diff_url":"https://github.com/omni-viral/rendy/pull/52.diff","patch_url":"https://github.com/omni-viral/rendy/pull/52.patch","issue_url":"https://api.github.com/repos/omni-viral/rendy/issues/52","number":52,"state":"open","locked":false,"title":"Add Swapchain image count and present mode configuration to PresentBuilder","user":{"login":"termhn","id":887711,"node_id":"MDQ6VXNlcjg4NzcxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/887711?v=4","gravatar_id":"","url":"https://api.github.com/users/termhn","html_url":"https://github.com/termhn","followers_url":"https://api.github.com/users/termhn/followers","following_url":"https://api.github.com/users/termhn/following{/other_user}","gists_url":"https://api.github.com/users/termhn/gists{/gist_id}","starred_url":"https://api.github.com/users/termhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/termhn/subscriptions","organizations_url":"https://api.github.com/users/termhn/orgs","repos_url":"https://api.github.com/users/termhn/repos","events_url":"https://api.github.com/users/termhn/events{/privacy}","received_events_url":"https://api.github.com/users/termhn/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-17T00:55:25Z","updated_at":"2019-02-18T21:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff0eabebfcbfb51303f2cb2e7e6facb9f52892b2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/omni-viral/rendy/pulls/52/commits","review_comments_url":"https://api.github.com/repos/omni-viral/rendy/pulls/52/comments","review_comment_url":"https://api.github.com/repos/omni-viral/rendy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omni-viral/rendy/issues/52/comments","statuses_url":"https://api.github.com/repos/omni-viral/rendy/statuses/c2a9ba16590fef45680b3f1a6950ced3c016de1f","head":{"label":"termhn:swapchain_config","ref":"swapchain_config","sha":"c2a9ba16590fef45680b3f1a6950ced3c016de1f","user":{"login":"termhn","id":887711,"node_id":"MDQ6VXNlcjg4NzcxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/887711?v=4","gravatar_id":"","url":"https://api.github.com/users/termhn","html_url":"https://github.com/termhn","followers_url":"https://api.github.com/users/termhn/followers","following_url":"https://api.github.com/users/termhn/following{/other_user}","gists_url":"https://api.github.com/users/termhn/gists{/gist_id}","starred_url":"https://api.github.com/users/termhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/termhn/subscriptions","organizations_url":"https://api.github.com/users/termhn/orgs","repos_url":"https://api.github.com/users/termhn/repos","events_url":"https://api.github.com/users/termhn/events{/privacy}","received_events_url":"https://api.github.com/users/termhn/received_events","type":"User","site_admin":false},"repo":{"id":160404705,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MDQ3MDU=","name":"rendy","full_name":"termhn/rendy","private":false,"owner":{"login":"termhn","id":887711,"node_id":"MDQ6VXNlcjg4NzcxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/887711?v=4","gravatar_id":"","url":"https://api.github.com/users/termhn","html_url":"https://github.com/termhn","followers_url":"https://api.github.com/users/termhn/followers","following_url":"https://api.github.com/users/termhn/following{/other_user}","gists_url":"https://api.github.com/users/termhn/gists{/gist_id}","starred_url":"https://api.github.com/users/termhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/termhn/subscriptions","organizations_url":"https://api.github.com/users/termhn/orgs","repos_url":"https://api.github.com/users/termhn/repos","events_url":"https://api.github.com/users/termhn/events{/privacy}","received_events_url":"https://api.github.com/users/termhn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/termhn/rendy","description":"Yet another Vulkan based rendering engine.","fork":true,"url":"https://api.github.com/repos/termhn/rendy","forks_url":"https://api.github.com/repos/termhn/rendy/forks","keys_url":"https://api.github.com/repos/termhn/rendy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/termhn/rendy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/termhn/rendy/teams","hooks_url":"https://api.github.com/repos/termhn/rendy/hooks","issue_events_url":"https://api.github.com/repos/termhn/rendy/issues/events{/number}","events_url":"https://api.github.com/repos/termhn/rendy/events","assignees_url":"https://api.github.com/repos/termhn/rendy/assignees{/user}","branches_url":"https://api.github.com/repos/termhn/rendy/branches{/branch}","tags_url":"https://api.github.com/repos/termhn/rendy/tags","blobs_url":"https://api.github.com/repos/termhn/rendy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/termhn/rendy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/termhn/rendy/git/refs{/sha}","trees_url":"https://api.github.com/repos/termhn/rendy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/termhn/rendy/statuses/{sha}","languages_url":"https://api.github.com/repos/termhn/rendy/languages","stargazers_url":"https://api.github.com/repos/termhn/rendy/stargazers","contributors_url":"https://api.github.com/repos/termhn/rendy/contributors","subscribers_url":"https://api.github.com/repos/termhn/rendy/subscribers","subscription_url":"https://api.github.com/repos/termhn/rendy/subscription","commits_url":"https://api.github.com/repos/termhn/rendy/commits{/sha}","git_commits_url":"https://api.github.com/repos/termhn/rendy/git/commits{/sha}","comments_url":"https://api.github.com/repos/termhn/rendy/comments{/number}","issue_comment_url":"https://api.github.com/repos/termhn/rendy/issues/comments{/number}","contents_url":"https://api.github.com/repos/termhn/rendy/contents/{+path}","compare_url":"https://api.github.com/repos/termhn/rendy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/termhn/rendy/merges","archive_url":"https://api.github.com/repos/termhn/rendy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/termhn/rendy/downloads","issues_url":"https://api.github.com/repos/termhn/rendy/issues{/number}","pulls_url":"https://api.github.com/repos/termhn/rendy/pulls{/number}","milestones_url":"https://api.github.com/repos/termhn/rendy/milestones{/number}","notifications_url":"https://api.github.com/repos/termhn/rendy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/termhn/rendy/labels{/name}","releases_url":"https://api.github.com/repos/termhn/rendy/releases{/id}","deployments_url":"https://api.github.com/repos/termhn/rendy/deployments","created_at":"2018-12-04T18:56:49Z","updated_at":"2018-12-24T18:10:03Z","pushed_at":"2019-02-18T03:12:34Z","git_url":"git://github.com/termhn/rendy.git","ssh_url":"git@github.com:termhn/rendy.git","clone_url":"https://github.com/termhn/rendy.git","svn_url":"https://github.com/termhn/rendy","homepage":null,"size":847,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"omni-viral:master","ref":"master","sha":"337213d4b92a2a2f125141310866a3034ff875fa","user":{"login":"omni-viral","id":4456841,"node_id":"MDQ6VXNlcjQ0NTY4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4456841?v=4","gravatar_id":"","url":"https://api.github.com/users/omni-viral","html_url":"https://github.com/omni-viral","followers_url":"https://api.github.com/users/omni-viral/followers","following_url":"https://api.github.com/users/omni-viral/following{/other_user}","gists_url":"https://api.github.com/users/omni-viral/gists{/gist_id}","starred_url":"https://api.github.com/users/omni-viral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omni-viral/subscriptions","organizations_url":"https://api.github.com/users/omni-viral/orgs","repos_url":"https://api.github.com/users/omni-viral/repos","events_url":"https://api.github.com/users/omni-viral/events{/privacy}","received_events_url":"https://api.github.com/users/omni-viral/received_events","type":"User","site_admin":false},"repo":{"id":140871078,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4NzEwNzg=","name":"rendy","full_name":"omni-viral/rendy","private":false,"owner":{"login":"omni-viral","id":4456841,"node_id":"MDQ6VXNlcjQ0NTY4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4456841?v=4","gravatar_id":"","url":"https://api.github.com/users/omni-viral","html_url":"https://github.com/omni-viral","followers_url":"https://api.github.com/users/omni-viral/followers","following_url":"https://api.github.com/users/omni-viral/following{/other_user}","gists_url":"https://api.github.com/users/omni-viral/gists{/gist_id}","starred_url":"https://api.github.com/users/omni-viral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omni-viral/subscriptions","organizations_url":"https://api.github.com/users/omni-viral/orgs","repos_url":"https://api.github.com/users/omni-viral/repos","events_url":"https://api.github.com/users/omni-viral/events{/privacy}","received_events_url":"https://api.github.com/users/omni-viral/received_events","type":"User","site_admin":false},"html_url":"https://github.com/omni-viral/rendy","description":"Yet another Vulkan based rendering engine.","fork":false,"url":"https://api.github.com/repos/omni-viral/rendy","forks_url":"https://api.github.com/repos/omni-viral/rendy/forks","keys_url":"https://api.github.com/repos/omni-viral/rendy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omni-viral/rendy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omni-viral/rendy/teams","hooks_url":"https://api.github.com/repos/omni-viral/rendy/hooks","issue_events_url":"https://api.github.com/repos/omni-viral/rendy/issues/events{/number}","events_url":"https://api.github.com/repos/omni-viral/rendy/events","assignees_url":"https://api.github.com/repos/omni-viral/rendy/assignees{/user}","branches_url":"https://api.github.com/repos/omni-viral/rendy/branches{/branch}","tags_url":"https://api.github.com/repos/omni-viral/rendy/tags","blobs_url":"https://api.github.com/repos/omni-viral/rendy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omni-viral/rendy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omni-viral/rendy/git/refs{/sha}","trees_url":"https://api.github.com/repos/omni-viral/rendy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omni-viral/rendy/statuses/{sha}","languages_url":"https://api.github.com/repos/omni-viral/rendy/languages","stargazers_url":"https://api.github.com/repos/omni-viral/rendy/stargazers","contributors_url":"https://api.github.com/repos/omni-viral/rendy/contributors","subscribers_url":"https://api.github.com/repos/omni-viral/rendy/subscribers","subscription_url":"https://api.github.com/repos/omni-viral/rendy/subscription","commits_url":"https://api.github.com/repos/omni-viral/rendy/commits{/sha}","git_commits_url":"https://api.github.com/repos/omni-viral/rendy/git/commits{/sha}","comments_url":"https://api.github.com/repos/omni-viral/rendy/comments{/number}","issue_comment_url":"https://api.github.com/repos/omni-viral/rendy/issues/comments{/number}","contents_url":"https://api.github.com/repos/omni-viral/rendy/contents/{+path}","compare_url":"https://api.github.com/repos/omni-viral/rendy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omni-viral/rendy/merges","archive_url":"https://api.github.com/repos/omni-viral/rendy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omni-viral/rendy/downloads","issues_url":"https://api.github.com/repos/omni-viral/rendy/issues{/number}","pulls_url":"https://api.github.com/repos/omni-viral/rendy/pulls{/number}","milestones_url":"https://api.github.com/repos/omni-viral/rendy/milestones{/number}","notifications_url":"https://api.github.com/repos/omni-viral/rendy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omni-viral/rendy/labels{/name}","releases_url":"https://api.github.com/repos/omni-viral/rendy/releases{/id}","deployments_url":"https://api.github.com/repos/omni-viral/rendy/deployments","created_at":"2018-07-13T16:43:38Z","updated_at":"2019-02-18T21:24:25Z","pushed_at":"2019-02-18T20:43:22Z","git_url":"git://github.com/omni-viral/rendy.git","ssh_url":"git@github.com:omni-viral/rendy.git","clone_url":"https://github.com/omni-viral/rendy.git","svn_url":"https://github.com/omni-viral/rendy","homepage":null,"size":832,"stargazers_count":201,"watchers_count":201,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":8,"watchers":201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omni-viral/rendy/pulls/52"},"html":{"href":"https://github.com/omni-viral/rendy/pull/52"},"issue":{"href":"https://api.github.com/repos/omni-viral/rendy/issues/52"},"comments":{"href":"https://api.github.com/repos/omni-viral/rendy/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/omni-viral/rendy/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/omni-viral/rendy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omni-viral/rendy/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/omni-viral/rendy/statuses/c2a9ba16590fef45680b3f1a6950ced3c016de1f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"termhn"}}