{"action":"created","comment":{"url":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/comments/352897025","pull_request_review_id":325790972,"id":352897025,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Mjg5NzAyNQ==","diff_hunk":"@@ -7,7 +7,7 @@ part of firebase_auth;\n class GithubAuthProvider {\n   static const String providerId = 'github.com';\n \n-  static AuthCredential getCredential({@required String token}) {\n-    return AuthCredential._(providerId, <String, String>{'token': token});\n+  static GithubAuthCredential getCredential({@required String token}) {","path":"packages/firebase_auth/firebase_auth/lib/src/auth_provider/github_auth_provider.dart","position":6,"original_position":6,"commit_id":"8bbe3c3a79d067274dc6a97076a1ab049a15450e","original_commit_id":"8bbe3c3a79d067274dc6a97076a1ab049a15450e","user":{"login":"ditman","id":1255594,"node_id":"MDQ6VXNlcjEyNTU1OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1255594?v=4","gravatar_id":"","url":"https://api.github.com/users/ditman","html_url":"https://github.com/ditman","followers_url":"https://api.github.com/users/ditman/followers","following_url":"https://api.github.com/users/ditman/following{/other_user}","gists_url":"https://api.github.com/users/ditman/gists{/gist_id}","starred_url":"https://api.github.com/users/ditman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ditman/subscriptions","organizations_url":"https://api.github.com/users/ditman/orgs","repos_url":"https://api.github.com/users/ditman/repos","events_url":"https://api.github.com/users/ditman/events{/privacy}","received_events_url":"https://api.github.com/users/ditman/received_events","type":"User","site_admin":false},"body":"@collinjackson it's so weird that the PhoneAuthCredential has a \"special\" type, though :/ ","created_at":"2019-12-02T22:38:04Z","updated_at":"2019-12-02T22:38:04Z","html_url":"https://github.com/FirebaseExtended/flutterfire/pull/1523#discussion_r352897025","pull_request_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/1523","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/comments/352897025"},"html":{"href":"https://github.com/FirebaseExtended/flutterfire/pull/1523#discussion_r352897025"},"pull_request":{"href":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/1523"}},"in_reply_to_id":352798415},"pull_request":{"url":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/1523","id":347276075,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3Mjc2MDc1","html_url":"https://github.com/FirebaseExtended/flutterfire/pull/1523","diff_url":"https://github.com/FirebaseExtended/flutterfire/pull/1523.diff","patch_url":"https://github.com/FirebaseExtended/flutterfire/pull/1523.patch","issue_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/issues/1523","number":1523,"state":"open","locked":false,"title":"[firebase_auth_web] Add initial implementation","user":{"login":"hterkelsen","id":1961493,"node_id":"MDQ6VXNlcjE5NjE0OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1961493?v=4","gravatar_id":"","url":"https://api.github.com/users/hterkelsen","html_url":"https://github.com/hterkelsen","followers_url":"https://api.github.com/users/hterkelsen/followers","following_url":"https://api.github.com/users/hterkelsen/following{/other_user}","gists_url":"https://api.github.com/users/hterkelsen/gists{/gist_id}","starred_url":"https://api.github.com/users/hterkelsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hterkelsen/subscriptions","organizations_url":"https://api.github.com/users/hterkelsen/orgs","repos_url":"https://api.github.com/users/hterkelsen/repos","events_url":"https://api.github.com/users/hterkelsen/events{/privacy}","received_events_url":"https://api.github.com/users/hterkelsen/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nAdds `firebase_auth_web`, the web implementation of `package:firebase_auth`.\r\n\r\n## Related Issues\r\n\r\nFixes https://github.com/flutter/flutter/issues/45288\r\n\r\n## Checklist\r\n\r\nBefore you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.\r\n\r\n- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.\r\n- [x] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])\r\n- [x] My PR includes unit or integration tests for *all* changed/updated/fixed behaviors (See [Contributor Guide]).\r\n- [x] All existing and new tests are passing.\r\n- [x] I updated/added relevant documentation (doc comments with `///`).\r\n- [x] The analyzer (`flutter analyze`) does not report any problems on my PR.\r\n- [x] I read and followed the [Flutter Style Guide].\r\n- [x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].\r\n- [x] I updated CHANGELOG.md to add a description of the change.\r\n- [x] I signed the [CLA].\r\n- [x] I am willing to follow-up on review comments in a timely manner.\r\n\r\n## Breaking Change\r\n\r\nDoes your PR require plugin users to manually update their apps to accommodate your change?\r\n\r\n- [ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).\r\n- [x] No, this is *not* a breaking change.\r\n\r\n<!-- Links -->\r\n[issue database]: https://github.com/flutter/flutter/issues\r\n[Contributor Guide]: https://github.com/FirebaseExtended/flutterfire/blob/master/CONTRIBUTING.md\r\n[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo\r\n[pub versioning philosophy]: https://www.dartlang.org/tools/pub/versioning\r\n[CLA]: https://cla.developers.google.com/\r\n","created_at":"2019-12-01T01:18:16Z","updated_at":"2019-12-02T22:38:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85da5a57d92a5c99f6b5a9ccead822cfb86e0edd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"collinjackson","id":394889,"node_id":"MDQ6VXNlcjM5NDg4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/394889?v=4","gravatar_id":"","url":"https://api.github.com/users/collinjackson","html_url":"https://github.com/collinjackson","followers_url":"https://api.github.com/users/collinjackson/followers","following_url":"https://api.github.com/users/collinjackson/following{/other_user}","gists_url":"https://api.github.com/users/collinjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/collinjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collinjackson/subscriptions","organizations_url":"https://api.github.com/users/collinjackson/orgs","repos_url":"https://api.github.com/users/collinjackson/repos","events_url":"https://api.github.com/users/collinjackson/events{/privacy}","received_events_url":"https://api.github.com/users/collinjackson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1548790476,"node_id":"MDU6TGFiZWwxNTQ4NzkwNDc2","url":"https://api.github.com/repos/FirebaseExtended/flutterfire/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/1523/commits","review_comments_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/1523/comments","review_comment_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/issues/1523/comments","statuses_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/statuses/8bbe3c3a79d067274dc6a97076a1ab049a15450e","head":{"label":"hterkelsen:firebase-auth-web","ref":"firebase-auth-web","sha":"8bbe3c3a79d067274dc6a97076a1ab049a15450e","user":{"login":"hterkelsen","id":1961493,"node_id":"MDQ6VXNlcjE5NjE0OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1961493?v=4","gravatar_id":"","url":"https://api.github.com/users/hterkelsen","html_url":"https://github.com/hterkelsen","followers_url":"https://api.github.com/users/hterkelsen/followers","following_url":"https://api.github.com/users/hterkelsen/following{/other_user}","gists_url":"https://api.github.com/users/hterkelsen/gists{/gist_id}","starred_url":"https://api.github.com/users/hterkelsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hterkelsen/subscriptions","organizations_url":"https://api.github.com/users/hterkelsen/orgs","repos_url":"https://api.github.com/users/hterkelsen/repos","events_url":"https://api.github.com/users/hterkelsen/events{/privacy}","received_events_url":"https://api.github.com/users/hterkelsen/received_events","type":"User","site_admin":false},"repo":{"id":214300757,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQzMDA3NTc=","name":"flutterfire","full_name":"hterkelsen/flutterfire","private":false,"owner":{"login":"hterkelsen","id":1961493,"node_id":"MDQ6VXNlcjE5NjE0OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1961493?v=4","gravatar_id":"","url":"https://api.github.com/users/hterkelsen","html_url":"https://github.com/hterkelsen","followers_url":"https://api.github.com/users/hterkelsen/followers","following_url":"https://api.github.com/users/hterkelsen/following{/other_user}","gists_url":"https://api.github.com/users/hterkelsen/gists{/gist_id}","starred_url":"https://api.github.com/users/hterkelsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hterkelsen/subscriptions","organizations_url":"https://api.github.com/users/hterkelsen/orgs","repos_url":"https://api.github.com/users/hterkelsen/repos","events_url":"https://api.github.com/users/hterkelsen/events{/privacy}","received_events_url":"https://api.github.com/users/hterkelsen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hterkelsen/flutterfire","description":"🔥 Firebase plugins for Flutter iOS and Android apps","fork":true,"url":"https://api.github.com/repos/hterkelsen/flutterfire","forks_url":"https://api.github.com/repos/hterkelsen/flutterfire/forks","keys_url":"https://api.github.com/repos/hterkelsen/flutterfire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hterkelsen/flutterfire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hterkelsen/flutterfire/teams","hooks_url":"https://api.github.com/repos/hterkelsen/flutterfire/hooks","issue_events_url":"https://api.github.com/repos/hterkelsen/flutterfire/issues/events{/number}","events_url":"https://api.github.com/repos/hterkelsen/flutterfire/events","assignees_url":"https://api.github.com/repos/hterkelsen/flutterfire/assignees{/user}","branches_url":"https://api.github.com/repos/hterkelsen/flutterfire/branches{/branch}","tags_url":"https://api.github.com/repos/hterkelsen/flutterfire/tags","blobs_url":"https://api.github.com/repos/hterkelsen/flutterfire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hterkelsen/flutterfire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hterkelsen/flutterfire/git/refs{/sha}","trees_url":"https://api.github.com/repos/hterkelsen/flutterfire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hterkelsen/flutterfire/statuses/{sha}","languages_url":"https://api.github.com/repos/hterkelsen/flutterfire/languages","stargazers_url":"https://api.github.com/repos/hterkelsen/flutterfire/stargazers","contributors_url":"https://api.github.com/repos/hterkelsen/flutterfire/contributors","subscribers_url":"https://api.github.com/repos/hterkelsen/flutterfire/subscribers","subscription_url":"https://api.github.com/repos/hterkelsen/flutterfire/subscription","commits_url":"https://api.github.com/repos/hterkelsen/flutterfire/commits{/sha}","git_commits_url":"https://api.github.com/repos/hterkelsen/flutterfire/git/commits{/sha}","comments_url":"https://api.github.com/repos/hterkelsen/flutterfire/comments{/number}","issue_comment_url":"https://api.github.com/repos/hterkelsen/flutterfire/issues/comments{/number}","contents_url":"https://api.github.com/repos/hterkelsen/flutterfire/contents/{+path}","compare_url":"https://api.github.com/repos/hterkelsen/flutterfire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hterkelsen/flutterfire/merges","archive_url":"https://api.github.com/repos/hterkelsen/flutterfire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hterkelsen/flutterfire/downloads","issues_url":"https://api.github.com/repos/hterkelsen/flutterfire/issues{/number}","pulls_url":"https://api.github.com/repos/hterkelsen/flutterfire/pulls{/number}","milestones_url":"https://api.github.com/repos/hterkelsen/flutterfire/milestones{/number}","notifications_url":"https://api.github.com/repos/hterkelsen/flutterfire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hterkelsen/flutterfire/labels{/name}","releases_url":"https://api.github.com/repos/hterkelsen/flutterfire/releases{/id}","deployments_url":"https://api.github.com/repos/hterkelsen/flutterfire/deployments","created_at":"2019-10-10T23:04:05Z","updated_at":"2019-11-30T20:18:39Z","pushed_at":"2019-12-02T00:35:37Z","git_url":"git://github.com/hterkelsen/flutterfire.git","ssh_url":"git@github.com:hterkelsen/flutterfire.git","clone_url":"https://github.com/hterkelsen/flutterfire.git","svn_url":"https://github.com/hterkelsen/flutterfire","homepage":"https://firebaseopensource.com/projects/firebaseextended/flutterfire/","size":3047,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FirebaseExtended:master","ref":"master","sha":"b49837250c619e7363463db732261737e093557d","user":{"login":"FirebaseExtended","id":42357678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMzU3Njc4","avatar_url":"https://avatars0.githubusercontent.com/u/42357678?v=4","gravatar_id":"","url":"https://api.github.com/users/FirebaseExtended","html_url":"https://github.com/FirebaseExtended","followers_url":"https://api.github.com/users/FirebaseExtended/followers","following_url":"https://api.github.com/users/FirebaseExtended/following{/other_user}","gists_url":"https://api.github.com/users/FirebaseExtended/gists{/gist_id}","starred_url":"https://api.github.com/users/FirebaseExtended/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirebaseExtended/subscriptions","organizations_url":"https://api.github.com/users/FirebaseExtended/orgs","repos_url":"https://api.github.com/users/FirebaseExtended/repos","events_url":"https://api.github.com/users/FirebaseExtended/events{/privacy}","received_events_url":"https://api.github.com/users/FirebaseExtended/received_events","type":"Organization","site_admin":false},"repo":{"id":202429703,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI0Mjk3MDM=","name":"flutterfire","full_name":"FirebaseExtended/flutterfire","private":false,"owner":{"login":"FirebaseExtended","id":42357678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMzU3Njc4","avatar_url":"https://avatars0.githubusercontent.com/u/42357678?v=4","gravatar_id":"","url":"https://api.github.com/users/FirebaseExtended","html_url":"https://github.com/FirebaseExtended","followers_url":"https://api.github.com/users/FirebaseExtended/followers","following_url":"https://api.github.com/users/FirebaseExtended/following{/other_user}","gists_url":"https://api.github.com/users/FirebaseExtended/gists{/gist_id}","starred_url":"https://api.github.com/users/FirebaseExtended/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirebaseExtended/subscriptions","organizations_url":"https://api.github.com/users/FirebaseExtended/orgs","repos_url":"https://api.github.com/users/FirebaseExtended/repos","events_url":"https://api.github.com/users/FirebaseExtended/events{/privacy}","received_events_url":"https://api.github.com/users/FirebaseExtended/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FirebaseExtended/flutterfire","description":"🔥 Firebase plugins for Flutter iOS and Android apps","fork":false,"url":"https://api.github.com/repos/FirebaseExtended/flutterfire","forks_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/forks","keys_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/teams","hooks_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/hooks","issue_events_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/issues/events{/number}","events_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/events","assignees_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/assignees{/user}","branches_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/branches{/branch}","tags_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/tags","blobs_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/git/refs{/sha}","trees_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/statuses/{sha}","languages_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/languages","stargazers_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/stargazers","contributors_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/contributors","subscribers_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/subscribers","subscription_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/subscription","commits_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/commits{/sha}","git_commits_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/git/commits{/sha}","comments_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/comments{/number}","issue_comment_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/issues/comments{/number}","contents_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/contents/{+path}","compare_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/merges","archive_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/downloads","issues_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/issues{/number}","pulls_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls{/number}","milestones_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/milestones{/number}","notifications_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/labels{/name}","releases_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/releases{/id}","deployments_url":"https://api.github.com/repos/FirebaseExtended/flutterfire/deployments","created_at":"2019-08-14T21:38:05Z","updated_at":"2019-12-02T22:13:30Z","pushed_at":"2019-12-02T22:13:28Z","git_url":"git://github.com/FirebaseExtended/flutterfire.git","ssh_url":"git@github.com:FirebaseExtended/flutterfire.git","clone_url":"https://github.com/FirebaseExtended/flutterfire.git","svn_url":"https://github.com/FirebaseExtended/flutterfire","homepage":"https://firebaseopensource.com/projects/firebaseextended/flutterfire/","size":3013,"stargazers_count":761,"watchers_count":761,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":311,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":569,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":311,"open_issues":569,"watchers":761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/1523"},"html":{"href":"https://github.com/FirebaseExtended/flutterfire/pull/1523"},"issue":{"href":"https://api.github.com/repos/FirebaseExtended/flutterfire/issues/1523"},"comments":{"href":"https://api.github.com/repos/FirebaseExtended/flutterfire/issues/1523/comments"},"review_comments":{"href":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/1523/comments"},"review_comment":{"href":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FirebaseExtended/flutterfire/pulls/1523/commits"},"statuses":{"href":"https://api.github.com/repos/FirebaseExtended/flutterfire/statuses/8bbe3c3a79d067274dc6a97076a1ab049a15450e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ditman"}}