{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/dcos/pulls/comments/266684234","pull_request_review_id":215904566,"id":266684234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjY4NDIzNA==","diff_hunk":"@@ -0,0 +1,8 @@\n+#!/bin/bash\n+\n+set -o errexit\n+set -o xtrace\n+set -o nounset\n+\n+# Start fluentbit\n+exec /opt/mesosphere/bin/fluent-bit \"$@\"","path":"packages/fluentbit/extra/start_fluentbit.sh","position":8,"original_position":8,"commit_id":"23648b705616f2d26ac6ffa6441ff0fe09761cf9","original_commit_id":"23648b705616f2d26ac6ffa6441ff0fe09761cf9","user":{"login":"branden","id":42242,"node_id":"MDQ6VXNlcjQyMjQy","avatar_url":"https://avatars0.githubusercontent.com/u/42242?v=4","gravatar_id":"","url":"https://api.github.com/users/branden","html_url":"https://github.com/branden","followers_url":"https://api.github.com/users/branden/followers","following_url":"https://api.github.com/users/branden/following{/other_user}","gists_url":"https://api.github.com/users/branden/gists{/gist_id}","starred_url":"https://api.github.com/users/branden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branden/subscriptions","organizations_url":"https://api.github.com/users/branden/orgs","repos_url":"https://api.github.com/users/branden/repos","events_url":"https://api.github.com/users/branden/events{/privacy}","received_events_url":"https://api.github.com/users/branden/received_events","type":"User","site_admin":false},"body":"Are we going to need to put anything in this startup script? I wonder if we can do without it.","created_at":"2019-03-18T23:46:35Z","updated_at":"2019-03-18T23:48:19Z","html_url":"https://github.com/mesosphere/dcos/pull/64#discussion_r266684234","pull_request_url":"https://api.github.com/repos/mesosphere/dcos/pulls/64","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos/pulls/comments/266684234"},"html":{"href":"https://github.com/mesosphere/dcos/pull/64#discussion_r266684234"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/dcos/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos/pulls/64","id":262258614,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyMjU4NjE0","html_url":"https://github.com/mesosphere/dcos/pull/64","diff_url":"https://github.com/mesosphere/dcos/pull/64.diff","patch_url":"https://github.com/mesosphere/dcos/pull/64.patch","issue_url":"https://api.github.com/repos/mesosphere/dcos/issues/64","number":64,"state":"open","locked":false,"title":"Add fluentbit as a component","user":{"login":"philipnrmn","id":2989362,"node_id":"MDQ6VXNlcjI5ODkzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/2989362?v=4","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"body":"## High-level description\r\n\r\nAdds fluentbit as a component\r\n\r\n\r\n## Corresponding DC/OS tickets (obligatory)\r\n\r\nThese DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:\r\n\r\n  - [DCOS_OSS-4421](https://jira.mesosphere.com/browse/DCOS_OSS-4421) Add fluentbit to DC/OS as a component\r\n\r\n\r\n## Related tickets (optional)\r\n\r\nOther tickets related to this change:\r\n\r\n  - [DCOS-44454](https://jira.mesosphere.com/browse/DCOS-44454)     Add a service account for fluentbit\r\n\r\n\r\n## Checklist for all PRs\r\n\r\n  - [ ] Added a comprehensible changelog entry to `CHANGES.md` or explain why this is not a user-facing change:\r\n  - [ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n  - [ ] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n  - [ ] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)\r\n\r\n\r\n## Checklist for component/package updates:\r\n\r\nIf you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath `packages`), then in addition to the above please also include:\r\n\r\n  - [ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): [example](https://github.com/dcos/dcos-mesos-modules/compare/f6fa27d7c40f4207ba3bb2274e2cfe79b62a395a...6660b90fbbf69a15ef46d0184e36755881d6a5ae)\r\n  - [ ] Test Results: [link to CI job test results for component]\r\n  - [ ] Code Coverage (if available): [link to code coverage report]\r\n","created_at":"2019-03-18T23:12:19Z","updated_at":"2019-03-18T23:48:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c548add1ee2161ffe851d4019e71a6f0328c0de","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gracedo","id":5897740,"node_id":"MDQ6VXNlcjU4OTc3NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/5897740?v=4","gravatar_id":"","url":"https://api.github.com/users/gracedo","html_url":"https://github.com/gracedo","followers_url":"https://api.github.com/users/gracedo/followers","following_url":"https://api.github.com/users/gracedo/following{/other_user}","gists_url":"https://api.github.com/users/gracedo/gists{/gist_id}","starred_url":"https://api.github.com/users/gracedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gracedo/subscriptions","organizations_url":"https://api.github.com/users/gracedo/orgs","repos_url":"https://api.github.com/users/gracedo/repos","events_url":"https://api.github.com/users/gracedo/events{/privacy}","received_events_url":"https://api.github.com/users/gracedo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/dcos/pulls/64/commits","review_comments_url":"https://api.github.com/repos/mesosphere/dcos/pulls/64/comments","review_comment_url":"https://api.github.com/repos/mesosphere/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/dcos/issues/64/comments","statuses_url":"https://api.github.com/repos/mesosphere/dcos/statuses/23648b705616f2d26ac6ffa6441ff0fe09761cf9","head":{"label":"philipnrmn:fluentbit-component","ref":"fluentbit-component","sha":"23648b705616f2d26ac6ffa6441ff0fe09761cf9","user":{"login":"philipnrmn","id":2989362,"node_id":"MDQ6VXNlcjI5ODkzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/2989362?v=4","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"repo":{"id":92886752,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjg4Njc1Mg==","name":"dcos","full_name":"philipnrmn/dcos","private":false,"owner":{"login":"philipnrmn","id":2989362,"node_id":"MDQ6VXNlcjI5ODkzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/2989362?v=4","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/philipnrmn/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/philipnrmn/dcos","forks_url":"https://api.github.com/repos/philipnrmn/dcos/forks","keys_url":"https://api.github.com/repos/philipnrmn/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philipnrmn/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philipnrmn/dcos/teams","hooks_url":"https://api.github.com/repos/philipnrmn/dcos/hooks","issue_events_url":"https://api.github.com/repos/philipnrmn/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/philipnrmn/dcos/events","assignees_url":"https://api.github.com/repos/philipnrmn/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/philipnrmn/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/philipnrmn/dcos/tags","blobs_url":"https://api.github.com/repos/philipnrmn/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philipnrmn/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philipnrmn/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/philipnrmn/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philipnrmn/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/philipnrmn/dcos/languages","stargazers_url":"https://api.github.com/repos/philipnrmn/dcos/stargazers","contributors_url":"https://api.github.com/repos/philipnrmn/dcos/contributors","subscribers_url":"https://api.github.com/repos/philipnrmn/dcos/subscribers","subscription_url":"https://api.github.com/repos/philipnrmn/dcos/subscription","commits_url":"https://api.github.com/repos/philipnrmn/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/philipnrmn/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/philipnrmn/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/philipnrmn/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/philipnrmn/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/philipnrmn/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philipnrmn/dcos/merges","archive_url":"https://api.github.com/repos/philipnrmn/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philipnrmn/dcos/downloads","issues_url":"https://api.github.com/repos/philipnrmn/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/philipnrmn/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/philipnrmn/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/philipnrmn/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philipnrmn/dcos/labels{/name}","releases_url":"https://api.github.com/repos/philipnrmn/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/philipnrmn/dcos/deployments","created_at":"2017-05-31T00:06:25Z","updated_at":"2018-12-07T23:59:24Z","pushed_at":"2019-03-18T23:14:19Z","git_url":"git://github.com/philipnrmn/dcos.git","ssh_url":"git@github.com:philipnrmn/dcos.git","clone_url":"https://github.com/philipnrmn/dcos.git","svn_url":"https://github.com/philipnrmn/dcos","homepage":"https://dcos.io","size":8672,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mesosphere:fluentbit","ref":"fluentbit","sha":"b2682b70c5c1b683890099b71c64289a916c1e15","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":62745648,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjc0NTY0OA==","name":"dcos","full_name":"mesosphere/dcos","private":false,"owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesosphere/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/mesosphere/dcos","forks_url":"https://api.github.com/repos/mesosphere/dcos/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos/deployments","created_at":"2016-07-06T18:52:22Z","updated_at":"2019-03-18T23:30:32Z","pushed_at":"2019-03-18T23:36:23Z","git_url":"git://github.com/mesosphere/dcos.git","ssh_url":"git@github.com:mesosphere/dcos.git","clone_url":"https://github.com/mesosphere/dcos.git","svn_url":"https://github.com/mesosphere/dcos","homepage":"https://dcos.io","size":12790,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":1,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos/pulls/64"},"html":{"href":"https://github.com/mesosphere/dcos/pull/64"},"issue":{"href":"https://api.github.com/repos/mesosphere/dcos/issues/64"},"comments":{"href":"https://api.github.com/repos/mesosphere/dcos/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/dcos/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/dcos/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/dcos/statuses/23648b705616f2d26ac6ffa6441ff0fe09761cf9"}},"author_association":"NONE"}}
{"actor":{"display_login":"branden"}}