{"action":"created","comment":{"url":"https://api.github.com/repos/PCMDI/cmor/pulls/comments/287477394","pull_request_review_id":241895238,"id":287477394,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NzQ3NzM5NA==","diff_hunk":"@@ -457,15 +457,15 @@ def ControlVocab(self, ncfile, variable=None, print_all=True):\n         for attr in ['branch_time_in_child', 'branch_time_in_parent']:\n             if attr in list(self.dictGbl.keys()):\n                 self.set_double_value(attr)\n-                if not isinstance(self.dictGbl[attr], numpy.float64):\n+                if not numpy.issubdtype(self.dictGbl[attr], numpy.float64):","path":"LibCV/PrePARE/PrePARE.py","position":24,"original_position":24,"commit_id":"9f56aa6bf71c22e54315239c2e2f705d28cafa6a","original_commit_id":"9f56aa6bf71c22e54315239c2e2f705d28cafa6a","user":{"login":"doutriaux1","id":2781425,"node_id":"MDQ6VXNlcjI3ODE0MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2781425?v=4","gravatar_id":"","url":"https://api.github.com/users/doutriaux1","html_url":"https://github.com/doutriaux1","followers_url":"https://api.github.com/users/doutriaux1/followers","following_url":"https://api.github.com/users/doutriaux1/following{/other_user}","gists_url":"https://api.github.com/users/doutriaux1/gists{/gist_id}","starred_url":"https://api.github.com/users/doutriaux1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doutriaux1/subscriptions","organizations_url":"https://api.github.com/users/doutriaux1/orgs","repos_url":"https://api.github.com/users/doutriaux1/repos","events_url":"https://api.github.com/users/doutriaux1/events{/privacy}","received_events_url":"https://api.github.com/users/doutriaux1/received_events","type":"User","site_admin":false},"body":"nice!","created_at":"2019-05-24T18:46:55Z","updated_at":"2019-05-24T18:46:55Z","html_url":"https://github.com/PCMDI/cmor/pull/493#discussion_r287477394","pull_request_url":"https://api.github.com/repos/PCMDI/cmor/pulls/493","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PCMDI/cmor/pulls/comments/287477394"},"html":{"href":"https://github.com/PCMDI/cmor/pull/493#discussion_r287477394"},"pull_request":{"href":"https://api.github.com/repos/PCMDI/cmor/pulls/493"}}},"pull_request":{"url":"https://api.github.com/repos/PCMDI/cmor/pulls/493","id":282120814,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyMTIwODE0","html_url":"https://github.com/PCMDI/cmor/pull/493","diff_url":"https://github.com/PCMDI/cmor/pull/493.diff","patch_url":"https://github.com/PCMDI/cmor/pull/493.patch","issue_url":"https://api.github.com/repos/PCMDI/cmor/issues/493","number":493,"state":"open","locked":false,"title":"Replace cdms2 with netCDF4 in PrePARE and Python tests","user":{"login":"mauzey1","id":42009431,"node_id":"MDQ6VXNlcjQyMDA5NDMx","avatar_url":"https://avatars0.githubusercontent.com/u/42009431?v=4","gravatar_id":"","url":"https://api.github.com/users/mauzey1","html_url":"https://github.com/mauzey1","followers_url":"https://api.github.com/users/mauzey1/followers","following_url":"https://api.github.com/users/mauzey1/following{/other_user}","gists_url":"https://api.github.com/users/mauzey1/gists{/gist_id}","starred_url":"https://api.github.com/users/mauzey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauzey1/subscriptions","organizations_url":"https://api.github.com/users/mauzey1/orgs","repos_url":"https://api.github.com/users/mauzey1/repos","events_url":"https://api.github.com/users/mauzey1/events{/privacy}","received_events_url":"https://api.github.com/users/mauzey1/received_events","type":"User","site_admin":false},"body":"Resolves #490 \r\n\r\nThis PR replaces the use of cdms2 in PrePARE and some of the Python tests with netCDF4.\r\n\r\nNote: The MacOS CircleCI checks failed due to an error when creating the conda environment.\r\n\r\n```\r\nMD5MismatchError: Conda detected a mismatch between the expected content and downloaded content\r\nfor url 'https://repo.anaconda.com/pkgs/main/osx-64/libcxx-4.0.1-h579ed51_0.tar.bz2'.\r\n  download saved to: /Users/distiller/project/workspace/test_macos_cmor/miniconda/pkgs/libcxx-4.0.1-h579ed51_0.tar.bz2\r\n  expected md5 sum: 28471619a3a79da80d9b5747f1ec0221\r\n  actual md5 sum: 291e61684d014641092020bdb1acb096\r\n```\r\n\r\nHowever, the changes that triggered the failed tests (https://github.com/PCMDI/cmor/commit/9f56aa6bf71c22e54315239c2e2f705d28cafa6a) didn't change the CircleCI configuration script.  The previous commit (https://github.com/PCMDI/cmor/commit/8ee711286de435522aaa5933ac848f1095389e91) that did change the CircleCI and Travis scripts was passing tests.\r\n","created_at":"2019-05-24T18:39:39Z","updated_at":"2019-05-24T18:46:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd9da662fa63d7393322aef8ea55a09e7cda293f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"durack1","id":3229632,"node_id":"MDQ6VXNlcjMyMjk2MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/3229632?v=4","gravatar_id":"","url":"https://api.github.com/users/durack1","html_url":"https://github.com/durack1","followers_url":"https://api.github.com/users/durack1/followers","following_url":"https://api.github.com/users/durack1/following{/other_user}","gists_url":"https://api.github.com/users/durack1/gists{/gist_id}","starred_url":"https://api.github.com/users/durack1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durack1/subscriptions","organizations_url":"https://api.github.com/users/durack1/orgs","repos_url":"https://api.github.com/users/durack1/repos","events_url":"https://api.github.com/users/durack1/events{/privacy}","received_events_url":"https://api.github.com/users/durack1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PCMDI/cmor/pulls/493/commits","review_comments_url":"https://api.github.com/repos/PCMDI/cmor/pulls/493/comments","review_comment_url":"https://api.github.com/repos/PCMDI/cmor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCMDI/cmor/issues/493/comments","statuses_url":"https://api.github.com/repos/PCMDI/cmor/statuses/9f56aa6bf71c22e54315239c2e2f705d28cafa6a","head":{"label":"PCMDI:490_replace_cdms2_with_netcdf4","ref":"490_replace_cdms2_with_netcdf4","sha":"9f56aa6bf71c22e54315239c2e2f705d28cafa6a","user":{"login":"PCMDI","id":6098305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTgzMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/6098305?v=4","gravatar_id":"","url":"https://api.github.com/users/PCMDI","html_url":"https://github.com/PCMDI","followers_url":"https://api.github.com/users/PCMDI/followers","following_url":"https://api.github.com/users/PCMDI/following{/other_user}","gists_url":"https://api.github.com/users/PCMDI/gists{/gist_id}","starred_url":"https://api.github.com/users/PCMDI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCMDI/subscriptions","organizations_url":"https://api.github.com/users/PCMDI/orgs","repos_url":"https://api.github.com/users/PCMDI/repos","events_url":"https://api.github.com/users/PCMDI/events{/privacy}","received_events_url":"https://api.github.com/users/PCMDI/received_events","type":"Organization","site_admin":false},"repo":{"id":10127138,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNzEzOA==","name":"cmor","full_name":"PCMDI/cmor","private":false,"owner":{"login":"PCMDI","id":6098305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTgzMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/6098305?v=4","gravatar_id":"","url":"https://api.github.com/users/PCMDI","html_url":"https://github.com/PCMDI","followers_url":"https://api.github.com/users/PCMDI/followers","following_url":"https://api.github.com/users/PCMDI/following{/other_user}","gists_url":"https://api.github.com/users/PCMDI/gists{/gist_id}","starred_url":"https://api.github.com/users/PCMDI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCMDI/subscriptions","organizations_url":"https://api.github.com/users/PCMDI/orgs","repos_url":"https://api.github.com/users/PCMDI/repos","events_url":"https://api.github.com/users/PCMDI/events{/privacy}","received_events_url":"https://api.github.com/users/PCMDI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PCMDI/cmor","description":"Climate Model Output Rewriter","fork":false,"url":"https://api.github.com/repos/PCMDI/cmor","forks_url":"https://api.github.com/repos/PCMDI/cmor/forks","keys_url":"https://api.github.com/repos/PCMDI/cmor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCMDI/cmor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCMDI/cmor/teams","hooks_url":"https://api.github.com/repos/PCMDI/cmor/hooks","issue_events_url":"https://api.github.com/repos/PCMDI/cmor/issues/events{/number}","events_url":"https://api.github.com/repos/PCMDI/cmor/events","assignees_url":"https://api.github.com/repos/PCMDI/cmor/assignees{/user}","branches_url":"https://api.github.com/repos/PCMDI/cmor/branches{/branch}","tags_url":"https://api.github.com/repos/PCMDI/cmor/tags","blobs_url":"https://api.github.com/repos/PCMDI/cmor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCMDI/cmor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCMDI/cmor/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCMDI/cmor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCMDI/cmor/statuses/{sha}","languages_url":"https://api.github.com/repos/PCMDI/cmor/languages","stargazers_url":"https://api.github.com/repos/PCMDI/cmor/stargazers","contributors_url":"https://api.github.com/repos/PCMDI/cmor/contributors","subscribers_url":"https://api.github.com/repos/PCMDI/cmor/subscribers","subscription_url":"https://api.github.com/repos/PCMDI/cmor/subscription","commits_url":"https://api.github.com/repos/PCMDI/cmor/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCMDI/cmor/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCMDI/cmor/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCMDI/cmor/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCMDI/cmor/contents/{+path}","compare_url":"https://api.github.com/repos/PCMDI/cmor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCMDI/cmor/merges","archive_url":"https://api.github.com/repos/PCMDI/cmor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCMDI/cmor/downloads","issues_url":"https://api.github.com/repos/PCMDI/cmor/issues{/number}","pulls_url":"https://api.github.com/repos/PCMDI/cmor/pulls{/number}","milestones_url":"https://api.github.com/repos/PCMDI/cmor/milestones{/number}","notifications_url":"https://api.github.com/repos/PCMDI/cmor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCMDI/cmor/labels{/name}","releases_url":"https://api.github.com/repos/PCMDI/cmor/releases{/id}","deployments_url":"https://api.github.com/repos/PCMDI/cmor/deployments","created_at":"2013-05-17T16:07:52Z","updated_at":"2019-05-22T21:14:05Z","pushed_at":"2019-05-24T18:39:40Z","git_url":"git://github.com/PCMDI/cmor.git","ssh_url":"git@github.com:PCMDI/cmor.git","clone_url":"https://github.com/PCMDI/cmor.git","svn_url":"https://github.com/PCMDI/cmor","homepage":null,"size":22710,"stargazers_count":29,"watchers_count":29,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":39,"watchers":29,"default_branch":"master"}},"base":{"label":"PCMDI:master","ref":"master","sha":"8a48023d6456b596df5f0a1a9440bc3fe4d2634c","user":{"login":"PCMDI","id":6098305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTgzMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/6098305?v=4","gravatar_id":"","url":"https://api.github.com/users/PCMDI","html_url":"https://github.com/PCMDI","followers_url":"https://api.github.com/users/PCMDI/followers","following_url":"https://api.github.com/users/PCMDI/following{/other_user}","gists_url":"https://api.github.com/users/PCMDI/gists{/gist_id}","starred_url":"https://api.github.com/users/PCMDI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCMDI/subscriptions","organizations_url":"https://api.github.com/users/PCMDI/orgs","repos_url":"https://api.github.com/users/PCMDI/repos","events_url":"https://api.github.com/users/PCMDI/events{/privacy}","received_events_url":"https://api.github.com/users/PCMDI/received_events","type":"Organization","site_admin":false},"repo":{"id":10127138,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNzEzOA==","name":"cmor","full_name":"PCMDI/cmor","private":false,"owner":{"login":"PCMDI","id":6098305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwOTgzMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/6098305?v=4","gravatar_id":"","url":"https://api.github.com/users/PCMDI","html_url":"https://github.com/PCMDI","followers_url":"https://api.github.com/users/PCMDI/followers","following_url":"https://api.github.com/users/PCMDI/following{/other_user}","gists_url":"https://api.github.com/users/PCMDI/gists{/gist_id}","starred_url":"https://api.github.com/users/PCMDI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCMDI/subscriptions","organizations_url":"https://api.github.com/users/PCMDI/orgs","repos_url":"https://api.github.com/users/PCMDI/repos","events_url":"https://api.github.com/users/PCMDI/events{/privacy}","received_events_url":"https://api.github.com/users/PCMDI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PCMDI/cmor","description":"Climate Model Output Rewriter","fork":false,"url":"https://api.github.com/repos/PCMDI/cmor","forks_url":"https://api.github.com/repos/PCMDI/cmor/forks","keys_url":"https://api.github.com/repos/PCMDI/cmor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCMDI/cmor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCMDI/cmor/teams","hooks_url":"https://api.github.com/repos/PCMDI/cmor/hooks","issue_events_url":"https://api.github.com/repos/PCMDI/cmor/issues/events{/number}","events_url":"https://api.github.com/repos/PCMDI/cmor/events","assignees_url":"https://api.github.com/repos/PCMDI/cmor/assignees{/user}","branches_url":"https://api.github.com/repos/PCMDI/cmor/branches{/branch}","tags_url":"https://api.github.com/repos/PCMDI/cmor/tags","blobs_url":"https://api.github.com/repos/PCMDI/cmor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCMDI/cmor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCMDI/cmor/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCMDI/cmor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCMDI/cmor/statuses/{sha}","languages_url":"https://api.github.com/repos/PCMDI/cmor/languages","stargazers_url":"https://api.github.com/repos/PCMDI/cmor/stargazers","contributors_url":"https://api.github.com/repos/PCMDI/cmor/contributors","subscribers_url":"https://api.github.com/repos/PCMDI/cmor/subscribers","subscription_url":"https://api.github.com/repos/PCMDI/cmor/subscription","commits_url":"https://api.github.com/repos/PCMDI/cmor/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCMDI/cmor/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCMDI/cmor/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCMDI/cmor/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCMDI/cmor/contents/{+path}","compare_url":"https://api.github.com/repos/PCMDI/cmor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCMDI/cmor/merges","archive_url":"https://api.github.com/repos/PCMDI/cmor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCMDI/cmor/downloads","issues_url":"https://api.github.com/repos/PCMDI/cmor/issues{/number}","pulls_url":"https://api.github.com/repos/PCMDI/cmor/pulls{/number}","milestones_url":"https://api.github.com/repos/PCMDI/cmor/milestones{/number}","notifications_url":"https://api.github.com/repos/PCMDI/cmor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCMDI/cmor/labels{/name}","releases_url":"https://api.github.com/repos/PCMDI/cmor/releases{/id}","deployments_url":"https://api.github.com/repos/PCMDI/cmor/deployments","created_at":"2013-05-17T16:07:52Z","updated_at":"2019-05-22T21:14:05Z","pushed_at":"2019-05-24T18:39:40Z","git_url":"git://github.com/PCMDI/cmor.git","ssh_url":"git@github.com:PCMDI/cmor.git","clone_url":"https://github.com/PCMDI/cmor.git","svn_url":"https://github.com/PCMDI/cmor","homepage":null,"size":22710,"stargazers_count":29,"watchers_count":29,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":39,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCMDI/cmor/pulls/493"},"html":{"href":"https://github.com/PCMDI/cmor/pull/493"},"issue":{"href":"https://api.github.com/repos/PCMDI/cmor/issues/493"},"comments":{"href":"https://api.github.com/repos/PCMDI/cmor/issues/493/comments"},"review_comments":{"href":"https://api.github.com/repos/PCMDI/cmor/pulls/493/comments"},"review_comment":{"href":"https://api.github.com/repos/PCMDI/cmor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCMDI/cmor/pulls/493/commits"},"statuses":{"href":"https://api.github.com/repos/PCMDI/cmor/statuses/9f56aa6bf71c22e54315239c2e2f705d28cafa6a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"doutriaux1"}}