{"action":"created","issue":{"url":"https://api.github.com/repos/sahb1239/SAHB.GraphQLClient/issues/70","repository_url":"https://api.github.com/repos/sahb1239/SAHB.GraphQLClient","labels_url":"https://api.github.com/repos/sahb1239/SAHB.GraphQLClient/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/sahb1239/SAHB.GraphQLClient/issues/70/comments","events_url":"https://api.github.com/repos/sahb1239/SAHB.GraphQLClient/issues/70/events","html_url":"https://github.com/sahb1239/SAHB.GraphQLClient/issues/70","id":491802790,"node_id":"MDU6SXNzdWU0OTE4MDI3OTA=","number":70,"title":"Handling loss of websocket connection","user":{"login":"chelliwell","id":5724284,"node_id":"MDQ6VXNlcjU3MjQyODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5724284?v=4","gravatar_id":"","url":"https://api.github.com/users/chelliwell","html_url":"https://github.com/chelliwell","followers_url":"https://api.github.com/users/chelliwell/followers","following_url":"https://api.github.com/users/chelliwell/following{/other_user}","gists_url":"https://api.github.com/users/chelliwell/gists{/gist_id}","starred_url":"https://api.github.com/users/chelliwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chelliwell/subscriptions","organizations_url":"https://api.github.com/users/chelliwell/orgs","repos_url":"https://api.github.com/users/chelliwell/repos","events_url":"https://api.github.com/users/chelliwell/events{/privacy}","received_events_url":"https://api.github.com/users/chelliwell/received_events","type":"User","site_admin":false},"labels":[{"id":688385218,"node_id":"MDU6TGFiZWw2ODgzODUyMTg=","url":"https://api.github.com/repos/sahb1239/SAHB.GraphQLClient/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2019-09-10T17:25:49Z","updated_at":"2019-09-17T20:07:33Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"(Me again lol)\r\nAn area I'm concerned about is if a subscription websocket gets disconnected - loss of network, server restart etc.\r\nI will be supplying an intermediate library for people to write their own 'as simple as possible' client app for receiving specific subscription messages from my server, and I would prefer not to burden them with reconnection headaches.  - i.e. have either my library or [ideally!] SAHB.GraphQLClient deal with retrying on first subscribe, and with reconnecting if the websocket goes down after that.\r\nI see that OnDisconnected() is empty, so maybe it's 'work in progress' - but it's quite a key area for me which would be great to see enhanced.\r\nI appreciate that it might not be an easy one!\r\n"},"comment":{"url":"https://api.github.com/repos/sahb1239/SAHB.GraphQLClient/issues/comments/532381015","html_url":"https://github.com/sahb1239/SAHB.GraphQLClient/issues/70#issuecomment-532381015","issue_url":"https://api.github.com/repos/sahb1239/SAHB.GraphQLClient/issues/70","id":532381015,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMjM4MTAxNQ==","user":{"login":"sahb1239","id":5653344,"node_id":"MDQ6VXNlcjU2NTMzNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5653344?v=4","gravatar_id":"","url":"https://api.github.com/users/sahb1239","html_url":"https://github.com/sahb1239","followers_url":"https://api.github.com/users/sahb1239/followers","following_url":"https://api.github.com/users/sahb1239/following{/other_user}","gists_url":"https://api.github.com/users/sahb1239/gists{/gist_id}","starred_url":"https://api.github.com/users/sahb1239/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahb1239/subscriptions","organizations_url":"https://api.github.com/users/sahb1239/orgs","repos_url":"https://api.github.com/users/sahb1239/repos","events_url":"https://api.github.com/users/sahb1239/events{/privacy}","received_events_url":"https://api.github.com/users/sahb1239/received_events","type":"User","site_admin":false},"created_at":"2019-09-17T20:07:33Z","updated_at":"2019-09-17T20:07:33Z","author_association":"OWNER","body":"Yep I think it should not disconnect if the vent handler is throwing an exception.\r\n\r\nI will work on the disconnection logic in the next weeks - it would be fine to have some observation on how it should work."}}
{"actor":{"display_login":"sahb1239"}}