{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/296181258","pull_request_review_id":252750354,"id":296181258,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NjE4MTI1OA==","diff_hunk":"@@ -32,7 +32,7 @@ import (\n var joinCommandTemplate = template.Must(template.New(\"join\").Parse(`` +\n \t`kubeadm join {{.ControlPlaneHostPort}} --token {{.Token}} \\\n     {{range $h := .CAPubKeyPins}}--discovery-token-ca-cert-hash {{$h}} {{end}}{{if .ControlPlane}}\\\n-    --experimental-control-plane {{if .CertificateKey}}--certificate-key {{.CertificateKey}}{{end}}{{end}}`,\n+    --control-plane {{if .CertificateKey}}--certificate-key {{.CertificateKey}}{{end}}{{end}}`,","path":"cmd/kubeadm/app/cmd/util/join.go","position":5,"original_position":5,"commit_id":"3b4dbe6e301cc12a9250663f026361143ffa5d1d","original_commit_id":"3b4dbe6e301cc12a9250663f026361143ffa5d1d","user":{"login":"dixudx","id":5449021,"node_id":"MDQ6VXNlcjU0NDkwMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/5449021?v=4","gravatar_id":"","url":"https://api.github.com/users/dixudx","html_url":"https://github.com/dixudx","followers_url":"https://api.github.com/users/dixudx/followers","following_url":"https://api.github.com/users/dixudx/following{/other_user}","gists_url":"https://api.github.com/users/dixudx/gists{/gist_id}","starred_url":"https://api.github.com/users/dixudx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dixudx/subscriptions","organizations_url":"https://api.github.com/users/dixudx/orgs","repos_url":"https://api.github.com/users/dixudx/repos","events_url":"https://api.github.com/users/dixudx/events{/privacy}","received_events_url":"https://api.github.com/users/dixudx/received_events","type":"User","site_admin":false},"body":"The same.\r\n\r\nRemove `ExperimentalControlPlane` as well and use `UploadCerts` instead.","created_at":"2019-06-21T10:21:55Z","updated_at":"2019-06-21T10:23:06Z","html_url":"https://github.com/kubernetes/kubernetes/pull/79267#discussion_r296181258","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/79267","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/296181258"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/79267#discussion_r296181258"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/79267"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/79267","id":290515039,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwNTE1MDM5","html_url":"https://github.com/kubernetes/kubernetes/pull/79267","diff_url":"https://github.com/kubernetes/kubernetes/pull/79267.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/79267.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79267","number":79267,"state":"open","locked":false,"title":"kubeadm: cleanup command output","user":{"login":"SataQiu","id":9354727,"node_id":"MDQ6VXNlcjkzNTQ3Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/9354727?v=4","gravatar_id":"","url":"https://api.github.com/users/SataQiu","html_url":"https://github.com/SataQiu","followers_url":"https://api.github.com/users/SataQiu/followers","following_url":"https://api.github.com/users/SataQiu/following{/other_user}","gists_url":"https://api.github.com/users/SataQiu/gists{/gist_id}","starred_url":"https://api.github.com/users/SataQiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SataQiu/subscriptions","organizations_url":"https://api.github.com/users/SataQiu/orgs","repos_url":"https://api.github.com/users/SataQiu/repos","events_url":"https://api.github.com/users/SataQiu/events{/privacy}","received_events_url":"https://api.github.com/users/SataQiu/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n\r\n1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n/kind cleanup\r\n\r\n**What this PR does / why we need it**:\r\nkubeadm: cleanup command output (remove experimental)\r\n\r\n**Which issue(s) this PR fixes**:\r\n<!--\r\n*Automatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n-->\r\nFixes kubernetes/kubeadm#1627\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--\r\nIf no, just write \"NONE\" in the release-note block below.\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2019-06-21T08:34:38Z","updated_at":"2019-06-21T10:23:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d2cdc0e5eb9fc96416c36052d85e681ed3c275a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rosti","id":1117321,"node_id":"MDQ6VXNlcjExMTczMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1117321?v=4","gravatar_id":"","url":"https://api.github.com/users/rosti","html_url":"https://github.com/rosti","followers_url":"https://api.github.com/users/rosti/followers","following_url":"https://api.github.com/users/rosti/following{/other_user}","gists_url":"https://api.github.com/users/rosti/gists{/gist_id}","starred_url":"https://api.github.com/users/rosti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosti/subscriptions","organizations_url":"https://api.github.com/users/rosti/orgs","repos_url":"https://api.github.com/users/rosti/repos","events_url":"https://api.github.com/users/rosti/events{/privacy}","received_events_url":"https://api.github.com/users/rosti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":451459590,"node_id":"MDU6TGFiZWw0NTE0NTk1OTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":114528273,"node_id":"MDU6TGFiZWwxMTQ1MjgyNzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/backlog","name":"priority/backlog","color":"fbca04","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/79267/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/79267/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79267/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3b4dbe6e301cc12a9250663f026361143ffa5d1d","head":{"label":"SataQiu:fix-kubeadm-20190621","ref":"fix-kubeadm-20190621","sha":"3b4dbe6e301cc12a9250663f026361143ffa5d1d","user":{"login":"SataQiu","id":9354727,"node_id":"MDQ6VXNlcjkzNTQ3Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/9354727?v=4","gravatar_id":"","url":"https://api.github.com/users/SataQiu","html_url":"https://github.com/SataQiu","followers_url":"https://api.github.com/users/SataQiu/followers","following_url":"https://api.github.com/users/SataQiu/following{/other_user}","gists_url":"https://api.github.com/users/SataQiu/gists{/gist_id}","starred_url":"https://api.github.com/users/SataQiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SataQiu/subscriptions","organizations_url":"https://api.github.com/users/SataQiu/orgs","repos_url":"https://api.github.com/users/SataQiu/repos","events_url":"https://api.github.com/users/SataQiu/events{/privacy}","received_events_url":"https://api.github.com/users/SataQiu/received_events","type":"User","site_admin":false},"repo":{"id":144560224,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1NjAyMjQ=","name":"kubernetes","full_name":"SataQiu/kubernetes","private":false,"owner":{"login":"SataQiu","id":9354727,"node_id":"MDQ6VXNlcjkzNTQ3Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/9354727?v=4","gravatar_id":"","url":"https://api.github.com/users/SataQiu","html_url":"https://github.com/SataQiu","followers_url":"https://api.github.com/users/SataQiu/followers","following_url":"https://api.github.com/users/SataQiu/following{/other_user}","gists_url":"https://api.github.com/users/SataQiu/gists{/gist_id}","starred_url":"https://api.github.com/users/SataQiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SataQiu/subscriptions","organizations_url":"https://api.github.com/users/SataQiu/orgs","repos_url":"https://api.github.com/users/SataQiu/repos","events_url":"https://api.github.com/users/SataQiu/events{/privacy}","received_events_url":"https://api.github.com/users/SataQiu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SataQiu/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/SataQiu/kubernetes","forks_url":"https://api.github.com/repos/SataQiu/kubernetes/forks","keys_url":"https://api.github.com/repos/SataQiu/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SataQiu/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SataQiu/kubernetes/teams","hooks_url":"https://api.github.com/repos/SataQiu/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/SataQiu/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/SataQiu/kubernetes/events","assignees_url":"https://api.github.com/repos/SataQiu/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/SataQiu/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/SataQiu/kubernetes/tags","blobs_url":"https://api.github.com/repos/SataQiu/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SataQiu/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SataQiu/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/SataQiu/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SataQiu/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/SataQiu/kubernetes/languages","stargazers_url":"https://api.github.com/repos/SataQiu/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/SataQiu/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/SataQiu/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/SataQiu/kubernetes/subscription","commits_url":"https://api.github.com/repos/SataQiu/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/SataQiu/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/SataQiu/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/SataQiu/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/SataQiu/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/SataQiu/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SataQiu/kubernetes/merges","archive_url":"https://api.github.com/repos/SataQiu/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SataQiu/kubernetes/downloads","issues_url":"https://api.github.com/repos/SataQiu/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/SataQiu/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/SataQiu/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/SataQiu/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SataQiu/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/SataQiu/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/SataQiu/kubernetes/deployments","created_at":"2018-08-13T09:49:11Z","updated_at":"2019-05-31T07:34:38Z","pushed_at":"2019-06-21T09:59:32Z","git_url":"git://github.com/SataQiu/kubernetes.git","ssh_url":"git@github.com:SataQiu/kubernetes.git","clone_url":"https://github.com/SataQiu/kubernetes.git","svn_url":"https://github.com/SataQiu/kubernetes","homepage":"http://kubernetes.io","size":651857,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"737d74d12de86481b17d2f361edd70b26580b139","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2019-06-21T10:22:50Z","pushed_at":"2019-06-21T10:13:13Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":873061,"stargazers_count":54293,"watchers_count":54293,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18817,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3238,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18817,"open_issues":3238,"watchers":54293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/79267"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/79267"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/79267"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/79267/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/79267/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/79267/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3b4dbe6e301cc12a9250663f026361143ffa5d1d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dixudx"}}