{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/docfx/pulls/comments/296112343","pull_request_review_id":252661188,"id":296112343,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NjExMjM0Mw==","diff_hunk":"@@ -166,7 +166,7 @@ private static (List<Error> errors, IReadOnlyList<InternalXrefSpec> specs) LoadS\n                 var xref = new InternalXrefSpec\n                 {\n                     Uid = item.Key,\n-                    Href = isRoot ? file.CanonicalUrlWithoutLocale : $\"{file.CanonicalUrlWithoutLocale}#{GetBookmarkFromUid(item.Key)}\",\n+                    Href = isRoot ? file.SiteUrl : $\"{file.SiteUrl}#{GetBookmarkFromUid(item.Key)}\",","path":"src/docfx/build/xref/XrefMapBuilder.cs","position":14,"original_position":14,"commit_id":"ebdcaaa6a35946199400315bd0433c1d3099aab9","original_commit_id":"ebdcaaa6a35946199400315bd0433c1d3099aab9","user":{"login":"live1206","id":5196139,"node_id":"MDQ6VXNlcjUxOTYxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5196139?v=4","gravatar_id":"","url":"https://api.github.com/users/live1206","html_url":"https://github.com/live1206","followers_url":"https://api.github.com/users/live1206/followers","following_url":"https://api.github.com/users/live1206/following{/other_user}","gists_url":"https://api.github.com/users/live1206/gists{/gist_id}","starred_url":"https://api.github.com/users/live1206/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/live1206/subscriptions","organizations_url":"https://api.github.com/users/live1206/orgs","repos_url":"https://api.github.com/users/live1206/repos","events_url":"https://api.github.com/users/live1206/events{/privacy}","received_events_url":"https://api.github.com/users/live1206/received_events","type":"User","site_admin":false},"body":"it is still in use when outputting xref map","created_at":"2019-06-21T06:36:19Z","updated_at":"2019-06-21T06:36:19Z","html_url":"https://github.com/dotnet/docfx/pull/4772#discussion_r296112343","pull_request_url":"https://api.github.com/repos/dotnet/docfx/pulls/4772","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/comments/296112343"},"html":{"href":"https://github.com/dotnet/docfx/pull/4772#discussion_r296112343"},"pull_request":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/4772"}},"in_reply_to_id":296107934},"pull_request":{"url":"https://api.github.com/repos/dotnet/docfx/pulls/4772","id":290436001,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwNDM2MDAx","html_url":"https://github.com/dotnet/docfx/pull/4772","diff_url":"https://github.com/dotnet/docfx/pull/4772.diff","patch_url":"https://github.com/dotnet/docfx/pull/4772.patch","issue_url":"https://api.github.com/repos/dotnet/docfx/issues/4772","number":4772,"state":"open","locked":false,"title":"✔xref resolving","user":{"login":"live1206","id":5196139,"node_id":"MDQ6VXNlcjUxOTYxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5196139?v=4","gravatar_id":"","url":"https://api.github.com/users/live1206","html_url":"https://github.com/live1206","followers_url":"https://api.github.com/users/live1206/followers","following_url":"https://api.github.com/users/live1206/following{/other_user}","gists_url":"https://api.github.com/users/live1206/gists{/gist_id}","starred_url":"https://api.github.com/users/live1206/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/live1206/subscriptions","organizations_url":"https://api.github.com/users/live1206/orgs","repos_url":"https://api.github.com/users/live1206/repos","events_url":"https://api.github.com/users/live1206/events{/privacy}","received_events_url":"https://api.github.com/users/live1206/received_events","type":"User","site_admin":false},"body":"- No need to remove the host name while resolving xref\r\n- Append `?branch=master` to xref URL while build branch is `master`\r\n\n\n###### Microsoft Reviewers: [Open in CodeFlow](http://wpcp.azurewebsites.net/CodeFlowProtocolProxy2.php?pullrequest=https://github.com/dotnet/docfx/pull/4772)","created_at":"2019-06-21T02:03:35Z","updated_at":"2019-06-21T06:36:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9a9ff6653be32ec6fda79e185af8c02c8c02f15","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":666587409,"node_id":"MDU6TGFiZWw2NjY1ODc0MDk=","url":"https://api.github.com/repos/dotnet/docfx/labels/v3","name":"v3","color":"8764B8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/docfx/pulls/4772/commits","review_comments_url":"https://api.github.com/repos/dotnet/docfx/pulls/4772/comments","review_comment_url":"https://api.github.com/repos/dotnet/docfx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/docfx/issues/4772/comments","statuses_url":"https://api.github.com/repos/dotnet/docfx/statuses/ebdcaaa6a35946199400315bd0433c1d3099aab9","head":{"label":"live1206:xref-resolve","ref":"xref-resolve","sha":"ebdcaaa6a35946199400315bd0433c1d3099aab9","user":{"login":"live1206","id":5196139,"node_id":"MDQ6VXNlcjUxOTYxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5196139?v=4","gravatar_id":"","url":"https://api.github.com/users/live1206","html_url":"https://github.com/live1206","followers_url":"https://api.github.com/users/live1206/followers","following_url":"https://api.github.com/users/live1206/following{/other_user}","gists_url":"https://api.github.com/users/live1206/gists{/gist_id}","starred_url":"https://api.github.com/users/live1206/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/live1206/subscriptions","organizations_url":"https://api.github.com/users/live1206/orgs","repos_url":"https://api.github.com/users/live1206/repos","events_url":"https://api.github.com/users/live1206/events{/privacy}","received_events_url":"https://api.github.com/users/live1206/received_events","type":"User","site_admin":false},"repo":{"id":141073652,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEwNzM2NTI=","name":"docfx","full_name":"live1206/docfx","private":false,"owner":{"login":"live1206","id":5196139,"node_id":"MDQ6VXNlcjUxOTYxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5196139?v=4","gravatar_id":"","url":"https://api.github.com/users/live1206","html_url":"https://github.com/live1206","followers_url":"https://api.github.com/users/live1206/followers","following_url":"https://api.github.com/users/live1206/following{/other_user}","gists_url":"https://api.github.com/users/live1206/gists{/gist_id}","starred_url":"https://api.github.com/users/live1206/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/live1206/subscriptions","organizations_url":"https://api.github.com/users/live1206/orgs","repos_url":"https://api.github.com/users/live1206/repos","events_url":"https://api.github.com/users/live1206/events{/privacy}","received_events_url":"https://api.github.com/users/live1206/received_events","type":"User","site_admin":false},"html_url":"https://github.com/live1206/docfx","description":"Tools for building and publishing API documentation for .NET projects","fork":true,"url":"https://api.github.com/repos/live1206/docfx","forks_url":"https://api.github.com/repos/live1206/docfx/forks","keys_url":"https://api.github.com/repos/live1206/docfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/live1206/docfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/live1206/docfx/teams","hooks_url":"https://api.github.com/repos/live1206/docfx/hooks","issue_events_url":"https://api.github.com/repos/live1206/docfx/issues/events{/number}","events_url":"https://api.github.com/repos/live1206/docfx/events","assignees_url":"https://api.github.com/repos/live1206/docfx/assignees{/user}","branches_url":"https://api.github.com/repos/live1206/docfx/branches{/branch}","tags_url":"https://api.github.com/repos/live1206/docfx/tags","blobs_url":"https://api.github.com/repos/live1206/docfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/live1206/docfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/live1206/docfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/live1206/docfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/live1206/docfx/statuses/{sha}","languages_url":"https://api.github.com/repos/live1206/docfx/languages","stargazers_url":"https://api.github.com/repos/live1206/docfx/stargazers","contributors_url":"https://api.github.com/repos/live1206/docfx/contributors","subscribers_url":"https://api.github.com/repos/live1206/docfx/subscribers","subscription_url":"https://api.github.com/repos/live1206/docfx/subscription","commits_url":"https://api.github.com/repos/live1206/docfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/live1206/docfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/live1206/docfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/live1206/docfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/live1206/docfx/contents/{+path}","compare_url":"https://api.github.com/repos/live1206/docfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/live1206/docfx/merges","archive_url":"https://api.github.com/repos/live1206/docfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/live1206/docfx/downloads","issues_url":"https://api.github.com/repos/live1206/docfx/issues{/number}","pulls_url":"https://api.github.com/repos/live1206/docfx/pulls{/number}","milestones_url":"https://api.github.com/repos/live1206/docfx/milestones{/number}","notifications_url":"https://api.github.com/repos/live1206/docfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/live1206/docfx/labels{/name}","releases_url":"https://api.github.com/repos/live1206/docfx/releases{/id}","deployments_url":"https://api.github.com/repos/live1206/docfx/deployments","created_at":"2018-07-16T01:52:40Z","updated_at":"2018-07-16T01:52:46Z","pushed_at":"2019-06-21T05:47:55Z","git_url":"git://github.com/live1206/docfx.git","ssh_url":"git@github.com:live1206/docfx.git","clone_url":"https://github.com/live1206/docfx.git","svn_url":"https://github.com/live1206/docfx","homepage":"http://dotnet.github.io/docfx/","size":337002,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"dotnet:v3","ref":"v3","sha":"ac268d8e4d0ed94286797df99e36bdbe0b7474d8","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":38007053,"node_id":"MDEwOlJlcG9zaXRvcnkzODAwNzA1Mw==","name":"docfx","full_name":"dotnet/docfx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/docfx","description":"Tools for building and publishing API documentation for .NET projects","fork":false,"url":"https://api.github.com/repos/dotnet/docfx","forks_url":"https://api.github.com/repos/dotnet/docfx/forks","keys_url":"https://api.github.com/repos/dotnet/docfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/docfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/docfx/teams","hooks_url":"https://api.github.com/repos/dotnet/docfx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/docfx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/docfx/events","assignees_url":"https://api.github.com/repos/dotnet/docfx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/docfx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/docfx/tags","blobs_url":"https://api.github.com/repos/dotnet/docfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/docfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/docfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/docfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/docfx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/docfx/languages","stargazers_url":"https://api.github.com/repos/dotnet/docfx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/docfx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/docfx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/docfx/subscription","commits_url":"https://api.github.com/repos/dotnet/docfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/docfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/docfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/docfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/docfx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/docfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/docfx/merges","archive_url":"https://api.github.com/repos/dotnet/docfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/docfx/downloads","issues_url":"https://api.github.com/repos/dotnet/docfx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/docfx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/docfx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/docfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/docfx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/docfx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/docfx/deployments","created_at":"2015-06-24T19:43:53Z","updated_at":"2019-06-21T05:54:48Z","pushed_at":"2019-06-21T06:17:53Z","git_url":"git://github.com/dotnet/docfx.git","ssh_url":"git@github.com:dotnet/docfx.git","clone_url":"https://github.com/dotnet/docfx.git","svn_url":"https://github.com/dotnet/docfx","homepage":"https://dotnet.github.io/docfx/","size":346125,"stargazers_count":1756,"watchers_count":1756,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":453,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":329,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":453,"open_issues":329,"watchers":1756,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/4772"},"html":{"href":"https://github.com/dotnet/docfx/pull/4772"},"issue":{"href":"https://api.github.com/repos/dotnet/docfx/issues/4772"},"comments":{"href":"https://api.github.com/repos/dotnet/docfx/issues/4772/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/4772/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/docfx/pulls/4772/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/docfx/statuses/ebdcaaa6a35946199400315bd0433c1d3099aab9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"live1206"}}