{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/comments/254645364","pull_request_review_id":201040075,"id":254645364,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDY0NTM2NA==","diff_hunk":"@@ -0,0 +1,205 @@\n+﻿/*\n+ * Copyright 2019 Google LLC\n+ * Use of this source code is governed by a BSD-style\n+ * license that can be found in the LICENSE file or at\n+ * https://developers.google.com/open-source/licenses/bsd\n+ */\n+\n+using Google.Apis.Auth.OAuth2;\n+using Grpc.Auth;\n+using Grpc.Core;\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Threading;\n+using System.Threading.Tasks;\n+\n+namespace Google.Api.Gax.Grpc\n+{\n+    /// <summary>\n+    /// Base class for API-specific builders.\n+    /// </summary>\n+    /// <typeparam name=\"TClient\">The type of client created by this builder.</typeparam>\n+    public abstract class ClientBuilder<TClient>\n+    {\n+        /// <summary>\n+        /// The endpoint to connect to, or null to use the default endpoint.\n+        /// </summary>\n+        public ServiceEndpoint Endpoint { get; set; }\n+\n+        /// <summary>\n+        /// The scopes to use, or null to use the default scopes.\n+        /// </summary>\n+        public IReadOnlyList<string> Scopes { get; set; }\n+\n+        /// <summary>\n+        /// The channel credentials to use, or null if credentials are being provided in a different way.\n+        /// </summary>\n+        public ChannelCredentials ChannelCredentials { get; set; }\n+\n+        /// <summary>\n+        /// The path to the credentials file to use, or null if credentials are being provided in a different way.\n+        /// </summary>\n+        public string CredentialsPath { get; set; }\n+\n+        /// <summary>\n+        /// The credentials to use as a JSON string, or null if credentials are being provided in a different way.\n+        /// </summary>\n+        public string JsonCredentials { get; set; }\n+\n+        /// <summary>\n+        /// The token access method to use, or null if credentials are being provided in a different way.\n+        /// </summary>\n+        /// <remarks>\n+        /// <para>\n+        /// To use a GoogleCredential for credentials, call this method using a method group conversion, e.g.","path":"Google.Api.Gax.Grpc/ClientBuilder.cs","position":55,"original_position":55,"commit_id":"100a09b49eb2092b3aedf2f6f4b9370d3e56fbda","original_commit_id":"100a09b49eb2092b3aedf2f6f4b9370d3e56fbda","user":{"login":"amanda-tarafa","id":14878252,"node_id":"MDQ6VXNlcjE0ODc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/14878252?v=4","gravatar_id":"","url":"https://api.github.com/users/amanda-tarafa","html_url":"https://github.com/amanda-tarafa","followers_url":"https://api.github.com/users/amanda-tarafa/followers","following_url":"https://api.github.com/users/amanda-tarafa/following{/other_user}","gists_url":"https://api.github.com/users/amanda-tarafa/gists{/gist_id}","starred_url":"https://api.github.com/users/amanda-tarafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amanda-tarafa/subscriptions","organizations_url":"https://api.github.com/users/amanda-tarafa/orgs","repos_url":"https://api.github.com/users/amanda-tarafa/repos","events_url":"https://api.github.com/users/amanda-tarafa/events{/privacy}","received_events_url":"https://api.github.com/users/amanda-tarafa/received_events","type":"User","site_admin":false},"body":"nit: This part of the comment is outdated.","created_at":"2019-02-07T11:35:15Z","updated_at":"2019-02-07T11:45:04Z","html_url":"https://github.com/googleapis/gax-dotnet/pull/293#discussion_r254645364","pull_request_url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/293","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/comments/254645364"},"html":{"href":"https://github.com/googleapis/gax-dotnet/pull/293#discussion_r254645364"},"pull_request":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/293"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/293","id":251077316,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxMDc3MzE2","html_url":"https://github.com/googleapis/gax-dotnet/pull/293","diff_url":"https://github.com/googleapis/gax-dotnet/pull/293.diff","patch_url":"https://github.com/googleapis/gax-dotnet/pull/293.patch","issue_url":"https://api.github.com/repos/googleapis/gax-dotnet/issues/293","number":293,"state":"open","locked":false,"title":"First pass at putting a client builder into GAX","user":{"login":"jskeet","id":17011,"node_id":"MDQ6VXNlcjE3MDEx","avatar_url":"https://avatars1.githubusercontent.com/u/17011?v=4","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"body":"This is mostly like the previous prototypes, but with slightly fewer\r\nvirtual methods:\r\n\r\n- Build and BuildAsync are now simply abstract\r\n- There's no BuildImpl/BuildImplAsync\r\n- The concrete class is responsible for validating (but we provide simple validation of the properties in this base class)\r\n\r\nWe should also consider whether we want this to be ClientBuilder or ClientBuilderBase. I don't have strong opinions either way.\r\n\r\n(I'm happy to add a unit test that uses a simple example builder - will do that once we're comfortable with the shape, but as part of this PR.)","created_at":"2019-02-07T11:21:32Z","updated_at":"2019-02-07T11:45:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb9e881b88b8cde1214738e486275f6a30e13f22","assignee":{"login":"chrisdunelm","id":316748,"node_id":"MDQ6VXNlcjMxNjc0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/316748?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdunelm","html_url":"https://github.com/chrisdunelm","followers_url":"https://api.github.com/users/chrisdunelm/followers","following_url":"https://api.github.com/users/chrisdunelm/following{/other_user}","gists_url":"https://api.github.com/users/chrisdunelm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdunelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdunelm/subscriptions","organizations_url":"https://api.github.com/users/chrisdunelm/orgs","repos_url":"https://api.github.com/users/chrisdunelm/repos","events_url":"https://api.github.com/users/chrisdunelm/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdunelm/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisdunelm","id":316748,"node_id":"MDQ6VXNlcjMxNjc0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/316748?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdunelm","html_url":"https://github.com/chrisdunelm","followers_url":"https://api.github.com/users/chrisdunelm/followers","following_url":"https://api.github.com/users/chrisdunelm/following{/other_user}","gists_url":"https://api.github.com/users/chrisdunelm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdunelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdunelm/subscriptions","organizations_url":"https://api.github.com/users/chrisdunelm/orgs","repos_url":"https://api.github.com/users/chrisdunelm/repos","events_url":"https://api.github.com/users/chrisdunelm/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdunelm/received_events","type":"User","site_admin":false},{"login":"amanda-tarafa","id":14878252,"node_id":"MDQ6VXNlcjE0ODc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/14878252?v=4","gravatar_id":"","url":"https://api.github.com/users/amanda-tarafa","html_url":"https://github.com/amanda-tarafa","followers_url":"https://api.github.com/users/amanda-tarafa/followers","following_url":"https://api.github.com/users/amanda-tarafa/following{/other_user}","gists_url":"https://api.github.com/users/amanda-tarafa/gists{/gist_id}","starred_url":"https://api.github.com/users/amanda-tarafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amanda-tarafa/subscriptions","organizations_url":"https://api.github.com/users/amanda-tarafa/orgs","repos_url":"https://api.github.com/users/amanda-tarafa/repos","events_url":"https://api.github.com/users/amanda-tarafa/events{/privacy}","received_events_url":"https://api.github.com/users/amanda-tarafa/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1062999473,"node_id":"MDU6TGFiZWwxMDYyOTk5NDcz","url":"https://api.github.com/repos/googleapis/gax-dotnet/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/293/commits","review_comments_url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/293/comments","review_comment_url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/gax-dotnet/issues/293/comments","statuses_url":"https://api.github.com/repos/googleapis/gax-dotnet/statuses/100a09b49eb2092b3aedf2f6f4b9370d3e56fbda","head":{"label":"jskeet:client-builder-base","ref":"client-builder-base","sha":"100a09b49eb2092b3aedf2f6f4b9370d3e56fbda","user":{"login":"jskeet","id":17011,"node_id":"MDQ6VXNlcjE3MDEx","avatar_url":"https://avatars1.githubusercontent.com/u/17011?v=4","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"repo":{"id":52385973,"node_id":"MDEwOlJlcG9zaXRvcnk1MjM4NTk3Mw==","name":"gax-dotnet","full_name":"jskeet/gax-dotnet","private":false,"owner":{"login":"jskeet","id":17011,"node_id":"MDQ6VXNlcjE3MDEx","avatar_url":"https://avatars1.githubusercontent.com/u/17011?v=4","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jskeet/gax-dotnet","description":null,"fork":true,"url":"https://api.github.com/repos/jskeet/gax-dotnet","forks_url":"https://api.github.com/repos/jskeet/gax-dotnet/forks","keys_url":"https://api.github.com/repos/jskeet/gax-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jskeet/gax-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jskeet/gax-dotnet/teams","hooks_url":"https://api.github.com/repos/jskeet/gax-dotnet/hooks","issue_events_url":"https://api.github.com/repos/jskeet/gax-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/jskeet/gax-dotnet/events","assignees_url":"https://api.github.com/repos/jskeet/gax-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/jskeet/gax-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/jskeet/gax-dotnet/tags","blobs_url":"https://api.github.com/repos/jskeet/gax-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jskeet/gax-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jskeet/gax-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jskeet/gax-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jskeet/gax-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/jskeet/gax-dotnet/languages","stargazers_url":"https://api.github.com/repos/jskeet/gax-dotnet/stargazers","contributors_url":"https://api.github.com/repos/jskeet/gax-dotnet/contributors","subscribers_url":"https://api.github.com/repos/jskeet/gax-dotnet/subscribers","subscription_url":"https://api.github.com/repos/jskeet/gax-dotnet/subscription","commits_url":"https://api.github.com/repos/jskeet/gax-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jskeet/gax-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jskeet/gax-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jskeet/gax-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jskeet/gax-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/jskeet/gax-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jskeet/gax-dotnet/merges","archive_url":"https://api.github.com/repos/jskeet/gax-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jskeet/gax-dotnet/downloads","issues_url":"https://api.github.com/repos/jskeet/gax-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/jskeet/gax-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/jskeet/gax-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/jskeet/gax-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jskeet/gax-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/jskeet/gax-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/jskeet/gax-dotnet/deployments","created_at":"2016-02-23T19:33:42Z","updated_at":"2018-03-20T08:19:12Z","pushed_at":"2019-02-07T11:19:59Z","git_url":"git://github.com/jskeet/gax-dotnet.git","ssh_url":"git@github.com:jskeet/gax-dotnet.git","clone_url":"https://github.com/jskeet/gax-dotnet.git","svn_url":"https://github.com/jskeet/gax-dotnet","homepage":null,"size":903,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"ba1d6242ce870881eac8e10481a4d03a0a2429ca","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":50878438,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3ODQzOA==","name":"gax-dotnet","full_name":"googleapis/gax-dotnet","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/gax-dotnet","description":"Google API Extensions for .NET ","fork":false,"url":"https://api.github.com/repos/googleapis/gax-dotnet","forks_url":"https://api.github.com/repos/googleapis/gax-dotnet/forks","keys_url":"https://api.github.com/repos/googleapis/gax-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/gax-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/gax-dotnet/teams","hooks_url":"https://api.github.com/repos/googleapis/gax-dotnet/hooks","issue_events_url":"https://api.github.com/repos/googleapis/gax-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/gax-dotnet/events","assignees_url":"https://api.github.com/repos/googleapis/gax-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/gax-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/gax-dotnet/tags","blobs_url":"https://api.github.com/repos/googleapis/gax-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/gax-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/gax-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/gax-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/gax-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/gax-dotnet/languages","stargazers_url":"https://api.github.com/repos/googleapis/gax-dotnet/stargazers","contributors_url":"https://api.github.com/repos/googleapis/gax-dotnet/contributors","subscribers_url":"https://api.github.com/repos/googleapis/gax-dotnet/subscribers","subscription_url":"https://api.github.com/repos/googleapis/gax-dotnet/subscription","commits_url":"https://api.github.com/repos/googleapis/gax-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/gax-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/gax-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/gax-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/gax-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/gax-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/gax-dotnet/merges","archive_url":"https://api.github.com/repos/googleapis/gax-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/gax-dotnet/downloads","issues_url":"https://api.github.com/repos/googleapis/gax-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/gax-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/gax-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/gax-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/gax-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/gax-dotnet/deployments","created_at":"2016-02-01T23:13:51Z","updated_at":"2019-02-07T10:54:52Z","pushed_at":"2019-02-07T11:21:32Z","git_url":"git://github.com/googleapis/gax-dotnet.git","ssh_url":"git@github.com:googleapis/gax-dotnet.git","clone_url":"https://github.com/googleapis/gax-dotnet.git","svn_url":"https://github.com/googleapis/gax-dotnet","homepage":"","size":908,"stargazers_count":32,"watchers_count":32,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":5,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/293"},"html":{"href":"https://github.com/googleapis/gax-dotnet/pull/293"},"issue":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/issues/293"},"comments":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/statuses/100a09b49eb2092b3aedf2f6f4b9370d3e56fbda"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"amanda-tarafa"}}