{"action":"created","issue":{"url":"https://api.github.com/repos/linkerd/linkerd2/issues/3120","repository_url":"https://api.github.com/repos/linkerd/linkerd2","labels_url":"https://api.github.com/repos/linkerd/linkerd2/issues/3120/labels{/name}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/issues/3120/comments","events_url":"https://api.github.com/repos/linkerd/linkerd2/issues/3120/events","html_url":"https://github.com/linkerd/linkerd2/pull/3120","id":471406136,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMDc5OTY0","number":3120,"title":"Return invalid argument for external name services","user":{"login":"adleong","id":3979810,"node_id":"MDQ6VXNlcjM5Nzk4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"adleong","id":3979810,"node_id":"MDQ6VXNlcjM5Nzk4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false},"assignees":[{"login":"adleong","id":3979810,"node_id":"MDQ6VXNlcjM5Nzk4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2019-07-22T23:53:42Z","updated_at":"2019-07-26T21:54:33Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/linkerd/linkerd2/pulls/3120","html_url":"https://github.com/linkerd/linkerd2/pull/3120","diff_url":"https://github.com/linkerd/linkerd2/pull/3120.diff","patch_url":"https://github.com/linkerd/linkerd2/pull/3120.patch"},"body":"Fixes https://github.com/linkerd/linkerd2/issues/2800#issuecomment-513740498\r\n\r\nWhen the Linkerd proxy sends a query for a Kubernetes external name service to the destination service, the destination service returns `NoEndpoints: exists=false` because an external name service has no endpoints resource.  Due to a change in the proxy's fallback logic, this no longer causes the proxy to fallback to either DNS or SO_ORIG_DST and instead fails the request.  The net effect is that Linkerd fails all requests to external name services.\r\n\r\nWe change the destination service to instead return `InvalidArgument` for external name services.  This causes the proxy to fallback to SO_ORIG_DST instead of failing the request.\r\n\r\nSigned-off-by: Alex Leong <alex@buoyant.io>"},"comment":{"url":"https://api.github.com/repos/linkerd/linkerd2/issues/comments/515610841","html_url":"https://github.com/linkerd/linkerd2/pull/3120#issuecomment-515610841","issue_url":"https://api.github.com/repos/linkerd/linkerd2/issues/3120","id":515610841,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNTYxMDg0MQ==","user":{"login":"l5d-bot","id":48604953,"node_id":"MDQ6VXNlcjQ4NjA0OTUz","avatar_url":"https://avatars3.githubusercontent.com/u/48604953?v=4","gravatar_id":"","url":"https://api.github.com/users/l5d-bot","html_url":"https://github.com/l5d-bot","followers_url":"https://api.github.com/users/l5d-bot/followers","following_url":"https://api.github.com/users/l5d-bot/following{/other_user}","gists_url":"https://api.github.com/users/l5d-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/l5d-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l5d-bot/subscriptions","organizations_url":"https://api.github.com/users/l5d-bot/orgs","repos_url":"https://api.github.com/users/l5d-bot/repos","events_url":"https://api.github.com/users/l5d-bot/events{/privacy}","received_events_url":"https://api.github.com/users/l5d-bot/received_events","type":"User","site_admin":false},"created_at":"2019-07-26T21:54:33Z","updated_at":"2019-07-26T21:54:33Z","author_association":"NONE","body":"Integration test results for 627e88793616f306bb019c5d7a6fc9ce6e098f98: fail 😕\nLog output: https://gist.github.com/3c82837c3063be1a436396b7f8a70e87"}}
{"actor":{"display_login":"l5d-bot"}}