{"action":"created","issue":{"url":"https://api.github.com/repos/simon-jouet/ESP32Controller/issues/5","repository_url":"https://api.github.com/repos/simon-jouet/ESP32Controller","labels_url":"https://api.github.com/repos/simon-jouet/ESP32Controller/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/simon-jouet/ESP32Controller/issues/5/comments","events_url":"https://api.github.com/repos/simon-jouet/ESP32Controller/issues/5/events","html_url":"https://github.com/simon-jouet/ESP32Controller/issues/5","id":445852612,"node_id":"MDU6SXNzdWU0NDU4NTI2MTI=","number":5,"title":"[Question] Where to define I2S_STEPPER_STREAM and any ideas about temperature readings?","user":{"login":"felixstorm","id":1177810,"node_id":"MDQ6VXNlcjExNzc4MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1177810?v=4","gravatar_id":"","url":"https://api.github.com/users/felixstorm","html_url":"https://github.com/felixstorm","followers_url":"https://api.github.com/users/felixstorm/followers","following_url":"https://api.github.com/users/felixstorm/following{/other_user}","gists_url":"https://api.github.com/users/felixstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/felixstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixstorm/subscriptions","organizations_url":"https://api.github.com/users/felixstorm/orgs","repos_url":"https://api.github.com/users/felixstorm/repos","events_url":"https://api.github.com/users/felixstorm/events{/privacy}","received_events_url":"https://api.github.com/users/felixstorm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2019-05-19T19:02:36Z","updated_at":"2019-05-21T08:22:26Z","closed_at":null,"author_association":"NONE","body":"Hi Simon,\r\n\r\nthanks for your great work! I upgraded my Creality Ender 3 to use an ESP32 with TMC2208 stepper drivers connected to I2S based on your coding and on your schematic here in the r2 branch and it works like a charm - just finished my first print today!\r\n\r\nTwo questions came up that you might have an answer to:\r\n* Where did you define `I2S_STEPPER_STREAM`? I thought it would be best suited in `pins_ESP32.h` but then it seems to be missing inside `stepper.cpp` (all moves ended up terribly slow as `STEPPER_TIMER_RATE` had been defined as if used without I2S). I ended up putting it in `platformio.ini` as a build flag, but maybe you have a better idea?\r\n* Temperature readings vary massively. This might have to do with the ESP32s ADC - is that just the way it is or have you been able to figure out a better solution?\r\n\r\nThanks again for your great work and kind regards,\r\nFelix"},"comment":{"url":"https://api.github.com/repos/simon-jouet/ESP32Controller/issues/comments/494291206","html_url":"https://github.com/simon-jouet/ESP32Controller/issues/5#issuecomment-494291206","issue_url":"https://api.github.com/repos/simon-jouet/ESP32Controller/issues/5","id":494291206,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5NDI5MTIwNg==","user":{"login":"vivian-ng","id":24537694,"node_id":"MDQ6VXNlcjI0NTM3Njk0","avatar_url":"https://avatars3.githubusercontent.com/u/24537694?v=4","gravatar_id":"","url":"https://api.github.com/users/vivian-ng","html_url":"https://github.com/vivian-ng","followers_url":"https://api.github.com/users/vivian-ng/followers","following_url":"https://api.github.com/users/vivian-ng/following{/other_user}","gists_url":"https://api.github.com/users/vivian-ng/gists{/gist_id}","starred_url":"https://api.github.com/users/vivian-ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivian-ng/subscriptions","organizations_url":"https://api.github.com/users/vivian-ng/orgs","repos_url":"https://api.github.com/users/vivian-ng/repos","events_url":"https://api.github.com/users/vivian-ng/events{/privacy}","received_events_url":"https://api.github.com/users/vivian-ng/received_events","type":"User","site_admin":false},"created_at":"2019-05-21T08:22:26Z","updated_at":"2019-05-21T08:22:26Z","author_association":"NONE","body":"@felixstorm Thank you for the schematic.\r\nDid you have any issues feeding back inputs to the ESP32 with the LCD controller? Because the LCD controller is being powered by 5V, but the ESP32 only accepts 3.3V inputs. My main worry is blowing out the pins on the ESP32 from the inputs like BTN_EN1 and BTN_EN2."}}
{"actor":{"display_login":"vivian-ng"}}