{"action":"created","issue":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/654","repository_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl","labels_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/654/labels{/name}","comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/654/comments","events_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/654/events","html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/654","id":507820683,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4NzM0NzEw","number":654,"title":"Change representation of debug-commands to a set of command names","user":{"login":"yuhan0","id":22216124,"node_id":"MDQ6VXNlcjIyMjE2MTI0","avatar_url":"https://avatars0.githubusercontent.com/u/22216124?v=4","gravatar_id":"","url":"https://api.github.com/users/yuhan0","html_url":"https://github.com/yuhan0","followers_url":"https://api.github.com/users/yuhan0/followers","following_url":"https://api.github.com/users/yuhan0/following{/other_user}","gists_url":"https://api.github.com/users/yuhan0/gists{/gist_id}","starred_url":"https://api.github.com/users/yuhan0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuhan0/subscriptions","organizations_url":"https://api.github.com/users/yuhan0/orgs","repos_url":"https://api.github.com/users/yuhan0/repos","events_url":"https://api.github.com/users/yuhan0/events{/privacy}","received_events_url":"https://api.github.com/users/yuhan0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-10-16T12:30:37Z","updated_at":"2019-10-17T14:22:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/654","html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/654","diff_url":"https://github.com/clojure-emacs/cider-nrepl/pull/654.diff","patch_url":"https://github.com/clojure-emacs/cider-nrepl/pull/654.patch"},"body":"Note: This is a breaking change that sends debug commands to the client as an unsorted\r\nlist of command names without key mapping information, as a means of separating\r\nconcerns.\r\n\r\n\r\nQuick draft of the changes suggested in https://github.com/clojure-emacs/cider/pull/2731\r\nIf everything looks alright I'll go ahead with adding changelog notes and tests\r\n\r\nBefore submitting a PR make sure the following things have been done:\r\n\r\n- [x] The commits are consistent with our [contribution guidelines](CONTRIBUTING.md)\r\n- [ ] You've added tests to cover your change(s)\r\n- [ ] All tests are passing\r\n- [x] The new code is not generating reflection warnings\r\n- [ ] You've updated the README (if adding/changing middleware)\r\n"},"comment":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/comments/543198283","html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/654#issuecomment-543198283","issue_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/654","id":543198283,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MzE5ODI4Mw==","user":{"login":"yuhan0","id":22216124,"node_id":"MDQ6VXNlcjIyMjE2MTI0","avatar_url":"https://avatars0.githubusercontent.com/u/22216124?v=4","gravatar_id":"","url":"https://api.github.com/users/yuhan0","html_url":"https://github.com/yuhan0","followers_url":"https://api.github.com/users/yuhan0/followers","following_url":"https://api.github.com/users/yuhan0/following{/other_user}","gists_url":"https://api.github.com/users/yuhan0/gists{/gist_id}","starred_url":"https://api.github.com/users/yuhan0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuhan0/subscriptions","organizations_url":"https://api.github.com/users/yuhan0/orgs","repos_url":"https://api.github.com/users/yuhan0/repos","events_url":"https://api.github.com/users/yuhan0/events{/privacy}","received_events_url":"https://api.github.com/users/yuhan0/received_events","type":"User","site_admin":false},"created_at":"2019-10-17T14:22:18Z","updated_at":"2019-10-17T14:22:18Z","author_association":"CONTRIBUTOR","body":"Ok, I rebased the conflicts, removed the references to :insPect and renamed :Continue to :continue-all. \r\n\r\nSomehow I can't seem to get the test suite working locally - `make test` reports an unrelated error in the info-test and passes the cider.nrepl.debug tests.\r\n\r\n```\r\nFAIL in (integration-test) (info_test.clj:161)\r\ninfo op get info of a java method\r\nexpected: (.startsWith (:javadoc response) \"https://docs.oracle.com/\")\r\n  actual: false\r\n```"}}
{"actor":{"display_login":"yuhan0"}}