{"action":"created","comment":{"url":"https://api.github.com/repos/istio/cni/pulls/comments/364402099","pull_request_review_id":340086303,"id":364402099,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDQwMjA5OQ==","diff_hunk":"@@ -0,0 +1,14 @@\n+FROM ubuntu:xenial","path":"deployments/kubernetes/Dockerfile.istio-cni-daemonset","position":1,"original_position":1,"commit_id":"a685682a05739cb5db3bc15770ff25d483aafde5","original_commit_id":"a685682a05739cb5db3bc15770ff25d483aafde5","user":{"login":"howardjohn","id":623453,"node_id":"MDQ6VXNlcjYyMzQ1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/623453?v=4","gravatar_id":"","url":"https://api.github.com/users/howardjohn","html_url":"https://github.com/howardjohn","followers_url":"https://api.github.com/users/howardjohn/followers","following_url":"https://api.github.com/users/howardjohn/following{/other_user}","gists_url":"https://api.github.com/users/howardjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/howardjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardjohn/subscriptions","organizations_url":"https://api.github.com/users/howardjohn/orgs","repos_url":"https://api.github.com/users/howardjohn/repos","events_url":"https://api.github.com/users/howardjohn/events{/privacy}","received_events_url":"https://api.github.com/users/howardjohn/received_events","type":"User","site_admin":false},"body":"use :bionic to match other istio components. Or distroless","created_at":"2020-01-08T19:24:36Z","updated_at":"2020-01-08T19:27:15Z","html_url":"https://github.com/istio/cni/pull/226#discussion_r364402099","pull_request_url":"https://api.github.com/repos/istio/cni/pulls/226","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/cni/pulls/comments/364402099"},"html":{"href":"https://github.com/istio/cni/pull/226#discussion_r364402099"},"pull_request":{"href":"https://api.github.com/repos/istio/cni/pulls/226"}}},"pull_request":{"url":"https://api.github.com/repos/istio/cni/pulls/226","id":354217892,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0MjE3ODky","html_url":"https://github.com/istio/cni/pull/226","diff_url":"https://github.com/istio/cni/pull/226.diff","patch_url":"https://github.com/istio/cni/pull/226.patch","issue_url":"https://api.github.com/repos/istio/cni/issues/226","number":226,"state":"open","locked":false,"title":"Adding CNI Repair Daemonset","user":{"login":"stewartbutler","id":167207,"node_id":"MDQ6VXNlcjE2NzIwNw==","avatar_url":"https://avatars3.githubusercontent.com/u/167207?v=4","gravatar_id":"","url":"https://api.github.com/users/stewartbutler","html_url":"https://github.com/stewartbutler","followers_url":"https://api.github.com/users/stewartbutler/followers","following_url":"https://api.github.com/users/stewartbutler/following{/other_user}","gists_url":"https://api.github.com/users/stewartbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/stewartbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stewartbutler/subscriptions","organizations_url":"https://api.github.com/users/stewartbutler/orgs","repos_url":"https://api.github.com/users/stewartbutler/repos","events_url":"https://api.github.com/users/stewartbutler/events{/privacy}","received_events_url":"https://api.github.com/users/stewartbutler/received_events","type":"User","site_admin":false},"body":"This PR will implement the CNI repair daemonset as detailed in https://tinyurl.com/istio-cni-race. The code is still being written, this PR is just a placeholder for tracking progress and providing a place for implementation discussion.\r\n\r\nThis PR will not include the race condition detection code; at present, the plan is for that to be included in a separate PR by @lambdai.\r\n\r\n","created_at":"2019-12-17T17:11:22Z","updated_at":"2020-01-08T19:27:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17aff28017d212e49c234be9e88be9e67f241c0c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1463980339,"node_id":"MDU6TGFiZWwxNDYzOTgwMzM5","url":"https://api.github.com/repos/istio/cni/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false,"description":"Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA."},{"id":1448953385,"node_id":"MDU6TGFiZWwxNDQ4OTUzMzg1","url":"https://api.github.com/repos/istio/cni/labels/size/XXL","name":"size/XXL","color":"77bb00","default":false,"description":"Denotes a PR that changes 1000+ lines, ignoring generated files."}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/cni/pulls/226/commits","review_comments_url":"https://api.github.com/repos/istio/cni/pulls/226/comments","review_comment_url":"https://api.github.com/repos/istio/cni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/cni/issues/226/comments","statuses_url":"https://api.github.com/repos/istio/cni/statuses/a685682a05739cb5db3bc15770ff25d483aafde5","head":{"label":"stewartbutler:cni-repair-daemonset","ref":"cni-repair-daemonset","sha":"a685682a05739cb5db3bc15770ff25d483aafde5","user":{"login":"stewartbutler","id":167207,"node_id":"MDQ6VXNlcjE2NzIwNw==","avatar_url":"https://avatars3.githubusercontent.com/u/167207?v=4","gravatar_id":"","url":"https://api.github.com/users/stewartbutler","html_url":"https://github.com/stewartbutler","followers_url":"https://api.github.com/users/stewartbutler/followers","following_url":"https://api.github.com/users/stewartbutler/following{/other_user}","gists_url":"https://api.github.com/users/stewartbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/stewartbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stewartbutler/subscriptions","organizations_url":"https://api.github.com/users/stewartbutler/orgs","repos_url":"https://api.github.com/users/stewartbutler/repos","events_url":"https://api.github.com/users/stewartbutler/events{/privacy}","received_events_url":"https://api.github.com/users/stewartbutler/received_events","type":"User","site_admin":false},"repo":{"id":228478155,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg0NzgxNTU=","name":"cni","full_name":"stewartbutler/cni","private":false,"owner":{"login":"stewartbutler","id":167207,"node_id":"MDQ6VXNlcjE2NzIwNw==","avatar_url":"https://avatars3.githubusercontent.com/u/167207?v=4","gravatar_id":"","url":"https://api.github.com/users/stewartbutler","html_url":"https://github.com/stewartbutler","followers_url":"https://api.github.com/users/stewartbutler/followers","following_url":"https://api.github.com/users/stewartbutler/following{/other_user}","gists_url":"https://api.github.com/users/stewartbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/stewartbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stewartbutler/subscriptions","organizations_url":"https://api.github.com/users/stewartbutler/orgs","repos_url":"https://api.github.com/users/stewartbutler/repos","events_url":"https://api.github.com/users/stewartbutler/events{/privacy}","received_events_url":"https://api.github.com/users/stewartbutler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stewartbutler/cni","description":"Istio CNI to setup kubernetes pod namespaces to redirect traffic to sidecar proxy.","fork":true,"url":"https://api.github.com/repos/stewartbutler/cni","forks_url":"https://api.github.com/repos/stewartbutler/cni/forks","keys_url":"https://api.github.com/repos/stewartbutler/cni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stewartbutler/cni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stewartbutler/cni/teams","hooks_url":"https://api.github.com/repos/stewartbutler/cni/hooks","issue_events_url":"https://api.github.com/repos/stewartbutler/cni/issues/events{/number}","events_url":"https://api.github.com/repos/stewartbutler/cni/events","assignees_url":"https://api.github.com/repos/stewartbutler/cni/assignees{/user}","branches_url":"https://api.github.com/repos/stewartbutler/cni/branches{/branch}","tags_url":"https://api.github.com/repos/stewartbutler/cni/tags","blobs_url":"https://api.github.com/repos/stewartbutler/cni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stewartbutler/cni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stewartbutler/cni/git/refs{/sha}","trees_url":"https://api.github.com/repos/stewartbutler/cni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stewartbutler/cni/statuses/{sha}","languages_url":"https://api.github.com/repos/stewartbutler/cni/languages","stargazers_url":"https://api.github.com/repos/stewartbutler/cni/stargazers","contributors_url":"https://api.github.com/repos/stewartbutler/cni/contributors","subscribers_url":"https://api.github.com/repos/stewartbutler/cni/subscribers","subscription_url":"https://api.github.com/repos/stewartbutler/cni/subscription","commits_url":"https://api.github.com/repos/stewartbutler/cni/commits{/sha}","git_commits_url":"https://api.github.com/repos/stewartbutler/cni/git/commits{/sha}","comments_url":"https://api.github.com/repos/stewartbutler/cni/comments{/number}","issue_comment_url":"https://api.github.com/repos/stewartbutler/cni/issues/comments{/number}","contents_url":"https://api.github.com/repos/stewartbutler/cni/contents/{+path}","compare_url":"https://api.github.com/repos/stewartbutler/cni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stewartbutler/cni/merges","archive_url":"https://api.github.com/repos/stewartbutler/cni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stewartbutler/cni/downloads","issues_url":"https://api.github.com/repos/stewartbutler/cni/issues{/number}","pulls_url":"https://api.github.com/repos/stewartbutler/cni/pulls{/number}","milestones_url":"https://api.github.com/repos/stewartbutler/cni/milestones{/number}","notifications_url":"https://api.github.com/repos/stewartbutler/cni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stewartbutler/cni/labels{/name}","releases_url":"https://api.github.com/repos/stewartbutler/cni/releases{/id}","deployments_url":"https://api.github.com/repos/stewartbutler/cni/deployments","created_at":"2019-12-16T21:22:07Z","updated_at":"2019-12-16T21:22:09Z","pushed_at":"2020-01-07T00:18:53Z","git_url":"git://github.com/stewartbutler/cni.git","ssh_url":"git@github.com:stewartbutler/cni.git","clone_url":"https://github.com/stewartbutler/cni.git","svn_url":"https://github.com/stewartbutler/cni","homepage":null,"size":54121,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"de82fe897b1e1307d437535a852f6ca6a8c11749","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":150199467,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxOTk0Njc=","name":"cni","full_name":"istio/cni","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/cni","description":"Istio CNI to setup kubernetes pod namespaces to redirect traffic to sidecar proxy.","fork":false,"url":"https://api.github.com/repos/istio/cni","forks_url":"https://api.github.com/repos/istio/cni/forks","keys_url":"https://api.github.com/repos/istio/cni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/cni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/cni/teams","hooks_url":"https://api.github.com/repos/istio/cni/hooks","issue_events_url":"https://api.github.com/repos/istio/cni/issues/events{/number}","events_url":"https://api.github.com/repos/istio/cni/events","assignees_url":"https://api.github.com/repos/istio/cni/assignees{/user}","branches_url":"https://api.github.com/repos/istio/cni/branches{/branch}","tags_url":"https://api.github.com/repos/istio/cni/tags","blobs_url":"https://api.github.com/repos/istio/cni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/cni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/cni/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/cni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/cni/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/cni/languages","stargazers_url":"https://api.github.com/repos/istio/cni/stargazers","contributors_url":"https://api.github.com/repos/istio/cni/contributors","subscribers_url":"https://api.github.com/repos/istio/cni/subscribers","subscription_url":"https://api.github.com/repos/istio/cni/subscription","commits_url":"https://api.github.com/repos/istio/cni/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/cni/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/cni/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/cni/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/cni/contents/{+path}","compare_url":"https://api.github.com/repos/istio/cni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/cni/merges","archive_url":"https://api.github.com/repos/istio/cni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/cni/downloads","issues_url":"https://api.github.com/repos/istio/cni/issues{/number}","pulls_url":"https://api.github.com/repos/istio/cni/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/cni/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/cni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/cni/labels{/name}","releases_url":"https://api.github.com/repos/istio/cni/releases{/id}","deployments_url":"https://api.github.com/repos/istio/cni/deployments","created_at":"2018-09-25T02:58:43Z","updated_at":"2020-01-07T03:13:34Z","pushed_at":"2020-01-07T00:18:55Z","git_url":"git://github.com/istio/cni.git","ssh_url":"git@github.com:istio/cni.git","clone_url":"https://github.com/istio/cni.git","svn_url":"https://github.com/istio/cni","homepage":null,"size":54073,"stargazers_count":105,"watchers_count":105,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":59,"open_issues":2,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/cni/pulls/226"},"html":{"href":"https://github.com/istio/cni/pull/226"},"issue":{"href":"https://api.github.com/repos/istio/cni/issues/226"},"comments":{"href":"https://api.github.com/repos/istio/cni/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/cni/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/cni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/cni/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/istio/cni/statuses/a685682a05739cb5db3bc15770ff25d483aafde5"}},"author_association":"NONE"}}
{"actor":{"display_login":"howardjohn"}}