{"action":"created","comment":{"url":"https://api.github.com/repos/eBay/ebayui-core/pulls/comments/356977409","pull_request_review_id":331016068,"id":356977409,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Njk3NzQwOQ==","diff_hunk":"@@ -84,8 +90,14 @@ module.exports = {\n     onInput(input) {\n         input.autocomplete = input.autocomplete === 'list' ? 'list' : 'none';\n         input.options = input.options || [];\n-        this.lastValue = input.value;\n-        this.state = { currentValue: input.value };\n+        let inputId;\n+        if (input['*']) {","path":"src/components/ebay-combobox/component.js","position":22,"original_position":22,"commit_id":"9e7cfb0a5704e79e46c81179e63b8391f5633228","original_commit_id":"9e7cfb0a5704e79e46c81179e63b8391f5633228","user":{"login":"agliga","id":1755269,"node_id":"MDQ6VXNlcjE3NTUyNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1755269?v=4","gravatar_id":"","url":"https://api.github.com/users/agliga","html_url":"https://github.com/agliga","followers_url":"https://api.github.com/users/agliga/followers","following_url":"https://api.github.com/users/agliga/following{/other_user}","gists_url":"https://api.github.com/users/agliga/gists{/gist_id}","starred_url":"https://api.github.com/users/agliga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agliga/subscriptions","organizations_url":"https://api.github.com/users/agliga/orgs","repos_url":"https://api.github.com/users/agliga/repos","events_url":"https://api.github.com/users/agliga/events{/privacy}","received_events_url":"https://api.github.com/users/agliga/received_events","type":"User","site_admin":false},"body":"In marko 4, we should have `input.value` and `input.id` instead of `input['*']` attributes.","created_at":"2019-12-12T06:31:37Z","updated_at":"2019-12-12T06:33:16Z","html_url":"https://github.com/eBay/ebayui-core/pull/984#discussion_r356977409","pull_request_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/984","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/comments/356977409"},"html":{"href":"https://github.com/eBay/ebayui-core/pull/984#discussion_r356977409"},"pull_request":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/984"}}},"pull_request":{"url":"https://api.github.com/repos/eBay/ebayui-core/pulls/984","id":352090121,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyMDkwMTIx","html_url":"https://github.com/eBay/ebayui-core/pull/984","diff_url":"https://github.com/eBay/ebayui-core/pull/984.diff","patch_url":"https://github.com/eBay/ebayui-core/pull/984.patch","issue_url":"https://api.github.com/repos/eBay/ebayui-core/issues/984","number":984,"state":"open","locked":false,"title":"Upstream combobox custom id","user":{"login":"ETCaton","id":18296249,"node_id":"MDQ6VXNlcjE4Mjk2MjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/18296249?v=4","gravatar_id":"","url":"https://api.github.com/users/ETCaton","html_url":"https://github.com/ETCaton","followers_url":"https://api.github.com/users/ETCaton/followers","following_url":"https://api.github.com/users/ETCaton/following{/other_user}","gists_url":"https://api.github.com/users/ETCaton/gists{/gist_id}","starred_url":"https://api.github.com/users/ETCaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ETCaton/subscriptions","organizations_url":"https://api.github.com/users/ETCaton/orgs","repos_url":"https://api.github.com/users/ETCaton/repos","events_url":"https://api.github.com/users/ETCaton/events{/privacy}","received_events_url":"https://api.github.com/users/ETCaton/received_events","type":"User","site_admin":false},"body":"## Description\r\n<!--- What are the changes? -->\r\nPorted #972 to 5.0.0\r\n#956 \r\n","created_at":"2019-12-11T20:01:28Z","updated_at":"2019-12-12T06:33:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8185447ff200fd680903a1531ea84f5e04a43c01","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ianmcburnie","id":38065,"node_id":"MDQ6VXNlcjM4MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/38065?v=4","gravatar_id":"","url":"https://api.github.com/users/ianmcburnie","html_url":"https://github.com/ianmcburnie","followers_url":"https://api.github.com/users/ianmcburnie/followers","following_url":"https://api.github.com/users/ianmcburnie/following{/other_user}","gists_url":"https://api.github.com/users/ianmcburnie/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcburnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcburnie/subscriptions","organizations_url":"https://api.github.com/users/ianmcburnie/orgs","repos_url":"https://api.github.com/users/ianmcburnie/repos","events_url":"https://api.github.com/users/ianmcburnie/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcburnie/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/984/commits","review_comments_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/984/comments","review_comment_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/issues/984/comments","statuses_url":"https://api.github.com/repos/eBay/ebayui-core/statuses/9e7cfb0a5704e79e46c81179e63b8391f5633228","head":{"label":"eBay:956-upstream-combobox-id","ref":"956-upstream-combobox-id","sha":"9e7cfb0a5704e79e46c81179e63b8391f5633228","user":{"login":"eBay","id":3639281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzkyODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"repo":{"id":123346792,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzNDY3OTI=","name":"ebayui-core","full_name":"eBay/ebayui-core","private":false,"owner":{"login":"eBay","id":3639281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzkyODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eBay/ebayui-core","description":"Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps","fork":false,"url":"https://api.github.com/repos/eBay/ebayui-core","forks_url":"https://api.github.com/repos/eBay/ebayui-core/forks","keys_url":"https://api.github.com/repos/eBay/ebayui-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eBay/ebayui-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eBay/ebayui-core/teams","hooks_url":"https://api.github.com/repos/eBay/ebayui-core/hooks","issue_events_url":"https://api.github.com/repos/eBay/ebayui-core/issues/events{/number}","events_url":"https://api.github.com/repos/eBay/ebayui-core/events","assignees_url":"https://api.github.com/repos/eBay/ebayui-core/assignees{/user}","branches_url":"https://api.github.com/repos/eBay/ebayui-core/branches{/branch}","tags_url":"https://api.github.com/repos/eBay/ebayui-core/tags","blobs_url":"https://api.github.com/repos/eBay/ebayui-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eBay/ebayui-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eBay/ebayui-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eBay/ebayui-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eBay/ebayui-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eBay/ebayui-core/languages","stargazers_url":"https://api.github.com/repos/eBay/ebayui-core/stargazers","contributors_url":"https://api.github.com/repos/eBay/ebayui-core/contributors","subscribers_url":"https://api.github.com/repos/eBay/ebayui-core/subscribers","subscription_url":"https://api.github.com/repos/eBay/ebayui-core/subscription","commits_url":"https://api.github.com/repos/eBay/ebayui-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eBay/ebayui-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eBay/ebayui-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eBay/ebayui-core/contents/{+path}","compare_url":"https://api.github.com/repos/eBay/ebayui-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eBay/ebayui-core/merges","archive_url":"https://api.github.com/repos/eBay/ebayui-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eBay/ebayui-core/downloads","issues_url":"https://api.github.com/repos/eBay/ebayui-core/issues{/number}","pulls_url":"https://api.github.com/repos/eBay/ebayui-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eBay/ebayui-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eBay/ebayui-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eBay/ebayui-core/labels{/name}","releases_url":"https://api.github.com/repos/eBay/ebayui-core/releases{/id}","deployments_url":"https://api.github.com/repos/eBay/ebayui-core/deployments","created_at":"2018-02-28T21:51:53Z","updated_at":"2019-12-09T11:11:26Z","pushed_at":"2019-12-12T06:26:32Z","git_url":"git://github.com/eBay/ebayui-core.git","ssh_url":"git@github.com:eBay/ebayui-core.git","clone_url":"https://github.com/eBay/ebayui-core.git","svn_url":"https://github.com/eBay/ebayui-core","homepage":"https://ebay.github.io/ebayui-core/","size":11757,"stargazers_count":101,"watchers_count":101,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":52,"open_issues":48,"watchers":101,"default_branch":"master"}},"base":{"label":"eBay:5.0.0","ref":"5.0.0","sha":"5b395f22f1a5b97193515c12e53147b23b0b6a4f","user":{"login":"eBay","id":3639281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzkyODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"repo":{"id":123346792,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzNDY3OTI=","name":"ebayui-core","full_name":"eBay/ebayui-core","private":false,"owner":{"login":"eBay","id":3639281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzkyODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eBay/ebayui-core","description":"Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps","fork":false,"url":"https://api.github.com/repos/eBay/ebayui-core","forks_url":"https://api.github.com/repos/eBay/ebayui-core/forks","keys_url":"https://api.github.com/repos/eBay/ebayui-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eBay/ebayui-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eBay/ebayui-core/teams","hooks_url":"https://api.github.com/repos/eBay/ebayui-core/hooks","issue_events_url":"https://api.github.com/repos/eBay/ebayui-core/issues/events{/number}","events_url":"https://api.github.com/repos/eBay/ebayui-core/events","assignees_url":"https://api.github.com/repos/eBay/ebayui-core/assignees{/user}","branches_url":"https://api.github.com/repos/eBay/ebayui-core/branches{/branch}","tags_url":"https://api.github.com/repos/eBay/ebayui-core/tags","blobs_url":"https://api.github.com/repos/eBay/ebayui-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eBay/ebayui-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eBay/ebayui-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eBay/ebayui-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eBay/ebayui-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eBay/ebayui-core/languages","stargazers_url":"https://api.github.com/repos/eBay/ebayui-core/stargazers","contributors_url":"https://api.github.com/repos/eBay/ebayui-core/contributors","subscribers_url":"https://api.github.com/repos/eBay/ebayui-core/subscribers","subscription_url":"https://api.github.com/repos/eBay/ebayui-core/subscription","commits_url":"https://api.github.com/repos/eBay/ebayui-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eBay/ebayui-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eBay/ebayui-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eBay/ebayui-core/contents/{+path}","compare_url":"https://api.github.com/repos/eBay/ebayui-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eBay/ebayui-core/merges","archive_url":"https://api.github.com/repos/eBay/ebayui-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eBay/ebayui-core/downloads","issues_url":"https://api.github.com/repos/eBay/ebayui-core/issues{/number}","pulls_url":"https://api.github.com/repos/eBay/ebayui-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eBay/ebayui-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eBay/ebayui-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eBay/ebayui-core/labels{/name}","releases_url":"https://api.github.com/repos/eBay/ebayui-core/releases{/id}","deployments_url":"https://api.github.com/repos/eBay/ebayui-core/deployments","created_at":"2018-02-28T21:51:53Z","updated_at":"2019-12-09T11:11:26Z","pushed_at":"2019-12-12T06:26:32Z","git_url":"git://github.com/eBay/ebayui-core.git","ssh_url":"git@github.com:eBay/ebayui-core.git","clone_url":"https://github.com/eBay/ebayui-core.git","svn_url":"https://github.com/eBay/ebayui-core","homepage":"https://ebay.github.io/ebayui-core/","size":11757,"stargazers_count":101,"watchers_count":101,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":52,"open_issues":48,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/984"},"html":{"href":"https://github.com/eBay/ebayui-core/pull/984"},"issue":{"href":"https://api.github.com/repos/eBay/ebayui-core/issues/984"},"comments":{"href":"https://api.github.com/repos/eBay/ebayui-core/issues/984/comments"},"review_comments":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/984/comments"},"review_comment":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/984/commits"},"statuses":{"href":"https://api.github.com/repos/eBay/ebayui-core/statuses/9e7cfb0a5704e79e46c81179e63b8391f5633228"}},"author_association":"NONE"}}
{"actor":{"display_login":"agliga"}}