{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/78490","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/78490/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/78490/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/78490/events","html_url":"https://github.com/kubernetes/kubernetes/pull/78490","id":449954298,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzMzc4NDIw","number":78490,"title":"cri: Add termination_grace_period for Pod Sandbox","user":{"login":"mrunalp","id":53798,"node_id":"MDQ6VXNlcjUzNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/53798?v=4","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"labels":[{"id":116719829,"node_id":"MDU6TGFiZWwxMTY3MTk4Mjk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubelet","name":"area/kubelet","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"assignees":[{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2019-05-29T18:22:45Z","updated_at":"2019-05-29T20:49:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/78490","html_url":"https://github.com/kubernetes/kubernetes/pull/78490","diff_url":"https://github.com/kubernetes/kubernetes/pull/78490.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/78490.patch"},"body":"**What type of PR is this?**:\r\n/kind bug\r\n\r\n**What this PR does / why we need it**:\r\nThis PR adds termination_grace_period to the Pod Sandbox in CRI API to handle\r\nsystem shutdowns/reboots gracefully for the pod containers.\r\nOne way to achieve it is by setting the systemd TimeoutStopUSec property when\r\nusing the systemd cgroup manager. \r\nSee #77873 for more details.\r\n\r\n**Which issue(s) this PR fixes**:\r\n\r\nFixes #77873\r\n\r\n```release-note\r\nAdd termination_grace_period to PodSandboxConfig\r\n```\r\n/sig node\r\n/priority important-soon\r\n/cc @derekwaynecarr\r\n/assign @yujuhong\r\n/milestone v1.15\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/497103466","html_url":"https://github.com/kubernetes/kubernetes/pull/78490#issuecomment-497103466","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/78490","id":497103466,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5NzEwMzQ2Ng==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-05-29T20:49:06Z","updated_at":"2019-05-29T20:49:06Z","author_association":"CONTRIBUTOR","body":"@mrunalp: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-gce-100-performance | 6eea5f004ee9d95fe8e980868312e93452c82e70 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/78490/pull-kubernetes-e2e-gce-100-performance/1133801059236450304/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-bazel-test | 5cf6070502edf0c79d3030c3a013d6b68fba8a0c | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/78490/pull-kubernetes-bazel-test/1133824208787214338) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-gce | 5cf6070502edf0c79d3030c3a013d6b68fba8a0c | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/78490/pull-kubernetes-e2e-gce/1133824208791408642/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | 5cf6070502edf0c79d3030c3a013d6b68fba8a0c | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/78490/pull-kubernetes-e2e-gce-device-plugin-gpu/1133824722979524608/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=78490). [Your PR dashboard](https://gubernator.k8s.io/pr/mrunalp). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}