{"action":"created","issue":{"url":"https://api.github.com/repos/janpaepke/ScrollMagic/issues/895","repository_url":"https://api.github.com/repos/janpaepke/ScrollMagic","labels_url":"https://api.github.com/repos/janpaepke/ScrollMagic/issues/895/labels{/name}","comments_url":"https://api.github.com/repos/janpaepke/ScrollMagic/issues/895/comments","events_url":"https://api.github.com/repos/janpaepke/ScrollMagic/issues/895/events","html_url":"https://github.com/janpaepke/ScrollMagic/issues/895","id":449722784,"node_id":"MDU6SXNzdWU0NDk3MjI3ODQ=","number":895,"title":"Modernize setup, fix bundling issues","user":{"login":"edorivai","id":765358,"node_id":"MDQ6VXNlcjc2NTM1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/765358?v=4","gravatar_id":"","url":"https://api.github.com/users/edorivai","html_url":"https://github.com/edorivai","followers_url":"https://api.github.com/users/edorivai/followers","following_url":"https://api.github.com/users/edorivai/following{/other_user}","gists_url":"https://api.github.com/users/edorivai/gists{/gist_id}","starred_url":"https://api.github.com/users/edorivai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edorivai/subscriptions","organizations_url":"https://api.github.com/users/edorivai/orgs","repos_url":"https://api.github.com/users/edorivai/repos","events_url":"https://api.github.com/users/edorivai/events{/privacy}","received_events_url":"https://api.github.com/users/edorivai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-05-29T10:20:45Z","updated_at":"2019-12-22T10:10:51Z","closed_at":null,"author_association":"COLLABORATOR","body":"Hi All :wave: \r\n\r\nI've been joining @janpaepke to take a look at the entire setup of this library, to see if we can modernize things and make sure the lib works with a variety of setups. It should work seemlessly with\r\n- [UMD](https://github.com/umdjs/umd) `<script src='...' />`, `define(['scrollmagic'])`\r\n- [CJS](https://nodejs.org/docs/latest/api/modules.html) `const scrollmagic = require('scrollmagic')`\r\n- [ESM](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import) `import scrollmagic from 'scrollmagic'`\r\n\r\nWork has started in the [`rollup-integration`](https://github.com/janpaepke/ScrollMagic/tree/rollup-integration) branch, but please bear with us as we work out all the kinks. For those interested, we're looking at using [rollup](https://rollupjs.org/guide/en/) for bundling.\r\n\r\nTODO:\r\n\r\n- [x] restructure the code to replace all `//@include`s with esm `import`s\r\n- [ ] drop bower support\r\n- [x] configure build outputs for esm, cjs, and umd\r\n- [ ] configure entry points for plugins\r\n- [ ] use [unpkg](https://unpkg.com/) instead of cdnjs for publishing umd bundles\r\n- [ ] use version in `package.json` as much as possible - try using `npm version` as much as possible instead of gulp versioning mechanism\r\n- [ ] replace custom replacements with `rollup-plugin-replace`\r\n- [ ] replace production-build exclusions with `if(__DEV__)` blocks, which should be removed by uglify for the production builds\r\n- [ ] figure out what to do with plugin warnings, banners\r\n- [ ] replace jshint by prettier+eslint\r\n"},"comment":{"url":"https://api.github.com/repos/janpaepke/ScrollMagic/issues/comments/568248716","html_url":"https://github.com/janpaepke/ScrollMagic/issues/895#issuecomment-568248716","issue_url":"https://api.github.com/repos/janpaepke/ScrollMagic/issues/895","id":568248716,"node_id":"MDEyOklzc3VlQ29tbWVudDU2ODI0ODcxNg==","user":{"login":"ppoulard","id":3876212,"node_id":"MDQ6VXNlcjM4NzYyMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/3876212?v=4","gravatar_id":"","url":"https://api.github.com/users/ppoulard","html_url":"https://github.com/ppoulard","followers_url":"https://api.github.com/users/ppoulard/followers","following_url":"https://api.github.com/users/ppoulard/following{/other_user}","gists_url":"https://api.github.com/users/ppoulard/gists{/gist_id}","starred_url":"https://api.github.com/users/ppoulard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppoulard/subscriptions","organizations_url":"https://api.github.com/users/ppoulard/orgs","repos_url":"https://api.github.com/users/ppoulard/repos","events_url":"https://api.github.com/users/ppoulard/events{/privacy}","received_events_url":"https://api.github.com/users/ppoulard/received_events","type":"User","site_admin":false},"created_at":"2019-12-22T10:10:51Z","updated_at":"2019-12-22T10:10:51Z","author_association":"NONE","body":"👍 \r\n\r\nMay I suggest too :\r\n\r\n- Use classes instead of functions : `var construct = function () {`\r\n- Use typescript instead of js : since all type descriptions are inert comments, they could be set in the code\r\n"}}
{"actor":{"display_login":"ppoulard"}}