{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/3349","repository_url":"https://api.github.com/repos/eclipse/jetty.project","labels_url":"https://api.github.com/repos/eclipse/jetty.project/issues/3349/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/3349/comments","events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/3349/events","html_url":"https://github.com/eclipse/jetty.project/pull/3349","id":409071417,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyMTM4Njkw","number":3349,"title":"Fixes #3332 jetty-maven-plugin - transitive deps in single war project","user":{"login":"mironbalcerzak","id":7910857,"node_id":"MDQ6VXNlcjc5MTA4NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7910857?v=4","gravatar_id":"","url":"https://api.github.com/users/mironbalcerzak","html_url":"https://github.com/mironbalcerzak","followers_url":"https://api.github.com/users/mironbalcerzak/followers","following_url":"https://api.github.com/users/mironbalcerzak/following{/other_user}","gists_url":"https://api.github.com/users/mironbalcerzak/gists{/gist_id}","starred_url":"https://api.github.com/users/mironbalcerzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mironbalcerzak/subscriptions","organizations_url":"https://api.github.com/users/mironbalcerzak/orgs","repos_url":"https://api.github.com/users/mironbalcerzak/repos","events_url":"https://api.github.com/users/mironbalcerzak/events{/privacy}","received_events_url":"https://api.github.com/users/mironbalcerzak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2019-02-12T01:42:10Z","updated_at":"2019-05-29T00:38:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/3349","html_url":"https://github.com/eclipse/jetty.project/pull/3349","diff_url":"https://github.com/eclipse/jetty.project/pull/3349.diff","patch_url":"https://github.com/eclipse/jetty.project/pull/3349.patch"},"body":"Greetings,\r\nPR fixes incorrect dependency resolution in goal jetty:run. \r\nScope of this PR is restricted to fixing dependencies for \"single war\".  (moduleA or moduleB case)\r\n\r\n```\r\nModule A\r\norg.mca.jetty.moduleA.ModuleA_api -> /C:/jettyProject/module-a/module-a-api/target/classes/org/mca/jetty/moduleA/ModuleA_api.class\r\norg.mca.jetty.moduleA.ModuleA_impl -> /C:/jettyProject/module-a/module-a-impl/target/classes/org/mca/jetty/moduleA/ModuleA_impl.class\r\norg.mca.jetty.moduleA.ModuleA_servlet -> /C:/jettyProject/module-a/module-a-war/target/classes/org/mca/jetty/moduleA/ModuleA_servlet.class\r\n```\r\nScanner is triggering hot reload correctly now.\r\n\r\nLogic around overlays is still broken (still depends on \"unpack\" functionality) and will be fixed in future PR.\r\n\r\nFor more info review #3332.\r\n\r\nCheers,\r\n-- mb"},"comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments/496740198","html_url":"https://github.com/eclipse/jetty.project/pull/3349#issuecomment-496740198","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/3349","id":496740198,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5Njc0MDE5OA==","user":{"login":"olamy","id":19728,"node_id":"MDQ6VXNlcjE5NzI4","avatar_url":"https://avatars2.githubusercontent.com/u/19728?v=4","gravatar_id":"","url":"https://api.github.com/users/olamy","html_url":"https://github.com/olamy","followers_url":"https://api.github.com/users/olamy/followers","following_url":"https://api.github.com/users/olamy/following{/other_user}","gists_url":"https://api.github.com/users/olamy/gists{/gist_id}","starred_url":"https://api.github.com/users/olamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olamy/subscriptions","organizations_url":"https://api.github.com/users/olamy/orgs","repos_url":"https://api.github.com/users/olamy/repos","events_url":"https://api.github.com/users/olamy/events{/privacy}","received_events_url":"https://api.github.com/users/olamy/received_events","type":"User","site_admin":false},"created_at":"2019-05-29T00:38:27Z","updated_at":"2019-05-29T00:38:27Z","author_association":"COLLABORATOR","body":"do not use ` git merge `?\r\nthe best is to use `git fetch` then `git rebase`"}}
{"actor":{"display_login":"olamy"}}