{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/17340","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/17340/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/17340/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/17340/events","html_url":"https://github.com/bitcoin/bitcoin/pull/17340","id":516146310,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM1NDQ4MzEw","number":17340,"title":"Tests: speed up fundrawtransaction test","user":{"login":"jnewbery","id":1063656,"node_id":"MDQ6VXNlcjEwNjM2NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-11-01T14:27:33Z","updated_at":"2019-11-01T14:28:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/17340","html_url":"https://github.com/bitcoin/bitcoin/pull/17340","diff_url":"https://github.com/bitcoin/bitcoin/pull/17340.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/17340.patch"},"body":"Builds on #17327. Review that first\r\n\r\nSpeed up rpc_fundrawtransaction.py\r\n\r\nMost of the time in rpc_fundrawtransaction.py is spent waiting for\r\nunconfirmed transactions to propagate. Net processing adds a poisson\r\nrandom delay to the time it will INV transactions with a mean interval\r\nof 5 seconds. Calls like the following:\r\n\r\n```\r\nself.nodes[2].sendrawtransaction(signedTx['hex'])\r\nself.sync_all()\r\nself.nodes[1].generate(1)\r\n````\r\n\r\nwill therefore introduce a delay waiting for the mempools to sync.\r\nInstead just generate the block on the node that sent the transaction:\r\n\r\n```\r\nself.nodes[2].sendrawtransaction(signedTx['hex'])\r\nself.nodes[2].generate(1)\r\n```\r\n\r\nrpc_fundrawtransaction.py is not intended to be a test for transaction\r\nrelay, so it's ok to do this."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/548808211","html_url":"https://github.com/bitcoin/bitcoin/pull/17340#issuecomment-548808211","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/17340","id":548808211,"node_id":"MDEyOklzc3VlQ29tbWVudDU0ODgwODIxMQ==","user":{"login":"jnewbery","id":1063656,"node_id":"MDQ6VXNlcjEwNjM2NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"created_at":"2019-11-01T14:28:13Z","updated_at":"2019-11-01T14:28:13Z","author_association":"MEMBER","body":"h/t to @jonatack for adding logging in #17327. It wouldn't have been obvious where the delays were being introduced without that PR."}}
{"actor":{"display_login":"jnewbery"}}