{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/269950332","pull_request_review_id":219953187,"id":269950332,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTk1MDMzMg==","diff_hunk":"@@ -88,17 +88,29 @@ class OPTICS(BaseEstimator, ClusterMixin):\n \n     cluster_method : string, optional (default='dbscan')\n         The extraction method used to extract clusters using the calculated\n-        reachability and ordering. Possible values are \"dbscan\".\n+        reachability and ordering. Possible values are \"xi\" and \"dbscan\".\n \n     eps : float, optional (default=0.5)\n         The maximum distance between two samples for them to be considered\n-        as in the same neighborhood. Used ony when `cluster_method='dbscan'`.\n+        as in the same neighborhood. Used ony when ``cluster_method='dbscan'``.","path":"sklearn/cluster/optics_.py","position":21,"original_position":21,"commit_id":"4d84f9498cc6dc00bcd7eb6b78e447a142c4951f","original_commit_id":"4d84f9498cc6dc00bcd7eb6b78e447a142c4951f","user":{"login":"kno10","id":3997899,"node_id":"MDQ6VXNlcjM5OTc4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/3997899?v=4","gravatar_id":"","url":"https://api.github.com/users/kno10","html_url":"https://github.com/kno10","followers_url":"https://api.github.com/users/kno10/followers","following_url":"https://api.github.com/users/kno10/following{/other_user}","gists_url":"https://api.github.com/users/kno10/gists{/gist_id}","starred_url":"https://api.github.com/users/kno10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kno10/subscriptions","organizations_url":"https://api.github.com/users/kno10/orgs","repos_url":"https://api.github.com/users/kno10/repos","events_url":"https://api.github.com/users/kno10/events{/privacy}","received_events_url":"https://api.github.com/users/kno10/received_events","type":"User","site_admin":false},"body":"s/ony/only/\r\n\r\nI would not give a default value. The best default would likely be `max_eps`, wouldn't it?","created_at":"2019-03-28T11:03:34Z","updated_at":"2019-03-28T11:03:35Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12077#discussion_r269950332","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12077","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/269950332"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12077#discussion_r269950332"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12077"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12077","id":215639864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjM5ODY0","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12077","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/12077.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/12077.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12077","number":12077,"state":"open","locked":false,"title":"[MRG] OPTICS: add extract_xi method","user":{"login":"adrinjalali","id":1663864,"node_id":"MDQ6VXNlcjE2NjM4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1663864?v=4","gravatar_id":"","url":"https://api.github.com/users/adrinjalali","html_url":"https://github.com/adrinjalali","followers_url":"https://api.github.com/users/adrinjalali/followers","following_url":"https://api.github.com/users/adrinjalali/following{/other_user}","gists_url":"https://api.github.com/users/adrinjalali/gists{/gist_id}","starred_url":"https://api.github.com/users/adrinjalali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrinjalali/subscriptions","organizations_url":"https://api.github.com/users/adrinjalali/orgs","repos_url":"https://api.github.com/users/adrinjalali/repos","events_url":"https://api.github.com/users/adrinjalali/events{/privacy}","received_events_url":"https://api.github.com/users/adrinjalali/received_events","type":"User","site_admin":false},"body":"Related: #12036, #12053, #11677\r\nFixes #12376\r\n\r\nAdding the Xi extraction method to OPTICS.\r\n\r\n@espg, I'll need the `predecessor_` to add that final touch to it. I'm still testing the implementation, but it'll be nice if I could get some feedback. (done)\r\n","created_at":"2018-09-14T15:58:14Z","updated_at":"2019-03-28T11:03:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abb1c34031717741a801b63860b7b3987bf938ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/26","html_url":"https://github.com/scikit-learn/scikit-learn/milestone/26","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/26/labels","id":3421829,"node_id":"MDk6TWlsZXN0b25lMzQyMTgyOQ==","number":26,"title":"0.21","description":"","creator":{"login":"glemaitre","id":7454015,"node_id":"MDQ6VXNlcjc0NTQwMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7454015?v=4","gravatar_id":"","url":"https://api.github.com/users/glemaitre","html_url":"https://github.com/glemaitre","followers_url":"https://api.github.com/users/glemaitre/followers","following_url":"https://api.github.com/users/glemaitre/following{/other_user}","gists_url":"https://api.github.com/users/glemaitre/gists{/gist_id}","starred_url":"https://api.github.com/users/glemaitre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glemaitre/subscriptions","organizations_url":"https://api.github.com/users/glemaitre/orgs","repos_url":"https://api.github.com/users/glemaitre/repos","events_url":"https://api.github.com/users/glemaitre/events{/privacy}","received_events_url":"https://api.github.com/users/glemaitre/received_events","type":"User","site_admin":false},"open_issues":87,"closed_issues":40,"state":"open","created_at":"2018-06-13T12:48:35Z","updated_at":"2019-03-28T05:50:37Z","due_on":"2019-01-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12077/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12077/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12077/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/4d84f9498cc6dc00bcd7eb6b78e447a142c4951f","head":{"label":"adrinjalali:optics/extractXi","ref":"optics/extractXi","sha":"4d84f9498cc6dc00bcd7eb6b78e447a142c4951f","user":{"login":"adrinjalali","id":1663864,"node_id":"MDQ6VXNlcjE2NjM4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1663864?v=4","gravatar_id":"","url":"https://api.github.com/users/adrinjalali","html_url":"https://github.com/adrinjalali","followers_url":"https://api.github.com/users/adrinjalali/followers","following_url":"https://api.github.com/users/adrinjalali/following{/other_user}","gists_url":"https://api.github.com/users/adrinjalali/gists{/gist_id}","starred_url":"https://api.github.com/users/adrinjalali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrinjalali/subscriptions","organizations_url":"https://api.github.com/users/adrinjalali/orgs","repos_url":"https://api.github.com/users/adrinjalali/repos","events_url":"https://api.github.com/users/adrinjalali/events{/privacy}","received_events_url":"https://api.github.com/users/adrinjalali/received_events","type":"User","site_admin":false},"repo":{"id":43740145,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc0MDE0NQ==","name":"scikit-learn","full_name":"adrinjalali/scikit-learn","private":false,"owner":{"login":"adrinjalali","id":1663864,"node_id":"MDQ6VXNlcjE2NjM4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1663864?v=4","gravatar_id":"","url":"https://api.github.com/users/adrinjalali","html_url":"https://github.com/adrinjalali","followers_url":"https://api.github.com/users/adrinjalali/followers","following_url":"https://api.github.com/users/adrinjalali/following{/other_user}","gists_url":"https://api.github.com/users/adrinjalali/gists{/gist_id}","starred_url":"https://api.github.com/users/adrinjalali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrinjalali/subscriptions","organizations_url":"https://api.github.com/users/adrinjalali/orgs","repos_url":"https://api.github.com/users/adrinjalali/repos","events_url":"https://api.github.com/users/adrinjalali/events{/privacy}","received_events_url":"https://api.github.com/users/adrinjalali/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adrinjalali/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/adrinjalali/scikit-learn","forks_url":"https://api.github.com/repos/adrinjalali/scikit-learn/forks","keys_url":"https://api.github.com/repos/adrinjalali/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrinjalali/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrinjalali/scikit-learn/teams","hooks_url":"https://api.github.com/repos/adrinjalali/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/adrinjalali/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/adrinjalali/scikit-learn/events","assignees_url":"https://api.github.com/repos/adrinjalali/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/adrinjalali/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/adrinjalali/scikit-learn/tags","blobs_url":"https://api.github.com/repos/adrinjalali/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrinjalali/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrinjalali/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrinjalali/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrinjalali/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/adrinjalali/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/adrinjalali/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/adrinjalali/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/adrinjalali/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/adrinjalali/scikit-learn/subscription","commits_url":"https://api.github.com/repos/adrinjalali/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrinjalali/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrinjalali/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrinjalali/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrinjalali/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/adrinjalali/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrinjalali/scikit-learn/merges","archive_url":"https://api.github.com/repos/adrinjalali/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrinjalali/scikit-learn/downloads","issues_url":"https://api.github.com/repos/adrinjalali/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/adrinjalali/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/adrinjalali/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/adrinjalali/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrinjalali/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/adrinjalali/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/adrinjalali/scikit-learn/deployments","created_at":"2015-10-06T09:03:13Z","updated_at":"2019-03-26T16:31:51Z","pushed_at":"2019-03-27T20:54:09Z","git_url":"git://github.com/adrinjalali/scikit-learn.git","ssh_url":"git@github.com:adrinjalali/scikit-learn.git","clone_url":"https://github.com/adrinjalali/scikit-learn.git","svn_url":"https://github.com/adrinjalali/scikit-learn","homepage":"http://scikit-learn.org","size":99150,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"3aefc834dce72e850bff48689bea3c7dff5f3fad","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","private":false,"owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2019-03-28T10:23:10Z","pushed_at":"2019-03-28T10:58:38Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":101511,"stargazers_count":34091,"watchers_count":34091,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16712,"mirror_url":null,"archived":false,"open_issues_count":1922,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16712,"open_issues":1922,"watchers":34091,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12077"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12077"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12077"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12077/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12077/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12077/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/4d84f9498cc6dc00bcd7eb6b78e447a142c4951f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kno10"}}