{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments/268108420","pull_request_review_id":217677817,"id":268108420,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODEwODQyMA==","diff_hunk":"@@ -1042,6 +1047,28 @@ protected void appendInlineFeatureCall(XAbstractFeatureCall call, ITreeAppendabl\n \t\tif (prevEnd != formatString.length()) {\n \t\t\tb.append(formatString.substring(prevEnd));\n \t\t}\n+\t\tif (inlineCallNeedsParenthesis) {\n+\t\t\tb.append(\")\");\n+\t\t}\n+\t}\n+\t\n+\tprotected boolean inlineCallNeedsParenthesis(XAbstractFeatureCall call, String formatString) {\n+\t\tString trimmedFormatString = formatString.trim();\n+\t\tif (trimmedFormatString.startsWith(\"(\")) {\n+\t\t\treturn false;\n+\t\t}\n+\t\tif (call.eContainer() instanceof XMemberFeatureCall) {\n+\t\t\tXMemberFeatureCall mfc = (XMemberFeatureCall) call.eContainer();\n+\t\t\tJvmAnnotationReference inlineAnnotation = expressionHelper.findInlineAnnotation(mfc);\n+\t\t\tif (inlineAnnotation != null) {\n+\t\t\t\treturn true;\n+\t\t\t}\n+\t\t\tif (mfc.isExtension()) {\n+\t\t\t\treturn false;\n+\t\t\t}\n+\t\t\treturn !trimmedFormatString.endsWith(\")\");","path":"org.eclipse.xtext.xbase/src/org/eclipse/xtext/xbase/compiler/FeatureCallCompiler.java","position":35,"original_position":35,"commit_id":"eb197c85949de6c2d3f361991908a541afc6f768","original_commit_id":"eb197c85949de6c2d3f361991908a541afc6f768","user":{"login":"szarnekow","id":375492,"node_id":"MDQ6VXNlcjM3NTQ5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/375492?v=4","gravatar_id":"","url":"https://api.github.com/users/szarnekow","html_url":"https://github.com/szarnekow","followers_url":"https://api.github.com/users/szarnekow/followers","following_url":"https://api.github.com/users/szarnekow/following{/other_user}","gists_url":"https://api.github.com/users/szarnekow/gists{/gist_id}","starred_url":"https://api.github.com/users/szarnekow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szarnekow/subscriptions","organizations_url":"https://api.github.com/users/szarnekow/orgs","repos_url":"https://api.github.com/users/szarnekow/repos","events_url":"https://api.github.com/users/szarnekow/events{/privacy}","received_events_url":"https://api.github.com/users/szarnekow/received_events","type":"User","site_admin":false},"body":"I see","created_at":"2019-03-22T10:17:18Z","updated_at":"2019-03-22T10:17:18Z","html_url":"https://github.com/eclipse/xtext-extras/pull/395#discussion_r268108420","pull_request_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/395","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments/268108420"},"html":{"href":"https://github.com/eclipse/xtext-extras/pull/395#discussion_r268108420"},"pull_request":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/395"}},"in_reply_to_id":268105808},"pull_request":{"url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/395","id":263401308,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzNDAxMzA4","html_url":"https://github.com/eclipse/xtext-extras/pull/395","diff_url":"https://github.com/eclipse/xtext-extras/pull/395.diff","patch_url":"https://github.com/eclipse/xtext-extras/pull/395.patch","issue_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/395","number":395,"state":"open","locked":false,"title":"[#394][eclipse/xtext-lib#60] fixed issues with nested inline feature calls","user":{"login":"cdietrich","id":238736,"node_id":"MDQ6VXNlcjIzODczNg==","avatar_url":"https://avatars2.githubusercontent.com/u/238736?v=4","gravatar_id":"","url":"https://api.github.com/users/cdietrich","html_url":"https://github.com/cdietrich","followers_url":"https://api.github.com/users/cdietrich/followers","following_url":"https://api.github.com/users/cdietrich/following{/other_user}","gists_url":"https://api.github.com/users/cdietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/cdietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdietrich/subscriptions","organizations_url":"https://api.github.com/users/cdietrich/orgs","repos_url":"https://api.github.com/users/cdietrich/repos","events_url":"https://api.github.com/users/cdietrich/events{/privacy}","received_events_url":"https://api.github.com/users/cdietrich/received_events","type":"User","site_admin":false},"body":"[#394][eclipse/xtext-lib#60] fixed issues with nested inline feature calls\r\n\r\nSigned-off-by: Christian Dietrich <christian.dietrich@itemis.de>","created_at":"2019-03-21T20:55:56Z","updated_at":"2019-03-22T10:17:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61e3a31310f2968587391e7e021528ee76475c1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/eclipse/xtext-extras/milestones/10","html_url":"https://github.com/eclipse/xtext-extras/milestone/10","labels_url":"https://api.github.com/repos/eclipse/xtext-extras/milestones/10/labels","id":3795576,"node_id":"MDk6TWlsZXN0b25lMzc5NTU3Ng==","number":10,"title":"Release_2.18","description":"","creator":{"login":"cdietrich","id":238736,"node_id":"MDQ6VXNlcjIzODczNg==","avatar_url":"https://avatars2.githubusercontent.com/u/238736?v=4","gravatar_id":"","url":"https://api.github.com/users/cdietrich","html_url":"https://github.com/cdietrich","followers_url":"https://api.github.com/users/cdietrich/followers","following_url":"https://api.github.com/users/cdietrich/following{/other_user}","gists_url":"https://api.github.com/users/cdietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/cdietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdietrich/subscriptions","organizations_url":"https://api.github.com/users/cdietrich/orgs","repos_url":"https://api.github.com/users/cdietrich/repos","events_url":"https://api.github.com/users/cdietrich/events{/privacy}","received_events_url":"https://api.github.com/users/cdietrich/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":5,"state":"open","created_at":"2018-11-05T11:00:51Z","updated_at":"2019-03-22T09:43:11Z","due_on":"2019-06-04T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/395/commits","review_comments_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/395/comments","review_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/395/comments","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/eb197c85949de6c2d3f361991908a541afc6f768","head":{"label":"eclipse:cd_extras_issue394","ref":"cd_extras_issue394","sha":"eb197c85949de6c2d3f361991908a541afc6f768","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":60115647,"node_id":"MDEwOlJlcG9zaXRvcnk2MDExNTY0Nw==","name":"xtext-extras","full_name":"eclipse/xtext-extras","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/xtext-extras","description":"xtext-extras","fork":false,"url":"https://api.github.com/repos/eclipse/xtext-extras","forks_url":"https://api.github.com/repos/eclipse/xtext-extras/forks","keys_url":"https://api.github.com/repos/eclipse/xtext-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/xtext-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/xtext-extras/teams","hooks_url":"https://api.github.com/repos/eclipse/xtext-extras/hooks","issue_events_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/xtext-extras/events","assignees_url":"https://api.github.com/repos/eclipse/xtext-extras/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/xtext-extras/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/xtext-extras/tags","blobs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/xtext-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/xtext-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/xtext-extras/languages","stargazers_url":"https://api.github.com/repos/eclipse/xtext-extras/stargazers","contributors_url":"https://api.github.com/repos/eclipse/xtext-extras/contributors","subscribers_url":"https://api.github.com/repos/eclipse/xtext-extras/subscribers","subscription_url":"https://api.github.com/repos/eclipse/xtext-extras/subscription","commits_url":"https://api.github.com/repos/eclipse/xtext-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/xtext-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/xtext-extras/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/xtext-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/xtext-extras/merges","archive_url":"https://api.github.com/repos/eclipse/xtext-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/xtext-extras/downloads","issues_url":"https://api.github.com/repos/eclipse/xtext-extras/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/xtext-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/xtext-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/xtext-extras/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/xtext-extras/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/xtext-extras/deployments","created_at":"2016-05-31T19:00:27Z","updated_at":"2019-03-22T09:43:23Z","pushed_at":"2019-03-22T09:43:14Z","git_url":"git://github.com/eclipse/xtext-extras.git","ssh_url":"git@github.com:eclipse/xtext-extras.git","clone_url":"https://github.com/eclipse/xtext-extras.git","svn_url":"https://github.com/eclipse/xtext-extras","homepage":null,"size":23199,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":24,"open_issues":36,"watchers":9,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"65eee29dc127c3a21241912b4ad6af8484933624","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":60115647,"node_id":"MDEwOlJlcG9zaXRvcnk2MDExNTY0Nw==","name":"xtext-extras","full_name":"eclipse/xtext-extras","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/xtext-extras","description":"xtext-extras","fork":false,"url":"https://api.github.com/repos/eclipse/xtext-extras","forks_url":"https://api.github.com/repos/eclipse/xtext-extras/forks","keys_url":"https://api.github.com/repos/eclipse/xtext-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/xtext-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/xtext-extras/teams","hooks_url":"https://api.github.com/repos/eclipse/xtext-extras/hooks","issue_events_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/xtext-extras/events","assignees_url":"https://api.github.com/repos/eclipse/xtext-extras/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/xtext-extras/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/xtext-extras/tags","blobs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/xtext-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/xtext-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/xtext-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/xtext-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/xtext-extras/languages","stargazers_url":"https://api.github.com/repos/eclipse/xtext-extras/stargazers","contributors_url":"https://api.github.com/repos/eclipse/xtext-extras/contributors","subscribers_url":"https://api.github.com/repos/eclipse/xtext-extras/subscribers","subscription_url":"https://api.github.com/repos/eclipse/xtext-extras/subscription","commits_url":"https://api.github.com/repos/eclipse/xtext-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/xtext-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/xtext-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/xtext-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/xtext-extras/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/xtext-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/xtext-extras/merges","archive_url":"https://api.github.com/repos/eclipse/xtext-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/xtext-extras/downloads","issues_url":"https://api.github.com/repos/eclipse/xtext-extras/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/xtext-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/xtext-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/xtext-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/xtext-extras/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/xtext-extras/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/xtext-extras/deployments","created_at":"2016-05-31T19:00:27Z","updated_at":"2019-03-22T09:43:23Z","pushed_at":"2019-03-22T09:43:14Z","git_url":"git://github.com/eclipse/xtext-extras.git","ssh_url":"git@github.com:eclipse/xtext-extras.git","clone_url":"https://github.com/eclipse/xtext-extras.git","svn_url":"https://github.com/eclipse/xtext-extras","homepage":null,"size":23199,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":24,"open_issues":36,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/395"},"html":{"href":"https://github.com/eclipse/xtext-extras/pull/395"},"issue":{"href":"https://api.github.com/repos/eclipse/xtext-extras/issues/395"},"comments":{"href":"https://api.github.com/repos/eclipse/xtext-extras/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/xtext-extras/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/xtext-extras/statuses/eb197c85949de6c2d3f361991908a541afc6f768"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"szarnekow"}}