{"action":"created","issue":{"url":"https://api.github.com/repos/advancedtelematic/aktualizr/issues/1362","repository_url":"https://api.github.com/repos/advancedtelematic/aktualizr","labels_url":"https://api.github.com/repos/advancedtelematic/aktualizr/issues/1362/labels{/name}","comments_url":"https://api.github.com/repos/advancedtelematic/aktualizr/issues/1362/comments","events_url":"https://api.github.com/repos/advancedtelematic/aktualizr/issues/1362/events","html_url":"https://github.com/advancedtelematic/aktualizr/pull/1362","id":493913213,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3NzY5MjUy","number":1362,"title":"Revert source code to 2019.5 state","user":{"login":"tkfu","id":4501758,"node_id":"MDQ6VXNlcjQ1MDE3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4501758?v=4","gravatar_id":"","url":"https://api.github.com/users/tkfu","html_url":"https://github.com/tkfu","followers_url":"https://api.github.com/users/tkfu/followers","following_url":"https://api.github.com/users/tkfu/following{/other_user}","gists_url":"https://api.github.com/users/tkfu/gists{/gist_id}","starred_url":"https://api.github.com/users/tkfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkfu/subscriptions","organizations_url":"https://api.github.com/users/tkfu/orgs","repos_url":"https://api.github.com/users/tkfu/repos","events_url":"https://api.github.com/users/tkfu/events{/privacy}","received_events_url":"https://api.github.com/users/tkfu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-09-16T08:32:29Z","updated_at":"2019-09-16T09:51:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/advancedtelematic/aktualizr/pulls/1362","html_url":"https://github.com/advancedtelematic/aktualizr/pull/1362","diff_url":"https://github.com/advancedtelematic/aktualizr/pull/1362.diff","patch_url":"https://github.com/advancedtelematic/aktualizr/pull/1362.patch"},"body":"The 2019.5-docs branch was an attempt to clean up the branch so that it only had the docs-relevant commits in it. This involved a pretty massive cherry-pick, and many of the cherry-picked commits included changes to both code and docs. (I also may have gotten a bit sloppy in resolving merge conflicts outside of the docs directory.)\r\n\r\nThis PR just takes out a shotgun and reverts everything except for the docs directory to the way it was when 2019.5 was released. That's the \"correct\" state for this branch to be in according to our new versioning policy; the only differences between this branch and tag 2019.5 are in the docs directory. (You can also verify that the docs changes are correct by diffing the docs directory on this branch against the docs directory in 2019.05; they're identical.)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/advancedtelematic/aktualizr/issues/comments/531710702","html_url":"https://github.com/advancedtelematic/aktualizr/pull/1362#issuecomment-531710702","issue_url":"https://api.github.com/repos/advancedtelematic/aktualizr/issues/1362","id":531710702,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMTcxMDcwMg==","user":{"login":"tkfu","id":4501758,"node_id":"MDQ6VXNlcjQ1MDE3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4501758?v=4","gravatar_id":"","url":"https://api.github.com/users/tkfu","html_url":"https://github.com/tkfu","followers_url":"https://api.github.com/users/tkfu/followers","following_url":"https://api.github.com/users/tkfu/following{/other_user}","gists_url":"https://api.github.com/users/tkfu/gists{/gist_id}","starred_url":"https://api.github.com/users/tkfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkfu/subscriptions","organizations_url":"https://api.github.com/users/tkfu/orgs","repos_url":"https://api.github.com/users/tkfu/repos","events_url":"https://api.github.com/users/tkfu/events{/privacy}","received_events_url":"https://api.github.com/users/tkfu/received_events","type":"User","site_admin":false},"created_at":"2019-09-16T09:51:57Z","updated_at":"2019-09-16T09:51:57Z","author_association":"MEMBER","body":"I agree that it's confusing, and a rebase and force-push is probably the right thing to do. But I don't think there's a very easy fix that gets the docs for this branch right according to our [new versioning policy](https://github.com/advancedtelematic/adr/blob/master/0007-aktualizr-docs-release-process.md]--which is understandable, because it predates that policy. It's also the first docs branch with the Antora stuff, so it's got a big and messy commit history; there are definitely docs changes mixed into that messy history that don't actually apply to 2019.5.\r\n\r\n> I see commits already in the 2019.5-docs that shouldn't be there, like renaming aktualizr-repo to uptane-generator. I think I can rebase the branch and remove the bits that shouldn't be there in the first place\r\n\r\nIf you feel like it's worth the time to do that, I'd be grateful. My personal evaluation was that it would take an amount of time, close reading, and git fuckery that just wouldn't be worth it for a bit of extra correctness in the docs for an old version. That's why I was willing to just settle for getting this branch to render the current status quo on the docsite, while getting at least the branch name correct and having the code on the branch be the aktualizr-2019.5 code. If we find mistakes that people complain about, or that we think are worth correcting, we can always fix them later."}}
{"actor":{"display_login":"tkfu"}}