{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse-vertx/vert.x/issues/2843","repository_url":"https://api.github.com/repos/eclipse-vertx/vert.x","labels_url":"https://api.github.com/repos/eclipse-vertx/vert.x/issues/2843/labels{/name}","comments_url":"https://api.github.com/repos/eclipse-vertx/vert.x/issues/2843/comments","events_url":"https://api.github.com/repos/eclipse-vertx/vert.x/issues/2843/events","html_url":"https://github.com/eclipse-vertx/vert.x/pull/2843","id":412502729,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0Njk2MDg3","number":2843,"title":"Context tracing - fixes #2842","user":{"login":"vietj","id":225674,"node_id":"MDQ6VXNlcjIyNTY3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/225674?v=4","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"labels":[{"id":234421832,"node_id":"MDU6TGFiZWwyMzQ0MjE4MzI=","url":"https://api.github.com/repos/eclipse-vertx/vert.x/labels/to%20review","name":"to review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/eclipse-vertx/vert.x/milestones/51","html_url":"https://github.com/eclipse-vertx/vert.x/milestone/51","labels_url":"https://api.github.com/repos/eclipse-vertx/vert.x/milestones/51/labels","id":3466549,"node_id":"MDk6TWlsZXN0b25lMzQ2NjU0OQ==","number":51,"title":"4.0.0","description":null,"creator":{"login":"tsegismont","id":1500598,"node_id":"MDQ6VXNlcjE1MDA1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1500598?v=4","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":13,"state":"open","created_at":"2018-07-02T09:51:36Z","updated_at":"2019-02-21T19:46:03Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2019-02-20T16:03:08Z","updated_at":"2019-02-26T09:44:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse-vertx/vert.x/pulls/2843","html_url":"https://github.com/eclipse-vertx/vert.x/pull/2843","diff_url":"https://github.com/eclipse-vertx/vert.x/pull/2843.diff","patch_url":"https://github.com/eclipse-vertx/vert.x/pull/2843.patch"},"body":"See #2842\r\n"},"comment":{"url":"https://api.github.com/repos/eclipse-vertx/vert.x/issues/comments/467369976","html_url":"https://github.com/eclipse-vertx/vert.x/pull/2843#issuecomment-467369976","issue_url":"https://api.github.com/repos/eclipse-vertx/vert.x/issues/2843","id":467369976,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NzM2OTk3Ng==","user":{"login":"adriancole","id":64215,"node_id":"MDQ6VXNlcjY0MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2019-02-26T09:44:57Z","updated_at":"2019-02-26T09:44:57Z","author_association":"NONE","body":"anyway I think you probably get my concern which is that the trace\ninstrumentation will be making data policy decisions and doing that also\nhere mixes config at different layers that which is containable below. it\nis up to you what to do with this feedback\n\nOn Tue, Feb 26, 2019, 5:34 PM Julien Viet <notifications@github.com> wrote:\n\n> @adriancole <https://github.com/adriancole> the client request is\n> actually passed, so the tracer can chose when it's an HttpClientRequest to\n> use it instead of the tags (which is what the brave-tracing does for the\n> moment). If there is a concern about security, we can make passing the\n> http.url configurable in the tracing options for this particular case.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/eclipse-vertx/vert.x/pull/2843#issuecomment-467366160>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAD614mQi8F4RkIs1WGx28JkMxKBfNu9ks5vRP-xgaJpZM4bFjs7>\n> .\n>\n"}}
{"actor":{"display_login":"adriancole"}}