{"action":"created","comment":{"url":"https://api.github.com/repos/kokkos/kokkos/pulls/comments/329219674","pull_request_review_id":294521403,"id":329219674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTIxOTY3NA==","diff_hunk":"@@ -2,5 +2,8 @@\n \n int main(int argc, char** argv) {\n   int thr = omp_get_num_threads();\n-  return 0;\n+  if ( thr > 0 )\n+     return thr;\n+  else\n+     return 0;","path":"cmake/compile_tests/clang_omp.cpp","position":8,"original_position":8,"commit_id":"979a41a5968b32e019fb4ba71709450b349e7892","original_commit_id":"979a41a5968b32e019fb4ba71709450b349e7892","user":{"login":"masterleinad","id":2423533,"node_id":"MDQ6VXNlcjI0MjM1MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"body":"Shouldn't `omp_get_num_threads()` return a positive number on success?\r\nThen,\r\n```\r\nreturn omp_get_num_threads()==0;\r\n```\r\nwould at least return a success status.","created_at":"2019-09-27T19:27:45Z","updated_at":"2019-09-27T19:27:45Z","html_url":"https://github.com/kokkos/kokkos/pull/2398#discussion_r329219674","pull_request_url":"https://api.github.com/repos/kokkos/kokkos/pulls/2398","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/comments/329219674"},"html":{"href":"https://github.com/kokkos/kokkos/pull/2398#discussion_r329219674"},"pull_request":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/2398"}}},"pull_request":{"url":"https://api.github.com/repos/kokkos/kokkos/pulls/2398","id":322286469,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyMjg2NDY5","html_url":"https://github.com/kokkos/kokkos/pull/2398","diff_url":"https://github.com/kokkos/kokkos/pull/2398.diff","patch_url":"https://github.com/kokkos/kokkos/pull/2398.patch","issue_url":"https://api.github.com/repos/kokkos/kokkos/issues/2398","number":2398,"state":"open","locked":false,"title":"Fix issue with unused variable with warnings as errors enabled (Issue #2397)","user":{"login":"jeffmiles63","id":44623162,"node_id":"MDQ6VXNlcjQ0NjIzMTYy","avatar_url":"https://avatars2.githubusercontent.com/u/44623162?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffmiles63","html_url":"https://github.com/jeffmiles63","followers_url":"https://api.github.com/users/jeffmiles63/followers","following_url":"https://api.github.com/users/jeffmiles63/following{/other_user}","gists_url":"https://api.github.com/users/jeffmiles63/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmiles63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmiles63/subscriptions","organizations_url":"https://api.github.com/users/jeffmiles63/orgs","repos_url":"https://api.github.com/users/jeffmiles63/repos","events_url":"https://api.github.com/users/jeffmiles63/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmiles63/received_events","type":"User","site_admin":false},"body":"must use the thr variable or -Werror will cause it to fail\r\n\r\nIssue #2397 ","created_at":"2019-09-27T18:54:54Z","updated_at":"2019-09-27T19:27:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85bbbdf2b2153bfb98fae74f45bd32db33022970","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kokkos/kokkos/pulls/2398/commits","review_comments_url":"https://api.github.com/repos/kokkos/kokkos/pulls/2398/comments","review_comment_url":"https://api.github.com/repos/kokkos/kokkos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kokkos/kokkos/issues/2398/comments","statuses_url":"https://api.github.com/repos/kokkos/kokkos/statuses/979a41a5968b32e019fb4ba71709450b349e7892","head":{"label":"jeffmiles63:issue-2397","ref":"issue-2397","sha":"979a41a5968b32e019fb4ba71709450b349e7892","user":{"login":"jeffmiles63","id":44623162,"node_id":"MDQ6VXNlcjQ0NjIzMTYy","avatar_url":"https://avatars2.githubusercontent.com/u/44623162?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffmiles63","html_url":"https://github.com/jeffmiles63","followers_url":"https://api.github.com/users/jeffmiles63/followers","following_url":"https://api.github.com/users/jeffmiles63/following{/other_user}","gists_url":"https://api.github.com/users/jeffmiles63/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmiles63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmiles63/subscriptions","organizations_url":"https://api.github.com/users/jeffmiles63/orgs","repos_url":"https://api.github.com/users/jeffmiles63/repos","events_url":"https://api.github.com/users/jeffmiles63/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmiles63/received_events","type":"User","site_admin":false},"repo":{"id":208150481,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgxNTA0ODE=","name":"kokkos","full_name":"jeffmiles63/kokkos","private":false,"owner":{"login":"jeffmiles63","id":44623162,"node_id":"MDQ6VXNlcjQ0NjIzMTYy","avatar_url":"https://avatars2.githubusercontent.com/u/44623162?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffmiles63","html_url":"https://github.com/jeffmiles63","followers_url":"https://api.github.com/users/jeffmiles63/followers","following_url":"https://api.github.com/users/jeffmiles63/following{/other_user}","gists_url":"https://api.github.com/users/jeffmiles63/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmiles63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmiles63/subscriptions","organizations_url":"https://api.github.com/users/jeffmiles63/orgs","repos_url":"https://api.github.com/users/jeffmiles63/repos","events_url":"https://api.github.com/users/jeffmiles63/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmiles63/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeffmiles63/kokkos","description":"Kokkos Development fork used for Bug fixes and Enhancements intended to merge into kokkos/kokkos.git","fork":true,"url":"https://api.github.com/repos/jeffmiles63/kokkos","forks_url":"https://api.github.com/repos/jeffmiles63/kokkos/forks","keys_url":"https://api.github.com/repos/jeffmiles63/kokkos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffmiles63/kokkos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffmiles63/kokkos/teams","hooks_url":"https://api.github.com/repos/jeffmiles63/kokkos/hooks","issue_events_url":"https://api.github.com/repos/jeffmiles63/kokkos/issues/events{/number}","events_url":"https://api.github.com/repos/jeffmiles63/kokkos/events","assignees_url":"https://api.github.com/repos/jeffmiles63/kokkos/assignees{/user}","branches_url":"https://api.github.com/repos/jeffmiles63/kokkos/branches{/branch}","tags_url":"https://api.github.com/repos/jeffmiles63/kokkos/tags","blobs_url":"https://api.github.com/repos/jeffmiles63/kokkos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffmiles63/kokkos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffmiles63/kokkos/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffmiles63/kokkos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffmiles63/kokkos/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffmiles63/kokkos/languages","stargazers_url":"https://api.github.com/repos/jeffmiles63/kokkos/stargazers","contributors_url":"https://api.github.com/repos/jeffmiles63/kokkos/contributors","subscribers_url":"https://api.github.com/repos/jeffmiles63/kokkos/subscribers","subscription_url":"https://api.github.com/repos/jeffmiles63/kokkos/subscription","commits_url":"https://api.github.com/repos/jeffmiles63/kokkos/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffmiles63/kokkos/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffmiles63/kokkos/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffmiles63/kokkos/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffmiles63/kokkos/contents/{+path}","compare_url":"https://api.github.com/repos/jeffmiles63/kokkos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffmiles63/kokkos/merges","archive_url":"https://api.github.com/repos/jeffmiles63/kokkos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffmiles63/kokkos/downloads","issues_url":"https://api.github.com/repos/jeffmiles63/kokkos/issues{/number}","pulls_url":"https://api.github.com/repos/jeffmiles63/kokkos/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffmiles63/kokkos/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffmiles63/kokkos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffmiles63/kokkos/labels{/name}","releases_url":"https://api.github.com/repos/jeffmiles63/kokkos/releases{/id}","deployments_url":"https://api.github.com/repos/jeffmiles63/kokkos/deployments","created_at":"2019-09-12T21:35:58Z","updated_at":"2019-09-12T21:37:08Z","pushed_at":"2019-09-27T19:23:33Z","git_url":"git://github.com/jeffmiles63/kokkos.git","ssh_url":"git@github.com:jeffmiles63/kokkos.git","clone_url":"https://github.com/jeffmiles63/kokkos.git","svn_url":"https://github.com/jeffmiles63/kokkos","homepage":"","size":11947,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kokkos:develop","ref":"develop","sha":"445c17625fe6dcfa8ddf98046301a648550c5738","user":{"login":"kokkos","id":10199860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTk5ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/10199860?v=4","gravatar_id":"","url":"https://api.github.com/users/kokkos","html_url":"https://github.com/kokkos","followers_url":"https://api.github.com/users/kokkos/followers","following_url":"https://api.github.com/users/kokkos/following{/other_user}","gists_url":"https://api.github.com/users/kokkos/gists{/gist_id}","starred_url":"https://api.github.com/users/kokkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokkos/subscriptions","organizations_url":"https://api.github.com/users/kokkos/orgs","repos_url":"https://api.github.com/users/kokkos/repos","events_url":"https://api.github.com/users/kokkos/events{/privacy}","received_events_url":"https://api.github.com/users/kokkos/received_events","type":"Organization","site_admin":false},"repo":{"id":33634359,"node_id":"MDEwOlJlcG9zaXRvcnkzMzYzNDM1OQ==","name":"kokkos","full_name":"kokkos/kokkos","private":false,"owner":{"login":"kokkos","id":10199860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTk5ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/10199860?v=4","gravatar_id":"","url":"https://api.github.com/users/kokkos","html_url":"https://github.com/kokkos","followers_url":"https://api.github.com/users/kokkos/followers","following_url":"https://api.github.com/users/kokkos/following{/other_user}","gists_url":"https://api.github.com/users/kokkos/gists{/gist_id}","starred_url":"https://api.github.com/users/kokkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokkos/subscriptions","organizations_url":"https://api.github.com/users/kokkos/orgs","repos_url":"https://api.github.com/users/kokkos/repos","events_url":"https://api.github.com/users/kokkos/events{/privacy}","received_events_url":"https://api.github.com/users/kokkos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kokkos/kokkos","description":"Kokkos C++ Performance Portability Programming EcoSystem: The Programming Model - Parallel Execution and Memory Abstraction","fork":false,"url":"https://api.github.com/repos/kokkos/kokkos","forks_url":"https://api.github.com/repos/kokkos/kokkos/forks","keys_url":"https://api.github.com/repos/kokkos/kokkos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kokkos/kokkos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kokkos/kokkos/teams","hooks_url":"https://api.github.com/repos/kokkos/kokkos/hooks","issue_events_url":"https://api.github.com/repos/kokkos/kokkos/issues/events{/number}","events_url":"https://api.github.com/repos/kokkos/kokkos/events","assignees_url":"https://api.github.com/repos/kokkos/kokkos/assignees{/user}","branches_url":"https://api.github.com/repos/kokkos/kokkos/branches{/branch}","tags_url":"https://api.github.com/repos/kokkos/kokkos/tags","blobs_url":"https://api.github.com/repos/kokkos/kokkos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kokkos/kokkos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kokkos/kokkos/git/refs{/sha}","trees_url":"https://api.github.com/repos/kokkos/kokkos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kokkos/kokkos/statuses/{sha}","languages_url":"https://api.github.com/repos/kokkos/kokkos/languages","stargazers_url":"https://api.github.com/repos/kokkos/kokkos/stargazers","contributors_url":"https://api.github.com/repos/kokkos/kokkos/contributors","subscribers_url":"https://api.github.com/repos/kokkos/kokkos/subscribers","subscription_url":"https://api.github.com/repos/kokkos/kokkos/subscription","commits_url":"https://api.github.com/repos/kokkos/kokkos/commits{/sha}","git_commits_url":"https://api.github.com/repos/kokkos/kokkos/git/commits{/sha}","comments_url":"https://api.github.com/repos/kokkos/kokkos/comments{/number}","issue_comment_url":"https://api.github.com/repos/kokkos/kokkos/issues/comments{/number}","contents_url":"https://api.github.com/repos/kokkos/kokkos/contents/{+path}","compare_url":"https://api.github.com/repos/kokkos/kokkos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kokkos/kokkos/merges","archive_url":"https://api.github.com/repos/kokkos/kokkos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kokkos/kokkos/downloads","issues_url":"https://api.github.com/repos/kokkos/kokkos/issues{/number}","pulls_url":"https://api.github.com/repos/kokkos/kokkos/pulls{/number}","milestones_url":"https://api.github.com/repos/kokkos/kokkos/milestones{/number}","notifications_url":"https://api.github.com/repos/kokkos/kokkos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kokkos/kokkos/labels{/name}","releases_url":"https://api.github.com/repos/kokkos/kokkos/releases{/id}","deployments_url":"https://api.github.com/repos/kokkos/kokkos/deployments","created_at":"2015-04-08T21:55:55Z","updated_at":"2019-09-24T23:02:21Z","pushed_at":"2019-09-27T19:23:34Z","git_url":"git://github.com/kokkos/kokkos.git","ssh_url":"git@github.com:kokkos/kokkos.git","clone_url":"https://github.com/kokkos/kokkos.git","svn_url":"https://github.com/kokkos/kokkos","homepage":"","size":11891,"stargazers_count":457,"watchers_count":457,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":287,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":141,"open_issues":287,"watchers":457,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/2398"},"html":{"href":"https://github.com/kokkos/kokkos/pull/2398"},"issue":{"href":"https://api.github.com/repos/kokkos/kokkos/issues/2398"},"comments":{"href":"https://api.github.com/repos/kokkos/kokkos/issues/2398/comments"},"review_comments":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/2398/comments"},"review_comment":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/2398/commits"},"statuses":{"href":"https://api.github.com/repos/kokkos/kokkos/statuses/979a41a5968b32e019fb4ba71709450b349e7892"}},"author_association":"NONE"}}
{"actor":{"display_login":"masterleinad"}}