{"action":"created","issue":{"url":"https://api.github.com/repos/gajus/lightship/issues/5","repository_url":"https://api.github.com/repos/gajus/lightship","labels_url":"https://api.github.com/repos/gajus/lightship/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/gajus/lightship/issues/5/comments","events_url":"https://api.github.com/repos/gajus/lightship/issues/5/events","html_url":"https://github.com/gajus/lightship/issues/5","id":396285801,"node_id":"MDU6SXNzdWUzOTYyODU4MDE=","number":5,"title":"`Stop` does not properly wait for the server to close","user":{"login":"dcherman","id":976608,"node_id":"MDQ6VXNlcjk3NjYwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/976608?v=4","gravatar_id":"","url":"https://api.github.com/users/dcherman","html_url":"https://github.com/dcherman","followers_url":"https://api.github.com/users/dcherman/followers","following_url":"https://api.github.com/users/dcherman/following{/other_user}","gists_url":"https://api.github.com/users/dcherman/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherman/subscriptions","organizations_url":"https://api.github.com/users/dcherman/orgs","repos_url":"https://api.github.com/users/dcherman/repos","events_url":"https://api.github.com/users/dcherman/events{/privacy}","received_events_url":"https://api.github.com/users/dcherman/received_events","type":"User","site_admin":false},"labels":[{"id":1182102346,"node_id":"MDU6TGFiZWwxMTgyMTAyMzQ2","url":"https://api.github.com/repos/gajus/lightship/labels/released","name":"released","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2019-01-06T19:17:56Z","updated_at":"2019-11-05T10:17:42Z","closed_at":"2019-01-06T20:24:02Z","author_association":"NONE","body":"Thanks for providing this lib, I was about to write something like this when I saw you mention this in the k8s slack channel :)\r\n\r\nWas looking through the code and noticed that the `stop` method does not properly wait for the server to close since no callback is provided.  Since the method was marked `async`, it seems like you had intended for it to wait.\r\n\r\nhttps://github.com/gajus/lightship/blob/c45367275ddccdd1d2df4f4db9839f0f3e3e5822/src/factories/createLightship.js#L133"},"comment":{"url":"https://api.github.com/repos/gajus/lightship/issues/comments/549758421","html_url":"https://github.com/gajus/lightship/issues/5#issuecomment-549758421","issue_url":"https://api.github.com/repos/gajus/lightship/issues/5","id":549758421,"node_id":"MDEyOklzc3VlQ29tbWVudDU0OTc1ODQyMQ==","user":{"login":"gajus","id":973543,"node_id":"MDQ6VXNlcjk3MzU0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/973543?v=4","gravatar_id":"","url":"https://api.github.com/users/gajus","html_url":"https://github.com/gajus","followers_url":"https://api.github.com/users/gajus/followers","following_url":"https://api.github.com/users/gajus/following{/other_user}","gists_url":"https://api.github.com/users/gajus/gists{/gist_id}","starred_url":"https://api.github.com/users/gajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajus/subscriptions","organizations_url":"https://api.github.com/users/gajus/orgs","repos_url":"https://api.github.com/users/gajus/repos","events_url":"https://api.github.com/users/gajus/events{/privacy}","received_events_url":"https://api.github.com/users/gajus/received_events","type":"User","site_admin":false},"created_at":"2019-11-05T10:17:41Z","updated_at":"2019-11-05T10:17:41Z","author_association":"OWNER","body":"Just do:\r\n\r\n```js\r\nregisterShutdownHandler(async () => {\r\n  await Promise.all([\r\n    userCollectionOfShutdownHandlers,\r\n  ]);\r\n});\r\n\r\n```\r\n\r\nif you need parallelism."}}
{"actor":{"display_login":"gajus"}}