{"action":"created","issue":{"url":"https://api.github.com/repos/wherebyus/general-tasks/issues/1280","repository_url":"https://api.github.com/repos/wherebyus/general-tasks","labels_url":"https://api.github.com/repos/wherebyus/general-tasks/issues/1280/labels{/name}","comments_url":"https://api.github.com/repos/wherebyus/general-tasks/issues/1280/comments","events_url":"https://api.github.com/repos/wherebyus/general-tasks/issues/1280/events","html_url":"https://github.com/wherebyus/general-tasks/issues/1280","id":442046318,"node_id":"MDU6SXNzdWU0NDIwNDYzMTg=","number":1280,"title":"Latest newsletters don't show on Production","user":{"login":"ErnieAtLYD","id":33945,"node_id":"MDQ6VXNlcjMzOTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/33945?v=4","gravatar_id":"","url":"https://api.github.com/users/ErnieAtLYD","html_url":"https://github.com/ErnieAtLYD","followers_url":"https://api.github.com/users/ErnieAtLYD/followers","following_url":"https://api.github.com/users/ErnieAtLYD/following{/other_user}","gists_url":"https://api.github.com/users/ErnieAtLYD/gists{/gist_id}","starred_url":"https://api.github.com/users/ErnieAtLYD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErnieAtLYD/subscriptions","organizations_url":"https://api.github.com/users/ErnieAtLYD/orgs","repos_url":"https://api.github.com/users/ErnieAtLYD/repos","events_url":"https://api.github.com/users/ErnieAtLYD/events{/privacy}","received_events_url":"https://api.github.com/users/ErnieAtLYD/received_events","type":"User","site_admin":false},"labels":[{"id":1156977881,"node_id":"MDU6TGFiZWwxMTU2OTc3ODgx","url":"https://api.github.com/repos/wherebyus/general-tasks/labels/Product:%20Site","name":"Product: Site","color":"bfdadc","default":false},{"id":991948327,"node_id":"MDU6TGFiZWw5OTE5NDgzMjc=","url":"https://api.github.com/repos/wherebyus/general-tasks/labels/Severity:%20Medium","name":"Severity: Medium","color":"fef2c0","default":false},{"id":990769466,"node_id":"MDU6TGFiZWw5OTA3Njk0NjY=","url":"https://api.github.com/repos/wherebyus/general-tasks/labels/Type:%20Bug","name":"Type: Bug","color":"d73a4a","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-05-09T04:40:32Z","updated_at":"2019-05-17T15:16:01Z","closed_at":null,"author_association":"MEMBER","body":"### Reproduction steps\r\n1. Go to a page such as https://thenewtropic.com/what-are-your-questions-about-miamis-little-haiti-neighborhood/ on your browser\r\n2. Look at \"Latest Newsletters\"\r\n\r\n### Expected\r\nA listing of the latest newsletters should appear\r\n\r\n### Actual\r\nThere's a JS error.\r\n```\r\nUncaught TypeError: dateString.getMonth is not a function\r\n    at Object.<anonymous> ((index):352)\r\n    at Function.each (jquery.min.js?ver=3.2.1:2)\r\n    at Object.success ((index):334)\r\n    at i (jquery.min.js?ver=3.2.1:2)\r\n    at Object.fireWith [as resolveWith] (jquery.min.js?ver=3.2.1:2)\r\n    at A (jquery.min.js?ver=3.2.1:4)\r\n    at XMLHttpRequest.<anonymous> (jquery.min.js?ver=3.2.1:4)\r\n```\r\n\r\nViewing the code itself:\r\n```\r\n$.each(data, function(index, newsletter) {\r\n    const dateString = newsletter.datePublishedTimestamp;\r\n            const monthNames = [\r\n              'January',\r\n              'February',\r\n              'March',\r\n              'April',\r\n              'May',\r\n              'June',\r\n              'July',\r\n              'August',\r\n              'September',\r\n              'October',\r\n              'November',\r\n              'December',\r\n            ];\r\n\tmarkup += `\r\n\t<li style=\"list-style: none;\">\r\n\t\t<span class=\"newsletter-date\">${monthNames[dateString.getMonth()]} ${dateString.getDay()} &mdash;</span>\r\n\t\t<a href=\"/newsletter/${newsletter.slug}\">\r\n\t\t\t${newsletter.subject}\r\n\t\t</a>\r\n\t</li>\r\n`;\r\n});\r\n```"},"comment":{"url":"https://api.github.com/repos/wherebyus/general-tasks/issues/comments/493491337","html_url":"https://github.com/wherebyus/general-tasks/issues/1280#issuecomment-493491337","issue_url":"https://api.github.com/repos/wherebyus/general-tasks/issues/1280","id":493491337,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MzQ5MTMzNw==","user":{"login":"michaelschofield","id":1489144,"node_id":"MDQ6VXNlcjE0ODkxNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1489144?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelschofield","html_url":"https://github.com/michaelschofield","followers_url":"https://api.github.com/users/michaelschofield/followers","following_url":"https://api.github.com/users/michaelschofield/following{/other_user}","gists_url":"https://api.github.com/users/michaelschofield/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelschofield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelschofield/subscriptions","organizations_url":"https://api.github.com/users/michaelschofield/orgs","repos_url":"https://api.github.com/users/michaelschofield/repos","events_url":"https://api.github.com/users/michaelschofield/events{/privacy}","received_events_url":"https://api.github.com/users/michaelschofield/received_events","type":"User","site_admin":false},"created_at":"2019-05-17T15:16:01Z","updated_at":"2019-05-17T15:16:01Z","author_association":"CONTRIBUTOR","body":"@carogea @ErnieAtLYD In the spirit of reduce to less-is-more as we gradually build new features /d esigns / things for the homepages, what if we just _removed the latest newsletters_ there? The c2a is still there, although maybe we take that away too. \n\nI'd be interested in stripping down to the barest need of the page until what the page is suppose to do is done really well, reduce the overall complexity of this template, etc. \n\nI could always fix the latest newsletters, but I doubt we need it. It's one more call ajax call (written with jquery), one more touchpoint. Does its value to the company outweigh the cost of the technical debt?"}}
{"actor":{"display_login":"michaelschofield"}}