{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/10633","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/10633/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/10633/comments","events_url":"https://api.github.com/repos/coq/coq/issues/10633/events","html_url":"https://github.com/coq/coq/pull/10633","id":477824682,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1MDcwMTI5","number":10633,"title":"Ltac2: substitution in notations","user":{"login":"vbgl","id":2612464,"node_id":"MDQ6VXNlcjI2MTI0NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2612464?v=4","gravatar_id":"","url":"https://api.github.com/users/vbgl","html_url":"https://github.com/vbgl","followers_url":"https://api.github.com/users/vbgl/followers","following_url":"https://api.github.com/users/vbgl/following{/other_user}","gists_url":"https://api.github.com/users/vbgl/gists{/gist_id}","starred_url":"https://api.github.com/users/vbgl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbgl/subscriptions","organizations_url":"https://api.github.com/users/vbgl/orgs","repos_url":"https://api.github.com/users/vbgl/repos","events_url":"https://api.github.com/users/vbgl/events{/privacy}","received_events_url":"https://api.github.com/users/vbgl/received_events","type":"User","site_admin":false},"labels":[{"id":662198547,"node_id":"MDU6TGFiZWw2NjIxOTg1NDc=","url":"https://api.github.com/repos/coq/coq/labels/needs:%20squashing","name":"needs: squashing","color":"d4c5d0","default":false},{"id":1342769602,"node_id":"MDU6TGFiZWwxMzQyNzY5NjAy","url":"https://api.github.com/repos/coq/coq/labels/part:%20ltac2","name":"part: ltac2","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2019-08-07T09:52:15Z","updated_at":"2019-09-02T13:30:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/10633","html_url":"https://github.com/coq/coq/pull/10633","diff_url":"https://github.com/coq/coq/pull/10633.diff","patch_url":"https://github.com/coq/coq/pull/10633.patch"},"body":"This implements substitution for notations using ltac2 tactic-in-terms. Substitution only occurs within `constr:` and `open_constr:` antiquotiations; in particular it cannot occur in plain Ltac2 code so substitution under (Ltac2) bindings is safe.\r\n\r\nSubstitution itself is not implemented here: we only insert let-bindings.\r\n\r\nSuggestions welcome on what to do about the few “assert false”.\r\n\r\nFixes #10615 \r\n\r\n- [x] Added / updated test-suite\r\n- [x] Entry added in the changelog (see https://github.com/coq/coq/tree/master/doc/changelog#unreleased-changelog for details).\r\n\r\ncc/ @ppedrot"},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/527149051","html_url":"https://github.com/coq/coq/pull/10633#issuecomment-527149051","issue_url":"https://api.github.com/repos/coq/coq/issues/10633","id":527149051,"node_id":"MDEyOklzc3VlQ29tbWVudDUyNzE0OTA1MQ==","user":{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"created_at":"2019-09-02T13:30:02Z","updated_at":"2019-09-02T13:30:02Z","author_association":"MEMBER","body":"@ppedrot any chance you can help a bit with this?"}}
{"actor":{"display_login":"maximedenes"}}