{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/342377321","pull_request_review_id":311495402,"id":342377321,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MjM3NzMyMQ==","diff_hunk":"@@ -270,31 +270,25 @@ func (c *SyntheticServiceEntryController) configStoreUpdate(resources []*sink.Ob\n \t\t\tsvcChangeByNamespace[conf.Namespace] = struct{}{}\n \t\t\tcontinue\n \t\t}\n-\n-\t\t// this is done before updating internal cache\n-\t\toldEpVersion := c.endpointVersion(conf.Namespace, conf.Name)\n-\t\tnewEpVersion := version(conf.Annotations, endpointKey)\n-\t\tif oldEpVersion != newEpVersion {\n-\t\t\tif err := c.edsUpdate(conf); err != nil {","path":"pilot/pkg/config/coredatamodel/syntheticserviceentrycontroller.go","position":9,"original_position":9,"commit_id":"a9aee2adbca0260d4990232d737c37017f144ff8","original_commit_id":"a9aee2adbca0260d4990232d737c37017f144ff8","user":{"login":"ramaraochavali","id":17204904,"node_id":"MDQ6VXNlcjE3MjA0OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/17204904?v=4","gravatar_id":"","url":"https://api.github.com/users/ramaraochavali","html_url":"https://github.com/ramaraochavali","followers_url":"https://api.github.com/users/ramaraochavali/followers","following_url":"https://api.github.com/users/ramaraochavali/following{/other_user}","gists_url":"https://api.github.com/users/ramaraochavali/gists{/gist_id}","starred_url":"https://api.github.com/users/ramaraochavali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramaraochavali/subscriptions","organizations_url":"https://api.github.com/users/ramaraochavali/orgs","repos_url":"https://api.github.com/users/ramaraochavali/repos","events_url":"https://api.github.com/users/ramaraochavali/events{/privacy}","received_events_url":"https://api.github.com/users/ramaraochavali/received_events","type":"User","site_admin":false},"body":"Yes. That is what we have to do. But it is not working for SSE. See the TODO below and  #18625 ","created_at":"2019-11-05T04:23:42Z","updated_at":"2019-11-05T04:23:43Z","html_url":"https://github.com/istio/istio/pull/18574#discussion_r342377321","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/18574","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/342377321"},"html":{"href":"https://github.com/istio/istio/pull/18574#discussion_r342377321"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/18574"}},"in_reply_to_id":342367519},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/18574","id":335711788,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM1NzExNzg4","html_url":"https://github.com/istio/istio/pull/18574","diff_url":"https://github.com/istio/istio/pull/18574.diff","patch_url":"https://github.com/istio/istio/pull/18574.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/18574","number":18574,"state":"open","locked":false,"title":"eds: do not trigger continuous full pushes when a pod is in crash loop","user":{"login":"ramaraochavali","id":17204904,"node_id":"MDQ6VXNlcjE3MjA0OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/17204904?v=4","gravatar_id":"","url":"https://api.github.com/users/ramaraochavali","html_url":"https://github.com/ramaraochavali","followers_url":"https://api.github.com/users/ramaraochavali/followers","following_url":"https://api.github.com/users/ramaraochavali/following{/other_user}","gists_url":"https://api.github.com/users/ramaraochavali/gists{/gist_id}","starred_url":"https://api.github.com/users/ramaraochavali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramaraochavali/subscriptions","organizations_url":"https://api.github.com/users/ramaraochavali/orgs","repos_url":"https://api.github.com/users/ramaraochavali/repos","events_url":"https://api.github.com/users/ramaraochavali/events{/privacy}","received_events_url":"https://api.github.com/users/ramaraochavali/received_events","type":"User","site_admin":false},"body":"Prevents full push being triggered when a pod is in crash loop and thus its endpoints flipflop between 0 and 1. Fixes https://github.com/istio/istio/issues/13822","created_at":"2019-11-02T03:37:20Z","updated_at":"2019-11-05T04:23:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6264458a77ec993c209ef5f22ff8d39c1a4537b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":735781806,"node_id":"MDU6TGFiZWw3MzU3ODE4MDY=","url":"https://api.github.com/repos/istio/istio/labels/area/networking","name":"area/networking","color":"0e8a16","default":false},{"id":1475126481,"node_id":"MDU6TGFiZWwxNDc1MTI2NDgx","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":1448953239,"node_id":"MDU6TGFiZWwxNDQ4OTUzMjM5","url":"https://api.github.com/repos/istio/istio/labels/size/L","name":"size/L","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/18574/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/18574/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/18574/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/a9aee2adbca0260d4990232d737c37017f144ff8","head":{"label":"ramaraochavali:fix/eds_full_push","ref":"fix/eds_full_push","sha":"a9aee2adbca0260d4990232d737c37017f144ff8","user":{"login":"ramaraochavali","id":17204904,"node_id":"MDQ6VXNlcjE3MjA0OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/17204904?v=4","gravatar_id":"","url":"https://api.github.com/users/ramaraochavali","html_url":"https://github.com/ramaraochavali","followers_url":"https://api.github.com/users/ramaraochavali/followers","following_url":"https://api.github.com/users/ramaraochavali/following{/other_user}","gists_url":"https://api.github.com/users/ramaraochavali/gists{/gist_id}","starred_url":"https://api.github.com/users/ramaraochavali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramaraochavali/subscriptions","organizations_url":"https://api.github.com/users/ramaraochavali/orgs","repos_url":"https://api.github.com/users/ramaraochavali/repos","events_url":"https://api.github.com/users/ramaraochavali/events{/privacy}","received_events_url":"https://api.github.com/users/ramaraochavali/received_events","type":"User","site_admin":false},"repo":{"id":139224975,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyMjQ5NzU=","name":"istio","full_name":"ramaraochavali/istio","private":false,"owner":{"login":"ramaraochavali","id":17204904,"node_id":"MDQ6VXNlcjE3MjA0OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/17204904?v=4","gravatar_id":"","url":"https://api.github.com/users/ramaraochavali","html_url":"https://github.com/ramaraochavali","followers_url":"https://api.github.com/users/ramaraochavali/followers","following_url":"https://api.github.com/users/ramaraochavali/following{/other_user}","gists_url":"https://api.github.com/users/ramaraochavali/gists{/gist_id}","starred_url":"https://api.github.com/users/ramaraochavali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramaraochavali/subscriptions","organizations_url":"https://api.github.com/users/ramaraochavali/orgs","repos_url":"https://api.github.com/users/ramaraochavali/repos","events_url":"https://api.github.com/users/ramaraochavali/events{/privacy}","received_events_url":"https://api.github.com/users/ramaraochavali/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ramaraochavali/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/ramaraochavali/istio","forks_url":"https://api.github.com/repos/ramaraochavali/istio/forks","keys_url":"https://api.github.com/repos/ramaraochavali/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramaraochavali/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramaraochavali/istio/teams","hooks_url":"https://api.github.com/repos/ramaraochavali/istio/hooks","issue_events_url":"https://api.github.com/repos/ramaraochavali/istio/issues/events{/number}","events_url":"https://api.github.com/repos/ramaraochavali/istio/events","assignees_url":"https://api.github.com/repos/ramaraochavali/istio/assignees{/user}","branches_url":"https://api.github.com/repos/ramaraochavali/istio/branches{/branch}","tags_url":"https://api.github.com/repos/ramaraochavali/istio/tags","blobs_url":"https://api.github.com/repos/ramaraochavali/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramaraochavali/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramaraochavali/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramaraochavali/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramaraochavali/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/ramaraochavali/istio/languages","stargazers_url":"https://api.github.com/repos/ramaraochavali/istio/stargazers","contributors_url":"https://api.github.com/repos/ramaraochavali/istio/contributors","subscribers_url":"https://api.github.com/repos/ramaraochavali/istio/subscribers","subscription_url":"https://api.github.com/repos/ramaraochavali/istio/subscription","commits_url":"https://api.github.com/repos/ramaraochavali/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramaraochavali/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramaraochavali/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramaraochavali/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramaraochavali/istio/contents/{+path}","compare_url":"https://api.github.com/repos/ramaraochavali/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramaraochavali/istio/merges","archive_url":"https://api.github.com/repos/ramaraochavali/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramaraochavali/istio/downloads","issues_url":"https://api.github.com/repos/ramaraochavali/istio/issues{/number}","pulls_url":"https://api.github.com/repos/ramaraochavali/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/ramaraochavali/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/ramaraochavali/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramaraochavali/istio/labels{/name}","releases_url":"https://api.github.com/repos/ramaraochavali/istio/releases{/id}","deployments_url":"https://api.github.com/repos/ramaraochavali/istio/deployments","created_at":"2018-06-30T06:25:17Z","updated_at":"2019-11-04T05:48:37Z","pushed_at":"2019-11-05T03:03:05Z","git_url":"git://github.com/ramaraochavali/istio.git","ssh_url":"git@github.com:ramaraochavali/istio.git","clone_url":"https://github.com/ramaraochavali/istio.git","svn_url":"https://github.com/ramaraochavali/istio","homepage":"https://istio.io","size":102857,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"e70584500ba15da73cdb3c3462d6579fb92e609d","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2019-11-05T04:15:46Z","pushed_at":"2019-11-05T04:18:45Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":105519,"stargazers_count":20241,"watchers_count":20241,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3582,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1103,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3582,"open_issues":1103,"watchers":20241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/18574"},"html":{"href":"https://github.com/istio/istio/pull/18574"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/18574"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/18574/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/18574/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/18574/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/a9aee2adbca0260d4990232d737c37017f144ff8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ramaraochavali"}}