{"action":"created","issue":{"url":"https://api.github.com/repos/eggheads/eggdrop/issues/839","repository_url":"https://api.github.com/repos/eggheads/eggdrop","labels_url":"https://api.github.com/repos/eggheads/eggdrop/issues/839/labels{/name}","comments_url":"https://api.github.com/repos/eggheads/eggdrop/issues/839/comments","events_url":"https://api.github.com/repos/eggheads/eggdrop/issues/839/events","html_url":"https://github.com/eggheads/eggdrop/pull/839","id":478199565,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1MzY5MDcy","number":839,"title":"Add sasl timeout","user":{"login":"michaelortmann","id":41313082,"node_id":"MDQ6VXNlcjQxMzEzMDgy","avatar_url":"https://avatars1.githubusercontent.com/u/41313082?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelortmann","html_url":"https://github.com/michaelortmann","followers_url":"https://api.github.com/users/michaelortmann/followers","following_url":"https://api.github.com/users/michaelortmann/following{/other_user}","gists_url":"https://api.github.com/users/michaelortmann/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelortmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelortmann/subscriptions","organizations_url":"https://api.github.com/users/michaelortmann/orgs","repos_url":"https://api.github.com/users/michaelortmann/repos","events_url":"https://api.github.com/users/michaelortmann/events{/privacy}","received_events_url":"https://api.github.com/users/michaelortmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-08-08T00:50:40Z","updated_at":"2019-08-28T00:22:30Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/eggheads/eggdrop/pulls/839","html_url":"https://github.com/eggheads/eggdrop/pull/839","diff_url":"https://github.com/eggheads/eggdrop/pull/839.diff","patch_url":"https://github.com/eggheads/eggdrop/pull/839.patch"},"body":"Found by:\r\nPatch by: michaelortmann\r\nFixes: \r\n\r\nOne-line summary:\r\n\r\n\r\nAdditional description (if needed):\r\n\r\n\r\nTest cases demonstrating functionality (if applicable):\r\nTo test timeout code disable line https://github.com/eggheads/eggdrop/blob/02a73d075ad0c5223f3e4790884eaa03ec92b681/src/mod/server.mod/servmsg.c#L1299 or simulate loss of authenticate messages from server by making function gotauthenticate() instantly return and not progressing with sasl. The 2nd test would result in something like:\r\n```\r\n[05:26:14] SASL: put AUTHENTICATE ECDSA-NIST256P-CHALLENGE\r\n[05:26:24] SASL: timeout\r\n[05:26:24] -NOTICE- *** Notice -- You have an illegal character in your hostname\r\n[05:26:24] SASL: SASL authentication aborted\r\n[05:26:24] triggering bind evnt:init_server\r\n[05:26:24] triggered bind evnt:init_server, user 0.469ms sys 0.039ms\r\n[05:26:24] -NickServ (NickServ@services.int)- This nickname is registered. Please choose a different nickname, or identify via /msg NickServ identify <password>.\r\n[05:26:24] -NickServ (NickServ@services.int)- You are now identified for BotA.\r\n```\r\nNote that i also tested the eggdrop.conf option sasl-timeout = 10, which would otherwise default to 15."},"comment":{"url":"https://api.github.com/repos/eggheads/eggdrop/issues/comments/525532894","html_url":"https://github.com/eggheads/eggdrop/pull/839#issuecomment-525532894","issue_url":"https://api.github.com/repos/eggheads/eggdrop/issues/839","id":525532894,"node_id":"MDEyOklzc3VlQ29tbWVudDUyNTUzMjg5NA==","user":{"login":"michaelortmann","id":41313082,"node_id":"MDQ6VXNlcjQxMzEzMDgy","avatar_url":"https://avatars1.githubusercontent.com/u/41313082?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelortmann","html_url":"https://github.com/michaelortmann","followers_url":"https://api.github.com/users/michaelortmann/followers","following_url":"https://api.github.com/users/michaelortmann/following{/other_user}","gists_url":"https://api.github.com/users/michaelortmann/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelortmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelortmann/subscriptions","organizations_url":"https://api.github.com/users/michaelortmann/orgs","repos_url":"https://api.github.com/users/michaelortmann/repos","events_url":"https://api.github.com/users/michaelortmann/events{/privacy}","received_events_url":"https://api.github.com/users/michaelortmann/received_events","type":"User","site_admin":false},"created_at":"2019-08-28T00:22:30Z","updated_at":"2019-08-28T00:22:30Z","author_association":"MEMBER","body":"**Ready for review again.**"}}
{"actor":{"display_login":"michaelortmann"}}