{"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/356831474","pull_request_review_id":330839979,"id":356831474,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NjgzMTQ3NA==","diff_hunk":"@@ -6,6 +6,9 @@ add_definitions(\n include_directories(${REACTOS_SOURCE_DIR}/sdk/include/reactos/wine)\n spec2def(d3dcompiler_43.dll d3dcompiler_43.spec ADD_IMPORTLIB)\n \n+add_bison_files(asmshader.y hlsl.y ppy.y)\n+add_flex_files(asmshader.l hlsl.l ppl.l)","path":"dll/directx/wine/d3dcompiler_43/CMakeLists.txt","position":5,"original_position":5,"commit_id":"1862dc94e9df7fa862a48c0c0dd5cdc4506fc0af","original_commit_id":"1862dc94e9df7fa862a48c0c0dd5cdc4506fc0af","user":{"login":"AmineKhaldi","id":352225,"node_id":"MDQ6VXNlcjM1MjIyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/352225?v=4","gravatar_id":"","url":"https://api.github.com/users/AmineKhaldi","html_url":"https://github.com/AmineKhaldi","followers_url":"https://api.github.com/users/AmineKhaldi/followers","following_url":"https://api.github.com/users/AmineKhaldi/following{/other_user}","gists_url":"https://api.github.com/users/AmineKhaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/AmineKhaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmineKhaldi/subscriptions","organizations_url":"https://api.github.com/users/AmineKhaldi/orgs","repos_url":"https://api.github.com/users/AmineKhaldi/repos","events_url":"https://api.github.com/users/AmineKhaldi/events{/privacy}","received_events_url":"https://api.github.com/users/AmineKhaldi/received_events","type":"User","site_admin":false},"body":"They are, by definition, bound to the target they've added as source files to, so yes, it works as you would like it to.","created_at":"2019-12-11T21:01:39Z","updated_at":"2019-12-11T21:01:39Z","html_url":"https://github.com/reactos/reactos/pull/2148#discussion_r356831474","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/2148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/356831474"},"html":{"href":"https://github.com/reactos/reactos/pull/2148#discussion_r356831474"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/2148"}},"in_reply_to_id":356829267},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/2148","id":352108903,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyMTA4OTAz","html_url":"https://github.com/reactos/reactos/pull/2148","diff_url":"https://github.com/reactos/reactos/pull/2148.diff","patch_url":"https://github.com/reactos/reactos/pull/2148.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/2148","number":2148,"state":"open","locked":false,"title":"[CMAKE] Flexify and Bisonify automagically at build time. Needs flex and bison to be available (which RosBE provides).","user":{"login":"AmineKhaldi","id":352225,"node_id":"MDQ6VXNlcjM1MjIyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/352225?v=4","gravatar_id":"","url":"https://api.github.com/users/AmineKhaldi","html_url":"https://github.com/AmineKhaldi","followers_url":"https://api.github.com/users/AmineKhaldi/followers","following_url":"https://api.github.com/users/AmineKhaldi/following{/other_user}","gists_url":"https://api.github.com/users/AmineKhaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/AmineKhaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmineKhaldi/subscriptions","organizations_url":"https://api.github.com/users/AmineKhaldi/orgs","repos_url":"https://api.github.com/users/AmineKhaldi/repos","events_url":"https://api.github.com/users/AmineKhaldi/events{/privacy}","received_events_url":"https://api.github.com/users/AmineKhaldi/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-11T20:50:44Z","updated_at":"2019-12-11T21:01:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0629eaee49e2f1c0109d756821a64f6f2298465a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/2148/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/2148/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/2148/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/1862dc94e9df7fa862a48c0c0dd5cdc4506fc0af","head":{"label":"AmineKhaldi:flexify_and_bisonify_automagically","ref":"flexify_and_bisonify_automagically","sha":"1862dc94e9df7fa862a48c0c0dd5cdc4506fc0af","user":{"login":"AmineKhaldi","id":352225,"node_id":"MDQ6VXNlcjM1MjIyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/352225?v=4","gravatar_id":"","url":"https://api.github.com/users/AmineKhaldi","html_url":"https://github.com/AmineKhaldi","followers_url":"https://api.github.com/users/AmineKhaldi/followers","following_url":"https://api.github.com/users/AmineKhaldi/following{/other_user}","gists_url":"https://api.github.com/users/AmineKhaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/AmineKhaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmineKhaldi/subscriptions","organizations_url":"https://api.github.com/users/AmineKhaldi/orgs","repos_url":"https://api.github.com/users/AmineKhaldi/repos","events_url":"https://api.github.com/users/AmineKhaldi/events{/privacy}","received_events_url":"https://api.github.com/users/AmineKhaldi/received_events","type":"User","site_admin":false},"repo":{"id":106090353,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwOTAzNTM=","name":"reactos","full_name":"AmineKhaldi/reactos","private":false,"owner":{"login":"AmineKhaldi","id":352225,"node_id":"MDQ6VXNlcjM1MjIyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/352225?v=4","gravatar_id":"","url":"https://api.github.com/users/AmineKhaldi","html_url":"https://github.com/AmineKhaldi","followers_url":"https://api.github.com/users/AmineKhaldi/followers","following_url":"https://api.github.com/users/AmineKhaldi/following{/other_user}","gists_url":"https://api.github.com/users/AmineKhaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/AmineKhaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmineKhaldi/subscriptions","organizations_url":"https://api.github.com/users/AmineKhaldi/orgs","repos_url":"https://api.github.com/users/AmineKhaldi/repos","events_url":"https://api.github.com/users/AmineKhaldi/events{/privacy}","received_events_url":"https://api.github.com/users/AmineKhaldi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AmineKhaldi/reactos","description":"A free Windows-compatible Operating System","fork":true,"url":"https://api.github.com/repos/AmineKhaldi/reactos","forks_url":"https://api.github.com/repos/AmineKhaldi/reactos/forks","keys_url":"https://api.github.com/repos/AmineKhaldi/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AmineKhaldi/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AmineKhaldi/reactos/teams","hooks_url":"https://api.github.com/repos/AmineKhaldi/reactos/hooks","issue_events_url":"https://api.github.com/repos/AmineKhaldi/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/AmineKhaldi/reactos/events","assignees_url":"https://api.github.com/repos/AmineKhaldi/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/AmineKhaldi/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/AmineKhaldi/reactos/tags","blobs_url":"https://api.github.com/repos/AmineKhaldi/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AmineKhaldi/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AmineKhaldi/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/AmineKhaldi/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AmineKhaldi/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/AmineKhaldi/reactos/languages","stargazers_url":"https://api.github.com/repos/AmineKhaldi/reactos/stargazers","contributors_url":"https://api.github.com/repos/AmineKhaldi/reactos/contributors","subscribers_url":"https://api.github.com/repos/AmineKhaldi/reactos/subscribers","subscription_url":"https://api.github.com/repos/AmineKhaldi/reactos/subscription","commits_url":"https://api.github.com/repos/AmineKhaldi/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/AmineKhaldi/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/AmineKhaldi/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/AmineKhaldi/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/AmineKhaldi/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/AmineKhaldi/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AmineKhaldi/reactos/merges","archive_url":"https://api.github.com/repos/AmineKhaldi/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AmineKhaldi/reactos/downloads","issues_url":"https://api.github.com/repos/AmineKhaldi/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/AmineKhaldi/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/AmineKhaldi/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/AmineKhaldi/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AmineKhaldi/reactos/labels{/name}","releases_url":"https://api.github.com/repos/AmineKhaldi/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/AmineKhaldi/reactos/deployments","created_at":"2017-10-07T10:46:12Z","updated_at":"2019-03-15T13:39:16Z","pushed_at":"2019-12-11T20:49:01Z","git_url":"git://github.com/AmineKhaldi/reactos.git","ssh_url":"git@github.com:AmineKhaldi/reactos.git","clone_url":"https://github.com/AmineKhaldi/reactos.git","svn_url":"https://github.com/AmineKhaldi/reactos","homepage":null,"size":402980,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"cfdd483c0ee168529efc702c0711b285cf558453","user":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2Mjc4NDY=","name":"reactos","full_name":"reactos/reactos","private":false,"owner":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2019-12-11T17:30:30Z","pushed_at":"2019-12-11T20:50:45Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":492806,"stargazers_count":7077,"watchers_count":7077,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":769,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":106,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":769,"open_issues":106,"watchers":7077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/2148"},"html":{"href":"https://github.com/reactos/reactos/pull/2148"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/2148"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/2148/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/2148/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/2148/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/1862dc94e9df7fa862a48c0c0dd5cdc4506fc0af"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AmineKhaldi"}}