{"action":"created","comment":{"url":"https://api.github.com/repos/klarna/brod/pulls/comments/339832319","pull_request_review_id":307749827,"id":339832319,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTgzMjMxOQ==","diff_hunk":"@@ -0,0 +1,127 @@\n+%%%\n+%%%   Copyright (c) 2015-2018 Klarna Bank AB (publ)\n+%%%\n+%%%   Licensed under the Apache License, Version 2.0 (the \"License\");\n+%%%   you may not use this file except in compliance with the License.\n+%%%   You may obtain a copy of the License at\n+%%%\n+%%%       http://www.apache.org/licenses/LICENSE-2.0\n+%%%\n+%%%   Unless required by applicable law or agreed to in writing, software\n+%%%   distributed under the License is distributed on an \"AS IS\" BASIS,\n+%%%   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+%%%   See the License for the specific language governing permissions and\n+%%%   limitations under the License.\n+%%%\n+\n+%% @private\n+-module(brod_group_coordinator_SUITE).\n+-define(CLIENT_ID, ?MODULE).\n+-define(OTHER_CLIENT_ID, other_coordinator_id).\n+-define(TOPIC, <<\"brod-group-subscriber-1\">>).","path":"test/brod_group_coordinator_SUITE.erl","position":21,"original_position":21,"commit_id":"6947efd08bbea28e5c7906883d3f944fc9d58b3f","original_commit_id":"6947efd08bbea28e5c7906883d3f944fc9d58b3f","user":{"login":"k32","id":10274441,"node_id":"MDQ6VXNlcjEwMjc0NDQx","avatar_url":"https://avatars0.githubusercontent.com/u/10274441?v=4","gravatar_id":"","url":"https://api.github.com/users/k32","html_url":"https://github.com/k32","followers_url":"https://api.github.com/users/k32/followers","following_url":"https://api.github.com/users/k32/following{/other_user}","gists_url":"https://api.github.com/users/k32/gists{/gist_id}","starred_url":"https://api.github.com/users/k32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k32/subscriptions","organizations_url":"https://api.github.com/users/k32/orgs","repos_url":"https://api.github.com/users/k32/repos","events_url":"https://api.github.com/users/k32/events{/privacy}","received_events_url":"https://api.github.com/users/k32/received_events","type":"User","site_admin":false},"body":"This topic name collides with the `group_subscriber_SUITE`, please rename to something unique","created_at":"2019-10-28T23:07:41Z","updated_at":"2019-10-28T23:27:00Z","html_url":"https://github.com/klarna/brod/pull/351#discussion_r339832319","pull_request_url":"https://api.github.com/repos/klarna/brod/pulls/351","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/klarna/brod/pulls/comments/339832319"},"html":{"href":"https://github.com/klarna/brod/pull/351#discussion_r339832319"},"pull_request":{"href":"https://api.github.com/repos/klarna/brod/pulls/351"}}},"pull_request":{"url":"https://api.github.com/repos/klarna/brod/pulls/351","id":332223861,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyMjIzODYx","html_url":"https://github.com/klarna/brod/pull/351","diff_url":"https://github.com/klarna/brod/pull/351.diff","patch_url":"https://github.com/klarna/brod/pull/351.patch","issue_url":"https://api.github.com/repos/klarna/brod/issues/351","number":351,"state":"open","locked":false,"title":"Receive pending acks after assignments_revoked is invoked","user":{"login":"josevalim","id":9582,"node_id":"MDQ6VXNlcjk1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/9582?v=4","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"body":"We are building a multi-process data processing pipeline\r\nwith Brod and we are using the assignments_revoked callback\r\nto flush all messages being processed. However, if any message\r\nis acknowledged during the assignments_revoked step, those\r\nacks won't be committed, they will just sit in the group coordinator\r\ninbox and eventually be processed too late.\r\n\r\nThis commit makes it so we retrieve any pending ack from the\r\ninbox before we commit them.","created_at":"2019-10-24T20:17:35Z","updated_at":"2019-10-28T23:27:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92e0ae61fa4117f400e8b471e3a66a7f1f8770a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/klarna/brod/pulls/351/commits","review_comments_url":"https://api.github.com/repos/klarna/brod/pulls/351/comments","review_comment_url":"https://api.github.com/repos/klarna/brod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/klarna/brod/issues/351/comments","statuses_url":"https://api.github.com/repos/klarna/brod/statuses/6947efd08bbea28e5c7906883d3f944fc9d58b3f","head":{"label":"josevalim:patch-1","ref":"patch-1","sha":"6947efd08bbea28e5c7906883d3f944fc9d58b3f","user":{"login":"josevalim","id":9582,"node_id":"MDQ6VXNlcjk1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/9582?v=4","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"repo":{"id":217386962,"node_id":"MDEwOlJlcG9zaXRvcnkyMTczODY5NjI=","name":"brod","full_name":"josevalim/brod","private":false,"owner":{"login":"josevalim","id":9582,"node_id":"MDQ6VXNlcjk1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/9582?v=4","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"html_url":"https://github.com/josevalim/brod","description":"Apache Kafka client library for Erlang/Elixir","fork":true,"url":"https://api.github.com/repos/josevalim/brod","forks_url":"https://api.github.com/repos/josevalim/brod/forks","keys_url":"https://api.github.com/repos/josevalim/brod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josevalim/brod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josevalim/brod/teams","hooks_url":"https://api.github.com/repos/josevalim/brod/hooks","issue_events_url":"https://api.github.com/repos/josevalim/brod/issues/events{/number}","events_url":"https://api.github.com/repos/josevalim/brod/events","assignees_url":"https://api.github.com/repos/josevalim/brod/assignees{/user}","branches_url":"https://api.github.com/repos/josevalim/brod/branches{/branch}","tags_url":"https://api.github.com/repos/josevalim/brod/tags","blobs_url":"https://api.github.com/repos/josevalim/brod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josevalim/brod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josevalim/brod/git/refs{/sha}","trees_url":"https://api.github.com/repos/josevalim/brod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josevalim/brod/statuses/{sha}","languages_url":"https://api.github.com/repos/josevalim/brod/languages","stargazers_url":"https://api.github.com/repos/josevalim/brod/stargazers","contributors_url":"https://api.github.com/repos/josevalim/brod/contributors","subscribers_url":"https://api.github.com/repos/josevalim/brod/subscribers","subscription_url":"https://api.github.com/repos/josevalim/brod/subscription","commits_url":"https://api.github.com/repos/josevalim/brod/commits{/sha}","git_commits_url":"https://api.github.com/repos/josevalim/brod/git/commits{/sha}","comments_url":"https://api.github.com/repos/josevalim/brod/comments{/number}","issue_comment_url":"https://api.github.com/repos/josevalim/brod/issues/comments{/number}","contents_url":"https://api.github.com/repos/josevalim/brod/contents/{+path}","compare_url":"https://api.github.com/repos/josevalim/brod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josevalim/brod/merges","archive_url":"https://api.github.com/repos/josevalim/brod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josevalim/brod/downloads","issues_url":"https://api.github.com/repos/josevalim/brod/issues{/number}","pulls_url":"https://api.github.com/repos/josevalim/brod/pulls{/number}","milestones_url":"https://api.github.com/repos/josevalim/brod/milestones{/number}","notifications_url":"https://api.github.com/repos/josevalim/brod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josevalim/brod/labels{/name}","releases_url":"https://api.github.com/repos/josevalim/brod/releases{/id}","deployments_url":"https://api.github.com/repos/josevalim/brod/deployments","created_at":"2019-10-24T20:11:57Z","updated_at":"2019-10-24T22:35:43Z","pushed_at":"2019-10-26T17:56:47Z","git_url":"git://github.com/josevalim/brod.git","ssh_url":"git@github.com:josevalim/brod.git","clone_url":"https://github.com/josevalim/brod.git","svn_url":"https://github.com/josevalim/brod","homepage":"","size":2432,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"klarna:master","ref":"master","sha":"71e403a2de16e36d78e101be01ee675b501f25a9","user":{"login":"klarna","id":394540,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDU0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/394540?v=4","gravatar_id":"","url":"https://api.github.com/users/klarna","html_url":"https://github.com/klarna","followers_url":"https://api.github.com/users/klarna/followers","following_url":"https://api.github.com/users/klarna/following{/other_user}","gists_url":"https://api.github.com/users/klarna/gists{/gist_id}","starred_url":"https://api.github.com/users/klarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klarna/subscriptions","organizations_url":"https://api.github.com/users/klarna/orgs","repos_url":"https://api.github.com/users/klarna/repos","events_url":"https://api.github.com/users/klarna/events{/privacy}","received_events_url":"https://api.github.com/users/klarna/received_events","type":"Organization","site_admin":false},"repo":{"id":31531585,"node_id":"MDEwOlJlcG9zaXRvcnkzMTUzMTU4NQ==","name":"brod","full_name":"klarna/brod","private":false,"owner":{"login":"klarna","id":394540,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDU0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/394540?v=4","gravatar_id":"","url":"https://api.github.com/users/klarna","html_url":"https://github.com/klarna","followers_url":"https://api.github.com/users/klarna/followers","following_url":"https://api.github.com/users/klarna/following{/other_user}","gists_url":"https://api.github.com/users/klarna/gists{/gist_id}","starred_url":"https://api.github.com/users/klarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klarna/subscriptions","organizations_url":"https://api.github.com/users/klarna/orgs","repos_url":"https://api.github.com/users/klarna/repos","events_url":"https://api.github.com/users/klarna/events{/privacy}","received_events_url":"https://api.github.com/users/klarna/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/klarna/brod","description":"Apache Kafka client library for Erlang/Elixir","fork":false,"url":"https://api.github.com/repos/klarna/brod","forks_url":"https://api.github.com/repos/klarna/brod/forks","keys_url":"https://api.github.com/repos/klarna/brod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klarna/brod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klarna/brod/teams","hooks_url":"https://api.github.com/repos/klarna/brod/hooks","issue_events_url":"https://api.github.com/repos/klarna/brod/issues/events{/number}","events_url":"https://api.github.com/repos/klarna/brod/events","assignees_url":"https://api.github.com/repos/klarna/brod/assignees{/user}","branches_url":"https://api.github.com/repos/klarna/brod/branches{/branch}","tags_url":"https://api.github.com/repos/klarna/brod/tags","blobs_url":"https://api.github.com/repos/klarna/brod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klarna/brod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klarna/brod/git/refs{/sha}","trees_url":"https://api.github.com/repos/klarna/brod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klarna/brod/statuses/{sha}","languages_url":"https://api.github.com/repos/klarna/brod/languages","stargazers_url":"https://api.github.com/repos/klarna/brod/stargazers","contributors_url":"https://api.github.com/repos/klarna/brod/contributors","subscribers_url":"https://api.github.com/repos/klarna/brod/subscribers","subscription_url":"https://api.github.com/repos/klarna/brod/subscription","commits_url":"https://api.github.com/repos/klarna/brod/commits{/sha}","git_commits_url":"https://api.github.com/repos/klarna/brod/git/commits{/sha}","comments_url":"https://api.github.com/repos/klarna/brod/comments{/number}","issue_comment_url":"https://api.github.com/repos/klarna/brod/issues/comments{/number}","contents_url":"https://api.github.com/repos/klarna/brod/contents/{+path}","compare_url":"https://api.github.com/repos/klarna/brod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klarna/brod/merges","archive_url":"https://api.github.com/repos/klarna/brod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klarna/brod/downloads","issues_url":"https://api.github.com/repos/klarna/brod/issues{/number}","pulls_url":"https://api.github.com/repos/klarna/brod/pulls{/number}","milestones_url":"https://api.github.com/repos/klarna/brod/milestones{/number}","notifications_url":"https://api.github.com/repos/klarna/brod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klarna/brod/labels{/name}","releases_url":"https://api.github.com/repos/klarna/brod/releases{/id}","deployments_url":"https://api.github.com/repos/klarna/brod/deployments","created_at":"2015-03-02T09:02:18Z","updated_at":"2019-10-28T14:36:17Z","pushed_at":"2019-10-28T08:50:25Z","git_url":"git://github.com/klarna/brod.git","ssh_url":"git@github.com:klarna/brod.git","clone_url":"https://github.com/klarna/brod.git","svn_url":"https://github.com/klarna/brod","homepage":"","size":2431,"stargazers_count":375,"watchers_count":375,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":103,"open_issues":12,"watchers":375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/klarna/brod/pulls/351"},"html":{"href":"https://github.com/klarna/brod/pull/351"},"issue":{"href":"https://api.github.com/repos/klarna/brod/issues/351"},"comments":{"href":"https://api.github.com/repos/klarna/brod/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/klarna/brod/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/klarna/brod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/klarna/brod/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/klarna/brod/statuses/6947efd08bbea28e5c7906883d3f944fc9d58b3f"}},"author_association":"NONE"}}
{"actor":{"display_login":"k32"}}