{"action":"created","comment":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/comments/266274633","pull_request_review_id":215337685,"id":266274633,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjI3NDYzMw==","diff_hunk":"@@ -27,20 +27,32 @@ class Vivify extends Analyzer {\n   gustsHealing = 0;\n   lastCastTarget = null;\n   remDuringManaTea = 0;\n+  countForGusts = false;","path":"src/parser/monk/mistweaver/modules/spells/Vivify.js","position":4,"original_position":4,"commit_id":"a0592a4bde19d86e4e41f41f3f3e688b3f9d098a","original_commit_id":"a0592a4bde19d86e4e41f41f3f3e688b3f9d098a","user":{"login":"anom0ly","id":3225957,"node_id":"MDQ6VXNlcjMyMjU5NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/3225957?v=4","gravatar_id":"","url":"https://api.github.com/users/anom0ly","html_url":"https://github.com/anom0ly","followers_url":"https://api.github.com/users/anom0ly/followers","following_url":"https://api.github.com/users/anom0ly/following{/other_user}","gists_url":"https://api.github.com/users/anom0ly/gists{/gist_id}","starred_url":"https://api.github.com/users/anom0ly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anom0ly/subscriptions","organizations_url":"https://api.github.com/users/anom0ly/orgs","repos_url":"https://api.github.com/users/anom0ly/repos","events_url":"https://api.github.com/users/anom0ly/events{/privacy}","received_events_url":"https://api.github.com/users/anom0ly/received_events","type":"User","site_admin":false},"body":"Is this variable used anywhere else?","created_at":"2019-03-18T01:47:12Z","updated_at":"2019-03-18T01:55:53Z","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/3070#discussion_r266274633","pull_request_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/3070","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/comments/266274633"},"html":{"href":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/3070#discussion_r266274633"},"pull_request":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/3070"}}},"pull_request":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/3070","id":261795025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxNzk1MDI1","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/3070","diff_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/3070.diff","patch_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/3070.patch","issue_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/3070","number":3070,"state":"open","locked":false,"title":"[MW] Mastery correction, small bugs","user":{"login":"abelito75","id":25177817,"node_id":"MDQ6VXNlcjI1MTc3ODE3","avatar_url":"https://avatars1.githubusercontent.com/u/25177817?v=4","gravatar_id":"","url":"https://api.github.com/users/abelito75","html_url":"https://github.com/abelito75","followers_url":"https://api.github.com/users/abelito75/followers","following_url":"https://api.github.com/users/abelito75/following{/other_user}","gists_url":"https://api.github.com/users/abelito75/gists{/gist_id}","starred_url":"https://api.github.com/users/abelito75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abelito75/subscriptions","organizations_url":"https://api.github.com/users/abelito75/orgs","repos_url":"https://api.github.com/users/abelito75/repos","events_url":"https://api.github.com/users/abelito75/events{/privacy}","received_events_url":"https://api.github.com/users/abelito75/received_events","type":"User","site_admin":false},"body":"Should have broken up this into more pull requests most likely but shrug. Fixed mastery within 2ish% some fights its lower some its higher. Its a dirty fix but it works. The issue is that we can miss some casts and count some twice but we are always count the right number now. aka no more 2 env -> 8 gusts hit from env. It will always be 2 env -> 2-4 gusts procs depending on ef buff. This is a quick fix that works and could be slightly improved if you have a big brain idea. \r\n\r\nMost of the other things in here are removing old dead code/icon changes/tooltip changes\r\n\r\nDidn't put anything in the change log as imo we don't want people to see we had issues before","created_at":"2019-03-16T19:30:20Z","updated_at":"2019-03-18T01:55:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ce94717f93e0c835608a40ea4f09a9683df7573","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/3070/commits","review_comments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/3070/comments","review_comment_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/3070/comments","statuses_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/statuses/a0592a4bde19d86e4e41f41f3f3e688b3f9d098a","head":{"label":"abelito75:master","ref":"master","sha":"a0592a4bde19d86e4e41f41f3f3e688b3f9d098a","user":{"login":"abelito75","id":25177817,"node_id":"MDQ6VXNlcjI1MTc3ODE3","avatar_url":"https://avatars1.githubusercontent.com/u/25177817?v=4","gravatar_id":"","url":"https://api.github.com/users/abelito75","html_url":"https://github.com/abelito75","followers_url":"https://api.github.com/users/abelito75/followers","following_url":"https://api.github.com/users/abelito75/following{/other_user}","gists_url":"https://api.github.com/users/abelito75/gists{/gist_id}","starred_url":"https://api.github.com/users/abelito75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abelito75/subscriptions","organizations_url":"https://api.github.com/users/abelito75/orgs","repos_url":"https://api.github.com/users/abelito75/repos","events_url":"https://api.github.com/users/abelito75/events{/privacy}","received_events_url":"https://api.github.com/users/abelito75/received_events","type":"User","site_admin":false},"repo":{"id":175302790,"node_id":"MDEwOlJlcG9zaXRvcnkxNzUzMDI3OTA=","name":"WoWAnalyzer","full_name":"abelito75/WoWAnalyzer","private":false,"owner":{"login":"abelito75","id":25177817,"node_id":"MDQ6VXNlcjI1MTc3ODE3","avatar_url":"https://avatars1.githubusercontent.com/u/25177817?v=4","gravatar_id":"","url":"https://api.github.com/users/abelito75","html_url":"https://github.com/abelito75","followers_url":"https://api.github.com/users/abelito75/followers","following_url":"https://api.github.com/users/abelito75/following{/other_user}","gists_url":"https://api.github.com/users/abelito75/gists{/gist_id}","starred_url":"https://api.github.com/users/abelito75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abelito75/subscriptions","organizations_url":"https://api.github.com/users/abelito75/orgs","repos_url":"https://api.github.com/users/abelito75/repos","events_url":"https://api.github.com/users/abelito75/events{/privacy}","received_events_url":"https://api.github.com/users/abelito75/received_events","type":"User","site_admin":false},"html_url":"https://github.com/abelito75/WoWAnalyzer","description":"WoWAnalyzer is a tool to help you analyze and improve your World of Warcraft raiding performance through various relevant metrics and gameplay suggestions.","fork":true,"url":"https://api.github.com/repos/abelito75/WoWAnalyzer","forks_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/forks","keys_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/teams","hooks_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/hooks","issue_events_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/issues/events{/number}","events_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/events","assignees_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/assignees{/user}","branches_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/branches{/branch}","tags_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/tags","blobs_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/languages","stargazers_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/stargazers","contributors_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/contributors","subscribers_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/subscribers","subscription_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/subscription","commits_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/contents/{+path}","compare_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/merges","archive_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/downloads","issues_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/issues{/number}","pulls_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/labels{/name}","releases_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/releases{/id}","deployments_url":"https://api.github.com/repos/abelito75/WoWAnalyzer/deployments","created_at":"2019-03-12T22:01:59Z","updated_at":"2019-03-16T19:24:15Z","pushed_at":"2019-03-16T19:24:14Z","git_url":"git://github.com/abelito75/WoWAnalyzer.git","ssh_url":"git@github.com:abelito75/WoWAnalyzer.git","clone_url":"https://github.com/abelito75/WoWAnalyzer.git","svn_url":"https://github.com/abelito75/WoWAnalyzer","homepage":"http://wowanalyzer.com/","size":302207,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WoWAnalyzer:master","ref":"master","sha":"c4ef734575a16cf6e9a71730951203428bf52501","user":{"login":"WoWAnalyzer","id":32273378,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjczMzc4","avatar_url":"https://avatars2.githubusercontent.com/u/32273378?v=4","gravatar_id":"","url":"https://api.github.com/users/WoWAnalyzer","html_url":"https://github.com/WoWAnalyzer","followers_url":"https://api.github.com/users/WoWAnalyzer/followers","following_url":"https://api.github.com/users/WoWAnalyzer/following{/other_user}","gists_url":"https://api.github.com/users/WoWAnalyzer/gists{/gist_id}","starred_url":"https://api.github.com/users/WoWAnalyzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WoWAnalyzer/subscriptions","organizations_url":"https://api.github.com/users/WoWAnalyzer/orgs","repos_url":"https://api.github.com/users/WoWAnalyzer/repos","events_url":"https://api.github.com/users/WoWAnalyzer/events{/privacy}","received_events_url":"https://api.github.com/users/WoWAnalyzer/received_events","type":"Organization","site_admin":false},"repo":{"id":80472692,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQ3MjY5Mg==","name":"WoWAnalyzer","full_name":"WoWAnalyzer/WoWAnalyzer","private":false,"owner":{"login":"WoWAnalyzer","id":32273378,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjczMzc4","avatar_url":"https://avatars2.githubusercontent.com/u/32273378?v=4","gravatar_id":"","url":"https://api.github.com/users/WoWAnalyzer","html_url":"https://github.com/WoWAnalyzer","followers_url":"https://api.github.com/users/WoWAnalyzer/followers","following_url":"https://api.github.com/users/WoWAnalyzer/following{/other_user}","gists_url":"https://api.github.com/users/WoWAnalyzer/gists{/gist_id}","starred_url":"https://api.github.com/users/WoWAnalyzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WoWAnalyzer/subscriptions","organizations_url":"https://api.github.com/users/WoWAnalyzer/orgs","repos_url":"https://api.github.com/users/WoWAnalyzer/repos","events_url":"https://api.github.com/users/WoWAnalyzer/events{/privacy}","received_events_url":"https://api.github.com/users/WoWAnalyzer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer","description":"WoWAnalyzer is a tool to help you analyze and improve your World of Warcraft raiding performance through various relevant metrics and gameplay suggestions.","fork":false,"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer","forks_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/forks","keys_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/teams","hooks_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/hooks","issue_events_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/events{/number}","events_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/events","assignees_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/assignees{/user}","branches_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/branches{/branch}","tags_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/tags","blobs_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/languages","stargazers_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/stargazers","contributors_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/contributors","subscribers_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/subscribers","subscription_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/subscription","commits_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/contents/{+path}","compare_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/merges","archive_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/downloads","issues_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues{/number}","pulls_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/labels{/name}","releases_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/releases{/id}","deployments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/deployments","created_at":"2017-01-30T23:02:17Z","updated_at":"2019-03-17T15:02:07Z","pushed_at":"2019-03-17T14:20:53Z","git_url":"git://github.com/WoWAnalyzer/WoWAnalyzer.git","ssh_url":"git@github.com:WoWAnalyzer/WoWAnalyzer.git","clone_url":"https://github.com/WoWAnalyzer/WoWAnalyzer.git","svn_url":"https://github.com/WoWAnalyzer/WoWAnalyzer","homepage":"http://wowanalyzer.com/","size":302333,"stargazers_count":215,"watchers_count":215,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":283,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":283,"open_issues":150,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/3070"},"html":{"href":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/3070"},"issue":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/3070"},"comments":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/3070/comments"},"review_comments":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/3070/comments"},"review_comment":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/3070/commits"},"statuses":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/statuses/a0592a4bde19d86e4e41f41f3f3e688b3f9d098a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anom0ly"}}