{"action":"created","comment":{"url":"https://api.github.com/repos/UIUC-PPL/charm/pulls/comments/300125578","pull_request_review_id":257699324,"id":300125578,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDEyNTU3OA==","diff_hunk":"@@ -1731,10 +1731,18 @@ int ampiParent::setAttr(int context, vector<int>& keyvals, int keyval, void* att\n     return MPI_SUCCESS;\n   }\n   keyvals.push_back(keyval);\n-  kvlist[keyval]->incRefCount();\n+  kvlist[keyval]->incRefCount(); // TODO: is this needed?\n   return setUserKeyval(context, keyval, attribute_val);\n }\n \n+int ampiParent::freeKeyval(int context, vector<int>& keyvals, int keyval) noexcept {\n+  if (keyval >= 0 && keyval < kvlist.size()) {\n+    kvlist[keyval]->decRefCount();","path":"src/libs/ck-libs/ampi/ampi.C","position":11,"original_position":11,"commit_id":"8b30f45b6b166ef8fe4cba8a5dea6f8630fc0b11","original_commit_id":"8b30f45b6b166ef8fe4cba8a5dea6f8630fc0b11","user":{"login":"matthiasdiener","id":1772435,"node_id":"MDQ6VXNlcjE3NzI0MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1772435?v=4","gravatar_id":"","url":"https://api.github.com/users/matthiasdiener","html_url":"https://github.com/matthiasdiener","followers_url":"https://api.github.com/users/matthiasdiener/followers","following_url":"https://api.github.com/users/matthiasdiener/following{/other_user}","gists_url":"https://api.github.com/users/matthiasdiener/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasdiener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasdiener/subscriptions","organizations_url":"https://api.github.com/users/matthiasdiener/orgs","repos_url":"https://api.github.com/users/matthiasdiener/repos","events_url":"https://api.github.com/users/matthiasdiener/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasdiener/received_events","type":"User","site_admin":false},"body":"This doesn't seem to actually free the keyval?","created_at":"2019-07-03T19:40:24Z","updated_at":"2019-07-03T19:41:40Z","html_url":"https://github.com/UIUC-PPL/charm/pull/2373#discussion_r300125578","pull_request_url":"https://api.github.com/repos/UIUC-PPL/charm/pulls/2373","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/UIUC-PPL/charm/pulls/comments/300125578"},"html":{"href":"https://github.com/UIUC-PPL/charm/pull/2373#discussion_r300125578"},"pull_request":{"href":"https://api.github.com/repos/UIUC-PPL/charm/pulls/2373"}}},"pull_request":{"url":"https://api.github.com/repos/UIUC-PPL/charm/pulls/2373","id":293477550,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzNDc3NTUw","html_url":"https://github.com/UIUC-PPL/charm/pull/2373","diff_url":"https://github.com/UIUC-PPL/charm/pull/2373.diff","patch_url":"https://github.com/UIUC-PPL/charm/pull/2373.patch","issue_url":"https://api.github.com/repos/UIUC-PPL/charm/issues/2373","number":2373,"state":"open","locked":false,"title":"AMPI: manage freeing of keyvals from Comm_free and Comm_free_keyval","user":{"login":"stwhite91","id":12042181,"node_id":"MDQ6VXNlcjEyMDQyMTgx","avatar_url":"https://avatars2.githubusercontent.com/u/12042181?v=4","gravatar_id":"","url":"https://api.github.com/users/stwhite91","html_url":"https://github.com/stwhite91","followers_url":"https://api.github.com/users/stwhite91/followers","following_url":"https://api.github.com/users/stwhite91/following{/other_user}","gists_url":"https://api.github.com/users/stwhite91/gists{/gist_id}","starred_url":"https://api.github.com/users/stwhite91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stwhite91/subscriptions","organizations_url":"https://api.github.com/users/stwhite91/orgs","repos_url":"https://api.github.com/users/stwhite91/repos","events_url":"https://api.github.com/users/stwhite91/events{/privacy}","received_events_url":"https://api.github.com/users/stwhite91/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-01T19:58:29Z","updated_at":"2019-07-03T19:41:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57be6acb9d470392a34b5c1aaf377df49abb5c39","assignee":{"login":"stwhite91","id":12042181,"node_id":"MDQ6VXNlcjEyMDQyMTgx","avatar_url":"https://avatars2.githubusercontent.com/u/12042181?v=4","gravatar_id":"","url":"https://api.github.com/users/stwhite91","html_url":"https://github.com/stwhite91","followers_url":"https://api.github.com/users/stwhite91/followers","following_url":"https://api.github.com/users/stwhite91/following{/other_user}","gists_url":"https://api.github.com/users/stwhite91/gists{/gist_id}","starred_url":"https://api.github.com/users/stwhite91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stwhite91/subscriptions","organizations_url":"https://api.github.com/users/stwhite91/orgs","repos_url":"https://api.github.com/users/stwhite91/repos","events_url":"https://api.github.com/users/stwhite91/events{/privacy}","received_events_url":"https://api.github.com/users/stwhite91/received_events","type":"User","site_admin":false},"assignees":[{"login":"stwhite91","id":12042181,"node_id":"MDQ6VXNlcjEyMDQyMTgx","avatar_url":"https://avatars2.githubusercontent.com/u/12042181?v=4","gravatar_id":"","url":"https://api.github.com/users/stwhite91","html_url":"https://github.com/stwhite91","followers_url":"https://api.github.com/users/stwhite91/followers","following_url":"https://api.github.com/users/stwhite91/following{/other_user}","gists_url":"https://api.github.com/users/stwhite91/gists{/gist_id}","starred_url":"https://api.github.com/users/stwhite91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stwhite91/subscriptions","organizations_url":"https://api.github.com/users/stwhite91/orgs","repos_url":"https://api.github.com/users/stwhite91/repos","events_url":"https://api.github.com/users/stwhite91/events{/privacy}","received_events_url":"https://api.github.com/users/stwhite91/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"evan-charmworks","id":31295111,"node_id":"MDQ6VXNlcjMxMjk1MTEx","avatar_url":"https://avatars3.githubusercontent.com/u/31295111?v=4","gravatar_id":"","url":"https://api.github.com/users/evan-charmworks","html_url":"https://github.com/evan-charmworks","followers_url":"https://api.github.com/users/evan-charmworks/followers","following_url":"https://api.github.com/users/evan-charmworks/following{/other_user}","gists_url":"https://api.github.com/users/evan-charmworks/gists{/gist_id}","starred_url":"https://api.github.com/users/evan-charmworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evan-charmworks/subscriptions","organizations_url":"https://api.github.com/users/evan-charmworks/orgs","repos_url":"https://api.github.com/users/evan-charmworks/repos","events_url":"https://api.github.com/users/evan-charmworks/events{/privacy}","received_events_url":"https://api.github.com/users/evan-charmworks/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1334354115,"node_id":"MDU6TGFiZWwxMzM0MzU0MTE1","url":"https://api.github.com/repos/UIUC-PPL/charm/labels/AMPI","name":"AMPI","color":"c91e96","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/UIUC-PPL/charm/pulls/2373/commits","review_comments_url":"https://api.github.com/repos/UIUC-PPL/charm/pulls/2373/comments","review_comment_url":"https://api.github.com/repos/UIUC-PPL/charm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UIUC-PPL/charm/issues/2373/comments","statuses_url":"https://api.github.com/repos/UIUC-PPL/charm/statuses/8b30f45b6b166ef8fe4cba8a5dea6f8630fc0b11","head":{"label":"UIUC-PPL:swhite/ampi_free_keyvals","ref":"swhite/ampi_free_keyvals","sha":"8b30f45b6b166ef8fe4cba8a5dea6f8630fc0b11","user":{"login":"UIUC-PPL","id":20606319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjA2MzE5","avatar_url":"https://avatars2.githubusercontent.com/u/20606319?v=4","gravatar_id":"","url":"https://api.github.com/users/UIUC-PPL","html_url":"https://github.com/UIUC-PPL","followers_url":"https://api.github.com/users/UIUC-PPL/followers","following_url":"https://api.github.com/users/UIUC-PPL/following{/other_user}","gists_url":"https://api.github.com/users/UIUC-PPL/gists{/gist_id}","starred_url":"https://api.github.com/users/UIUC-PPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UIUC-PPL/subscriptions","organizations_url":"https://api.github.com/users/UIUC-PPL/orgs","repos_url":"https://api.github.com/users/UIUC-PPL/repos","events_url":"https://api.github.com/users/UIUC-PPL/events{/privacy}","received_events_url":"https://api.github.com/users/UIUC-PPL/received_events","type":"Organization","site_admin":false},"repo":{"id":182860956,"node_id":"MDEwOlJlcG9zaXRvcnkxODI4NjA5NTY=","name":"charm","full_name":"UIUC-PPL/charm","private":false,"owner":{"login":"UIUC-PPL","id":20606319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjA2MzE5","avatar_url":"https://avatars2.githubusercontent.com/u/20606319?v=4","gravatar_id":"","url":"https://api.github.com/users/UIUC-PPL","html_url":"https://github.com/UIUC-PPL","followers_url":"https://api.github.com/users/UIUC-PPL/followers","following_url":"https://api.github.com/users/UIUC-PPL/following{/other_user}","gists_url":"https://api.github.com/users/UIUC-PPL/gists{/gist_id}","starred_url":"https://api.github.com/users/UIUC-PPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UIUC-PPL/subscriptions","organizations_url":"https://api.github.com/users/UIUC-PPL/orgs","repos_url":"https://api.github.com/users/UIUC-PPL/repos","events_url":"https://api.github.com/users/UIUC-PPL/events{/privacy}","received_events_url":"https://api.github.com/users/UIUC-PPL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UIUC-PPL/charm","description":"The Charm++ parallel programming system. Visit http://charmplusplus.org/ for more information.","fork":false,"url":"https://api.github.com/repos/UIUC-PPL/charm","forks_url":"https://api.github.com/repos/UIUC-PPL/charm/forks","keys_url":"https://api.github.com/repos/UIUC-PPL/charm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UIUC-PPL/charm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UIUC-PPL/charm/teams","hooks_url":"https://api.github.com/repos/UIUC-PPL/charm/hooks","issue_events_url":"https://api.github.com/repos/UIUC-PPL/charm/issues/events{/number}","events_url":"https://api.github.com/repos/UIUC-PPL/charm/events","assignees_url":"https://api.github.com/repos/UIUC-PPL/charm/assignees{/user}","branches_url":"https://api.github.com/repos/UIUC-PPL/charm/branches{/branch}","tags_url":"https://api.github.com/repos/UIUC-PPL/charm/tags","blobs_url":"https://api.github.com/repos/UIUC-PPL/charm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UIUC-PPL/charm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UIUC-PPL/charm/git/refs{/sha}","trees_url":"https://api.github.com/repos/UIUC-PPL/charm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UIUC-PPL/charm/statuses/{sha}","languages_url":"https://api.github.com/repos/UIUC-PPL/charm/languages","stargazers_url":"https://api.github.com/repos/UIUC-PPL/charm/stargazers","contributors_url":"https://api.github.com/repos/UIUC-PPL/charm/contributors","subscribers_url":"https://api.github.com/repos/UIUC-PPL/charm/subscribers","subscription_url":"https://api.github.com/repos/UIUC-PPL/charm/subscription","commits_url":"https://api.github.com/repos/UIUC-PPL/charm/commits{/sha}","git_commits_url":"https://api.github.com/repos/UIUC-PPL/charm/git/commits{/sha}","comments_url":"https://api.github.com/repos/UIUC-PPL/charm/comments{/number}","issue_comment_url":"https://api.github.com/repos/UIUC-PPL/charm/issues/comments{/number}","contents_url":"https://api.github.com/repos/UIUC-PPL/charm/contents/{+path}","compare_url":"https://api.github.com/repos/UIUC-PPL/charm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UIUC-PPL/charm/merges","archive_url":"https://api.github.com/repos/UIUC-PPL/charm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UIUC-PPL/charm/downloads","issues_url":"https://api.github.com/repos/UIUC-PPL/charm/issues{/number}","pulls_url":"https://api.github.com/repos/UIUC-PPL/charm/pulls{/number}","milestones_url":"https://api.github.com/repos/UIUC-PPL/charm/milestones{/number}","notifications_url":"https://api.github.com/repos/UIUC-PPL/charm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UIUC-PPL/charm/labels{/name}","releases_url":"https://api.github.com/repos/UIUC-PPL/charm/releases{/id}","deployments_url":"https://api.github.com/repos/UIUC-PPL/charm/deployments","created_at":"2019-04-22T20:14:58Z","updated_at":"2019-07-02T16:08:26Z","pushed_at":"2019-07-03T19:33:36Z","git_url":"git://github.com/UIUC-PPL/charm.git","ssh_url":"git@github.com:UIUC-PPL/charm.git","clone_url":"https://github.com/UIUC-PPL/charm.git","svn_url":"https://github.com/UIUC-PPL/charm","homepage":"","size":89864,"stargazers_count":27,"watchers_count":27,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":538,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":538,"watchers":27,"default_branch":"master"}},"base":{"label":"UIUC-PPL:master","ref":"master","sha":"d2e39d287bcccc10e67d3223ef25c02896f9e859","user":{"login":"UIUC-PPL","id":20606319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjA2MzE5","avatar_url":"https://avatars2.githubusercontent.com/u/20606319?v=4","gravatar_id":"","url":"https://api.github.com/users/UIUC-PPL","html_url":"https://github.com/UIUC-PPL","followers_url":"https://api.github.com/users/UIUC-PPL/followers","following_url":"https://api.github.com/users/UIUC-PPL/following{/other_user}","gists_url":"https://api.github.com/users/UIUC-PPL/gists{/gist_id}","starred_url":"https://api.github.com/users/UIUC-PPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UIUC-PPL/subscriptions","organizations_url":"https://api.github.com/users/UIUC-PPL/orgs","repos_url":"https://api.github.com/users/UIUC-PPL/repos","events_url":"https://api.github.com/users/UIUC-PPL/events{/privacy}","received_events_url":"https://api.github.com/users/UIUC-PPL/received_events","type":"Organization","site_admin":false},"repo":{"id":182860956,"node_id":"MDEwOlJlcG9zaXRvcnkxODI4NjA5NTY=","name":"charm","full_name":"UIUC-PPL/charm","private":false,"owner":{"login":"UIUC-PPL","id":20606319,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjA2MzE5","avatar_url":"https://avatars2.githubusercontent.com/u/20606319?v=4","gravatar_id":"","url":"https://api.github.com/users/UIUC-PPL","html_url":"https://github.com/UIUC-PPL","followers_url":"https://api.github.com/users/UIUC-PPL/followers","following_url":"https://api.github.com/users/UIUC-PPL/following{/other_user}","gists_url":"https://api.github.com/users/UIUC-PPL/gists{/gist_id}","starred_url":"https://api.github.com/users/UIUC-PPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UIUC-PPL/subscriptions","organizations_url":"https://api.github.com/users/UIUC-PPL/orgs","repos_url":"https://api.github.com/users/UIUC-PPL/repos","events_url":"https://api.github.com/users/UIUC-PPL/events{/privacy}","received_events_url":"https://api.github.com/users/UIUC-PPL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UIUC-PPL/charm","description":"The Charm++ parallel programming system. Visit http://charmplusplus.org/ for more information.","fork":false,"url":"https://api.github.com/repos/UIUC-PPL/charm","forks_url":"https://api.github.com/repos/UIUC-PPL/charm/forks","keys_url":"https://api.github.com/repos/UIUC-PPL/charm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UIUC-PPL/charm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UIUC-PPL/charm/teams","hooks_url":"https://api.github.com/repos/UIUC-PPL/charm/hooks","issue_events_url":"https://api.github.com/repos/UIUC-PPL/charm/issues/events{/number}","events_url":"https://api.github.com/repos/UIUC-PPL/charm/events","assignees_url":"https://api.github.com/repos/UIUC-PPL/charm/assignees{/user}","branches_url":"https://api.github.com/repos/UIUC-PPL/charm/branches{/branch}","tags_url":"https://api.github.com/repos/UIUC-PPL/charm/tags","blobs_url":"https://api.github.com/repos/UIUC-PPL/charm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UIUC-PPL/charm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UIUC-PPL/charm/git/refs{/sha}","trees_url":"https://api.github.com/repos/UIUC-PPL/charm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UIUC-PPL/charm/statuses/{sha}","languages_url":"https://api.github.com/repos/UIUC-PPL/charm/languages","stargazers_url":"https://api.github.com/repos/UIUC-PPL/charm/stargazers","contributors_url":"https://api.github.com/repos/UIUC-PPL/charm/contributors","subscribers_url":"https://api.github.com/repos/UIUC-PPL/charm/subscribers","subscription_url":"https://api.github.com/repos/UIUC-PPL/charm/subscription","commits_url":"https://api.github.com/repos/UIUC-PPL/charm/commits{/sha}","git_commits_url":"https://api.github.com/repos/UIUC-PPL/charm/git/commits{/sha}","comments_url":"https://api.github.com/repos/UIUC-PPL/charm/comments{/number}","issue_comment_url":"https://api.github.com/repos/UIUC-PPL/charm/issues/comments{/number}","contents_url":"https://api.github.com/repos/UIUC-PPL/charm/contents/{+path}","compare_url":"https://api.github.com/repos/UIUC-PPL/charm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UIUC-PPL/charm/merges","archive_url":"https://api.github.com/repos/UIUC-PPL/charm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UIUC-PPL/charm/downloads","issues_url":"https://api.github.com/repos/UIUC-PPL/charm/issues{/number}","pulls_url":"https://api.github.com/repos/UIUC-PPL/charm/pulls{/number}","milestones_url":"https://api.github.com/repos/UIUC-PPL/charm/milestones{/number}","notifications_url":"https://api.github.com/repos/UIUC-PPL/charm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UIUC-PPL/charm/labels{/name}","releases_url":"https://api.github.com/repos/UIUC-PPL/charm/releases{/id}","deployments_url":"https://api.github.com/repos/UIUC-PPL/charm/deployments","created_at":"2019-04-22T20:14:58Z","updated_at":"2019-07-02T16:08:26Z","pushed_at":"2019-07-03T19:33:36Z","git_url":"git://github.com/UIUC-PPL/charm.git","ssh_url":"git@github.com:UIUC-PPL/charm.git","clone_url":"https://github.com/UIUC-PPL/charm.git","svn_url":"https://github.com/UIUC-PPL/charm","homepage":"","size":89864,"stargazers_count":27,"watchers_count":27,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":538,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":538,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UIUC-PPL/charm/pulls/2373"},"html":{"href":"https://github.com/UIUC-PPL/charm/pull/2373"},"issue":{"href":"https://api.github.com/repos/UIUC-PPL/charm/issues/2373"},"comments":{"href":"https://api.github.com/repos/UIUC-PPL/charm/issues/2373/comments"},"review_comments":{"href":"https://api.github.com/repos/UIUC-PPL/charm/pulls/2373/comments"},"review_comment":{"href":"https://api.github.com/repos/UIUC-PPL/charm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UIUC-PPL/charm/pulls/2373/commits"},"statuses":{"href":"https://api.github.com/repos/UIUC-PPL/charm/statuses/8b30f45b6b166ef8fe4cba8a5dea6f8630fc0b11"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"matthiasdiener"}}