{"action":"created","comment":{"url":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/comments/275178324","pull_request_review_id":226417755,"id":275178324,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTE3ODMyNA==","diff_hunk":"@@ -0,0 +1,60 @@\n+import * as THREE from \"three\";\n+\n+export const BoundaryMixin = (superclass) => class extends superclass {\n+\n+    constructor(config) {\n+        super(config);\n+        this.boundaryConditions = config.boundaryConditions || {};\n+    }\n+\n+    /**\n+     * Boundaries are drawn only if type is \"bc1\", \"bc2\", or \"bc3\".\n+     */\n+    get areBoundariesEnabled() {return [\"bc1\", \"bc2\", \"bc3\"].includes(this.boundaryConditions.type)}\n+\n+    /**\n+     * Returns a plane-like mesh object with given corner vertices in counterclockwise order.\n+     */","path":"src/mixins/boundary.js","position":17,"original_position":17,"commit_id":"112563ff15875334e91a11f2a9026e88837e787a","original_commit_id":"112563ff15875334e91a11f2a9026e88837e787a","user":{"login":"timurbazhirov","id":721112,"node_id":"MDQ6VXNlcjcyMTExMg==","avatar_url":"https://avatars3.githubusercontent.com/u/721112?v=4","gravatar_id":"","url":"https://api.github.com/users/timurbazhirov","html_url":"https://github.com/timurbazhirov","followers_url":"https://api.github.com/users/timurbazhirov/followers","following_url":"https://api.github.com/users/timurbazhirov/following{/other_user}","gists_url":"https://api.github.com/users/timurbazhirov/gists{/gist_id}","starred_url":"https://api.github.com/users/timurbazhirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timurbazhirov/subscriptions","organizations_url":"https://api.github.com/users/timurbazhirov/orgs","repos_url":"https://api.github.com/users/timurbazhirov/repos","events_url":"https://api.github.com/users/timurbazhirov/events{/privacy}","received_events_url":"https://api.github.com/users/timurbazhirov/received_events","type":"User","site_admin":false},"body":"1. input params need explanation\r\n2. plane is defined by 3 points, why have 4?","created_at":"2019-04-14T23:03:10Z","updated_at":"2019-04-14T23:03:10Z","html_url":"https://github.com/Exabyte-io/wave.js/pull/33#discussion_r275178324","pull_request_url":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/33","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/comments/275178324"},"html":{"href":"https://github.com/Exabyte-io/wave.js/pull/33#discussion_r275178324"},"pull_request":{"href":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/33","id":269856173,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5ODU2MTcz","html_url":"https://github.com/Exabyte-io/wave.js/pull/33","diff_url":"https://github.com/Exabyte-io/wave.js/pull/33.diff","patch_url":"https://github.com/Exabyte-io/wave.js/pull/33.patch","issue_url":"https://api.github.com/repos/Exabyte-io/wave.js/issues/33","number":33,"state":"open","locked":false,"title":"feature/SOF-3779","user":{"login":"mohammadidinani","id":10528238,"node_id":"MDQ6VXNlcjEwNTI4MjM4","avatar_url":"https://avatars2.githubusercontent.com/u/10528238?v=4","gravatar_id":"","url":"https://api.github.com/users/mohammadidinani","html_url":"https://github.com/mohammadidinani","followers_url":"https://api.github.com/users/mohammadidinani/followers","following_url":"https://api.github.com/users/mohammadidinani/following{/other_user}","gists_url":"https://api.github.com/users/mohammadidinani/gists{/gist_id}","starred_url":"https://api.github.com/users/mohammadidinani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohammadidinani/subscriptions","organizations_url":"https://api.github.com/users/mohammadidinani/orgs","repos_url":"https://api.github.com/users/mohammadidinani/repos","events_url":"https://api.github.com/users/mohammadidinani/events{/privacy}","received_events_url":"https://api.github.com/users/mohammadidinani/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-12T03:04:22Z","updated_at":"2019-04-14T23:03:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cb3615d483b2dbc98ee4efac286e864b5fa8092","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/33/commits","review_comments_url":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/33/comments","review_comment_url":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Exabyte-io/wave.js/issues/33/comments","statuses_url":"https://api.github.com/repos/Exabyte-io/wave.js/statuses/112563ff15875334e91a11f2a9026e88837e787a","head":{"label":"Exabyte-io:feature/SOF-3779","ref":"feature/SOF-3779","sha":"112563ff15875334e91a11f2a9026e88837e787a","user":{"login":"Exabyte-io","id":7788846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODg4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7788846?v=4","gravatar_id":"","url":"https://api.github.com/users/Exabyte-io","html_url":"https://github.com/Exabyte-io","followers_url":"https://api.github.com/users/Exabyte-io/followers","following_url":"https://api.github.com/users/Exabyte-io/following{/other_user}","gists_url":"https://api.github.com/users/Exabyte-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Exabyte-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exabyte-io/subscriptions","organizations_url":"https://api.github.com/users/Exabyte-io/orgs","repos_url":"https://api.github.com/users/Exabyte-io/repos","events_url":"https://api.github.com/users/Exabyte-io/events{/privacy}","received_events_url":"https://api.github.com/users/Exabyte-io/received_events","type":"Organization","site_admin":false},"repo":{"id":169485824,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk0ODU4MjQ=","name":"wave.js","full_name":"Exabyte-io/wave.js","private":false,"owner":{"login":"Exabyte-io","id":7788846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODg4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7788846?v=4","gravatar_id":"","url":"https://api.github.com/users/Exabyte-io","html_url":"https://github.com/Exabyte-io","followers_url":"https://api.github.com/users/Exabyte-io/followers","following_url":"https://api.github.com/users/Exabyte-io/following{/other_user}","gists_url":"https://api.github.com/users/Exabyte-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Exabyte-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exabyte-io/subscriptions","organizations_url":"https://api.github.com/users/Exabyte-io/orgs","repos_url":"https://api.github.com/users/Exabyte-io/repos","events_url":"https://api.github.com/users/Exabyte-io/events{/privacy}","received_events_url":"https://api.github.com/users/Exabyte-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Exabyte-io/wave.js","description":"Web-based Atomic Viewer by Exabyte.","fork":false,"url":"https://api.github.com/repos/Exabyte-io/wave.js","forks_url":"https://api.github.com/repos/Exabyte-io/wave.js/forks","keys_url":"https://api.github.com/repos/Exabyte-io/wave.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exabyte-io/wave.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exabyte-io/wave.js/teams","hooks_url":"https://api.github.com/repos/Exabyte-io/wave.js/hooks","issue_events_url":"https://api.github.com/repos/Exabyte-io/wave.js/issues/events{/number}","events_url":"https://api.github.com/repos/Exabyte-io/wave.js/events","assignees_url":"https://api.github.com/repos/Exabyte-io/wave.js/assignees{/user}","branches_url":"https://api.github.com/repos/Exabyte-io/wave.js/branches{/branch}","tags_url":"https://api.github.com/repos/Exabyte-io/wave.js/tags","blobs_url":"https://api.github.com/repos/Exabyte-io/wave.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exabyte-io/wave.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exabyte-io/wave.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exabyte-io/wave.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exabyte-io/wave.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Exabyte-io/wave.js/languages","stargazers_url":"https://api.github.com/repos/Exabyte-io/wave.js/stargazers","contributors_url":"https://api.github.com/repos/Exabyte-io/wave.js/contributors","subscribers_url":"https://api.github.com/repos/Exabyte-io/wave.js/subscribers","subscription_url":"https://api.github.com/repos/Exabyte-io/wave.js/subscription","commits_url":"https://api.github.com/repos/Exabyte-io/wave.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exabyte-io/wave.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exabyte-io/wave.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exabyte-io/wave.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exabyte-io/wave.js/contents/{+path}","compare_url":"https://api.github.com/repos/Exabyte-io/wave.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exabyte-io/wave.js/merges","archive_url":"https://api.github.com/repos/Exabyte-io/wave.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exabyte-io/wave.js/downloads","issues_url":"https://api.github.com/repos/Exabyte-io/wave.js/issues{/number}","pulls_url":"https://api.github.com/repos/Exabyte-io/wave.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Exabyte-io/wave.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Exabyte-io/wave.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exabyte-io/wave.js/labels{/name}","releases_url":"https://api.github.com/repos/Exabyte-io/wave.js/releases{/id}","deployments_url":"https://api.github.com/repos/Exabyte-io/wave.js/deployments","created_at":"2019-02-06T22:20:37Z","updated_at":"2019-04-03T02:42:16Z","pushed_at":"2019-04-13T00:20:55Z","git_url":"git://github.com/Exabyte-io/wave.js.git","ssh_url":"git@github.com:Exabyte-io/wave.js.git","clone_url":"https://github.com/Exabyte-io/wave.js.git","svn_url":"https://github.com/Exabyte-io/wave.js","homepage":null,"size":209,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Exabyte-io:dev","ref":"dev","sha":"c735991850ea9f955ee963317b5f2d7c55df13b9","user":{"login":"Exabyte-io","id":7788846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODg4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7788846?v=4","gravatar_id":"","url":"https://api.github.com/users/Exabyte-io","html_url":"https://github.com/Exabyte-io","followers_url":"https://api.github.com/users/Exabyte-io/followers","following_url":"https://api.github.com/users/Exabyte-io/following{/other_user}","gists_url":"https://api.github.com/users/Exabyte-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Exabyte-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exabyte-io/subscriptions","organizations_url":"https://api.github.com/users/Exabyte-io/orgs","repos_url":"https://api.github.com/users/Exabyte-io/repos","events_url":"https://api.github.com/users/Exabyte-io/events{/privacy}","received_events_url":"https://api.github.com/users/Exabyte-io/received_events","type":"Organization","site_admin":false},"repo":{"id":169485824,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk0ODU4MjQ=","name":"wave.js","full_name":"Exabyte-io/wave.js","private":false,"owner":{"login":"Exabyte-io","id":7788846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODg4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7788846?v=4","gravatar_id":"","url":"https://api.github.com/users/Exabyte-io","html_url":"https://github.com/Exabyte-io","followers_url":"https://api.github.com/users/Exabyte-io/followers","following_url":"https://api.github.com/users/Exabyte-io/following{/other_user}","gists_url":"https://api.github.com/users/Exabyte-io/gists{/gist_id}","starred_url":"https://api.github.com/users/Exabyte-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exabyte-io/subscriptions","organizations_url":"https://api.github.com/users/Exabyte-io/orgs","repos_url":"https://api.github.com/users/Exabyte-io/repos","events_url":"https://api.github.com/users/Exabyte-io/events{/privacy}","received_events_url":"https://api.github.com/users/Exabyte-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Exabyte-io/wave.js","description":"Web-based Atomic Viewer by Exabyte.","fork":false,"url":"https://api.github.com/repos/Exabyte-io/wave.js","forks_url":"https://api.github.com/repos/Exabyte-io/wave.js/forks","keys_url":"https://api.github.com/repos/Exabyte-io/wave.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exabyte-io/wave.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exabyte-io/wave.js/teams","hooks_url":"https://api.github.com/repos/Exabyte-io/wave.js/hooks","issue_events_url":"https://api.github.com/repos/Exabyte-io/wave.js/issues/events{/number}","events_url":"https://api.github.com/repos/Exabyte-io/wave.js/events","assignees_url":"https://api.github.com/repos/Exabyte-io/wave.js/assignees{/user}","branches_url":"https://api.github.com/repos/Exabyte-io/wave.js/branches{/branch}","tags_url":"https://api.github.com/repos/Exabyte-io/wave.js/tags","blobs_url":"https://api.github.com/repos/Exabyte-io/wave.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exabyte-io/wave.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exabyte-io/wave.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exabyte-io/wave.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exabyte-io/wave.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Exabyte-io/wave.js/languages","stargazers_url":"https://api.github.com/repos/Exabyte-io/wave.js/stargazers","contributors_url":"https://api.github.com/repos/Exabyte-io/wave.js/contributors","subscribers_url":"https://api.github.com/repos/Exabyte-io/wave.js/subscribers","subscription_url":"https://api.github.com/repos/Exabyte-io/wave.js/subscription","commits_url":"https://api.github.com/repos/Exabyte-io/wave.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exabyte-io/wave.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exabyte-io/wave.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exabyte-io/wave.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exabyte-io/wave.js/contents/{+path}","compare_url":"https://api.github.com/repos/Exabyte-io/wave.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exabyte-io/wave.js/merges","archive_url":"https://api.github.com/repos/Exabyte-io/wave.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exabyte-io/wave.js/downloads","issues_url":"https://api.github.com/repos/Exabyte-io/wave.js/issues{/number}","pulls_url":"https://api.github.com/repos/Exabyte-io/wave.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Exabyte-io/wave.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Exabyte-io/wave.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exabyte-io/wave.js/labels{/name}","releases_url":"https://api.github.com/repos/Exabyte-io/wave.js/releases{/id}","deployments_url":"https://api.github.com/repos/Exabyte-io/wave.js/deployments","created_at":"2019-02-06T22:20:37Z","updated_at":"2019-04-03T02:42:16Z","pushed_at":"2019-04-13T00:20:55Z","git_url":"git://github.com/Exabyte-io/wave.js.git","ssh_url":"git@github.com:Exabyte-io/wave.js.git","clone_url":"https://github.com/Exabyte-io/wave.js.git","svn_url":"https://github.com/Exabyte-io/wave.js","homepage":null,"size":209,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/33"},"html":{"href":"https://github.com/Exabyte-io/wave.js/pull/33"},"issue":{"href":"https://api.github.com/repos/Exabyte-io/wave.js/issues/33"},"comments":{"href":"https://api.github.com/repos/Exabyte-io/wave.js/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Exabyte-io/wave.js/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/Exabyte-io/wave.js/statuses/112563ff15875334e91a11f2a9026e88837e787a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"timurbazhirov"}}