{"action":"created","comment":{"url":"https://api.github.com/repos/toolmantim/release-drafter/pulls/comments/279171456","pull_request_review_id":231441189,"id":279171456,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTE3MTQ1Ng==","diff_hunk":"@@ -139,27 +139,27 @@ exclude-labels:\n \n Pull requests with the label \"skip-changelog\" will now be excluded from the release draft.\n \n-## Projects that don't use Semantic Versioning\n+## Projects that don’t use Semantic Versioning\n \n-If your project doesn't follow [Semantic Versioning](https://semver.org) you can still use Release Drafter, but you may want to set the `version-template` option to customize how the `$NEXT_{PATCH,MINOR,MAJOR}_VERSION` environment variables are generated.\n+If your project doesn’t follow [Semantic Versioning](https://semver.org) you can still use Release Drafter, but you may want to set the `version-template` option to customize how the `$NEXT_{PATCH,MINOR,MAJOR}_VERSION` environment variables are generated.\n \n-For example, if your project doesn't use patch version numbers, you can set `version-template` to `$MAJOR.$MINOR`. If the current release is version 1.0, then `$NEXT_MINOR_VERSION` will be `1.1`.\n+For example, if your project doesn’t use patch version numbers, you can set `version-template` to `$MAJOR.$MINOR`. If the current release is version 1.0, then `$NEXT_MINOR_VERSION` will be `1.1`.\n \n ## Replacers\n \n-You can search and replace content in the generated changelog body using the `replacers` option. Replacers support searching via regular expressions with the `regex` option, and plain strings with the `search` option. Each replacer is applied in order.\n+You can search and replace content in the generated changelog body using the `replacers` option. Replacers support searching via regular expressions. Each replacer is applied in order.\n \n ```yml\n replacers:\n-  - regex: '/CVE-(\\d{4})-(\\d+)/g'\n+  - search: '/CVE-(\\d{4})-(\\d+)/g'","path":"README.md","position":37,"original_position":37,"commit_id":"c893ca2859762bdb643e3e46def21fcd09a949cb","original_commit_id":"c893ca2859762bdb643e3e46def21fcd09a949cb","user":{"login":"toolmantim","id":153,"node_id":"MDQ6VXNlcjE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/153?v=4","gravatar_id":"","url":"https://api.github.com/users/toolmantim","html_url":"https://github.com/toolmantim","followers_url":"https://api.github.com/users/toolmantim/followers","following_url":"https://api.github.com/users/toolmantim/following{/other_user}","gists_url":"https://api.github.com/users/toolmantim/gists{/gist_id}","starred_url":"https://api.github.com/users/toolmantim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolmantim/subscriptions","organizations_url":"https://api.github.com/users/toolmantim/orgs","repos_url":"https://api.github.com/users/toolmantim/repos","events_url":"https://api.github.com/users/toolmantim/events{/privacy}","received_events_url":"https://api.github.com/users/toolmantim/received_events","type":"User","site_admin":false},"body":"I think there might have been a misunderstanding, in that both @halkeye and myself assumed you wanted an explicit parameter (and I just trusted you both had talked through the design enough) 😁","created_at":"2019-04-27T23:20:28Z","updated_at":"2019-04-27T23:20:28Z","html_url":"https://github.com/toolmantim/release-drafter/pull/193#discussion_r279171456","pull_request_url":"https://api.github.com/repos/toolmantim/release-drafter/pulls/193","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/toolmantim/release-drafter/pulls/comments/279171456"},"html":{"href":"https://github.com/toolmantim/release-drafter/pull/193#discussion_r279171456"},"pull_request":{"href":"https://api.github.com/repos/toolmantim/release-drafter/pulls/193"}},"in_reply_to_id":279170285},"pull_request":{"url":"https://api.github.com/repos/toolmantim/release-drafter/pulls/193","id":274123773,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0MTIzNzcz","html_url":"https://github.com/toolmantim/release-drafter/pull/193","diff_url":"https://github.com/toolmantim/release-drafter/pull/193.diff","patch_url":"https://github.com/toolmantim/release-drafter/pull/193.patch","issue_url":"https://api.github.com/repos/toolmantim/release-drafter/issues/193","number":193,"state":"open","locked":false,"title":"add Schema to make error handling and validation easier","user":{"login":"casz","id":1661688,"node_id":"MDQ6VXNlcjE2NjE2ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1661688?v=4","gravatar_id":"","url":"https://api.github.com/users/casz","html_url":"https://github.com/casz","followers_url":"https://api.github.com/users/casz/followers","following_url":"https://api.github.com/users/casz/following{/other_user}","gists_url":"https://api.github.com/users/casz/gists{/gist_id}","starred_url":"https://api.github.com/users/casz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casz/subscriptions","organizations_url":"https://api.github.com/users/casz/orgs","repos_url":"https://api.github.com/users/casz/repos","events_url":"https://api.github.com/users/casz/events{/privacy}","received_events_url":"https://api.github.com/users/casz/received_events","type":"User","site_admin":false},"body":"The schema works. Tests are passing.\r\n\r\n@halkeye I chose to remove `regex` from the schema. The Joi schema logic got nasty with either `xor`, `rename` or inside the `template.js` with\r\n```\r\n    customReplacers.forEach(({ search, regex, replace }) => {\r\n      if (regex) search = regex\r\n      str = str.replace(search, replace)\r\n    })\r\n```\r\n\r\n@toolmantim @TimonVS feel free to add your suggestions\r\n\r\n- [x] add schema\r\n- [ ] Improve schema with errors and descriptions\r\n- [ ] add more schema tests","created_at":"2019-04-27T18:14:51Z","updated_at":"2019-04-27T23:20:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a81d4346468865a17fd485617540fce70925475","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/toolmantim/release-drafter/pulls/193/commits","review_comments_url":"https://api.github.com/repos/toolmantim/release-drafter/pulls/193/comments","review_comment_url":"https://api.github.com/repos/toolmantim/release-drafter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toolmantim/release-drafter/issues/193/comments","statuses_url":"https://api.github.com/repos/toolmantim/release-drafter/statuses/c893ca2859762bdb643e3e46def21fcd09a949cb","head":{"label":"casz:schema","ref":"schema","sha":"c893ca2859762bdb643e3e46def21fcd09a949cb","user":{"login":"casz","id":1661688,"node_id":"MDQ6VXNlcjE2NjE2ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1661688?v=4","gravatar_id":"","url":"https://api.github.com/users/casz","html_url":"https://github.com/casz","followers_url":"https://api.github.com/users/casz/followers","following_url":"https://api.github.com/users/casz/following{/other_user}","gists_url":"https://api.github.com/users/casz/gists{/gist_id}","starred_url":"https://api.github.com/users/casz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casz/subscriptions","organizations_url":"https://api.github.com/users/casz/orgs","repos_url":"https://api.github.com/users/casz/repos","events_url":"https://api.github.com/users/casz/events{/privacy}","received_events_url":"https://api.github.com/users/casz/received_events","type":"User","site_admin":false},"repo":{"id":178846911,"node_id":"MDEwOlJlcG9zaXRvcnkxNzg4NDY5MTE=","name":"release-drafter","full_name":"casz/release-drafter","private":false,"owner":{"login":"casz","id":1661688,"node_id":"MDQ6VXNlcjE2NjE2ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1661688?v=4","gravatar_id":"","url":"https://api.github.com/users/casz","html_url":"https://github.com/casz","followers_url":"https://api.github.com/users/casz/followers","following_url":"https://api.github.com/users/casz/following{/other_user}","gists_url":"https://api.github.com/users/casz/gists{/gist_id}","starred_url":"https://api.github.com/users/casz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casz/subscriptions","organizations_url":"https://api.github.com/users/casz/orgs","repos_url":"https://api.github.com/users/casz/repos","events_url":"https://api.github.com/users/casz/events{/privacy}","received_events_url":"https://api.github.com/users/casz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/casz/release-drafter","description":"Drafts your next release notes as pull requests are merged into master. ","fork":true,"url":"https://api.github.com/repos/casz/release-drafter","forks_url":"https://api.github.com/repos/casz/release-drafter/forks","keys_url":"https://api.github.com/repos/casz/release-drafter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/casz/release-drafter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/casz/release-drafter/teams","hooks_url":"https://api.github.com/repos/casz/release-drafter/hooks","issue_events_url":"https://api.github.com/repos/casz/release-drafter/issues/events{/number}","events_url":"https://api.github.com/repos/casz/release-drafter/events","assignees_url":"https://api.github.com/repos/casz/release-drafter/assignees{/user}","branches_url":"https://api.github.com/repos/casz/release-drafter/branches{/branch}","tags_url":"https://api.github.com/repos/casz/release-drafter/tags","blobs_url":"https://api.github.com/repos/casz/release-drafter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/casz/release-drafter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/casz/release-drafter/git/refs{/sha}","trees_url":"https://api.github.com/repos/casz/release-drafter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/casz/release-drafter/statuses/{sha}","languages_url":"https://api.github.com/repos/casz/release-drafter/languages","stargazers_url":"https://api.github.com/repos/casz/release-drafter/stargazers","contributors_url":"https://api.github.com/repos/casz/release-drafter/contributors","subscribers_url":"https://api.github.com/repos/casz/release-drafter/subscribers","subscription_url":"https://api.github.com/repos/casz/release-drafter/subscription","commits_url":"https://api.github.com/repos/casz/release-drafter/commits{/sha}","git_commits_url":"https://api.github.com/repos/casz/release-drafter/git/commits{/sha}","comments_url":"https://api.github.com/repos/casz/release-drafter/comments{/number}","issue_comment_url":"https://api.github.com/repos/casz/release-drafter/issues/comments{/number}","contents_url":"https://api.github.com/repos/casz/release-drafter/contents/{+path}","compare_url":"https://api.github.com/repos/casz/release-drafter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/casz/release-drafter/merges","archive_url":"https://api.github.com/repos/casz/release-drafter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/casz/release-drafter/downloads","issues_url":"https://api.github.com/repos/casz/release-drafter/issues{/number}","pulls_url":"https://api.github.com/repos/casz/release-drafter/pulls{/number}","milestones_url":"https://api.github.com/repos/casz/release-drafter/milestones{/number}","notifications_url":"https://api.github.com/repos/casz/release-drafter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/casz/release-drafter/labels{/name}","releases_url":"https://api.github.com/repos/casz/release-drafter/releases{/id}","deployments_url":"https://api.github.com/repos/casz/release-drafter/deployments","created_at":"2019-04-01T11:16:05Z","updated_at":"2019-04-17T04:09:54Z","pushed_at":"2019-04-27T22:17:55Z","git_url":"git://github.com/casz/release-drafter.git","ssh_url":"git@github.com:casz/release-drafter.git","clone_url":"https://github.com/casz/release-drafter.git","svn_url":"https://github.com/casz/release-drafter","homepage":"https://github.com/apps/release-drafter","size":1542,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"toolmantim:master","ref":"master","sha":"5b573591f9055ce2280b41f5fb1b35beb6350201","user":{"login":"toolmantim","id":153,"node_id":"MDQ6VXNlcjE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/153?v=4","gravatar_id":"","url":"https://api.github.com/users/toolmantim","html_url":"https://github.com/toolmantim","followers_url":"https://api.github.com/users/toolmantim/followers","following_url":"https://api.github.com/users/toolmantim/following{/other_user}","gists_url":"https://api.github.com/users/toolmantim/gists{/gist_id}","starred_url":"https://api.github.com/users/toolmantim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolmantim/subscriptions","organizations_url":"https://api.github.com/users/toolmantim/orgs","repos_url":"https://api.github.com/users/toolmantim/repos","events_url":"https://api.github.com/users/toolmantim/events{/privacy}","received_events_url":"https://api.github.com/users/toolmantim/received_events","type":"User","site_admin":false},"repo":{"id":139022359,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMjIzNTk=","name":"release-drafter","full_name":"toolmantim/release-drafter","private":false,"owner":{"login":"toolmantim","id":153,"node_id":"MDQ6VXNlcjE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/153?v=4","gravatar_id":"","url":"https://api.github.com/users/toolmantim","html_url":"https://github.com/toolmantim","followers_url":"https://api.github.com/users/toolmantim/followers","following_url":"https://api.github.com/users/toolmantim/following{/other_user}","gists_url":"https://api.github.com/users/toolmantim/gists{/gist_id}","starred_url":"https://api.github.com/users/toolmantim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolmantim/subscriptions","organizations_url":"https://api.github.com/users/toolmantim/orgs","repos_url":"https://api.github.com/users/toolmantim/repos","events_url":"https://api.github.com/users/toolmantim/events{/privacy}","received_events_url":"https://api.github.com/users/toolmantim/received_events","type":"User","site_admin":false},"html_url":"https://github.com/toolmantim/release-drafter","description":"Drafts your next release notes as pull requests are merged into master. ","fork":false,"url":"https://api.github.com/repos/toolmantim/release-drafter","forks_url":"https://api.github.com/repos/toolmantim/release-drafter/forks","keys_url":"https://api.github.com/repos/toolmantim/release-drafter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toolmantim/release-drafter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toolmantim/release-drafter/teams","hooks_url":"https://api.github.com/repos/toolmantim/release-drafter/hooks","issue_events_url":"https://api.github.com/repos/toolmantim/release-drafter/issues/events{/number}","events_url":"https://api.github.com/repos/toolmantim/release-drafter/events","assignees_url":"https://api.github.com/repos/toolmantim/release-drafter/assignees{/user}","branches_url":"https://api.github.com/repos/toolmantim/release-drafter/branches{/branch}","tags_url":"https://api.github.com/repos/toolmantim/release-drafter/tags","blobs_url":"https://api.github.com/repos/toolmantim/release-drafter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toolmantim/release-drafter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toolmantim/release-drafter/git/refs{/sha}","trees_url":"https://api.github.com/repos/toolmantim/release-drafter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toolmantim/release-drafter/statuses/{sha}","languages_url":"https://api.github.com/repos/toolmantim/release-drafter/languages","stargazers_url":"https://api.github.com/repos/toolmantim/release-drafter/stargazers","contributors_url":"https://api.github.com/repos/toolmantim/release-drafter/contributors","subscribers_url":"https://api.github.com/repos/toolmantim/release-drafter/subscribers","subscription_url":"https://api.github.com/repos/toolmantim/release-drafter/subscription","commits_url":"https://api.github.com/repos/toolmantim/release-drafter/commits{/sha}","git_commits_url":"https://api.github.com/repos/toolmantim/release-drafter/git/commits{/sha}","comments_url":"https://api.github.com/repos/toolmantim/release-drafter/comments{/number}","issue_comment_url":"https://api.github.com/repos/toolmantim/release-drafter/issues/comments{/number}","contents_url":"https://api.github.com/repos/toolmantim/release-drafter/contents/{+path}","compare_url":"https://api.github.com/repos/toolmantim/release-drafter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toolmantim/release-drafter/merges","archive_url":"https://api.github.com/repos/toolmantim/release-drafter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toolmantim/release-drafter/downloads","issues_url":"https://api.github.com/repos/toolmantim/release-drafter/issues{/number}","pulls_url":"https://api.github.com/repos/toolmantim/release-drafter/pulls{/number}","milestones_url":"https://api.github.com/repos/toolmantim/release-drafter/milestones{/number}","notifications_url":"https://api.github.com/repos/toolmantim/release-drafter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toolmantim/release-drafter/labels{/name}","releases_url":"https://api.github.com/repos/toolmantim/release-drafter/releases{/id}","deployments_url":"https://api.github.com/repos/toolmantim/release-drafter/deployments","created_at":"2018-06-28T13:31:05Z","updated_at":"2019-04-27T13:59:25Z","pushed_at":"2019-04-27T22:17:56Z","git_url":"git://github.com/toolmantim/release-drafter.git","ssh_url":"git@github.com:toolmantim/release-drafter.git","clone_url":"https://github.com/toolmantim/release-drafter.git","svn_url":"https://github.com/toolmantim/release-drafter","homepage":"https://github.com/apps/release-drafter","size":1548,"stargazers_count":479,"watchers_count":479,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":24,"open_issues":19,"watchers":479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/toolmantim/release-drafter/pulls/193"},"html":{"href":"https://github.com/toolmantim/release-drafter/pull/193"},"issue":{"href":"https://api.github.com/repos/toolmantim/release-drafter/issues/193"},"comments":{"href":"https://api.github.com/repos/toolmantim/release-drafter/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/toolmantim/release-drafter/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/toolmantim/release-drafter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toolmantim/release-drafter/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/toolmantim/release-drafter/statuses/c893ca2859762bdb643e3e46def21fcd09a949cb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"toolmantim"}}