{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/aks-engine/issues/1088","repository_url":"https://api.github.com/repos/Azure/aks-engine","labels_url":"https://api.github.com/repos/Azure/aks-engine/issues/1088/labels{/name}","comments_url":"https://api.github.com/repos/Azure/aks-engine/issues/1088/comments","events_url":"https://api.github.com/repos/Azure/aks-engine/issues/1088/events","html_url":"https://github.com/Azure/aks-engine/pull/1088","id":434562332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxNTI4Nzg4","number":1088,"title":"fix: commit generated go-bindata files with \"--no-compress\" option","user":{"login":"andyliuliming","id":339728,"node_id":"MDQ6VXNlcjMzOTcyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/339728?v=4","gravatar_id":"","url":"https://api.github.com/users/andyliuliming","html_url":"https://github.com/andyliuliming","followers_url":"https://api.github.com/users/andyliuliming/followers","following_url":"https://api.github.com/users/andyliuliming/following{/other_user}","gists_url":"https://api.github.com/users/andyliuliming/gists{/gist_id}","starred_url":"https://api.github.com/users/andyliuliming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyliuliming/subscriptions","organizations_url":"https://api.github.com/users/andyliuliming/orgs","repos_url":"https://api.github.com/users/andyliuliming/repos","events_url":"https://api.github.com/users/andyliuliming/events{/privacy}","received_events_url":"https://api.github.com/users/andyliuliming/received_events","type":"User","site_admin":false},"labels":[{"id":1128153706,"node_id":"MDU6TGFiZWwxMTI4MTUzNzA2","url":"https://api.github.com/repos/Azure/aks-engine/labels/approved","name":"approved","color":"5df7c4","default":false},{"id":1128999543,"node_id":"MDU6TGFiZWwxMTI4OTk5NTQz","url":"https://api.github.com/repos/Azure/aks-engine/labels/size/XXL","name":"size/XXL","color":"ddc433","default":false}],"state":"open","locked":false,"assignee":{"login":"mboersma","id":73019,"node_id":"MDQ6VXNlcjczMDE5","avatar_url":"https://avatars0.githubusercontent.com/u/73019?v=4","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"assignees":[{"login":"mboersma","id":73019,"node_id":"MDQ6VXNlcjczMDE5","avatar_url":"https://avatars0.githubusercontent.com/u/73019?v=4","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false}],"milestone":null,"comments":28,"created_at":"2019-04-18T02:27:18Z","updated_at":"2019-05-07T13:23:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Azure/aks-engine/pulls/1088","html_url":"https://github.com/Azure/aks-engine/pull/1088","diff_url":"https://github.com/Azure/aks-engine/pull/1088.diff","patch_url":"https://github.com/Azure/aks-engine/pull/1088.patch"},"body":"so do go-bindata here will help projects which vendored aks-engine.\r\nand add no-compress option to go-bindata, so we will not need to rebase it everytime.\r\n\r\n<!-- Thank you for helping aks-engine with a pull request!\r\nUse conventional commit messages, such as\r\n  feat: add a knob to the frobnitz\r\nor\r\n  fix: repair hole in wumpus\r\nAnd read this for faster PR reviews: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#best-practices-for-faster-reviews -->\r\n\r\n**Reason for Change**:\r\n<!-- What does this PR improve or fix in aks-engine? -->\r\n\r\n\r\n**Issue Fixed**:\r\n<!-- If this PR fixes GitHub issue 1234, add \"Fixes #1234\" to the next line. -->\r\n\r\n\r\n**Requirements**:\r\n<!-- Put an \"X\" character inside the brackets of each completed task. Some may be optional depending on the PR. -->\r\n\r\n- [ ] uses [conventional commit messages](https://www.conventionalcommits.org/)\r\n  <!-- Common commit types:\r\n        build: Build 🏭\r\n        chore: Maintenance 🔧\r\n        ci: Continuous Integration 💜\r\n        docs: Documentation 📘\r\n        feat: Features 🌈\r\n        fix: Bug Fixes 🐞\r\n        perf: Performance Improvements 🚀\r\n        refactor: Code Refactoring 💎\r\n        revert: Revert Change ◀️\r\n        style: Code Style 🎶\r\n        test: Testing 💚 -->\r\n- [ ] includes documentation\r\n- [ ] adds unit tests\r\n- [ ] tested upgrade from previous version\r\n\r\n**Notes**:\r\n"},"comment":{"url":"https://api.github.com/repos/Azure/aks-engine/issues/comments/490077609","html_url":"https://github.com/Azure/aks-engine/pull/1088#issuecomment-490077609","issue_url":"https://api.github.com/repos/Azure/aks-engine/issues/1088","id":490077609,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MDA3NzYwOQ==","user":{"login":"andyliuliming","id":339728,"node_id":"MDQ6VXNlcjMzOTcyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/339728?v=4","gravatar_id":"","url":"https://api.github.com/users/andyliuliming","html_url":"https://github.com/andyliuliming","followers_url":"https://api.github.com/users/andyliuliming/followers","following_url":"https://api.github.com/users/andyliuliming/following{/other_user}","gists_url":"https://api.github.com/users/andyliuliming/gists{/gist_id}","starred_url":"https://api.github.com/users/andyliuliming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyliuliming/subscriptions","organizations_url":"https://api.github.com/users/andyliuliming/orgs","repos_url":"https://api.github.com/users/andyliuliming/repos","events_url":"https://api.github.com/users/andyliuliming/events{/privacy}","received_events_url":"https://api.github.com/users/andyliuliming/received_events","type":"User","site_admin":false},"created_at":"2019-05-07T13:23:59Z","updated_at":"2019-05-07T13:23:59Z","author_association":"MEMBER","body":"@mboersma @CecileRobertMichon any updates?\r\ndo you mind grant me the permission to trigger the pipeline, so I can do a test on if the \"merge conflicts\" will happen on a separate branch."}}
{"actor":{"display_login":"andyliuliming"}}