{"action":"closed","issue":{"url":"https://api.github.com/repos/prabirshrestha/vim-lsp/issues/340","repository_url":"https://api.github.com/repos/prabirshrestha/vim-lsp","labels_url":"https://api.github.com/repos/prabirshrestha/vim-lsp/issues/340/labels{/name}","comments_url":"https://api.github.com/repos/prabirshrestha/vim-lsp/issues/340/comments","events_url":"https://api.github.com/repos/prabirshrestha/vim-lsp/issues/340/events","html_url":"https://github.com/prabirshrestha/vim-lsp/issues/340","id":420731712,"node_id":"MDU6SXNzdWU0MjA3MzE3MTI=","number":340,"title":"Virtual Text and Signs highlight defaults don't work","user":{"login":"aktau","id":189413,"node_id":"MDQ6VXNlcjE4OTQxMw==","avatar_url":"https://avatars0.githubusercontent.com/u/189413?v=4","gravatar_id":"","url":"https://api.github.com/users/aktau","html_url":"https://github.com/aktau","followers_url":"https://api.github.com/users/aktau/followers","following_url":"https://api.github.com/users/aktau/following{/other_user}","gists_url":"https://api.github.com/users/aktau/gists{/gist_id}","starred_url":"https://api.github.com/users/aktau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aktau/subscriptions","organizations_url":"https://api.github.com/users/aktau/orgs","repos_url":"https://api.github.com/users/aktau/repos","events_url":"https://api.github.com/users/aktau/events{/privacy}","received_events_url":"https://api.github.com/users/aktau/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-03-13T21:39:20Z","updated_at":"2019-03-16T18:14:24Z","closed_at":"2019-03-16T18:14:24Z","author_association":"NONE","body":"Sorry for not sending a PR but it's been a long time since I properly used GitHub and moreover I wasn't sure if what I'm seeing is intentional. From `signs.vim` and `virtual.vim`:\r\n\r\n```vim\r\nlet s:severity_sign_names_mapping = {\r\n    \\ 1: 'LspError',\r\n    \\ 2: 'LspWarning',\r\n    \\ 3: 'LspInformation',\r\n    \\ 4: 'LspHint',\r\n    \\ }\r\n\r\nif !hlexists('LspErrorText')\r\n    highlight link LspErrorText Error\r\nendif\r\n\r\n\" ...\r\n```\r\n\r\nBasically the mapping says `LspWarning` but the highlight linking is for LspError**Text**, which is not the same thing. As a result, the virtual text in my editor for diagnostic warnings is \"normal\", making it look very strange as it's not spaced apart far from EOL. Was it the intention to do:\r\n\r\n```vim\r\nif !hlexists('LspError')\r\n    highlight link LspError Error\r\nendif\r\n```\r\n\r\nInstead?"}}
{"actor":{"display_login":"prabirshrestha"}}