{"action":"created","comment":{"url":"https://api.github.com/repos/apollographql/apollo-android/pulls/comments/361331262","pull_request_review_id":336381441,"id":361331262,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTMzMTI2Mg==","diff_hunk":"@@ -36,6 +36,7 @@ dependencies {\n   add(\"implementation\", \"com.apollographql.apollo:apollo-rx2-support\")\n   add(\"implementation\", \"com.apollographql.apollo:apollo-coroutines-support\")\n   add(\"implementation\", \"com.apollographql.apollo:apollo-http-cache\")\n+  add(\"implementation\", \"com.apollographql.apollo:apollo-compiler\")","path":"apollo-integration/build.gradle.kts","position":13,"original_position":4,"commit_id":"2c9672d966992dab93102af8ad6698c8c9724d58","original_commit_id":"dd95a041c881bad2f5ce2bfa59cbfaaca77f6058","user":{"login":"martinbonnin","id":3974977,"node_id":"MDQ6VXNlcjM5NzQ5Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3974977?v=4","gravatar_id":"","url":"https://api.github.com/users/martinbonnin","html_url":"https://github.com/martinbonnin","followers_url":"https://api.github.com/users/martinbonnin/followers","following_url":"https://api.github.com/users/martinbonnin/following{/other_user}","gists_url":"https://api.github.com/users/martinbonnin/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbonnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbonnin/subscriptions","organizations_url":"https://api.github.com/users/martinbonnin/orgs","repos_url":"https://api.github.com/users/martinbonnin/repos","events_url":"https://api.github.com/users/martinbonnin/events{/privacy}","received_events_url":"https://api.github.com/users/martinbonnin/received_events","type":"User","site_admin":false},"body":"I just removed the `antlr-runtime` dependency from apollo-compiler altogether 🤷‍♂: https://github.com/apollographql/apollo-android/pull/1859/commits/2c9672d966992dab93102af8ad6698c8c9724d58#diff-8d72e2bd6e0f687326024c0f1306de87L18\r\n\r\nWhat's weird is that both `antlr` and `antlr-runtime` seem to include the same duplicate classes. I would have expected one to depend on the other. Anyways, it looks like it fixed the build.\r\n ","created_at":"2019-12-25T18:17:07Z","updated_at":"2019-12-25T18:17:07Z","html_url":"https://github.com/apollographql/apollo-android/pull/1859#discussion_r361331262","pull_request_url":"https://api.github.com/repos/apollographql/apollo-android/pulls/1859","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/comments/361331262"},"html":{"href":"https://github.com/apollographql/apollo-android/pull/1859#discussion_r361331262"},"pull_request":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/1859"}},"in_reply_to_id":361216656},"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-android/pulls/1859","id":353171118,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMTcxMTE4","html_url":"https://github.com/apollographql/apollo-android/pull/1859","diff_url":"https://github.com/apollographql/apollo-android/pull/1859.diff","patch_url":"https://github.com/apollographql/apollo-android/pull/1859.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-android/issues/1859","number":1859,"state":"open","locked":false,"title":"Remove transformed queries","user":{"login":"martinbonnin","id":3974977,"node_id":"MDQ6VXNlcjM5NzQ5Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3974977?v=4","gravatar_id":"","url":"https://api.github.com/users/martinbonnin","html_url":"https://github.com/martinbonnin","followers_url":"https://api.github.com/users/martinbonnin/followers","following_url":"https://api.github.com/users/martinbonnin/following{/other_user}","gists_url":"https://api.github.com/users/martinbonnin/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbonnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbonnin/subscriptions","organizations_url":"https://api.github.com/users/martinbonnin/orgs","repos_url":"https://api.github.com/users/martinbonnin/repos","events_url":"https://api.github.com/users/martinbonnin/events{/privacy}","received_events_url":"https://api.github.com/users/martinbonnin/received_events","type":"User","site_admin":false},"body":"Now that https://github.com/apollographql/apollo-android/pull/1841 is merged, this PR can be merged.\r\n\r\nThis PR:\r\n\r\n* removes the transformed queries as `operationOutput.json` contains more data\r\n* makes `operationOutputFile` a `RegularFileProperty` instead of a `DirectoryProperty`\r\n* adds `OperationOutput(File)` to transform OperationOutput.json to data structures easier to work with. There an exemple in the integration tests: https://github.com/apollographql/apollo-android/compare/master...martinbonnin:remove-transformed-queries?expand=1#diff-2966339ccc9c3f57b884f0a635458863R12. Would that be ok ?","created_at":"2019-12-14T12:25:05Z","updated_at":"2019-12-25T18:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1acd3200abe92ddf4d4ba5465af00796ed81b743","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollographql/apollo-android/pulls/1859/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-android/pulls/1859/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-android/issues/1859/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-android/statuses/2c9672d966992dab93102af8ad6698c8c9724d58","head":{"label":"martinbonnin:remove-transformed-queries","ref":"remove-transformed-queries","sha":"2c9672d966992dab93102af8ad6698c8c9724d58","user":{"login":"martinbonnin","id":3974977,"node_id":"MDQ6VXNlcjM5NzQ5Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3974977?v=4","gravatar_id":"","url":"https://api.github.com/users/martinbonnin","html_url":"https://github.com/martinbonnin","followers_url":"https://api.github.com/users/martinbonnin/followers","following_url":"https://api.github.com/users/martinbonnin/following{/other_user}","gists_url":"https://api.github.com/users/martinbonnin/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbonnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbonnin/subscriptions","organizations_url":"https://api.github.com/users/martinbonnin/orgs","repos_url":"https://api.github.com/users/martinbonnin/repos","events_url":"https://api.github.com/users/martinbonnin/events{/privacy}","received_events_url":"https://api.github.com/users/martinbonnin/received_events","type":"User","site_admin":false},"repo":{"id":80289679,"node_id":"MDEwOlJlcG9zaXRvcnk4MDI4OTY3OQ==","name":"apollo-android","full_name":"martinbonnin/apollo-android","private":false,"owner":{"login":"martinbonnin","id":3974977,"node_id":"MDQ6VXNlcjM5NzQ5Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/3974977?v=4","gravatar_id":"","url":"https://api.github.com/users/martinbonnin","html_url":"https://github.com/martinbonnin","followers_url":"https://api.github.com/users/martinbonnin/followers","following_url":"https://api.github.com/users/martinbonnin/following{/other_user}","gists_url":"https://api.github.com/users/martinbonnin/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbonnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbonnin/subscriptions","organizations_url":"https://api.github.com/users/martinbonnin/orgs","repos_url":"https://api.github.com/users/martinbonnin/repos","events_url":"https://api.github.com/users/martinbonnin/events{/privacy}","received_events_url":"https://api.github.com/users/martinbonnin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/martinbonnin/apollo-android","description":":pager: A GraphQL client for Android (WIP)","fork":true,"url":"https://api.github.com/repos/martinbonnin/apollo-android","forks_url":"https://api.github.com/repos/martinbonnin/apollo-android/forks","keys_url":"https://api.github.com/repos/martinbonnin/apollo-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinbonnin/apollo-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinbonnin/apollo-android/teams","hooks_url":"https://api.github.com/repos/martinbonnin/apollo-android/hooks","issue_events_url":"https://api.github.com/repos/martinbonnin/apollo-android/issues/events{/number}","events_url":"https://api.github.com/repos/martinbonnin/apollo-android/events","assignees_url":"https://api.github.com/repos/martinbonnin/apollo-android/assignees{/user}","branches_url":"https://api.github.com/repos/martinbonnin/apollo-android/branches{/branch}","tags_url":"https://api.github.com/repos/martinbonnin/apollo-android/tags","blobs_url":"https://api.github.com/repos/martinbonnin/apollo-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinbonnin/apollo-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinbonnin/apollo-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinbonnin/apollo-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinbonnin/apollo-android/statuses/{sha}","languages_url":"https://api.github.com/repos/martinbonnin/apollo-android/languages","stargazers_url":"https://api.github.com/repos/martinbonnin/apollo-android/stargazers","contributors_url":"https://api.github.com/repos/martinbonnin/apollo-android/contributors","subscribers_url":"https://api.github.com/repos/martinbonnin/apollo-android/subscribers","subscription_url":"https://api.github.com/repos/martinbonnin/apollo-android/subscription","commits_url":"https://api.github.com/repos/martinbonnin/apollo-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinbonnin/apollo-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinbonnin/apollo-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinbonnin/apollo-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinbonnin/apollo-android/contents/{+path}","compare_url":"https://api.github.com/repos/martinbonnin/apollo-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinbonnin/apollo-android/merges","archive_url":"https://api.github.com/repos/martinbonnin/apollo-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinbonnin/apollo-android/downloads","issues_url":"https://api.github.com/repos/martinbonnin/apollo-android/issues{/number}","pulls_url":"https://api.github.com/repos/martinbonnin/apollo-android/pulls{/number}","milestones_url":"https://api.github.com/repos/martinbonnin/apollo-android/milestones{/number}","notifications_url":"https://api.github.com/repos/martinbonnin/apollo-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinbonnin/apollo-android/labels{/name}","releases_url":"https://api.github.com/repos/martinbonnin/apollo-android/releases{/id}","deployments_url":"https://api.github.com/repos/martinbonnin/apollo-android/deployments","created_at":"2017-01-28T14:45:10Z","updated_at":"2018-12-01T17:57:40Z","pushed_at":"2019-12-25T18:04:46Z","git_url":"git://github.com/martinbonnin/apollo-android.git","ssh_url":"git@github.com:martinbonnin/apollo-android.git","clone_url":"https://github.com/martinbonnin/apollo-android.git","svn_url":"https://github.com/martinbonnin/apollo-android","homepage":"","size":143391,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apollographql:master","ref":"master","sha":"e910d625c00ace1e71478a961e5d088389822721","user":{"login":"apollographql","id":17189275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTg5Mjc1","avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":69469299,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQ2OTI5OQ==","name":"apollo-android","full_name":"apollographql/apollo-android","private":false,"owner":{"login":"apollographql","id":17189275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTg5Mjc1","avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apollographql/apollo-android","description":":pager: A strongly-typed, caching GraphQL client for Android and the JVM","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-android","forks_url":"https://api.github.com/repos/apollographql/apollo-android/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-android/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-android/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-android/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-android/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-android/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-android/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-android/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-android/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-android/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-android/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-android/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-android/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-android/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-android/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-android/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-android/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-android/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-android/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-android/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-android/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-android/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-android/deployments","created_at":"2016-09-28T14:03:30Z","updated_at":"2019-12-25T09:12:00Z","pushed_at":"2019-12-25T18:04:48Z","git_url":"git://github.com/apollographql/apollo-android.git","ssh_url":"git@github.com:apollographql/apollo-android.git","clone_url":"https://github.com/apollographql/apollo-android.git","svn_url":"https://github.com/apollographql/apollo-android","homepage":"","size":143332,"stargazers_count":2009,"watchers_count":2009,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":384,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":91,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":384,"open_issues":91,"watchers":2009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/1859"},"html":{"href":"https://github.com/apollographql/apollo-android/pull/1859"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-android/issues/1859"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-android/issues/1859/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/1859/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/1859/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-android/statuses/2c9672d966992dab93102af8ad6698c8c9724d58"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"martinbonnin"}}