{"action":"created","issue":{"url":"https://api.github.com/repos/confluence-publisher/confluence-publisher/issues/196","repository_url":"https://api.github.com/repos/confluence-publisher/confluence-publisher","labels_url":"https://api.github.com/repos/confluence-publisher/confluence-publisher/issues/196/labels{/name}","comments_url":"https://api.github.com/repos/confluence-publisher/confluence-publisher/issues/196/comments","events_url":"https://api.github.com/repos/confluence-publisher/confluence-publisher/issues/196/events","html_url":"https://github.com/confluence-publisher/confluence-publisher/issues/196","id":516123024,"node_id":"MDU6SXNzdWU1MTYxMjMwMjQ=","number":196,"title":"Client: Make deletion of existing sub-pages optional","user":{"login":"znerd","id":117866,"node_id":"MDQ6VXNlcjExNzg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/117866?v=4","gravatar_id":"","url":"https://api.github.com/users/znerd","html_url":"https://github.com/znerd","followers_url":"https://api.github.com/users/znerd/followers","following_url":"https://api.github.com/users/znerd/following{/other_user}","gists_url":"https://api.github.com/users/znerd/gists{/gist_id}","starred_url":"https://api.github.com/users/znerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/znerd/subscriptions","organizations_url":"https://api.github.com/users/znerd/orgs","repos_url":"https://api.github.com/users/znerd/repos","events_url":"https://api.github.com/users/znerd/events{/privacy}","received_events_url":"https://api.github.com/users/znerd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-11-01T13:47:46Z","updated_at":"2019-11-01T13:50:14Z","closed_at":null,"author_association":"NONE","body":"Currently the Confluence Publisher Client (the Java library) _always_ deletes all existing child pages under the ancestor, when the `APPEND_TO_ANCESTOR` publishing strategy is used.\r\n\r\nHowever, sometimes it makes sense to just append new pages, and not remove the existing ones. For example, when generating a daily report and adding it below a predefined ancestor page.\r\n\r\nTherefore, please make it possible to disable that behavior.\r\n\r\nRelevant observations:\r\n- the method `ConfluencePublisher.deleteConfluencePagesNotPresentUnderAncestor()` is effectively only invoked from `startPublishingUnderAncestorId()` (and then also recursively), so it should be easy to implement the conditional"},"comment":{"url":"https://api.github.com/repos/confluence-publisher/confluence-publisher/issues/comments/548794500","html_url":"https://github.com/confluence-publisher/confluence-publisher/issues/196#issuecomment-548794500","issue_url":"https://api.github.com/repos/confluence-publisher/confluence-publisher/issues/196","id":548794500,"node_id":"MDEyOklzc3VlQ29tbWVudDU0ODc5NDUwMA==","user":{"login":"znerd","id":117866,"node_id":"MDQ6VXNlcjExNzg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/117866?v=4","gravatar_id":"","url":"https://api.github.com/users/znerd","html_url":"https://github.com/znerd","followers_url":"https://api.github.com/users/znerd/followers","following_url":"https://api.github.com/users/znerd/following{/other_user}","gists_url":"https://api.github.com/users/znerd/gists{/gist_id}","starred_url":"https://api.github.com/users/znerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/znerd/subscriptions","organizations_url":"https://api.github.com/users/znerd/orgs","repos_url":"https://api.github.com/users/znerd/repos","events_url":"https://api.github.com/users/znerd/events{/privacy}","received_events_url":"https://api.github.com/users/znerd/received_events","type":"User","site_admin":false},"created_at":"2019-11-01T13:50:14Z","updated_at":"2019-11-01T13:50:14Z","author_association":"NONE","body":"The `boolean` that influences the new conditional should be stored somewhere.\r\n\r\nThe simplest approach seems to be to add a 3rd enum in the `ConfluencePublisherStrategy`, e.g. `APPEND_TO_ANCESTOR_KEEP_CHILDREN`.\r\n\r\nNot the most forward-looking solution, but it's the simplest at this point in time."}}
{"actor":{"display_login":"znerd"}}