{"action":"created","comment":{"url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/comments/316158237","pull_request_review_id":277760304,"id":316158237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjE1ODIzNw==","diff_hunk":"@@ -506,22 +507,25 @@ class ValidationTest\n                    _ <- Validation[Task].parents(b3, genesisBlockHash, dag)\n                    _ <- Validation[Task].parents(b4, genesisBlockHash, dag)\n                    _ <- Validation[Task].parents(b5, genesisBlockHash, dag)\n-                   _ <- Validation[Task].parents(b6, genesisBlockHash, dag)","path":"casper/src/test/scala/io/casperlabs/casper/ValidationTest.scala","position":41,"original_position":41,"commit_id":"38e8b794bec1a3c6320015876f105238dc028c48","original_commit_id":"38e8b794bec1a3c6320015876f105238dc028c48","user":{"login":"goral09","id":5120801,"node_id":"MDQ6VXNlcjUxMjA4MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5120801?v=4","gravatar_id":"","url":"https://api.github.com/users/goral09","html_url":"https://github.com/goral09","followers_url":"https://api.github.com/users/goral09/followers","following_url":"https://api.github.com/users/goral09/following{/other_user}","gists_url":"https://api.github.com/users/goral09/gists{/gist_id}","starred_url":"https://api.github.com/users/goral09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goral09/subscriptions","organizations_url":"https://api.github.com/users/goral09/orgs","repos_url":"https://api.github.com/users/goral09/repos","events_url":"https://api.github.com/users/goral09/events{/privacy}","received_events_url":"https://api.github.com/users/goral09/received_events","type":"User","site_admin":false},"body":"What happened with validation of **b6**?","created_at":"2019-08-21T12:33:37Z","updated_at":"2019-08-21T12:33:37Z","html_url":"https://github.com/CasperLabs/CasperLabs/pull/978#discussion_r316158237","pull_request_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/978","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/comments/316158237"},"html":{"href":"https://github.com/CasperLabs/CasperLabs/pull/978#discussion_r316158237"},"pull_request":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/978"}}},"pull_request":{"url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/978","id":309352971,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5MzUyOTcx","html_url":"https://github.com/CasperLabs/CasperLabs/pull/978","diff_url":"https://github.com/CasperLabs/CasperLabs/pull/978.diff","patch_url":"https://github.com/CasperLabs/CasperLabs/pull/978.patch","issue_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/978","number":978,"state":"open","locked":false,"title":"STOR-104: the created block's rank should be calculated from justification's rank.","user":{"login":"AbnerZheng","id":7604540,"node_id":"MDQ6VXNlcjc2MDQ1NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7604540?v=4","gravatar_id":"","url":"https://api.github.com/users/AbnerZheng","html_url":"https://github.com/AbnerZheng","followers_url":"https://api.github.com/users/AbnerZheng/followers","following_url":"https://api.github.com/users/AbnerZheng/following{/other_user}","gists_url":"https://api.github.com/users/AbnerZheng/gists{/gist_id}","starred_url":"https://api.github.com/users/AbnerZheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbnerZheng/subscriptions","organizations_url":"https://api.github.com/users/AbnerZheng/orgs","repos_url":"https://api.github.com/users/AbnerZheng/repos","events_url":"https://api.github.com/users/AbnerZheng/events{/privacy}","received_events_url":"https://api.github.com/users/AbnerZheng/received_events","type":"User","site_admin":false},"body":"### Overview\r\nWhen creating a block in the test, if we provide justifications, then its rank is max{rank of justifications} + 1, if not, then its rank is max{rank of parent} + 1. \r\n\r\n### Which JIRA ticket does this PR relate to?\r\nhttps://casperlabs.atlassian.net/browse/STOR-104\r\n\r\n### Complete this checklist before you submit this PR\r\n- [X] This PR contains no more than 200 lines of code, excluding test code.\r\n- [X] This PR meets [CasperLabs coding standards](https://casperlabs.atlassian.net/wiki/spaces/EN/pages/16842753/Coding+Standards).\r\n- [X] If this PR adds a new feature, it includes tests related to this feature.\r\n- [X] You assigned one person to review this PR.\r\n- [X] Your GitHub account is linked with our [Drone CI](http://drone.casperlabs.io/) system. This is necessary to run tests on this PR.\r\n\r\n### Notes\r\n_Optional. Add any notes on caveats, approaches you tried that didn't work, or anything else._\r\n","created_at":"2019-08-21T07:04:52Z","updated_at":"2019-08-21T12:33:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6f568a206155c9fd22b7197ab8b87675682aa22","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/978/commits","review_comments_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/978/comments","review_comment_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/978/comments","statuses_url":"https://api.github.com/repos/CasperLabs/CasperLabs/statuses/38e8b794bec1a3c6320015876f105238dc028c48","head":{"label":"CasperLabs:abner/STOR-104","ref":"abner/STOR-104","sha":"38e8b794bec1a3c6320015876f105238dc028c48","user":{"login":"CasperLabs","id":44785362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0Nzg1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/44785362?v=4","gravatar_id":"","url":"https://api.github.com/users/CasperLabs","html_url":"https://github.com/CasperLabs","followers_url":"https://api.github.com/users/CasperLabs/followers","following_url":"https://api.github.com/users/CasperLabs/following{/other_user}","gists_url":"https://api.github.com/users/CasperLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/CasperLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CasperLabs/subscriptions","organizations_url":"https://api.github.com/users/CasperLabs/orgs","repos_url":"https://api.github.com/users/CasperLabs/repos","events_url":"https://api.github.com/users/CasperLabs/events{/privacy}","received_events_url":"https://api.github.com/users/CasperLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":160243933,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyNDM5MzM=","name":"CasperLabs","full_name":"CasperLabs/CasperLabs","private":false,"owner":{"login":"CasperLabs","id":44785362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0Nzg1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/44785362?v=4","gravatar_id":"","url":"https://api.github.com/users/CasperLabs","html_url":"https://github.com/CasperLabs","followers_url":"https://api.github.com/users/CasperLabs/followers","following_url":"https://api.github.com/users/CasperLabs/following{/other_user}","gists_url":"https://api.github.com/users/CasperLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/CasperLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CasperLabs/subscriptions","organizations_url":"https://api.github.com/users/CasperLabs/orgs","repos_url":"https://api.github.com/users/CasperLabs/repos","events_url":"https://api.github.com/users/CasperLabs/events{/privacy}","received_events_url":"https://api.github.com/users/CasperLabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CasperLabs/CasperLabs","description":"CasperLabs Core","fork":false,"url":"https://api.github.com/repos/CasperLabs/CasperLabs","forks_url":"https://api.github.com/repos/CasperLabs/CasperLabs/forks","keys_url":"https://api.github.com/repos/CasperLabs/CasperLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CasperLabs/CasperLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CasperLabs/CasperLabs/teams","hooks_url":"https://api.github.com/repos/CasperLabs/CasperLabs/hooks","issue_events_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/events{/number}","events_url":"https://api.github.com/repos/CasperLabs/CasperLabs/events","assignees_url":"https://api.github.com/repos/CasperLabs/CasperLabs/assignees{/user}","branches_url":"https://api.github.com/repos/CasperLabs/CasperLabs/branches{/branch}","tags_url":"https://api.github.com/repos/CasperLabs/CasperLabs/tags","blobs_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CasperLabs/CasperLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/CasperLabs/CasperLabs/languages","stargazers_url":"https://api.github.com/repos/CasperLabs/CasperLabs/stargazers","contributors_url":"https://api.github.com/repos/CasperLabs/CasperLabs/contributors","subscribers_url":"https://api.github.com/repos/CasperLabs/CasperLabs/subscribers","subscription_url":"https://api.github.com/repos/CasperLabs/CasperLabs/subscription","commits_url":"https://api.github.com/repos/CasperLabs/CasperLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CasperLabs/CasperLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CasperLabs/CasperLabs/contents/{+path}","compare_url":"https://api.github.com/repos/CasperLabs/CasperLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CasperLabs/CasperLabs/merges","archive_url":"https://api.github.com/repos/CasperLabs/CasperLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CasperLabs/CasperLabs/downloads","issues_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues{/number}","pulls_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/CasperLabs/CasperLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/CasperLabs/CasperLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CasperLabs/CasperLabs/labels{/name}","releases_url":"https://api.github.com/repos/CasperLabs/CasperLabs/releases{/id}","deployments_url":"https://api.github.com/repos/CasperLabs/CasperLabs/deployments","created_at":"2018-12-03T19:39:20Z","updated_at":"2019-08-21T11:48:31Z","pushed_at":"2019-08-21T12:27:56Z","git_url":"git://github.com/CasperLabs/CasperLabs.git","ssh_url":"git@github.com:CasperLabs/CasperLabs.git","clone_url":"https://github.com/CasperLabs/CasperLabs.git","svn_url":"https://github.com/CasperLabs/CasperLabs","homepage":"","size":16281,"stargazers_count":56,"watchers_count":56,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":11,"watchers":56,"default_branch":"dev"}},"base":{"label":"CasperLabs:dev","ref":"dev","sha":"d094d6bc44f7add5d95ba2b554196283a67e74b7","user":{"login":"CasperLabs","id":44785362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0Nzg1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/44785362?v=4","gravatar_id":"","url":"https://api.github.com/users/CasperLabs","html_url":"https://github.com/CasperLabs","followers_url":"https://api.github.com/users/CasperLabs/followers","following_url":"https://api.github.com/users/CasperLabs/following{/other_user}","gists_url":"https://api.github.com/users/CasperLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/CasperLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CasperLabs/subscriptions","organizations_url":"https://api.github.com/users/CasperLabs/orgs","repos_url":"https://api.github.com/users/CasperLabs/repos","events_url":"https://api.github.com/users/CasperLabs/events{/privacy}","received_events_url":"https://api.github.com/users/CasperLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":160243933,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyNDM5MzM=","name":"CasperLabs","full_name":"CasperLabs/CasperLabs","private":false,"owner":{"login":"CasperLabs","id":44785362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0Nzg1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/44785362?v=4","gravatar_id":"","url":"https://api.github.com/users/CasperLabs","html_url":"https://github.com/CasperLabs","followers_url":"https://api.github.com/users/CasperLabs/followers","following_url":"https://api.github.com/users/CasperLabs/following{/other_user}","gists_url":"https://api.github.com/users/CasperLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/CasperLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CasperLabs/subscriptions","organizations_url":"https://api.github.com/users/CasperLabs/orgs","repos_url":"https://api.github.com/users/CasperLabs/repos","events_url":"https://api.github.com/users/CasperLabs/events{/privacy}","received_events_url":"https://api.github.com/users/CasperLabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CasperLabs/CasperLabs","description":"CasperLabs Core","fork":false,"url":"https://api.github.com/repos/CasperLabs/CasperLabs","forks_url":"https://api.github.com/repos/CasperLabs/CasperLabs/forks","keys_url":"https://api.github.com/repos/CasperLabs/CasperLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CasperLabs/CasperLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CasperLabs/CasperLabs/teams","hooks_url":"https://api.github.com/repos/CasperLabs/CasperLabs/hooks","issue_events_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/events{/number}","events_url":"https://api.github.com/repos/CasperLabs/CasperLabs/events","assignees_url":"https://api.github.com/repos/CasperLabs/CasperLabs/assignees{/user}","branches_url":"https://api.github.com/repos/CasperLabs/CasperLabs/branches{/branch}","tags_url":"https://api.github.com/repos/CasperLabs/CasperLabs/tags","blobs_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CasperLabs/CasperLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/CasperLabs/CasperLabs/languages","stargazers_url":"https://api.github.com/repos/CasperLabs/CasperLabs/stargazers","contributors_url":"https://api.github.com/repos/CasperLabs/CasperLabs/contributors","subscribers_url":"https://api.github.com/repos/CasperLabs/CasperLabs/subscribers","subscription_url":"https://api.github.com/repos/CasperLabs/CasperLabs/subscription","commits_url":"https://api.github.com/repos/CasperLabs/CasperLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CasperLabs/CasperLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CasperLabs/CasperLabs/contents/{+path}","compare_url":"https://api.github.com/repos/CasperLabs/CasperLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CasperLabs/CasperLabs/merges","archive_url":"https://api.github.com/repos/CasperLabs/CasperLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CasperLabs/CasperLabs/downloads","issues_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues{/number}","pulls_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/CasperLabs/CasperLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/CasperLabs/CasperLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CasperLabs/CasperLabs/labels{/name}","releases_url":"https://api.github.com/repos/CasperLabs/CasperLabs/releases{/id}","deployments_url":"https://api.github.com/repos/CasperLabs/CasperLabs/deployments","created_at":"2018-12-03T19:39:20Z","updated_at":"2019-08-21T11:48:31Z","pushed_at":"2019-08-21T12:27:56Z","git_url":"git://github.com/CasperLabs/CasperLabs.git","ssh_url":"git@github.com:CasperLabs/CasperLabs.git","clone_url":"https://github.com/CasperLabs/CasperLabs.git","svn_url":"https://github.com/CasperLabs/CasperLabs","homepage":"","size":16281,"stargazers_count":56,"watchers_count":56,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":11,"watchers":56,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/978"},"html":{"href":"https://github.com/CasperLabs/CasperLabs/pull/978"},"issue":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/978"},"comments":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/978/comments"},"review_comments":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/978/comments"},"review_comment":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/978/commits"},"statuses":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/statuses/38e8b794bec1a3c6320015876f105238dc028c48"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"goral09"}}