{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/14847","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/14847/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/14847/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/14847/events","html_url":"https://github.com/civicrm/civicrm-core/pull/14847","id":470625448,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5NTMwMzQz","number":14847,"title":"[REF] Down with php4 compatibility","user":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-07-20T02:32:54Z","updated_at":"2019-07-20T02:32:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/14847","html_url":"https://github.com/civicrm/civicrm-core/pull/14847","diff_url":"https://github.com/civicrm/civicrm-core/pull/14847.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/14847.patch"},"body":"Overview\r\n----------------------------------------\r\nRemoves a few more cases where parameters are needlessly passed as references\r\n\r\nBefore\r\n----------------------------------------\r\nBetter support for php4\r\n\r\nAfter\r\n----------------------------------------\r\nWorse support for php 4\r\n\r\nTechnical Details\r\n----------------------------------------\r\nPart of ongoing cleanup removing unnecessary pass-by-references (which allows code simplication). The key is to check whether the parameters are changes anywhere in the function - if not we are not achieving anything by passing by ref\r\n\r\nComments\r\n----------------------------------------\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/513428215","html_url":"https://github.com/civicrm/civicrm-core/pull/14847#issuecomment-513428215","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/14847","id":513428215,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMzQyODIxNQ==","user":{"login":"civibot[bot]","id":39925015,"node_id":"MDM6Qm90Mzk5MjUwMTU=","avatar_url":"https://avatars1.githubusercontent.com/in/13082?v=4","gravatar_id":"","url":"https://api.github.com/users/civibot%5Bbot%5D","html_url":"https://github.com/apps/civibot","followers_url":"https://api.github.com/users/civibot%5Bbot%5D/followers","following_url":"https://api.github.com/users/civibot%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/civibot%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/civibot%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civibot%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/civibot%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/civibot%5Bbot%5D/repos","events_url":"https://api.github.com/users/civibot%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/civibot%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-07-20T02:32:56Z","updated_at":"2019-07-20T02:32:56Z","author_association":"NONE","body":"(*Standard links*)\n\n* __If this is your first pull-request for CiviCRM__, please browse [CONTRIBUTING.md](https://github.com/civicrm/civicrm-core/blob/master/.github/CONTRIBUTING.md) for information about the development and testing processes.\n* __If you are reviewing this pull-request__, you may wish to consult the [test sites](http://site-list.test-1.civicrm.org/?filter=core-14847-*) and the [Review Standards](https://docs.civicrm.org/dev/en/latest/standards/review/) ([long template](https://civicrm.org/dev/review/template-del.md), [short template](https://civicrm.org/dev/review/template-word.md)).\n"}}
{"actor":{"display_login":"civibot"}}