{"action":"created","comment":{"url":"https://api.github.com/repos/stellar/go/pulls/comments/330211613","pull_request_review_id":295809427,"id":330211613,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMDIxMTYxMw==","diff_hunk":"@@ -84,6 +84,17 @@ func RegisterHost(host string) {\n \tServiceHost = host\n }\n \n+type ReportFunc func(context.Context, error)","path":"support/render/problem/problem.go","position":5,"original_position":4,"commit_id":"ce314f089d265a3209b1653758d63c48ff4adb5b","original_commit_id":"9b1356b8f8ddce644a4c5289098fe4005ed96564","user":{"login":"howardtw","id":8033797,"node_id":"MDQ6VXNlcjgwMzM3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8033797?v=4","gravatar_id":"","url":"https://api.github.com/users/howardtw","html_url":"https://github.com/howardtw","followers_url":"https://api.github.com/users/howardtw/followers","following_url":"https://api.github.com/users/howardtw/following{/other_user}","gists_url":"https://api.github.com/users/howardtw/gists{/gist_id}","starred_url":"https://api.github.com/users/howardtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardtw/subscriptions","organizations_url":"https://api.github.com/users/howardtw/orgs","repos_url":"https://api.github.com/users/howardtw/repos","events_url":"https://api.github.com/users/howardtw/events{/privacy}","received_events_url":"https://api.github.com/users/howardtw/received_events","type":"User","site_admin":false},"body":"https://github.com/stellar/go/pull/1795/commits/ce314f089d265a3209b1653758d63c48ff4adb5b","created_at":"2019-10-01T18:37:15Z","updated_at":"2019-10-01T18:37:16Z","html_url":"https://github.com/stellar/go/pull/1795#discussion_r330211613","pull_request_url":"https://api.github.com/repos/stellar/go/pulls/1795","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stellar/go/pulls/comments/330211613"},"html":{"href":"https://github.com/stellar/go/pull/1795#discussion_r330211613"},"pull_request":{"href":"https://api.github.com/repos/stellar/go/pulls/1795"}},"in_reply_to_id":330193771},"pull_request":{"url":"https://api.github.com/repos/stellar/go/pulls/1795","id":322989207,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyOTg5MjA3","html_url":"https://github.com/stellar/go/pull/1795","diff_url":"https://github.com/stellar/go/pull/1795.diff","patch_url":"https://github.com/stellar/go/pull/1795.patch","issue_url":"https://api.github.com/repos/stellar/go/issues/1795","number":1795,"state":"open","locked":false,"title":"support/render: report unregistered errors with Sentry or else","user":{"login":"howardtw","id":8033797,"node_id":"MDQ6VXNlcjgwMzM3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8033797?v=4","gravatar_id":"","url":"https://api.github.com/users/howardtw","html_url":"https://github.com/howardtw","followers_url":"https://api.github.com/users/howardtw/followers","following_url":"https://api.github.com/users/howardtw/following{/other_user}","gists_url":"https://api.github.com/users/howardtw/gists{/gist_id}","starred_url":"https://api.github.com/users/howardtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardtw/subscriptions","organizations_url":"https://api.github.com/users/howardtw/orgs","repos_url":"https://api.github.com/users/howardtw/repos","events_url":"https://api.github.com/users/howardtw/events{/privacy}","received_events_url":"https://api.github.com/users/howardtw/received_events","type":"User","site_admin":false},"body":"This PR introduces a function type `ReportFunc` used to report unknown errors as well as a global variable of that type. Once the variable initialized, `problem.Render` will use it to report the error.\r\n\r\nThis PR also introduces a Sentry package with a function that satisfies the function type mentioned above.\r\n\r\nApplications that wants to use Sentry can simply do `problem.RegisterReportFunc(Sentry.AsyncCapture)`.","created_at":"2019-09-30T21:46:44Z","updated_at":"2019-10-01T18:37:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a01a83df2d3ff6f82d0dcbd37adeedcef9af2cf6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bartekn","id":464938,"node_id":"MDQ6VXNlcjQ2NDkzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/464938?v=4","gravatar_id":"","url":"https://api.github.com/users/bartekn","html_url":"https://github.com/bartekn","followers_url":"https://api.github.com/users/bartekn/followers","following_url":"https://api.github.com/users/bartekn/following{/other_user}","gists_url":"https://api.github.com/users/bartekn/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekn/subscriptions","organizations_url":"https://api.github.com/users/bartekn/orgs","repos_url":"https://api.github.com/users/bartekn/repos","events_url":"https://api.github.com/users/bartekn/events{/privacy}","received_events_url":"https://api.github.com/users/bartekn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stellar/go/pulls/1795/commits","review_comments_url":"https://api.github.com/repos/stellar/go/pulls/1795/comments","review_comment_url":"https://api.github.com/repos/stellar/go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stellar/go/issues/1795/comments","statuses_url":"https://api.github.com/repos/stellar/go/statuses/ce314f089d265a3209b1653758d63c48ff4adb5b","head":{"label":"howardtw:sentry","ref":"sentry","sha":"ce314f089d265a3209b1653758d63c48ff4adb5b","user":{"login":"howardtw","id":8033797,"node_id":"MDQ6VXNlcjgwMzM3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8033797?v=4","gravatar_id":"","url":"https://api.github.com/users/howardtw","html_url":"https://github.com/howardtw","followers_url":"https://api.github.com/users/howardtw/followers","following_url":"https://api.github.com/users/howardtw/following{/other_user}","gists_url":"https://api.github.com/users/howardtw/gists{/gist_id}","starred_url":"https://api.github.com/users/howardtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardtw/subscriptions","organizations_url":"https://api.github.com/users/howardtw/orgs","repos_url":"https://api.github.com/users/howardtw/repos","events_url":"https://api.github.com/users/howardtw/events{/privacy}","received_events_url":"https://api.github.com/users/howardtw/received_events","type":"User","site_admin":false},"repo":{"id":166466162,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY0NjYxNjI=","name":"go","full_name":"howardtw/go","private":false,"owner":{"login":"howardtw","id":8033797,"node_id":"MDQ6VXNlcjgwMzM3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8033797?v=4","gravatar_id":"","url":"https://api.github.com/users/howardtw","html_url":"https://github.com/howardtw","followers_url":"https://api.github.com/users/howardtw/followers","following_url":"https://api.github.com/users/howardtw/following{/other_user}","gists_url":"https://api.github.com/users/howardtw/gists{/gist_id}","starred_url":"https://api.github.com/users/howardtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardtw/subscriptions","organizations_url":"https://api.github.com/users/howardtw/orgs","repos_url":"https://api.github.com/users/howardtw/repos","events_url":"https://api.github.com/users/howardtw/events{/privacy}","received_events_url":"https://api.github.com/users/howardtw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/howardtw/go","description":"Stellar's public monorepo of go code","fork":true,"url":"https://api.github.com/repos/howardtw/go","forks_url":"https://api.github.com/repos/howardtw/go/forks","keys_url":"https://api.github.com/repos/howardtw/go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/howardtw/go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/howardtw/go/teams","hooks_url":"https://api.github.com/repos/howardtw/go/hooks","issue_events_url":"https://api.github.com/repos/howardtw/go/issues/events{/number}","events_url":"https://api.github.com/repos/howardtw/go/events","assignees_url":"https://api.github.com/repos/howardtw/go/assignees{/user}","branches_url":"https://api.github.com/repos/howardtw/go/branches{/branch}","tags_url":"https://api.github.com/repos/howardtw/go/tags","blobs_url":"https://api.github.com/repos/howardtw/go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/howardtw/go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/howardtw/go/git/refs{/sha}","trees_url":"https://api.github.com/repos/howardtw/go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/howardtw/go/statuses/{sha}","languages_url":"https://api.github.com/repos/howardtw/go/languages","stargazers_url":"https://api.github.com/repos/howardtw/go/stargazers","contributors_url":"https://api.github.com/repos/howardtw/go/contributors","subscribers_url":"https://api.github.com/repos/howardtw/go/subscribers","subscription_url":"https://api.github.com/repos/howardtw/go/subscription","commits_url":"https://api.github.com/repos/howardtw/go/commits{/sha}","git_commits_url":"https://api.github.com/repos/howardtw/go/git/commits{/sha}","comments_url":"https://api.github.com/repos/howardtw/go/comments{/number}","issue_comment_url":"https://api.github.com/repos/howardtw/go/issues/comments{/number}","contents_url":"https://api.github.com/repos/howardtw/go/contents/{+path}","compare_url":"https://api.github.com/repos/howardtw/go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/howardtw/go/merges","archive_url":"https://api.github.com/repos/howardtw/go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/howardtw/go/downloads","issues_url":"https://api.github.com/repos/howardtw/go/issues{/number}","pulls_url":"https://api.github.com/repos/howardtw/go/pulls{/number}","milestones_url":"https://api.github.com/repos/howardtw/go/milestones{/number}","notifications_url":"https://api.github.com/repos/howardtw/go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/howardtw/go/labels{/name}","releases_url":"https://api.github.com/repos/howardtw/go/releases{/id}","deployments_url":"https://api.github.com/repos/howardtw/go/deployments","created_at":"2019-01-18T20:05:54Z","updated_at":"2019-10-01T16:44:23Z","pushed_at":"2019-10-01T18:36:14Z","git_url":"git://github.com/howardtw/go.git","ssh_url":"git@github.com:howardtw/go.git","clone_url":"https://github.com/howardtw/go.git","svn_url":"https://github.com/howardtw/go","homepage":"https://stellar.org/developers","size":28477,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stellar:master","ref":"master","sha":"828c132a75607ec7747c1ef9d5c44cfd65432003","user":{"login":"stellar","id":7386716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODY3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":64954128,"node_id":"MDEwOlJlcG9zaXRvcnk2NDk1NDEyOA==","name":"go","full_name":"stellar/go","private":false,"owner":{"login":"stellar","id":7386716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODY3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stellar/go","description":"Stellar's public monorepo of go code","fork":false,"url":"https://api.github.com/repos/stellar/go","forks_url":"https://api.github.com/repos/stellar/go/forks","keys_url":"https://api.github.com/repos/stellar/go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/go/teams","hooks_url":"https://api.github.com/repos/stellar/go/hooks","issue_events_url":"https://api.github.com/repos/stellar/go/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/go/events","assignees_url":"https://api.github.com/repos/stellar/go/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/go/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/go/tags","blobs_url":"https://api.github.com/repos/stellar/go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/go/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/go/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/go/languages","stargazers_url":"https://api.github.com/repos/stellar/go/stargazers","contributors_url":"https://api.github.com/repos/stellar/go/contributors","subscribers_url":"https://api.github.com/repos/stellar/go/subscribers","subscription_url":"https://api.github.com/repos/stellar/go/subscription","commits_url":"https://api.github.com/repos/stellar/go/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/go/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/go/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/go/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellar/go/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/go/merges","archive_url":"https://api.github.com/repos/stellar/go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/go/downloads","issues_url":"https://api.github.com/repos/stellar/go/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/go/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/go/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/go/labels{/name}","releases_url":"https://api.github.com/repos/stellar/go/releases{/id}","deployments_url":"https://api.github.com/repos/stellar/go/deployments","created_at":"2016-08-04T17:27:50Z","updated_at":"2019-10-01T16:11:35Z","pushed_at":"2019-10-01T18:36:16Z","git_url":"git://github.com/stellar/go.git","ssh_url":"git@github.com:stellar/go.git","clone_url":"https://github.com/stellar/go.git","svn_url":"https://github.com/stellar/go","homepage":"https://stellar.org/developers","size":28516,"stargazers_count":597,"watchers_count":597,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":332,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":215,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":332,"open_issues":215,"watchers":597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stellar/go/pulls/1795"},"html":{"href":"https://github.com/stellar/go/pull/1795"},"issue":{"href":"https://api.github.com/repos/stellar/go/issues/1795"},"comments":{"href":"https://api.github.com/repos/stellar/go/issues/1795/comments"},"review_comments":{"href":"https://api.github.com/repos/stellar/go/pulls/1795/comments"},"review_comment":{"href":"https://api.github.com/repos/stellar/go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stellar/go/pulls/1795/commits"},"statuses":{"href":"https://api.github.com/repos/stellar/go/statuses/ce314f089d265a3209b1653758d63c48ff4adb5b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"howardtw"}}