{"action":"created","comment":{"url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/comments/317077941","pull_request_review_id":278928329,"id":317077941,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNzA3Nzk0MQ==","diff_hunk":"@@ -0,0 +1,33 @@\n+/*\n+ * Copyright 2017-2018 original authors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+\n+package io.micronaut.configuration.vertx.mysql.client.condition;\n+\n+import io.micronaut.configuration.vertx.mysql.client.MySQLConnectionSettings;\n+import io.micronaut.context.annotation.Requires;\n+import io.vertx.mysqlclient.MySQLConnectOptions;\n+import io.vertx.sqlclient.PoolOptions;\n+\n+import java.lang.annotation.*;\n+\n+@Documented\n+@Retention(RetentionPolicy.RUNTIME)\n+@Target({ElementType.PACKAGE, ElementType.TYPE})\n+@Requires(property = MySQLConnectionSettings.PREFIX)","path":"vertx-mysql-client/src/main/java/io/micronaut/configuration/vertx/mysql/client/condition/RequiresVertxMySQLClient.java","position":30,"original_position":30,"commit_id":"3396fe69ff0c1ef279718ed73e0878947b0d423e","original_commit_id":"3396fe69ff0c1ef279718ed73e0878947b0d423e","user":{"login":"BillyYccc","id":5463589,"node_id":"MDQ6VXNlcjU0NjM1ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/5463589?v=4","gravatar_id":"","url":"https://api.github.com/users/BillyYccc","html_url":"https://github.com/BillyYccc","followers_url":"https://api.github.com/users/BillyYccc/followers","following_url":"https://api.github.com/users/BillyYccc/following{/other_user}","gists_url":"https://api.github.com/users/BillyYccc/gists{/gist_id}","starred_url":"https://api.github.com/users/BillyYccc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillyYccc/subscriptions","organizations_url":"https://api.github.com/users/BillyYccc/orgs","repos_url":"https://api.github.com/users/BillyYccc/repos","events_url":"https://api.github.com/users/BillyYccc/events{/privacy}","received_events_url":"https://api.github.com/users/BillyYccc/received_events","type":"User","site_admin":false},"body":"IMHO It is more like a configuration namespace here, I think it would be better to keep only one for each project and we have already two separated options object anyway.","created_at":"2019-08-23T10:47:11Z","updated_at":"2019-08-23T10:47:12Z","html_url":"https://github.com/micronaut-projects/micronaut-sql/pull/36#discussion_r317077941","pull_request_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/36","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/comments/317077941"},"html":{"href":"https://github.com/micronaut-projects/micronaut-sql/pull/36#discussion_r317077941"},"pull_request":{"href":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/36"}},"in_reply_to_id":317062103},"pull_request":{"url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/36","id":309408398,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5NDA4Mzk4","html_url":"https://github.com/micronaut-projects/micronaut-sql/pull/36","diff_url":"https://github.com/micronaut-projects/micronaut-sql/pull/36.diff","patch_url":"https://github.com/micronaut-projects/micronaut-sql/pull/36.patch","issue_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/issues/36","number":36,"state":"open","locked":false,"title":"Support vertx-mysql-client","user":{"login":"shenzhou-6","id":40198505,"node_id":"MDQ6VXNlcjQwMTk4NTA1","avatar_url":"https://avatars0.githubusercontent.com/u/40198505?v=4","gravatar_id":"","url":"https://api.github.com/users/shenzhou-6","html_url":"https://github.com/shenzhou-6","followers_url":"https://api.github.com/users/shenzhou-6/followers","following_url":"https://api.github.com/users/shenzhou-6/following{/other_user}","gists_url":"https://api.github.com/users/shenzhou-6/gists{/gist_id}","starred_url":"https://api.github.com/users/shenzhou-6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenzhou-6/subscriptions","organizations_url":"https://api.github.com/users/shenzhou-6/orgs","repos_url":"https://api.github.com/users/shenzhou-6/repos","events_url":"https://api.github.com/users/shenzhou-6/events{/privacy}","received_events_url":"https://api.github.com/users/shenzhou-6/received_events","type":"User","site_admin":false},"body":"Signed-off-by: shenzhou-6 <yizmao.me@gmail.com>","created_at":"2019-08-21T09:32:10Z","updated_at":"2019-08-23T10:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"291a35027694f9d31d9cb77b69091e73f66aed9e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/36/commits","review_comments_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/36/comments","review_comment_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/issues/36/comments","statuses_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/statuses/3396fe69ff0c1ef279718ed73e0878947b0d423e","head":{"label":"shenzhou-6:master","ref":"master","sha":"3396fe69ff0c1ef279718ed73e0878947b0d423e","user":{"login":"shenzhou-6","id":40198505,"node_id":"MDQ6VXNlcjQwMTk4NTA1","avatar_url":"https://avatars0.githubusercontent.com/u/40198505?v=4","gravatar_id":"","url":"https://api.github.com/users/shenzhou-6","html_url":"https://github.com/shenzhou-6","followers_url":"https://api.github.com/users/shenzhou-6/followers","following_url":"https://api.github.com/users/shenzhou-6/following{/other_user}","gists_url":"https://api.github.com/users/shenzhou-6/gists{/gist_id}","starred_url":"https://api.github.com/users/shenzhou-6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenzhou-6/subscriptions","organizations_url":"https://api.github.com/users/shenzhou-6/orgs","repos_url":"https://api.github.com/users/shenzhou-6/repos","events_url":"https://api.github.com/users/shenzhou-6/events{/privacy}","received_events_url":"https://api.github.com/users/shenzhou-6/received_events","type":"User","site_admin":false},"repo":{"id":200024393,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAwMjQzOTM=","name":"micronaut-sql","full_name":"shenzhou-6/micronaut-sql","private":false,"owner":{"login":"shenzhou-6","id":40198505,"node_id":"MDQ6VXNlcjQwMTk4NTA1","avatar_url":"https://avatars0.githubusercontent.com/u/40198505?v=4","gravatar_id":"","url":"https://api.github.com/users/shenzhou-6","html_url":"https://github.com/shenzhou-6","followers_url":"https://api.github.com/users/shenzhou-6/followers","following_url":"https://api.github.com/users/shenzhou-6/following{/other_user}","gists_url":"https://api.github.com/users/shenzhou-6/gists{/gist_id}","starred_url":"https://api.github.com/users/shenzhou-6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenzhou-6/subscriptions","organizations_url":"https://api.github.com/users/shenzhou-6/orgs","repos_url":"https://api.github.com/users/shenzhou-6/repos","events_url":"https://api.github.com/users/shenzhou-6/events{/privacy}","received_events_url":"https://api.github.com/users/shenzhou-6/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shenzhou-6/micronaut-sql","description":"Projects to support SQL Database access in Micronaut","fork":true,"url":"https://api.github.com/repos/shenzhou-6/micronaut-sql","forks_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/forks","keys_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/teams","hooks_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/hooks","issue_events_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/issues/events{/number}","events_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/events","assignees_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/assignees{/user}","branches_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/branches{/branch}","tags_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/tags","blobs_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/git/refs{/sha}","trees_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/statuses/{sha}","languages_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/languages","stargazers_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/stargazers","contributors_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/contributors","subscribers_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/subscribers","subscription_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/subscription","commits_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/commits{/sha}","git_commits_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/git/commits{/sha}","comments_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/comments{/number}","issue_comment_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/issues/comments{/number}","contents_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/contents/{+path}","compare_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/merges","archive_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/downloads","issues_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/issues{/number}","pulls_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/pulls{/number}","milestones_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/milestones{/number}","notifications_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/labels{/name}","releases_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/releases{/id}","deployments_url":"https://api.github.com/repos/shenzhou-6/micronaut-sql/deployments","created_at":"2019-08-01T09:51:24Z","updated_at":"2019-08-23T09:46:12Z","pushed_at":"2019-08-23T09:46:10Z","git_url":"git://github.com/shenzhou-6/micronaut-sql.git","ssh_url":"git@github.com:shenzhou-6/micronaut-sql.git","clone_url":"https://github.com/shenzhou-6/micronaut-sql.git","svn_url":"https://github.com/shenzhou-6/micronaut-sql","homepage":null,"size":1693,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"micronaut-projects:master","ref":"master","sha":"873afca37046ad95b91f4a47a78bab04046c6fd0","user":{"login":"micronaut-projects","id":36880643,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODgwNjQz","avatar_url":"https://avatars3.githubusercontent.com/u/36880643?v=4","gravatar_id":"","url":"https://api.github.com/users/micronaut-projects","html_url":"https://github.com/micronaut-projects","followers_url":"https://api.github.com/users/micronaut-projects/followers","following_url":"https://api.github.com/users/micronaut-projects/following{/other_user}","gists_url":"https://api.github.com/users/micronaut-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/micronaut-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micronaut-projects/subscriptions","organizations_url":"https://api.github.com/users/micronaut-projects/orgs","repos_url":"https://api.github.com/users/micronaut-projects/repos","events_url":"https://api.github.com/users/micronaut-projects/events{/privacy}","received_events_url":"https://api.github.com/users/micronaut-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":166014991,"node_id":"MDEwOlJlcG9zaXRvcnkxNjYwMTQ5OTE=","name":"micronaut-sql","full_name":"micronaut-projects/micronaut-sql","private":false,"owner":{"login":"micronaut-projects","id":36880643,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODgwNjQz","avatar_url":"https://avatars3.githubusercontent.com/u/36880643?v=4","gravatar_id":"","url":"https://api.github.com/users/micronaut-projects","html_url":"https://github.com/micronaut-projects","followers_url":"https://api.github.com/users/micronaut-projects/followers","following_url":"https://api.github.com/users/micronaut-projects/following{/other_user}","gists_url":"https://api.github.com/users/micronaut-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/micronaut-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micronaut-projects/subscriptions","organizations_url":"https://api.github.com/users/micronaut-projects/orgs","repos_url":"https://api.github.com/users/micronaut-projects/repos","events_url":"https://api.github.com/users/micronaut-projects/events{/privacy}","received_events_url":"https://api.github.com/users/micronaut-projects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/micronaut-projects/micronaut-sql","description":"Projects to support SQL Database access in Micronaut","fork":false,"url":"https://api.github.com/repos/micronaut-projects/micronaut-sql","forks_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/forks","keys_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/teams","hooks_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/hooks","issue_events_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/issues/events{/number}","events_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/events","assignees_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/assignees{/user}","branches_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/branches{/branch}","tags_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/tags","blobs_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/git/refs{/sha}","trees_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/statuses/{sha}","languages_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/languages","stargazers_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/stargazers","contributors_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/contributors","subscribers_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/subscribers","subscription_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/subscription","commits_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/commits{/sha}","git_commits_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/git/commits{/sha}","comments_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/comments{/number}","issue_comment_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/issues/comments{/number}","contents_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/contents/{+path}","compare_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/merges","archive_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/downloads","issues_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/issues{/number}","pulls_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls{/number}","milestones_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/milestones{/number}","notifications_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/labels{/name}","releases_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/releases{/id}","deployments_url":"https://api.github.com/repos/micronaut-projects/micronaut-sql/deployments","created_at":"2019-01-16T09:47:18Z","updated_at":"2019-08-16T06:50:00Z","pushed_at":"2019-08-23T09:46:12Z","git_url":"git://github.com/micronaut-projects/micronaut-sql.git","ssh_url":"git@github.com:micronaut-projects/micronaut-sql.git","clone_url":"https://github.com/micronaut-projects/micronaut-sql.git","svn_url":"https://github.com/micronaut-projects/micronaut-sql","homepage":null,"size":1687,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":9,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/36"},"html":{"href":"https://github.com/micronaut-projects/micronaut-sql/pull/36"},"issue":{"href":"https://api.github.com/repos/micronaut-projects/micronaut-sql/issues/36"},"comments":{"href":"https://api.github.com/repos/micronaut-projects/micronaut-sql/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micronaut-projects/micronaut-sql/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/micronaut-projects/micronaut-sql/statuses/3396fe69ff0c1ef279718ed73e0878947b0d423e"}},"author_association":"NONE"}}
{"actor":{"display_login":"BillyYccc"}}