{"action":"closed","number":51,"pull_request":{"url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/pulls/51","id":354069694,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0MDY5Njk0","html_url":"https://github.com/stackhpc/ansible-role-beegfs/pull/51","diff_url":"https://github.com/stackhpc/ansible-role-beegfs/pull/51.diff","patch_url":"https://github.com/stackhpc/ansible-role-beegfs/pull/51.patch","issue_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/issues/51","number":51,"state":"closed","locked":false,"title":"Use source of symlinked OSS devices","user":{"login":"markgoddard","id":5795873,"node_id":"MDQ6VXNlcjU3OTU4NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5795873?v=4","gravatar_id":"","url":"https://api.github.com/users/markgoddard","html_url":"https://github.com/markgoddard","followers_url":"https://api.github.com/users/markgoddard/followers","following_url":"https://api.github.com/users/markgoddard/following{/other_user}","gists_url":"https://api.github.com/users/markgoddard/gists{/gist_id}","starred_url":"https://api.github.com/users/markgoddard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markgoddard/subscriptions","organizations_url":"https://api.github.com/users/markgoddard/orgs","repos_url":"https://api.github.com/users/markgoddard/repos","events_url":"https://api.github.com/users/markgoddard/events{/privacy}","received_events_url":"https://api.github.com/users/markgoddard/received_events","type":"User","site_admin":false},"body":"If you set the dev attribute of one of the OSS devices to a symlink in\r\n/dev/disk/ e.g. /dev/disk/by-id/<id>, then run the role with the file\r\nsystem already mounted, the following task fails:\r\n\r\nTASK [roles/stackhpc.beegfs : Attempt to format if the device is not\r\nmounted or if beegfs_force_format is true]\r\n\r\nmkfs.xfs: cannot open /dev/disk/by-path/pci-0000:18:00.0-sas-phy4-lun-0:\r\nDevice or resource busy\r\n\r\nThis is because the task runs only if the device is not mounted, but the\r\nsymlink source is displayed in the mount list rather than the target.\r\n\r\nThis commit changes to use the source of the link when checking the list\r\nof mounted devices.\r\n\r\nWe also introduce a check for the existence of the device, and fail if\r\nit does not exist.\r\n\r\nFixes: #50","created_at":"2019-12-17T12:04:39Z","updated_at":"2019-12-17T14:52:12Z","closed_at":"2019-12-17T14:52:12Z","merged_at":"2019-12-17T14:52:11Z","merge_commit_sha":"f2ace83bf91c302b4e6b100b6aa5a8b7ed6279ec","assignee":{"login":"markgoddard","id":5795873,"node_id":"MDQ6VXNlcjU3OTU4NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5795873?v=4","gravatar_id":"","url":"https://api.github.com/users/markgoddard","html_url":"https://github.com/markgoddard","followers_url":"https://api.github.com/users/markgoddard/followers","following_url":"https://api.github.com/users/markgoddard/following{/other_user}","gists_url":"https://api.github.com/users/markgoddard/gists{/gist_id}","starred_url":"https://api.github.com/users/markgoddard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markgoddard/subscriptions","organizations_url":"https://api.github.com/users/markgoddard/orgs","repos_url":"https://api.github.com/users/markgoddard/repos","events_url":"https://api.github.com/users/markgoddard/events{/privacy}","received_events_url":"https://api.github.com/users/markgoddard/received_events","type":"User","site_admin":false},"assignees":[{"login":"markgoddard","id":5795873,"node_id":"MDQ6VXNlcjU3OTU4NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5795873?v=4","gravatar_id":"","url":"https://api.github.com/users/markgoddard","html_url":"https://github.com/markgoddard","followers_url":"https://api.github.com/users/markgoddard/followers","following_url":"https://api.github.com/users/markgoddard/following{/other_user}","gists_url":"https://api.github.com/users/markgoddard/gists{/gist_id}","starred_url":"https://api.github.com/users/markgoddard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markgoddard/subscriptions","organizations_url":"https://api.github.com/users/markgoddard/orgs","repos_url":"https://api.github.com/users/markgoddard/repos","events_url":"https://api.github.com/users/markgoddard/events{/privacy}","received_events_url":"https://api.github.com/users/markgoddard/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"oneswig","id":14276704,"node_id":"MDQ6VXNlcjE0Mjc2NzA0","avatar_url":"https://avatars0.githubusercontent.com/u/14276704?v=4","gravatar_id":"","url":"https://api.github.com/users/oneswig","html_url":"https://github.com/oneswig","followers_url":"https://api.github.com/users/oneswig/followers","following_url":"https://api.github.com/users/oneswig/following{/other_user}","gists_url":"https://api.github.com/users/oneswig/gists{/gist_id}","starred_url":"https://api.github.com/users/oneswig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oneswig/subscriptions","organizations_url":"https://api.github.com/users/oneswig/orgs","repos_url":"https://api.github.com/users/oneswig/repos","events_url":"https://api.github.com/users/oneswig/events{/privacy}","received_events_url":"https://api.github.com/users/oneswig/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/pulls/51/commits","review_comments_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/pulls/51/comments","review_comment_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/issues/51/comments","statuses_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/statuses/897b68dc7298707c54f23da241564f5492e2ffda","head":{"label":"stackhpc:issues/50","ref":"issues/50","sha":"897b68dc7298707c54f23da241564f5492e2ffda","user":{"login":"stackhpc","id":22750772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzUwNzcy","avatar_url":"https://avatars2.githubusercontent.com/u/22750772?v=4","gravatar_id":"","url":"https://api.github.com/users/stackhpc","html_url":"https://github.com/stackhpc","followers_url":"https://api.github.com/users/stackhpc/followers","following_url":"https://api.github.com/users/stackhpc/following{/other_user}","gists_url":"https://api.github.com/users/stackhpc/gists{/gist_id}","starred_url":"https://api.github.com/users/stackhpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackhpc/subscriptions","organizations_url":"https://api.github.com/users/stackhpc/orgs","repos_url":"https://api.github.com/users/stackhpc/repos","events_url":"https://api.github.com/users/stackhpc/events{/privacy}","received_events_url":"https://api.github.com/users/stackhpc/received_events","type":"Organization","site_admin":false},"repo":{"id":141720277,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3MjAyNzc=","name":"ansible-role-beegfs","full_name":"stackhpc/ansible-role-beegfs","private":false,"owner":{"login":"stackhpc","id":22750772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzUwNzcy","avatar_url":"https://avatars2.githubusercontent.com/u/22750772?v=4","gravatar_id":"","url":"https://api.github.com/users/stackhpc","html_url":"https://github.com/stackhpc","followers_url":"https://api.github.com/users/stackhpc/followers","following_url":"https://api.github.com/users/stackhpc/following{/other_user}","gists_url":"https://api.github.com/users/stackhpc/gists{/gist_id}","starred_url":"https://api.github.com/users/stackhpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackhpc/subscriptions","organizations_url":"https://api.github.com/users/stackhpc/orgs","repos_url":"https://api.github.com/users/stackhpc/repos","events_url":"https://api.github.com/users/stackhpc/events{/privacy}","received_events_url":"https://api.github.com/users/stackhpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stackhpc/ansible-role-beegfs","description":"Create beegfs server and client","fork":false,"url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs","forks_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/forks","keys_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/teams","hooks_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/hooks","issue_events_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/issues/events{/number}","events_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/events","assignees_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/assignees{/user}","branches_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/branches{/branch}","tags_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/tags","blobs_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/statuses/{sha}","languages_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/languages","stargazers_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/stargazers","contributors_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/contributors","subscribers_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/subscribers","subscription_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/subscription","commits_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/contents/{+path}","compare_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/merges","archive_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/downloads","issues_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/issues{/number}","pulls_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/pulls{/number}","milestones_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/milestones{/number}","notifications_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/labels{/name}","releases_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/releases{/id}","deployments_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/deployments","created_at":"2018-07-20T14:13:33Z","updated_at":"2019-11-02T22:35:36Z","pushed_at":"2019-12-17T14:52:12Z","git_url":"git://github.com/stackhpc/ansible-role-beegfs.git","ssh_url":"git@github.com:stackhpc/ansible-role-beegfs.git","clone_url":"https://github.com/stackhpc/ansible-role-beegfs.git","svn_url":"https://github.com/stackhpc/ansible-role-beegfs","homepage":null,"size":133,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":7,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"stackhpc:master","ref":"master","sha":"cb05795b86f175d439a66d5bbd091fc78a3a3d52","user":{"login":"stackhpc","id":22750772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzUwNzcy","avatar_url":"https://avatars2.githubusercontent.com/u/22750772?v=4","gravatar_id":"","url":"https://api.github.com/users/stackhpc","html_url":"https://github.com/stackhpc","followers_url":"https://api.github.com/users/stackhpc/followers","following_url":"https://api.github.com/users/stackhpc/following{/other_user}","gists_url":"https://api.github.com/users/stackhpc/gists{/gist_id}","starred_url":"https://api.github.com/users/stackhpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackhpc/subscriptions","organizations_url":"https://api.github.com/users/stackhpc/orgs","repos_url":"https://api.github.com/users/stackhpc/repos","events_url":"https://api.github.com/users/stackhpc/events{/privacy}","received_events_url":"https://api.github.com/users/stackhpc/received_events","type":"Organization","site_admin":false},"repo":{"id":141720277,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3MjAyNzc=","name":"ansible-role-beegfs","full_name":"stackhpc/ansible-role-beegfs","private":false,"owner":{"login":"stackhpc","id":22750772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzUwNzcy","avatar_url":"https://avatars2.githubusercontent.com/u/22750772?v=4","gravatar_id":"","url":"https://api.github.com/users/stackhpc","html_url":"https://github.com/stackhpc","followers_url":"https://api.github.com/users/stackhpc/followers","following_url":"https://api.github.com/users/stackhpc/following{/other_user}","gists_url":"https://api.github.com/users/stackhpc/gists{/gist_id}","starred_url":"https://api.github.com/users/stackhpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackhpc/subscriptions","organizations_url":"https://api.github.com/users/stackhpc/orgs","repos_url":"https://api.github.com/users/stackhpc/repos","events_url":"https://api.github.com/users/stackhpc/events{/privacy}","received_events_url":"https://api.github.com/users/stackhpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stackhpc/ansible-role-beegfs","description":"Create beegfs server and client","fork":false,"url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs","forks_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/forks","keys_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/teams","hooks_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/hooks","issue_events_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/issues/events{/number}","events_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/events","assignees_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/assignees{/user}","branches_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/branches{/branch}","tags_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/tags","blobs_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/statuses/{sha}","languages_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/languages","stargazers_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/stargazers","contributors_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/contributors","subscribers_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/subscribers","subscription_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/subscription","commits_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/contents/{+path}","compare_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/merges","archive_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/downloads","issues_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/issues{/number}","pulls_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/pulls{/number}","milestones_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/milestones{/number}","notifications_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/labels{/name}","releases_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/releases{/id}","deployments_url":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/deployments","created_at":"2018-07-20T14:13:33Z","updated_at":"2019-11-02T22:35:36Z","pushed_at":"2019-12-17T14:52:12Z","git_url":"git://github.com/stackhpc/ansible-role-beegfs.git","ssh_url":"git@github.com:stackhpc/ansible-role-beegfs.git","clone_url":"https://github.com/stackhpc/ansible-role-beegfs.git","svn_url":"https://github.com/stackhpc/ansible-role-beegfs","homepage":null,"size":133,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":7,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/pulls/51"},"html":{"href":"https://github.com/stackhpc/ansible-role-beegfs/pull/51"},"issue":{"href":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/issues/51"},"comments":{"href":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/stackhpc/ansible-role-beegfs/statuses/897b68dc7298707c54f23da241564f5492e2ffda"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"markgoddard","id":5795873,"node_id":"MDQ6VXNlcjU3OTU4NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5795873?v=4","gravatar_id":"","url":"https://api.github.com/users/markgoddard","html_url":"https://github.com/markgoddard","followers_url":"https://api.github.com/users/markgoddard/followers","following_url":"https://api.github.com/users/markgoddard/following{/other_user}","gists_url":"https://api.github.com/users/markgoddard/gists{/gist_id}","starred_url":"https://api.github.com/users/markgoddard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markgoddard/subscriptions","organizations_url":"https://api.github.com/users/markgoddard/orgs","repos_url":"https://api.github.com/users/markgoddard/repos","events_url":"https://api.github.com/users/markgoddard/events{/privacy}","received_events_url":"https://api.github.com/users/markgoddard/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":12,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"markgoddard"}}