{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/18509","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/18509/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/18509/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/18509/events","html_url":"https://github.com/ManageIQ/manageiq/pull/18509","id":416244986,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3NTU0OTk1","number":18509,"title":"Warn devs if their current branch is out of date","user":{"login":"jrafanie","id":19339,"node_id":"MDQ6VXNlcjE5MzM5","avatar_url":"https://avatars0.githubusercontent.com/u/19339?v=4","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"labels":[{"id":321141499,"node_id":"MDU6TGFiZWwzMjExNDE0OTk=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/developer","name":"developer","color":"bcf5db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-03-01T19:23:55Z","updated_at":"2019-03-01T19:35:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/18509","html_url":"https://github.com/ManageIQ/manageiq/pull/18509","diff_url":"https://github.com/ManageIQ/manageiq/pull/18509.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/18509.patch"},"body":"It's easy to pull in provider or other repo updates via `bin/update`\r\nbut forget to git pull or git fetch + merge your current branch, leading\r\nto \"constant\" errors or just inconsistency.\r\n\r\nNow, at the end of `bin/update`, it will check your current branch vs.\r\nit's upstream remote tracking branch if it has one and tries\r\nupstream/master if you don't.  This should cover the cases for both\r\nrelease branches such as master and also feature branches which may not\r\ntrack anything but probably originated from upstream/master.  We can\r\nexternalize the \"master\" branch name at some point so this can be used\r\non hammer, gaprindashvili, etc.\r\n\r\nIf you don't use upstream as your remote name, you're on your own.\r\n\r\nIt looks like this at the end of `bin/update`.\r\n\r\n```\r\n...\r\nJS plugins:\r\n  ManageIQ::GraphQL::Engine:\r\n    namespace: manageiq-graphql\r\n    path: /Users/joerafaniello/.gem/ruby/2.4.5/bundler/gems/manageiq-graphql-82fdd9385bdd\r\n  ManageIQ::Providers::Lenovo::Engine:\r\n    namespace: manageiq-providers-lenovo\r\n    path: /Users/joerafaniello/.gem/ruby/2.4.5/bundler/gems/manageiq-providers-lenovo-5eea49854a3a\r\n  ManageIQ::Providers::Nuage::Engine:\r\n    namespace: manageiq-providers-nuage\r\n    path: /Users/joerafaniello/.gem/ruby/2.4.5/bundler/gems/manageiq-providers-nuage-2f8d63586d9b\r\n  ManageIQ::UI::Classic::Engine:\r\n    namespace: manageiq-ui-classic\r\n    path: /Users/joerafaniello/.gem/ruby/2.4.5/bundler/gems/manageiq-ui-classic-2721cb43d860\r\n  ManageIQ::V2V::Engine:\r\n    namespace: manageiq-v2v\r\n    path: /Users/joerafaniello/.gem/ruby/2.4.5/bundler/gems/manageiq-v2v-c097fb87593a\r\n\r\n== Updating UI assets complete ==\r\n\r\n== Removing old logs and tempfiles ==\r\n\r\n== Your branch is 15 commits out of date, please pull or fetch + merge.\r\n```"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/468785309","html_url":"https://github.com/ManageIQ/manageiq/pull/18509#issuecomment-468785309","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/18509","id":468785309,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2ODc4NTMwOQ==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2019-03-01T19:35:37Z","updated_at":"2019-03-01T19:35:37Z","author_association":"MEMBER","body":"<rubocop />Checked commit https://github.com/jrafanie/manageiq/commit/302aa22d9d4d4a9de5c222d8bdf50957915b2eef with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n1 file checked, 3 offenses detected\n\n**lib/manageiq/environment.rb**\n- [ ] :exclamation: - [Line 137](https://github.com/jrafanie/manageiq/blob/302aa22d9d4d4a9de5c222d8bdf50957915b2eef/lib/manageiq/environment.rb#L137), Col 12 - [Style/NumericPredicate](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/NumericPredicate) - Use `commits.positive?` instead of `commits > 0`.\n- [ ] :exclamation: - [Line 158](https://github.com/jrafanie/manageiq/blob/302aa22d9d4d4a9de5c222d8bdf50957915b2eef/lib/manageiq/environment.rb#L158), Col 23 - [Style/NumericPredicate](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/NumericPredicate) - Use `$?.exitstatus.zero?` instead of `$?.exitstatus == 0`.\n- [ ] :exclamation: - [Line 158](https://github.com/jrafanie/manageiq/blob/302aa22d9d4d4a9de5c222d8bdf50957915b2eef/lib/manageiq/environment.rb#L158), Col 23 - [Style/SpecialGlobalVars](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/SpecialGlobalVars) - Prefer `$CHILD_STATUS` from the stdlib 'English' module (don't forget to require it) over `$?`.\n"}}
{"actor":{"display_login":"miq-bot"}}