{"push_id":3356680097,"size":13,"distinct_size":1,"ref":"refs/heads/separate_rubygems_sources_in_lockfile","head":"9cbf1d13ed26a5a5d0a7789de6e9e332ac9115f8","before":"0435187dd9ca538684cbd9da5512723f57ce48bc","commits":[{"sha":"93c7f551c09f7cc8badbcc4da2488d1664909f95","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Remove unnecessary gsub","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/93c7f551c09f7cc8badbcc4da2488d1664909f95"},{"sha":"ec56cdbd64c9ba920946e0fc3e823257189c8196","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Move some test setups to before blocks","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/ec56cdbd64c9ba920946e0fc3e823257189c8196"},{"sha":"f89bca863fdaec498d19b2aabe88653a5c585d84","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Delay requiring --all to update everything to bundler 3\n\nSince we haven't even yet deprecated the old behavior.","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/f89bca863fdaec498d19b2aabe88653a5c585d84"},{"sha":"4fbf085ea2748436755751e59240f3ab042cfcd7","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Remove unnecessary gems.rb file creation\n\nNot necessary for the test since the main before block already creates\none.","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/4fbf085ea2748436755751e59240f3ab042cfcd7"},{"sha":"a30cd4b6f4c92372b9c8581eec6e38fb5c610c59","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Delay `bundle console` removal to bundler 3","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/a30cd4b6f4c92372b9c8581eec6e38fb5c610c59"},{"sha":"cc7faa030aa89f2a8bc38abe2b14e1c902751bcb","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Adapt `bundle show` deprecation specs","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/cc7faa030aa89f2a8bc38abe2b14e1c902751bcb"},{"sha":"9c0701d5f3d6728f9b6a1c26827e12f2e1c0d80c","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Fix major deprecation matcher\n\nThe previous logic was broken. Previously, changing the expectation\nabout gems.rb vs Gemfile deprecation to\n\n```ruby\nexpect(warnings).to have_major_deprecation(\"gems.rb is preferred to chocolate ice-cream\")\n```\n\nwould still pass.","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/9c0701d5f3d6728f9b6a1c26827e12f2e1c0d80c"},{"sha":"3b24acce0fa2f3fa1e6330acb47bbce13697321a","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Make sure deprecation specs run on bundler 2\n\nAnd skip the rest of the broken ones.","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/3b24acce0fa2f3fa1e6330acb47bbce13697321a"},{"sha":"ae11272b8afe7adc7b5ad297bcd14afe39e397a4","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Remove now unnecessary filtering\n\nThose deprecation messages are no longer printed.","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/ae11272b8afe7adc7b5ad297bcd14afe39e397a4"},{"sha":"c425c5cd2b987a5b4c2c397b5308618241dcacbd","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Prefer the `err` helper for checking errors\n\nThe helper already considers the stream errors are printed to.","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/c425c5cd2b987a5b4c2c397b5308618241dcacbd"},{"sha":"280307575c8a6ba550469498fcf1c7a91ae88026","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Split (and skip) specs about multiple source deprecation\n\nI'll get to this on a separate PR.","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/280307575c8a6ba550469498fcf1c7a91ae88026"},{"sha":"4820acf3dbea172c6ec4f165b875acbe85f095cd","author":{"name":"Bundlerbot","email":"c71e7261d37a4f6ae4cfb0cbd79081310a237e67@bundler.io"},"message":"Merge #6991\n\n6991: Fix deprecation specs r=deivid-rodriguez a=deivid-rodriguez\n\n### What was the end-user problem that led to this PR?\r\n\r\nThe problem was the current deprecation specs are broken. Not the deprecations themselves, their specs.\r\n\r\n### What was your diagnosis of the problem?\r\n\r\nMy diagnosis was we need to fix the specs for the deprecations before actually making sure that the deprecations themselves are properly enabled.\r\n\r\n### What is your fix for the problem, implemented in this PR?\r\n\r\nMy fix is to:\r\n\r\n* Get the target version corrected. Deprecation specs should run on bundler 2, not on bundler 1, since deprecations are disabled on bundler 1.\r\n* Get the deprecation matcher fixed. The previous version was passing every time any deprecation was printed and a positive expectation was set. That means that on a spec printing a single deprecation, the assertion `expect(warnings).to have_major_deprecation(\"bananas will be deprecated in favor of potatoes\")`, or any other message, would just pass. This explains why the deprecation specs were currently passing on bundler 1 and it's fixed by https://github.com/bundler/bundler/commit/33383f2faae10cd307b86466921b1a17391bae80.\r\n\r\n### Why did you choose this fix out of the possible options?\r\n\r\nThis fix changes the target for the deprecation specs to bundler 2 (https://github.com/bundler/bundler/commit/e54ddb60298036e3a25c95deda6d575d384ff48a) and uses the following strategy to get CI green after that:\r\n\r\n* If the deprecation is already correct on bundler 2, do nothing, the specs already pass.\r\n* If the deprecation is incorrect on bundler 2, but the fix is a no-brainer, fix it here. For example, the `bundle update --all` deprecation (968fe965c), or the `bundle console` deprecation (5bece2f0f).\r\n* If the deprecation is incorrect on bundler 2, but fixing it requires a separate discussion, skip the spec for now, and stage the fix for a separate PR.\r\n\r\nI chose this fix because it keeps this PR simple and focused, while unblocking fixing the rest of the deprecations by at least having correct (although disabled) specs for them. \n\nCo-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/4820acf3dbea172c6ec4f165b875acbe85f095cd"},{"sha":"9cbf1d13ed26a5a5d0a7789de6e9e332ac9115f8","author":{"name":"David Rodríguez","email":"96558bf9378c437d3852fad4fa4b4bd63aeb6eda@riseup.net"},"message":"Remove lockfile incompatibility due to a setting\n\nThe `lockfile_uses_separate_rubygems_sources` was causing a lockfile\nincompatibility but in my opinion, this incompatibility is not necessary\nin the general case.","distinct":true,"url":"https://api.github.com/repos/bundler/bundler/commits/9cbf1d13ed26a5a5d0a7789de6e9e332ac9115f8"}]}
{"actor":{"display_login":"deivid-rodriguez"}}