{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/269715106","pull_request_review_id":219656838,"id":269715106,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTcxNTEwNg==","diff_hunk":"@@ -48,7 +44,7 @@ public ConfigurationClient(string connectionString, HttpPipelineOptions options)\n             if (connectionString == null) throw new ArgumentNullException(nameof(connectionString));\n             if (options == null) throw new ArgumentNullException(nameof(options));\n \n-            _pipeline = options.Build(ComponentName, ComponentVersion);\n+            _pipeline = options.Build(typeof(ConfigurationClient));","path":"src/SDKs/Azure.ApplicationModel.Configuration/data-plane/Azure.ApplicationModel.Configuration/ConfigurationClient.cs","position":23,"original_position":23,"commit_id":"3035c59a86b4ede340d70fe919bf3c07588767cf","original_commit_id":"3035c59a86b4ede340d70fe919bf3c07588767cf","user":{"login":"KrzysztofCwalina","id":9724236,"node_id":"MDQ6VXNlcjk3MjQyMzY=","avatar_url":"https://avatars0.githubusercontent.com/u/9724236?v=4","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false},"body":"What do we do if there are more than one client?","created_at":"2019-03-27T18:42:26Z","updated_at":"2019-03-27T18:50:55Z","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/5610#discussion_r269715106","pull_request_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5610","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/269715106"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/5610#discussion_r269715106"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5610"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5610","id":265038439,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1MDM4NDM5","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/5610","diff_url":"https://github.com/Azure/azure-sdk-for-net/pull/5610.diff","patch_url":"https://github.com/Azure/azure-sdk-for-net/pull/5610.patch","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5610","number":5610,"state":"open","locked":false,"title":"Derive component name/version from assembly metadata","user":{"login":"pakrym","id":1697911,"node_id":"MDQ6VXNlcjE2OTc5MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1697911?v=4","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/Azure/azure-sdk-for-net/issues/5609\r\n\r\nAlso cleans-up the mock transport.","created_at":"2019-03-27T17:54:47Z","updated_at":"2019-03-27T18:50:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d86dba55ac0eef576e4367369ed71ddb6aa641e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jsquire","id":913445,"node_id":"MDQ6VXNlcjkxMzQ0NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/913445?v=4","gravatar_id":"","url":"https://api.github.com/users/jsquire","html_url":"https://github.com/jsquire","followers_url":"https://api.github.com/users/jsquire/followers","following_url":"https://api.github.com/users/jsquire/following{/other_user}","gists_url":"https://api.github.com/users/jsquire/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquire/subscriptions","organizations_url":"https://api.github.com/users/jsquire/orgs","repos_url":"https://api.github.com/users/jsquire/repos","events_url":"https://api.github.com/users/jsquire/events{/privacy}","received_events_url":"https://api.github.com/users/jsquire/received_events","type":"User","site_admin":false},{"login":"maririos","id":9868623,"node_id":"MDQ6VXNlcjk4Njg2MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9868623?v=4","gravatar_id":"","url":"https://api.github.com/users/maririos","html_url":"https://github.com/maririos","followers_url":"https://api.github.com/users/maririos/followers","following_url":"https://api.github.com/users/maririos/following{/other_user}","gists_url":"https://api.github.com/users/maririos/gists{/gist_id}","starred_url":"https://api.github.com/users/maririos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maririos/subscriptions","organizations_url":"https://api.github.com/users/maririos/orgs","repos_url":"https://api.github.com/users/maririos/repos","events_url":"https://api.github.com/users/maririos/events{/privacy}","received_events_url":"https://api.github.com/users/maririos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5610/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5610/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5610/comments","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/3035c59a86b4ede340d70fe919bf3c07588767cf","head":{"label":"pakrym:pakrym/derive-component-version-from-assembly","ref":"pakrym/derive-component-version-from-assembly","sha":"3035c59a86b4ede340d70fe919bf3c07588767cf","user":{"login":"pakrym","id":1697911,"node_id":"MDQ6VXNlcjE2OTc5MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1697911?v=4","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"repo":{"id":176317692,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzMTc2OTI=","name":"azure-sdk-for-net","full_name":"pakrym/azure-sdk-for-net","private":false,"owner":{"login":"pakrym","id":1697911,"node_id":"MDQ6VXNlcjE2OTc5MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1697911?v=4","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pakrym/azure-sdk-for-net","description":".NET Libraries for Azure","fork":true,"url":"https://api.github.com/repos/pakrym/azure-sdk-for-net","forks_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/pakrym/azure-sdk-for-net/deployments","created_at":"2019-03-18T15:40:09Z","updated_at":"2019-03-22T22:39:56Z","pushed_at":"2019-03-27T18:12:51Z","git_url":"git://github.com/pakrym/azure-sdk-for-net.git","ssh_url":"git@github.com:pakrym/azure-sdk-for-net.git","clone_url":"https://github.com/pakrym/azure-sdk-for-net.git","svn_url":"https://github.com/pakrym/azure-sdk-for-net","homepage":"https://docs.microsoft.com/en-us/dotnet/azure/","size":281823,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"c93855f8ac7fea338effa22a5f1b29c67b778814","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":2928944,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI4OTQ0","name":"azure-sdk-for-net","full_name":"Azure/azure-sdk-for-net","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-sdk-for-net","description":".NET Libraries for Azure","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk-for-net","forks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/deployments","created_at":"2011-12-06T23:32:47Z","updated_at":"2019-03-27T17:00:39Z","pushed_at":"2019-03-27T18:20:58Z","git_url":"git://github.com/Azure/azure-sdk-for-net.git","ssh_url":"git@github.com:Azure/azure-sdk-for-net.git","clone_url":"https://github.com/Azure/azure-sdk-for-net.git","svn_url":"https://github.com/Azure/azure-sdk-for-net","homepage":"https://docs.microsoft.com/en-us/dotnet/azure/","size":282800,"stargazers_count":1309,"watchers_count":1309,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1339,"mirror_url":null,"archived":false,"open_issues_count":459,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1339,"open_issues":459,"watchers":1309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5610"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/5610"},"issue":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5610"},"comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5610/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5610/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5610/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/3035c59a86b4ede340d70fe919bf3c07588767cf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KrzysztofCwalina"}}