{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79552","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79552/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79552/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79552/events","html_url":"https://github.com/kubernetes/kubernetes/pull/79552","id":462249481,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzMDAyNjQ4","number":79552,"title":"Add support for AWS EBS on windows","user":{"login":"wongma7","id":13111288,"node_id":"MDQ6VXNlcjEzMTExMjg4","avatar_url":"https://avatars0.githubusercontent.com/u/13111288?v=4","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"labels":[{"id":105152717,"node_id":"MDU6TGFiZWwxMDUxNTI3MTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/test","name":"area/test","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":328487998,"node_id":"MDU6TGFiZWwzMjg0ODc5OTg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/aws","name":"sig/aws","color":"d2b48c","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":422106010,"node_id":"MDU6TGFiZWw0MjIxMDYwMTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/windows","name":"sig/windows","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2019-06-29T00:56:34Z","updated_at":"2019-07-17T20:00:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/79552","html_url":"https://github.com/kubernetes/kubernetes/pull/79552","diff_url":"https://github.com/kubernetes/kubernetes/pull/79552.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/79552.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n\r\n1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n/kind feature\r\n\r\n**What this PR does / why we need it**: Currently, EBS WaitForAttach on windows nodes fails because the EBS driver looks for the device at some Linux-specific /dev/xxxxx path which doesn't exist on Windows. Nothing prevents the scheduling of windows pods using EBS to windows nodes, so the pods end up stuck pending. Windows nodes are already GA, so fix it.\r\n\r\n**Which issue(s) this PR fixes**:\r\n<!--\r\n*Automatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n-->\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\nTODO: add Get-Disk fallback or maybe not.\r\nTODO: e2e test?\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--\r\nIf no, just write \"NONE\" in the release-note block below.\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n-->\r\n```release-note\r\nAdd support for AWS EBS on windows\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/512546270","html_url":"https://github.com/kubernetes/kubernetes/pull/79552#issuecomment-512546270","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79552","id":512546270,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMjU0NjI3MA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-07-17T20:00:00Z","updated_at":"2019-07-17T20:00:00Z","author_association":"CONTRIBUTOR","body":"@wongma7: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-gce-device-plugin-gpu | 2ed46799c5cef12bf2c956c3b1309a0baf6181f9 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79552/pull-kubernetes-e2e-gce-device-plugin-gpu/1151579318208434176/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-e2e-gce-100-performance | 2ed46799c5cef12bf2c956c3b1309a0baf6181f9 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79552/pull-kubernetes-e2e-gce-100-performance/1151579318183268352/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-bazel-build | 2ed46799c5cef12bf2c956c3b1309a0baf6181f9 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79552/pull-kubernetes-bazel-build/1151579318124548096) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-e2e-gce-storage-slow | 2ed46799c5cef12bf2c956c3b1309a0baf6181f9 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79552/pull-kubernetes-e2e-gce-storage-slow/1151579318158102529/) | `/test pull-kubernetes-e2e-gce-storage-slow`\npull-kubernetes-e2e-gce-csi-serial | 2ed46799c5cef12bf2c956c3b1309a0baf6181f9 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79552/pull-kubernetes-e2e-gce-csi-serial/1151579318208434177/) | `/test pull-kubernetes-e2e-gce-csi-serial`\npull-kubernetes-bazel-test | 2ed46799c5cef12bf2c956c3b1309a0baf6181f9 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79552/pull-kubernetes-bazel-test/1151579318162296832) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-kubemark-e2e-gce-big | 2ed46799c5cef12bf2c956c3b1309a0baf6181f9 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79552/pull-kubernetes-kubemark-e2e-gce-big/1151579318229405696/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\npull-kubernetes-e2e-gce | fb57e4c8173c3a83649df15e578866a7b33bc7fa | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79552/pull-kubernetes-e2e-gce/1151581474575618048/) | `/test pull-kubernetes-e2e-gce`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=79552). [Your PR dashboard](https://gubernator.k8s.io/pr/wongma7). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}