{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/comments/263058064","pull_request_review_id":211378053,"id":263058064,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzA1ODA2NA==","diff_hunk":"@@ -0,0 +1,93 @@\n+/*******************************************************************************\n+ * Copyright (c) 2019 Oracle and/or its affiliates. All rights reserved.\n+ * This program and the accompanying materials are made available under the\n+ * terms of the Eclipse Public License v1.0 and Eclipse Distribution License v. 1.0\n+ * which accompanies this distribution.\n+ * The Eclipse Public License is available at http://www.eclipse.org/legal/epl-v10.html\n+ * and the Eclipse Distribution License is available at\n+ * http://www.eclipse.org/org/documents/edl-v10.php.\n+ ******************************************************************************/\n+package org.eclipse.yasson;\n+\n+import javax.json.bind.JsonbException;\n+import javax.json.stream.JsonGenerator;\n+import javax.json.stream.JsonParser;\n+import java.lang.reflect.Type;\n+\n+/**\n+ * Adds methods to Jsonb that are operating directly with {@link JsonGenerator} or {@link JsonParser} types.\n+ * <p>\n+ * {@link javax.json.spi.JsonProvider} operates on top of the\n+ * {@link java.io.InputStream} / {@link java.io.OutputStream} or {@link java.io.Reader} / {@link java.io.Writer}\n+ * and creates generator / parser instances during runtime.\n+ * </p>\n+ * <p>\n+ * This interface accepts instantiated generators and parsers with different input / output sources.\n+ * </p>\n+ */\n+public interface Jsonb extends javax.json.bind.Jsonb {","path":"src/main/java/org/eclipse/yasson/Jsonb.java","position":28,"original_position":28,"commit_id":"62dc006ac312fc8b1543892b82a14ef6485d6fa3","original_commit_id":"62dc006ac312fc8b1543892b82a14ef6485d6fa3","user":{"login":"aguibert","id":5427967,"node_id":"MDQ6VXNlcjU0Mjc5Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/5427967?v=4","gravatar_id":"","url":"https://api.github.com/users/aguibert","html_url":"https://github.com/aguibert","followers_url":"https://api.github.com/users/aguibert/followers","following_url":"https://api.github.com/users/aguibert/following{/other_user}","gists_url":"https://api.github.com/users/aguibert/gists{/gist_id}","starred_url":"https://api.github.com/users/aguibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguibert/subscriptions","organizations_url":"https://api.github.com/users/aguibert/orgs","repos_url":"https://api.github.com/users/aguibert/repos","events_url":"https://api.github.com/users/aguibert/events{/privacy}","received_events_url":"https://api.github.com/users/aguibert/received_events","type":"User","site_admin":false},"body":"of the two options you suggest, I prefer `ExternalJsonpBinding`\r\n\r\n> Hmm, I did this intentionally to make users aware of alternative and if this is eventionally introduced into API later (see linked bug), Yasson will just delete this ifc and users only change import.\r\n\r\nAssuming this gets rolled into JSON-B spec, the best we could do is collapse this class down to an interface that extended the spec `Jsonb` and adds no extra methods. We shouldn't ever delete it entirely, because that would be a breaking change for users.","created_at":"2019-03-06T17:47:58Z","updated_at":"2019-03-06T17:47:59Z","html_url":"https://github.com/eclipse-ee4j/yasson/pull/246#discussion_r263058064","pull_request_url":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/246","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/comments/263058064"},"html":{"href":"https://github.com/eclipse-ee4j/yasson/pull/246#discussion_r263058064"},"pull_request":{"href":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/246"}},"in_reply_to_id":261686117},"pull_request":{"url":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/246","id":257092451,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3MDkyNDUx","html_url":"https://github.com/eclipse-ee4j/yasson/pull/246","diff_url":"https://github.com/eclipse-ee4j/yasson/pull/246.diff","patch_url":"https://github.com/eclipse-ee4j/yasson/pull/246.patch","issue_url":"https://api.github.com/repos/eclipse-ee4j/yasson/issues/246","number":246,"state":"open","locked":false,"title":"Yasson's own Jsonb interface for usage of preinstantiated JSONP parse…","user":{"login":"bravehorsie","id":9378230,"node_id":"MDQ6VXNlcjkzNzgyMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/9378230?v=4","gravatar_id":"","url":"https://api.github.com/users/bravehorsie","html_url":"https://github.com/bravehorsie","followers_url":"https://api.github.com/users/bravehorsie/followers","following_url":"https://api.github.com/users/bravehorsie/following{/other_user}","gists_url":"https://api.github.com/users/bravehorsie/gists{/gist_id}","starred_url":"https://api.github.com/users/bravehorsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bravehorsie/subscriptions","organizations_url":"https://api.github.com/users/bravehorsie/orgs","repos_url":"https://api.github.com/users/bravehorsie/repos","events_url":"https://api.github.com/users/bravehorsie/events{/privacy}","received_events_url":"https://api.github.com/users/bravehorsie/received_events","type":"User","site_admin":false},"body":"…rs / generators.\r\n\r\nFixes #245 \r\n\r\nSigned-off-by: Roman Grigoriadi <roman.grigoriadi@oracle.com>","created_at":"2019-02-28T14:33:25Z","updated_at":"2019-03-06T17:47:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39042441f94da575bebf936fbded847caa68f0de","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aguibert","id":5427967,"node_id":"MDQ6VXNlcjU0Mjc5Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/5427967?v=4","gravatar_id":"","url":"https://api.github.com/users/aguibert","html_url":"https://github.com/aguibert","followers_url":"https://api.github.com/users/aguibert/followers","following_url":"https://api.github.com/users/aguibert/following{/other_user}","gists_url":"https://api.github.com/users/aguibert/gists{/gist_id}","starred_url":"https://api.github.com/users/aguibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguibert/subscriptions","organizations_url":"https://api.github.com/users/aguibert/orgs","repos_url":"https://api.github.com/users/aguibert/repos","events_url":"https://api.github.com/users/aguibert/events{/privacy}","received_events_url":"https://api.github.com/users/aguibert/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/246/commits","review_comments_url":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/246/comments","review_comment_url":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse-ee4j/yasson/issues/246/comments","statuses_url":"https://api.github.com/repos/eclipse-ee4j/yasson/statuses/62dc006ac312fc8b1543892b82a14ef6485d6fa3","head":{"label":"bravehorsie:api-extension","ref":"api-extension","sha":"62dc006ac312fc8b1543892b82a14ef6485d6fa3","user":{"login":"bravehorsie","id":9378230,"node_id":"MDQ6VXNlcjkzNzgyMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/9378230?v=4","gravatar_id":"","url":"https://api.github.com/users/bravehorsie","html_url":"https://github.com/bravehorsie","followers_url":"https://api.github.com/users/bravehorsie/followers","following_url":"https://api.github.com/users/bravehorsie/following{/other_user}","gists_url":"https://api.github.com/users/bravehorsie/gists{/gist_id}","starred_url":"https://api.github.com/users/bravehorsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bravehorsie/subscriptions","organizations_url":"https://api.github.com/users/bravehorsie/orgs","repos_url":"https://api.github.com/users/bravehorsie/repos","events_url":"https://api.github.com/users/bravehorsie/events{/privacy}","received_events_url":"https://api.github.com/users/bravehorsie/received_events","type":"User","site_admin":false},"repo":{"id":167970553,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc5NzA1NTM=","name":"yasson","full_name":"bravehorsie/yasson","private":false,"owner":{"login":"bravehorsie","id":9378230,"node_id":"MDQ6VXNlcjkzNzgyMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/9378230?v=4","gravatar_id":"","url":"https://api.github.com/users/bravehorsie","html_url":"https://github.com/bravehorsie","followers_url":"https://api.github.com/users/bravehorsie/followers","following_url":"https://api.github.com/users/bravehorsie/following{/other_user}","gists_url":"https://api.github.com/users/bravehorsie/gists{/gist_id}","starred_url":"https://api.github.com/users/bravehorsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bravehorsie/subscriptions","organizations_url":"https://api.github.com/users/bravehorsie/orgs","repos_url":"https://api.github.com/users/bravehorsie/repos","events_url":"https://api.github.com/users/bravehorsie/events{/privacy}","received_events_url":"https://api.github.com/users/bravehorsie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bravehorsie/yasson","description":"Eclipse Yasson project","fork":true,"url":"https://api.github.com/repos/bravehorsie/yasson","forks_url":"https://api.github.com/repos/bravehorsie/yasson/forks","keys_url":"https://api.github.com/repos/bravehorsie/yasson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bravehorsie/yasson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bravehorsie/yasson/teams","hooks_url":"https://api.github.com/repos/bravehorsie/yasson/hooks","issue_events_url":"https://api.github.com/repos/bravehorsie/yasson/issues/events{/number}","events_url":"https://api.github.com/repos/bravehorsie/yasson/events","assignees_url":"https://api.github.com/repos/bravehorsie/yasson/assignees{/user}","branches_url":"https://api.github.com/repos/bravehorsie/yasson/branches{/branch}","tags_url":"https://api.github.com/repos/bravehorsie/yasson/tags","blobs_url":"https://api.github.com/repos/bravehorsie/yasson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bravehorsie/yasson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bravehorsie/yasson/git/refs{/sha}","trees_url":"https://api.github.com/repos/bravehorsie/yasson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bravehorsie/yasson/statuses/{sha}","languages_url":"https://api.github.com/repos/bravehorsie/yasson/languages","stargazers_url":"https://api.github.com/repos/bravehorsie/yasson/stargazers","contributors_url":"https://api.github.com/repos/bravehorsie/yasson/contributors","subscribers_url":"https://api.github.com/repos/bravehorsie/yasson/subscribers","subscription_url":"https://api.github.com/repos/bravehorsie/yasson/subscription","commits_url":"https://api.github.com/repos/bravehorsie/yasson/commits{/sha}","git_commits_url":"https://api.github.com/repos/bravehorsie/yasson/git/commits{/sha}","comments_url":"https://api.github.com/repos/bravehorsie/yasson/comments{/number}","issue_comment_url":"https://api.github.com/repos/bravehorsie/yasson/issues/comments{/number}","contents_url":"https://api.github.com/repos/bravehorsie/yasson/contents/{+path}","compare_url":"https://api.github.com/repos/bravehorsie/yasson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bravehorsie/yasson/merges","archive_url":"https://api.github.com/repos/bravehorsie/yasson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bravehorsie/yasson/downloads","issues_url":"https://api.github.com/repos/bravehorsie/yasson/issues{/number}","pulls_url":"https://api.github.com/repos/bravehorsie/yasson/pulls{/number}","milestones_url":"https://api.github.com/repos/bravehorsie/yasson/milestones{/number}","notifications_url":"https://api.github.com/repos/bravehorsie/yasson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bravehorsie/yasson/labels{/name}","releases_url":"https://api.github.com/repos/bravehorsie/yasson/releases{/id}","deployments_url":"https://api.github.com/repos/bravehorsie/yasson/deployments","created_at":"2019-01-28T13:54:17Z","updated_at":"2019-02-14T09:46:24Z","pushed_at":"2019-03-01T14:46:20Z","git_url":"git://github.com/bravehorsie/yasson.git","ssh_url":"git@github.com:bravehorsie/yasson.git","clone_url":"https://github.com/bravehorsie/yasson.git","svn_url":"https://github.com/bravehorsie/yasson","homepage":"https://projects.eclipse.org/projects/ee4j.yasson","size":1441,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse-ee4j:master","ref":"master","sha":"9024640eb56642247b56266e695c25c54f28949b","user":{"login":"eclipse-ee4j","id":31900942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAwOTQy","avatar_url":"https://avatars3.githubusercontent.com/u/31900942?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse-ee4j","html_url":"https://github.com/eclipse-ee4j","followers_url":"https://api.github.com/users/eclipse-ee4j/followers","following_url":"https://api.github.com/users/eclipse-ee4j/following{/other_user}","gists_url":"https://api.github.com/users/eclipse-ee4j/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse-ee4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse-ee4j/subscriptions","organizations_url":"https://api.github.com/users/eclipse-ee4j/orgs","repos_url":"https://api.github.com/users/eclipse-ee4j/repos","events_url":"https://api.github.com/users/eclipse-ee4j/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse-ee4j/received_events","type":"Organization","site_admin":false},"repo":{"id":74138254,"node_id":"MDEwOlJlcG9zaXRvcnk3NDEzODI1NA==","name":"yasson","full_name":"eclipse-ee4j/yasson","private":false,"owner":{"login":"eclipse-ee4j","id":31900942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAwOTQy","avatar_url":"https://avatars3.githubusercontent.com/u/31900942?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse-ee4j","html_url":"https://github.com/eclipse-ee4j","followers_url":"https://api.github.com/users/eclipse-ee4j/followers","following_url":"https://api.github.com/users/eclipse-ee4j/following{/other_user}","gists_url":"https://api.github.com/users/eclipse-ee4j/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse-ee4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse-ee4j/subscriptions","organizations_url":"https://api.github.com/users/eclipse-ee4j/orgs","repos_url":"https://api.github.com/users/eclipse-ee4j/repos","events_url":"https://api.github.com/users/eclipse-ee4j/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse-ee4j/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse-ee4j/yasson","description":"Eclipse Yasson project","fork":false,"url":"https://api.github.com/repos/eclipse-ee4j/yasson","forks_url":"https://api.github.com/repos/eclipse-ee4j/yasson/forks","keys_url":"https://api.github.com/repos/eclipse-ee4j/yasson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse-ee4j/yasson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse-ee4j/yasson/teams","hooks_url":"https://api.github.com/repos/eclipse-ee4j/yasson/hooks","issue_events_url":"https://api.github.com/repos/eclipse-ee4j/yasson/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse-ee4j/yasson/events","assignees_url":"https://api.github.com/repos/eclipse-ee4j/yasson/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse-ee4j/yasson/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse-ee4j/yasson/tags","blobs_url":"https://api.github.com/repos/eclipse-ee4j/yasson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse-ee4j/yasson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse-ee4j/yasson/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse-ee4j/yasson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse-ee4j/yasson/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse-ee4j/yasson/languages","stargazers_url":"https://api.github.com/repos/eclipse-ee4j/yasson/stargazers","contributors_url":"https://api.github.com/repos/eclipse-ee4j/yasson/contributors","subscribers_url":"https://api.github.com/repos/eclipse-ee4j/yasson/subscribers","subscription_url":"https://api.github.com/repos/eclipse-ee4j/yasson/subscription","commits_url":"https://api.github.com/repos/eclipse-ee4j/yasson/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse-ee4j/yasson/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse-ee4j/yasson/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse-ee4j/yasson/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse-ee4j/yasson/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse-ee4j/yasson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse-ee4j/yasson/merges","archive_url":"https://api.github.com/repos/eclipse-ee4j/yasson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse-ee4j/yasson/downloads","issues_url":"https://api.github.com/repos/eclipse-ee4j/yasson/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse-ee4j/yasson/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse-ee4j/yasson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse-ee4j/yasson/labels{/name}","releases_url":"https://api.github.com/repos/eclipse-ee4j/yasson/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse-ee4j/yasson/deployments","created_at":"2016-11-18T14:46:19Z","updated_at":"2019-03-01T15:04:24Z","pushed_at":"2019-03-06T15:28:06Z","git_url":"git://github.com/eclipse-ee4j/yasson.git","ssh_url":"git@github.com:eclipse-ee4j/yasson.git","clone_url":"https://github.com/eclipse-ee4j/yasson.git","svn_url":"https://github.com/eclipse-ee4j/yasson","homepage":"https://projects.eclipse.org/projects/ee4j.yasson","size":2060,"stargazers_count":99,"watchers_count":99,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":27,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/246"},"html":{"href":"https://github.com/eclipse-ee4j/yasson/pull/246"},"issue":{"href":"https://api.github.com/repos/eclipse-ee4j/yasson/issues/246"},"comments":{"href":"https://api.github.com/repos/eclipse-ee4j/yasson/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse-ee4j/yasson/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse-ee4j/yasson/statuses/62dc006ac312fc8b1543892b82a14ef6485d6fa3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aguibert"}}