{"action":"created","issue":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/666","repository_url":"https://api.github.com/repos/jprichardson/node-fs-extra","labels_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/666/labels{/name}","comments_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/666/comments","events_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/666/events","html_url":"https://github.com/jprichardson/node-fs-extra/pull/666","id":425874271,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0ODYwODMz","number":666,"title":"CheckPath Error -> Warn of Inode.","user":{"login":"Domvel","id":35452565,"node_id":"MDQ6VXNlcjM1NDUyNTY1","avatar_url":"https://avatars0.githubusercontent.com/u/35452565?v=4","gravatar_id":"","url":"https://api.github.com/users/Domvel","html_url":"https://github.com/Domvel","followers_url":"https://api.github.com/users/Domvel/followers","following_url":"https://api.github.com/users/Domvel/following{/other_user}","gists_url":"https://api.github.com/users/Domvel/gists{/gist_id}","starred_url":"https://api.github.com/users/Domvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Domvel/subscriptions","organizations_url":"https://api.github.com/users/Domvel/orgs","repos_url":"https://api.github.com/users/Domvel/repos","events_url":"https://api.github.com/users/Domvel/events{/privacy}","received_events_url":"https://api.github.com/users/Domvel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-03-27T10:21:33Z","updated_at":"2019-03-28T06:34:07Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/pulls/666","html_url":"https://github.com/jprichardson/node-fs-extra/pull/666","diff_url":"https://github.com/jprichardson/node-fs-extra/pull/666.diff","patch_url":"https://github.com/jprichardson/node-fs-extra/pull/666.patch"},"body":"https://github.com/jprichardson/node-fs-extra/issues/657\r\n\r\nThe inode number is an integer unique to the volume upon which it is stored.\r\nThat means, the method checkPaths() disallows me to copy a file from one to another volume.\r\nAlso `fs-extra` does not set the big-integer flag of node `fs`. It's only a \"default\" JavaScript number (max integer is 53-bit). [See the difference here](https://stackblitz.com/edit/js-bigint-comparison?embed=1&file=index.js) On Windows the cap is reached.\r\n\r\nNo option provided, because checking if Inode is the wrong way. It's not only a big-integer issue. Inodes are only unique to the volume upon which it is stored.\r\n\r\nThis will fix the issue #657 \r\nI keep it as warning to see it when is happen.\r\nMaybe not the best solution. But with the thrown error, it is not possible to use it.\r\nExample: It's not possible to stable build with Android-Cordova 8.x. Because Cordova switched to `fs-extra` since version 8.x. \r\n\r\nBetter solutions are welcome. But keep in mind that the Inode (state.ino of fs) is not really unique global and in current fs-extra implementation. Again:\r\n- The inode number is an integer unique to the volume upon which it is stored.\r\n- `state.ino` of `fs` also supports `big-integer`. Node version 10.4 is required to use this. But currently it's set for `number` (53-bit) only.\r\n\r\nThe aim is to remove / replace this check. Because it's faulty. (Inode) You'll get errors from `fs` / `os`.\r\n"},"comment":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/comments/477467389","html_url":"https://github.com/jprichardson/node-fs-extra/pull/666#issuecomment-477467389","issue_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/666","id":477467389,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3NzQ2NzM4OQ==","user":{"login":"iamsim","id":19293720,"node_id":"MDQ6VXNlcjE5MjkzNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19293720?v=4","gravatar_id":"","url":"https://api.github.com/users/iamsim","html_url":"https://github.com/iamsim","followers_url":"https://api.github.com/users/iamsim/followers","following_url":"https://api.github.com/users/iamsim/following{/other_user}","gists_url":"https://api.github.com/users/iamsim/gists{/gist_id}","starred_url":"https://api.github.com/users/iamsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamsim/subscriptions","organizations_url":"https://api.github.com/users/iamsim/orgs","repos_url":"https://api.github.com/users/iamsim/repos","events_url":"https://api.github.com/users/iamsim/events{/privacy}","received_events_url":"https://api.github.com/users/iamsim/received_events","type":"User","site_admin":false},"created_at":"2019-03-28T06:34:06Z","updated_at":"2019-03-28T06:34:06Z","author_association":"NONE","body":"> Downgrade to Cordova 7.x and also build on Windows. Because Cordova 7.x does not use fs-extra.\r\n\r\nDoing this now!\r\nWill keep you updated if I find a fix.\r\nBut please keep me in mind if you find a fix.\r\n\r\nReally thank you for a response. 🙂"}}
{"actor":{"display_login":"iamsim"}}