{"action":"created","comment":{"url":"https://api.github.com/repos/quarkusio/quarkus/pulls/comments/348930737","pull_request_review_id":320685091,"id":348930737,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODkzMDczNw==","diff_hunk":"@@ -91,7 +91,7 @@ InfinispanPropertiesBuildItem setup(ApplicationArchivesBuildItem applicationArch\n         // Enable SSL support by default\n         sslNativeSupport.produce(new ExtensionSslNativeSupportBuildItem(FeatureBuildItem.INFINISPAN_CLIENT));\n \n-        ClassLoader cl = Thread.currentThread().getContextClassLoader();","path":"extensions/infinispan-client/deployment/src/main/java/io/quarkus/infinispan/client/deployment/InfinispanClientProcessor.java","position":4,"original_position":4,"commit_id":"e447f09e6c046982b0ad78a4a5cad60b0e775032","original_commit_id":"e447f09e6c046982b0ad78a4a5cad60b0e775032","user":{"login":"stuartwdouglas","id":328571,"node_id":"MDQ6VXNlcjMyODU3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/328571?v=4","gravatar_id":"","url":"https://api.github.com/users/stuartwdouglas","html_url":"https://github.com/stuartwdouglas","followers_url":"https://api.github.com/users/stuartwdouglas/followers","following_url":"https://api.github.com/users/stuartwdouglas/following{/other_user}","gists_url":"https://api.github.com/users/stuartwdouglas/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartwdouglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartwdouglas/subscriptions","organizations_url":"https://api.github.com/users/stuartwdouglas/orgs","repos_url":"https://api.github.com/users/stuartwdouglas/repos","events_url":"https://api.github.com/users/stuartwdouglas/events{/privacy}","received_events_url":"https://api.github.com/users/stuartwdouglas/received_events","type":"User","site_admin":false},"body":"This should also use loadsApplicationClasses and just use the TCCL (not the fault of this PR, but while we are fixing these issues might as well get this one too).\r\n\r\nI know it seems like a bit of a corner case (the wrong TCCL being set during class loading), but this did actually cause real issues in the early days of WildFly so it can be a problem.","created_at":"2019-11-21T07:37:10Z","updated_at":"2019-11-21T07:37:15Z","html_url":"https://github.com/quarkusio/quarkus/pull/5632#discussion_r348930737","pull_request_url":"https://api.github.com/repos/quarkusio/quarkus/pulls/5632","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/quarkusio/quarkus/pulls/comments/348930737"},"html":{"href":"https://github.com/quarkusio/quarkus/pull/5632#discussion_r348930737"},"pull_request":{"href":"https://api.github.com/repos/quarkusio/quarkus/pulls/5632"}}},"pull_request":{"url":"https://api.github.com/repos/quarkusio/quarkus/pulls/5632","id":343407131,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzNDA3MTMx","html_url":"https://github.com/quarkusio/quarkus/pull/5632","diff_url":"https://github.com/quarkusio/quarkus/pull/5632.diff","patch_url":"https://github.com/quarkusio/quarkus/pull/5632.patch","issue_url":"https://api.github.com/repos/quarkusio/quarkus/issues/5632","number":5632,"state":"open","locked":false,"title":"Replace TCCL with CL from DeploymentClassLoaderBuildItem in deployment modules","user":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"body":"This doesn't fix a bug or anything, it's just the \"proper\" way of obtaining a ClassLoader that can load classes in a build step","created_at":"2019-11-20T15:12:37Z","updated_at":"2019-11-21T07:37:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"353a954b4341ebbc9a6dd303acb5a97761dfd3c8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cescoffier","id":402301,"node_id":"MDQ6VXNlcjQwMjMwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/402301?v=4","gravatar_id":"","url":"https://api.github.com/users/cescoffier","html_url":"https://github.com/cescoffier","followers_url":"https://api.github.com/users/cescoffier/followers","following_url":"https://api.github.com/users/cescoffier/following{/other_user}","gists_url":"https://api.github.com/users/cescoffier/gists{/gist_id}","starred_url":"https://api.github.com/users/cescoffier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cescoffier/subscriptions","organizations_url":"https://api.github.com/users/cescoffier/orgs","repos_url":"https://api.github.com/users/cescoffier/repos","events_url":"https://api.github.com/users/cescoffier/events{/privacy}","received_events_url":"https://api.github.com/users/cescoffier/received_events","type":"User","site_admin":false},{"login":"mkouba","id":913004,"node_id":"MDQ6VXNlcjkxMzAwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/913004?v=4","gravatar_id":"","url":"https://api.github.com/users/mkouba","html_url":"https://github.com/mkouba","followers_url":"https://api.github.com/users/mkouba/followers","following_url":"https://api.github.com/users/mkouba/following{/other_user}","gists_url":"https://api.github.com/users/mkouba/gists{/gist_id}","starred_url":"https://api.github.com/users/mkouba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkouba/subscriptions","organizations_url":"https://api.github.com/users/mkouba/orgs","repos_url":"https://api.github.com/users/mkouba/repos","events_url":"https://api.github.com/users/mkouba/events{/privacy}","received_events_url":"https://api.github.com/users/mkouba/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/quarkusio/quarkus/milestones/43","html_url":"https://github.com/quarkusio/quarkus/milestone/43","labels_url":"https://api.github.com/repos/quarkusio/quarkus/milestones/43/labels","id":4810978,"node_id":"MDk6TWlsZXN0b25lNDgxMDk3OA==","number":43,"title":"1.1.0","description":"","creator":{"login":"Sanne","id":42573,"node_id":"MDQ6VXNlcjQyNTcz","avatar_url":"https://avatars0.githubusercontent.com/u/42573?v=4","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":129,"state":"open","created_at":"2019-11-04T09:29:45Z","updated_at":"2019-11-21T06:36:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/quarkusio/quarkus/pulls/5632/commits","review_comments_url":"https://api.github.com/repos/quarkusio/quarkus/pulls/5632/comments","review_comment_url":"https://api.github.com/repos/quarkusio/quarkus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quarkusio/quarkus/issues/5632/comments","statuses_url":"https://api.github.com/repos/quarkusio/quarkus/statuses/e447f09e6c046982b0ad78a4a5cad60b0e775032","head":{"label":"geoand:reactive-messaging-cl","ref":"reactive-messaging-cl","sha":"e447f09e6c046982b0ad78a4a5cad60b0e775032","user":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"repo":{"id":174345441,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQzNDU0NDE=","name":"quarkus","full_name":"geoand/quarkus","private":false,"owner":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"html_url":"https://github.com/geoand/quarkus","description":"Quarkus: Supersonic Subatomic Java. ","fork":true,"url":"https://api.github.com/repos/geoand/quarkus","forks_url":"https://api.github.com/repos/geoand/quarkus/forks","keys_url":"https://api.github.com/repos/geoand/quarkus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoand/quarkus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoand/quarkus/teams","hooks_url":"https://api.github.com/repos/geoand/quarkus/hooks","issue_events_url":"https://api.github.com/repos/geoand/quarkus/issues/events{/number}","events_url":"https://api.github.com/repos/geoand/quarkus/events","assignees_url":"https://api.github.com/repos/geoand/quarkus/assignees{/user}","branches_url":"https://api.github.com/repos/geoand/quarkus/branches{/branch}","tags_url":"https://api.github.com/repos/geoand/quarkus/tags","blobs_url":"https://api.github.com/repos/geoand/quarkus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoand/quarkus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoand/quarkus/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoand/quarkus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoand/quarkus/statuses/{sha}","languages_url":"https://api.github.com/repos/geoand/quarkus/languages","stargazers_url":"https://api.github.com/repos/geoand/quarkus/stargazers","contributors_url":"https://api.github.com/repos/geoand/quarkus/contributors","subscribers_url":"https://api.github.com/repos/geoand/quarkus/subscribers","subscription_url":"https://api.github.com/repos/geoand/quarkus/subscription","commits_url":"https://api.github.com/repos/geoand/quarkus/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoand/quarkus/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoand/quarkus/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoand/quarkus/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoand/quarkus/contents/{+path}","compare_url":"https://api.github.com/repos/geoand/quarkus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoand/quarkus/merges","archive_url":"https://api.github.com/repos/geoand/quarkus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoand/quarkus/downloads","issues_url":"https://api.github.com/repos/geoand/quarkus/issues{/number}","pulls_url":"https://api.github.com/repos/geoand/quarkus/pulls{/number}","milestones_url":"https://api.github.com/repos/geoand/quarkus/milestones{/number}","notifications_url":"https://api.github.com/repos/geoand/quarkus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoand/quarkus/labels{/name}","releases_url":"https://api.github.com/repos/geoand/quarkus/releases{/id}","deployments_url":"https://api.github.com/repos/geoand/quarkus/deployments","created_at":"2019-03-07T13:05:07Z","updated_at":"2019-03-07T13:05:12Z","pushed_at":"2019-11-21T07:31:36Z","git_url":"git://github.com/geoand/quarkus.git","ssh_url":"git@github.com:geoand/quarkus.git","clone_url":"https://github.com/geoand/quarkus.git","svn_url":"https://github.com/geoand/quarkus","homepage":"https://quarkus.io","size":34100,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quarkusio:master","ref":"master","sha":"493ff762f80bc96d9ecd1504bdc8ce096babe033","user":{"login":"quarkusio","id":47638783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjM4Nzgz","avatar_url":"https://avatars0.githubusercontent.com/u/47638783?v=4","gravatar_id":"","url":"https://api.github.com/users/quarkusio","html_url":"https://github.com/quarkusio","followers_url":"https://api.github.com/users/quarkusio/followers","following_url":"https://api.github.com/users/quarkusio/following{/other_user}","gists_url":"https://api.github.com/users/quarkusio/gists{/gist_id}","starred_url":"https://api.github.com/users/quarkusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quarkusio/subscriptions","organizations_url":"https://api.github.com/users/quarkusio/orgs","repos_url":"https://api.github.com/users/quarkusio/repos","events_url":"https://api.github.com/users/quarkusio/events{/privacy}","received_events_url":"https://api.github.com/users/quarkusio/received_events","type":"Organization","site_admin":false},"repo":{"id":139914932,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5MTQ5MzI=","name":"quarkus","full_name":"quarkusio/quarkus","private":false,"owner":{"login":"quarkusio","id":47638783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjM4Nzgz","avatar_url":"https://avatars0.githubusercontent.com/u/47638783?v=4","gravatar_id":"","url":"https://api.github.com/users/quarkusio","html_url":"https://github.com/quarkusio","followers_url":"https://api.github.com/users/quarkusio/followers","following_url":"https://api.github.com/users/quarkusio/following{/other_user}","gists_url":"https://api.github.com/users/quarkusio/gists{/gist_id}","starred_url":"https://api.github.com/users/quarkusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quarkusio/subscriptions","organizations_url":"https://api.github.com/users/quarkusio/orgs","repos_url":"https://api.github.com/users/quarkusio/repos","events_url":"https://api.github.com/users/quarkusio/events{/privacy}","received_events_url":"https://api.github.com/users/quarkusio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/quarkusio/quarkus","description":"Quarkus: Supersonic Subatomic Java. ","fork":false,"url":"https://api.github.com/repos/quarkusio/quarkus","forks_url":"https://api.github.com/repos/quarkusio/quarkus/forks","keys_url":"https://api.github.com/repos/quarkusio/quarkus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quarkusio/quarkus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quarkusio/quarkus/teams","hooks_url":"https://api.github.com/repos/quarkusio/quarkus/hooks","issue_events_url":"https://api.github.com/repos/quarkusio/quarkus/issues/events{/number}","events_url":"https://api.github.com/repos/quarkusio/quarkus/events","assignees_url":"https://api.github.com/repos/quarkusio/quarkus/assignees{/user}","branches_url":"https://api.github.com/repos/quarkusio/quarkus/branches{/branch}","tags_url":"https://api.github.com/repos/quarkusio/quarkus/tags","blobs_url":"https://api.github.com/repos/quarkusio/quarkus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quarkusio/quarkus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quarkusio/quarkus/git/refs{/sha}","trees_url":"https://api.github.com/repos/quarkusio/quarkus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quarkusio/quarkus/statuses/{sha}","languages_url":"https://api.github.com/repos/quarkusio/quarkus/languages","stargazers_url":"https://api.github.com/repos/quarkusio/quarkus/stargazers","contributors_url":"https://api.github.com/repos/quarkusio/quarkus/contributors","subscribers_url":"https://api.github.com/repos/quarkusio/quarkus/subscribers","subscription_url":"https://api.github.com/repos/quarkusio/quarkus/subscription","commits_url":"https://api.github.com/repos/quarkusio/quarkus/commits{/sha}","git_commits_url":"https://api.github.com/repos/quarkusio/quarkus/git/commits{/sha}","comments_url":"https://api.github.com/repos/quarkusio/quarkus/comments{/number}","issue_comment_url":"https://api.github.com/repos/quarkusio/quarkus/issues/comments{/number}","contents_url":"https://api.github.com/repos/quarkusio/quarkus/contents/{+path}","compare_url":"https://api.github.com/repos/quarkusio/quarkus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quarkusio/quarkus/merges","archive_url":"https://api.github.com/repos/quarkusio/quarkus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quarkusio/quarkus/downloads","issues_url":"https://api.github.com/repos/quarkusio/quarkus/issues{/number}","pulls_url":"https://api.github.com/repos/quarkusio/quarkus/pulls{/number}","milestones_url":"https://api.github.com/repos/quarkusio/quarkus/milestones{/number}","notifications_url":"https://api.github.com/repos/quarkusio/quarkus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quarkusio/quarkus/labels{/name}","releases_url":"https://api.github.com/repos/quarkusio/quarkus/releases{/id}","deployments_url":"https://api.github.com/repos/quarkusio/quarkus/deployments","created_at":"2018-07-06T00:44:20Z","updated_at":"2019-11-21T07:13:42Z","pushed_at":"2019-11-21T07:31:38Z","git_url":"git://github.com/quarkusio/quarkus.git","ssh_url":"git@github.com:quarkusio/quarkus.git","clone_url":"https://github.com/quarkusio/quarkus.git","svn_url":"https://github.com/quarkusio/quarkus","homepage":"https://quarkus.io","size":37150,"stargazers_count":3228,"watchers_count":3228,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":519,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":698,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":519,"open_issues":698,"watchers":3228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quarkusio/quarkus/pulls/5632"},"html":{"href":"https://github.com/quarkusio/quarkus/pull/5632"},"issue":{"href":"https://api.github.com/repos/quarkusio/quarkus/issues/5632"},"comments":{"href":"https://api.github.com/repos/quarkusio/quarkus/issues/5632/comments"},"review_comments":{"href":"https://api.github.com/repos/quarkusio/quarkus/pulls/5632/comments"},"review_comment":{"href":"https://api.github.com/repos/quarkusio/quarkus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quarkusio/quarkus/pulls/5632/commits"},"statuses":{"href":"https://api.github.com/repos/quarkusio/quarkus/statuses/e447f09e6c046982b0ad78a4a5cad60b0e775032"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stuartwdouglas"}}