{"action":"created","comment":{"url":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/comments/294240127","pull_request_review_id":250422694,"id":294240127,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDI0MDEyNw==","diff_hunk":"@@ -13,6 +13,7 @@\n public enum ProtocolVersion {\n   UNKNOWN(-1, \"Unknown\"),\n   LEGACY(-2, \"Legacy\"),\n+  MINECRAFT_1_7(5, \"1.7\"),","path":"api/src/main/java/com/velocitypowered/api/network/ProtocolVersion.java","position":4,"original_position":4,"commit_id":"708cae8a6716925f99c89fffb7fa6d011d6edcc2","original_commit_id":"708cae8a6716925f99c89fffb7fa6d011d6edcc2","user":{"login":"Leymooo","id":8667294,"node_id":"MDQ6VXNlcjg2NjcyOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8667294?v=4","gravatar_id":"","url":"https://api.github.com/users/Leymooo","html_url":"https://github.com/Leymooo","followers_url":"https://api.github.com/users/Leymooo/followers","following_url":"https://api.github.com/users/Leymooo/following{/other_user}","gists_url":"https://api.github.com/users/Leymooo/gists{/gist_id}","starred_url":"https://api.github.com/users/Leymooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leymooo/subscriptions","organizations_url":"https://api.github.com/users/Leymooo/orgs","repos_url":"https://api.github.com/users/Leymooo/repos","events_url":"https://api.github.com/users/Leymooo/events{/privacy}","received_events_url":"https://api.github.com/users/Leymooo/received_events","type":"User","site_admin":false},"body":"1.7 - 1.7.10 have multiple protocol versions (1.7-1.7.5, 1.7.6-1.7.10 if i not mistaken)","created_at":"2019-06-17T10:48:48Z","updated_at":"2019-06-17T10:50:20Z","html_url":"https://github.com/VelocityPowered/Velocity/pull/219#discussion_r294240127","pull_request_url":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/219","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/comments/294240127"},"html":{"href":"https://github.com/VelocityPowered/Velocity/pull/219#discussion_r294240127"},"pull_request":{"href":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/219"}}},"pull_request":{"url":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/219","id":288788717,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4Nzg4NzE3","html_url":"https://github.com/VelocityPowered/Velocity/pull/219","diff_url":"https://github.com/VelocityPowered/Velocity/pull/219.diff","patch_url":"https://github.com/VelocityPowered/Velocity/pull/219.patch","issue_url":"https://api.github.com/repos/VelocityPowered/Velocity/issues/219","number":219,"state":"open","locked":false,"title":"1.7 Protocol Support","user":{"login":"Gabik21MC","id":22858790,"node_id":"MDQ6VXNlcjIyODU4Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/22858790?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabik21MC","html_url":"https://github.com/Gabik21MC","followers_url":"https://api.github.com/users/Gabik21MC/followers","following_url":"https://api.github.com/users/Gabik21MC/following{/other_user}","gists_url":"https://api.github.com/users/Gabik21MC/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabik21MC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabik21MC/subscriptions","organizations_url":"https://api.github.com/users/Gabik21MC/orgs","repos_url":"https://api.github.com/users/Gabik21MC/repos","events_url":"https://api.github.com/users/Gabik21MC/events{/privacy}","received_events_url":"https://api.github.com/users/Gabik21MC/received_events","type":"User","site_admin":false},"body":"This PR implements support for the _evil_ 6 year old minecraft version.\r\nI am down to support this if there are issues.\r\n\r\nI tested a join from 1.7, 1.8, 1.13 and 1.14\r\nI tested server switching for 1.7 and 1.8 \r\nBut for server switching nothing had to be changed apart from the clearAll for tablist.","created_at":"2019-06-17T10:36:47Z","updated_at":"2019-06-17T10:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"350ebe00e04472ce83791cfc13623c880cab7109","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/219/commits","review_comments_url":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/219/comments","review_comment_url":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VelocityPowered/Velocity/issues/219/comments","statuses_url":"https://api.github.com/repos/VelocityPowered/Velocity/statuses/708cae8a6716925f99c89fffb7fa6d011d6edcc2","head":{"label":"Gabik21MC:master","ref":"master","sha":"708cae8a6716925f99c89fffb7fa6d011d6edcc2","user":{"login":"Gabik21MC","id":22858790,"node_id":"MDQ6VXNlcjIyODU4Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/22858790?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabik21MC","html_url":"https://github.com/Gabik21MC","followers_url":"https://api.github.com/users/Gabik21MC/followers","following_url":"https://api.github.com/users/Gabik21MC/following{/other_user}","gists_url":"https://api.github.com/users/Gabik21MC/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabik21MC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabik21MC/subscriptions","organizations_url":"https://api.github.com/users/Gabik21MC/orgs","repos_url":"https://api.github.com/users/Gabik21MC/repos","events_url":"https://api.github.com/users/Gabik21MC/events{/privacy}","received_events_url":"https://api.github.com/users/Gabik21MC/received_events","type":"User","site_admin":false},"repo":{"id":190636825,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA2MzY4MjU=","name":"Velocity","full_name":"Gabik21MC/Velocity","private":false,"owner":{"login":"Gabik21MC","id":22858790,"node_id":"MDQ6VXNlcjIyODU4Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/22858790?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabik21MC","html_url":"https://github.com/Gabik21MC","followers_url":"https://api.github.com/users/Gabik21MC/followers","following_url":"https://api.github.com/users/Gabik21MC/following{/other_user}","gists_url":"https://api.github.com/users/Gabik21MC/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabik21MC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabik21MC/subscriptions","organizations_url":"https://api.github.com/users/Gabik21MC/orgs","repos_url":"https://api.github.com/users/Gabik21MC/repos","events_url":"https://api.github.com/users/Gabik21MC/events{/privacy}","received_events_url":"https://api.github.com/users/Gabik21MC/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Gabik21MC/Velocity","description":"A Minecraft server proxy with unparalleled server support, scalability, and flexibility.","fork":true,"url":"https://api.github.com/repos/Gabik21MC/Velocity","forks_url":"https://api.github.com/repos/Gabik21MC/Velocity/forks","keys_url":"https://api.github.com/repos/Gabik21MC/Velocity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gabik21MC/Velocity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gabik21MC/Velocity/teams","hooks_url":"https://api.github.com/repos/Gabik21MC/Velocity/hooks","issue_events_url":"https://api.github.com/repos/Gabik21MC/Velocity/issues/events{/number}","events_url":"https://api.github.com/repos/Gabik21MC/Velocity/events","assignees_url":"https://api.github.com/repos/Gabik21MC/Velocity/assignees{/user}","branches_url":"https://api.github.com/repos/Gabik21MC/Velocity/branches{/branch}","tags_url":"https://api.github.com/repos/Gabik21MC/Velocity/tags","blobs_url":"https://api.github.com/repos/Gabik21MC/Velocity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gabik21MC/Velocity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gabik21MC/Velocity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gabik21MC/Velocity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gabik21MC/Velocity/statuses/{sha}","languages_url":"https://api.github.com/repos/Gabik21MC/Velocity/languages","stargazers_url":"https://api.github.com/repos/Gabik21MC/Velocity/stargazers","contributors_url":"https://api.github.com/repos/Gabik21MC/Velocity/contributors","subscribers_url":"https://api.github.com/repos/Gabik21MC/Velocity/subscribers","subscription_url":"https://api.github.com/repos/Gabik21MC/Velocity/subscription","commits_url":"https://api.github.com/repos/Gabik21MC/Velocity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gabik21MC/Velocity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gabik21MC/Velocity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gabik21MC/Velocity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gabik21MC/Velocity/contents/{+path}","compare_url":"https://api.github.com/repos/Gabik21MC/Velocity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gabik21MC/Velocity/merges","archive_url":"https://api.github.com/repos/Gabik21MC/Velocity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gabik21MC/Velocity/downloads","issues_url":"https://api.github.com/repos/Gabik21MC/Velocity/issues{/number}","pulls_url":"https://api.github.com/repos/Gabik21MC/Velocity/pulls{/number}","milestones_url":"https://api.github.com/repos/Gabik21MC/Velocity/milestones{/number}","notifications_url":"https://api.github.com/repos/Gabik21MC/Velocity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gabik21MC/Velocity/labels{/name}","releases_url":"https://api.github.com/repos/Gabik21MC/Velocity/releases{/id}","deployments_url":"https://api.github.com/repos/Gabik21MC/Velocity/deployments","created_at":"2019-06-06T19:18:49Z","updated_at":"2019-06-17T10:17:28Z","pushed_at":"2019-06-17T10:17:26Z","git_url":"git://github.com/Gabik21MC/Velocity.git","ssh_url":"git@github.com:Gabik21MC/Velocity.git","clone_url":"https://github.com/Gabik21MC/Velocity.git","svn_url":"https://github.com/Gabik21MC/Velocity","homepage":"https://www.velocitypowered.com","size":1864,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"VelocityPowered:master","ref":"master","sha":"1fd2bd9ee446e9b13bb7068ff7fdac01e9069e6c","user":{"login":"VelocityPowered","id":41710604,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNzEwNjA0","avatar_url":"https://avatars3.githubusercontent.com/u/41710604?v=4","gravatar_id":"","url":"https://api.github.com/users/VelocityPowered","html_url":"https://github.com/VelocityPowered","followers_url":"https://api.github.com/users/VelocityPowered/followers","following_url":"https://api.github.com/users/VelocityPowered/following{/other_user}","gists_url":"https://api.github.com/users/VelocityPowered/gists{/gist_id}","starred_url":"https://api.github.com/users/VelocityPowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VelocityPowered/subscriptions","organizations_url":"https://api.github.com/users/VelocityPowered/orgs","repos_url":"https://api.github.com/users/VelocityPowered/repos","events_url":"https://api.github.com/users/VelocityPowered/events{/privacy}","received_events_url":"https://api.github.com/users/VelocityPowered/received_events","type":"Organization","site_admin":false},"repo":{"id":142085119,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwODUxMTk=","name":"Velocity","full_name":"VelocityPowered/Velocity","private":false,"owner":{"login":"VelocityPowered","id":41710604,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNzEwNjA0","avatar_url":"https://avatars3.githubusercontent.com/u/41710604?v=4","gravatar_id":"","url":"https://api.github.com/users/VelocityPowered","html_url":"https://github.com/VelocityPowered","followers_url":"https://api.github.com/users/VelocityPowered/followers","following_url":"https://api.github.com/users/VelocityPowered/following{/other_user}","gists_url":"https://api.github.com/users/VelocityPowered/gists{/gist_id}","starred_url":"https://api.github.com/users/VelocityPowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VelocityPowered/subscriptions","organizations_url":"https://api.github.com/users/VelocityPowered/orgs","repos_url":"https://api.github.com/users/VelocityPowered/repos","events_url":"https://api.github.com/users/VelocityPowered/events{/privacy}","received_events_url":"https://api.github.com/users/VelocityPowered/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VelocityPowered/Velocity","description":"A Minecraft server proxy with unparalleled server support, scalability, and flexibility.","fork":false,"url":"https://api.github.com/repos/VelocityPowered/Velocity","forks_url":"https://api.github.com/repos/VelocityPowered/Velocity/forks","keys_url":"https://api.github.com/repos/VelocityPowered/Velocity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VelocityPowered/Velocity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VelocityPowered/Velocity/teams","hooks_url":"https://api.github.com/repos/VelocityPowered/Velocity/hooks","issue_events_url":"https://api.github.com/repos/VelocityPowered/Velocity/issues/events{/number}","events_url":"https://api.github.com/repos/VelocityPowered/Velocity/events","assignees_url":"https://api.github.com/repos/VelocityPowered/Velocity/assignees{/user}","branches_url":"https://api.github.com/repos/VelocityPowered/Velocity/branches{/branch}","tags_url":"https://api.github.com/repos/VelocityPowered/Velocity/tags","blobs_url":"https://api.github.com/repos/VelocityPowered/Velocity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VelocityPowered/Velocity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VelocityPowered/Velocity/git/refs{/sha}","trees_url":"https://api.github.com/repos/VelocityPowered/Velocity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VelocityPowered/Velocity/statuses/{sha}","languages_url":"https://api.github.com/repos/VelocityPowered/Velocity/languages","stargazers_url":"https://api.github.com/repos/VelocityPowered/Velocity/stargazers","contributors_url":"https://api.github.com/repos/VelocityPowered/Velocity/contributors","subscribers_url":"https://api.github.com/repos/VelocityPowered/Velocity/subscribers","subscription_url":"https://api.github.com/repos/VelocityPowered/Velocity/subscription","commits_url":"https://api.github.com/repos/VelocityPowered/Velocity/commits{/sha}","git_commits_url":"https://api.github.com/repos/VelocityPowered/Velocity/git/commits{/sha}","comments_url":"https://api.github.com/repos/VelocityPowered/Velocity/comments{/number}","issue_comment_url":"https://api.github.com/repos/VelocityPowered/Velocity/issues/comments{/number}","contents_url":"https://api.github.com/repos/VelocityPowered/Velocity/contents/{+path}","compare_url":"https://api.github.com/repos/VelocityPowered/Velocity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VelocityPowered/Velocity/merges","archive_url":"https://api.github.com/repos/VelocityPowered/Velocity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VelocityPowered/Velocity/downloads","issues_url":"https://api.github.com/repos/VelocityPowered/Velocity/issues{/number}","pulls_url":"https://api.github.com/repos/VelocityPowered/Velocity/pulls{/number}","milestones_url":"https://api.github.com/repos/VelocityPowered/Velocity/milestones{/number}","notifications_url":"https://api.github.com/repos/VelocityPowered/Velocity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VelocityPowered/Velocity/labels{/name}","releases_url":"https://api.github.com/repos/VelocityPowered/Velocity/releases{/id}","deployments_url":"https://api.github.com/repos/VelocityPowered/Velocity/deployments","created_at":"2018-07-24T00:51:53Z","updated_at":"2019-06-16T20:55:51Z","pushed_at":"2019-06-17T10:36:47Z","git_url":"git://github.com/VelocityPowered/Velocity.git","ssh_url":"git@github.com:VelocityPowered/Velocity.git","clone_url":"https://github.com/VelocityPowered/Velocity.git","svn_url":"https://github.com/VelocityPowered/Velocity","homepage":"https://www.velocitypowered.com","size":1857,"stargazers_count":166,"watchers_count":166,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":37,"open_issues":10,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/219"},"html":{"href":"https://github.com/VelocityPowered/Velocity/pull/219"},"issue":{"href":"https://api.github.com/repos/VelocityPowered/Velocity/issues/219"},"comments":{"href":"https://api.github.com/repos/VelocityPowered/Velocity/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VelocityPowered/Velocity/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/VelocityPowered/Velocity/statuses/708cae8a6716925f99c89fffb7fa6d011d6edcc2"}},"author_association":"NONE"}}
{"actor":{"display_login":"Leymooo"}}