{"action":"created","issue":{"url":"https://api.github.com/repos/grafana/grafana/issues/15554","repository_url":"https://api.github.com/repos/grafana/grafana","labels_url":"https://api.github.com/repos/grafana/grafana/issues/15554/labels{/name}","comments_url":"https://api.github.com/repos/grafana/grafana/issues/15554/comments","events_url":"https://api.github.com/repos/grafana/grafana/issues/15554/events","html_url":"https://github.com/grafana/grafana/pull/15554","id":412574562,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NzUyMTA3","number":15554,"title":"Lazy loading OMG (from scrollTop) v2","user":{"login":"ryantxu","id":705951,"node_id":"MDQ6VXNlcjcwNTk1MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/705951?v=4","gravatar_id":"","url":"https://api.github.com/users/ryantxu","html_url":"https://github.com/ryantxu","followers_url":"https://api.github.com/users/ryantxu/followers","following_url":"https://api.github.com/users/ryantxu/following{/other_user}","gists_url":"https://api.github.com/users/ryantxu/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantxu/subscriptions","organizations_url":"https://api.github.com/users/ryantxu/orgs","repos_url":"https://api.github.com/users/ryantxu/repos","events_url":"https://api.github.com/users/ryantxu/events{/privacy}","received_events_url":"https://api.github.com/users/ryantxu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-02-20T18:49:03Z","updated_at":"2019-02-20T19:53:27Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/grafana/grafana/pulls/15554","html_url":"https://github.com/grafana/grafana/pull/15554","diff_url":"https://github.com/grafana/grafana/pull/15554.diff","patch_url":"https://github.com/grafana/grafana/pull/15554.patch"},"body":"duplicating #15310 with a new branch after a merge error\r\n\r\nyet-another-lazy-loading-pull-request!\r\n\r\nFollowing @torkelo idea on #15272, this does not use an intersection observer, but (approximately) calculates visibility from the existing scroll events in DashboardGrid.tsx\r\n\r\nThis seems to work well!\r\n\r\nOpen questions:\r\n- Is there a better way to get the height?  \r\n- Is the visibility calculation accurate enough?  missing GRID_CELL_VMARGIN may be an issue for very large dashboards\r\n\r\n\r\nSee also: #7452 #5216 #8365 #8500 #12200 #14731"},"comment":{"url":"https://api.github.com/repos/grafana/grafana/issues/comments/465729507","html_url":"https://github.com/grafana/grafana/pull/15554#issuecomment-465729507","issue_url":"https://api.github.com/repos/grafana/grafana/issues/15554","id":465729507,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NTcyOTUwNw==","user":{"login":"buroa","id":36205263,"node_id":"MDQ6VXNlcjM2MjA1MjYz","avatar_url":"https://avatars2.githubusercontent.com/u/36205263?v=4","gravatar_id":"","url":"https://api.github.com/users/buroa","html_url":"https://github.com/buroa","followers_url":"https://api.github.com/users/buroa/followers","following_url":"https://api.github.com/users/buroa/following{/other_user}","gists_url":"https://api.github.com/users/buroa/gists{/gist_id}","starred_url":"https://api.github.com/users/buroa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buroa/subscriptions","organizations_url":"https://api.github.com/users/buroa/orgs","repos_url":"https://api.github.com/users/buroa/repos","events_url":"https://api.github.com/users/buroa/events{/privacy}","received_events_url":"https://api.github.com/users/buroa/received_events","type":"User","site_admin":false},"created_at":"2019-02-20T19:53:27Z","updated_at":"2019-02-20T19:53:27Z","author_association":"CONTRIBUTOR","body":"Ok -- I see it working on my end. But with some bugs:\r\n\r\nIf I load a big dashboard (we automatically generate dashboards on the fly in my org) and scroll relatively fast, it just has a bunch of tiles (graphs) that are blank... They are supposed to be there, but it looks like they are moved further down the screen."}}
{"actor":{"display_login":"buroa"}}