{"action":"opened","number":137,"pull_request":{"url":"https://api.github.com/repos/reactphp/dns/pulls/137","id":296570828,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2NTcwODI4","html_url":"https://github.com/reactphp/dns/pull/137","diff_url":"https://github.com/reactphp/dns/pull/137.diff","patch_url":"https://github.com/reactphp/dns/pull/137.patch","issue_url":"https://api.github.com/repos/reactphp/dns/issues/137","number":137,"state":"open","locked":false,"title":"API documentation for ExecutorInterface ","user":{"login":"clue","id":776829,"node_id":"MDQ6VXNlcjc3NjgyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/776829?v=4","gravatar_id":"","url":"https://api.github.com/users/clue","html_url":"https://github.com/clue","followers_url":"https://api.github.com/users/clue/followers","following_url":"https://api.github.com/users/clue/following{/other_user}","gists_url":"https://api.github.com/users/clue/gists{/gist_id}","starred_url":"https://api.github.com/users/clue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clue/subscriptions","organizations_url":"https://api.github.com/users/clue/orgs","repos_url":"https://api.github.com/users/clue/repos","events_url":"https://api.github.com/users/clue/events{/privacy}","received_events_url":"https://api.github.com/users/clue/received_events","type":"User","site_admin":false},"body":"This changeset adds documentation for the `ExecutorInterface` and marks its cancellation logic (#28) as required. Practically, this is only a documentation addition, but theoretically this could be considered a BC break for implementations of this interface that do not currently follow this API definition. These APIs are somewhat internal and it's very unlikely this will affect any consumers of this package.\r\n\r\nThe changeset builds on top of #135, see only the last commit for changes in this PR. I will rebase this once #135 is in.\r\n\r\nBuilds on top of #135 and #136\r\nRefs #128","created_at":"2019-07-11T10:09:34Z","updated_at":"2019-07-11T10:09:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":123355387,"node_id":"MDU6TGFiZWwxMjMzNTUzODc=","url":"https://api.github.com/repos/reactphp/dns/labels/BC%20break","name":"BC break","color":"e99695","default":false},{"id":483011925,"node_id":"MDU6TGFiZWw0ODMwMTE5MjU=","url":"https://api.github.com/repos/reactphp/dns/labels/maintenance","name":"maintenance","color":"bfd4f2","default":false}],"milestone":{"url":"https://api.github.com/repos/reactphp/dns/milestones/18","html_url":"https://github.com/reactphp/dns/milestone/18","labels_url":"https://api.github.com/repos/reactphp/dns/milestones/18/labels","id":4470661,"node_id":"MDk6TWlsZXN0b25lNDQ3MDY2MQ==","number":18,"title":"v1.0.0","description":null,"creator":{"login":"clue","id":776829,"node_id":"MDQ6VXNlcjc3NjgyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/776829?v=4","gravatar_id":"","url":"https://api.github.com/users/clue","html_url":"https://github.com/clue","followers_url":"https://api.github.com/users/clue/followers","following_url":"https://api.github.com/users/clue/following{/other_user}","gists_url":"https://api.github.com/users/clue/gists{/gist_id}","starred_url":"https://api.github.com/users/clue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clue/subscriptions","organizations_url":"https://api.github.com/users/clue/orgs","repos_url":"https://api.github.com/users/clue/repos","events_url":"https://api.github.com/users/clue/events{/privacy}","received_events_url":"https://api.github.com/users/clue/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":2,"state":"open","created_at":"2019-07-07T13:09:56Z","updated_at":"2019-07-11T10:09:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/reactphp/dns/pulls/137/commits","review_comments_url":"https://api.github.com/repos/reactphp/dns/pulls/137/comments","review_comment_url":"https://api.github.com/repos/reactphp/dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactphp/dns/issues/137/comments","statuses_url":"https://api.github.com/repos/reactphp/dns/statuses/309ab96655b434ebc0ca4f4cbd228305b218e717","head":{"label":"clue-labs:executor-docs","ref":"executor-docs","sha":"309ab96655b434ebc0ca4f4cbd228305b218e717","user":{"login":"clue-labs","id":7551069,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTEwNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/7551069?v=4","gravatar_id":"","url":"https://api.github.com/users/clue-labs","html_url":"https://github.com/clue-labs","followers_url":"https://api.github.com/users/clue-labs/followers","following_url":"https://api.github.com/users/clue-labs/following{/other_user}","gists_url":"https://api.github.com/users/clue-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/clue-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clue-labs/subscriptions","organizations_url":"https://api.github.com/users/clue-labs/orgs","repos_url":"https://api.github.com/users/clue-labs/repos","events_url":"https://api.github.com/users/clue-labs/events{/privacy}","received_events_url":"https://api.github.com/users/clue-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":20581506,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MTUwNg==","name":"dns","full_name":"clue-labs/dns","private":false,"owner":{"login":"clue-labs","id":7551069,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTEwNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/7551069?v=4","gravatar_id":"","url":"https://api.github.com/users/clue-labs","html_url":"https://github.com/clue-labs","followers_url":"https://api.github.com/users/clue-labs/followers","following_url":"https://api.github.com/users/clue-labs/following{/other_user}","gists_url":"https://api.github.com/users/clue-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/clue-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clue-labs/subscriptions","organizations_url":"https://api.github.com/users/clue-labs/orgs","repos_url":"https://api.github.com/users/clue-labs/repos","events_url":"https://api.github.com/users/clue-labs/events{/privacy}","received_events_url":"https://api.github.com/users/clue-labs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/clue-labs/dns","description":"Asynchronous DNS resolver","fork":true,"url":"https://api.github.com/repos/clue-labs/dns","forks_url":"https://api.github.com/repos/clue-labs/dns/forks","keys_url":"https://api.github.com/repos/clue-labs/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clue-labs/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clue-labs/dns/teams","hooks_url":"https://api.github.com/repos/clue-labs/dns/hooks","issue_events_url":"https://api.github.com/repos/clue-labs/dns/issues/events{/number}","events_url":"https://api.github.com/repos/clue-labs/dns/events","assignees_url":"https://api.github.com/repos/clue-labs/dns/assignees{/user}","branches_url":"https://api.github.com/repos/clue-labs/dns/branches{/branch}","tags_url":"https://api.github.com/repos/clue-labs/dns/tags","blobs_url":"https://api.github.com/repos/clue-labs/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clue-labs/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clue-labs/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/clue-labs/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clue-labs/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/clue-labs/dns/languages","stargazers_url":"https://api.github.com/repos/clue-labs/dns/stargazers","contributors_url":"https://api.github.com/repos/clue-labs/dns/contributors","subscribers_url":"https://api.github.com/repos/clue-labs/dns/subscribers","subscription_url":"https://api.github.com/repos/clue-labs/dns/subscription","commits_url":"https://api.github.com/repos/clue-labs/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/clue-labs/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/clue-labs/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/clue-labs/dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/clue-labs/dns/contents/{+path}","compare_url":"https://api.github.com/repos/clue-labs/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clue-labs/dns/merges","archive_url":"https://api.github.com/repos/clue-labs/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clue-labs/dns/downloads","issues_url":"https://api.github.com/repos/clue-labs/dns/issues{/number}","pulls_url":"https://api.github.com/repos/clue-labs/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/clue-labs/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/clue-labs/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clue-labs/dns/labels{/name}","releases_url":"https://api.github.com/repos/clue-labs/dns/releases{/id}","deployments_url":"https://api.github.com/repos/clue-labs/dns/deployments","created_at":"2014-06-06T23:57:21Z","updated_at":"2014-11-26T16:28:23Z","pushed_at":"2019-07-11T10:06:20Z","git_url":"git://github.com/clue-labs/dns.git","ssh_url":"git@github.com:clue-labs/dns.git","clone_url":"https://github.com/clue-labs/dns.git","svn_url":"https://github.com/clue-labs/dns","homepage":"","size":412,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactphp:master","ref":"master","sha":"230d64825a21f86cfcb0d99c95b5ff6585c76a07","user":{"login":"reactphp","id":1696866,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTY4NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1696866?v=4","gravatar_id":"","url":"https://api.github.com/users/reactphp","html_url":"https://github.com/reactphp","followers_url":"https://api.github.com/users/reactphp/followers","following_url":"https://api.github.com/users/reactphp/following{/other_user}","gists_url":"https://api.github.com/users/reactphp/gists{/gist_id}","starred_url":"https://api.github.com/users/reactphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactphp/subscriptions","organizations_url":"https://api.github.com/users/reactphp/orgs","repos_url":"https://api.github.com/users/reactphp/repos","events_url":"https://api.github.com/users/reactphp/events{/privacy}","received_events_url":"https://api.github.com/users/reactphp/received_events","type":"Organization","site_admin":false},"repo":{"id":5749054,"node_id":"MDEwOlJlcG9zaXRvcnk1NzQ5MDU0","name":"dns","full_name":"reactphp/dns","private":false,"owner":{"login":"reactphp","id":1696866,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTY4NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1696866?v=4","gravatar_id":"","url":"https://api.github.com/users/reactphp","html_url":"https://github.com/reactphp","followers_url":"https://api.github.com/users/reactphp/followers","following_url":"https://api.github.com/users/reactphp/following{/other_user}","gists_url":"https://api.github.com/users/reactphp/gists{/gist_id}","starred_url":"https://api.github.com/users/reactphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactphp/subscriptions","organizations_url":"https://api.github.com/users/reactphp/orgs","repos_url":"https://api.github.com/users/reactphp/repos","events_url":"https://api.github.com/users/reactphp/events{/privacy}","received_events_url":"https://api.github.com/users/reactphp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactphp/dns","description":"Async DNS resolver for ReactPHP.","fork":false,"url":"https://api.github.com/repos/reactphp/dns","forks_url":"https://api.github.com/repos/reactphp/dns/forks","keys_url":"https://api.github.com/repos/reactphp/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactphp/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactphp/dns/teams","hooks_url":"https://api.github.com/repos/reactphp/dns/hooks","issue_events_url":"https://api.github.com/repos/reactphp/dns/issues/events{/number}","events_url":"https://api.github.com/repos/reactphp/dns/events","assignees_url":"https://api.github.com/repos/reactphp/dns/assignees{/user}","branches_url":"https://api.github.com/repos/reactphp/dns/branches{/branch}","tags_url":"https://api.github.com/repos/reactphp/dns/tags","blobs_url":"https://api.github.com/repos/reactphp/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactphp/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactphp/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactphp/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactphp/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/reactphp/dns/languages","stargazers_url":"https://api.github.com/repos/reactphp/dns/stargazers","contributors_url":"https://api.github.com/repos/reactphp/dns/contributors","subscribers_url":"https://api.github.com/repos/reactphp/dns/subscribers","subscription_url":"https://api.github.com/repos/reactphp/dns/subscription","commits_url":"https://api.github.com/repos/reactphp/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactphp/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactphp/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactphp/dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactphp/dns/contents/{+path}","compare_url":"https://api.github.com/repos/reactphp/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactphp/dns/merges","archive_url":"https://api.github.com/repos/reactphp/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactphp/dns/downloads","issues_url":"https://api.github.com/repos/reactphp/dns/issues{/number}","pulls_url":"https://api.github.com/repos/reactphp/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/reactphp/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/reactphp/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactphp/dns/labels{/name}","releases_url":"https://api.github.com/repos/reactphp/dns/releases{/id}","deployments_url":"https://api.github.com/repos/reactphp/dns/deployments","created_at":"2012-09-10T12:21:27Z","updated_at":"2019-07-10T21:05:13Z","pushed_at":"2019-07-11T09:46:23Z","git_url":"git://github.com/reactphp/dns.git","ssh_url":"git@github.com:reactphp/dns.git","clone_url":"https://github.com/reactphp/dns.git","svn_url":"https://github.com/reactphp/dns","homepage":"https://reactphp.org/dns/","size":392,"stargazers_count":247,"watchers_count":247,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":45,"open_issues":10,"watchers":247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactphp/dns/pulls/137"},"html":{"href":"https://github.com/reactphp/dns/pull/137"},"issue":{"href":"https://api.github.com/repos/reactphp/dns/issues/137"},"comments":{"href":"https://api.github.com/repos/reactphp/dns/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/reactphp/dns/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/reactphp/dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactphp/dns/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/reactphp/dns/statuses/309ab96655b434ebc0ca4f4cbd228305b218e717"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":270,"deletions":225,"changed_files":21}}
{"actor":{"display_login":"clue"}}