{"action":"created","issue":{"url":"https://api.github.com/repos/FRRouting/frr/issues/5224","repository_url":"https://api.github.com/repos/FRRouting/frr","labels_url":"https://api.github.com/repos/FRRouting/frr/issues/5224/labels{/name}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/5224/comments","events_url":"https://api.github.com/repos/FRRouting/frr/issues/5224/events","html_url":"https://github.com/FRRouting/frr/pull/5224","id":512404407,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyNDIwNjA2","number":5224,"title":"Fixes and extensions to frr_reload.py","user":{"login":"manuhalo","id":1090076,"node_id":"MDQ6VXNlcjEwOTAwNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1090076?v=4","gravatar_id":"","url":"https://api.github.com/users/manuhalo","html_url":"https://github.com/manuhalo","followers_url":"https://api.github.com/users/manuhalo/followers","following_url":"https://api.github.com/users/manuhalo/following{/other_user}","gists_url":"https://api.github.com/users/manuhalo/gists{/gist_id}","starred_url":"https://api.github.com/users/manuhalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuhalo/subscriptions","organizations_url":"https://api.github.com/users/manuhalo/orgs","repos_url":"https://api.github.com/users/manuhalo/repos","events_url":"https://api.github.com/users/manuhalo/events{/privacy}","received_events_url":"https://api.github.com/users/manuhalo/received_events","type":"User","site_admin":false},"labels":[{"id":1243680197,"node_id":"MDU6TGFiZWwxMjQzNjgwMTk3","url":"https://api.github.com/repos/FRRouting/frr/labels/libfrr","name":"libfrr","color":"06a521","default":false},{"id":1290611954,"node_id":"MDU6TGFiZWwxMjkwNjExOTU0","url":"https://api.github.com/repos/FRRouting/frr/labels/tools","name":"tools","color":"6ed883","default":false},{"id":1216322134,"node_id":"MDU6TGFiZWwxMjE2MzIyMTM0","url":"https://api.github.com/repos/FRRouting/frr/labels/vtysh","name":"vtysh","color":"dab5f4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2019-10-25T09:23:45Z","updated_at":"2019-11-12T17:20:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/5224","html_url":"https://github.com/FRRouting/frr/pull/5224","diff_url":"https://github.com/FRRouting/frr/pull/5224.diff","patch_url":"https://github.com/FRRouting/frr/pull/5224.patch"},"body":"This PR addresses a couple of issues with frr_reload.py:\r\n\r\n- It removes some hardcoded paths in the script, which are now configurable through command line parameters. Defaults use the previously harcoded values so that the script behaves in the same way if the new parameters are not provided.\r\n- It adds a `--daemon` option which computes the diff for a single daemon only. This is useful when integrated config is not enabled. Once again, if the option is not provided the current behavior is preserved.\r\n- It adds some fixes for ldpd, whose diffs were not correctly computed in many cases.\r\n\r\nThis PR is not:\r\n- An attempt to automatically enforce the configured paths from `configure.ac` in `frr_reload`. This would be nice but I am no autoconf expert.\r\n- An attempt to port watchfrr / `service frr reload` to non-integrated config. If called manually with the right parameters frr_reload.py should do the right thing, but I have not touched watchfrr at all. I'm happy to leave this extra work to the interested (and experienced) reader :)\r\n"},"comment":{"url":"https://api.github.com/repos/FRRouting/frr/issues/comments/552995882","html_url":"https://github.com/FRRouting/frr/pull/5224#issuecomment-552995882","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/5224","id":552995882,"node_id":"MDEyOklzc3VlQ29tbWVudDU1Mjk5NTg4Mg==","user":{"login":"NetDEF-CI","id":19297776,"node_id":"MDQ6VXNlcjE5Mjk3Nzc2","avatar_url":"https://avatars3.githubusercontent.com/u/19297776?v=4","gravatar_id":"","url":"https://api.github.com/users/NetDEF-CI","html_url":"https://github.com/NetDEF-CI","followers_url":"https://api.github.com/users/NetDEF-CI/followers","following_url":"https://api.github.com/users/NetDEF-CI/following{/other_user}","gists_url":"https://api.github.com/users/NetDEF-CI/gists{/gist_id}","starred_url":"https://api.github.com/users/NetDEF-CI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetDEF-CI/subscriptions","organizations_url":"https://api.github.com/users/NetDEF-CI/orgs","repos_url":"https://api.github.com/users/NetDEF-CI/repos","events_url":"https://api.github.com/users/NetDEF-CI/events{/privacy}","received_events_url":"https://api.github.com/users/NetDEF-CI/received_events","type":"User","site_admin":false},"created_at":"2019-11-12T17:20:27Z","updated_at":"2019-11-12T17:20:27Z","author_association":"COLLABORATOR","body":"# Continuous Integration Result: SUCCESSFUL\n\nCongratulations, this patch passed basic tests\n\nTested-by: NetDEF / OpenSourceRouting.org CI System\n\nCI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9672/\n\nThis is a comment from an automated CI system.\nFor questions and feedback in regards to this CI system, please feel free to email\nMartin Winter - mwinter (at) opensourcerouting.org.\n\n\n-----------------------------\n### CLANG Static Analyzer Summary\n- Github Pull Request 5224, comparing to Git base SHA f7f051f\n- Base image data for Git f7f051f does not exist - compare skipped\n#### 1 Static Analyzer issues remaining.\nSee details at\nhttps://ci1.netdef.org/browse/FRR-FRRPULLREQ-9672/artifact/shared/static_analysis/index.html\n"}}
{"actor":{"display_login":"NetDEF-CI"}}