{"action":"closed","number":3621,"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa/pulls/3621","id":351374989,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxMzc0OTg5","html_url":"https://github.com/mozilla/fxa/pull/3621","diff_url":"https://github.com/mozilla/fxa/pull/3621.diff","patch_url":"https://github.com/mozilla/fxa/pull/3621.patch","issue_url":"https://api.github.com/repos/mozilla/fxa/issues/3621","number":3621,"state":"closed","locked":false,"title":"fix(metrics): Ensure metrics are flushed before redirecting to external links","user":{"login":"shane-tomlinson","id":848085,"node_id":"MDQ6VXNlcjg0ODA4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/848085?v=4","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"body":"Metrics were not always flushed before redirecting to external sites,\r\ne.g., the product page on /*_confirmed and even sometimes when\r\nredirecting back to an OAuth RP.\r\n\r\nThis ensures metrics are always flushed before setting the\r\nhref.\r\n\r\nfixes #3619\r\n\r\n@mozilla/fxa-devs - r?","created_at":"2019-12-10T12:53:19Z","updated_at":"2019-12-10T15:03:19Z","closed_at":"2019-12-10T15:03:19Z","merged_at":"2019-12-10T15:03:18Z","merge_commit_sha":"6f1cbaa617e71cc2fcf03895f485f5bfb01dd53b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/mozilla/fxa/milestones/125","html_url":"https://github.com/mozilla/fxa/milestone/125","labels_url":"https://api.github.com/repos/mozilla/fxa/milestones/125/labels","id":4877557,"node_id":"MDk6TWlsZXN0b25lNDg3NzU1Nw==","number":125,"title":"Train 153: FxA","description":"","creator":{"login":"clouserw","id":80098,"node_id":"MDQ6VXNlcjgwMDk4","avatar_url":"https://avatars3.githubusercontent.com/u/80098?v=4","gravatar_id":"","url":"https://api.github.com/users/clouserw","html_url":"https://github.com/clouserw","followers_url":"https://api.github.com/users/clouserw/followers","following_url":"https://api.github.com/users/clouserw/following{/other_user}","gists_url":"https://api.github.com/users/clouserw/gists{/gist_id}","starred_url":"https://api.github.com/users/clouserw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clouserw/subscriptions","organizations_url":"https://api.github.com/users/clouserw/orgs","repos_url":"https://api.github.com/users/clouserw/repos","events_url":"https://api.github.com/users/clouserw/events{/privacy}","received_events_url":"https://api.github.com/users/clouserw/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":4,"state":"open","created_at":"2019-11-25T17:18:48Z","updated_at":"2019-12-10T15:03:19Z","due_on":"2019-12-20T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mozilla/fxa/pulls/3621/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa/pulls/3621/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa/issues/3621/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa/statuses/14543fdcd73d300946b7155c275391072d96e247","head":{"label":"mozilla:i3619-flush-metrics-external-links","ref":"i3619-flush-metrics-external-links","sha":"14543fdcd73d300946b7155c275391072d96e247","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":36831081,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgzMTA4MQ==","name":"fxa","full_name":"mozilla/fxa","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/fxa","description":"Monorepo for Firefox Accounts","fork":false,"url":"https://api.github.com/repos/mozilla/fxa","forks_url":"https://api.github.com/repos/mozilla/fxa/forks","keys_url":"https://api.github.com/repos/mozilla/fxa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa/events","assignees_url":"https://api.github.com/repos/mozilla/fxa/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa/merges","archive_url":"https://api.github.com/repos/mozilla/fxa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa/deployments","created_at":"2015-06-03T21:16:46Z","updated_at":"2019-12-10T11:00:33Z","pushed_at":"2019-12-10T15:03:20Z","git_url":"git://github.com/mozilla/fxa.git","ssh_url":"git@github.com:mozilla/fxa.git","clone_url":"https://github.com/mozilla/fxa.git","svn_url":"https://github.com/mozilla/fxa","homepage":"https://mozilla.github.io/application-services/docs/accounts/welcome.html","size":120593,"stargazers_count":131,"watchers_count":131,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":78,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":856,"license":null,"forks":78,"open_issues":856,"watchers":131,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"971b3e5b65ecfab0ce86ec7f58f744052b2cb355","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":36831081,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgzMTA4MQ==","name":"fxa","full_name":"mozilla/fxa","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/fxa","description":"Monorepo for Firefox Accounts","fork":false,"url":"https://api.github.com/repos/mozilla/fxa","forks_url":"https://api.github.com/repos/mozilla/fxa/forks","keys_url":"https://api.github.com/repos/mozilla/fxa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa/events","assignees_url":"https://api.github.com/repos/mozilla/fxa/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa/merges","archive_url":"https://api.github.com/repos/mozilla/fxa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa/deployments","created_at":"2015-06-03T21:16:46Z","updated_at":"2019-12-10T11:00:33Z","pushed_at":"2019-12-10T15:03:20Z","git_url":"git://github.com/mozilla/fxa.git","ssh_url":"git@github.com:mozilla/fxa.git","clone_url":"https://github.com/mozilla/fxa.git","svn_url":"https://github.com/mozilla/fxa","homepage":"https://mozilla.github.io/application-services/docs/accounts/welcome.html","size":120593,"stargazers_count":131,"watchers_count":131,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":78,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":856,"license":null,"forks":78,"open_issues":856,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa/pulls/3621"},"html":{"href":"https://github.com/mozilla/fxa/pull/3621"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa/issues/3621"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa/issues/3621/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa/pulls/3621/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa/pulls/3621/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa/statuses/14543fdcd73d300946b7155c275391072d96e247"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"shane-tomlinson","id":848085,"node_id":"MDQ6VXNlcjg0ODA4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/848085?v=4","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":105,"deletions":157,"changed_files":8}}
{"actor":{"display_login":"shane-tomlinson"}}