{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/hubs/pulls/comments/260421234","pull_request_review_id":208116745,"id":260421234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDQyMTIzNA==","diff_hunk":"@@ -0,0 +1,90 @@\n+import React, { Component } from \"react\";\n+import PropTypes from \"prop-types\";\n+import styles from \"../assets/stylesheets/change-scene-dialog.scss\";\n+import cx from \"classnames\";\n+import DialogContainer from \"./dialog-container.js\";\n+import { handleTextFieldFocus, handleTextFieldBlur } from \"../utils/focus-utils\";\n+import { WithHoverSound } from \"./wrap-with-audio\";\n+\n+export default class ChangeSceneDialog extends Component {\n+  state = {\n+    url: \"\"\n+  };\n+\n+  static propTypes = {\n+    onChange: PropTypes.func,\n+    onClose: PropTypes.func\n+  };\n+\n+  onUrlChange = e => {\n+    this.setState({\n+      url: e.target && e.target.value\n+    });\n+  };\n+\n+  reset = e => {\n+    e.preventDefault();\n+    this.setState({ url: \"\" });\n+  };\n+\n+  onChangeClicked = e => {\n+    e.preventDefault();\n+\n+    if (this.state.url) {\n+      this.props.onChange(this.state.url);\n+    }\n+\n+    this.props.onClose();\n+  };\n+\n+  render() {\n+    const { onChange, onClose, ...other } = this.props; // eslint-disable-line no-unused-vars","path":"src/react-components/change-scene-dialog.js","position":41,"original_position":41,"commit_id":"f92c32c427b6f4293801eb3fe3fa746943d41b55","original_commit_id":"f92c32c427b6f4293801eb3fe3fa746943d41b55","user":{"login":"brianpeiris","id":79419,"node_id":"MDQ6VXNlcjc5NDE5","avatar_url":"https://avatars3.githubusercontent.com/u/79419?v=4","gravatar_id":"","url":"https://api.github.com/users/brianpeiris","html_url":"https://github.com/brianpeiris","followers_url":"https://api.github.com/users/brianpeiris/followers","following_url":"https://api.github.com/users/brianpeiris/following{/other_user}","gists_url":"https://api.github.com/users/brianpeiris/gists{/gist_id}","starred_url":"https://api.github.com/users/brianpeiris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianpeiris/subscriptions","organizations_url":"https://api.github.com/users/brianpeiris/orgs","repos_url":"https://api.github.com/users/brianpeiris/repos","events_url":"https://api.github.com/users/brianpeiris/events{/privacy}","received_events_url":"https://api.github.com/users/brianpeiris/received_events","type":"User","site_admin":false},"body":"I dunno how I feel about this catch-all props pattern. I'd rather be explicit where we can, as is the case with this dialog. For one thing, we probably shouldn't encourage use of `eslint-disable-line`.","created_at":"2019-02-26T18:19:52Z","updated_at":"2019-02-26T18:43:19Z","html_url":"https://github.com/mozilla/hubs/pull/951#discussion_r260421234","pull_request_url":"https://api.github.com/repos/mozilla/hubs/pulls/951","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/comments/260421234"},"html":{"href":"https://github.com/mozilla/hubs/pull/951#discussion_r260421234"},"pull_request":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/951"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/hubs/pulls/951","id":256163621,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2MTYzNjIx","html_url":"https://github.com/mozilla/hubs/pull/951","diff_url":"https://github.com/mozilla/hubs/pull/951.diff","patch_url":"https://github.com/mozilla/hubs/pull/951.patch","issue_url":"https://api.github.com/repos/mozilla/hubs/issues/951","number":951,"state":"open","locked":false,"title":"Add scene change dialog","user":{"login":"gfodor","id":220020,"node_id":"MDQ6VXNlcjIyMDAyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/220020?v=4","gravatar_id":"","url":"https://api.github.com/users/gfodor","html_url":"https://github.com/gfodor","followers_url":"https://api.github.com/users/gfodor/followers","following_url":"https://api.github.com/users/gfodor/following{/other_user}","gists_url":"https://api.github.com/users/gfodor/gists{/gist_id}","starred_url":"https://api.github.com/users/gfodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfodor/subscriptions","organizations_url":"https://api.github.com/users/gfodor/orgs","repos_url":"https://api.github.com/users/gfodor/repos","events_url":"https://api.github.com/users/gfodor/events{/privacy}","received_events_url":"https://api.github.com/users/gfodor/received_events","type":"User","site_admin":false},"body":"Adds a dialog to set to a custom scene from the scene picker.\r\n\r\n![image](https://user-images.githubusercontent.com/220020/53393172-7c794500-3950-11e9-9f10-bb7c46f308ad.png)\r\n","created_at":"2019-02-26T06:55:48Z","updated_at":"2019-02-26T18:43:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c81040f24f0d322de33017c4586dd3ac921886d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/hubs/pulls/951/commits","review_comments_url":"https://api.github.com/repos/mozilla/hubs/pulls/951/comments","review_comment_url":"https://api.github.com/repos/mozilla/hubs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/hubs/issues/951/comments","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/f92c32c427b6f4293801eb3fe3fa746943d41b55","head":{"label":"mozilla:feature/scene-change-dialog","ref":"feature/scene-change-dialog","sha":"f92c32c427b6f4293801eb3fe3fa746943d41b55","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":104933644,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MzM2NDQ=","name":"hubs","full_name":"mozilla/hubs","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/hubs","description":"Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.","fork":false,"url":"https://api.github.com/repos/mozilla/hubs","forks_url":"https://api.github.com/repos/mozilla/hubs/forks","keys_url":"https://api.github.com/repos/mozilla/hubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/hubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/hubs/teams","hooks_url":"https://api.github.com/repos/mozilla/hubs/hooks","issue_events_url":"https://api.github.com/repos/mozilla/hubs/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/hubs/events","assignees_url":"https://api.github.com/repos/mozilla/hubs/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/hubs/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/hubs/tags","blobs_url":"https://api.github.com/repos/mozilla/hubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/hubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/hubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/hubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/hubs/languages","stargazers_url":"https://api.github.com/repos/mozilla/hubs/stargazers","contributors_url":"https://api.github.com/repos/mozilla/hubs/contributors","subscribers_url":"https://api.github.com/repos/mozilla/hubs/subscribers","subscription_url":"https://api.github.com/repos/mozilla/hubs/subscription","commits_url":"https://api.github.com/repos/mozilla/hubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/hubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/hubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/hubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/hubs/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/hubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/hubs/merges","archive_url":"https://api.github.com/repos/mozilla/hubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/hubs/downloads","issues_url":"https://api.github.com/repos/mozilla/hubs/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/hubs/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/hubs/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/hubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/hubs/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/hubs/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/hubs/deployments","created_at":"2017-09-26T20:20:12Z","updated_at":"2019-02-26T04:48:14Z","pushed_at":"2019-02-26T18:42:47Z","git_url":"git://github.com/mozilla/hubs.git","ssh_url":"git@github.com:mozilla/hubs.git","clone_url":"https://github.com/mozilla/hubs.git","svn_url":"https://github.com/mozilla/hubs","homepage":"https://hubs.mozilla.com","size":105421,"stargazers_count":195,"watchers_count":195,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":49,"open_issues":128,"watchers":195,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"cb724d9f9df8e0bf3896511291c1cfe690282024","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":104933644,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MzM2NDQ=","name":"hubs","full_name":"mozilla/hubs","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/hubs","description":"Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.","fork":false,"url":"https://api.github.com/repos/mozilla/hubs","forks_url":"https://api.github.com/repos/mozilla/hubs/forks","keys_url":"https://api.github.com/repos/mozilla/hubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/hubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/hubs/teams","hooks_url":"https://api.github.com/repos/mozilla/hubs/hooks","issue_events_url":"https://api.github.com/repos/mozilla/hubs/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/hubs/events","assignees_url":"https://api.github.com/repos/mozilla/hubs/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/hubs/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/hubs/tags","blobs_url":"https://api.github.com/repos/mozilla/hubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/hubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/hubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/hubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/hubs/languages","stargazers_url":"https://api.github.com/repos/mozilla/hubs/stargazers","contributors_url":"https://api.github.com/repos/mozilla/hubs/contributors","subscribers_url":"https://api.github.com/repos/mozilla/hubs/subscribers","subscription_url":"https://api.github.com/repos/mozilla/hubs/subscription","commits_url":"https://api.github.com/repos/mozilla/hubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/hubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/hubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/hubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/hubs/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/hubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/hubs/merges","archive_url":"https://api.github.com/repos/mozilla/hubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/hubs/downloads","issues_url":"https://api.github.com/repos/mozilla/hubs/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/hubs/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/hubs/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/hubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/hubs/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/hubs/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/hubs/deployments","created_at":"2017-09-26T20:20:12Z","updated_at":"2019-02-26T04:48:14Z","pushed_at":"2019-02-26T18:42:47Z","git_url":"git://github.com/mozilla/hubs.git","ssh_url":"git@github.com:mozilla/hubs.git","clone_url":"https://github.com/mozilla/hubs.git","svn_url":"https://github.com/mozilla/hubs","homepage":"https://hubs.mozilla.com","size":105421,"stargazers_count":195,"watchers_count":195,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":49,"open_issues":128,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/951"},"html":{"href":"https://github.com/mozilla/hubs/pull/951"},"issue":{"href":"https://api.github.com/repos/mozilla/hubs/issues/951"},"comments":{"href":"https://api.github.com/repos/mozilla/hubs/issues/951/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/951/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/951/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/hubs/statuses/f92c32c427b6f4293801eb3fe3fa746943d41b55"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"brianpeiris"}}