{"action":"created","comment":{"url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/comments/354075963","pull_request_review_id":327266819,"id":354075963,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDA3NTk2Mw==","diff_hunk":"@@ -659,4 +683,46 @@ public static void cleanUp() {\n \n \t}\n \n+\t@Test\n+\tpublic void testGetVisibleColumnMapWithMGID() {\n+\t\tMap<String, Boolean> visibleColumnsMap;\n+\t\tint visibleColumnCount;\n+\t\tGermplasmListExporterTest.listDataTable = GermplasmListExporterTest.generateTestTable(new ArrayList<>(Arrays.asList(ColumnLabels.MGID.getName())));\n+\n+\t\tvisibleColumnsMap = this.germplasmListExporter.getVisibleColumnMap(GermplasmListExporterTest.listDataTable);\n+\t\tvisibleColumnCount = this.getNoOfVisibleColumns(visibleColumnsMap);\n+\t\tAssert.assertEquals(10, visibleColumnCount);\n+\t\tAssert.assertTrue(\"Expected to have exactly 10 visible columns.\", visibleColumnCount == 10);\n+\n+\t\tGermplasmListExporterTest.listDataTable = GermplasmListExporterTest.generateTestTable();","path":"src/test/java/org/generationcp/breeding/manager/listmanager/util/GermplasmListExporterTest.java","position":46,"original_position":46,"commit_id":"5b54ebef8534d17a933359bf2f322c4c26b3a327","original_commit_id":"5b54ebef8534d17a933359bf2f322c4c26b3a327","user":{"login":"darla-leafnode","id":15937514,"node_id":"MDQ6VXNlcjE1OTM3NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/15937514?v=4","gravatar_id":"","url":"https://api.github.com/users/darla-leafnode","html_url":"https://github.com/darla-leafnode","followers_url":"https://api.github.com/users/darla-leafnode/followers","following_url":"https://api.github.com/users/darla-leafnode/following{/other_user}","gists_url":"https://api.github.com/users/darla-leafnode/gists{/gist_id}","starred_url":"https://api.github.com/users/darla-leafnode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darla-leafnode/subscriptions","organizations_url":"https://api.github.com/users/darla-leafnode/orgs","repos_url":"https://api.github.com/users/darla-leafnode/repos","events_url":"https://api.github.com/users/darla-leafnode/events{/privacy}","received_events_url":"https://api.github.com/users/darla-leafnode/received_events","type":"User","site_admin":false},"body":"Do we need this line in the test:\r\n> GermplasmListExporterTest.listDataTable = GermplasmListExporterTest.generateTestTable();","created_at":"2019-12-05T01:51:32Z","updated_at":"2019-12-05T01:51:32Z","html_url":"https://github.com/IntegratedBreedingPlatform/BreedingManager/pull/321#discussion_r354075963","pull_request_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/321","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/comments/354075963"},"html":{"href":"https://github.com/IntegratedBreedingPlatform/BreedingManager/pull/321#discussion_r354075963"},"pull_request":{"href":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/321","id":342966340,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyOTY2MzQw","html_url":"https://github.com/IntegratedBreedingPlatform/BreedingManager/pull/321","diff_url":"https://github.com/IntegratedBreedingPlatform/BreedingManager/pull/321.diff","patch_url":"https://github.com/IntegratedBreedingPlatform/BreedingManager/pull/321.patch","issue_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/issues/321","number":321,"state":"open","locked":false,"title":"IBP-2796 Set Cross Details of Derivative Germplasm","user":{"login":"gelli-leafnode","id":55473223,"node_id":"MDQ6VXNlcjU1NDczMjIz","avatar_url":"https://avatars0.githubusercontent.com/u/55473223?v=4","gravatar_id":"","url":"https://api.github.com/users/gelli-leafnode","html_url":"https://github.com/gelli-leafnode","followers_url":"https://api.github.com/users/gelli-leafnode/followers","following_url":"https://api.github.com/users/gelli-leafnode/following{/other_user}","gists_url":"https://api.github.com/users/gelli-leafnode/gists{/gist_id}","starred_url":"https://api.github.com/users/gelli-leafnode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelli-leafnode/subscriptions","organizations_url":"https://api.github.com/users/gelli-leafnode/orgs","repos_url":"https://api.github.com/users/gelli-leafnode/repos","events_url":"https://api.github.com/users/gelli-leafnode/events{/privacy}","received_events_url":"https://api.github.com/users/gelli-leafnode/received_events","type":"User","site_admin":false},"body":"Added Derivative Germplasm in condition to fill Column Information of Female GID, Female Name, Male GID and Male Name","created_at":"2019-11-20T01:10:02Z","updated_at":"2019-12-05T01:51:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f9078d73bff69efb8c3a8f42b5bded52331d482","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/321/commits","review_comments_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/321/comments","review_comment_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/issues/321/comments","statuses_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/statuses/5b54ebef8534d17a933359bf2f322c4c26b3a327","head":{"label":"IntegratedBreedingPlatform:IBP-2796-SetCrossDetailsDerivativeGermplasm","ref":"IBP-2796-SetCrossDetailsDerivativeGermplasm","sha":"5b54ebef8534d17a933359bf2f322c4c26b3a327","user":{"login":"IntegratedBreedingPlatform","id":11062385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDYyMzg1","avatar_url":"https://avatars0.githubusercontent.com/u/11062385?v=4","gravatar_id":"","url":"https://api.github.com/users/IntegratedBreedingPlatform","html_url":"https://github.com/IntegratedBreedingPlatform","followers_url":"https://api.github.com/users/IntegratedBreedingPlatform/followers","following_url":"https://api.github.com/users/IntegratedBreedingPlatform/following{/other_user}","gists_url":"https://api.github.com/users/IntegratedBreedingPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/IntegratedBreedingPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntegratedBreedingPlatform/subscriptions","organizations_url":"https://api.github.com/users/IntegratedBreedingPlatform/orgs","repos_url":"https://api.github.com/users/IntegratedBreedingPlatform/repos","events_url":"https://api.github.com/users/IntegratedBreedingPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/IntegratedBreedingPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":12487941,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ4Nzk0MQ==","name":"BreedingManager","full_name":"IntegratedBreedingPlatform/BreedingManager","private":false,"owner":{"login":"IntegratedBreedingPlatform","id":11062385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDYyMzg1","avatar_url":"https://avatars0.githubusercontent.com/u/11062385?v=4","gravatar_id":"","url":"https://api.github.com/users/IntegratedBreedingPlatform","html_url":"https://github.com/IntegratedBreedingPlatform","followers_url":"https://api.github.com/users/IntegratedBreedingPlatform/followers","following_url":"https://api.github.com/users/IntegratedBreedingPlatform/following{/other_user}","gists_url":"https://api.github.com/users/IntegratedBreedingPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/IntegratedBreedingPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntegratedBreedingPlatform/subscriptions","organizations_url":"https://api.github.com/users/IntegratedBreedingPlatform/orgs","repos_url":"https://api.github.com/users/IntegratedBreedingPlatform/repos","events_url":"https://api.github.com/users/IntegratedBreedingPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/IntegratedBreedingPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IntegratedBreedingPlatform/BreedingManager","description":null,"fork":false,"url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager","forks_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/forks","keys_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/teams","hooks_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/hooks","issue_events_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/issues/events{/number}","events_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/events","assignees_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/assignees{/user}","branches_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/branches{/branch}","tags_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/tags","blobs_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/statuses/{sha}","languages_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/languages","stargazers_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/stargazers","contributors_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/contributors","subscribers_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/subscribers","subscription_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/subscription","commits_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/contents/{+path}","compare_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/merges","archive_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/downloads","issues_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/issues{/number}","pulls_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls{/number}","milestones_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/milestones{/number}","notifications_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/labels{/name}","releases_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/releases{/id}","deployments_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/deployments","created_at":"2013-08-30T14:10:57Z","updated_at":"2019-11-20T01:58:04Z","pushed_at":"2019-12-02T14:30:14Z","git_url":"git://github.com/IntegratedBreedingPlatform/BreedingManager.git","ssh_url":"git@github.com:IntegratedBreedingPlatform/BreedingManager.git","clone_url":"https://github.com/IntegratedBreedingPlatform/BreedingManager.git","svn_url":"https://github.com/IntegratedBreedingPlatform/BreedingManager","homepage":null,"size":30126,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"IntegratedBreedingPlatform:master","ref":"master","sha":"5dfc710997ccfed550b55aa6a0fba45af42b2a09","user":{"login":"IntegratedBreedingPlatform","id":11062385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDYyMzg1","avatar_url":"https://avatars0.githubusercontent.com/u/11062385?v=4","gravatar_id":"","url":"https://api.github.com/users/IntegratedBreedingPlatform","html_url":"https://github.com/IntegratedBreedingPlatform","followers_url":"https://api.github.com/users/IntegratedBreedingPlatform/followers","following_url":"https://api.github.com/users/IntegratedBreedingPlatform/following{/other_user}","gists_url":"https://api.github.com/users/IntegratedBreedingPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/IntegratedBreedingPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntegratedBreedingPlatform/subscriptions","organizations_url":"https://api.github.com/users/IntegratedBreedingPlatform/orgs","repos_url":"https://api.github.com/users/IntegratedBreedingPlatform/repos","events_url":"https://api.github.com/users/IntegratedBreedingPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/IntegratedBreedingPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":12487941,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ4Nzk0MQ==","name":"BreedingManager","full_name":"IntegratedBreedingPlatform/BreedingManager","private":false,"owner":{"login":"IntegratedBreedingPlatform","id":11062385,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDYyMzg1","avatar_url":"https://avatars0.githubusercontent.com/u/11062385?v=4","gravatar_id":"","url":"https://api.github.com/users/IntegratedBreedingPlatform","html_url":"https://github.com/IntegratedBreedingPlatform","followers_url":"https://api.github.com/users/IntegratedBreedingPlatform/followers","following_url":"https://api.github.com/users/IntegratedBreedingPlatform/following{/other_user}","gists_url":"https://api.github.com/users/IntegratedBreedingPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/IntegratedBreedingPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntegratedBreedingPlatform/subscriptions","organizations_url":"https://api.github.com/users/IntegratedBreedingPlatform/orgs","repos_url":"https://api.github.com/users/IntegratedBreedingPlatform/repos","events_url":"https://api.github.com/users/IntegratedBreedingPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/IntegratedBreedingPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IntegratedBreedingPlatform/BreedingManager","description":null,"fork":false,"url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager","forks_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/forks","keys_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/teams","hooks_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/hooks","issue_events_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/issues/events{/number}","events_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/events","assignees_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/assignees{/user}","branches_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/branches{/branch}","tags_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/tags","blobs_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/statuses/{sha}","languages_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/languages","stargazers_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/stargazers","contributors_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/contributors","subscribers_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/subscribers","subscription_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/subscription","commits_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/contents/{+path}","compare_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/merges","archive_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/downloads","issues_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/issues{/number}","pulls_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls{/number}","milestones_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/milestones{/number}","notifications_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/labels{/name}","releases_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/releases{/id}","deployments_url":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/deployments","created_at":"2013-08-30T14:10:57Z","updated_at":"2019-11-20T01:58:04Z","pushed_at":"2019-12-02T14:30:14Z","git_url":"git://github.com/IntegratedBreedingPlatform/BreedingManager.git","ssh_url":"git@github.com:IntegratedBreedingPlatform/BreedingManager.git","clone_url":"https://github.com/IntegratedBreedingPlatform/BreedingManager.git","svn_url":"https://github.com/IntegratedBreedingPlatform/BreedingManager","homepage":null,"size":30126,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/321"},"html":{"href":"https://github.com/IntegratedBreedingPlatform/BreedingManager/pull/321"},"issue":{"href":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/issues/321"},"comments":{"href":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/IntegratedBreedingPlatform/BreedingManager/statuses/5b54ebef8534d17a933359bf2f322c4c26b3a327"}},"author_association":"NONE"}}
{"actor":{"display_login":"darla-leafnode"}}