{"action":"created","issue":{"url":"https://api.github.com/repos/DataBiosphere/azul/issues/1067","repository_url":"https://api.github.com/repos/DataBiosphere/azul","labels_url":"https://api.github.com/repos/DataBiosphere/azul/issues/1067/labels{/name}","comments_url":"https://api.github.com/repos/DataBiosphere/azul/issues/1067/comments","events_url":"https://api.github.com/repos/DataBiosphere/azul/issues/1067/events","html_url":"https://github.com/DataBiosphere/azul/pull/1067","id":453290622,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2MDEyMTAx","number":1067,"title":"Isolate test fixtures for service tests (#1064)","user":{"login":"jessebrennan","id":10734740,"node_id":"MDQ6VXNlcjEwNzM0NzQw","avatar_url":"https://avatars1.githubusercontent.com/u/10734740?v=4","gravatar_id":"","url":"https://api.github.com/users/jessebrennan","html_url":"https://github.com/jessebrennan","followers_url":"https://api.github.com/users/jessebrennan/followers","following_url":"https://api.github.com/users/jessebrennan/following{/other_user}","gists_url":"https://api.github.com/users/jessebrennan/gists{/gist_id}","starred_url":"https://api.github.com/users/jessebrennan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessebrennan/subscriptions","organizations_url":"https://api.github.com/users/jessebrennan/orgs","repos_url":"https://api.github.com/users/jessebrennan/repos","events_url":"https://api.github.com/users/jessebrennan/events{/privacy}","received_events_url":"https://api.github.com/users/jessebrennan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-06-07T00:17:46Z","updated_at":"2019-06-07T18:39:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DataBiosphere/azul/pulls/1067","html_url":"https://github.com/DataBiosphere/azul/pull/1067","diff_url":"https://github.com/DataBiosphere/azul/pull/1067.diff","patch_url":"https://github.com/DataBiosphere/azul/pull/1067.patch"},"body":"Now test classes that inherit from WebServiceTestCase all need to\r\nexplicitly provision the documents that they need to be indexed, instead\r\nof just always indexing a document in WebServiceTestCase.\r\n\r\nAlso TestManifestContent class was created which now contains all of\r\nthe tests for the Manifest's content. Some of these tests were\r\npreviously located in test_request_validation. Moving them to their own\r\nclass is what ultimately fixes #1064 since they are now correctly\r\nprovisioning and de-provisioning the fixtures between tests."},"comment":{"url":"https://api.github.com/repos/DataBiosphere/azul/issues/comments/499994956","html_url":"https://github.com/DataBiosphere/azul/pull/1067#issuecomment-499994956","issue_url":"https://api.github.com/repos/DataBiosphere/azul/issues/1067","id":499994956,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5OTk5NDk1Ng==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2019-06-07T18:39:27Z","updated_at":"2019-06-07T18:39:27Z","author_association":"NONE","body":"## Pull Request Test Coverage Report for [Build 4340](https://coveralls.io/builds/23866321)\n\n* **182** of **183**   **(99.45%)**  changed or added relevant lines in **10** files are covered.\n* No unchanged relevant lines lost coverage.\n* Overall coverage increased (+**0.08%**) to **84.976%**\n\n---\n\n|  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |\n| :-----|--------------|--------|---: |\n| [test/service/test_manifest.py](https://coveralls.io/builds/23866321/source?filename=test%2Fservice%2Ftest_manifest.py#L33) | 155 | 156 | 99.36%\n<!-- | **Total:** | **182** | **183** | **99.45%** | -->\n\n\n|  Totals | [![Coverage Status](https://coveralls.io/builds/23866321/badge)](https://coveralls.io/builds/23866321) |\n| :-- | --: |\n| Change from base [Build 4296](https://coveralls.io/builds/23800452): |  0.08% |\n| Covered Lines: | 6810 |\n| Relevant Lines: | 8014 |\n\n---\n##### 💛  - [Coveralls](https://coveralls.io)\n"}}
{"actor":{"display_login":"coveralls"}}