{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/aria-practices/issues/1160","repository_url":"https://api.github.com/repos/w3c/aria-practices","labels_url":"https://api.github.com/repos/w3c/aria-practices/issues/1160/labels{/name}","comments_url":"https://api.github.com/repos/w3c/aria-practices/issues/1160/comments","events_url":"https://api.github.com/repos/w3c/aria-practices/issues/1160/events","html_url":"https://github.com/w3c/aria-practices/pull/1160","id":487850456,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEzMDA5MTE3","number":1160,"title":"Editor Menubar Example: add group around font style menu item checkboxes","user":{"login":"mcking65","id":7241781,"node_id":"MDQ6VXNlcjcyNDE3ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/7241781?v=4","gravatar_id":"","url":"https://api.github.com/users/mcking65","html_url":"https://github.com/mcking65","followers_url":"https://api.github.com/users/mcking65/followers","following_url":"https://api.github.com/users/mcking65/following{/other_user}","gists_url":"https://api.github.com/users/mcking65/gists{/gist_id}","starred_url":"https://api.github.com/users/mcking65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcking65/subscriptions","organizations_url":"https://api.github.com/users/mcking65/orgs","repos_url":"https://api.github.com/users/mcking65/repos","events_url":"https://api.github.com/users/mcking65/events{/privacy}","received_events_url":"https://api.github.com/users/mcking65/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-09-01T07:08:08Z","updated_at":"2019-09-29T01:33:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/w3c/aria-practices/pulls/1160","html_url":"https://github.com/w3c/aria-practices/pull/1160","diff_url":"https://github.com/w3c/aria-practices/pull/1160.diff","patch_url":"https://github.com/w3c/aria-practices/pull/1160.patch"},"body":"To resolve issue #914, adds role group around the menuitemcheckbox elements for font style.\r\nAlso updates applicable regression test for the group role.\r\nAlso adds missing role=\"none\" on `<li>` elements.\r\n\r\nUses commits from #1144 by @jnurthen, but merges to master instead of apg-1.2.\r\n\r\n#### Preview Link\r\n\r\n[View the editor menubar in the compare branch for this PR](https://raw.githack.com/w3c/aria-practices/issue914-menubar2-add-fontstyle-group/examples/menubar/menubar-2/menubar-2.html)"},"comment":{"url":"https://api.github.com/repos/w3c/aria-practices/issues/comments/536238703","html_url":"https://github.com/w3c/aria-practices/pull/1160#issuecomment-536238703","issue_url":"https://api.github.com/repos/w3c/aria-practices/issues/1160","id":536238703,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNjIzODcwMw==","user":{"login":"mcking65","id":7241781,"node_id":"MDQ6VXNlcjcyNDE3ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/7241781?v=4","gravatar_id":"","url":"https://api.github.com/users/mcking65","html_url":"https://github.com/mcking65","followers_url":"https://api.github.com/users/mcking65/followers","following_url":"https://api.github.com/users/mcking65/following{/other_user}","gists_url":"https://api.github.com/users/mcking65/gists{/gist_id}","starred_url":"https://api.github.com/users/mcking65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcking65/subscriptions","organizations_url":"https://api.github.com/users/mcking65/orgs","repos_url":"https://api.github.com/users/mcking65/repos","events_url":"https://api.github.com/users/mcking65/events{/privacy}","received_events_url":"https://api.github.com/users/mcking65/received_events","type":"User","site_admin":false},"created_at":"2019-09-29T01:33:54Z","updated_at":"2019-09-29T01:33:54Z","author_association":"CONTRIBUTOR","body":"@jongund, we are getting the following in the PR test:\r\n\r\n```\r\n313 not ok 39 - menubar_menubar-2 › menubar/menubar-2/menubar-2.html [data-test-id=\"submenu-menuitem-aria-disabled\"]: Test aria-disabled=\"false\" for all submenu role=\"menuitem\"s\r\n314   ---\r\n315     name: Error\r\n316    message: >-\r\n317      Test was expected to fail, but succeeded, you should stop marking the test as\r\n318      failing\r\n```\r\n"}}
{"actor":{"display_login":"mcking65"}}