{"action":"created","comment":{"url":"https://api.github.com/repos/telus/tds-core/pulls/comments/306965464","pull_request_review_id":266215041,"id":306965464,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjk2NTQ2NA==","diff_hunk":"@@ -109,6 +104,6 @@ describe('FlexGrid', () => {\n       limitWidth: false,\n     })\n \n-    expect(flexGrid).not.toHaveClassName('limitWidth')\n+    expect(flexGrid).toMatchSnapshot()","path":"packages/FlexGrid/__tests__/FlexGrid.spec.jsx","position":50,"original_position":50,"commit_id":"9d997691796671d63235f00109264d59a83d25f7","original_commit_id":"9d997691796671d63235f00109264d59a83d25f7","user":{"login":"agorovyi","id":26413531,"node_id":"MDQ6VXNlcjI2NDEzNTMx","avatar_url":"https://avatars3.githubusercontent.com/u/26413531?v=4","gravatar_id":"","url":"https://api.github.com/users/agorovyi","html_url":"https://github.com/agorovyi","followers_url":"https://api.github.com/users/agorovyi/followers","following_url":"https://api.github.com/users/agorovyi/following{/other_user}","gists_url":"https://api.github.com/users/agorovyi/gists{/gist_id}","starred_url":"https://api.github.com/users/agorovyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agorovyi/subscriptions","organizations_url":"https://api.github.com/users/agorovyi/orgs","repos_url":"https://api.github.com/users/agorovyi/repos","events_url":"https://api.github.com/users/agorovyi/events{/privacy}","received_events_url":"https://api.github.com/users/agorovyi/received_events","type":"User","site_admin":false},"body":"Adding too many snapshot assertions is stretching the final snapshot file which will make it complicated to read when it breaks in future. It's a good practice to keep snapshot files short.","created_at":"2019-07-24T18:46:02Z","updated_at":"2019-07-24T18:46:02Z","html_url":"https://github.com/telus/tds-core/pull/1195#discussion_r306965464","pull_request_url":"https://api.github.com/repos/telus/tds-core/pulls/1195","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/telus/tds-core/pulls/comments/306965464"},"html":{"href":"https://github.com/telus/tds-core/pull/1195#discussion_r306965464"},"pull_request":{"href":"https://api.github.com/repos/telus/tds-core/pulls/1195"}}},"pull_request":{"url":"https://api.github.com/repos/telus/tds-core/pulls/1195","id":300343143,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMzQzMTQz","html_url":"https://github.com/telus/tds-core/pull/1195","diff_url":"https://github.com/telus/tds-core/pull/1195.diff","patch_url":"https://github.com/telus/tds-core/pull/1195.patch","issue_url":"https://api.github.com/repos/telus/tds-core/issues/1195","number":1195,"state":"open","locked":false,"title":"Upgrade FlexGrid to Styled Components, Export Breakpoints From Responsive","user":{"login":"marcod1419","id":10531523,"node_id":"MDQ6VXNlcjEwNTMxNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/10531523?v=4","gravatar_id":"","url":"https://api.github.com/users/marcod1419","html_url":"https://github.com/marcod1419","followers_url":"https://api.github.com/users/marcod1419/followers","following_url":"https://api.github.com/users/marcod1419/following{/other_user}","gists_url":"https://api.github.com/users/marcod1419/gists{/gist_id}","starred_url":"https://api.github.com/users/marcod1419/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcod1419/subscriptions","organizations_url":"https://api.github.com/users/marcod1419/orgs","repos_url":"https://api.github.com/users/marcod1419/repos","events_url":"https://api.github.com/users/marcod1419/events{/privacy}","received_events_url":"https://api.github.com/users/marcod1419/received_events","type":"User","site_admin":false},"body":"This upgrades our FlexGrid override CSS to styled-components, while also upgrading the dependency FlexGrid relies on for a slightly cleaner DOM.\r\n\r\nTo facilitate FlexGrid, Responsive has been updated to export an object containing our breakpoints.\r\n\r\nLastly, I went ahead and ran `npm audit` to clear up lots of vulnerabilities.","created_at":"2019-07-23T15:07:53Z","updated_at":"2019-07-24T18:46:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"653614d1edee5b0e4d0ae2fa5e89a30498a3d222","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jraff","id":1036187,"node_id":"MDQ6VXNlcjEwMzYxODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1036187?v=4","gravatar_id":"","url":"https://api.github.com/users/jraff","html_url":"https://github.com/jraff","followers_url":"https://api.github.com/users/jraff/followers","following_url":"https://api.github.com/users/jraff/following{/other_user}","gists_url":"https://api.github.com/users/jraff/gists{/gist_id}","starred_url":"https://api.github.com/users/jraff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jraff/subscriptions","organizations_url":"https://api.github.com/users/jraff/orgs","repos_url":"https://api.github.com/users/jraff/repos","events_url":"https://api.github.com/users/jraff/events{/privacy}","received_events_url":"https://api.github.com/users/jraff/received_events","type":"User","site_admin":false},{"login":"theetrain","id":12798751,"node_id":"MDQ6VXNlcjEyNzk4NzUx","avatar_url":"https://avatars0.githubusercontent.com/u/12798751?v=4","gravatar_id":"","url":"https://api.github.com/users/theetrain","html_url":"https://github.com/theetrain","followers_url":"https://api.github.com/users/theetrain/followers","following_url":"https://api.github.com/users/theetrain/following{/other_user}","gists_url":"https://api.github.com/users/theetrain/gists{/gist_id}","starred_url":"https://api.github.com/users/theetrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theetrain/subscriptions","organizations_url":"https://api.github.com/users/theetrain/orgs","repos_url":"https://api.github.com/users/theetrain/repos","events_url":"https://api.github.com/users/theetrain/events{/privacy}","received_events_url":"https://api.github.com/users/theetrain/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/telus/tds-core/pulls/1195/commits","review_comments_url":"https://api.github.com/repos/telus/tds-core/pulls/1195/comments","review_comment_url":"https://api.github.com/repos/telus/tds-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telus/tds-core/issues/1195/comments","statuses_url":"https://api.github.com/repos/telus/tds-core/statuses/9d997691796671d63235f00109264d59a83d25f7","head":{"label":"telus:styled/flex-grid","ref":"styled/flex-grid","sha":"9d997691796671d63235f00109264d59a83d25f7","user":{"login":"telus","id":9374493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNzQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9374493?v=4","gravatar_id":"","url":"https://api.github.com/users/telus","html_url":"https://github.com/telus","followers_url":"https://api.github.com/users/telus/followers","following_url":"https://api.github.com/users/telus/following{/other_user}","gists_url":"https://api.github.com/users/telus/gists{/gist_id}","starred_url":"https://api.github.com/users/telus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telus/subscriptions","organizations_url":"https://api.github.com/users/telus/orgs","repos_url":"https://api.github.com/users/telus/repos","events_url":"https://api.github.com/users/telus/events{/privacy}","received_events_url":"https://api.github.com/users/telus/received_events","type":"Organization","site_admin":false},"repo":{"id":66407038,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQwNzAzOA==","name":"tds-core","full_name":"telus/tds-core","private":false,"owner":{"login":"telus","id":9374493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNzQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9374493?v=4","gravatar_id":"","url":"https://api.github.com/users/telus","html_url":"https://github.com/telus","followers_url":"https://api.github.com/users/telus/followers","following_url":"https://api.github.com/users/telus/following{/other_user}","gists_url":"https://api.github.com/users/telus/gists{/gist_id}","starred_url":"https://api.github.com/users/telus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telus/subscriptions","organizations_url":"https://api.github.com/users/telus/orgs","repos_url":"https://api.github.com/users/telus/repos","events_url":"https://api.github.com/users/telus/events{/privacy}","received_events_url":"https://api.github.com/users/telus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telus/tds-core","description":"TELUS Design System core components","fork":false,"url":"https://api.github.com/repos/telus/tds-core","forks_url":"https://api.github.com/repos/telus/tds-core/forks","keys_url":"https://api.github.com/repos/telus/tds-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telus/tds-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telus/tds-core/teams","hooks_url":"https://api.github.com/repos/telus/tds-core/hooks","issue_events_url":"https://api.github.com/repos/telus/tds-core/issues/events{/number}","events_url":"https://api.github.com/repos/telus/tds-core/events","assignees_url":"https://api.github.com/repos/telus/tds-core/assignees{/user}","branches_url":"https://api.github.com/repos/telus/tds-core/branches{/branch}","tags_url":"https://api.github.com/repos/telus/tds-core/tags","blobs_url":"https://api.github.com/repos/telus/tds-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telus/tds-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telus/tds-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/telus/tds-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telus/tds-core/statuses/{sha}","languages_url":"https://api.github.com/repos/telus/tds-core/languages","stargazers_url":"https://api.github.com/repos/telus/tds-core/stargazers","contributors_url":"https://api.github.com/repos/telus/tds-core/contributors","subscribers_url":"https://api.github.com/repos/telus/tds-core/subscribers","subscription_url":"https://api.github.com/repos/telus/tds-core/subscription","commits_url":"https://api.github.com/repos/telus/tds-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/telus/tds-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/telus/tds-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/telus/tds-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/telus/tds-core/contents/{+path}","compare_url":"https://api.github.com/repos/telus/tds-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telus/tds-core/merges","archive_url":"https://api.github.com/repos/telus/tds-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telus/tds-core/downloads","issues_url":"https://api.github.com/repos/telus/tds-core/issues{/number}","pulls_url":"https://api.github.com/repos/telus/tds-core/pulls{/number}","milestones_url":"https://api.github.com/repos/telus/tds-core/milestones{/number}","notifications_url":"https://api.github.com/repos/telus/tds-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telus/tds-core/labels{/name}","releases_url":"https://api.github.com/repos/telus/tds-core/releases{/id}","deployments_url":"https://api.github.com/repos/telus/tds-core/deployments","created_at":"2016-08-23T22:07:13Z","updated_at":"2019-07-24T17:50:33Z","pushed_at":"2019-07-24T18:44:55Z","git_url":"git://github.com/telus/tds-core.git","ssh_url":"git@github.com:telus/tds-core.git","clone_url":"https://github.com/telus/tds-core.git","svn_url":"https://github.com/telus/tds-core","homepage":"https://tds.telus.com/","size":256119,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":56,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":56,"watchers":54,"default_branch":"master"}},"base":{"label":"telus:master","ref":"master","sha":"c4fe10f04c9179ed68ea45bcdc75d47f7b3378f8","user":{"login":"telus","id":9374493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNzQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9374493?v=4","gravatar_id":"","url":"https://api.github.com/users/telus","html_url":"https://github.com/telus","followers_url":"https://api.github.com/users/telus/followers","following_url":"https://api.github.com/users/telus/following{/other_user}","gists_url":"https://api.github.com/users/telus/gists{/gist_id}","starred_url":"https://api.github.com/users/telus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telus/subscriptions","organizations_url":"https://api.github.com/users/telus/orgs","repos_url":"https://api.github.com/users/telus/repos","events_url":"https://api.github.com/users/telus/events{/privacy}","received_events_url":"https://api.github.com/users/telus/received_events","type":"Organization","site_admin":false},"repo":{"id":66407038,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQwNzAzOA==","name":"tds-core","full_name":"telus/tds-core","private":false,"owner":{"login":"telus","id":9374493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNzQ0OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9374493?v=4","gravatar_id":"","url":"https://api.github.com/users/telus","html_url":"https://github.com/telus","followers_url":"https://api.github.com/users/telus/followers","following_url":"https://api.github.com/users/telus/following{/other_user}","gists_url":"https://api.github.com/users/telus/gists{/gist_id}","starred_url":"https://api.github.com/users/telus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telus/subscriptions","organizations_url":"https://api.github.com/users/telus/orgs","repos_url":"https://api.github.com/users/telus/repos","events_url":"https://api.github.com/users/telus/events{/privacy}","received_events_url":"https://api.github.com/users/telus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telus/tds-core","description":"TELUS Design System core components","fork":false,"url":"https://api.github.com/repos/telus/tds-core","forks_url":"https://api.github.com/repos/telus/tds-core/forks","keys_url":"https://api.github.com/repos/telus/tds-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telus/tds-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telus/tds-core/teams","hooks_url":"https://api.github.com/repos/telus/tds-core/hooks","issue_events_url":"https://api.github.com/repos/telus/tds-core/issues/events{/number}","events_url":"https://api.github.com/repos/telus/tds-core/events","assignees_url":"https://api.github.com/repos/telus/tds-core/assignees{/user}","branches_url":"https://api.github.com/repos/telus/tds-core/branches{/branch}","tags_url":"https://api.github.com/repos/telus/tds-core/tags","blobs_url":"https://api.github.com/repos/telus/tds-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telus/tds-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telus/tds-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/telus/tds-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telus/tds-core/statuses/{sha}","languages_url":"https://api.github.com/repos/telus/tds-core/languages","stargazers_url":"https://api.github.com/repos/telus/tds-core/stargazers","contributors_url":"https://api.github.com/repos/telus/tds-core/contributors","subscribers_url":"https://api.github.com/repos/telus/tds-core/subscribers","subscription_url":"https://api.github.com/repos/telus/tds-core/subscription","commits_url":"https://api.github.com/repos/telus/tds-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/telus/tds-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/telus/tds-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/telus/tds-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/telus/tds-core/contents/{+path}","compare_url":"https://api.github.com/repos/telus/tds-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telus/tds-core/merges","archive_url":"https://api.github.com/repos/telus/tds-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telus/tds-core/downloads","issues_url":"https://api.github.com/repos/telus/tds-core/issues{/number}","pulls_url":"https://api.github.com/repos/telus/tds-core/pulls{/number}","milestones_url":"https://api.github.com/repos/telus/tds-core/milestones{/number}","notifications_url":"https://api.github.com/repos/telus/tds-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telus/tds-core/labels{/name}","releases_url":"https://api.github.com/repos/telus/tds-core/releases{/id}","deployments_url":"https://api.github.com/repos/telus/tds-core/deployments","created_at":"2016-08-23T22:07:13Z","updated_at":"2019-07-24T17:50:33Z","pushed_at":"2019-07-24T18:44:55Z","git_url":"git://github.com/telus/tds-core.git","ssh_url":"git@github.com:telus/tds-core.git","clone_url":"https://github.com/telus/tds-core.git","svn_url":"https://github.com/telus/tds-core","homepage":"https://tds.telus.com/","size":256119,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":56,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":56,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telus/tds-core/pulls/1195"},"html":{"href":"https://github.com/telus/tds-core/pull/1195"},"issue":{"href":"https://api.github.com/repos/telus/tds-core/issues/1195"},"comments":{"href":"https://api.github.com/repos/telus/tds-core/issues/1195/comments"},"review_comments":{"href":"https://api.github.com/repos/telus/tds-core/pulls/1195/comments"},"review_comment":{"href":"https://api.github.com/repos/telus/tds-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telus/tds-core/pulls/1195/commits"},"statuses":{"href":"https://api.github.com/repos/telus/tds-core/statuses/9d997691796671d63235f00109264d59a83d25f7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"agorovyi"}}