{"action":"created","comment":{"url":"https://api.github.com/repos/godotengine/godot/pulls/comments/294063140","pull_request_review_id":250210309,"id":294063140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDA2MzE0MA==","diff_hunk":"@@ -842,7 +842,7 @@ void ProjectSettingsEditor::_item_add() {\n \t\tcatname = \"global\";\n \t}\n \n-\tString name = catname + \"/\" + propname;\n+\tString name = catname.plus_file(propname);","path":"editor/project_settings_editor.cpp","position":5,"original_position":5,"commit_id":"1cccded4c3ff6d9a7d72df8639d111c45feac575","original_commit_id":"1cccded4c3ff6d9a7d72df8639d111c45feac575","user":{"login":"neikeq","id":7718100,"node_id":"MDQ6VXNlcjc3MTgxMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7718100?v=4","gravatar_id":"","url":"https://api.github.com/users/neikeq","html_url":"https://github.com/neikeq","followers_url":"https://api.github.com/users/neikeq/followers","following_url":"https://api.github.com/users/neikeq/following{/other_user}","gists_url":"https://api.github.com/users/neikeq/gists{/gist_id}","starred_url":"https://api.github.com/users/neikeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neikeq/subscriptions","organizations_url":"https://api.github.com/users/neikeq/orgs","repos_url":"https://api.github.com/users/neikeq/repos","events_url":"https://api.github.com/users/neikeq/events{/privacy}","received_events_url":"https://api.github.com/users/neikeq/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2019-06-16T00:12:20Z","updated_at":"2019-06-16T00:24:03Z","html_url":"https://github.com/godotengine/godot/pull/29815#discussion_r294063140","pull_request_url":"https://api.github.com/repos/godotengine/godot/pulls/29815","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments/294063140"},"html":{"href":"https://github.com/godotengine/godot/pull/29815#discussion_r294063140"},"pull_request":{"href":"https://api.github.com/repos/godotengine/godot/pulls/29815"}}},"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/29815","id":288585390,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NTg1Mzkw","html_url":"https://github.com/godotengine/godot/pull/29815","diff_url":"https://github.com/godotengine/godot/pull/29815.diff","patch_url":"https://github.com/godotengine/godot/pull/29815.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/29815","number":29815,"state":"open","locked":false,"title":"Replace ` + \"/\" + ` with `String::file_add()`","user":{"login":"NilsIrl","id":26231126,"node_id":"MDQ6VXNlcjI2MjMxMTI2","avatar_url":"https://avatars1.githubusercontent.com/u/26231126?v=4","gravatar_id":"","url":"https://api.github.com/users/NilsIrl","html_url":"https://github.com/NilsIrl","followers_url":"https://api.github.com/users/NilsIrl/followers","following_url":"https://api.github.com/users/NilsIrl/following{/other_user}","gists_url":"https://api.github.com/users/NilsIrl/gists{/gist_id}","starred_url":"https://api.github.com/users/NilsIrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilsIrl/subscriptions","organizations_url":"https://api.github.com/users/NilsIrl/orgs","repos_url":"https://api.github.com/users/NilsIrl/repos","events_url":"https://api.github.com/users/NilsIrl/events{/privacy}","received_events_url":"https://api.github.com/users/NilsIrl/received_events","type":"User","site_admin":false},"body":"Adresses #29602\r\n\r\nI still need a bit of feedback on the following points:\r\n1. There are only 2 cases of string appending (e.g. https://github.com/godotengine/godot/blob/ce8e5413390b48542b98ffafe5fc8b0b8032efa2/core/node_path.cpp#L280 and they have been ignored). This is fine but an alternative is to implement a `plus_file()` function for appending.\r\n2. There are also 2 cases where the class in a `StringName`. This again isn't a problem but an alternative is to implement a `plus_file()` function for `StringName`.\r\nhttps://github.com/godotengine/godot/blob/ce8e5413390b48542b98ffafe5fc8b0b8032efa2/editor/plugins/spatial_editor_plugin.cpp#L875\r\n\r\nI'd like to know if the PR is good as it is or if I should address the two points mentioned.","created_at":"2019-06-15T22:20:51Z","updated_at":"2019-06-16T00:24:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e166d97730f0aaf74220acd424f880d1b4660166","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hpvb","id":2591099,"node_id":"MDQ6VXNlcjI1OTEwOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2591099?v=4","gravatar_id":"","url":"https://api.github.com/users/hpvb","html_url":"https://github.com/hpvb","followers_url":"https://api.github.com/users/hpvb/followers","following_url":"https://api.github.com/users/hpvb/following{/other_user}","gists_url":"https://api.github.com/users/hpvb/gists{/gist_id}","starred_url":"https://api.github.com/users/hpvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpvb/subscriptions","organizations_url":"https://api.github.com/users/hpvb/orgs","repos_url":"https://api.github.com/users/hpvb/repos","events_url":"https://api.github.com/users/hpvb/events{/privacy}","received_events_url":"https://api.github.com/users/hpvb/received_events","type":"User","site_admin":false},{"login":"bojidar-bg","id":5276727,"node_id":"MDQ6VXNlcjUyNzY3Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/5276727?v=4","gravatar_id":"","url":"https://api.github.com/users/bojidar-bg","html_url":"https://github.com/bojidar-bg","followers_url":"https://api.github.com/users/bojidar-bg/followers","following_url":"https://api.github.com/users/bojidar-bg/following{/other_user}","gists_url":"https://api.github.com/users/bojidar-bg/gists{/gist_id}","starred_url":"https://api.github.com/users/bojidar-bg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bojidar-bg/subscriptions","organizations_url":"https://api.github.com/users/bojidar-bg/orgs","repos_url":"https://api.github.com/users/bojidar-bg/repos","events_url":"https://api.github.com/users/bojidar-bg/events{/privacy}","received_events_url":"https://api.github.com/users/bojidar-bg/received_events","type":"User","site_admin":false},{"login":"vnen","id":5599796,"node_id":"MDQ6VXNlcjU1OTk3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5599796?v=4","gravatar_id":"","url":"https://api.github.com/users/vnen","html_url":"https://github.com/vnen","followers_url":"https://api.github.com/users/vnen/followers","following_url":"https://api.github.com/users/vnen/following{/other_user}","gists_url":"https://api.github.com/users/vnen/gists{/gist_id}","starred_url":"https://api.github.com/users/vnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vnen/subscriptions","organizations_url":"https://api.github.com/users/vnen/orgs","repos_url":"https://api.github.com/users/vnen/repos","events_url":"https://api.github.com/users/vnen/events{/privacy}","received_events_url":"https://api.github.com/users/vnen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/29815/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/29815/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/29815/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/1cccded4c3ff6d9a7d72df8639d111c45feac575","head":{"label":"NilsIrl:plus_file_1","ref":"plus_file_1","sha":"1cccded4c3ff6d9a7d72df8639d111c45feac575","user":{"login":"NilsIrl","id":26231126,"node_id":"MDQ6VXNlcjI2MjMxMTI2","avatar_url":"https://avatars1.githubusercontent.com/u/26231126?v=4","gravatar_id":"","url":"https://api.github.com/users/NilsIrl","html_url":"https://github.com/NilsIrl","followers_url":"https://api.github.com/users/NilsIrl/followers","following_url":"https://api.github.com/users/NilsIrl/following{/other_user}","gists_url":"https://api.github.com/users/NilsIrl/gists{/gist_id}","starred_url":"https://api.github.com/users/NilsIrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilsIrl/subscriptions","organizations_url":"https://api.github.com/users/NilsIrl/orgs","repos_url":"https://api.github.com/users/NilsIrl/repos","events_url":"https://api.github.com/users/NilsIrl/events{/privacy}","received_events_url":"https://api.github.com/users/NilsIrl/received_events","type":"User","site_admin":false},"repo":{"id":191594788,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE1OTQ3ODg=","name":"godot","full_name":"NilsIrl/godot","private":false,"owner":{"login":"NilsIrl","id":26231126,"node_id":"MDQ6VXNlcjI2MjMxMTI2","avatar_url":"https://avatars1.githubusercontent.com/u/26231126?v=4","gravatar_id":"","url":"https://api.github.com/users/NilsIrl","html_url":"https://github.com/NilsIrl","followers_url":"https://api.github.com/users/NilsIrl/followers","following_url":"https://api.github.com/users/NilsIrl/following{/other_user}","gists_url":"https://api.github.com/users/NilsIrl/gists{/gist_id}","starred_url":"https://api.github.com/users/NilsIrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilsIrl/subscriptions","organizations_url":"https://api.github.com/users/NilsIrl/orgs","repos_url":"https://api.github.com/users/NilsIrl/repos","events_url":"https://api.github.com/users/NilsIrl/events{/privacy}","received_events_url":"https://api.github.com/users/NilsIrl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NilsIrl/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":true,"url":"https://api.github.com/repos/NilsIrl/godot","forks_url":"https://api.github.com/repos/NilsIrl/godot/forks","keys_url":"https://api.github.com/repos/NilsIrl/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NilsIrl/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NilsIrl/godot/teams","hooks_url":"https://api.github.com/repos/NilsIrl/godot/hooks","issue_events_url":"https://api.github.com/repos/NilsIrl/godot/issues/events{/number}","events_url":"https://api.github.com/repos/NilsIrl/godot/events","assignees_url":"https://api.github.com/repos/NilsIrl/godot/assignees{/user}","branches_url":"https://api.github.com/repos/NilsIrl/godot/branches{/branch}","tags_url":"https://api.github.com/repos/NilsIrl/godot/tags","blobs_url":"https://api.github.com/repos/NilsIrl/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NilsIrl/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NilsIrl/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/NilsIrl/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NilsIrl/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/NilsIrl/godot/languages","stargazers_url":"https://api.github.com/repos/NilsIrl/godot/stargazers","contributors_url":"https://api.github.com/repos/NilsIrl/godot/contributors","subscribers_url":"https://api.github.com/repos/NilsIrl/godot/subscribers","subscription_url":"https://api.github.com/repos/NilsIrl/godot/subscription","commits_url":"https://api.github.com/repos/NilsIrl/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/NilsIrl/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/NilsIrl/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/NilsIrl/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/NilsIrl/godot/contents/{+path}","compare_url":"https://api.github.com/repos/NilsIrl/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NilsIrl/godot/merges","archive_url":"https://api.github.com/repos/NilsIrl/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NilsIrl/godot/downloads","issues_url":"https://api.github.com/repos/NilsIrl/godot/issues{/number}","pulls_url":"https://api.github.com/repos/NilsIrl/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/NilsIrl/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/NilsIrl/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NilsIrl/godot/labels{/name}","releases_url":"https://api.github.com/repos/NilsIrl/godot/releases{/id}","deployments_url":"https://api.github.com/repos/NilsIrl/godot/deployments","created_at":"2019-06-12T15:10:40Z","updated_at":"2019-06-12T15:10:50Z","pushed_at":"2019-06-15T22:22:29Z","git_url":"git://github.com/NilsIrl/godot.git","ssh_url":"git@github.com:NilsIrl/godot.git","clone_url":"https://github.com/NilsIrl/godot.git","svn_url":"https://github.com/NilsIrl/godot","homepage":"https://godotengine.org","size":318618,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"ce8e5413390b48542b98ffafe5fc8b0b8032efa2","user":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzNDk4MQ==","name":"godot","full_name":"godotengine/godot","private":false,"owner":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/godotengine/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2019-06-15T22:37:43Z","pushed_at":"2019-06-15T22:22:31Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"git@github.com:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"https://godotengine.org","size":318671,"stargazers_count":22763,"watchers_count":22763,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4438,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5265,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4438,"open_issues":5265,"watchers":22763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/29815"},"html":{"href":"https://github.com/godotengine/godot/pull/29815"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/29815"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/29815/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/29815/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/29815/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/1cccded4c3ff6d9a7d72df8639d111c45feac575"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"neikeq"}}