{"action":"created","comment":{"url":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/comments/275131700","pull_request_review_id":226368521,"id":275131700,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTEzMTcwMA==","diff_hunk":"@@ -12,23 +12,29 @@\n TW_EXTERN_C_BEGIN\n \n TW_EXPORT_STRUCT\n-struct TWCoinTypeConfiguration { \n+struct TWCoinTypeConfiguration {\n     uint8_t unused; // C doesn't allow zero-sized struct\n };\n \n+/// Returns stock symbol of coin\n TW_EXPORT_STATIC_METHOD\n-TWString *_Nonnull TWCoinTypeConfigurationGetSymbol(enum TWCoinType type);","path":"include/TrustWalletCore/TWCoinTypeConfiguration.h","position":11,"original_position":11,"commit_id":"e476eebcd40c2039864bbd0086f8da0b1675c9c1","original_commit_id":"e476eebcd40c2039864bbd0086f8da0b1675c9c1","user":{"login":"armatusmiles","id":20345096,"node_id":"MDQ6VXNlcjIwMzQ1MDk2","avatar_url":"https://avatars0.githubusercontent.com/u/20345096?v=4","gravatar_id":"","url":"https://api.github.com/users/armatusmiles","html_url":"https://github.com/armatusmiles","followers_url":"https://api.github.com/users/armatusmiles/followers","following_url":"https://api.github.com/users/armatusmiles/following{/other_user}","gists_url":"https://api.github.com/users/armatusmiles/gists{/gist_id}","starred_url":"https://api.github.com/users/armatusmiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armatusmiles/subscriptions","organizations_url":"https://api.github.com/users/armatusmiles/orgs","repos_url":"https://api.github.com/users/armatusmiles/repos","events_url":"https://api.github.com/users/armatusmiles/events{/privacy}","received_events_url":"https://api.github.com/users/armatusmiles/received_events","type":"User","site_admin":false},"body":"> It's great that the parser doesn't fail on this condition, but can you make pointer alignment here consistent with the rest of the headers?\r\n\r\nWhy? I use [.clang-format](https://github.com/TrustWallet/wallet-core/blob/master/.clang-format#L9) from this repository where: 'PointerAlignment: Left' ","created_at":"2019-04-13T20:37:43Z","updated_at":"2019-04-13T20:37:43Z","html_url":"https://github.com/TrustWallet/wallet-core/pull/316#discussion_r275131700","pull_request_url":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/316","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/comments/275131700"},"html":{"href":"https://github.com/TrustWallet/wallet-core/pull/316#discussion_r275131700"},"pull_request":{"href":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/316"}},"in_reply_to_id":275130391},"pull_request":{"url":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/316","id":270218088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMjE4MDg4","html_url":"https://github.com/TrustWallet/wallet-core/pull/316","diff_url":"https://github.com/TrustWallet/wallet-core/pull/316.diff","patch_url":"https://github.com/TrustWallet/wallet-core/pull/316.patch","issue_url":"https://api.github.com/repos/TrustWallet/wallet-core/issues/316","number":316,"state":"open","locked":false,"title":"Fix codegen bug. Add comments to TWCoinTypeConfiguration.h","user":{"login":"armatusmiles","id":20345096,"node_id":"MDQ6VXNlcjIwMzQ1MDk2","avatar_url":"https://avatars0.githubusercontent.com/u/20345096?v=4","gravatar_id":"","url":"https://api.github.com/users/armatusmiles","html_url":"https://github.com/armatusmiles","followers_url":"https://api.github.com/users/armatusmiles/followers","following_url":"https://api.github.com/users/armatusmiles/following{/other_user}","gists_url":"https://api.github.com/users/armatusmiles/gists{/gist_id}","starred_url":"https://api.github.com/users/armatusmiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armatusmiles/subscriptions","organizations_url":"https://api.github.com/users/armatusmiles/orgs","repos_url":"https://api.github.com/users/armatusmiles/repos","events_url":"https://api.github.com/users/armatusmiles/events{/privacy}","received_events_url":"https://api.github.com/users/armatusmiles/received_events","type":"User","site_admin":false},"body":"## Description\r\nFix codegen parser bug.\r\nAdd comments to TWCoinTypeConfiguration.h for more clarify code\r\n<!--- Describe your changes in detail -->\r\n\r\n## Testing instructions\r\n\r\n<!--- Please describe how reviewers can test your changes -->\r\n\r\n## Types of changes\r\n\r\n<!--- What types of changes does your code introduce? Uncomment all the bullets that apply: -->\r\n * Documentation\r\n* Bug fix (non-breaking change which fixes an issue) \r\n\r\n<!-- * New feature (non-breaking change which adds functionality) -->\r\n\r\n<!-- * Breaking change (fix or feature that would cause existing functionality to change) -->\r\n\r\n## Checklist\r\n\r\n<!--- The following points should be used to indicate the progress of your PR.  Put an `x` in all the boxes that apply right now, and come back over time and check them off as you make progress.  If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n- [ ] Prefix PR title with `[WIP]` if necessary.\r\n- [x] Add tests to cover changes as needed.\r\n- [ ] Update documentation as needed.\r\n","created_at":"2019-04-13T10:45:54Z","updated_at":"2019-04-13T20:37:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27bfa18578e25ef15cd0d193f02993edc35904dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/316/commits","review_comments_url":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/316/comments","review_comment_url":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrustWallet/wallet-core/issues/316/comments","statuses_url":"https://api.github.com/repos/TrustWallet/wallet-core/statuses/e476eebcd40c2039864bbd0086f8da0b1675c9c1","head":{"label":"armatusmiles:TwCoinTypeConfiguration-comments","ref":"TwCoinTypeConfiguration-comments","sha":"e476eebcd40c2039864bbd0086f8da0b1675c9c1","user":{"login":"armatusmiles","id":20345096,"node_id":"MDQ6VXNlcjIwMzQ1MDk2","avatar_url":"https://avatars0.githubusercontent.com/u/20345096?v=4","gravatar_id":"","url":"https://api.github.com/users/armatusmiles","html_url":"https://github.com/armatusmiles","followers_url":"https://api.github.com/users/armatusmiles/followers","following_url":"https://api.github.com/users/armatusmiles/following{/other_user}","gists_url":"https://api.github.com/users/armatusmiles/gists{/gist_id}","starred_url":"https://api.github.com/users/armatusmiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armatusmiles/subscriptions","organizations_url":"https://api.github.com/users/armatusmiles/orgs","repos_url":"https://api.github.com/users/armatusmiles/repos","events_url":"https://api.github.com/users/armatusmiles/events{/privacy}","received_events_url":"https://api.github.com/users/armatusmiles/received_events","type":"User","site_admin":false},"repo":{"id":181138737,"node_id":"MDEwOlJlcG9zaXRvcnkxODExMzg3Mzc=","name":"wallet-core","full_name":"armatusmiles/wallet-core","private":false,"owner":{"login":"armatusmiles","id":20345096,"node_id":"MDQ6VXNlcjIwMzQ1MDk2","avatar_url":"https://avatars0.githubusercontent.com/u/20345096?v=4","gravatar_id":"","url":"https://api.github.com/users/armatusmiles","html_url":"https://github.com/armatusmiles","followers_url":"https://api.github.com/users/armatusmiles/followers","following_url":"https://api.github.com/users/armatusmiles/following{/other_user}","gists_url":"https://api.github.com/users/armatusmiles/gists{/gist_id}","starred_url":"https://api.github.com/users/armatusmiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armatusmiles/subscriptions","organizations_url":"https://api.github.com/users/armatusmiles/orgs","repos_url":"https://api.github.com/users/armatusmiles/repos","events_url":"https://api.github.com/users/armatusmiles/events{/privacy}","received_events_url":"https://api.github.com/users/armatusmiles/received_events","type":"User","site_admin":false},"html_url":"https://github.com/armatusmiles/wallet-core","description":"Cross-platform, cross-blockchain wallet library.","fork":true,"url":"https://api.github.com/repos/armatusmiles/wallet-core","forks_url":"https://api.github.com/repos/armatusmiles/wallet-core/forks","keys_url":"https://api.github.com/repos/armatusmiles/wallet-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/armatusmiles/wallet-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/armatusmiles/wallet-core/teams","hooks_url":"https://api.github.com/repos/armatusmiles/wallet-core/hooks","issue_events_url":"https://api.github.com/repos/armatusmiles/wallet-core/issues/events{/number}","events_url":"https://api.github.com/repos/armatusmiles/wallet-core/events","assignees_url":"https://api.github.com/repos/armatusmiles/wallet-core/assignees{/user}","branches_url":"https://api.github.com/repos/armatusmiles/wallet-core/branches{/branch}","tags_url":"https://api.github.com/repos/armatusmiles/wallet-core/tags","blobs_url":"https://api.github.com/repos/armatusmiles/wallet-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/armatusmiles/wallet-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/armatusmiles/wallet-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/armatusmiles/wallet-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/armatusmiles/wallet-core/statuses/{sha}","languages_url":"https://api.github.com/repos/armatusmiles/wallet-core/languages","stargazers_url":"https://api.github.com/repos/armatusmiles/wallet-core/stargazers","contributors_url":"https://api.github.com/repos/armatusmiles/wallet-core/contributors","subscribers_url":"https://api.github.com/repos/armatusmiles/wallet-core/subscribers","subscription_url":"https://api.github.com/repos/armatusmiles/wallet-core/subscription","commits_url":"https://api.github.com/repos/armatusmiles/wallet-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/armatusmiles/wallet-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/armatusmiles/wallet-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/armatusmiles/wallet-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/armatusmiles/wallet-core/contents/{+path}","compare_url":"https://api.github.com/repos/armatusmiles/wallet-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/armatusmiles/wallet-core/merges","archive_url":"https://api.github.com/repos/armatusmiles/wallet-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/armatusmiles/wallet-core/downloads","issues_url":"https://api.github.com/repos/armatusmiles/wallet-core/issues{/number}","pulls_url":"https://api.github.com/repos/armatusmiles/wallet-core/pulls{/number}","milestones_url":"https://api.github.com/repos/armatusmiles/wallet-core/milestones{/number}","notifications_url":"https://api.github.com/repos/armatusmiles/wallet-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/armatusmiles/wallet-core/labels{/name}","releases_url":"https://api.github.com/repos/armatusmiles/wallet-core/releases{/id}","deployments_url":"https://api.github.com/repos/armatusmiles/wallet-core/deployments","created_at":"2019-04-13T07:49:31Z","updated_at":"2019-04-13T18:29:14Z","pushed_at":"2019-04-13T18:29:12Z","git_url":"git://github.com/armatusmiles/wallet-core.git","ssh_url":"git@github.com:armatusmiles/wallet-core.git","clone_url":"https://github.com/armatusmiles/wallet-core.git","svn_url":"https://github.com/armatusmiles/wallet-core","homepage":null,"size":13923,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TrustWallet:master","ref":"master","sha":"9b80c6c1cb2b8eabdc2aedecfc5b125df085e8be","user":{"login":"TrustWallet","id":32179889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTc5ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"repo":{"id":170738310,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA3MzgzMTA=","name":"wallet-core","full_name":"TrustWallet/wallet-core","private":false,"owner":{"login":"TrustWallet","id":32179889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTc5ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TrustWallet/wallet-core","description":"Cross-platform, cross-blockchain wallet library.","fork":false,"url":"https://api.github.com/repos/TrustWallet/wallet-core","forks_url":"https://api.github.com/repos/TrustWallet/wallet-core/forks","keys_url":"https://api.github.com/repos/TrustWallet/wallet-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrustWallet/wallet-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrustWallet/wallet-core/teams","hooks_url":"https://api.github.com/repos/TrustWallet/wallet-core/hooks","issue_events_url":"https://api.github.com/repos/TrustWallet/wallet-core/issues/events{/number}","events_url":"https://api.github.com/repos/TrustWallet/wallet-core/events","assignees_url":"https://api.github.com/repos/TrustWallet/wallet-core/assignees{/user}","branches_url":"https://api.github.com/repos/TrustWallet/wallet-core/branches{/branch}","tags_url":"https://api.github.com/repos/TrustWallet/wallet-core/tags","blobs_url":"https://api.github.com/repos/TrustWallet/wallet-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrustWallet/wallet-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrustWallet/wallet-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrustWallet/wallet-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrustWallet/wallet-core/statuses/{sha}","languages_url":"https://api.github.com/repos/TrustWallet/wallet-core/languages","stargazers_url":"https://api.github.com/repos/TrustWallet/wallet-core/stargazers","contributors_url":"https://api.github.com/repos/TrustWallet/wallet-core/contributors","subscribers_url":"https://api.github.com/repos/TrustWallet/wallet-core/subscribers","subscription_url":"https://api.github.com/repos/TrustWallet/wallet-core/subscription","commits_url":"https://api.github.com/repos/TrustWallet/wallet-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrustWallet/wallet-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrustWallet/wallet-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrustWallet/wallet-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrustWallet/wallet-core/contents/{+path}","compare_url":"https://api.github.com/repos/TrustWallet/wallet-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrustWallet/wallet-core/merges","archive_url":"https://api.github.com/repos/TrustWallet/wallet-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrustWallet/wallet-core/downloads","issues_url":"https://api.github.com/repos/TrustWallet/wallet-core/issues{/number}","pulls_url":"https://api.github.com/repos/TrustWallet/wallet-core/pulls{/number}","milestones_url":"https://api.github.com/repos/TrustWallet/wallet-core/milestones{/number}","notifications_url":"https://api.github.com/repos/TrustWallet/wallet-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrustWallet/wallet-core/labels{/name}","releases_url":"https://api.github.com/repos/TrustWallet/wallet-core/releases{/id}","deployments_url":"https://api.github.com/repos/TrustWallet/wallet-core/deployments","created_at":"2019-02-14T18:25:54Z","updated_at":"2019-04-13T18:24:21Z","pushed_at":"2019-04-13T18:43:50Z","git_url":"git://github.com/TrustWallet/wallet-core.git","ssh_url":"git@github.com:TrustWallet/wallet-core.git","clone_url":"https://github.com/TrustWallet/wallet-core.git","svn_url":"https://github.com/TrustWallet/wallet-core","homepage":null,"size":13917,"stargazers_count":132,"watchers_count":132,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":59,"open_issues":31,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/316"},"html":{"href":"https://github.com/TrustWallet/wallet-core/pull/316"},"issue":{"href":"https://api.github.com/repos/TrustWallet/wallet-core/issues/316"},"comments":{"href":"https://api.github.com/repos/TrustWallet/wallet-core/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrustWallet/wallet-core/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/TrustWallet/wallet-core/statuses/e476eebcd40c2039864bbd0086f8da0b1675c9c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"armatusmiles"}}