{"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/306861653","pull_request_review_id":266085530,"id":306861653,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjg2MTY1Mw==","diff_hunk":"@@ -644,8 +644,10 @@ class UnionConverter final : public ConcreteConverter<UnionConverter> {\n   }\n \n   Status AppendNull() override {\n-    for (auto& converter : child_converters_) {\n-      RETURN_NOT_OK(converter->AppendNull());\n+    if (mode_ == UnionMode::SPARSE) {","path":"cpp/src/arrow/ipc/json-simple.cc","position":6,"original_position":6,"commit_id":"3df7bf39630c4c7e632d107fb0ef499c3085eac7","original_commit_id":"3df7bf39630c4c7e632d107fb0ef499c3085eac7","user":{"login":"pitrou","id":1721820,"node_id":"MDQ6VXNlcjE3MjE4MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1721820?v=4","gravatar_id":"","url":"https://api.github.com/users/pitrou","html_url":"https://github.com/pitrou","followers_url":"https://api.github.com/users/pitrou/followers","following_url":"https://api.github.com/users/pitrou/following{/other_user}","gists_url":"https://api.github.com/users/pitrou/gists{/gist_id}","starred_url":"https://api.github.com/users/pitrou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitrou/subscriptions","organizations_url":"https://api.github.com/users/pitrou/orgs","repos_url":"https://api.github.com/users/pitrou/repos","events_url":"https://api.github.com/users/pitrou/events{/privacy}","received_events_url":"https://api.github.com/users/pitrou/received_events","type":"User","site_admin":false},"body":"Interesting. Is there a way to test for this in `json-simple-test`?","created_at":"2019-07-24T15:02:52Z","updated_at":"2019-07-24T15:17:15Z","html_url":"https://github.com/apache/arrow/pull/4866#discussion_r306861653","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/4866","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/306861653"},"html":{"href":"https://github.com/apache/arrow/pull/4866#discussion_r306861653"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/4866"}}},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/4866","id":297188030,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3MTg4MDMw","html_url":"https://github.com/apache/arrow/pull/4866","diff_url":"https://github.com/apache/arrow/pull/4866.diff","patch_url":"https://github.com/apache/arrow/pull/4866.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/4866","number":4866,"state":"open","locked":false,"title":"ARROW-5594: [C++] add UnionArrays support to Take/Filter kernels","user":{"login":"bkietz","id":1299904,"node_id":"MDQ6VXNlcjEyOTk5MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1299904?v=4","gravatar_id":"","url":"https://api.github.com/users/bkietz","html_url":"https://github.com/bkietz","followers_url":"https://api.github.com/users/bkietz/followers","following_url":"https://api.github.com/users/bkietz/following{/other_user}","gists_url":"https://api.github.com/users/bkietz/gists{/gist_id}","starred_url":"https://api.github.com/users/bkietz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkietz/subscriptions","organizations_url":"https://api.github.com/users/bkietz/orgs","repos_url":"https://api.github.com/users/bkietz/repos","events_url":"https://api.github.com/users/bkietz/events{/privacy}","received_events_url":"https://api.github.com/users/bkietz/received_events","type":"User","site_admin":false},"body":"Take and Filter kernels should now be able to operate on arrays of any type.","created_at":"2019-07-12T19:02:37Z","updated_at":"2019-07-24T15:17:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3031b21879d3a584c879c0e7bc316df20829313","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1405501793,"node_id":"MDU6TGFiZWwxNDA1NTAxNzkz","url":"https://api.github.com/repos/apache/arrow/labels/lang-c++","name":"lang-c++","color":"f34b7d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/4866/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/4866/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/4866/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/3df7bf39630c4c7e632d107fb0ef499c3085eac7","head":{"label":"bkietz:5594-add-support-for-UnionArrays-to-Take-and-","ref":"5594-add-support-for-UnionArrays-to-Take-and-","sha":"3df7bf39630c4c7e632d107fb0ef499c3085eac7","user":{"login":"bkietz","id":1299904,"node_id":"MDQ6VXNlcjEyOTk5MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1299904?v=4","gravatar_id":"","url":"https://api.github.com/users/bkietz","html_url":"https://github.com/bkietz","followers_url":"https://api.github.com/users/bkietz/followers","following_url":"https://api.github.com/users/bkietz/following{/other_user}","gists_url":"https://api.github.com/users/bkietz/gists{/gist_id}","starred_url":"https://api.github.com/users/bkietz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkietz/subscriptions","organizations_url":"https://api.github.com/users/bkietz/orgs","repos_url":"https://api.github.com/users/bkietz/repos","events_url":"https://api.github.com/users/bkietz/events{/privacy}","received_events_url":"https://api.github.com/users/bkietz/received_events","type":"User","site_admin":false},"repo":{"id":159206370,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkyMDYzNzA=","name":"arrow","full_name":"bkietz/arrow","private":false,"owner":{"login":"bkietz","id":1299904,"node_id":"MDQ6VXNlcjEyOTk5MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1299904?v=4","gravatar_id":"","url":"https://api.github.com/users/bkietz","html_url":"https://github.com/bkietz","followers_url":"https://api.github.com/users/bkietz/followers","following_url":"https://api.github.com/users/bkietz/following{/other_user}","gists_url":"https://api.github.com/users/bkietz/gists{/gist_id}","starred_url":"https://api.github.com/users/bkietz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkietz/subscriptions","organizations_url":"https://api.github.com/users/bkietz/orgs","repos_url":"https://api.github.com/users/bkietz/repos","events_url":"https://api.github.com/users/bkietz/events{/privacy}","received_events_url":"https://api.github.com/users/bkietz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bkietz/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":true,"url":"https://api.github.com/repos/bkietz/arrow","forks_url":"https://api.github.com/repos/bkietz/arrow/forks","keys_url":"https://api.github.com/repos/bkietz/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkietz/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkietz/arrow/teams","hooks_url":"https://api.github.com/repos/bkietz/arrow/hooks","issue_events_url":"https://api.github.com/repos/bkietz/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/bkietz/arrow/events","assignees_url":"https://api.github.com/repos/bkietz/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/bkietz/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/bkietz/arrow/tags","blobs_url":"https://api.github.com/repos/bkietz/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkietz/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkietz/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkietz/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkietz/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/bkietz/arrow/languages","stargazers_url":"https://api.github.com/repos/bkietz/arrow/stargazers","contributors_url":"https://api.github.com/repos/bkietz/arrow/contributors","subscribers_url":"https://api.github.com/repos/bkietz/arrow/subscribers","subscription_url":"https://api.github.com/repos/bkietz/arrow/subscription","commits_url":"https://api.github.com/repos/bkietz/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkietz/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkietz/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkietz/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/bkietz/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/bkietz/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkietz/arrow/merges","archive_url":"https://api.github.com/repos/bkietz/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkietz/arrow/downloads","issues_url":"https://api.github.com/repos/bkietz/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/bkietz/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/bkietz/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/bkietz/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkietz/arrow/labels{/name}","releases_url":"https://api.github.com/repos/bkietz/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/bkietz/arrow/deployments","created_at":"2018-11-26T17:18:46Z","updated_at":"2019-02-22T16:15:43Z","pushed_at":"2019-07-23T20:56:39Z","git_url":"git://github.com/bkietz/arrow.git","ssh_url":"git@github.com:bkietz/arrow.git","clone_url":"https://github.com/bkietz/arrow.git","svn_url":"https://github.com/bkietz/arrow","homepage":"https://arrow.apache.org","size":33454,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"85fe33653b6ba8b72e1af2d64abb759aa7aa50e7","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"node_id":"MDEwOlJlcG9zaXRvcnk1MTkwNTM1Mw==","name":"arrow","full_name":"apache/arrow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2019-07-24T14:37:20Z","pushed_at":"2019-07-24T14:37:03Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":33225,"stargazers_count":4247,"watchers_count":4247,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1040,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1040,"open_issues":66,"watchers":4247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/4866"},"html":{"href":"https://github.com/apache/arrow/pull/4866"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/4866"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/4866/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/4866/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/4866/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/3df7bf39630c4c7e632d107fb0ef499c3085eac7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pitrou"}}