{"action":"created","comment":{"url":"https://api.github.com/repos/amethyst/laminar/pulls/comments/294056650","pull_request_review_id":250203646,"id":294056650,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDA1NjY1MA==","diff_hunk":"@@ -162,20 +181,29 @@ impl Socket {\n                     self.event_sender.send(SocketEvent::Connect(address))?;\n                 }\n \n-                let connection = self\n-                    .connections\n-                    .get_or_insert_connection(address, &self.config);\n+                let connection =\n+                    self.connections\n+                        .get_or_create_connection(address, time, &self.config);\n \n-                connection.process_incoming(received_payload, &self.event_sender)?;\n+                match connection {\n+                    Left(existing) => {\n+                        existing.process_incoming(received_payload, time, &self.event_sender)?;\n+                    }\n+                    Right(mut anonymous) => {\n+                        anonymous.process_incoming(received_payload, time, &self.event_sender)?;","path":"src/net/socket.rs","position":null,"original_position":146,"commit_id":"0138f89821139ba403831240aff884c2d81ac805","original_commit_id":"71007c3ab0ad17fa6217dc479d7db3cad5b90b6a","user":{"login":"BourgondAries","id":4683721,"node_id":"MDQ6VXNlcjQ2ODM3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4683721?v=4","gravatar_id":"","url":"https://api.github.com/users/BourgondAries","html_url":"https://github.com/BourgondAries","followers_url":"https://api.github.com/users/BourgondAries/followers","following_url":"https://api.github.com/users/BourgondAries/following{/other_user}","gists_url":"https://api.github.com/users/BourgondAries/gists{/gist_id}","starred_url":"https://api.github.com/users/BourgondAries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BourgondAries/subscriptions","organizations_url":"https://api.github.com/users/BourgondAries/orgs","repos_url":"https://api.github.com/users/BourgondAries/repos","events_url":"https://api.github.com/users/BourgondAries/events{/privacy}","received_events_url":"https://api.github.com/users/BourgondAries/received_events","type":"User","site_admin":false},"body":"Scratch that, forgot a manual_poll, seems like we're not properly re-sending.","created_at":"2019-06-15T19:01:54Z","updated_at":"2019-06-15T19:01:54Z","html_url":"https://github.com/amethyst/laminar/pull/194#discussion_r294056650","pull_request_url":"https://api.github.com/repos/amethyst/laminar/pulls/194","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/amethyst/laminar/pulls/comments/294056650"},"html":{"href":"https://github.com/amethyst/laminar/pull/194#discussion_r294056650"},"pull_request":{"href":"https://api.github.com/repos/amethyst/laminar/pulls/194"}},"in_reply_to_id":293949972},"pull_request":{"url":"https://api.github.com/repos/amethyst/laminar/pulls/194","id":288451956,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NDUxOTU2","html_url":"https://github.com/amethyst/laminar/pull/194","diff_url":"https://github.com/amethyst/laminar/pull/194.diff","patch_url":"https://github.com/amethyst/laminar/pull/194.patch","issue_url":"https://api.github.com/repos/amethyst/laminar/issues/194","number":194,"state":"open","locked":false,"title":"DoS attack mitigation","user":{"login":"BourgondAries","id":4683721,"node_id":"MDQ6VXNlcjQ2ODM3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4683721?v=4","gravatar_id":"","url":"https://api.github.com/users/BourgondAries","html_url":"https://github.com/BourgondAries","followers_url":"https://api.github.com/users/BourgondAries/followers","following_url":"https://api.github.com/users/BourgondAries/following{/other_user}","gists_url":"https://api.github.com/users/BourgondAries/gists{/gist_id}","starred_url":"https://api.github.com/users/BourgondAries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BourgondAries/subscriptions","organizations_url":"https://api.github.com/users/BourgondAries/orgs","repos_url":"https://api.github.com/users/BourgondAries/repos","events_url":"https://api.github.com/users/BourgondAries/events{/privacy}","received_events_url":"https://api.github.com/users/BourgondAries/received_events","type":"User","site_admin":false},"body":"This fixes issue 187. See last commit in the series for more detail.","created_at":"2019-06-14T19:22:24Z","updated_at":"2019-06-15T19:01:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3896edaea13bc103c60a7a3ac701ab869ecf9926","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/amethyst/laminar/pulls/194/commits","review_comments_url":"https://api.github.com/repos/amethyst/laminar/pulls/194/comments","review_comment_url":"https://api.github.com/repos/amethyst/laminar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amethyst/laminar/issues/194/comments","statuses_url":"https://api.github.com/repos/amethyst/laminar/statuses/0138f89821139ba403831240aff884c2d81ac805","head":{"label":"BourgondAries:dos","ref":"dos","sha":"0138f89821139ba403831240aff884c2d81ac805","user":{"login":"BourgondAries","id":4683721,"node_id":"MDQ6VXNlcjQ2ODM3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4683721?v=4","gravatar_id":"","url":"https://api.github.com/users/BourgondAries","html_url":"https://github.com/BourgondAries","followers_url":"https://api.github.com/users/BourgondAries/followers","following_url":"https://api.github.com/users/BourgondAries/following{/other_user}","gists_url":"https://api.github.com/users/BourgondAries/gists{/gist_id}","starred_url":"https://api.github.com/users/BourgondAries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BourgondAries/subscriptions","organizations_url":"https://api.github.com/users/BourgondAries/orgs","repos_url":"https://api.github.com/users/BourgondAries/repos","events_url":"https://api.github.com/users/BourgondAries/events{/privacy}","received_events_url":"https://api.github.com/users/BourgondAries/received_events","type":"User","site_admin":false},"repo":{"id":191803953,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE4MDM5NTM=","name":"laminar","full_name":"BourgondAries/laminar","private":false,"owner":{"login":"BourgondAries","id":4683721,"node_id":"MDQ6VXNlcjQ2ODM3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4683721?v=4","gravatar_id":"","url":"https://api.github.com/users/BourgondAries","html_url":"https://github.com/BourgondAries","followers_url":"https://api.github.com/users/BourgondAries/followers","following_url":"https://api.github.com/users/BourgondAries/following{/other_user}","gists_url":"https://api.github.com/users/BourgondAries/gists{/gist_id}","starred_url":"https://api.github.com/users/BourgondAries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BourgondAries/subscriptions","organizations_url":"https://api.github.com/users/BourgondAries/orgs","repos_url":"https://api.github.com/users/BourgondAries/repos","events_url":"https://api.github.com/users/BourgondAries/events{/privacy}","received_events_url":"https://api.github.com/users/BourgondAries/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BourgondAries/laminar","description":"A simple semi-reliable UDP protocol for multiplayer games","fork":true,"url":"https://api.github.com/repos/BourgondAries/laminar","forks_url":"https://api.github.com/repos/BourgondAries/laminar/forks","keys_url":"https://api.github.com/repos/BourgondAries/laminar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BourgondAries/laminar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BourgondAries/laminar/teams","hooks_url":"https://api.github.com/repos/BourgondAries/laminar/hooks","issue_events_url":"https://api.github.com/repos/BourgondAries/laminar/issues/events{/number}","events_url":"https://api.github.com/repos/BourgondAries/laminar/events","assignees_url":"https://api.github.com/repos/BourgondAries/laminar/assignees{/user}","branches_url":"https://api.github.com/repos/BourgondAries/laminar/branches{/branch}","tags_url":"https://api.github.com/repos/BourgondAries/laminar/tags","blobs_url":"https://api.github.com/repos/BourgondAries/laminar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BourgondAries/laminar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BourgondAries/laminar/git/refs{/sha}","trees_url":"https://api.github.com/repos/BourgondAries/laminar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BourgondAries/laminar/statuses/{sha}","languages_url":"https://api.github.com/repos/BourgondAries/laminar/languages","stargazers_url":"https://api.github.com/repos/BourgondAries/laminar/stargazers","contributors_url":"https://api.github.com/repos/BourgondAries/laminar/contributors","subscribers_url":"https://api.github.com/repos/BourgondAries/laminar/subscribers","subscription_url":"https://api.github.com/repos/BourgondAries/laminar/subscription","commits_url":"https://api.github.com/repos/BourgondAries/laminar/commits{/sha}","git_commits_url":"https://api.github.com/repos/BourgondAries/laminar/git/commits{/sha}","comments_url":"https://api.github.com/repos/BourgondAries/laminar/comments{/number}","issue_comment_url":"https://api.github.com/repos/BourgondAries/laminar/issues/comments{/number}","contents_url":"https://api.github.com/repos/BourgondAries/laminar/contents/{+path}","compare_url":"https://api.github.com/repos/BourgondAries/laminar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BourgondAries/laminar/merges","archive_url":"https://api.github.com/repos/BourgondAries/laminar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BourgondAries/laminar/downloads","issues_url":"https://api.github.com/repos/BourgondAries/laminar/issues{/number}","pulls_url":"https://api.github.com/repos/BourgondAries/laminar/pulls{/number}","milestones_url":"https://api.github.com/repos/BourgondAries/laminar/milestones{/number}","notifications_url":"https://api.github.com/repos/BourgondAries/laminar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BourgondAries/laminar/labels{/name}","releases_url":"https://api.github.com/repos/BourgondAries/laminar/releases{/id}","deployments_url":"https://api.github.com/repos/BourgondAries/laminar/deployments","created_at":"2019-06-13T17:14:18Z","updated_at":"2019-06-14T06:54:12Z","pushed_at":"2019-06-15T19:01:43Z","git_url":"git://github.com/BourgondAries/laminar.git","ssh_url":"git@github.com:BourgondAries/laminar.git","clone_url":"https://github.com/BourgondAries/laminar.git","svn_url":"https://github.com/BourgondAries/laminar","homepage":"","size":9221,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amethyst:master","ref":"master","sha":"1a835ff244e1466794136a2c3c1a899c223182e5","user":{"login":"amethyst","id":17814736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODE0NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/17814736?v=4","gravatar_id":"","url":"https://api.github.com/users/amethyst","html_url":"https://github.com/amethyst","followers_url":"https://api.github.com/users/amethyst/followers","following_url":"https://api.github.com/users/amethyst/following{/other_user}","gists_url":"https://api.github.com/users/amethyst/gists{/gist_id}","starred_url":"https://api.github.com/users/amethyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amethyst/subscriptions","organizations_url":"https://api.github.com/users/amethyst/orgs","repos_url":"https://api.github.com/users/amethyst/repos","events_url":"https://api.github.com/users/amethyst/events{/privacy}","received_events_url":"https://api.github.com/users/amethyst/received_events","type":"Organization","site_admin":false},"repo":{"id":151304692,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEzMDQ2OTI=","name":"laminar","full_name":"amethyst/laminar","private":false,"owner":{"login":"amethyst","id":17814736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODE0NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/17814736?v=4","gravatar_id":"","url":"https://api.github.com/users/amethyst","html_url":"https://github.com/amethyst","followers_url":"https://api.github.com/users/amethyst/followers","following_url":"https://api.github.com/users/amethyst/following{/other_user}","gists_url":"https://api.github.com/users/amethyst/gists{/gist_id}","starred_url":"https://api.github.com/users/amethyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amethyst/subscriptions","organizations_url":"https://api.github.com/users/amethyst/orgs","repos_url":"https://api.github.com/users/amethyst/repos","events_url":"https://api.github.com/users/amethyst/events{/privacy}","received_events_url":"https://api.github.com/users/amethyst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/amethyst/laminar","description":"A simple semi-reliable UDP protocol for multiplayer games","fork":false,"url":"https://api.github.com/repos/amethyst/laminar","forks_url":"https://api.github.com/repos/amethyst/laminar/forks","keys_url":"https://api.github.com/repos/amethyst/laminar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amethyst/laminar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amethyst/laminar/teams","hooks_url":"https://api.github.com/repos/amethyst/laminar/hooks","issue_events_url":"https://api.github.com/repos/amethyst/laminar/issues/events{/number}","events_url":"https://api.github.com/repos/amethyst/laminar/events","assignees_url":"https://api.github.com/repos/amethyst/laminar/assignees{/user}","branches_url":"https://api.github.com/repos/amethyst/laminar/branches{/branch}","tags_url":"https://api.github.com/repos/amethyst/laminar/tags","blobs_url":"https://api.github.com/repos/amethyst/laminar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amethyst/laminar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amethyst/laminar/git/refs{/sha}","trees_url":"https://api.github.com/repos/amethyst/laminar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amethyst/laminar/statuses/{sha}","languages_url":"https://api.github.com/repos/amethyst/laminar/languages","stargazers_url":"https://api.github.com/repos/amethyst/laminar/stargazers","contributors_url":"https://api.github.com/repos/amethyst/laminar/contributors","subscribers_url":"https://api.github.com/repos/amethyst/laminar/subscribers","subscription_url":"https://api.github.com/repos/amethyst/laminar/subscription","commits_url":"https://api.github.com/repos/amethyst/laminar/commits{/sha}","git_commits_url":"https://api.github.com/repos/amethyst/laminar/git/commits{/sha}","comments_url":"https://api.github.com/repos/amethyst/laminar/comments{/number}","issue_comment_url":"https://api.github.com/repos/amethyst/laminar/issues/comments{/number}","contents_url":"https://api.github.com/repos/amethyst/laminar/contents/{+path}","compare_url":"https://api.github.com/repos/amethyst/laminar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amethyst/laminar/merges","archive_url":"https://api.github.com/repos/amethyst/laminar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amethyst/laminar/downloads","issues_url":"https://api.github.com/repos/amethyst/laminar/issues{/number}","pulls_url":"https://api.github.com/repos/amethyst/laminar/pulls{/number}","milestones_url":"https://api.github.com/repos/amethyst/laminar/milestones{/number}","notifications_url":"https://api.github.com/repos/amethyst/laminar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amethyst/laminar/labels{/name}","releases_url":"https://api.github.com/repos/amethyst/laminar/releases{/id}","deployments_url":"https://api.github.com/repos/amethyst/laminar/deployments","created_at":"2018-10-02T18:38:49Z","updated_at":"2019-06-15T03:55:58Z","pushed_at":"2019-06-15T19:01:45Z","git_url":"git://github.com/amethyst/laminar.git","ssh_url":"git@github.com:amethyst/laminar.git","clone_url":"https://github.com/amethyst/laminar.git","svn_url":"https://github.com/amethyst/laminar","homepage":"","size":9213,"stargazers_count":217,"watchers_count":217,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":25,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amethyst/laminar/pulls/194"},"html":{"href":"https://github.com/amethyst/laminar/pull/194"},"issue":{"href":"https://api.github.com/repos/amethyst/laminar/issues/194"},"comments":{"href":"https://api.github.com/repos/amethyst/laminar/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/amethyst/laminar/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/amethyst/laminar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amethyst/laminar/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/amethyst/laminar/statuses/0138f89821139ba403831240aff884c2d81ac805"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"BourgondAries"}}