{"action":"created","comment":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/359721963","pull_request_review_id":334452251,"id":359721963,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTcyMTk2Mw==","diff_hunk":"@@ -143,7 +140,7 @@ if (MINGW)\n             DESTINATION bin)\n       endif (Qt5Widgets_VERSION VERSION_GREATER_EQUAL \"5.12.4\")\n       install( FILES\n-         ${DEPENDENCIES_DIR}/portaudio.dll RENAME libportaudio-x86_64-w64-mingw32.static.dll\n+         ${DEPENDENCIES_DIR}/portaudio.dll","path":"main/CMakeLists.txt","position":28,"original_position":28,"commit_id":"9a995f70e836fcf00a0d5243c1782472a298506a","original_commit_id":"9a995f70e836fcf00a0d5243c1782472a298506a","user":{"login":"Jojo-Schmitz","id":1786669,"node_id":"MDQ6VXNlcjE3ODY2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1786669?v=4","gravatar_id":"","url":"https://api.github.com/users/Jojo-Schmitz","html_url":"https://github.com/Jojo-Schmitz","followers_url":"https://api.github.com/users/Jojo-Schmitz/followers","following_url":"https://api.github.com/users/Jojo-Schmitz/following{/other_user}","gists_url":"https://api.github.com/users/Jojo-Schmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/Jojo-Schmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jojo-Schmitz/subscriptions","organizations_url":"https://api.github.com/users/Jojo-Schmitz/orgs","repos_url":"https://api.github.com/users/Jojo-Schmitz/repos","events_url":"https://api.github.com/users/Jojo-Schmitz/events{/privacy}","received_events_url":"https://api.github.com/users/Jojo-Schmitz/received_events","type":"User","site_admin":false},"body":"This one is part of #5457","created_at":"2019-12-19T07:42:07Z","updated_at":"2019-12-19T07:42:07Z","html_url":"https://github.com/musescore/MuseScore/pull/5541#discussion_r359721963","pull_request_url":"https://api.github.com/repos/musescore/MuseScore/pulls/5541","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/359721963"},"html":{"href":"https://github.com/musescore/MuseScore/pull/5541#discussion_r359721963"},"pull_request":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5541"}}},"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/5541","id":354810660,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0ODEwNjYw","html_url":"https://github.com/musescore/MuseScore/pull/5541","diff_url":"https://github.com/musescore/MuseScore/pull/5541.diff","patch_url":"https://github.com/musescore/MuseScore/pull/5541.patch","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/5541","number":5541,"state":"open","locked":false,"title":"fix MinGW build and simplify resfile.o generation","user":{"login":"AntonioBL","id":2855332,"node_id":"MDQ6VXNlcjI4NTUzMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2855332?v=4","gravatar_id":"","url":"https://api.github.com/users/AntonioBL","html_url":"https://github.com/AntonioBL","followers_url":"https://api.github.com/users/AntonioBL/followers","following_url":"https://api.github.com/users/AntonioBL/following{/other_user}","gists_url":"https://api.github.com/users/AntonioBL/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonioBL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonioBL/subscriptions","organizations_url":"https://api.github.com/users/AntonioBL/orgs","repos_url":"https://api.github.com/users/AntonioBL/repos","events_url":"https://api.github.com/users/AntonioBL/events{/privacy}","received_events_url":"https://api.github.com/users/AntonioBL/received_events","type":"User","site_admin":false},"body":"The MinGW build was not linking because of the order in which the Qt libraries were appearing at link time.\r\nThe simplification of resfile.o generation cleans up some very old code and should also allow cross-compilation for Windows under Linux (e.g. with MXE).\r\n\r\n- [x] I signed [CLA](https://musescore.org/en/cla)\r\n- [x] I made sure the code in the PR follows [the coding rules](https://musescore.org/en/handbook/developers-handbook/finding-your-way-around/musescore-coding-rules)\r\n- [x] I made sure the code compiles on my machine\r\n- [x] I made sure there are no unnecessary changes in the code\r\n- [x] I made sure the title of the PR reflects the core meaning of the issue you are solving\r\n- [x] I made sure the commit message(s) contain a description and answer the question \"Why do those changes fix that particular issue?\" or \"Why are those changes really necessary as improvements?\"\r\n- [N/A] I made sure the commit message title starts with \"fix #424242:\" if there is a related issue\r\n- [N/A] I created the test (mtest, vtest, script test) to verify the changes I made\r\n","created_at":"2019-12-18T20:47:43Z","updated_at":"2019-12-19T07:42:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7cfce41f50137157866907b6a590384cc180b55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/musescore/MuseScore/pulls/5541/commits","review_comments_url":"https://api.github.com/repos/musescore/MuseScore/pulls/5541/comments","review_comment_url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/5541/comments","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/9a995f70e836fcf00a0d5243c1782472a298506a","head":{"label":"AntonioBL:mingwbuild","ref":"mingwbuild","sha":"9a995f70e836fcf00a0d5243c1782472a298506a","user":{"login":"AntonioBL","id":2855332,"node_id":"MDQ6VXNlcjI4NTUzMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2855332?v=4","gravatar_id":"","url":"https://api.github.com/users/AntonioBL","html_url":"https://github.com/AntonioBL","followers_url":"https://api.github.com/users/AntonioBL/followers","following_url":"https://api.github.com/users/AntonioBL/following{/other_user}","gists_url":"https://api.github.com/users/AntonioBL/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonioBL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonioBL/subscriptions","organizations_url":"https://api.github.com/users/AntonioBL/orgs","repos_url":"https://api.github.com/users/AntonioBL/repos","events_url":"https://api.github.com/users/AntonioBL/events{/privacy}","received_events_url":"https://api.github.com/users/AntonioBL/received_events","type":"User","site_admin":false},"repo":{"id":6799176,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzk5MTc2","name":"MuseScore","full_name":"AntonioBL/MuseScore","private":false,"owner":{"login":"AntonioBL","id":2855332,"node_id":"MDQ6VXNlcjI4NTUzMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/2855332?v=4","gravatar_id":"","url":"https://api.github.com/users/AntonioBL","html_url":"https://github.com/AntonioBL","followers_url":"https://api.github.com/users/AntonioBL/followers","following_url":"https://api.github.com/users/AntonioBL/following{/other_user}","gists_url":"https://api.github.com/users/AntonioBL/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonioBL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonioBL/subscriptions","organizations_url":"https://api.github.com/users/AntonioBL/orgs","repos_url":"https://api.github.com/users/AntonioBL/repos","events_url":"https://api.github.com/users/AntonioBL/events{/privacy}","received_events_url":"https://api.github.com/users/AntonioBL/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AntonioBL/MuseScore","description":"MuseScore is a free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":true,"url":"https://api.github.com/repos/AntonioBL/MuseScore","forks_url":"https://api.github.com/repos/AntonioBL/MuseScore/forks","keys_url":"https://api.github.com/repos/AntonioBL/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AntonioBL/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AntonioBL/MuseScore/teams","hooks_url":"https://api.github.com/repos/AntonioBL/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/AntonioBL/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/AntonioBL/MuseScore/events","assignees_url":"https://api.github.com/repos/AntonioBL/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/AntonioBL/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/AntonioBL/MuseScore/tags","blobs_url":"https://api.github.com/repos/AntonioBL/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AntonioBL/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AntonioBL/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/AntonioBL/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AntonioBL/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/AntonioBL/MuseScore/languages","stargazers_url":"https://api.github.com/repos/AntonioBL/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/AntonioBL/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/AntonioBL/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/AntonioBL/MuseScore/subscription","commits_url":"https://api.github.com/repos/AntonioBL/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/AntonioBL/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/AntonioBL/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/AntonioBL/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/AntonioBL/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/AntonioBL/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AntonioBL/MuseScore/merges","archive_url":"https://api.github.com/repos/AntonioBL/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AntonioBL/MuseScore/downloads","issues_url":"https://api.github.com/repos/AntonioBL/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/AntonioBL/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/AntonioBL/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/AntonioBL/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AntonioBL/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/AntonioBL/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/AntonioBL/MuseScore/deployments","created_at":"2012-11-21T16:40:50Z","updated_at":"2019-12-18T20:41:46Z","pushed_at":"2019-12-18T20:41:48Z","git_url":"git://github.com/AntonioBL/MuseScore.git","ssh_url":"git@github.com:AntonioBL/MuseScore.git","clone_url":"https://github.com/AntonioBL/MuseScore.git","svn_url":"https://github.com/AntonioBL/MuseScore","homepage":"http://musescore.org","size":337474,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"musescore:master","ref":"master","sha":"a5de0cec8b594611ff1a9c0c760a0e345673fc73","user":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"repo":{"id":4454793,"node_id":"MDEwOlJlcG9zaXRvcnk0NDU0Nzkz","name":"MuseScore","full_name":"musescore/MuseScore","private":false,"owner":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/musescore/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":false,"url":"https://api.github.com/repos/musescore/MuseScore","forks_url":"https://api.github.com/repos/musescore/MuseScore/forks","keys_url":"https://api.github.com/repos/musescore/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musescore/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musescore/MuseScore/teams","hooks_url":"https://api.github.com/repos/musescore/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/musescore/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/musescore/MuseScore/events","assignees_url":"https://api.github.com/repos/musescore/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/musescore/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/musescore/MuseScore/tags","blobs_url":"https://api.github.com/repos/musescore/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musescore/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musescore/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/musescore/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/musescore/MuseScore/languages","stargazers_url":"https://api.github.com/repos/musescore/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/musescore/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/musescore/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/musescore/MuseScore/subscription","commits_url":"https://api.github.com/repos/musescore/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/musescore/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/musescore/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/musescore/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/musescore/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/musescore/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musescore/MuseScore/merges","archive_url":"https://api.github.com/repos/musescore/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musescore/MuseScore/downloads","issues_url":"https://api.github.com/repos/musescore/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/musescore/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/musescore/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/musescore/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musescore/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/musescore/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/musescore/MuseScore/deployments","created_at":"2012-05-26T12:46:33Z","updated_at":"2019-12-18T17:32:57Z","pushed_at":"2019-12-18T20:47:44Z","git_url":"git://github.com/musescore/MuseScore.git","ssh_url":"git@github.com:musescore/MuseScore.git","clone_url":"https://github.com/musescore/MuseScore.git","svn_url":"https://github.com/musescore/MuseScore","homepage":"https://musescore.org","size":399022,"stargazers_count":4195,"watchers_count":4195,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1300,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":191,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1300,"open_issues":191,"watchers":4195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5541"},"html":{"href":"https://github.com/musescore/MuseScore/pull/5541"},"issue":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/5541"},"comments":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/5541/comments"},"review_comments":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5541/comments"},"review_comment":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/5541/commits"},"statuses":{"href":"https://api.github.com/repos/musescore/MuseScore/statuses/9a995f70e836fcf00a0d5243c1782472a298506a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Jojo-Schmitz"}}