{"action":"created","comment":{"url":"https://api.github.com/repos/rchain/rchain/pulls/comments/267129063","pull_request_review_id":216458942,"id":267129063,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzEyOTA2Mw==","diff_hunk":"@@ -106,14 +106,15 @@ sealed abstract class MetricsInstances {\n \n       //todo make this sleeker\n       def span(source: Metrics.Source): EitherT[F, E, Span[EitherT[F, E, ?]]] = {\n-        val fSpan: F[Span[F]] = evF.span(source)\n-        val temp: Span[EitherT[F, E, ?]] = new Span[EitherT[F, E, ?]] {\n-          def mark(name: String): EitherT[F, E, Unit] =\n-            EitherT.liftF(fSpan.flatMap(_.mark(name)))\n-          def close(): EitherT[F, E, Unit] = EitherT.liftF(fSpan.flatMap(s => s.close()))\n+        val fSpan = evF.span(source).map { s =>\n+          new Span[EitherT[F, E, ?]] {\n+            def mark(name: String): EitherT[F, E, Unit] =\n+              EitherT.liftF(s.mark(name))\n+            def close(): EitherT[F, E, Unit] = EitherT.liftF(s.close())\n+          }\n         }\n \n-        EitherT.liftF(temp.pure[F])\n+        EitherT.liftF(fSpan)","path":"shared/src/main/scala/coop/rchain/metrics/Metrics.scala","position":18,"original_position":18,"commit_id":"4bee8d62f9c723d8890e88b68f4fa465983f55b5","original_commit_id":"4bee8d62f9c723d8890e88b68f4fa465983f55b5","user":{"login":"ArturGajowy","id":460141,"node_id":"MDQ6VXNlcjQ2MDE0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460141?v=4","gravatar_id":"","url":"https://api.github.com/users/ArturGajowy","html_url":"https://github.com/ArturGajowy","followers_url":"https://api.github.com/users/ArturGajowy/followers","following_url":"https://api.github.com/users/ArturGajowy/following{/other_user}","gists_url":"https://api.github.com/users/ArturGajowy/gists{/gist_id}","starred_url":"https://api.github.com/users/ArturGajowy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArturGajowy/subscriptions","organizations_url":"https://api.github.com/users/ArturGajowy/orgs","repos_url":"https://api.github.com/users/ArturGajowy/repos","events_url":"https://api.github.com/users/ArturGajowy/events{/privacy}","received_events_url":"https://api.github.com/users/ArturGajowy/received_events","type":"User","site_admin":false},"body":".pure FTW :joy: ","created_at":"2019-03-19T22:52:37Z","updated_at":"2019-03-19T22:52:42Z","html_url":"https://github.com/rchain/rchain/pull/2282#discussion_r267129063","pull_request_url":"https://api.github.com/repos/rchain/rchain/pulls/2282","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments/267129063"},"html":{"href":"https://github.com/rchain/rchain/pull/2282#discussion_r267129063"},"pull_request":{"href":"https://api.github.com/repos/rchain/rchain/pulls/2282"}}},"pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/2282","id":262397318,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyMzk3MzE4","html_url":"https://github.com/rchain/rchain/pull/2282","diff_url":"https://github.com/rchain/rchain/pull/2282.diff","patch_url":"https://github.com/rchain/rchain/pull/2282.patch","issue_url":"https://api.github.com/repos/rchain/rchain/issues/2282","number":2282,"state":"open","locked":false,"title":"Fix EitherT Metrics Span instance","user":{"login":"dzajkowski","id":1588718,"node_id":"MDQ6VXNlcjE1ODg3MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1588718?v=4","gravatar_id":"","url":"https://api.github.com/users/dzajkowski","html_url":"https://github.com/dzajkowski","followers_url":"https://api.github.com/users/dzajkowski/followers","following_url":"https://api.github.com/users/dzajkowski/following{/other_user}","gists_url":"https://api.github.com/users/dzajkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/dzajkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzajkowski/subscriptions","organizations_url":"https://api.github.com/users/dzajkowski/orgs","repos_url":"https://api.github.com/users/dzajkowski/repos","events_url":"https://api.github.com/users/dzajkowski/events{/privacy}","received_events_url":"https://api.github.com/users/dzajkowski/received_events","type":"User","site_admin":false},"body":"## Overview\r\n<sup>_What this PR does, and why it's needed_</sup>\r\ntitle says it all\r\n\r\n\r\n### JIRA ticket:\r\n<sup>_Create it if there isn't one already._</sup>\r\nNo ticket\r\n\r\n\r\n### Notes\r\n<sup>_Optional. Add any notes on caveats, approaches you tried that didn't work, or anything else._</sup>\r\n\r\n\r\n\r\n### Please make sure that this PR:\r\n- [x] is at most 200 lines of code (excluding tests),\r\n- [x] meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards),\r\n- [x] includes tests for all added features,\r\n- [x] has a reviewer assigned,\r\n- [x] has [all commits signed](https://rchain.atlassian.net/wiki/spaces/DOC/pages/498630673/How+to+sign+commits+to+rchain+rchain).\r\n\r\n### [Bors](https://bors.tech/) cheat-sheet:\r\n\r\n- `bors r+` runs integration tests and merges the PR (if it's approved),\r\n- `bors try` runs integration tests for the PR,\r\n- `bors delegate+` enables non-maintainer PR authors to run the above.\r\n","created_at":"2019-03-19T10:36:14Z","updated_at":"2019-03-19T22:52:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5114818dfafc672b42a9cbd805f6441941df221","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rabbitonweb","id":6287558,"node_id":"MDQ6VXNlcjYyODc1NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6287558?v=4","gravatar_id":"","url":"https://api.github.com/users/rabbitonweb","html_url":"https://github.com/rabbitonweb","followers_url":"https://api.github.com/users/rabbitonweb/followers","following_url":"https://api.github.com/users/rabbitonweb/following{/other_user}","gists_url":"https://api.github.com/users/rabbitonweb/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitonweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitonweb/subscriptions","organizations_url":"https://api.github.com/users/rabbitonweb/orgs","repos_url":"https://api.github.com/users/rabbitonweb/repos","events_url":"https://api.github.com/users/rabbitonweb/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitonweb/received_events","type":"User","site_admin":false},{"login":"sebtomba","id":6872800,"node_id":"MDQ6VXNlcjY4NzI4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/6872800?v=4","gravatar_id":"","url":"https://api.github.com/users/sebtomba","html_url":"https://github.com/sebtomba","followers_url":"https://api.github.com/users/sebtomba/followers","following_url":"https://api.github.com/users/sebtomba/following{/other_user}","gists_url":"https://api.github.com/users/sebtomba/gists{/gist_id}","starred_url":"https://api.github.com/users/sebtomba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebtomba/subscriptions","organizations_url":"https://api.github.com/users/sebtomba/orgs","repos_url":"https://api.github.com/users/sebtomba/repos","events_url":"https://api.github.com/users/sebtomba/events{/privacy}","received_events_url":"https://api.github.com/users/sebtomba/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rchain/rchain/pulls/2282/commits","review_comments_url":"https://api.github.com/repos/rchain/rchain/pulls/2282/comments","review_comment_url":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/2282/comments","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/4bee8d62f9c723d8890e88b68f4fa465983f55b5","head":{"label":"dzajkowski:metrics/fix-span-eithert-lift","ref":"metrics/fix-span-eithert-lift","sha":"4bee8d62f9c723d8890e88b68f4fa465983f55b5","user":{"login":"dzajkowski","id":1588718,"node_id":"MDQ6VXNlcjE1ODg3MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1588718?v=4","gravatar_id":"","url":"https://api.github.com/users/dzajkowski","html_url":"https://github.com/dzajkowski","followers_url":"https://api.github.com/users/dzajkowski/followers","following_url":"https://api.github.com/users/dzajkowski/following{/other_user}","gists_url":"https://api.github.com/users/dzajkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/dzajkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzajkowski/subscriptions","organizations_url":"https://api.github.com/users/dzajkowski/orgs","repos_url":"https://api.github.com/users/dzajkowski/repos","events_url":"https://api.github.com/users/dzajkowski/events{/privacy}","received_events_url":"https://api.github.com/users/dzajkowski/received_events","type":"User","site_admin":false},"repo":{"id":134190120,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQxOTAxMjA=","name":"rchain","full_name":"dzajkowski/rchain","private":false,"owner":{"login":"dzajkowski","id":1588718,"node_id":"MDQ6VXNlcjE1ODg3MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1588718?v=4","gravatar_id":"","url":"https://api.github.com/users/dzajkowski","html_url":"https://github.com/dzajkowski","followers_url":"https://api.github.com/users/dzajkowski/followers","following_url":"https://api.github.com/users/dzajkowski/following{/other_user}","gists_url":"https://api.github.com/users/dzajkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/dzajkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzajkowski/subscriptions","organizations_url":"https://api.github.com/users/dzajkowski/orgs","repos_url":"https://api.github.com/users/dzajkowski/repos","events_url":"https://api.github.com/users/dzajkowski/events{/privacy}","received_events_url":"https://api.github.com/users/dzajkowski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dzajkowski/rchain","description":null,"fork":true,"url":"https://api.github.com/repos/dzajkowski/rchain","forks_url":"https://api.github.com/repos/dzajkowski/rchain/forks","keys_url":"https://api.github.com/repos/dzajkowski/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzajkowski/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzajkowski/rchain/teams","hooks_url":"https://api.github.com/repos/dzajkowski/rchain/hooks","issue_events_url":"https://api.github.com/repos/dzajkowski/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/dzajkowski/rchain/events","assignees_url":"https://api.github.com/repos/dzajkowski/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/dzajkowski/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/dzajkowski/rchain/tags","blobs_url":"https://api.github.com/repos/dzajkowski/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzajkowski/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzajkowski/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzajkowski/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzajkowski/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/dzajkowski/rchain/languages","stargazers_url":"https://api.github.com/repos/dzajkowski/rchain/stargazers","contributors_url":"https://api.github.com/repos/dzajkowski/rchain/contributors","subscribers_url":"https://api.github.com/repos/dzajkowski/rchain/subscribers","subscription_url":"https://api.github.com/repos/dzajkowski/rchain/subscription","commits_url":"https://api.github.com/repos/dzajkowski/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzajkowski/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzajkowski/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzajkowski/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzajkowski/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/dzajkowski/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzajkowski/rchain/merges","archive_url":"https://api.github.com/repos/dzajkowski/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzajkowski/rchain/downloads","issues_url":"https://api.github.com/repos/dzajkowski/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/dzajkowski/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/dzajkowski/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/dzajkowski/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzajkowski/rchain/labels{/name}","releases_url":"https://api.github.com/repos/dzajkowski/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/dzajkowski/rchain/deployments","created_at":"2018-05-20T21:56:38Z","updated_at":"2018-05-20T21:56:42Z","pushed_at":"2019-03-19T21:47:50Z","git_url":"git://github.com/dzajkowski/rchain.git","ssh_url":"git@github.com:dzajkowski/rchain.git","clone_url":"https://github.com/dzajkowski/rchain.git","svn_url":"https://github.com/dzajkowski/rchain","homepage":null,"size":24151,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"rchain:dev","ref":"dev","sha":"e24765df16a3d8afdd46c0bfe6757882d0946d03","user":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"repo":{"id":84493691,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ5MzY5MQ==","name":"rchain","full_name":"rchain/rchain","private":false,"owner":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rchain/rchain","description":null,"fork":false,"url":"https://api.github.com/repos/rchain/rchain","forks_url":"https://api.github.com/repos/rchain/rchain/forks","keys_url":"https://api.github.com/repos/rchain/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchain/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchain/rchain/teams","hooks_url":"https://api.github.com/repos/rchain/rchain/hooks","issue_events_url":"https://api.github.com/repos/rchain/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/rchain/rchain/events","assignees_url":"https://api.github.com/repos/rchain/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/rchain/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/rchain/rchain/tags","blobs_url":"https://api.github.com/repos/rchain/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchain/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchain/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchain/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/rchain/rchain/languages","stargazers_url":"https://api.github.com/repos/rchain/rchain/stargazers","contributors_url":"https://api.github.com/repos/rchain/rchain/contributors","subscribers_url":"https://api.github.com/repos/rchain/rchain/subscribers","subscription_url":"https://api.github.com/repos/rchain/rchain/subscription","commits_url":"https://api.github.com/repos/rchain/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchain/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchain/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchain/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchain/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/rchain/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchain/rchain/merges","archive_url":"https://api.github.com/repos/rchain/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchain/rchain/downloads","issues_url":"https://api.github.com/repos/rchain/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/rchain/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/rchain/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/rchain/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchain/rchain/labels{/name}","releases_url":"https://api.github.com/repos/rchain/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/rchain/rchain/deployments","created_at":"2017-03-09T22:15:35Z","updated_at":"2019-03-19T12:32:44Z","pushed_at":"2019-03-19T21:54:23Z","git_url":"git://github.com/rchain/rchain.git","ssh_url":"git@github.com:rchain/rchain.git","clone_url":"https://github.com/rchain/rchain.git","svn_url":"https://github.com/rchain/rchain","homepage":null,"size":23880,"stargazers_count":527,"watchers_count":527,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":157,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":157,"open_issues":21,"watchers":527,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/2282"},"html":{"href":"https://github.com/rchain/rchain/pull/2282"},"issue":{"href":"https://api.github.com/repos/rchain/rchain/issues/2282"},"comments":{"href":"https://api.github.com/repos/rchain/rchain/issues/2282/comments"},"review_comments":{"href":"https://api.github.com/repos/rchain/rchain/pulls/2282/comments"},"review_comment":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rchain/rchain/pulls/2282/commits"},"statuses":{"href":"https://api.github.com/repos/rchain/rchain/statuses/4bee8d62f9c723d8890e88b68f4fa465983f55b5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ArturGajowy"}}