{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79708","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79708/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79708/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79708/events","html_url":"https://github.com/kubernetes/kubernetes/pull/79708","id":463623352,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0MDY0MDM3","number":79708,"title":"Cherry pick #79035 to 1.14 (Fix HPA feedback from writing status.replicas to spec.replicas)","user":{"login":"josephburnett","id":1103629,"node_id":"MDQ6VXNlcjExMDM2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1103629?v=4","gravatar_id":"","url":"https://api.github.com/users/josephburnett","html_url":"https://github.com/josephburnett","followers_url":"https://api.github.com/users/josephburnett/followers","following_url":"https://api.github.com/users/josephburnett/following{/other_user}","gists_url":"https://api.github.com/users/josephburnett/gists{/gist_id}","starred_url":"https://api.github.com/users/josephburnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephburnett/subscriptions","organizations_url":"https://api.github.com/users/josephburnett/orgs","repos_url":"https://api.github.com/users/josephburnett/repos","events_url":"https://api.github.com/users/josephburnett/events{/privacy}","received_events_url":"https://api.github.com/users/josephburnett/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680154135,"node_id":"MDU6TGFiZWw2ODAxNTQxMzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/cherry-pick-not-approved","name":"do-not-merge/cherry-pick-not-approved","color":"e11d21","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":573014062,"node_id":"MDU6TGFiZWw1NzMwMTQwNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":404091735,"node_id":"MDU6TGFiZWw0MDQwOTE3MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false},{"id":238245616,"node_id":"MDU6TGFiZWwyMzgyNDU2MTY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/autoscaling","name":"sig/autoscaling","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-07-03T08:45:34Z","updated_at":"2019-07-03T08:46:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/79708","html_url":"https://github.com/kubernetes/kubernetes/pull/79708","diff_url":"https://github.com/kubernetes/kubernetes/pull/79708.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/79708.patch"},"body":"There are various reasons that the HPA will decide not the change the\r\ncurrent scale. Two important ones are when missing metrics might\r\nchange the direction of scaling, and when the recommended scale is\r\nwithin tolerance of the current scale.\r\n\r\nThe way that ReplicaCalculator signals it's desire to not change the\r\ncurrent scale is by returning the current scale. However the current\r\nscale is from scale.Status.Replicas and can be larger than\r\nscale.Spec.Replicas (e.g. during Deployment rollout with configured\r\nsurge). This causes a positive feedback loop because\r\nscale.Status.Replicas is written back into scale.Spec.Replicas,\r\nfurther increasing the current scale.\r\n\r\nThis PR fixes the feedback loop by plumbing the replica count from\r\nspec through horizontal.go and replica_calculator.go so the calculator\r\ncan punt with the right value.\r\n\r\n**What type of PR is this?**\r\n/kind bug\r\n\r\n**What this PR does / why we need it**:\r\n\r\nCherry pick of #79035 to fix HPA feedback from writing status.replicas to spec.replicas.\r\n\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/508001116","html_url":"https://github.com/kubernetes/kubernetes/pull/79708#issuecomment-508001116","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/79708","id":508001116,"node_id":"MDEyOklzc3VlQ29tbWVudDUwODAwMTExNg==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-07-03T08:46:01Z","updated_at":"2019-07-03T08:46:01Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/79708#\" title=\"Author self-approved\">josephburnett</a>*\nTo complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **piosz**\nYou can assign the PR to them by writing `/assign @piosz` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/controller/podautoscaler/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.14/pkg/controller/podautoscaler/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"piosz\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}