{"push_id":3878757459,"size":9,"distinct_size":0,"ref":"refs/heads/jk/test-signals","head":"6646126bcf91c7372428f1710d005cda269d3993","before":"9c9f369dac2659c6029e072aa7ae4cb3e86a7342","commits":[{"sha":"96728b223685410a252a253bd49f8ecb77f34cb1","author":{"name":"Jeff King","email":"696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net"},"message":"verify-tag: drop signal.h include\n\nThere's no reason verify-tag.c needs to include signal.h. It's already\nin git-compat-util.h, which we properly include as the first header.\nAnd there doesn't seem to be a particular reason for this include; it's\njust an artifact from the file creation in 2ae68fcb78 (Make verify-tag a\nbuiltin., 2007-07-27).\n\nLikewise verify-commit.c has the same issue, probably because it was\ncreated using verify-tag as a template in d07b00b7f3 (verify-commit:\nscriptable commit signature verification, 2014-06-23).\n\nThese includes are probably just redundant, and not hurting anything by\ncircumventing the order that git-compat-util.h tries to impose, since\nwe'll always have loaded git-compat-util by the time we get to these. So\nthis is just a cleanup, and shouldn't fix or break any platforms.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/96728b223685410a252a253bd49f8ecb77f34cb1"},{"sha":"7a06fb038ccfccb0e2a5991341b43f2586627c71","author":{"name":"Jeff King","email":"696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net"},"message":"wt-status.h: drop stdio.h include\n\nWe started including stdio.h to pick up the declaration of \"FILE\" in\nf26a001226 (Enable wt-status output to a given FILE pointer.,\n2007-09-17). But there's no need, since headers can assume that\ngit-compat-util.h has been included, which covers stdio.\n\nThis should just be redundant, and not hurting anything (like pulling in\nincludes out of order) because C files are supposed to always include\ngit-compat-util.h first. But it's worth cleaning up to model good\nbehavior.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/7a06fb038ccfccb0e2a5991341b43f2586627c71"},{"sha":"0d0e1e85aad517e46bcb341cd7081395de9c6dee","author":{"name":"Carlo Marcelo Arenas Belón","email":"a799130fe4873cad0b28326d5f5ccb2cdc6e1724@gmail.com"},"message":"xdiff: drop system includes in xutils.c\n\nAfter b46054b374 (\"xdiff: use git-compat-util\", 2019-04-11), two system\nheaders added with 6942efcfa9 (\"xdiff: load full words in the inner loop\nof xdl_hash_record\", 2012-04-06) to xutils.c are no longer needed and\ncould conflict as shown below from an OpenIndiana build:\n\nIn file included from xdiff/xinclude.h:26:0,\n                 from xdiff/xutils.c:25:\n./git-compat-util.h:4:0: warning: \"_FILE_OFFSET_BITS\" redefined\n #define _FILE_OFFSET_BITS 64\n\nIn file included from /usr/include/limits.h:37:0,\n                 from xdiff/xutils.c:23:\n/usr/include/sys/feature_tests.h:231:0: note: this is the location of the previous definition\n #define _FILE_OFFSET_BITS 32\n\nMake sure git-compat-util.h is the first header (through xinclude.h)\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/0d0e1e85aad517e46bcb341cd7081395de9c6dee"},{"sha":"29a0f9038eb050fac4b4d284c4852b82d4d401d3","author":{"name":"Carlo Marcelo Arenas Belón","email":"a799130fe4873cad0b28326d5f5ccb2cdc6e1724@gmail.com"},"message":"xdiff: remove duplicate headers from xhistogram.c\n\n8c912eea94 (\"teach --histogram to diff\", 2011-07-12) included them, but\nwere already part of xinclude.h\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/29a0f9038eb050fac4b4d284c4852b82d4d401d3"},{"sha":"81ed2b405cc6eca56fa4ab8eb1fb3efb839e353c","author":{"name":"Carlo Marcelo Arenas Belón","email":"a799130fe4873cad0b28326d5f5ccb2cdc6e1724@gmail.com"},"message":"xdiff: remove duplicate headers from xpatience.c\n\n92b7de93fb (Implement the patience diff algorithm, 2009-01-07) added them\nbut were already part of xinclude.h\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/81ed2b405cc6eca56fa4ab8eb1fb3efb839e353c"},{"sha":"0bdce88004b768a0d12f64de0b71946c444f616c","author":{"name":"Junio C Hamano","email":"a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com"},"message":"Merge branch 'jk/no-system-includes-in-dot-c'\n\nCompilation fix.\n\n* jk/no-system-includes-in-dot-c:\n  wt-status.h: drop stdio.h include\n  verify-tag: drop signal.h include","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/0bdce88004b768a0d12f64de0b71946c444f616c"},{"sha":"d163b6ae6b6e670494f8547a29eea3ad1e477e82","author":{"name":"Junio C Hamano","email":"a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com"},"message":"Merge branch 'cb/xdiff-no-system-includes-in-dot-c'\n\nCompilation fix.\n\n* cb/xdiff-no-system-includes-in-dot-c:\n  xdiff: remove duplicate headers from xpatience.c\n  xdiff: remove duplicate headers from xhistogram.c\n  xdiff: drop system includes in xutils.c","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/d163b6ae6b6e670494f8547a29eea3ad1e477e82"},{"sha":"f36d08d72e7f68f880f8c1d7646cb3809c820485","author":{"name":"Junio C Hamano","email":"a6723cc3f76163bf7adb636a73ac3b0ceb3e6b9b@pobox.com"},"message":"A few more last-minute fixes\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/f36d08d72e7f68f880f8c1d7646cb3809c820485"},{"sha":"6646126bcf91c7372428f1710d005cda269d3993","author":{"name":"Jeff King","email":"696e3fbcf235d40b6ea1ebd61c87cbea79d444e7@peff.net"},"message":"tests: factor portable signal check out of t0005\n\nIn POSIX shells, a program which exits due to a signal\ngenerally has an exit code of 128 plus the signal number.\nHowever, ksh uses 256 plus the signal number.  We've\naccounted for that in t0005, but not in other tests.  Let's\npull out the logic so we can use it elsewhere.\n\nIt would be nice for debugging if this additionally printed\nerrors to stderr, like our other test_* helpers. But we're\ngoing to need to use it in other places besides the innards\nof a test_expect block. So let's leave it as generic as\npossible.\n\nNote that we also leave the magic \"3\" for Windows out of the\ngeneric helper. This is an artifact of the way we use\nraise() to kill ourselves in test-sigchain.c, and will not\nnecessarily apply to all programs. So it's better to keep it\nout of the helper, to reduce the chance of confusing it with\na real call to exit(3).","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/6646126bcf91c7372428f1710d005cda269d3993"}]}
{"actor":{"display_login":"peff"}}