{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/quilt/pulls/comments/282503472","pull_request_review_id":235611652,"id":282503472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MjUwMzQ3Mg==","diff_hunk":"@@ -200,35 +205,38 @@ describe('useForm', () => {\n \n       wrapper.find(TextField, {label: 'title'})!.trigger('onChange', '');\n \n-      wrapper\n-        .find('button', {type: 'submit'})!\n-        .trigger('onClick', clickEvent());\n+      await wrapper.act(() => {","path":"packages/react-form/src/hooks/test/form.test.tsx","position":101,"original_position":101,"commit_id":"3175af53f95565ba6f47e5038dbd07dfa186f457","original_commit_id":"3175af53f95565ba6f47e5038dbd07dfa186f457","user":{"login":"lemonmade","id":3012583,"node_id":"MDQ6VXNlcjMwMTI1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3012583?v=4","gravatar_id":"","url":"https://api.github.com/users/lemonmade","html_url":"https://github.com/lemonmade","followers_url":"https://api.github.com/users/lemonmade/followers","following_url":"https://api.github.com/users/lemonmade/following{/other_user}","gists_url":"https://api.github.com/users/lemonmade/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonmade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonmade/subscriptions","organizations_url":"https://api.github.com/users/lemonmade/orgs","repos_url":"https://api.github.com/users/lemonmade/repos","events_url":"https://api.github.com/users/lemonmade/events{/privacy}","received_events_url":"https://api.github.com/users/lemonmade/received_events","type":"User","site_admin":false},"body":"Not awaiting anything","created_at":"2019-05-09T14:10:42Z","updated_at":"2019-05-09T14:17:36Z","html_url":"https://github.com/Shopify/quilt/pull/688#discussion_r282503472","pull_request_url":"https://api.github.com/repos/Shopify/quilt/pulls/688","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Shopify/quilt/pulls/comments/282503472"},"html":{"href":"https://github.com/Shopify/quilt/pull/688#discussion_r282503472"},"pull_request":{"href":"https://api.github.com/repos/Shopify/quilt/pulls/688"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/quilt/pulls/688","id":276328011,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2MzI4MDEx","html_url":"https://github.com/Shopify/quilt/pull/688","diff_url":"https://github.com/Shopify/quilt/pull/688.diff","patch_url":"https://github.com/Shopify/quilt/pull/688.patch","issue_url":"https://api.github.com/repos/Shopify/quilt/issues/688","number":688,"state":"open","locked":false,"title":"[WIP] React upgrade 16.9","user":{"login":"cartogram","id":462077,"node_id":"MDQ6VXNlcjQ2MjA3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/462077?v=4","gravatar_id":"","url":"https://api.github.com/users/cartogram","html_url":"https://github.com/cartogram","followers_url":"https://api.github.com/users/cartogram/followers","following_url":"https://api.github.com/users/cartogram/following{/other_user}","gists_url":"https://api.github.com/users/cartogram/gists{/gist_id}","starred_url":"https://api.github.com/users/cartogram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartogram/subscriptions","organizations_url":"https://api.github.com/users/cartogram/orgs","repos_url":"https://api.github.com/users/cartogram/repos","events_url":"https://api.github.com/users/cartogram/events{/privacy}","received_events_url":"https://api.github.com/users/cartogram/received_events","type":"User","site_admin":false},"body":"This pull closes https://github.com/Shopify/web/issues/13363 by upgrading to React@16.9.0.alpha0, this includes:\r\n\r\n- Upgrading `react` and `react-dom` (note, there are no tags for the updated types yet)\r\n- Modifying relevant parts of the `react-testing` library\r\n- Found all skipped tests waiting on this upgrade and fixed them\r\n- Removed the utility that whitelisted react errors from the console\r\n\r\n🎩 There should be no failing tests, no async-act related skipped tests and no act-related console errors.","created_at":"2019-05-06T20:47:12Z","updated_at":"2019-05-09T14:17:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2408cbb1713d711db47e581d6aac329f77b0f3e1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"michelleyschen","id":1610169,"node_id":"MDQ6VXNlcjE2MTAxNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1610169?v=4","gravatar_id":"","url":"https://api.github.com/users/michelleyschen","html_url":"https://github.com/michelleyschen","followers_url":"https://api.github.com/users/michelleyschen/followers","following_url":"https://api.github.com/users/michelleyschen/following{/other_user}","gists_url":"https://api.github.com/users/michelleyschen/gists{/gist_id}","starred_url":"https://api.github.com/users/michelleyschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michelleyschen/subscriptions","organizations_url":"https://api.github.com/users/michelleyschen/orgs","repos_url":"https://api.github.com/users/michelleyschen/repos","events_url":"https://api.github.com/users/michelleyschen/events{/privacy}","received_events_url":"https://api.github.com/users/michelleyschen/received_events","type":"User","site_admin":false},{"login":"TheMallen","id":4889856,"node_id":"MDQ6VXNlcjQ4ODk4NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4889856?v=4","gravatar_id":"","url":"https://api.github.com/users/TheMallen","html_url":"https://github.com/TheMallen","followers_url":"https://api.github.com/users/TheMallen/followers","following_url":"https://api.github.com/users/TheMallen/following{/other_user}","gists_url":"https://api.github.com/users/TheMallen/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMallen/subscriptions","organizations_url":"https://api.github.com/users/TheMallen/orgs","repos_url":"https://api.github.com/users/TheMallen/repos","events_url":"https://api.github.com/users/TheMallen/events{/privacy}","received_events_url":"https://api.github.com/users/TheMallen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/quilt/pulls/688/commits","review_comments_url":"https://api.github.com/repos/Shopify/quilt/pulls/688/comments","review_comment_url":"https://api.github.com/repos/Shopify/quilt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/quilt/issues/688/comments","statuses_url":"https://api.github.com/repos/Shopify/quilt/statuses/3175af53f95565ba6f47e5038dbd07dfa186f457","head":{"label":"Shopify:react-upgrade-16.9","ref":"react-upgrade-16.9","sha":"3175af53f95565ba6f47e5038dbd07dfa186f457","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":127035128,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwMzUxMjg=","name":"quilt","full_name":"Shopify/quilt","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/quilt","description":"A loosely related set of packages for JavaScript / TypeScript projects at Shopify","fork":false,"url":"https://api.github.com/repos/Shopify/quilt","forks_url":"https://api.github.com/repos/Shopify/quilt/forks","keys_url":"https://api.github.com/repos/Shopify/quilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/quilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/quilt/teams","hooks_url":"https://api.github.com/repos/Shopify/quilt/hooks","issue_events_url":"https://api.github.com/repos/Shopify/quilt/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/quilt/events","assignees_url":"https://api.github.com/repos/Shopify/quilt/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/quilt/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/quilt/tags","blobs_url":"https://api.github.com/repos/Shopify/quilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/quilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/quilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/quilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/quilt/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/quilt/languages","stargazers_url":"https://api.github.com/repos/Shopify/quilt/stargazers","contributors_url":"https://api.github.com/repos/Shopify/quilt/contributors","subscribers_url":"https://api.github.com/repos/Shopify/quilt/subscribers","subscription_url":"https://api.github.com/repos/Shopify/quilt/subscription","commits_url":"https://api.github.com/repos/Shopify/quilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/quilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/quilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/quilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/quilt/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/quilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/quilt/merges","archive_url":"https://api.github.com/repos/Shopify/quilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/quilt/downloads","issues_url":"https://api.github.com/repos/Shopify/quilt/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/quilt/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/quilt/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/quilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/quilt/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/quilt/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/quilt/deployments","created_at":"2018-03-27T19:20:06Z","updated_at":"2019-05-08T19:23:11Z","pushed_at":"2019-05-09T04:23:57Z","git_url":"git://github.com/Shopify/quilt.git","ssh_url":"git@github.com:Shopify/quilt.git","clone_url":"https://github.com/Shopify/quilt.git","svn_url":"https://github.com/Shopify/quilt","homepage":"","size":3671,"stargazers_count":191,"watchers_count":191,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":123,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":31,"open_issues":123,"watchers":191,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"65fd6b413598552e896edad8c8f4087a643fb342","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":127035128,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwMzUxMjg=","name":"quilt","full_name":"Shopify/quilt","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/quilt","description":"A loosely related set of packages for JavaScript / TypeScript projects at Shopify","fork":false,"url":"https://api.github.com/repos/Shopify/quilt","forks_url":"https://api.github.com/repos/Shopify/quilt/forks","keys_url":"https://api.github.com/repos/Shopify/quilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/quilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/quilt/teams","hooks_url":"https://api.github.com/repos/Shopify/quilt/hooks","issue_events_url":"https://api.github.com/repos/Shopify/quilt/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/quilt/events","assignees_url":"https://api.github.com/repos/Shopify/quilt/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/quilt/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/quilt/tags","blobs_url":"https://api.github.com/repos/Shopify/quilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/quilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/quilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/quilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/quilt/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/quilt/languages","stargazers_url":"https://api.github.com/repos/Shopify/quilt/stargazers","contributors_url":"https://api.github.com/repos/Shopify/quilt/contributors","subscribers_url":"https://api.github.com/repos/Shopify/quilt/subscribers","subscription_url":"https://api.github.com/repos/Shopify/quilt/subscription","commits_url":"https://api.github.com/repos/Shopify/quilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/quilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/quilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/quilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/quilt/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/quilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/quilt/merges","archive_url":"https://api.github.com/repos/Shopify/quilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/quilt/downloads","issues_url":"https://api.github.com/repos/Shopify/quilt/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/quilt/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/quilt/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/quilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/quilt/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/quilt/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/quilt/deployments","created_at":"2018-03-27T19:20:06Z","updated_at":"2019-05-08T19:23:11Z","pushed_at":"2019-05-09T04:23:57Z","git_url":"git://github.com/Shopify/quilt.git","ssh_url":"git@github.com:Shopify/quilt.git","clone_url":"https://github.com/Shopify/quilt.git","svn_url":"https://github.com/Shopify/quilt","homepage":"","size":3671,"stargazers_count":191,"watchers_count":191,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":123,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":31,"open_issues":123,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/quilt/pulls/688"},"html":{"href":"https://github.com/Shopify/quilt/pull/688"},"issue":{"href":"https://api.github.com/repos/Shopify/quilt/issues/688"},"comments":{"href":"https://api.github.com/repos/Shopify/quilt/issues/688/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/quilt/pulls/688/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/quilt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/quilt/pulls/688/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/quilt/statuses/3175af53f95565ba6f47e5038dbd07dfa186f457"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lemonmade"}}