{"action":"created","comment":{"url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/comments/346922500","pull_request_review_id":317750794,"id":346922500,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NjkyMjUwMA==","diff_hunk":"@@ -124,6 +151,29 @@ struct hip_copy\n     std::ptrdiff_t output_alias(const std::vector<shape>&) const { return 1; }\n };\n \n+struct hip_load_memory\n+{\n+    shape s;\n+    std::string id{};\n+\n+    template <class Self, class F>\n+    static auto reflect(Self& self, F f)\n+    {\n+        return pack(f(self.s, \"shape\"), f(self.id, \"id\"));\n+    }\n+\n+    std::string name() const { return \"hip::hip_load_memory\"; }","path":"src/targets/gpu/include/migraphx/gpu/hip.hpp","position":118,"original_position":118,"commit_id":"4629eca081aca6a39610d3e4963bf2007710408c","original_commit_id":"4629eca081aca6a39610d3e4963bf2007710408c","user":{"login":"scxiao","id":10176958,"node_id":"MDQ6VXNlcjEwMTc2OTU4","avatar_url":"https://avatars2.githubusercontent.com/u/10176958?v=4","gravatar_id":"","url":"https://api.github.com/users/scxiao","html_url":"https://github.com/scxiao","followers_url":"https://api.github.com/users/scxiao/followers","following_url":"https://api.github.com/users/scxiao/following{/other_user}","gists_url":"https://api.github.com/users/scxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/scxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scxiao/subscriptions","organizations_url":"https://api.github.com/users/scxiao/orgs","repos_url":"https://api.github.com/users/scxiao/repos","events_url":"https://api.github.com/users/scxiao/events{/privacy}","received_events_url":"https://api.github.com/users/scxiao/received_events","type":"User","site_admin":false},"body":"I prefer the name \"gpu::hip_load_memory\"","created_at":"2019-11-15T17:04:37Z","updated_at":"2019-11-15T17:19:44Z","html_url":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/pull/403#discussion_r346922500","pull_request_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/403","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/comments/346922500"},"html":{"href":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/pull/403#discussion_r346922500"},"pull_request":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/403","id":341019746,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxMDE5NzQ2","html_url":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/pull/403","diff_url":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/pull/403.diff","patch_url":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/pull/403.patch","issue_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/issues/403","number":403,"state":"open","locked":false,"title":"Add option to do offload copying automatically","user":{"login":"pfultz2","id":1306044,"node_id":"MDQ6VXNlcjEzMDYwNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1306044?v=4","gravatar_id":"","url":"https://api.github.com/users/pfultz2","html_url":"https://github.com/pfultz2","followers_url":"https://api.github.com/users/pfultz2/followers","following_url":"https://api.github.com/users/pfultz2/following{/other_user}","gists_url":"https://api.github.com/users/pfultz2/gists{/gist_id}","starred_url":"https://api.github.com/users/pfultz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfultz2/subscriptions","organizations_url":"https://api.github.com/users/pfultz2/orgs","repos_url":"https://api.github.com/users/pfultz2/repos","events_url":"https://api.github.com/users/pfultz2/events{/privacy}","received_events_url":"https://api.github.com/users/pfultz2/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-14T14:59:52Z","updated_at":"2019-11-15T17:19:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9e68a5299b6ad9a7933af162b6a2dca2e7731fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/403/commits","review_comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/403/comments","review_comment_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/issues/403/comments","statuses_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/statuses/4629eca081aca6a39610d3e4963bf2007710408c","head":{"label":"ROCmSoftwarePlatform:implicit-copy","ref":"implicit-copy","sha":"4629eca081aca6a39610d3e4963bf2007710408c","user":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":130718031,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3MTgwMzE=","name":"AMDMIGraphX","full_name":"ROCmSoftwarePlatform/AMDMIGraphX","private":false,"owner":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX","description":"AMD's graph optimization engine.","fork":false,"url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX","forks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/forks","keys_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/teams","hooks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/hooks","issue_events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/issues/events{/number}","events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/events","assignees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/assignees{/user}","branches_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/branches{/branch}","tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/tags","blobs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/statuses/{sha}","languages_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/languages","stargazers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/stargazers","contributors_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/contributors","subscribers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/subscribers","subscription_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/subscription","commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/contents/{+path}","compare_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/merges","archive_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/downloads","issues_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/issues{/number}","pulls_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls{/number}","milestones_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/milestones{/number}","notifications_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/labels{/name}","releases_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/releases{/id}","deployments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/deployments","created_at":"2018-04-23T15:29:10Z","updated_at":"2019-11-14T16:34:15Z","pushed_at":"2019-11-14T22:40:09Z","git_url":"git://github.com/ROCmSoftwarePlatform/AMDMIGraphX.git","ssh_url":"git@github.com:ROCmSoftwarePlatform/AMDMIGraphX.git","clone_url":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX.git","svn_url":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX","homepage":"https://rocmsoftwareplatform.github.io/AMDMIGraphX/doc/html/","size":5076,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":34,"watchers":14,"default_branch":"develop"}},"base":{"label":"ROCmSoftwarePlatform:develop","ref":"develop","sha":"6e6e7f3aaf8c61abc4dbd8f56b9f2e7faa7bfcd4","user":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":130718031,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3MTgwMzE=","name":"AMDMIGraphX","full_name":"ROCmSoftwarePlatform/AMDMIGraphX","private":false,"owner":{"login":"ROCmSoftwarePlatform","id":16900697,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTAwNjk3","avatar_url":"https://avatars0.githubusercontent.com/u/16900697?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCmSoftwarePlatform","html_url":"https://github.com/ROCmSoftwarePlatform","followers_url":"https://api.github.com/users/ROCmSoftwarePlatform/followers","following_url":"https://api.github.com/users/ROCmSoftwarePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ROCmSoftwarePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCmSoftwarePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCmSoftwarePlatform/subscriptions","organizations_url":"https://api.github.com/users/ROCmSoftwarePlatform/orgs","repos_url":"https://api.github.com/users/ROCmSoftwarePlatform/repos","events_url":"https://api.github.com/users/ROCmSoftwarePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ROCmSoftwarePlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX","description":"AMD's graph optimization engine.","fork":false,"url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX","forks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/forks","keys_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/teams","hooks_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/hooks","issue_events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/issues/events{/number}","events_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/events","assignees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/assignees{/user}","branches_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/branches{/branch}","tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/tags","blobs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/statuses/{sha}","languages_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/languages","stargazers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/stargazers","contributors_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/contributors","subscribers_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/subscribers","subscription_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/subscription","commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/contents/{+path}","compare_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/merges","archive_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/downloads","issues_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/issues{/number}","pulls_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls{/number}","milestones_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/milestones{/number}","notifications_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/labels{/name}","releases_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/releases{/id}","deployments_url":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/deployments","created_at":"2018-04-23T15:29:10Z","updated_at":"2019-11-14T16:34:15Z","pushed_at":"2019-11-14T22:40:09Z","git_url":"git://github.com/ROCmSoftwarePlatform/AMDMIGraphX.git","ssh_url":"git@github.com:ROCmSoftwarePlatform/AMDMIGraphX.git","clone_url":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX.git","svn_url":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX","homepage":"https://rocmsoftwareplatform.github.io/AMDMIGraphX/doc/html/","size":5076,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":34,"watchers":14,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/403"},"html":{"href":"https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/pull/403"},"issue":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/issues/403"},"comments":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/ROCmSoftwarePlatform/AMDMIGraphX/statuses/4629eca081aca6a39610d3e4963bf2007710408c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"scxiao"}}