{"action":"created","comment":{"url":"https://api.github.com/repos/ldtteam/minecolonies/pulls/comments/292432088","pull_request_review_id":248146128,"id":292432088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MjQzMjA4OA==","diff_hunk":"@@ -146,6 +149,11 @@ public boolean shouldExecute()\n                      || citizenData.getJob() == null;\n         }\n \n+        if (citizenData.getJob() instanceof AbstractJobGuard && checkForFood(citizenData) == EAT && citizen.isOkayToEat())","path":"src/main/java/com/minecolonies/coremod/entity/ai/minimal/EntityAIEatTask.java","position":22,"original_position":22,"commit_id":"dd611d0dea3268c4cdbc05efee87780026209e56","original_commit_id":"dd611d0dea3268c4cdbc05efee87780026209e56","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Avoid unnecessary if..then..else statements when returning booleans](https://app.codacy.com/app/Minecolonies/minecolonies/pullRequest?prid=3703160)","created_at":"2019-06-11T12:39:43Z","updated_at":"2019-06-11T12:39:44Z","html_url":"https://github.com/ldtteam/minecolonies/pull/3668#discussion_r292432088","pull_request_url":"https://api.github.com/repos/ldtteam/minecolonies/pulls/3668","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ldtteam/minecolonies/pulls/comments/292432088"},"html":{"href":"https://github.com/ldtteam/minecolonies/pull/3668#discussion_r292432088"},"pull_request":{"href":"https://api.github.com/repos/ldtteam/minecolonies/pulls/3668"}}},"pull_request":{"url":"https://api.github.com/repos/ldtteam/minecolonies/pulls/3668","id":287068311,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3MDY4MzEx","html_url":"https://github.com/ldtteam/minecolonies/pull/3668","diff_url":"https://github.com/ldtteam/minecolonies/pull/3668.diff","patch_url":"https://github.com/ldtteam/minecolonies/pull/3668.patch","issue_url":"https://api.github.com/repos/ldtteam/minecolonies/issues/3668","number":3668,"state":"open","locked":false,"title":"Guard rework","user":{"login":"Raycoms","id":6438347,"node_id":"MDQ6VXNlcjY0MzgzNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6438347?v=4","gravatar_id":"","url":"https://api.github.com/users/Raycoms","html_url":"https://github.com/Raycoms","followers_url":"https://api.github.com/users/Raycoms/followers","following_url":"https://api.github.com/users/Raycoms/following{/other_user}","gists_url":"https://api.github.com/users/Raycoms/gists{/gist_id}","starred_url":"https://api.github.com/users/Raycoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raycoms/subscriptions","organizations_url":"https://api.github.com/users/Raycoms/orgs","repos_url":"https://api.github.com/users/Raycoms/repos","events_url":"https://api.github.com/users/Raycoms/events{/privacy}","received_events_url":"https://api.github.com/users/Raycoms/received_events","type":"User","site_admin":false},"body":"\r\n# Changes proposed in this pull request:\r\nGuards are now smarter:\r\n- Archers don't run to their targets\r\n- Archers have farther range on high positions\r\n- Knights run away from the target to avoid getting hit when having no shield (doesn't work well against skeletons)\r\n- Balancing Knights and archers to be stronger early on but having less of an advantage for leveling\r\n- Balancing armour to be available up to any level (no max cap)\r\n- Fixing NPE with construction tape removal\r\n- Fixing food intake for guards (eat earlier)\r\n- Fix food intake for all workers (first try working chest then go to restaurant)\r\n\r\nReview please\r\n","created_at":"2019-06-11T12:36:24Z","updated_at":"2019-06-11T12:39:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3134565601eb5e53e68007bd8d8db651bec051d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ldtteam/minecolonies/pulls/3668/commits","review_comments_url":"https://api.github.com/repos/ldtteam/minecolonies/pulls/3668/comments","review_comment_url":"https://api.github.com/repos/ldtteam/minecolonies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ldtteam/minecolonies/issues/3668/comments","statuses_url":"https://api.github.com/repos/ldtteam/minecolonies/statuses/dd611d0dea3268c4cdbc05efee87780026209e56","head":{"label":"ldtteam:guard-rework","ref":"guard-rework","sha":"dd611d0dea3268c4cdbc05efee87780026209e56","user":{"login":"ldtteam","id":5167336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNjczMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/ldtteam","html_url":"https://github.com/ldtteam","followers_url":"https://api.github.com/users/ldtteam/followers","following_url":"https://api.github.com/users/ldtteam/following{/other_user}","gists_url":"https://api.github.com/users/ldtteam/gists{/gist_id}","starred_url":"https://api.github.com/users/ldtteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldtteam/subscriptions","organizations_url":"https://api.github.com/users/ldtteam/orgs","repos_url":"https://api.github.com/users/ldtteam/repos","events_url":"https://api.github.com/users/ldtteam/events{/privacy}","received_events_url":"https://api.github.com/users/ldtteam/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYxNjc2MA==","name":"minecolonies","full_name":"ldtteam/minecolonies","private":false,"owner":{"login":"ldtteam","id":5167336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNjczMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/ldtteam","html_url":"https://github.com/ldtteam","followers_url":"https://api.github.com/users/ldtteam/followers","following_url":"https://api.github.com/users/ldtteam/following{/other_user}","gists_url":"https://api.github.com/users/ldtteam/gists{/gist_id}","starred_url":"https://api.github.com/users/ldtteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldtteam/subscriptions","organizations_url":"https://api.github.com/users/ldtteam/orgs","repos_url":"https://api.github.com/users/ldtteam/repos","events_url":"https://api.github.com/users/ldtteam/events{/privacy}","received_events_url":"https://api.github.com/users/ldtteam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ldtteam/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/ldtteam/minecolonies","forks_url":"https://api.github.com/repos/ldtteam/minecolonies/forks","keys_url":"https://api.github.com/repos/ldtteam/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldtteam/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldtteam/minecolonies/teams","hooks_url":"https://api.github.com/repos/ldtteam/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/ldtteam/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/ldtteam/minecolonies/events","assignees_url":"https://api.github.com/repos/ldtteam/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/ldtteam/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/ldtteam/minecolonies/tags","blobs_url":"https://api.github.com/repos/ldtteam/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldtteam/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldtteam/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldtteam/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldtteam/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/ldtteam/minecolonies/languages","stargazers_url":"https://api.github.com/repos/ldtteam/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/ldtteam/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/ldtteam/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/ldtteam/minecolonies/subscription","commits_url":"https://api.github.com/repos/ldtteam/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldtteam/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldtteam/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldtteam/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldtteam/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/ldtteam/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldtteam/minecolonies/merges","archive_url":"https://api.github.com/repos/ldtteam/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldtteam/minecolonies/downloads","issues_url":"https://api.github.com/repos/ldtteam/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/ldtteam/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/ldtteam/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/ldtteam/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldtteam/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/ldtteam/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/ldtteam/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2019-06-11T01:43:39Z","pushed_at":"2019-06-11T12:36:24Z","git_url":"git://github.com/ldtteam/minecolonies.git","ssh_url":"git@github.com:ldtteam/minecolonies.git","clone_url":"https://github.com/ldtteam/minecolonies.git","svn_url":"https://github.com/ldtteam/minecolonies","homepage":"http://minecolonies.com/","size":75110,"stargazers_count":159,"watchers_count":159,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":171,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":107,"open_issues":171,"watchers":159,"default_branch":"version/1.12"}},"base":{"label":"ldtteam:version/1.12","ref":"version/1.12","sha":"bd2d85805993a1f31cfe0aa829bb4296cd9fe198","user":{"login":"ldtteam","id":5167336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNjczMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/ldtteam","html_url":"https://github.com/ldtteam","followers_url":"https://api.github.com/users/ldtteam/followers","following_url":"https://api.github.com/users/ldtteam/following{/other_user}","gists_url":"https://api.github.com/users/ldtteam/gists{/gist_id}","starred_url":"https://api.github.com/users/ldtteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldtteam/subscriptions","organizations_url":"https://api.github.com/users/ldtteam/orgs","repos_url":"https://api.github.com/users/ldtteam/repos","events_url":"https://api.github.com/users/ldtteam/events{/privacy}","received_events_url":"https://api.github.com/users/ldtteam/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYxNjc2MA==","name":"minecolonies","full_name":"ldtteam/minecolonies","private":false,"owner":{"login":"ldtteam","id":5167336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNjczMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5167336?v=4","gravatar_id":"","url":"https://api.github.com/users/ldtteam","html_url":"https://github.com/ldtteam","followers_url":"https://api.github.com/users/ldtteam/followers","following_url":"https://api.github.com/users/ldtteam/following{/other_user}","gists_url":"https://api.github.com/users/ldtteam/gists{/gist_id}","starred_url":"https://api.github.com/users/ldtteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldtteam/subscriptions","organizations_url":"https://api.github.com/users/ldtteam/orgs","repos_url":"https://api.github.com/users/ldtteam/repos","events_url":"https://api.github.com/users/ldtteam/events{/privacy}","received_events_url":"https://api.github.com/users/ldtteam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ldtteam/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/ldtteam/minecolonies","forks_url":"https://api.github.com/repos/ldtteam/minecolonies/forks","keys_url":"https://api.github.com/repos/ldtteam/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldtteam/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldtteam/minecolonies/teams","hooks_url":"https://api.github.com/repos/ldtteam/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/ldtteam/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/ldtteam/minecolonies/events","assignees_url":"https://api.github.com/repos/ldtteam/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/ldtteam/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/ldtteam/minecolonies/tags","blobs_url":"https://api.github.com/repos/ldtteam/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldtteam/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldtteam/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldtteam/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldtteam/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/ldtteam/minecolonies/languages","stargazers_url":"https://api.github.com/repos/ldtteam/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/ldtteam/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/ldtteam/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/ldtteam/minecolonies/subscription","commits_url":"https://api.github.com/repos/ldtteam/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldtteam/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldtteam/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldtteam/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldtteam/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/ldtteam/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldtteam/minecolonies/merges","archive_url":"https://api.github.com/repos/ldtteam/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldtteam/minecolonies/downloads","issues_url":"https://api.github.com/repos/ldtteam/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/ldtteam/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/ldtteam/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/ldtteam/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldtteam/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/ldtteam/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/ldtteam/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2019-06-11T01:43:39Z","pushed_at":"2019-06-11T12:36:24Z","git_url":"git://github.com/ldtteam/minecolonies.git","ssh_url":"git@github.com:ldtteam/minecolonies.git","clone_url":"https://github.com/ldtteam/minecolonies.git","svn_url":"https://github.com/ldtteam/minecolonies","homepage":"http://minecolonies.com/","size":75110,"stargazers_count":159,"watchers_count":159,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":171,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":107,"open_issues":171,"watchers":159,"default_branch":"version/1.12"}},"_links":{"self":{"href":"https://api.github.com/repos/ldtteam/minecolonies/pulls/3668"},"html":{"href":"https://github.com/ldtteam/minecolonies/pull/3668"},"issue":{"href":"https://api.github.com/repos/ldtteam/minecolonies/issues/3668"},"comments":{"href":"https://api.github.com/repos/ldtteam/minecolonies/issues/3668/comments"},"review_comments":{"href":"https://api.github.com/repos/ldtteam/minecolonies/pulls/3668/comments"},"review_comment":{"href":"https://api.github.com/repos/ldtteam/minecolonies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ldtteam/minecolonies/pulls/3668/commits"},"statuses":{"href":"https://api.github.com/repos/ldtteam/minecolonies/statuses/dd611d0dea3268c4cdbc05efee87780026209e56"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codacy-bot"}}