{"action":"created","issue":{"url":"https://api.github.com/repos/NeoCoast/pis2019-chat-dashboard-frontend/issues/15","repository_url":"https://api.github.com/repos/NeoCoast/pis2019-chat-dashboard-frontend","labels_url":"https://api.github.com/repos/NeoCoast/pis2019-chat-dashboard-frontend/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/NeoCoast/pis2019-chat-dashboard-frontend/issues/15/comments","events_url":"https://api.github.com/repos/NeoCoast/pis2019-chat-dashboard-frontend/issues/15/events","html_url":"https://github.com/NeoCoast/pis2019-chat-dashboard-frontend/pull/15","id":496897405,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIwMTMxOTU4","number":15,"title":"Error messages - Login & Register","user":{"login":"eb16","id":20881388,"node_id":"MDQ6VXNlcjIwODgxMzg4","avatar_url":"https://avatars0.githubusercontent.com/u/20881388?v=4","gravatar_id":"","url":"https://api.github.com/users/eb16","html_url":"https://github.com/eb16","followers_url":"https://api.github.com/users/eb16/followers","following_url":"https://api.github.com/users/eb16/following{/other_user}","gists_url":"https://api.github.com/users/eb16/gists{/gist_id}","starred_url":"https://api.github.com/users/eb16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eb16/subscriptions","organizations_url":"https://api.github.com/users/eb16/orgs","repos_url":"https://api.github.com/users/eb16/repos","events_url":"https://api.github.com/users/eb16/events{/privacy}","received_events_url":"https://api.github.com/users/eb16/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-09-23T05:10:16Z","updated_at":"2019-09-25T02:56:57Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/NeoCoast/pis2019-chat-dashboard-frontend/pulls/15","html_url":"https://github.com/NeoCoast/pis2019-chat-dashboard-frontend/pull/15","diff_url":"https://github.com/NeoCoast/pis2019-chat-dashboard-frontend/pull/15.diff","patch_url":"https://github.com/NeoCoast/pis2019-chat-dashboard-frontend/pull/15.patch"},"body":"# :wrench: Bugfixes\r\n\r\n# :recycle: Refactor\r\n\r\n## Error messages\r\n\r\n#### :link: Trello board reference:\r\n\r\n- [Mensajes de error en el dashboard y widget (ej: registro)](https://trello.com/c/G1NWkCVO)\r\n\r\n---\r\n\r\n#### :pencil2: Description:\r\n\r\nWhen the user enters wrong information, the app should display error messages. This covers validations when:\r\n\r\n-  There are invalid login credentials\r\n-  The user tries to register with an invalid email, invalid password, empty fields, or with an existing email (denied by backend).\r\n\r\nThis PR also adds a spinner while loading both register and login screens.\r\n\r\n---\r\n\r\n#### :movie_camera: Screen record:\r\n\r\n<p align=\"center\">\r\n<img src=\"https://user-images.githubusercontent.com/20881388/65402518-43e60080-dda5-11e9-91ba-d7a56c1e5857.gif\">\r\n<img src=\"https://user-images.githubusercontent.com/20881388/65402517-43e60080-dda5-11e9-8655-1fc1baa54017.gif\">\r\n<img src=\"https://user-images.githubusercontent.com/20881388/65402516-434d6a00-dda5-11e9-944c-054f0da583fe.gif\">\r\n</p>\r\n\r\n---\r\n\r\n#### :pushpin: Notes:\r\n\r\n- The base branch was taken from `origin/task/dashboard-styles` which is currently under development. All the styles that doesn't involve error messages aren't from my scope and would be derived to @fernandacanepa who's working on it.\r\n\r\n---\r\n\r\n#### :heavy_check_mark:Tasks:\r\n\r\n- Refactored and created generic custom hooks which manage form inputs.\r\n- Created custom hook that validates the data, returning an Ant format object, which is passed as prop to the `Form.item` component.\r\n- Did a helper that receives the catched error in a thunk action and returns the backend encapsulated message, which will be displayed when something fails.\r\n\r\n---\r\n"},"comment":{"url":"https://api.github.com/repos/NeoCoast/pis2019-chat-dashboard-frontend/issues/comments/534829569","html_url":"https://github.com/NeoCoast/pis2019-chat-dashboard-frontend/pull/15#issuecomment-534829569","issue_url":"https://api.github.com/repos/NeoCoast/pis2019-chat-dashboard-frontend/issues/15","id":534829569,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNDgyOTU2OQ==","user":{"login":"eb16","id":20881388,"node_id":"MDQ6VXNlcjIwODgxMzg4","avatar_url":"https://avatars0.githubusercontent.com/u/20881388?v=4","gravatar_id":"","url":"https://api.github.com/users/eb16","html_url":"https://github.com/eb16","followers_url":"https://api.github.com/users/eb16/followers","following_url":"https://api.github.com/users/eb16/following{/other_user}","gists_url":"https://api.github.com/users/eb16/gists{/gist_id}","starred_url":"https://api.github.com/users/eb16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eb16/subscriptions","organizations_url":"https://api.github.com/users/eb16/orgs","repos_url":"https://api.github.com/users/eb16/repos","events_url":"https://api.github.com/users/eb16/events{/privacy}","received_events_url":"https://api.github.com/users/eb16/received_events","type":"User","site_admin":false},"created_at":"2019-09-25T02:56:57Z","updated_at":"2019-09-25T02:56:57Z","author_association":"COLLABORATOR","body":"@guilleripa About this message:\r\n`![image](https://user-images.githubusercontent.com/20881388/65565596-b7fbe200-df26-11e9-9187-27d45841b8a5.png)`\r\n\r\nThere's an open issue in Ant repository:\r\nhttps://github.com/ant-design/ant-design/issues/18197\r\n\r\nRight now they are fixing this, and they will wait until form upgrades. By now we have to wait, there's nothing we can do I think. Have any thoughts?\r\n\r\nThis is the ToDo they've active:\r\nhttps://github.com/ant-design/ant-design/issues/9792"}}
{"actor":{"display_login":"eb16"}}