{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/aks-engine/pulls/comments/280136174","pull_request_review_id":232654406,"id":280136174,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDEzNjE3NA==","diff_hunk":"@@ -141,7 +141,7 @@ func createAgentVMASCustomScriptExtension(cs *api.ContainerService, profile *api\n \t\tvmExtension.Publisher = to.StringPtr(\"Microsoft.Azure.Extensions\")\n \t\tvmExtension.VirtualMachineExtensionProperties.Type = to.StringPtr(\"CustomScript\")\n \t\tvmExtension.TypeHandlerVersion = to.StringPtr(\"2.0\")\n-\t\tcommandExec := fmt.Sprintf(\"[concat('retrycmd_if_failure() { r=$1; w=$2; t=$3; shift && shift && shift; for i in $(seq 1 $r); do timeout $t ${@}; [ $? -eq 0  ] && break || if [ $i -eq $r ]; then return 1; else sleep $w; fi; done }; %s for i in $(seq 1 1200); do if [ -f /opt/azure/containers/provision.sh ]; then break; fi; if [ $i -eq 1200 ]; then exit 100; else sleep 1; fi; done; ', variables('provisionScriptParametersCommon'),' GPU_NODE=%s SGX_NODE=%s /usr/bin/nohup /bin/bash -c \\\"/bin/bash /opt/azure/containers/provision.sh >> /var/log/azure/cluster-provision.log 2>&1%s\\\"')]\", outBoundCmd, nVidiaEnabled, sgxEnabled, runInBackground)","path":"pkg/engine/vmextensions.go","position":13,"original_position":13,"commit_id":"dc6d98cdd93c182ccf87f78ca884cf7dbef4948d","original_commit_id":"dc6d98cdd93c182ccf87f78ca884cf7dbef4948d","user":{"login":"CecileRobertMichon","id":8650424,"node_id":"MDQ6VXNlcjg2NTA0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8650424?v=4","gravatar_id":"","url":"https://api.github.com/users/CecileRobertMichon","html_url":"https://github.com/CecileRobertMichon","followers_url":"https://api.github.com/users/CecileRobertMichon/followers","following_url":"https://api.github.com/users/CecileRobertMichon/following{/other_user}","gists_url":"https://api.github.com/users/CecileRobertMichon/gists{/gist_id}","starred_url":"https://api.github.com/users/CecileRobertMichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CecileRobertMichon/subscriptions","organizations_url":"https://api.github.com/users/CecileRobertMichon/orgs","repos_url":"https://api.github.com/users/CecileRobertMichon/repos","events_url":"https://api.github.com/users/CecileRobertMichon/events{/privacy}","received_events_url":"https://api.github.com/users/CecileRobertMichon/received_events","type":"User","site_admin":false},"body":"if we're not using `variables('provisionScriptParametersCommon')` anywhere anymore we should be able to remove it from https://github.com/Azure/aks-engine/blob/master/pkg/engine/armvariables.go","created_at":"2019-05-01T16:56:40Z","updated_at":"2019-05-01T16:56:40Z","html_url":"https://github.com/Azure/aks-engine/pull/1169#discussion_r280136174","pull_request_url":"https://api.github.com/repos/Azure/aks-engine/pulls/1169","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/comments/280136174"},"html":{"href":"https://github.com/Azure/aks-engine/pull/1169#discussion_r280136174"},"pull_request":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/1169"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/aks-engine/pulls/1169","id":274261635,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0MjYxNjM1","html_url":"https://github.com/Azure/aks-engine/pull/1169","diff_url":"https://github.com/Azure/aks-engine/pull/1169.diff","patch_url":"https://github.com/Azure/aks-engine/pull/1169.patch","issue_url":"https://api.github.com/repos/Azure/aks-engine/issues/1169","number":1169,"state":"open","locked":false,"title":"fix: USER_ASSIGNED_IDENTITY_ID is empty in azure.json","user":{"login":"norshtein","id":12193736,"node_id":"MDQ6VXNlcjEyMTkzNzM2","avatar_url":"https://avatars0.githubusercontent.com/u/12193736?v=4","gravatar_id":"","url":"https://api.github.com/users/norshtein","html_url":"https://github.com/norshtein","followers_url":"https://api.github.com/users/norshtein/followers","following_url":"https://api.github.com/users/norshtein/following{/other_user}","gists_url":"https://api.github.com/users/norshtein/gists{/gist_id}","starred_url":"https://api.github.com/users/norshtein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norshtein/subscriptions","organizations_url":"https://api.github.com/users/norshtein/orgs","repos_url":"https://api.github.com/users/norshtein/repos","events_url":"https://api.github.com/users/norshtein/events{/privacy}","received_events_url":"https://api.github.com/users/norshtein/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for helping aks-engine with a pull request!\r\nUse conventional commit messages, such as\r\n  feat: add a knob to the frobnitz\r\nor\r\n  fix: repair hole in wumpus\r\nAnd read this for faster PR reviews: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#best-practices-for-faster-reviews -->\r\n\r\n**Reason for Change**:\r\n<!-- What does this PR improve or fix in aks-engine? -->\r\nThis PR fixes #904, please refer to #904 for detailed background.\r\n\r\n**Issue Fixed**:\r\n<!-- If this PR fixes GitHub issue 1234, add \"Fixes #1234\" to the next line. -->\r\nFixes #904 \r\n\r\n**Requirements**:\r\n<!-- Put an \"X\" character inside the brackets of each completed task. Some may be optional depending on the PR. -->\r\n\r\n- [X] uses [conventional commit messages](https://www.conventionalcommits.org/)\r\n  <!-- Common commit types:\r\n        build: Build 🏭\r\n        chore: Maintenance 🔧\r\n        ci: Continuous Integration 💜\r\n        docs: Documentation 📘\r\n        feat: Features 🌈\r\n        fix: Bug Fixes 🐞\r\n        perf: Performance Improvements 🚀\r\n        refactor: Code Refactoring 💎\r\n        revert: Revert Change ◀️\r\n        style: Code Style 🎶\r\n        test: Testing 💚 -->\r\n- [ ] includes documentation\r\n- [X] adds unit tests\r\n- [ ] tested upgrade from previous version\r\n\r\n**Notes**:\r\nTo get the client id of the generated user assigned identity, we can use `reference(concat('Microsoft.ManagedIdentity/userAssignedIdentities/', variables('userAssignedID')), '2018-11-30').clientId`. But previously, in aks-engine, variables in `azure.json` are provided to provision script by a variable called `provisionScriptParametersCommon`. It is an ARM template variable, according to [ARM template manual](https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-group-template-functions-resource#reference):  \r\n> The reference function can only be used in the properties of a resource definition and the outputs section of a template or deployment.\r\n\r\nWe can't use `reference` function in the definition of a variable. So in this PR, instead of using ARM template variable, I switched to use raw string to provide parameters to provision script. The raw string is returned by a helper function `GenerateProvisionScriptParameters`. The variable `provisionScriptParametersCommon` no longer has any effect, but I keep it as a variable in case it can be used later, and also avoid breaking anything.","created_at":"2019-04-29T06:53:17Z","updated_at":"2019-05-01T16:56:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12d9b71681d14a4d56605642fbfb75fe201c8d51","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1128168964,"node_id":"MDU6TGFiZWwxMTI4MTY4OTY0","url":"https://api.github.com/repos/Azure/aks-engine/labels/size/L","name":"size/L","color":"ddc433","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/aks-engine/pulls/1169/commits","review_comments_url":"https://api.github.com/repos/Azure/aks-engine/pulls/1169/comments","review_comment_url":"https://api.github.com/repos/Azure/aks-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/aks-engine/issues/1169/comments","statuses_url":"https://api.github.com/repos/Azure/aks-engine/statuses/dc6d98cdd93c182ccf87f78ca884cf7dbef4948d","head":{"label":"norshtein:fix-user-assigned-identity-client-id-empty","ref":"fix-user-assigned-identity-client-id-empty","sha":"dc6d98cdd93c182ccf87f78ca884cf7dbef4948d","user":{"login":"norshtein","id":12193736,"node_id":"MDQ6VXNlcjEyMTkzNzM2","avatar_url":"https://avatars0.githubusercontent.com/u/12193736?v=4","gravatar_id":"","url":"https://api.github.com/users/norshtein","html_url":"https://github.com/norshtein","followers_url":"https://api.github.com/users/norshtein/followers","following_url":"https://api.github.com/users/norshtein/following{/other_user}","gists_url":"https://api.github.com/users/norshtein/gists{/gist_id}","starred_url":"https://api.github.com/users/norshtein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norshtein/subscriptions","organizations_url":"https://api.github.com/users/norshtein/orgs","repos_url":"https://api.github.com/users/norshtein/repos","events_url":"https://api.github.com/users/norshtein/events{/privacy}","received_events_url":"https://api.github.com/users/norshtein/received_events","type":"User","site_admin":false},"repo":{"id":163241726,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMyNDE3MjY=","name":"aks-engine","full_name":"norshtein/aks-engine","private":false,"owner":{"login":"norshtein","id":12193736,"node_id":"MDQ6VXNlcjEyMTkzNzM2","avatar_url":"https://avatars0.githubusercontent.com/u/12193736?v=4","gravatar_id":"","url":"https://api.github.com/users/norshtein","html_url":"https://github.com/norshtein","followers_url":"https://api.github.com/users/norshtein/followers","following_url":"https://api.github.com/users/norshtein/following{/other_user}","gists_url":"https://api.github.com/users/norshtein/gists{/gist_id}","starred_url":"https://api.github.com/users/norshtein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norshtein/subscriptions","organizations_url":"https://api.github.com/users/norshtein/orgs","repos_url":"https://api.github.com/users/norshtein/repos","events_url":"https://api.github.com/users/norshtein/events{/privacy}","received_events_url":"https://api.github.com/users/norshtein/received_events","type":"User","site_admin":false},"html_url":"https://github.com/norshtein/aks-engine","description":"AKS-Engine: Units of Kubernetes on Azure!","fork":true,"url":"https://api.github.com/repos/norshtein/aks-engine","forks_url":"https://api.github.com/repos/norshtein/aks-engine/forks","keys_url":"https://api.github.com/repos/norshtein/aks-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/norshtein/aks-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/norshtein/aks-engine/teams","hooks_url":"https://api.github.com/repos/norshtein/aks-engine/hooks","issue_events_url":"https://api.github.com/repos/norshtein/aks-engine/issues/events{/number}","events_url":"https://api.github.com/repos/norshtein/aks-engine/events","assignees_url":"https://api.github.com/repos/norshtein/aks-engine/assignees{/user}","branches_url":"https://api.github.com/repos/norshtein/aks-engine/branches{/branch}","tags_url":"https://api.github.com/repos/norshtein/aks-engine/tags","blobs_url":"https://api.github.com/repos/norshtein/aks-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/norshtein/aks-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/norshtein/aks-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/norshtein/aks-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/norshtein/aks-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/norshtein/aks-engine/languages","stargazers_url":"https://api.github.com/repos/norshtein/aks-engine/stargazers","contributors_url":"https://api.github.com/repos/norshtein/aks-engine/contributors","subscribers_url":"https://api.github.com/repos/norshtein/aks-engine/subscribers","subscription_url":"https://api.github.com/repos/norshtein/aks-engine/subscription","commits_url":"https://api.github.com/repos/norshtein/aks-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/norshtein/aks-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/norshtein/aks-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/norshtein/aks-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/norshtein/aks-engine/contents/{+path}","compare_url":"https://api.github.com/repos/norshtein/aks-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/norshtein/aks-engine/merges","archive_url":"https://api.github.com/repos/norshtein/aks-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/norshtein/aks-engine/downloads","issues_url":"https://api.github.com/repos/norshtein/aks-engine/issues{/number}","pulls_url":"https://api.github.com/repos/norshtein/aks-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/norshtein/aks-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/norshtein/aks-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/norshtein/aks-engine/labels{/name}","releases_url":"https://api.github.com/repos/norshtein/aks-engine/releases{/id}","deployments_url":"https://api.github.com/repos/norshtein/aks-engine/deployments","created_at":"2018-12-27T03:17:05Z","updated_at":"2019-04-25T06:57:34Z","pushed_at":"2019-04-30T17:41:52Z","git_url":"git://github.com/norshtein/aks-engine.git","ssh_url":"git@github.com:norshtein/aks-engine.git","clone_url":"https://github.com/norshtein/aks-engine.git","svn_url":"https://github.com/norshtein/aks-engine","homepage":"https://github.com/Azure/aks-engine","size":65109,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"55b12ea26bb2a505ad21d8575b829a4c2192adc3","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":155447233,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU0NDcyMzM=","name":"aks-engine","full_name":"Azure/aks-engine","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/aks-engine","description":"AKS Engine: Units of Kubernetes on Azure!","fork":false,"url":"https://api.github.com/repos/Azure/aks-engine","forks_url":"https://api.github.com/repos/Azure/aks-engine/forks","keys_url":"https://api.github.com/repos/Azure/aks-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/aks-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/aks-engine/teams","hooks_url":"https://api.github.com/repos/Azure/aks-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/aks-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/aks-engine/events","assignees_url":"https://api.github.com/repos/Azure/aks-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/aks-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/aks-engine/tags","blobs_url":"https://api.github.com/repos/Azure/aks-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/aks-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/aks-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/aks-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/aks-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/aks-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/aks-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/aks-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/aks-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/aks-engine/subscription","commits_url":"https://api.github.com/repos/Azure/aks-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/aks-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/aks-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/aks-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/aks-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/aks-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/aks-engine/merges","archive_url":"https://api.github.com/repos/Azure/aks-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/aks-engine/downloads","issues_url":"https://api.github.com/repos/Azure/aks-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/aks-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/aks-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/aks-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/aks-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/aks-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/aks-engine/deployments","created_at":"2018-10-30T19:50:54Z","updated_at":"2019-05-01T16:20:44Z","pushed_at":"2019-05-01T16:20:39Z","git_url":"git://github.com/Azure/aks-engine.git","ssh_url":"git@github.com:Azure/aks-engine.git","clone_url":"https://github.com/Azure/aks-engine.git","svn_url":"https://github.com/Azure/aks-engine","homepage":"https://github.com/Azure/aks-engine","size":65227,"stargazers_count":343,"watchers_count":343,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":210,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":158,"open_issues":210,"watchers":343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/1169"},"html":{"href":"https://github.com/Azure/aks-engine/pull/1169"},"issue":{"href":"https://api.github.com/repos/Azure/aks-engine/issues/1169"},"comments":{"href":"https://api.github.com/repos/Azure/aks-engine/issues/1169/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/1169/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/aks-engine/pulls/1169/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/aks-engine/statuses/dc6d98cdd93c182ccf87f78ca884cf7dbef4948d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"CecileRobertMichon"}}