{"action":"created","issue":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/1171","repository_url":"https://api.github.com/repos/openjournals/joss-reviews","labels_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/1171/labels{/name}","comments_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/1171/comments","events_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/1171/events","html_url":"https://github.com/openjournals/joss-reviews/issues/1171","id":398961034,"node_id":"MDU6SXNzdWUzOTg5NjEwMzQ=","number":1171,"title":"[REVIEW]: COSplay: Contrast Optimized Stimulation Player","user":{"login":"whedon","id":18508068,"node_id":"MDQ6VXNlcjE4NTA4MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/18508068?v=4","gravatar_id":"","url":"https://api.github.com/users/whedon","html_url":"https://github.com/whedon","followers_url":"https://api.github.com/users/whedon/followers","following_url":"https://api.github.com/users/whedon/following{/other_user}","gists_url":"https://api.github.com/users/whedon/gists{/gist_id}","starred_url":"https://api.github.com/users/whedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whedon/subscriptions","organizations_url":"https://api.github.com/users/whedon/orgs","repos_url":"https://api.github.com/users/whedon/repos","events_url":"https://api.github.com/users/whedon/events{/privacy}","received_events_url":"https://api.github.com/users/whedon/received_events","type":"User","site_admin":false},"labels":[{"id":330465313,"node_id":"MDU6TGFiZWwzMzA0NjUzMTM=","url":"https://api.github.com/repos/openjournals/joss-reviews/labels/review","name":"review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"effigies","id":83442,"node_id":"MDQ6VXNlcjgzNDQy","avatar_url":"https://avatars0.githubusercontent.com/u/83442?v=4","gravatar_id":"","url":"https://api.github.com/users/effigies","html_url":"https://github.com/effigies","followers_url":"https://api.github.com/users/effigies/followers","following_url":"https://api.github.com/users/effigies/following{/other_user}","gists_url":"https://api.github.com/users/effigies/gists{/gist_id}","starred_url":"https://api.github.com/users/effigies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effigies/subscriptions","organizations_url":"https://api.github.com/users/effigies/orgs","repos_url":"https://api.github.com/users/effigies/repos","events_url":"https://api.github.com/users/effigies/events{/privacy}","received_events_url":"https://api.github.com/users/effigies/received_events","type":"User","site_admin":false},"assignees":[{"login":"effigies","id":83442,"node_id":"MDQ6VXNlcjgzNDQy","avatar_url":"https://avatars0.githubusercontent.com/u/83442?v=4","gravatar_id":"","url":"https://api.github.com/users/effigies","html_url":"https://github.com/effigies","followers_url":"https://api.github.com/users/effigies/followers","following_url":"https://api.github.com/users/effigies/following{/other_user}","gists_url":"https://api.github.com/users/effigies/gists{/gist_id}","starred_url":"https://api.github.com/users/effigies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effigies/subscriptions","organizations_url":"https://api.github.com/users/effigies/orgs","repos_url":"https://api.github.com/users/effigies/repos","events_url":"https://api.github.com/users/effigies/events{/privacy}","received_events_url":"https://api.github.com/users/effigies/received_events","type":"User","site_admin":false},{"login":"arokem","id":118582,"node_id":"MDQ6VXNlcjExODU4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/118582?v=4","gravatar_id":"","url":"https://api.github.com/users/arokem","html_url":"https://github.com/arokem","followers_url":"https://api.github.com/users/arokem/followers","following_url":"https://api.github.com/users/arokem/following{/other_user}","gists_url":"https://api.github.com/users/arokem/gists{/gist_id}","starred_url":"https://api.github.com/users/arokem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arokem/subscriptions","organizations_url":"https://api.github.com/users/arokem/orgs","repos_url":"https://api.github.com/users/arokem/repos","events_url":"https://api.github.com/users/arokem/events{/privacy}","received_events_url":"https://api.github.com/users/arokem/received_events","type":"User","site_admin":false},{"login":"tanselbaran","id":20699311,"node_id":"MDQ6VXNlcjIwNjk5MzEx","avatar_url":"https://avatars0.githubusercontent.com/u/20699311?v=4","gravatar_id":"","url":"https://api.github.com/users/tanselbaran","html_url":"https://github.com/tanselbaran","followers_url":"https://api.github.com/users/tanselbaran/followers","following_url":"https://api.github.com/users/tanselbaran/following{/other_user}","gists_url":"https://api.github.com/users/tanselbaran/gists{/gist_id}","starred_url":"https://api.github.com/users/tanselbaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanselbaran/subscriptions","organizations_url":"https://api.github.com/users/tanselbaran/orgs","repos_url":"https://api.github.com/users/tanselbaran/repos","events_url":"https://api.github.com/users/tanselbaran/events{/privacy}","received_events_url":"https://api.github.com/users/tanselbaran/received_events","type":"User","site_admin":false}],"milestone":null,"comments":49,"created_at":"2019-01-14T16:12:50Z","updated_at":"2019-07-15T18:06:37Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Submitting author:** @TheChymera (<a href=\"http://orcid.org/0000-0001-7037-2449\">Horea-Ioan Ioanas</a>)\r\n**Repository:** <a href=\"https://github.com/IBT-FMI/COSplay/\" target =\"_blank\">https://github.com/IBT-FMI/COSplay/</a>\r\n**Version:** 1.1.1\r\n**Editor:** @arokem\r\n**Reviewers:** @effigies, @tanselbaran\r\n**Archive:** Pending\r\n\r\n## Status\r\n\r\n[![status](http://joss.theoj.org/papers/3ee7ef4edc7b537e19f89225d1d96139/status.svg)](http://joss.theoj.org/papers/3ee7ef4edc7b537e19f89225d1d96139)\r\n\r\nStatus badge code:\r\n\r\n```\r\nHTML: <a href=\"http://joss.theoj.org/papers/3ee7ef4edc7b537e19f89225d1d96139\"><img src=\"http://joss.theoj.org/papers/3ee7ef4edc7b537e19f89225d1d96139/status.svg\"></a>\r\nMarkdown: [![status](http://joss.theoj.org/papers/3ee7ef4edc7b537e19f89225d1d96139/status.svg)](http://joss.theoj.org/papers/3ee7ef4edc7b537e19f89225d1d96139)\r\n```\r\n**Reviewers and authors**:\r\n\r\nPlease avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=\"https://github.com/IBT-FMI/COSplay/\" target=\"_blank\">target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)\r\n\r\n## Reviewer instructions & questions\r\n\r\n@damaggu & @effigies, please carry out your reviews in this issue by updating the checklist below. If you cannot edit the checklist please:\r\n1. Make sure you're logged in to your GitHub account\r\n2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations\r\n\r\nThe reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arokem know.\r\n\r\n✨ **Please try and complete your review in the next two weeks** ✨ \r\n\r\n## Review checklist for @tanselbaran \r\n### Conflict of interest\r\n\r\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/IBT-FMI/COSplay/\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [x] **Version:** Does the release version given match the GitHub release (1.1.1)?\r\n- [x] **Authorship:** Has the submitting author (@TheChymera) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\r\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\r\n\r\n### Documentation\r\n\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\r\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\r\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\r\n\r\n## Review checklist for @effigies\r\n### Conflict of interest\r\n\r\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/IBT-FMI/COSplay/\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [x] **Version:** Does the release version given match the GitHub release (1.1.1)?\r\n- [x] **Authorship:** Has the submitting author (@TheChymera) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\r\n- [ ] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [ ] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\r\n\r\n### Documentation\r\n\r\n- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\r\n- [ ] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\r\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [ ] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/comments/511509067","html_url":"https://github.com/openjournals/joss-reviews/issues/1171#issuecomment-511509067","issue_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/1171","id":511509067,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMTUwOTA2Nw==","user":{"login":"TheChymera","id":950524,"node_id":"MDQ6VXNlcjk1MDUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/950524?v=4","gravatar_id":"","url":"https://api.github.com/users/TheChymera","html_url":"https://github.com/TheChymera","followers_url":"https://api.github.com/users/TheChymera/followers","following_url":"https://api.github.com/users/TheChymera/following{/other_user}","gists_url":"https://api.github.com/users/TheChymera/gists{/gist_id}","starred_url":"https://api.github.com/users/TheChymera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheChymera/subscriptions","organizations_url":"https://api.github.com/users/TheChymera/orgs","repos_url":"https://api.github.com/users/TheChymera/repos","events_url":"https://api.github.com/users/TheChymera/events{/privacy}","received_events_url":"https://api.github.com/users/TheChymera/received_events","type":"User","site_admin":false},"created_at":"2019-07-15T18:06:37Z","updated_at":"2019-07-15T18:06:37Z","author_association":"NONE","body":"@danielskatz @arokem sorry for the long delay, I too have been sidetracked by my thesis.\r\n\r\nAddressing @effigies ' open concerns: https://github.com/IBT-FMI/COSplay/commit/ba9406744637701d1d586a28551e653960d4041b\r\n\r\nAddressing @tanselbaran 's concerns: https://github.com/IBT-FMI/COSplay/commit/413c49149282bbbd39e5ea322fed492ac7aed724\r\nRegarding the question about the amplitude: it is clarified [in the first two paragraphs, here](https://github.com/IBT-FMI/COSplay/blob/master/documentation/pyboard.rst#circuit). This section was now also linked to in the README overview: https://github.com/IBT-FMI/COSplay/commit/799f50d180375c8de17abac804e5dc866f60e328 "}}
{"actor":{"display_login":"TheChymera"}}