{"action":"created","comment":{"url":"https://api.github.com/repos/dask/dask-kubernetes/pulls/comments/353679196","pull_request_review_id":326765035,"id":353679196,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzY3OTE5Ng==","diff_hunk":"@@ -393,6 +396,73 @@ def __init__(\n         self.kwargs = kwargs\n         super().__init__(**self.kwargs)\n \n+    def _clean_pod_templates(self):\n+        for pod_template, pod_type in [\n+            (self.pod_template, \"worker\"),\n+            (self.scheduler_pod_template, \"scheduler\"),\n+        ]:","path":"dask_kubernetes/core.py","position":48,"original_position":48,"commit_id":"3dd66405fabc7d8f3fb32576b5efa068ad516dc7","original_commit_id":"3dd66405fabc7d8f3fb32576b5efa068ad516dc7","user":{"login":"jacobtomlinson","id":1610850,"node_id":"MDQ6VXNlcjE2MTA4NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1610850?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobtomlinson","html_url":"https://github.com/jacobtomlinson","followers_url":"https://api.github.com/users/jacobtomlinson/followers","following_url":"https://api.github.com/users/jacobtomlinson/following{/other_user}","gists_url":"https://api.github.com/users/jacobtomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobtomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobtomlinson/subscriptions","organizations_url":"https://api.github.com/users/jacobtomlinson/orgs","repos_url":"https://api.github.com/users/jacobtomlinson/repos","events_url":"https://api.github.com/users/jacobtomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/jacobtomlinson/received_events","type":"User","site_admin":false},"body":"I think my preference would be to have it in the main `_start` function. It makes the start function clearer to read.","created_at":"2019-12-04T11:04:58Z","updated_at":"2019-12-04T11:04:58Z","html_url":"https://github.com/dask/dask-kubernetes/pull/211#discussion_r353679196","pull_request_url":"https://api.github.com/repos/dask/dask-kubernetes/pulls/211","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dask/dask-kubernetes/pulls/comments/353679196"},"html":{"href":"https://github.com/dask/dask-kubernetes/pull/211#discussion_r353679196"},"pull_request":{"href":"https://api.github.com/repos/dask/dask-kubernetes/pulls/211"}},"in_reply_to_id":353670802},"pull_request":{"url":"https://api.github.com/repos/dask/dask-kubernetes/pulls/211","id":348815001,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4ODE1MDAx","html_url":"https://github.com/dask/dask-kubernetes/pull/211","diff_url":"https://github.com/dask/dask-kubernetes/pull/211.diff","patch_url":"https://github.com/dask/dask-kubernetes/pull/211.patch","issue_url":"https://api.github.com/repos/dask/dask-kubernetes/issues/211","number":211,"state":"open","locked":false,"title":"Add optional separate scheduler deployment","user":{"login":"Timost","id":7479071,"node_id":"MDQ6VXNlcjc0NzkwNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/7479071?v=4","gravatar_id":"","url":"https://api.github.com/users/Timost","html_url":"https://github.com/Timost","followers_url":"https://api.github.com/users/Timost/followers","following_url":"https://api.github.com/users/Timost/following{/other_user}","gists_url":"https://api.github.com/users/Timost/gists{/gist_id}","starred_url":"https://api.github.com/users/Timost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Timost/subscriptions","organizations_url":"https://api.github.com/users/Timost/orgs","repos_url":"https://api.github.com/users/Timost/repos","events_url":"https://api.github.com/users/Timost/events{/privacy}","received_events_url":"https://api.github.com/users/Timost/received_events","type":"User","site_admin":false},"body":"This can be usefull when one wants to set different affinities for the\r\nscheduler and the worker pods.\r\n\r\nMy personal use case is to take advantage of premptible nodes for dask workers but keep the scheduler on a guaranteed node.\r\n\r\nAttempts to fix #208.","created_at":"2019-12-04T10:40:49Z","updated_at":"2019-12-04T11:04:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00fbf0ef18af63ddc8d421a4c9d2ca0321002db7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dask/dask-kubernetes/pulls/211/commits","review_comments_url":"https://api.github.com/repos/dask/dask-kubernetes/pulls/211/comments","review_comment_url":"https://api.github.com/repos/dask/dask-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dask/dask-kubernetes/issues/211/comments","statuses_url":"https://api.github.com/repos/dask/dask-kubernetes/statuses/3dd66405fabc7d8f3fb32576b5efa068ad516dc7","head":{"label":"Timost:separate-scheduler-deployment","ref":"separate-scheduler-deployment","sha":"3dd66405fabc7d8f3fb32576b5efa068ad516dc7","user":{"login":"Timost","id":7479071,"node_id":"MDQ6VXNlcjc0NzkwNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/7479071?v=4","gravatar_id":"","url":"https://api.github.com/users/Timost","html_url":"https://github.com/Timost","followers_url":"https://api.github.com/users/Timost/followers","following_url":"https://api.github.com/users/Timost/following{/other_user}","gists_url":"https://api.github.com/users/Timost/gists{/gist_id}","starred_url":"https://api.github.com/users/Timost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Timost/subscriptions","organizations_url":"https://api.github.com/users/Timost/orgs","repos_url":"https://api.github.com/users/Timost/repos","events_url":"https://api.github.com/users/Timost/events{/privacy}","received_events_url":"https://api.github.com/users/Timost/received_events","type":"User","site_admin":false},"repo":{"id":225396306,"node_id":"MDEwOlJlcG9zaXRvcnkyMjUzOTYzMDY=","name":"dask-kubernetes","full_name":"Timost/dask-kubernetes","private":false,"owner":{"login":"Timost","id":7479071,"node_id":"MDQ6VXNlcjc0NzkwNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/7479071?v=4","gravatar_id":"","url":"https://api.github.com/users/Timost","html_url":"https://github.com/Timost","followers_url":"https://api.github.com/users/Timost/followers","following_url":"https://api.github.com/users/Timost/following{/other_user}","gists_url":"https://api.github.com/users/Timost/gists{/gist_id}","starred_url":"https://api.github.com/users/Timost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Timost/subscriptions","organizations_url":"https://api.github.com/users/Timost/orgs","repos_url":"https://api.github.com/users/Timost/repos","events_url":"https://api.github.com/users/Timost/events{/privacy}","received_events_url":"https://api.github.com/users/Timost/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Timost/dask-kubernetes","description":"Native Kubernetes integration for dask","fork":true,"url":"https://api.github.com/repos/Timost/dask-kubernetes","forks_url":"https://api.github.com/repos/Timost/dask-kubernetes/forks","keys_url":"https://api.github.com/repos/Timost/dask-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Timost/dask-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Timost/dask-kubernetes/teams","hooks_url":"https://api.github.com/repos/Timost/dask-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Timost/dask-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Timost/dask-kubernetes/events","assignees_url":"https://api.github.com/repos/Timost/dask-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Timost/dask-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Timost/dask-kubernetes/tags","blobs_url":"https://api.github.com/repos/Timost/dask-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Timost/dask-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Timost/dask-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Timost/dask-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Timost/dask-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Timost/dask-kubernetes/languages","stargazers_url":"https://api.github.com/repos/Timost/dask-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Timost/dask-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Timost/dask-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Timost/dask-kubernetes/subscription","commits_url":"https://api.github.com/repos/Timost/dask-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Timost/dask-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Timost/dask-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Timost/dask-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Timost/dask-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Timost/dask-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Timost/dask-kubernetes/merges","archive_url":"https://api.github.com/repos/Timost/dask-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Timost/dask-kubernetes/downloads","issues_url":"https://api.github.com/repos/Timost/dask-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Timost/dask-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Timost/dask-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Timost/dask-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Timost/dask-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Timost/dask-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Timost/dask-kubernetes/deployments","created_at":"2019-12-02T14:39:07Z","updated_at":"2019-12-03T15:42:31Z","pushed_at":"2019-12-04T10:30:04Z","git_url":"git://github.com/Timost/dask-kubernetes.git","ssh_url":"git@github.com:Timost/dask-kubernetes.git","clone_url":"https://github.com/Timost/dask-kubernetes.git","svn_url":"https://github.com/Timost/dask-kubernetes","homepage":"https://kubernetes.dask.org","size":403,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dask:master","ref":"master","sha":"b481bbbc6c1bb7d0719bc385c0537c4ba4a0ee57","user":{"login":"dask","id":17131925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTMxOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"repo":{"id":116078346,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwNzgzNDY=","name":"dask-kubernetes","full_name":"dask/dask-kubernetes","private":false,"owner":{"login":"dask","id":17131925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTMxOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dask/dask-kubernetes","description":"Native Kubernetes integration for dask","fork":false,"url":"https://api.github.com/repos/dask/dask-kubernetes","forks_url":"https://api.github.com/repos/dask/dask-kubernetes/forks","keys_url":"https://api.github.com/repos/dask/dask-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dask/dask-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dask/dask-kubernetes/teams","hooks_url":"https://api.github.com/repos/dask/dask-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dask/dask-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dask/dask-kubernetes/events","assignees_url":"https://api.github.com/repos/dask/dask-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dask/dask-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dask/dask-kubernetes/tags","blobs_url":"https://api.github.com/repos/dask/dask-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dask/dask-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dask/dask-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dask/dask-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dask/dask-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dask/dask-kubernetes/languages","stargazers_url":"https://api.github.com/repos/dask/dask-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dask/dask-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dask/dask-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dask/dask-kubernetes/subscription","commits_url":"https://api.github.com/repos/dask/dask-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dask/dask-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dask/dask-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dask/dask-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dask/dask-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dask/dask-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dask/dask-kubernetes/merges","archive_url":"https://api.github.com/repos/dask/dask-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dask/dask-kubernetes/downloads","issues_url":"https://api.github.com/repos/dask/dask-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dask/dask-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dask/dask-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dask/dask-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dask/dask-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dask/dask-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dask/dask-kubernetes/deployments","created_at":"2018-01-03T01:56:46Z","updated_at":"2019-12-03T15:28:40Z","pushed_at":"2019-12-04T10:40:50Z","git_url":"git://github.com/dask/dask-kubernetes.git","ssh_url":"git@github.com:dask/dask-kubernetes.git","clone_url":"https://github.com/dask/dask-kubernetes.git","svn_url":"https://github.com/dask/dask-kubernetes","homepage":"https://kubernetes.dask.org","size":403,"stargazers_count":149,"watchers_count":149,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":44,"open_issues":21,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dask/dask-kubernetes/pulls/211"},"html":{"href":"https://github.com/dask/dask-kubernetes/pull/211"},"issue":{"href":"https://api.github.com/repos/dask/dask-kubernetes/issues/211"},"comments":{"href":"https://api.github.com/repos/dask/dask-kubernetes/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/dask/dask-kubernetes/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/dask/dask-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dask/dask-kubernetes/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/dask/dask-kubernetes/statuses/3dd66405fabc7d8f3fb32576b5efa068ad516dc7"}},"author_association":"NONE"}}
{"actor":{"display_login":"jacobtomlinson"}}