{"action":"closed","number":1439,"pull_request":{"url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1439","id":253598386,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzNTk4Mzg2","html_url":"https://github.com/joel-costigliola/assertj-core/pull/1439","diff_url":"https://github.com/joel-costigliola/assertj-core/pull/1439.diff","patch_url":"https://github.com/joel-costigliola/assertj-core/pull/1439.patch","issue_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1439","number":1439,"state":"closed","locked":false,"title":"Initial @Nullable annotations and using them in org.assertj.core.api.exception","user":{"login":"checketts","id":416063,"node_id":"MDQ6VXNlcjQxNjA2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/416063?v=4","gravatar_id":"","url":"https://api.github.com/users/checketts","html_url":"https://github.com/checketts","followers_url":"https://api.github.com/users/checketts/followers","following_url":"https://api.github.com/users/checketts/following{/other_user}","gists_url":"https://api.github.com/users/checketts/gists{/gist_id}","starred_url":"https://api.github.com/users/checketts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checketts/subscriptions","organizations_url":"https://api.github.com/users/checketts/orgs","repos_url":"https://api.github.com/users/checketts/repos","events_url":"https://api.github.com/users/checketts/events{/privacy}","received_events_url":"https://api.github.com/users/checketts/received_events","type":"User","site_admin":false},"body":"#### Check List:\r\n* Fixes #1414 \r\n* Unit tests : NA\r\n* Javadoc with a code example (API only) : YES\r\n\r\nSo far this PR adds the various @NonNullApi annotations a `package-info.java` that default each package to assume all parameters and returns are non-null. Then I am going in and inspecting the code for null checks, javadocs comments about nullability, or where nulls are returned and are naturally appearing in the code.\r\n\r\nPackages completed so far:\r\n\r\n- [X] org.assertj.core.annotations\r\n- [X] org.assertj.core.api.exception\r\n- [ ] org.assertj.core.api.filter\r\n- [ ] org.assertj.core.api.iterable\r\n- [ ] org.assertj.core.api.recursive.comparison\r\n- [ ] org.assertj.core.api (that one is huge!)\r\n- [ ] org.assertj.core.condition\r\n- [ ] org.assertj.core.configuration\r\n- [ ] org.assertj.core.data\r\n- [ ] org.assertj.core.description\r\n- [ ] org.assertj.core.error.future\r\n- [ ] org.assertj.core.error.uri\r\n- [ ] org.assertj.core.error (another beast!)\r\n- [ ] org.assertj.core.extractor \r\n- [ ] org.assertj.core.groups \r\n- [ ] org.assertj.core.internal \r\n- [ ] org.assertj.core.matcher \r\n- [ ] org.assertj.core.presentation\r\n- [ ] org.assertj.core.util.diff.myers\r\n- [ ] org.assertj.core.util.diff\r\n- [ ] org.assertj.core.util.introspection\r\n- [ ] org.assertj.core.util.xml\r\n- [ ] org.assertj.core.util \r\n\r\nThis is going to be a HUGE PR. What would be the best way for me to break this up so you can review it in a sane way?  Odds are I will find a potential NPE that we might want to actually handle.","created_at":"2019-02-15T23:54:50Z","updated_at":"2019-03-31T05:47:28Z","closed_at":"2019-03-31T05:47:28Z","merged_at":null,"merge_commit_sha":"634bedfa319bff5b41305271b94209664b1c8470","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/joel-costigliola/assertj-core/milestones/43","html_url":"https://github.com/joel-costigliola/assertj-core/milestone/43","labels_url":"https://api.github.com/repos/joel-costigliola/assertj-core/milestones/43/labels","id":4001945,"node_id":"MDk6TWlsZXN0b25lNDAwMTk0NQ==","number":43,"title":"3.13","description":null,"creator":{"login":"joel-costigliola","id":382613,"node_id":"MDQ6VXNlcjM4MjYxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/382613?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-costigliola","html_url":"https://github.com/joel-costigliola","followers_url":"https://api.github.com/users/joel-costigliola/followers","following_url":"https://api.github.com/users/joel-costigliola/following{/other_user}","gists_url":"https://api.github.com/users/joel-costigliola/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-costigliola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-costigliola/subscriptions","organizations_url":"https://api.github.com/users/joel-costigliola/orgs","repos_url":"https://api.github.com/users/joel-costigliola/repos","events_url":"https://api.github.com/users/joel-costigliola/events{/privacy}","received_events_url":"https://api.github.com/users/joel-costigliola/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":6,"state":"open","created_at":"2019-01-25T10:29:30Z","updated_at":"2019-03-31T05:47:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1439/commits","review_comments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1439/comments","review_comment_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1439/comments","statuses_url":"https://api.github.com/repos/joel-costigliola/assertj-core/statuses/a4528f0100ecd6d503e477c627fcf027d0d6d842","head":{"label":"checketts:master","ref":"master","sha":"a4528f0100ecd6d503e477c627fcf027d0d6d842","user":{"login":"checketts","id":416063,"node_id":"MDQ6VXNlcjQxNjA2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/416063?v=4","gravatar_id":"","url":"https://api.github.com/users/checketts","html_url":"https://github.com/checketts","followers_url":"https://api.github.com/users/checketts/followers","following_url":"https://api.github.com/users/checketts/following{/other_user}","gists_url":"https://api.github.com/users/checketts/gists{/gist_id}","starred_url":"https://api.github.com/users/checketts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checketts/subscriptions","organizations_url":"https://api.github.com/users/checketts/orgs","repos_url":"https://api.github.com/users/checketts/repos","events_url":"https://api.github.com/users/checketts/events{/privacy}","received_events_url":"https://api.github.com/users/checketts/received_events","type":"User","site_admin":false},"repo":{"id":33764408,"node_id":"MDEwOlJlcG9zaXRvcnkzMzc2NDQwOA==","name":"assertj-core","full_name":"checketts/assertj-core","private":false,"owner":{"login":"checketts","id":416063,"node_id":"MDQ6VXNlcjQxNjA2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/416063?v=4","gravatar_id":"","url":"https://api.github.com/users/checketts","html_url":"https://github.com/checketts","followers_url":"https://api.github.com/users/checketts/followers","following_url":"https://api.github.com/users/checketts/following{/other_user}","gists_url":"https://api.github.com/users/checketts/gists{/gist_id}","starred_url":"https://api.github.com/users/checketts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checketts/subscriptions","organizations_url":"https://api.github.com/users/checketts/orgs","repos_url":"https://api.github.com/users/checketts/repos","events_url":"https://api.github.com/users/checketts/events{/privacy}","received_events_url":"https://api.github.com/users/checketts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/checketts/assertj-core","description":"AssertJ is a library of assertions similar to fest-assert but providing a richer set of assertions.","fork":true,"url":"https://api.github.com/repos/checketts/assertj-core","forks_url":"https://api.github.com/repos/checketts/assertj-core/forks","keys_url":"https://api.github.com/repos/checketts/assertj-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/checketts/assertj-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/checketts/assertj-core/teams","hooks_url":"https://api.github.com/repos/checketts/assertj-core/hooks","issue_events_url":"https://api.github.com/repos/checketts/assertj-core/issues/events{/number}","events_url":"https://api.github.com/repos/checketts/assertj-core/events","assignees_url":"https://api.github.com/repos/checketts/assertj-core/assignees{/user}","branches_url":"https://api.github.com/repos/checketts/assertj-core/branches{/branch}","tags_url":"https://api.github.com/repos/checketts/assertj-core/tags","blobs_url":"https://api.github.com/repos/checketts/assertj-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/checketts/assertj-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/checketts/assertj-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/checketts/assertj-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/checketts/assertj-core/statuses/{sha}","languages_url":"https://api.github.com/repos/checketts/assertj-core/languages","stargazers_url":"https://api.github.com/repos/checketts/assertj-core/stargazers","contributors_url":"https://api.github.com/repos/checketts/assertj-core/contributors","subscribers_url":"https://api.github.com/repos/checketts/assertj-core/subscribers","subscription_url":"https://api.github.com/repos/checketts/assertj-core/subscription","commits_url":"https://api.github.com/repos/checketts/assertj-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/checketts/assertj-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/checketts/assertj-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/checketts/assertj-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/checketts/assertj-core/contents/{+path}","compare_url":"https://api.github.com/repos/checketts/assertj-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/checketts/assertj-core/merges","archive_url":"https://api.github.com/repos/checketts/assertj-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/checketts/assertj-core/downloads","issues_url":"https://api.github.com/repos/checketts/assertj-core/issues{/number}","pulls_url":"https://api.github.com/repos/checketts/assertj-core/pulls{/number}","milestones_url":"https://api.github.com/repos/checketts/assertj-core/milestones{/number}","notifications_url":"https://api.github.com/repos/checketts/assertj-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/checketts/assertj-core/labels{/name}","releases_url":"https://api.github.com/repos/checketts/assertj-core/releases{/id}","deployments_url":"https://api.github.com/repos/checketts/assertj-core/deployments","created_at":"2015-04-11T05:47:07Z","updated_at":"2019-02-27T14:14:02Z","pushed_at":"2019-02-27T14:14:00Z","git_url":"git://github.com/checketts/assertj-core.git","ssh_url":"git@github.com:checketts/assertj-core.git","clone_url":"https://github.com/checketts/assertj-core.git","svn_url":"https://github.com/checketts/assertj-core","homepage":"","size":26822,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joel-costigliola:master","ref":"master","sha":"14384ec07c09d510685f88c95814daa068fdba33","user":{"login":"joel-costigliola","id":382613,"node_id":"MDQ6VXNlcjM4MjYxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/382613?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-costigliola","html_url":"https://github.com/joel-costigliola","followers_url":"https://api.github.com/users/joel-costigliola/followers","following_url":"https://api.github.com/users/joel-costigliola/following{/other_user}","gists_url":"https://api.github.com/users/joel-costigliola/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-costigliola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-costigliola/subscriptions","organizations_url":"https://api.github.com/users/joel-costigliola/orgs","repos_url":"https://api.github.com/users/joel-costigliola/repos","events_url":"https://api.github.com/users/joel-costigliola/events{/privacy}","received_events_url":"https://api.github.com/users/joel-costigliola/received_events","type":"User","site_admin":false},"repo":{"id":8779606,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzc5NjA2","name":"assertj-core","full_name":"joel-costigliola/assertj-core","private":false,"owner":{"login":"joel-costigliola","id":382613,"node_id":"MDQ6VXNlcjM4MjYxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/382613?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-costigliola","html_url":"https://github.com/joel-costigliola","followers_url":"https://api.github.com/users/joel-costigliola/followers","following_url":"https://api.github.com/users/joel-costigliola/following{/other_user}","gists_url":"https://api.github.com/users/joel-costigliola/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-costigliola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-costigliola/subscriptions","organizations_url":"https://api.github.com/users/joel-costigliola/orgs","repos_url":"https://api.github.com/users/joel-costigliola/repos","events_url":"https://api.github.com/users/joel-costigliola/events{/privacy}","received_events_url":"https://api.github.com/users/joel-costigliola/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joel-costigliola/assertj-core","description":"AssertJ is a library providing easy to use rich typed assertions ","fork":false,"url":"https://api.github.com/repos/joel-costigliola/assertj-core","forks_url":"https://api.github.com/repos/joel-costigliola/assertj-core/forks","keys_url":"https://api.github.com/repos/joel-costigliola/assertj-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joel-costigliola/assertj-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joel-costigliola/assertj-core/teams","hooks_url":"https://api.github.com/repos/joel-costigliola/assertj-core/hooks","issue_events_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/events{/number}","events_url":"https://api.github.com/repos/joel-costigliola/assertj-core/events","assignees_url":"https://api.github.com/repos/joel-costigliola/assertj-core/assignees{/user}","branches_url":"https://api.github.com/repos/joel-costigliola/assertj-core/branches{/branch}","tags_url":"https://api.github.com/repos/joel-costigliola/assertj-core/tags","blobs_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joel-costigliola/assertj-core/statuses/{sha}","languages_url":"https://api.github.com/repos/joel-costigliola/assertj-core/languages","stargazers_url":"https://api.github.com/repos/joel-costigliola/assertj-core/stargazers","contributors_url":"https://api.github.com/repos/joel-costigliola/assertj-core/contributors","subscribers_url":"https://api.github.com/repos/joel-costigliola/assertj-core/subscribers","subscription_url":"https://api.github.com/repos/joel-costigliola/assertj-core/subscription","commits_url":"https://api.github.com/repos/joel-costigliola/assertj-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/joel-costigliola/assertj-core/contents/{+path}","compare_url":"https://api.github.com/repos/joel-costigliola/assertj-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joel-costigliola/assertj-core/merges","archive_url":"https://api.github.com/repos/joel-costigliola/assertj-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joel-costigliola/assertj-core/downloads","issues_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues{/number}","pulls_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls{/number}","milestones_url":"https://api.github.com/repos/joel-costigliola/assertj-core/milestones{/number}","notifications_url":"https://api.github.com/repos/joel-costigliola/assertj-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joel-costigliola/assertj-core/labels{/name}","releases_url":"https://api.github.com/repos/joel-costigliola/assertj-core/releases{/id}","deployments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/deployments","created_at":"2013-03-14T16:18:49Z","updated_at":"2019-03-31T05:44:39Z","pushed_at":"2019-03-31T05:44:36Z","git_url":"git://github.com/joel-costigliola/assertj-core.git","ssh_url":"git@github.com:joel-costigliola/assertj-core.git","clone_url":"https://github.com/joel-costigliola/assertj-core.git","svn_url":"https://github.com/joel-costigliola/assertj-core","homepage":"https://assertj.github.io/doc/","size":26696,"stargazers_count":1465,"watchers_count":1465,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":338,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":338,"open_issues":94,"watchers":1465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1439"},"html":{"href":"https://github.com/joel-costigliola/assertj-core/pull/1439"},"issue":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1439"},"comments":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1439/comments"},"review_comments":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1439/comments"},"review_comment":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1439/commits"},"statuses":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/statuses/a4528f0100ecd6d503e477c627fcf027d0d6d842"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":7,"maintainer_can_modify":false,"commits":1,"additions":201,"deletions":1,"changed_files":7}}
{"actor":{"display_login":"joel-costigliola"}}