{"action":"created","comment":{"url":"https://api.github.com/repos/UnitedIncome/components/pulls/comments/305460788","pull_request_review_id":264348126,"id":305460788,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTQ2MDc4OA==","diff_hunk":"@@ -26,7 +26,7 @@ const FormSummary = ({shortTitle, editCard, answerGroups, to}) => {\n         </div>\n       </div>\n       {answerGroups.map((group, index) => {\n-        const key = group.groupName || `${shortTitle}-${index}`;\n+        const key = group.key || group.groupName || `${shortTitle}-${index}`;","path":"components/molecules/CardSummaries/FormSummary/FormSummary.js","position":5,"original_position":5,"commit_id":"f0a3d54157132781760f18f4c5b1882744febdf5","original_commit_id":"f0a3d54157132781760f18f4c5b1882744febdf5","user":{"login":"labichn","id":1727145,"node_id":"MDQ6VXNlcjE3MjcxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1727145?v=4","gravatar_id":"","url":"https://api.github.com/users/labichn","html_url":"https://github.com/labichn","followers_url":"https://api.github.com/users/labichn/followers","following_url":"https://api.github.com/users/labichn/following{/other_user}","gists_url":"https://api.github.com/users/labichn/gists{/gist_id}","starred_url":"https://api.github.com/users/labichn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labichn/subscriptions","organizations_url":"https://api.github.com/users/labichn/orgs","repos_url":"https://api.github.com/users/labichn/repos","events_url":"https://api.github.com/users/labichn/events{/privacy}","received_events_url":"https://api.github.com/users/labichn/received_events","type":"User","site_admin":false},"body":"I'm assuming the form summaries to-date have unique answer groups, or this probably would have come up before. I don't want to force changes to existing code, but I understand your point.","created_at":"2019-07-19T17:48:50Z","updated_at":"2019-07-19T17:48:50Z","html_url":"https://github.com/UnitedIncome/components/pull/594#discussion_r305460788","pull_request_url":"https://api.github.com/repos/UnitedIncome/components/pulls/594","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/UnitedIncome/components/pulls/comments/305460788"},"html":{"href":"https://github.com/UnitedIncome/components/pull/594#discussion_r305460788"},"pull_request":{"href":"https://api.github.com/repos/UnitedIncome/components/pulls/594"}},"in_reply_to_id":305459534},"pull_request":{"url":"https://api.github.com/repos/UnitedIncome/components/pulls/594","id":299423586,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5NDIzNTg2","html_url":"https://github.com/UnitedIncome/components/pull/594","diff_url":"https://github.com/UnitedIncome/components/pull/594.diff","patch_url":"https://github.com/UnitedIncome/components/pull/594.patch","issue_url":"https://api.github.com/repos/UnitedIncome/components/issues/594","number":594,"state":"open","locked":false,"title":"Add optional group key to form summary","user":{"login":"labichn","id":1727145,"node_id":"MDQ6VXNlcjE3MjcxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1727145?v=4","gravatar_id":"","url":"https://api.github.com/users/labichn","html_url":"https://github.com/labichn","followers_url":"https://api.github.com/users/labichn/followers","following_url":"https://api.github.com/users/labichn/following{/other_user}","gists_url":"https://api.github.com/users/labichn/gists{/gist_id}","starred_url":"https://api.github.com/users/labichn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labichn/subscriptions","organizations_url":"https://api.github.com/users/labichn/orgs","repos_url":"https://api.github.com/users/labichn/repos","events_url":"https://api.github.com/users/labichn/events{/privacy}","received_events_url":"https://api.github.com/users/labichn/received_events","type":"User","site_admin":false},"body":"### Description\r\nThe form summary component uses the group names as the React keys (see [here](https://github.com/UnitedIncome/components/blob/1d99ad2afdecd07e3a0e12217f12250a53df15a1/components/molecules/CardSummaries/FormSummary/FormSummary.js#L29))--which causes warnings if you have duplicate group names:\r\n![form-summary](https://user-images.githubusercontent.com/1727145/61554177-4e44f080-aa2a-11e9-8859-452470aa435a.png)\r\n![warning](https://user-images.githubusercontent.com/1727145/61554363-c3182a80-aa2a-11e9-8e85-685a82e8f69f.png)\r\n\r\nThis PR allows answer groups to specify an optional key to use as the React key.\r\n\r\n### Testing Instructions\r\nRender a form summary with two answer groups that have the same name--there will be a React warning. Add a unique key name to one or both of the answer groups and re-render--there will not be a React warning.","created_at":"2019-07-19T17:43:06Z","updated_at":"2019-07-19T17:48:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c355bf82ec4dde394f3800f579634e6f5eda9f08","assignee":null,"assignees":[],"requested_reviewers":[{"login":"RohitRajendran","id":3478163,"node_id":"MDQ6VXNlcjM0NzgxNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/3478163?v=4","gravatar_id":"","url":"https://api.github.com/users/RohitRajendran","html_url":"https://github.com/RohitRajendran","followers_url":"https://api.github.com/users/RohitRajendran/followers","following_url":"https://api.github.com/users/RohitRajendran/following{/other_user}","gists_url":"https://api.github.com/users/RohitRajendran/gists{/gist_id}","starred_url":"https://api.github.com/users/RohitRajendran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohitRajendran/subscriptions","organizations_url":"https://api.github.com/users/RohitRajendran/orgs","repos_url":"https://api.github.com/users/RohitRajendran/repos","events_url":"https://api.github.com/users/RohitRajendran/events{/privacy}","received_events_url":"https://api.github.com/users/RohitRajendran/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UnitedIncome/components/pulls/594/commits","review_comments_url":"https://api.github.com/repos/UnitedIncome/components/pulls/594/comments","review_comment_url":"https://api.github.com/repos/UnitedIncome/components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UnitedIncome/components/issues/594/comments","statuses_url":"https://api.github.com/repos/UnitedIncome/components/statuses/f0a3d54157132781760f18f4c5b1882744febdf5","head":{"label":"UnitedIncome:form-summary-key","ref":"form-summary-key","sha":"f0a3d54157132781760f18f4c5b1882744febdf5","user":{"login":"UnitedIncome","id":19732939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzMyOTM5","avatar_url":"https://avatars3.githubusercontent.com/u/19732939?v=4","gravatar_id":"","url":"https://api.github.com/users/UnitedIncome","html_url":"https://github.com/UnitedIncome","followers_url":"https://api.github.com/users/UnitedIncome/followers","following_url":"https://api.github.com/users/UnitedIncome/following{/other_user}","gists_url":"https://api.github.com/users/UnitedIncome/gists{/gist_id}","starred_url":"https://api.github.com/users/UnitedIncome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnitedIncome/subscriptions","organizations_url":"https://api.github.com/users/UnitedIncome/orgs","repos_url":"https://api.github.com/users/UnitedIncome/repos","events_url":"https://api.github.com/users/UnitedIncome/events{/privacy}","received_events_url":"https://api.github.com/users/UnitedIncome/received_events","type":"Organization","site_admin":false},"repo":{"id":167983990,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc5ODM5OTA=","name":"components","full_name":"UnitedIncome/components","private":false,"owner":{"login":"UnitedIncome","id":19732939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzMyOTM5","avatar_url":"https://avatars3.githubusercontent.com/u/19732939?v=4","gravatar_id":"","url":"https://api.github.com/users/UnitedIncome","html_url":"https://github.com/UnitedIncome","followers_url":"https://api.github.com/users/UnitedIncome/followers","following_url":"https://api.github.com/users/UnitedIncome/following{/other_user}","gists_url":"https://api.github.com/users/UnitedIncome/gists{/gist_id}","starred_url":"https://api.github.com/users/UnitedIncome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnitedIncome/subscriptions","organizations_url":"https://api.github.com/users/UnitedIncome/orgs","repos_url":"https://api.github.com/users/UnitedIncome/repos","events_url":"https://api.github.com/users/UnitedIncome/events{/privacy}","received_events_url":"https://api.github.com/users/UnitedIncome/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UnitedIncome/components","description":"💰📘Application component library for United Income.","fork":false,"url":"https://api.github.com/repos/UnitedIncome/components","forks_url":"https://api.github.com/repos/UnitedIncome/components/forks","keys_url":"https://api.github.com/repos/UnitedIncome/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UnitedIncome/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UnitedIncome/components/teams","hooks_url":"https://api.github.com/repos/UnitedIncome/components/hooks","issue_events_url":"https://api.github.com/repos/UnitedIncome/components/issues/events{/number}","events_url":"https://api.github.com/repos/UnitedIncome/components/events","assignees_url":"https://api.github.com/repos/UnitedIncome/components/assignees{/user}","branches_url":"https://api.github.com/repos/UnitedIncome/components/branches{/branch}","tags_url":"https://api.github.com/repos/UnitedIncome/components/tags","blobs_url":"https://api.github.com/repos/UnitedIncome/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UnitedIncome/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UnitedIncome/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/UnitedIncome/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UnitedIncome/components/statuses/{sha}","languages_url":"https://api.github.com/repos/UnitedIncome/components/languages","stargazers_url":"https://api.github.com/repos/UnitedIncome/components/stargazers","contributors_url":"https://api.github.com/repos/UnitedIncome/components/contributors","subscribers_url":"https://api.github.com/repos/UnitedIncome/components/subscribers","subscription_url":"https://api.github.com/repos/UnitedIncome/components/subscription","commits_url":"https://api.github.com/repos/UnitedIncome/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/UnitedIncome/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/UnitedIncome/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/UnitedIncome/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/UnitedIncome/components/contents/{+path}","compare_url":"https://api.github.com/repos/UnitedIncome/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UnitedIncome/components/merges","archive_url":"https://api.github.com/repos/UnitedIncome/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UnitedIncome/components/downloads","issues_url":"https://api.github.com/repos/UnitedIncome/components/issues{/number}","pulls_url":"https://api.github.com/repos/UnitedIncome/components/pulls{/number}","milestones_url":"https://api.github.com/repos/UnitedIncome/components/milestones{/number}","notifications_url":"https://api.github.com/repos/UnitedIncome/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UnitedIncome/components/labels{/name}","releases_url":"https://api.github.com/repos/UnitedIncome/components/releases{/id}","deployments_url":"https://api.github.com/repos/UnitedIncome/components/deployments","created_at":"2019-01-28T15:19:48Z","updated_at":"2019-07-19T17:46:59Z","pushed_at":"2019-07-19T17:46:55Z","git_url":"git://github.com/UnitedIncome/components.git","ssh_url":"git@github.com:UnitedIncome/components.git","clone_url":"https://github.com/UnitedIncome/components.git","svn_url":"https://github.com/UnitedIncome/components","homepage":"https://ui.unitedincome.com","size":5115,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":6,"watchers":9,"default_branch":"develop"}},"base":{"label":"UnitedIncome:develop","ref":"develop","sha":"71ebad95f431f412c189d95420c4e3cdd1258cbe","user":{"login":"UnitedIncome","id":19732939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzMyOTM5","avatar_url":"https://avatars3.githubusercontent.com/u/19732939?v=4","gravatar_id":"","url":"https://api.github.com/users/UnitedIncome","html_url":"https://github.com/UnitedIncome","followers_url":"https://api.github.com/users/UnitedIncome/followers","following_url":"https://api.github.com/users/UnitedIncome/following{/other_user}","gists_url":"https://api.github.com/users/UnitedIncome/gists{/gist_id}","starred_url":"https://api.github.com/users/UnitedIncome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnitedIncome/subscriptions","organizations_url":"https://api.github.com/users/UnitedIncome/orgs","repos_url":"https://api.github.com/users/UnitedIncome/repos","events_url":"https://api.github.com/users/UnitedIncome/events{/privacy}","received_events_url":"https://api.github.com/users/UnitedIncome/received_events","type":"Organization","site_admin":false},"repo":{"id":167983990,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc5ODM5OTA=","name":"components","full_name":"UnitedIncome/components","private":false,"owner":{"login":"UnitedIncome","id":19732939,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzMyOTM5","avatar_url":"https://avatars3.githubusercontent.com/u/19732939?v=4","gravatar_id":"","url":"https://api.github.com/users/UnitedIncome","html_url":"https://github.com/UnitedIncome","followers_url":"https://api.github.com/users/UnitedIncome/followers","following_url":"https://api.github.com/users/UnitedIncome/following{/other_user}","gists_url":"https://api.github.com/users/UnitedIncome/gists{/gist_id}","starred_url":"https://api.github.com/users/UnitedIncome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnitedIncome/subscriptions","organizations_url":"https://api.github.com/users/UnitedIncome/orgs","repos_url":"https://api.github.com/users/UnitedIncome/repos","events_url":"https://api.github.com/users/UnitedIncome/events{/privacy}","received_events_url":"https://api.github.com/users/UnitedIncome/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UnitedIncome/components","description":"💰📘Application component library for United Income.","fork":false,"url":"https://api.github.com/repos/UnitedIncome/components","forks_url":"https://api.github.com/repos/UnitedIncome/components/forks","keys_url":"https://api.github.com/repos/UnitedIncome/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UnitedIncome/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UnitedIncome/components/teams","hooks_url":"https://api.github.com/repos/UnitedIncome/components/hooks","issue_events_url":"https://api.github.com/repos/UnitedIncome/components/issues/events{/number}","events_url":"https://api.github.com/repos/UnitedIncome/components/events","assignees_url":"https://api.github.com/repos/UnitedIncome/components/assignees{/user}","branches_url":"https://api.github.com/repos/UnitedIncome/components/branches{/branch}","tags_url":"https://api.github.com/repos/UnitedIncome/components/tags","blobs_url":"https://api.github.com/repos/UnitedIncome/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UnitedIncome/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UnitedIncome/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/UnitedIncome/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UnitedIncome/components/statuses/{sha}","languages_url":"https://api.github.com/repos/UnitedIncome/components/languages","stargazers_url":"https://api.github.com/repos/UnitedIncome/components/stargazers","contributors_url":"https://api.github.com/repos/UnitedIncome/components/contributors","subscribers_url":"https://api.github.com/repos/UnitedIncome/components/subscribers","subscription_url":"https://api.github.com/repos/UnitedIncome/components/subscription","commits_url":"https://api.github.com/repos/UnitedIncome/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/UnitedIncome/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/UnitedIncome/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/UnitedIncome/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/UnitedIncome/components/contents/{+path}","compare_url":"https://api.github.com/repos/UnitedIncome/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UnitedIncome/components/merges","archive_url":"https://api.github.com/repos/UnitedIncome/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UnitedIncome/components/downloads","issues_url":"https://api.github.com/repos/UnitedIncome/components/issues{/number}","pulls_url":"https://api.github.com/repos/UnitedIncome/components/pulls{/number}","milestones_url":"https://api.github.com/repos/UnitedIncome/components/milestones{/number}","notifications_url":"https://api.github.com/repos/UnitedIncome/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UnitedIncome/components/labels{/name}","releases_url":"https://api.github.com/repos/UnitedIncome/components/releases{/id}","deployments_url":"https://api.github.com/repos/UnitedIncome/components/deployments","created_at":"2019-01-28T15:19:48Z","updated_at":"2019-07-19T17:46:59Z","pushed_at":"2019-07-19T17:46:55Z","git_url":"git://github.com/UnitedIncome/components.git","ssh_url":"git@github.com:UnitedIncome/components.git","clone_url":"https://github.com/UnitedIncome/components.git","svn_url":"https://github.com/UnitedIncome/components","homepage":"https://ui.unitedincome.com","size":5115,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":6,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/UnitedIncome/components/pulls/594"},"html":{"href":"https://github.com/UnitedIncome/components/pull/594"},"issue":{"href":"https://api.github.com/repos/UnitedIncome/components/issues/594"},"comments":{"href":"https://api.github.com/repos/UnitedIncome/components/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/UnitedIncome/components/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/UnitedIncome/components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UnitedIncome/components/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/UnitedIncome/components/statuses/f0a3d54157132781760f18f4c5b1882744febdf5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"labichn"}}