{"action":"created","issue":{"url":"https://api.github.com/repos/lc-soft/LCUI/issues/189","repository_url":"https://api.github.com/repos/lc-soft/LCUI","labels_url":"https://api.github.com/repos/lc-soft/LCUI/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/lc-soft/LCUI/issues/189/comments","events_url":"https://api.github.com/repos/lc-soft/LCUI/issues/189/events","html_url":"https://github.com/lc-soft/LCUI/pull/189","id":536380805,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxOTIxODE5","number":189,"title":"perf: Add OpenMP support for widget rendering (#118)","user":{"login":"d4yvector","id":9170826,"node_id":"MDQ6VXNlcjkxNzA4MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/9170826?v=4","gravatar_id":"","url":"https://api.github.com/users/d4yvector","html_url":"https://github.com/d4yvector","followers_url":"https://api.github.com/users/d4yvector/followers","following_url":"https://api.github.com/users/d4yvector/following{/other_user}","gists_url":"https://api.github.com/users/d4yvector/gists{/gist_id}","starred_url":"https://api.github.com/users/d4yvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d4yvector/subscriptions","organizations_url":"https://api.github.com/users/d4yvector/orgs","repos_url":"https://api.github.com/users/d4yvector/repos","events_url":"https://api.github.com/users/d4yvector/events{/privacy}","received_events_url":"https://api.github.com/users/d4yvector/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2019-12-11T13:47:02Z","updated_at":"2019-12-18T02:14:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lc-soft/LCUI/pulls/189","html_url":"https://github.com/lc-soft/LCUI/pull/189","diff_url":"https://github.com/lc-soft/LCUI/pull/189.diff","patch_url":"https://github.com/lc-soft/LCUI/pull/189.patch"},"body":"## Purpose\r\nAdd OpenMP support for widget rendering (#118) .\r\n\r\n## Changes\r\n- Modified src/Makefile.am and added compiler option.\r\n- Modified src/display.c and added preprocessor directives for OpenMP.\r\n- To check whether multithreading is possible, the string is output to standard output. However, I will remove it before merging.\r\n\r\n## Screenshots\r\n- When OpenMP is not supported(change before)\r\n![openmp_is_not_supported](https://user-images.githubusercontent.com/9170826/70626664-346da980-1c68-11ea-9717-11fc86408849.png)\r\n\r\n- When OpenMP is supported(change after)\r\n![openmp_is_supported](https://user-images.githubusercontent.com/9170826/70621588-49910b00-1c5d-11ea-8f24-47fe48f7cf93.png)\r\n\r\nI printed `thread_num` to confirm that multiple threads were used.\r\nIf there are no problems with the review, I will remove the `thread_num` output.\r\n\r\n## To reproduce\r\n```bash\r\n$ make\r\n$ make test\r\n```\r\n\r\nIn `make test`, there is only one rectangle in `rects`, the execution time was slightly longer due to overhead.\r\nI measured it with `time make test`."},"comment":{"url":"https://api.github.com/repos/lc-soft/LCUI/issues/comments/566835392","html_url":"https://github.com/lc-soft/LCUI/pull/189#issuecomment-566835392","issue_url":"https://api.github.com/repos/lc-soft/LCUI/issues/189","id":566835392,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NjgzNTM5Mg==","user":{"login":"lc-soft","id":1730073,"node_id":"MDQ6VXNlcjE3MzAwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1730073?v=4","gravatar_id":"","url":"https://api.github.com/users/lc-soft","html_url":"https://github.com/lc-soft","followers_url":"https://api.github.com/users/lc-soft/followers","following_url":"https://api.github.com/users/lc-soft/following{/other_user}","gists_url":"https://api.github.com/users/lc-soft/gists{/gist_id}","starred_url":"https://api.github.com/users/lc-soft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lc-soft/subscriptions","organizations_url":"https://api.github.com/users/lc-soft/orgs","repos_url":"https://api.github.com/users/lc-soft/repos","events_url":"https://api.github.com/users/lc-soft/events{/privacy}","received_events_url":"https://api.github.com/users/lc-soft/received_events","type":"User","site_admin":false},"created_at":"2019-12-18T02:14:26Z","updated_at":"2019-12-18T02:14:26Z","author_association":"OWNER","body":"## Performance test results\r\n\r\nI updated the test code:\r\n\r\n- Number of widgets reduced to 3600\r\n- Resize window to 1600x900\r\n\r\n**OpenMP disabled:**\r\n\r\n```text\r\nrunning rendering performance test\r\nrendered 120 frames in 6.47s, rendering speed is 18.55 fps\r\n```\r\n\r\n**OpenMP enabled:**\r\n\r\n```text\r\nunning rendering performance test\r\nrendered 120 frames in 6.48s, rendering speed is 18.52 fps\r\n```\r\n\r\nIt looks the same, maybe there are still problems to be solved."}}
{"actor":{"display_login":"lc-soft"}}