{"action":"created","comment":{"url":"https://api.github.com/repos/dragonchain/dragonchain/pulls/comments/341802108","pull_request_review_id":310760020,"id":341802108,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTgwMjEwOA==","diff_hunk":"@@ -669,3 +669,49 @@ def get_transaction_queue_task_schema(dict_payload: bool = False) -> Dict[str, A\n     \"required\": [\"to\", \"value\"],\n     \"additionalProperties\": False,\n }\n+\n+# BINANCE INTERCHAIN #\n+\n+create_binance_interchain_schema_v1 = {\n+    \"type\": \"object\",\n+    \"properties\": {\n+        \"version\": {\"type\": \"string\", \"enum\": [\"1\"]},\n+        \"name\": {\"type\": \"string\"},\n+        \"testnet\": {\"type\": \"boolean\"},\n+        \"node_url\": {\"type\": \"string\"},\n+        \"rpc_port\": {\"type\": \"integer\"},\n+        \"api_port\": {\"type\": \"integer\"},\n+        \"private_key\": {\"type\": \"string\"},\n+    },\n+    \"additionalProperties\": False,\n+    \"required\": [\"name\", \"version\"],\n+}\n+\n+# Same as create without required name field\n+update_binance_interchain_schema_v1 = {\n+    \"type\": \"object\",\n+    \"properties\": {\n+        \"version\": {\"type\": \"string\", \"enum\": [\"1\"]},\n+        \"name\": {\"type\": \"string\"},\n+        \"testnet\": {\"type\": \"boolean\"},\n+        \"node_url\": {\"type\": \"string\"},\n+        \"rpc_port\": {\"type\": \"integer\"},\n+        \"api_port\": {\"type\": \"integer\"},\n+        \"private_key\": {\"type\": \"string\"},\n+    },\n+    \"additionalProperties\": False,\n+    \"required\": [\"version\"],\n+}\n+\n+bnb_transaction_schema_v1 = {\n+    \"type\": \"object\",\n+    \"properties\": {\n+        \"version\": {\"type\": \"string\", \"enum\": [\"1\"]},\n+        \"symbol\": {\"type\": \"string\"},\n+        \"amount\": {\"type\": \"number\"},\n+        \"to_address\": {\"type\": \"string\"},\n+        \"memo\": {\"type\": \"string\"},\n+    },\n+    \"required\": [\"amount\", \"to_address\"],","path":"dragonchain/lib/dto/schema.py","position":47,"original_position":47,"commit_id":"479341c9df17f31c5336838de5c3f0c86fa33f58","original_commit_id":"61b872782c1e0e19090291a2571c9221df9281f8","user":{"login":"Wingman4l7","id":1383561,"node_id":"MDQ6VXNlcjEzODM1NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1383561?v=4","gravatar_id":"","url":"https://api.github.com/users/Wingman4l7","html_url":"https://github.com/Wingman4l7","followers_url":"https://api.github.com/users/Wingman4l7/followers","following_url":"https://api.github.com/users/Wingman4l7/following{/other_user}","gists_url":"https://api.github.com/users/Wingman4l7/gists{/gist_id}","starred_url":"https://api.github.com/users/Wingman4l7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wingman4l7/subscriptions","organizations_url":"https://api.github.com/users/Wingman4l7/orgs","repos_url":"https://api.github.com/users/Wingman4l7/repos","events_url":"https://api.github.com/users/Wingman4l7/events{/privacy}","received_events_url":"https://api.github.com/users/Wingman4l7/received_events","type":"User","site_admin":false},"body":"Version is not required in BTC and ETH transaction schemas.","created_at":"2019-11-02T07:30:44Z","updated_at":"2019-11-02T07:30:44Z","html_url":"https://github.com/dragonchain/dragonchain/pull/231#discussion_r341802108","pull_request_url":"https://api.github.com/repos/dragonchain/dragonchain/pulls/231","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dragonchain/dragonchain/pulls/comments/341802108"},"html":{"href":"https://github.com/dragonchain/dragonchain/pull/231#discussion_r341802108"},"pull_request":{"href":"https://api.github.com/repos/dragonchain/dragonchain/pulls/231"}},"in_reply_to_id":341753066},"pull_request":{"url":"https://api.github.com/repos/dragonchain/dragonchain/pulls/231","id":333956598,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzOTU2NTk4","html_url":"https://github.com/dragonchain/dragonchain/pull/231","diff_url":"https://github.com/dragonchain/dragonchain/pull/231.diff","patch_url":"https://github.com/dragonchain/dragonchain/pull/231.patch","issue_url":"https://api.github.com/repos/dragonchain/dragonchain/issues/231","number":231,"state":"open","locked":false,"title":"Adds Binance L5","user":{"login":"deanshelton913","id":1299498,"node_id":"MDQ6VXNlcjEyOTk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1299498?v=4","gravatar_id":"","url":"https://api.github.com/users/deanshelton913","html_url":"https://github.com/deanshelton913","followers_url":"https://api.github.com/users/deanshelton913/followers","following_url":"https://api.github.com/users/deanshelton913/following{/other_user}","gists_url":"https://api.github.com/users/deanshelton913/gists{/gist_id}","starred_url":"https://api.github.com/users/deanshelton913/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanshelton913/subscriptions","organizations_url":"https://api.github.com/users/deanshelton913/orgs","repos_url":"https://api.github.com/users/deanshelton913/repos","events_url":"https://api.github.com/users/deanshelton913/events{/privacy}","received_events_url":"https://api.github.com/users/deanshelton913/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please ensure that you've reviewed the contributors guide:\r\nhttps://github.com/dragonchain/dragonchain/blob/master/CONTRIBUTING.md\r\n\r\nPlease ensure to provide a good title and description for the pull request\r\n\r\nNote that bug fixes and new features should include tests.\r\n-->\r\n\r\n## Description\r\n\r\n<!-- Put your pull request description here, and be sure to link any relevant github issues -->\r\n\r\n##### Checklist\r\n\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `./tools.sh full-test` passes\r\n- [ ] tests are included\r\n- [ ] documentation is changed or added\r\n- [ ] changelog has been modified for the changes\r\n","created_at":"2019-10-30T00:34:19Z","updated_at":"2019-11-02T07:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a2d894bd1410f36a040bd28d1f85080ac506b2b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"regan-karlewicz","id":1987265,"node_id":"MDQ6VXNlcjE5ODcyNjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1987265?v=4","gravatar_id":"","url":"https://api.github.com/users/regan-karlewicz","html_url":"https://github.com/regan-karlewicz","followers_url":"https://api.github.com/users/regan-karlewicz/followers","following_url":"https://api.github.com/users/regan-karlewicz/following{/other_user}","gists_url":"https://api.github.com/users/regan-karlewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/regan-karlewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regan-karlewicz/subscriptions","organizations_url":"https://api.github.com/users/regan-karlewicz/orgs","repos_url":"https://api.github.com/users/regan-karlewicz/repos","events_url":"https://api.github.com/users/regan-karlewicz/events{/privacy}","received_events_url":"https://api.github.com/users/regan-karlewicz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dragonchain/dragonchain/pulls/231/commits","review_comments_url":"https://api.github.com/repos/dragonchain/dragonchain/pulls/231/comments","review_comment_url":"https://api.github.com/repos/dragonchain/dragonchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dragonchain/dragonchain/issues/231/comments","statuses_url":"https://api.github.com/repos/dragonchain/dragonchain/statuses/479341c9df17f31c5336838de5c3f0c86fa33f58","head":{"label":"dragonchain:DRGN-871-rebased","ref":"DRGN-871-rebased","sha":"479341c9df17f31c5336838de5c3f0c86fa33f58","user":{"login":"dragonchain","id":21167437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMTY3NDM3","avatar_url":"https://avatars3.githubusercontent.com/u/21167437?v=4","gravatar_id":"","url":"https://api.github.com/users/dragonchain","html_url":"https://github.com/dragonchain","followers_url":"https://api.github.com/users/dragonchain/followers","following_url":"https://api.github.com/users/dragonchain/following{/other_user}","gists_url":"https://api.github.com/users/dragonchain/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonchain/subscriptions","organizations_url":"https://api.github.com/users/dragonchain/orgs","repos_url":"https://api.github.com/users/dragonchain/repos","events_url":"https://api.github.com/users/dragonchain/events{/privacy}","received_events_url":"https://api.github.com/users/dragonchain/received_events","type":"Organization","site_admin":false},"repo":{"id":66244442,"node_id":"MDEwOlJlcG9zaXRvcnk2NjI0NDQ0Mg==","name":"dragonchain","full_name":"dragonchain/dragonchain","private":false,"owner":{"login":"dragonchain","id":21167437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMTY3NDM3","avatar_url":"https://avatars3.githubusercontent.com/u/21167437?v=4","gravatar_id":"","url":"https://api.github.com/users/dragonchain","html_url":"https://github.com/dragonchain","followers_url":"https://api.github.com/users/dragonchain/followers","following_url":"https://api.github.com/users/dragonchain/following{/other_user}","gists_url":"https://api.github.com/users/dragonchain/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonchain/subscriptions","organizations_url":"https://api.github.com/users/dragonchain/orgs","repos_url":"https://api.github.com/users/dragonchain/repos","events_url":"https://api.github.com/users/dragonchain/events{/privacy}","received_events_url":"https://api.github.com/users/dragonchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dragonchain/dragonchain","description":"Dragonchain blockchain platform - simplified integration of advanced blockchain features","fork":false,"url":"https://api.github.com/repos/dragonchain/dragonchain","forks_url":"https://api.github.com/repos/dragonchain/dragonchain/forks","keys_url":"https://api.github.com/repos/dragonchain/dragonchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dragonchain/dragonchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dragonchain/dragonchain/teams","hooks_url":"https://api.github.com/repos/dragonchain/dragonchain/hooks","issue_events_url":"https://api.github.com/repos/dragonchain/dragonchain/issues/events{/number}","events_url":"https://api.github.com/repos/dragonchain/dragonchain/events","assignees_url":"https://api.github.com/repos/dragonchain/dragonchain/assignees{/user}","branches_url":"https://api.github.com/repos/dragonchain/dragonchain/branches{/branch}","tags_url":"https://api.github.com/repos/dragonchain/dragonchain/tags","blobs_url":"https://api.github.com/repos/dragonchain/dragonchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dragonchain/dragonchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dragonchain/dragonchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/dragonchain/dragonchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dragonchain/dragonchain/statuses/{sha}","languages_url":"https://api.github.com/repos/dragonchain/dragonchain/languages","stargazers_url":"https://api.github.com/repos/dragonchain/dragonchain/stargazers","contributors_url":"https://api.github.com/repos/dragonchain/dragonchain/contributors","subscribers_url":"https://api.github.com/repos/dragonchain/dragonchain/subscribers","subscription_url":"https://api.github.com/repos/dragonchain/dragonchain/subscription","commits_url":"https://api.github.com/repos/dragonchain/dragonchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/dragonchain/dragonchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/dragonchain/dragonchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/dragonchain/dragonchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/dragonchain/dragonchain/contents/{+path}","compare_url":"https://api.github.com/repos/dragonchain/dragonchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dragonchain/dragonchain/merges","archive_url":"https://api.github.com/repos/dragonchain/dragonchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dragonchain/dragonchain/downloads","issues_url":"https://api.github.com/repos/dragonchain/dragonchain/issues{/number}","pulls_url":"https://api.github.com/repos/dragonchain/dragonchain/pulls{/number}","milestones_url":"https://api.github.com/repos/dragonchain/dragonchain/milestones{/number}","notifications_url":"https://api.github.com/repos/dragonchain/dragonchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dragonchain/dragonchain/labels{/name}","releases_url":"https://api.github.com/repos/dragonchain/dragonchain/releases{/id}","deployments_url":"https://api.github.com/repos/dragonchain/dragonchain/deployments","created_at":"2016-08-22T06:08:34Z","updated_at":"2019-10-29T21:56:36Z","pushed_at":"2019-11-02T04:21:12Z","git_url":"git://github.com/dragonchain/dragonchain.git","ssh_url":"git@github.com:dragonchain/dragonchain.git","clone_url":"https://github.com/dragonchain/dragonchain.git","svn_url":"https://github.com/dragonchain/dragonchain","homepage":"https://dragonchain.com","size":7161,"stargazers_count":650,"watchers_count":650,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":165,"open_issues":7,"watchers":650,"default_branch":"master"}},"base":{"label":"dragonchain:master","ref":"master","sha":"13e64b13529d91c643685ce03b723ea49892355d","user":{"login":"dragonchain","id":21167437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMTY3NDM3","avatar_url":"https://avatars3.githubusercontent.com/u/21167437?v=4","gravatar_id":"","url":"https://api.github.com/users/dragonchain","html_url":"https://github.com/dragonchain","followers_url":"https://api.github.com/users/dragonchain/followers","following_url":"https://api.github.com/users/dragonchain/following{/other_user}","gists_url":"https://api.github.com/users/dragonchain/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonchain/subscriptions","organizations_url":"https://api.github.com/users/dragonchain/orgs","repos_url":"https://api.github.com/users/dragonchain/repos","events_url":"https://api.github.com/users/dragonchain/events{/privacy}","received_events_url":"https://api.github.com/users/dragonchain/received_events","type":"Organization","site_admin":false},"repo":{"id":66244442,"node_id":"MDEwOlJlcG9zaXRvcnk2NjI0NDQ0Mg==","name":"dragonchain","full_name":"dragonchain/dragonchain","private":false,"owner":{"login":"dragonchain","id":21167437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMTY3NDM3","avatar_url":"https://avatars3.githubusercontent.com/u/21167437?v=4","gravatar_id":"","url":"https://api.github.com/users/dragonchain","html_url":"https://github.com/dragonchain","followers_url":"https://api.github.com/users/dragonchain/followers","following_url":"https://api.github.com/users/dragonchain/following{/other_user}","gists_url":"https://api.github.com/users/dragonchain/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonchain/subscriptions","organizations_url":"https://api.github.com/users/dragonchain/orgs","repos_url":"https://api.github.com/users/dragonchain/repos","events_url":"https://api.github.com/users/dragonchain/events{/privacy}","received_events_url":"https://api.github.com/users/dragonchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dragonchain/dragonchain","description":"Dragonchain blockchain platform - simplified integration of advanced blockchain features","fork":false,"url":"https://api.github.com/repos/dragonchain/dragonchain","forks_url":"https://api.github.com/repos/dragonchain/dragonchain/forks","keys_url":"https://api.github.com/repos/dragonchain/dragonchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dragonchain/dragonchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dragonchain/dragonchain/teams","hooks_url":"https://api.github.com/repos/dragonchain/dragonchain/hooks","issue_events_url":"https://api.github.com/repos/dragonchain/dragonchain/issues/events{/number}","events_url":"https://api.github.com/repos/dragonchain/dragonchain/events","assignees_url":"https://api.github.com/repos/dragonchain/dragonchain/assignees{/user}","branches_url":"https://api.github.com/repos/dragonchain/dragonchain/branches{/branch}","tags_url":"https://api.github.com/repos/dragonchain/dragonchain/tags","blobs_url":"https://api.github.com/repos/dragonchain/dragonchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dragonchain/dragonchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dragonchain/dragonchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/dragonchain/dragonchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dragonchain/dragonchain/statuses/{sha}","languages_url":"https://api.github.com/repos/dragonchain/dragonchain/languages","stargazers_url":"https://api.github.com/repos/dragonchain/dragonchain/stargazers","contributors_url":"https://api.github.com/repos/dragonchain/dragonchain/contributors","subscribers_url":"https://api.github.com/repos/dragonchain/dragonchain/subscribers","subscription_url":"https://api.github.com/repos/dragonchain/dragonchain/subscription","commits_url":"https://api.github.com/repos/dragonchain/dragonchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/dragonchain/dragonchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/dragonchain/dragonchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/dragonchain/dragonchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/dragonchain/dragonchain/contents/{+path}","compare_url":"https://api.github.com/repos/dragonchain/dragonchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dragonchain/dragonchain/merges","archive_url":"https://api.github.com/repos/dragonchain/dragonchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dragonchain/dragonchain/downloads","issues_url":"https://api.github.com/repos/dragonchain/dragonchain/issues{/number}","pulls_url":"https://api.github.com/repos/dragonchain/dragonchain/pulls{/number}","milestones_url":"https://api.github.com/repos/dragonchain/dragonchain/milestones{/number}","notifications_url":"https://api.github.com/repos/dragonchain/dragonchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dragonchain/dragonchain/labels{/name}","releases_url":"https://api.github.com/repos/dragonchain/dragonchain/releases{/id}","deployments_url":"https://api.github.com/repos/dragonchain/dragonchain/deployments","created_at":"2016-08-22T06:08:34Z","updated_at":"2019-10-29T21:56:36Z","pushed_at":"2019-11-02T04:21:12Z","git_url":"git://github.com/dragonchain/dragonchain.git","ssh_url":"git@github.com:dragonchain/dragonchain.git","clone_url":"https://github.com/dragonchain/dragonchain.git","svn_url":"https://github.com/dragonchain/dragonchain","homepage":"https://dragonchain.com","size":7161,"stargazers_count":650,"watchers_count":650,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":165,"open_issues":7,"watchers":650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dragonchain/dragonchain/pulls/231"},"html":{"href":"https://github.com/dragonchain/dragonchain/pull/231"},"issue":{"href":"https://api.github.com/repos/dragonchain/dragonchain/issues/231"},"comments":{"href":"https://api.github.com/repos/dragonchain/dragonchain/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/dragonchain/dragonchain/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/dragonchain/dragonchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dragonchain/dragonchain/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/dragonchain/dragonchain/statuses/479341c9df17f31c5336838de5c3f0c86fa33f58"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Wingman4l7"}}