{"action":"closed","number":14603,"pull_request":{"url":"https://api.github.com/repos/phalcon/cphalcon/pulls/14603","id":350438725,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwNDM4NzI1","html_url":"https://github.com/phalcon/cphalcon/pull/14603","diff_url":"https://github.com/phalcon/cphalcon/pull/14603.diff","patch_url":"https://github.com/phalcon/cphalcon/pull/14603.patch","issue_url":"https://api.github.com/repos/phalcon/cphalcon/issues/14603","number":14603,"state":"closed","locked":false,"title":"Small Http\\Response tests delivery","user":{"login":"jenovateurs","id":3491729,"node_id":"MDQ6VXNlcjM0OTE3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3491729?v=4","gravatar_id":"","url":"https://api.github.com/users/jenovateurs","html_url":"https://github.com/jenovateurs","followers_url":"https://api.github.com/users/jenovateurs/followers","following_url":"https://api.github.com/users/jenovateurs/following{/other_user}","gists_url":"https://api.github.com/users/jenovateurs/gists{/gist_id}","starred_url":"https://api.github.com/users/jenovateurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenovateurs/subscriptions","organizations_url":"https://api.github.com/users/jenovateurs/orgs","repos_url":"https://api.github.com/users/jenovateurs/repos","events_url":"https://api.github.com/users/jenovateurs/events{/privacy}","received_events_url":"https://api.github.com/users/jenovateurs/received_events","type":"User","site_admin":false},"body":"* Type: code quality\r\n* Link to issue: #13655 \r\n\r\nHello!\r\n\r\nI did some tests, some merges with old ones and I hope it's OK.\r\nHere are the new tests for Http\\Response:\r\n* construct()\r\n* get/setContent()\r\n* get/setStatusCode()\r\n* get/setHeaders()\r\n* getReasonPhrase()\r\n* get/setCookies() -> Like I said in #14602, I've had trouble with Cookies which do not exist.\r\n* isSent()\r\n* setExpires()\r\n* get/setHeaders()\r\n* setLastModified()\r\n* setJsonContent()\r\n\r\nThanks for your review and comments :-).\r\n\r\n\r\n","created_at":"2019-12-08T18:11:13Z","updated_at":"2019-12-08T20:46:11Z","closed_at":"2019-12-08T20:46:11Z","merged_at":"2019-12-08T20:46:11Z","merge_commit_sha":"814efea53ac685c7984e4127ac0c87caae18b6a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1416776067,"node_id":"MDU6TGFiZWwxNDE2Nzc2MDY3","url":"https://api.github.com/repos/phalcon/cphalcon/labels/4.0","name":"4.0","color":"90EE90","default":false,"description":"Release: 4.0"},{"id":13573059,"node_id":"MDU6TGFiZWwxMzU3MzA1OQ==","url":"https://api.github.com/repos/phalcon/cphalcon/labels/Bug%20-%20Medium","name":"Bug - Medium","color":"d7e102","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/14603/commits","review_comments_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/14603/comments","review_comment_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phalcon/cphalcon/issues/14603/comments","statuses_url":"https://api.github.com/repos/phalcon/cphalcon/statuses/bf2179d187b1e1df6e9bc9d681395dccf42de79d","head":{"label":"jenovateurs:patch-11","ref":"patch-11","sha":"bf2179d187b1e1df6e9bc9d681395dccf42de79d","user":{"login":"jenovateurs","id":3491729,"node_id":"MDQ6VXNlcjM0OTE3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3491729?v=4","gravatar_id":"","url":"https://api.github.com/users/jenovateurs","html_url":"https://github.com/jenovateurs","followers_url":"https://api.github.com/users/jenovateurs/followers","following_url":"https://api.github.com/users/jenovateurs/following{/other_user}","gists_url":"https://api.github.com/users/jenovateurs/gists{/gist_id}","starred_url":"https://api.github.com/users/jenovateurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenovateurs/subscriptions","organizations_url":"https://api.github.com/users/jenovateurs/orgs","repos_url":"https://api.github.com/users/jenovateurs/repos","events_url":"https://api.github.com/users/jenovateurs/events{/privacy}","received_events_url":"https://api.github.com/users/jenovateurs/received_events","type":"User","site_admin":false},"repo":{"id":226131537,"node_id":"MDEwOlJlcG9zaXRvcnkyMjYxMzE1Mzc=","name":"cphalcon","full_name":"jenovateurs/cphalcon","private":false,"owner":{"login":"jenovateurs","id":3491729,"node_id":"MDQ6VXNlcjM0OTE3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3491729?v=4","gravatar_id":"","url":"https://api.github.com/users/jenovateurs","html_url":"https://github.com/jenovateurs","followers_url":"https://api.github.com/users/jenovateurs/followers","following_url":"https://api.github.com/users/jenovateurs/following{/other_user}","gists_url":"https://api.github.com/users/jenovateurs/gists{/gist_id}","starred_url":"https://api.github.com/users/jenovateurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenovateurs/subscriptions","organizations_url":"https://api.github.com/users/jenovateurs/orgs","repos_url":"https://api.github.com/users/jenovateurs/repos","events_url":"https://api.github.com/users/jenovateurs/events{/privacy}","received_events_url":"https://api.github.com/users/jenovateurs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jenovateurs/cphalcon","description":"High performance, full-stack PHP framework delivered as a C extension.","fork":true,"url":"https://api.github.com/repos/jenovateurs/cphalcon","forks_url":"https://api.github.com/repos/jenovateurs/cphalcon/forks","keys_url":"https://api.github.com/repos/jenovateurs/cphalcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenovateurs/cphalcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenovateurs/cphalcon/teams","hooks_url":"https://api.github.com/repos/jenovateurs/cphalcon/hooks","issue_events_url":"https://api.github.com/repos/jenovateurs/cphalcon/issues/events{/number}","events_url":"https://api.github.com/repos/jenovateurs/cphalcon/events","assignees_url":"https://api.github.com/repos/jenovateurs/cphalcon/assignees{/user}","branches_url":"https://api.github.com/repos/jenovateurs/cphalcon/branches{/branch}","tags_url":"https://api.github.com/repos/jenovateurs/cphalcon/tags","blobs_url":"https://api.github.com/repos/jenovateurs/cphalcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenovateurs/cphalcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenovateurs/cphalcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenovateurs/cphalcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenovateurs/cphalcon/statuses/{sha}","languages_url":"https://api.github.com/repos/jenovateurs/cphalcon/languages","stargazers_url":"https://api.github.com/repos/jenovateurs/cphalcon/stargazers","contributors_url":"https://api.github.com/repos/jenovateurs/cphalcon/contributors","subscribers_url":"https://api.github.com/repos/jenovateurs/cphalcon/subscribers","subscription_url":"https://api.github.com/repos/jenovateurs/cphalcon/subscription","commits_url":"https://api.github.com/repos/jenovateurs/cphalcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenovateurs/cphalcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenovateurs/cphalcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenovateurs/cphalcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenovateurs/cphalcon/contents/{+path}","compare_url":"https://api.github.com/repos/jenovateurs/cphalcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenovateurs/cphalcon/merges","archive_url":"https://api.github.com/repos/jenovateurs/cphalcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenovateurs/cphalcon/downloads","issues_url":"https://api.github.com/repos/jenovateurs/cphalcon/issues{/number}","pulls_url":"https://api.github.com/repos/jenovateurs/cphalcon/pulls{/number}","milestones_url":"https://api.github.com/repos/jenovateurs/cphalcon/milestones{/number}","notifications_url":"https://api.github.com/repos/jenovateurs/cphalcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenovateurs/cphalcon/labels{/name}","releases_url":"https://api.github.com/repos/jenovateurs/cphalcon/releases{/id}","deployments_url":"https://api.github.com/repos/jenovateurs/cphalcon/deployments","created_at":"2019-12-05T15:22:41Z","updated_at":"2019-12-05T15:22:44Z","pushed_at":"2019-12-08T20:32:51Z","git_url":"git://github.com/jenovateurs/cphalcon.git","ssh_url":"git@github.com:jenovateurs/cphalcon.git","clone_url":"https://github.com/jenovateurs/cphalcon.git","svn_url":"https://github.com/jenovateurs/cphalcon","homepage":"https://phalcon.io","size":181641,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phalcon:4.0.x","ref":"4.0.x","sha":"2e8901363300e709dbaf5db276fd5d08ed49cf26","user":{"login":"phalcon","id":1221505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjE1MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1221505?v=4","gravatar_id":"","url":"https://api.github.com/users/phalcon","html_url":"https://github.com/phalcon","followers_url":"https://api.github.com/users/phalcon/followers","following_url":"https://api.github.com/users/phalcon/following{/other_user}","gists_url":"https://api.github.com/users/phalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/phalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phalcon/subscriptions","organizations_url":"https://api.github.com/users/phalcon/orgs","repos_url":"https://api.github.com/users/phalcon/repos","events_url":"https://api.github.com/users/phalcon/events{/privacy}","received_events_url":"https://api.github.com/users/phalcon/received_events","type":"Organization","site_admin":false},"repo":{"id":2854337,"node_id":"MDEwOlJlcG9zaXRvcnkyODU0MzM3","name":"cphalcon","full_name":"phalcon/cphalcon","private":false,"owner":{"login":"phalcon","id":1221505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjE1MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1221505?v=4","gravatar_id":"","url":"https://api.github.com/users/phalcon","html_url":"https://github.com/phalcon","followers_url":"https://api.github.com/users/phalcon/followers","following_url":"https://api.github.com/users/phalcon/following{/other_user}","gists_url":"https://api.github.com/users/phalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/phalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phalcon/subscriptions","organizations_url":"https://api.github.com/users/phalcon/orgs","repos_url":"https://api.github.com/users/phalcon/repos","events_url":"https://api.github.com/users/phalcon/events{/privacy}","received_events_url":"https://api.github.com/users/phalcon/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/phalcon/cphalcon","description":"High performance, full-stack PHP framework delivered as a C extension.","fork":false,"url":"https://api.github.com/repos/phalcon/cphalcon","forks_url":"https://api.github.com/repos/phalcon/cphalcon/forks","keys_url":"https://api.github.com/repos/phalcon/cphalcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phalcon/cphalcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phalcon/cphalcon/teams","hooks_url":"https://api.github.com/repos/phalcon/cphalcon/hooks","issue_events_url":"https://api.github.com/repos/phalcon/cphalcon/issues/events{/number}","events_url":"https://api.github.com/repos/phalcon/cphalcon/events","assignees_url":"https://api.github.com/repos/phalcon/cphalcon/assignees{/user}","branches_url":"https://api.github.com/repos/phalcon/cphalcon/branches{/branch}","tags_url":"https://api.github.com/repos/phalcon/cphalcon/tags","blobs_url":"https://api.github.com/repos/phalcon/cphalcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phalcon/cphalcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phalcon/cphalcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/phalcon/cphalcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phalcon/cphalcon/statuses/{sha}","languages_url":"https://api.github.com/repos/phalcon/cphalcon/languages","stargazers_url":"https://api.github.com/repos/phalcon/cphalcon/stargazers","contributors_url":"https://api.github.com/repos/phalcon/cphalcon/contributors","subscribers_url":"https://api.github.com/repos/phalcon/cphalcon/subscribers","subscription_url":"https://api.github.com/repos/phalcon/cphalcon/subscription","commits_url":"https://api.github.com/repos/phalcon/cphalcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/phalcon/cphalcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/phalcon/cphalcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/phalcon/cphalcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/phalcon/cphalcon/contents/{+path}","compare_url":"https://api.github.com/repos/phalcon/cphalcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phalcon/cphalcon/merges","archive_url":"https://api.github.com/repos/phalcon/cphalcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phalcon/cphalcon/downloads","issues_url":"https://api.github.com/repos/phalcon/cphalcon/issues{/number}","pulls_url":"https://api.github.com/repos/phalcon/cphalcon/pulls{/number}","milestones_url":"https://api.github.com/repos/phalcon/cphalcon/milestones{/number}","notifications_url":"https://api.github.com/repos/phalcon/cphalcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phalcon/cphalcon/labels{/name}","releases_url":"https://api.github.com/repos/phalcon/cphalcon/releases{/id}","deployments_url":"https://api.github.com/repos/phalcon/cphalcon/deployments","created_at":"2011-11-26T05:52:50Z","updated_at":"2019-12-07T18:41:39Z","pushed_at":"2019-12-08T20:46:11Z","git_url":"git://github.com/phalcon/cphalcon.git","ssh_url":"git@github.com:phalcon/cphalcon.git","clone_url":"https://github.com/phalcon/cphalcon.git","svn_url":"https://github.com/phalcon/cphalcon","homepage":"https://phalcon.io","size":181662,"stargazers_count":9985,"watchers_count":9985,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1809,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":109,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1809,"open_issues":109,"watchers":9985,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/14603"},"html":{"href":"https://github.com/phalcon/cphalcon/pull/14603"},"issue":{"href":"https://api.github.com/repos/phalcon/cphalcon/issues/14603"},"comments":{"href":"https://api.github.com/repos/phalcon/cphalcon/issues/14603/comments"},"review_comments":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/14603/comments"},"review_comment":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/14603/commits"},"statuses":{"href":"https://api.github.com/repos/phalcon/cphalcon/statuses/bf2179d187b1e1df6e9bc9d681395dccf42de79d"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"niden","id":1073784,"node_id":"MDQ6VXNlcjEwNzM3ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1073784?v=4","gravatar_id":"","url":"https://api.github.com/users/niden","html_url":"https://github.com/niden","followers_url":"https://api.github.com/users/niden/followers","following_url":"https://api.github.com/users/niden/following{/other_user}","gists_url":"https://api.github.com/users/niden/gists{/gist_id}","starred_url":"https://api.github.com/users/niden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niden/subscriptions","organizations_url":"https://api.github.com/users/niden/orgs","repos_url":"https://api.github.com/users/niden/repos","events_url":"https://api.github.com/users/niden/events{/privacy}","received_events_url":"https://api.github.com/users/niden/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":21,"additions":334,"deletions":236,"changed_files":16}}
{"actor":{"display_login":"niden"}}