{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/291444092","pull_request_review_id":246904833,"id":291444092,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTQ0NDA5Mg==","diff_hunk":"@@ -416,6 +424,20 @@ - (void)setImageRenderingMode:(UIImageRenderingMode)imageRenderingMode {\n   [self.tableView reloadData];\n }\n \n+- (void)setAlignTitles:(BOOL)alignTitles {\n+  _alignTitles = alignTitles;\n+  BOOL addPaddingToCells = NO;\n+  // Check to make sure atleast one action has an image. If not then all actions will align already\n+  // and we don't need to add padding.\n+  for (MDCActionSheetAction *action in self.actions) {\n+    if (action.image) {\n+      addPaddingToCells = YES;\n+    }\n+  }","path":"components/ActionSheet/src/MDCActionSheetController.m","position":39,"original_position":35,"commit_id":"d0c1f9536f337a94f47f1c1fe000e8a0f235f0b4","original_commit_id":"c4fb630a7c54d955319936c3ac263fabe47bea05","user":{"login":"codeman7","id":7131294,"node_id":"MDQ6VXNlcjcxMzEyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7131294?v=4","gravatar_id":"","url":"https://api.github.com/users/codeman7","html_url":"https://github.com/codeman7","followers_url":"https://api.github.com/users/codeman7/followers","following_url":"https://api.github.com/users/codeman7/following{/other_user}","gists_url":"https://api.github.com/users/codeman7/gists{/gist_id}","starred_url":"https://api.github.com/users/codeman7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeman7/subscriptions","organizations_url":"https://api.github.com/users/codeman7/orgs","repos_url":"https://api.github.com/users/codeman7/repos","events_url":"https://api.github.com/users/codeman7/events{/privacy}","received_events_url":"https://api.github.com/users/codeman7/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2019-06-07T03:45:04Z","updated_at":"2019-06-07T03:45:05Z","html_url":"https://github.com/material-components/material-components-ios/pull/7548#discussion_r291444092","pull_request_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/7548","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/291444092"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/7548#discussion_r291444092"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/7548"}},"in_reply_to_id":291442775},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/7548","id":286026667,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2MDI2NjY3","html_url":"https://github.com/material-components/material-components-ios/pull/7548","diff_url":"https://github.com/material-components/material-components-ios/pull/7548.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/7548.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/7548","number":7548,"state":"open","locked":false,"title":"[ActionSheet] Allow clients to align titles if only some actions have images.","user":{"login":"codeman7","id":7131294,"node_id":"MDQ6VXNlcjcxMzEyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7131294?v=4","gravatar_id":"","url":"https://api.github.com/users/codeman7","html_url":"https://github.com/codeman7","followers_url":"https://api.github.com/users/codeman7/followers","following_url":"https://api.github.com/users/codeman7/following{/other_user}","gists_url":"https://api.github.com/users/codeman7/gists{/gist_id}","starred_url":"https://api.github.com/users/codeman7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeman7/subscriptions","organizations_url":"https://api.github.com/users/codeman7/orgs","repos_url":"https://api.github.com/users/codeman7/repos","events_url":"https://api.github.com/users/codeman7/events{/privacy}","received_events_url":"https://api.github.com/users/codeman7/received_events","type":"User","site_admin":false},"body":"This adds functionality to MDCActionSheetController to allow clients to align the titles even if some actions have images and others don't. If a client sets this flag to `YES` but none of the actions have images then we need to make sure that we don't add padding to the cells, that check is in the setter. Additionally the setter reloads the data so that if a client sets this property after and _ActionSheet_ has been presented then the table would update. Test were added for the `init` for both `MDCActionSheetController` and `MDCActionSheetItemTableViewCell` but only for the property added here, this is to minimize the changes in this PR. I have opened up # to track adding test for all default properties.\r\n\r\nCloses #7484 \r\n","created_at":"2019-06-07T02:08:16Z","updated_at":"2019-06-07T03:45:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aec89dcada69a56f42064fd2c9c4efe127ce75d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1004918311,"node_id":"MDU6TGFiZWwxMDA0OTE4MzEx","url":"https://api.github.com/repos/material-components/material-components-ios/labels/[ActionSheet]","name":"[ActionSheet]","color":"eeeeee","default":false},{"id":273191333,"node_id":"MDU6TGFiZWwyNzMxOTEzMzM=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/7548/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/7548/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/7548/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/d0c1f9536f337a94f47f1c1fe000e8a0f235f0b4","head":{"label":"codeman7:action-sheet-titles","ref":"action-sheet-titles","sha":"d0c1f9536f337a94f47f1c1fe000e8a0f235f0b4","user":{"login":"codeman7","id":7131294,"node_id":"MDQ6VXNlcjcxMzEyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7131294?v=4","gravatar_id":"","url":"https://api.github.com/users/codeman7","html_url":"https://github.com/codeman7","followers_url":"https://api.github.com/users/codeman7/followers","following_url":"https://api.github.com/users/codeman7/following{/other_user}","gists_url":"https://api.github.com/users/codeman7/gists{/gist_id}","starred_url":"https://api.github.com/users/codeman7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeman7/subscriptions","organizations_url":"https://api.github.com/users/codeman7/orgs","repos_url":"https://api.github.com/users/codeman7/repos","events_url":"https://api.github.com/users/codeman7/events{/privacy}","received_events_url":"https://api.github.com/users/codeman7/received_events","type":"User","site_admin":false},"repo":{"id":153677219,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2NzcyMTk=","name":"material-components-ios","full_name":"codeman7/material-components-ios","private":false,"owner":{"login":"codeman7","id":7131294,"node_id":"MDQ6VXNlcjcxMzEyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7131294?v=4","gravatar_id":"","url":"https://api.github.com/users/codeman7","html_url":"https://github.com/codeman7","followers_url":"https://api.github.com/users/codeman7/followers","following_url":"https://api.github.com/users/codeman7/following{/other_user}","gists_url":"https://api.github.com/users/codeman7/gists{/gist_id}","starred_url":"https://api.github.com/users/codeman7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeman7/subscriptions","organizations_url":"https://api.github.com/users/codeman7/orgs","repos_url":"https://api.github.com/users/codeman7/repos","events_url":"https://api.github.com/users/codeman7/events{/privacy}","received_events_url":"https://api.github.com/users/codeman7/received_events","type":"User","site_admin":false},"html_url":"https://github.com/codeman7/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/codeman7/material-components-ios","forks_url":"https://api.github.com/repos/codeman7/material-components-ios/forks","keys_url":"https://api.github.com/repos/codeman7/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeman7/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeman7/material-components-ios/teams","hooks_url":"https://api.github.com/repos/codeman7/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/codeman7/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/codeman7/material-components-ios/events","assignees_url":"https://api.github.com/repos/codeman7/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/codeman7/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/codeman7/material-components-ios/tags","blobs_url":"https://api.github.com/repos/codeman7/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeman7/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeman7/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeman7/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeman7/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/codeman7/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/codeman7/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/codeman7/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/codeman7/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/codeman7/material-components-ios/subscription","commits_url":"https://api.github.com/repos/codeman7/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeman7/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeman7/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeman7/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeman7/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/codeman7/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeman7/material-components-ios/merges","archive_url":"https://api.github.com/repos/codeman7/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeman7/material-components-ios/downloads","issues_url":"https://api.github.com/repos/codeman7/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/codeman7/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/codeman7/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/codeman7/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeman7/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/codeman7/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/codeman7/material-components-ios/deployments","created_at":"2018-10-18T19:32:13Z","updated_at":"2019-06-07T03:08:49Z","pushed_at":"2019-06-07T03:44:56Z","git_url":"git://github.com/codeman7/material-components-ios.git","ssh_url":"git@github.com:codeman7/material-components-ios.git","clone_url":"https://github.com/codeman7/material-components-ios.git","svn_url":"https://github.com/codeman7/material-components-ios","homepage":"","size":143822,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"fd142cc6c6ae524867884973eec63a063bc4c44d","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgyMDIxOQ==","name":"material-components-ios","full_name":"material-components/material-components-ios","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2019-06-07T03:08:22Z","pushed_at":"2019-06-07T03:44:58Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":143260,"stargazers_count":3497,"watchers_count":3497,"language":"Objective-C","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":568,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1032,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":568,"open_issues":1032,"watchers":3497,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/7548"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/7548"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/7548"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/7548/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/7548/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/7548/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/d0c1f9536f337a94f47f1c1fe000e8a0f235f0b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codeman7"}}