{"action":"created","comment":{"url":"https://api.github.com/repos/vuejs/vue-next/pulls/comments/334562158","pull_request_review_id":301412064,"id":334562158,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDU2MjE1OA==","diff_hunk":"@@ -219,11 +221,25 @@ export const setCurrentInstance = (\n   currentInstance = instance\n }\n \n+export function validateComponentName(name: string, config: AppConfig) {\n+  const appIsNativeTag = config.isNativeTag || NO\n+  if (isBuiltInTag(name) || appIsNativeTag(name)) {\n+    warn(\n+      'Do not use built-in or reserved HTML elements as component id: ' + name\n+    )\n+  }\n+}\n+\n export function setupStatefulComponent(\n   instance: ComponentInternalInstance,\n   parentSuspense: SuspenseBoundary | null\n ) {\n   const Component = instance.type as ComponentOptions\n+\n+  if (__DEV__ && Component.name) {\n+    validateComponentName(Component.name, instance.appContext.config)","path":"packages/runtime-core/src/component.ts","position":null,"original_position":40,"commit_id":"3d629ae103f9bfbc6c0ae0643f86581821116a1f","original_commit_id":"79a085996853d75a188e9633c0063af8956c4371","user":{"login":"CodeDaraW","id":12277082,"node_id":"MDQ6VXNlcjEyMjc3MDgy","avatar_url":"https://avatars2.githubusercontent.com/u/12277082?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeDaraW","html_url":"https://github.com/CodeDaraW","followers_url":"https://api.github.com/users/CodeDaraW/followers","following_url":"https://api.github.com/users/CodeDaraW/following{/other_user}","gists_url":"https://api.github.com/users/CodeDaraW/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeDaraW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeDaraW/subscriptions","organizations_url":"https://api.github.com/users/CodeDaraW/orgs","repos_url":"https://api.github.com/users/CodeDaraW/repos","events_url":"https://api.github.com/users/CodeDaraW/events{/privacy}","received_events_url":"https://api.github.com/users/CodeDaraW/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2019-10-14T16:24:26Z","updated_at":"2019-10-14T16:24:26Z","html_url":"https://github.com/vuejs/vue-next/pull/217#discussion_r334562158","pull_request_url":"https://api.github.com/repos/vuejs/vue-next/pulls/217","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vuejs/vue-next/pulls/comments/334562158"},"html":{"href":"https://github.com/vuejs/vue-next/pull/217#discussion_r334562158"},"pull_request":{"href":"https://api.github.com/repos/vuejs/vue-next/pulls/217"}},"in_reply_to_id":334318490},"pull_request":{"url":"https://api.github.com/repos/vuejs/vue-next/pulls/217","id":327305776,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3MzA1Nzc2","html_url":"https://github.com/vuejs/vue-next/pull/217","diff_url":"https://github.com/vuejs/vue-next/pull/217.diff","patch_url":"https://github.com/vuejs/vue-next/pull/217.patch","issue_url":"https://api.github.com/repos/vuejs/vue-next/issues/217","number":217,"state":"open","locked":false,"title":"feat: runtime component name validation","user":{"login":"CodeDaraW","id":12277082,"node_id":"MDQ6VXNlcjEyMjc3MDgy","avatar_url":"https://avatars2.githubusercontent.com/u/12277082?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeDaraW","html_url":"https://github.com/CodeDaraW","followers_url":"https://api.github.com/users/CodeDaraW/followers","following_url":"https://api.github.com/users/CodeDaraW/following{/other_user}","gists_url":"https://api.github.com/users/CodeDaraW/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeDaraW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeDaraW/subscriptions","organizations_url":"https://api.github.com/users/CodeDaraW/orgs","repos_url":"https://api.github.com/users/CodeDaraW/repos","events_url":"https://api.github.com/users/CodeDaraW/events{/privacy}","received_events_url":"https://api.github.com/users/CodeDaraW/received_events","type":"User","site_admin":false},"body":"See #139","created_at":"2019-10-11T17:55:58Z","updated_at":"2019-10-14T16:24:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24864a3b81d52b9501dd59a59515812e1dcc7a01","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vuejs/vue-next/pulls/217/commits","review_comments_url":"https://api.github.com/repos/vuejs/vue-next/pulls/217/comments","review_comment_url":"https://api.github.com/repos/vuejs/vue-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vuejs/vue-next/issues/217/comments","statuses_url":"https://api.github.com/repos/vuejs/vue-next/statuses/3d629ae103f9bfbc6c0ae0643f86581821116a1f","head":{"label":"CodeDaraW:feat/runtime-component-name-validation","ref":"feat/runtime-component-name-validation","sha":"3d629ae103f9bfbc6c0ae0643f86581821116a1f","user":{"login":"CodeDaraW","id":12277082,"node_id":"MDQ6VXNlcjEyMjc3MDgy","avatar_url":"https://avatars2.githubusercontent.com/u/12277082?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeDaraW","html_url":"https://github.com/CodeDaraW","followers_url":"https://api.github.com/users/CodeDaraW/followers","following_url":"https://api.github.com/users/CodeDaraW/following{/other_user}","gists_url":"https://api.github.com/users/CodeDaraW/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeDaraW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeDaraW/subscriptions","organizations_url":"https://api.github.com/users/CodeDaraW/orgs","repos_url":"https://api.github.com/users/CodeDaraW/repos","events_url":"https://api.github.com/users/CodeDaraW/events{/privacy}","received_events_url":"https://api.github.com/users/CodeDaraW/received_events","type":"User","site_admin":false},"repo":{"id":213002756,"node_id":"MDEwOlJlcG9zaXRvcnkyMTMwMDI3NTY=","name":"vue-next","full_name":"CodeDaraW/vue-next","private":false,"owner":{"login":"CodeDaraW","id":12277082,"node_id":"MDQ6VXNlcjEyMjc3MDgy","avatar_url":"https://avatars2.githubusercontent.com/u/12277082?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeDaraW","html_url":"https://github.com/CodeDaraW","followers_url":"https://api.github.com/users/CodeDaraW/followers","following_url":"https://api.github.com/users/CodeDaraW/following{/other_user}","gists_url":"https://api.github.com/users/CodeDaraW/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeDaraW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeDaraW/subscriptions","organizations_url":"https://api.github.com/users/CodeDaraW/orgs","repos_url":"https://api.github.com/users/CodeDaraW/repos","events_url":"https://api.github.com/users/CodeDaraW/events{/privacy}","received_events_url":"https://api.github.com/users/CodeDaraW/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CodeDaraW/vue-next","description":null,"fork":true,"url":"https://api.github.com/repos/CodeDaraW/vue-next","forks_url":"https://api.github.com/repos/CodeDaraW/vue-next/forks","keys_url":"https://api.github.com/repos/CodeDaraW/vue-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeDaraW/vue-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeDaraW/vue-next/teams","hooks_url":"https://api.github.com/repos/CodeDaraW/vue-next/hooks","issue_events_url":"https://api.github.com/repos/CodeDaraW/vue-next/issues/events{/number}","events_url":"https://api.github.com/repos/CodeDaraW/vue-next/events","assignees_url":"https://api.github.com/repos/CodeDaraW/vue-next/assignees{/user}","branches_url":"https://api.github.com/repos/CodeDaraW/vue-next/branches{/branch}","tags_url":"https://api.github.com/repos/CodeDaraW/vue-next/tags","blobs_url":"https://api.github.com/repos/CodeDaraW/vue-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeDaraW/vue-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeDaraW/vue-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeDaraW/vue-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeDaraW/vue-next/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeDaraW/vue-next/languages","stargazers_url":"https://api.github.com/repos/CodeDaraW/vue-next/stargazers","contributors_url":"https://api.github.com/repos/CodeDaraW/vue-next/contributors","subscribers_url":"https://api.github.com/repos/CodeDaraW/vue-next/subscribers","subscription_url":"https://api.github.com/repos/CodeDaraW/vue-next/subscription","commits_url":"https://api.github.com/repos/CodeDaraW/vue-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeDaraW/vue-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeDaraW/vue-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeDaraW/vue-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeDaraW/vue-next/contents/{+path}","compare_url":"https://api.github.com/repos/CodeDaraW/vue-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeDaraW/vue-next/merges","archive_url":"https://api.github.com/repos/CodeDaraW/vue-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeDaraW/vue-next/downloads","issues_url":"https://api.github.com/repos/CodeDaraW/vue-next/issues{/number}","pulls_url":"https://api.github.com/repos/CodeDaraW/vue-next/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeDaraW/vue-next/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeDaraW/vue-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeDaraW/vue-next/labels{/name}","releases_url":"https://api.github.com/repos/CodeDaraW/vue-next/releases{/id}","deployments_url":"https://api.github.com/repos/CodeDaraW/vue-next/deployments","created_at":"2019-10-05T13:19:04Z","updated_at":"2019-10-11T02:48:13Z","pushed_at":"2019-10-14T16:21:38Z","git_url":"git://github.com/CodeDaraW/vue-next.git","ssh_url":"git@github.com:CodeDaraW/vue-next.git","clone_url":"https://github.com/CodeDaraW/vue-next.git","svn_url":"https://github.com/CodeDaraW/vue-next","homepage":null,"size":1543,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vuejs:master","ref":"master","sha":"5f28708cb99c631302b0cc1ccc14c1fc71af0730","user":{"login":"vuejs","id":6128107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMjgxMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6128107?v=4","gravatar_id":"","url":"https://api.github.com/users/vuejs","html_url":"https://github.com/vuejs","followers_url":"https://api.github.com/users/vuejs/followers","following_url":"https://api.github.com/users/vuejs/following{/other_user}","gists_url":"https://api.github.com/users/vuejs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuejs/subscriptions","organizations_url":"https://api.github.com/users/vuejs/orgs","repos_url":"https://api.github.com/users/vuejs/repos","events_url":"https://api.github.com/users/vuejs/events{/privacy}","received_events_url":"https://api.github.com/users/vuejs/received_events","type":"Organization","site_admin":false},"repo":{"id":137078487,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwNzg0ODc=","name":"vue-next","full_name":"vuejs/vue-next","private":false,"owner":{"login":"vuejs","id":6128107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMjgxMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6128107?v=4","gravatar_id":"","url":"https://api.github.com/users/vuejs","html_url":"https://github.com/vuejs","followers_url":"https://api.github.com/users/vuejs/followers","following_url":"https://api.github.com/users/vuejs/following{/other_user}","gists_url":"https://api.github.com/users/vuejs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuejs/subscriptions","organizations_url":"https://api.github.com/users/vuejs/orgs","repos_url":"https://api.github.com/users/vuejs/repos","events_url":"https://api.github.com/users/vuejs/events{/privacy}","received_events_url":"https://api.github.com/users/vuejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vuejs/vue-next","description":null,"fork":false,"url":"https://api.github.com/repos/vuejs/vue-next","forks_url":"https://api.github.com/repos/vuejs/vue-next/forks","keys_url":"https://api.github.com/repos/vuejs/vue-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuejs/vue-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuejs/vue-next/teams","hooks_url":"https://api.github.com/repos/vuejs/vue-next/hooks","issue_events_url":"https://api.github.com/repos/vuejs/vue-next/issues/events{/number}","events_url":"https://api.github.com/repos/vuejs/vue-next/events","assignees_url":"https://api.github.com/repos/vuejs/vue-next/assignees{/user}","branches_url":"https://api.github.com/repos/vuejs/vue-next/branches{/branch}","tags_url":"https://api.github.com/repos/vuejs/vue-next/tags","blobs_url":"https://api.github.com/repos/vuejs/vue-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuejs/vue-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuejs/vue-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuejs/vue-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuejs/vue-next/statuses/{sha}","languages_url":"https://api.github.com/repos/vuejs/vue-next/languages","stargazers_url":"https://api.github.com/repos/vuejs/vue-next/stargazers","contributors_url":"https://api.github.com/repos/vuejs/vue-next/contributors","subscribers_url":"https://api.github.com/repos/vuejs/vue-next/subscribers","subscription_url":"https://api.github.com/repos/vuejs/vue-next/subscription","commits_url":"https://api.github.com/repos/vuejs/vue-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuejs/vue-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuejs/vue-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuejs/vue-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuejs/vue-next/contents/{+path}","compare_url":"https://api.github.com/repos/vuejs/vue-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuejs/vue-next/merges","archive_url":"https://api.github.com/repos/vuejs/vue-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuejs/vue-next/downloads","issues_url":"https://api.github.com/repos/vuejs/vue-next/issues{/number}","pulls_url":"https://api.github.com/repos/vuejs/vue-next/pulls{/number}","milestones_url":"https://api.github.com/repos/vuejs/vue-next/milestones{/number}","notifications_url":"https://api.github.com/repos/vuejs/vue-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuejs/vue-next/labels{/name}","releases_url":"https://api.github.com/repos/vuejs/vue-next/releases{/id}","deployments_url":"https://api.github.com/repos/vuejs/vue-next/deployments","created_at":"2018-06-12T13:49:36Z","updated_at":"2019-10-14T16:21:11Z","pushed_at":"2019-10-14T16:21:40Z","git_url":"git://github.com/vuejs/vue-next.git","ssh_url":"git@github.com:vuejs/vue-next.git","clone_url":"https://github.com/vuejs/vue-next.git","svn_url":"https://github.com/vuejs/vue-next","homepage":null,"size":1607,"stargazers_count":5881,"watchers_count":5881,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1003,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":null,"forks":1003,"open_issues":30,"watchers":5881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vuejs/vue-next/pulls/217"},"html":{"href":"https://github.com/vuejs/vue-next/pull/217"},"issue":{"href":"https://api.github.com/repos/vuejs/vue-next/issues/217"},"comments":{"href":"https://api.github.com/repos/vuejs/vue-next/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/vuejs/vue-next/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/vuejs/vue-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vuejs/vue-next/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/vuejs/vue-next/statuses/3d629ae103f9bfbc6c0ae0643f86581821116a1f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CodeDaraW"}}