{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/axe-windows/pulls/comments/291298458","pull_request_review_id":246720260,"id":291298458,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTI5ODQ1OA==","diff_hunk":"@@ -0,0 +1,29 @@\n+﻿// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+using System;\n+\n+namespace Axe.Windows.Automation\n+{\n+    /// <summary>\n+    /// Runs AxeWindows automated tests\n+    /// </summary>\n+    public interface IScanner\n+    {\n+        /// <summary>\n+        /// Run AxeWindows automated tests\n+        /// </summary>\n+        /// <remarks>\n+        /// If a value was provided in <see cref=\"Config.OutputDirectory\"/>,\n+        /// output files may be written to the specified directory.\n+        /// (Note: no output files will be written if no errors were found.)\n+        /// An exception may be thrown if the value of <see cref=\"Config.ProcessId\"/> is invalid\n+        /// or if the directory provided in <see cref=\"Config.OutputDirectory\"/> does not exist.","path":"src/Automation/Interfaces/IScanner.cs","position":20,"original_position":20,"commit_id":"360f21f8f6079b1312416dab6088b677c860f5da","original_commit_id":"360f21f8f6079b1312416dab6088b677c860f5da","user":{"login":"RobGallo","id":43080011,"node_id":"MDQ6VXNlcjQzMDgwMDEx","avatar_url":"https://avatars3.githubusercontent.com/u/43080011?v=4","gravatar_id":"","url":"https://api.github.com/users/RobGallo","html_url":"https://github.com/RobGallo","followers_url":"https://api.github.com/users/RobGallo/followers","following_url":"https://api.github.com/users/RobGallo/following{/other_user}","gists_url":"https://api.github.com/users/RobGallo/gists{/gist_id}","starred_url":"https://api.github.com/users/RobGallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobGallo/subscriptions","organizations_url":"https://api.github.com/users/RobGallo/orgs","repos_url":"https://api.github.com/users/RobGallo/repos","events_url":"https://api.github.com/users/RobGallo/events{/privacy}","received_events_url":"https://api.github.com/users/RobGallo/received_events","type":"User","site_admin":false},"body":"I do agree. I just didn't remember there was a comment specifically calling this out.","created_at":"2019-06-06T17:47:18Z","updated_at":"2019-06-06T17:47:18Z","html_url":"https://github.com/microsoft/axe-windows/pull/46#discussion_r291298458","pull_request_url":"https://api.github.com/repos/microsoft/axe-windows/pulls/46","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/microsoft/axe-windows/pulls/comments/291298458"},"html":{"href":"https://github.com/microsoft/axe-windows/pull/46#discussion_r291298458"},"pull_request":{"href":"https://api.github.com/repos/microsoft/axe-windows/pulls/46"}},"in_reply_to_id":290937202},"pull_request":{"url":"https://api.github.com/repos/microsoft/axe-windows/pulls/46","id":285549832,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1NTQ5ODMy","html_url":"https://github.com/microsoft/axe-windows/pull/46","diff_url":"https://github.com/microsoft/axe-windows/pull/46.diff","patch_url":"https://github.com/microsoft/axe-windows/pull/46.patch","issue_url":"https://api.github.com/repos/microsoft/axe-windows/issues/46","number":46,"state":"open","locked":false,"title":"Add new interface model for Axe.Windows.Automation","user":{"login":"RobGallo","id":43080011,"node_id":"MDQ6VXNlcjQzMDgwMDEx","avatar_url":"https://avatars3.githubusercontent.com/u/43080011?v=4","gravatar_id":"","url":"https://api.github.com/users/RobGallo","html_url":"https://github.com/RobGallo","followers_url":"https://api.github.com/users/RobGallo/followers","following_url":"https://api.github.com/users/RobGallo/following{/other_user}","gists_url":"https://api.github.com/users/RobGallo/gists{/gist_id}","starred_url":"https://api.github.com/users/RobGallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobGallo/subscriptions","organizations_url":"https://api.github.com/users/RobGallo/orgs","repos_url":"https://api.github.com/users/RobGallo/repos","events_url":"https://api.github.com/users/RobGallo/events{/privacy}","received_events_url":"https://api.github.com/users/RobGallo/received_events","type":"User","site_admin":false},"body":"#### Describe the change\r\n\r\nThe model has not been implemented yet, except for the Config class and the ScannerFactory class.\r\n\r\nChanges since the last design review:\r\n- Change ScanResult.OutputFiles from an IEnumerable to a Tuple: (string A11yTest, string Sarif) so that output files are grouped together, but still distinguishable by type\r\n- Removed Scanner.Builder and created ScannerFactory since creating new objects which implement a specific interface is the job of a factory. It also hides the implementation of Scanner entirely.\r\n- For the returned data classes, changed private access to internal access because we don't need to manage construction of these classes with a builder.\r\n\r\n\r\n> Note: After the PR has been created, certain checks will be kicked off. All of these checks must pass before a merge. \r\n\r\n\r\n\r\n","created_at":"2019-06-05T21:02:19Z","updated_at":"2019-06-06T17:47:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54933bf85fa570d18761e9cb5fdb1c153aece36d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/axe-windows/pulls/46/commits","review_comments_url":"https://api.github.com/repos/microsoft/axe-windows/pulls/46/comments","review_comment_url":"https://api.github.com/repos/microsoft/axe-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/axe-windows/issues/46/comments","statuses_url":"https://api.github.com/repos/microsoft/axe-windows/statuses/360f21f8f6079b1312416dab6088b677c860f5da","head":{"label":"RobGallo:auto","ref":"auto","sha":"360f21f8f6079b1312416dab6088b677c860f5da","user":{"login":"RobGallo","id":43080011,"node_id":"MDQ6VXNlcjQzMDgwMDEx","avatar_url":"https://avatars3.githubusercontent.com/u/43080011?v=4","gravatar_id":"","url":"https://api.github.com/users/RobGallo","html_url":"https://github.com/RobGallo","followers_url":"https://api.github.com/users/RobGallo/followers","following_url":"https://api.github.com/users/RobGallo/following{/other_user}","gists_url":"https://api.github.com/users/RobGallo/gists{/gist_id}","starred_url":"https://api.github.com/users/RobGallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobGallo/subscriptions","organizations_url":"https://api.github.com/users/RobGallo/orgs","repos_url":"https://api.github.com/users/RobGallo/repos","events_url":"https://api.github.com/users/RobGallo/events{/privacy}","received_events_url":"https://api.github.com/users/RobGallo/received_events","type":"User","site_admin":false},"repo":{"id":183249427,"node_id":"MDEwOlJlcG9zaXRvcnkxODMyNDk0Mjc=","name":"axe-windows","full_name":"RobGallo/axe-windows","private":false,"owner":{"login":"RobGallo","id":43080011,"node_id":"MDQ6VXNlcjQzMDgwMDEx","avatar_url":"https://avatars3.githubusercontent.com/u/43080011?v=4","gravatar_id":"","url":"https://api.github.com/users/RobGallo","html_url":"https://github.com/RobGallo","followers_url":"https://api.github.com/users/RobGallo/followers","following_url":"https://api.github.com/users/RobGallo/following{/other_user}","gists_url":"https://api.github.com/users/RobGallo/gists{/gist_id}","starred_url":"https://api.github.com/users/RobGallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobGallo/subscriptions","organizations_url":"https://api.github.com/users/RobGallo/orgs","repos_url":"https://api.github.com/users/RobGallo/repos","events_url":"https://api.github.com/users/RobGallo/events{/privacy}","received_events_url":"https://api.github.com/users/RobGallo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RobGallo/axe-windows","description":"Automated accessibility testing engine for Windows applications","fork":true,"url":"https://api.github.com/repos/RobGallo/axe-windows","forks_url":"https://api.github.com/repos/RobGallo/axe-windows/forks","keys_url":"https://api.github.com/repos/RobGallo/axe-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RobGallo/axe-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RobGallo/axe-windows/teams","hooks_url":"https://api.github.com/repos/RobGallo/axe-windows/hooks","issue_events_url":"https://api.github.com/repos/RobGallo/axe-windows/issues/events{/number}","events_url":"https://api.github.com/repos/RobGallo/axe-windows/events","assignees_url":"https://api.github.com/repos/RobGallo/axe-windows/assignees{/user}","branches_url":"https://api.github.com/repos/RobGallo/axe-windows/branches{/branch}","tags_url":"https://api.github.com/repos/RobGallo/axe-windows/tags","blobs_url":"https://api.github.com/repos/RobGallo/axe-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RobGallo/axe-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RobGallo/axe-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/RobGallo/axe-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RobGallo/axe-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/RobGallo/axe-windows/languages","stargazers_url":"https://api.github.com/repos/RobGallo/axe-windows/stargazers","contributors_url":"https://api.github.com/repos/RobGallo/axe-windows/contributors","subscribers_url":"https://api.github.com/repos/RobGallo/axe-windows/subscribers","subscription_url":"https://api.github.com/repos/RobGallo/axe-windows/subscription","commits_url":"https://api.github.com/repos/RobGallo/axe-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/RobGallo/axe-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/RobGallo/axe-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/RobGallo/axe-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/RobGallo/axe-windows/contents/{+path}","compare_url":"https://api.github.com/repos/RobGallo/axe-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RobGallo/axe-windows/merges","archive_url":"https://api.github.com/repos/RobGallo/axe-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RobGallo/axe-windows/downloads","issues_url":"https://api.github.com/repos/RobGallo/axe-windows/issues{/number}","pulls_url":"https://api.github.com/repos/RobGallo/axe-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/RobGallo/axe-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/RobGallo/axe-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RobGallo/axe-windows/labels{/name}","releases_url":"https://api.github.com/repos/RobGallo/axe-windows/releases{/id}","deployments_url":"https://api.github.com/repos/RobGallo/axe-windows/deployments","created_at":"2019-04-24T14:47:20Z","updated_at":"2019-06-05T20:35:50Z","pushed_at":"2019-06-05T21:00:52Z","git_url":"git://github.com/RobGallo/axe-windows.git","ssh_url":"git@github.com:RobGallo/axe-windows.git","clone_url":"https://github.com/RobGallo/axe-windows.git","svn_url":"https://github.com/RobGallo/axe-windows","homepage":null,"size":774,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"cc7330c8ee11191203321e571f96b1c0f5d4cd6a","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":182308830,"node_id":"MDEwOlJlcG9zaXRvcnkxODIzMDg4MzA=","name":"axe-windows","full_name":"microsoft/axe-windows","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/axe-windows","description":"Automated accessibility testing engine for Windows applications","fork":false,"url":"https://api.github.com/repos/microsoft/axe-windows","forks_url":"https://api.github.com/repos/microsoft/axe-windows/forks","keys_url":"https://api.github.com/repos/microsoft/axe-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/axe-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/axe-windows/teams","hooks_url":"https://api.github.com/repos/microsoft/axe-windows/hooks","issue_events_url":"https://api.github.com/repos/microsoft/axe-windows/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/axe-windows/events","assignees_url":"https://api.github.com/repos/microsoft/axe-windows/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/axe-windows/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/axe-windows/tags","blobs_url":"https://api.github.com/repos/microsoft/axe-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/axe-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/axe-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/axe-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/axe-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/axe-windows/languages","stargazers_url":"https://api.github.com/repos/microsoft/axe-windows/stargazers","contributors_url":"https://api.github.com/repos/microsoft/axe-windows/contributors","subscribers_url":"https://api.github.com/repos/microsoft/axe-windows/subscribers","subscription_url":"https://api.github.com/repos/microsoft/axe-windows/subscription","commits_url":"https://api.github.com/repos/microsoft/axe-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/axe-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/axe-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/axe-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/axe-windows/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/axe-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/axe-windows/merges","archive_url":"https://api.github.com/repos/microsoft/axe-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/axe-windows/downloads","issues_url":"https://api.github.com/repos/microsoft/axe-windows/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/axe-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/axe-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/axe-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/axe-windows/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/axe-windows/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/axe-windows/deployments","created_at":"2019-04-19T18:29:40Z","updated_at":"2019-05-31T19:18:34Z","pushed_at":"2019-06-05T21:02:20Z","git_url":"git://github.com/microsoft/axe-windows.git","ssh_url":"git@github.com:microsoft/axe-windows.git","clone_url":"https://github.com/microsoft/axe-windows.git","svn_url":"https://github.com/microsoft/axe-windows","homepage":null,"size":758,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":6,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/axe-windows/pulls/46"},"html":{"href":"https://github.com/microsoft/axe-windows/pull/46"},"issue":{"href":"https://api.github.com/repos/microsoft/axe-windows/issues/46"},"comments":{"href":"https://api.github.com/repos/microsoft/axe-windows/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/axe-windows/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/axe-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/axe-windows/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/axe-windows/statuses/360f21f8f6079b1312416dab6088b677c860f5da"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RobGallo"}}