{"action":"created","issue":{"url":"https://api.github.com/repos/cryptomator/cryptomator/issues/933","repository_url":"https://api.github.com/repos/cryptomator/cryptomator","labels_url":"https://api.github.com/repos/cryptomator/cryptomator/issues/933/labels{/name}","comments_url":"https://api.github.com/repos/cryptomator/cryptomator/issues/933/comments","events_url":"https://api.github.com/repos/cryptomator/cryptomator/issues/933/events","html_url":"https://github.com/cryptomator/cryptomator/issues/933","id":472237172,"node_id":"MDU6SXNzdWU0NzIyMzcxNzI=","number":933,"title":"Enhancement: Custom volume icon using custom mount flags","user":{"login":"PKizzle","id":39984529,"node_id":"MDQ6VXNlcjM5OTg0NTI5","avatar_url":"https://avatars0.githubusercontent.com/u/39984529?v=4","gravatar_id":"","url":"https://api.github.com/users/PKizzle","html_url":"https://github.com/PKizzle","followers_url":"https://api.github.com/users/PKizzle/followers","following_url":"https://api.github.com/users/PKizzle/following{/other_user}","gists_url":"https://api.github.com/users/PKizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/PKizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PKizzle/subscriptions","organizations_url":"https://api.github.com/users/PKizzle/orgs","repos_url":"https://api.github.com/users/PKizzle/repos","events_url":"https://api.github.com/users/PKizzle/events{/privacy}","received_events_url":"https://api.github.com/users/PKizzle/received_events","type":"User","site_admin":false},"labels":[{"id":78221089,"node_id":"MDU6TGFiZWw3ODIyMTA4OQ==","url":"https://api.github.com/repos/cryptomator/cryptomator/labels/type:enhancement","name":"type:enhancement","color":"c2e0c6","default":false},{"id":277024169,"node_id":"MDU6TGFiZWwyNzcwMjQxNjk=","url":"https://api.github.com/repos/cryptomator/cryptomator/labels/type:upstream-bug","name":"type:upstream-bug","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2019-07-24T11:46:02Z","updated_at":"2019-07-31T14:50:12Z","closed_at":null,"author_association":"NONE","body":"### Description\r\n\r\nUnable to set custom volume icon using custom mount flag #802 `-ovolicon`.\r\nI am not sure whether this is a FUSE issue or happens because of Cryptomator's FUSE integration.\r\n\r\n### System Setup\r\n\r\n* Operating system and version: macOS 10.14.6 (18G84)\r\n* Cryptomator version: 1.4.12\r\n* Drive: FUSE 3.10.0\r\n\r\n### Steps to Reproduce\r\n\r\n1. Enable custom mount flags\r\n2. Add `-ovolicon=PATH_TO_ICNS`\r\n3. Mount the volume\r\n\r\n#### Expected Behavior\r\n\r\nThe selected icns file should be used as the volume icon.\r\n\r\n#### Actual Behavior\r\n\r\nThe default macOS volume icon is used instead.\r\n\r\n#### Reproducibility\r\n\r\nAlways"},"comment":{"url":"https://api.github.com/repos/cryptomator/cryptomator/issues/comments/516883053","html_url":"https://github.com/cryptomator/cryptomator/issues/933#issuecomment-516883053","issue_url":"https://api.github.com/repos/cryptomator/cryptomator/issues/933","id":516883053,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNjg4MzA1Mw==","user":{"login":"overheadhunter","id":1204330,"node_id":"MDQ6VXNlcjEyMDQzMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1204330?v=4","gravatar_id":"","url":"https://api.github.com/users/overheadhunter","html_url":"https://github.com/overheadhunter","followers_url":"https://api.github.com/users/overheadhunter/followers","following_url":"https://api.github.com/users/overheadhunter/following{/other_user}","gists_url":"https://api.github.com/users/overheadhunter/gists{/gist_id}","starred_url":"https://api.github.com/users/overheadhunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overheadhunter/subscriptions","organizations_url":"https://api.github.com/users/overheadhunter/orgs","repos_url":"https://api.github.com/users/overheadhunter/repos","events_url":"https://api.github.com/users/overheadhunter/events{/privacy}","received_events_url":"https://api.github.com/users/overheadhunter/received_events","type":"User","site_admin":false},"created_at":"2019-07-31T14:50:12Z","updated_at":"2019-07-31T14:50:12Z","author_association":"MEMBER","body":"> Regarding xattr, is it correct that since Java does not support xattr at the moment Cryptomator is unable to encrypt xattr related ._ files?\r\n\r\nxattr are supported in Java via the `UserDefinedFileAttributeView`, however this is not available on macOS yet. Since we're targeting all platforms we need either a workaround for mac or we have to wait for a fix.\r\n\r\nSince we're not supporting xattr natively yet, `auto_xattr` allows macOS to attempt to set xattrs and if it fails to fall back to `._` files.\r\n\r\n> If this is true why is enabling native xattr support for the .VolumeIcon.icns file bad?\r\n\r\nI didn't remember saying this is bad in any way. It is just not supported yet."}}
{"actor":{"display_login":"overheadhunter"}}