{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/glean/pulls/comments/314616653","pull_request_review_id":275813358,"id":314616653,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDYxNjY1Mw==","diff_hunk":"@@ -39,7 +39,8 @@ assertEquals(\n \n ## Limits\n \n-* Fixed maximum experiment and branch id lengths: 30. Longer strings are truncated. For the original Kotlin implementation of the Glean SDK, this is measured in Unicode characters. For the Rust implementation, this is measured in the number of bytes when the string is encoded in UTF-8.\n+* `experimentId` and `branch` fields are fixed at a maximum length of 100. Fixed maximum key and value lengths for the `extra` map is 50. Longer strings used as ids, keys, or values are truncated to their respective maximum length. For the original Kotlin implementation of the Glean SDK, this is measured in Unicode characters. For the Rust implementation, this is measured in the number of bytes when the string is encoded in UTF-8.","path":"docs/user/experiments-api.md","position":5,"original_position":5,"commit_id":"59b995334e8e2fbbecfa76fd39f193c25f479214","original_commit_id":"59b995334e8e2fbbecfa76fd39f193c25f479214","user":{"login":"Dexterp37","id":883721,"node_id":"MDQ6VXNlcjg4MzcyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/883721?v=4","gravatar_id":"","url":"https://api.github.com/users/Dexterp37","html_url":"https://github.com/Dexterp37","followers_url":"https://api.github.com/users/Dexterp37/followers","following_url":"https://api.github.com/users/Dexterp37/following{/other_user}","gists_url":"https://api.github.com/users/Dexterp37/gists{/gist_id}","starred_url":"https://api.github.com/users/Dexterp37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dexterp37/subscriptions","organizations_url":"https://api.github.com/users/Dexterp37/orgs","repos_url":"https://api.github.com/users/Dexterp37/repos","events_url":"https://api.github.com/users/Dexterp37/events{/privacy}","received_events_url":"https://api.github.com/users/Dexterp37/received_events","type":"User","site_admin":false},"body":"Let's not change current limits, please. This will introduce a different behaviour between glean-ac and glean-core. Let's limit this PR to the `extra` map.","created_at":"2019-08-16T07:49:51Z","updated_at":"2019-08-16T07:50:44Z","html_url":"https://github.com/mozilla/glean/pull/247#discussion_r314616653","pull_request_url":"https://api.github.com/repos/mozilla/glean/pulls/247","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/glean/pulls/comments/314616653"},"html":{"href":"https://github.com/mozilla/glean/pull/247#discussion_r314616653"},"pull_request":{"href":"https://api.github.com/repos/mozilla/glean/pulls/247"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/glean/pulls/247","id":307806512,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3ODA2NTEy","html_url":"https://github.com/mozilla/glean/pull/247","diff_url":"https://github.com/mozilla/glean/pull/247.diff","patch_url":"https://github.com/mozilla/glean/pull/247.patch","issue_url":"https://api.github.com/repos/mozilla/glean/issues/247","number":247,"state":"open","locked":false,"title":" Bug 1566001 - Add limits for the experiment's extra HashMap","user":{"login":"travis79","id":7341315,"node_id":"MDQ6VXNlcjczNDEzMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/7341315?v=4","gravatar_id":"","url":"https://api.github.com/users/travis79","html_url":"https://github.com/travis79","followers_url":"https://api.github.com/users/travis79/followers","following_url":"https://api.github.com/users/travis79/following{/other_user}","gists_url":"https://api.github.com/users/travis79/gists{/gist_id}","starred_url":"https://api.github.com/users/travis79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis79/subscriptions","organizations_url":"https://api.github.com/users/travis79/orgs","repos_url":"https://api.github.com/users/travis79/repos","events_url":"https://api.github.com/users/travis79/events{/privacy}","received_events_url":"https://api.github.com/users/travis79/received_events","type":"User","site_admin":false},"body":"Adds limits to the `extras` HashMap in experiments.rs\n\n### Pull Request checklist ###\n<!-- Before submitting the PR, please address each item -->\n- [ ] **Quality**: This PR builds and tests run cleanly\n  - `make test` runs without emitting any warnings\n  - `make lint` runs without emitting any errors\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\n  - Any breaking changes to language binding APIs are noted explicitly\n","created_at":"2019-08-15T18:23:13Z","updated_at":"2019-08-16T07:50:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc3f152b7e002f36f2c58748291cbb74519f4f93","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mdboom","id":38294,"node_id":"MDQ6VXNlcjM4Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/38294?v=4","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/glean/pulls/247/commits","review_comments_url":"https://api.github.com/repos/mozilla/glean/pulls/247/comments","review_comment_url":"https://api.github.com/repos/mozilla/glean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/glean/issues/247/comments","statuses_url":"https://api.github.com/repos/mozilla/glean/statuses/59b995334e8e2fbbecfa76fd39f193c25f479214","head":{"label":"travis79:experiment-extras-limits","ref":"experiment-extras-limits","sha":"59b995334e8e2fbbecfa76fd39f193c25f479214","user":{"login":"travis79","id":7341315,"node_id":"MDQ6VXNlcjczNDEzMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/7341315?v=4","gravatar_id":"","url":"https://api.github.com/users/travis79","html_url":"https://github.com/travis79","followers_url":"https://api.github.com/users/travis79/followers","following_url":"https://api.github.com/users/travis79/following{/other_user}","gists_url":"https://api.github.com/users/travis79/gists{/gist_id}","starred_url":"https://api.github.com/users/travis79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis79/subscriptions","organizations_url":"https://api.github.com/users/travis79/orgs","repos_url":"https://api.github.com/users/travis79/repos","events_url":"https://api.github.com/users/travis79/events{/privacy}","received_events_url":"https://api.github.com/users/travis79/received_events","type":"User","site_admin":false},"repo":{"id":202431781,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI0MzE3ODE=","name":"glean","full_name":"travis79/glean","private":false,"owner":{"login":"travis79","id":7341315,"node_id":"MDQ6VXNlcjczNDEzMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/7341315?v=4","gravatar_id":"","url":"https://api.github.com/users/travis79","html_url":"https://github.com/travis79","followers_url":"https://api.github.com/users/travis79/followers","following_url":"https://api.github.com/users/travis79/following{/other_user}","gists_url":"https://api.github.com/users/travis79/gists{/gist_id}","starred_url":"https://api.github.com/users/travis79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis79/subscriptions","organizations_url":"https://api.github.com/users/travis79/orgs","repos_url":"https://api.github.com/users/travis79/repos","events_url":"https://api.github.com/users/travis79/events{/privacy}","received_events_url":"https://api.github.com/users/travis79/received_events","type":"User","site_admin":false},"html_url":"https://github.com/travis79/glean","description":"Modern Firefox Telemetry for mobile platforms","fork":true,"url":"https://api.github.com/repos/travis79/glean","forks_url":"https://api.github.com/repos/travis79/glean/forks","keys_url":"https://api.github.com/repos/travis79/glean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis79/glean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis79/glean/teams","hooks_url":"https://api.github.com/repos/travis79/glean/hooks","issue_events_url":"https://api.github.com/repos/travis79/glean/issues/events{/number}","events_url":"https://api.github.com/repos/travis79/glean/events","assignees_url":"https://api.github.com/repos/travis79/glean/assignees{/user}","branches_url":"https://api.github.com/repos/travis79/glean/branches{/branch}","tags_url":"https://api.github.com/repos/travis79/glean/tags","blobs_url":"https://api.github.com/repos/travis79/glean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis79/glean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis79/glean/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis79/glean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis79/glean/statuses/{sha}","languages_url":"https://api.github.com/repos/travis79/glean/languages","stargazers_url":"https://api.github.com/repos/travis79/glean/stargazers","contributors_url":"https://api.github.com/repos/travis79/glean/contributors","subscribers_url":"https://api.github.com/repos/travis79/glean/subscribers","subscription_url":"https://api.github.com/repos/travis79/glean/subscription","commits_url":"https://api.github.com/repos/travis79/glean/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis79/glean/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis79/glean/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis79/glean/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis79/glean/contents/{+path}","compare_url":"https://api.github.com/repos/travis79/glean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis79/glean/merges","archive_url":"https://api.github.com/repos/travis79/glean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis79/glean/downloads","issues_url":"https://api.github.com/repos/travis79/glean/issues{/number}","pulls_url":"https://api.github.com/repos/travis79/glean/pulls{/number}","milestones_url":"https://api.github.com/repos/travis79/glean/milestones{/number}","notifications_url":"https://api.github.com/repos/travis79/glean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis79/glean/labels{/name}","releases_url":"https://api.github.com/repos/travis79/glean/releases{/id}","deployments_url":"https://api.github.com/repos/travis79/glean/deployments","created_at":"2019-08-14T21:58:36Z","updated_at":"2019-08-15T18:22:21Z","pushed_at":"2019-08-15T20:31:21Z","git_url":"git://github.com/travis79/glean.git","ssh_url":"git@github.com:travis79/glean.git","clone_url":"https://github.com/travis79/glean.git","svn_url":"https://github.com/travis79/glean","homepage":"https://mozilla.github.io/glean/","size":6313,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"864aa9a239d32bc9e3d5950f3d8eba3754f9c121","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":160544457,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA1NDQ0NTc=","name":"glean","full_name":"mozilla/glean","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/glean","description":"Modern Firefox Telemetry for mobile platforms","fork":false,"url":"https://api.github.com/repos/mozilla/glean","forks_url":"https://api.github.com/repos/mozilla/glean/forks","keys_url":"https://api.github.com/repos/mozilla/glean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/glean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/glean/teams","hooks_url":"https://api.github.com/repos/mozilla/glean/hooks","issue_events_url":"https://api.github.com/repos/mozilla/glean/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/glean/events","assignees_url":"https://api.github.com/repos/mozilla/glean/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/glean/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/glean/tags","blobs_url":"https://api.github.com/repos/mozilla/glean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/glean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/glean/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/glean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/glean/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/glean/languages","stargazers_url":"https://api.github.com/repos/mozilla/glean/stargazers","contributors_url":"https://api.github.com/repos/mozilla/glean/contributors","subscribers_url":"https://api.github.com/repos/mozilla/glean/subscribers","subscription_url":"https://api.github.com/repos/mozilla/glean/subscription","commits_url":"https://api.github.com/repos/mozilla/glean/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/glean/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/glean/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/glean/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/glean/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/glean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/glean/merges","archive_url":"https://api.github.com/repos/mozilla/glean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/glean/downloads","issues_url":"https://api.github.com/repos/mozilla/glean/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/glean/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/glean/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/glean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/glean/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/glean/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/glean/deployments","created_at":"2018-12-05T16:09:14Z","updated_at":"2019-08-15T16:45:35Z","pushed_at":"2019-08-16T07:47:18Z","git_url":"git://github.com/mozilla/glean.git","ssh_url":"git@github.com:mozilla/glean.git","clone_url":"https://github.com/mozilla/glean.git","svn_url":"https://github.com/mozilla/glean","homepage":"https://mozilla.github.io/glean/","size":6297,"stargazers_count":10,"watchers_count":10,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":6,"open_issues":9,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/glean/pulls/247"},"html":{"href":"https://github.com/mozilla/glean/pull/247"},"issue":{"href":"https://api.github.com/repos/mozilla/glean/issues/247"},"comments":{"href":"https://api.github.com/repos/mozilla/glean/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/glean/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/glean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/glean/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/glean/statuses/59b995334e8e2fbbecfa76fd39f193c25f479214"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Dexterp37"}}