{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/278691404","pull_request_review_id":230831858,"id":278691404,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODY5MTQwNA==","diff_hunk":"@@ -1420,6 +1438,27 @@ private boolean containsFunctionById(int functionId) {\n         return false;\n     }\n \n+    /**\n+     * This function will recursively find any function expression with any ID in the functionIds.\n+     * If found, return the functionId. Otherwise, return -1.\n+     * @param functionIds\n+     * @return If found, return the functionId. Otherwise, return -1\n+     */\n+    private int containsFunctionByIds(Set<Integer> functionIds) {\n+        if (this instanceof AbstractValueExpression) {","path":"src/frontend/org/voltdb/expressions/AbstractExpression.java","position":56,"original_position":56,"commit_id":"ca6f9c849027830ba8b7c2f2a988ae1bbc8e770f","original_commit_id":"ca6f9c849027830ba8b7c2f2a988ae1bbc8e770f","user":{"login":"kaikaizi","id":1848688,"node_id":"MDQ6VXNlcjE4NDg2ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1848688?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikaizi","html_url":"https://github.com/kaikaizi","followers_url":"https://api.github.com/users/kaikaizi/followers","following_url":"https://api.github.com/users/kaikaizi/following{/other_user}","gists_url":"https://api.github.com/users/kaikaizi/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikaizi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikaizi/subscriptions","organizations_url":"https://api.github.com/users/kaikaizi/orgs","repos_url":"https://api.github.com/users/kaikaizi/repos","events_url":"https://api.github.com/users/kaikaizi/events{/privacy}","received_events_url":"https://api.github.com/users/kaikaizi/received_events","type":"User","site_admin":false},"body":"Do you need this here? When?\r\nOr should it belong to `findAllFunctionsSubexpressions()`?","created_at":"2019-04-25T19:08:27Z","updated_at":"2019-04-25T19:09:40Z","html_url":"https://github.com/VoltDB/voltdb/pull/6171#discussion_r278691404","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/6171","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/278691404"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/6171#discussion_r278691404"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/6171"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/6171","id":273637137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczNjM3MTM3","html_url":"https://github.com/VoltDB/voltdb/pull/6171","diff_url":"https://github.com/VoltDB/voltdb/pull/6171.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/6171.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/6171","number":6171,"state":"open","locked":false,"title":"ENG-15786: Crash with terminate after 'second parameter' error","user":{"login":"Chaozz","id":6102632,"node_id":"MDQ6VXNlcjYxMDI2MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6102632?v=4","gravatar_id":"","url":"https://api.github.com/users/Chaozz","html_url":"https://github.com/Chaozz","followers_url":"https://api.github.com/users/Chaozz/followers","following_url":"https://api.github.com/users/Chaozz/following{/other_user}","gists_url":"https://api.github.com/users/Chaozz/gists{/gist_id}","starred_url":"https://api.github.com/users/Chaozz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chaozz/subscriptions","organizations_url":"https://api.github.com/users/Chaozz/orgs","repos_url":"https://api.github.com/users/Chaozz/repos","events_url":"https://api.github.com/users/Chaozz/events{/privacy}","received_events_url":"https://api.github.com/users/Chaozz/received_events","type":"User","site_admin":false},"body":"The cause of the problem is that we are trying to create an index based on [STR](https://docs.voltdb.com/UsingVoltDB/sqlfuncstr.php) function.\r\nThe second argument of **STR** must be an integer between 0 and 38. An insertion/update of the table will fail if it hit the index and fail to meet the 0~38 constraint.\r\n\r\nThis fix disallows **STR** in index expressions.","created_at":"2019-04-25T18:37:39Z","updated_at":"2019-04-25T19:09:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c975c85d179485c5a8cda80880b008946414ac3e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"GuaGuaDean","id":17966660,"node_id":"MDQ6VXNlcjE3OTY2NjYw","avatar_url":"https://avatars0.githubusercontent.com/u/17966660?v=4","gravatar_id":"","url":"https://api.github.com/users/GuaGuaDean","html_url":"https://github.com/GuaGuaDean","followers_url":"https://api.github.com/users/GuaGuaDean/followers","following_url":"https://api.github.com/users/GuaGuaDean/following{/other_user}","gists_url":"https://api.github.com/users/GuaGuaDean/gists{/gist_id}","starred_url":"https://api.github.com/users/GuaGuaDean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuaGuaDean/subscriptions","organizations_url":"https://api.github.com/users/GuaGuaDean/orgs","repos_url":"https://api.github.com/users/GuaGuaDean/repos","events_url":"https://api.github.com/users/GuaGuaDean/events{/privacy}","received_events_url":"https://api.github.com/users/GuaGuaDean/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":999183728,"node_id":"MDU6TGFiZWw5OTkxODM3Mjg=","url":"https://api.github.com/repos/VoltDB/voltdb/labels/SQL%20team","name":"SQL team","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/6171/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/6171/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/6171/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/ca6f9c849027830ba8b7c2f2a988ae1bbc8e770f","head":{"label":"VoltDB:ENG-15786","ref":"ENG-15786","sha":"ca6f9c849027830ba8b7c2f2a988ae1bbc8e770f","user":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ1OTcw","name":"voltdb","full_name":"VoltDB/voltdb","private":false,"owner":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2019-04-25T01:01:18Z","pushed_at":"2019-04-25T19:02:31Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":615121,"stargazers_count":1386,"watchers_count":1386,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":76,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":364,"open_issues":76,"watchers":1386,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"bbabc358ae0e98aad3b113b804a36e3a4307fb75","user":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ1OTcw","name":"voltdb","full_name":"VoltDB/voltdb","private":false,"owner":{"login":"VoltDB","id":703910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMzkxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/703910?v=4","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2019-04-25T01:01:18Z","pushed_at":"2019-04-25T19:02:31Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":615121,"stargazers_count":1386,"watchers_count":1386,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":364,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":76,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":364,"open_issues":76,"watchers":1386,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/6171"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/6171"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/6171"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/6171/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/6171/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/6171/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/ca6f9c849027830ba8b7c2f2a988ae1bbc8e770f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kaikaizi"}}