{"action":"created","comment":{"url":"https://api.github.com/repos/apache/rocketmq-operator/pulls/comments/325623474","pull_request_review_id":289850723,"id":325623474,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNTYyMzQ3NA==","diff_hunk":"@@ -188,9 +188,9 @@ func (r *ReconcileNameService) updateNameServiceStatus(instance *rocketmqv1alpha\n \t\tshare.NameServersStr = nameServerListStr[:len(nameServerListStr)-1]\n \t\treqLogger.Info(\"share.NameServersStr:\" + share.NameServersStr)\n \n-\t\tif len(oldNameServerListStr) < 2 {\n+\t\tif len(oldNameServerListStr) < 8 {","path":"pkg/controller/nameservice/nameservice_controller.go","position":5,"original_position":5,"commit_id":"b25958a3f629a64140575d433c971fdde589bf35","original_commit_id":"cea76847a56e067179b729b746f1671ee1b4b70d","user":{"login":"vongosling","id":635581,"node_id":"MDQ6VXNlcjYzNTU4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/635581?v=4","gravatar_id":"","url":"https://api.github.com/users/vongosling","html_url":"https://github.com/vongosling","followers_url":"https://api.github.com/users/vongosling/followers","following_url":"https://api.github.com/users/vongosling/following{/other_user}","gists_url":"https://api.github.com/users/vongosling/gists{/gist_id}","starred_url":"https://api.github.com/users/vongosling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vongosling/subscriptions","organizations_url":"https://api.github.com/users/vongosling/orgs","repos_url":"https://api.github.com/users/vongosling/repos","events_url":"https://api.github.com/users/vongosling/events{/privacy}","received_events_url":"https://api.github.com/users/vongosling/received_events","type":"User","site_admin":false},"body":"magic number","created_at":"2019-09-18T11:34:35Z","updated_at":"2019-09-18T11:35:11Z","html_url":"https://github.com/apache/rocketmq-operator/pull/5#discussion_r325623474","pull_request_url":"https://api.github.com/repos/apache/rocketmq-operator/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/rocketmq-operator/pulls/comments/325623474"},"html":{"href":"https://github.com/apache/rocketmq-operator/pull/5#discussion_r325623474"},"pull_request":{"href":"https://api.github.com/repos/apache/rocketmq-operator/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/apache/rocketmq-operator/pulls/5","id":318646949,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE4NjQ2OTQ5","html_url":"https://github.com/apache/rocketmq-operator/pull/5","diff_url":"https://github.com/apache/rocketmq-operator/pull/5.diff","patch_url":"https://github.com/apache/rocketmq-operator/pull/5.patch","issue_url":"https://api.github.com/repos/apache/rocketmq-operator/issues/5","number":5,"state":"open","locked":false,"title":"Add Broker Horizontal Up-scale and Broker Rolling Update when Name Service Scaling","user":{"login":"liuruiyiyang","id":20263106,"node_id":"MDQ6VXNlcjIwMjYzMTA2","avatar_url":"https://avatars3.githubusercontent.com/u/20263106?v=4","gravatar_id":"","url":"https://api.github.com/users/liuruiyiyang","html_url":"https://github.com/liuruiyiyang","followers_url":"https://api.github.com/users/liuruiyiyang/followers","following_url":"https://api.github.com/users/liuruiyiyang/following{/other_user}","gists_url":"https://api.github.com/users/liuruiyiyang/gists{/gist_id}","starred_url":"https://api.github.com/users/liuruiyiyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuruiyiyang/subscriptions","organizations_url":"https://api.github.com/users/liuruiyiyang/orgs","repos_url":"https://api.github.com/users/liuruiyiyang/repos","events_url":"https://api.github.com/users/liuruiyiyang/events{/privacy}","received_events_url":"https://api.github.com/users/liuruiyiyang/received_events","type":"User","site_admin":false},"body":"Change List:\r\n1. Add a new feature that the broker cluster can up-scale with metadata copied from a user-defined source broker pod for the out-of-order message scenario.\r\n2. Implement the rolling updating of broker pods when name service cluster scaling.\r\n3. Add documents related to the above features and a content table for reader navigation.","created_at":"2019-09-18T06:20:56Z","updated_at":"2019-09-18T11:35:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3357e82ac1568cfec289a072eb8e602c7b52c872","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1388159448,"node_id":"MDU6TGFiZWwxMzg4MTU5NDQ4","url":"https://api.github.com/repos/apache/rocketmq-operator/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":{"url":"https://api.github.com/repos/apache/rocketmq-operator/milestones/1","html_url":"https://github.com/apache/rocketmq-operator/milestone/1","labels_url":"https://api.github.com/repos/apache/rocketmq-operator/milestones/1/labels","id":4629125,"node_id":"MDk6TWlsZXN0b25lNDYyOTEyNQ==","number":1,"title":"0.0.1","description":"MVP version for RocketMQ operator\r\n","creator":{"login":"vongosling","id":635581,"node_id":"MDQ6VXNlcjYzNTU4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/635581?v=4","gravatar_id":"","url":"https://api.github.com/users/vongosling","html_url":"https://github.com/vongosling","followers_url":"https://api.github.com/users/vongosling/followers","following_url":"https://api.github.com/users/vongosling/following{/other_user}","gists_url":"https://api.github.com/users/vongosling/gists{/gist_id}","starred_url":"https://api.github.com/users/vongosling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vongosling/subscriptions","organizations_url":"https://api.github.com/users/vongosling/orgs","repos_url":"https://api.github.com/users/vongosling/repos","events_url":"https://api.github.com/users/vongosling/events{/privacy}","received_events_url":"https://api.github.com/users/vongosling/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2019-09-04T06:37:50Z","updated_at":"2019-09-18T09:36:31Z","due_on":"2019-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/rocketmq-operator/pulls/5/commits","review_comments_url":"https://api.github.com/repos/apache/rocketmq-operator/pulls/5/comments","review_comment_url":"https://api.github.com/repos/apache/rocketmq-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/rocketmq-operator/issues/5/comments","statuses_url":"https://api.github.com/repos/apache/rocketmq-operator/statuses/b25958a3f629a64140575d433c971fdde589bf35","head":{"label":"liuruiyiyang:scale_broker","ref":"scale_broker","sha":"b25958a3f629a64140575d433c971fdde589bf35","user":{"login":"liuruiyiyang","id":20263106,"node_id":"MDQ6VXNlcjIwMjYzMTA2","avatar_url":"https://avatars3.githubusercontent.com/u/20263106?v=4","gravatar_id":"","url":"https://api.github.com/users/liuruiyiyang","html_url":"https://github.com/liuruiyiyang","followers_url":"https://api.github.com/users/liuruiyiyang/followers","following_url":"https://api.github.com/users/liuruiyiyang/following{/other_user}","gists_url":"https://api.github.com/users/liuruiyiyang/gists{/gist_id}","starred_url":"https://api.github.com/users/liuruiyiyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuruiyiyang/subscriptions","organizations_url":"https://api.github.com/users/liuruiyiyang/orgs","repos_url":"https://api.github.com/users/liuruiyiyang/repos","events_url":"https://api.github.com/users/liuruiyiyang/events{/privacy}","received_events_url":"https://api.github.com/users/liuruiyiyang/received_events","type":"User","site_admin":false},"repo":{"id":203987242,"node_id":"MDEwOlJlcG9zaXRvcnkyMDM5ODcyNDI=","name":"rocketmq-operator","full_name":"liuruiyiyang/rocketmq-operator","private":false,"owner":{"login":"liuruiyiyang","id":20263106,"node_id":"MDQ6VXNlcjIwMjYzMTA2","avatar_url":"https://avatars3.githubusercontent.com/u/20263106?v=4","gravatar_id":"","url":"https://api.github.com/users/liuruiyiyang","html_url":"https://github.com/liuruiyiyang","followers_url":"https://api.github.com/users/liuruiyiyang/followers","following_url":"https://api.github.com/users/liuruiyiyang/following{/other_user}","gists_url":"https://api.github.com/users/liuruiyiyang/gists{/gist_id}","starred_url":"https://api.github.com/users/liuruiyiyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuruiyiyang/subscriptions","organizations_url":"https://api.github.com/users/liuruiyiyang/orgs","repos_url":"https://api.github.com/users/liuruiyiyang/repos","events_url":"https://api.github.com/users/liuruiyiyang/events{/privacy}","received_events_url":"https://api.github.com/users/liuruiyiyang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/liuruiyiyang/rocketmq-operator","description":"Apache RocketMQ Operator","fork":true,"url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator","forks_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/forks","keys_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/teams","hooks_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/hooks","issue_events_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/issues/events{/number}","events_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/events","assignees_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/assignees{/user}","branches_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/branches{/branch}","tags_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/tags","blobs_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/languages","stargazers_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/stargazers","contributors_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/contributors","subscribers_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/subscribers","subscription_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/subscription","commits_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/contents/{+path}","compare_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/merges","archive_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/downloads","issues_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/issues{/number}","pulls_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/labels{/name}","releases_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/releases{/id}","deployments_url":"https://api.github.com/repos/liuruiyiyang/rocketmq-operator/deployments","created_at":"2019-08-23T11:40:18Z","updated_at":"2019-09-12T08:40:29Z","pushed_at":"2019-09-18T11:34:05Z","git_url":"git://github.com/liuruiyiyang/rocketmq-operator.git","ssh_url":"git@github.com:liuruiyiyang/rocketmq-operator.git","clone_url":"https://github.com/liuruiyiyang/rocketmq-operator.git","svn_url":"https://github.com/liuruiyiyang/rocketmq-operator","homepage":"https://rocketmq.apache.org/","size":230,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"76859b2aef06d1397df5974ead140b242d7c7b68","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":189944025,"node_id":"MDEwOlJlcG9zaXRvcnkxODk5NDQwMjU=","name":"rocketmq-operator","full_name":"apache/rocketmq-operator","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/rocketmq-operator","description":"Apache RocketMQ Operator","fork":false,"url":"https://api.github.com/repos/apache/rocketmq-operator","forks_url":"https://api.github.com/repos/apache/rocketmq-operator/forks","keys_url":"https://api.github.com/repos/apache/rocketmq-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/rocketmq-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/rocketmq-operator/teams","hooks_url":"https://api.github.com/repos/apache/rocketmq-operator/hooks","issue_events_url":"https://api.github.com/repos/apache/rocketmq-operator/issues/events{/number}","events_url":"https://api.github.com/repos/apache/rocketmq-operator/events","assignees_url":"https://api.github.com/repos/apache/rocketmq-operator/assignees{/user}","branches_url":"https://api.github.com/repos/apache/rocketmq-operator/branches{/branch}","tags_url":"https://api.github.com/repos/apache/rocketmq-operator/tags","blobs_url":"https://api.github.com/repos/apache/rocketmq-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/rocketmq-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/rocketmq-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/rocketmq-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/rocketmq-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/rocketmq-operator/languages","stargazers_url":"https://api.github.com/repos/apache/rocketmq-operator/stargazers","contributors_url":"https://api.github.com/repos/apache/rocketmq-operator/contributors","subscribers_url":"https://api.github.com/repos/apache/rocketmq-operator/subscribers","subscription_url":"https://api.github.com/repos/apache/rocketmq-operator/subscription","commits_url":"https://api.github.com/repos/apache/rocketmq-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/rocketmq-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/rocketmq-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/rocketmq-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/rocketmq-operator/contents/{+path}","compare_url":"https://api.github.com/repos/apache/rocketmq-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/rocketmq-operator/merges","archive_url":"https://api.github.com/repos/apache/rocketmq-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/rocketmq-operator/downloads","issues_url":"https://api.github.com/repos/apache/rocketmq-operator/issues{/number}","pulls_url":"https://api.github.com/repos/apache/rocketmq-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/rocketmq-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/rocketmq-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/rocketmq-operator/labels{/name}","releases_url":"https://api.github.com/repos/apache/rocketmq-operator/releases{/id}","deployments_url":"https://api.github.com/repos/apache/rocketmq-operator/deployments","created_at":"2019-06-03T06:01:27Z","updated_at":"2019-09-15T14:47:56Z","pushed_at":"2019-09-18T11:34:07Z","git_url":"git://github.com/apache/rocketmq-operator.git","ssh_url":"git@github.com:apache/rocketmq-operator.git","clone_url":"https://github.com/apache/rocketmq-operator.git","svn_url":"https://github.com/apache/rocketmq-operator","homepage":"https://rocketmq.apache.org/","size":181,"stargazers_count":17,"watchers_count":17,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":1,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/rocketmq-operator/pulls/5"},"html":{"href":"https://github.com/apache/rocketmq-operator/pull/5"},"issue":{"href":"https://api.github.com/repos/apache/rocketmq-operator/issues/5"},"comments":{"href":"https://api.github.com/repos/apache/rocketmq-operator/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/rocketmq-operator/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/rocketmq-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/rocketmq-operator/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/apache/rocketmq-operator/statuses/b25958a3f629a64140575d433c971fdde589bf35"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vongosling"}}