{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/pulls/7","id":250060306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwMDYwMzA2","html_url":"https://github.com/digitalbazaar/bedrock-account-http/pull/7","diff_url":"https://github.com/digitalbazaar/bedrock-account-http/pull/7.diff","patch_url":"https://github.com/digitalbazaar/bedrock-account-http/pull/7.patch","issue_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/issues/7","number":7,"state":"closed","locked":false,"title":"Test framework","user":{"login":"aljones15","id":278280,"node_id":"MDQ6VXNlcjI3ODI4MA==","avatar_url":"https://avatars2.githubusercontent.com/u/278280?v=4","gravatar_id":"","url":"https://api.github.com/users/aljones15","html_url":"https://github.com/aljones15","followers_url":"https://api.github.com/users/aljones15/followers","following_url":"https://api.github.com/users/aljones15/following{/other_user}","gists_url":"https://api.github.com/users/aljones15/gists{/gist_id}","starred_url":"https://api.github.com/users/aljones15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljones15/subscriptions","organizations_url":"https://api.github.com/users/aljones15/orgs","repos_url":"https://api.github.com/users/aljones15/repos","events_url":"https://api.github.com/users/aljones15/events{/privacy}","received_events_url":"https://api.github.com/users/aljones15/received_events","type":"User","site_admin":false},"body":"1. Adds eslint as a dependency to bedrock-account-http\r\n2. Expands Test project with tests for accountExists\r\n3. Adds Tests for account create\r\n4. Adds Tests for account get by id\r\n5. Adds a stub that let's tests specify the req.user the handler receives\r\n6. abstracts lambdas out to async functions with doc string with tests to ensure they still work.\r\n7. adds a check to account create for when the user forgets to specify an email. (ui check is there).","created_at":"2019-02-04T13:57:46Z","updated_at":"2019-02-06T18:18:03Z","closed_at":"2019-02-06T18:18:02Z","merged_at":"2019-02-06T18:18:02Z","merge_commit_sha":"2bdc2dc66e1fda230ad3361655db7ab3e56dd4da","assignee":{"login":"dlongley","id":168137,"node_id":"MDQ6VXNlcjE2ODEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/168137?v=4","gravatar_id":"","url":"https://api.github.com/users/dlongley","html_url":"https://github.com/dlongley","followers_url":"https://api.github.com/users/dlongley/followers","following_url":"https://api.github.com/users/dlongley/following{/other_user}","gists_url":"https://api.github.com/users/dlongley/gists{/gist_id}","starred_url":"https://api.github.com/users/dlongley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlongley/subscriptions","organizations_url":"https://api.github.com/users/dlongley/orgs","repos_url":"https://api.github.com/users/dlongley/repos","events_url":"https://api.github.com/users/dlongley/events{/privacy}","received_events_url":"https://api.github.com/users/dlongley/received_events","type":"User","site_admin":false},"assignees":[{"login":"dlongley","id":168137,"node_id":"MDQ6VXNlcjE2ODEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/168137?v=4","gravatar_id":"","url":"https://api.github.com/users/dlongley","html_url":"https://github.com/dlongley","followers_url":"https://api.github.com/users/dlongley/followers","following_url":"https://api.github.com/users/dlongley/following{/other_user}","gists_url":"https://api.github.com/users/dlongley/gists{/gist_id}","starred_url":"https://api.github.com/users/dlongley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlongley/subscriptions","organizations_url":"https://api.github.com/users/dlongley/orgs","repos_url":"https://api.github.com/users/dlongley/repos","events_url":"https://api.github.com/users/dlongley/events{/privacy}","received_events_url":"https://api.github.com/users/dlongley/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":929246066,"node_id":"MDU6TGFiZWw5MjkyNDYwNjY=","url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/pulls/7/commits","review_comments_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/pulls/7/comments","review_comment_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/issues/7/comments","statuses_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/statuses/201a851ed028217b1d4bdb7371646958a2680ec6","head":{"label":"digitalbazaar:testFramework","ref":"testFramework","sha":"201a851ed028217b1d4bdb7371646958a2680ec6","user":{"login":"digitalbazaar","id":167436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzQzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/167436?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalbazaar","html_url":"https://github.com/digitalbazaar","followers_url":"https://api.github.com/users/digitalbazaar/followers","following_url":"https://api.github.com/users/digitalbazaar/following{/other_user}","gists_url":"https://api.github.com/users/digitalbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalbazaar/subscriptions","organizations_url":"https://api.github.com/users/digitalbazaar/orgs","repos_url":"https://api.github.com/users/digitalbazaar/repos","events_url":"https://api.github.com/users/digitalbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/digitalbazaar/received_events","type":"Organization","site_admin":false},"repo":{"id":132947982,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5NDc5ODI=","name":"bedrock-account-http","full_name":"digitalbazaar/bedrock-account-http","private":false,"owner":{"login":"digitalbazaar","id":167436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzQzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/167436?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalbazaar","html_url":"https://github.com/digitalbazaar","followers_url":"https://api.github.com/users/digitalbazaar/followers","following_url":"https://api.github.com/users/digitalbazaar/following{/other_user}","gists_url":"https://api.github.com/users/digitalbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalbazaar/subscriptions","organizations_url":"https://api.github.com/users/digitalbazaar/orgs","repos_url":"https://api.github.com/users/digitalbazaar/repos","events_url":"https://api.github.com/users/digitalbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/digitalbazaar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digitalbazaar/bedrock-account-http","description":"HTTP APIs for Bedrock User Accounts","fork":false,"url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http","forks_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/forks","keys_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/teams","hooks_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/hooks","issue_events_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/issues/events{/number}","events_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/events","assignees_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/assignees{/user}","branches_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/branches{/branch}","tags_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/tags","blobs_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/languages","stargazers_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/stargazers","contributors_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/contributors","subscribers_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/subscribers","subscription_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/subscription","commits_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/contents/{+path}","compare_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/merges","archive_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/downloads","issues_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/issues{/number}","pulls_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/labels{/name}","releases_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/releases{/id}","deployments_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/deployments","created_at":"2018-05-10T19:56:26Z","updated_at":"2018-09-14T18:48:16Z","pushed_at":"2019-02-06T18:18:02Z","git_url":"git://github.com/digitalbazaar/bedrock-account-http.git","ssh_url":"git@github.com:digitalbazaar/bedrock-account-http.git","clone_url":"https://github.com/digitalbazaar/bedrock-account-http.git","svn_url":"https://github.com/digitalbazaar/bedrock-account-http","homepage":null,"size":57,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"digitalbazaar:dev","ref":"dev","sha":"3bbf735dd8ca4e299eef246c460a3eefacbbc04c","user":{"login":"digitalbazaar","id":167436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzQzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/167436?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalbazaar","html_url":"https://github.com/digitalbazaar","followers_url":"https://api.github.com/users/digitalbazaar/followers","following_url":"https://api.github.com/users/digitalbazaar/following{/other_user}","gists_url":"https://api.github.com/users/digitalbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalbazaar/subscriptions","organizations_url":"https://api.github.com/users/digitalbazaar/orgs","repos_url":"https://api.github.com/users/digitalbazaar/repos","events_url":"https://api.github.com/users/digitalbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/digitalbazaar/received_events","type":"Organization","site_admin":false},"repo":{"id":132947982,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5NDc5ODI=","name":"bedrock-account-http","full_name":"digitalbazaar/bedrock-account-http","private":false,"owner":{"login":"digitalbazaar","id":167436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzQzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/167436?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalbazaar","html_url":"https://github.com/digitalbazaar","followers_url":"https://api.github.com/users/digitalbazaar/followers","following_url":"https://api.github.com/users/digitalbazaar/following{/other_user}","gists_url":"https://api.github.com/users/digitalbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalbazaar/subscriptions","organizations_url":"https://api.github.com/users/digitalbazaar/orgs","repos_url":"https://api.github.com/users/digitalbazaar/repos","events_url":"https://api.github.com/users/digitalbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/digitalbazaar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digitalbazaar/bedrock-account-http","description":"HTTP APIs for Bedrock User Accounts","fork":false,"url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http","forks_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/forks","keys_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/teams","hooks_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/hooks","issue_events_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/issues/events{/number}","events_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/events","assignees_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/assignees{/user}","branches_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/branches{/branch}","tags_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/tags","blobs_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/languages","stargazers_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/stargazers","contributors_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/contributors","subscribers_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/subscribers","subscription_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/subscription","commits_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/contents/{+path}","compare_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/merges","archive_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/downloads","issues_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/issues{/number}","pulls_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/labels{/name}","releases_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/releases{/id}","deployments_url":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/deployments","created_at":"2018-05-10T19:56:26Z","updated_at":"2018-09-14T18:48:16Z","pushed_at":"2019-02-06T18:18:02Z","git_url":"git://github.com/digitalbazaar/bedrock-account-http.git","ssh_url":"git@github.com:digitalbazaar/bedrock-account-http.git","clone_url":"https://github.com/digitalbazaar/bedrock-account-http.git","svn_url":"https://github.com/digitalbazaar/bedrock-account-http","homepage":null,"size":57,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/pulls/7"},"html":{"href":"https://github.com/digitalbazaar/bedrock-account-http/pull/7"},"issue":{"href":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/issues/7"},"comments":{"href":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/digitalbazaar/bedrock-account-http/statuses/201a851ed028217b1d4bdb7371646958a2680ec6"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dlongley","id":168137,"node_id":"MDQ6VXNlcjE2ODEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/168137?v=4","gravatar_id":"","url":"https://api.github.com/users/dlongley","html_url":"https://github.com/dlongley","followers_url":"https://api.github.com/users/dlongley/followers","following_url":"https://api.github.com/users/dlongley/following{/other_user}","gists_url":"https://api.github.com/users/dlongley/gists{/gist_id}","starred_url":"https://api.github.com/users/dlongley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlongley/subscriptions","organizations_url":"https://api.github.com/users/dlongley/orgs","repos_url":"https://api.github.com/users/dlongley/repos","events_url":"https://api.github.com/users/dlongley/events{/privacy}","received_events_url":"https://api.github.com/users/dlongley/received_events","type":"User","site_admin":false},"comments":9,"review_comments":40,"maintainer_can_modify":false,"commits":40,"additions":448,"deletions":15,"changed_files":14}}
{"actor":{"display_login":"dlongley"}}