{"action":"created","issue":{"url":"https://api.github.com/repos/microsoft/vscode-cpptools/issues/4095","repository_url":"https://api.github.com/repos/microsoft/vscode-cpptools","labels_url":"https://api.github.com/repos/microsoft/vscode-cpptools/issues/4095/labels{/name}","comments_url":"https://api.github.com/repos/microsoft/vscode-cpptools/issues/4095/comments","events_url":"https://api.github.com/repos/microsoft/vscode-cpptools/issues/4095/events","html_url":"https://github.com/microsoft/vscode-cpptools/issues/4095","id":481416096,"node_id":"MDU6SXNzdWU0ODE0MTYwOTY=","number":4095,"title":"Excluded files shouldn't be included in the symbol resolution.","user":{"login":"smwikipedia","id":999318,"node_id":"MDQ6VXNlcjk5OTMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/999318?v=4","gravatar_id":"","url":"https://api.github.com/users/smwikipedia","html_url":"https://github.com/smwikipedia","followers_url":"https://api.github.com/users/smwikipedia/followers","following_url":"https://api.github.com/users/smwikipedia/following{/other_user}","gists_url":"https://api.github.com/users/smwikipedia/gists{/gist_id}","starred_url":"https://api.github.com/users/smwikipedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smwikipedia/subscriptions","organizations_url":"https://api.github.com/users/smwikipedia/orgs","repos_url":"https://api.github.com/users/smwikipedia/repos","events_url":"https://api.github.com/users/smwikipedia/events{/privacy}","received_events_url":"https://api.github.com/users/smwikipedia/received_events","type":"User","site_admin":false},"labels":[{"id":1322613788,"node_id":"MDU6TGFiZWwxMzIyNjEzNzg4","url":"https://api.github.com/repos/microsoft/vscode-cpptools/labels/Feature:%20Go%20to%20Definition","name":"Feature: Go to Definition","color":"fef2c0","default":false},{"id":355010486,"node_id":"MDU6TGFiZWwzNTUwMTA0ODY=","url":"https://api.github.com/repos/microsoft/vscode-cpptools/labels/Language%20Service","name":"Language Service","color":"c5def5","default":false},{"id":415705549,"node_id":"MDU6TGFiZWw0MTU3MDU1NDk=","url":"https://api.github.com/repos/microsoft/vscode-cpptools/labels/fixed%20(release%20pending)","name":"fixed (release pending)","color":"2ffa5f","default":false},{"id":757191975,"node_id":"MDU6TGFiZWw3NTcxOTE5NzU=","url":"https://api.github.com/repos/microsoft/vscode-cpptools/labels/quick%20fix","name":"quick fix","color":"fcbcb8","default":false},{"id":1330954849,"node_id":"MDU6TGFiZWwxMzMwOTU0ODQ5","url":"https://api.github.com/repos/microsoft/vscode-cpptools/labels/verified","name":"verified","color":"99ff00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/microsoft/vscode-cpptools/milestones/39","html_url":"https://github.com/microsoft/vscode-cpptools/milestone/39","labels_url":"https://api.github.com/repos/microsoft/vscode-cpptools/milestones/39/labels","id":4199071,"node_id":"MDk6TWlsZXN0b25lNDE5OTA3MQ==","number":39,"title":"0.25.0","description":"0.25.0-insiders: Aug 7?, Find All References\r\n0.25.0: Aug 21?","creator":{"login":"sean-mcmanus","id":19859882,"node_id":"MDQ6VXNlcjE5ODU5ODgy","avatar_url":"https://avatars0.githubusercontent.com/u/19859882?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-mcmanus","html_url":"https://github.com/sean-mcmanus","followers_url":"https://api.github.com/users/sean-mcmanus/followers","following_url":"https://api.github.com/users/sean-mcmanus/following{/other_user}","gists_url":"https://api.github.com/users/sean-mcmanus/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-mcmanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-mcmanus/subscriptions","organizations_url":"https://api.github.com/users/sean-mcmanus/orgs","repos_url":"https://api.github.com/users/sean-mcmanus/repos","events_url":"https://api.github.com/users/sean-mcmanus/events{/privacy}","received_events_url":"https://api.github.com/users/sean-mcmanus/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":15,"state":"open","created_at":"2019-04-03T20:48:52Z","updated_at":"2019-08-19T23:10:38Z","due_on":"2019-08-21T07:00:00Z","closed_at":null},"comments":11,"created_at":"2019-08-16T02:37:49Z","updated_at":"2019-08-20T02:23:18Z","closed_at":null,"author_association":"NONE","body":"**Type: LanguageService**\r\n<!----- Input information below ----->\r\n\r\n<!--\r\n**Prior to filing an issue, please review:**\r\n- Existing issues at https://github.com/Microsoft/vscode-cpptools/issues\r\n- Our documentation at https://code.visualstudio.com/docs/languages/cpp\r\n- FAQs at https://code.visualstudio.com/docs/cpp/faq-cpp\r\n-->\r\n\r\n**Describe the bug**\r\nI have a folder containing below files. The `func1.c` and `func2.c` contains 2 functions definitions. They are for the same function name but with different implementation.\r\n\r\nBelow are the folder/file details.\r\n\r\n![image](https://user-images.githubusercontent.com/999318/63139380-b75f5a00-c010-11e9-98a6-254cc5021f07.png)\r\n\r\n**(func.h)**\r\n\r\n`void func();\r\n`\r\n\r\n**(func1.c)**\r\n```\r\nvoid func()\r\n{\r\n    int a;\r\n    a++;\r\n}\r\n```\r\n\r\n**(func2.c)**\r\n```\r\nvoid func()   // Same function name but with different implementation\r\n{\r\n    int b;\r\n    b++;\r\n}\r\n```\r\n\r\n**(main.c)**\r\n\r\n```\r\n#include \"func.h\"\r\nint main()\r\n{\r\n    func();\r\n}\r\n\r\n```\r\n\r\nI use `files.exclude` to exclude one of the c files, `func2.c` from workspace. And the `func2.c` disappeared from the workspace explorer indeed.\r\n\r\n**(settings.json)**\r\n```\r\n{\r\n    \"files.exclude\": {\r\n        \"func2.c\": true\r\n    }\r\n}\r\n\r\n```\r\nI expect the file parsing / symbol resolution should do the same exclusion when looking for definition for `func()`.\r\n\r\n\r\nBut actually, after I reset the intellisense database, definitions from both `func1.c` and `func2.c` are still listed.\r\n\r\n![image](https://user-images.githubusercontent.com/999318/63139682-bed33300-c011-11e9-8e2e-f0222c4a4b4f.png)\r\n\r\n\r\n\r\n\r\n\r\n- OS and Version:\r\n- VS Code Version:\r\nVersion: 1.37.0 (user setup)\r\nCommit: 036a6b1d3ac84e5ca96a17a44e63a87971f8fcc8\r\nDate: 2019-08-08T02:33:50.993Z\r\nElectron: 4.2.7\r\nChrome: 69.0.3497.128\r\nNode.js: 10.11.0\r\nV8: 6.9.427.31-electron.0\r\nOS: Windows_NT x64 10.0.16299\r\n\r\n- C/C++ Extension Version:\r\n0.25.0-insiders2\r\n\r\n\r\n- Other extensions you installed (and if the issue persists after disabling them):\r\n- A clear and concise description of what the bug is.\r\n\r\n**To Reproduce**\r\n<!-- Steps to reproduce the behavior: -->\r\n<!-- *The most actionable issue reports include a code sample including configuration files such as c_cpp_properties.json* -->\r\n1. Go to '...'\r\n2. Click on '....'\r\n3. Scroll down to '....'\r\n4. See error\r\n\r\n**Expected behavior**\r\n<!-- A clear and concise description of what you expected to happen. -->\r\n\r\n**Screenshots**\r\n<!-- If applicable, add screenshots to help explain your problem. -->\r\n\r\n**Additional context**\r\n<!--\r\n* Call Stacks: For bugs like crashes, deadlocks, infinite loops, etc. that we are not able to repro and for which the call stack may be useful, please attach a debugger and/or create a dmp and provide the call stacks. Windows binaries have symbols available in VS Code by setting your \"symbolSearchPath\" to \"https://msdl.microsoft.com/download/symbols\".\r\n* Add any other context about the problem here including log messages in your Output window (\"C_Cpp.loggingLevel\": \"Debug\" in settings.json).\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/microsoft/vscode-cpptools/issues/comments/522825495","html_url":"https://github.com/microsoft/vscode-cpptools/issues/4095#issuecomment-522825495","issue_url":"https://api.github.com/repos/microsoft/vscode-cpptools/issues/4095","id":522825495,"node_id":"MDEyOklzc3VlQ29tbWVudDUyMjgyNTQ5NQ==","user":{"login":"smwikipedia","id":999318,"node_id":"MDQ6VXNlcjk5OTMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/999318?v=4","gravatar_id":"","url":"https://api.github.com/users/smwikipedia","html_url":"https://github.com/smwikipedia","followers_url":"https://api.github.com/users/smwikipedia/followers","following_url":"https://api.github.com/users/smwikipedia/following{/other_user}","gists_url":"https://api.github.com/users/smwikipedia/gists{/gist_id}","starred_url":"https://api.github.com/users/smwikipedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smwikipedia/subscriptions","organizations_url":"https://api.github.com/users/smwikipedia/orgs","repos_url":"https://api.github.com/users/smwikipedia/repos","events_url":"https://api.github.com/users/smwikipedia/events{/privacy}","received_events_url":"https://api.github.com/users/smwikipedia/received_events","type":"User","site_admin":false},"created_at":"2019-08-20T02:23:18Z","updated_at":"2019-08-20T02:23:18Z","author_association":"NONE","body":"I guess you mean `${workspaceFolder}/folder1` because that's the folder containing `func()` definition file.\r\n\r\nI put the `${workspaceFolder}/folder1` in the `browse.path`.  It cause the same issue as I put just `folder1` there.\r\n\r\n![image](https://user-images.githubusercontent.com/999318/63312488-4bdcfb80-c334-11e9-86f0-a38ffae2457e.png)\r\n\r\nThe excluded `func2.c` is still found.\r\n\r\n![image](https://user-images.githubusercontent.com/999318/63312531-644d1600-c334-11e9-8308-9c2c98961893.png)\r\n\r\nI believe the fix to make `browse.path` take into consideration of the `files.exclude` can solve this. \r\n\r\nI will wait for the new release."}}
{"actor":{"display_login":"smwikipedia"}}