{"action":"opened","number":17,"pull_request":{"url":"https://api.github.com/repos/icyleaf/markd/pulls/17","id":306299887,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2Mjk5ODg3","html_url":"https://github.com/icyleaf/markd/pull/17","diff_url":"https://github.com/icyleaf/markd/pull/17.diff","patch_url":"https://github.com/icyleaf/markd/pull/17.patch","issue_url":"https://api.github.com/repos/icyleaf/markd/issues/17","number":17,"state":"open","locked":false,"title":"Fix issue with URI API change in crystal 0.30.0","user":{"login":"bdtomlin","id":25921,"node_id":"MDQ6VXNlcjI1OTIx","avatar_url":"https://avatars0.githubusercontent.com/u/25921?v=4","gravatar_id":"","url":"https://api.github.com/users/bdtomlin","html_url":"https://github.com/bdtomlin","followers_url":"https://api.github.com/users/bdtomlin/followers","following_url":"https://api.github.com/users/bdtomlin/following{/other_user}","gists_url":"https://api.github.com/users/bdtomlin/gists{/gist_id}","starred_url":"https://api.github.com/users/bdtomlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdtomlin/subscriptions","organizations_url":"https://api.github.com/users/bdtomlin/orgs","repos_url":"https://api.github.com/users/bdtomlin/repos","events_url":"https://api.github.com/users/bdtomlin/events{/privacy}","received_events_url":"https://api.github.com/users/bdtomlin/received_events","type":"User","site_admin":false},"body":"Crystal has deprecated URI.escape and URI.unescape. Not only have they been deprecated, but URI.escape no longer has a variation that accepts a block. This causes markd to fail.\r\n\r\nSee [v0.30.0](https://crystal-lang.org/api/0.30.0/URI.html#escape(string:String,io:IO,space_to_plus=false)-class-method) vs. [v0.29.0](https://crystal-lang.org/api/0.29.0/URI.html#escape%28string%3AString%2Cio%3AIO%2Cspace_to_plus%3Dfalse%29-class-method)\r\n\r\n@icyleaf, I'm not sure how you would want to handle supporting different versions of Crystal, but this pull request currently just fixes the issue for 0.30.0, which breaks for older versions where the encode and decode methods didn't exist.\r\n\r\nI think adding a note about versions to the top of the readme is adequate since Crystal is pre-release. I have included that here, but if you have other ideas I'm open.\r\n\r\nIn case you are wondering why I introduced the io variable, it's because [there is only one encode method signature that accepts a block, and it writes to an IO](https://crystal-lang.org/api/0.30.0/URI.html#encode(string:String,io:IO,space_to_plus:Bool=false,&block):Nil-class-method).","created_at":"2019-08-11T18:42:35Z","updated_at":"2019-08-11T18:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/icyleaf/markd/pulls/17/commits","review_comments_url":"https://api.github.com/repos/icyleaf/markd/pulls/17/comments","review_comment_url":"https://api.github.com/repos/icyleaf/markd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/icyleaf/markd/issues/17/comments","statuses_url":"https://api.github.com/repos/icyleaf/markd/statuses/f4a9e8fe8055b442f29e0a6ecec50cbecbddc84c","head":{"label":"bdtomlin:master","ref":"master","sha":"f4a9e8fe8055b442f29e0a6ecec50cbecbddc84c","user":{"login":"bdtomlin","id":25921,"node_id":"MDQ6VXNlcjI1OTIx","avatar_url":"https://avatars0.githubusercontent.com/u/25921?v=4","gravatar_id":"","url":"https://api.github.com/users/bdtomlin","html_url":"https://github.com/bdtomlin","followers_url":"https://api.github.com/users/bdtomlin/followers","following_url":"https://api.github.com/users/bdtomlin/following{/other_user}","gists_url":"https://api.github.com/users/bdtomlin/gists{/gist_id}","starred_url":"https://api.github.com/users/bdtomlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdtomlin/subscriptions","organizations_url":"https://api.github.com/users/bdtomlin/orgs","repos_url":"https://api.github.com/users/bdtomlin/repos","events_url":"https://api.github.com/users/bdtomlin/events{/privacy}","received_events_url":"https://api.github.com/users/bdtomlin/received_events","type":"User","site_admin":false},"repo":{"id":201784998,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE3ODQ5OTg=","name":"markd","full_name":"bdtomlin/markd","private":false,"owner":{"login":"bdtomlin","id":25921,"node_id":"MDQ6VXNlcjI1OTIx","avatar_url":"https://avatars0.githubusercontent.com/u/25921?v=4","gravatar_id":"","url":"https://api.github.com/users/bdtomlin","html_url":"https://github.com/bdtomlin","followers_url":"https://api.github.com/users/bdtomlin/followers","following_url":"https://api.github.com/users/bdtomlin/following{/other_user}","gists_url":"https://api.github.com/users/bdtomlin/gists{/gist_id}","starred_url":"https://api.github.com/users/bdtomlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdtomlin/subscriptions","organizations_url":"https://api.github.com/users/bdtomlin/orgs","repos_url":"https://api.github.com/users/bdtomlin/repos","events_url":"https://api.github.com/users/bdtomlin/events{/privacy}","received_events_url":"https://api.github.com/users/bdtomlin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bdtomlin/markd","description":"Yet another markdown parser, Compliant to CommonMark specification, written in Crystal.","fork":true,"url":"https://api.github.com/repos/bdtomlin/markd","forks_url":"https://api.github.com/repos/bdtomlin/markd/forks","keys_url":"https://api.github.com/repos/bdtomlin/markd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdtomlin/markd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdtomlin/markd/teams","hooks_url":"https://api.github.com/repos/bdtomlin/markd/hooks","issue_events_url":"https://api.github.com/repos/bdtomlin/markd/issues/events{/number}","events_url":"https://api.github.com/repos/bdtomlin/markd/events","assignees_url":"https://api.github.com/repos/bdtomlin/markd/assignees{/user}","branches_url":"https://api.github.com/repos/bdtomlin/markd/branches{/branch}","tags_url":"https://api.github.com/repos/bdtomlin/markd/tags","blobs_url":"https://api.github.com/repos/bdtomlin/markd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdtomlin/markd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdtomlin/markd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdtomlin/markd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdtomlin/markd/statuses/{sha}","languages_url":"https://api.github.com/repos/bdtomlin/markd/languages","stargazers_url":"https://api.github.com/repos/bdtomlin/markd/stargazers","contributors_url":"https://api.github.com/repos/bdtomlin/markd/contributors","subscribers_url":"https://api.github.com/repos/bdtomlin/markd/subscribers","subscription_url":"https://api.github.com/repos/bdtomlin/markd/subscription","commits_url":"https://api.github.com/repos/bdtomlin/markd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdtomlin/markd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdtomlin/markd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdtomlin/markd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdtomlin/markd/contents/{+path}","compare_url":"https://api.github.com/repos/bdtomlin/markd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdtomlin/markd/merges","archive_url":"https://api.github.com/repos/bdtomlin/markd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdtomlin/markd/downloads","issues_url":"https://api.github.com/repos/bdtomlin/markd/issues{/number}","pulls_url":"https://api.github.com/repos/bdtomlin/markd/pulls{/number}","milestones_url":"https://api.github.com/repos/bdtomlin/markd/milestones{/number}","notifications_url":"https://api.github.com/repos/bdtomlin/markd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdtomlin/markd/labels{/name}","releases_url":"https://api.github.com/repos/bdtomlin/markd/releases{/id}","deployments_url":"https://api.github.com/repos/bdtomlin/markd/deployments","created_at":"2019-08-11T15:54:10Z","updated_at":"2019-08-11T18:32:31Z","pushed_at":"2019-08-11T18:32:29Z","git_url":"git://github.com/bdtomlin/markd.git","ssh_url":"git@github.com:bdtomlin/markd.git","clone_url":"https://github.com/bdtomlin/markd.git","svn_url":"https://github.com/bdtomlin/markd","homepage":"","size":373,"stargazers_count":0,"watchers_count":0,"language":"Crystal","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"icyleaf:master","ref":"master","sha":"445e6b7c37b06ce15676ee81a9bb4a362f74a5d6","user":{"login":"icyleaf","id":17814,"node_id":"MDQ6VXNlcjE3ODE0","avatar_url":"https://avatars2.githubusercontent.com/u/17814?v=4","gravatar_id":"","url":"https://api.github.com/users/icyleaf","html_url":"https://github.com/icyleaf","followers_url":"https://api.github.com/users/icyleaf/followers","following_url":"https://api.github.com/users/icyleaf/following{/other_user}","gists_url":"https://api.github.com/users/icyleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/icyleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icyleaf/subscriptions","organizations_url":"https://api.github.com/users/icyleaf/orgs","repos_url":"https://api.github.com/users/icyleaf/repos","events_url":"https://api.github.com/users/icyleaf/events{/privacy}","received_events_url":"https://api.github.com/users/icyleaf/received_events","type":"User","site_admin":false},"repo":{"id":93261243,"node_id":"MDEwOlJlcG9zaXRvcnk5MzI2MTI0Mw==","name":"markd","full_name":"icyleaf/markd","private":false,"owner":{"login":"icyleaf","id":17814,"node_id":"MDQ6VXNlcjE3ODE0","avatar_url":"https://avatars2.githubusercontent.com/u/17814?v=4","gravatar_id":"","url":"https://api.github.com/users/icyleaf","html_url":"https://github.com/icyleaf","followers_url":"https://api.github.com/users/icyleaf/followers","following_url":"https://api.github.com/users/icyleaf/following{/other_user}","gists_url":"https://api.github.com/users/icyleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/icyleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icyleaf/subscriptions","organizations_url":"https://api.github.com/users/icyleaf/orgs","repos_url":"https://api.github.com/users/icyleaf/repos","events_url":"https://api.github.com/users/icyleaf/events{/privacy}","received_events_url":"https://api.github.com/users/icyleaf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/icyleaf/markd","description":"Yet another markdown parser, Compliant to CommonMark specification, written in Crystal.","fork":false,"url":"https://api.github.com/repos/icyleaf/markd","forks_url":"https://api.github.com/repos/icyleaf/markd/forks","keys_url":"https://api.github.com/repos/icyleaf/markd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icyleaf/markd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icyleaf/markd/teams","hooks_url":"https://api.github.com/repos/icyleaf/markd/hooks","issue_events_url":"https://api.github.com/repos/icyleaf/markd/issues/events{/number}","events_url":"https://api.github.com/repos/icyleaf/markd/events","assignees_url":"https://api.github.com/repos/icyleaf/markd/assignees{/user}","branches_url":"https://api.github.com/repos/icyleaf/markd/branches{/branch}","tags_url":"https://api.github.com/repos/icyleaf/markd/tags","blobs_url":"https://api.github.com/repos/icyleaf/markd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icyleaf/markd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icyleaf/markd/git/refs{/sha}","trees_url":"https://api.github.com/repos/icyleaf/markd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icyleaf/markd/statuses/{sha}","languages_url":"https://api.github.com/repos/icyleaf/markd/languages","stargazers_url":"https://api.github.com/repos/icyleaf/markd/stargazers","contributors_url":"https://api.github.com/repos/icyleaf/markd/contributors","subscribers_url":"https://api.github.com/repos/icyleaf/markd/subscribers","subscription_url":"https://api.github.com/repos/icyleaf/markd/subscription","commits_url":"https://api.github.com/repos/icyleaf/markd/commits{/sha}","git_commits_url":"https://api.github.com/repos/icyleaf/markd/git/commits{/sha}","comments_url":"https://api.github.com/repos/icyleaf/markd/comments{/number}","issue_comment_url":"https://api.github.com/repos/icyleaf/markd/issues/comments{/number}","contents_url":"https://api.github.com/repos/icyleaf/markd/contents/{+path}","compare_url":"https://api.github.com/repos/icyleaf/markd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icyleaf/markd/merges","archive_url":"https://api.github.com/repos/icyleaf/markd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icyleaf/markd/downloads","issues_url":"https://api.github.com/repos/icyleaf/markd/issues{/number}","pulls_url":"https://api.github.com/repos/icyleaf/markd/pulls{/number}","milestones_url":"https://api.github.com/repos/icyleaf/markd/milestones{/number}","notifications_url":"https://api.github.com/repos/icyleaf/markd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icyleaf/markd/labels{/name}","releases_url":"https://api.github.com/repos/icyleaf/markd/releases{/id}","deployments_url":"https://api.github.com/repos/icyleaf/markd/deployments","created_at":"2017-06-03T16:44:53Z","updated_at":"2019-07-12T17:34:05Z","pushed_at":"2019-06-17T07:21:56Z","git_url":"git://github.com/icyleaf/markd.git","ssh_url":"git@github.com:icyleaf/markd.git","clone_url":"https://github.com/icyleaf/markd.git","svn_url":"https://github.com/icyleaf/markd","homepage":"","size":373,"stargazers_count":31,"watchers_count":31,"language":"Crystal","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":2,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/icyleaf/markd/pulls/17"},"html":{"href":"https://github.com/icyleaf/markd/pull/17"},"issue":{"href":"https://api.github.com/repos/icyleaf/markd/issues/17"},"comments":{"href":"https://api.github.com/repos/icyleaf/markd/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/icyleaf/markd/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/icyleaf/markd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/icyleaf/markd/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/icyleaf/markd/statuses/f4a9e8fe8055b442f29e0a6ecec50cbecbddc84c"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":16,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"bdtomlin"}}