{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/felix/pulls/comments/297336591","pull_request_review_id":254197148,"id":297336591,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzMzNjU5MQ==","diff_hunk":"@@ -293,6 +293,19 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(\n \t\t},\n \t})\n \n+\trules = append(rules, Rule{\n+\t\tMatch: Match().ProtocolNum(ProtoUDP).\n+\t\t\tDestPorts(uint16(r.Config.VXLANPort)).\n+\t\t\tVXLANVNI(uint32(r.Config.VXLANVNI)),\n+\t\tAction:  DropAction{},\n+\t\tComment: \"Drop VXLAN encapped packets originating in pods\",\n+\t})\n+\trules = append(rules, Rule{\n+\t\tMatch:   Match().ProtocolNum(ProtoIPIP),\n+\t\tAction:  DropAction{},\n+\t\tComment: \"Drop IPinIP encapped packets originating in pods\",\n+\t})\n+","path":"rules/endpoints.go","position":16,"original_position":16,"commit_id":"6b35282b5aa328d63ba37d2ff57b0652a57a5d28","original_commit_id":"6b35282b5aa328d63ba37d2ff57b0652a57a5d28","user":{"login":"rafaelvanoni","id":18339884,"node_id":"MDQ6VXNlcjE4MzM5ODg0","avatar_url":"https://avatars1.githubusercontent.com/u/18339884?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelvanoni","html_url":"https://github.com/rafaelvanoni","followers_url":"https://api.github.com/users/rafaelvanoni/followers","following_url":"https://api.github.com/users/rafaelvanoni/following{/other_user}","gists_url":"https://api.github.com/users/rafaelvanoni/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelvanoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelvanoni/subscriptions","organizations_url":"https://api.github.com/users/rafaelvanoni/orgs","repos_url":"https://api.github.com/users/rafaelvanoni/repos","events_url":"https://api.github.com/users/rafaelvanoni/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelvanoni/received_events","type":"User","site_admin":false},"body":"Fixed per our conversation on slack","created_at":"2019-06-25T18:39:50Z","updated_at":"2019-06-25T18:39:50Z","html_url":"https://github.com/projectcalico/felix/pull/2052#discussion_r297336591","pull_request_url":"https://api.github.com/repos/projectcalico/felix/pulls/2052","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/felix/pulls/comments/297336591"},"html":{"href":"https://github.com/projectcalico/felix/pull/2052#discussion_r297336591"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/felix/pulls/2052"}},"in_reply_to_id":297195858},"pull_request":{"url":"https://api.github.com/repos/projectcalico/felix/pulls/2052","id":291226741,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxMjI2NzQx","html_url":"https://github.com/projectcalico/felix/pull/2052","diff_url":"https://github.com/projectcalico/felix/pull/2052.diff","patch_url":"https://github.com/projectcalico/felix/pull/2052.patch","issue_url":"https://api.github.com/repos/projectcalico/felix/issues/2052","number":2052,"state":"open","locked":false,"title":"Drop VXLAN and IPIP packets originating in pods","user":{"login":"rafaelvanoni","id":18339884,"node_id":"MDQ6VXNlcjE4MzM5ODg0","avatar_url":"https://avatars1.githubusercontent.com/u/18339884?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelvanoni","html_url":"https://github.com/rafaelvanoni","followers_url":"https://api.github.com/users/rafaelvanoni/followers","following_url":"https://api.github.com/users/rafaelvanoni/following{/other_user}","gists_url":"https://api.github.com/users/rafaelvanoni/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelvanoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelvanoni/subscriptions","organizations_url":"https://api.github.com/users/rafaelvanoni/orgs","repos_url":"https://api.github.com/users/rafaelvanoni/repos","events_url":"https://api.github.com/users/rafaelvanoni/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelvanoni/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-24T17:26:10Z","updated_at":"2019-06-25T18:39:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"844ded0aa97c2f55aa4ec93c00bb23cf16c6eabd","assignee":{"login":"rafaelvanoni","id":18339884,"node_id":"MDQ6VXNlcjE4MzM5ODg0","avatar_url":"https://avatars1.githubusercontent.com/u/18339884?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelvanoni","html_url":"https://github.com/rafaelvanoni","followers_url":"https://api.github.com/users/rafaelvanoni/followers","following_url":"https://api.github.com/users/rafaelvanoni/following{/other_user}","gists_url":"https://api.github.com/users/rafaelvanoni/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelvanoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelvanoni/subscriptions","organizations_url":"https://api.github.com/users/rafaelvanoni/orgs","repos_url":"https://api.github.com/users/rafaelvanoni/repos","events_url":"https://api.github.com/users/rafaelvanoni/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelvanoni/received_events","type":"User","site_admin":false},"assignees":[{"login":"rafaelvanoni","id":18339884,"node_id":"MDQ6VXNlcjE4MzM5ODg0","avatar_url":"https://avatars1.githubusercontent.com/u/18339884?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelvanoni","html_url":"https://github.com/rafaelvanoni","followers_url":"https://api.github.com/users/rafaelvanoni/followers","following_url":"https://api.github.com/users/rafaelvanoni/following{/other_user}","gists_url":"https://api.github.com/users/rafaelvanoni/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelvanoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelvanoni/subscriptions","organizations_url":"https://api.github.com/users/rafaelvanoni/orgs","repos_url":"https://api.github.com/users/rafaelvanoni/repos","events_url":"https://api.github.com/users/rafaelvanoni/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelvanoni/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":857080272,"node_id":"MDU6TGFiZWw4NTcwODAyNzI=","url":"https://api.github.com/repos/projectcalico/felix/labels/cherry-pick-candidate","name":"cherry-pick-candidate","color":"b32735","default":false},{"id":1165876525,"node_id":"MDU6TGFiZWwxMTY1ODc2NTI1","url":"https://api.github.com/repos/projectcalico/felix/labels/docs-not-required","name":"docs-not-required","color":"5f00cc","default":false},{"id":1165876529,"node_id":"MDU6TGFiZWwxMTY1ODc2NTI5","url":"https://api.github.com/repos/projectcalico/felix/labels/release-note-not-required","name":"release-note-not-required","color":"cc7a00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/felix/pulls/2052/commits","review_comments_url":"https://api.github.com/repos/projectcalico/felix/pulls/2052/comments","review_comment_url":"https://api.github.com/repos/projectcalico/felix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/felix/issues/2052/comments","statuses_url":"https://api.github.com/repos/projectcalico/felix/statuses/6b35282b5aa328d63ba37d2ff57b0652a57a5d28","head":{"label":"projectcalico:fix-master","ref":"fix-master","sha":"6b35282b5aa328d63ba37d2ff57b0652a57a5d28","user":{"login":"projectcalico","id":12304728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzA0NzI4","avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":21242831,"node_id":"MDEwOlJlcG9zaXRvcnkyMTI0MjgzMQ==","name":"felix","full_name":"projectcalico/felix","private":false,"owner":{"login":"projectcalico","id":12304728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzA0NzI4","avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/projectcalico/felix","description":"Project Calico's per-host agent Felix, responsible for programming routes and security policy.","fork":false,"url":"https://api.github.com/repos/projectcalico/felix","forks_url":"https://api.github.com/repos/projectcalico/felix/forks","keys_url":"https://api.github.com/repos/projectcalico/felix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/felix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/felix/teams","hooks_url":"https://api.github.com/repos/projectcalico/felix/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/felix/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/felix/events","assignees_url":"https://api.github.com/repos/projectcalico/felix/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/felix/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/felix/tags","blobs_url":"https://api.github.com/repos/projectcalico/felix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/felix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/felix/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/felix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/felix/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/felix/languages","stargazers_url":"https://api.github.com/repos/projectcalico/felix/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/felix/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/felix/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/felix/subscription","commits_url":"https://api.github.com/repos/projectcalico/felix/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/felix/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/felix/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/felix/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/felix/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/felix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/felix/merges","archive_url":"https://api.github.com/repos/projectcalico/felix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/felix/downloads","issues_url":"https://api.github.com/repos/projectcalico/felix/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/felix/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/felix/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/felix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/felix/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/felix/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/felix/deployments","created_at":"2014-06-26T14:08:43Z","updated_at":"2019-06-25T05:11:54Z","pushed_at":"2019-06-25T08:24:22Z","git_url":"git://github.com/projectcalico/felix.git","ssh_url":"git@github.com:projectcalico/felix.git","clone_url":"https://github.com/projectcalico/felix.git","svn_url":"https://github.com/projectcalico/felix","homepage":"http://projectcalico.org/","size":11065,"stargazers_count":780,"watchers_count":780,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":206,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":206,"open_issues":24,"watchers":780,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"e001ad4f11be7e5dc9270863f75c539e028c45e9","user":{"login":"projectcalico","id":12304728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzA0NzI4","avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":21242831,"node_id":"MDEwOlJlcG9zaXRvcnkyMTI0MjgzMQ==","name":"felix","full_name":"projectcalico/felix","private":false,"owner":{"login":"projectcalico","id":12304728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzA0NzI4","avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/projectcalico/felix","description":"Project Calico's per-host agent Felix, responsible for programming routes and security policy.","fork":false,"url":"https://api.github.com/repos/projectcalico/felix","forks_url":"https://api.github.com/repos/projectcalico/felix/forks","keys_url":"https://api.github.com/repos/projectcalico/felix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/felix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/felix/teams","hooks_url":"https://api.github.com/repos/projectcalico/felix/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/felix/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/felix/events","assignees_url":"https://api.github.com/repos/projectcalico/felix/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/felix/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/felix/tags","blobs_url":"https://api.github.com/repos/projectcalico/felix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/felix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/felix/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/felix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/felix/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/felix/languages","stargazers_url":"https://api.github.com/repos/projectcalico/felix/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/felix/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/felix/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/felix/subscription","commits_url":"https://api.github.com/repos/projectcalico/felix/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/felix/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/felix/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/felix/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/felix/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/felix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/felix/merges","archive_url":"https://api.github.com/repos/projectcalico/felix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/felix/downloads","issues_url":"https://api.github.com/repos/projectcalico/felix/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/felix/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/felix/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/felix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/felix/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/felix/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/felix/deployments","created_at":"2014-06-26T14:08:43Z","updated_at":"2019-06-25T05:11:54Z","pushed_at":"2019-06-25T08:24:22Z","git_url":"git://github.com/projectcalico/felix.git","ssh_url":"git@github.com:projectcalico/felix.git","clone_url":"https://github.com/projectcalico/felix.git","svn_url":"https://github.com/projectcalico/felix","homepage":"http://projectcalico.org/","size":11065,"stargazers_count":780,"watchers_count":780,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":206,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":206,"open_issues":24,"watchers":780,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/felix/pulls/2052"},"html":{"href":"https://github.com/projectcalico/felix/pull/2052"},"issue":{"href":"https://api.github.com/repos/projectcalico/felix/issues/2052"},"comments":{"href":"https://api.github.com/repos/projectcalico/felix/issues/2052/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/felix/pulls/2052/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/felix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/felix/pulls/2052/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/felix/statuses/6b35282b5aa328d63ba37d2ff57b0652a57a5d28"}},"author_association":"NONE"}}
{"actor":{"display_login":"rafaelvanoni"}}