{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/274672549","pull_request_review_id":225799570,"id":274672549,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NDY3MjU0OQ==","diff_hunk":"@@ -0,0 +1,9 @@\n+Check that the velero is up and running:","path":"stable/velero/templates/NOTES.txt","position":1,"original_position":1,"commit_id":"67168cbc8096a258a8ae9972aef5dbf547c5ea3e","original_commit_id":"67168cbc8096a258a8ae9972aef5dbf547c5ea3e","user":{"login":"nrb","id":321387,"node_id":"MDQ6VXNlcjMyMTM4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/321387?v=4","gravatar_id":"","url":"https://api.github.com/users/nrb","html_url":"https://github.com/nrb","followers_url":"https://api.github.com/users/nrb/followers","following_url":"https://api.github.com/users/nrb/following{/other_user}","gists_url":"https://api.github.com/users/nrb/gists{/gist_id}","starred_url":"https://api.github.com/users/nrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrb/subscriptions","organizations_url":"https://api.github.com/users/nrb/orgs","repos_url":"https://api.github.com/users/nrb/repos","events_url":"https://api.github.com/users/nrb/events{/privacy}","received_events_url":"https://api.github.com/users/nrb/received_events","type":"User","site_admin":false},"body":"I would add the follow here so that users can actually verify.\r\n\r\n```\r\nCheck that the velero is up and running:\r\n\r\n    kubectl get deployment/{{ .Release.Name }} -n {{ .Release.Namespace }}\r\n\r\nCheck that the secret has been created:\r\n\r\n    kubectl get secret/{{ include \"velero.fullname\" . }} -n {{ .Release.Namespace }}\r\n```","created_at":"2019-04-11T21:27:19Z","updated_at":"2019-04-11T21:31:14Z","html_url":"https://github.com/helm/charts/pull/12031#discussion_r274672549","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/12031","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/274672549"},"html":{"href":"https://github.com/helm/charts/pull/12031#discussion_r274672549"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/12031"}}},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/12031","id":259615946,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5NjE1OTQ2","html_url":"https://github.com/helm/charts/pull/12031","diff_url":"https://github.com/helm/charts/pull/12031.diff","patch_url":"https://github.com/helm/charts/pull/12031.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/12031","number":12031,"state":"open","locked":false,"title":"[stable/velero] Upgrade Ark 0.10.x to Velero 0.11","user":{"login":"josephgorse","id":19844674,"node_id":"MDQ6VXNlcjE5ODQ0Njc0","avatar_url":"https://avatars2.githubusercontent.com/u/19844674?v=4","gravatar_id":"","url":"https://api.github.com/users/josephgorse","html_url":"https://github.com/josephgorse","followers_url":"https://api.github.com/users/josephgorse/followers","following_url":"https://api.github.com/users/josephgorse/following{/other_user}","gists_url":"https://api.github.com/users/josephgorse/gists{/gist_id}","starred_url":"https://api.github.com/users/josephgorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephgorse/subscriptions","organizations_url":"https://api.github.com/users/josephgorse/orgs","repos_url":"https://api.github.com/users/josephgorse/repos","events_url":"https://api.github.com/users/josephgorse/events{/privacy}","received_events_url":"https://api.github.com/users/josephgorse/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n#### What this PR does / why we need it: Upgrades the Helm chart to Velero 0.11.0, which includes a project rename from Ark to Velero\r\n\r\n#### Special notes for your reviewer:\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] [DCO](https://github.com/helm/charts/blob/master/CONTRIBUTING.md#sign-your-work) signed\r\n- [x] Chart Version bumped\r\n- [x] Variables are documented in the README.md\r\n","created_at":"2019-03-08T21:42:00Z","updated_at":"2019-04-11T21:31:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fea14fd84ab49cf72e0220afbee68bfb6c8f199","assignee":{"login":"unguiculus","id":925412,"node_id":"MDQ6VXNlcjkyNTQxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"assignees":[{"login":"unguiculus","id":925412,"node_id":"MDQ6VXNlcjkyNTQxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"scottrigby","id":407675,"node_id":"MDQ6VXNlcjQwNzY3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/407675?v=4","gravatar_id":"","url":"https://api.github.com/users/scottrigby","html_url":"https://github.com/scottrigby","followers_url":"https://api.github.com/users/scottrigby/followers","following_url":"https://api.github.com/users/scottrigby/following{/other_user}","gists_url":"https://api.github.com/users/scottrigby/gists{/gist_id}","starred_url":"https://api.github.com/users/scottrigby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottrigby/subscriptions","organizations_url":"https://api.github.com/users/scottrigby/orgs","repos_url":"https://api.github.com/users/scottrigby/repos","events_url":"https://api.github.com/users/scottrigby/events{/privacy}","received_events_url":"https://api.github.com/users/scottrigby/received_events","type":"User","site_admin":false},{"login":"prydonius","id":1544861,"node_id":"MDQ6VXNlcjE1NDQ4NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1544861?v=4","gravatar_id":"","url":"https://api.github.com/users/prydonius","html_url":"https://github.com/prydonius","followers_url":"https://api.github.com/users/prydonius/followers","following_url":"https://api.github.com/users/prydonius/following{/other_user}","gists_url":"https://api.github.com/users/prydonius/gists{/gist_id}","starred_url":"https://api.github.com/users/prydonius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prydonius/subscriptions","organizations_url":"https://api.github.com/users/prydonius/orgs","repos_url":"https://api.github.com/users/prydonius/repos","events_url":"https://api.github.com/users/prydonius/events{/privacy}","received_events_url":"https://api.github.com/users/prydonius/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":1120334296,"node_id":"MDU6TGFiZWwxMTIwMzM0Mjk2","url":"https://api.github.com/repos/helm/charts/labels/ok-to-test","name":"ok-to-test","color":"ededed","default":false},{"id":678010043,"node_id":"MDU6TGFiZWw2NzgwMTAwNDM=","url":"https://api.github.com/repos/helm/charts/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/12031/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/12031/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/12031/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/67168cbc8096a258a8ae9972aef5dbf547c5ea3e","head":{"label":"josephgorse:master","ref":"master","sha":"67168cbc8096a258a8ae9972aef5dbf547c5ea3e","user":{"login":"josephgorse","id":19844674,"node_id":"MDQ6VXNlcjE5ODQ0Njc0","avatar_url":"https://avatars2.githubusercontent.com/u/19844674?v=4","gravatar_id":"","url":"https://api.github.com/users/josephgorse","html_url":"https://github.com/josephgorse","followers_url":"https://api.github.com/users/josephgorse/followers","following_url":"https://api.github.com/users/josephgorse/following{/other_user}","gists_url":"https://api.github.com/users/josephgorse/gists{/gist_id}","starred_url":"https://api.github.com/users/josephgorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephgorse/subscriptions","organizations_url":"https://api.github.com/users/josephgorse/orgs","repos_url":"https://api.github.com/users/josephgorse/repos","events_url":"https://api.github.com/users/josephgorse/events{/privacy}","received_events_url":"https://api.github.com/users/josephgorse/received_events","type":"User","site_admin":false},"repo":{"id":174552140,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ1NTIxNDA=","name":"charts","full_name":"josephgorse/charts","private":false,"owner":{"login":"josephgorse","id":19844674,"node_id":"MDQ6VXNlcjE5ODQ0Njc0","avatar_url":"https://avatars2.githubusercontent.com/u/19844674?v=4","gravatar_id":"","url":"https://api.github.com/users/josephgorse","html_url":"https://github.com/josephgorse","followers_url":"https://api.github.com/users/josephgorse/followers","following_url":"https://api.github.com/users/josephgorse/following{/other_user}","gists_url":"https://api.github.com/users/josephgorse/gists{/gist_id}","starred_url":"https://api.github.com/users/josephgorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephgorse/subscriptions","organizations_url":"https://api.github.com/users/josephgorse/orgs","repos_url":"https://api.github.com/users/josephgorse/repos","events_url":"https://api.github.com/users/josephgorse/events{/privacy}","received_events_url":"https://api.github.com/users/josephgorse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/josephgorse/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/josephgorse/charts","forks_url":"https://api.github.com/repos/josephgorse/charts/forks","keys_url":"https://api.github.com/repos/josephgorse/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josephgorse/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josephgorse/charts/teams","hooks_url":"https://api.github.com/repos/josephgorse/charts/hooks","issue_events_url":"https://api.github.com/repos/josephgorse/charts/issues/events{/number}","events_url":"https://api.github.com/repos/josephgorse/charts/events","assignees_url":"https://api.github.com/repos/josephgorse/charts/assignees{/user}","branches_url":"https://api.github.com/repos/josephgorse/charts/branches{/branch}","tags_url":"https://api.github.com/repos/josephgorse/charts/tags","blobs_url":"https://api.github.com/repos/josephgorse/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josephgorse/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josephgorse/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/josephgorse/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josephgorse/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/josephgorse/charts/languages","stargazers_url":"https://api.github.com/repos/josephgorse/charts/stargazers","contributors_url":"https://api.github.com/repos/josephgorse/charts/contributors","subscribers_url":"https://api.github.com/repos/josephgorse/charts/subscribers","subscription_url":"https://api.github.com/repos/josephgorse/charts/subscription","commits_url":"https://api.github.com/repos/josephgorse/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/josephgorse/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/josephgorse/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/josephgorse/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/josephgorse/charts/contents/{+path}","compare_url":"https://api.github.com/repos/josephgorse/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josephgorse/charts/merges","archive_url":"https://api.github.com/repos/josephgorse/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josephgorse/charts/downloads","issues_url":"https://api.github.com/repos/josephgorse/charts/issues{/number}","pulls_url":"https://api.github.com/repos/josephgorse/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/josephgorse/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/josephgorse/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josephgorse/charts/labels{/name}","releases_url":"https://api.github.com/repos/josephgorse/charts/releases{/id}","deployments_url":"https://api.github.com/repos/josephgorse/charts/deployments","created_at":"2019-03-08T14:30:07Z","updated_at":"2019-04-11T13:12:29Z","pushed_at":"2019-04-11T13:12:25Z","git_url":"git://github.com/josephgorse/charts.git","ssh_url":"git@github.com:josephgorse/charts.git","clone_url":"https://github.com/josephgorse/charts.git","svn_url":"https://github.com/josephgorse/charts","homepage":"","size":18380,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"0238e09deae814ea128e2ff75729d6f6704a8fb3","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2019-04-11T17:53:54Z","pushed_at":"2019-04-11T20:56:37Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":18420,"stargazers_count":7812,"watchers_count":7812,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7420,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":719,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7420,"open_issues":719,"watchers":7812,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/12031"},"html":{"href":"https://github.com/helm/charts/pull/12031"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/12031"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/12031/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/12031/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/12031/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/67168cbc8096a258a8ae9972aef5dbf547c5ea3e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nrb"}}