{"action":"created","issue":{"url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/1683","repository_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml","labels_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/1683/labels{/name}","comments_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/1683/comments","events_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/1683/events","html_url":"https://github.com/microsoft/microsoft-ui-xaml/pull/1683","id":529043724,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1OTk0MzY5","number":1683,"title":" Move NavigationView to Repeater","user":{"login":"ojhad","id":6562139,"node_id":"MDQ6VXNlcjY1NjIxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6562139?v=4","gravatar_id":"","url":"https://api.github.com/users/ojhad","html_url":"https://github.com/ojhad","followers_url":"https://api.github.com/users/ojhad/followers","following_url":"https://api.github.com/users/ojhad/following{/other_user}","gists_url":"https://api.github.com/users/ojhad/gists{/gist_id}","starred_url":"https://api.github.com/users/ojhad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojhad/subscriptions","organizations_url":"https://api.github.com/users/ojhad/orgs","repos_url":"https://api.github.com/users/ojhad/repos","events_url":"https://api.github.com/users/ojhad/events{/privacy}","received_events_url":"https://api.github.com/users/ojhad/received_events","type":"User","site_admin":false},"labels":[{"id":1167178022,"node_id":"MDU6TGFiZWwxMTY3MTc4MDIy","url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/labels/area-NavigationView","name":"area-NavigationView","color":"006b75","default":false,"description":"NavView control"},{"id":1659453645,"node_id":"MDU6TGFiZWwxNjU5NDUzNjQ1","url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/labels/team-Controls","name":"team-Controls","color":"7b03b2","default":false,"description":"Issue for the Controls team"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2019-11-27T00:24:36Z","updated_at":"2019-12-20T20:40:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/pulls/1683","html_url":"https://github.com/microsoft/microsoft-ui-xaml/pull/1683","diff_url":"https://github.com/microsoft/microsoft-ui-xaml/pull/1683.diff","patch_url":"https://github.com/microsoft/microsoft-ui-xaml/pull/1683.patch"},"body":"Also fixes ItemsRepeater bug #1671 \r\n\r\n## Description \r\nReplaced ListView with ItemsRepeater in NavigationView.\r\n\r\n## Motivation and Context\r\nIssue #378 \r\nIssue #1477 \r\nNavigationView's dependency on ListView is a drawback in places where we have to circumvent some of ListView's existing behaviors which results in complicated codepaths and is a way for bugs to be introduced. As more behavior gets added to the control, the more we have to fight with ListView in order to get desired behavior. Moving to ItemsRepeater will provide us more freedom in implementing future functionality as well as resolve some issues that the control currently has due to the usage of ListView.\r\n\r\n## How Has This Been Tested?\r\n- Ran current test corpus \r\n\r\nTesting is not in a completed state yet, I will be cleaning up the current tests and adding more tests (probably in a separate PR and then bringing that over here). \r\n"},"comment":{"url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/comments/568080148","html_url":"https://github.com/microsoft/microsoft-ui-xaml/pull/1683#issuecomment-568080148","issue_url":"https://api.github.com/repos/microsoft/microsoft-ui-xaml/issues/1683","id":568080148,"node_id":"MDEyOklzc3VlQ29tbWVudDU2ODA4MDE0OA==","user":{"login":"StephenLPeters","id":7758786,"node_id":"MDQ6VXNlcjc3NTg3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/7758786?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenLPeters","html_url":"https://github.com/StephenLPeters","followers_url":"https://api.github.com/users/StephenLPeters/followers","following_url":"https://api.github.com/users/StephenLPeters/following{/other_user}","gists_url":"https://api.github.com/users/StephenLPeters/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenLPeters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenLPeters/subscriptions","organizations_url":"https://api.github.com/users/StephenLPeters/orgs","repos_url":"https://api.github.com/users/StephenLPeters/repos","events_url":"https://api.github.com/users/StephenLPeters/events{/privacy}","received_events_url":"https://api.github.com/users/StephenLPeters/received_events","type":"User","site_admin":false},"created_at":"2019-12-20T20:40:24Z","updated_at":"2019-12-20T20:40:24Z","author_association":"CONTRIBUTOR","body":">     return position;\r\n\r\nreturn a default value here\r\n\r\n---\r\nRefers to: dev/NavigationView/NavigationViewItemAutomationPeer.cpp:192 in b9d33f5. [](commit_id = b9d33f5c416d8b3cd51b2bacbe0be9350b4ca062, deletion_comment = False)"}}
{"actor":{"display_login":"StephenLPeters"}}