{"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/northstar/pulls/comments/357807836","pull_request_review_id":332083545,"id":357807836,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NzgwNzgzNg==","diff_hunk":"@@ -23,4 +23,6 @@\n     'optional-fields' => env('DS_OPTIONAL_FIELDS', false),\n \n     'refer-friends-scholarship' => env('DS_REFER_FRIENDS_SCHOLARSHIP_TEST', false),\n+\n+    'no-badge-campaigns' => explode(',', env('DS_CONTENTFUL_IDS_FOR_CAMPAIGNS_WITH_NO_BADGES', null)),","path":"config/features.php","position":5,"original_position":5,"commit_id":"4e0f04cc50b23de13eea91ce53ff46bc38639e62","original_commit_id":"4e0f04cc50b23de13eea91ce53ff46bc38639e62","user":{"login":"katiecrane","id":4240292,"node_id":"MDQ6VXNlcjQyNDAyOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4240292?v=4","gravatar_id":"","url":"https://api.github.com/users/katiecrane","html_url":"https://github.com/katiecrane","followers_url":"https://api.github.com/users/katiecrane/followers","following_url":"https://api.github.com/users/katiecrane/following{/other_user}","gists_url":"https://api.github.com/users/katiecrane/gists{/gist_id}","starred_url":"https://api.github.com/users/katiecrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katiecrane/subscriptions","organizations_url":"https://api.github.com/users/katiecrane/orgs","repos_url":"https://api.github.com/users/katiecrane/repos","events_url":"https://api.github.com/users/katiecrane/events{/privacy}","received_events_url":"https://api.github.com/users/katiecrane/received_events","type":"User","site_admin":false},"body":"I really like this grouping idea, I'm adding this to our list of cleanup work for the start of the year (since I agree it's more than we want to do today).","created_at":"2019-12-13T19:53:28Z","updated_at":"2019-12-13T19:53:29Z","html_url":"https://github.com/DoSomething/northstar/pull/969#discussion_r357807836","pull_request_url":"https://api.github.com/repos/DoSomething/northstar/pulls/969","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/comments/357807836"},"html":{"href":"https://github.com/DoSomething/northstar/pull/969#discussion_r357807836"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/969"}},"in_reply_to_id":357802467},"pull_request":{"url":"https://api.github.com/repos/DoSomething/northstar/pulls/969","id":353036259,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMDM2MjU5","html_url":"https://github.com/DoSomething/northstar/pull/969","diff_url":"https://github.com/DoSomething/northstar/pull/969.diff","patch_url":"https://github.com/DoSomething/northstar/pull/969.patch","issue_url":"https://api.github.com/repos/DoSomething/northstar/issues/969","number":969,"state":"open","locked":false,"title":"Expand badges configuration - allow campaigns to be opted out","user":{"login":"katiecrane","id":4240292,"node_id":"MDQ6VXNlcjQyNDAyOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4240292?v=4","gravatar_id":"","url":"https://api.github.com/users/katiecrane","html_url":"https://github.com/katiecrane","followers_url":"https://api.github.com/users/katiecrane/followers","following_url":"https://api.github.com/users/katiecrane/following{/other_user}","gists_url":"https://api.github.com/users/katiecrane/gists{/gist_id}","starred_url":"https://api.github.com/users/katiecrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katiecrane/subscriptions","organizations_url":"https://api.github.com/users/katiecrane/orgs","repos_url":"https://api.github.com/users/katiecrane/repos","events_url":"https://api.github.com/users/katiecrane/events{/privacy}","received_events_url":"https://api.github.com/users/katiecrane/received_events","type":"User","site_admin":false},"body":"### What's this PR do?\r\n\r\nThis pull request creates a new environment variable `DS_CONTENTFUL_IDS_FOR_CAMPAIGNS_WITH_NO_BADGES`. The variable takes a comma separated list of Contentful IDs.\r\n\r\nCurrently when a user registers from a campaign page, we save the Contentful ID of the campaign in their `source_detail`. Now, if their `source_detail` contains one of these excluded Contentful IDs, we will NOT opt them in to the badges experiment. They will have NO `feature_flags` value for `badges`.\r\n\r\n### How should this be reviewed?\r\n\r\nIs this the best way to accomplish this goal? Does this provide a way to test on QA and also configure on prod?\r\n\r\n### Any background context you want to provide?\r\n\r\nWe don't want to give teachers badges.\r\n\r\n### Relevant tickets\r\n\r\nReferences [Pivotal #170284773](https://www.pivotaltracker.com/story/show/170284773).\r\n\r\n### Checklist\r\n\r\n- [ ] This PR has been added to the relevant Pivotal card.\r\n- [ ] Documentation added for new features/changed endpoints.\r\n- [ ] Added appropriate feature/unit tests.\r\n","created_at":"2019-12-13T19:30:51Z","updated_at":"2019-12-13T19:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecfb2d3af3ce2e3605bb799ffa57f23215cb68d7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Vmack","id":18747117,"node_id":"MDQ6VXNlcjE4NzQ3MTE3","avatar_url":"https://avatars3.githubusercontent.com/u/18747117?v=4","gravatar_id":"","url":"https://api.github.com/users/Vmack","html_url":"https://github.com/Vmack","followers_url":"https://api.github.com/users/Vmack/followers","following_url":"https://api.github.com/users/Vmack/following{/other_user}","gists_url":"https://api.github.com/users/Vmack/gists{/gist_id}","starred_url":"https://api.github.com/users/Vmack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vmack/subscriptions","organizations_url":"https://api.github.com/users/Vmack/orgs","repos_url":"https://api.github.com/users/Vmack/repos","events_url":"https://api.github.com/users/Vmack/events{/privacy}","received_events_url":"https://api.github.com/users/Vmack/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/northstar/pulls/969/commits","review_comments_url":"https://api.github.com/repos/DoSomething/northstar/pulls/969/comments","review_comment_url":"https://api.github.com/repos/DoSomething/northstar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/northstar/issues/969/comments","statuses_url":"https://api.github.com/repos/DoSomething/northstar/statuses/4e0f04cc50b23de13eea91ce53ff46bc38639e62","head":{"label":"DoSomething:no-teacher-badges","ref":"no-teacher-badges","sha":"4e0f04cc50b23de13eea91ce53ff46bc38639e62","user":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":26884886,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg4NDg4Ng==","name":"northstar","full_name":"DoSomething/northstar","private":false,"owner":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DoSomething/northstar","description":":sparkles: The DoSomething.org user & identity service.","fork":false,"url":"https://api.github.com/repos/DoSomething/northstar","forks_url":"https://api.github.com/repos/DoSomething/northstar/forks","keys_url":"https://api.github.com/repos/DoSomething/northstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/northstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/northstar/teams","hooks_url":"https://api.github.com/repos/DoSomething/northstar/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/northstar/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/northstar/events","assignees_url":"https://api.github.com/repos/DoSomething/northstar/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/northstar/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/northstar/tags","blobs_url":"https://api.github.com/repos/DoSomething/northstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/northstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/northstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/northstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/northstar/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/northstar/languages","stargazers_url":"https://api.github.com/repos/DoSomething/northstar/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/northstar/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/northstar/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/northstar/subscription","commits_url":"https://api.github.com/repos/DoSomething/northstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/northstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/northstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/northstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/northstar/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/northstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/northstar/merges","archive_url":"https://api.github.com/repos/DoSomething/northstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/northstar/downloads","issues_url":"https://api.github.com/repos/DoSomething/northstar/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/northstar/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/northstar/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/northstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/northstar/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/northstar/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/northstar/deployments","created_at":"2014-11-19T22:33:42Z","updated_at":"2019-12-12T20:30:11Z","pushed_at":"2019-12-13T19:30:52Z","git_url":"git://github.com/DoSomething/northstar.git","ssh_url":"git@github.com:DoSomething/northstar.git","clone_url":"https://github.com/DoSomething/northstar.git","svn_url":"https://github.com/DoSomething/northstar","homepage":"https://profile.dosomething.org","size":8579,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":13,"watchers":5,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"ebd2ed52ee328c5ac1ec61c4569f1448f8340764","user":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":26884886,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg4NDg4Ng==","name":"northstar","full_name":"DoSomething/northstar","private":false,"owner":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DoSomething/northstar","description":":sparkles: The DoSomething.org user & identity service.","fork":false,"url":"https://api.github.com/repos/DoSomething/northstar","forks_url":"https://api.github.com/repos/DoSomething/northstar/forks","keys_url":"https://api.github.com/repos/DoSomething/northstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/northstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/northstar/teams","hooks_url":"https://api.github.com/repos/DoSomething/northstar/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/northstar/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/northstar/events","assignees_url":"https://api.github.com/repos/DoSomething/northstar/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/northstar/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/northstar/tags","blobs_url":"https://api.github.com/repos/DoSomething/northstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/northstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/northstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/northstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/northstar/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/northstar/languages","stargazers_url":"https://api.github.com/repos/DoSomething/northstar/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/northstar/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/northstar/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/northstar/subscription","commits_url":"https://api.github.com/repos/DoSomething/northstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/northstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/northstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/northstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/northstar/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/northstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/northstar/merges","archive_url":"https://api.github.com/repos/DoSomething/northstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/northstar/downloads","issues_url":"https://api.github.com/repos/DoSomething/northstar/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/northstar/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/northstar/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/northstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/northstar/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/northstar/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/northstar/deployments","created_at":"2014-11-19T22:33:42Z","updated_at":"2019-12-12T20:30:11Z","pushed_at":"2019-12-13T19:30:52Z","git_url":"git://github.com/DoSomething/northstar.git","ssh_url":"git@github.com:DoSomething/northstar.git","clone_url":"https://github.com/DoSomething/northstar.git","svn_url":"https://github.com/DoSomething/northstar","homepage":"https://profile.dosomething.org","size":8579,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":13,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/969"},"html":{"href":"https://github.com/DoSomething/northstar/pull/969"},"issue":{"href":"https://api.github.com/repos/DoSomething/northstar/issues/969"},"comments":{"href":"https://api.github.com/repos/DoSomething/northstar/issues/969/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/969/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/969/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/northstar/statuses/4e0f04cc50b23de13eea91ce53ff46bc38639e62"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"katiecrane"}}