{"push_id":3888324199,"size":57,"distinct_size":0,"ref":"refs/heads/diagnostic_builder","head":"a3b689d13ea96bba91dba32a528eb425e7b52130","before":"ddb6a63f6c49777734c0ca998a4ee898562aa733","commits":[{"sha":"043c4ac0cb810e526ba924eac6c3839e73ae372d","author":{"name":"Szelethus","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"reviewer comments","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/043c4ac0cb810e526ba924eac6c3839e73ae372d"},{"sha":"c6d30f28e8db1b13928c1463ca64627c93b1f4be","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"[analyzer] Track the right hand side of the last store regardless of its value\n\nSummary:\nThe following code snippet taken from D64271#1572188 has an issue: namely, because `flag`'s value isn't undef or a concrete int, it isn't being tracked.\n```lang=c++\nint flag;\nbool coin();\n\nvoid foo() {\n  flag = coin();\n}\n\nvoid test() {\n  int *x = 0;\n  int local_flag;\n  flag = 1;\n\n  foo();\n  local_flag = flag;\n  if (local_flag)\n    x = new int;\n\n  foo();\n  local_flag = flag;\n  if (local_flag)\n    *x = 5;\n}\n```\nThis, in my opinion, makes no sense, other values may be interesting too. Originally added by rC185608.\n\nReviewers: NoQ, xazax.hun, rnkovacs, baloghadamsoftware, Charusso, dcoughlin\n\nReviewed By: NoQ\n\nSubscribers: whisperity, szepet, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, gamesh411, cfe-commits\n\nTags: #clang\n\nDifferential Revision: https://reviews.llvm.org/D64287","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/c6d30f28e8db1b13928c1463ca64627c93b1f4be"},{"sha":"25047a0bdb2c18a0e70a74752cdec73dbbc85ea1","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"[analyzer][NFC] Prepare visitors for different tracking kinds\n\nSummary:\nWhen we're tracking a variable that is responsible for a null pointer dereference or some other sinister programming error, we of course would like to gather as much information why we think that the variable has that specific value as possible. However, the newly introduced condition tracking shows that tracking all values this thoroughly could easily cause an intolerable growth in the bug report's length.\n\nTake, for instance the following report as an example: [[ http://cc.elte.hu:15001/Default/#is-unique=on&run=LLVM%2FClang%2FClang-tools-extra%20AFTER%20tracking%20conditions&review-status=Confirmed&review-status=False%20positive&review-status=Intentional&detection-status=New&detection-status=Reopened&detection-status=Unresolved&tab=LLVM%2FClang%2FClang-tools-extra%20AFTER%20tracking%20conditions&reportHash=07aee7deb54777a4042572f86714de35&report=4364&subtab=07aee7deb54777a4042572f86714de35 | BEFORE condition tracking ]], [[ http://cc.elte.hu:15001/Default/#is-unique=on&run=LLVM%2FClang%2FClang-tools-extra%20AFTER%20tracking%20conditions&review-status=Confirmed&review-status=False%20positive&review-status=Intentional&detection-status=New&detection-status=Reopened&detection-status=Unresolved&tab=LLVM%2FClang%2FClang-tools-extra%20AFTER%20tracking%20conditions&reportHash=07aee7deb54777a4042572f86714de35&report=3037&subtab=07aee7deb54777a4042572f86714de35 | AFTER condition tracking]]. Having an already lengthy, bug report with 18 events grew to 45 is inexcusable.\n\nThere are a variety of heuristics we discussed on the [[ http://lists.llvm.org/pipermail/cfe-dev/2019-June/062613.html | mailing list]] to combat this, all of them requiring to differentiate in between tracking a \"regular value\" and a \"condition\".\n\nThis patch introduces the new `bugreporter::TrackingKind` enum, adds it to `FindLastStoreBRVisitor` as a non-optional argument, and moves some functions around to make the code a little more coherent.\n\nReviewers: NoQ, xazax.hun, rnkovacs, Charusso, baloghadamsoftware, dcoughlin\n\nReviewed By: NoQ, Charusso\n\nSubscribers: whisperity, szepet, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, gamesh411, cfe-commits\n\nTags: #clang\n\nDifferential Revision: https://reviews.llvm.org/D64270","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/25047a0bdb2c18a0e70a74752cdec73dbbc85ea1"},{"sha":"a94b9e9e4500c5c79e2b42eb97fb3a165623cfb0","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"Add tracking kind to returnvisitor","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/a94b9e9e4500c5c79e2b42eb97fb3a165623cfb0"},{"sha":"a8af2c7ac7efaf6e8d16d912610674ffc5dfdcb2","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"expose tracking kind to the checkers","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/a8af2c7ac7efaf6e8d16d912610674ffc5dfdcb2"},{"sha":"8131cec36d86a635dd91461663ce0a2cc645e195","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"[analyzer] Note last writes to a condition only in a nested stackframe\n\nExactly what it says on the tin! The comments in the code detail this a\nlittle more too.\n\nDifferential Revision: https://reviews.llvm.org/D64272","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/8131cec36d86a635dd91461663ce0a2cc645e195"},{"sha":"92bcf6f332488f7e14f2957939fb593dbfd265b7","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"Only note last writes in *nested* stackframes","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/92bcf6f332488f7e14f2957939fb593dbfd265b7"},{"sha":"0262d222023b5d03d1c85fc22dccce7070a9d562","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"fix tests","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/0262d222023b5d03d1c85fc22dccce7070a9d562"},{"sha":"9b2e2e83524d2a081460656f64d711e676ac79df","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"fixed test","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/9b2e2e83524d2a081460656f64d711e676ac79df"},{"sha":"d15968d123fb71d7404d9411318e71400f47fa78","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"fixed compilation error","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/d15968d123fb71d7404d9411318e71400f47fa78"},{"sha":"79086f944b20f63251af97ae27538539004e7b9d","author":{"name":"Szelethus","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"Don't track assert conditions","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/79086f944b20f63251af97ae27538539004e7b9d"},{"sha":"11547823308ddc7bbe3dfeecacc7c645837c7dc3","author":{"name":"Szelethus","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"fixed a crash","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/11547823308ddc7bbe3dfeecacc7c645837c7dc3"},{"sha":"9e83755b8e573404b126fbc5d54b604713807102","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"better tests","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/9e83755b8e573404b126fbc5d54b604713807102"},{"sha":"14d376a8149d3a07b63a6458c3f7983c59898f90","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"handle ||","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/14d376a8149d3a07b63a6458c3f7983c59898f90"},{"sha":"28e5e35247a5b92a57dc5465cb51a52df648c7c2","author":{"name":"Szelethus","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"reviewer comments","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/28e5e35247a5b92a57dc5465cb51a52df648c7c2"},{"sha":"8a2763fef6a267433c7961abb4e925f0d827e205","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"prove that this is working already","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/8a2763fef6a267433c7961abb4e925f0d827e205"},{"sha":"a86775d6d56f3d93ce7d57f85254bec8d887ff9d","author":{"name":"Szelethus","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"progress","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/a86775d6d56f3d93ce7d57f85254bec8d887ff9d"},{"sha":"b8db514b855389006b3b79786e4794baa5e1a23d","author":{"name":"Szelethus","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"compile error fix","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/b8db514b855389006b3b79786e4794baa5e1a23d"},{"sha":"5206c709485db9fb2ede23fd42cdba83ea133abb","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"correct the testfile","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/5206c709485db9fb2ede23fd42cdba83ea133abb"},{"sha":"c2efa1434bb03a46d2b637e7b34d648faa80aa15","author":{"name":"Kristóf Umann","email":"110393adbfb0fd6dcfb6f9680d770d661e28ceb7@gmail.com"},"message":"remove a retarded layer of abstraction","distinct":false,"url":"https://api.github.com/repos/Szelethus/llvm-project/commits/c2efa1434bb03a46d2b637e7b34d648faa80aa15"}]}
{"actor":{"display_login":"Szelethus"}}