{"action":"created","comment":{"url":"https://api.github.com/repos/FabricMC/yarn/pulls/comments/354983065","pull_request_review_id":328396226,"id":354983065,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDk4MzA2NQ==","diff_hunk":"@@ -1,7 +1,20 @@\n CLASS net/minecraft/class_823 net/minecraft/client/render/block/entity/BannerBlockEntityRenderer\n-\tFIELD field_20810 field Lnet/minecraft/class_630;\n-\tFIELD field_20811 verticalBar Lnet/minecraft/class_630;\n-\tFIELD field_20812 topBar Lnet/minecraft/class_630;\n+\tFIELD field_20810 banner Lnet/minecraft/class_630;","path":"mappings/net/minecraft/client/render/block/entity/BannerBlockEntityRenderer.mapping","position":5,"original_position":5,"commit_id":"b1f4724089537893f01bbf508d1c68a0c42b8361","original_commit_id":"742296a0e45668f1311bf25b9f3f84c0bb07a489","user":{"login":"Sollace","id":6429283,"node_id":"MDQ6VXNlcjY0MjkyODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6429283?v=4","gravatar_id":"","url":"https://api.github.com/users/Sollace","html_url":"https://github.com/Sollace","followers_url":"https://api.github.com/users/Sollace/followers","following_url":"https://api.github.com/users/Sollace/following{/other_user}","gists_url":"https://api.github.com/users/Sollace/gists{/gist_id}","starred_url":"https://api.github.com/users/Sollace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sollace/subscriptions","organizations_url":"https://api.github.com/users/Sollace/orgs","repos_url":"https://api.github.com/users/Sollace/repos","events_url":"https://api.github.com/users/Sollace/events{/privacy}","received_events_url":"https://api.github.com/users/Sollace/received_events","type":"User","site_admin":false},"body":"Huh?\r\n\r\nField is too generic. The banner is literally a banner. It's a piece of cloth you hang on a wall of attach to a stand/pole.\r\n\r\n```1.a: a piece of cloth attached by one edge to a staff and used by a leader (such as a monarch or feudal lord) as a standard```\r\n```3 : a strip of cloth on which a sign is painted```\r\n\r\nhttps://www.merriam-webster.com/dictionary/banner","created_at":"2019-12-06T19:00:05Z","updated_at":"2019-12-06T19:00:05Z","html_url":"https://github.com/FabricMC/yarn/pull/988#discussion_r354983065","pull_request_url":"https://api.github.com/repos/FabricMC/yarn/pulls/988","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/comments/354983065"},"html":{"href":"https://github.com/FabricMC/yarn/pull/988#discussion_r354983065"},"pull_request":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/988"}},"in_reply_to_id":354979030},"pull_request":{"url":"https://api.github.com/repos/FabricMC/yarn/pulls/988","id":346158906,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2MTU4OTA2","html_url":"https://github.com/FabricMC/yarn/pull/988","diff_url":"https://github.com/FabricMC/yarn/pull/988.diff","patch_url":"https://github.com/FabricMC/yarn/pull/988.patch","issue_url":"https://api.github.com/repos/FabricMC/yarn/issues/988","number":988,"state":"open","locked":false,"title":"Renderer mappings","user":{"login":"Sollace","id":6429283,"node_id":"MDQ6VXNlcjY0MjkyODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6429283?v=4","gravatar_id":"","url":"https://api.github.com/users/Sollace","html_url":"https://github.com/Sollace","followers_url":"https://api.github.com/users/Sollace/followers","following_url":"https://api.github.com/users/Sollace/following{/other_user}","gists_url":"https://api.github.com/users/Sollace/gists{/gist_id}","starred_url":"https://api.github.com/users/Sollace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sollace/subscriptions","organizations_url":"https://api.github.com/users/Sollace/orgs","repos_url":"https://api.github.com/users/Sollace/repos","events_url":"https://api.github.com/users/Sollace/events{/privacy}","received_events_url":"https://api.github.com/users/Sollace/received_events","type":"User","site_admin":false},"body":"This maps all the parameter names in model `render` methods, the `setAngles`, and a lot of the entity renderers/feature renderers.\r\n\r\nExplanations in the commit descriptions, because it would have been too long to remember for a PR description and it's easier to write it down as I do it.\r\n\r\n90% of the parameters all filter directly down to `VertexConsumer.elements` where the usage is pretty clear:\r\n\r\n```java\r\n    default void elements(float x, float y, float z, float red, float green, float blue, float alpha, float textureU, float textureV, int overlay, int light, float normalX, float normalY, float normalZ) {\r\n        this.vertex(x, y, z);\r\n        this.color(red, green, blue, alpha);\r\n        this.texture(textureU, textureV);\r\n        this.overlay(overlay);\r\n        this.light(light);\r\n        this.normal(normalX, normalY, normalZ);\r\n        this.next();\r\n    }\r\n```\r\n\r\nThe shadow rendering in `EntityRenderDispatcher` I recognised from previous versions, and if there was any doubt they have references to other fields mentioning shadows:\r\n\r\n```java\r\nmatrix.translate(-pos.getX(), -pos.getY(), -pos.getZ());\r\nif (gameOptions.entityShadows && renderShadows && renderer.shadowRadius > 0 && !entity.isInvisible()) {\r\n    double distance = this.getSquaredDistanceToCamera(entity.getX(), entity.getY(), entity.getZ());\r\n    float opacity = (float)((1 - distance / 256) * renderer.shadowOpacity);\r\n    if (opacity > 0.0f) {\r\n        renderShadow(matrix, provider, entity, opacity, tickDelta, world, renderer.shadowRadius);\r\n    }\r\n}\r\n```\r\n\r\nShadow radius also matched here with code in my own project that was altering the shadow radius before that was remapped by the update job to reference this field.\r\n\r\n```java\r\n    @Override\r\n    public void render(AbstractClientPlayerEntity entity, float entityYaw, float tickDelta, MatrixStack stack, VertexConsumerProvider renderContext, int lightUv) {\r\n        field_4673 = renderPony.getShadowScale();\r\n        super.render(entity, entityYaw, tickDelta, stack, renderContext, lightUv);\r\n```","created_at":"2019-11-27T10:15:10Z","updated_at":"2019-12-06T19:00:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a5efe539ebfa411f62c51ca98dbe8ca0f77f91c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1347504571,"node_id":"MDU6TGFiZWwxMzQ3NTA0NTcx","url":"https://api.github.com/repos/FabricMC/yarn/labels/new","name":"new","color":"129127","default":false,"description":"A PR that maps out mainly new names"},{"id":1347503559,"node_id":"MDU6TGFiZWwxMzQ3NTAzNTU5","url":"https://api.github.com/repos/FabricMC/yarn/labels/refactor","name":"refactor","color":"09a8e8","default":false,"description":"A PR that renames existing names."},{"id":1606173234,"node_id":"MDU6TGFiZWwxNjA2MTczMjM0","url":"https://api.github.com/repos/FabricMC/yarn/labels/snapshot","name":"snapshot","color":"b383ea","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/FabricMC/yarn/pulls/988/commits","review_comments_url":"https://api.github.com/repos/FabricMC/yarn/pulls/988/comments","review_comment_url":"https://api.github.com/repos/FabricMC/yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FabricMC/yarn/issues/988/comments","statuses_url":"https://api.github.com/repos/FabricMC/yarn/statuses/b1f4724089537893f01bbf508d1c68a0c42b8361","head":{"label":"Sollace:renderer_mappings","ref":"renderer_mappings","sha":"b1f4724089537893f01bbf508d1c68a0c42b8361","user":{"login":"Sollace","id":6429283,"node_id":"MDQ6VXNlcjY0MjkyODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6429283?v=4","gravatar_id":"","url":"https://api.github.com/users/Sollace","html_url":"https://github.com/Sollace","followers_url":"https://api.github.com/users/Sollace/followers","following_url":"https://api.github.com/users/Sollace/following{/other_user}","gists_url":"https://api.github.com/users/Sollace/gists{/gist_id}","starred_url":"https://api.github.com/users/Sollace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sollace/subscriptions","organizations_url":"https://api.github.com/users/Sollace/orgs","repos_url":"https://api.github.com/users/Sollace/repos","events_url":"https://api.github.com/users/Sollace/events{/privacy}","received_events_url":"https://api.github.com/users/Sollace/received_events","type":"User","site_admin":false},"repo":{"id":189890473,"node_id":"MDEwOlJlcG9zaXRvcnkxODk4OTA0NzM=","name":"yarn","full_name":"Sollace/yarn","private":false,"owner":{"login":"Sollace","id":6429283,"node_id":"MDQ6VXNlcjY0MjkyODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6429283?v=4","gravatar_id":"","url":"https://api.github.com/users/Sollace","html_url":"https://github.com/Sollace","followers_url":"https://api.github.com/users/Sollace/followers","following_url":"https://api.github.com/users/Sollace/following{/other_user}","gists_url":"https://api.github.com/users/Sollace/gists{/gist_id}","starred_url":"https://api.github.com/users/Sollace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sollace/subscriptions","organizations_url":"https://api.github.com/users/Sollace/orgs","repos_url":"https://api.github.com/users/Sollace/repos","events_url":"https://api.github.com/users/Sollace/events{/privacy}","received_events_url":"https://api.github.com/users/Sollace/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Sollace/yarn","description":"Libre Minecraft mappings, free to use for everyone. No exceptions.","fork":true,"url":"https://api.github.com/repos/Sollace/yarn","forks_url":"https://api.github.com/repos/Sollace/yarn/forks","keys_url":"https://api.github.com/repos/Sollace/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sollace/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sollace/yarn/teams","hooks_url":"https://api.github.com/repos/Sollace/yarn/hooks","issue_events_url":"https://api.github.com/repos/Sollace/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/Sollace/yarn/events","assignees_url":"https://api.github.com/repos/Sollace/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/Sollace/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/Sollace/yarn/tags","blobs_url":"https://api.github.com/repos/Sollace/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sollace/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sollace/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sollace/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sollace/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/Sollace/yarn/languages","stargazers_url":"https://api.github.com/repos/Sollace/yarn/stargazers","contributors_url":"https://api.github.com/repos/Sollace/yarn/contributors","subscribers_url":"https://api.github.com/repos/Sollace/yarn/subscribers","subscription_url":"https://api.github.com/repos/Sollace/yarn/subscription","commits_url":"https://api.github.com/repos/Sollace/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sollace/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sollace/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sollace/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sollace/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/Sollace/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sollace/yarn/merges","archive_url":"https://api.github.com/repos/Sollace/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sollace/yarn/downloads","issues_url":"https://api.github.com/repos/Sollace/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/Sollace/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/Sollace/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/Sollace/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sollace/yarn/labels{/name}","releases_url":"https://api.github.com/repos/Sollace/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/Sollace/yarn/deployments","created_at":"2019-06-02T20:11:19Z","updated_at":"2019-11-04T10:41:08Z","pushed_at":"2019-12-06T18:56:35Z","git_url":"git://github.com/Sollace/yarn.git","ssh_url":"git@github.com:Sollace/yarn.git","clone_url":"https://github.com/Sollace/yarn.git","svn_url":"https://github.com/Sollace/yarn","homepage":"","size":22087,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.14.4"}},"base":{"label":"FabricMC:1.15-pre6","ref":"1.15-pre6","sha":"946346c722a25d5ecf3a20904bbdfb0be4e45f89","user":{"login":"FabricMC","id":21025855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDI1ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/21025855?v=4","gravatar_id":"","url":"https://api.github.com/users/FabricMC","html_url":"https://github.com/FabricMC","followers_url":"https://api.github.com/users/FabricMC/followers","following_url":"https://api.github.com/users/FabricMC/following{/other_user}","gists_url":"https://api.github.com/users/FabricMC/gists{/gist_id}","starred_url":"https://api.github.com/users/FabricMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabricMC/subscriptions","organizations_url":"https://api.github.com/users/FabricMC/orgs","repos_url":"https://api.github.com/users/FabricMC/repos","events_url":"https://api.github.com/users/FabricMC/events{/privacy}","received_events_url":"https://api.github.com/users/FabricMC/received_events","type":"Organization","site_admin":false},"repo":{"id":65555184,"node_id":"MDEwOlJlcG9zaXRvcnk2NTU1NTE4NA==","name":"yarn","full_name":"FabricMC/yarn","private":false,"owner":{"login":"FabricMC","id":21025855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDI1ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/21025855?v=4","gravatar_id":"","url":"https://api.github.com/users/FabricMC","html_url":"https://github.com/FabricMC","followers_url":"https://api.github.com/users/FabricMC/followers","following_url":"https://api.github.com/users/FabricMC/following{/other_user}","gists_url":"https://api.github.com/users/FabricMC/gists{/gist_id}","starred_url":"https://api.github.com/users/FabricMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabricMC/subscriptions","organizations_url":"https://api.github.com/users/FabricMC/orgs","repos_url":"https://api.github.com/users/FabricMC/repos","events_url":"https://api.github.com/users/FabricMC/events{/privacy}","received_events_url":"https://api.github.com/users/FabricMC/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FabricMC/yarn","description":"Libre Minecraft mappings, free to use for everyone. No exceptions.","fork":false,"url":"https://api.github.com/repos/FabricMC/yarn","forks_url":"https://api.github.com/repos/FabricMC/yarn/forks","keys_url":"https://api.github.com/repos/FabricMC/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FabricMC/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FabricMC/yarn/teams","hooks_url":"https://api.github.com/repos/FabricMC/yarn/hooks","issue_events_url":"https://api.github.com/repos/FabricMC/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/FabricMC/yarn/events","assignees_url":"https://api.github.com/repos/FabricMC/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/FabricMC/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/FabricMC/yarn/tags","blobs_url":"https://api.github.com/repos/FabricMC/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FabricMC/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FabricMC/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/FabricMC/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FabricMC/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/FabricMC/yarn/languages","stargazers_url":"https://api.github.com/repos/FabricMC/yarn/stargazers","contributors_url":"https://api.github.com/repos/FabricMC/yarn/contributors","subscribers_url":"https://api.github.com/repos/FabricMC/yarn/subscribers","subscription_url":"https://api.github.com/repos/FabricMC/yarn/subscription","commits_url":"https://api.github.com/repos/FabricMC/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/FabricMC/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/FabricMC/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/FabricMC/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/FabricMC/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/FabricMC/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FabricMC/yarn/merges","archive_url":"https://api.github.com/repos/FabricMC/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FabricMC/yarn/downloads","issues_url":"https://api.github.com/repos/FabricMC/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/FabricMC/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/FabricMC/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/FabricMC/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FabricMC/yarn/labels{/name}","releases_url":"https://api.github.com/repos/FabricMC/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/FabricMC/yarn/deployments","created_at":"2016-08-12T13:27:21Z","updated_at":"2019-12-05T23:28:24Z","pushed_at":"2019-12-06T18:56:36Z","git_url":"git://github.com/FabricMC/yarn.git","ssh_url":"git@github.com:FabricMC/yarn.git","clone_url":"https://github.com/FabricMC/yarn.git","svn_url":"https://github.com/FabricMC/yarn","homepage":"","size":22858,"stargazers_count":245,"watchers_count":245,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":79,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":149,"open_issues":79,"watchers":245,"default_branch":"1.15-pre6"}},"_links":{"self":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/988"},"html":{"href":"https://github.com/FabricMC/yarn/pull/988"},"issue":{"href":"https://api.github.com/repos/FabricMC/yarn/issues/988"},"comments":{"href":"https://api.github.com/repos/FabricMC/yarn/issues/988/comments"},"review_comments":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/988/comments"},"review_comment":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FabricMC/yarn/pulls/988/commits"},"statuses":{"href":"https://api.github.com/repos/FabricMC/yarn/statuses/b1f4724089537893f01bbf508d1c68a0c42b8361"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Sollace"}}