{"action":"created","comment":{"url":"https://api.github.com/repos/inspec/inspec/pulls/comments/284851977","pull_request_review_id":238578905,"id":284851977,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDg1MTk3Nw==","diff_hunk":"@@ -166,9 +166,9 @@ def format_with_color(color_name, text)\n     end\n \n     def all_unique_controls\n-      return @unique_controls unless @unique_controls.nil?\n+      @unique_controls ||= Set.new\n+      return @unique_controls unless @unique_controls.empty?\n \n-      @unique_controls = Set.new\n       run_data[:profiles].each do |profile|\n         profile[:controls].map { |control| @unique_controls.add(control) }\n       end","path":"lib/inspec/reporters/cli.rb","position":11,"original_position":11,"commit_id":"832dc4a1c94f82bf786576ce842199c14180fc6f","original_commit_id":"832dc4a1c94f82bf786576ce842199c14180fc6f","user":{"login":"miah","id":49856,"node_id":"MDQ6VXNlcjQ5ODU2","avatar_url":"https://avatars1.githubusercontent.com/u/49856?v=4","gravatar_id":"","url":"https://api.github.com/users/miah","html_url":"https://github.com/miah","followers_url":"https://api.github.com/users/miah/followers","following_url":"https://api.github.com/users/miah/following{/other_user}","gists_url":"https://api.github.com/users/miah/gists{/gist_id}","starred_url":"https://api.github.com/users/miah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miah/subscriptions","organizations_url":"https://api.github.com/users/miah/orgs","repos_url":"https://api.github.com/users/miah/repos","events_url":"https://api.github.com/users/miah/events{/privacy}","received_events_url":"https://api.github.com/users/miah/received_events","type":"User","site_admin":false},"body":"Perfect feedback. Thank you!","created_at":"2019-05-16T18:57:05Z","updated_at":"2019-05-16T18:57:06Z","html_url":"https://github.com/inspec/inspec/pull/4079#discussion_r284851977","pull_request_url":"https://api.github.com/repos/inspec/inspec/pulls/4079","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/inspec/inspec/pulls/comments/284851977"},"html":{"href":"https://github.com/inspec/inspec/pull/4079#discussion_r284851977"},"pull_request":{"href":"https://api.github.com/repos/inspec/inspec/pulls/4079"}},"in_reply_to_id":284850875},"pull_request":{"url":"https://api.github.com/repos/inspec/inspec/pulls/4079","id":279308842,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5MzA4ODQy","html_url":"https://github.com/inspec/inspec/pull/4079","diff_url":"https://github.com/inspec/inspec/pull/4079.diff","patch_url":"https://github.com/inspec/inspec/pull/4079.patch","issue_url":"https://api.github.com/repos/inspec/inspec/issues/4079","number":4079,"state":"open","locked":false,"title":"Fix @unique_controls uninitialized warning","user":{"login":"miah","id":49856,"node_id":"MDQ6VXNlcjQ5ODU2","avatar_url":"https://avatars1.githubusercontent.com/u/49856?v=4","gravatar_id":"","url":"https://api.github.com/users/miah","html_url":"https://github.com/miah","followers_url":"https://api.github.com/users/miah/followers","following_url":"https://api.github.com/users/miah/following{/other_user}","gists_url":"https://api.github.com/users/miah/gists{/gist_id}","starred_url":"https://api.github.com/users/miah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miah/subscriptions","organizations_url":"https://api.github.com/users/miah/orgs","repos_url":"https://api.github.com/users/miah/repos","events_url":"https://api.github.com/users/miah/events{/privacy}","received_events_url":"https://api.github.com/users/miah/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nmemoize @unique_controls to a Set if nil and\r\ncheck that its empty? to continue and add controls\r\n\r\n/home/miah/projects/github/inspec-master/lib/inspec/reporters/cli.rb:169: warning: instance variable @unique_controls not initialized\r\n\r\nSigned-off-by: Miah Johnson <miah@chia-pet.org>\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New content (non-breaking change)\r\n- [ ] Breaking change (a content change which would break existing functionality or processes)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the **CONTRIBUTING** document.\r\n","created_at":"2019-05-16T00:35:20Z","updated_at":"2019-05-16T18:57:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7070630f199349ec1dcfb4833c9f5edcc08e1063","assignee":null,"assignees":[],"requested_reviewers":[{"login":"clintoncwolfe","id":156460,"node_id":"MDQ6VXNlcjE1NjQ2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/156460?v=4","gravatar_id":"","url":"https://api.github.com/users/clintoncwolfe","html_url":"https://github.com/clintoncwolfe","followers_url":"https://api.github.com/users/clintoncwolfe/followers","following_url":"https://api.github.com/users/clintoncwolfe/following{/other_user}","gists_url":"https://api.github.com/users/clintoncwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/clintoncwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintoncwolfe/subscriptions","organizations_url":"https://api.github.com/users/clintoncwolfe/orgs","repos_url":"https://api.github.com/users/clintoncwolfe/repos","events_url":"https://api.github.com/users/clintoncwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/clintoncwolfe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/inspec/inspec/pulls/4079/commits","review_comments_url":"https://api.github.com/repos/inspec/inspec/pulls/4079/comments","review_comment_url":"https://api.github.com/repos/inspec/inspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inspec/inspec/issues/4079/comments","statuses_url":"https://api.github.com/repos/inspec/inspec/statuses/832dc4a1c94f82bf786576ce842199c14180fc6f","head":{"label":"inspec:mj/cli_warn","ref":"mj/cli_warn","sha":"832dc4a1c94f82bf786576ce842199c14180fc6f","user":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"repo":{"id":41571541,"node_id":"MDEwOlJlcG9zaXRvcnk0MTU3MTU0MQ==","name":"inspec","full_name":"inspec/inspec","private":false,"owner":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inspec/inspec","description":"InSpec: Auditing and Testing Framework","fork":false,"url":"https://api.github.com/repos/inspec/inspec","forks_url":"https://api.github.com/repos/inspec/inspec/forks","keys_url":"https://api.github.com/repos/inspec/inspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspec/inspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspec/inspec/teams","hooks_url":"https://api.github.com/repos/inspec/inspec/hooks","issue_events_url":"https://api.github.com/repos/inspec/inspec/issues/events{/number}","events_url":"https://api.github.com/repos/inspec/inspec/events","assignees_url":"https://api.github.com/repos/inspec/inspec/assignees{/user}","branches_url":"https://api.github.com/repos/inspec/inspec/branches{/branch}","tags_url":"https://api.github.com/repos/inspec/inspec/tags","blobs_url":"https://api.github.com/repos/inspec/inspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspec/inspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspec/inspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspec/inspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspec/inspec/statuses/{sha}","languages_url":"https://api.github.com/repos/inspec/inspec/languages","stargazers_url":"https://api.github.com/repos/inspec/inspec/stargazers","contributors_url":"https://api.github.com/repos/inspec/inspec/contributors","subscribers_url":"https://api.github.com/repos/inspec/inspec/subscribers","subscription_url":"https://api.github.com/repos/inspec/inspec/subscription","commits_url":"https://api.github.com/repos/inspec/inspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspec/inspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspec/inspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspec/inspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspec/inspec/contents/{+path}","compare_url":"https://api.github.com/repos/inspec/inspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspec/inspec/merges","archive_url":"https://api.github.com/repos/inspec/inspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspec/inspec/downloads","issues_url":"https://api.github.com/repos/inspec/inspec/issues{/number}","pulls_url":"https://api.github.com/repos/inspec/inspec/pulls{/number}","milestones_url":"https://api.github.com/repos/inspec/inspec/milestones{/number}","notifications_url":"https://api.github.com/repos/inspec/inspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspec/inspec/labels{/name}","releases_url":"https://api.github.com/repos/inspec/inspec/releases{/id}","deployments_url":"https://api.github.com/repos/inspec/inspec/deployments","created_at":"2015-08-28T22:16:01Z","updated_at":"2019-05-16T18:45:39Z","pushed_at":"2019-05-16T18:45:34Z","git_url":"git://github.com/inspec/inspec.git","ssh_url":"git@github.com:inspec/inspec.git","clone_url":"https://github.com/inspec/inspec.git","svn_url":"https://github.com/inspec/inspec","homepage":"http://inspec.io","size":15995,"stargazers_count":1776,"watchers_count":1776,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":494,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":595,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":494,"open_issues":595,"watchers":1776,"default_branch":"master"}},"base":{"label":"inspec:master","ref":"master","sha":"67929db658accf271d8e52b70e110e6e7921b61d","user":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"repo":{"id":41571541,"node_id":"MDEwOlJlcG9zaXRvcnk0MTU3MTU0MQ==","name":"inspec","full_name":"inspec/inspec","private":false,"owner":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inspec/inspec","description":"InSpec: Auditing and Testing Framework","fork":false,"url":"https://api.github.com/repos/inspec/inspec","forks_url":"https://api.github.com/repos/inspec/inspec/forks","keys_url":"https://api.github.com/repos/inspec/inspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspec/inspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspec/inspec/teams","hooks_url":"https://api.github.com/repos/inspec/inspec/hooks","issue_events_url":"https://api.github.com/repos/inspec/inspec/issues/events{/number}","events_url":"https://api.github.com/repos/inspec/inspec/events","assignees_url":"https://api.github.com/repos/inspec/inspec/assignees{/user}","branches_url":"https://api.github.com/repos/inspec/inspec/branches{/branch}","tags_url":"https://api.github.com/repos/inspec/inspec/tags","blobs_url":"https://api.github.com/repos/inspec/inspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspec/inspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspec/inspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspec/inspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspec/inspec/statuses/{sha}","languages_url":"https://api.github.com/repos/inspec/inspec/languages","stargazers_url":"https://api.github.com/repos/inspec/inspec/stargazers","contributors_url":"https://api.github.com/repos/inspec/inspec/contributors","subscribers_url":"https://api.github.com/repos/inspec/inspec/subscribers","subscription_url":"https://api.github.com/repos/inspec/inspec/subscription","commits_url":"https://api.github.com/repos/inspec/inspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspec/inspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspec/inspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspec/inspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspec/inspec/contents/{+path}","compare_url":"https://api.github.com/repos/inspec/inspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspec/inspec/merges","archive_url":"https://api.github.com/repos/inspec/inspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspec/inspec/downloads","issues_url":"https://api.github.com/repos/inspec/inspec/issues{/number}","pulls_url":"https://api.github.com/repos/inspec/inspec/pulls{/number}","milestones_url":"https://api.github.com/repos/inspec/inspec/milestones{/number}","notifications_url":"https://api.github.com/repos/inspec/inspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspec/inspec/labels{/name}","releases_url":"https://api.github.com/repos/inspec/inspec/releases{/id}","deployments_url":"https://api.github.com/repos/inspec/inspec/deployments","created_at":"2015-08-28T22:16:01Z","updated_at":"2019-05-16T18:45:39Z","pushed_at":"2019-05-16T18:45:34Z","git_url":"git://github.com/inspec/inspec.git","ssh_url":"git@github.com:inspec/inspec.git","clone_url":"https://github.com/inspec/inspec.git","svn_url":"https://github.com/inspec/inspec","homepage":"http://inspec.io","size":15995,"stargazers_count":1776,"watchers_count":1776,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":494,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":595,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":494,"open_issues":595,"watchers":1776,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspec/inspec/pulls/4079"},"html":{"href":"https://github.com/inspec/inspec/pull/4079"},"issue":{"href":"https://api.github.com/repos/inspec/inspec/issues/4079"},"comments":{"href":"https://api.github.com/repos/inspec/inspec/issues/4079/comments"},"review_comments":{"href":"https://api.github.com/repos/inspec/inspec/pulls/4079/comments"},"review_comment":{"href":"https://api.github.com/repos/inspec/inspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inspec/inspec/pulls/4079/commits"},"statuses":{"href":"https://api.github.com/repos/inspec/inspec/statuses/832dc4a1c94f82bf786576ce842199c14180fc6f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"miah"}}