{"action":"closed","number":4596,"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/4596","id":293591089,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzNTkxMDg5","html_url":"https://github.com/knative/serving/pull/4596","diff_url":"https://github.com/knative/serving/pull/4596.diff","patch_url":"https://github.com/knative/serving/pull/4596.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/4596","number":4596,"state":"closed","locked":false,"title":"Remove the check, since it's useless.","user":{"login":"vagababov","id":764767,"node_id":"MDQ6VXNlcjc2NDc2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/764767?v=4","gravatar_id":"","url":"https://api.github.com/users/vagababov","html_url":"https://github.com/vagababov","followers_url":"https://api.github.com/users/vagababov/followers","following_url":"https://api.github.com/users/vagababov/following{/other_user}","gists_url":"https://api.github.com/users/vagababov/gists{/gist_id}","starred_url":"https://api.github.com/users/vagababov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vagababov/subscriptions","organizations_url":"https://api.github.com/users/vagababov/orgs","repos_url":"https://api.github.com/users/vagababov/repos","events_url":"https://api.github.com/users/vagababov/events{/privacy}","received_events_url":"https://api.github.com/users/vagababov/received_events","type":"User","site_admin":false},"body":"The way code is written that check can never fail.\r\nAs such, let's speedup the code and save cycles.\r\n\r\nAlso gofmt redid ordering.\r\n\r\n/assign @markusthoemmes\r\n\r\n","created_at":"2019-07-02T05:43:23Z","updated_at":"2019-07-02T16:48:33Z","closed_at":"2019-07-02T16:48:33Z","merged_at":"2019-07-02T16:48:33Z","merge_commit_sha":"d7f29bd1a436bd651b2fa5ecf042ece6bf7cb09d","assignee":{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},"assignees":[{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":873831452,"node_id":"MDU6TGFiZWw4NzM4MzE0NTI=","url":"https://api.github.com/repos/knative/serving/labels/approved","name":"approved","color":"ededed","default":false},{"id":868660931,"node_id":"MDU6TGFiZWw4Njg2NjA5MzE=","url":"https://api.github.com/repos/knative/serving/labels/area/networking","name":"area/networking","color":"e59cc2","default":false},{"id":1294350338,"node_id":"MDU6TGFiZWwxMjk0MzUwMzM4","url":"https://api.github.com/repos/knative/serving/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":864751607,"node_id":"MDU6TGFiZWw4NjQ3NTE2MDc=","url":"https://api.github.com/repos/knative/serving/labels/lgtm","name":"lgtm","color":"ededed","default":false},{"id":860818304,"node_id":"MDU6TGFiZWw4NjA4MTgzMDQ=","url":"https://api.github.com/repos/knative/serving/labels/size/S","name":"size/S","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/4596/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/4596/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/4596/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/96550c72c9472ef7b163d777f3774115b4126b34","head":{"label":"vagababov:remove-redundancy-in-loop","ref":"remove-redundancy-in-loop","sha":"96550c72c9472ef7b163d777f3774115b4126b34","user":{"login":"vagababov","id":764767,"node_id":"MDQ6VXNlcjc2NDc2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/764767?v=4","gravatar_id":"","url":"https://api.github.com/users/vagababov","html_url":"https://github.com/vagababov","followers_url":"https://api.github.com/users/vagababov/followers","following_url":"https://api.github.com/users/vagababov/following{/other_user}","gists_url":"https://api.github.com/users/vagababov/gists{/gist_id}","starred_url":"https://api.github.com/users/vagababov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vagababov/subscriptions","organizations_url":"https://api.github.com/users/vagababov/orgs","repos_url":"https://api.github.com/users/vagababov/repos","events_url":"https://api.github.com/users/vagababov/events{/privacy}","received_events_url":"https://api.github.com/users/vagababov/received_events","type":"User","site_admin":false},"repo":{"id":159222472,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkyMjI0NzI=","name":"serving","full_name":"vagababov/serving","private":false,"owner":{"login":"vagababov","id":764767,"node_id":"MDQ6VXNlcjc2NDc2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/764767?v=4","gravatar_id":"","url":"https://api.github.com/users/vagababov","html_url":"https://github.com/vagababov","followers_url":"https://api.github.com/users/vagababov/followers","following_url":"https://api.github.com/users/vagababov/following{/other_user}","gists_url":"https://api.github.com/users/vagababov/gists{/gist_id}","starred_url":"https://api.github.com/users/vagababov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vagababov/subscriptions","organizations_url":"https://api.github.com/users/vagababov/orgs","repos_url":"https://api.github.com/users/vagababov/repos","events_url":"https://api.github.com/users/vagababov/events{/privacy}","received_events_url":"https://api.github.com/users/vagababov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vagababov/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/vagababov/serving","forks_url":"https://api.github.com/repos/vagababov/serving/forks","keys_url":"https://api.github.com/repos/vagababov/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vagababov/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vagababov/serving/teams","hooks_url":"https://api.github.com/repos/vagababov/serving/hooks","issue_events_url":"https://api.github.com/repos/vagababov/serving/issues/events{/number}","events_url":"https://api.github.com/repos/vagababov/serving/events","assignees_url":"https://api.github.com/repos/vagababov/serving/assignees{/user}","branches_url":"https://api.github.com/repos/vagababov/serving/branches{/branch}","tags_url":"https://api.github.com/repos/vagababov/serving/tags","blobs_url":"https://api.github.com/repos/vagababov/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vagababov/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vagababov/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/vagababov/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vagababov/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/vagababov/serving/languages","stargazers_url":"https://api.github.com/repos/vagababov/serving/stargazers","contributors_url":"https://api.github.com/repos/vagababov/serving/contributors","subscribers_url":"https://api.github.com/repos/vagababov/serving/subscribers","subscription_url":"https://api.github.com/repos/vagababov/serving/subscription","commits_url":"https://api.github.com/repos/vagababov/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/vagababov/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/vagababov/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/vagababov/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/vagababov/serving/contents/{+path}","compare_url":"https://api.github.com/repos/vagababov/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vagababov/serving/merges","archive_url":"https://api.github.com/repos/vagababov/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vagababov/serving/downloads","issues_url":"https://api.github.com/repos/vagababov/serving/issues{/number}","pulls_url":"https://api.github.com/repos/vagababov/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/vagababov/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/vagababov/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vagababov/serving/labels{/name}","releases_url":"https://api.github.com/repos/vagababov/serving/releases{/id}","deployments_url":"https://api.github.com/repos/vagababov/serving/deployments","created_at":"2018-11-26T19:35:50Z","updated_at":"2019-07-02T04:04:41Z","pushed_at":"2019-07-02T15:41:25Z","git_url":"git://github.com/vagababov/serving.git","ssh_url":"git@github.com:vagababov/serving.git","clone_url":"https://github.com/vagababov/serving.git","svn_url":"https://github.com/vagababov/serving","homepage":"","size":37152,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"13e854108202e6d1c9d3d3d692f2741b251a29b5","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2019-07-02T14:57:42Z","pushed_at":"2019-07-02T16:48:33Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"https://knative.dev/docs/serving/","size":37091,"stargazers_count":1997,"watchers_count":1997,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":389,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":271,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":389,"open_issues":271,"watchers":1997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/4596"},"html":{"href":"https://github.com/knative/serving/pull/4596"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/4596"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/4596/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/4596/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/4596/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/96550c72c9472ef7b163d777f3774115b4126b34"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":13,"changed_files":1}}
{"actor":{"display_login":"knative-prow-robot"}}