{"action":"created","comment":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments/353451592","pull_request_review_id":326485927,"id":353451592,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzQ1MTU5Mg==","diff_hunk":"@@ -246,16 +246,16 @@ private void restartIfNecessary(int podId, boolean finalAttempt)\n             try {\n                 try {\n                     adminClient = adminClient(podId);\n-                    Integer controller = controller(podId, adminClient, 1, TimeUnit.MINUTES);\n+                    Integer controller = controller(podId, adminClient, operationTimeoutMs, TimeUnit.MILLISECONDS);\n                     int stillRunning = podToContext.reduceValuesToInt(100, v -> v.future.isComplete() ? 0 : 1,\n                             0, Integer::sum);\n                     if (controller == podId && stillRunning > 1) {\n                         log.debug(\"Pod {} is controller and there are other pods to roll\", podId);\n                         throw new ForceableProblem(\"Pod \" + podName(podId) + \" is currently the controller and there are other pods still to roll\");\n                     } else {\n-                        if (canRoll(adminClient, podId, 1, TimeUnit.MINUTES)) {\n+                        if (canRoll(adminClient, podId, 1_000, TimeUnit.MILLISECONDS)) {","path":"cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/resource/KafkaRoller.java","position":13,"original_position":13,"commit_id":"c164e4a7a3f751bc2ea365b0814620f1be43d2f5","original_commit_id":"c164e4a7a3f751bc2ea365b0814620f1be43d2f5","user":{"login":"scholzj","id":5658439,"node_id":"MDQ6VXNlcjU2NTg0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"body":"Ehh, I do not think 1000ms is one minute ... now you made a bit too short ;-)","created_at":"2019-12-03T22:15:42Z","updated_at":"2019-12-03T22:15:43Z","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/2270#discussion_r353451592","pull_request_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/2270","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments/353451592"},"html":{"href":"https://github.com/strimzi/strimzi-kafka-operator/pull/2270#discussion_r353451592"},"pull_request":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/2270"}}},"pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/2270","id":348210444,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4MjEwNDQ0","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/2270","diff_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/2270.diff","patch_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/2270.patch","issue_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/2270","number":2270,"state":"open","locked":false,"title":"Remove hardcoded timeouts","user":{"login":"stanlyDoge","id":19408098,"node_id":"MDQ6VXNlcjE5NDA4MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/19408098?v=4","gravatar_id":"","url":"https://api.github.com/users/stanlyDoge","html_url":"https://github.com/stanlyDoge","followers_url":"https://api.github.com/users/stanlyDoge/followers","following_url":"https://api.github.com/users/stanlyDoge/following{/other_user}","gists_url":"https://api.github.com/users/stanlyDoge/gists{/gist_id}","starred_url":"https://api.github.com/users/stanlyDoge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanlyDoge/subscriptions","organizations_url":"https://api.github.com/users/stanlyDoge/orgs","repos_url":"https://api.github.com/users/stanlyDoge/repos","events_url":"https://api.github.com/users/stanlyDoge/events{/privacy}","received_events_url":"https://api.github.com/users/stanlyDoge/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Stanislav Knot <sknot@redhat.com>\r\n\r\n### Type of change\r\n- Refactoring\r\n\r\n### Description\r\nRemoving hardcoded timeouts for operations. Fixes https://github.com/strimzi/strimzi-kafka-operator/issues/2262\r\n\r\n### Checklist\r\n\r\n_Please go through this checklist and make sure all applicable tasks have been done_\r\n\r\n- [ ] Update/write design documentation in `./design`\r\n- [ ] Write tests\r\n- [ ] Make sure all tests pass\r\n- [ ] Update documentation\r\n- [ ] Check RBAC rights for Kubernetes / OpenShift roles\r\n- [ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally\r\n- [ ] Reference relevant issue(s) and close them after merging\r\n- [ ] Update CHANGELOG.md\r\n\r\n","created_at":"2019-12-03T09:14:18Z","updated_at":"2019-12-03T22:15:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2f36ae64a317759a802c83950dcdd4aa9b5a334","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tombentley","id":879487,"node_id":"MDQ6VXNlcjg3OTQ4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/879487?v=4","gravatar_id":"","url":"https://api.github.com/users/tombentley","html_url":"https://github.com/tombentley","followers_url":"https://api.github.com/users/tombentley/followers","following_url":"https://api.github.com/users/tombentley/following{/other_user}","gists_url":"https://api.github.com/users/tombentley/gists{/gist_id}","starred_url":"https://api.github.com/users/tombentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombentley/subscriptions","organizations_url":"https://api.github.com/users/tombentley/orgs","repos_url":"https://api.github.com/users/tombentley/repos","events_url":"https://api.github.com/users/tombentley/events{/privacy}","received_events_url":"https://api.github.com/users/tombentley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones/15","html_url":"https://github.com/strimzi/strimzi-kafka-operator/milestone/15","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones/15/labels","id":4863716,"node_id":"MDk6TWlsZXN0b25lNDg2MzcxNg==","number":15,"title":"0.16.0","description":"","creator":{"login":"scholzj","id":5658439,"node_id":"MDQ6VXNlcjU2NTg0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":22,"state":"open","created_at":"2019-11-20T16:48:34Z","updated_at":"2019-12-03T13:47:05Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/2270/commits","review_comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/2270/comments","review_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/2270/comments","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/c164e4a7a3f751bc2ea365b0814620f1be43d2f5","head":{"label":"stanlyDoge:remove-hardcoded-timeouts","ref":"remove-hardcoded-timeouts","sha":"c164e4a7a3f751bc2ea365b0814620f1be43d2f5","user":{"login":"stanlyDoge","id":19408098,"node_id":"MDQ6VXNlcjE5NDA4MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/19408098?v=4","gravatar_id":"","url":"https://api.github.com/users/stanlyDoge","html_url":"https://github.com/stanlyDoge","followers_url":"https://api.github.com/users/stanlyDoge/followers","following_url":"https://api.github.com/users/stanlyDoge/following{/other_user}","gists_url":"https://api.github.com/users/stanlyDoge/gists{/gist_id}","starred_url":"https://api.github.com/users/stanlyDoge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanlyDoge/subscriptions","organizations_url":"https://api.github.com/users/stanlyDoge/orgs","repos_url":"https://api.github.com/users/stanlyDoge/repos","events_url":"https://api.github.com/users/stanlyDoge/events{/privacy}","received_events_url":"https://api.github.com/users/stanlyDoge/received_events","type":"User","site_admin":false},"repo":{"id":130844562,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4NDQ1NjI=","name":"strimzi","full_name":"stanlyDoge/strimzi","private":false,"owner":{"login":"stanlyDoge","id":19408098,"node_id":"MDQ6VXNlcjE5NDA4MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/19408098?v=4","gravatar_id":"","url":"https://api.github.com/users/stanlyDoge","html_url":"https://github.com/stanlyDoge","followers_url":"https://api.github.com/users/stanlyDoge/followers","following_url":"https://api.github.com/users/stanlyDoge/following{/other_user}","gists_url":"https://api.github.com/users/stanlyDoge/gists{/gist_id}","starred_url":"https://api.github.com/users/stanlyDoge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanlyDoge/subscriptions","organizations_url":"https://api.github.com/users/stanlyDoge/orgs","repos_url":"https://api.github.com/users/stanlyDoge/repos","events_url":"https://api.github.com/users/stanlyDoge/events{/privacy}","received_events_url":"https://api.github.com/users/stanlyDoge/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stanlyDoge/strimzi","description":"Kafka as a Service running on Kubernetes and OpenShift","fork":true,"url":"https://api.github.com/repos/stanlyDoge/strimzi","forks_url":"https://api.github.com/repos/stanlyDoge/strimzi/forks","keys_url":"https://api.github.com/repos/stanlyDoge/strimzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stanlyDoge/strimzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stanlyDoge/strimzi/teams","hooks_url":"https://api.github.com/repos/stanlyDoge/strimzi/hooks","issue_events_url":"https://api.github.com/repos/stanlyDoge/strimzi/issues/events{/number}","events_url":"https://api.github.com/repos/stanlyDoge/strimzi/events","assignees_url":"https://api.github.com/repos/stanlyDoge/strimzi/assignees{/user}","branches_url":"https://api.github.com/repos/stanlyDoge/strimzi/branches{/branch}","tags_url":"https://api.github.com/repos/stanlyDoge/strimzi/tags","blobs_url":"https://api.github.com/repos/stanlyDoge/strimzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stanlyDoge/strimzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stanlyDoge/strimzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/stanlyDoge/strimzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stanlyDoge/strimzi/statuses/{sha}","languages_url":"https://api.github.com/repos/stanlyDoge/strimzi/languages","stargazers_url":"https://api.github.com/repos/stanlyDoge/strimzi/stargazers","contributors_url":"https://api.github.com/repos/stanlyDoge/strimzi/contributors","subscribers_url":"https://api.github.com/repos/stanlyDoge/strimzi/subscribers","subscription_url":"https://api.github.com/repos/stanlyDoge/strimzi/subscription","commits_url":"https://api.github.com/repos/stanlyDoge/strimzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/stanlyDoge/strimzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/stanlyDoge/strimzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/stanlyDoge/strimzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/stanlyDoge/strimzi/contents/{+path}","compare_url":"https://api.github.com/repos/stanlyDoge/strimzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stanlyDoge/strimzi/merges","archive_url":"https://api.github.com/repos/stanlyDoge/strimzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stanlyDoge/strimzi/downloads","issues_url":"https://api.github.com/repos/stanlyDoge/strimzi/issues{/number}","pulls_url":"https://api.github.com/repos/stanlyDoge/strimzi/pulls{/number}","milestones_url":"https://api.github.com/repos/stanlyDoge/strimzi/milestones{/number}","notifications_url":"https://api.github.com/repos/stanlyDoge/strimzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stanlyDoge/strimzi/labels{/name}","releases_url":"https://api.github.com/repos/stanlyDoge/strimzi/releases{/id}","deployments_url":"https://api.github.com/repos/stanlyDoge/strimzi/deployments","created_at":"2018-04-24T11:36:44Z","updated_at":"2019-12-03T08:59:13Z","pushed_at":"2019-12-03T13:51:26Z","git_url":"git://github.com/stanlyDoge/strimzi.git","ssh_url":"git@github.com:stanlyDoge/strimzi.git","clone_url":"https://github.com/stanlyDoge/strimzi.git","svn_url":"https://github.com/stanlyDoge/strimzi","homepage":"http://strimzi.io/","size":24349,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strimzi:master","ref":"master","sha":"1f9c5b0de1824b2589bcfb0db66accc040d128e5","user":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE5NDE4MA==","name":"strimzi-kafka-operator","full_name":"strimzi/strimzi-kafka-operator","private":false,"owner":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strimzi/strimzi-kafka-operator","description":"Apache Kafka running on Kubernetes","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator","forks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2019-12-03T06:53:31Z","pushed_at":"2019-12-03T19:54:18Z","git_url":"git://github.com/strimzi/strimzi-kafka-operator.git","ssh_url":"git@github.com:strimzi/strimzi-kafka-operator.git","clone_url":"https://github.com/strimzi/strimzi-kafka-operator.git","svn_url":"https://github.com/strimzi/strimzi-kafka-operator","homepage":"http://strimzi.io/","size":24385,"stargazers_count":1035,"watchers_count":1035,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":263,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":223,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":263,"open_issues":223,"watchers":1035,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/2270"},"html":{"href":"https://github.com/strimzi/strimzi-kafka-operator/pull/2270"},"issue":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/2270"},"comments":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/2270/comments"},"review_comments":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/2270/comments"},"review_comment":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/2270/commits"},"statuses":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/c164e4a7a3f751bc2ea365b0814620f1be43d2f5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"scholzj"}}