{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/292006457","pull_request_review_id":247608611,"id":292006457,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MjAwNjQ1Nw==","diff_hunk":"@@ -415,11 +415,8 @@ void ssl3_digest_master_key_set_params(const SSL_SESSION *session,\n                                        OSSL_PARAM params[])\n {\n     int n = 0;\n-    int cmd = EVP_CTRL_SSL3_MASTER_SECRET;\n \n-    params[n++] = OSSL_PARAM_construct_int(OSSL_DIGEST_PARAM_CMD, &cmd,\n-                                           NULL);\n-    params[n++] = OSSL_PARAM_construct_octet_ptr(OSSL_DIGEST_PARAM_MSG,\n+    params[n++] = OSSL_PARAM_construct_octet_ptr(OSSL_DIGEST_PARAM_SSL3_MS,","path":"ssl/s3_enc.c","position":null,"original_position":9,"commit_id":"509b692c9e27286db5eec6a8bd7e7974b0abecae","original_commit_id":"1a9a26e4a387d4110b0b1cfeb097acf276ca9947","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"body":"Confirmed, there's a new commit dealing with this.","created_at":"2019-06-10T13:18:49Z","updated_at":"2019-06-10T13:18:50Z","html_url":"https://github.com/openssl/openssl/pull/9126#discussion_r292006457","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/9126","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/292006457"},"html":{"href":"https://github.com/openssl/openssl/pull/9126#discussion_r292006457"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/9126"}},"in_reply_to_id":291992391},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/9126","id":286637563,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2NjM3NTYz","html_url":"https://github.com/openssl/openssl/pull/9126","diff_url":"https://github.com/openssl/openssl/pull/9126.diff","patch_url":"https://github.com/openssl/openssl/pull/9126.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/9126","number":9126,"state":"open","locked":false,"title":"SSL: Pass the master key by explicit parameters","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"body":"The parameter keys for passing the master key down to the algorithms\r\nhandling that was done in a way that mimics the legacy EVP_MD_CTX_ctrl()\r\nfunction.  We now change that to use an explicit parameter key, and\r\nlet set_params() type functions translate that into legacy controls\r\nwhere needed, under the hood.\r\n","created_at":"2019-06-10T11:20:35Z","updated_at":"2019-06-10T13:18:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05c6f01be77c55947fbb6a2bb5a7aa14ab29b288","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mattcaswell","id":7422273,"node_id":"MDQ6VXNlcjc0MjIyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7422273?v=4","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},{"login":"slontis","id":40444794,"node_id":"MDQ6VXNlcjQwNDQ0Nzk0","avatar_url":"https://avatars1.githubusercontent.com/u/40444794?v=4","gravatar_id":"","url":"https://api.github.com/users/slontis","html_url":"https://github.com/slontis","followers_url":"https://api.github.com/users/slontis/followers","following_url":"https://api.github.com/users/slontis/following{/other_user}","gists_url":"https://api.github.com/users/slontis/gists{/gist_id}","starred_url":"https://api.github.com/users/slontis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slontis/subscriptions","organizations_url":"https://api.github.com/users/slontis/orgs","repos_url":"https://api.github.com/users/slontis/repos","events_url":"https://api.github.com/users/slontis/events{/privacy}","received_events_url":"https://api.github.com/users/slontis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":441165144,"node_id":"MDU6TGFiZWw0NDExNjUxNDQ=","url":"https://api.github.com/repos/openssl/openssl/labels/master","name":"master","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/9126/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/9126/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/9126/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/509b692c9e27286db5eec6a8bd7e7974b0abecae","head":{"label":"levitte:ssl3-md5-sha1-redo-params","ref":"ssl3-md5-sha1-redo-params","sha":"509b692c9e27286db5eec6a8bd7e7974b0abecae","user":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"repo":{"id":22960861,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk2MDg2MQ==","name":"openssl","full_name":"levitte/openssl","private":false,"owner":{"login":"levitte","id":698918,"node_id":"MDQ6VXNlcjY5ODkxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"html_url":"https://github.com/levitte/openssl","description":null,"fork":true,"url":"https://api.github.com/repos/levitte/openssl","forks_url":"https://api.github.com/repos/levitte/openssl/forks","keys_url":"https://api.github.com/repos/levitte/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/levitte/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/levitte/openssl/teams","hooks_url":"https://api.github.com/repos/levitte/openssl/hooks","issue_events_url":"https://api.github.com/repos/levitte/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/levitte/openssl/events","assignees_url":"https://api.github.com/repos/levitte/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/levitte/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/levitte/openssl/tags","blobs_url":"https://api.github.com/repos/levitte/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/levitte/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/levitte/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/levitte/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/levitte/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/levitte/openssl/languages","stargazers_url":"https://api.github.com/repos/levitte/openssl/stargazers","contributors_url":"https://api.github.com/repos/levitte/openssl/contributors","subscribers_url":"https://api.github.com/repos/levitte/openssl/subscribers","subscription_url":"https://api.github.com/repos/levitte/openssl/subscription","commits_url":"https://api.github.com/repos/levitte/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/levitte/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/levitte/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/levitte/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/levitte/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/levitte/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/levitte/openssl/merges","archive_url":"https://api.github.com/repos/levitte/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/levitte/openssl/downloads","issues_url":"https://api.github.com/repos/levitte/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/levitte/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/levitte/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/levitte/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/levitte/openssl/labels{/name}","releases_url":"https://api.github.com/repos/levitte/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/levitte/openssl/deployments","created_at":"2014-08-14T16:32:56Z","updated_at":"2019-04-09T12:45:41Z","pushed_at":"2019-06-10T13:17:56Z","git_url":"git://github.com/levitte/openssl.git","ssh_url":"git@github.com:levitte/openssl.git","clone_url":"https://github.com/levitte/openssl.git","svn_url":"https://github.com/levitte/openssl","homepage":"","size":179391,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"5ded1ca6dade13e093086573f4cebe400bff9f4d","user":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM0Njc3","name":"openssl","full_name":"openssl/openssl","private":false,"owner":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2019-06-10T10:36:01Z","pushed_at":"2019-06-10T13:17:59Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":171195,"stargazers_count":10544,"watchers_count":10544,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4604,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":894,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4604,"open_issues":894,"watchers":10544,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/9126"},"html":{"href":"https://github.com/openssl/openssl/pull/9126"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/9126"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/9126/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/9126/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/9126/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/509b692c9e27286db5eec6a8bd7e7974b0abecae"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"levitte"}}