{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/comments/297917724","pull_request_review_id":254943836,"id":297917724,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzkxNzcyNA==","diff_hunk":"@@ -67,3 +67,24 @@ def enable_monitoring_hanainstance(client, resource_group_name, instance_name, h\n         \"hanaDbPassword\": hana_db_password\n     }\n     return client.enable_monitoring(resource_group_name, instance_name, monitoring_details)\n+\n+def list_sapmonitor(client):\n+    return client.list()\n+\n+def show_sapmonitor(client, resource_group_name, monitor_name):\n+    return client.get(resource_group_name, monitor_name)\n+\n+def create_sapmonitor(client, resource_group_name, monitor_name, region, hana_subnet, hana_hostname, hana_db_sql_port, hana_db_username, hana_db_password, hana_db_name):\n+    monitoring_details = {\n+        \"location\": region,","path":"azext_hanaonazure/custom.py","position":13,"original_position":13,"commit_id":"da48f1c519fe1a3e9d6ec1b4cfe5c3aae2439b56","original_commit_id":"da48f1c519fe1a3e9d6ec1b4cfe5c3aae2439b56","user":{"login":"jovillas","id":30352805,"node_id":"MDQ6VXNlcjMwMzUyODA1","avatar_url":"https://avatars2.githubusercontent.com/u/30352805?v=4","gravatar_id":"","url":"https://api.github.com/users/jovillas","html_url":"https://github.com/jovillas","followers_url":"https://api.github.com/users/jovillas/followers","following_url":"https://api.github.com/users/jovillas/following{/other_user}","gists_url":"https://api.github.com/users/jovillas/gists{/gist_id}","starred_url":"https://api.github.com/users/jovillas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jovillas/subscriptions","organizations_url":"https://api.github.com/users/jovillas/orgs","repos_url":"https://api.github.com/users/jovillas/repos","events_url":"https://api.github.com/users/jovillas/events{/privacy}","received_events_url":"https://api.github.com/users/jovillas/received_events","type":"User","site_admin":false},"body":"I don't think this would be 100% related to the HanaDB, but to the Vnet in which the monitoring compute resource is going to be deployed.\r\n\r\nAnd I guess this \"location\" would indicate which RP to call.","created_at":"2019-06-27T00:37:46Z","updated_at":"2019-06-27T00:39:13Z","html_url":"https://github.com/Azure/azure-hanaonazure-cli-extension/pull/25#discussion_r297917724","pull_request_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/25","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/comments/297917724"},"html":{"href":"https://github.com/Azure/azure-hanaonazure-cli-extension/pull/25#discussion_r297917724"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/25"}},"in_reply_to_id":297904657},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/25","id":292188334,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyMTg4MzM0","html_url":"https://github.com/Azure/azure-hanaonazure-cli-extension/pull/25","diff_url":"https://github.com/Azure/azure-hanaonazure-cli-extension/pull/25.diff","patch_url":"https://github.com/Azure/azure-hanaonazure-cli-extension/pull/25.patch","issue_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/issues/25","number":25,"state":"open","locked":false,"title":"Added new SAP monitor commands","user":{"login":"PakDLiu","id":32778916,"node_id":"MDQ6VXNlcjMyNzc4OTE2","avatar_url":"https://avatars2.githubusercontent.com/u/32778916?v=4","gravatar_id":"","url":"https://api.github.com/users/PakDLiu","html_url":"https://github.com/PakDLiu","followers_url":"https://api.github.com/users/PakDLiu/followers","following_url":"https://api.github.com/users/PakDLiu/following{/other_user}","gists_url":"https://api.github.com/users/PakDLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/PakDLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PakDLiu/subscriptions","organizations_url":"https://api.github.com/users/PakDLiu/orgs","repos_url":"https://api.github.com/users/PakDLiu/repos","events_url":"https://api.github.com/users/PakDLiu/events{/privacy}","received_events_url":"https://api.github.com/users/PakDLiu/received_events","type":"User","site_admin":false},"body":"Added new SAP monitor commands\r\nUpdated python SDK library with new SAP monitor commands","created_at":"2019-06-26T22:55:28Z","updated_at":"2019-06-27T00:39:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2da6a4c4e1d8fd29c572434dfc79008ac98eb421","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/25/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/25/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/issues/25/comments","statuses_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/statuses/da48f1c519fe1a3e9d6ec1b4cfe5c3aae2439b56","head":{"label":"PakDLiu:donaliu/addSapMonitor2","ref":"donaliu/addSapMonitor2","sha":"da48f1c519fe1a3e9d6ec1b4cfe5c3aae2439b56","user":{"login":"PakDLiu","id":32778916,"node_id":"MDQ6VXNlcjMyNzc4OTE2","avatar_url":"https://avatars2.githubusercontent.com/u/32778916?v=4","gravatar_id":"","url":"https://api.github.com/users/PakDLiu","html_url":"https://github.com/PakDLiu","followers_url":"https://api.github.com/users/PakDLiu/followers","following_url":"https://api.github.com/users/PakDLiu/following{/other_user}","gists_url":"https://api.github.com/users/PakDLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/PakDLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PakDLiu/subscriptions","organizations_url":"https://api.github.com/users/PakDLiu/orgs","repos_url":"https://api.github.com/users/PakDLiu/repos","events_url":"https://api.github.com/users/PakDLiu/events{/privacy}","received_events_url":"https://api.github.com/users/PakDLiu/received_events","type":"User","site_admin":false},"repo":{"id":143784705,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3ODQ3MDU=","name":"azure-hanaonazure-cli-extension","full_name":"PakDLiu/azure-hanaonazure-cli-extension","private":false,"owner":{"login":"PakDLiu","id":32778916,"node_id":"MDQ6VXNlcjMyNzc4OTE2","avatar_url":"https://avatars2.githubusercontent.com/u/32778916?v=4","gravatar_id":"","url":"https://api.github.com/users/PakDLiu","html_url":"https://github.com/PakDLiu","followers_url":"https://api.github.com/users/PakDLiu/followers","following_url":"https://api.github.com/users/PakDLiu/following{/other_user}","gists_url":"https://api.github.com/users/PakDLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/PakDLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PakDLiu/subscriptions","organizations_url":"https://api.github.com/users/PakDLiu/orgs","repos_url":"https://api.github.com/users/PakDLiu/repos","events_url":"https://api.github.com/users/PakDLiu/events{/privacy}","received_events_url":"https://api.github.com/users/PakDLiu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PakDLiu/azure-hanaonazure-cli-extension","description":"Microsoft Azure Command-Line Tools SAP HANA Command Module","fork":true,"url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension","forks_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/forks","keys_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/teams","hooks_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/hooks","issue_events_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/issues/events{/number}","events_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/events","assignees_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/assignees{/user}","branches_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/branches{/branch}","tags_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/tags","blobs_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/languages","stargazers_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/stargazers","contributors_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/contributors","subscribers_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/subscribers","subscription_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/subscription","commits_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/contents/{+path}","compare_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/merges","archive_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/downloads","issues_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/issues{/number}","pulls_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/labels{/name}","releases_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/releases{/id}","deployments_url":"https://api.github.com/repos/PakDLiu/azure-hanaonazure-cli-extension/deployments","created_at":"2018-08-06T21:22:51Z","updated_at":"2019-06-26T22:23:38Z","pushed_at":"2019-06-26T22:54:38Z","git_url":"git://github.com/PakDLiu/azure-hanaonazure-cli-extension.git","ssh_url":"git@github.com:PakDLiu/azure-hanaonazure-cli-extension.git","clone_url":"https://github.com/PakDLiu/azure-hanaonazure-cli-extension.git","svn_url":"https://github.com/PakDLiu/azure-hanaonazure-cli-extension","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"d130dd54579d88d948fc400129748a2cbdbcb157","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":120659977,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2NTk5Nzc=","name":"azure-hanaonazure-cli-extension","full_name":"Azure/azure-hanaonazure-cli-extension","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-hanaonazure-cli-extension","description":"Microsoft Azure Command-Line Tools SAP HANA Command Module","fork":false,"url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension","forks_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/forks","keys_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/teams","hooks_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/events","assignees_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/tags","blobs_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/subscription","commits_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/merges","archive_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/downloads","issues_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/deployments","created_at":"2018-02-07T19:16:48Z","updated_at":"2019-06-17T21:10:42Z","pushed_at":"2019-06-26T22:55:29Z","git_url":"git://github.com/Azure/azure-hanaonazure-cli-extension.git","ssh_url":"git@github.com:Azure/azure-hanaonazure-cli-extension.git","clone_url":"https://github.com/Azure/azure-hanaonazure-cli-extension.git","svn_url":"https://github.com/Azure/azure-hanaonazure-cli-extension","homepage":null,"size":72,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/25"},"html":{"href":"https://github.com/Azure/azure-hanaonazure-cli-extension/pull/25"},"issue":{"href":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/issues/25"},"comments":{"href":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-hanaonazure-cli-extension/statuses/da48f1c519fe1a3e9d6ec1b4cfe5c3aae2439b56"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jovillas"}}