{"push_id":3974091420,"size":5,"distinct_size":5,"ref":"refs/heads/master","head":"deb7d43d084346a21346696ad0dae6dcc80652b7","before":"64c2ca61fa6811e720bc4ab866f37be74935bfc4","commits":[{"sha":"9b340d753dcfd6ad08f47c8b7bf0ee3915ad2401","author":{"name":"spinnakerbot","email":"a4a8645f7f0005a16a040883bfb21e51a77178c1@spinnaker.io"},"message":"chore(dependencies): Autobump korkVersion (#3984)","distinct":true,"url":"https://api.github.com/repos/plumpy/clouddriver/commits/9b340d753dcfd6ad08f47c8b7bf0ee3915ad2401"},{"sha":"aac9dde4c0a3e4770c543002be50cd4efbbd3caf","author":{"name":"Eric Zimanyi","email":"5d05ebf431fd21c231b042c233237a0dc079f070@google.com"},"message":"fix(kubernetes): Use an account-specific kind registry (#3985)\n\n* fix(kubernetes): Use an account-specific kind registry\r\n\r\nThe primary goal of the changes here is to split up the global\r\nKubernetesKindRegistry (primarily accessed through the static\r\nfunctions on KubernetesKind) into a separate kind registries for\r\neach account.\r\n\r\nBefore this change, KubernetesKind was a KubernetesKind.ScopedKind\r\n(name + api group) as well as some properties (ex: namespaced,\r\nhasClusterRelationship). The first change this commit makes is\r\nto rename these classes:\r\n* KubernetesKind is now what KubernetesKind.ScopedKind was before,\r\njust a pointer to a name and api group (with no properties or\r\nother data)\r\n* KubernetesKindProperties is now what KubernetsKind was before;\r\nit has a KubernetesKind as well as additional properties\r\n\r\nThe advantage of this renaming is that the vast majority of times\r\nwe are using a KubernetesKind in the codebase, we actually don't\r\nneed the properties so these usages aren't affected at all by\r\nremoving the properties from KubernetesKind.\r\n\r\nThen, we've added a KubernetesKindRegistry onto each account object\r\nthat allows for registering mappings from kinds to their properties\r\nas well as fetching the properties for a given kind. The\r\naccount-specific registry falls back to a global registry of built-in\r\nkinds if we look up something that's not in the registry.\r\n\r\nAny of the places that were using KubernetesKind before and that did\r\nactually need the properties were then updated to look up the properties\r\nusing the registry on the appropriate account (sometimes needing to\r\nthread it down a call or two).\r\n\r\nFinally, prior to this change the old implementation of a kind registry\r\nhandled lookig up things by alias (so if you asked for \"rs\" it would\r\nactually return the properties registered for \"replicaSet\"). This logic\r\nwas moved out of the registry and into the new KubernetesKind class;\r\nnow if you try to create a KubernetesKind from the string \"rs\" it will\r\njust give you back a \"replicaSet\", which means the logic can be removed\r\nfrom the registry. (We can do this because the alias functionality is\r\nonly supported for a few built-in kinds and is not supported for crds.)\r\n\r\nThis is more change than I normally like to include in a single commit,\r\nbut given the intertwined nature of these refactors, my attempts to\r\nsplit this up actually led to a more complicated diff, so hopefully\r\nthis is readable enough with the above description.\r\n\r\n* style(kubernetes): Address code review comments\r\n\r\nReplace wildcard imports and remove unused variable","distinct":true,"url":"https://api.github.com/repos/plumpy/clouddriver/commits/aac9dde4c0a3e4770c543002be50cd4efbbd3caf"},{"sha":"5a66c4aebed41ee63a1fc67827c3af261fe8f011","author":{"name":"Clare Liguori","email":"7d1716f808386461736482d1343b9e1851152116@amazon.com"},"message":"fix(ecs): look up security groups by AWS account name (#3986)","distinct":true,"url":"https://api.github.com/repos/plumpy/clouddriver/commits/5a66c4aebed41ee63a1fc67827c3af261fe8f011"},{"sha":"1cb1c027e503ee446a4842b76bafc5446f8e3e1b","author":{"name":"Eric Zimanyi","email":"5d05ebf431fd21c231b042c233237a0dc079f070@google.com"},"message":"fix(kubernetes): Use consistent casing for kind names (#3987)\n\n* fix(kubernetes): Use consistent casing for kind names\r\n\r\nKind names are currently serialized preserving their case; prior\r\nto the recent refactor, we had a global registry of kinds that\r\neffectively enforced a single casing for every kind. Now that this\r\nregistry is gone, there are some places where we are referring to\r\na replicaset as ReplicaSet and others as replicaSet which is causing\r\nissues.\r\n\r\nIn order to resolve this without resorting to adding back a global\r\nregistry, convert kind names to lower case before serializing (and\r\nthus before generating cache keys).\r\n\r\n* test(kubernetes): Fix tests from prior commit","distinct":true,"url":"https://api.github.com/repos/plumpy/clouddriver/commits/1cb1c027e503ee446a4842b76bafc5446f8e3e1b"},{"sha":"deb7d43d084346a21346696ad0dae6dcc80652b7","author":{"name":"Rob Zienert","email":"4e7f4d65b1ba6b280a5f76829b08a1fa1eb3d728@netflix.com"},"message":"fix(circle): Bump up resources (#3988)","distinct":true,"url":"https://api.github.com/repos/plumpy/clouddriver/commits/deb7d43d084346a21346696ad0dae6dcc80652b7"}]}
{"actor":{"display_login":"plumpy"}}