{"action":"created","issue":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/11249","repository_url":"https://api.github.com/repos/appcelerator/titanium_mobile","labels_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/11249/labels{/name}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/11249/comments","events_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/11249/events","html_url":"https://github.com/appcelerator/titanium_mobile/pull/11249","id":500468876,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyOTMzMDEz","number":11249,"title":"fix(ios): fix TiBase header to order macros properly, re-use macros","user":{"login":"sgtcoolguy","id":3252,"node_id":"MDQ6VXNlcjMyNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/3252?v=4","gravatar_id":"","url":"https://api.github.com/users/sgtcoolguy","html_url":"https://github.com/sgtcoolguy","followers_url":"https://api.github.com/users/sgtcoolguy/followers","following_url":"https://api.github.com/users/sgtcoolguy/following{/other_user}","gists_url":"https://api.github.com/users/sgtcoolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/sgtcoolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgtcoolguy/subscriptions","organizations_url":"https://api.github.com/users/sgtcoolguy/orgs","repos_url":"https://api.github.com/users/sgtcoolguy/repos","events_url":"https://api.github.com/users/sgtcoolguy/events{/privacy}","received_events_url":"https://api.github.com/users/sgtcoolguy/received_events","type":"User","site_admin":false},"labels":[{"id":319882979,"node_id":"MDU6TGFiZWwzMTk4ODI5Nzk=","url":"https://api.github.com/repos/appcelerator/titanium_mobile/labels/bug%20%F0%9F%90%9C","name":"bug 🐜","color":"e11d21","default":false},{"id":319881804,"node_id":"MDU6TGFiZWwzMTk4ODE4MDQ=","url":"https://api.github.com/repos/appcelerator/titanium_mobile/labels/ios","name":"ios","color":"1d76db","default":false},{"id":319883416,"node_id":"MDU6TGFiZWwzMTk4ODM0MTY=","url":"https://api.github.com/repos/appcelerator/titanium_mobile/labels/needs%20jira%20%F0%9F%9A%A8","name":"needs jira 🚨","color":"5319e7","default":false},{"id":468667064,"node_id":"MDU6TGFiZWw0Njg2NjcwNjQ=","url":"https://api.github.com/repos/appcelerator/titanium_mobile/labels/needs%20tests%20%F0%9F%9A%A8","name":"needs tests 🚨","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/milestones/36","html_url":"https://github.com/appcelerator/titanium_mobile/milestone/36","labels_url":"https://api.github.com/repos/appcelerator/titanium_mobile/milestones/36/labels","id":4410233,"node_id":"MDk6TWlsZXN0b25lNDQxMDIzMw==","number":36,"title":"8.3.0","description":"Android Q","creator":{"login":"jquick-axway","id":26234558,"node_id":"MDQ6VXNlcjI2MjM0NTU4","avatar_url":"https://avatars3.githubusercontent.com/u/26234558?v=4","gravatar_id":"","url":"https://api.github.com/users/jquick-axway","html_url":"https://github.com/jquick-axway","followers_url":"https://api.github.com/users/jquick-axway/followers","following_url":"https://api.github.com/users/jquick-axway/following{/other_user}","gists_url":"https://api.github.com/users/jquick-axway/gists{/gist_id}","starred_url":"https://api.github.com/users/jquick-axway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquick-axway/subscriptions","organizations_url":"https://api.github.com/users/jquick-axway/orgs","repos_url":"https://api.github.com/users/jquick-axway/repos","events_url":"https://api.github.com/users/jquick-axway/events{/privacy}","received_events_url":"https://api.github.com/users/jquick-axway/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":60,"state":"open","created_at":"2019-06-15T01:36:06Z","updated_at":"2019-09-30T19:31:02Z","due_on":"2019-10-29T07:00:00Z","closed_at":null},"comments":1,"created_at":"2019-09-30T19:15:42Z","updated_at":"2019-09-30T20:28:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/11249","html_url":"https://github.com/appcelerator/titanium_mobile/pull/11249","diff_url":"https://github.com/appcelerator/titanium_mobile/pull/11249.diff","patch_url":"https://github.com/appcelerator/titanium_mobile/pull/11249.patch"},"body":"**Description:**\r\nWhile attempting to build ti.barcode-zxing against SDK 8.2.0.GA, it would fail due to multiple matches of `count` method against the `args` for capture/parse going through our TiBase.h macros. This ia a very specific bug fix for building native modules against the SDK, and seems to only come up when you have 3rd party headers that may define types with a count method.\r\n\r\nThis fixes the macros to explicitly cast to `NSArray *` (after checking for it) when calling count on the argument, which fixes the issue. I also re-ordered the macro definitions so they proceed in-order (i.e. a macro doesn't refer to another defined below it, must be above); and to have macros call other macros rather than re-implement the same code to check types/etc."},"comment":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/comments/536737526","html_url":"https://github.com/appcelerator/titanium_mobile/pull/11249#issuecomment-536737526","issue_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/11249","id":536737526,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNjczNzUyNg==","user":{"login":"sgtcoolguy","id":3252,"node_id":"MDQ6VXNlcjMyNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/3252?v=4","gravatar_id":"","url":"https://api.github.com/users/sgtcoolguy","html_url":"https://github.com/sgtcoolguy","followers_url":"https://api.github.com/users/sgtcoolguy/followers","following_url":"https://api.github.com/users/sgtcoolguy/following{/other_user}","gists_url":"https://api.github.com/users/sgtcoolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/sgtcoolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgtcoolguy/subscriptions","organizations_url":"https://api.github.com/users/sgtcoolguy/orgs","repos_url":"https://api.github.com/users/sgtcoolguy/repos","events_url":"https://api.github.com/users/sgtcoolguy/events{/privacy}","received_events_url":"https://api.github.com/users/sgtcoolguy/received_events","type":"User","site_admin":false},"created_at":"2019-09-30T20:28:41Z","updated_at":"2019-09-30T20:28:41Z","author_association":"MEMBER","body":"See https://jenkins.appcelerator.org/blue/rest/organizations/jenkins/pipelines/modules/pipelines/ti.barcode/branches/PR-112/runs/4/nodes/48/steps/82/log/?start=0 for example of how this is breaking that module's build"}}
{"actor":{"display_login":"sgtcoolguy"}}