{"action":"created","issue":{"url":"https://api.github.com/repos/IBM/zowe-cli-cics-deploy-plugin/issues/86","repository_url":"https://api.github.com/repos/IBM/zowe-cli-cics-deploy-plugin","labels_url":"https://api.github.com/repos/IBM/zowe-cli-cics-deploy-plugin/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/IBM/zowe-cli-cics-deploy-plugin/issues/86/comments","events_url":"https://api.github.com/repos/IBM/zowe-cli-cics-deploy-plugin/issues/86/events","html_url":"https://github.com/IBM/zowe-cli-cics-deploy-plugin/issues/86","id":436175536,"node_id":"MDU6SXNzdWU0MzYxNzU1MzY=","number":86,"title":"Should PUSH detect if npm_modules directory is removed from .zosattributes ?","user":{"login":"ChrisAtkinson1","id":47417716,"node_id":"MDQ6VXNlcjQ3NDE3NzE2","avatar_url":"https://avatars3.githubusercontent.com/u/47417716?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisAtkinson1","html_url":"https://github.com/ChrisAtkinson1","followers_url":"https://api.github.com/users/ChrisAtkinson1/followers","following_url":"https://api.github.com/users/ChrisAtkinson1/following{/other_user}","gists_url":"https://api.github.com/users/ChrisAtkinson1/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisAtkinson1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisAtkinson1/subscriptions","organizations_url":"https://api.github.com/users/ChrisAtkinson1/orgs","repos_url":"https://api.github.com/users/ChrisAtkinson1/repos","events_url":"https://api.github.com/users/ChrisAtkinson1/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisAtkinson1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-04-23T13:02:12Z","updated_at":"2019-04-23T13:26:02Z","closed_at":null,"author_association":"COLLABORATOR","body":"If you edit the .zosatttribute file to allow npm_modules directory to be uploaded the npm_modules are uploaded.\r\n\r\nThe PUSH then does a npm install of the .package.json file.\r\n\r\nIf the modules are all the same they are just reinstalled.  So wastes time.\r\n\r\nMaybe a warning should be given, as perhaps there maybe a use case for the user uploading something that is not in the package.json ?"},"comment":{"url":"https://api.github.com/repos/IBM/zowe-cli-cics-deploy-plugin/issues/comments/485801746","html_url":"https://github.com/IBM/zowe-cli-cics-deploy-plugin/issues/86#issuecomment-485801746","issue_url":"https://api.github.com/repos/IBM/zowe-cli-cics-deploy-plugin/issues/86","id":485801746,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NTgwMTc0Ng==","user":{"login":"pcoop","id":36080552,"node_id":"MDQ6VXNlcjM2MDgwNTUy","avatar_url":"https://avatars3.githubusercontent.com/u/36080552?v=4","gravatar_id":"","url":"https://api.github.com/users/pcoop","html_url":"https://github.com/pcoop","followers_url":"https://api.github.com/users/pcoop/followers","following_url":"https://api.github.com/users/pcoop/following{/other_user}","gists_url":"https://api.github.com/users/pcoop/gists{/gist_id}","starred_url":"https://api.github.com/users/pcoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcoop/subscriptions","organizations_url":"https://api.github.com/users/pcoop/orgs","repos_url":"https://api.github.com/users/pcoop/repos","events_url":"https://api.github.com/users/pcoop/events{/privacy}","received_events_url":"https://api.github.com/users/pcoop/received_events","type":"User","site_admin":false},"created_at":"2019-04-23T13:26:02Z","updated_at":"2019-04-23T13:26:02Z","author_association":"COLLABORATOR","body":"Seems to me that if a power user decides to tweak .zosattributes we should let them - that's what it's there for after all. We have to run the remote 'npm install' regardless, otherwise they'll have native modules for the wrong platform.\r\n\r\nAs for issuing a warning... I suppose we could do that... but as it was their decision to override the defaults then it seems unnecessary. Besides, we don't really have the concept of a warning; we either issue a message so that they know what happened afterwards (which they can infer by the horribly slow upload anyway), or we refuse to process the request."}}
{"actor":{"display_login":"pcoop"}}