{"action":"closed","number":905,"pull_request":{"url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/905","id":341073544,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxMDczNTQ0","html_url":"https://github.com/vinyldns/vinyldns/pull/905","diff_url":"https://github.com/vinyldns/vinyldns/pull/905.diff","patch_url":"https://github.com/vinyldns/vinyldns/pull/905.patch","issue_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/905","number":905,"state":"closed","locked":false,"title":"validate CNAME record data is not an IP address in DNS Change form","user":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"body":"<img width=\"1182\" alt=\"Screen Shot 2019-11-14 at 11 19 47 AM\" src=\"https://user-images.githubusercontent.com/4439228/68877203-b1424d80-06d3-11ea-92c2-bd2fcac4b9a2.png\">\r\n\r\nChanges in this pull request:\r\n- add an invalid IP check to the CNAME record data field in the DNS Change form. If the record data is an IPV4 address (with or without a trailing dot) return an error that states \"CNAME data must be a domain name, not an IP address!\" Opted for this new message as opposed to tying it into the existing FQDN validation in order to provide users with more context about why the data they provided is invalid, and help them understand that CNAMES are for FQDNS not IP addresses. \r\n\r\nIntentionally kept the scope of this PR small, but we should make additional changes to the FQDN regex in the portal and the API to not allow IP addresses to be considered valid FQDNs. It's a little tricky right now between the regex and the way we handle adding trailing dots. I believe we add or ensure there's a trailing dot before we do the FQDN regex validation in the API. So `1.1.1.1` would normally fail but by the time it gets to the validation it's `1.1.1.1.` which passes.","created_at":"2019-11-14T16:46:35Z","updated_at":"2019-11-19T16:33:10Z","closed_at":"2019-11-19T16:33:10Z","merged_at":"2019-11-19T16:33:10Z","merge_commit_sha":"99dae7563cb55f750ff73d38814238dc24c348fc","assignee":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"assignees":[{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/905/commits","review_comments_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/905/comments","review_comment_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/905/comments","statuses_url":"https://api.github.com/repos/vinyldns/vinyldns/statuses/f6a711ff4ec9f5005c120dbfad92d9464ea24a2d","head":{"label":"britneywright:cname-dns-change-validation","ref":"cname-dns-change-validation","sha":"f6a711ff4ec9f5005c120dbfad92d9464ea24a2d","user":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"repo":{"id":142593271,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI1OTMyNzE=","name":"vinyldns","full_name":"britneywright/vinyldns","private":false,"owner":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"html_url":"https://github.com/britneywright/vinyldns","description":"Vendor agnostic DNS front-end for managing DNS self-service across your systems.","fork":true,"url":"https://api.github.com/repos/britneywright/vinyldns","forks_url":"https://api.github.com/repos/britneywright/vinyldns/forks","keys_url":"https://api.github.com/repos/britneywright/vinyldns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/britneywright/vinyldns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/britneywright/vinyldns/teams","hooks_url":"https://api.github.com/repos/britneywright/vinyldns/hooks","issue_events_url":"https://api.github.com/repos/britneywright/vinyldns/issues/events{/number}","events_url":"https://api.github.com/repos/britneywright/vinyldns/events","assignees_url":"https://api.github.com/repos/britneywright/vinyldns/assignees{/user}","branches_url":"https://api.github.com/repos/britneywright/vinyldns/branches{/branch}","tags_url":"https://api.github.com/repos/britneywright/vinyldns/tags","blobs_url":"https://api.github.com/repos/britneywright/vinyldns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/britneywright/vinyldns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/britneywright/vinyldns/git/refs{/sha}","trees_url":"https://api.github.com/repos/britneywright/vinyldns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/britneywright/vinyldns/statuses/{sha}","languages_url":"https://api.github.com/repos/britneywright/vinyldns/languages","stargazers_url":"https://api.github.com/repos/britneywright/vinyldns/stargazers","contributors_url":"https://api.github.com/repos/britneywright/vinyldns/contributors","subscribers_url":"https://api.github.com/repos/britneywright/vinyldns/subscribers","subscription_url":"https://api.github.com/repos/britneywright/vinyldns/subscription","commits_url":"https://api.github.com/repos/britneywright/vinyldns/commits{/sha}","git_commits_url":"https://api.github.com/repos/britneywright/vinyldns/git/commits{/sha}","comments_url":"https://api.github.com/repos/britneywright/vinyldns/comments{/number}","issue_comment_url":"https://api.github.com/repos/britneywright/vinyldns/issues/comments{/number}","contents_url":"https://api.github.com/repos/britneywright/vinyldns/contents/{+path}","compare_url":"https://api.github.com/repos/britneywright/vinyldns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/britneywright/vinyldns/merges","archive_url":"https://api.github.com/repos/britneywright/vinyldns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/britneywright/vinyldns/downloads","issues_url":"https://api.github.com/repos/britneywright/vinyldns/issues{/number}","pulls_url":"https://api.github.com/repos/britneywright/vinyldns/pulls{/number}","milestones_url":"https://api.github.com/repos/britneywright/vinyldns/milestones{/number}","notifications_url":"https://api.github.com/repos/britneywright/vinyldns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/britneywright/vinyldns/labels{/name}","releases_url":"https://api.github.com/repos/britneywright/vinyldns/releases{/id}","deployments_url":"https://api.github.com/repos/britneywright/vinyldns/deployments","created_at":"2018-07-27T15:18:39Z","updated_at":"2019-09-30T17:34:11Z","pushed_at":"2019-11-15T04:31:40Z","git_url":"git://github.com/britneywright/vinyldns.git","ssh_url":"git@github.com:britneywright/vinyldns.git","clone_url":"https://github.com/britneywright/vinyldns.git","svn_url":"https://github.com/britneywright/vinyldns","homepage":"","size":20157,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vinyldns:master","ref":"master","sha":"e3da818101adc59e7dac951a2a3aa64ecb70e637","user":{"login":"vinyldns","id":40363296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzYzMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/40363296?v=4","gravatar_id":"","url":"https://api.github.com/users/vinyldns","html_url":"https://github.com/vinyldns","followers_url":"https://api.github.com/users/vinyldns/followers","following_url":"https://api.github.com/users/vinyldns/following{/other_user}","gists_url":"https://api.github.com/users/vinyldns/gists{/gist_id}","starred_url":"https://api.github.com/users/vinyldns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinyldns/subscriptions","organizations_url":"https://api.github.com/users/vinyldns/orgs","repos_url":"https://api.github.com/users/vinyldns/repos","events_url":"https://api.github.com/users/vinyldns/events{/privacy}","received_events_url":"https://api.github.com/users/vinyldns/received_events","type":"Organization","site_admin":false},"repo":{"id":142474323,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0NzQzMjM=","name":"vinyldns","full_name":"vinyldns/vinyldns","private":false,"owner":{"login":"vinyldns","id":40363296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzYzMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/40363296?v=4","gravatar_id":"","url":"https://api.github.com/users/vinyldns","html_url":"https://github.com/vinyldns","followers_url":"https://api.github.com/users/vinyldns/followers","following_url":"https://api.github.com/users/vinyldns/following{/other_user}","gists_url":"https://api.github.com/users/vinyldns/gists{/gist_id}","starred_url":"https://api.github.com/users/vinyldns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinyldns/subscriptions","organizations_url":"https://api.github.com/users/vinyldns/orgs","repos_url":"https://api.github.com/users/vinyldns/repos","events_url":"https://api.github.com/users/vinyldns/events{/privacy}","received_events_url":"https://api.github.com/users/vinyldns/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vinyldns/vinyldns","description":"DNS Governance for streamlining DNS operations and enabling safe and secure DNS self-service","fork":false,"url":"https://api.github.com/repos/vinyldns/vinyldns","forks_url":"https://api.github.com/repos/vinyldns/vinyldns/forks","keys_url":"https://api.github.com/repos/vinyldns/vinyldns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinyldns/vinyldns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinyldns/vinyldns/teams","hooks_url":"https://api.github.com/repos/vinyldns/vinyldns/hooks","issue_events_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/events{/number}","events_url":"https://api.github.com/repos/vinyldns/vinyldns/events","assignees_url":"https://api.github.com/repos/vinyldns/vinyldns/assignees{/user}","branches_url":"https://api.github.com/repos/vinyldns/vinyldns/branches{/branch}","tags_url":"https://api.github.com/repos/vinyldns/vinyldns/tags","blobs_url":"https://api.github.com/repos/vinyldns/vinyldns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinyldns/vinyldns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinyldns/vinyldns/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinyldns/vinyldns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinyldns/vinyldns/statuses/{sha}","languages_url":"https://api.github.com/repos/vinyldns/vinyldns/languages","stargazers_url":"https://api.github.com/repos/vinyldns/vinyldns/stargazers","contributors_url":"https://api.github.com/repos/vinyldns/vinyldns/contributors","subscribers_url":"https://api.github.com/repos/vinyldns/vinyldns/subscribers","subscription_url":"https://api.github.com/repos/vinyldns/vinyldns/subscription","commits_url":"https://api.github.com/repos/vinyldns/vinyldns/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinyldns/vinyldns/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinyldns/vinyldns/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinyldns/vinyldns/contents/{+path}","compare_url":"https://api.github.com/repos/vinyldns/vinyldns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinyldns/vinyldns/merges","archive_url":"https://api.github.com/repos/vinyldns/vinyldns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinyldns/vinyldns/downloads","issues_url":"https://api.github.com/repos/vinyldns/vinyldns/issues{/number}","pulls_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls{/number}","milestones_url":"https://api.github.com/repos/vinyldns/vinyldns/milestones{/number}","notifications_url":"https://api.github.com/repos/vinyldns/vinyldns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinyldns/vinyldns/labels{/name}","releases_url":"https://api.github.com/repos/vinyldns/vinyldns/releases{/id}","deployments_url":"https://api.github.com/repos/vinyldns/vinyldns/deployments","created_at":"2018-07-26T17:43:18Z","updated_at":"2019-11-19T10:25:08Z","pushed_at":"2019-11-19T16:33:10Z","git_url":"git://github.com/vinyldns/vinyldns.git","ssh_url":"git@github.com:vinyldns/vinyldns.git","clone_url":"https://github.com/vinyldns/vinyldns.git","svn_url":"https://github.com/vinyldns/vinyldns","homepage":"http://vinyldns.io/","size":21696,"stargazers_count":220,"watchers_count":220,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":70,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":105,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":70,"open_issues":105,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/905"},"html":{"href":"https://github.com/vinyldns/vinyldns/pull/905"},"issue":{"href":"https://api.github.com/repos/vinyldns/vinyldns/issues/905"},"comments":{"href":"https://api.github.com/repos/vinyldns/vinyldns/issues/905/comments"},"review_comments":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/905/comments"},"review_comment":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/905/commits"},"statuses":{"href":"https://api.github.com/repos/vinyldns/vinyldns/statuses/f6a711ff4ec9f5005c120dbfad92d9464ea24a2d"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":93,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"britneywright"}}