{"action":"created","issue":{"url":"https://api.github.com/repos/sdnfv/openNetVM/issues/117","repository_url":"https://api.github.com/repos/sdnfv/openNetVM","labels_url":"https://api.github.com/repos/sdnfv/openNetVM/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/sdnfv/openNetVM/issues/117/comments","events_url":"https://api.github.com/repos/sdnfv/openNetVM/issues/117/events","html_url":"https://github.com/sdnfv/openNetVM/pull/117","id":445011691,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5NTUxMjU3","number":117,"title":"[WIP] Restructure main onvm_nf structs","user":{"login":"koolzz","id":11281728,"node_id":"MDQ6VXNlcjExMjgxNzI4","avatar_url":"https://avatars0.githubusercontent.com/u/11281728?v=4","gravatar_id":"","url":"https://api.github.com/users/koolzz","html_url":"https://github.com/koolzz","followers_url":"https://api.github.com/users/koolzz/followers","following_url":"https://api.github.com/users/koolzz/following{/other_user}","gists_url":"https://api.github.com/users/koolzz/gists{/gist_id}","starred_url":"https://api.github.com/users/koolzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koolzz/subscriptions","organizations_url":"https://api.github.com/users/koolzz/orgs","repos_url":"https://api.github.com/users/koolzz/repos","events_url":"https://api.github.com/users/koolzz/events{/privacy}","received_events_url":"https://api.github.com/users/koolzz/received_events","type":"User","site_admin":false},"labels":[{"id":1220381313,"node_id":"MDU6TGFiZWwxMjIwMzgxMzEz","url":"https://api.github.com/repos/sdnfv/openNetVM/labels/enhancement%20:rocket:","name":"enhancement :rocket:","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2019-05-16T15:09:49Z","updated_at":"2019-05-24T17:37:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/sdnfv/openNetVM/pulls/117","html_url":"https://github.com/sdnfv/openNetVM/pull/117","diff_url":"https://github.com/sdnfv/openNetVM/pull/117.diff","patch_url":"https://github.com/sdnfv/openNetVM/pull/117.patch"},"body":"This PR merges together `onvm_nf_info` and `onvm_nf` structs, into a single `onvm_nf` struct with internal variable groupings for readability.\r\n\r\n<!-- Add detailed description and provide running instructions -->\r\n## Summary:\r\n - The old `onvm_nf_info` is re purposed as `onvm_nf_init_data` a struct used to initialize the NF with the manager. This struct is passed to `onvm_mgr` and is then freed when initialization is complete.\r\n - In attempt to merge these structs the usage of `onvm_nf_info` has been removed from all internal and external API calls. Excluding the startup sequence.\r\n\r\n\r\n**Usage:**\r\n\r\n<!-- Check list of the things this PR accomplishes -->\r\n| This PR includes         |          |\r\n| ------------------------ | -------- |\r\n| Resolves issues          | <!-- Provide a list of issues --> \r\n| Breaking API changes     | 👍 \r\n| Internal API changes     | 👍\r\n| Usability improvements   |  👍\r\n| Bug fixes                |\r\n| New functionality        |\r\n| New NF/onvm_mgr args     | \r\n| Changes to starting NFs  |  \r\n| Dependency updates       | \r\n| Web stats updates        | \r\n\r\n\r\n<!-- If the pr has any dependencies or merge quirks note them here -->\r\n## Merging notes:\r\n - Dependencies: None  \r\n\r\n**TODO before merging :**\r\n - [ ] PR is ready for review\r\n\r\n\r\n<!-- What you did to test the PR, what needs to be done -->\r\n## Test Plan:\r\n\r\n<!-- Notes about what you think should be reviewed, any specific hacks in this PR -->\r\n## Review: \r\n(optional) << @-mention people who should review these changes >>\r\n\r\n(optional) **Subscribers:** << @-mention people who probably care about these changes >>\r\n"},"comment":{"url":"https://api.github.com/repos/sdnfv/openNetVM/issues/comments/495724476","html_url":"https://github.com/sdnfv/openNetVM/pull/117#issuecomment-495724476","issue_url":"https://api.github.com/repos/sdnfv/openNetVM/issues/117","id":495724476,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5NTcyNDQ3Ng==","user":{"login":"koolzz","id":11281728,"node_id":"MDQ6VXNlcjExMjgxNzI4","avatar_url":"https://avatars0.githubusercontent.com/u/11281728?v=4","gravatar_id":"","url":"https://api.github.com/users/koolzz","html_url":"https://github.com/koolzz","followers_url":"https://api.github.com/users/koolzz/followers","following_url":"https://api.github.com/users/koolzz/following{/other_user}","gists_url":"https://api.github.com/users/koolzz/gists{/gist_id}","starred_url":"https://api.github.com/users/koolzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koolzz/subscriptions","organizations_url":"https://api.github.com/users/koolzz/orgs","repos_url":"https://api.github.com/users/koolzz/repos","events_url":"https://api.github.com/users/koolzz/events{/privacy}","received_events_url":"https://api.github.com/users/koolzz/received_events","type":"User","site_admin":false},"created_at":"2019-05-24T17:37:22Z","updated_at":"2019-05-24T17:37:22Z","author_association":"MEMBER","body":"@onvm oi m8"}}
{"actor":{"display_login":"koolzz"}}