{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/AirSim/pulls/comments/276495102","pull_request_review_id":228073479,"id":276495102,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NjQ5NTEwMg==","diff_hunk":"@@ -47,18 +47,18 @@ private void SetupCompileMode(CompileMode mode, ReadOnlyTargetRules Target)\n         switch (mode)\n         {\n             case CompileMode.HeaderOnlyNoRpc:\n-                Definitions.Add(\"AIRLIB_HEADER_ONLY=1\");\n-                Definitions.Add(\"AIRLIB_NO_RPC=1\");\n+                PublicDefinitions.Add(\"AIRLIB_HEADER_ONLY=1\");","path":"Unreal/Plugins/AirSim/Source/AirSim.Build.cs","position":6,"original_position":6,"commit_id":"0ddd659ebebd4a0b478269068888e8dae076ae2b","original_commit_id":"0ddd659ebebd4a0b478269068888e8dae076ae2b","user":{"login":"edowson","id":10365427,"node_id":"MDQ6VXNlcjEwMzY1NDI3","avatar_url":"https://avatars2.githubusercontent.com/u/10365427?v=4","gravatar_id":"","url":"https://api.github.com/users/edowson","html_url":"https://github.com/edowson","followers_url":"https://api.github.com/users/edowson/followers","following_url":"https://api.github.com/users/edowson/following{/other_user}","gists_url":"https://api.github.com/users/edowson/gists{/gist_id}","starred_url":"https://api.github.com/users/edowson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edowson/subscriptions","organizations_url":"https://api.github.com/users/edowson/orgs","repos_url":"https://api.github.com/users/edowson/repos","events_url":"https://api.github.com/users/edowson/events{/privacy}","received_events_url":"https://api.github.com/users/edowson/received_events","type":"User","site_admin":false},"body":"I can submit a patch surrounding that code with a pre-processor check for UE_4_19_OR_LATER to handle the breakage on UE4 versions 18 and lower.\r\n\r\nCI reported no build issue and since 4.18 is the current officially supported version, I assumed it was being tested against UE4.18.3. Unless CI is only setup to check and build on linux and not windows!","created_at":"2019-04-18T02:03:11Z","updated_at":"2019-04-18T02:03:11Z","html_url":"https://github.com/Microsoft/AirSim/pull/1888#discussion_r276495102","pull_request_url":"https://api.github.com/repos/Microsoft/AirSim/pulls/1888","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/AirSim/pulls/comments/276495102"},"html":{"href":"https://github.com/Microsoft/AirSim/pull/1888#discussion_r276495102"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/AirSim/pulls/1888"}},"in_reply_to_id":276471567},"pull_request":{"url":"https://api.github.com/repos/Microsoft/AirSim/pulls/1888","id":270522392,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNTIyMzky","html_url":"https://github.com/Microsoft/AirSim/pull/1888","diff_url":"https://github.com/Microsoft/AirSim/pull/1888.diff","patch_url":"https://github.com/Microsoft/AirSim/pull/1888.patch","issue_url":"https://api.github.com/repos/Microsoft/AirSim/issues/1888","number":1888,"state":"closed","locked":false,"title":"UE4.22: Fix deprecation warnings and compilation errors.","user":{"login":"edowson","id":10365427,"node_id":"MDQ6VXNlcjEwMzY1NDI3","avatar_url":"https://avatars2.githubusercontent.com/u/10365427?v=4","gravatar_id":"","url":"https://api.github.com/users/edowson","html_url":"https://github.com/edowson","followers_url":"https://api.github.com/users/edowson/followers","following_url":"https://api.github.com/users/edowson/following{/other_user}","gists_url":"https://api.github.com/users/edowson/gists{/gist_id}","starred_url":"https://api.github.com/users/edowson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edowson/subscriptions","organizations_url":"https://api.github.com/users/edowson/orgs","repos_url":"https://api.github.com/users/edowson/repos","events_url":"https://api.github.com/users/edowson/events{/privacy}","received_events_url":"https://api.github.com/users/edowson/received_events","type":"User","site_admin":false},"body":"Fixes the following warnings:\r\n```\r\nThe 'Definitions' property has been deprecated. Use 'PublicDefinitions' instead.\r\n```\r\nFixes the following compile errors:\r\n```\r\nerror C2039: 'IncrementFlushOnDraw': is not a member of 'FSceneViewport'\r\n```","created_at":"2019-04-15T13:41:44Z","updated_at":"2019-04-18T02:03:11Z","closed_at":"2019-04-17T00:41:31Z","merged_at":"2019-04-17T00:41:31Z","merge_commit_sha":"fff500f6111d463c6f8a0cf386d54cfccf5c0d1b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/AirSim/pulls/1888/commits","review_comments_url":"https://api.github.com/repos/Microsoft/AirSim/pulls/1888/comments","review_comment_url":"https://api.github.com/repos/Microsoft/AirSim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/AirSim/issues/1888/comments","statuses_url":"https://api.github.com/repos/Microsoft/AirSim/statuses/0ddd659ebebd4a0b478269068888e8dae076ae2b","head":{"label":"edowson:4.22","ref":"4.22","sha":"0ddd659ebebd4a0b478269068888e8dae076ae2b","user":{"login":"edowson","id":10365427,"node_id":"MDQ6VXNlcjEwMzY1NDI3","avatar_url":"https://avatars2.githubusercontent.com/u/10365427?v=4","gravatar_id":"","url":"https://api.github.com/users/edowson","html_url":"https://github.com/edowson","followers_url":"https://api.github.com/users/edowson/followers","following_url":"https://api.github.com/users/edowson/following{/other_user}","gists_url":"https://api.github.com/users/edowson/gists{/gist_id}","starred_url":"https://api.github.com/users/edowson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edowson/subscriptions","organizations_url":"https://api.github.com/users/edowson/orgs","repos_url":"https://api.github.com/users/edowson/repos","events_url":"https://api.github.com/users/edowson/events{/privacy}","received_events_url":"https://api.github.com/users/edowson/received_events","type":"User","site_admin":false},"repo":{"id":142773951,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3NzM5NTE=","name":"AirSim","full_name":"edowson/AirSim","private":false,"owner":{"login":"edowson","id":10365427,"node_id":"MDQ6VXNlcjEwMzY1NDI3","avatar_url":"https://avatars2.githubusercontent.com/u/10365427?v=4","gravatar_id":"","url":"https://api.github.com/users/edowson","html_url":"https://github.com/edowson","followers_url":"https://api.github.com/users/edowson/followers","following_url":"https://api.github.com/users/edowson/following{/other_user}","gists_url":"https://api.github.com/users/edowson/gists{/gist_id}","starred_url":"https://api.github.com/users/edowson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edowson/subscriptions","organizations_url":"https://api.github.com/users/edowson/orgs","repos_url":"https://api.github.com/users/edowson/repos","events_url":"https://api.github.com/users/edowson/events{/privacy}","received_events_url":"https://api.github.com/users/edowson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/edowson/AirSim","description":"Open source simulator based on Unreal Engine for autonomous vehicles from Microsoft AI & Research","fork":true,"url":"https://api.github.com/repos/edowson/AirSim","forks_url":"https://api.github.com/repos/edowson/AirSim/forks","keys_url":"https://api.github.com/repos/edowson/AirSim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edowson/AirSim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edowson/AirSim/teams","hooks_url":"https://api.github.com/repos/edowson/AirSim/hooks","issue_events_url":"https://api.github.com/repos/edowson/AirSim/issues/events{/number}","events_url":"https://api.github.com/repos/edowson/AirSim/events","assignees_url":"https://api.github.com/repos/edowson/AirSim/assignees{/user}","branches_url":"https://api.github.com/repos/edowson/AirSim/branches{/branch}","tags_url":"https://api.github.com/repos/edowson/AirSim/tags","blobs_url":"https://api.github.com/repos/edowson/AirSim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edowson/AirSim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edowson/AirSim/git/refs{/sha}","trees_url":"https://api.github.com/repos/edowson/AirSim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edowson/AirSim/statuses/{sha}","languages_url":"https://api.github.com/repos/edowson/AirSim/languages","stargazers_url":"https://api.github.com/repos/edowson/AirSim/stargazers","contributors_url":"https://api.github.com/repos/edowson/AirSim/contributors","subscribers_url":"https://api.github.com/repos/edowson/AirSim/subscribers","subscription_url":"https://api.github.com/repos/edowson/AirSim/subscription","commits_url":"https://api.github.com/repos/edowson/AirSim/commits{/sha}","git_commits_url":"https://api.github.com/repos/edowson/AirSim/git/commits{/sha}","comments_url":"https://api.github.com/repos/edowson/AirSim/comments{/number}","issue_comment_url":"https://api.github.com/repos/edowson/AirSim/issues/comments{/number}","contents_url":"https://api.github.com/repos/edowson/AirSim/contents/{+path}","compare_url":"https://api.github.com/repos/edowson/AirSim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edowson/AirSim/merges","archive_url":"https://api.github.com/repos/edowson/AirSim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edowson/AirSim/downloads","issues_url":"https://api.github.com/repos/edowson/AirSim/issues{/number}","pulls_url":"https://api.github.com/repos/edowson/AirSim/pulls{/number}","milestones_url":"https://api.github.com/repos/edowson/AirSim/milestones{/number}","notifications_url":"https://api.github.com/repos/edowson/AirSim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edowson/AirSim/labels{/name}","releases_url":"https://api.github.com/repos/edowson/AirSim/releases{/id}","deployments_url":"https://api.github.com/repos/edowson/AirSim/deployments","created_at":"2018-07-29T15:47:27Z","updated_at":"2019-04-17T05:00:31Z","pushed_at":"2019-04-17T05:02:48Z","git_url":"git://github.com/edowson/AirSim.git","ssh_url":"git@github.com:edowson/AirSim.git","clone_url":"https://github.com/edowson/AirSim.git","svn_url":"https://github.com/edowson/AirSim","homepage":"","size":277883,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"c494e2c15ec6f363a60a7ca6b6640f3394f528e2","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":81887991,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg4Nzk5MQ==","name":"AirSim","full_name":"Microsoft/AirSim","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/AirSim","description":"Open source simulator for autonomous vehicles built on Unreal Engine / Unity, from Microsoft AI & Research","fork":false,"url":"https://api.github.com/repos/Microsoft/AirSim","forks_url":"https://api.github.com/repos/Microsoft/AirSim/forks","keys_url":"https://api.github.com/repos/Microsoft/AirSim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/AirSim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/AirSim/teams","hooks_url":"https://api.github.com/repos/Microsoft/AirSim/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/AirSim/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/AirSim/events","assignees_url":"https://api.github.com/repos/Microsoft/AirSim/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/AirSim/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/AirSim/tags","blobs_url":"https://api.github.com/repos/Microsoft/AirSim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/AirSim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/AirSim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/AirSim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/AirSim/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/AirSim/languages","stargazers_url":"https://api.github.com/repos/Microsoft/AirSim/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/AirSim/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/AirSim/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/AirSim/subscription","commits_url":"https://api.github.com/repos/Microsoft/AirSim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/AirSim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/AirSim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/AirSim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/AirSim/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/AirSim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/AirSim/merges","archive_url":"https://api.github.com/repos/Microsoft/AirSim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/AirSim/downloads","issues_url":"https://api.github.com/repos/Microsoft/AirSim/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/AirSim/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/AirSim/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/AirSim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/AirSim/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/AirSim/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/AirSim/deployments","created_at":"2017-02-14T00:52:29Z","updated_at":"2019-04-18T01:52:37Z","pushed_at":"2019-04-17T00:41:31Z","git_url":"git://github.com/Microsoft/AirSim.git","ssh_url":"git@github.com:Microsoft/AirSim.git","clone_url":"https://github.com/Microsoft/AirSim.git","svn_url":"https://github.com/Microsoft/AirSim","homepage":"","size":278390,"stargazers_count":7378,"watchers_count":7378,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1977,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":408,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1977,"open_issues":408,"watchers":7378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/AirSim/pulls/1888"},"html":{"href":"https://github.com/Microsoft/AirSim/pull/1888"},"issue":{"href":"https://api.github.com/repos/Microsoft/AirSim/issues/1888"},"comments":{"href":"https://api.github.com/repos/Microsoft/AirSim/issues/1888/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/AirSim/pulls/1888/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/AirSim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/AirSim/pulls/1888/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/AirSim/statuses/0ddd659ebebd4a0b478269068888e8dae076ae2b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"edowson"}}