{"action":"created","issue":{"url":"https://api.github.com/repos/sephiroth74/RangeSeekBar/issues/2","repository_url":"https://api.github.com/repos/sephiroth74/RangeSeekBar","labels_url":"https://api.github.com/repos/sephiroth74/RangeSeekBar/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/sephiroth74/RangeSeekBar/issues/2/comments","events_url":"https://api.github.com/repos/sephiroth74/RangeSeekBar/issues/2/events","html_url":"https://github.com/sephiroth74/RangeSeekBar/issues/2","id":423179837,"node_id":"MDU6SXNzdWU0MjMxNzk4Mzc=","number":2,"title":"Change minsdk to 21","user":{"login":"codefury","id":47972015,"node_id":"MDQ6VXNlcjQ3OTcyMDE1","avatar_url":"https://avatars3.githubusercontent.com/u/47972015?v=4","gravatar_id":"","url":"https://api.github.com/users/codefury","html_url":"https://github.com/codefury","followers_url":"https://api.github.com/users/codefury/followers","following_url":"https://api.github.com/users/codefury/following{/other_user}","gists_url":"https://api.github.com/users/codefury/gists{/gist_id}","starred_url":"https://api.github.com/users/codefury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefury/subscriptions","organizations_url":"https://api.github.com/users/codefury/orgs","repos_url":"https://api.github.com/users/codefury/repos","events_url":"https://api.github.com/users/codefury/events{/privacy}","received_events_url":"https://api.github.com/users/codefury/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-03-20T10:38:53Z","updated_at":"2019-11-11T16:10:00Z","closed_at":null,"author_association":"NONE","body":"Manifest merger fails because this library is using minSdk as 23\r\nCan you change it to uses-sdk:minSdkVersion 21"},"comment":{"url":"https://api.github.com/repos/sephiroth74/RangeSeekBar/issues/comments/552507187","html_url":"https://github.com/sephiroth74/RangeSeekBar/issues/2#issuecomment-552507187","issue_url":"https://api.github.com/repos/sephiroth74/RangeSeekBar/issues/2","id":552507187,"node_id":"MDEyOklzc3VlQ29tbWVudDU1MjUwNzE4Nw==","user":{"login":"bTodary","id":18718819,"node_id":"MDQ6VXNlcjE4NzE4ODE5","avatar_url":"https://avatars2.githubusercontent.com/u/18718819?v=4","gravatar_id":"","url":"https://api.github.com/users/bTodary","html_url":"https://github.com/bTodary","followers_url":"https://api.github.com/users/bTodary/followers","following_url":"https://api.github.com/users/bTodary/following{/other_user}","gists_url":"https://api.github.com/users/bTodary/gists{/gist_id}","starred_url":"https://api.github.com/users/bTodary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bTodary/subscriptions","organizations_url":"https://api.github.com/users/bTodary/orgs","repos_url":"https://api.github.com/users/bTodary/repos","events_url":"https://api.github.com/users/bTodary/events{/privacy}","received_events_url":"https://api.github.com/users/bTodary/received_events","type":"User","site_admin":false},"created_at":"2019-11-11T16:10:00Z","updated_at":"2019-11-11T16:10:00Z","author_association":"NONE","body":"> The minSdk 23 seems to only be required by the `DrawableWrapper` class usage in `DrawableUtils.canSafelyMutateDrawable` static function.\r\n> \r\n> But something is bothering me in its usage:\r\n> \r\n> ```\r\n>         } else if (drawable instanceof DrawableWrapper) {\r\n>             return canSafelyMutateDrawable(\r\n>                 Objects.requireNonNull(((DrawableWrapper) drawable).getDrawable()));\r\n>         } else if (drawable instanceof ScaleDrawable) {\r\n>             return canSafelyMutateDrawable(Objects.requireNonNull(((ScaleDrawable) drawable).getDrawable()));\r\n>         }\r\n> ```\r\n> \r\n> According to Android documentation the [`DrawableWrapper`](https://developer.android.com/reference/android/graphics/drawable/DrawableWrapper) is a superclass of [`ScaleDrawable`](https://developer.android.com/reference/android/graphics/drawable/ScaleDrawable.html).\r\n> \r\n> So the `else if (drawable instanceof ScaleDrawable)` will never be reached.\r\n> \r\n> The most interesting part of this is that this `DrawableUtils.canSafelyMutateDrawable` is never used.\r\n\r\nDepending on this answer, if the only need for the minsdk 23 is in DrawableUtils.canSafelyMutateDrawable which is never used then you can add the following in your manifest.\r\n`<uses-sdk tools:overrideLibrary=\"it.sephiroth.android.library.rangeseekbar\"/>`\r\nand include `xmlns:tools=\"http://schemas.android.com/tools\"` before the tag as following\r\n```\r\n<manifest ...\r\nxmlns:tools=\"http://schemas.android.com/tools\"\r\n...>\r\n```"}}
{"actor":{"display_login":"bTodary"}}