{"action":"closed","number":36,"pull_request":{"url":"https://api.github.com/repos/GMOD/bam-js/pulls/36","id":309824807,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5ODI0ODA3","html_url":"https://github.com/GMOD/bam-js/pull/36","diff_url":"https://github.com/GMOD/bam-js/pull/36.diff","patch_url":"https://github.com/GMOD/bam-js/pull/36.patch","issue_url":"https://api.github.com/repos/GMOD/bam-js/issues/36","number":36,"state":"closed","locked":false,"title":"Add failing test case and fix for incorrect chunk merges","user":{"login":"cmdcolin","id":6511937,"node_id":"MDQ6VXNlcjY1MTE5Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6511937?v=4","gravatar_id":"","url":"https://api.github.com/users/cmdcolin","html_url":"https://github.com/cmdcolin","followers_url":"https://api.github.com/users/cmdcolin/followers","following_url":"https://api.github.com/users/cmdcolin/following{/other_user}","gists_url":"https://api.github.com/users/cmdcolin/gists{/gist_id}","starred_url":"https://api.github.com/users/cmdcolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmdcolin/subscriptions","organizations_url":"https://api.github.com/users/cmdcolin/orgs","repos_url":"https://api.github.com/users/cmdcolin/repos","events_url":"https://api.github.com/users/cmdcolin/events{/privacy}","received_events_url":"https://api.github.com/users/cmdcolin/received_events","type":"User","site_admin":false},"body":"It can be seen in 1.0.20 and 1.0.21 that there are breaks in long nanopore features\r\n\r\n![localhost_jbrowse__data=hg19 loc=chr22%3A16564260 16565959 tracks=nanopore highlight= (1)](https://user-images.githubusercontent.com/6511937/63496137-56f86e80-c48f-11e9-804d-e08c470da841.png)\r\n\r\nThe \"completely resolved chunk\" merging caused this. The test case here demonstrates it albeit with a sort of large test file of ~14mb\r\n\r\n\r\n\r\nPotentially we need to review yet the other chunk merging case\r\n\r\n","created_at":"2019-08-22T07:48:41Z","updated_at":"2019-08-23T03:12:17Z","closed_at":"2019-08-23T03:12:17Z","merged_at":"2019-08-23T03:12:17Z","merge_commit_sha":"248bb54d181885eb3b26dcdedf51940c7f677fe7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GMOD/bam-js/pulls/36/commits","review_comments_url":"https://api.github.com/repos/GMOD/bam-js/pulls/36/comments","review_comment_url":"https://api.github.com/repos/GMOD/bam-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GMOD/bam-js/issues/36/comments","statuses_url":"https://api.github.com/repos/GMOD/bam-js/statuses/b84c90dfe8ff4776a8a3f3bc34e2373bc6de7185","head":{"label":"GMOD:fix_incorrect_chunk_merge","ref":"fix_incorrect_chunk_merge","sha":"b84c90dfe8ff4776a8a3f3bc34e2373bc6de7185","user":{"login":"GMOD","id":342482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjQ4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/342482?v=4","gravatar_id":"","url":"https://api.github.com/users/GMOD","html_url":"https://github.com/GMOD","followers_url":"https://api.github.com/users/GMOD/followers","following_url":"https://api.github.com/users/GMOD/following{/other_user}","gists_url":"https://api.github.com/users/GMOD/gists{/gist_id}","starred_url":"https://api.github.com/users/GMOD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMOD/subscriptions","organizations_url":"https://api.github.com/users/GMOD/orgs","repos_url":"https://api.github.com/users/GMOD/repos","events_url":"https://api.github.com/users/GMOD/events{/privacy}","received_events_url":"https://api.github.com/users/GMOD/received_events","type":"Organization","site_admin":false},"repo":{"id":147417557,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc0MTc1NTc=","name":"bam-js","full_name":"GMOD/bam-js","private":false,"owner":{"login":"GMOD","id":342482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjQ4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/342482?v=4","gravatar_id":"","url":"https://api.github.com/users/GMOD","html_url":"https://github.com/GMOD","followers_url":"https://api.github.com/users/GMOD/followers","following_url":"https://api.github.com/users/GMOD/following{/other_user}","gists_url":"https://api.github.com/users/GMOD/gists{/gist_id}","starred_url":"https://api.github.com/users/GMOD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMOD/subscriptions","organizations_url":"https://api.github.com/users/GMOD/orgs","repos_url":"https://api.github.com/users/GMOD/repos","events_url":"https://api.github.com/users/GMOD/events{/privacy}","received_events_url":"https://api.github.com/users/GMOD/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GMOD/bam-js","description":"Parse BAM and BAM index files in javascript for node and the browser","fork":false,"url":"https://api.github.com/repos/GMOD/bam-js","forks_url":"https://api.github.com/repos/GMOD/bam-js/forks","keys_url":"https://api.github.com/repos/GMOD/bam-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GMOD/bam-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GMOD/bam-js/teams","hooks_url":"https://api.github.com/repos/GMOD/bam-js/hooks","issue_events_url":"https://api.github.com/repos/GMOD/bam-js/issues/events{/number}","events_url":"https://api.github.com/repos/GMOD/bam-js/events","assignees_url":"https://api.github.com/repos/GMOD/bam-js/assignees{/user}","branches_url":"https://api.github.com/repos/GMOD/bam-js/branches{/branch}","tags_url":"https://api.github.com/repos/GMOD/bam-js/tags","blobs_url":"https://api.github.com/repos/GMOD/bam-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GMOD/bam-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GMOD/bam-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/GMOD/bam-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GMOD/bam-js/statuses/{sha}","languages_url":"https://api.github.com/repos/GMOD/bam-js/languages","stargazers_url":"https://api.github.com/repos/GMOD/bam-js/stargazers","contributors_url":"https://api.github.com/repos/GMOD/bam-js/contributors","subscribers_url":"https://api.github.com/repos/GMOD/bam-js/subscribers","subscription_url":"https://api.github.com/repos/GMOD/bam-js/subscription","commits_url":"https://api.github.com/repos/GMOD/bam-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/GMOD/bam-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/GMOD/bam-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/GMOD/bam-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/GMOD/bam-js/contents/{+path}","compare_url":"https://api.github.com/repos/GMOD/bam-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GMOD/bam-js/merges","archive_url":"https://api.github.com/repos/GMOD/bam-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GMOD/bam-js/downloads","issues_url":"https://api.github.com/repos/GMOD/bam-js/issues{/number}","pulls_url":"https://api.github.com/repos/GMOD/bam-js/pulls{/number}","milestones_url":"https://api.github.com/repos/GMOD/bam-js/milestones{/number}","notifications_url":"https://api.github.com/repos/GMOD/bam-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GMOD/bam-js/labels{/name}","releases_url":"https://api.github.com/repos/GMOD/bam-js/releases{/id}","deployments_url":"https://api.github.com/repos/GMOD/bam-js/deployments","created_at":"2018-09-04T20:56:32Z","updated_at":"2019-08-06T18:37:23Z","pushed_at":"2019-08-23T03:12:17Z","git_url":"git://github.com/GMOD/bam-js.git","ssh_url":"git@github.com:GMOD/bam-js.git","clone_url":"https://github.com/GMOD/bam-js.git","svn_url":"https://github.com/GMOD/bam-js","homepage":null,"size":17094,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"GMOD:master","ref":"master","sha":"db4ef17df65620451d1b271f3ddc9d732c8d9031","user":{"login":"GMOD","id":342482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjQ4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/342482?v=4","gravatar_id":"","url":"https://api.github.com/users/GMOD","html_url":"https://github.com/GMOD","followers_url":"https://api.github.com/users/GMOD/followers","following_url":"https://api.github.com/users/GMOD/following{/other_user}","gists_url":"https://api.github.com/users/GMOD/gists{/gist_id}","starred_url":"https://api.github.com/users/GMOD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMOD/subscriptions","organizations_url":"https://api.github.com/users/GMOD/orgs","repos_url":"https://api.github.com/users/GMOD/repos","events_url":"https://api.github.com/users/GMOD/events{/privacy}","received_events_url":"https://api.github.com/users/GMOD/received_events","type":"Organization","site_admin":false},"repo":{"id":147417557,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc0MTc1NTc=","name":"bam-js","full_name":"GMOD/bam-js","private":false,"owner":{"login":"GMOD","id":342482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjQ4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/342482?v=4","gravatar_id":"","url":"https://api.github.com/users/GMOD","html_url":"https://github.com/GMOD","followers_url":"https://api.github.com/users/GMOD/followers","following_url":"https://api.github.com/users/GMOD/following{/other_user}","gists_url":"https://api.github.com/users/GMOD/gists{/gist_id}","starred_url":"https://api.github.com/users/GMOD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMOD/subscriptions","organizations_url":"https://api.github.com/users/GMOD/orgs","repos_url":"https://api.github.com/users/GMOD/repos","events_url":"https://api.github.com/users/GMOD/events{/privacy}","received_events_url":"https://api.github.com/users/GMOD/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GMOD/bam-js","description":"Parse BAM and BAM index files in javascript for node and the browser","fork":false,"url":"https://api.github.com/repos/GMOD/bam-js","forks_url":"https://api.github.com/repos/GMOD/bam-js/forks","keys_url":"https://api.github.com/repos/GMOD/bam-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GMOD/bam-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GMOD/bam-js/teams","hooks_url":"https://api.github.com/repos/GMOD/bam-js/hooks","issue_events_url":"https://api.github.com/repos/GMOD/bam-js/issues/events{/number}","events_url":"https://api.github.com/repos/GMOD/bam-js/events","assignees_url":"https://api.github.com/repos/GMOD/bam-js/assignees{/user}","branches_url":"https://api.github.com/repos/GMOD/bam-js/branches{/branch}","tags_url":"https://api.github.com/repos/GMOD/bam-js/tags","blobs_url":"https://api.github.com/repos/GMOD/bam-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GMOD/bam-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GMOD/bam-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/GMOD/bam-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GMOD/bam-js/statuses/{sha}","languages_url":"https://api.github.com/repos/GMOD/bam-js/languages","stargazers_url":"https://api.github.com/repos/GMOD/bam-js/stargazers","contributors_url":"https://api.github.com/repos/GMOD/bam-js/contributors","subscribers_url":"https://api.github.com/repos/GMOD/bam-js/subscribers","subscription_url":"https://api.github.com/repos/GMOD/bam-js/subscription","commits_url":"https://api.github.com/repos/GMOD/bam-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/GMOD/bam-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/GMOD/bam-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/GMOD/bam-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/GMOD/bam-js/contents/{+path}","compare_url":"https://api.github.com/repos/GMOD/bam-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GMOD/bam-js/merges","archive_url":"https://api.github.com/repos/GMOD/bam-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GMOD/bam-js/downloads","issues_url":"https://api.github.com/repos/GMOD/bam-js/issues{/number}","pulls_url":"https://api.github.com/repos/GMOD/bam-js/pulls{/number}","milestones_url":"https://api.github.com/repos/GMOD/bam-js/milestones{/number}","notifications_url":"https://api.github.com/repos/GMOD/bam-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GMOD/bam-js/labels{/name}","releases_url":"https://api.github.com/repos/GMOD/bam-js/releases{/id}","deployments_url":"https://api.github.com/repos/GMOD/bam-js/deployments","created_at":"2018-09-04T20:56:32Z","updated_at":"2019-08-06T18:37:23Z","pushed_at":"2019-08-23T03:12:17Z","git_url":"git://github.com/GMOD/bam-js.git","ssh_url":"git@github.com:GMOD/bam-js.git","clone_url":"https://github.com/GMOD/bam-js.git","svn_url":"https://github.com/GMOD/bam-js","homepage":null,"size":17094,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GMOD/bam-js/pulls/36"},"html":{"href":"https://github.com/GMOD/bam-js/pull/36"},"issue":{"href":"https://api.github.com/repos/GMOD/bam-js/issues/36"},"comments":{"href":"https://api.github.com/repos/GMOD/bam-js/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/GMOD/bam-js/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/GMOD/bam-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GMOD/bam-js/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/GMOD/bam-js/statuses/b84c90dfe8ff4776a8a3f3bc34e2373bc6de7185"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cmdcolin","id":6511937,"node_id":"MDQ6VXNlcjY1MTE5Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6511937?v=4","gravatar_id":"","url":"https://api.github.com/users/cmdcolin","html_url":"https://github.com/cmdcolin","followers_url":"https://api.github.com/users/cmdcolin/followers","following_url":"https://api.github.com/users/cmdcolin/following{/other_user}","gists_url":"https://api.github.com/users/cmdcolin/gists{/gist_id}","starred_url":"https://api.github.com/users/cmdcolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmdcolin/subscriptions","organizations_url":"https://api.github.com/users/cmdcolin/orgs","repos_url":"https://api.github.com/users/cmdcolin/repos","events_url":"https://api.github.com/users/cmdcolin/events{/privacy}","received_events_url":"https://api.github.com/users/cmdcolin/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":12,"changed_files":4}}
{"actor":{"display_login":"cmdcolin"}}